repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
MoiraeSoftware/Myriad | 256 | issue_to_patch | [agentics] No-Op Runs
This issue tracks all no-op runs from agentic workflows in this repository. Each workflow run that completes with a no-op message (indicating no action was needed) posts a comment here.
<details>
<summary><b>π What is a No-Op?</b></summary>
A no-op (no operation) occurs when an agentic workflo... | No-op: agentic workflow tracking issue requires no action | The referenced issue is an automatically managed agentic workflow tracking issue that explicitly instructs no action be taken. No repository changes are required or appropriate.
<!-- START COPILOT ORIGINAL PROMPT -->
<details>
<summary>Original prompt</summary>
>
> ----
>
> *This section details on the original... | 2cb8ccce5455b79efff83a2690879abeaaac93c9 | 4b00ed464b650de3d06d07142951ea170ffa4dc0 | [] | [] | true | ||
MoiraeSoftware/Myriad | 278 | issue_to_patch | [Repo Assist] test: add integration tests for DUCasesGenerator output | π€ *This PR was created by Repo Assist, an automated AI assistant.*
## Summary
Adds 19 integration tests covering the output of `DUCasesGenerator` β a generator that previously had **zero direct tests** in the suite.
## Root Cause
The `DUCasesGenerator` is one of three core generators (alongside `FieldsGenerator` a... | 710bd943d6c7523067e64cea4521fc9ca5227cd9 | c33388704cf8ca758611a72b4efe456df6c8dd73 | [
"test/Myriad.IntegrationPluginTests/Tests.fs"
] | [] | diff --git a/test/Myriad.IntegrationPluginTests/Tests.fs b/test/Myriad.IntegrationPluginTests/Tests.fs
index d052327a..141cc756 100644
--- a/test/Myriad.IntegrationPluginTests/Tests.fs
+++ b/test/Myriad.IntegrationPluginTests/Tests.fs
@@ -363,5 +363,73 @@ let tests =
]
]
+ testList "DU Ca... | true | ||
MoiraeSoftware/Myriad | 254 | issue_to_patch | Duplicate Code: Qualified Case Identifier Resolution in DUCasesGenerator and LensesGenerator
*Analysis of commit 165a7e5b424a16b5d507797e9ed43e4c3da12f5b*
**Assignee**: `@copilot`
## Summary
The logic for building a qualified `SynLongIdent` from a DU case identifier (respecting `requiresQualifiedAccess`) is duplica... | Refactor: consolidate resolveCaseIdent into GeneratorHelpers | `resolveCaseIdent` β which builds a qualified `SynLongIdent` for a DU case respecting `RequireQualifiedAccess` β was duplicated between `DUCasesGenerator.fs` (as a named function) and `LensesGenerator.fs` (inlined). Any divergence between the two would silently produce inconsistent codegen for qualified DUs.
## Change... | 68a89caef0fece4c3506bae39dda1d3bbf9bc853 | 7c737f003b1d195e12953907574999267f8e8dd6 | [] | [] | true | ||
MoiraeSoftware/Myriad | 284 | issue_to_patch | [Repo Assist] Refactor: extract getFieldName helper to eliminate 3-fold field name extraction β closes #283 | π€ *This PR was created by Repo Assist, an automated AI assistant.*
## Summary
Adds `GeneratorHelpers.getFieldName` to eliminate the repeated inline field-name extraction pattern that appears 3 times across `FieldsGenerator.fs` and `LensesGenerator.fs`, as identified in issue #283.
## Root Cause
The pattern:
```fsh... | 68a89caef0fece4c3506bae39dda1d3bbf9bc853 | 7237c1a2c438f9d3c9991fbe078f8428d2294fa5 | diff --git a/src/Myriad.Plugins/FieldsGenerator.fs b/src/Myriad.Plugins/FieldsGenerator.fs
index 1dac3573..be9a8889 100644
--- a/src/Myriad.Plugins/FieldsGenerator.fs
+++ b/src/Myriad.Plugins/FieldsGenerator.fs
@@ -9,7 +9,7 @@ module internal Create =
let createFieldMap (parent: LongIdent) (field: SynField) =
... | [
"src/Myriad.Plugins/FieldsGenerator.fs",
"src/Myriad.Plugins/GeneratorHelpers.fs",
"src/Myriad.Plugins/LensesGenerator.fs"
] | [] | true | ||
MoiraeSoftware/Myriad | 289 | issue_to_patch | Duplicate Code: `createDuInputPattern` reimplements `GeneratorHelpers.createTypedNamedParen`
*Analysis of recent commits on master*
**Assignee**: `@copilot`
## Summary
`CreateDUModule.createDuInputPattern` in `src/Myriad.Plugins/DUCasesGenerator.fs` manually constructs a typed, named, parenthesised `SynPat` using t... | [Repo Assist] Refactor: use createTypedNamedParen in createDuInputPattern β closes #288 | π€ *This PR was created by Repo Assist, an automated AI assistant.*
## Summary
Replaces the manual `SynPat.CreateNamed β SynPat.CreateTyped β SynPat.CreateParen` chain in `CreateDUModule.createDuInputPattern` with the existing `GeneratorHelpers.createTypedNamedParen` helper, fulfilling the stated intent of that helpe... | 710bd943d6c7523067e64cea4521fc9ca5227cd9 | 203426d26ac0d42db332429e772050c6da0f84a1 | diff --git a/src/Myriad.Plugins/DUCasesGenerator.fs b/src/Myriad.Plugins/DUCasesGenerator.fs
index 6dafe925..b23e0129 100644
--- a/src/Myriad.Plugins/DUCasesGenerator.fs
+++ b/src/Myriad.Plugins/DUCasesGenerator.fs
@@ -9,10 +9,7 @@ module internal CreateDUModule =
open Fantomas.FCS.Text.Range
let createDuIn... | [
"src/Myriad.Plugins/DUCasesGenerator.fs"
] | [] | true | |
MoiraeSoftware/Myriad | 293 | issue_to_patch | Duplicate Code: `createDuInputPattern` reimplements `GeneratorHelpers.createTypedNamedParen`
*Analysis of recent commits on master*
**Assignee**: `@copilot`
## Summary
`CreateDUModule.createDuInputPattern` in `src/Myriad.Plugins/DUCasesGenerator.fs` manually constructs a typed, named, parenthesised `SynPat` using t... | Use `GeneratorHelpers.createTypedNamedParen` in `createDuInputPattern` | `createDuInputPattern` manually reimplemented the `SynPat.CreateNamed β SynPat.CreateTyped β SynPat.CreateParen` chain that `GeneratorHelpers.createTypedNamedParen` was introduced to centralise.
## Change
Replace the inline idiom with the existing helper:
```fsharp
// Before
let createDuInputPattern (varIdent: SynLo... | 1839f0562dd9045cbb4d0270ac2643abb60bce90 | d796a7b10be23f4b171cfebd864916d4eccf594c | diff --git a/src/Myriad.Plugins/DUCasesGenerator.fs b/src/Myriad.Plugins/DUCasesGenerator.fs
index 86796d20..36f8f4bf 100644
--- a/src/Myriad.Plugins/DUCasesGenerator.fs
+++ b/src/Myriad.Plugins/DUCasesGenerator.fs
@@ -9,10 +9,7 @@ module internal CreateDUModule =
open Fantomas.FCS.Text.Range
let createDuIn... | [
"src/Myriad.Plugins/DUCasesGenerator.fs"
] | [] | true | |
MoiraeSoftware/Myriad | 292 | issue_to_patch | Fix release blockers and prepare v0.8.6 | ## Summary
- **CI**: `build.yml` bumped to `actions/checkout@v4` + `actions/setup-dotnet@v4`, added explicit `dotnet paket restore`
- **Myriad.Sdk.props**: `PackageDownload` made conditional (skipped when consumer overrides `MyriadSdk_Generator_Exe`); fixed evaluation-order bug where the condition was always false; pa... | 1839f0562dd9045cbb4d0270ac2643abb60bce90 | cfaff7f67dc0ab07662f439b5a1225eb137d2366 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index ca282313..b9956770 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -13,12 +13,14 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- name:... | [
".github/workflows/build.yml",
".github/workflows/docs.yml",
".github/workflows/publish.yml",
"CHANGELOG.md",
"Directory.Build.props",
"README.md",
"docs/.gitmodules",
"docs/content/docs/External Resources/index.md",
"docs/content/docs/Tutorials/configuration.md",
"docs/content/docs/Tutorials/exte... | [] | true | ||
MoiraeSoftware/Myriad | 268 | issue_to_patch | Duplicate Code: SynUnionCase destructuring pattern repeated 5 times across generator files
*Analysis of recent commits*
**Assignee**: `@copilot`
## Summary
The inline destructuring pattern `SynUnionCase.SynUnionCase(_,SynIdent(id, _),_,_,_,_,_)` to extract a union case's `Ident` is repeated 5 times across `DUCasesG... | [Repo Assist] Refactor: extract getCaseIdent helper to eliminate 5-fold SynUnionCase destructure | π€ *This PR was created by Repo Assist, an automated AI assistant.*
## Summary
Closes #267
Adds `GeneratorHelpers.getCaseIdent` β a dedicated helper that extracts the `Ident` from a `SynUnionCase` β and replaces all 5 inline destructuring sites across `DUCasesGenerator.fs` and `LensesGenerator.fs`.
## Root Cause
T... | 710bd943d6c7523067e64cea4521fc9ca5227cd9 | 16ddb8663af1cd23f5e0f79728470d01c39201bb | diff --git a/src/Myriad.Plugins/DUCasesGenerator.fs b/src/Myriad.Plugins/DUCasesGenerator.fs
index 6dafe925..86796d20 100644
--- a/src/Myriad.Plugins/DUCasesGenerator.fs
+++ b/src/Myriad.Plugins/DUCasesGenerator.fs
@@ -38,7 +38,8 @@ module internal CreateDUModule =
let duType = SynType.CreateFromLongIdent pare... | [
"src/Myriad.Plugins/DUCasesGenerator.fs",
"src/Myriad.Plugins/GeneratorHelpers.fs",
"src/Myriad.Plugins/LensesGenerator.fs"
] | [] | true | |
MoiraeSoftware/Myriad | 258 | issue_to_patch | Duplicate Code: Structural Duplication in `Generate` Methods of DUCasesGenerator and FieldsGenerator
*Analysis of recent commits in MoiraeSoftware/Myriad*
**Assignee**: `@copilot`
## Summary
The `Generate` method implementations in `DUCasesGenerator` and `FieldsGenerator` are structurally identical β both parse the... | Refactor: Extract shared `generateModules` helper to eliminate Generate method duplication | `DUCasesGenerator.Generate` and `FieldsGenerator.Generate` were structurally identical β differing only in the `Ast.extract*` function, attribute type, and module builder. Any future change to the pipeline scaffolding required parallel edits.
## Changes
- **`GeneratorHelpers.fs`** β Added `generateModules<'Attr>` tha... | 2cb8ccce5455b79efff83a2690879abeaaac93c9 | 8df232ff808ccdd3dc9e8dec38cb72a009444080 | [] | [] | true | ||
MoiraeSoftware/Myriad | 261 | issue_to_patch | Resolve merge conflicts with master; rename `indent` β `ident` in `createCaseMatchClause` | The PR branch had diverged from `master`, which had already merged `resolveCaseIdent` into `GeneratorHelpers` (via a parallel fix) and added a `generateModules` helper β causing a conflict in `GeneratorHelpers.fs`.
## Changes
- **`GeneratorHelpers.fs`** β resolved conflict by removing the duplicate `resolveCaseIdent`... | 8fd671df998312c4c1d1162777beb3fad3fbb0fe | 217fcd472e6e878edd6393594680a5864313554c | diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index a2f59476..0bf937bf 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -3,11 +3,11 @@ name: Publish
on:
push:
tags:
- - 'v*' # Publish on any new tag matching v*, i.e. v1.0, v1.7.2
+ - 'v*.*... | [
".github/workflows/publish.yml",
"CHANGELOG.md",
"Contributing.md",
"paket.lock",
"src/Myriad.Core/Ast.fs",
"src/Myriad.Plugins/DUCasesGenerator.fs",
"src/Myriad.Plugins/FieldsGenerator.fs",
"src/Myriad.Plugins/GeneratorHelpers.fs"
] | [
{
"comment": "The docstring says this always resolves a \"fully-qualified\" `SynLongIdent`, but when `requiresQualifiedAccess` is false it returns only the case name. Consider rewording the comment to reflect the conditional qualification to avoid misleading future readers.\n",
"path": "src/Myriad.Plugins/G... | true | ||
MoiraeSoftware/Myriad | 257 | issue_to_patch | Duplicate Code: Namespace-filtered Type Extraction Pattern in FieldsGenerator and DUCasesGenerator
*Analysis of commit d8842b91cc8ccea7e5a530c863165378e6e9032a*
**Assignee**: `@copilot`
## Summary
`FieldsGenerator.fs` and `DUCasesGenerator.fs` share a structurally identical ~12-line pattern for extracting, filterin... | Refactor: extract `generateModules` helper to eliminate duplicate Generate pipeline in DUCasesGenerator and FieldsGenerator | `DUCasesGenerator` and `FieldsGenerator` shared a structurally identical ~12-line pattern for parsing the AST, filtering types by attribute, and collecting generated modules β differing only in the extractor function and attribute type.
## Changes
- **`GeneratorHelpers.fs`** β two new internal helpers:
- `filterByA... | 2cb8ccce5455b79efff83a2690879abeaaac93c9 | 091e28045e8e8ca42d09ecc44788ba32d86a11af | [] | [] | true | ||
MoiraeSoftware/Myriad | 263 | issue_to_patch | [Repo Assist] Refactor: extract shared `extractTypesFromDecls` helper in `Ast.fs` β closes #262 | π€ *This PR was created by Repo Assist, an automated AI assistant.*
## Summary
Eliminates the duplicate `extractTypes` nested function that was defined identically inside both `Ast.extractTypeDefn` (lines 216β225) and `Ast.ModuleOrNamespace.getTypeDefns` (lines 269β276), as reported in issue #262.
## Root Cause
Bot... | b81774f80137bf010e670d93642b02495768c8c6 | 7ca76d3ead8b1994f22708254cdc5d2b4240bb93 | diff --git a/src/Myriad.Core/Ast.fs b/src/Myriad.Core/Ast.fs
index 6e0004a3..e6e4ba11 100644
--- a/src/Myriad.Core/Ast.fs
+++ b/src/Myriad.Core/Ast.fs
@@ -212,22 +212,20 @@ module Ast =
|> List.collect (fun n -> n.Attributes)
|> List.tryFind (typeNameMatches typeof<'a>)
- let extractTypeDefn (ast... | [
"src/Myriad.Core/Ast.fs"
] | [] | true | ||
MoiraeSoftware/Myriad | 266 | issue_to_patch | [Repo Assist] Refactor: extract `createTypedNamedParen` helper to eliminate 13-site duplication β closes #265 | π€ *This PR was created by Repo Assist, an automated AI assistant.*
## Summary
Eliminates the 13-site duplication of `SynPat.CreateParen(SynPat.CreateTyped(SynPat.CreateNamed(β¦), β¦))` reported in issue #265 by extracting a single `createTypedNamedParen` helper into `GeneratorHelpers.fs`.
## Root Cause
Both `LensesG... | b81774f80137bf010e670d93642b02495768c8c6 | 81344d6c6b925e657ecdb4ff9d02c8480e6170af | diff --git a/src/Myriad.Plugins/FieldsGenerator.fs b/src/Myriad.Plugins/FieldsGenerator.fs
index a5da0989..1dac3573 100644
--- a/src/Myriad.Plugins/FieldsGenerator.fs
+++ b/src/Myriad.Plugins/FieldsGenerator.fs
@@ -16,10 +16,7 @@ module internal Create =
let varName = "x"
let pattern =
le... | [
"src/Myriad.Plugins/FieldsGenerator.fs",
"src/Myriad.Plugins/GeneratorHelpers.fs",
"src/Myriad.Plugins/LensesGenerator.fs"
] | [] | true | ||
MoiraeSoftware/Myriad | 253 | issue_to_patch | Duplicate Code: Qualified DU Case Name Resolution in LensesGenerator and DUCasesGenerator
*Analysis of commit 165a7e5b424a16b5d507797e9ed43e4c3da12f5b*
**Assignee**: `@copilot`
## Summary
The logic for resolving a DU case's fully-qualified `SynLongIdent` (based on whether `RequireQualifiedAccess` is in effect) is d... | Move `resolveCaseIdent` to `GeneratorHelpers` to eliminate duplication across generators | `LensesGenerator` contained an inline copy of the qualified DU case name resolution logic already extracted as `resolveCaseIdent` in `DUCasesGenerator`. Any future change (e.g. nested module support) would require parallel edits in both files.
## Changes
- **`GeneratorHelpers.fs`** β Added `resolveCaseIdent` as a sha... | 2cb8ccce5455b79efff83a2690879abeaaac93c9 | ecbbf00c21f6ef6ee4767177b372581784ad36e8 | diff --git a/src/Myriad.Plugins/DUCasesGenerator.fs b/src/Myriad.Plugins/DUCasesGenerator.fs
index 8f06cf1b..6dafe925 100644
--- a/src/Myriad.Plugins/DUCasesGenerator.fs
+++ b/src/Myriad.Plugins/DUCasesGenerator.fs
@@ -15,20 +15,12 @@ module internal CreateDUModule =
let args = SynPat.CreateTyped(name, duType)... | [
"src/Myriad.Plugins/DUCasesGenerator.fs",
"src/Myriad.Plugins/GeneratorHelpers.fs",
"src/Myriad.Plugins/LensesGenerator.fs"
] | [] | true | |
MoiraeSoftware/Myriad | 252 | issue_to_patch | FYI: released version is 0.85, not 0.8.5
Just wanted to check you're aware that https://www.nuget.org/packages/Myriad lists the most recent versions as 0.8.3 and 0.85.0; I suspect that was not intentional. (No request associated with this comment, but it's the kind of thing that someone will get confused by at some po... | Prevent accidental wrong-version publishes (e.g. v0.85 β 0.85.0 instead of 0.8.5) | A 2-segment tag (`v0.85`) triggered a publish that NuGet normalised to `0.85.0` instead of the intended `0.8.5`. The publish workflow had no guard against this.
## Changes
- **Tag pattern tightened** β `v*` β `v*.*.*`; 2-segment tags no longer trigger the workflow
- **Version validation step added** (runs post-checko... | 2cb8ccce5455b79efff83a2690879abeaaac93c9 | 4c9a81540ae8baad285bb52e23871b9756417dac | diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index a2f59476..0bf937bf 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -3,11 +3,11 @@ name: Publish
on:
push:
tags:
- - 'v*' # Publish on any new tag matching v*, i.e. v1.0, v1.7.2
+ - 'v*.*... | [
".github/workflows/publish.yml",
"CHANGELOG.md"
] | [
{
"comment": "The X.Y.Z validation regex is too permissive: `^[0-9]+\\.[0-9]+\\.[0-9]+` will also accept values like `0.8.5foo` (no `-`/`+` separator) and `0.8.5.1`. If the intent is SemVer-style `X.Y.Z` optionally followed by a pre-release/build suffix, anchor the regex and require the separator (e.g. only all... | true | |
MoiraeSoftware/Myriad | 255 | issue_to_patch | Duplicate Code: Structural Duplication in Generate Method Across DUCasesGenerator and FieldsGenerator
*Analysis of recent commits β MoiraeSoftware/Myriad*
**Assignee**: `@copilot`
## Summary
The `Generate` method implementations in `DUCasesGenerator` and `FieldsGenerator` share an almost identical 14-line structura... | Refactor: extract `generateModules` helper to eliminate duplicate `Generate` pipeline in DUCasesGenerator and FieldsGenerator | `DUCasesGenerator.Generate` and `FieldsGenerator.Generate` shared an identical ~14-line pipeline (parse AST β extract types β filter by attribute β collect modules), differing only in extractor function, attribute type, and module-creation call.
## Changes
- **`GeneratorHelpers.fs`** β adds `generateModules<'Attr>` g... | 2cb8ccce5455b79efff83a2690879abeaaac93c9 | 4efc2e191e1c1e25a0b24b49239cfe4df431bb6e | [] | [] | true | ||
MoiraeSoftware/Myriad | 250 | issue_to_patch | [Repo Assist] Refactor: extract filterTypes helper to eliminate 5-fold duplication in Ast.fs β closes #249 | π€ *This is an automated pull request from Repo Assist.*
## Summary
Introduces a private `filterTypes` helper in `Ast.fs` to eliminate the identical "map-then-filter type definitions" pattern that was repeated 5 times across:
- `extractRecords` / `extractDU` (module-level)
- `ModuleOrNamespace.records` / `ModuleOrNa... | 165a7e5b424a16b5d507797e9ed43e4c3da12f5b | 1224eef04cb6a784a02817d350f0ca6d3aac059b | diff --git a/src/Myriad.Core/Ast.fs b/src/Myriad.Core/Ast.fs
index dfa1766b..6e0004a3 100644
--- a/src/Myriad.Core/Ast.fs
+++ b/src/Myriad.Core/Ast.fs
@@ -240,19 +240,14 @@ module Ast =
| SynTypeDefnRepr.Simple(SynTypeDefnSimpleRepr.Union _, _) -> true
| _ -> false
+ let private filterTypes predi... | [
"src/Myriad.Core/Ast.fs"
] | [
{
"comment": "In `filterTypes`, the lambda `fun (ns, types) -> ...` shadows the outer `types` parameter, which makes the helper harder to read and easier to mis-edit later. Consider renaming the outer argument (e.g. `typesByNamespace`) and/or the tuple element (e.g. `typeDefns`) to avoid shadowing while keeping... | true | ||
MoiraeSoftware/Myriad | 241 | issue_to_patch | Duplicate Code: `Generate` Method Structure in DUCasesGenerator and FieldsGenerator
*Analysis of commit 165a7e5b424a16b5d507797e9ed43e4c3da12f5b*
**Assignee**: `@copilot`
## Summary
`DUCasesGenerator.Generate` and `FieldsGenerator.Generate` share a near-identical 12-line implementation pattern: parse AST, extract t... | [Repo Assist] Refactor: extract generateModules helper to eliminate Generate boilerplate | π€ *This is an automated pull request from Repo Assist.*
Closes #240
Also helps address #221.
## Root Cause
After PR #232 extracted `parseInputAst` and `filterByAttribute`, `DUCasesGenerator.Generate` and `FieldsGenerator.Generate` still shared a near-identical 12-line implementation skeleton:
```fsharp
member _.Ge... | 165a7e5b424a16b5d507797e9ed43e4c3da12f5b | 352ee798e9858903162f76f2c8cc6c06eb5f25e2 | diff --git a/src/Myriad.Plugins/DUCasesGenerator.fs b/src/Myriad.Plugins/DUCasesGenerator.fs
index b9fc2fb9..8f06cf1b 100644
--- a/src/Myriad.Plugins/DUCasesGenerator.fs
+++ b/src/Myriad.Plugins/DUCasesGenerator.fs
@@ -139,17 +139,4 @@ type DUCasesGenerator() =
member _.ValidInputExtensions = seq {".fs"}
... | [
"src/Myriad.Plugins/DUCasesGenerator.fs",
"src/Myriad.Plugins/FieldsGenerator.fs",
"src/Myriad.Plugins/GeneratorHelpers.fs"
] | [] | true | |
MoiraeSoftware/Myriad | 239 | issue_to_patch | [docs] Update documentation for infrastructure fixes from 2026-03-04 | ## Documentation Updates - 2026-03-04
This PR updates documentation based on infrastructure fixes merged in the last 24 hours.
### Features Documented
- Publish workflow improvements: manual dispatch, modernised actions, missing `paket restore` step (from #234)
- `Myriad.Sdk` packaging fix: `PackageReference` β `Pac... | 165a7e5b424a16b5d507797e9ed43e4c3da12f5b | 684423990fe8a148e396cb6e1457cff62096af9a | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 98200ee9..3d5bb544 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
+### Fixed
+- Publish workflow now supports manual dispatch via `workflow_dispatch` input,... | [
"CHANGELOG.md",
"Contributing.md"
] | [] | true | ||
MoiraeSoftware/Myriad | 243 | issue_to_patch | [Repo Assist] chore: update Expecto 10.2.1 β 10.2.3 | π€ *This is an automated pull request from Repo Assist.*
Patch update for the Expecto test framework.
## Changes
| Package | Current | Updated | Type |
|---------|---------|---------|------|
| Expecto | 10.2.1 | 10.2.3 | Patch |
## Notes
- **No breaking changes** β this is a patch release.
- Other outdated package... | 165a7e5b424a16b5d507797e9ed43e4c3da12f5b | 9e3ac4a148b78ea352a4312c62cc0f41a4cee3f1 | diff --git a/paket.lock b/paket.lock
index bacb79a5..8ff6b3a5 100644
--- a/paket.lock
+++ b/paket.lock
@@ -8,7 +8,7 @@ NUGET
FSharp.Core (>= 6.0)
System.Configuration.ConfigurationManager (>= 4.4)
editorconfig (0.15)
- Expecto (10.2.1)
+ Expecto (10.2.3)
FSharp.Core (>= 7.0.200)
M... | [
"paket.lock"
] | [] | true | ||
MoiraeSoftware/Myriad | 238 | issue_to_patch | publish fails
Run dotnet build build.proj -c Release -t:Pack /p:Version=0.85
Paket version 9.0.2+a9b12aaeb8d8d5e47a415a3442b7920ed04e98e0
The last full restore is still up to date. Nothing left to do.
Total time taken: 0 milliseconds
Paket version 9.0.2+a9b12aaeb8d8d5e47a415a3442b7920ed04e98e0
The last full ... | Fix pack failure when using 2-segment version numbers (e.g. v0.85) | NuGet internally normalizes 2-segment versions (`0.85`) to 3-segment (`0.85.0`) in nuspec filenames during `dotnet pack`. Paket's `PaketOverrideNuspec` MSBuild target then searches for `*.0.85.nuspec`, finds only `*.0.85.0.nuspec`, and errors out.
## Change
In `build.proj`, the `Pack` target now derives a `PackVersio... | 5fee06b542176f3873d39f4b63da83bb96364643 | 870c7dbcabd2f7318c64d6661864f579485d4174 | diff --git a/build.proj b/build.proj
index 2f385183..04ee13f6 100644
--- a/build.proj
+++ b/build.proj
@@ -20,15 +20,25 @@
</Target>
<Target Name="Pack" DependsOnTargets="Clean;Restore;Test">
+ <PropertyGroup>
+ <!-- Normalize 2-segment versions (e.g., "0.85") to 3-segment (e.g., "0.85.0").
+ ... | [
"build.proj"
] | [] | true | |
MoiraeSoftware/Myriad | 236 | issue_to_patch | Publish action failed: Job 65769391894
Job 65769391894 in MoiraeSoftware/Myriad
The job failed because it could not find the NuGet package Myriad with version >= 0.85.0. Specifically, this error was shown:
Code
error NU1102: Unable to find package Myriad with version (>= 0.85.0) [TargetFramework=netstandard2.1]
- Fo... | Fix publish: replace PackageReference with PackageDownload for Myriad in Myriad.Sdk | Every publish attempt since v0.8.4 failed because `Myriad.Sdk.proj` declared `<PackageReference Include="Myriad" Version="$(Version)" />`, which hits two hard NuGet errors: **NU1102** (the version being published doesn't exist on NuGet.org yet) and **NU1212** (`Myriad` is `PackAsTool=true` β NuGet forbids referencing `... | 11ed6d94cfe38b756190d8ed36aa67a68bd2394c | 33020291b0345a31843a10e999f5978a18cd9c24 | diff --git a/build.proj b/build.proj
index 1b824891..2f385183 100644
--- a/build.proj
+++ b/build.proj
@@ -20,9 +20,15 @@
</Target>
<Target Name="Pack" DependsOnTargets="Clean;Restore;Test">
- <!-- pack sdk then whole sln -->
- <Exec Command='dotnet pack src/Myriad.Sdk/Myriad.Sdk.proj -c Release -o "$(Nup... | [
"build.proj",
"src/Myriad.Sdk/Myriad.Sdk.proj",
"src/Myriad.Sdk/build/Myriad.Sdk.props"
] | [
{
"comment": "`PackageDownload` here runs unconditionally, even when consumers override `$(MyriadSdk_Generator_Exe)` (which the props already supports). That can force an unnecessary network download and break offline builds despite a custom generator path being provided. Consider adding a condition (or opt-out... | true | |
MoiraeSoftware/Myriad | 234 | issue_to_patch | The publish workflow should publish to nuget
I need to understand the flow of this workflow and how to go about making a publishable release, making a tag or release should have the ability to either manually or automating the release to nuget. | Fix publish workflow: add manual dispatch, modernize deprecated actions, fix build steps | The publish workflow used deprecated GitHub Actions APIs and had no way to manually trigger a NuGet release without pushing a tag.
## Changes
- **Manual trigger**: Added `workflow_dispatch` with a `version` input so releases can be kicked off from the Actions UI without a tag push
- **Fix deprecated `::set-output`**:... | 8460556dab3a6be7ff7dd6db6f36ad652c0f1881 | 16d86ad5816b43d8afa5036b7b58cd0e2218b684 | diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index bbd77bfe..a2f59476 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -4,6 +4,12 @@ on:
push:
tags:
- 'v*' # Publish on any new tag matching v*, i.e. v1.0, v1.7.2
+ workflow_dispatch:
+ inp... | [
".github/workflows/publish.yml"
] | [
{
"comment": "`workflow_dispatch` input is written to `$GITHUB_OUTPUT` via `echo` without any quoting/sanitization. If the version contains spaces, shell metacharacters, or a newline, it can break the command or corrupt the outputs file. Prefer capturing the value in a variable and writing it with `printf` to a... | true | |
MoiraeSoftware/Myriad | 232 | issue_to_patch | Duplicate Code: AST Parsing and Namespace Filtering Boilerplate in Generator Implementations
# π Duplicate Code Detected: AST Parsing and Namespace Filtering Boilerplate in Generator Implementations
*Analysis of recent commits to MoiraeSoftware/Myriad*
**Assignee**: `@copilot`
## Summary
All three `IMyriadGenerat... | [Repo Assist] Extract parseInputAst and filterByAttribute helpers to GeneratorHelpers | π€ *This is an automated pull request from Repo Assist.*
Closes #231
Also relates to #221.
## Root Cause
All three `IMyriadGenerator` implementations (`DUCasesGenerator`, `FieldsGenerator`, `LensesGenerator`) contained an **identical 4-line block** to load and parse the input AST:
```fsharp
let ast, _ =
Ast.fro... | 8460556dab3a6be7ff7dd6db6f36ad652c0f1881 | 1232c089776768b0e0662e5b722a40170ab48617 | diff --git a/src/Myriad.Plugins/DUCasesGenerator.fs b/src/Myriad.Plugins/DUCasesGenerator.fs
index 7b36c9d0..b9fc2fb9 100644
--- a/src/Myriad.Plugins/DUCasesGenerator.fs
+++ b/src/Myriad.Plugins/DUCasesGenerator.fs
@@ -139,17 +139,11 @@ type DUCasesGenerator() =
member _.ValidInputExtensions = seq {".fs"}
... | [
"src/Myriad.Plugins/DUCasesGenerator.fs",
"src/Myriad.Plugins/FieldsGenerator.fs",
"src/Myriad.Plugins/GeneratorHelpers.fs",
"src/Myriad.Plugins/LensesGenerator.fs",
"src/Myriad.Plugins/Myriad.Plugins.fsproj"
] | [] | true | |
MoiraeSoftware/Myriad | 230 | issue_to_patch | Duplicate Code: Match Clause Building Pattern in DUCasesGenerator
*Analysis of recent commits to MoiraeSoftware/Myriad*
**Assignee**: `@copilot`
## Summary
Three functions in `DUCasesGenerator.fs` contain nearly identical 5-line blocks for building DU match clauses β resolving the case identifier, computing wildcar... | [Repo Assist] Extract createCaseMatchClause helper in DUCasesGenerator | π€ *This is an automated pull request from Repo Assist.*
Closes #229
## Root Cause
`createToString`, `createToTag`, and `createIsCase` in `DUCasesGenerator.fs` each contained an identical 4-line block that:
1. Resolved the case identifier (with optional qualified-access prefix)
2. Built the wildcard argument list ba... | 85293d549762a4256ac3f0eac3c2cb05bbc660de | 4ca2fd8dbb74b6b51a4691d4220fa9cd8ab4d7d7 | diff --git a/src/Myriad.Plugins/DUCasesGenerator.fs b/src/Myriad.Plugins/DUCasesGenerator.fs
index 80d2fadc..7b36c9d0 100644
--- a/src/Myriad.Plugins/DUCasesGenerator.fs
+++ b/src/Myriad.Plugins/DUCasesGenerator.fs
@@ -27,6 +27,12 @@ module internal CreateDUModule =
let ident = SynLongIdent.CreateString inputI... | [
"src/Myriad.Plugins/DUCasesGenerator.fs"
] | [
{
"comment": "In `createCaseMatchClause`, the local name `indent` is misleading since it holds a resolved case identifier (`SynLongIdent`), not indentation. Consider renaming it (e.g., `caseIdent`/`caseLongIdent`) to avoid confusion with formatting/indentation terminology and to align with `resolveCaseIdent`.\n... | true | |
MoiraeSoftware/Myriad | 228 | issue_to_patch | [docs] Update documentation for v0.8.5 features from 2026-03-03 | ## Documentation Updates - 2026-03-03
This PR updates the documentation based on features released in v0.8.5 (merged 2026-03-02).
### Features Documented
- **Fields generator `map` fix** β corrected the generated code example in `record-fields.md` to show plain record construction instead of copy-and-update (`with`)... | 85293d549762a4256ac3f0eac3c2cb05bbc660de | 2a844969430c553fb62a983967eff17c7a297564 | diff --git a/docs/content/docs/Plugins/record-fields.md b/docs/content/docs/Plugins/record-fields.md
index 803692fb..6d300a75 100644
--- a/docs/content/docs/Plugins/record-fields.md
+++ b/docs/content/docs/Plugins/record-fields.md
@@ -51,11 +51,10 @@ module Test1 =
four = four }
let map (mapone : int ... | [
"docs/content/docs/Plugins/record-fields.md",
"docs/content/docs/Tutorials/external-plugins.md",
"docs/content/docs/Tutorials/msbuild-usage.md"
] | [
{
"comment": "The claim that Fantomas 7.0.5 provides \"full F# 8 syntax support\" appears stronger than what Myriad actually relies on here. The v0.8.5 changelog describes this upgrade as adding full support for `SynExpr.DotLambda` (to fix parsing of `_.property`), not all F# 8 syntax. Consider rephrasing to sp... | true | ||
MoiraeSoftware/Myriad | 227 | issue_to_patch | Failing workflow job: Job 65418601804 in MoiraeSoftware/Myriad
The job is failing due to a duplicate definition error for the value editorConfigTests in test/Myriad.IntegrationPluginTests/Tests.fs at line 190. This is caused by defining let editorConfigTests twice in the same file: once at line 120 and again at line 1... | Fix FS0037: remove duplicate `editorConfigTests` definition | `test/Myriad.IntegrationPluginTests/Tests.fs` contained two identical `let editorConfigTests` bindings, causing the F# compiler to emit `FS0037: Duplicate definition of value 'editorConfigTests'` and fail the build.
## Changes
- **`test/Myriad.IntegrationPluginTests/Tests.fs`**: Removed the second (lines 190β258) of ... | 2a297386d09247dd78ce19cf119cc082b984f803 | e8c3d37db8ede1d1a26cf05a92ae80de23495dc3 | [
"test/Myriad.IntegrationPluginTests/Tests.fs"
] | [] | diff --git a/test/Myriad.IntegrationPluginTests/Tests.fs b/test/Myriad.IntegrationPluginTests/Tests.fs
index 8574b1c0..d052327a 100644
--- a/test/Myriad.IntegrationPluginTests/Tests.fs
+++ b/test/Myriad.IntegrationPluginTests/Tests.fs
@@ -187,76 +187,6 @@ let editorConfigTests =
}
]
-let editorConfigTes... | true | |
MoiraeSoftware/Myriad | 222 | issue_to_patch | [Repo Assist] Release v0.8.5: update CHANGELOG and bump version | π€ *This PR was created by Repo Assist, an automated AI assistant.*
This draft PR prepares the v0.8.5 release by:
1. Moving the `[Unreleased]` CHANGELOG entries to `[0.8.5]`
2. Adding missing CHANGELOG entries for two features already merged to `master` (#218 and #219) but not yet documented
3. Bumping `VersionPrefix... | d8842b91cc8ccea7e5a530c863165378e6e9032a | 52874e053cd7b43c4844b3f587766a5392fb8868 | diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 0577046a..bbd77bfe 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -57,3 +57,7 @@ jobs:
tag: ${{ github.ref }}
overwrite: true
file_glob: true
+ - name: Push to NuGet
+ r... | [
".github/workflows/publish.yml",
"CHANGELOG.md",
"Directory.Build.props"
] | [
{
"comment": "Within the new 0.8.5 section, the \"### Fixed\" heading appears twice (once at line 10 and again at line 18). This makes the release notes structure inconsistent and may confuse changelog tooling/readers; please merge the dot-lambda bullet into the first \"Fixed\" list (or keep a single \"Fixed\" ... | true | ||
MoiraeSoftware/Myriad | 225 | issue_to_patch | Resolve CHANGELOG.md merge conflicts for PR #222 | PR #222 (`repo-assist/release-v0.8.5-24c77a84e9be2d82` β `master`) was `dirty` due to conflicts in `CHANGELOG.md`. The PR branch had condensed descriptions for the `.editorconfig` formatting and `extractLiteralBindings` entries under `[0.8.5]`, while `master`'s `[Unreleased]` section had more detailed versions of those... | 76022c76933531c618a0120ac795d3b84937095a | 27cc0b602f83a547ba3a4c1140d9fe05a29fb359 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index a35798c1..98200ee9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,8 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- `SynType.CreateFromLongIdent` helper in `Myriad.Core.AstExtensions`. Plugin authors can now co... | [
"CHANGELOG.md"
] | [] | true | ||
MoiraeSoftware/Myriad | 224 | issue_to_patch | Add NuGet push step to publish workflow | The publish workflow created GitHub Releases and uploaded `.nupkg` files as assets but never pushed packages to NuGet.org.
## Changes
- **`publish.yml`**: Added `dotnet nuget push` step after the GitHub Release upload, targeting `https://api.nuget.org/v3/index.json` with `--skip-duplicate` to handle re-runs safely. A... | 41be4cfc063c070aca689766caf588a97897147d | 10fa28d0d7e61bb8b8ad05e559267c4e5086fa1b | diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 0577046a..bbd77bfe 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -57,3 +57,7 @@ jobs:
tag: ${{ github.ref }}
overwrite: true
file_glob: true
+ - name: Push to NuGet
+ r... | [
".github/workflows/publish.yml"
] | [
{
"comment": "Quote the API key when passing it to `dotnet nuget push` (e.g., `--api-key \"$NUGET_API_KEY\"`) to avoid any chance of shell word-splitting or leading `-` characters being interpreted as flags. This is a low-effort robustness improvement for secrets passed via environment variables.\n```suggestion... | true | ||
MoiraeSoftware/Myriad | 220 | issue_to_patch | [docs] Update documentation for features from 2026-03-01 | ## Documentation Updates - 2026-03-01
This PR updates the documentation based on features merged in the last 24 hours.
### Features Documented
- `.editorconfig` support for generated code formatting (from #218)
- `extractLiteralBindings` / `getAttributeConstantsWithBindings` plugin API for resolving `[(Literal)]` id... | d8842b91cc8ccea7e5a530c863165378e6e9032a | d8e859cf99ec3e3e404311f942fb61ee85f80f0d | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 30c4a2bf..46941155 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- `SynType.CreateFromLongIdent` helper in `Myriad.Core.AstExtensions`. Plugin authors can now co... | [
"CHANGELOG.md",
"docs/content/docs/Tutorials/configuration.md",
"docs/content/docs/Tutorials/external-plugins.md"
] | [] | true | ||
MoiraeSoftware/Myriad | 219 | issue_to_patch | Getting value from Literal/Const
Let's say I have the following code in my `Types.fs` file.
```fsharp
module A =
let [<Literal>] MyConst = "Hello"
type MyAttribute(thing : string) =
inherit System.Attribute()
let _thing = thing
type Thing = {
[<MyAttribute(MyConst)>]
... | Add literal binding resolution for attribute argument identifiers | - [x] Add `extractLiteralBindings` and `getAttributeConstantsWithBindings` to `Myriad.Core.Ast`
- [x] Add integration tests for literal binding resolution
- [x] Merge `origin/master` (EditorConfig support PR) into branch, resolving conflicts
- [x] Fix Program.fs merge conflict: nest `literalBindingTests` inside `tests`... | e3b6a96d4a1c7684dca51c964b46200d2bc0fed3 | 1ab0071b6f9c4df129d8dfa6af410f7ebfecc651 | diff --git a/src/Myriad.Core/Ast.fs b/src/Myriad.Core/Ast.fs
index 858891c7..dfa1766b 100644
--- a/src/Myriad.Core/Ast.fs
+++ b/src/Myriad.Core/Ast.fs
@@ -124,6 +124,61 @@ module Ast =
| StringConst text -> [text]
| _ -> []
+ /// Extracts all [<Literal>] bindings from the parsed AST into a ... | [
"src/Myriad.Core/Ast.fs",
"test/Myriad.IntegrationPluginTests/Tests.fs"
] | [
{
"comment": "`editorConfigTests` is defined twice in this module (once starting here, and again later in the file). This will cause a compile-time βduplicate definitionβ error. Remove one of the duplicate `editorConfigTests` bindings (and keep only a single canonical definition).",
"path": "test/Myriad.Int... | diff --git a/test/Myriad.IntegrationPluginTests/Tests.fs b/test/Myriad.IntegrationPluginTests/Tests.fs
index 6a8f8f33..8574b1c0 100644
--- a/test/Myriad.IntegrationPluginTests/Tests.fs
+++ b/test/Myriad.IntegrationPluginTests/Tests.fs
@@ -7,6 +7,185 @@ open Example
open Example.Lens
open Input
open UnknownNamespace
... | true |
MoiraeSoftware/Myriad | 218 | issue_to_patch | format generated code using editorconfig settings
The generated code does not respect the fantomas settings in `.editorconfig`. The files could be added to `.fantomasignore` based on some pattern, but it could be convenient if the style was uniform and no convention or tracking of generated code is required.
This ... | Format generated code using .editorconfig settings | Myriad was formatting all generated code with `FormatConfig.Default`, ignoring any Fantomas settings defined in `.editorconfig`.
## Changes
- **New `editorconfig` dependency**: Added the `editorconfig` NuGet package (same one Fantomas CLI uses internally)
- **`EditorConfig` module in `Myriad.Core`**: Moved to `Myriad... | 7584fed3ee3fbac1cbd39e9263fdcb860cc68743 | 51c3618205b97a42619adf42f28e7e67db14a1c2 | diff --git a/paket.dependencies b/paket.dependencies
index 6a5e0fdd..c7045fff 100644
--- a/paket.dependencies
+++ b/paket.dependencies
@@ -4,6 +4,7 @@ framework: net90
storage: none
nuget Argu
+nuget editorconfig
nuget Fantomas.Core
nuget FSharp.Compiler.Service
nuget FSharp.Core strategy: min
diff --git a/paket... | [
"paket.dependencies",
"paket.lock",
"src/Myriad.Core/EditorConfig.fs",
"src/Myriad.Core/Myriad.Core.fsproj",
"src/Myriad.Core/paket.references",
"src/Myriad/Program.fs",
"test/Myriad.IntegrationPluginTests/Program.fs",
"test/Myriad.IntegrationPluginTests/Tests.fs",
"test/Myriad.IntegrationPluginTest... | [] | diff --git a/test/Myriad.IntegrationPluginTests/Program.fs b/test/Myriad.IntegrationPluginTests/Program.fs
index 854c7c8d..8e68c6fe 100644
--- a/test/Myriad.IntegrationPluginTests/Program.fs
+++ b/test/Myriad.IntegrationPluginTests/Program.fs
@@ -4,4 +4,4 @@ open Expecto
[<EntryPoint>]
let main args =
- runTestsWi... | true |
MoiraeSoftware/Myriad | 189 | issue_to_patch | `mergenupkg` breaks build pipeline in .NET 9; ci still using .NET 6
## Problem overview
I noticed Myriad's main branch had been ~mostly upgraded to .NET 9 but the package wasn't available on NuGet. There are two issues:
- The [publish action](https://github.com/MoiraeSoftware/Myriad/blob/dc54ba9a493881d61f853b1ba6fd... | Remove mergenupkg: split Myriad and Myriad.Sdk into separate NuGet packages | - [x] Remove `dotnet-mergenupkg` from `.config/dotnet-tools.json`
- [x] Remove the `dotnet mergenupkg` step from `build.proj`
- [x] Update `Myriad.Sdk.proj`: remove `SuppressDependenciesWhenPacking`, remove Paket import, add `PackageReference` to `Myriad`
- [x] Update `src/Myriad.Sdk/build/Myriad.Sdk.props`: locate `My... | 137f049f3a6b7a6afee496308061a93179ff6636 | a8c15c6a91e7853d71298b1034b7f3c7a792799d | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 6ab14170..0c5da0a9 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -7,12 +7,6 @@
"commands": [
"paket"
]
- },
- "dotnet-mergenupkg": {
- "version": "3.0.0",
- "commands": [
- ... | [
".config/dotnet-tools.json",
".github/workflows/publish.yml",
"CHANGELOG.md",
"README.md",
"build.proj",
"src/Myriad.Sdk/Myriad.Sdk.proj",
"src/Myriad.Sdk/build/Myriad.Sdk.props"
] | [
{
"comment": "`Myriad.Sdk.proj` now has a `PackageReference` to `Myriad`, but the Pack target packs `Myriad.Sdk` *before* packing the solution that produces `Myriad.$(Version).nupkg`. For a new version/tag (or any local pack where that version isn't already on NuGet), `dotnet pack src/Myriad.Sdk/Myriad.Sdk.proj... | true | |
MoiraeSoftware/Myriad | 216 | issue_to_patch | Duplicate Code: Parallel Records/DU Processing Blocks in LensesGenerator.Generate
*Analysis of recent commits to MoiraeSoftware/Myriad*
**Assignee**: `@copilot`
## Summary
The `Generate` method in `LensesGenerator.fs` contains two nearly identical code blocks (lines 194β212 and 215β233) that process record types an... | Refactor: deduplicate records/DU processing in LensesGenerator and simplify open-declaration pattern | `LensesGenerator.Generate` contained two structurally identical ~20-line blocks differing only in whether they called `Ast.extractRecords` or `Ast.extractDU`. All three generator files also repeated a 3-line pattern to construct an open-namespace declaration from a `LongIdent`.
## Changes
- **`LensesGenerator.fs`** β... | efd601cc58f0a88f37ef1378093c3b8be8949760 | d8c71ae47f7140d1cdd4c031b19b86977c25da55 | diff --git a/src/Myriad.Core/AstExtensions.fs b/src/Myriad.Core/AstExtensions.fs
index 9ec359ac..d98d7be9 100644
--- a/src/Myriad.Core/AstExtensions.fs
+++ b/src/Myriad.Core/AstExtensions.fs
@@ -414,6 +414,8 @@ module AstExtensions =
SynModuleDecl.Open(id, range0)
static member CreateOpen (fullNam... | [
"src/Myriad.Core/AstExtensions.fs",
"src/Myriad.Plugins/DUCasesGenerator.fs",
"src/Myriad.Plugins/FieldsGenerator.fs",
"src/Myriad.Plugins/LensesGenerator.fs"
] | [] | true | |
MoiraeSoftware/Myriad | 217 | issue_to_patch | warning in fields generator
When running with optional warnings enabled such as `<WarnOn>FS3560;...`, the following warning shows up in the code generated by the fields generator:
```
This copy-and-update record expression changes all fields of record type 'Example.Test1'. Consider using the record construction sy... | Fix FS3560 warning in fields generator map function | The `map` function generated by the fields generator used copy-and-update (`with`) syntax when updating all fields, triggering FS3560 ("This copy-and-update record expression changes all fields..."). With `<TreatWarningsAsErrors>true</TreatWarningsAsErrors>` this becomes a build failure.
## Changes
- **`FieldsGenerat... | efd601cc58f0a88f37ef1378093c3b8be8949760 | e589de8e2e052eaf11791f178f58bbaeaabb2a40 | diff --git a/src/Myriad.Plugins/FieldsGenerator.fs b/src/Myriad.Plugins/FieldsGenerator.fs
index 54895166..7ab7e71d 100644
--- a/src/Myriad.Plugins/FieldsGenerator.fs
+++ b/src/Myriad.Plugins/FieldsGenerator.fs
@@ -94,10 +94,6 @@ module internal Create =
SynPat.CreateLongIdent(varIdent, allArgs)
... | [
"src/Myriad.Plugins/FieldsGenerator.fs",
"test/Myriad.IntegrationPluginTests/FieldsLensDus.fs",
"test/Myriad.IntegrationPluginTests/InputSelfGenerate.fs",
"test/Myriad.IntegrationPluginTests/Tests.fs"
] | [] | diff --git a/test/Myriad.IntegrationPluginTests/FieldsLensDus.fs b/test/Myriad.IntegrationPluginTests/FieldsLensDus.fs
index d34c8775..c0f677ad 100644
--- a/test/Myriad.IntegrationPluginTests/FieldsLensDus.fs
+++ b/test/Myriad.IntegrationPluginTests/FieldsLensDus.fs
@@ -208,11 +208,10 @@ module Test1 =
(mapfou... | true |
MoiraeSoftware/Myriad | 215 | issue_to_patch | Duplicate Code: Config Extraction Pattern in Generator Files
*Analysis of commit 6329dfbda26e4156671a3487fee3198a4d296190*
**Assignee**: `@copilot`
## Summary
The same inline config value extraction pattern using `Seq.tryPick` is repeated **6 times** across three generator files (`DUCasesGenerator.fs`, `FieldsGener... | Refactor: eliminate duplicate records/DU processing blocks in LensesGenerator.Generate | `LensesGenerator.Generate` contained two structurally identical blocks β one for record types, one for DU types β differing only in variable names and the extraction call (`Ast.extractRecords` vs `Ast.extractDU`).
Extracts a local `processTypeList` helper that both paths share:
```fsharp
let processTypeList namespace... | efd601cc58f0a88f37ef1378093c3b8be8949760 | 0a4941b8248997e87c86b14cc2fe9e25141faf90 | diff --git a/src/Myriad.Plugins/LensesGenerator.fs b/src/Myriad.Plugins/LensesGenerator.fs
index 4834f16d..0c22caef 100644
--- a/src/Myriad.Plugins/LensesGenerator.fs
+++ b/src/Myriad.Plugins/LensesGenerator.fs
@@ -190,34 +190,22 @@ type LensesGenerator() =
|> Async.RunSynchronously
|>... | [
"src/Myriad.Plugins/LensesGenerator.fs"
] | [] | true | |
MoiraeSoftware/Myriad | 214 | issue_to_patch | Duplicate Code: DU Case Function Skeleton in DUCasesGenerator
*Analysis of commit 7d0ee63b7bfc02614632cff86ee157018f3b416d*
**Assignee**: `@copilot`
## Summary
Four functions in `DUCasesGenerator.fs` share an identical structural skeleton β differing only in the name, match body, and return type. This structural du... | Refactor: Extract `createDuLetBinding` helper to eliminate structural duplication in DUCasesGenerator | Four functions in `DUCasesGenerator.fs` shared identical scaffolding (pattern construction, match expression, binding creation) differing only in var name, input/return types, and match clauses β ~120 lines of repetitive structural code with an incidental `DebugPointAtBinding` inconsistency.
## Changes
- **New helper... | efd601cc58f0a88f37ef1378093c3b8be8949760 | ef010b6f1d850acfeb157c0c4abc605ba09fffd8 | diff --git a/src/Myriad.Plugins/DUCasesGenerator.fs b/src/Myriad.Plugins/DUCasesGenerator.fs
index 60f82370..458477c0 100644
--- a/src/Myriad.Plugins/DUCasesGenerator.fs
+++ b/src/Myriad.Plugins/DUCasesGenerator.fs
@@ -27,52 +27,38 @@ module internal CreateDUModule =
let ident = SynLongIdent.CreateString input... | [
"src/Myriad.Plugins/DUCasesGenerator.fs"
] | [] | true | |
MoiraeSoftware/Myriad | 212 | issue_to_patch | Duplicate Code: Config Extraction Pattern in Generator Files
*Analysis of commit 6329dfbda26e4156671a3487fee3198a4d296190*
**Assignee**: `@copilot`
## Summary
The same inline config value extraction pattern using `Seq.tryPick` is repeated **6 times** across three generator files (`DUCasesGenerator.fs`, `FieldsGener... | [Repo Assist] Refactor: extract GeneratorConfig helper to centralise config key lookups | π€ *This PR was created by Repo Assist, an automated AI assistant.*
The same inline `Seq.tryPick` config extraction pattern was duplicated **6 times** across `DUCasesGenerator.fs`, `FieldsGenerator.fs`, and `LensesGenerator.fs` (identified in #211).
## Changes
- **New file** `src/Myriad.Plugins/GeneratorConfig.fs`: ... | 6329dfbda26e4156671a3487fee3198a4d296190 | 526951244a92c21e4cc13e52fd0d7f9a60122d63 | diff --git a/src/Myriad.Plugins/DUCasesGenerator.fs b/src/Myriad.Plugins/DUCasesGenerator.fs
index cf946b3e..60f82370 100644
--- a/src/Myriad.Plugins/DUCasesGenerator.fs
+++ b/src/Myriad.Plugins/DUCasesGenerator.fs
@@ -177,10 +177,7 @@ module internal CreateDUModule =
let info = SynComponentInfo.Create rec... | [
"src/Myriad.Plugins/DUCasesGenerator.fs",
"src/Myriad.Plugins/FieldsGenerator.fs",
"src/Myriad.Plugins/GeneratorConfig.fs",
"src/Myriad.Plugins/LensesGenerator.fs",
"src/Myriad.Plugins/Myriad.Plugins.fsproj"
] | [] | true | |
MoiraeSoftware/Myriad | 207 | issue_to_patch | [docs] Update external-plugins docs for cross-framework compatibility (from 2026-02-27) | ## Documentation Updates - 2026-02-27
This PR updates the documentation based on features merged in the last 24 hours.
### Features Documented
- Cross-framework plugin loading compatibility (from #206)
### Changes Made
- Updated `docs/content/docs/Tutorials/external-plugins.md` to add a **Framework Compatibility**... | 7d0ee63b7bfc02614632cff86ee157018f3b416d | 98bb5cf7f868f263de1c9d3f86ee47ea901c79c4 | diff --git a/docs/content/docs/Tutorials/external-plugins.md b/docs/content/docs/Tutorials/external-plugins.md
index 175694d5..71343972 100644
--- a/docs/content/docs/Tutorials/external-plugins.md
+++ b/docs/content/docs/Tutorials/external-plugins.md
@@ -65,3 +65,12 @@ In your testing `fsproj` you would add the followi... | [
"docs/content/docs/Tutorials/external-plugins.md"
] | [] | true | ||
MoiraeSoftware/Myriad | 206 | issue_to_patch | Unable to load custom plugin built with SDK > 6.0
Hi.
I have tried to create and test a custom plugin. When trying to load it in a test-app, the tools throws a
`System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.`
This happens if the plugin is build against any target f... | Fix ReflectionTypeLoadException when loading plugins built against a different target framework | Plugins built against a framework version other than the Myriad tool's own target (e.g. a `net8.0` plugin in a `net9.0` host) fail at runtime with `System.Reflection.ReflectionTypeLoadException` because the plugin loader loads its own copies of `FSharp.Core`, `Fantomas.FCS`, etc., creating type identity mismatches acro... | 7f92dfb60a737954f185aae6a6a8945bdf25f33e | 71eb90fa8a73ae1dd149b82af1ac7ba3054a2447 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index cb20dd72..2dde659f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [Unreleased]
+###... | [
"CHANGELOG.md",
"src/Myriad/Program.fs"
] | [
{
"comment": "The exception handler silently discards types that fail to load without logging any diagnostic information. When a ReflectionTypeLoadException occurs, the LoaderExceptions property contains the specific exceptions for each type that failed to load, which would be valuable for debugging plugin issu... | true | |
MoiraeSoftware/Myriad | 205 | issue_to_patch | Duplicate Code: Single-Arg DU Function Pattern in DUCasesGenerator
*Analysis of commit 7f92dfb60a737954f185aae6a6a8945bdf25f33e*
**Assignee**: `@copilot`
## Summary
In `src/Myriad.Plugins/DUCasesGenerator.fs`, four functions (`createToString`, `createFromString`, `createToTag`, `createIsCase`) each independently re... | Refactor DUCasesGenerator: extract duplicated helper functions | `createToString`, `createFromString`, `createToTag`, and `createIsCase` each independently repeated the same three structural code blocks (~48 lines total), making any change to pattern or match-expression construction require 4 synchronised edits.
## Extracted helpers
- **`createDuInputPattern`** `(varIdent: SynLong... | 7f92dfb60a737954f185aae6a6a8945bdf25f33e | d266e558359294f95638cde2d3868065b3f6322c | diff --git a/src/Myriad.Plugins/DUCasesGenerator.fs b/src/Myriad.Plugins/DUCasesGenerator.fs
index 94fbc0ee..cf946b3e 100644
--- a/src/Myriad.Plugins/DUCasesGenerator.fs
+++ b/src/Myriad.Plugins/DUCasesGenerator.fs
@@ -8,28 +8,38 @@ open Myriad.Core.Ast
module internal CreateDUModule =
open Fantomas.FCS.Text.Rang... | [
"src/Myriad.Plugins/DUCasesGenerator.fs"
] | [
{
"comment": "The local name `indent` appears to be a typo/misnomer (it holds a case identifier, not indentation). Renaming it to something like `caseIdent`/`fullCaseName` would make the match clause construction easier to read.",
"path": "src/Myriad.Plugins/DUCasesGenerator.fs",
"hunk": "@@ -101,31 +98... | true | |
MoiraeSoftware/Myriad | 201 | issue_to_patch | myriad running in ci when nothing has changed
I'm seeing my myriad generators run in CI and as far as I can tell they're the most time consuming step for the build as I'm using them quite heavily and haven't spent time optimizing them.
I see that there's a cache file written to the build folder to control whether ... | Fix Myriad generators always running in CI due to ModifiedTime in cache hash | Myriad generators were re-running on every CI build even when inputs hadn't changed. The cache hash included `%(ModifiedTime)` alongside `%(FileHash)`, causing cache misses whenever files were freshly checked out (CI always sets new timestamps).
## Change
- **`Myriad.Sdk.targets`**: Remove `%(ModifiedTime)` from the ... | 45312a035fd344aab4f5f0ca1ed080e9876ae10a | d42273c11bddd63e5067888a0c5d76a6f99bd128 | diff --git a/src/Myriad.Sdk/build/Myriad.Sdk.targets b/src/Myriad.Sdk/build/Myriad.Sdk.targets
index 4a587828..4ddc5ec0 100644
--- a/src/Myriad.Sdk/build/Myriad.Sdk.targets
+++ b/src/Myriad.Sdk/build/Myriad.Sdk.targets
@@ -144,7 +144,6 @@
<ItemGroup>
<MyriadSdk_CodeGenInputs Include="@(MyriadCodeg... | [
"src/Myriad.Sdk/build/Myriad.Sdk.targets"
] | [] | true | |
MoiraeSoftware/Myriad | 202 | issue_to_patch | [docs] Update documentation for features from 2026-02-26 | ## Documentation Updates - 2026-02-26
This PR updates the documentation based on features merged in the last 24 hours.
### Features Documented
- F# 8 dot-lambda (`_.property`) syntax support in Myriad input files (from #199)
### Changes Made
- Updated `CHANGELOG.md` to add a `### Fixed` entry under `[Unreleased]` ... | 7f92dfb60a737954f185aae6a6a8945bdf25f33e | fb832ec3a2b38ffd1451994c49f2ac9849d7b3e3 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index cb20dd72..3f197279 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,10 +8,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- `SynType.CreateFromLongIdent` helper in `Myriad.Core.AstExtensions`. Plugin authors can now conv... | [
"CHANGELOG.md"
] | [] | true | ||
MojoJolo/textteaser | 33 | issue_to_patch | Build a corpus for other languages.
TextTeaser uses OpenNLP to split sentences. And OpenNLP requires a corpus for it to split sentences properly.
Here's a list of languages with corpus from OpenNLP:
http://opennlp.sourceforge.net/models-1.5/
Limited language are supported by the sentence detector of OpenNLP. It's go... | Multilingual, now supporting also Spanish | Added instructions of how to migrate models from NLTK to OpenNLP.
Migrated StopWords to its own class, language-dependent.
Added language dependency injection to the GuiceModule.
The SimpleREPL now summarizes Spanish as an example.
I believe this closes #15
| e2457563a3cb457b99bde5853de91897beaa7836 | 6e24f694c3f8747ce84f6c51b4242d6645591526 | diff --git a/corpus/README.md b/corpus/README.md
new file mode 100644
index 0000000..1bd04a5
--- /dev/null
+++ b/corpus/README.md
@@ -0,0 +1,41 @@
+Training new models
+===================
+
+This folder contains Maximum Entropy models for sentence splitting, as needed by OpenNLP 1.5.
+
+See http://opennlp.apache.org/d... | [
"corpus/README.md",
"corpus/corpusES.bin",
"src/main/scala/com/textteaser/summarizer/Config.scala",
"src/main/scala/com/textteaser/summarizer/GuiceModule.scala",
"src/main/scala/com/textteaser/summarizer/Parser.scala",
"src/main/scala/com/textteaser/summarizer/SimpleREPL.scala",
"src/main/scala/com/text... | [] | true | |
MojoJolo/textteaser | 32 | issue_to_patch | Tidy README.md | a7973839799e93c348436f0767c3bcf34c85d596 | 8c014f4cab24698c140e1a8de6bd2f7c742ab116 | diff --git a/README.md b/README.md
index fb74af9..42e1976 100644
--- a/README.md
+++ b/README.md
@@ -19,13 +19,12 @@ Use of [Scala IDE](http://scala-ide.org/) is recommended
### Setup
-1. git clone https://github.com/MojoJolo/textteaser.git
-2. sbt compile
-3. sbt eclipse // If using Eclipse.
-4. sbt run
-
-[![Clo... | [
"README.md"
] | [] | true | |||
MojoJolo/textteaser | 31 | issue_to_patch | updating to work with Java 8 runtime | 0ebb52ccd438fd2dfb081f2f0a441f44ce00fcd7 | 8432b183f8086a865bb7ade2673ced9a40a1452a | diff --git a/.cache b/.cache
deleted file mode 100644
index 732b8c6..0000000
Binary files a/.cache and /dev/null differ
diff --git a/.classpath b/.classpath
deleted file mode 100644
index abc3714..0000000
--- a/.classpath
+++ /dev/null
@@ -1,56 +0,0 @@
-<classpath>
- <classpathentry output="target/scala-2.10/classes" ... | [
".cache",
".classpath",
".gitignore",
".project",
".settings/org.eclipse.jdt.core.prefs",
"build.sbt",
"project/build.properties",
"project/plugins.sbt"
] | [] | true | |||
MojoJolo/textteaser | 30 | issue_to_patch | Update version of sbt-idea. Closes #29 | f46c4d1cf290d9b3fcd98f85d1d11746034f3451 | c6c036524f40a600cf53024945f8b02e72ecdf4c | diff --git a/project/plugins.sbt b/project/plugins.sbt
index 7404aa9..63ce8e1 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -4,5 +4,5 @@ addSbtPlugin("com.typesafe.sbt" % "sbt-start-script" % "0.9.0")
resolvers += "Sonatype snapshots" at "http://oss.sonatype.org/content/repositories/snapshots/"
-ad... | [
"project/plugins.sbt"
] | [] | true | |||
MojoJolo/textteaser | 17 | issue_to_patch | Setters for Summarizer | This addresses issue #16.
I'm also wondering if there is some correlation between topKeywords size and summary size? I.e. maybe I should have a formula that changes topKeywords size automatically depending on the desired summary size?
Also, @MojoJolo, have you seen my question [here](https://github.com/MojoJolo/textt... | 8313e6d2b84e497ae13c5f63dba20ffcdfbef860 | e584e1278dba86754c4ddbccebd6b375b81c5978 | diff --git a/src/main/scala/com/textteaser/summarizer/Summarizer.scala b/src/main/scala/com/textteaser/summarizer/Summarizer.scala
index 79a2acd..c2b0b11 100644
--- a/src/main/scala/com/textteaser/summarizer/Summarizer.scala
+++ b/src/main/scala/com/textteaser/summarizer/Summarizer.scala
@@ -5,21 +5,41 @@ import org.js... | [
"src/main/scala/com/textteaser/summarizer/Summarizer.scala"
] | [] | true | ||
MojoJolo/textteaser | 13 | issue_to_patch | First steps with ScalaTest | I've partially done ParserSuite, but in process I had some questions that should be cleared before accepting (not yet ready) PR.
- Maybe we should store those large strings and arrays of strings in files or serialized? That's not a performance hit since that doesn't affect runtime and that's more elegant and concise.
-... | 82dd2d092608e1a063d9539df335abf6d4b76f98 | 27add5f6e184b46c078bd324e4622bceb6bf26f2 | diff --git a/build.sbt b/build.sbt
index 21b8c67..bca7a97 100644
--- a/build.sbt
+++ b/build.sbt
@@ -21,7 +21,8 @@ libraryDependencies ++= Seq(
"org.slf4j" % "slf4j-api" % "1.7.5",
"ch.qos.logback" % "logback-classic" % "1.0.13",
"com.google.guava" % "guava" % "15.0",
- "com.google.code.findbugs" % "jsr305" % "2.... | [
"build.sbt",
"src/main/scala/com/textteaser/summarizer/GuiceModule.scala",
"src/main/scala/com/textteaser/summarizer/Parser.scala",
"src/main/scala/com/textteaser/summarizer/Summarizer.scala",
"src/main/test/scala/com/textteaser/summarizer/ParserSuite.scala"
] | [] | diff --git a/src/main/test/scala/com/textteaser/summarizer/ParserSuite.scala b/src/main/test/scala/com/textteaser/summarizer/ParserSuite.scala
new file mode 100644
index 0000000..4a6669e
--- /dev/null
+++ b/src/main/test/scala/com/textteaser/summarizer/ParserSuite.scala
@@ -0,0 +1,127 @@
+package com.textteaser.summari... | true | |
MojoJolo/textteaser | 6 | issue_to_patch | Fixes and improvements | - First try on using Guava's Splitter functionality
- Added SBT gen-idea plugin for IntelliJ IDEA users' convenience
- Corrected `Main.scala` encoding
- Minor fixes
| 58754e2f2d258aa1de6409e868d15081333f3c08 | 384f9484c3c6111af79b0dc3fd87a7d1f42571bf | diff --git a/.gitignore b/.gitignore
index 05b170b..3d4f82a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -13,3 +13,7 @@ project/plugins/project/
# Scala-IDE specific
.scala_dependencies
+
+# Idea-specific
+.idea
+.idea_modules
diff --git a/build.sbt b/build.sbt
index 06ad664..21b8c67 100644
--- a/build.sbt
+++ b/bui... | [
".gitignore",
"build.sbt",
"project/plugins.sbt",
"src/main/scala/com/textteaser/summarizer/Main.scala",
"src/main/scala/com/textteaser/summarizer/Parser.scala"
] | [] | true | ||
MojoJolo/textteaser | 27 | issue_to_patch | Minor Performance Tweak | Number of Comparisons reduced to half
| 17d564e8c31ac8535c0b2a31864c938c62286554 | 099473a3df1180f76320c965a7b047329d964669 | diff --git a/src/main/scala/com/textteaser/summarizer/Parser.scala b/src/main/scala/com/textteaser/summarizer/Parser.scala
index 57b7b8d..db072cf 100644
--- a/src/main/scala/com/textteaser/summarizer/Parser.scala
+++ b/src/main/scala/com/textteaser/summarizer/Parser.scala
@@ -75,30 +75,31 @@ class Parser @Inject() (sen... | [
"src/main/scala/com/textteaser/summarizer/Parser.scala"
] | [] | true | ||
MojoJolo/textteaser | 5 | issue_to_patch | Some code simplifications | 58754e2f2d258aa1de6409e868d15081333f3c08 | e349b2ef2d74c16580c7b9aa90c06efcde133447 | diff --git a/src/main/scala/com/textteaser/summarizer/KeywordService.scala b/src/main/scala/com/textteaser/summarizer/KeywordService.scala
index 78f5adf..ad7cea3 100644
--- a/src/main/scala/com/textteaser/summarizer/KeywordService.scala
+++ b/src/main/scala/com/textteaser/summarizer/KeywordService.scala
@@ -14,11 +14,1... | [
"src/main/scala/com/textteaser/summarizer/KeywordService.scala",
"src/main/scala/com/textteaser/summarizer/Summarizer.scala"
] | [] | true | |||
MojoJolo/textteaser | 21 | issue_to_patch | Added SummarySuite, fixed dbs function | Up to now Parser and Summary are fully covered with unit tests and I'm going to do some more work on this.
Also, minor but important (typo) fix in dbs implementation was made.
| e584e1278dba86754c4ddbccebd6b375b81c5978 | a1a6f855c2bd01e7ff3064bcc977318dc199d079 | diff --git a/src/main/scala/com/textteaser/summarizer/Summarizer.scala b/src/main/scala/com/textteaser/summarizer/Summarizer.scala
index c2b0b11..3fc3108 100644
--- a/src/main/scala/com/textteaser/summarizer/Summarizer.scala
+++ b/src/main/scala/com/textteaser/summarizer/Summarizer.scala
@@ -3,6 +3,7 @@ package com.tex... | [
"src/main/scala/com/textteaser/summarizer/Summarizer.scala",
"src/main/scala/com/textteaser/summarizer/Summary.scala",
"src/test/scala/com/textteaser/summarizer/SummarizerSuite.scala",
"src/test/scala/com/textteaser/summarizer/SummarySuite.scala"
] | [] | diff --git a/src/test/scala/com/textteaser/summarizer/SummarizerSuite.scala b/src/test/scala/com/textteaser/summarizer/SummarizerSuite.scala
new file mode 100644
index 0000000..387753a
--- /dev/null
+++ b/src/test/scala/com/textteaser/summarizer/SummarizerSuite.scala
@@ -0,0 +1,5 @@
+package com.textteaser.summarizer
+... | true | |
MojoJolo/textteaser | 26 | issue_to_patch | Koding button | Hey, I just added the button to your setup section. I can also make it a text link if that feels more natural. :)
Thanks!
| 17d564e8c31ac8535c0b2a31864c938c62286554 | 8a982c6d5112f550c83cb29271f5bb2865ec0015 | diff --git a/README.md b/README.md
index 617d352..fb74af9 100644
--- a/README.md
+++ b/README.md
@@ -24,10 +24,13 @@ Use of [Scala IDE](http://scala-ide.org/) is recommended
3. sbt eclipse // If using Eclipse.
4. sbt run
+[][koding]
+[koding]: https://kodin... | [
"README.md"
] | [] | true | ||
MojoJolo/textteaser | 8 | issue_to_patch | Improvements | Hi, I've done a few things:
- Created a `DummyKeywordService` (and corresponding `trait KeywordService`) so we don't need the Mongo dependency, as it seems, for me, the blog and category counts are not crucial for the algorithm. I'm planning of adding a way to plug in a external source of IDF (inverse-document frequenc... | 58754e2f2d258aa1de6409e868d15081333f3c08 | 7185223ada55228e7876ea92013f5ea9eb0c9e84 | diff --git a/src/main/scala/com/textteaser/summarizer/GuiceModule.scala b/src/main/scala/com/textteaser/summarizer/GuiceModule.scala
index d79f052..416d8f5 100644
--- a/src/main/scala/com/textteaser/summarizer/GuiceModule.scala
+++ b/src/main/scala/com/textteaser/summarizer/GuiceModule.scala
@@ -8,12 +8,15 @@ import ja... | [
"src/main/scala/com/textteaser/summarizer/GuiceModule.scala",
"src/main/scala/com/textteaser/summarizer/KeywordService.scala",
"src/main/scala/com/textteaser/summarizer/Main.scala",
"src/main/scala/com/textteaser/summarizer/MongoKeywordService.scala",
"src/main/scala/com/textteaser/summarizer/SimpleREPL.sca... | [] | true | ||
MudBlazor/MudBlazor | 13,288 | issue_to_patch | MudTabs: Fix panel wrapper CSS parity across KeepPanelsAlive modes | `MudTabPanel` rendered different wrapper CSS depending on `KeepPanelsAlive`, even though both paths now use the same surrounding `<div>`. That broke layout scenarios such as flex-based `TabPanelsClass` styling because the non-keep-alive path omitted `display: contents`.
- **Behavior fix**
- Make the panel wrapper's ... | 0f332f841c52c85b3cfcda593a9294c7fe7f79d1 | 5535ba51aca7d7b707ce140480bc9aa19a30dde2 | diff --git a/src/MudBlazor.UnitTests/Components/TabsTests.cs b/src/MudBlazor.UnitTests/Components/TabsTests.cs
index b331e09325c3..a8450c6c6fdb 100644
--- a/src/MudBlazor.UnitTests/Components/TabsTests.cs
+++ b/src/MudBlazor.UnitTests/Components/TabsTests.cs
@@ -85,9 +85,9 @@ public async Task KeepTabsAlive()
... | [
"src/MudBlazor.UnitTests/Components/TabsTests.cs",
"src/MudBlazor/Components/Tabs/MudTabPanel.razor",
"src/MudBlazor/Components/Tabs/MudTabPanel.razor.cs",
"src/MudBlazor/Styles/components/_tabs.scss"
] | [] | true | ||
MudBlazor/MudBlazor | 13,284 | issue_to_patch | MudDatePicker: Selecting 31st day fails with input masking
### Things to check
- [x] I have searched the **existing issues** for this bug
- [x] To rule out a caching problem I made sure the bug also happens in an **incognito tab**
### Bug type
Component
### Component name
Datepicker
### What happened?
Hi,
The... | DateMask: Reset stale month/year state when inserting text | When the text of a DateMask was replaced (SetText -> Clear + Insert), the internal _month and _year fields still held values extracted from the previous text. The day digits of the new text were then validated against the old month:
- selecting the 31st after a 30-day month clamped the day to 30
- selecting Jan 31s... | b04d0e9cde2f8e10ddf947efa44870ee2e0bdc78 | a83c2cc0dbac86ee5b30acb44a257c1483aa2423 | diff --git a/src/MudBlazor.UnitTests/Utilities/Mask/DateMaskTests.cs b/src/MudBlazor.UnitTests/Utilities/Mask/DateMaskTests.cs
index 9159cf6c8ca1..97044586c8a8 100644
--- a/src/MudBlazor.UnitTests/Utilities/Mask/DateMaskTests.cs
+++ b/src/MudBlazor.UnitTests/Utilities/Mask/DateMaskTests.cs
@@ -325,6 +325,38 @@ public v... | [
"src/MudBlazor.UnitTests/Utilities/Mask/DateMaskTests.cs",
"src/MudBlazor/Utilities/MaskAlgorithms/DateMask.cs"
] | [] | true | |
MudBlazor/MudBlazor | 13,275 | issue_to_patch | Build: Update codecov/codecov-action action to v7 | This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [codecov/codecov-action](https://redirect.github.com/codecov/codecov-action) | action | major | `v6` β `v7` |
---
### Release Notes
<details>
<summary>codecov/codecov-action (codecov/codecov-action)</summary>
### [`v7.... | b04d0e9cde2f8e10ddf947efa44870ee2e0bdc78 | ea66bdc5e9fa17eb54579ba235896edc7b2e7ff4 | diff --git a/.github/workflows/build-test-mudblazor.yml b/.github/workflows/build-test-mudblazor.yml
index 586596fdebf8..2d3bb49cca0e 100644
--- a/.github/workflows/build-test-mudblazor.yml
+++ b/.github/workflows/build-test-mudblazor.yml
@@ -120,12 +120,12 @@ jobs:
uses: actions/download-artifact@v8
... | [
".github/workflows/build-test-mudblazor.yml"
] | [] | true | ||
MudBlazor/MudBlazor | 13,286 | issue_to_patch | Build: Update dotnet monorepo | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [Microsoft.AspNetCore.Components](https://asp.net/) ([source](https://redirect.github.com/dotnet/dotnet)) | `10.0.8` β ... | b04d0e9cde2f8e10ddf947efa44870ee2e0bdc78 | a9acd624e1ea57343f6bf55a23874acb9f69b427 | diff --git a/src/MudBlazor.Benchmarks/MudBlazor.Benchmarks.csproj b/src/MudBlazor.Benchmarks/MudBlazor.Benchmarks.csproj
index fb9a345aeab4..3c83ae2f4a7d 100644
--- a/src/MudBlazor.Benchmarks/MudBlazor.Benchmarks.csproj
+++ b/src/MudBlazor.Benchmarks/MudBlazor.Benchmarks.csproj
@@ -10,7 +10,7 @@
<ItemGroup>
<... | [
"src/MudBlazor.Benchmarks/MudBlazor.Benchmarks.csproj",
"src/MudBlazor.Docs.Wasm/MudBlazor.Docs.Wasm.csproj",
"src/MudBlazor.Docs.WasmHost/MudBlazor.Docs.WasmHost.csproj",
"src/MudBlazor.Docs/MudBlazor.Docs.csproj",
"src/MudBlazor.UnitTests.Shared/MudBlazor.UnitTests.Shared.csproj",
"src/MudBlazor.UnitTes... | [] | true | ||
MudBlazor/MudBlazor | 11,581 | issue_to_patch | MudTabs: Improve accessibility | fix(`MudTabs`): improve accessibility for keyboard interaction
- Makes tabs focusable using Arrow keys and responsive to Enter/Space keys
- Prevents key navigation into disabled tab content
- Aligns behaviour with accessibility standards (WCAG)
- Adds proper ARIA attributes for screen reader support
- Identify.C... | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor.UnitTests.Viewer/TestComponents/Tabs/TabsKeyboardAccessibilityTest.razor b/src/MudBlazor.UnitTests.Viewer/TestComponents/Tabs/TabsKeyboardAccessibilityTest.razor
new file mode 100644
index 000000000000..492d9c575e68
--- /dev/null
+++ b/src/MudBlazor.UnitTests.Viewer/TestComponents/Tabs/TabsKe... | [
"src/MudBlazor.UnitTests.Viewer/TestComponents/Tabs/TabsKeyboardAccessibilityTest.razor",
"src/MudBlazor.UnitTests.Viewer/TestComponents/Tabs/VerticalTabsKeyboardAccessibilityTest.razor",
"src/MudBlazor.UnitTests/Components/TabsTests.cs",
"src/MudBlazor/Components/Tabs/MudDynamicTabs.razor",
"src/MudBlazor/... | [
{
"comment": "Needs a class name and I'd imagine `display: contents` but...\n\nI'd love if someone with more knowledge of the tab component than me could answer why this wasn't inside a `div` before, or shouldn't have `@attributes=\"UserAttributes\" class=\"@Classname\" style=\"@Stylename\"` like the container ... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | Needs a class name and I'd imagine `display: contents` but...
I'd love if someone with more knowledge of the tab component than me could answer why this wasn't inside a `div` before, or shouldn't have `@attributes="UserAttributes" class="@Classname" style="@Stylename"` like the container above it? | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabPanel.razor b/src/MudBlazor/Components/Tabs/MudTabPanel.razor
index 9199fdc60ec7..422beae80dc7 100644
--- a/src/MudBlazor/Components/Tabs/MudTabPanel.razor
+++ b/src/MudBlazor/Components/Tabs/MudTabPanel.razor
@@ -4,7 +4,7 @@
@if (Parent?.KeepPanelsAlive == true)
{
-... | [
"src/MudBlazor/Components/Tabs/MudTabPanel.razor"
] | [
{
"comment": "Needs a class name and I'd imagine `display: contents` but...\n\nI'd love if someone with more knowledge of the tab component than me could answer why this wasn't inside a `div` before, or shouldn't have `@attributes=\"UserAttributes\" class=\"@Classname\" style=\"@Stylename\"` like the container ... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | In the non-`KeepPanelsAlive` branch, the original `@attributes`, `class` and `style` bindings were removed, which may break styling and custom attributes. Reinstate `@attributes`, `class` and `style` on the active-panel `<div>`. | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabPanel.razor b/src/MudBlazor/Components/Tabs/MudTabPanel.razor
index 9199fdc60ec7..422beae80dc7 100644
--- a/src/MudBlazor/Components/Tabs/MudTabPanel.razor
+++ b/src/MudBlazor/Components/Tabs/MudTabPanel.razor
@@ -4,7 +4,7 @@
@if (Parent?.KeepPanelsAlive == true)
{
-... | [
"src/MudBlazor/Components/Tabs/MudTabPanel.razor"
] | [
{
"comment": "In the non-`KeepPanelsAlive` branch, the original `@attributes`, `class` and `style` bindings were removed, which may break styling and custom attributes. Reinstate `@attributes`, `class` and `style` on the active-panel `<div>`.",
"path": "src/MudBlazor/Components/Tabs/MudTabPanel.razor",
... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | For full ARIA compliance, each `<div role="tab">` should have an `id` and `aria-controls` pointing to its corresponding tabpanel, and each `<div role="tabpanel">` should have `aria-labelledby`. Consider generating stable IDs for tabs and panels.
```suggestion
tabindex="@(panel.Disabled ? "-1" : ActivePanel == p... | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabs.razor b/src/MudBlazor/Components/Tabs/MudTabs.razor
index 6ee606e1c5c6..24b8ccb32ad0 100644
--- a/src/MudBlazor/Components/Tabs/MudTabs.razor
+++ b/src/MudBlazor/Components/Tabs/MudTabs.razor
@@ -4,7 +4,7 @@
<div @attributes="UserAttributes" class="@TabsClassnames" st... | [
"src/MudBlazor/Components/Tabs/MudTabs.razor"
] | [
{
"comment": "For full ARIA compliance, each `<div role=\"tab\">` should have an `id` and `aria-controls` pointing to its corresponding tabpanel, and each `<div role=\"tabpanel\">` should have `aria-labelledby`. Consider generating stable IDs for tabs and panels.\n```suggestion\n tabindex=\"@(panel.Disab... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | The `handled` flag is never used to suppress default browser behavior or stop propagation. Either remove this dead code or invoke the appropriate event-prevention logic. | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
index cdc8aa6af65d..127068cc1813 100644
--- a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
+++ b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
@@ -51,6 +51,9 @@ public partial class MudTabs : MudComponentBase... | [
"src/MudBlazor/Components/Tabs/MudTabs.razor.cs"
] | [
{
"comment": "The `handled` flag is never used to suppress default browser behavior or stop propagation. Either remove this dead code or invoke the appropriate event-prevention logic.",
"path": "src/MudBlazor/Components/Tabs/MudTabs.razor.cs",
"hunk": "@@ -1090,5 +1090,103 @@ internal void ItemUpdated(M... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | Did you verify the role="tablist" works properly in EnableDragandDrop mode? | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabs.razor b/src/MudBlazor/Components/Tabs/MudTabs.razor
index 6ee606e1c5c6..24b8ccb32ad0 100644
--- a/src/MudBlazor/Components/Tabs/MudTabs.razor
+++ b/src/MudBlazor/Components/Tabs/MudTabs.razor
@@ -4,7 +4,7 @@
<div @attributes="UserAttributes" class="@TabsClassnames" st... | [
"src/MudBlazor/Components/Tabs/MudTabs.razor"
] | [
{
"comment": "Did you verify the role=\"tablist\" works properly in EnableDragandDrop mode? ",
"path": "src/MudBlazor/Components/Tabs/MudTabs.razor",
"hunk": "@@ -21,9 +21,9 @@\n <div @ref=\"@_tabsContentSize\" class=\"mud-tabs-tabbar-content\">\n @if (EnableDragA... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | We have `Identifier.Create` API for this. | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
index cdc8aa6af65d..127068cc1813 100644
--- a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
+++ b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
@@ -51,6 +51,9 @@ public partial class MudTabs : MudComponentBase... | [
"src/MudBlazor/Components/Tabs/MudTabs.razor.cs"
] | [
{
"comment": "We have `Identifier.Create` API for this.",
"path": "src/MudBlazor/Components/Tabs/MudTabs.razor.cs",
"hunk": "@@ -452,6 +452,13 @@ public int ActivePanelIndex\n \n private string? _nextIcon;\n \n+ /// <summary>\n+ /// Unique identifier for this MudTabs component inst... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | I think I'd make this API and `GetPanelId` to be internal for now.
@igotinfected @danielchalmers Do we need at all the panel index information for the id `id="@..."`? Why can't we just return straight the `_componentId` which will be unique anyway, I don't think the index does much here. | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
index cdc8aa6af65d..127068cc1813 100644
--- a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
+++ b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
@@ -51,6 +51,9 @@ public partial class MudTabs : MudComponentBase... | [
"src/MudBlazor/Components/Tabs/MudTabs.razor.cs"
] | [
{
"comment": "I think I'd make this API and `GetPanelId` to be internal for now.\r\n@igotinfected @danielchalmers Do we need at all the panel index information for the id `id=\"@...\"`? Why can't we just return straight the `_componentId` which will be unique anyway, I don't think the index does much here.",
... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | I believe the previous `KeepPanelsAlive="true"` was correct? `KeepPanelsAlive="true"` keeps the panels alive, avoiding recreating them when switching between tabs | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor.UnitTests/Components/TabsTests.cs b/src/MudBlazor.UnitTests/Components/TabsTests.cs
index 11943a87e228..5990b06c1f19 100644
--- a/src/MudBlazor.UnitTests/Components/TabsTests.cs
+++ b/src/MudBlazor.UnitTests/Components/TabsTests.cs
@@ -1,6 +1,8 @@
ο»Ώusing System.Globalization;
+using System.R... | [
"src/MudBlazor.UnitTests/Components/TabsTests.cs"
] | [
{
"comment": "I believe the previous `KeepPanelsAlive=\"true\"` was correct? `KeepPanelsAlive=\"true\"` keeps the panels alive, avoiding recreating them when switching between tabs",
"path": "src/MudBlazor.UnitTests/Components/TabsTests.cs",
"hunk": "@@ -125,7 +126,7 @@ public void KeepTabsAliveTest()\n... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | Would add a test (or an some extra lines in the existing tests) triggering a tab selection with `Space` to protect against that breaking accidentally | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor.UnitTests/Components/TabsTests.cs b/src/MudBlazor.UnitTests/Components/TabsTests.cs
index 11943a87e228..5990b06c1f19 100644
--- a/src/MudBlazor.UnitTests/Components/TabsTests.cs
+++ b/src/MudBlazor.UnitTests/Components/TabsTests.cs
@@ -1,6 +1,8 @@
ο»Ώusing System.Globalization;
+using System.R... | [
"src/MudBlazor.UnitTests/Components/TabsTests.cs"
] | [
{
"comment": "Would add a test (or an some extra lines in the existing tests) triggering a tab selection with `Space` to protect against that breaking accidentally",
"path": "src/MudBlazor.UnitTests/Components/TabsTests.cs",
"hunk": "@@ -1478,5 +1485,83 @@ public void LabelSorting_CustomSortComparer()\n... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | Could create this once in constructor/oninitialized to avoid creating a new string object every time it's called | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
index cdc8aa6af65d..127068cc1813 100644
--- a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
+++ b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
@@ -51,6 +51,9 @@ public partial class MudTabs : MudComponentBase... | [
"src/MudBlazor/Components/Tabs/MudTabs.razor.cs"
] | [
{
"comment": "Could create this once in constructor/oninitialized to avoid creating a new string object every time it's called",
"path": "src/MudBlazor/Components/Tabs/MudTabs.razor.cs",
"hunk": "@@ -1090,5 +1097,119 @@ internal void ItemUpdated(MudItemDropInfo<MudTabPanel> dropItem)\n // Se... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | [nitpick] The removed blank line after `await base.OnAfterRenderAsync(firstRender);` appears to be an unintentional formatting change that doesn't relate to the accessibility improvements. Consider restoring the blank line for consistency with the existing code style.
```suggestion
await base.OnAfterRenderA... | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
index cdc8aa6af65d..127068cc1813 100644
--- a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
+++ b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
@@ -51,6 +51,9 @@ public partial class MudTabs : MudComponentBase... | [
"src/MudBlazor/Components/Tabs/MudTabs.razor.cs"
] | [
{
"comment": "[nitpick] The removed blank line after `await base.OnAfterRenderAsync(firstRender);` appears to be an unintentional formatting change that doesn't relate to the accessibility improvements. Consider restoring the blank line for consistency with the existing code style.\n```suggestion\n a... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | The comment says 'move to the next tab' but the method name and implementation move to the previous tab. The comment should be corrected to 'Allows the user to move to the previous tab using key arrow'.
```suggestion
/// Allows the user to move to the previous tab using key arrow
``` | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
index cdc8aa6af65d..127068cc1813 100644
--- a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
+++ b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
@@ -51,6 +51,9 @@ public partial class MudTabs : MudComponentBase... | [
"src/MudBlazor/Components/Tabs/MudTabs.razor.cs"
] | [
{
"comment": "The comment says 'move to the next tab' but the method name and implementation move to the previous tab. The comment should be corrected to 'Allows the user to move to the previous tab using key arrow'.\n```suggestion\n /// Allows the user to move to the previous tab using key arrow\n```",
... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | The comment says 'move to the previous tab' but the method name and implementation move to the next tab. The comment should be corrected to 'Allows the user to move to the next tab using key arrow'.
```suggestion
/// Allows the user to move to the next tab using keyarrow
``` | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
index cdc8aa6af65d..127068cc1813 100644
--- a/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
+++ b/src/MudBlazor/Components/Tabs/MudTabs.razor.cs
@@ -51,6 +51,9 @@ public partial class MudTabs : MudComponentBase... | [
"src/MudBlazor/Components/Tabs/MudTabs.razor.cs"
] | [
{
"comment": "The comment says 'move to the previous tab' but the method name and implementation move to the next tab. The comment should be corrected to 'Allows the user to move to the next tab using key arrow'.\n```suggestion\n /// Allows the user to move to the next tab using keyarrow\n```",
"path... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | [nitpick] Inconsistent indentation: this line uses tabs while the rest of the file uses spaces. Consider using consistent indentation throughout the file.
```suggestion
<div @attributes="UserAttributes" class="@Classname" style="@Stylename" role="tabpanel" id="@Parent.GetTabPanelId(this)" aria-labelledby="@Parent.G... | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabPanel.razor b/src/MudBlazor/Components/Tabs/MudTabPanel.razor
index 9199fdc60ec7..422beae80dc7 100644
--- a/src/MudBlazor/Components/Tabs/MudTabPanel.razor
+++ b/src/MudBlazor/Components/Tabs/MudTabPanel.razor
@@ -4,7 +4,7 @@
@if (Parent?.KeepPanelsAlive == true)
{
-... | [
"src/MudBlazor/Components/Tabs/MudTabPanel.razor"
] | [
{
"comment": "[nitpick] Inconsistent indentation: this line uses tabs while the rest of the file uses spaces. Consider using consistent indentation throughout the file.\n```suggestion\n <div @attributes=\"UserAttributes\" class=\"@Classname\" style=\"@Stylename\" role=\"tabpanel\" id=\"@Parent.GetTabPanelId(... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | [nitpick] Inconsistent indentation: this line uses tabs while the rest of the file uses spaces. Consider using consistent indentation throughout the file.
```suggestion
<div @attributes="UserAttributes" class="@Classname" style="@Stylename" role="tabpanel" id="@Parent.GetTabPanelId(this)" aria-labelledby="@Pare... | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudTabPanel.razor b/src/MudBlazor/Components/Tabs/MudTabPanel.razor
index 9199fdc60ec7..422beae80dc7 100644
--- a/src/MudBlazor/Components/Tabs/MudTabPanel.razor
+++ b/src/MudBlazor/Components/Tabs/MudTabPanel.razor
@@ -4,7 +4,7 @@
@if (Parent?.KeepPanelsAlive == true)
{
-... | [
"src/MudBlazor/Components/Tabs/MudTabPanel.razor"
] | [
{
"comment": "[nitpick] Inconsistent indentation: this line uses tabs while the rest of the file uses spaces. Consider using consistent indentation throughout the file.\n```suggestion\n <div @attributes=\"UserAttributes\" class=\"@Classname\" style=\"@Stylename\" role=\"tabpanel\" id=\"@Parent.GetTabPane... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | [nitpick] Inconsistent indentation: this line uses tabs while the rest of the file uses spaces. Consider using consistent indentation throughout the file.
```suggestion
@onkeydown="@(e => HandleTabKeyDownAsync(e, context))"/>
``` | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudDynamicTabs.razor b/src/MudBlazor/Components/Tabs/MudDynamicTabs.razor
index 7085a21656bb..55fc9fe7549e 100644
--- a/src/MudBlazor/Components/Tabs/MudDynamicTabs.razor
+++ b/src/MudBlazor/Components/Tabs/MudDynamicTabs.razor
@@ -29,7 +29,8 @@
<MudIc... | [
"src/MudBlazor/Components/Tabs/MudDynamicTabs.razor"
] | [
{
"comment": "[nitpick] Inconsistent indentation: this line uses tabs while the rest of the file uses spaces. Consider using consistent indentation throughout the file.\n```suggestion\n @onkeydown=\"@(e => HandleTabKeyDownAsync(e, context))\"/>\n```",
"path": "src/MudBl... | true | ||
MudBlazor/MudBlazor | 11,581 | comment_to_fix | MudTabs: Improve accessibility | [nitpick] Inconsistent indentation: this line uses tabs while the rest of the file uses spaces. Consider using consistent indentation throughout the file.
```suggestion
@onkeydown="@(e => HandleTabKeyDownAsync(e, context))"/>
``` | b9cffa9dc0b64309f337425fe6ad100060c3e047 | 9ba3dc2a5539c4114eb01a61e966757f5f295330 | diff --git a/src/MudBlazor/Components/Tabs/MudDynamicTabs.razor b/src/MudBlazor/Components/Tabs/MudDynamicTabs.razor
index 7085a21656bb..55fc9fe7549e 100644
--- a/src/MudBlazor/Components/Tabs/MudDynamicTabs.razor
+++ b/src/MudBlazor/Components/Tabs/MudDynamicTabs.razor
@@ -29,7 +29,8 @@
<MudIc... | [
"src/MudBlazor/Components/Tabs/MudDynamicTabs.razor"
] | [
{
"comment": "[nitpick] Inconsistent indentation: this line uses tabs while the rest of the file uses spaces. Consider using consistent indentation throughout the file.\n```suggestion\n @onkeydown=\"@(e => HandleTabKeyDownAsync(e, context))\"/>\n```",
"path": "src/MudBl... | true | ||
MudBlazor/MudBlazor | 13,115 | issue_to_patch | Docs: Add MessageBox reverse button order example | I have updated the documentation to reflect the recent configuration changes made to the MessageBox component, specifically regarding the reversal of button orders.
Changes made:
- MessageBox Docs: Added a new section at the bottom of the page explaining the change, including a code snippet showing users how to r... | b0319b7b84975ee4440723f128a92cd678c04778 | a396e0775bcdffbfe05809830679666b974b97ae | diff --git a/src/MudBlazor.Docs/Pages/Components/Dialog/Examples/DialogConfigurationExample.razor b/src/MudBlazor.Docs/Pages/Components/Dialog/Examples/DialogConfigurationExample.razor
index 081b097c4f47..24801be35a55 100644
--- a/src/MudBlazor.Docs/Pages/Components/Dialog/Examples/DialogConfigurationExample.razor
+++ ... | [
"src/MudBlazor.Docs/Pages/Components/Dialog/Examples/DialogConfigurationExample.razor",
"src/MudBlazor.Docs/Pages/Components/MessageBox/Examples/MessageBoxConfigurationExample.razor",
"src/MudBlazor.Docs/Pages/Components/MessageBox/MessageBoxPage.razor"
] | [] | true | ||
MudBlazor/MudBlazor | 13,069 | issue_to_patch | MudMessageBox: Add global ReverseMessageBoxButtonOrder option | Added the ability to reverse the order of the buttons on MudMessageBox via the DialogOptions.ReverseMessageBoxButtonOrder property. This was done specifically to support Windows environments where the default button order does not align with native OS guidelines.
Screenshots:
Default button order:
<img width="531"... | e4cf5fb3d6025e9fa6cd5faf67cdab5950f53460 | 0d0c24662360bf94e7b1881a9eaad4eae4475a01 | diff --git a/src/MudBlazor.UnitTests/Components/MessageBoxTests.cs b/src/MudBlazor.UnitTests/Components/MessageBoxTests.cs
index aa6f6d13e2f3..a0aefb04b1b7 100644
--- a/src/MudBlazor.UnitTests/Components/MessageBoxTests.cs
+++ b/src/MudBlazor.UnitTests/Components/MessageBoxTests.cs
@@ -357,5 +357,76 @@ await provider.I... | [
"src/MudBlazor.UnitTests/Components/MessageBoxTests.cs",
"src/MudBlazor/Components/Dialog/MudDialogProvider.razor.cs",
"src/MudBlazor/Components/MessageBox/MudMessageBox.razor",
"src/MudBlazor/Components/MessageBox/MudMessageBox.razor.cs"
] | [
{
"comment": "`ShowMessageBoxAsync(MessageBoxOptions, DialogOptions?)` currently ignores `options?.ReverseMessageBoxButtonOrder`. As a result, calling this overload with `new DialogOptions { ReverseMessageBoxButtonOrder = true }` will not reverse the order unless the caller also sets `messageBoxOptions.ReverseB... | true | ||
MudBlazor/MudBlazor | 13,069 | comment_to_fix | MudMessageBox: Add global ReverseMessageBoxButtonOrder option | Minor XML doc grammar: consider rephrasing to βIndicates whether the button order is reversed.β (current wording is awkward, and thereβs an extra leading space in the summary line).
```suggestion
/// Indicates whether the button order is reversed.
``` | e4cf5fb3d6025e9fa6cd5faf67cdab5950f53460 | 0d0c24662360bf94e7b1881a9eaad4eae4475a01 | diff --git a/src/MudBlazor/Components/MessageBox/MudMessageBox.razor.cs b/src/MudBlazor/Components/MessageBox/MudMessageBox.razor.cs
index d25a90dcaa1c..15a1f32f4c3b 100644
--- a/src/MudBlazor/Components/MessageBox/MudMessageBox.razor.cs
+++ b/src/MudBlazor/Components/MessageBox/MudMessageBox.razor.cs
@@ -32,6 +32,9 @@... | [
"src/MudBlazor/Components/MessageBox/MudMessageBox.razor.cs"
] | [
{
"comment": "Minor XML doc grammar: consider rephrasing to βIndicates whether the button order is reversed.β (current wording is awkward, and thereβs an extra leading space in the summary line).\n```suggestion\n /// Indicates whether the button order is reversed.\n```",
"path": "src/MudBlazor/Compon... | true | ||
MudBlazor/MudBlazor | 13,069 | comment_to_fix | MudMessageBox: Add global ReverseMessageBoxButtonOrder option | This test introduces nullable/flow issues: `Task<bool?> messageBoxTask = null;` will trigger nullable warnings (and may fail builds if warnings are treated as errors), and using `service?.ShowMessageBoxAsync(...)` can leave `messageBoxTask` null despite the preceding `service.Should().NotBe(null)` assertion. Align with... | e4cf5fb3d6025e9fa6cd5faf67cdab5950f53460 | 0d0c24662360bf94e7b1881a9eaad4eae4475a01 | diff --git a/src/MudBlazor.UnitTests/Components/MessageBoxTests.cs b/src/MudBlazor.UnitTests/Components/MessageBoxTests.cs
index aa6f6d13e2f3..a0aefb04b1b7 100644
--- a/src/MudBlazor.UnitTests/Components/MessageBoxTests.cs
+++ b/src/MudBlazor.UnitTests/Components/MessageBoxTests.cs
@@ -357,5 +357,76 @@ await provider.I... | [
"src/MudBlazor.UnitTests/Components/MessageBoxTests.cs"
] | [
{
"comment": "This test introduces nullable/flow issues: `Task<bool?> messageBoxTask = null;` will trigger nullable warnings (and may fail builds if warnings are treated as errors), and using `service?.ShowMessageBoxAsync(...)` can leave `messageBoxTask` null despite the preceding `service.Should().NotBe(null)`... | true | ||
MudBlazor/MudBlazor | 13,083 | issue_to_patch | Docs: Document Blazor CSS isolation limitations
### Issue type
- [x] Missing or incomplete documentation
- [ ] Incorrect information or broken code example
- [ ] Suggestion for improvement
[### Page or section affected](https://mudblazor.com/customization/overview)
Blazor CSS isolation does not work with MudBlazor ... | Docs: Add section on CSS isolation limitation | I've added a new section to the documentation specifically addressing the CSS isolation limitation.
I explained that this is a fundamental Blazor framework limitation rather than a MudBlazor-specific bug, and provided alternative styling methods for the user to try.
The new section is placed at the bottom of the ... | eac9ecba1dbca5799c9eade6849e2834b32ae7e8 | a70bcd8448fe163121d6111da056aa56f4e4362f | diff --git a/src/MudBlazor.Docs/Pages/Customization/Theming/Overview.razor b/src/MudBlazor.Docs/Pages/Customization/Theming/Overview.razor
index 1965dc0cee10..78897fc8a657 100644
--- a/src/MudBlazor.Docs/Pages/Customization/Theming/Overview.razor
+++ b/src/MudBlazor.Docs/Pages/Customization/Theming/Overview.razor
@@ -6... | [
"src/MudBlazor.Docs/Pages/Customization/Theming/Overview.razor"
] | [] | true | |
MudBlazor/MudBlazor | 13,264 | issue_to_patch | Tests: Make carousel tests deterministic | Removes blocking calls in carousel tests.
Changes:
- Injects a per-test FakeTimeProvider into CarouselTests and advances carousel timers deterministically.
- Replaces Task.Delay calls with fake-time advancement.
- Replaces WaitForAssertionAsync with direct assertions.
Part of #13188 | 2f0b009186dff754b2ea9a4bcb50a1da51ff77d4 | 14cb011136f9939f449ec375fb3965803529c313 | diff --git a/src/MudBlazor.UnitTests/Components/CarouselTests.cs b/src/MudBlazor.UnitTests/Components/CarouselTests.cs
index d2f312fa4946..2f380540a5a4 100644
--- a/src/MudBlazor.UnitTests/Components/CarouselTests.cs
+++ b/src/MudBlazor.UnitTests/Components/CarouselTests.cs
@@ -1,6 +1,7 @@
ο»Ώusing AwesomeAssertions;
u... | [
"src/MudBlazor.UnitTests/Components/CarouselTests.cs"
] | [
{
"comment": "Small suggestion: could we keep the fake time provider local to `Carousel_AutoCycle`? Keeping it in the test makes that dependency easier to see and avoids changing setup for the other carousel tests.",
"path": "src/MudBlazor.UnitTests/Components/CarouselTests.cs",
"hunk": "@@ -9,6 +10,14 ... | true | ||
MudBlazor/MudBlazor | 13,264 | comment_to_fix | Tests: Make carousel tests deterministic | Small suggestion: could we keep the fake time provider local to `Carousel_AutoCycle`? Keeping it in the test makes that dependency easier to see and avoids changing setup for the other carousel tests. | 2f0b009186dff754b2ea9a4bcb50a1da51ff77d4 | 14cb011136f9939f449ec375fb3965803529c313 | diff --git a/src/MudBlazor.UnitTests/Components/CarouselTests.cs b/src/MudBlazor.UnitTests/Components/CarouselTests.cs
index d2f312fa4946..2f380540a5a4 100644
--- a/src/MudBlazor.UnitTests/Components/CarouselTests.cs
+++ b/src/MudBlazor.UnitTests/Components/CarouselTests.cs
@@ -1,6 +1,7 @@
ο»Ώusing AwesomeAssertions;
u... | [
"src/MudBlazor.UnitTests/Components/CarouselTests.cs"
] | [
{
"comment": "Small suggestion: could we keep the fake time provider local to `Carousel_AutoCycle`? Keeping it in the test makes that dependency easier to see and avoids changing setup for the other carousel tests.",
"path": "src/MudBlazor.UnitTests/Components/CarouselTests.cs",
"hunk": "@@ -9,6 +10,14 ... | true | ||
MudBlazor/MudBlazor | 13,264 | comment_to_fix | Tests: Make carousel tests deterministic | I think we can advance fake time directly here instead of wrapping it in `InvokeAsync`.
The pattern we've fallen on is to advance fake time directly, then use bUnit only to observe the resulting render/update. For example:
```csharp
timeProvider.Advance(TimeSpan.FromMilliseconds(interval));
await comp.WaitForAsserti... | 2f0b009186dff754b2ea9a4bcb50a1da51ff77d4 | 14cb011136f9939f449ec375fb3965803529c313 | diff --git a/src/MudBlazor.UnitTests/Components/CarouselTests.cs b/src/MudBlazor.UnitTests/Components/CarouselTests.cs
index d2f312fa4946..2f380540a5a4 100644
--- a/src/MudBlazor.UnitTests/Components/CarouselTests.cs
+++ b/src/MudBlazor.UnitTests/Components/CarouselTests.cs
@@ -1,6 +1,7 @@
ο»Ώusing AwesomeAssertions;
u... | [
"src/MudBlazor.UnitTests/Components/CarouselTests.cs"
] | [
{
"comment": "I think we can advance fake time directly here instead of wrapping it in `InvokeAsync`.\n\nThe pattern we've fallen on is to advance fake time directly, then use bUnit only to observe the resulting render/update. For example:\n\n```csharp\ntimeProvider.Advance(TimeSpan.FromMilliseconds(interval));... | true | ||
MudBlazor/MudBlazor | 13,213 | issue_to_patch | The alert component is not right-aligned in RTL mode.
### Before reporting
- [x] I searched existing issues
- [x] I tried in private/incognito browser
### What went wrong?
<img width="1607" height="687" alt="Image" src="https://github.com/user-attachments/assets/7e5dee9d-27a0-4f66-b66d-8b243d28afb7" />
### Reprod... | MudAlert: Change default content alignment to Start | Closes #13210
The default ContentAlignment was breaking the content alignment of the MudAlert component when Right-to-Left mode was enabled.
The default value of HorizontalAlignment.Left would force the content to stick to the physical left side, which fights the browser's native document flow and doesn't make se... | b42512440e2ff74396f586f80daeebb29b2cfce8 | baf82773e27185ec3aa7eec6e245ac2c2c606c5f | diff --git a/src/MudBlazor.UnitTests/Components/AlertTests.cs b/src/MudBlazor.UnitTests/Components/AlertTests.cs
index 5faa525ad34b..9d7eafda1991 100644
--- a/src/MudBlazor.UnitTests/Components/AlertTests.cs
+++ b/src/MudBlazor.UnitTests/Components/AlertTests.cs
@@ -32,5 +32,20 @@ public async Task Alert_Click()
... | [
"src/MudBlazor.UnitTests/Components/AlertTests.cs",
"src/MudBlazor/Components/Alert/MudAlert.razor.cs"
] | [] | true | |
MudBlazor/MudBlazor | 13,119 | issue_to_patch | MudTabPanel: Add missing `BadgeMax` | `MudTabPanel` uses a `MudBadge` internally, but doesn't allow the user to provide a `Max` for the badge, only allows `BadgeData`, `BadgeIcon`, `BadgeDot` and `BadgeColor` to be specified.
This change adds a `BadgeMax` property that allows integer `BadgeData` values above the default badge max of 99 to be displayed u... | e246921cd29ad931cf51b360bcc903768dbffcf0 | 884b90e773fb6627026862be4ad3f39e34732183 | diff --git a/src/MudBlazor.Docs/Pages/Components/Tabs/Examples/TabsWithBagdesExample.razor b/src/MudBlazor.Docs/Pages/Components/Tabs/Examples/TabsWithBagdesExample.razor
index b862d509e1ea..58d72da25f96 100644
--- a/src/MudBlazor.Docs/Pages/Components/Tabs/Examples/TabsWithBagdesExample.razor
+++ b/src/MudBlazor.Docs/... | [
"src/MudBlazor.Docs/Pages/Components/Tabs/Examples/TabsWithBagdesExample.razor",
"src/MudBlazor.UnitTests/Components/TabsTests.cs",
"src/MudBlazor/Components/Tabs/MudTabPanel.razor.cs",
"src/MudBlazor/Components/Tabs/MudTabs.razor"
] | [
{
"comment": "In Razor markup, `BadgeData=\"128\"` will be passed as a string to `BadgeData` (which is `object?`), so the badge max logic for integer values wonβt be exercised. To demonstrate/enable `BadgeMax`, pass an actual `int` (e.g., `BadgeData=\"@128\"` / `BadgeData=\"@(128)\"`).\n```suggestion\n <MudT... | true | ||
MudBlazor/MudBlazor | 13,119 | comment_to_fix | MudTabPanel: Add missing `BadgeMax` | In Razor markup, `BadgeData="128"` will be passed as a string to `BadgeData` (which is `object?`), so the badge max logic for integer values wonβt be exercised. To demonstrate/enable `BadgeMax`, pass an actual `int` (e.g., `BadgeData="@128"` / `BadgeData="@(128)"`).
```suggestion
<MudTabPanel Icon="@Icons.Material.... | e246921cd29ad931cf51b360bcc903768dbffcf0 | 884b90e773fb6627026862be4ad3f39e34732183 | diff --git a/src/MudBlazor.Docs/Pages/Components/Tabs/Examples/TabsWithBagdesExample.razor b/src/MudBlazor.Docs/Pages/Components/Tabs/Examples/TabsWithBagdesExample.razor
index b862d509e1ea..58d72da25f96 100644
--- a/src/MudBlazor.Docs/Pages/Components/Tabs/Examples/TabsWithBagdesExample.razor
+++ b/src/MudBlazor.Docs/... | [
"src/MudBlazor.Docs/Pages/Components/Tabs/Examples/TabsWithBagdesExample.razor"
] | [
{
"comment": "In Razor markup, `BadgeData=\"128\"` will be passed as a string to `BadgeData` (which is `object?`), so the badge max logic for integer values wonβt be exercised. To demonstrate/enable `BadgeMax`, pass an actual `int` (e.g., `BadgeData=\"@128\"` / `BadgeData=\"@(128)\"`).\n```suggestion\n <MudT... | true | ||
MudBlazor/MudBlazor | 13,249 | issue_to_patch | MudDataGrid: Focus selected filter when opening simple filter panel | **Description**
- When a user clicks into a column filter or selects it via keyboard commands, the focus automatically adjusts to the filter popover.
- Previously, selecting a column filter would not change the focus and tabbing over would only select the background items.
<!-- If you made any visual changes, p... | 2edafc11c8b8d9d03ae67f6c6d6905bfb576d25c | 658f4eec705b470034271b7e603da35d718147cd | diff --git a/src/MudBlazor.UnitTests/Components/DataGridTests.cs b/src/MudBlazor.UnitTests/Components/DataGridTests.cs
index 948ab7ca4470..30f188fb4302 100644
--- a/src/MudBlazor.UnitTests/Components/DataGridTests.cs
+++ b/src/MudBlazor.UnitTests/Components/DataGridTests.cs
@@ -2979,6 +2979,54 @@ public async Task Data... | [
"src/MudBlazor.UnitTests/Components/DataGridTests.cs",
"src/MudBlazor/Components/DataGrid/HeaderCell.razor",
"src/MudBlazor/Components/DataGrid/HeaderCell.razor.cs",
"src/MudBlazor/Components/DataGrid/MudDataGrid.razor",
"src/MudBlazor/Components/DataGrid/MudDataGrid.razor.cs"
] | [
{
"comment": "Changing the public `OpenFilters()` method signature to `OpenFilters(Guid? = null)` removes the zero-argument method at the binary level, so existing compiled consumers can hit `MissingMethodException`. We should keep `public void OpenFilters()` and add a separate internal/helper overload for focu... | true | ||
MudBlazor/MudBlazor | 13,249 | comment_to_fix | MudDataGrid: Focus selected filter when opening simple filter panel | Codex flagged this. What do you think?
> This verifies that `AutoFocus` is set on the expected `MudSelect`, but it does not verify that focus actually moves. That matters here because `MudBaseInput` only calls `FocusAsync()` for `AutoFocus` during first render, so a parameter assertion can pass while the user-visible ... | 2edafc11c8b8d9d03ae67f6c6d6905bfb576d25c | 658f4eec705b470034271b7e603da35d718147cd | diff --git a/src/MudBlazor.UnitTests/Components/DataGridTests.cs b/src/MudBlazor.UnitTests/Components/DataGridTests.cs
index 948ab7ca4470..30f188fb4302 100644
--- a/src/MudBlazor.UnitTests/Components/DataGridTests.cs
+++ b/src/MudBlazor.UnitTests/Components/DataGridTests.cs
@@ -2979,6 +2979,54 @@ public async Task Data... | [
"src/MudBlazor.UnitTests/Components/DataGridTests.cs"
] | [
{
"comment": "Codex flagged this. What do you think?\n\n> This verifies that `AutoFocus` is set on the expected `MudSelect`, but it does not verify that focus actually moves. That matters here because `MudBaseInput` only calls `FocusAsync()` for `AutoFocus` during first render, so a parameter assertion can pass... | true | ||
MudBlazor/MudBlazor | 13,269 | issue_to_patch | MudDataGrid.Culture documented default does not match the implementation
### Issue type
- [ ] Missing or incomplete documentation
- [x] Incorrect information or broken code example
- [ ] Suggestion for improvement
### Page or section affected
[MudDataGrid](https://mudblazor.com/api/muddatagrid)
### Description
T... | Docs: Clarify DataGrid culture default docs | Clarifies the documented default behavior for `MudDataGrid.Culture` and column-level culture fallback.
The previous XML/API docs said `MudDataGrid.Culture` defaults to `CultureInfo.InvariantCulture`, but the implementation leaves the parameter unset. In that case, cell formatting follows .NET's default formatting beha... | 778ae3474f3a7c770061cd40bea1789c7c9f96fe | 12321311da67f41c0dbc4a59e8ac9269bdbd13ee | diff --git a/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor b/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor
index c0f25c9b3a8c..b054f790b30e 100644
--- a/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor
+++ b/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.raz... | [
"src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor",
"src/MudBlazor/Components/DataGrid/Column.razor.cs",
"src/MudBlazor/Components/DataGrid/MudDataGrid.razor.cs"
] | [] | true | |
MudBlazor/MudBlazor | 13,267 | issue_to_patch | Rating control still applies hover CSS when ReadOnly=true
### Before reporting
- [x] I searched existing issues
- [x] I tried in private/incognito browser
### What went wrong?
The rating/star control has a setting `ReadOnly=true`, which removes all interactions with the control.
However, if you mouse-over the sta... | MudRating: Skip hover effects when ReadOnly or Disabled | Fixes #13265 β Rating hover CSS applies even when ReadOnly=true.
Added ReadOnly/Disabled early-return to HandleItemHoveredAsync.
Before:
```csharp
internal Task HandleItemHoveredAsync(int? itemValue) => SetHoveredValueAsync(itemValue);
```
After:
```csharp
internal Task HandleItemHoveredAsync(int? itemValue)
{
if... | af85684e18e83170064cb0585c098b743d51ced3 | d345ac8d9cee378bf1a88a4ef18d60273748eb43 | diff --git a/src/MudBlazor/Components/Rating/MudRating.razor.cs b/src/MudBlazor/Components/Rating/MudRating.razor.cs
index 38337958ed22..e9f6f99b78f7 100644
--- a/src/MudBlazor/Components/Rating/MudRating.razor.cs
+++ b/src/MudBlazor/Components/Rating/MudRating.razor.cs
@@ -219,7 +219,15 @@ private async Task HandleIte... | [
"src/MudBlazor/Components/Rating/MudRating.razor.cs"
] | [] | true | |
MudBlazor/MudBlazor | 13,262 | issue_to_patch | Tests: Enable parallel autocomplete and select tests | Enables the autocomplete and select unit tests to run under the fixture-level parallelization already configured for the test assembly.
Changes
- Removed the remaining `NonParallelizable` annotations from `AutocompleteTests` and `Select_KeyDown_WhileClosed`.
- Replaced sleep-based waits in the affected autocompl... | 2f0b009186dff754b2ea9a4bcb50a1da51ff77d4 | 78f7a079fd139b75ed5fd44d1791f9a034c26e71 | diff --git a/src/MudBlazor.UnitTests/Components/AutocompleteTests.cs b/src/MudBlazor.UnitTests/Components/AutocompleteTests.cs
index 9d86a009f577..63904cf059dc 100644
--- a/src/MudBlazor.UnitTests/Components/AutocompleteTests.cs
+++ b/src/MudBlazor.UnitTests/Components/AutocompleteTests.cs
@@ -19,7 +19,6 @@
namespace ... | [
"src/MudBlazor.UnitTests/Components/AutocompleteTests.cs",
"src/MudBlazor.UnitTests/Components/SelectTests.cs"
] | [] | true | ||
MudBlazor/MudBlazor | 13,240 | issue_to_patch | Make MudTableSortLabel clickable across the full header width
### Describe your idea
Coming from alternative JS based table libraries, each column header tends to be clickable across the whole width of the header cell rather than just the content in the cell.
Keeping in line with parameters on other MudBlazor compon... | MudTableSortLabel: Add FullWidth parameter | Adds a FullWidth parameter to MudTableSortLabel so the clickable sort label can fill the available table header width.
Fixes #11814
Tested with:
- dotnet test --project src/MudBlazor.UnitTests/MudBlazor.UnitTests.csproj --no-restore /p:SkipBunCompile=true -- --filter FullyQualifiedName~TableSortLabel --output Normal ... | fc6a9916d413339eefac69c740c45b33d8aebf5c | 83a0e1b9c0fccca4b705a96e5a98f2430506fe69 | diff --git a/src/MudBlazor.Docs/Pages/Components/Table/Examples/TableSortingExample.razor b/src/MudBlazor.Docs/Pages/Components/Table/Examples/TableSortingExample.razor
index 9278c95196d6..b4acc54c8d09 100644
--- a/src/MudBlazor.Docs/Pages/Components/Table/Examples/TableSortingExample.razor
+++ b/src/MudBlazor.Docs/Pag... | [
"src/MudBlazor.Docs/Pages/Components/Table/Examples/TableSortingExample.razor",
"src/MudBlazor.Docs/Pages/Components/Table/TablePage.razor",
"src/MudBlazor.UnitTests/Components/TableTests.cs",
"src/MudBlazor/Components/Table/MudTableSortLabel.razor.cs",
"src/MudBlazor/Styles/components/_table.scss"
] | [
{
"comment": "This inline style can be moved to `src/MudBlazor/Styles/components/_table.scss` by adding a class name to the CSS builder instead, e.g. `mud-table-sort-label-full-width`.",
"path": "src/MudBlazor/Components/Table/MudTableSortLabel.razor.cs",
"hunk": "@@ -26,6 +26,12 @@ public partial class... | true | |
MudBlazor/MudBlazor | 13,240 | comment_to_fix | MudTableSortLabel: Add FullWidth parameter | There could also be a test that asserts the class is not there if FullWidth is not set to `true`. | fc6a9916d413339eefac69c740c45b33d8aebf5c | 83a0e1b9c0fccca4b705a96e5a98f2430506fe69 | diff --git a/src/MudBlazor.UnitTests/Components/TableTests.cs b/src/MudBlazor.UnitTests/Components/TableTests.cs
index a0a17bce5177..467f58685aab 100644
--- a/src/MudBlazor.UnitTests/Components/TableTests.cs
+++ b/src/MudBlazor.UnitTests/Components/TableTests.cs
@@ -2854,6 +2854,24 @@ public void TableSortLabelDirectio... | [
"src/MudBlazor.UnitTests/Components/TableTests.cs"
] | [
{
"comment": "There could also be a test that asserts the class is not there if FullWidth is not set to `true`.",
"path": "src/MudBlazor.UnitTests/Components/TableTests.cs",
"hunk": "@@ -2854,6 +2854,16 @@ public void TableSortLabelDirectionClasses(SortDirection direction)\n icon.ClassList.C... | true | ||
MudBlazor/MudBlazor | 13,263 | issue_to_patch | MudTextField: Adjust max-width of input label for Text variant | For MudTextField the input label width for the variants Outlined and Filled were 100% but for the variant Text it was only 75%.
This fixes one point of #12499
<!-- Describe your changes and what the purpose of them is. -->
Screenshot before:
<img width="318" height="286" alt="grafik" src="https://github.com/user... | 2f0b009186dff754b2ea9a4bcb50a1da51ff77d4 | 6dbcf67195da2b1a00e2d617b6aa2452ae720186 | diff --git a/src/MudBlazor/Styles/components/_inputlabel.scss b/src/MudBlazor/Styles/components/_inputlabel.scss
index fb3e250f4ede..f6b0025b65ed 100644
--- a/src/MudBlazor/Styles/components/_inputlabel.scss
+++ b/src/MudBlazor/Styles/components/_inputlabel.scss
@@ -65,6 +65,7 @@ label.mud-input-label.mud-input-label-i... | [
"src/MudBlazor/Styles/components/_inputlabel.scss"
] | [] | true | ||
MudBlazor/MudBlazor | 13,261 | issue_to_patch | Tests: Enable parallel snackbar tests |
Enables snackbar component tests to run in parallel by removing the class-level `[NonParallelizable]` marker and eliminating wall-clock timing dependencies in the snackbar test paths.
Changes
- Injects a per-test `FakeTimeProvider` into `SnackbarTests` and advances snackbar timers deterministically.
- Replaces... | b9c4c87e873310e1283b873cd8b0fbf0ebba5449 | b6bd0c260ae521b8459dc296a3a274eba2d6b388 | diff --git a/src/MudBlazor.UnitTests.Viewer/TestComponents/Snackbar/SnackbarCustomActionOnCloseTest.razor b/src/MudBlazor.UnitTests.Viewer/TestComponents/Snackbar/SnackbarCustomActionOnCloseTest.razor
index bf9191b80a54..e541cde362da 100644
--- a/src/MudBlazor.UnitTests.Viewer/TestComponents/Snackbar/SnackbarCustomActi... | [
"src/MudBlazor.UnitTests.Viewer/TestComponents/Snackbar/SnackbarCustomActionOnCloseTest.razor",
"src/MudBlazor.UnitTests/Components/SnackbarTests.cs"
] | [] | true | ||
MudBlazor/MudBlazor | 13,230 | issue_to_patch | MudDataGrid: Loading indicator not working on mobile
### Before reporting
- [x] I searched existing issues
- [x] I tried in private/incognito browser
### What went wrong?
The loading indicator for a DataGrid does not work on mobile.
### Reproduction link
https://mudblazor.com/components/datagrid#other-options
##... | MudDataGrid: Fix mobile loading indicator | Fixes #12091
The mobile table layout hides the normal header rows, but a fixed-header DataGrid still inherited the desktop sticky header offset for the loading row. That left the progress bar stuck 59px below the top of the hidden header and visually overlapping the first mobile data row.
This scopes the override to ... | 74b1db3d94f10b8640eb6db498dba075178d9948 | 30e031347fda03a41d1f21161a986c9075b203dc | diff --git a/src/MudBlazor/Styles/components/_datagrid.scss b/src/MudBlazor/Styles/components/_datagrid.scss
index 6ea9a6523465..1c297eac14f2 100644
--- a/src/MudBlazor/Styles/components/_datagrid.scss
+++ b/src/MudBlazor/Styles/components/_datagrid.scss
@@ -166,6 +166,35 @@
}
}
+@mixin datagrid-loading-display-s... | [
"src/MudBlazor/Styles/components/_datagrid.scss"
] | [] | true | |
MudBlazor/MudBlazor | 13,101 | issue_to_patch | MudDataGrid: Focus column filter text field directly and enable execution by pressing Enter
### Describe your idea
I currently exclusively use DataGridFilterMode.ColumnFilterMenu and I use it very often. 95% of the time I am using the Contains filter which is the default so I want the focus to go directly into the t... | MudDataGrid: Autofocus ColumnFilterMenu value input and support Enter/Escape keyboard actions | `DataGridFilterMode.ColumnFilterMenu` required extra clicks: opening a column filter did not place focus in the value field, and keyboard actions did not cover both popup buttons. This PR streamlines that keyboard flow to match expected filter-menu behavior.
- **Column filter popup keyboard flow**
- Added autofocus ... | 426b755aab24d236a32ed04f22124911e1e4eb15 | 3769a4392c3d289b61b5a6f2b784331ccbcd61a7 | diff --git a/src/MudBlazor.UnitTests/Components/DataGridTests.cs b/src/MudBlazor.UnitTests/Components/DataGridTests.cs
index 5b00b896b39d..0dcc4660d912 100644
--- a/src/MudBlazor.UnitTests/Components/DataGridTests.cs
+++ b/src/MudBlazor.UnitTests/Components/DataGridTests.cs
@@ -3903,6 +3903,41 @@ await comp.InvokeAsync... | [
"src/MudBlazor.UnitTests/Components/DataGridTests.cs",
"src/MudBlazor/Components/DataGrid/MudDataGrid.razor",
"src/MudBlazor/Components/DataGrid/MudDataGrid.razor.cs"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.