repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
MudBlazor/MudBlazor | 13,137 | issue_to_patch | MudHotkey doesnโt fire on numpad enter
### Before reporting
- [x] I searched existing issues
- [x] I tried in private/incognito browser
### What went wrong?
JsKey enum is missing NumpadEnter (KeyboardEvent.code).
This prevents MudHotkey from detecting numpad Enter.
Suggested addition:
NumpadEnter = 109
### Repro... | MudHotkey: Add missing standard numpad JsKey codes | `MudHotkey` matches browser `KeyboardEvent.code` values, but `JsKey` did not expose several standard numpad codes. That prevented hotkeys from being registered for numpad-specific keys such as numpad Enter.
- **Problem**
- `JsKey` was missing standard numpad `code` values used by browsers.
- `MudHotkey` could not ... | 72e19fa982966aa0ca566a60af61dbd6a9ae0c29 | 148651c7bf2d0510de908d7c177a8aabd3f9a757 | diff --git a/src/MudBlazor/Utilities/JsKey.cs b/src/MudBlazor/Utilities/JsKey.cs
index b50cefcac296..789f0ea5b0d4 100644
--- a/src/MudBlazor/Utilities/JsKey.cs
+++ b/src/MudBlazor/Utilities/JsKey.cs
@@ -113,5 +113,8 @@ public enum JsKey
BracketLeft,
Backslash,
BracketRight,
- Quote
+ Quote,
+ Nu... | [
"src/MudBlazor/Utilities/JsKey.cs"
] | [] | true | |
MudBlazor/MudBlazor | 13,248 | issue_to_patch | Build: Update dependency Microsoft.NET.Test.Sdk to 18.6.0 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [Microsoft.NET.Test.Sdk](https://redirect.github.com/microsoft/vstest) | `18.5.1` โ `18.6.0` | ![age](https://developer... | 3b35720976db97daa0d9191c016d3490e062dcd7 | 984a30c4003f823595be666a7edba00133a3d48c | diff --git a/src/MudBlazor.UnitTests.Analyzers/MudBlazor.UnitTests.Analyzers.csproj b/src/MudBlazor.UnitTests.Analyzers/MudBlazor.UnitTests.Analyzers.csproj
index 504fbeb6527b..c13b4698066f 100644
--- a/src/MudBlazor.UnitTests.Analyzers/MudBlazor.UnitTests.Analyzers.csproj
+++ b/src/MudBlazor.UnitTests.Analyzers/MudBla... | [
"src/MudBlazor.UnitTests.Analyzers/MudBlazor.UnitTests.Analyzers.csproj",
"src/MudBlazor.UnitTests.Docs/MudBlazor.UnitTests.Docs.csproj",
"src/MudBlazor.UnitTests/MudBlazor.UnitTests.csproj"
] | [] | true | ||
MudBlazor/MudBlazor | 13,190 | issue_to_patch | MudPopover: Time-testability hooks scoped to popover and batch queue | This narrows the change to the two places that already own time in production: popover state and the batch periodic queue. Date picker changes were removed, and the batch queue now exposes a dedicated `TimeProvider` overload instead of using an optional parameter.
- **Scope reduction**
- Reverted all date picker and... | 58346779fb1016b9dd79e3e6d7944d7da39406ed | 751141b0bcf608d94b61332bf2a10f1903690f67 | diff --git a/src/MudBlazor.UnitTests/Services/Popover/PopoverServiceTests.cs b/src/MudBlazor.UnitTests/Services/Popover/PopoverServiceTests.cs
index 378bf76869f3..16b85ea699de 100644
--- a/src/MudBlazor.UnitTests/Services/Popover/PopoverServiceTests.cs
+++ b/src/MudBlazor.UnitTests/Services/Popover/PopoverServiceTests.... | [
"src/MudBlazor.UnitTests/Services/Popover/PopoverServiceTests.cs",
"src/MudBlazor.UnitTests/Utilities/Background/BatchPeriodicQueueTests.cs",
"src/MudBlazor/Services/Popover/MudPopoverHolder.cs",
"src/MudBlazor/Utilities/Background/Batch/BatchPeriodicQueue.cs"
] | [] | true | ||
MudBlazor/MudBlazor | 13,122 | issue_to_patch | Rotated X Axis Labels overlapping bars
### Before reporting
- [x] I searched existing issues
- [x] I tried in private/incognito browser
### What went wrong?
After updating to the current version rotated x axis labels on a bar chart now overlaps the bars
<img width="1023" height="576" alt="Image" src="https://githu... | MudChart: Fix x-axis rotation overlap | Closes #12902
Fixes x-axis label rotation overlapping chart at 90 degrees.
Before
<img width="1023" height="576" alt="image" src="https://github.com/user-attachments/assets/2fbb7f85-19bf-4dee-993c-829189d1df31" />
After
<img width="1654" height="940" alt="image" src="https://github.com/user-attachments/asse... | d0e1bf0d454ca8c6ee6f20a82a002897f8d710e5 | 2905a974aa02d878356f468ca92bb9c26608cfcc | diff --git a/src/MudBlazor.Docs/Pages/Components/Charts/Examples/BarExample1.razor b/src/MudBlazor.Docs/Pages/Components/Charts/Examples/BarExample1.razor
index aaf73cf4c685..231807e402c6 100644
--- a/src/MudBlazor.Docs/Pages/Components/Charts/Examples/BarExample1.razor
+++ b/src/MudBlazor.Docs/Pages/Components/Charts/... | [
"src/MudBlazor.Docs/Pages/Components/Charts/Examples/BarExample1.razor",
"src/MudBlazor.UnitTests/Components/Charts/BarChartTests.cs",
"src/MudBlazor.UnitTests/Components/Charts/TimeSeriesChartTests.cs",
"src/MudBlazor/Components/Chart/Base/BaseAxisChart.razor",
"src/MudBlazor/Components/Chart/Base/BaseAxis... | [
{
"comment": "The X-axis label is rendered via `MarkupString` with `verticalLineValue.Value` interpolated directly into SVG markup. Since `verticalLineValue.Value` ultimately comes from `ChartLabels` (user-provided strings), this can allow SVG/HTML injection (e.g., `<script>` or `<a onload=...>`). Prefer render... | true | |
MudBlazor/MudBlazor | 13,122 | comment_to_fix | MudChart: Fix x-axis rotation overlap | The X-axis label is rendered via `MarkupString` with `verticalLineValue.Value` interpolated directly into SVG markup. Since `verticalLineValue.Value` ultimately comes from `ChartLabels` (user-provided strings), this can allow SVG/HTML injection (e.g., `<script>` or `<a onload=...>`). Prefer rendering the `<text>` eleme... | d0e1bf0d454ca8c6ee6f20a82a002897f8d710e5 | 2905a974aa02d878356f468ca92bb9c26608cfcc | diff --git a/src/MudBlazor/Components/Chart/Base/BaseAxisChart.razor b/src/MudBlazor/Components/Chart/Base/BaseAxisChart.razor
index 55785d8e5310..854f4c300b86 100644
--- a/src/MudBlazor/Components/Chart/Base/BaseAxisChart.razor
+++ b/src/MudBlazor/Components/Chart/Base/BaseAxisChart.razor
@@ -54,8 +54,10 @@
... | [
"src/MudBlazor/Components/Chart/Base/BaseAxisChart.razor"
] | [
{
"comment": "The X-axis label is rendered via `MarkupString` with `verticalLineValue.Value` interpolated directly into SVG markup. Since `verticalLineValue.Value` ultimately comes from `ChartLabels` (user-provided strings), this can allow SVG/HTML injection (e.g., `<script>` or `<a onload=...>`). Prefer render... | true | ||
MudBlazor/MudBlazor | 13,122 | comment_to_fix | MudChart: Fix x-axis rotation overlap | This PR fixes rotated X-axis label layout, but there is no unit test that asserts the new behavior for `XAxisLabelRotation` (e.g., 90ยฐ) such as the expected `text-anchor` change and the increased bottom padding/label offset. Adding a focused chart markup test for a bar chart (or BaseAxisChart) with `XAxisLabelRotation ... | d0e1bf0d454ca8c6ee6f20a82a002897f8d710e5 | 2905a974aa02d878356f468ca92bb9c26608cfcc | diff --git a/src/MudBlazor/Components/Chart/Base/BaseAxisChart.razor b/src/MudBlazor/Components/Chart/Base/BaseAxisChart.razor
index 55785d8e5310..854f4c300b86 100644
--- a/src/MudBlazor/Components/Chart/Base/BaseAxisChart.razor
+++ b/src/MudBlazor/Components/Chart/Base/BaseAxisChart.razor
@@ -54,8 +54,10 @@
... | [
"src/MudBlazor/Components/Chart/Base/BaseAxisChart.razor"
] | [
{
"comment": "This PR fixes rotated X-axis label layout, but there is no unit test that asserts the new behavior for `XAxisLabelRotation` (e.g., 90ยฐ) such as the expected `text-anchor` change and the increased bottom padding/label offset. Adding a focused chart markup test for a bar chart (or BaseAxisChart) wit... | true | ||
MudBlazor/MudBlazor | 13,122 | comment_to_fix | MudChart: Fix x-axis rotation overlap | `TimeSeriesChartRendersWithIntData` now asserts only the opening `<path ...>` tag (it no longer includes the closing `</path>` like the other test). This weakens the assertion and could allow unintended markup changes to slip through. Consider making this expectation consistent with the other test by asserting the comp... | d0e1bf0d454ca8c6ee6f20a82a002897f8d710e5 | 2905a974aa02d878356f468ca92bb9c26608cfcc | diff --git a/src/MudBlazor.UnitTests/Components/Charts/TimeSeriesChartTests.cs b/src/MudBlazor.UnitTests/Components/Charts/TimeSeriesChartTests.cs
index e1acf6bd59da..eb4074515e1f 100644
--- a/src/MudBlazor.UnitTests/Components/Charts/TimeSeriesChartTests.cs
+++ b/src/MudBlazor.UnitTests/Components/Charts/TimeSeriesCha... | [
"src/MudBlazor.UnitTests/Components/Charts/TimeSeriesChartTests.cs"
] | [
{
"comment": "`TimeSeriesChartRendersWithIntData` now asserts only the opening `<path ...>` tag (it no longer includes the closing `</path>` like the other test). This weakens the assertion and could allow unintended markup changes to slip through. Consider making this expectation consistent with the other test... | true | ||
MudBlazor/MudBlazor | 13,247 | issue_to_patch | Docs: Removed sponsor | <!-- Describe your changes and what the purpose of them is. -->
<!-- If you made any visual changes, provide screenshots of before/after. If it has moving parts, please attach a high-quality video. -->
Removed blackhawk as sponsor from docs since they cancelled from May 8, 2026
**Checklist:**
<!-- If you're uns... | 615351cd851592dc4c3cb5f25b0c8ed7ac12d8cf | 1b440a8d19f3246ab76dfeedc2d1080c2838700a | diff --git a/src/MudBlazor.Docs/Pages/Index.razor b/src/MudBlazor.Docs/Pages/Index.razor
index 603610fdd1e1..13ccb23f7405 100644
--- a/src/MudBlazor.Docs/Pages/Index.razor
+++ b/src/MudBlazor.Docs/Pages/Index.razor
@@ -43,9 +43,6 @@
The continued development and maintenance of MudBlazor is secured by our spons... | [
"src/MudBlazor.Docs/Pages/Index.razor",
"src/MudBlazor.Docs/Pages/Mud/Project/Sponsors.razor",
"src/MudBlazor.Docs/wwwroot/images/sponsors/blackhawk.png"
] | [] | true | ||
MudBlazor/MudBlazor | 13,245 | issue_to_patch | Build: Optimize AutoTriage prompt structure for harness | ## Summary
This PR restructures `.github/AutoTriage.prompt` so the whole-file prompt is easier for Gemini to navigate without changing the substance of the triage policy.
The changes are intentionally limited to:
- adding a short `Prompt Map` at the top
- numbering the major policy areas
- grouping `good first issue`... | 5f038e91f1636c05e16ef036d77bf1688d74a0ce | 7ab54e54437a04722c50d6fd8a50f805f8b3f0f7 | diff --git a/.github/AutoTriage.prompt b/.github/AutoTriage.prompt
index 894876fa9fde..571f1e5db51f 100644
--- a/.github/AutoTriage.prompt
+++ b/.github/AutoTriage.prompt
@@ -1,6 +1,15 @@
-# MudBot Assistant Behavior Policy
+# MudBot AutoTriage Policy
-## General Guidelines
+## Prompt Map
+This file is read in full b... | [
".github/AutoTriage.prompt"
] | [] | true | ||
MudBlazor/MudBlazor | 13,243 | issue_to_patch | Build: Update code-analysis monorepo to 1.1.4 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [Microsoft.CodeAnalysis.Analyzer.Testing](https://redirect.github.com/dotnet/roslyn-sdk) | `1.1.3` โ `1.1.4` | ![age](h... | 50b985c56f49b632745d1d94972b40329bc1e74c | 5290784343b7f25f509a387415e634c6bdf4361e | diff --git a/src/MudBlazor.UnitTests.Analyzers/MudBlazor.UnitTests.Analyzers.csproj b/src/MudBlazor.UnitTests.Analyzers/MudBlazor.UnitTests.Analyzers.csproj
index 85dc82b6e2f1..504fbeb6527b 100644
--- a/src/MudBlazor.UnitTests.Analyzers/MudBlazor.UnitTests.Analyzers.csproj
+++ b/src/MudBlazor.UnitTests.Analyzers/MudBla... | [
"src/MudBlazor.UnitTests.Analyzers/MudBlazor.UnitTests.Analyzers.csproj"
] | [] | true | ||
MudBlazor/MudBlazor | 13,241 | issue_to_patch | Build: Refine AutoTriage `needs` label guidance | Refines MudBot's autotriage prompt with targeted wording changes to the existing missing-information and needs-label guidance.
The goal is to make review-blocking asks clearer without broadly changing the bot's stable behavior. The updated wording keeps the current flow intact while clarifying that:
- bug-fix PRs s... | fc6a9916d413339eefac69c740c45b33d8aebf5c | 0d9b95784dc61fb74cf9b94f8e8932faf7582b95 | diff --git a/.github/AutoTriage.prompt b/.github/AutoTriage.prompt
index 65998da60227..894876fa9fde 100644
--- a/.github/AutoTriage.prompt
+++ b/.github/AutoTriage.prompt
@@ -98,13 +98,13 @@ Purpose: Capture essential details early on open threads so maintainers can act
### Step 3 โ Compose the request comment
- Post... | [
".github/AutoTriage.prompt"
] | [] | true | ||
MudBlazor/MudBlazor | 13,237 | issue_to_patch | Docs: Improve AGENTS.md as a single-file agent harness | ## Summary
This PR keeps `AGENTS.md` as a single file, but reshapes it into a more useful execution harness for coding agents working in MudBlazor.
The existing file already had the right domain knowledge: scoped build rules, component authoring conventions, docs expectations, bUnit guidance, and verification constra... | 894ff5240b89c3d38609d6ea2f4ad50345e3d7d6 | f71fbdc5b7caa9ddbd8d61e5d4bf36e3f14bd7f0 | diff --git a/AGENTS.md b/AGENTS.md
index 9a44e370ca07..4ca7d5f540cb 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -1,5 +1,25 @@
# AGENTS.md - AI Coding Agent Guide for MudBlazor
+## Start Here
+
+1. Identify the change type: component, docs, docs example, analyzer, TS/style, asset pipeline, or metadata-only.
+2. Inspect... | [
"AGENTS.md"
] | [] | true | ||
MudBlazor/MudBlazor | 13,234 | issue_to_patch | Build: Update AutoTriage workflows to v4 | <!-- Describe your changes and what the purpose of them is. -->
<!-- If you made any visual changes, provide screenshots of before/after. If it has moving parts, please attach a high-quality video. -->
- update AutoTriage workflow actions from v3 to v4
- switch pro model defaults/usages to gemini-3.5-flash
**Ch... | 74b1db3d94f10b8640eb6db498dba075178d9948 | 0331c709db6aee935b76338e031f4a7bb9f96e5b | diff --git a/.github/workflows/autotriage-backlog.yml b/.github/workflows/autotriage-backlog.yml
index 66fa964b15a6..2c6bbe022210 100644
--- a/.github/workflows/autotriage-backlog.yml
+++ b/.github/workflows/autotriage-backlog.yml
@@ -19,11 +19,6 @@ on:
type: number
required: false
default: 2... | [
".github/workflows/autotriage-backlog.yml",
".github/workflows/autotriage-issues.yml",
".github/workflows/autotriage-prs.yml"
] | [] | true | ||
MudBlazor/MudBlazor | 13,229 | issue_to_patch | Build: Update dependency nunit to 4.6.1 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [nunit](https://nunit.org/) ([source](https://redirect.github.com/nunit/nunit)) | `4.6.0` โ `4.6.1` | ![age](https://de... | b620fffe66d602ee893a1cc49a6b461d89a3f2ae | c4d722a73b3803d674390a7d1b43146da085d6db | diff --git a/src/MudBlazor.UnitTests.Shared/MudBlazor.UnitTests.Shared.csproj b/src/MudBlazor.UnitTests.Shared/MudBlazor.UnitTests.Shared.csproj
index 39210361aa33..e377cc69df86 100644
--- a/src/MudBlazor.UnitTests.Shared/MudBlazor.UnitTests.Shared.csproj
+++ b/src/MudBlazor.UnitTests.Shared/MudBlazor.UnitTests.Shared.... | [
"src/MudBlazor.UnitTests.Shared/MudBlazor.UnitTests.Shared.csproj"
] | [] | true | ||
MudBlazor/MudBlazor | 13,227 | issue_to_patch | Build: Improve deterministic test guidance for agents | ## Summary
- Tightens `AGENTS.md` testing guidance for deterministic, parallel-safe test work.
- Clarifies async coordination patterns: `async Task`, fake time, `TaskCompletionSource` gates, framework cancellation, and no fire-and-forget assertion flows.
- Adds bUnit-specific guidance for service registration order, r... | c47627a51551a7f203a500e671503028a8accf47 | b97eca0116d37c8ac0c78dd09c78848ae191cde6 | diff --git a/AGENTS.md b/AGENTS.md
index 9a44e370ca07..1b777af04ce9 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -245,17 +245,27 @@ private Task ToggleAsync()
- Test logic rather than full HTML snapshots.
- Prefer a fail-first workflow: add or update the test to fail for the target behavior before implementing the fix.
... | [
"AGENTS.md"
] | [] | true | ||
MudBlazor/MudBlazor | 13,198 | issue_to_patch | Build: Update dependency Markdig to 1.2.0 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [Markdig](https://xoofx.github.io/markdig) ([source](https://redirect.github.com/xoofx/markdig)) | `1.1.3` โ `1.2.0` | ... | e54c3ac4bc1011911ad346fb58ac979637702564 | 9fd514f7d590b4581720206110cb57b3306d585d | diff --git a/src/MudBlazor.Docs/MudBlazor.Docs.csproj b/src/MudBlazor.Docs/MudBlazor.Docs.csproj
index 02ac1b27c92c..871f5682b206 100644
--- a/src/MudBlazor.Docs/MudBlazor.Docs.csproj
+++ b/src/MudBlazor.Docs/MudBlazor.Docs.csproj
@@ -62,7 +62,7 @@
<PackageReference Include="Microsoft.AspNetCore.Components" Versio... | [
"src/MudBlazor.Docs/MudBlazor.Docs.csproj"
] | [] | true | ||
MudBlazor/MudBlazor | 13,226 | issue_to_patch | Tests: Add deterministic time helpers and agent guidance | This keeps the first deterministic-wait cleanup PR focused on shared patterns and existing fake-time usage. Component tests now have one obvious way to register fake time, while lower-level unit tests continue passing `FakeTimeProvider` directly to the subject under test.
Changes
- Add `Context.AddFakeTimeProvi... | a28d7be8b9df71ed60e3c1330d768bd6a2244d46 | 8b63cabb85915858d44ba882e0a01601278a0d00 | diff --git a/AGENTS.md b/AGENTS.md
index 358ecdd73ec5..9a44e370ca07 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -247,12 +247,15 @@ private Task ToggleAsync()
- Keep tests isolated so they can run in parallel.
- If a test modifies shared or static state, restore it in `[TearDown]`.
- Use `[NonParallelizable]` only when... | [
"AGENTS.md",
"src/MudBlazor.UnitTests.Shared/Extensions/TestContextExtensions.cs",
"src/MudBlazor.UnitTests/Components/DatePickerTests.cs",
"src/MudBlazor.UnitTests/Components/DateRangePickerTests.cs",
"src/MudBlazor.UnitTests/Components/NumericFieldTests.cs",
"src/MudBlazor.UnitTests/Components/TextField... | [] | true | ||
MudBlazor/MudBlazor | 12,776 | issue_to_patch | MudStepper: Nested steppers with different orientation
### Before reporting
- [x] I searched existing issues
- [x] I tried in private/incognito browser
### What went wrong?
Outside Stepper: Horizontal
Inside Stepper: Vertical
Result: The inside stepper will render as horizontal.
` <MudStepper Color="Color... | MudStepper: Fix nested steppers with different orientations | When a horizontal `MudStepper` contains a nested vertical `MudStepper`, the inner stepper renders as horizontal. The outer stepper's `display: flex` on `.mud-stepper-nav` used a descendant selector, leaking into any nested stepper's nav and overriding its orientation.
### Changes
- **`_stepper.scss`** โ Replace desce... | f4788e379b3172512ba87dfae19ec1f14ac6b907 | 59bd955994e58d4a92fe1361caa8b9825268f3e5 | diff --git a/src/MudBlazor/Styles/components/_stepper.scss b/src/MudBlazor/Styles/components/_stepper.scss
index f73f436bbbd1..70cf4e3a79fb 100644
--- a/src/MudBlazor/Styles/components/_stepper.scss
+++ b/src/MudBlazor/Styles/components/_stepper.scss
@@ -114,17 +114,17 @@
&.mud-stepper__horizontal {
- .mud-st... | [
"src/MudBlazor/Styles/components/_stepper.scss"
] | [] | true | |
MudBlazor/MudBlazor | 12,781 | issue_to_patch | MudTimePicker wrong mouse icon in popover if editable and Dialog Mode
### Bug type
Component
### Component name
MudTimePicker
### What happened?
If you set the MudTimePicker component to Dialog Mode and editable the mouse icon in the popover is incorrect, the text icon is proposed.
### Expected beh... | MudTimePicker: Fix wrong cursor in popover/dialog when editable | When `MudTimePicker` is set to `PickerVariant.Dialog` (or `Inline`) with `Editable="true"`, the outer wrapper receives `mud-picker-input-text` which sets `cursor: text`. This cascades into the picker content, showing a text cursor over the clock face instead of the default arrow cursor.
## Change
- **`_picker.scss`**... | f4788e379b3172512ba87dfae19ec1f14ac6b907 | 92fa879d2493320fe70a872ffb5938d118642e2e | diff --git a/src/MudBlazor/Styles/components/_picker.scss b/src/MudBlazor/Styles/components/_picker.scss
index cbbf58da2d58..1a488c5fc90d 100644
--- a/src/MudBlazor/Styles/components/_picker.scss
+++ b/src/MudBlazor/Styles/components/_picker.scss
@@ -105,6 +105,7 @@
overflow: hidden;
flex-direction: column;
ju... | [
"src/MudBlazor/Styles/components/_picker.scss"
] | [] | true | |
MudBlazor/MudBlazor | 12,777 | issue_to_patch | MudSlider value-label stays opposite in RTL mode (should mirror)
### Things to check
- [x] I have searched the **existing issues** for this bug
- [x] To rule out a caching problem I made sure the bug also happens in an **incognito tab**
### Bug type
Component
### Component name
MudSlider
### What happened?
When... | MudSlider: Fix value label position in RTL mode | In RTL mode, `MudSlider`'s value label was always anchored with `left: {Width}%`, placing it on the wrong side of the thumb. In RTL, the range input reverses direction so the label must use `right: {Width}%` to track the thumb correctly.
## Changes
- **`MudSlider.razor.cs`** โ Added `RightToLeft` cascading parameter;... | f4788e379b3172512ba87dfae19ec1f14ac6b907 | 35b798e2092231256da6c9e23056a43ca8ae06f7 | diff --git a/src/MudBlazor.UnitTests/Components/SliderTests.cs b/src/MudBlazor.UnitTests/Components/SliderTests.cs
index 50c62af8385b..5d013a3afd94 100644
--- a/src/MudBlazor.UnitTests/Components/SliderTests.cs
+++ b/src/MudBlazor.UnitTests/Components/SliderTests.cs
@@ -371,6 +371,26 @@ public void Percentage(double mi... | [
"src/MudBlazor.UnitTests/Components/SliderTests.cs",
"src/MudBlazor/Components/Slider/MudSlider.razor",
"src/MudBlazor/Components/Slider/MudSlider.razor.cs",
"src/MudBlazor/Styles/components/_slider.scss"
] | [] | true | |
MudBlazor/MudBlazor | 12,712 | issue_to_patch | Build: Update Gemini model name to `gemini-3.1-pro-preview` | The autotriage workflows were referencing an incorrect model name (`gemini-3-pro-preview` instead of `gemini-3.1-pro-preview`).
## Changes
- Updated `model-pro` value in `.github/workflows/autotriage-prs.yml`
- Updated `model-pro` value in `.github/workflows/autotriage-issues.yml`
<!-- START COPILOT CODING AGENT TIPS... | 6648f03f6dd650a73fe8d7e3f77c3ac51bea9cb3 | 26ded7fca486613f9b85704603000b6774498209 | diff --git a/.github/workflows/autotriage-issues.yml b/.github/workflows/autotriage-issues.yml
index 8c2d5aed9c67..c8bf77f68a3d 100644
--- a/.github/workflows/autotriage-issues.yml
+++ b/.github/workflows/autotriage-issues.yml
@@ -24,7 +24,7 @@ jobs:
issue-number: ${{ github.event.issue.number }}
... | [
".github/workflows/autotriage-issues.yml",
".github/workflows/autotriage-prs.yml"
] | [] | true | ||
MudBlazor/MudBlazor | 12,711 | issue_to_patch | Documenting DataGrid Column Sizing
### Feature request type
Enhance component
### Component name
DataGrid
### Is your feature request related to a problem?
Setting the column widths in percentages of the view width is something almost everyone needs to do for production. These are the initial widths for resizable... | Docs: Document Data Grid column sizing, initial widths, and text truncation | No documentation existed for setting DataGrid column widths or preventing cell text wrapping โ common production requirements.
### Changes
- **New `DataGridColumnSizingExample.razor`** โ demonstrates percentage-based column widths via `<ColGroup>`, combined with `CellStyle` for no-wrap + ellipsis truncation on long-t... | cde08a8caaacff5311a3e3f238257896b3b83223 | b24dbd4009ce892592fc520676afab8b389e84e6 | diff --git a/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor b/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor
index 1e319da6cc48..bffd1112c614 100644
--- a/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor
+++ b/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.raz... | [
"src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor",
"src/MudBlazor.Docs/Pages/Components/DataGrid/Examples/DataGridColumnSizingExample.razor"
] | [] | true | |
MudBlazor/MudBlazor | 12,707 | issue_to_patch | Add documentation comparing MudDataGrid and MudTable
### Feature request type
Other
### Component name
MudDataGrid
### Is your feature request related to a problem?
Its unclear when we should use MudDataGrid vs MudTable. There seems to be a huge amount of overlap - even the description of each componen... | Docs: Add MudDataGrid vs MudTable comparison | - [x] Remove standalone "MudDataGrid vs MudTable" sections from both pages
- [x] Move condensed comparison into `<DocsPageHeader>` `<Description>` on each page
- [x] Move features sentence into XML `<summary>` of each component (auto-populated as page subtitle)
- [x] Condense both XML summaries to a single short senten... | 178ab9c40aca8e19311469c634cc55851537fc19 | 45e8f8aaebf89e0b7f0923b8996482aacad74629 | diff --git a/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor b/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor
index 9cf30182a680..beb12bb20ccb 100644
--- a/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor
+++ b/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.raz... | [
"src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor",
"src/MudBlazor.Docs/Pages/Components/Table/TablePage.razor",
"src/MudBlazor/Components/DataGrid/MudDataGrid.razor.cs",
"src/MudBlazor/Components/Table/MudTable.razor.cs"
] | [] | true | |
MudBlazor/MudBlazor | 12,710 | issue_to_patch | Docs: Clarify that CommittedItemChanges must be called manually in DataGrid EditTemplate
### Bug type
Component
### Component name
MudDataGrid
### What happened?
I have a MudDataGrid in which I have a column for displaying a date, I've used EditTemplate like this
```
<MudDataGrid @ref=@grid
... | Docs: Clarify MudDataGrid EditTemplate Cell mode behavior for CommittedItemChanges | In `Cell` edit mode, standard `PropertyColumn` fields auto-commit on change, but custom controls inside `EditTemplate` bypass that mechanism entirely โ `CommittedItemChanges` never fires. This PR clarifies the existing behavior in the docs without making any API changes.
### Changes
- **`Column.EditTemplate` XML docs... | 178ab9c40aca8e19311469c634cc55851537fc19 | c4a867fcc03b4254c4980eda335118b8d917dd0a | diff --git a/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor b/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor
index 9cf30182a680..1e319da6cc48 100644
--- a/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor
+++ b/src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.raz... | [
"src/MudBlazor.Docs/Pages/Components/DataGrid/DataGridPage.razor",
"src/MudBlazor/Components/DataGrid/Column.razor.cs"
] | [] | true | |
MudBlazor/MudBlazor | 12,706 | issue_to_patch | MudMenu nested menu arrow icon is wrong direction in RTL
### Things to check
- [x] I have searched the **existing issues** for this bug
- [x] To rule out a caching problem I made sure the bug also happens in an **incognito tab**
### Bug type
Component
### Component name
MudMenu
### What happened?
when we select... | MudMenu: Fix nested submenu arrow direction in RTL mode | `MudMenuItem` hardcoded `Icons.Material.Filled.ArrowRight` for the submenu indicator, ignoring RTL layout โ so the arrow always pointed โถ even when the submenu opens to the left.
## Changes
- **`MudMenuItem`** โ add `[CascadingParameter(Name = "RightToLeft")] public bool RightToLeft` (consistent with the pattern used... | 178ab9c40aca8e19311469c634cc55851537fc19 | ff56b56d545417f2f2bec0effa396f2a0310d87c | diff --git a/src/MudBlazor.UnitTests/Components/MenuTests.cs b/src/MudBlazor.UnitTests/Components/MenuTests.cs
index bfd1bf3a9b0f..ac7aab225901 100644
--- a/src/MudBlazor.UnitTests/Components/MenuTests.cs
+++ b/src/MudBlazor.UnitTests/Components/MenuTests.cs
@@ -1158,5 +1158,23 @@ public void PopoverSettings_UsesGlobal... | [
"src/MudBlazor.UnitTests/Components/MenuTests.cs",
"src/MudBlazor/Components/Menu/MudMenuItem.razor",
"src/MudBlazor/Components/Menu/MudMenuItem.razor.cs"
] | [] | true | |
MudBlazor/MudBlazor | 12,709 | issue_to_patch | Add ArrowsColor property to MudCarousel
### Feature request type
Enhance component
### Component name
MudCarousel
### Is your feature request related to a problem?
The arrows only use Color.Inherit. I want to be able to set the arrows color (ArrowsColor), just like I can set the bullets color (BulletsColor). Othe... | MudCarousel: Add ArrowsColor parameter | `MudCarousel` had no way to color the navigation arrows short of implementing full custom arrow templates โ inconsistent with the existing `BulletsColor` parameter.
## Changes
- **`MudCarousel.razor.cs`** โ Added nullable `ArrowsColor` parameter (`Color?`) in `CategoryTypes.Carousel.Appearance`, placed alongside `Arr... | 178ab9c40aca8e19311469c634cc55851537fc19 | ba44af7e2a1b85125695a3c34aed58f65cc8ec0d | diff --git a/src/MudBlazor.UnitTests/Components/CarouselTests.cs b/src/MudBlazor.UnitTests/Components/CarouselTests.cs
index 00071a7247a9..d2f312fa4946 100644
--- a/src/MudBlazor.UnitTests/Components/CarouselTests.cs
+++ b/src/MudBlazor.UnitTests/Components/CarouselTests.cs
@@ -311,5 +311,28 @@ public async Task Carous... | [
"src/MudBlazor.UnitTests/Components/CarouselTests.cs",
"src/MudBlazor/Components/Carousel/MudCarousel.razor",
"src/MudBlazor/Components/Carousel/MudCarousel.razor.cs"
] | [] | true | |
MudBlazor/MudBlazor | 12,704 | issue_to_patch | MudSelect and MudAutocomplete sets pointer: cursor when readonly
### Before reporting
- [x] I searched existing issues
- [x] I tried in private/incognito browser
### What went wrong?
Currently, when hovering the mouse over a MudSelect or MudAutocomplete set in readonly mode, the cursor changes to a pointer icon.
T... | MudSelect, MudAutocomplete: Fix pointer cursor shown on readonly | `MudSelect` and `MudAutocomplete` displayed `cursor: pointer` when hovered in readonly mode, inconsistent with other readonly inputs which use the default cursor.
## Changes
- **`MudSelect.razor.cs` / `MudAutocomplete.razor.cs`**: Conditionally add `mud-readonly` CSS class to `InputClassname` when `GetReadOnlyState()... | 178ab9c40aca8e19311469c634cc55851537fc19 | 17457d7819ccc97b4d5a74fdb16afa969b2def7e | diff --git a/src/MudBlazor.UnitTests/Components/AutocompleteTests.cs b/src/MudBlazor.UnitTests/Components/AutocompleteTests.cs
index 4e99f8f9b0b5..bd2e54789782 100644
--- a/src/MudBlazor.UnitTests/Components/AutocompleteTests.cs
+++ b/src/MudBlazor.UnitTests/Components/AutocompleteTests.cs
@@ -585,6 +585,18 @@ public a... | [
"src/MudBlazor.UnitTests/Components/AutocompleteTests.cs",
"src/MudBlazor.UnitTests/Components/SelectTests.cs",
"src/MudBlazor/Components/Autocomplete/MudAutocomplete.razor.cs",
"src/MudBlazor/Components/Select/MudSelect.razor.cs",
"src/MudBlazor/Styles/components/_select.scss"
] | [] | true | |
MudBlazor/MudBlazor | 12,705 | issue_to_patch | MudNavGroup API documentation - Add accessibility precisions
### Issue type
- [x] Missing or incomplete documentation
- [ ] Incorrect information or broken code example
- [ ] Suggestion for improvement
### Page or section affected
https://mudblazor.com/api/mudnavgroup#properties
### Description
Documentation for ... | Docs: Clarify MudNavGroup TitleContent accessibility behavior | `TitleContent` doc comment stated it "overrides the `Title` property" without qualification โ misleading, since `Title` is still used for the button's `aria-label` regardless of whether `TitleContent` is set.
## Changes
- **`MudNavGroup.razor.cs`**: Updated `TitleContent` XML doc to clarify it only overrides `Title` ... | 178ab9c40aca8e19311469c634cc55851537fc19 | 787bda11cfc1239af4a4cdef21e0a78290d67c4e | diff --git a/src/MudBlazor/Components/NavMenu/MudNavGroup.razor.cs b/src/MudBlazor/Components/NavMenu/MudNavGroup.razor.cs
index 398a7975f347..b8cded789cf3 100644
--- a/src/MudBlazor/Components/NavMenu/MudNavGroup.razor.cs
+++ b/src/MudBlazor/Components/NavMenu/MudNavGroup.razor.cs
@@ -83,7 +83,7 @@ protected override ... | [
"src/MudBlazor/Components/NavMenu/MudNavGroup.razor.cs"
] | [] | true | |
MudBlazor/MudBlazor | 12,701 | issue_to_patch | MaxItemCount is not available on .NET 8
### Before reporting
- [x] I searched existing issues
- [x] I tried in private/incognito browser
### What went wrong?
#12536 added `MaxItemCount` to `MudVirtualize<T>` for _all_ TFMs , but the wrapped [`Virtualize<T>.MaxItemCount`](https://learn.microsoft.com/en-us/dotnet/api... | MudVirtualize: Fix MaxItemCount runtime crash on .NET 8 | `MudVirtualize<T>` unconditionally passed `MaxItemCount` to Blazor's `Virtualize<T>`, but that parameter was only introduced in .NET 9 โ causing a runtime exception when using MudBlazor v9 in a .NET 8 application.
## Changes
- **`MudVirtualize.razor.cs`**: Guard `MaxItemCount` parameter (including XML docs) with `#if... | b835911756eeb3e2dab7a1a349982f7b7fd3d33e | fd9592899cf39ddd16d4a74cc54ae66eae8bcc36 | diff --git a/src/MudBlazor.UnitTests/Components/VirtualizeTests.cs b/src/MudBlazor.UnitTests/Components/VirtualizeTests.cs
index 5ce416b58c76..4c0881140709 100644
--- a/src/MudBlazor.UnitTests/Components/VirtualizeTests.cs
+++ b/src/MudBlazor.UnitTests/Components/VirtualizeTests.cs
@@ -1,6 +1,7 @@
๏ปฟusing AngleSharp.Do... | [
"src/MudBlazor.UnitTests/Components/VirtualizeTests.cs",
"src/MudBlazor/Components/Virtualize/MudVirtualize.razor",
"src/MudBlazor/Components/Virtualize/MudVirtualize.razor.cs"
] | [
{
"comment": "@ScarletKuro In general is it better to keep the parameter for all TFMs but add a runtime assertion (or just ignore it)? Doesn't seem right to conditionally include it in the build - might cause problems with razor tooling?",
"path": "src/MudBlazor/Components/Virtualize/MudVirtualize.razor.cs"... | true | |
MudBlazor/MudBlazor | 12,656 | issue_to_patch | Build: Add local BunDotNet tool manifest for offline asset builds | Offline or flaky connections were causing `Building MudBlazor web assets (outer build)` to hang or fail because the BunDotNet CLI was fetched from NuGet at build time. This change makes BunDotNet a local tool to avoid network dependency during asset builds.
- **Tooling**
- Add `dotnet-tools.json` with `BunDotNet.Cli... | 2085097e4a4b5c8ccffd5a29a1f8f6e65bd5a8cb | ee9ac8056bea56def18f8307dd0c41e9f7699f91 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
new file mode 100644
index 000000000000..cfd3f72d77e9
--- /dev/null
+++ b/.config/dotnet-tools.json
@@ -0,0 +1,13 @@
+{
+ "version": 1,
+ "isRoot": true,
+ "tools": {
+ "bundotnet.cli": {
+ "version": "1.2.0",
+ "commands": [
+ "b... | [
".config/dotnet-tools.json",
"src/Directory.Build.props",
"src/MudBlazor.Docs/MudBlazor.Docs.csproj",
"src/MudBlazor.Docs/build.mjs",
"src/MudBlazor/MudBlazor.csproj",
"src/MudBlazor/build.mjs",
"tools/watch.cs"
] | [
{
"comment": "`dotnet tool run bun` will fail if the local tool hasnโt been restored yet. In this watcher, the assets process is started immediately and does not run `dotnet tool restore` first, so a fresh checkout (or cleared tool cache) will error before any build targets have a chance to restore the tool. Co... | true | ||
MudBlazor/MudBlazor | 12,656 | comment_to_fix | Build: Add local BunDotNet tool manifest for offline asset builds | `dotnet tool run bun` will fail if the local tool hasnโt been restored yet. In this watcher, the assets process is started immediately and does not run `dotnet tool restore` first, so a fresh checkout (or cleared tool cache) will error before any build targets have a chance to restore the tool. Consider running a one-t... | 2085097e4a4b5c8ccffd5a29a1f8f6e65bd5a8cb | ee9ac8056bea56def18f8307dd0c41e9f7699f91 | diff --git a/tools/watch.cs b/tools/watch.cs
index 43a79575b701..0f122548153f 100755
--- a/tools/watch.cs
+++ b/tools/watch.cs
@@ -22,6 +22,7 @@ static async Task Run()
var assetBuildScript = Path.Combine(mudblazorProjectDirectory, "build.mjs");
var buildPropsFile = Path.Combine(srcDirectory, "Directory.Build... | [
"tools/watch.cs"
] | [
{
"comment": "`dotnet tool run bun` will fail if the local tool hasnโt been restored yet. In this watcher, the assets process is started immediately and does not run `dotnet tool restore` first, so a fresh checkout (or cleared tool cache) will error before any build targets have a chance to restore the tool. Co... | true | ||
MudBlazor/MudBlazor | 12,688 | issue_to_patch | Build: Pin AutoTriage workflows to `danielchalmers/AutoTriage@v2` | This updates all AutoTriage workflows to use the `v2` tag instead of tracking `main`, so triage automation runs against a stable, versioned action reference. Scope is limited to workflow pinning only.
- **What changed**
- Updated `uses` in:
- `.github/workflows/autotriage-prs.yml`
- `.github/workflows/autotr... | 48d90bea92869a959b3c687339db4495b3e289fa | 96476b4fc0fc3df4c1a022840961de25ceb52dd3 | diff --git a/.github/workflows/autotriage-backlog.yml b/.github/workflows/autotriage-backlog.yml
index 2633f035618e..684fee418801 100644
--- a/.github/workflows/autotriage-backlog.yml
+++ b/.github/workflows/autotriage-backlog.yml
@@ -41,7 +41,7 @@ jobs:
${{ runner.os }}-triage-db-
- name: AutoTri... | [
".github/workflows/autotriage-backlog.yml",
".github/workflows/autotriage-issues.yml",
".github/workflows/autotriage-prs.yml"
] | [] | true | ||
MudBlazor/MudBlazor | 12,650 | issue_to_patch | Build: Request core-team reviews on Renovate vulnerability PRs | Renovateโs vulnerability alerts should route to the Core Team for timely review. This change ensures security-related dependency updates request the core-team as reviewers.
- **Renovate rules**
- Add `team:core-team` reviewers to the existing `vulnerabilityAlerts` configuration
```json
{
"vulnerabilityAlerts": {
... | d75db0dc9c3f0b2c829d71a92456fdd738734f84 | 8c037c97f62f3a7b89881dd689f5205c4db043ed | diff --git a/.github/renovate.json b/.github/renovate.json
index 99e006cfcb02..35ec961cc886 100644
--- a/.github/renovate.json
+++ b/.github/renovate.json
@@ -16,6 +16,9 @@
"enabled": true,
"addLabels": [
"security"
+ ],
+ "reviewers": [
+ "team:core-team"
... | [
".github/renovate.json"
] | [] | true | ||
MudBlazor/MudBlazor | 12,652 | issue_to_patch | Action Required: Add missing credentials
There are missing credentials for the authentication-required feature. As a precaution, Renovate will pause PRs until it is resolved.
Location: `MatchConfidence Authenticator`
Error type: Missing credentials
Message: The `matchConfidence` matcher in `packageRules` requires aut... | Build: Remove Renovate matchConfidence rule requiring Mend credentials | Renovate merge confidence matching is a private beta feature that requires Mend credentials, causing Renovate to pause PRs. The repo uses `matchConfidence` without an API key, triggering the authentication error.
- **Renovate configuration**
- Removed the `matchConfidence` packageRule so Renovate no longer requir... | 8661d86fd8c8922dcdf6d82210d93d3360d13861 | ba18deb04de236fd7f9c6cd33fba8ee3212cefbc | diff --git a/.github/renovate.json b/.github/renovate.json
index 99e006cfcb02..b90b6c6b2fcb 100644
--- a/.github/renovate.json
+++ b/.github/renovate.json
@@ -50,17 +50,6 @@
"> [!WARNING]\n> Target version is either under 14 days old or does not publish a reliable release timestamp yet."
]... | [
".github/renovate.json"
] | [] | true | |
NLog/NLog | 6,217 | issue_to_patch | ScopeContext - Unify CollectNestedState implementation | 0f372d00a71a7e96730e5c3aafb40263e365797b | 917362a8c344f382ff3c676716c272d2af35736c | diff --git a/src/NLog/Internal/ScopeContextAsyncState.cs b/src/NLog/Internal/ScopeContextAsyncState.cs
index 40ffc30aea..426784c96b 100644
--- a/src/NLog/Internal/ScopeContextAsyncState.cs
+++ b/src/NLog/Internal/ScopeContextAsyncState.cs
@@ -253,6 +253,23 @@ public void CollectNestedState(object state)
}
... | [
"src/NLog/Internal/ScopeContextAsyncState.cs"
] | [] | true | |||
NLog/NLog | 6,216 | issue_to_patch | ScopeContext - Simplify CaptureContextProperties when only nested state | Maybe one should remove the ability of directly calling CaptureContextProperties, but instead always start out with StartCaptureProperties. Removing the complexity of CaptureContextProperties having to upgrade to StartCaptureProperties. | 36eee978973d9ee3a8e464d0eff70d994e26e488 | df671836517fd9cfc0b70d97718e37cd09b2a19c | diff --git a/src/NLog/Internal/ScopeContextAsyncState.cs b/src/NLog/Internal/ScopeContextAsyncState.cs
index ba388896db..40ffc30aea 100644
--- a/src/NLog/Internal/ScopeContextAsyncState.cs
+++ b/src/NLog/Internal/ScopeContextAsyncState.cs
@@ -299,16 +299,13 @@ public ScopedContextNestedAsyncState(IScopeContextAsyncStat... | [
"src/NLog/Internal/ScopeContextAsyncState.cs",
"tests/NLog.UnitTests/Contexts/ScopeContextTest.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Script executed:\n\n```shell\n#!/bin/bash\n# Verify how GetAllProperties and TryGetProperty handle the null return from CaptureContextProperties\n# and check if there's separate handling for NestedState at t... | diff --git a/tests/NLog.UnitTests/Contexts/ScopeContextTest.cs b/tests/NLog.UnitTests/Contexts/ScopeContextTest.cs
index 51236629ac..5fe7044875 100644
--- a/tests/NLog.UnitTests/Contexts/ScopeContextTest.cs
+++ b/tests/NLog.UnitTests/Contexts/ScopeContextTest.cs
@@ -793,6 +793,26 @@ public void ScopeContextPushWithoutS... | true | |
NLog/NLog | 6,216 | comment_to_fix | ScopeContext - Simplify CaptureContextProperties when only nested state | _โ ๏ธ Potential issue_ | _๐ Major_
<details>
<summary>๐งฉ Analysis chain</summary>
๐ Script executed:
```shell
#!/bin/bash
# Verify how GetAllProperties and TryGetProperty handle the null return from CaptureContextProperties
# and check if there's separate handling for NestedState at top of stack
echo "=== Check Get... | 36eee978973d9ee3a8e464d0eff70d994e26e488 | df671836517fd9cfc0b70d97718e37cd09b2a19c | diff --git a/src/NLog/Internal/ScopeContextAsyncState.cs b/src/NLog/Internal/ScopeContextAsyncState.cs
index ba388896db..40ffc30aea 100644
--- a/src/NLog/Internal/ScopeContextAsyncState.cs
+++ b/src/NLog/Internal/ScopeContextAsyncState.cs
@@ -299,16 +299,13 @@ public ScopedContextNestedAsyncState(IScopeContextAsyncStat... | [
"src/NLog/Internal/ScopeContextAsyncState.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Script executed:\n\n```shell\n#!/bin/bash\n# Verify how GetAllProperties and TryGetProperty handle the null return from CaptureContextProperties\n# and check if there's separate handling for NestedState at t... | true | ||
NLog/NLog | 6,214 | issue_to_patch | ScopeContext - Rename CaptureNestedContext to CloneNestedContext | ScopeContext GetAllNestedStates always converts the ScopeContext-chain into a newly allocated array or list.
Right now every LogEvent written within the same nested ScopeContext will allocate their own nested-state-collection.
The ScopeContextNestedStateCollector becomes armed when the first item is added, and th... | 4a5b3f40377cf1d2b811285e62e897b96cba190a | 6d5ca805de4d31e7174e924267c40cea54b025c6 | diff --git a/.gitignore b/.gitignore
index 7d46955165..24a3a47cb2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -35,4 +35,5 @@ build/
*.vshost.*
.vs
.cr
-/artifacts
\ No newline at end of file
+/artifacts
+/.github/copilot-instructions.md
diff --git a/src/NLog/Internal/ScopeContextAsyncState.cs b/src/NLog/Internal/Sco... | [
".gitignore",
"src/NLog/Internal/ScopeContextAsyncState.cs",
"src/NLog/ScopeContext.cs",
"src/NLog/Targets/TargetWithContext.cs"
] | [] | true | ||
NLog/NLog | 6,212 | issue_to_patch | PropertyTypeConverter - Simplify IsDynamicCodeSupported check | Followup to #6208 | a3c7ae5e8a2250488185ca85e8a5408f801d8bdb | 3b506594798a7a829dde59b308389320446a20e7 | diff --git a/src/NLog/Config/PropertyTypeConverter.cs b/src/NLog/Config/PropertyTypeConverter.cs
index 8059f36c7a..c71c35411a 100644
--- a/src/NLog/Config/PropertyTypeConverter.cs
+++ b/src/NLog/Config/PropertyTypeConverter.cs
@@ -234,11 +234,15 @@ internal static bool TryConvertFromString(string propertyString, Type p... | [
"src/NLog/Config/PropertyTypeConverter.cs",
"src/NLog/Internal/PropertyHelper.cs"
] | [] | true | ||
NLog/NLog | 6,211 | issue_to_patch | ScopeContext - Renamed PushNestedState to CollectNestedState | ce42142e10570746345644dab8879b61db5565cd | fd4a36284cdb3479ee0f29c4a2d34c972775d29a | diff --git a/src/NLog/Internal/ScopeContextAsyncState.cs b/src/NLog/Internal/ScopeContextAsyncState.cs
index cffa0474d2..bc7e5f8dad 100644
--- a/src/NLog/Internal/ScopeContextAsyncState.cs
+++ b/src/NLog/Internal/ScopeContextAsyncState.cs
@@ -246,7 +246,7 @@ public IList<object> StartCaptureNestedStates(IScopeContextAs... | [
"src/NLog/Internal/ScopeContextAsyncState.cs",
"src/NLog/NestedDiagnosticsContext.cs",
"src/NLog/NestedDiagnosticsLogicalContext.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ด Critical_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\necho \"== Find ToArray extension definitions that could apply ==\"\nrg -n -C2 'ToArray\\s*\\(\\s*this\\s+[^)]*\\)' \n\necho\necho \"== Check... | true | |||
NLog/NLog | 6,211 | comment_to_fix | ScopeContext - Renamed PushNestedState to CollectNestedState | _โ ๏ธ Potential issue_ | _๐ด Critical_
<details>
<summary>๐งฉ Analysis chain</summary>
๐ Script executed:
```shell
#!/bin/bash
set -euo pipefail
echo "== Find ToArray extension definitions that could apply =="
rg -n -C2 'ToArray\s*\(\s*this\s+[^)]*\)'
echo
echo "== Check for global usings or explicit System.Linq us... | ce42142e10570746345644dab8879b61db5565cd | fd4a36284cdb3479ee0f29c4a2d34c972775d29a | diff --git a/src/NLog/Internal/ScopeContextAsyncState.cs b/src/NLog/Internal/ScopeContextAsyncState.cs
index cffa0474d2..bc7e5f8dad 100644
--- a/src/NLog/Internal/ScopeContextAsyncState.cs
+++ b/src/NLog/Internal/ScopeContextAsyncState.cs
@@ -246,7 +246,7 @@ public IList<object> StartCaptureNestedStates(IScopeContextAs... | [
"src/NLog/Internal/ScopeContextAsyncState.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ด Critical_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\necho \"== Find ToArray extension definitions that could apply ==\"\nrg -n -C2 'ToArray\\s*\\(\\s*this\\s+[^)]*\\)' \n\necho\necho \"== Check... | true | ||
NLog/NLog | 6,210 | issue_to_patch | Fix List capacity for ScopeContext GetAllNestedStates | Parenthesize `??` as `+` binds stronger | d6f69e6874b940579d5577767bf9f2c4f80c95b1 | 6fe0877a2c0c59b024bbb2cc1f968bfdc0955a0b | diff --git a/src/NLog/Internal/ScopeContextAsyncState.cs b/src/NLog/Internal/ScopeContextAsyncState.cs
index 4766599d30..cffa0474d2 100644
--- a/src/NLog/Internal/ScopeContextAsyncState.cs
+++ b/src/NLog/Internal/ScopeContextAsyncState.cs
@@ -250,7 +250,7 @@ public void PushNestedState(object state)
{
... | [
"src/NLog/Internal/ScopeContextAsyncState.cs"
] | [] | true | ||
NLog/NLog | 6,209 | issue_to_patch | AppVeyor - Visual Studio 2026 | d6f69e6874b940579d5577767bf9f2c4f80c95b1 | 3b179f4b3204184cc6569552568a6caece87f2af | diff --git a/appveyor.yml b/appveyor.yml
index 69fa8cef07..6c1d90bb17 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -1,6 +1,6 @@
version: 6.0.0-{build} # Only change for mayor versions (e.g. 7.0)
image:
- - Visual Studio 2022
+ - Visual Studio 2026
- Ubuntu2204
configuration: Release
build: false
@@ -18,9 +1... | [
"appveyor.yml",
"run-tests.ps1",
"src/NLog.Targets.AtomicFile/NLog.Targets.AtomicFile.csproj",
"src/NLog.Targets.AtomicFile/README.md",
"tests/NLog.Benchmarks/NLog.Benchmarks.csproj",
"tests/NLog.RegEx.Tests/NLog.RegEx.Tests.csproj",
"tests/NLog.Targets.AtomicFile.Tests/NLog.Targets.AtomicFile.Tests.csp... | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ก Minor_ | _โก Quick win_\n\n**Sync contributor build docs with the new CI toolchain baseline.**\n\n`appveyor.yml` now targets `Visual Studio 2026`, but `CONTRIBUTING.md` still says โUse Visual Studio 2022โ. Please update that doc to avoid contributor confusion and local-vs... | diff --git a/tests/NLog.Benchmarks/NLog.Benchmarks.csproj b/tests/NLog.Benchmarks/NLog.Benchmarks.csproj
index 33b1122bb8..11f8233342 100644
--- a/tests/NLog.Benchmarks/NLog.Benchmarks.csproj
+++ b/tests/NLog.Benchmarks/NLog.Benchmarks.csproj
@@ -1,7 +1,11 @@
๏ปฟ<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- ... | true | ||
NLog/NLog | 6,209 | comment_to_fix | AppVeyor - Visual Studio 2026 | _โ ๏ธ Potential issue_ | _๐ด Critical_ | _โก Quick win_
**Default TargetFramework should be net10.0 to match run-tests.ps1 expectations.**
Line 9 defaults to `net8.0`, but `run-tests.ps1` at line 15 expects the publish output at the `net10.0` path. This mismatch will cause the test script to fail when run with Visual St... | d6f69e6874b940579d5577767bf9f2c4f80c95b1 | 3b179f4b3204184cc6569552568a6caece87f2af | diff --git a/tests/TestTrimPublish/TestTrimPublish.csproj b/tests/TestTrimPublish/TestTrimPublish.csproj
index ff43c584fd..4ecc279c25 100644
--- a/tests/TestTrimPublish/TestTrimPublish.csproj
+++ b/tests/TestTrimPublish/TestTrimPublish.csproj
@@ -4,8 +4,9 @@
<OutputType>Exe</OutputType>
<VisualStudioVersion... | [
"tests/TestTrimPublish/TestTrimPublish.csproj"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ด Critical_ | _โก Quick win_\n\n**Default TargetFramework should be net10.0 to match run-tests.ps1 expectations.**\n\nLine 9 defaults to `net8.0`, but `run-tests.ps1` at line 15 expects the publish output at the `net10.0` path. This mismatch will cause the test script to fa... | true | ||
NLog/NLog | 6,209 | comment_to_fix | AppVeyor - Visual Studio 2026 | _โ ๏ธ Potential issue_ | _๐ด Critical_ | _โก Quick win_
**Condition logic allows line 7 to overwrite line 6 for Visual Studio 2017 and 2019.**
MSBuild evaluates all matching conditions in order, so the last matching assignment wins. When `VisualStudioVersion` is 17.5 (Visual Studio 2019/2022 < 2026):
- Line 6 condition ... | d6f69e6874b940579d5577767bf9f2c4f80c95b1 | 3b179f4b3204184cc6569552568a6caece87f2af | diff --git a/tests/NLog.RegEx.Tests/NLog.RegEx.Tests.csproj b/tests/NLog.RegEx.Tests/NLog.RegEx.Tests.csproj
index 995d2603ba..45f590e413 100644
--- a/tests/NLog.RegEx.Tests/NLog.RegEx.Tests.csproj
+++ b/tests/NLog.RegEx.Tests/NLog.RegEx.Tests.csproj
@@ -3,7 +3,8 @@
<PropertyGroup>
<VisualStudioVersion Conditio... | [
"tests/NLog.RegEx.Tests/NLog.RegEx.Tests.csproj"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ด Critical_ | _โก Quick win_\n\n**Condition logic allows line 7 to overwrite line 6 for Visual Studio 2017 and 2019.**\n\nMSBuild evaluates all matching conditions in order, so the last matching assignment wins. When `VisualStudioVersion` is 17.5 (Visual Studio 2019/2022 < ... | true | ||
NLog/NLog | 6,209 | comment_to_fix | AppVeyor - Visual Studio 2026 | _โ ๏ธ Potential issue_ | _๐ด Critical_ | _โก Quick win_
**Condition logic allows line 7 to overwrite line 6 for Visual Studio 2017 and 2019.**
MSBuild evaluates all matching conditions in order, so the last matching assignment wins. When `VisualStudioVersion` is 17.5 (Visual Studio 2019/2022 < 2026):
- Line 6 condition ... | d6f69e6874b940579d5577767bf9f2c4f80c95b1 | 3b179f4b3204184cc6569552568a6caece87f2af | diff --git a/tests/NLog.UnitTests/NLog.UnitTests.csproj b/tests/NLog.UnitTests/NLog.UnitTests.csproj
index d67e34ce4f..306a0c6197 100644
--- a/tests/NLog.UnitTests/NLog.UnitTests.csproj
+++ b/tests/NLog.UnitTests/NLog.UnitTests.csproj
@@ -3,7 +3,8 @@
<PropertyGroup>
<VisualStudioVersion Condition="'$(VisualStud... | [
"tests/NLog.UnitTests/NLog.UnitTests.csproj"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ด Critical_ | _โก Quick win_\n\n**Condition logic allows line 7 to overwrite line 6 for Visual Studio 2017 and 2019.**\n\nMSBuild evaluates all matching conditions in order, so the last matching assignment wins. When `VisualStudioVersion` is 17.5 (Visual Studio 2019/2022 < ... | true | ||
NLog/NLog | 6,209 | comment_to_fix | AppVeyor - Visual Studio 2026 | _โ ๏ธ Potential issue_ | _๐ด Critical_ | _โก Quick win_
**Condition logic allows line 9 to overwrite line 8 for Visual Studio 2017 and 2019.**
MSBuild evaluates all matching conditions in order, so the last matching assignment wins. When `VisualStudioVersion` is 17.5 (Visual Studio 2019/2022 < 2026):
- Line 8 condition ... | d6f69e6874b940579d5577767bf9f2c4f80c95b1 | 3b179f4b3204184cc6569552568a6caece87f2af | diff --git a/tests/TestTrimPublish/TestTrimPublish.csproj b/tests/TestTrimPublish/TestTrimPublish.csproj
index ff43c584fd..4ecc279c25 100644
--- a/tests/TestTrimPublish/TestTrimPublish.csproj
+++ b/tests/TestTrimPublish/TestTrimPublish.csproj
@@ -4,8 +4,9 @@
<OutputType>Exe</OutputType>
<VisualStudioVersion... | [
"tests/TestTrimPublish/TestTrimPublish.csproj"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ด Critical_ | _โก Quick win_\n\n**Condition logic allows line 9 to overwrite line 8 for Visual Studio 2017 and 2019.**\n\nMSBuild evaluates all matching conditions in order, so the last matching assignment wins. When `VisualStudioVersion` is 17.5 (Visual Studio 2019/2022 < ... | true | ||
NLog/NLog | 6,208 | issue_to_patch | PropertyTypeConverter - Fix TryConvertToType to handle IsDynamicCodeSupported = true | Followup to #6183 + #6174 | e367804a0a51962c0198ac158c38ffc8db040912 | 829f5840516cebb584bffc56c533dc0d1efab19c | diff --git a/src/NLog/Config/PropertyTypeConverter.cs b/src/NLog/Config/PropertyTypeConverter.cs
index 61ebb99266..8059f36c7a 100644
--- a/src/NLog/Config/PropertyTypeConverter.cs
+++ b/src/NLog/Config/PropertyTypeConverter.cs
@@ -191,15 +191,6 @@ internal static bool TryConvertFromString(string propertyString, Type pr... | [
"src/NLog/Config/PropertyTypeConverter.cs",
"src/NLog/Internal/PropertyHelper.cs"
] | [] | true | ||
NLog/NLog | 6,206 | issue_to_patch | MruCache - Changed to ConcurrentDictionary but still single writer | Very happy about the prune-logic no longer requires allocation of List-of-candidates-for-removal. | e367804a0a51962c0198ac158c38ffc8db040912 | 752352241ce1e0a0a8aed9de174991cfbde3ecc8 | diff --git a/src/NLog/Internal/MruCache.cs b/src/NLog/Internal/MruCache.cs
index e9d76b4c99..2a77283968 100644
--- a/src/NLog/Internal/MruCache.cs
+++ b/src/NLog/Internal/MruCache.cs
@@ -34,6 +34,9 @@
namespace NLog.Internal
{
using System.Collections.Generic;
+#if !NET35
+ using System.Collections.Concurrent... | [
"src/NLog/Internal/MruCache.cs",
"src/NLog/MessageTemplates/ValueFormatter.cs",
"src/NLog/Targets/DefaultJsonSerializer.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_\n\n**De-duplicate NET35 prune candidates before decrementing `orgSize`.**\n\nLine 142 decrements `orgSize` before confirming the key is uniquely scheduled for removal. With `List<TKey>` on Line 121 and deferred removals, the same key can be counted... | true | ||
NLog/NLog | 6,206 | comment_to_fix | MruCache - Changed to ConcurrentDictionary but still single writer | _โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_
**De-duplicate NET35 prune candidates before decrementing `orgSize`.**
Line 142 decrements `orgSize` before confirming the key is uniquely scheduled for removal. With `List<TKey>` on Line 121 and deferred removals, the same key can be counted multiple times across swe... | e367804a0a51962c0198ac158c38ffc8db040912 | 752352241ce1e0a0a8aed9de174991cfbde3ecc8 | diff --git a/src/NLog/Internal/MruCache.cs b/src/NLog/Internal/MruCache.cs
index e9d76b4c99..2a77283968 100644
--- a/src/NLog/Internal/MruCache.cs
+++ b/src/NLog/Internal/MruCache.cs
@@ -34,6 +34,9 @@
namespace NLog.Internal
{
using System.Collections.Generic;
+#if !NET35
+ using System.Collections.Concurrent... | [
"src/NLog/Internal/MruCache.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_\n\n**De-duplicate NET35 prune candidates before decrementing `orgSize`.**\n\nLine 142 decrements `orgSize` before confirming the key is uniquely scheduled for removal. With `List<TKey>` on Line 121 and deferred removals, the same key can be counted... | true | ||
NLog/NLog | 6,207 | issue_to_patch | Reduce indent after adding NLog namespace in Examples | 96e3aad89a0d2cb637f0ccc2259cc6b819448899 | 5eb13a688cef431bac2bd859977a57e3e6f6ac2f | diff --git a/examples/ExtendingLoggers/InheritFromLogger/NLog.config b/examples/ExtendingLoggers/InheritFromLogger/NLog.config
index 5801bb1959..deadf7acd8 100644
--- a/examples/ExtendingLoggers/InheritFromLogger/NLog.config
+++ b/examples/ExtendingLoggers/InheritFromLogger/NLog.config
@@ -5,7 +5,7 @@
<targets>
... | [
"examples/ExtendingLoggers/InheritFromLogger/NLog.config",
"examples/ExtendingLoggers/InheritFromLogger/Program.cs",
"examples/ExtendingLoggers/LoggerWrapper/Program.cs",
"examples/ExtendingLoggers/README.html",
"examples/targets/Configuration API/AsyncWrapper/Wrapping File/Example.cs",
"examples/targets/... | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Script executed:\n\n```shell\n#!/bin/bash\n# Description: Check LogEventInfo for Context and Properties properties\n\n# Search for Context property definition in LogEventInfo\necho \"=== Searching for Contex... | true | |||
NLog/NLog | 6,207 | comment_to_fix | Reduce indent after adding NLog namespace in Examples | _โ ๏ธ Potential issue_ | _๐ Major_
<details>
<summary>๐งฉ Analysis chain</summary>
๐ Script executed:
```shell
#!/bin/bash
# Description: Check LogEventInfo for Context and Properties properties
# Search for Context property definition in LogEventInfo
echo "=== Searching for Context property ==="
rg -n -A5 -B2 'publ... | 96e3aad89a0d2cb637f0ccc2259cc6b819448899 | 5eb13a688cef431bac2bd859977a57e3e6f6ac2f | diff --git a/examples/ExtendingLoggers/InheritFromLogger/Program.cs b/examples/ExtendingLoggers/InheritFromLogger/Program.cs
index c1abf45e85..ee10a659d2 100644
--- a/examples/ExtendingLoggers/InheritFromLogger/Program.cs
+++ b/examples/ExtendingLoggers/InheritFromLogger/Program.cs
@@ -37,51 +37,51 @@
namespace NLog... | [
"examples/ExtendingLoggers/InheritFromLogger/Program.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Script executed:\n\n```shell\n#!/bin/bash\n# Description: Check LogEventInfo for Context and Properties properties\n\n# Search for Context property definition in LogEventInfo\necho \"=== Searching for Contex... | true | ||
NLog/NLog | 6,205 | issue_to_patch | TargetWithFilterChain - Increase CallSite MaxCapacity from 1000 to 2000 | Should still be below Large-Object-Heap-Threshold | 996d10cd2063701c9fb64fd81d059d44cdd51b34 | 750c56b303fdc569351c8da16306d26c9ec0f960 | diff --git a/src/NLog/Internal/TargetWithFilterChain.cs b/src/NLog/Internal/TargetWithFilterChain.cs
index 349b9a8236..4019bbd39a 100644
--- a/src/NLog/Internal/TargetWithFilterChain.cs
+++ b/src/NLog/Internal/TargetWithFilterChain.cs
@@ -339,7 +339,7 @@ internal bool TryLookupCallSiteClassName(LogEventInfo logEvent, o... | [
"src/NLog/Internal/TargetWithFilterChain.cs"
] | [] | true | ||
NLog/NLog | 6,204 | issue_to_patch | TemplateEnumerator - Replace LiteralHole with CurrentHole and CurrentLiteral | Reduce overhead of "huge" struct-copy of the combined `LiteralHole` | 8972e32578321ea159f9a5056cc2f6411e367a54 | c48168c8d8a76f9aa8fc0c2b21799814e595ef99 | diff --git a/appveyor.yml b/appveyor.yml
index 69fa8cef07..b52bf9fd6e 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -1,7 +1,7 @@
version: 6.0.0-{build} # Only change for mayor versions (e.g. 7.0)
image:
- Visual Studio 2022
- - Ubuntu2204
+ - Previous Ubuntu2204
configuration: Release
build: false
test: fal... | [
"appveyor.yml",
"src/NLog/Internal/LogMessageTemplateFormatter.cs",
"src/NLog/LogFactory.cs",
"src/NLog/LogManager.cs",
"src/NLog/Logger.cs",
"src/NLog/MessageTemplates/LiteralHole.cs",
"src/NLog/MessageTemplates/MessageTemplateParameters.cs",
"src/NLog/MessageTemplates/TemplateEnumerator.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_\n\n**Keep captured numeric holes classified as positional.**\n\n`ParseName()` and `MessageTemplateParameters` still treat `{`@0`}` / `{$0}` as positional because they only key off `hole.Index != -1`, but this helper now returns `false` for those sa... | true | ||
NLog/NLog | 6,204 | comment_to_fix | TemplateEnumerator - Replace LiteralHole with CurrentHole and CurrentLiteral | _โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_
**Keep captured numeric holes classified as positional.**
`ParseName()` and `MessageTemplateParameters` still treat `{`@0`}` / `{$0}` as positional because they only key off `hole.Index != -1`, but this helper now returns `false` for those same holes due to the `Captu... | 8972e32578321ea159f9a5056cc2f6411e367a54 | c48168c8d8a76f9aa8fc0c2b21799814e595ef99 | diff --git a/src/NLog/MessageTemplates/TemplateEnumerator.cs b/src/NLog/MessageTemplates/TemplateEnumerator.cs
index 4155093c0c..da165ee439 100644
--- a/src/NLog/MessageTemplates/TemplateEnumerator.cs
+++ b/src/NLog/MessageTemplates/TemplateEnumerator.cs
@@ -34,7 +34,6 @@
namespace NLog.MessageTemplates
{
using ... | [
"src/NLog/MessageTemplates/TemplateEnumerator.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_\n\n**Keep captured numeric holes classified as positional.**\n\n`ParseName()` and `MessageTemplateParameters` still treat `{`@0`}` / `{$0}` as positional because they only key off `hole.Index != -1`, but this helper now returns `false` for those sa... | true | ||
NLog/NLog | 6,202 | issue_to_patch | LogLevels - Restore ReadOnlyCollection to protect against evilness | Partial revert of #6174 | 182410f983da2ac1d239eb91da1cfca053a7b867 | 0588d93a5e0bc0d5748ade8f4166975412060608 | diff --git a/src/NLog/LogLevel.cs b/src/NLog/LogLevel.cs
index 4ace4d41e1..14c62d5f98 100644
--- a/src/NLog/LogLevel.cs
+++ b/src/NLog/LogLevel.cs
@@ -35,6 +35,7 @@ namespace NLog
{
using System;
using System.Collections.Generic;
+ using System.Collections.ObjectModel;
using System.ComponentModel;
... | [
"src/NLog/LogLevel.cs"
] | [] | true | ||
NLog/NLog | 6,199 | issue_to_patch | Fixed nullable warnings from Activator.CreateInstance | "Fixed" is maybe a big word, since using the "I give up" operator. | a58fc7c438d23ae5b2e2ffb6e69a1d09d660b613 | 82de37abc182fa01e9b61715ed078e1a41b2dd91 | diff --git a/src/NLog/Config/ConfigurationItemFactory.cs b/src/NLog/Config/ConfigurationItemFactory.cs
index 03d50bdb47..7785a143dc 100644
--- a/src/NLog/Config/ConfigurationItemFactory.cs
+++ b/src/NLog/Config/ConfigurationItemFactory.cs
@@ -297,6 +297,7 @@ public bool? ParseMessageTemplates
/// </summary>
... | [
"src/NLog/Config/ConfigurationItemFactory.cs",
"src/NLog/Internal/PropertiesDictionary.cs",
"src/NLog/Internal/PropertyHelper.cs",
"src/NLog/LayoutRenderers/ExceptionLayoutRenderer.cs",
"src/NLog/Layouts/LayoutParser.cs",
"src/NLog/SetupExtensionsBuilderExtensions.cs"
] | [] | true | ||
NLog/NLog | 6,198 | issue_to_patch | LoggingRule - Updated XML docs for Final to mention FinalMinLevel | f595114de28580d4ccb073f8cffd56a3ad58e1fa | 7a0a2727c00784bdb6a3ce857f472ac85dc84e3d | diff --git a/src/NLog/Config/LoggingRule.cs b/src/NLog/Config/LoggingRule.cs
index e13291dbc0..85049276f0 100644
--- a/src/NLog/Config/LoggingRule.cs
+++ b/src/NLog/Config/LoggingRule.cs
@@ -142,6 +142,7 @@ public LoggingRule(string loggerNamePattern, Target target)
/// <summary>
/// Gets or sets a va... | [
"src/NLog/Config/LoggingRule.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ก Minor_ | _โก Quick win_\n\n**Fix XML-doc grammar in `Final` remarks.**\n\nLine 145 reads awkwardly; use โAlternatively, use โฆโ for clear API docs.\n\n \n\n<details>\n<summary>Suggested doc wording</summary>\n\n```diff\n- /// <remarks>Alternative use <see cref=\"FinalMinLe... | true | |||
NLog/NLog | 6,197 | issue_to_patch | JsonAttribute - Constructor with JsonLayout and Encode = false | Reduce chance of errors, when using the NLog JsonLayout API for building a Json-Document. | 8cf58a8fa0dc223faffb348d1fc2fad40cba9fd3 | 70fd931e50574eba4f68dcc4f7219f56b71905e5 | diff --git a/src/NLog/Layouts/JSON/JsonAttribute.cs b/src/NLog/Layouts/JSON/JsonAttribute.cs
index b8e6e5977a..f9b98de20b 100644
--- a/src/NLog/Layouts/JSON/JsonAttribute.cs
+++ b/src/NLog/Layouts/JSON/JsonAttribute.cs
@@ -59,9 +59,16 @@ public JsonAttribute() : this(string.Empty, Layout.Empty, true) { }
/// I... | [
"src/NLog/Layouts/JSON/JsonAttribute.cs",
"tests/NLog.UnitTests/Layouts/JsonLayoutTests.cs"
] | [] | diff --git a/tests/NLog.UnitTests/Layouts/JsonLayoutTests.cs b/tests/NLog.UnitTests/Layouts/JsonLayoutTests.cs
index 20d4698e9c..83b9298e99 100644
--- a/tests/NLog.UnitTests/Layouts/JsonLayoutTests.cs
+++ b/tests/NLog.UnitTests/Layouts/JsonLayoutTests.cs
@@ -366,9 +366,7 @@ public void NestedJsonAttrDoesNotRenderEmptyL... | true | |
NLog/NLog | 6,195 | issue_to_patch | LoggingConfiguration - CheckUnusedTargets without Linq | **After:**
`ProcessPath: 'C:\projects\nlog\Tests\TestTrimPublish\bin\release\net8.0\win-X64\publish\TestTrimPublish.exe' with FileSize: 4774912`
**Before:**
`ProcessPath: 'C:\projects\nlog\Tests\TestTrimPublish\bin\release\net8.0\win-X64\publish\TestTrimPublish.exe' with FileSize: 4850688`
**NLog v6.1.3**
`Process... | 1ee2f84a031b81bc7c17fca120853919b2e7d2ff | c00c477580e9871125f05e2cbd8364c39453cf6f | diff --git a/src/NLog/Config/LoggingConfiguration.cs b/src/NLog/Config/LoggingConfiguration.cs
index e9bdc7ed3c..89e25f798c 100644
--- a/src/NLog/Config/LoggingConfiguration.cs
+++ b/src/NLog/Config/LoggingConfiguration.cs
@@ -116,7 +116,7 @@ public LoggingConfiguration(LogFactory logFactory)
private void AddL... | [
"src/NLog/Config/LoggingConfiguration.cs",
"src/NLog/Internal/CollectionExtensions.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_\n\n**Use thread-safe access for rule targets.**\n\nThis iterates `rule.Targets` directly, but other methods in this file (e.g., `GetAllTargetsToFlush` at line 713-720) use `rule.GetTargetsThreadSafe()` for thread-safe enumeration. If the rule's tar... | true | ||
NLog/NLog | 6,194 | issue_to_patch | Fix Sonar Code Smells in Unit Tests | 8a889f0dda1847bb22a54052e248a0276bfa3740 | 18a8e0c5bf0be57dbe3f655ee55220af388c0dff | [
"tests/NLog.UnitTests/Config/XmlConfigTests.cs",
"tests/NLog.UnitTests/LayoutRenderers/ExceptionDataLayoutRendererTests.cs"
] | [] | diff --git a/tests/NLog.UnitTests/Config/XmlConfigTests.cs b/tests/NLog.UnitTests/Config/XmlConfigTests.cs
index 6398bca418..06b0d8814c 100644
--- a/tests/NLog.UnitTests/Config/XmlConfigTests.cs
+++ b/tests/NLog.UnitTests/Config/XmlConfigTests.cs
@@ -285,7 +285,7 @@ public void XmlConfig_attributes_shouldNotLogWarnings... | true | |||
NLog/NLog | 6,193 | issue_to_patch | XmlLoggingConfiguration - Changed AutoReloadFileNames to use yield instead of Linq | **After:**
`ProcessPath: 'C:\projects\nlog\Tests\TestTrimPublish\bin\release\net8.0\win-X64\publish\TestTrimPublish.exe' with FileSize: 4850688`
**Before:**
`ProcessPath: 'C:\projects\nlog\Tests\TestTrimPublish\bin\release\net8.0\win-X64\publish\TestTrimPublish.exe' with FileSize: 4897792`
**NLog v6.1.3**
`Process... | 10ef77cda928a47a7732c32d9cb550e85e903994 | fe15f749ed413bcdcb08e151c680e9ca2330b993 | diff --git a/src/NLog/Config/XmlLoggingConfiguration.cs b/src/NLog/Config/XmlLoggingConfiguration.cs
index c6acaeeb9a..3b04bb8573 100644
--- a/src/NLog/Config/XmlLoggingConfiguration.cs
+++ b/src/NLog/Config/XmlLoggingConfiguration.cs
@@ -211,7 +211,16 @@ public IEnumerable<string> AutoReloadFileNames
... | [
"src/NLog/Config/XmlLoggingConfiguration.cs"
] | [] | true | ||
NLog/NLog | 6,192 | issue_to_patch | Target - FindAllLayouts using HashSet with ToArray instead of Linq Distinct | 049738c50a6d287847670c8b85e28719823cf03a | f50e4339d424ba6743c22ba23acf36a9b0dd6759 | diff --git a/src/NLog/Targets/Target.cs b/src/NLog/Targets/Target.cs
index 6abc1c3376..e7ece73fc6 100644
--- a/src/NLog/Targets/Target.cs
+++ b/src/NLog/Targets/Target.cs
@@ -549,7 +549,7 @@ private void FindAllLayouts()
var result = allLayouts.Aggregate(StackTraceUsage.None, (agg, layout) => agg | layou... | [
"src/NLog/Targets/Target.cs"
] | [] | true | |||
NLog/NLog | 6,191 | issue_to_patch | Fix Sonar Code Smells by adding NLog namespace to examples | 049738c50a6d287847670c8b85e28719823cf03a | 3c30363ccf1c4b14a981ddb2b90972e8544be65f | diff --git a/examples/ExtendingLoggers/InheritFromLogger/Program.cs b/examples/ExtendingLoggers/InheritFromLogger/Program.cs
index d0ddbb1e34..c1abf45e85 100644
--- a/examples/ExtendingLoggers/InheritFromLogger/Program.cs
+++ b/examples/ExtendingLoggers/InheritFromLogger/Program.cs
@@ -35,7 +35,7 @@
using System.Text;... | [
"examples/ExtendingLoggers/InheritFromLogger/Program.cs",
"examples/ExtendingLoggers/LoggerWrapper/Program.cs",
"examples/targets/Configuration API/AsyncWrapper/Wrapping File/Example.cs",
"examples/targets/Configuration API/AutoFlushWrapper/Simple/Example.cs",
"examples/targets/Configuration API/BufferingWr... | [] | diff --git a/tests/NLog.Benchmarks/Program.cs b/tests/NLog.Benchmarks/Program.cs
index d9d11a8b04..d54b772c2b 100644
--- a/tests/NLog.Benchmarks/Program.cs
+++ b/tests/NLog.Benchmarks/Program.cs
@@ -37,7 +37,7 @@ namespace NLog.Benchmarks
using BenchmarkDotNet.Diagnosers;
using BenchmarkDotNet.Running;
- ... | true | ||
NLog/NLog | 6,190 | issue_to_patch | SetupConfigurationTargetBuilder - Fix Sonar Code Smell | ec34b4712d150d1e800dc5beebea1880968a7a2f | cf67b76ce1f61b72bd29279806708b7df7138d6b | diff --git a/src/NLog/Internal/SetupConfigurationTargetBuilder.cs b/src/NLog/Internal/SetupConfigurationTargetBuilder.cs
index a7a8a25889..2e70f171bd 100644
--- a/src/NLog/Internal/SetupConfigurationTargetBuilder.cs
+++ b/src/NLog/Internal/SetupConfigurationTargetBuilder.cs
@@ -41,7 +41,7 @@ namespace NLog.Internal
... | [
"src/NLog/Internal/SetupConfigurationTargetBuilder.cs"
] | [] | true | |||
NLog/NLog | 6,189 | issue_to_patch | Fix Sonar Code Smells in PowerShell Scripts | 254d962ab401254bcbd2d59df06e3cffb2c492ff | 470d169568c6d6e7f8deb4f538d00519d00fbc75 | diff --git a/Test-XmlFile.ps1 b/Test-XmlFile.ps1
index c194310fd7..31e6428369 100644
--- a/Test-XmlFile.ps1
+++ b/Test-XmlFile.ps1
@@ -9,7 +9,7 @@ function Test-XmlFile
PS> dir *.xml | Test-XmlFile schema.xsd
#>
[CmdletBinding()]
- param (
+ param (
[Parameter(Mandatory=$true)]
... | [
"Test-XmlFile.ps1",
"build.ps1",
"run-tests.ps1"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Web query:\n\n`In PowerShell, how is `if (-not $LastExitCode -eq 1)` evaluated, and what is the recommended idiomatic expression for \"LastExitCode is not 1\"?`\n\n๐ก Result:\n\nIn PowerShell... | true | |||
NLog/NLog | 6,189 | comment_to_fix | Fix Sonar Code Smells in PowerShell Scripts | _โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_
<details>
<summary>๐งฉ Analysis chain</summary>
๐ Web query:
`In PowerShell, how is `if (-not $LastExitCode -eq 1)` evaluated, and what is the recommended idiomatic expression for "LastExitCode is not 1"?`
๐ก Result:
In PowerShell, `if (-not $LastExitCode -eq 1)` i... | 254d962ab401254bcbd2d59df06e3cffb2c492ff | 470d169568c6d6e7f8deb4f538d00519d00fbc75 | diff --git a/run-tests.ps1 b/run-tests.ps1
index 22a10432cd..15df770be7 100644
--- a/run-tests.ps1
+++ b/run-tests.ps1
@@ -1,57 +1,58 @@
dotnet restore ./tests/NLog.UnitTests/
-if (-Not $LastExitCode -eq 0)
+if (-not $LastExitCode -eq 0)
{ exit $LastExitCode }
dotnet test ./tests/NLog.UnitTests/ --framework net8.... | [
"run-tests.ps1"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Web query:\n\n`In PowerShell, how is `if (-not $LastExitCode -eq 1)` evaluated, and what is the recommended idiomatic expression for \"LastExitCode is not 1\"?`\n\n๐ก Result:\n\nIn PowerShell... | true | ||
NLog/NLog | 6,189 | comment_to_fix | Fix Sonar Code Smells in PowerShell Scripts | _โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_
**Add an immediate exit-code guard after the AtomicFile pack step.**
`msbuild` at Line 41 is not checked before calling `Create-Package` at Line 42, so a failed AtomicFile pack can be hidden by a later successful command.
<details>
<summary>Proposed fix</summary>
... | 254d962ab401254bcbd2d59df06e3cffb2c492ff | 470d169568c6d6e7f8deb4f538d00519d00fbc75 | diff --git a/build.ps1 b/build.ps1
index f479abea13..329757acb8 100644
--- a/build.ps1
+++ b/build.ps1
@@ -6,7 +6,7 @@ $versionPrefix = "6.1.3"
$versionSuffix = ""
$versionFile = $versionPrefix + "." + ${env:APPVEYOR_BUILD_NUMBER}
$versionProduct = $versionPrefix;
-if (-Not $versionSuffix.Equals(""))
+if (-not $vers... | [
"build.ps1"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_\n\n**Add an immediate exit-code guard after the AtomicFile pack step.**\n\n`msbuild` at Line 41 is not checked before calling `Create-Package` at Line 42, so a failed AtomicFile pack can be hidden by a later successful command.\n\n \n\n<details>\n<... | true | ||
NLog/NLog | 6,189 | comment_to_fix | Fix Sonar Code Smells in PowerShell Scripts | _โ ๏ธ Potential issue_ | _๐ก Minor_ | _โก Quick win_
<details>
<summary>๐งฉ Analysis chain</summary>
๐ Web query:
`PowerShell approved verbs list: is "Create" an approved function verb, and what approved verb should be used instead for a function currently named "Create-Package"?`
๐ก Result:
Yes. In the current Micro... | 254d962ab401254bcbd2d59df06e3cffb2c492ff | 470d169568c6d6e7f8deb4f538d00519d00fbc75 | diff --git a/build.ps1 b/build.ps1
index f479abea13..329757acb8 100644
--- a/build.ps1
+++ b/build.ps1
@@ -6,7 +6,7 @@ $versionPrefix = "6.1.3"
$versionSuffix = ""
$versionFile = $versionPrefix + "." + ${env:APPVEYOR_BUILD_NUMBER}
$versionProduct = $versionPrefix;
-if (-Not $versionSuffix.Equals(""))
+if (-not $vers... | [
"build.ps1"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ก Minor_ | _โก Quick win_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Web query:\n\n`PowerShell approved verbs list: is \"Create\" an approved function verb, and what approved verb should be used instead for a function currently named \"Create-Package\"?`\n\n๐ก... | true | ||
NLog/NLog | 6,189 | comment_to_fix | Fix Sonar Code Smells in PowerShell Scripts | _โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_
<details>
<summary>๐งฉ Analysis chain</summary>
๐ Web query:
`In PowerShell, how is `if (-not $LastExitCode -eq 0)` parsed by operator precedence, and what is the idiomatic equivalent for "exit code is not zero"?`
๐ก Result:
`if (-not $LastExitCode -eq 0)` is parse... | 254d962ab401254bcbd2d59df06e3cffb2c492ff | 470d169568c6d6e7f8deb4f538d00519d00fbc75 | diff --git a/build.ps1 b/build.ps1
index f479abea13..329757acb8 100644
--- a/build.ps1
+++ b/build.ps1
@@ -6,7 +6,7 @@ $versionPrefix = "6.1.3"
$versionSuffix = ""
$versionFile = $versionPrefix + "." + ${env:APPVEYOR_BUILD_NUMBER}
$versionProduct = $versionPrefix;
-if (-Not $versionSuffix.Equals(""))
+if (-not $vers... | [
"build.ps1"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Web query:\n\n`In PowerShell, how is `if (-not $LastExitCode -eq 0)` parsed by operator precedence, and what is the idiomatic equivalent for \"exit code is not zero\"?`\n\n๐ก Result:\n\n`if (... | true | ||
NLog/NLog | 6,188 | issue_to_patch | ConfigurationItemFactory - Skip upfront Dictionary creation for type properties | Besides simplifying code, then removing the last System.Linq.ToDictionary has reduced AOT filesize. | a69890f75c081567e047efb1ed91c5153634378f | 4c7ccd247edd50cd0b6754765b4e3d56890895f0 | diff --git a/src/NLog/Config/ConfigurationItemFactory.cs b/src/NLog/Config/ConfigurationItemFactory.cs
index 8e38262a3b..03d50bdb47 100644
--- a/src/NLog/Config/ConfigurationItemFactory.cs
+++ b/src/NLog/Config/ConfigurationItemFactory.cs
@@ -78,10 +78,10 @@ public sealed class ConfigurationItemFactory
#endif
... | [
"src/NLog/Config/ConfigurationItemFactory.cs",
"src/NLog/Internal/PropertyHelper.cs"
] | [] | true | ||
NLog/NLog | 6,183 | issue_to_patch | Reduce AOT build size by excluding legacy ComponentModel.TypeDescriptor | **After:**
`ProcessPath: 'C:\projects\nlog\tests\TestTrimPublish\bin\release\net8.0\win-x64\publish\TestTrimPublish.exe' with FileSize: 4982272`
**Before:**
`ProcessPath: 'C:\projects\nlog\tests\TestTrimPublish\bin\release\net8.0\win-x64\publish\TestTrimPublish.exe' with FileSize: 5448192`
**NLog v6.1.3**
`Process... | dd16d5e045529e32fef72a458c76446a659ed13f | 4d705222e301e1ea7314fbaa7e25d1329ec099d1 | diff --git a/src/NLog/Config/Factory.cs b/src/NLog/Config/Factory.cs
index 0d0f79cf8f..5cd13f6fbe 100644
--- a/src/NLog/Config/Factory.cs
+++ b/src/NLog/Config/Factory.cs
@@ -151,7 +151,7 @@ public void RegisterNamedType(string itemName, string typeName, bool checkTypeEx
Func<TBaseType?> typeCreator = () =... | [
"src/NLog/Config/Factory.cs",
"src/NLog/Config/PropertyTypeConverter.cs",
"src/NLog/Internal/PropertyHelper.cs",
"src/NLog/Internal/ReflectionHelpers.cs",
"src/NLog/LayoutRenderers/CounterLayoutRenderer.cs",
"src/NLog/LayoutRenderers/InstallContextLayoutRenderer.cs",
"src/NLog/Layouts/Typed/ValueTypeLay... | [] | true | ||
NLog/NLog | 6,185 | issue_to_patch | Changed from System.Linq to yield engine to reduce AOT filesize | Focus on not using System.Linq on generic-collections with non-standard item-type.
**After:**
`ProcessPath: 'C:\projects\nlog\tests\TestTrimPublish\bin\release\net8.0\win-x64\publish\TestTrimPublish.exe' with FileSize: 4927488`
**Before:**
`ProcessPath: 'C:\projects\nlog\tests\TestTrimPublish\bin\release\net8.0... | 3c1aedde9e68b8c91147319d1d02701778429ba2 | 778ad7c2d1d6e71a197a126c94213e5a14bad4c6 | diff --git a/src/NLog/Config/LoggingConfigurationElementExtensions.cs b/src/NLog/Config/LoggingConfigurationElementExtensions.cs
index 0570ed7602..8f800078f3 100644
--- a/src/NLog/Config/LoggingConfigurationElementExtensions.cs
+++ b/src/NLog/Config/LoggingConfigurationElementExtensions.cs
@@ -36,7 +36,6 @@ namespace N... | [
"src/NLog/Config/LoggingConfigurationElementExtensions.cs",
"src/NLog/Config/XmlLoggingConfigurationElement.cs",
"src/NLog/Config/XmlParserConfigurationElement.cs",
"src/NLog/Layouts/Layout.cs",
"src/NLog/Layouts/XML/XmlElementBase.cs",
"tests/TestTrimPublish/TestTrimPublish.csproj"
] | [] | diff --git a/tests/TestTrimPublish/TestTrimPublish.csproj b/tests/TestTrimPublish/TestTrimPublish.csproj
index 1498144bea..ff43c584fd 100644
--- a/tests/TestTrimPublish/TestTrimPublish.csproj
+++ b/tests/TestTrimPublish/TestTrimPublish.csproj
@@ -20,6 +20,7 @@
<EnableTrimAnalyzer>true</EnableTrimAnalyzer>
<Pu... | true | |
NLog/NLog | 6,177 | issue_to_patch | Reduce AOT file-size by skipping ToList clone for Dictionary | AOT file-size increase with every declared generic-type-instance, along with bonus code from System.Linq. | b1ede3ed7d071aa18ecbf80a033211e4f2d932be | b5938f103ad821e8cce4b441f5461993bbbf96dc | diff --git a/src/NLog/Conditions/ConditionRelationalExpression.cs b/src/NLog/Conditions/ConditionRelationalExpression.cs
index 431880d682..fa20dc2424 100644
--- a/src/NLog/Conditions/ConditionRelationalExpression.cs
+++ b/src/NLog/Conditions/ConditionRelationalExpression.cs
@@ -272,7 +272,7 @@ private static int GetOrd... | [
"src/NLog/Conditions/ConditionRelationalExpression.cs",
"src/NLog/Config/ConfigurationItemFactory.cs",
"src/NLog/Config/LoggingConfiguration.cs",
"src/NLog/Config/XmlLoggingConfiguration.cs",
"src/NLog/Config/XmlParserConfigurationElement.cs",
"src/NLog/Internal/CollectionExtensions.cs",
"src/NLog/Inter... | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ก Minor_ | _โก Quick win_\n\n**Add null parameter validation.**\n\nThe method accesses `items.Count` and calls `items.CopyTo` without validating that `items` is non-null, which will throw `NullReferenceException` if a null collection is passed.\n\n\n<details>\n<summary>๐ก๏ธ ... | true | ||
NLog/NLog | 6,176 | issue_to_patch | TryNLogSpecificConversion - Refactor parsing Layout from string | 68aa2cc92e1d3dea4573a82efd9155c7b75ce42c | 2e3f32e8df890bef1f219928dee48a50b094c52c | diff --git a/src/NLog/Internal/PropertyHelper.cs b/src/NLog/Internal/PropertyHelper.cs
index 474416af7f..1de5950870 100644
--- a/src/NLog/Internal/PropertyHelper.cs
+++ b/src/NLog/Internal/PropertyHelper.cs
@@ -257,7 +257,7 @@ private static bool TryNLogSpecificConversion(Type propertyType, string value, C
{
... | [
"src/NLog/Internal/PropertyHelper.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ก Minor_ | _โก Quick win_\n\n**Handle whitespace-only layout values as default.**\n\nLine 295 uses `string.IsNullOrEmpty`, so `\" \"` becomes `new SimpleLayout(\" \")` instead of `SimpleLayout.Default`. If whitespace should be treated as empty for this refactor contract... | true | |||
NLog/NLog | 6,176 | comment_to_fix | TryNLogSpecificConversion - Refactor parsing Layout from string | _โ ๏ธ Potential issue_ | _๐ก Minor_ | _โก Quick win_
**Handle whitespace-only layout values as default.**
Line 295 uses `string.IsNullOrEmpty`, so `" "` becomes `new SimpleLayout(" ")` instead of `SimpleLayout.Default`. If whitespace should be treated as empty for this refactor contract, switch to a whitespace check... | 68aa2cc92e1d3dea4573a82efd9155c7b75ce42c | 2e3f32e8df890bef1f219928dee48a50b094c52c | diff --git a/src/NLog/Internal/PropertyHelper.cs b/src/NLog/Internal/PropertyHelper.cs
index 474416af7f..1de5950870 100644
--- a/src/NLog/Internal/PropertyHelper.cs
+++ b/src/NLog/Internal/PropertyHelper.cs
@@ -257,7 +257,7 @@ private static bool TryNLogSpecificConversion(Type propertyType, string value, C
{
... | [
"src/NLog/Internal/PropertyHelper.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ก Minor_ | _โก Quick win_\n\n**Handle whitespace-only layout values as default.**\n\nLine 295 uses `string.IsNullOrEmpty`, so `\" \"` becomes `new SimpleLayout(\" \")` instead of `SimpleLayout.Default`. If whitespace should be treated as empty for this refactor contract... | true | ||
NLog/NLog | 6,174 | issue_to_patch | PropertyTypeConverter - Avoid allocating dictionary for conversion mapping until needed | Reducing upfront type-dependency resolving until actually needed (entering mapping-method)
Parsing Enum from empty string (or null) now fails upfront, instead of scanning for other conversions and casting. | 7f18a90739535f5ddc71c48e0fa28c59e5ee8969 | cdb55cb1856056ea36b86e637f064bb4e08b2661 | diff --git a/src/NLog/Config/LoggingConfiguration.cs b/src/NLog/Config/LoggingConfiguration.cs
index 4e8e9b058a..9b295d9a8f 100644
--- a/src/NLog/Config/LoggingConfiguration.cs
+++ b/src/NLog/Config/LoggingConfiguration.cs
@@ -851,45 +851,45 @@ internal string ExpandSimpleVariables(string? input)
internal st... | [
"src/NLog/Config/LoggingConfiguration.cs",
"src/NLog/Config/PropertyTypeConverter.cs",
"src/NLog/Internal/PropertyHelper.cs",
"src/NLog/LogLevel.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_\n\n**Don't turn an explicit empty `Layout<T>` into the default layout.**\n\nThis branch treats `\"\"` differently from the `Layout`/`SimpleLayout` path above: those map empty input to the empty-layout sentinel, but `Layout<T>` maps it to `SimpleLay... | true | ||
NLog/NLog | 6,174 | comment_to_fix | PropertyTypeConverter - Avoid allocating dictionary for conversion mapping until needed | _โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_
**Don't turn an explicit empty `Layout<T>` into the default layout.**
This branch treats `""` differently from the `Layout`/`SimpleLayout` path above: those map empty input to the empty-layout sentinel, but `Layout<T>` maps it to `SimpleLayout.Default`. That changes t... | 7f18a90739535f5ddc71c48e0fa28c59e5ee8969 | cdb55cb1856056ea36b86e637f064bb4e08b2661 | diff --git a/src/NLog/Internal/PropertyHelper.cs b/src/NLog/Internal/PropertyHelper.cs
index 44a423f0a2..474416af7f 100644
--- a/src/NLog/Internal/PropertyHelper.cs
+++ b/src/NLog/Internal/PropertyHelper.cs
@@ -36,7 +36,6 @@ namespace NLog.Internal
using System;
using System.Collections;
using System.Col... | [
"src/NLog/Internal/PropertyHelper.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _โก Quick win_\n\n**Don't turn an explicit empty `Layout<T>` into the default layout.**\n\nThis branch treats `\"\"` differently from the `Layout`/`SimpleLayout` path above: those map empty input to the empty-layout sentinel, but `Layout<T>` maps it to `SimpleLay... | true | ||
NLog/NLog | 6,008 | issue_to_patch | LoggerImpl - Merge WriteToTargetWithFilterChain into Write | Inlines WriteToTargetWithFilterChain to reduce NLog-callstack-length. | 8d726788ac99d99bc10f303dd3948604cd8d699e | 0652f361cbf20d301c2c99762e32ef8716fd2b04 | diff --git a/src/NLog/Internal/TargetWithFilterChain.cs b/src/NLog/Internal/TargetWithFilterChain.cs
index 80c42d5050..6948f78f52 100644
--- a/src/NLog/Internal/TargetWithFilterChain.cs
+++ b/src/NLog/Internal/TargetWithFilterChain.cs
@@ -311,34 +311,6 @@ private static bool SuppressLogLevel(LoggingRule rule, bool[] ru... | [
"src/NLog/Internal/TargetWithFilterChain.cs",
"src/NLog/LoggerImpl.cs"
] | [
{
"comment": "_๐ ๏ธ Refactor suggestion_ | _๐ Major_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n**Verify call-site capture also covers filter requirements**\n\nGate is based on targetsForLevel.StackTraceUsage. Per TargetWithFilterChain.PrecalculateStackTraceUsage summary, this ORs Target.StackTraceUs... | true | ||
NLog/NLog | 6,008 | comment_to_fix | LoggerImpl - Merge WriteToTargetWithFilterChain into Write | _๐ ๏ธ Refactor suggestion_ | _๐ Major_
<details>
<summary>๐งฉ Analysis chain</summary>
**Verify call-site capture also covers filter requirements**
Gate is based on targetsForLevel.StackTraceUsage. Per TargetWithFilterChain.PrecalculateStackTraceUsage summary, this ORs Target.StackTraceUsage, not filter needs. If any... | 8d726788ac99d99bc10f303dd3948604cd8d699e | 0652f361cbf20d301c2c99762e32ef8716fd2b04 | diff --git a/src/NLog/LoggerImpl.cs b/src/NLog/LoggerImpl.cs
index 5a585b3ef8..bb88d2cb9f 100644
--- a/src/NLog/LoggerImpl.cs
+++ b/src/NLog/LoggerImpl.cs
@@ -52,23 +52,9 @@ internal static void Write(Type loggerType, TargetWithFilterChain targetsForLeve
{
logEvent.SetMessageFormatter(logFactory.A... | [
"src/NLog/LoggerImpl.cs"
] | [
{
"comment": "_๐ ๏ธ Refactor suggestion_ | _๐ Major_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n**Verify call-site capture also covers filter requirements**\n\nGate is based on targetsForLevel.StackTraceUsage. Per TargetWithFilterChain.PrecalculateStackTraceUsage summary, this ORs Target.StackTraceUs... | true | ||
NLog/NLog | 6,008 | comment_to_fix | LoggerImpl - Merge WriteToTargetWithFilterChain into Write | _โ ๏ธ Potential issue_ | _๐ Major_
**Cache key misses FilterDefaultAction; potential mis-routing across same filterChain**
Result reuse is keyed only by reference-equality of the filterChain. If two TargetWithFilterChain instances share the same FilterChain object but have different FilterDefaultAction, then when no f... | 8d726788ac99d99bc10f303dd3948604cd8d699e | 0652f361cbf20d301c2c99762e32ef8716fd2b04 | diff --git a/src/NLog/LoggerImpl.cs b/src/NLog/LoggerImpl.cs
index 5a585b3ef8..bb88d2cb9f 100644
--- a/src/NLog/LoggerImpl.cs
+++ b/src/NLog/LoggerImpl.cs
@@ -52,23 +52,9 @@ internal static void Write(Type loggerType, TargetWithFilterChain targetsForLeve
{
logEvent.SetMessageFormatter(logFactory.A... | [
"src/NLog/LoggerImpl.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_\n\n**Cache key misses FilterDefaultAction; potential mis-routing across same filterChain**\n\nResult reuse is keyed only by reference-equality of the filterChain. If two TargetWithFilterChain instances share the same FilterChain object but have different FilterDef... | true | ||
NLog/NLog | 6,138 | issue_to_patch | INoAllocationStringValueRenderer should skip precalculate Layout
There is a lot of memory-allocation when needing to perform thread-context-capture. When NLog sees too many Properties on LogEventInfo, then it skips checking if all properties are immutable, and automatically assumes the entire LogEventInfo as mutable/d... | SimpleLayout skip Precalculate when INoAllocationStringValueRenderer available | ## Summary
Optimize async logging by skipping `Precalculate` when `INoAllocationStringValueRenderer` is available.
## Problem
When async logging is used, NLog calls `Precalculate` on the app thread to capture thread-context before handing the log event to a background thread. This causes memory allocations even wh... | a576c17fd3b8b2c4f62eae82e9d61a512f008721 | d4f95dc310f86540c5a5c0eb62eca359a9d9524a | diff --git a/src/NLog/Layouts/Layout.cs b/src/NLog/Layouts/Layout.cs
index 49ec46f594..7b4185c2de 100644
--- a/src/NLog/Layouts/Layout.cs
+++ b/src/NLog/Layouts/Layout.cs
@@ -93,7 +93,7 @@ public static implicit operator Layout([Localizable(false)] string text)
{
if (text is null)
... | [
"src/NLog/Layouts/Layout.cs",
"src/NLog/Layouts/SimpleLayout.cs",
"tests/NLog.UnitTests/Layouts/SimpleLayoutOutputTests.cs"
] | [
{
"comment": "Seems this logic will cause a JsonLayout to skip precalculation of inner SimpleLayout that only includes INoAllocationStringValueRenderer. So when the NLog Target precalculates the JsonLayout, then it will not check the SimpleLayout.",
"path": "src/NLog/Layouts/Layout.cs",
"hunk": "@@ -421... | diff --git a/tests/NLog.UnitTests/Layouts/SimpleLayoutOutputTests.cs b/tests/NLog.UnitTests/Layouts/SimpleLayoutOutputTests.cs
index c83daddd32..8bed84bf90 100644
--- a/tests/NLog.UnitTests/Layouts/SimpleLayoutOutputTests.cs
+++ b/tests/NLog.UnitTests/Layouts/SimpleLayoutOutputTests.cs
@@ -288,5 +288,21 @@ protected ov... | true |
NLog/NLog | 6,138 | comment_to_fix | SimpleLayout skip Precalculate when INoAllocationStringValueRenderer available | Seems this logic will cause a JsonLayout to skip precalculation of inner SimpleLayout that only includes INoAllocationStringValueRenderer. So when the NLog Target precalculates the JsonLayout, then it will not check the SimpleLayout. | a576c17fd3b8b2c4f62eae82e9d61a512f008721 | d4f95dc310f86540c5a5c0eb62eca359a9d9524a | diff --git a/src/NLog/Layouts/Layout.cs b/src/NLog/Layouts/Layout.cs
index 49ec46f594..7b4185c2de 100644
--- a/src/NLog/Layouts/Layout.cs
+++ b/src/NLog/Layouts/Layout.cs
@@ -93,7 +93,7 @@ public static implicit operator Layout([Localizable(false)] string text)
{
if (text is null)
... | [
"src/NLog/Layouts/Layout.cs"
] | [
{
"comment": "Seems this logic will cause a JsonLayout to skip precalculation of inner SimpleLayout that only includes INoAllocationStringValueRenderer. So when the NLog Target precalculates the JsonLayout, then it will not check the SimpleLayout.",
"path": "src/NLog/Layouts/Layout.cs",
"hunk": "@@ -421... | true | ||
NLog/NLog | 6,138 | comment_to_fix | SimpleLayout skip Precalculate when INoAllocationStringValueRenderer available | Instead of enumerating all `_layoutRenderers` then maybe only support single item, similar to `_rawValueRenderer` ? Ex. `${message}` (So skipping enumeration and casting) | a576c17fd3b8b2c4f62eae82e9d61a512f008721 | d4f95dc310f86540c5a5c0eb62eca359a9d9524a | diff --git a/src/NLog/Layouts/SimpleLayout.cs b/src/NLog/Layouts/SimpleLayout.cs
index 54d11cecee..960945a089 100644
--- a/src/NLog/Layouts/SimpleLayout.cs
+++ b/src/NLog/Layouts/SimpleLayout.cs
@@ -60,6 +60,7 @@ namespace NLog.Layouts
public sealed class SimpleLayout : Layout, IUsesStackTrace, IStringValueRendere... | [
"src/NLog/Layouts/SimpleLayout.cs"
] | [
{
"comment": "Instead of enumerating all `_layoutRenderers` then maybe only support single item, similar to `_rawValueRenderer` ? Ex. `${message}` (So skipping enumeration and casting)",
"path": "src/NLog/Layouts/SimpleLayout.cs",
"hunk": "@@ -348,9 +347,49 @@ private bool PrecalculateMustRenderLayoutVa... | true | ||
NLog/NLog | 6,138 | comment_to_fix | SimpleLayout skip Precalculate when INoAllocationStringValueRenderer available | Instead of creating your own custom `LayoutRenderer` for the uni-test, why not verify the logic using the existing `MessageLayoutRenderer` ? | a576c17fd3b8b2c4f62eae82e9d61a512f008721 | d4f95dc310f86540c5a5c0eb62eca359a9d9524a | diff --git a/tests/NLog.UnitTests/Layouts/SimpleLayoutOutputTests.cs b/tests/NLog.UnitTests/Layouts/SimpleLayoutOutputTests.cs
index c83daddd32..8bed84bf90 100644
--- a/tests/NLog.UnitTests/Layouts/SimpleLayoutOutputTests.cs
+++ b/tests/NLog.UnitTests/Layouts/SimpleLayoutOutputTests.cs
@@ -288,5 +288,21 @@ protected ov... | [
"tests/NLog.UnitTests/Layouts/SimpleLayoutOutputTests.cs"
] | [
{
"comment": "Instead of creating your own custom `LayoutRenderer` for the uni-test, why not verify the logic using the existing `MessageLayoutRenderer` ?",
"path": "tests/NLog.UnitTests/Layouts/SimpleLayoutOutputTests.cs",
"hunk": "@@ -288,5 +288,60 @@ protected override string GetFormattedMessage(LogE... | true | ||
NLog/NLog | 6,138 | comment_to_fix | SimpleLayout skip Precalculate when INoAllocationStringValueRenderer available | `since it avoids both StringBuilder AND string allocation during preca` -> `since it can avoid both StringBuilder and AddCachedLayoutValue` | a576c17fd3b8b2c4f62eae82e9d61a512f008721 | d4f95dc310f86540c5a5c0eb62eca359a9d9524a | diff --git a/src/NLog/Layouts/SimpleLayout.cs b/src/NLog/Layouts/SimpleLayout.cs
index 54d11cecee..960945a089 100644
--- a/src/NLog/Layouts/SimpleLayout.cs
+++ b/src/NLog/Layouts/SimpleLayout.cs
@@ -60,6 +60,7 @@ namespace NLog.Layouts
public sealed class SimpleLayout : Layout, IUsesStackTrace, IStringValueRendere... | [
"src/NLog/Layouts/SimpleLayout.cs"
] | [
{
"comment": "`since it avoids both StringBuilder AND string allocation during preca` -> `since it can avoid both StringBuilder and AddCachedLayoutValue`",
"path": "src/NLog/Layouts/SimpleLayout.cs",
"hunk": "@@ -336,11 +339,16 @@ private bool PrecalculateMustRenderLayoutValue(LogEventInfo logEvent)\n ... | true | ||
NLog/NLog | 6,169 | issue_to_patch | Version 6.1.3 | ad9f94a56e908f9385ba10676a42911eb8e24c36 | ff69937a98a5e5f6b60b1fb3cbdd06ad7b06387b | diff --git a/CHANGELOG.md b/CHANGELOG.md
index fe74d200e8..5398366190 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,23 @@ Date format: (year/month/day)
## Change Log
+### Version 6.1.3 (2026/05/04)
+**Improvements**
+- [#6168](https://github.com/NLog/NLog/pull/6168) PropertiesDictionary - Preserve Messag... | [
"CHANGELOG.md",
"build.ps1",
"src/NLog/NLog.csproj"
] | [] | true | |||
NLog/NLog | 6,165 | issue_to_patch | AsyncTaskTarget - Retry with help from Task.Delay | Task.Delay should not steal threads from the ThreadPool. Also reduced allocations of TaskCompletionSource-objects when recovery is enabled but not needed.
Made an observation that retry-logic is never triggered when hitting TaskTimeoutSeconds. The entire retry-execution must happen within TaskTimeoutSeconds, as the ... | a3c7b57f14029c1d8fcab80edba02e16280be1dc | 7eb16d7d6ded06ce7cb7c7348c11565675d75b73 | diff --git a/src/NLog/Targets/AsyncTaskTarget.cs b/src/NLog/Targets/AsyncTaskTarget.cs
index cf2f021d68..5f9cc82d0b 100644
--- a/src/NLog/Targets/AsyncTaskTarget.cs
+++ b/src/NLog/Targets/AsyncTaskTarget.cs
@@ -263,7 +263,7 @@ protected virtual Task WriteAsyncTask(IList<LogEventInfo> logEvents, Cancellatio
... | [
"src/NLog/Targets/AsyncTaskTarget.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Script executed:\n\n```shell\n# First, let's examine the actual code at line 266\ncat -n src/NLog/Targets/AsyncTaskTarget.cs | sed -n '260,275p'\n```\n\nRepository: NLog/NLog\n\nLength of output: 943\n\n---\... | true | ||
NLog/NLog | 6,165 | comment_to_fix | AsyncTaskTarget - Retry with help from Task.Delay | _โ ๏ธ Potential issue_ | _๐ Major_
<details>
<summary>๐งฉ Analysis chain</summary>
๐ Script executed:
```shell
# First, let's examine the actual code at line 266
cat -n src/NLog/Targets/AsyncTaskTarget.cs | sed -n '260,275p'
```
Repository: NLog/NLog
Length of output: 943
---
๐ Script executed:
```shell
# Let's... | a3c7b57f14029c1d8fcab80edba02e16280be1dc | 7eb16d7d6ded06ce7cb7c7348c11565675d75b73 | diff --git a/src/NLog/Targets/AsyncTaskTarget.cs b/src/NLog/Targets/AsyncTaskTarget.cs
index cf2f021d68..5f9cc82d0b 100644
--- a/src/NLog/Targets/AsyncTaskTarget.cs
+++ b/src/NLog/Targets/AsyncTaskTarget.cs
@@ -263,7 +263,7 @@ protected virtual Task WriteAsyncTask(IList<LogEventInfo> logEvents, Cancellatio
... | [
"src/NLog/Targets/AsyncTaskTarget.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Script executed:\n\n```shell\n# First, let's examine the actual code at line 266\ncat -n src/NLog/Targets/AsyncTaskTarget.cs | sed -n '260,275p'\n```\n\nRepository: NLog/NLog\n\nLength of output: 943\n\n---\... | true | ||
NLog/NLog | 6,165 | comment_to_fix | AsyncTaskTarget - Retry with help from Task.Delay | _โ ๏ธ Potential issue_ | _๐ Major_
<details>
<summary>๐งฉ Analysis chain</summary>
๐ Script executed:
```shell
find . -name "AsyncTaskTarget.cs" -type f
```
Repository: NLog/NLog
Length of output: 90
---
๐ Script executed:
```shell
wc -l ./src/NLog/Targets/AsyncTaskTarget.cs
```
Repository: NLog/NLog
Length o... | a3c7b57f14029c1d8fcab80edba02e16280be1dc | 7eb16d7d6ded06ce7cb7c7348c11565675d75b73 | diff --git a/src/NLog/Targets/AsyncTaskTarget.cs b/src/NLog/Targets/AsyncTaskTarget.cs
index cf2f021d68..5f9cc82d0b 100644
--- a/src/NLog/Targets/AsyncTaskTarget.cs
+++ b/src/NLog/Targets/AsyncTaskTarget.cs
@@ -263,7 +263,7 @@ protected virtual Task WriteAsyncTask(IList<LogEventInfo> logEvents, Cancellatio
... | [
"src/NLog/Targets/AsyncTaskTarget.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Script executed:\n\n```shell\nfind . -name \"AsyncTaskTarget.cs\" -type f\n```\n\nRepository: NLog/NLog\n\nLength of output: 90\n\n---\n\n๐ Script executed:\n\n```shell\nwc -l ./src/NLog/Targets/AsyncTaskTa... | true | ||
NLog/NLog | 6,165 | comment_to_fix | AsyncTaskTarget - Retry with help from Task.Delay | _โ ๏ธ Potential issue_ | _๐ด Critical_
<details>
<summary>๐งฉ Analysis chain</summary>
๐ Script executed:
```shell
#!/bin/bash
# Verify NET45 compatibility guards around Task.FromException usage.
rg -n -C 4 'Task\.FromException' src/NLog/Targets/AsyncTaskTarget.cs
rg -n -C 2 '#if NET45|#if !NET45' src/NLog/Targets/Asy... | a3c7b57f14029c1d8fcab80edba02e16280be1dc | 7eb16d7d6ded06ce7cb7c7348c11565675d75b73 | diff --git a/src/NLog/Targets/AsyncTaskTarget.cs b/src/NLog/Targets/AsyncTaskTarget.cs
index cf2f021d68..5f9cc82d0b 100644
--- a/src/NLog/Targets/AsyncTaskTarget.cs
+++ b/src/NLog/Targets/AsyncTaskTarget.cs
@@ -263,7 +263,7 @@ protected virtual Task WriteAsyncTask(IList<LogEventInfo> logEvents, Cancellatio
... | [
"src/NLog/Targets/AsyncTaskTarget.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ด Critical_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Script executed:\n\n```shell\n#!/bin/bash\n# Verify NET45 compatibility guards around Task.FromException usage.\nrg -n -C 4 'Task\\.FromException' src/NLog/Targets/AsyncTaskTarget.cs\nrg -n -C 2 '#if NET4... | true | ||
NLog/NLog | 6,165 | comment_to_fix | AsyncTaskTarget - Retry with help from Task.Delay | _โ ๏ธ Potential issue_ | _๐ Major_
<details>
<summary>๐งฉ Analysis chain</summary>
๐ Script executed:
```shell
#!/bin/bash
# Verify the timeout path now performs a blocking wait and where it is called from.
sed -n '797,858p' src/NLog/Targets/AsyncTaskTarget.cs
rg -n -C 3 'WaitTaskIsCompleted|\.Wait\(' src/NLog/Target... | a3c7b57f14029c1d8fcab80edba02e16280be1dc | 7eb16d7d6ded06ce7cb7c7348c11565675d75b73 | diff --git a/src/NLog/Targets/AsyncTaskTarget.cs b/src/NLog/Targets/AsyncTaskTarget.cs
index cf2f021d68..5f9cc82d0b 100644
--- a/src/NLog/Targets/AsyncTaskTarget.cs
+++ b/src/NLog/Targets/AsyncTaskTarget.cs
@@ -263,7 +263,7 @@ protected virtual Task WriteAsyncTask(IList<LogEventInfo> logEvents, Cancellatio
... | [
"src/NLog/Targets/AsyncTaskTarget.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Script executed:\n\n```shell\n#!/bin/bash\n# Verify the timeout path now performs a blocking wait and where it is called from.\nsed -n '797,858p' src/NLog/Targets/AsyncTaskTarget.cs\nrg -n -C 3 'WaitTaskIsCo... | true | ||
NLog/NLog | 6,165 | comment_to_fix | AsyncTaskTarget - Retry with help from Task.Delay | _โ ๏ธ Potential issue_ | _๐ Major_
<details>
<summary>๐งฉ Analysis chain</summary>
๐ Web query:
`Microsoft Learn Task.ContinueWith CancellationToken canceled before continuation executes`
๐ก Result:
When using Task.ContinueWith(continuationAction, cancellationToken, ...), if the cancellationToken's IsCancellationRe... | a3c7b57f14029c1d8fcab80edba02e16280be1dc | 7eb16d7d6ded06ce7cb7c7348c11565675d75b73 | diff --git a/src/NLog/Targets/AsyncTaskTarget.cs b/src/NLog/Targets/AsyncTaskTarget.cs
index cf2f021d68..5f9cc82d0b 100644
--- a/src/NLog/Targets/AsyncTaskTarget.cs
+++ b/src/NLog/Targets/AsyncTaskTarget.cs
@@ -263,7 +263,7 @@ protected virtual Task WriteAsyncTask(IList<LogEventInfo> logEvents, Cancellatio
... | [
"src/NLog/Targets/AsyncTaskTarget.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Web query:\n\n`Microsoft Learn Task.ContinueWith CancellationToken canceled before continuation executes`\n\n๐ก Result:\n\nWhen using Task.ContinueWith(continuationAction, cancellationToken, ...), if the can... | true | ||
NLog/NLog | 6,168 | issue_to_patch | Structured json logging to seq regression from 6.0.6 to 6.1.0 (and later)
I noticed that after updating NLog that my structured logs using `{@SomeObject}` now serialize using ToString() instead of ggenerating json.
Since there was a lot changed in 6.1.0 to do with JsonLayout it might be that broke something in connec... | PropertiesDictionary - Preserve MessageTemplate property details when adding extra properties | Fixed bug introduced with #6061
Restored the mixed-property-handling-logic, but keeping the fast-code-path when not mixing property-types. | 01a20bc9b61c0d6296e5b6e62a0518a443b944b5 | 7f6932f391f2c004a346b987b1fb8408d3784088 | diff --git a/src/NLog/Internal/PropertiesDictionary.cs b/src/NLog/Internal/PropertiesDictionary.cs
index dbe4fdb2b0..18c3447841 100644
--- a/src/NLog/Internal/PropertiesDictionary.cs
+++ b/src/NLog/Internal/PropertiesDictionary.cs
@@ -451,7 +451,7 @@ public struct PropertyDictionaryEnumerator : IEnumerator<KeyValuePair... | [
"src/NLog/Internal/PropertiesDictionary.cs",
"tests/NLog.UnitTests/Internal/PropertiesDictionaryTests.cs",
"tests/NLog.UnitTests/Layouts/JsonLayoutTests.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _๐๏ธ Heavy lift_\n\n**Mixed properties still drop template `Format` metadata.**\n\n`CaptureType` is now preserved, but `MessageTemplateParameter.Format` is still discarded when template properties are copied into `_eventProperties`, and Line 480 rebuilds the par... | diff --git a/tests/NLog.UnitTests/Internal/PropertiesDictionaryTests.cs b/tests/NLog.UnitTests/Internal/PropertiesDictionaryTests.cs
index a36d81399a..42c4f72988 100644
--- a/tests/NLog.UnitTests/Internal/PropertiesDictionaryTests.cs
+++ b/tests/NLog.UnitTests/Internal/PropertiesDictionaryTests.cs
@@ -438,7 +438,7 @@ p... | true |
NLog/NLog | 6,168 | comment_to_fix | PropertiesDictionary - Preserve MessageTemplate property details when adding extra properties | _โ ๏ธ Potential issue_ | _๐ Major_ | _๐๏ธ Heavy lift_
**Mixed properties still drop template `Format` metadata.**
`CaptureType` is now preserved, but `MessageTemplateParameter.Format` is still discarded when template properties are copied into `_eventProperties`, and Line 480 rebuilds the parameter with `format: null`... | 01a20bc9b61c0d6296e5b6e62a0518a443b944b5 | 7f6932f391f2c004a346b987b1fb8408d3784088 | diff --git a/src/NLog/Internal/PropertiesDictionary.cs b/src/NLog/Internal/PropertiesDictionary.cs
index dbe4fdb2b0..18c3447841 100644
--- a/src/NLog/Internal/PropertiesDictionary.cs
+++ b/src/NLog/Internal/PropertiesDictionary.cs
@@ -451,7 +451,7 @@ public struct PropertyDictionaryEnumerator : IEnumerator<KeyValuePair... | [
"src/NLog/Internal/PropertiesDictionary.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ Major_ | _๐๏ธ Heavy lift_\n\n**Mixed properties still drop template `Format` metadata.**\n\n`CaptureType` is now preserved, but `MessageTemplateParameter.Format` is still discarded when template properties are copied into `_eventProperties`, and Line 480 rebuilds the par... | true | ||
NLog/NLog | 6,164 | issue_to_patch | DateLayoutRenderer - UniversalTime = false should only convert to local when UTC | c9f2941adab03c9755d4d95a8e18de1a1841309b | 3abc11c553141d85cb67ecc97af0769fb40547d9 | diff --git a/src/NLog/LayoutRenderers/DateLayoutRenderer.cs b/src/NLog/LayoutRenderers/DateLayoutRenderer.cs
index 6aa4d469ce..ff16f8db6d 100644
--- a/src/NLog/LayoutRenderers/DateLayoutRenderer.cs
+++ b/src/NLog/LayoutRenderers/DateLayoutRenderer.cs
@@ -157,7 +157,10 @@ private DateTime GetValue(LogEventInfo logEvent)... | [
"src/NLog/LayoutRenderers/DateLayoutRenderer.cs",
"src/NLog/LayoutRenderers/LongDateLayoutRenderer.cs",
"src/NLog/LayoutRenderers/ShortDateLayoutRenderer.cs",
"src/NLog/LayoutRenderers/TimeLayoutRenderer.cs"
] | [] | true | |||
NLog/NLog | 6,152 | issue_to_patch | TemplateEnumerator - Optimize parsing of single digit holename | 96f6413eccc06d5ded687b8dcacdcaa7ea75ddfd | 2116cde712ccd5a985d26fc233e8bfd60c14fb95 | diff --git a/src/NLog/MessageTemplates/TemplateEnumerator.cs b/src/NLog/MessageTemplates/TemplateEnumerator.cs
index 31166f8575..f31e4ee5f8 100644
--- a/src/NLog/MessageTemplates/TemplateEnumerator.cs
+++ b/src/NLog/MessageTemplates/TemplateEnumerator.cs
@@ -66,9 +66,18 @@ public TemplateEnumerator(string template)
... | [
"src/NLog/MessageTemplates/TemplateEnumerator.cs"
] | [] | true | |||
NLog/NLog | 6,157 | issue_to_patch | TemplateEnumerator - Skip fast forward to first hole | Followup to #6152 | 0b99ee0eac640aacdcc0d2546bd5a526250d37b5 | 8895d3e7ebe5efbe9208c0b89761286c46f0582d | diff --git a/src/NLog/MessageTemplates/TemplateEnumerator.cs b/src/NLog/MessageTemplates/TemplateEnumerator.cs
index f31e4ee5f8..b99e08fe10 100644
--- a/src/NLog/MessageTemplates/TemplateEnumerator.cs
+++ b/src/NLog/MessageTemplates/TemplateEnumerator.cs
@@ -67,17 +67,8 @@ public TemplateEnumerator(string template)
... | [
"src/NLog/MessageTemplates/TemplateEnumerator.cs"
] | [] | true | ||
NLog/NLog | 6,140 | issue_to_patch | TryParseEnum - Apply Enum.TryParse<T> since better for AOT | 8ba58a41dc0e183739b27723cbcf9ff3d5f4c59f | e4249c0985b9041f94f33cb84f9c612f1b9bd8b8 | diff --git a/src/NLog/Common/ConversionHelpers.cs b/src/NLog/Common/ConversionHelpers.cs
index 7a9dd74190..076bd23d44 100644
--- a/src/NLog/Common/ConversionHelpers.cs
+++ b/src/NLog/Common/ConversionHelpers.cs
@@ -78,6 +78,9 @@ internal static bool TryParseEnum(string inputValue, Type enumType, out object?
#if NETSTA... | [
"src/NLog/Common/ConversionHelpers.cs",
"tests/NLog.UnitTests/Internal/ConversionHelpersTests.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ก Minor_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Web query:\n\n`Does .NET Framework 4.0 Enum.TryParse have any known issues or behavioral differences compared to later versions?`\n\n๐ก Result:\n\nNo, .NET Framework 4.0 Enum.TryParse does not have any known... | diff --git a/tests/NLog.UnitTests/Internal/ConversionHelpersTests.cs b/tests/NLog.UnitTests/Internal/ConversionHelpersTests.cs
index 3ea4a52e30..6ad209f1d4 100644
--- a/tests/NLog.UnitTests/Internal/ConversionHelpersTests.cs
+++ b/tests/NLog.UnitTests/Internal/ConversionHelpersTests.cs
@@ -183,6 +183,8 @@ public void E... | true | ||
NLog/NLog | 6,140 | comment_to_fix | TryParseEnum - Apply Enum.TryParse<T> since better for AOT | _โ ๏ธ Potential issue_ | _๐ก Minor_
<details>
<summary>๐งฉ Analysis chain</summary>
๐ Web query:
`Does .NET Framework 4.0 Enum.TryParse have any known issues or behavioral differences compared to later versions?`
๐ก Result:
No, .NET Framework 4.0 Enum.TryParse does not have any known issues or behavioral differences... | 8ba58a41dc0e183739b27723cbcf9ff3d5f4c59f | e4249c0985b9041f94f33cb84f9c612f1b9bd8b8 | diff --git a/src/NLog/Common/ConversionHelpers.cs b/src/NLog/Common/ConversionHelpers.cs
index 7a9dd74190..076bd23d44 100644
--- a/src/NLog/Common/ConversionHelpers.cs
+++ b/src/NLog/Common/ConversionHelpers.cs
@@ -78,6 +78,9 @@ internal static bool TryParseEnum(string inputValue, Type enumType, out object?
#if NETSTA... | [
"src/NLog/Common/ConversionHelpers.cs"
] | [
{
"comment": "_โ ๏ธ Potential issue_ | _๐ก Minor_\n\n<details>\n<summary>๐งฉ Analysis chain</summary>\n\n๐ Web query:\n\n`Does .NET Framework 4.0 Enum.TryParse have any known issues or behavioral differences compared to later versions?`\n\n๐ก Result:\n\nNo, .NET Framework 4.0 Enum.TryParse does not have any known... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.