url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/25618 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25618/labels{/name} | https://api.github.com/repos/facebook/react/issues/25618/comments | https://api.github.com/repos/facebook/react/issues/25618/events | https://github.com/facebook/react/issues/25618 | 1,433,783,851 | I_kwDOAJy2Ks5Vdc4r | 25,618 | Bug: React.forwardRef component defaultProps not working | {'login': 'XenoBino', 'id': 48479476, 'node_id': 'MDQ6VXNlcjQ4NDc5NDc2', 'avatar_url': 'https://avatars.githubusercontent.com/u/48479476?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/XenoBino', 'html_url': 'https://github.com/XenoBino', 'followers_url': 'https://api.github.com/users/XenoBino/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You should check this posts, maybe you can fix your problem:\r\n\r\nhttps://github.com/facebook/react/issues/16653\r\nhttps://github.com/typescript-cheatsheets/react/issues/199",
"Closing since this is a usage question related to TypeScript that was answered by znareak",
"I insist that there IS a problem. Usin... | 2022-11-02 21:01:44 | 2022-11-04 19:32:36 | 2022-11-03 12:20:30 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.2.0
## Steps To Reproduce
```javascript
import { forwar... | {'url': 'https://api.github.com/repos/facebook/react/issues/25618/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25618/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25617 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25617/labels{/name} | https://api.github.com/repos/facebook/react/issues/25617/comments | https://api.github.com/repos/facebook/react/issues/25617/events | https://github.com/facebook/react/pull/25617 | 1,433,672,715 | PR_kwDOAJy2Ks5CFc6u | 25,617 | [ServerRenderer] Move fizz external runtime implementation to react-dom-bindings | {'login': 'mofeiZ', 'id': 34200447, 'node_id': 'MDQ6VXNlcjM0MjAwNDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/34200447?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mofeiZ', 'html_url': 'https://github.com/mofeiZ', 'followers_url': 'https://api.github.com/users/mofeiZ/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1a902623a84ab004f9f042162bdcbce20f08b13f...6e5e622e601da5569974f3b10f47b9c52520b708\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-11-02 19:29:04 | 2022-11-03 15:15:30 | 2022-11-03 15:15:30 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25617', 'html_url': 'https://github.com/facebook/react/pull/25617', 'diff_url': 'https://github.com/facebook/react/pull/25617.diff', 'patch_url': 'https://github.com/facebook/react/pull/25617.patch', 'merged_at': datetime.datetime(2022, 11, 3, 15, 15, 30)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25617/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25617/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25616 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25616/labels{/name} | https://api.github.com/repos/facebook/react/issues/25616/comments | https://api.github.com/repos/facebook/react/issues/25616/events | https://github.com/facebook/react/pull/25616 | 1,433,648,650 | PR_kwDOAJy2Ks5CFXpP | 25,616 | [DevTools] add support for HostSingleton & HostResource | {'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2022-11-02 19:09:17 | 2022-11-07 20:23:18 | 2022-11-07 20:23:17 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25616', 'html_url': 'https://github.com/facebook/react/pull/25616', 'diff_url': 'https://github.com/facebook/react/pull/25616.diff', 'patch_url': 'https://github.com/facebook/react/pull/25616.patch', 'merged_at': datetime.datetime(2022, 11, 7, 20, 23, 17)} | ## Summary
This is to support two new reconciler work tags `HostSingleton` and `HostResource` introduced in PRs #25243 #25426. The behavior is described below.
I also renamed an option in components settings from an internal concept "host" to more understood "dom nodes"
## How did you test this change?
Tested... | {'url': 'https://api.github.com/repos/facebook/react/issues/25616/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25616/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25615 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25615/labels{/name} | https://api.github.com/repos/facebook/react/issues/25615/comments | https://api.github.com/repos/facebook/react/issues/25615/events | https://github.com/facebook/react/pull/25615 | 1,433,539,808 | PR_kwDOAJy2Ks5CE_7r | 25,615 | Unwrap sync resolved thenables without suspending | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4ea063b56ff7ccc69c4cc67c30fd6f31f9880464...9e09e0997955da52aca4046d11284bedf6407b49\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-11-02 17:40:20 | 2022-11-08 09:36:10 | 2022-11-02 17:53:24 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25615', 'html_url': 'https://github.com/facebook/react/pull/25615', 'diff_url': 'https://github.com/facebook/react/pull/25615.diff', 'patch_url': 'https://github.com/facebook/react/pull/25615.patch', 'merged_at': datetime.datetime(2022, 11, 2, 17, 53, 24)} | If a thenable resolves synchronously, `use` should unwrap its result without suspending or interrupting the component's execution. | {'url': 'https://api.github.com/repos/facebook/react/issues/25615/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25615/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25614 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25614/labels{/name} | https://api.github.com/repos/facebook/react/issues/25614/comments | https://api.github.com/repos/facebook/react/issues/25614/events | https://github.com/facebook/react/issues/25614 | 1,433,531,593 | I_kwDOAJy2Ks5VcfTJ | 25,614 | Bug: StrictMode double mounting doesn't clean up effects from first mount | {'login': 'juzerzarif', 'id': 22772637, 'node_id': 'MDQ6VXNlcjIyNzcyNjM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/22772637?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/juzerzarif', 'html_url': 'https://github.com/juzerzarif', 'followers_url': 'https://api.github.com/users/juzerzarif/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"At first glance, this sounds intentional, and the reason why StrictMode double-renders components and double-runs effects in the first place. By _forcing_ these bugs to happen earlier in development, they'll be more noticeable so you can fix them now.",
"I expected the double mounting in StrictMode. The thing t... | 2022-11-02 17:33:17 | 2023-02-24 03:56:22 | 2023-02-24 03:56:22 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.1.0
## Steps To Reproduce
1. Create a react component wi... | {'url': 'https://api.github.com/repos/facebook/react/issues/25614/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25614/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25613 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25613/labels{/name} | https://api.github.com/repos/facebook/react/issues/25613/comments | https://api.github.com/repos/facebook/react/issues/25613/events | https://github.com/facebook/react/issues/25613 | 1,433,380,808 | I_kwDOAJy2Ks5Vb6fI | 25,613 | [DevTools Bug] Cannot add node "47" because a node with that id is already in the Store. | {'login': 'huvber', 'id': 5032333, 'node_id': 'MDQ6VXNlcjUwMzIzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5032333?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/huvber', 'html_url': 'https://github.com/huvber', 'followers_url': 'https://api.github.com/users/huvber/followers', 'followin... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'huvber', 'id': 5032333.0, 'node_id': 'MDQ6VXNlcjUwMzIzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5032333?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/huvber', 'html_url': 'https://github.com/huvber', 'followers_url': 'https://api.github.com/users/huvber/followers', 'follow... | [{'login': 'huvber', 'id': 5032333, 'node_id': 'MDQ6VXNlcjUwMzIzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5032333?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/huvber', 'html_url': 'https://github.com/huvber', 'followers_url': 'https://api.github.com/users/huvber/followers', 'followi... | null | [
"@huvber: We're sorry you've seen this error. ❤️\n\nIt looks like you forgot to specify a valid URL. (This means that we will not be able to reproduce the problem you're reporting.)\n\nPlease help us by providing a link to a CodeSandbox (https://codesandbox.io/s/new), a repository on GitHub, or a minimal code examp... | 2022-11-02 15:46:40 | 2022-11-02 15:46:52 | 2022-11-02 15:46:52 | NONE | null | null | null | ### Website or app
private
### Repro steps
when we have multiple react application in the same page
### How often does this bug happen?
Often
### DevTools package (automated)
react-devtools-extensions
### DevTools version (automated)
4.25.0-336ac8ceb
### Error message (automated)
Cannot add node "47" because... | {'url': 'https://api.github.com/repos/facebook/react/issues/25613/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25613/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25612 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25612/labels{/name} | https://api.github.com/repos/facebook/react/issues/25612/comments | https://api.github.com/repos/facebook/react/issues/25612/events | https://github.com/facebook/react/issues/25612 | 1,433,128,446 | I_kwDOAJy2Ks5Va83- | 25,612 | convert function to component react | {'login': 'AlaaAlhoot', 'id': 87899347, 'node_id': 'MDQ6VXNlcjg3ODk5MzQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/87899347?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AlaaAlhoot', 'html_url': 'https://github.com/AlaaAlhoot', 'followers_url': 'https://api.github.com/users/AlaaAlhoot/fol... | [] | closed | false | null | [] | null | [
"Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:\r\n\r\n**Coding Questions**\r\nIf you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to ... | 2022-11-02 13:14:17 | 2022-11-02 17:14:46 | 2022-11-02 17:14:46 | NONE | null | null | null | import React, { useEffect, useState } from "react";
function App() {
const [clockState, setClockState] = useState();
const [dateState, setDateState] = useState(new Date());
useEffect(() => {
setInterval(() => {
const date = new Date();
setClockState(date.toLocaleTimeString());
setInt... | {'url': 'https://api.github.com/repos/facebook/react/issues/25612/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25612/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25611 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25611/labels{/name} | https://api.github.com/repos/facebook/react/issues/25611/comments | https://api.github.com/repos/facebook/react/issues/25611/events | https://github.com/facebook/react/pull/25611 | 1,432,434,570 | PR_kwDOAJy2Ks5CBRR8 | 25,611 | Fix: comment grammar error | {'login': 'Blackman99', 'id': 41723543, 'node_id': 'MDQ6VXNlcjQxNzIzNTQz', 'avatar_url': 'https://avatars.githubusercontent.com/u/41723543?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Blackman99', 'html_url': 'https://github.com/Blackman99', 'followers_url': 'https://api.github.com/users/Blackman99/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6fb8133ed3aa6b23063375dd345c6e413b05f0fe...08b797a5fd349179741c055c760bc3735c256553\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-11-02 03:43:47 | 2023-05-05 06:52:38 | 2023-05-05 06:52:38 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25611', 'html_url': 'https://github.com/facebook/react/pull/25611', 'diff_url': 'https://github.com/facebook/react/pull/25611.diff', 'patch_url': 'https://github.com/facebook/react/pull/25611.patch', 'merged_at': None} | ## Summary
Use "an element" and "An element" instead of "a element" and "A element".
## How did you test this change?
Only changed the comment. No souce code changes.
| {'url': 'https://api.github.com/repos/facebook/react/issues/25611/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25611/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25610 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25610/labels{/name} | https://api.github.com/repos/facebook/react/issues/25610/comments | https://api.github.com/repos/facebook/react/issues/25610/events | https://github.com/facebook/react/pull/25610 | 1,432,228,197 | PR_kwDOAJy2Ks5CAl6G | 25,610 | refactor isHostResourceType to not receive the context from reconciler and not leak types | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5f7ef8c4cbe824ef126a947b7ae0e1c07b143357...46d7b7fa63e42d383ebf69646054352170e3a9ff\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-11-01 23:13:29 | 2022-11-02 00:14:50 | 2022-11-02 00:14:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25610', 'html_url': 'https://github.com/facebook/react/pull/25610', 'diff_url': 'https://github.com/facebook/react/pull/25610.diff', 'patch_url': 'https://github.com/facebook/react/pull/25610.patch', 'merged_at': datetime.datetime(2022, 11, 2, 0, 14, 47)} | type validateDOMNesting
move `isHostResourceType` to ReactDOMHostConfig
type `AncestorInfo`
refactor `resourceFormOnly` into `ancestorInfo.containerTagInScope`
provide hostContext from reconciler | {'url': 'https://api.github.com/repos/facebook/react/issues/25610/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25610/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25609 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25609/labels{/name} | https://api.github.com/repos/facebook/react/issues/25609/comments | https://api.github.com/repos/facebook/react/issues/25609/events | https://github.com/facebook/react/pull/25609 | 1,432,177,368 | PR_kwDOAJy2Ks5CAa3s | 25,609 | Make host context use null as empty and only error in dev | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"It's 700x faster.",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5f7ef8c4cbe824ef126a947b7ae0e1c07b143357...2731b4ca3831885c5747d36f897daa00c2b3eb7a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any chang... | 2022-11-01 22:20:17 | 2022-11-01 23:02:37 | 2022-11-01 23:02:37 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25609', 'html_url': 'https://github.com/facebook/react/pull/25609', 'diff_url': 'https://github.com/facebook/react/pull/25609.diff', 'patch_url': 'https://github.com/facebook/react/pull/25609.patch', 'merged_at': datetime.datetime(2022, 11, 1, 23, 2, 37)} | Makes it slightly more blazing.
No host config actually uses null as any useful and we use this as a placeholder value anyway. It's also better for perf since it doesn't let two different hidden classes pass around. It's also a magic place holder that triggers error if we do try to access anything from it. | {'url': 'https://api.github.com/repos/facebook/react/issues/25609/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25609/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25605 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25605/labels{/name} | https://api.github.com/repos/facebook/react/issues/25605/comments | https://api.github.com/repos/facebook/react/issues/25605/events | https://github.com/facebook/react/issues/25605 | 1,431,938,916 | I_kwDOAJy2Ks5VWadk | 25,605 | Bug: An imposter library @actuallyworks/node-fetch was added as a dependency | {'login': 'CreativeTechGuy', 'id': 12002072, 'node_id': 'MDQ6VXNlcjEyMDAyMDcy', 'avatar_url': 'https://avatars.githubusercontent.com/u/12002072?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/CreativeTechGuy', 'html_url': 'https://github.com/CreativeTechGuy', 'followers_url': 'https://api.github.com/users... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"> In a recent PR https://github.com/facebook/react/pull/25516 a new dependency was added @actuallyworks/node-fetch.\r\n\r\nThis package was added to the workspace root and is only installed if you're working on React not if you're installing any package published from facebook/react.\r\n\r\nThe `@actuallyworks` pa... | 2022-11-01 19:05:19 | 2022-11-01 20:26:14 | 2022-11-01 20:07:10 | NONE | null | null | null | In a recent PR #25516 a new dependency was added `@actuallyworks/node-fetch`. This raised red flags for me. In investigating the library, here's the reasons to be alarmed:
* There is [only one version](https://www.npmjs.com/package/@actuallyworks/node-fetch?activeTab=versions) which was published just a few weeks be... | {'url': 'https://api.github.com/repos/facebook/react/issues/25605/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25605/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25604 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25604/labels{/name} | https://api.github.com/repos/facebook/react/issues/25604/comments | https://api.github.com/repos/facebook/react/issues/25604/events | https://github.com/facebook/react/issues/25604 | 1,431,860,585 | I_kwDOAJy2Ks5VWHVp | 25,604 | Bug: Code based on React portal example from official React documentation code works on Firefox, but not on Chrome. | {'login': 'MelvinWM', 'id': 26661991, 'node_id': 'MDQ6VXNlcjI2NjYxOTkx', 'avatar_url': 'https://avatars.githubusercontent.com/u/26661991?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MelvinWM', 'html_url': 'https://github.com/MelvinWM', 'followers_url': 'https://api.github.com/users/MelvinWM/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"It may also be the case that the original example from the official React documentation site is buggy.\r\n\r\nHowever, if that is the case, that example should at least be marked as obsolete or wrong, or maybe replaced.",
"This issue has been automatically marked as stale. **If this issue is still affecting you,... | 2022-11-01 18:08:54 | 2024-04-17 09:03:57 | 2024-04-17 09:03:56 | NONE | null | null | null | Dragging sliders using code based on official React documentation code on Firefox works, but not on Chrome.
React version: 18.2.0
## Steps To Reproduce
1.
Copy this code:
```
import React from 'react';
import ReactDOM from 'react-dom';
export default function App(props: {}) {
const [length, set... | {'url': 'https://api.github.com/repos/facebook/react/issues/25604/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25604/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25603 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25603/labels{/name} | https://api.github.com/repos/facebook/react/issues/25603/comments | https://api.github.com/repos/facebook/react/issues/25603/events | https://github.com/facebook/react/pull/25603 | 1,431,807,532 | PR_kwDOAJy2Ks5B_J3J | 25,603 | Offscreen add attach | {'login': 'sammy-SC', 'id': 1733610, 'node_id': 'MDQ6VXNlcjE3MzM2MTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1733610?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sammy-SC', 'html_url': 'https://github.com/sammy-SC', 'followers_url': 'https://api.github.com/users/sammy-SC/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b14d7fa4b88dad5f0017d084e462952c700aa2ad...dad8f0c343e9fce9817c1d4047a95105625f23a0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-11-01 17:29:24 | 2022-12-12 14:00:20 | 2022-12-12 14:00:17 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25603', 'html_url': 'https://github.com/facebook/react/pull/25603', 'diff_url': 'https://github.com/facebook/react/pull/25603.diff', 'patch_url': 'https://github.com/facebook/react/pull/25603.patch', 'merged_at': datetime.datetime(2022, 12, 12, 14, 0, 16)} | `Offscreen.attach` is imperative API to signal to Offscreen that its updates should be high priority and effects should be mounted. Coupled with `Offscreen.detach` it gives ability to manually control Offscreen. Unlike with mode `visible` and `hidden`, it is developers job to make sure contents of Offscreen are not vis... | {'url': 'https://api.github.com/repos/facebook/react/issues/25603/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 1, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25603/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25602 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25602/labels{/name} | https://api.github.com/repos/facebook/react/issues/25602/comments | https://api.github.com/repos/facebook/react/issues/25602/events | https://github.com/facebook/react/pull/25602 | 1,431,733,566 | PR_kwDOAJy2Ks5B-5rh | 25,602 | Fix `repository.directory` of `react-refresh` package | {'login': 'silverwind', 'id': 115237, 'node_id': 'MDQ6VXNlcjExNTIzNw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/115237?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/silverwind', 'html_url': 'https://github.com/silverwind', 'followers_url': 'https://api.github.com/users/silverwind/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6883d79445f38e2cdabf6fe1fa04cb44c2644c1c...ec6e0f737291b75439272f7d0b1b3ef8c182fe30\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-11-01 16:36:00 | 2024-04-10 21:21:59 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25602', 'html_url': 'https://github.com/facebook/react/pull/25602', 'diff_url': 'https://github.com/facebook/react/pull/25602.diff', 'patch_url': 'https://github.com/facebook/react/pull/25602.patch', 'merged_at': None} | ## Summary
Fix incorrect package metadata for `react-refresh` package.
## How did you test this change?
Not relevant
| {'url': 'https://api.github.com/repos/facebook/react/issues/25602/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25602/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25601 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25601/labels{/name} | https://api.github.com/repos/facebook/react/issues/25601/comments | https://api.github.com/repos/facebook/react/issues/25601/events | https://github.com/facebook/react/pull/25601 | 1,431,722,073 | PR_kwDOAJy2Ks5B-3QX | 25,601 | Add `scale` as a unitless property | {'login': 'JonnyBurger', 'id': 1629785, 'node_id': 'MDQ6VXNlcjE2Mjk3ODU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1629785?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JonnyBurger', 'html_url': 'https://github.com/JonnyBurger', 'followers_url': 'https://api.github.com/users/JonnyBurger/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: c08d8b8041a1fa2eba423cdb0398dfbc6402a5bc...5e3ce84e348275c3b2d0e711e75c125bc051a214\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-11-01 16:27:40 | 2023-02-16 10:12:33 | 2023-02-16 10:12:33 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25601', 'html_url': 'https://github.com/facebook/react/pull/25601', 'diff_url': 'https://github.com/facebook/react/pull/25601.diff', 'patch_url': 'https://github.com/facebook/react/pull/25601.patch', 'merged_at': datetime.datetime(2023, 2, 16, 10, 12, 33)} | ## Summary
CSS has a new property called `scale` (`scale: 2` is a shorthand for `transform: scale(2)`).
In vanilla JavaScript, we can do the following:
```js
document.querySelector('div').scale = 2;
```
which will make the `<div>` twice as big. So in JavaScript, it is possible to pass a plain number.
How... | {'url': 'https://api.github.com/repos/facebook/react/issues/25601/reactions', 'total_count': 9, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 2, 'confused': 0, 'heart': 7, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25601/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25600 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25600/labels{/name} | https://api.github.com/repos/facebook/react/issues/25600/comments | https://api.github.com/repos/facebook/react/issues/25600/events | https://github.com/facebook/react/issues/25600 | 1,431,706,850 | I_kwDOAJy2Ks5VVhzi | 25,600 | Bug: PropsWithChildren doesn't use React.Children | {'login': 'hazeled', 'id': 74346877, 'node_id': 'MDQ6VXNlcjc0MzQ2ODc3', 'avatar_url': 'https://avatars.githubusercontent.com/u/74346877?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hazeled', 'html_url': 'https://github.com/hazeled', 'followers_url': 'https://api.github.com/users/hazeled/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Nope. Not how react works. I take it back."
] | 2022-11-01 16:18:42 | 2022-11-01 16:27:12 | 2022-11-01 16:27:12 | NONE | null | null | null | React version: 18.2.0
[Example of what should work](https://codesandbox.io/s/dazzling-tree-qgubd4?file=/src/App.tsx)
## The current behavior
PropsWithChildren is currently defined as:
```jsx
type PropsWithChildren<P = unknown> = P & { children?: ReactNode | undefined };
```
However, a seperate definition... | {'url': 'https://api.github.com/repos/facebook/react/issues/25600/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25600/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25599 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25599/labels{/name} | https://api.github.com/repos/facebook/react/issues/25599/comments | https://api.github.com/repos/facebook/react/issues/25599/events | https://github.com/facebook/react/pull/25599 | 1,431,675,784 | PR_kwDOAJy2Ks5B-tUk | 25,599 | [Float] handle resource Resource creation inside svg context | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: ab075a232409ea1f566526c6a5dca30f658280de...6e949de028226e9887982c38caddc5bae1bab198\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-11-01 16:00:24 | 2022-11-01 22:20:59 | 2022-11-01 21:57:45 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25599', 'html_url': 'https://github.com/facebook/react/pull/25599', 'diff_url': 'https://github.com/facebook/react/pull/25599.diff', 'patch_url': 'https://github.com/facebook/react/pull/25599.patch', 'merged_at': datetime.datetime(2022, 11, 1, 21, 57, 45)} | `title` is a valid element descendent of `svg`. this PR adds a prohibition on turning titles in svg into Resources.
This PR also adds additional warnings if you render something that is almost a Resource inside an svg. | {'url': 'https://api.github.com/repos/facebook/react/issues/25599/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25599/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25598 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25598/labels{/name} | https://api.github.com/repos/facebook/react/issues/25598/comments | https://api.github.com/repos/facebook/react/issues/25598/events | https://github.com/facebook/react/pull/25598 | 1,431,234,074 | PR_kwDOAJy2Ks5B9OLF | 25,598 | Fix: comment grammar error | {'login': 'Blackman99', 'id': 41723543, 'node_id': 'MDQ6VXNlcjQxNzIzNTQz', 'avatar_url': 'https://avatars.githubusercontent.com/u/41723543?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Blackman99', 'html_url': 'https://github.com/Blackman99', 'followers_url': 'https://api.github.com/users/Blackman99/fol... | [] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4ea063b56ff7ccc69c4cc67c30fd6f31f9880464...9634081eb1c1c0383603fa540ab32f28eca1cd1f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-11-01 10:51:08 | 2022-11-02 03:40:45 | 2022-11-02 03:40:45 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25598', 'html_url': 'https://github.com/facebook/react/pull/25598', 'diff_url': 'https://github.com/facebook/react/pull/25598.diff', 'patch_url': 'https://github.com/facebook/react/pull/25598.patch', 'merged_at': None} | ## Summary
Using "an element" instead of "a element" in comment.
## How did you test this change?
Read the source code and found it.
| {'url': 'https://api.github.com/repos/facebook/react/issues/25598/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25598/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25597 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25597/labels{/name} | https://api.github.com/repos/facebook/react/issues/25597/comments | https://api.github.com/repos/facebook/react/issues/25597/events | https://github.com/facebook/react/pull/25597 | 1,430,814,449 | PR_kwDOAJy2Ks5B71QM | 25,597 | Add Bun streaming server renderer | {'login': 'colinhacks', 'id': 3084745, 'node_id': 'MDQ6VXNlcjMwODQ3NDU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3084745?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/colinhacks', 'html_url': 'https://github.com/colinhacks', 'followers_url': 'https://api.github.com/users/colinhacks/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @colinhacks! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order fo... | 2022-11-01 03:37:51 | 2022-11-17 21:15:57 | 2022-11-17 21:15:57 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25597', 'html_url': 'https://github.com/facebook/react/pull/25597', 'diff_url': 'https://github.com/facebook/react/pull/25597.diff', 'patch_url': 'https://github.com/facebook/react/pull/25597.patch', 'merged_at': datetime.datetime(2022, 11, 17, 21, 15, 57)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25597/reactions', 'total_count': 7, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 7, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25597/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25596 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25596/labels{/name} | https://api.github.com/repos/facebook/react/issues/25596/comments | https://api.github.com/repos/facebook/react/issues/25596/events | https://github.com/facebook/react/issues/25596 | 1,430,657,616 | I_kwDOAJy2Ks5VRhpQ | 25,596 | A | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [] | closed | false | null | [] | null | [] | 2022-11-01 00:13:19 | 2022-11-01 02:05:37 | 2022-11-01 02:05:37 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/25596/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25596/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25595 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25595/labels{/name} | https://api.github.com/repos/facebook/react/issues/25595/comments | https://api.github.com/repos/facebook/react/issues/25595/events | https://github.com/facebook/react/pull/25595 | 1,430,502,980 | PR_kwDOAJy2Ks5B6y-y | 25,595 | Fix type check for null | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2ac77aab94d125942d71e9113d70253eaaef698f...42a31c54c5d6c9d4a7d21ddcdc1f63aeaa555243\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-31 21:10:12 | 2022-10-31 21:29:02 | 2022-10-31 21:29:01 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25595', 'html_url': 'https://github.com/facebook/react/pull/25595', 'diff_url': 'https://github.com/facebook/react/pull/25595.diff', 'patch_url': 'https://github.com/facebook/react/pull/25595.patch', 'merged_at': datetime.datetime(2022, 10, 31, 21, 29, 1)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/25595/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25595/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25594 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25594/labels{/name} | https://api.github.com/repos/facebook/react/issues/25594/comments | https://api.github.com/repos/facebook/react/issues/25594/events | https://github.com/facebook/react/issues/25594 | 1,430,423,416 | I_kwDOAJy2Ks5VQod4 | 25,594 | not appearing | {'login': 'mag', 'id': 2266, 'node_id': 'MDQ6VXNlcjIyNjY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2266?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mag', 'html_url': 'https://github.com/mag', 'followers_url': 'https://api.github.com/users/mag/followers', 'following_url': 'https://api.g... | [] | closed | false | null | [] | null | [] | 2022-10-31 20:04:38 | 2022-10-31 20:04:43 | 2022-10-31 20:04:43 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/25594/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25594/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25593 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25593/labels{/name} | https://api.github.com/repos/facebook/react/issues/25593/comments | https://api.github.com/repos/facebook/react/issues/25593/events | https://github.com/facebook/react/issues/25593 | 1,430,344,692 | I_kwDOAJy2Ks5VQVP0 | 25,593 | Bug: setState inside useEffect is unreliable in React 18 | {'login': 'lucasbasquerotto', 'id': 19873627, 'node_id': 'MDQ6VXNlcjE5ODczNjI3', 'avatar_url': 'https://avatars.githubusercontent.com/u/19873627?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lucasbasquerotto', 'html_url': 'https://github.com/lucasbasquerotto', 'followers_url': 'https://api.github.com/us... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hmm i think that i've created a example functional, i don't know if this is the correct behavios, but you can test it\r\n\r\n```javascript\r\nimport React from \"react\";\r\nimport { Provider, useDispatch, useSelector } from \"react-redux\";\r\nimport { configureStore, createSlice } from \"@reduxjs/toolkit\";\r\n\... | 2022-10-31 19:05:18 | 2023-02-24 04:14:57 | 2023-02-24 04:13:16 | NONE | null | null | null | When I updated to react 18, there where parts of the code that caused infinite loops. The browser tab ends up frozen and I have to stop javascript in the page to be able to close the tab, and sometimes I can't even do that, having to close the browser window (and closing the SO processes of the browser to free memory).... | {'url': 'https://api.github.com/repos/facebook/react/issues/25593/reactions', 'total_count': 6, '+1': 6, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25593/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25592 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25592/labels{/name} | https://api.github.com/repos/facebook/react/issues/25592/comments | https://api.github.com/repos/facebook/react/issues/25592/events | https://github.com/facebook/react/pull/25592 | 1,430,015,960 | PR_kwDOAJy2Ks5B5KJu | 25,592 | Do not unmount layout effects on initial Offscreen mount | {'login': 'sammy-SC', 'id': 1733610, 'node_id': 'MDQ6VXNlcjE3MzM2MTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1733610?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sammy-SC', 'html_url': 'https://github.com/sammy-SC', 'followers_url': 'https://api.github.com/users/sammy-SC/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2ac77aab94d125942d71e9113d70253eaaef698f...30f1466687b742d359037b0481e5d31fd1b199a0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-31 15:13:29 | 2022-11-01 15:11:32 | 2022-11-01 15:11:29 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25592', 'html_url': 'https://github.com/facebook/react/pull/25592', 'diff_url': 'https://github.com/facebook/react/pull/25592.diff', 'patch_url': 'https://github.com/facebook/react/pull/25592.patch', 'merged_at': datetime.datetime(2022, 11, 1, 15, 11, 29)} | `wasHidden` is evaluted to false if `current` is null. This means Offscreen has never been shown but this code assumes it is going from 'visible' to 'hidden' and unmounts layout effects.
To fix this, only unmount layout effects if `current` is not null.
I'm not able to repro this problem or write unit test for it. ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25592/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25592/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25591 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25591/labels{/name} | https://api.github.com/repos/facebook/react/issues/25591/comments | https://api.github.com/repos/facebook/react/issues/25591/events | https://github.com/facebook/react/pull/25591 | 1,429,678,344 | PR_kwDOAJy2Ks5B4BGC | 25,591 | Enable modern strict mode for RN | {'login': 'sammy-SC', 'id': 1733610, 'node_id': 'MDQ6VXNlcjE3MzM2MTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1733610?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sammy-SC', 'html_url': 'https://github.com/sammy-SC', 'followers_url': 'https://api.github.com/users/sammy-SC/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2ac77aab94d125942d71e9113d70253eaaef698f...47797db49557e9aef6d159e191430522302fd9b8\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-31 11:19:02 | 2022-10-31 18:21:40 | 2022-10-31 18:21:40 | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/25591', 'html_url': 'https://github.com/facebook/react/pull/25591', 'diff_url': 'https://github.com/facebook/react/pull/25591.diff', 'patch_url': 'https://github.com/facebook/react/pull/25591.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25591/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25591/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25590 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25590/labels{/name} | https://api.github.com/repos/facebook/react/issues/25590/comments | https://api.github.com/repos/facebook/react/issues/25590/events | https://github.com/facebook/react/issues/25590 | 1,429,511,943 | I_kwDOAJy2Ks5VNJ8H | 25,590 | Error: Invalid hook call | {'login': 'aymeric75', 'id': 12927600, 'node_id': 'MDQ6VXNlcjEyOTI3NjAw', 'avatar_url': 'https://avatars.githubusercontent.com/u/12927600?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aymeric75', 'html_url': 'https://github.com/aymeric75', 'followers_url': 'https://api.github.com/users/aymeric75/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1168115654, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"You likely have different versions of React or React Native installed (see also https://github.com/facebook/react/issues/13991). Expo might also be the culprit. Try to remove as much code as possible until you can no longer reproduce.\r\n\r\nSupport requests filed as GitHub issues often go unanswered. We want you ... | 2022-10-31 09:12:34 | 2022-10-31 09:57:46 | 2022-10-31 09:25:01 | NONE | null | null | null | Hello,
I am having this error:
`Error: Invalid hook call`
I have checked the steps suggested to solve it:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
But I ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25590/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25590/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25589 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25589/labels{/name} | https://api.github.com/repos/facebook/react/issues/25589/comments | https://api.github.com/repos/facebook/react/issues/25589/events | https://github.com/facebook/react/issues/25589 | 1,429,241,946 | I_kwDOAJy2Ks5VMIBa | 25,589 | Bug: Internal React error: Expected static flag was missing. Please notify the React team. | {'login': 'Mumujianguang', 'id': 52249626, 'node_id': 'MDQ6VXNlcjUyMjQ5NjI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/52249626?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Mumujianguang', 'html_url': 'https://github.com/Mumujianguang', 'followers_url': 'https://api.github.com/users/Mumuj... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"Duplicate of https://github.com/facebook/react/issues/24391"
] | 2022-10-31 04:37:59 | 2022-10-31 08:06:51 | 2022-10-31 08:06:44 | NONE | null | null | null | After I upgraded the React version of the project from 16.14.0 to 18.2.0, the console reported the following warning after the project started
```
Warning: Internal React error: Expected static flag was missing. Please notify the React team.
```
![image](https://user-images.githubusercontent.com/52249626/19893138... | {'url': 'https://api.github.com/repos/facebook/react/issues/25589/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25589/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25588 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25588/labels{/name} | https://api.github.com/repos/facebook/react/issues/25588/comments | https://api.github.com/repos/facebook/react/issues/25588/events | https://github.com/facebook/react/issues/25588 | 1,428,995,494 | I_kwDOAJy2Ks5VLL2m | 25,588 | Bug: | {'login': 'leopalazzi', 'id': 24783016, 'node_id': 'MDQ6VXNlcjI0NzgzMDE2', 'avatar_url': 'https://avatars.githubusercontent.com/u/24783016?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/leopalazzi', 'html_url': 'https://github.com/leopalazzi', 'followers_url': 'https://api.github.com/users/leopalazzi/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!",
"C... | 2022-10-30 19:45:45 | 2024-04-17 09:03:58 | 2024-04-17 09:03:57 | NONE | null | null | null | I am trying to use an array of boolean inside a map and if the value is true it should display a div. This array is updated when I click on a button inside the map (updated as a state).
This doesn't trigger re-render to display the div.
React version:
## Steps To Reproduce
1. Create an array inside state
2.... | {'url': 'https://api.github.com/repos/facebook/react/issues/25588/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25588/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25587 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25587/labels{/name} | https://api.github.com/repos/facebook/react/issues/25587/comments | https://api.github.com/repos/facebook/react/issues/25587/events | https://github.com/facebook/react/pull/25587 | 1,428,525,705 | PR_kwDOAJy2Ks5B0MRb | 25,587 | Clean up vestige of useOpaqueIdentifier | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bdd3d0807c6e9f417909bab93ffe9795128b04d8...6e39da8feefbdf62cf747946ba0ea9bcb831b545\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-30 00:38:39 | 2022-10-30 00:46:54 | 2022-10-30 00:46:54 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25587', 'html_url': 'https://github.com/facebook/react/pull/25587', 'diff_url': 'https://github.com/facebook/react/pull/25587.diff', 'patch_url': 'https://github.com/facebook/react/pull/25587.patch', 'merged_at': datetime.datetime(2022, 10, 30, 0, 46, 54)} | Found some code that was left over from the experimental useOpaqueIdentifier hook, which we eventually replaced with useId.
This deletes it. | {'url': 'https://api.github.com/repos/facebook/react/issues/25587/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25587/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25586 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25586/labels{/name} | https://api.github.com/repos/facebook/react/issues/25586/comments | https://api.github.com/repos/facebook/react/issues/25586/events | https://github.com/facebook/react/pull/25586 | 1,428,497,971 | PR_kwDOAJy2Ks5B0GSX | 25,586 | Fix typo | {'login': 'pruthvip', 'id': 1709317, 'node_id': 'MDQ6VXNlcjE3MDkzMTc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1709317?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pruthvip', 'html_url': 'https://github.com/pruthvip', 'followers_url': 'https://api.github.com/users/pruthvip/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request has been automatically marked as stale. **If this pull request is still relevant, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.",
"Closing this pull r... | 2022-10-29 23:12:47 | 2024-04-17 09:03:59 | 2024-04-17 09:03:59 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25586', 'html_url': 'https://github.com/facebook/react/pull/25586', 'diff_url': 'https://github.com/facebook/react/pull/25586.diff', 'patch_url': 'https://github.com/facebook/react/pull/25586.patch', 'merged_at': None} | Fix typo
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
... | {'url': 'https://api.github.com/repos/facebook/react/issues/25586/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25586/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25585 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25585/labels{/name} | https://api.github.com/repos/facebook/react/issues/25585/comments | https://api.github.com/repos/facebook/react/issues/25585/events | https://github.com/facebook/react/pull/25585 | 1,428,195,203 | PR_kwDOAJy2Ks5BzHIu | 25,585 | Update node to latest version | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bdd3d0807c6e9f417909bab93ffe9795128b04d8...dc51b198e7a9dc1d2bf58d98b5baa0336831d668\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-29 10:15:19 | 2022-10-29 10:20:28 | 2022-10-29 10:20:22 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25585', 'html_url': 'https://github.com/facebook/react/pull/25585', 'diff_url': 'https://github.com/facebook/react/pull/25585.diff', 'patch_url': 'https://github.com/facebook/react/pull/25585.patch', 'merged_at': None} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/25585/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25585/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25584 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25584/labels{/name} | https://api.github.com/repos/facebook/react/issues/25584/comments | https://api.github.com/repos/facebook/react/issues/25584/events | https://github.com/facebook/react/issues/25584 | 1,428,062,737 | I_kwDOAJy2Ks5VHoIR | 25,584 | Bug: | {'login': 'thangtx69', 'id': 116911487, 'node_id': 'U_kgDOBvftfw', 'avatar_url': 'https://avatars.githubusercontent.com/u/116911487?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/thangtx69', 'html_url': 'https://github.com/thangtx69', 'followers_url': 'https://api.github.com/users/thangtx69/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2022-10-29 03:57:45 | 2022-10-29 08:06:02 | 2022-10-29 08:06:02 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/25584/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25584/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25583 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25583/labels{/name} | https://api.github.com/repos/facebook/react/issues/25583/comments | https://api.github.com/repos/facebook/react/issues/25583/events | https://github.com/facebook/react/pull/25583 | 1,427,789,636 | PR_kwDOAJy2Ks5Bxy8J | 25,583 | Strict Mode: Reuse memoized result from first pass | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: e7c5af45ceb8fa2b64d39ec68345254ce9abd65e...fe59dfe4508a7d4be187f0ecc8dcbd5a685e9254\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-28 20:25:06 | 2024-01-18 20:38:44 | 2022-10-28 21:46:20 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25583', 'html_url': 'https://github.com/facebook/react/pull/25583', 'diff_url': 'https://github.com/facebook/react/pull/25583.diff', 'patch_url': 'https://github.com/facebook/react/pull/25583.patch', 'merged_at': datetime.datetime(2022, 10, 28, 21, 46, 20)} | In Strict Mode, during development, user functions are double invoked to help detect side effects. Currently, the way we implement this is to completely discard the first pass and start over. Theoretically this should be fine because components are idempotent. However, it's a bit tricky to get right because our impleme... | {'url': 'https://api.github.com/repos/facebook/react/issues/25583/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25583/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25582 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25582/labels{/name} | https://api.github.com/repos/facebook/react/issues/25582/comments | https://api.github.com/repos/facebook/react/issues/25582/events | https://github.com/facebook/react/pull/25582 | 1,427,664,299 | PR_kwDOAJy2Ks5BxXgw | 25,582 | Flow: first batch of function annotations | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"What? Really all functions? That's super annoying. Worse than TypeScript.",
"> What? Really all functions? That's super annoying. Worse than TypeScript.\r\n\r\nSome minor exceptions, like inline callbacks (e.g. `xs.map(x => x * 2)`):\r\n\r\nhttps://medium.com/flow-type/requiring-more-annotations-to-functions-and... | 2022-10-28 18:41:50 | 2023-01-10 14:57:59 | 2023-01-10 14:57:59 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25582', 'html_url': 'https://github.com/facebook/react/pull/25582', 'diff_url': 'https://github.com/facebook/react/pull/25582.diff', 'patch_url': 'https://github.com/facebook/react/pull/25582.patch', 'merged_at': None} | The next version of Flow requires type annotation on all function arguments and some other places.
This adds the types from the automatic codemod provided by flow that didn't repeat large literal objects or similar thing that might need a bit more manual review.
Also include a minor bump to the Flow version from ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25582/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25582/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25581 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25581/labels{/name} | https://api.github.com/repos/facebook/react/issues/25581/comments | https://api.github.com/repos/facebook/react/issues/25581/events | https://github.com/facebook/react/issues/25581 | 1,427,492,585 | I_kwDOAJy2Ks5VFc7p | 25,581 | Suggestion: why not make accessing and changing the state more flexible? | {'login': 'anasouardini', 'id': 114059811, 'node_id': 'U_kgDOBsxqIw', 'avatar_url': 'https://avatars.githubusercontent.com/u/114059811?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anasouardini', 'html_url': 'https://github.com/anasouardini', 'followers_url': 'https://api.github.com/users/anasouardini/f... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"a good solution to splitting UI and business logic, see: https://github.com/hawx1993/hooks-view-model",
"> a good solution to splitting UI and business logic, see: https://github.com/hawx1993/hooks-view-model\r\n\r\ngood suggestion but not form tho. Also I really want to see this feature in react since to other ... | 2022-10-28 16:24:55 | 2024-04-11 01:06:01 | 2024-04-11 01:06:01 | NONE | null | null | null | It would provide the ability to create a state, read the state
and set the state form anywhere in the code base.
I imagine It would be something like this:
## adding the state to the global state
```js
import {useGlobalState} from 'react';
const ProviderComponent = ()=>{
const [ceateState, _, __] = us... | {'url': 'https://api.github.com/repos/facebook/react/issues/25581/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25581/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25580 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25580/labels{/name} | https://api.github.com/repos/facebook/react/issues/25580/comments | https://api.github.com/repos/facebook/react/issues/25580/events | https://github.com/facebook/react/issues/25580 | 1,427,398,299 | I_kwDOAJy2Ks5VFF6b | 25,580 | Bug: Some external components cannot be used as JSX component. | {'login': 'ltsfran', 'id': 38477522, 'node_id': 'MDQ6VXNlcjM4NDc3NTIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/38477522?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ltsfran', 'html_url': 'https://github.com/ltsfran', 'followers_url': 'https://api.github.com/users/ltsfran/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1168115654, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"You probably had multiple versions of `@types/react` installed which is generally not supported. That's why adding a `resolutions` entry resolved the issue."
] | 2022-10-28 15:06:10 | 2022-10-28 15:12:17 | 2022-10-28 15:12:11 | NONE | null | null | null | For example, I'm using CSSTransitionGroup and I have this mistake.
React version:
@types/react: 18.0.24
@types/react-dom: 18.0.6
react: 18.2.0
react-dom: 18.2.0
## Steps To Reproduce
1. Have a component CSSTransition inside createPortal function
```
createPortal(
<CSSTransition
in={isOpen}
... | {'url': 'https://api.github.com/repos/facebook/react/issues/25580/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25580/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25579 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25579/labels{/name} | https://api.github.com/repos/facebook/react/issues/25579/comments | https://api.github.com/repos/facebook/react/issues/25579/events | https://github.com/facebook/react/pull/25579 | 1,427,252,375 | PR_kwDOAJy2Ks5Bv_OW | 25,579 | fix typo: Suspensey to Suspense in error message | {'login': 'f', 'id': 196477, 'node_id': 'MDQ6VXNlcjE5NjQ3Nw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/196477?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/f', 'html_url': 'https://github.com/f', 'followers_url': 'https://api.github.com/users/f/followers', 'following_url': 'https://api.g... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cf3932be5ca95bf5507a9566e4a9605bce0c5e21...ec36ffd86100f9bbef732784b6e486718ecb80f6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-28 13:17:46 | 2022-10-29 00:55:42 | 2022-10-29 00:55:42 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25579', 'html_url': 'https://github.com/facebook/react/pull/25579', 'diff_url': 'https://github.com/facebook/react/pull/25579.diff', 'patch_url': 'https://github.com/facebook/react/pull/25579.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25579/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25579/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25578 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25578/labels{/name} | https://api.github.com/repos/facebook/react/issues/25578/comments | https://api.github.com/repos/facebook/react/issues/25578/events | https://github.com/facebook/react/pull/25578 | 1,426,995,845 | PR_kwDOAJy2Ks5BvI4k | 25,578 | Fix useSyncExternalStore dropped update when state is dispatched in render phase | {'login': 'pandaiolo', 'id': 1933404, 'node_id': 'MDQ6VXNlcjE5MzM0MDQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1933404?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pandaiolo', 'html_url': 'https://github.com/pandaiolo', 'followers_url': 'https://api.github.com/users/pandaiolo/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cf3932be5ca95bf5507a9566e4a9605bce0c5e21...776bd87ceacf026879df1527c9304144f6c005c9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-28 09:45:41 | 2022-11-08 10:25:43 | 2022-11-08 10:25:42 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25578', 'html_url': 'https://github.com/facebook/react/pull/25578', 'diff_url': 'https://github.com/facebook/react/pull/25578.diff', 'patch_url': 'https://github.com/facebook/react/pull/25578.patch', 'merged_at': datetime.datetime(2022, 11, 8, 10, 25, 42)} | ## Summary
Fix #25565
In `updateSyncExternalStore`, If state is dispatched during render phase, then work in progress `hook` will hold already updated memoized state in the second pass, defeating previous value comparison. As a consequence, the effect updating internal store value with next value will not be sche... | {'url': 'https://api.github.com/repos/facebook/react/issues/25578/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25578/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25577 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25577/labels{/name} | https://api.github.com/repos/facebook/react/issues/25577/comments | https://api.github.com/repos/facebook/react/issues/25577/events | https://github.com/facebook/react/pull/25577 | 1,426,267,644 | PR_kwDOAJy2Ks5Bsxn- | 25,577 | Remove old react-fetch, react-fs and react-pg libraries | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 28a574ea8f5d0efa95f861abca26a67af47dd0c0...9e9489969e73acac206b33b8084e6c2724d5653e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-27 21:07:58 | 2022-11-02 16:59:28 | 2022-10-27 21:52:54 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25577', 'html_url': 'https://github.com/facebook/react/pull/25577', 'diff_url': 'https://github.com/facebook/react/pull/25577.diff', 'patch_url': 'https://github.com/facebook/react/pull/25577.patch', 'merged_at': datetime.datetime(2022, 10, 27, 21, 52, 54)} | To avoid confusion. We are patching `fetch`, and only `fetch`, for a small fix scoped to react renders elsewhere, but this code is not it.
This code was for the strategy used in the original [React Server Components demo](https://github.com/reactjs/server-components-demo). Which [we announced](https://reactjs.org/bl... | {'url': 'https://api.github.com/repos/facebook/react/issues/25577/reactions', 'total_count': 3, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 2, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25577/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25576 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25576/labels{/name} | https://api.github.com/repos/facebook/react/issues/25576/comments | https://api.github.com/repos/facebook/react/issues/25576/events | https://github.com/facebook/react/pull/25576 | 1,426,163,143 | PR_kwDOAJy2Ks5BsbiK | 25,576 | Minor wording fixes | {'login': 'Vitalik-Hakim', 'id': 73163003, 'node_id': 'MDQ6VXNlcjczMTYzMDAz', 'avatar_url': 'https://avatars.githubusercontent.com/u/73163003?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Vitalik-Hakim', 'html_url': 'https://github.com/Vitalik-Hakim', 'followers_url': 'https://api.github.com/users/Vital... | [] | closed | false | null | [] | null | [
"Since these are all subjective nits that don't seem to alter or clarify the original meaning, I'm going to close. But thanks for your suggestions."
] | 2022-10-27 19:25:23 | 2022-10-27 19:29:34 | 2022-10-27 19:29:33 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25576', 'html_url': 'https://github.com/facebook/react/pull/25576', 'diff_url': 'https://github.com/facebook/react/pull/25576.diff', 'patch_url': 'https://github.com/facebook/react/pull/25576.patch', 'merged_at': None} | Minor wording fixes in readme | {'url': 'https://api.github.com/repos/facebook/react/issues/25576/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25576/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25575 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25575/labels{/name} | https://api.github.com/repos/facebook/react/issues/25575/comments | https://api.github.com/repos/facebook/react/issues/25575/events | https://github.com/facebook/react/pull/25575 | 1,426,061,951 | PR_kwDOAJy2Ks5BsGHb | 25,575 | [cleanup] remove unused values from ReactFeatureFlags.www-dynamic | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Let me know if this sound right, I'll dig into the test failures then. Not sure what's going on there.",
"revert replayFailedUnitOfWorkWithInvokeGuardedCallback change, seems like it should pass now"
] | 2022-10-27 17:56:43 | 2023-01-11 04:26:05 | 2023-01-11 04:26:01 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25575', 'html_url': 'https://github.com/facebook/react/pull/25575', 'diff_url': 'https://github.com/facebook/react/pull/25575.diff', 'patch_url': 'https://github.com/facebook/react/pull/25575.patch', 'merged_at': datetime.datetime(2023, 1, 11, 4, 26, 1)} | These values are never imported into `ReactFeatureFlags.www.js`, so they're unused:
- `allowConcurrentByDefault`
- `consoleManagedByDevToolsDuringStrictMode`
These values are never set in the WWW module (https://fburl.com/code/dsb2ohv8), so they're always `undefined` on www:
- `createRootStrictEffectsByDefault`
... | {'url': 'https://api.github.com/repos/facebook/react/issues/25575/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25575/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25574 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25574/labels{/name} | https://api.github.com/repos/facebook/react/issues/25574/comments | https://api.github.com/repos/facebook/react/issues/25574/events | https://github.com/facebook/react/issues/25574 | 1,425,728,231 | I_kwDOAJy2Ks5U-uLn | 25,574 | Enhancement: Better solution for useEffect to not make multiple calls. | {'login': 'sueannioanis', 'id': 3586765, 'node_id': 'MDQ6VXNlcjM1ODY3NjU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3586765?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sueannioanis', 'html_url': 'https://github.com/sueannioanis', 'followers_url': 'https://api.github.com/users/sueannioan... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Was able to find a good solution."
] | 2022-10-27 14:24:10 | 2022-10-27 16:15:58 | 2022-10-27 16:15:57 | NONE | null | null | null | We need a better solution for stopping multiple calls on a `useEffect` function.
React version: ^18.0.8
## Steps To Reproduce
1. Adding `useEffect` with a custom hook call.
Explanations that don't work:
- https://beta.reactjs.org/learn/synchronizing-with-effects#how-to-handle-the-effect-firing-twice-in-d... | {'url': 'https://api.github.com/repos/facebook/react/issues/25574/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25574/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25573 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25573/labels{/name} | https://api.github.com/repos/facebook/react/issues/25573/comments | https://api.github.com/repos/facebook/react/issues/25573/events | https://github.com/facebook/react/issues/25573 | 1,425,655,694 | I_kwDOAJy2Ks5U-ceO | 25,573 | What is the reason to patch the fetch? | {'login': 'artalar', 'id': 27290320, 'node_id': 'MDQ6VXNlcjI3MjkwMzIw', 'avatar_url': 'https://avatars.githubusercontent.com/u/27290320?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/artalar', 'html_url': 'https://github.com/artalar', 'followers_url': 'https://api.github.com/users/artalar/followers', 'fo... | [] | closed | false | null | [] | null | [
"I agree, patching fetch is a bad idea.\r\nThis should definitely be done in another way.",
"This is a seriously concerning choice",
"This is an absurd breach of what developers expect out of something like React. Don't monkeypatch existing, standardized browser APIs. If you want to build your own fetch wrapper... | 2022-10-27 13:38:59 | 2024-04-24 13:09:58 | 2022-10-27 19:58:06 | NONE | null | null | null | [This](https://github.com/facebook/react/blob/main/packages/react/src/ReactFetch.js) looks so unpredictable:
- [works only for `get` and `head`](https://github.com/facebook/react/blob/28a574ea8f5d0efa95f861abca26a67af47dd0c0/packages/react/src/ReactFetch.js#L79) (Many APIs request data via `post`)
- do not support ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25573/reactions', 'total_count': 200, '+1': 128, '-1': 0, 'laugh': 1, 'hooray': 0, 'confused': 0, 'heart': 71, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25573/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25572 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25572/labels{/name} | https://api.github.com/repos/facebook/react/issues/25572/comments | https://api.github.com/repos/facebook/react/issues/25572/events | https://github.com/facebook/react/issues/25572 | 1,425,028,258 | I_kwDOAJy2Ks5U8DSi | 25,572 | Suggestion: It is recommended to provide an api for querying root container globally | {'login': 'Mumujianguang', 'id': 52249626, 'node_id': 'MDQ6VXNlcjUyMjQ5NjI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/52249626?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Mumujianguang', 'html_url': 'https://github.com/Mumujianguang', 'followers_url': 'https://api.github.com/users/Mumuj... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"a good solution to splitting UI and business logic, see: https://github.com/hawx1993/hooks-view-model",
"This is a big problem that requires you to save the root object somehow.\r\n\r\nUsing the above example, something like this would be immensely helpful.\r\n```js\r\nconst rootDom = document.querySelector('#ro... | 2022-10-27 04:51:35 | 2024-04-17 10:03:13 | 2024-04-17 10:03:12 | NONE | null | null | null | In react 18, it is difficult to uninstall components in some scenarios
```js
// a.tsx
function render() {
const root = createRoot(document.querySelector('#root'));
root.render(<Mask />)
}
```
```js
// b.ts
function destroy() {
// before
const rootDom= document.querySelector('#root');
... | {'url': 'https://api.github.com/repos/facebook/react/issues/25572/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25572/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25571 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25571/labels{/name} | https://api.github.com/repos/facebook/react/issues/25571/comments | https://api.github.com/repos/facebook/react/issues/25571/events | https://github.com/facebook/react/pull/25571 | 1,424,998,520 | PR_kwDOAJy2Ks5Bog0I | 25,571 | Try assigning fetch to globalThis if global assignment fails | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 17204056d5ec0a53a74979321c519137d215cf64...7461214434220c390d31c69f9a8364ff6bbd7d00\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-27 04:09:02 | 2022-10-29 21:55:17 | 2022-10-27 06:43:18 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25571', 'html_url': 'https://github.com/facebook/react/pull/25571', 'diff_url': 'https://github.com/facebook/react/pull/25571.diff', 'patch_url': 'https://github.com/facebook/react/pull/25571.patch', 'merged_at': datetime.datetime(2022, 10, 27, 6, 43, 18)} | In case it's a more modern yet rigid environment.
| {'url': 'https://api.github.com/repos/facebook/react/issues/25571/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25571/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25570 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25570/labels{/name} | https://api.github.com/repos/facebook/react/issues/25570/comments | https://api.github.com/repos/facebook/react/issues/25570/events | https://github.com/facebook/react/pull/25570 | 1,424,796,533 | PR_kwDOAJy2Ks5Bn2Mv | 25,570 | Add errorInfo argument to onError in Fizz | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fecc288b7dce182fbc3056b3f98a445a95fb1e68...6f7aa85cf1120030c3b8f133ad16d835b51a56d0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-26 23:02:04 | 2024-04-09 23:22:09 | 2024-04-09 23:22:09 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25570', 'html_url': 'https://github.com/facebook/react/pull/25570', 'diff_url': 'https://github.com/facebook/react/pull/25570.diff', 'patch_url': 'https://github.com/facebook/react/pull/25570.patch', 'merged_at': None} | Fizz currently accepts an onError callback which is provided any errors thrown during rendering. However previously the component stack was generated and sent to the client after logging the error so if you relied upon server logs to see where an error ocurred it was hard to make sense of it.
This change adds errorI... | {'url': 'https://api.github.com/repos/facebook/react/issues/25570/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25570/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25569 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25569/labels{/name} | https://api.github.com/repos/facebook/react/issues/25569/comments | https://api.github.com/repos/facebook/react/issues/25569/events | https://github.com/facebook/react/pull/25569 | 1,424,674,983 | PR_kwDOAJy2Ks5BncA6 | 25,569 | [Float] fix coordination of resource identity and hydration | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fecc288b7dce182fbc3056b3f98a445a95fb1e68...54cb45a94a724882725239f4aec4d59d42fd491c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-26 20:47:33 | 2022-10-27 02:53:34 | 2022-10-27 02:53:30 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25569', 'html_url': 'https://github.com/facebook/react/pull/25569', 'diff_url': 'https://github.com/facebook/react/pull/25569.diff', 'patch_url': 'https://github.com/facebook/react/pull/25569.patch', 'merged_at': datetime.datetime(2022, 10, 27, 2, 53, 30)} | there are a few bugs where dom representations from SSR aren't identified as Resources when they should be.
There are 3 semantics
Resource -> hoist to head, deduping, etc...
hydratable Component -> SSR'd and hydrated in place
non-hydratable Component -> never SSR'd, never hydrated, always inserted on the client... | {'url': 'https://api.github.com/repos/facebook/react/issues/25569/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25569/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25568 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25568/labels{/name} | https://api.github.com/repos/facebook/react/issues/25568/comments | https://api.github.com/repos/facebook/react/issues/25568/events | https://github.com/facebook/react/pull/25568 | 1,424,513,060 | PR_kwDOAJy2Ks5Bm45w | 25,568 | Fork ReactDOMSharedInternals for www | {'login': 'poteto', 'id': 1390709, 'node_id': 'MDQ6VXNlcjEzOTA3MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1390709?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/poteto', 'html_url': 'https://github.com/poteto', 'followers_url': 'https://api.github.com/users/poteto/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fecc288b7dce182fbc3056b3f98a445a95fb1e68...e617e9c6f756c31cc74d3e29486df2c9a8de88ae\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-26 18:22:29 | 2022-10-27 14:49:53 | 2022-10-27 14:49:47 | MEMBER | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/25568', 'html_url': 'https://github.com/facebook/react/pull/25568', 'diff_url': 'https://github.com/facebook/react/pull/25568.diff', 'patch_url': 'https://github.com/facebook/react/pull/25568.patch', 'merged_at': None} | I'm not sure if there's a better way to do this, but internally we have some restrictions so we need to add an indirection. | {'url': 'https://api.github.com/repos/facebook/react/issues/25568/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25568/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25567 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25567/labels{/name} | https://api.github.com/repos/facebook/react/issues/25567/comments | https://api.github.com/repos/facebook/react/issues/25567/events | https://github.com/facebook/react/pull/25567 | 1,424,287,017 | PR_kwDOAJy2Ks5BmG_K | 25,567 | [ServerRenderer] Setup for adding data attributes streaming format | {'login': 'mofeiZ', 'id': 34200447, 'node_id': 'MDQ6VXNlcjM0MjAwNDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/34200447?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mofeiZ', 'html_url': 'https://github.com/mofeiZ', 'followers_url': 'https://api.github.com/users/mofeiZ/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fecc288b7dce182fbc3056b3f98a445a95fb1e68...5f4d56033bf1c2f48c7ffe23cf6dc48fbcfe0da1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-26 15:49:26 | 2022-11-01 16:04:51 | 2022-11-01 16:04:51 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25567', 'html_url': 'https://github.com/facebook/react/pull/25567', 'diff_url': 'https://github.com/facebook/react/pull/25567.diff', 'patch_url': 'https://github.com/facebook/react/pull/25567.patch', 'merged_at': datetime.datetime(2022, 11, 1, 16, 4, 51)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25567/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25567/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25566 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25566/labels{/name} | https://api.github.com/repos/facebook/react/issues/25566/comments | https://api.github.com/repos/facebook/react/issues/25566/events | https://github.com/facebook/react/pull/25566 | 1,424,094,610 | PR_kwDOAJy2Ks5Blcp4 | 25,566 | [cleanup] remove dead feature flag warnAboutDeprecatedLifecycles | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2022-10-26 14:06:06 | 2023-01-10 15:27:42 | 2023-01-10 15:27:42 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25566', 'html_url': 'https://github.com/facebook/react/pull/25566', 'diff_url': 'https://github.com/facebook/react/pull/25566.diff', 'patch_url': 'https://github.com/facebook/react/pull/25566.patch', 'merged_at': None} | This was always set to true, I think we can clean this feature flag up.
| {'url': 'https://api.github.com/repos/facebook/react/issues/25566/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25566/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25565 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25565/labels{/name} | https://api.github.com/repos/facebook/react/issues/25565/comments | https://api.github.com/repos/facebook/react/issues/25565/events | https://github.com/facebook/react/issues/25565 | 1,423,255,423 | I_kwDOAJy2Ks5U1Sd_ | 25,565 | Bug: useSyncExternalStore does not update internal value if a setState is also called, outside useEffect, causing store sets not re-render | {'login': 'pandaiolo', 'id': 1933404, 'node_id': 'MDQ6VXNlcjE5MzM0MDQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1933404?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pandaiolo', 'html_url': 'https://github.com/pandaiolo', 'followers_url': 'https://api.github.com/users/pandaiolo/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"In order to familiarize myself with react codebase, I wrote a small test that fails on this pattern. (even if it is expected so)\r\n\r\nHere is it fwiw (in `packages/react-reconciler/src/__tests__/useSyncExternalStore-test.js`):\r\n\r\n```js\r\ntest('store value is correctly stored in current hook instance even wi... | 2022-10-26 00:15:04 | 2022-11-08 10:25:44 | 2022-11-08 10:25:44 | CONTRIBUTOR | null | null | null | In a custom hook, I forgot to wrap my `setState` call in a `useEffect`, which did not pose any problems prior to React 18 but now this does not work anymore. The component does not re-render if the store is changed back to its initial value. I guess this might be expected, but there was no warning whatsoever, so it was... | {'url': 'https://api.github.com/repos/facebook/react/issues/25565/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25565/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25564 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25564/labels{/name} | https://api.github.com/repos/facebook/react/issues/25564/comments | https://api.github.com/repos/facebook/react/issues/25564/events | https://github.com/facebook/react/issues/25564 | 1,422,974,716 | I_kwDOAJy2Ks5U0N78 | 25,564 | [DevTools Bug]: Not seeing source / file path | {'login': 'jschuler', 'id': 869106, 'node_id': 'MDQ6VXNlcjg2OTEwNg==', 'avatar_url': 'https://avatars.githubusercontent.com/u/869106?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jschuler', 'html_url': 'https://github.com/jschuler', 'followers_url': 'https://api.github.com/users/jschuler/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | null | [] | null | [
"@jschuler: We're sorry you've seen this error. ❤️\n\nIt looks like you forgot to specify a valid URL. (This means that we will not be able to reproduce the problem you're reporting.)\n\nPlease help us by providing a link to a CodeSandbox (https://codesandbox.io/s/new), a repository on GitHub, or a minimal code exa... | 2022-10-25 19:39:07 | 2022-10-31 08:42:48 | null | NONE | null | null | null | ### Website or app
[Any](https://reactjs.org/)
### Repro steps
Open react dev tools in browser
Select a react component from the tree
Notice that no Source (file path) is printed in the bottom right panel (see description screenshot in https://github.com/facebook/react/pull/17567)
### How often does t... | {'url': 'https://api.github.com/repos/facebook/react/issues/25564/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25564/timeline | null | reopened | false |
https://api.github.com/repos/facebook/react/issues/25563 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25563/labels{/name} | https://api.github.com/repos/facebook/react/issues/25563/comments | https://api.github.com/repos/facebook/react/issues/25563/events | https://github.com/facebook/react/issues/25563 | 1,422,540,916 | I_kwDOAJy2Ks5UykB0 | 25,563 | Bug: Infinite loop in Suspense | {'login': 'Skolotsky', 'id': 6927091, 'node_id': 'MDQ6VXNlcjY5MjcwOTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6927091?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Skolotsky', 'html_url': 'https://github.com/Skolotsky', 'followers_url': 'https://api.github.com/users/Skolotsky/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"a good solution to splitting UI and business logic, see: https://github.com/hawx1993/hooks-view-model",
"Instead of writing `loading.promise = null` if you just reset the state to its initial value\r\nlike `setLoading(() => {return {promise:null})` then it doesn't go into an infinite loop and I think that this i... | 2022-10-25 14:15:13 | 2024-04-17 10:03:15 | 2024-04-17 10:03:14 | NONE | null | null | null | React starts infinite rendering loop on promise resolve
React version: 18.2.0
## Steps To Reproduce
1. Wrap component with Suspense
2. Pass object which will have promise there
3. Create promise and in `setTimeout(..., 0)` call it's resolve
Link to code example:
Open sandbox and click `Start and Finis... | {'url': 'https://api.github.com/repos/facebook/react/issues/25563/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25563/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25562 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25562/labels{/name} | https://api.github.com/repos/facebook/react/issues/25562/comments | https://api.github.com/repos/facebook/react/issues/25562/events | https://github.com/facebook/react/issues/25562 | 1,421,993,252 | I_kwDOAJy2Ks5UweUk | 25,562 | Bug: Concurrent mode does not improve page jank | {'login': 'jeremies', 'id': 18210819, 'node_id': 'MDQ6VXNlcjE4MjEwODE5', 'avatar_url': 'https://avatars.githubusercontent.com/u/18210819?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jeremies', 'html_url': 'https://github.com/jeremies', 'followers_url': 'https://api.github.com/users/jeremies/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [
"a good solution to splitting UI and business logic, see: https://github.com/hawx1993/hooks-view-model",
"> a good solution to splitting UI and business logic, see: https://github.com/hawx1993/hooks-view-model\r\n\r\n@hawx1993 Thanks for the suggestion. Shall you fork the codesandbox using your hooks-view-model p... | 2022-10-25 07:26:41 | 2024-04-10 21:22:02 | null | NONE | null | null | null | React version: 18.0.0
## Steps To Reproduce
1. Open web page https://9bzvbl.csb.app/
2. Enter number 2 on the input
## The current behavior
Look how the FPS at top left corner decrease to a low number (depending on your CPU, you can increase the list length if you don't see low FPS)
## The expected beha... | {'url': 'https://api.github.com/repos/facebook/react/issues/25562/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25562/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/25561 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25561/labels{/name} | https://api.github.com/repos/facebook/react/issues/25561/comments | https://api.github.com/repos/facebook/react/issues/25561/events | https://github.com/facebook/react/pull/25561 | 1,421,695,448 | PR_kwDOAJy2Ks5Bdc_b | 25,561 | Allow uncached IO to stablize | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6883d79445f38e2cdabf6fe1fa04cb44c2644c1c...401230ea5353a5e90b721d66f9064b503ec84059\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-25 01:22:11 | 2022-11-01 19:00:35 | 2022-11-01 19:00:35 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25561', 'html_url': 'https://github.com/facebook/react/pull/25561', 'diff_url': 'https://github.com/facebook/react/pull/25561.diff', 'patch_url': 'https://github.com/facebook/react/pull/25561.patch', 'merged_at': datetime.datetime(2022, 11, 1, 19, 0, 35)} | Initial draft. I need to test this more.
If a promise is passed to `use`, but the I/O isn't cached, we should still be able to unwrap it.
This already worked in Server Components, and during SSR.
For Fiber (in the browser), before this fix the state would get lost between attempts unless the promise resolved i... | {'url': 'https://api.github.com/repos/facebook/react/issues/25561/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25561/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25560 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25560/labels{/name} | https://api.github.com/repos/facebook/react/issues/25560/comments | https://api.github.com/repos/facebook/react/issues/25560/events | https://github.com/facebook/react/pull/25560 | 1,421,608,143 | PR_kwDOAJy2Ks5BdKm2 | 25,560 | Flight client error stack | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 996b00b78708ece4d584c9a81b5460a1bdb752e6...bd269f0f77e669d12d89ef18330534a7eb319dc3\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-24 23:25:36 | 2022-10-24 23:32:36 | 2022-10-24 23:32:34 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25560', 'html_url': 'https://github.com/facebook/react/pull/25560', 'diff_url': 'https://github.com/facebook/react/pull/25560.diff', 'patch_url': 'https://github.com/facebook/react/pull/25560.patch', 'merged_at': datetime.datetime(2022, 10, 24, 23, 32, 34)} | restore error message into stack for flight prod errors | {'url': 'https://api.github.com/repos/facebook/react/issues/25560/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25560/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25559 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25559/labels{/name} | https://api.github.com/repos/facebook/react/issues/25559/comments | https://api.github.com/repos/facebook/react/issues/25559/events | https://github.com/facebook/react/pull/25559 | 1,421,541,515 | PR_kwDOAJy2Ks5Bc8N9 | 25,559 | [Float] handle noscript context for Resources | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 17204056d5ec0a53a74979321c519137d215cf64...0b67cfa9e19d1544a9b4617ed7d891172d295f26\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-24 22:21:17 | 2022-10-27 06:11:34 | 2022-10-27 06:11:31 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25559', 'html_url': 'https://github.com/facebook/react/pull/25559', 'diff_url': 'https://github.com/facebook/react/pull/25559.diff', 'patch_url': 'https://github.com/facebook/react/pull/25559.patch', 'merged_at': datetime.datetime(2022, 10, 27, 6, 11, 31)} | stacked on https://github.com/facebook/react/pull/25569
On the client noscript already never renders children so no resources will be extracted from this context. On the server we now track if we are in a noscript context and turn off Resource semantics in this scope | {'url': 'https://api.github.com/repos/facebook/react/issues/25559/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25559/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25558 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25558/labels{/name} | https://api.github.com/repos/facebook/react/issues/25558/comments | https://api.github.com/repos/facebook/react/issues/25558/events | https://github.com/facebook/react/issues/25558 | 1,421,503,240 | I_kwDOAJy2Ks5UumsI | 25,558 | Bug: Using `useSyncExternalStore` changes don't get reflected in UI in production | {'login': 'alinnert', 'id': 2638971, 'node_id': 'MDQ6VXNlcjI2Mzg5NzE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2638971?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/alinnert', 'html_url': 'https://github.com/alinnert', 'followers_url': 'https://api.github.com/users/alinnert/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"It seems that you are not subscribing correctly:\r\n\r\n```ts\r\nexport function subscribe(onStoreChange: () => void): () => void {\r\n // <-- should subscribe here\r\n return () => listeners.push(onStoreChange); // and unsubscribe here\r\n}\r\n```\r\n\r\nbasically you are not subscribing at all in production sc... | 2022-10-24 21:51:45 | 2022-10-25 22:14:08 | 2022-10-25 22:14:08 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
I've implemented a very minimalistic store and connected it to React using `useS... | {'url': 'https://api.github.com/repos/facebook/react/issues/25558/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25558/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25557 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25557/labels{/name} | https://api.github.com/repos/facebook/react/issues/25557/comments | https://api.github.com/repos/facebook/react/issues/25557/events | https://github.com/facebook/react/pull/25557 | 1,421,179,652 | PR_kwDOAJy2Ks5BbtA4 | 25,557 | fix: update doc | {'login': 'riddlenobody', 'id': 17842580, 'node_id': 'MDQ6VXNlcjE3ODQyNTgw', 'avatar_url': 'https://avatars.githubusercontent.com/u/17842580?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/riddlenobody', 'html_url': 'https://github.com/riddlenobody', 'followers_url': 'https://api.github.com/users/riddleno... | [] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: e7c5af45ceb8fa2b64d39ec68345254ce9abd65e...5e8d0d51c4e242e7bff5e02337cd957b89476145\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-24 17:34:05 | 2022-10-24 17:39:36 | 2022-10-24 17:34:36 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25557', 'html_url': 'https://github.com/facebook/react/pull/25557', 'diff_url': 'https://github.com/facebook/react/pull/25557.diff', 'patch_url': 'https://github.com/facebook/react/pull/25557.patch', 'merged_at': None} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/25557/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25557/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25556 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25556/labels{/name} | https://api.github.com/repos/facebook/react/issues/25556/comments | https://api.github.com/repos/facebook/react/issues/25556/events | https://github.com/facebook/react/pull/25556 | 1,421,161,964 | PR_kwDOAJy2Ks5BbpQB | 25,556 | A few Suspense related refactors | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5450dd409863b31fa7ef4dfcf8aeb06ac16c4c10...d3705eef912ef7096aeeac4e80d7ff309d352ffc\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-24 17:18:11 | 2022-10-29 00:19:46 | 2022-10-29 00:19:46 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25556', 'html_url': 'https://github.com/facebook/react/pull/25556', 'diff_url': 'https://github.com/facebook/react/pull/25556.diff', 'patch_url': 'https://github.com/facebook/react/pull/25556.patch', 'merged_at': datetime.datetime(2022, 10, 29, 0, 19, 46)} | Some Suspense-related refactors to prepare for a feature I'm working on. There are no behavioral changes. (Except for the first commit that adds a warning, which I opened as a separate PR: https://github.com/facebook/react/pull/25543. I can split the warning out if we're not sure we want to enable it yet.)
You can r... | {'url': 'https://api.github.com/repos/facebook/react/issues/25556/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25556/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25555 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25555/labels{/name} | https://api.github.com/repos/facebook/react/issues/25555/comments | https://api.github.com/repos/facebook/react/issues/25555/events | https://github.com/facebook/react/pull/25555 | 1,421,093,382 | PR_kwDOAJy2Ks5BbarE | 25,555 | Update README.md | {'login': 'ryanvienna', 'id': 116581203, 'node_id': 'U_kgDOBvLjUw', 'avatar_url': 'https://avatars.githubusercontent.com/u/116581203?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ryanvienna', 'html_url': 'https://github.com/ryanvienna', 'followers_url': 'https://api.github.com/users/ryanvienna/followers... | [] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: e7c5af45ceb8fa2b64d39ec68345254ce9abd65e...7577867d981fdc5f7c968a37e0f8aae72b1db2dc\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-24 16:22:30 | 2022-10-24 17:27:32 | 2022-10-24 17:27:32 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25555', 'html_url': 'https://github.com/facebook/react/pull/25555', 'diff_url': 'https://github.com/facebook/react/pull/25555.diff', 'patch_url': 'https://github.com/facebook/react/pull/25555.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25555/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25555/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25554 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25554/labels{/name} | https://api.github.com/repos/facebook/react/issues/25554/comments | https://api.github.com/repos/facebook/react/issues/25554/events | https://github.com/facebook/react/pull/25554 | 1,421,092,996 | PR_kwDOAJy2Ks5Bbalw | 25,554 | [Tiny] Fixed incorrect import in `react-server-dom-webpack` | {'login': 'leo', 'id': 6170607, 'node_id': 'MDQ6VXNlcjYxNzA2MDc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6170607?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/leo', 'html_url': 'https://github.com/leo', 'followers_url': 'https://api.github.com/users/leo/followers', 'following_url': 'htt... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"cc @gnoff, who reviewed the previous PR that introduced this bug.",
"Not sure why \"CircleCI Pipeline\" isn't running...? Seems to be broken on most other PRs too.",
"cc @sebmarkbage ",
"Good catch. This plugin is a bit outdated too though because it's not following the [latest convention](https://github.com... | 2022-10-24 16:22:11 | 2022-10-24 19:01:12 | 2022-10-24 17:40:19 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25554', 'html_url': 'https://github.com/facebook/react/pull/25554', 'diff_url': 'https://github.com/facebook/react/pull/25554.diff', 'patch_url': 'https://github.com/facebook/react/pull/25554.patch', 'merged_at': datetime.datetime(2022, 10, 24, 17, 40, 19)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25554/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25554/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25553 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25553/labels{/name} | https://api.github.com/repos/facebook/react/issues/25553/comments | https://api.github.com/repos/facebook/react/issues/25553/events | https://github.com/facebook/react/issues/25553 | 1,420,674,207 | I_kwDOAJy2Ks5UrcSf | 25,553 | Bug: Why does react fail to implement bidirectional data binding | {'login': 'cakeerrr', 'id': 116561379, 'node_id': 'U_kgDOBvKV4w', 'avatar_url': 'https://avatars.githubusercontent.com/u/116561379?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cakeerrr', 'html_url': 'https://github.com/cakeerrr', 'followers_url': 'https://api.github.com/users/cakeerrr/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"If you want to use bidirectional data binding, see my solution here: https://github.com/hawx1993/hooks-view-model",
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven'... | 2022-10-24 11:23:57 | 2024-04-17 10:03:16 | 2024-04-17 10:03:15 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/25553/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25553/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25552 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25552/labels{/name} | https://api.github.com/repos/facebook/react/issues/25552/comments | https://api.github.com/repos/facebook/react/issues/25552/events | https://github.com/facebook/react/issues/25552 | 1,420,609,791 | I_kwDOAJy2Ks5UrMj_ | 25,552 | Bug: React Whether gradual migration is supported | {'login': 'Lady-ru', 'id': 116558231, 'node_id': 'U_kgDOBvKJlw', 'avatar_url': 'https://avatars.githubusercontent.com/u/116558231?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Lady-ru', 'html_url': 'https://github.com/Lady-ru', 'followers_url': 'https://api.github.com/users/Lady-ru/followers', 'followin... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1168115654, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:\r\n\r\nCoding Questions\r\nIf you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to brow... | 2022-10-24 10:34:44 | 2022-10-24 21:28:32 | 2022-10-24 21:28:28 | NONE | null | null | null | React Whether gradual migration is supported | {'url': 'https://api.github.com/repos/facebook/react/issues/25552/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25552/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25551 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25551/labels{/name} | https://api.github.com/repos/facebook/react/issues/25551/comments | https://api.github.com/repos/facebook/react/issues/25551/events | https://github.com/facebook/react/issues/25551 | 1,420,579,911 | I_kwDOAJy2Ks5UrFRH | 25,551 | Bug: why render it twice | {'login': 'sellyWu', 'id': 116540191, 'node_id': 'U_kgDOBvJDHw', 'avatar_url': 'https://avatars.githubusercontent.com/u/116540191?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sellyWu', 'html_url': 'https://github.com/sellyWu', 'followers_url': 'https://api.github.com/users/sellyWu/followers', 'followin... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The render is only twice since react 18 and only in dev mode when strict mode is enabled. It is for testing if the component unmounts correctly.\nWhat do you mean with the second question?",
"Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we sug... | 2022-10-24 10:11:10 | 2022-10-24 17:41:32 | 2022-10-24 17:41:32 | NONE | null | null | null | why render it twice? You can add a compiler to the document.? | {'url': 'https://api.github.com/repos/facebook/react/issues/25551/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25551/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25550 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25550/labels{/name} | https://api.github.com/repos/facebook/react/issues/25550/comments | https://api.github.com/repos/facebook/react/issues/25550/events | https://github.com/facebook/react/pull/25550 | 1,420,556,998 | PR_kwDOAJy2Ks5BZnbI | 25,550 | 编译命令 | {'login': 'xusanduo08', 'id': 17930163, 'node_id': 'MDQ6VXNlcjE3OTMwMTYz', 'avatar_url': 'https://avatars.githubusercontent.com/u/17930163?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/xusanduo08', 'html_url': 'https://github.com/xusanduo08', 'followers_url': 'https://api.github.com/users/xusanduo08/fol... | [] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/25550/builds/308080) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on comm... | 2022-10-24 09:53:09 | 2022-10-24 14:53:06 | 2022-10-24 14:53:06 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25550', 'html_url': 'https://github.com/facebook/react/pull/25550', 'diff_url': 'https://github.com/facebook/react/pull/25550.diff', 'patch_url': 'https://github.com/facebook/react/pull/25550.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25550/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25550/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25549 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25549/labels{/name} | https://api.github.com/repos/facebook/react/issues/25549/comments | https://api.github.com/repos/facebook/react/issues/25549/events | https://github.com/facebook/react/pull/25549 | 1,420,144,939 | PR_kwDOAJy2Ks5BYPhF | 25,549 | Fix react/dom parse style array #25548 | {'login': 'linjinze999', 'id': 19993351, 'node_id': 'MDQ6VXNlcjE5OTkzMzUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/19993351?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/linjinze999', 'html_url': 'https://github.com/linjinze999', 'followers_url': 'https://api.github.com/users/linjinze999... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"> facebook#25548\r\n1. I have added the style tests.\r\n2. **React Native support [array of styles](https://reactnative.dev/docs/style).**\r\n```\r\nThe style prop can be a plain old JavaScript object. That's what we usually use for example code. \r\nYou can also pass an array of styles - the last style in the arr... | 2022-10-24 03:20:13 | 2024-04-17 10:03:17 | 2024-04-17 10:03:16 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25549', 'html_url': 'https://github.com/facebook/react/pull/25549', 'diff_url': 'https://github.com/facebook/react/pull/25549.diff', 'patch_url': 'https://github.com/facebook/react/pull/25549.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25549/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25549/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25548 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25548/labels{/name} | https://api.github.com/repos/facebook/react/issues/25548/comments | https://api.github.com/repos/facebook/react/issues/25548/events | https://github.com/facebook/react/issues/25548 | 1,420,114,897 | I_kwDOAJy2Ks5UpTvR | 25,548 | Bug: react-dom/server renderToString don't support array style(react-native ssr) | {'login': 'linjinze999', 'id': 19993351, 'node_id': 'MDQ6VXNlcjE5OTkzMzUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/19993351?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/linjinze999', 'html_url': 'https://github.com/linjinze999', 'followers_url': 'https://api.github.com/users/linjinze999... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/... | open | false | null | [] | null | [] | 2022-10-24 02:43:29 | 2022-10-29 08:37:51 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.2
## Steps To Reproduce
<!--
Your bug will get fixe... | {'url': 'https://api.github.com/repos/facebook/react/issues/25548/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25548/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/25547 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25547/labels{/name} | https://api.github.com/repos/facebook/react/issues/25547/comments | https://api.github.com/repos/facebook/react/issues/25547/events | https://github.com/facebook/react/pull/25547 | 1,420,042,032 | PR_kwDOAJy2Ks5BX5Kg | 25,547 | [cleanup]: meaningless hasTimeRemaining should be removed | {'login': 'bubucuo', 'id': 9839620, 'node_id': 'MDQ6VXNlcjk4Mzk2MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9839620?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bubucuo', 'html_url': 'https://github.com/bubucuo', 'followers_url': 'https://api.github.com/users/bubucuo/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"It's hard-coded as `true` here but not in the mock fork. It looks like that the compiled output has this hard-coded value removed anyway (hence no bundle size impact) so maybe this should be kept to not diverge forks needlessly?"
] | 2022-10-24 01:27:35 | 2024-01-11 15:48:59 | 2024-01-11 15:48:59 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25547', 'html_url': 'https://github.com/facebook/react/pull/25547', 'diff_url': 'https://github.com/facebook/react/pull/25547.diff', 'patch_url': 'https://github.com/facebook/react/pull/25547.patch', 'merged_at': None} | 'hasTimeRemaining' was set true as a constant, and never changed it. So 'workLoop' function should skip it.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fiel... | {'url': 'https://api.github.com/repos/facebook/react/issues/25547/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25547/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25546 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25546/labels{/name} | https://api.github.com/repos/facebook/react/issues/25546/comments | https://api.github.com/repos/facebook/react/issues/25546/events | https://github.com/facebook/react/pull/25546 | 1,419,942,739 | PR_kwDOAJy2Ks5BXj_A | 25,546 | [Float] support <base> as Resource | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cce18e3504fca651051da72cf9c2d126c16eb013...941479a16d49f062d4e88376c4eca6b93d2e2b44\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-23 21:27:44 | 2022-10-23 22:03:56 | 2022-10-23 22:03:53 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25546', 'html_url': 'https://github.com/facebook/react/pull/25546', 'diff_url': 'https://github.com/facebook/react/pull/25546.diff', 'patch_url': 'https://github.com/facebook/react/pull/25546.patch', 'merged_at': datetime.datetime(2022, 10, 23, 22, 3, 53)} | keys off `target` and `href`.
prepends on insertion similar to title.
only flushes on the server in the shell (should probably add a warning if there are any to flush in a boundary) | {'url': 'https://api.github.com/repos/facebook/react/issues/25546/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25546/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25545 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25545/labels{/name} | https://api.github.com/repos/facebook/react/issues/25545/comments | https://api.github.com/repos/facebook/react/issues/25545/events | https://github.com/facebook/react/pull/25545 | 1,419,875,837 | PR_kwDOAJy2Ks5BXWdR | 25,545 | Bug fix when resolving cache | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cce18e3504fca651051da72cf9c2d126c16eb013...0cd607b4a3a3d6a8d668aedcb21d2323a0e1c005\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-23 18:03:39 | 2022-10-23 18:12:47 | 2022-10-23 18:12:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25545', 'html_url': 'https://github.com/facebook/react/pull/25545', 'diff_url': 'https://github.com/facebook/react/pull/25545.diff', 'patch_url': 'https://github.com/facebook/react/pull/25545.patch', 'merged_at': datetime.datetime(2022, 10, 23, 18, 12, 47)} | We must use the asynclocalstorage one if it's available.
| {'url': 'https://api.github.com/repos/facebook/react/issues/25545/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25545/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25544 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25544/labels{/name} | https://api.github.com/repos/facebook/react/issues/25544/comments | https://api.github.com/repos/facebook/react/issues/25544/events | https://github.com/facebook/react/issues/25544 | 1,419,851,416 | I_kwDOAJy2Ks5UoTaY | 25,544 | Suggestion for JSX syntax simplification | {'login': 'gebbber', 'id': 36095842, 'node_id': 'MDQ6VXNlcjM2MDk1ODQy', 'avatar_url': 'https://avatars.githubusercontent.com/u/36095842?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gebbber', 'html_url': 'https://github.com/gebbber', 'followers_url': 'https://api.github.com/users/gebbber/followers', 'fo... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"The current workaround does look elegant to me. I don't think it's worth the time to implement your suggestion; when a simple workaround exists (and isn't too trivial). : )",
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bum... | 2022-10-23 16:36:35 | 2024-04-17 10:03:18 | 2024-04-17 10:03:18 | NONE | null | null | null | ## Suggestion
I would like to suggest enhancing the JSX specification to allow:
```jsx
return <button {onClick}>Text</button>
```
to be parsed as equivalent to:
```jsx
return <button onClick={onClick}>Text</button>
```
## Rationale
This would improve readability and shorten line lengths, especially ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25544/reactions', 'total_count': 3, '+1': 2, '-1': 0, 'laugh': 1, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25544/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25543 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25543/labels{/name} | https://api.github.com/repos/facebook/react/issues/25543/comments | https://api.github.com/repos/facebook/react/issues/25543/events | https://github.com/facebook/react/pull/25543 | 1,419,633,050 | PR_kwDOAJy2Ks5BWnGW | 25,543 | Detect and warn if use(promise) is wrapped with try/catch block | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cf3932be5ca95bf5507a9566e4a9605bce0c5e21...da38d043eaf23b4f017aeff7e989326b4e0f9472\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-23 04:32:05 | 2022-10-28 21:46:04 | 2022-10-28 21:46:03 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25543', 'html_url': 'https://github.com/facebook/react/pull/25543', 'diff_url': 'https://github.com/facebook/react/pull/25543.diff', 'patch_url': 'https://github.com/facebook/react/pull/25543.patch', 'merged_at': datetime.datetime(2022, 10, 28, 21, 46, 3)} | The old (unstable) mechanism for suspending was to throw a promise. The purpose of throwing is to interrupt the component's execution, and also to signal to React that the interruption was caused by Suspense as opposed to some other error.
A flaw is that throwing is meant to be an implementation detail — if code in ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25543/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25543/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25542 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25542/labels{/name} | https://api.github.com/repos/facebook/react/issues/25542/comments | https://api.github.com/repos/facebook/react/issues/25542/events | https://github.com/facebook/react/pull/25542 | 1,419,624,268 | PR_kwDOAJy2Ks5BWlbF | 25,542 | [Flight] Use AsyncLocalStorage to extend the scope of the cache to micro tasks | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: caa84c8da0aed390ec25783e577d91711dfd6bcc...e4de6114b1f7d8c897ee5579125c299afd6eb209\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-23 03:54:46 | 2022-10-23 05:06:59 | 2022-10-23 05:06:59 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25542', 'html_url': 'https://github.com/facebook/react/pull/25542', 'diff_url': 'https://github.com/facebook/react/pull/25542.diff', 'patch_url': 'https://github.com/facebook/react/pull/25542.patch', 'merged_at': datetime.datetime(2022, 10, 23, 5, 6, 58)} | This extends the scope of the cache and fetch instrumentation using AsyncLocalStorage for microtasks. This is an intermediate step. It sets up the dispatcher only once. This is unique to RSC because it uses the react.shared-subset module for its shared state.
Ideally we should support multiple renderers. We should a... | {'url': 'https://api.github.com/repos/facebook/react/issues/25542/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25542/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25541 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25541/labels{/name} | https://api.github.com/repos/facebook/react/issues/25541/comments | https://api.github.com/repos/facebook/react/issues/25541/events | https://github.com/facebook/react/pull/25541 | 1,419,610,088 | PR_kwDOAJy2Ks5BWioG | 25,541 | Revert yieldy behavior for non-use Suspense (in Flight, too) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cce18e3504fca651051da72cf9c2d126c16eb013...cefba1bd7b7e373e131304bf982e0ec070539f6b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-23 02:53:29 | 2022-10-24 03:23:04 | 2022-10-24 03:23:04 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25541', 'html_url': 'https://github.com/facebook/react/pull/25541', 'diff_url': 'https://github.com/facebook/react/pull/25541.diff', 'patch_url': 'https://github.com/facebook/react/pull/25541.patch', 'merged_at': None} | Same as #25537 but for Flight.
I was going to wait to do this later because the temporary implementation of async components uses some of the same code that non-used wakables do, but it's not so bad. I just had to inline one bit of code, which we'll remove when we unify the implementation with `use`. | {'url': 'https://api.github.com/repos/facebook/react/issues/25541/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25541/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25540 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25540/labels{/name} | https://api.github.com/repos/facebook/react/issues/25540/comments | https://api.github.com/repos/facebook/react/issues/25540/events | https://github.com/facebook/react/pull/25540 | 1,419,600,464 | PR_kwDOAJy2Ks5BWgoK | 25,540 | Revert fetch instrumentation to only RSC | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0c11baa6abea41132d0c894264783041ca852548...935848dc9bde4895c97e58d94268f5ae1896407f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-23 02:21:51 | 2022-10-23 02:58:31 | 2022-10-23 02:58:30 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25540', 'html_url': 'https://github.com/facebook/react/pull/25540', 'diff_url': 'https://github.com/facebook/react/pull/25540.diff', 'patch_url': 'https://github.com/facebook/react/pull/25540.patch', 'merged_at': datetime.datetime(2022, 10, 23, 2, 58, 30)} | Revert fetch instrumentation so that it only affects RSC by applying it only in the react-server condition of "react".
This helps make the rollout a little smoother because these affects existing libraries that fetch during client components, and then gets forever cached. We need to implement the GC first.
I have... | {'url': 'https://api.github.com/repos/facebook/react/issues/25540/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25540/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25539 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25539/labels{/name} | https://api.github.com/repos/facebook/react/issues/25539/comments | https://api.github.com/repos/facebook/react/issues/25539/events | https://github.com/facebook/react/pull/25539 | 1,419,572,959 | PR_kwDOAJy2Ks5BWbGg | 25,539 | Unify promise switch statements | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cce18e3504fca651051da72cf9c2d126c16eb013...66121957933d03a738ab3e688eb72fd91e038095\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-23 00:40:53 | 2022-10-23 22:43:30 | 2022-10-23 22:43:30 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25539', 'html_url': 'https://github.com/facebook/react/pull/25539', 'diff_url': 'https://github.com/facebook/react/pull/25539.diff', 'patch_url': 'https://github.com/facebook/react/pull/25539.patch', 'merged_at': datetime.datetime(2022, 10, 23, 22, 43, 30)} | ## Based on #25538
There are two different switch statements that we use to unwrap a `use`-ed promise, but there really only needs to be one. This was a factoring artifact that arose because I implemented the yieldy `status` instrumentation thing before I implemented `use` (for promises that are thrown directly dur... | {'url': 'https://api.github.com/repos/facebook/react/issues/25539/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25539/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25538 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25538/labels{/name} | https://api.github.com/repos/facebook/react/issues/25538/comments | https://api.github.com/repos/facebook/react/issues/25538/events | https://github.com/facebook/react/pull/25538 | 1,419,553,165 | PR_kwDOAJy2Ks5BWW5R | 25,538 | Track thenable state in work loop | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cce18e3504fca651051da72cf9c2d126c16eb013...6ad6cdf5f55c0dd3b67c1360142626c0e1297588\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-22 23:34:37 | 2022-10-24 17:36:11 | 2022-10-24 17:36:11 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25538', 'html_url': 'https://github.com/facebook/react/pull/25538', 'diff_url': 'https://github.com/facebook/react/pull/25538.diff', 'patch_url': 'https://github.com/facebook/react/pull/25538.patch', 'merged_at': None} | ## Based on #25541
This is a refactor to track the array of thenables that is preserved across replays in the work loop instead of the Thenable module.
The reason is that I'm about to add additional state to the Thenable module that is specific to a particular attempt — like the current index — and is reset betwe... | {'url': 'https://api.github.com/repos/facebook/react/issues/25538/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25538/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25537 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25537/labels{/name} | https://api.github.com/repos/facebook/react/issues/25537/comments | https://api.github.com/repos/facebook/react/issues/25537/events | https://github.com/facebook/react/pull/25537 | 1,419,514,349 | PR_kwDOAJy2Ks5BWPIC | 25,537 | Revert yieldy behavior for non-use Suspense | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 934177598e583672ac12fbc63288848c2f2930bc...5f9d29a6d393b79b9bf69aafe8d4029f550934f7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-22 21:15:57 | 2022-10-22 21:52:21 | 2022-10-22 21:52:20 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25537', 'html_url': 'https://github.com/facebook/react/pull/25537', 'diff_url': 'https://github.com/facebook/react/pull/25537.diff', 'patch_url': 'https://github.com/facebook/react/pull/25537.patch', 'merged_at': datetime.datetime(2022, 10, 22, 21, 52, 20)} | To derisk the rollout of `use`, and simplify the implementation, this reverts the yield-to-microtasks behavior for promises that are thrown directly (as opposed to being unwrapped by `use`).
We may add this back later. However, the plan is to deprecate throwing a promise directly and migrate all existing Suspense co... | {'url': 'https://api.github.com/repos/facebook/react/issues/25537/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25537/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25536 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25536/labels{/name} | https://api.github.com/repos/facebook/react/issues/25536/comments | https://api.github.com/repos/facebook/react/issues/25536/events | https://github.com/facebook/react/pull/25536 | 1,419,501,976 | PR_kwDOAJy2Ks5BWMhm | 25,536 | when float is enabled only push title and script as a single unit | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 934177598e583672ac12fbc63288848c2f2930bc...a36bde7dff4db5384be85cde9c8adbf99a538d3e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-22 20:45:19 | 2022-10-22 22:11:29 | 2022-10-22 22:11:26 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25536', 'html_url': 'https://github.com/facebook/react/pull/25536', 'diff_url': 'https://github.com/facebook/react/pull/25536.diff', 'patch_url': 'https://github.com/facebook/react/pull/25536.patch', 'merged_at': datetime.datetime(2022, 10, 22, 22, 11, 26)} | replaces: https://github.com/facebook/react/pull/25535
This takes a more huerstic based approach with no new conditionals on the hot path of fizz rendering.
If float is enabled
* title and script can only have simple children
* if non-simple children are found they will be ignored
* title and script are pushed... | {'url': 'https://api.github.com/repos/facebook/react/issues/25536/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25536/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25535 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25535/labels{/name} | https://api.github.com/repos/facebook/react/issues/25535/comments | https://api.github.com/repos/facebook/react/issues/25535/events | https://github.com/facebook/react/pull/25535 | 1,419,442,799 | PR_kwDOAJy2Ks5BWAT8 | 25,535 | [Float] handle non-void resources properly | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 934177598e583672ac12fbc63288848c2f2930bc...17cce5bb06fbc5683d19bc722e40d3e5f2586bc1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-22 18:30:21 | 2022-10-22 20:45:40 | 2022-10-22 20:45:34 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25535', 'html_url': 'https://github.com/facebook/react/pull/25535', 'diff_url': 'https://github.com/facebook/react/pull/25535.diff', 'patch_url': 'https://github.com/facebook/react/pull/25535.patch', 'merged_at': None} | Resources used to be all void but script and title have changed that. There was an implicit assumption that resources would be void and therefore the Fizz runtime did not have to consider whether it had pushed a Resource or Element.
Now that this void invariant no longer holds (title and script are not void) we need... | {'url': 'https://api.github.com/repos/facebook/react/issues/25535/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25535/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25534 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25534/labels{/name} | https://api.github.com/repos/facebook/react/issues/25534/comments | https://api.github.com/repos/facebook/react/issues/25534/events | https://github.com/facebook/react/pull/25534 | 1,419,377,797 | PR_kwDOAJy2Ks5BVy67 | 25,534 | fix transposed escape functions | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"would it be possible to add regression tests for this specific case?",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d1ced9fd58a1ba91febacba8ceaf2e17640fb942...e47291d31593b7ff96dd3f58b6fa60c0319e03f6\n\n## Critical size changes\n\nInclude... | 2022-10-22 16:00:03 | 2022-10-22 16:56:44 | 2022-10-22 16:56:41 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25534', 'html_url': 'https://github.com/facebook/react/pull/25534', 'diff_url': 'https://github.com/facebook/react/pull/25534.diff', 'patch_url': 'https://github.com/facebook/react/pull/25534.patch', 'merged_at': datetime.datetime(2022, 10, 22, 16, 56, 41)} | escapeTextForBrowser accepts any type so flow did not identify that we were escaping a Chunk rather than a string. It's tricky because we sometimes want to be able to escape non strings.
~~Long run I think it may be worth adding a lint to make sure you never escape a Chunk.~~
~~Another alternative would be to hav... | {'url': 'https://api.github.com/repos/facebook/react/issues/25534/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25534/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25533 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25533/labels{/name} | https://api.github.com/repos/facebook/react/issues/25533/comments | https://api.github.com/repos/facebook/react/issues/25533/events | https://github.com/facebook/react/issues/25533 | 1,419,342,732 | I_kwDOAJy2Ks5UmXOM | 25,533 | Compile JSX directly to VDom for improve draw of view performance and allow progressive view rendering | {'login': 'LabEG', 'id': 10910167, 'node_id': 'MDQ6VXNlcjEwOTEwMTY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10910167?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/LabEG', 'html_url': 'https://github.com/LabEG', 'followers_url': 'https://api.github.com/users/LabEG/followers', 'following_... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/... | open | false | null | [] | null | [
"I created a proof-of-concept to solve this issue partially, as a babel plugin: https://github.com/romgrk/babel-plugin-fast-jsx\r\n\r\nIt does its best to inline everything but some of the React/JSX semantics around key/ref prevent inline everything."
] | 2022-10-22 14:57:06 | 2024-03-19 06:18:58 | null | NONE | null | null | null | Right now JSX compiles to array of React.createElement or _jsx function. Each function calls for make VDom elements in runtime. I suggest compiling JSX directly to VDom. Because each function call in javascript has its own cost. On my PC its 2 nanoseonds. On 1000 JSX elements its 2 milliseconds.
This (call function... | {'url': 'https://api.github.com/repos/facebook/react/issues/25533/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25533/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/25532 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25532/labels{/name} | https://api.github.com/repos/facebook/react/issues/25532/comments | https://api.github.com/repos/facebook/react/issues/25532/events | https://github.com/facebook/react/pull/25532 | 1,419,139,834 | PR_kwDOAJy2Ks5BVBpZ | 25,532 | add warnings for non-resources rendered outside body or head | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d1ced9fd58a1ba91febacba8ceaf2e17640fb942...a06670514d5392b3a5f4bb5c01ff2d827ffec7bb\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-22 07:13:41 | 2022-10-22 22:19:45 | 2022-10-22 22:19:42 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25532', 'html_url': 'https://github.com/facebook/react/pull/25532', 'diff_url': 'https://github.com/facebook/react/pull/25532.diff', 'patch_url': 'https://github.com/facebook/react/pull/25532.patch', 'merged_at': datetime.datetime(2022, 10, 22, 22, 19, 42)} | Adds some clarifying warnings when you render a component that is almost a resource but isn't and the element was rendered outside the main document tree (outside of `<body>` or `<head>` | {'url': 'https://api.github.com/repos/facebook/react/issues/25532/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25532/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25531 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25531/labels{/name} | https://api.github.com/repos/facebook/react/issues/25531/comments | https://api.github.com/repos/facebook/react/issues/25531/events | https://github.com/facebook/react/issues/25531 | 1,419,046,690 | I_kwDOAJy2Ks5UlO8i | 25,531 | Bug: e.target.value of <option> differs from actual value | {'login': 'steveroof', 'id': 33550850, 'node_id': 'MDQ6VXNlcjMzNTUwODUw', 'avatar_url': 'https://avatars.githubusercontent.com/u/33550850?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/steveroof', 'html_url': 'https://github.com/steveroof', 'followers_url': 'https://api.github.com/users/steveroof/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Bug opened by mistake",
"Fixed mistake in code sandbox.",
"This seems to be part of HTML itself."
] | 2022-10-22 02:53:39 | 2022-10-22 03:14:58 | 2022-10-22 03:14:58 | NONE | null | null | null | I created a simple controlled select and populated it with a list of options, one of which contains two consecutive spaces. When I select this option in the select, the synthetic event does not faithfully contain the actual target.value. Instead it has scrubbed out one of the spaces, so in the event handler, I cannot d... | {'url': 'https://api.github.com/repos/facebook/react/issues/25531/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25531/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25530 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25530/labels{/name} | https://api.github.com/repos/facebook/react/issues/25530/comments | https://api.github.com/repos/facebook/react/issues/25530/events | https://github.com/facebook/react/pull/25530 | 1,418,967,140 | PR_kwDOAJy2Ks5BUdG3 | 25,530 | warn if you render a link above body/head when it is not a resource | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 973b90bdf6f4a1d9b3864d93985d4a204f233855...46e25833d285eb77b2bdf0e69bdc7885c26a0670\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-21 23:45:00 | 2022-10-22 22:12:00 | 2022-10-22 22:11:55 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25530', 'html_url': 'https://github.com/facebook/react/pull/25530', 'diff_url': 'https://github.com/facebook/react/pull/25530.diff', 'patch_url': 'https://github.com/facebook/react/pull/25530.patch', 'merged_at': None} | If you forget to add a precedence to a stylesheet or inadvertantly added onLoad when rendering a link higher than `<head>` or `<body>` in the DOM that is certainly an error. We already warn but this change adds extra explanation given your likely intent | {'url': 'https://api.github.com/repos/facebook/react/issues/25530/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25530/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25529 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25529/labels{/name} | https://api.github.com/repos/facebook/react/issues/25529/comments | https://api.github.com/repos/facebook/react/issues/25529/events | https://github.com/facebook/react/pull/25529 | 1,418,900,747 | PR_kwDOAJy2Ks5BUOeb | 25,529 | [cleanup] remove deletedTreeCleanUpLevel feature flag | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2022-10-21 22:01:04 | 2023-01-20 11:11:13 | 2023-01-17 16:03:29 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25529', 'html_url': 'https://github.com/facebook/react/pull/25529', 'diff_url': 'https://github.com/facebook/react/pull/25529.diff', 'patch_url': 'https://github.com/facebook/react/pull/25529.patch', 'merged_at': datetime.datetime(2023, 1, 17, 16, 3, 29)} | I noticed this was an experiment concluded 16 months ago (#21679) that this extra work is beneficial
to break up cycles leaking memory in product code. | {'url': 'https://api.github.com/repos/facebook/react/issues/25529/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25529/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25528 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25528/labels{/name} | https://api.github.com/repos/facebook/react/issues/25528/comments | https://api.github.com/repos/facebook/react/issues/25528/events | https://github.com/facebook/react/issues/25528 | 1,418,790,128 | I_kwDOAJy2Ks5UkQTw | 25,528 | Bug: | {'login': 'irtaza9', 'id': 98938307, 'node_id': 'U_kgDOBeWtww', 'avatar_url': 'https://avatars.githubusercontent.com/u/98938307?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/irtaza9', 'html_url': 'https://github.com/irtaza9', 'followers_url': 'https://api.github.com/users/irtaza9/followers', 'following_... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"Cold you, please, provide more code (or playground) from this use-case?",
"## Code\r\n\r\n <div className=\"w-full mt-3\">\r\n <div className=\"form-group\">\r\n <input\r\n type=\"text\"\r\n className=\"form-control\"\r\n ... | 2022-10-21 19:51:01 | 2024-04-17 10:03:20 | 2024-04-17 10:03:19 | NONE | null | null | null | ## React Version: ^18.2.0
## Doing
I am setting a parent component state inside useCallback when onChange of an input element take place.
## Warring
## Need Help
I need help regarding this issue a... | {'url': 'https://api.github.com/repos/facebook/react/issues/25528/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25528/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25527 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25527/labels{/name} | https://api.github.com/repos/facebook/react/issues/25527/comments | https://api.github.com/repos/facebook/react/issues/25527/events | https://github.com/facebook/react/pull/25527 | 1,418,723,486 | PR_kwDOAJy2Ks5BToY_ | 25,527 | Disable use in www | {'login': 'poteto', 'id': 1390709, 'node_id': 'MDQ6VXNlcjEzOTA3MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1390709?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/poteto', 'html_url': 'https://github.com/poteto', 'followers_url': 'https://api.github.com/users/poteto/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 79c5829813d07371d0f99a43a47c88e2b444fb1d...f50807ef7566dac43717d7afbf53c8642bea6487\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-21 18:39:52 | 2023-01-15 06:13:40 | 2023-01-15 06:13:37 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25527', 'html_url': 'https://github.com/facebook/react/pull/25527', 'diff_url': 'https://github.com/facebook/react/pull/25527.diff', 'patch_url': 'https://github.com/facebook/react/pull/25527.patch', 'merged_at': None} | Unblock the internal React sync. | {'url': 'https://api.github.com/repos/facebook/react/issues/25527/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25527/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25526 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25526/labels{/name} | https://api.github.com/repos/facebook/react/issues/25526/comments | https://api.github.com/repos/facebook/react/issues/25526/events | https://github.com/facebook/react/pull/25526 | 1,418,720,330 | PR_kwDOAJy2Ks5BTnuB | 25,526 | Disable use in www | {'login': 'poteto', 'id': 1390709, 'node_id': 'MDQ6VXNlcjEzOTA3MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1390709?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/poteto', 'html_url': 'https://github.com/poteto', 'followers_url': 'https://api.github.com/users/poteto/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 79c5829813d07371d0f99a43a47c88e2b444fb1d...f50807ef7566dac43717d7afbf53c8642bea6487\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-21 18:36:38 | 2023-01-15 06:13:43 | 2022-10-21 18:39:29 | MEMBER | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/25526', 'html_url': 'https://github.com/facebook/react/pull/25526', 'diff_url': 'https://github.com/facebook/react/pull/25526.diff', 'patch_url': 'https://github.com/facebook/react/pull/25526.patch', 'merged_at': None} | TODO | {'url': 'https://api.github.com/repos/facebook/react/issues/25526/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25526/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25525 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25525/labels{/name} | https://api.github.com/repos/facebook/react/issues/25525/comments | https://api.github.com/repos/facebook/react/issues/25525/events | https://github.com/facebook/react/issues/25525 | 1,418,589,573 | I_kwDOAJy2Ks5UjfWF | 25,525 | Bug: React 18 Downloading a file on-demand doesn't work | {'login': '72gm', 'id': 12847881, 'node_id': 'MDQ6VXNlcjEyODQ3ODgx', 'avatar_url': 'https://avatars.githubusercontent.com/u/12847881?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/72gm', 'html_url': 'https://github.com/72gm', 'followers_url': 'https://api.github.com/users/72gm/followers', 'following_url'... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This can be resolved by adding a timeout\r\n\r\nsetTimeout(() => {\r\n ref.current?.click();\r\n URL.revokeObjectURL(url);\r\n }, 100);",
"@72gm Why is this timeout required though? Shouldn't it instantly download like in 17?",
"@Anuragkillswitch absolutely, it should work exactly the same i... | 2022-10-21 16:30:45 | 2024-04-17 10:03:21 | 2024-04-17 10:03:20 | NONE | null | null | null | Creating an anchor tag that downloads a file on demand works fine in React 17 but in React 18 it doesn't work
In React 18
The first click gives a valid 200 call to get the file and you can view the file in preview on the network tab (devtools) but nothing downloads in downloads
The second and subsequent click... | {'url': 'https://api.github.com/repos/facebook/react/issues/25525/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25525/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25524 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25524/labels{/name} | https://api.github.com/repos/facebook/react/issues/25524/comments | https://api.github.com/repos/facebook/react/issues/25524/events | https://github.com/facebook/react/pull/25524 | 1,417,039,670 | PR_kwDOAJy2Ks5BN8Si | 25,524 | Unify Default and Sync lane | {'login': 'tyao1', 'id': 5868353, 'node_id': 'MDQ6VXNlcjU4NjgzNTM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5868353?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tyao1', 'html_url': 'https://github.com/tyao1', 'followers_url': 'https://api.github.com/users/tyao1/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: aa9988e5e669122ed0d76c72f2dea159eef872b4...a9537b1249b9656b623a5d5952b2a9d4b38c2eab\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-20 18:00:47 | 2023-11-15 04:02:46 | null | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25524', 'html_url': 'https://github.com/facebook/react/pull/25524', 'diff_url': 'https://github.com/facebook/react/pull/25524.diff', 'patch_url': 'https://github.com/facebook/react/pull/25524.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/25524/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25524/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25523 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25523/labels{/name} | https://api.github.com/repos/facebook/react/issues/25523/comments | https://api.github.com/repos/facebook/react/issues/25523/events | https://github.com/facebook/react/pull/25523 | 1,416,851,849 | PR_kwDOAJy2Ks5BNTWi | 25,523 | Support `use` in `act` testing API | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9cdf8a99edcfd94d7420835ea663edca04237527...65d6fc6fb18baf007344c4c5685489dc0c269d3b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-20 15:38:09 | 2022-11-18 00:36:17 | 2022-10-21 02:08:24 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25523', 'html_url': 'https://github.com/facebook/react/pull/25523', 'diff_url': 'https://github.com/facebook/react/pull/25523.diff', 'patch_url': 'https://github.com/facebook/react/pull/25523.patch', 'merged_at': datetime.datetime(2022, 10, 21, 2, 8, 24)} | `use` can avoid suspending on already resolved data by yielding to microtasks. In a real, browser environment, we do this by scheduling a platform task (i.e. postTask).
In a test environment, tasks are scheduled on a special internal queue so that they can be flushed by the `act` testing API. So we need to add suppo... | {'url': 'https://api.github.com/repos/facebook/react/issues/25523/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25523/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25522 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25522/labels{/name} | https://api.github.com/repos/facebook/react/issues/25522/comments | https://api.github.com/repos/facebook/react/issues/25522/events | https://github.com/facebook/react/issues/25522 | 1,416,517,595 | I_kwDOAJy2Ks5Ublfb | 25,522 | Bug: SVG executes contents of script tags. | {'login': 'nhunzaker', 'id': 590904, 'node_id': 'MDQ6VXNlcjU5MDkwNA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/590904?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nhunzaker', 'html_url': 'https://github.com/nhunzaker', 'followers_url': 'https://api.github.com/users/nhunzaker/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Hi @nhunzaker,\r\n\r\nI noticed the same behavior but it is probably wanted; SVG elements have their own namespace and behavior, separate from HTML elements which probably allows scripts execution. The same behavior is present in other libraries too (https://codesandbox.io/s/exciting-danny-cd7xqu?file=/src/app/app... | 2022-10-20 12:15:38 | 2024-04-17 10:03:23 | 2024-04-17 10:03:21 | CONTRIBUTOR | null | null | null | Script tags within SVG execute their contents when rendered with React. This is surprising, and creates opportunities for XSS attacks when rendering user generated content.
React version: 17.02, 18.2.0
## Steps To Reproduce
1. Create an `<svg>` element with a `<script>` tag in it
2. Render that element
3. Th... | {'url': 'https://api.github.com/repos/facebook/react/issues/25522/reactions', 'total_count': 3, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/25522/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25521 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25521/labels{/name} | https://api.github.com/repos/facebook/react/issues/25521/comments | https://api.github.com/repos/facebook/react/issues/25521/events | https://github.com/facebook/react/issues/25521 | 1,416,234,653 | I_kwDOAJy2Ks5Uagad | 25,521 | Security vulnerability in React! | {'login': 'watson', 'id': 10602, 'node_id': 'MDQ6VXNlcjEwNjAy', 'avatar_url': 'https://avatars.githubusercontent.com/u/10602?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/watson', 'html_url': 'https://github.com/watson', 'followers_url': 'https://api.github.com/users/watson/followers', 'following_url': ... | [] | closed | false | null | [] | null | [
"Can you email me pls? gaearon@fb.com"
] | 2022-10-20 08:57:36 | 2022-10-20 12:17:47 | 2022-10-20 12:17:47 | NONE | null | null | null | I've tried to report a security vulnerability via https://www.facebook.com/whitehat as instructed in the [React security policy](https://github.com/facebook/react/security/policy). The report was unfortunately rejected by Meta without any means of reopening it, because I didn't specify any specific apps that where vuln... | {'url': 'https://api.github.com/repos/facebook/react/issues/25521/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25521/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25520 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25520/labels{/name} | https://api.github.com/repos/facebook/react/issues/25520/comments | https://api.github.com/repos/facebook/react/issues/25520/events | https://github.com/facebook/react/issues/25520 | 1,416,099,168 | I_kwDOAJy2Ks5UZ_Vg | 25,520 | Bug: Github pages not displaying my Vite.js app | {'login': 'claudeMassaad', 'id': 109232112, 'node_id': 'U_kgDOBoK_8A', 'avatar_url': 'https://avatars.githubusercontent.com/u/109232112?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/claudeMassaad', 'html_url': 'https://github.com/claudeMassaad', 'followers_url': 'https://api.github.com/users/claudeMassa... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1168115654, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:\r\n\r\nCoding Questions\r\nIf you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to brow... | 2022-10-20 07:17:50 | 2024-02-11 07:20:41 | 2022-10-21 13:27:07 | NONE | null | null | null | Link to code example: https://github.com/claudeMassaad/TENZIES-GAME-REACT-APP
Here's my main and index.html in Vite app:
![Screen Shot 2022-10-20 at 10 16 45 AM](https:... | {'url': 'https://api.github.com/repos/facebook/react/issues/25520/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25520/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25519 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25519/labels{/name} | https://api.github.com/repos/facebook/react/issues/25519/comments | https://api.github.com/repos/facebook/react/issues/25519/events | https://github.com/facebook/react/issues/25519 | 1,415,895,459 | I_kwDOAJy2Ks5UZNmj | 25,519 | Bug: devtools "select an element in the page to inspect it" does not work for ShadowRoot | {'login': 'Jack-Works', 'id': 5390719, 'node_id': 'MDQ6VXNlcjUzOTA3MTk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5390719?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Jack-Works', 'html_url': 'https://github.com/Jack-Works', 'followers_url': 'https://api.github.com/users/Jack-Works/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Fixed by https://github.com/facebook/react/pull/26888."
] | 2022-10-20 03:50:59 | 2023-06-10 09:19:11 | 2023-06-10 09:19:11 | CONTRIBUTOR | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: unrelated
## Steps To Reproduce
Link to code example: https... | {'url': 'https://api.github.com/repos/facebook/react/issues/25519/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25519/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/25518 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25518/labels{/name} | https://api.github.com/repos/facebook/react/issues/25518/comments | https://api.github.com/repos/facebook/react/issues/25518/events | https://github.com/facebook/react/pull/25518 | 1,415,889,116 | PR_kwDOAJy2Ks5BKByn | 25,518 | feat(devtools): improve "hover to inspect" and shadow root compat | {'login': 'Jack-Works', 'id': 5390719, 'node_id': 'MDQ6VXNlcjUzOTA3MTk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5390719?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Jack-Works', 'html_url': 'https://github.com/Jack-Works', 'followers_url': 'https://api.github.com/users/Jack-Works/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"fixed by #26888"
] | 2022-10-20 03:43:11 | 2023-06-10 09:09:50 | 2023-06-10 08:51:54 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25518', 'html_url': 'https://github.com/facebook/react/pull/25518', 'diff_url': 'https://github.com/facebook/react/pull/25518.diff', 'patch_url': 'https://github.com/facebook/react/pull/25518.patch', 'merged_at': None} | fix #25519
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:... | {'url': 'https://api.github.com/repos/facebook/react/issues/25518/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25518/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/25517 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25517/labels{/name} | https://api.github.com/repos/facebook/react/issues/25517/comments | https://api.github.com/repos/facebook/react/issues/25517/events | https://github.com/facebook/react/issues/25517 | 1,415,805,835 | I_kwDOAJy2Ks5UY3uL | 25,517 | [DevTools Access] Chrome extension request pending for React Developer Tools | {'login': 'paulmambu', 'id': 116237912, 'node_id': 'U_kgDOBu2mWA', 'avatar_url': 'https://avatars.githubusercontent.com/u/116237912?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/paulmambu', 'html_url': 'https://github.com/paulmambu', 'followers_url': 'https://api.github.com/users/paulmambu/followers', '... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"@paulmambu what do you mean by 'who needs to approve it?', can you elaborate on your issue? ",
"Hi yes, exactly. May I know who needs to approve it? Thanks",
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'... | 2022-10-20 01:58:09 | 2024-04-17 10:03:23 | 2024-04-17 10:03:23 | NONE | null | null | null | Hi there, trying to download the chrome extension for the react developer tools. Who needs to approve it? Is it React side? Thanks | {'url': 'https://api.github.com/repos/facebook/react/issues/25517/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25517/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/25516 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/25516/labels{/name} | https://api.github.com/repos/facebook/react/issues/25516/comments | https://api.github.com/repos/facebook/react/issues/25516/events | https://github.com/facebook/react/pull/25516 | 1,415,536,458 | PR_kwDOAJy2Ks5BI2Sy | 25,516 | Add fetch Instrumentation to Dedupe Fetches | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8e2bde6f2751aa6335f3cef488c05c3ea08e074a...c94f72de0fc0598df9d3e6a7c10dcbbc37004fe0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-10-19 20:19:57 | 2023-02-27 05:55:58 | 2022-10-19 22:37:01 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/25516', 'html_url': 'https://github.com/facebook/react/pull/25516', 'diff_url': 'https://github.com/facebook/react/pull/25516.diff', 'patch_url': 'https://github.com/facebook/react/pull/25516.patch', 'merged_at': datetime.datetime(2022, 10, 19, 22, 37, 1)} | Dedupe GET and HEAD fetches while a React Cache is active.
Note that this doesn't say when this should happen nor the lifetime of these cache entries. Currently it's just during render and lives for the lifetime of the current Cache, but that will be expanded, in a limited form, in tasks outside of render. This PR i... | {'url': 'https://api.github.com/repos/facebook/react/issues/25516/reactions', 'total_count': 12, '+1': 0, '-1': 12, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/25516/timeline | null | null | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.