url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/18234 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18234/labels{/name} | https://api.github.com/repos/facebook/react/issues/18234/comments | https://api.github.com/repos/facebook/react/issues/18234/events | https://github.com/facebook/react/pull/18234 | 576,719,751 | MDExOlB1bGxSZXF1ZXN0Mzg0NjUxMjIz | 18,234 | Add test run that uses www feature flags | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18234/builds/13578) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-06 06:09:27 | 2020-03-06 18:05:07 | 2020-03-06 17:29:06 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18234', 'html_url': 'https://github.com/facebook/react/pull/18234', 'diff_url': 'https://github.com/facebook/react/pull/18234.diff', 'patch_url': 'https://github.com/facebook/react/pull/18234.patch', 'merged_at': datetime.datetime(2020, 3, 6, 17, 29, 6)} | In CI, we run our test suite against multiple build configurations. For example, we run our tests in both dev and prod, and in both the experimental and stable release channels. This is to prevent accidental deviations in behavior between the different builds. If there's an intentional deviation in behavior, the test a... | {'url': 'https://api.github.com/repos/facebook/react/issues/18234/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18234/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18233 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18233/labels{/name} | https://api.github.com/repos/facebook/react/issues/18233/comments | https://api.github.com/repos/facebook/react/issues/18233/events | https://github.com/facebook/react/pull/18233 | 576,564,830 | MDExOlB1bGxSZXF1ZXN0Mzg0NTI4NTE5 | 18,233 | [React Native] Add getInspectorDataForViewAtPoint | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 024a764310e64ef38963df16970364b9942a60cd...aa3719acd23e36924f8d9dfac40c8bd555751ee0</p>\n\n\n \n## react-native-renderer\nFil... | 2020-03-05 22:16:54 | 2020-03-24 21:37:04 | 2020-03-11 16:12:41 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18233', 'html_url': 'https://github.com/facebook/react/pull/18233', 'diff_url': 'https://github.com/facebook/react/pull/18233.diff', 'patch_url': 'https://github.com/facebook/react/pull/18233.patch', 'merged_at': datetime.datetime(2020, 3, 11, 16, 12, 41)} | ## Summary
This diff adds `getInspectorDataForViewAtPoint`, accessible through the DevTools hook, which provides an interface to return inspector data about the view touched at a given point. This allows the React Native inspector to ask React for information about a view at an x,y touch point without any knowledge of... | {'url': 'https://api.github.com/repos/facebook/react/issues/18233/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18233/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18232 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18232/labels{/name} | https://api.github.com/repos/facebook/react/issues/18232/comments | https://api.github.com/repos/facebook/react/issues/18232/events | https://github.com/facebook/react/pull/18232 | 576,502,731 | MDExOlB1bGxSZXF1ZXN0Mzg0NDc3MTIy | 18,232 | Fix yarn warning on running 'yarn build-for-devtools' | {'login': 'kerolloz', 'id': 36763164, 'node_id': 'MDQ6VXNlcjM2NzYzMTY0', 'avatar_url': 'https://avatars.githubusercontent.com/u/36763164?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kerolloz', 'html_url': 'https://github.com/kerolloz', 'followers_url': 'https://api.github.com/users/kerolloz/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @kerolloz! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on beh... | 2020-03-05 20:11:22 | 2020-03-10 15:37:04 | 2020-03-10 15:37:03 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18232', 'html_url': 'https://github.com/facebook/react/pull/18232', 'diff_url': 'https://github.com/facebook/react/pull/18232.diff', 'patch_url': 'https://github.com/facebook/react/pull/18232.patch', 'merged_at': datetime.datetime(2020, 3, 10, 15, 37, 3)} | fixes #18231
## Summary
Remove the "--" in `yarn build-for-devtools` script
| {'url': 'https://api.github.com/repos/facebook/react/issues/18232/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18232/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18231 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18231/labels{/name} | https://api.github.com/repos/facebook/react/issues/18231/comments | https://api.github.com/repos/facebook/react/issues/18231/events | https://github.com/facebook/react/issues/18231 | 576,501,637 | MDU6SXNzdWU1NzY1MDE2Mzc= | 18,231 | Warning: Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded | {'login': 'kerolloz', 'id': 36763164, 'node_id': 'MDQ6VXNlcjM2NzYzMTY0', 'avatar_url': 'https://avatars.githubusercontent.com/u/36763164?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kerolloz', 'html_url': 'https://github.com/kerolloz', 'followers_url': 'https://api.github.com/users/kerolloz/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2020-03-05 20:09:13 | 2020-03-10 15:37:03 | 2020-03-10 15:37:03 | CONTRIBUTOR | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwar... | {'url': 'https://api.github.com/repos/facebook/react/issues/18231/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18231/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18230 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18230/labels{/name} | https://api.github.com/repos/facebook/react/issues/18230/comments | https://api.github.com/repos/facebook/react/issues/18230/events | https://github.com/facebook/react/pull/18230 | 576,492,016 | MDExOlB1bGxSZXF1ZXN0Mzg0NDY4MTU4 | 18,230 | Enable enableProfilerCommitHooks flag for FB | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18230/builds/13486) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-05 19:50:52 | 2020-03-10 17:40:49 | 2020-03-10 17:40:46 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18230', 'html_url': 'https://github.com/facebook/react/pull/18230', 'diff_url': 'https://github.com/facebook/react/pull/18230.diff', 'patch_url': 'https://github.com/facebook/react/pull/18230.patch', 'merged_at': datetime.datetime(2020, 3, 10, 17, 40, 46)} | Alternately, I could hook this up to a GK, but it seems like it would be nice if the flag were static. | {'url': 'https://api.github.com/repos/facebook/react/issues/18230/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18230/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18229 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18229/labels{/name} | https://api.github.com/repos/facebook/react/issues/18229/comments | https://api.github.com/repos/facebook/react/issues/18229/events | https://github.com/facebook/react/issues/18229 | 576,484,375 | MDU6SXNzdWU1NzY0ODQzNzU= | 18,229 | [Feature Request] Allow dependency length to change in hooks | {'login': 'georeith', 'id': 3090066, 'node_id': 'MDQ6VXNlcjMwOTAwNjY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3090066?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/georeith', 'html_url': 'https://github.com/georeith', 'followers_url': 'https://api.github.com/users/georeith/followers', '... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/... | open | false | null | [] | null | [
"This is seems like a non-problem: just add an array itself as a single dependency.",
"@vkurchatkin I can't guarantee the referential equality of the array (it is derived itself, a list of ids mapped against a dictionary). The items within it stay referentially the same unless explcitily modified. \r\n\r\nTrying ... | 2020-03-05 19:36:28 | 2022-12-16 03:32:48 | null | NONE | null | null | null | Not allowing dependency lists to change size limits the usefulness of `useMemo` in this particular use case but I imagine there are other similar use cases.
To be clear I am talking about the error triggered here:
https://github.com/facebook/react/blob/024a764310e64ef38963df16970364b9942a60cd/packages/react-recon... | {'url': 'https://api.github.com/repos/facebook/react/issues/18229/reactions', 'total_count': 19, '+1': 19, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18229/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/18228 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18228/labels{/name} | https://api.github.com/repos/facebook/react/issues/18228/comments | https://api.github.com/repos/facebook/react/issues/18228/events | https://github.com/facebook/react/issues/18228 | 576,477,351 | MDU6SXNzdWU1NzY0NzczNTE= | 18,228 | Bug: Incorrect logging level on warnings for unique key | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Isn't it really dangerous to render an array without keys? Shouldn't it be treated as an error rather than a warning?\r\n\r\nIf all that needs to change is the error -> warning for `console` then I'd like to take this on as a PR.",
"In my years of working in this ecosystem it has proved to be entirely benign dur... | 2020-03-05 19:22:57 | 2020-03-07 02:46:17 | 2020-03-05 21:53:54 | NONE | null | null | null | 
React version: `^16.12.0`
## Steps To Reproduce
1. Render an array of elements without a key attribute to instigate the 'warning'
2. Observe an error
## The current behavior
Produces an error l... | {'url': 'https://api.github.com/repos/facebook/react/issues/18228/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18228/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18227 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18227/labels{/name} | https://api.github.com/repos/facebook/react/issues/18227/comments | https://api.github.com/repos/facebook/react/issues/18227/events | https://github.com/facebook/react/issues/18227 | 576,428,462 | MDU6SXNzdWU1NzY0Mjg0NjI= | 18,227 | DevTools: Standalone version should remember last opened tab | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Hi @bvaughn, I'd like to take this ticket",
"This issue is all yours! 😄\r\n\r\nI've added the **\"good first issue (taken)\"** label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for so... | 2020-03-05 17:50:12 | 2020-03-18 18:05:53 | 2020-03-18 18:05:53 | CONTRIBUTOR | null | null | null | Currently the "Components" tab is always opened by default. This should be a sticky preference such that if the "Profiler" tab was opened last, re-opening the [standalone DevTools](https://www.npmjs.com/package/react-devtools) should open "Profiler" by default again.
Note that these shortcut keys should **only** be ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18227/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18227/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18226 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18226/labels{/name} | https://api.github.com/repos/facebook/react/issues/18226/comments | https://api.github.com/repos/facebook/react/issues/18226/events | https://github.com/facebook/react/issues/18226 | 576,427,322 | MDU6SXNzdWU1NzY0MjczMjI= | 18,226 | DevTools: Add shortcut keys for standalone version | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}
{'id': 725156255, 'node_id': 'MDU6TGFiZWw3MjUxNTYyNTU=', 'url': 'https://... | closed | false | {'login': 'kerolloz', 'id': 36763164.0, 'node_id': 'MDQ6VXNlcjM2NzYzMTY0', 'avatar_url': 'https://avatars.githubusercontent.com/u/36763164?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kerolloz', 'html_url': 'https://github.com/kerolloz', 'followers_url': 'https://api.github.com/users/kerolloz/followers... | [{'login': 'kerolloz', 'id': 36763164, 'node_id': 'MDQ6VXNlcjM2NzYzMTY0', 'avatar_url': 'https://avatars.githubusercontent.com/u/36763164?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kerolloz', 'html_url': 'https://github.com/kerolloz', 'followers_url': 'https://api.github.com/users/kerolloz/followers'... | null | [
"Hello @bvaughn, I want to get started with this issue, I am not sure which one is the \"standalone DevTools\".\r\n I think https://github.com/facebook/react/tree/master/packages/react-devtools is what you mean, right? ",
"Yes, that's the one.",
"This issue is all yours! 😄\r\n\r\nI've added the **\"good first ... | 2020-03-05 17:48:11 | 2020-03-18 18:05:42 | 2020-03-18 18:05:42 | CONTRIBUTOR | null | null | null | Suggested keys:
* ⌘1 - Switch to "Components" tab
* ⌘2 - Switch to "Profiler" tab
Note that these shortcut keys should **only** be implemented for the [standalone DevTools](https://www.npmjs.com/package/react-devtools) since (1) the browser already uses these shortcut keys and (2) the "Component" and "Profiler" ta... | {'url': 'https://api.github.com/repos/facebook/react/issues/18226/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18226/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18225 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18225/labels{/name} | https://api.github.com/repos/facebook/react/issues/18225/comments | https://api.github.com/repos/facebook/react/issues/18225/events | https://github.com/facebook/react/issues/18225 | 576,406,620 | MDU6SXNzdWU1NzY0MDY2MjA= | 18,225 | link test build then Can't resolve './cjs/react-dom.development.js' | {'login': 'GoToBoy', 'id': 2384105, 'node_id': 'MDQ6VXNlcjIzODQxMDU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2384105?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/GoToBoy', 'html_url': 'https://github.com/GoToBoy', 'followers_url': 'https://api.github.com/users/GoToBoy/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"<img width=\"1300\" alt=\"image\" src=\"https://user-images.githubusercontent.com/2384105/76006956-3fbf3100-5f48-11ea-8323-1c929eb9d129.png\">\r\nit seems that wrong happen at yarn build step",
"Can you change the path from `/cjs/` to `/umd/` and try again?",
"You need to build `--type=NODE` for npm packages. ... | 2020-03-05 17:11:46 | 2020-03-14 13:34:39 | 2020-03-14 13:34:39 | NONE | null | null | null | React Source Code version: 16.13.0
## Steps To Reproduce
1. clone react souce code
2. yarn build react and react-dom then link them ( [from doc ](https://reactjs.org/docs/how-to-contribute.html)
<img width="980" alt="image" src="https://user-images.githubusercontent.com/2384105/76006565-a4c65700-5f47-11ea-9c4... | {'url': 'https://api.github.com/repos/facebook/react/issues/18225/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18225/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18224 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18224/labels{/name} | https://api.github.com/repos/facebook/react/issues/18224/comments | https://api.github.com/repos/facebook/react/issues/18224/events | https://github.com/facebook/react/pull/18224 | 576,398,261 | MDExOlB1bGxSZXF1ZXN0Mzg0MzkyNTg4 | 18,224 | feat: honor displayName of context types | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18224/builds/13472) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-05 16:59:40 | 2020-03-05 18:15:22 | 2020-03-05 18:13:53 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18224', 'html_url': 'https://github.com/facebook/react/pull/18224', 'diff_url': 'https://github.com/facebook/react/pull/18224.diff', 'patch_url': 'https://github.com/facebook/react/pull/18224.patch', 'merged_at': datetime.datetime(2020, 3, 5, 18, 13, 53)} | ## Summary
New iteration of #18035 which had to be reverted (#18223) since setting `Context.Consumer.displayName` would throw.
Setting `Context.Consumer.displayName` ignores the given value but emits warning. As far as I can tell this doesn't do anything on `master`: https://codesandbox.io/s/priceless-hooks-lm0k... | {'url': 'https://api.github.com/repos/facebook/react/issues/18224/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18224/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18223 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18223/labels{/name} | https://api.github.com/repos/facebook/react/issues/18223/comments | https://api.github.com/repos/facebook/react/issues/18223/events | https://github.com/facebook/react/pull/18223 | 576,351,531 | MDExOlB1bGxSZXF1ZXN0Mzg0MzU0NjI3 | 18,223 | Revert "feat: honor displayName of context types" | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18223/builds/13457) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-05 15:50:27 | 2022-11-29 22:20:55 | 2020-03-05 15:58:05 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18223', 'html_url': 'https://github.com/facebook/react/pull/18223', 'diff_url': 'https://github.com/facebook/react/pull/18223.diff', 'patch_url': 'https://github.com/facebook/react/pull/18223.patch', 'merged_at': datetime.datetime(2020, 3, 5, 15, 58, 5)} | Reverts facebook/react#18035. This breaks an internal FB test where we try and set the `displayName` on the context consumer. Otherwise we get this runtime exception:
`TypeError: Cannot set property displayName of #<Object> which has only a getter` | {'url': 'https://api.github.com/repos/facebook/react/issues/18223/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18223/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18222 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18222/labels{/name} | https://api.github.com/repos/facebook/react/issues/18222/comments | https://api.github.com/repos/facebook/react/issues/18222/events | https://github.com/facebook/react/pull/18222 | 576,346,016 | MDExOlB1bGxSZXF1ZXN0Mzg0MzUwMTA3 | 18,222 | Break up require/import statements in strings | {'login': 'cpojer', 'id': 13352, 'node_id': 'MDQ6VXNlcjEzMzUy', 'avatar_url': 'https://avatars.githubusercontent.com/u/13352?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cpojer', 'html_url': 'https://github.com/cpojer', 'followers_url': 'https://api.github.com/users/cpojer/followers', 'following_url': ... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18222/builds/13510) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-05 15:42:37 | 2020-03-05 22:37:04 | 2020-03-05 22:27:56 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18222', 'html_url': 'https://github.com/facebook/react/pull/18222', 'diff_url': 'https://github.com/facebook/react/pull/18222.diff', 'patch_url': 'https://github.com/facebook/react/pull/18222.patch', 'merged_at': datetime.datetime(2020, 3, 5, 22, 27, 56)} | ## Summary
We have a number of dependency extractors in JavaScript tools, like Jest but also in internal FB tooling, that are using RegExp to extract static dependencies and create a graph. I am trying to reduce the amount of extractors we have at FB and noticed the Jest one has a few issues that are hard to fix wit... | {'url': 'https://api.github.com/repos/facebook/react/issues/18222/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18222/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18221 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18221/labels{/name} | https://api.github.com/repos/facebook/react/issues/18221/comments | https://api.github.com/repos/facebook/react/issues/18221/events | https://github.com/facebook/react/pull/18221 | 576,268,358 | MDExOlB1bGxSZXF1ZXN0Mzg0Mjg3NTY2 | 18,221 | Modern Event System: export internal FB flag for testing | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18221/builds/13440) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-05 13:51:23 | 2020-03-05 14:05:06 | 2020-03-05 14:05:01 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18221', 'html_url': 'https://github.com/facebook/react/pull/18221', 'diff_url': 'https://github.com/facebook/react/pull/18221.diff', 'patch_url': 'https://github.com/facebook/react/pull/18221.patch', 'merged_at': datetime.datetime(2020, 3, 5, 14, 5, 1)} | This re-exports the `enableModernEventSystem` flag so we can test this internally at FB. | {'url': 'https://api.github.com/repos/facebook/react/issues/18221/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18221/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18220 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18220/labels{/name} | https://api.github.com/repos/facebook/react/issues/18220/comments | https://api.github.com/repos/facebook/react/issues/18220/events | https://github.com/facebook/react/pull/18220 | 576,030,391 | MDExOlB1bGxSZXF1ZXN0Mzg0MDk3NzYy | 18,220 | [Blocks] Make it possible to have lazy initialized and lazy loaded Blocks | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18220/builds/13471) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-05 06:48:15 | 2020-03-06 23:14:47 | 2020-03-06 23:14:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18220', 'html_url': 'https://github.com/facebook/react/pull/18220', 'diff_url': 'https://github.com/facebook/react/pull/18220.diff', 'patch_url': 'https://github.com/facebook/react/pull/18220.patch', 'merged_at': datetime.datetime(2020, 3, 6, 23, 14, 47)} | This builds on a similar design as Lazy in https://github.com/facebook/react/pull/18217
The goal here is to make evaluating the query lazy but still allow render functions from different sources to reconcile against each other - even if they're lazy. In my first approach I hid the lazy loading into the "render" func... | {'url': 'https://api.github.com/repos/facebook/react/issues/18220/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18220/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18219 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18219/labels{/name} | https://api.github.com/repos/facebook/react/issues/18219/comments | https://api.github.com/repos/facebook/react/issues/18219/events | https://github.com/facebook/react/issues/18219 | 575,999,061 | MDU6SXNzdWU1NzU5OTkwNjE= | 18,219 | Dev tools feature: I'd like make PR to add toggle ability for boolean prop/state types. | {'login': 'shahzeb1', 'id': 1383831, 'node_id': 'MDQ6VXNlcjEzODM4MzE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1383831?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shahzeb1', 'html_url': 'https://github.com/shahzeb1', 'followers_url': 'https://api.github.com/users/shahzeb1/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"could you set the value to undefined/null (or any other non boolean) if needed? It might not be common, but your change would make it impossible to do so, no? \r\n\r\ncc @bvaughn ",
"You're always welcome to make a PR to propose a UX change, @shahzeb1. I can't promise it will get merged though. The DevTools edit... | 2020-03-05 05:16:54 | 2020-03-05 19:27:47 | 2020-03-05 19:27:47 | NONE | null | null | null | Hello, on the now archived react-devtools repo I had worked on the ability to toggle (via a `checkbox` input) boolean values (from `true` to `false` and viceversa). I was unable to merge my PR because that repo was getting archived.
Do I have permission to add this feature into this repo and make a PR?
It would b... | {'url': 'https://api.github.com/repos/facebook/react/issues/18219/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18219/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18218 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18218/labels{/name} | https://api.github.com/repos/facebook/react/issues/18218/comments | https://api.github.com/repos/facebook/react/issues/18218/events | https://github.com/facebook/react/pull/18218 | 575,982,716 | MDExOlB1bGxSZXF1ZXN0Mzg0MDU5MDE1 | 18,218 | Updated React Native home URL | {'login': 'visshaljagtap', 'id': 35190080, 'node_id': 'MDQ6VXNlcjM1MTkwMDgw', 'avatar_url': 'https://avatars.githubusercontent.com/u/35190080?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/visshaljagtap', 'html_url': 'https://github.com/visshaljagtap', 'followers_url': 'https://api.github.com/users/vissh... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18218/builds/13394) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-05 04:21:46 | 2020-03-05 13:15:47 | 2020-03-05 13:15:47 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18218', 'html_url': 'https://github.com/facebook/react/pull/18218', 'diff_url': 'https://github.com/facebook/react/pull/18218.diff', 'patch_url': 'https://github.com/facebook/react/pull/18218.patch', 'merged_at': datetime.datetime(2020, 3, 5, 13, 15, 47)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18218/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18218/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18217 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18217/labels{/name} | https://api.github.com/repos/facebook/react/issues/18217/comments | https://api.github.com/repos/facebook/react/issues/18217/events | https://github.com/facebook/react/pull/18217 | 575,977,562 | MDExOlB1bGxSZXF1ZXN0Mzg0MDU1MDI4 | 18,217 | Remove _ctor field from Lazy components | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18217/builds/13396) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-05 04:04:01 | 2020-03-05 04:52:49 | 2020-03-05 04:52:49 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18217', 'html_url': 'https://github.com/facebook/react/pull/18217', 'diff_url': 'https://github.com/facebook/react/pull/18217.diff', 'patch_url': 'https://github.com/facebook/react/pull/18217.patch', 'merged_at': datetime.datetime(2020, 3, 5, 4, 52, 49)} | This field is not needed because it's only used before we've initialized, and we don't have anything else to store before we've initialized.
This isn't an important perf optimization by itself but this refactor is motivated by lining it up with the same work on Blocks. | {'url': 'https://api.github.com/repos/facebook/react/issues/18217/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18217/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18216 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18216/labels{/name} | https://api.github.com/repos/facebook/react/issues/18216/comments | https://api.github.com/repos/facebook/react/issues/18216/events | https://github.com/facebook/react/pull/18216 | 575,929,041 | MDExOlB1bGxSZXF1ZXN0Mzg0MDE2Mjk3 | 18,216 | Remove event pooling in the modern system | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18216/builds/13383) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-05 01:22:39 | 2020-05-21 11:04:26 | 2020-05-21 11:04:26 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18216', 'html_url': 'https://github.com/facebook/react/pull/18216', 'diff_url': 'https://github.com/facebook/react/pull/18216.diff', 'patch_url': 'https://github.com/facebook/react/pull/18216.patch', 'merged_at': None} | This is a proposal.
Event pooling saves allocations during high firing events, but adds a bit overhead in "releasing", "destroying" and "reusing" instances. I'm not sure this is actually beneficial. Nobody else is doing it so it's not like this is a common practice. I think maybe we can experiment with dropping it a... | {'url': 'https://api.github.com/repos/facebook/react/issues/18216/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18216/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18215 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18215/labels{/name} | https://api.github.com/repos/facebook/react/issues/18215/comments | https://api.github.com/repos/facebook/react/issues/18215/events | https://github.com/facebook/react/pull/18215 | 575,899,711 | MDExOlB1bGxSZXF1ZXN0MzgzOTkxNDE4 | 18,215 | Modern Event System: Support nested portal/root boundaries - Alternative approach | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18215/builds/13373) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-05 00:06:43 | 2020-03-05 00:48:02 | 2020-03-05 00:48:02 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18215', 'html_url': 'https://github.com/facebook/react/pull/18215', 'diff_url': 'https://github.com/facebook/react/pull/18215.diff', 'patch_url': 'https://github.com/facebook/react/pull/18215.patch', 'merged_at': None} | This is an alternative to https://github.com/facebook/react/pull/18201. Instead of letting the root handle its events and the portal handle its events, this always lets the portal handle any events that targets the portal.
There's a subtle difference in semantics between these approaches. I added a test to show the ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18215/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18215/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18214 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18214/labels{/name} | https://api.github.com/repos/facebook/react/issues/18214/comments | https://api.github.com/repos/facebook/react/issues/18214/events | https://github.com/facebook/react/issues/18214 | 575,746,214 | MDU6SXNzdWU1NzU3NDYyMTQ= | 18,214 | Bug: [eslint-plugin-react-hooks] exhaustive-deps doesn't allow for array hashing | {'login': 'cowboy', 'id': 54051, 'node_id': 'MDQ6VXNlcjU0MDUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/54051?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cowboy', 'html_url': 'https://github.com/cowboy', 'followers_url': 'https://api.github.com/users/cowboy/followers', 'following_url': ... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"> There should be some way to do this?\r\n\r\nThere is: `eslint-disable-next-line`",
"> There is: `eslint-disable-next-line`\r\n\r\nSure, that's what I'm doing right now. I just wanted to see if there was an official opinion on this!",
"Try this Solution:\r\n```\r\nconst getIdsArrayHash = useMemo(()=>ids.join(... | 2020-03-04 20:30:40 | 2020-03-30 15:17:33 | 2020-03-30 15:17:33 | NONE | null | null | null | I'm not sure how to file this. Please let me know if I need to adjust anything. Thanks!
React version: 16.13.0
## Steps To Reproduce
1. Create a `useEffect` hook that accesses an array whose identity might change, even when its contents do not
2. Attempt to provide a hashed value of the array as a dependency
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18214/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18214/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18213 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18213/labels{/name} | https://api.github.com/repos/facebook/react/issues/18213/comments | https://api.github.com/repos/facebook/react/issues/18213/events | https://github.com/facebook/react/pull/18213 | 575,708,753 | MDExOlB1bGxSZXF1ZXN0MzgzODIwODE1 | 18,213 | Fix instanceContainsElem bug | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18213/builds/13313) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-04 19:40:16 | 2020-03-04 19:53:20 | 2020-03-04 19:53:17 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18213', 'html_url': 'https://github.com/facebook/react/pull/18213', 'diff_url': 'https://github.com/facebook/react/pull/18213.diff', 'patch_url': 'https://github.com/facebook/react/pull/18213.patch', 'merged_at': datetime.datetime(2020, 3, 4, 19, 53, 17)} | This was an obvious bug on reflection, and most definitely a typo. The function is designed to find if an element is contained within another element in the fiber tree, except the original function mistakenly used `element` instead of `instance`, so we just early return everytime. | {'url': 'https://api.github.com/repos/facebook/react/issues/18213/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18213/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18212 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18212/labels{/name} | https://api.github.com/repos/facebook/react/issues/18212/comments | https://api.github.com/repos/facebook/react/issues/18212/events | https://github.com/facebook/react/pull/18212 | 575,686,736 | MDExOlB1bGxSZXF1ZXN0MzgzODAxNDI1 | 18,212 | react-devtools: move electron to optionalDependencies | {'login': 'threepointone', 'id': 18808, 'node_id': 'MDQ6VXNlcjE4ODA4', 'avatar_url': 'https://avatars.githubusercontent.com/u/18808?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/threepointone', 'html_url': 'https://github.com/threepointone', 'followers_url': 'https://api.github.com/users/threepointone/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18212/builds/13300) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-04 19:13:26 | 2020-03-04 21:53:46 | 2020-03-04 21:53:45 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18212', 'html_url': 'https://github.com/facebook/react/pull/18212', 'diff_url': 'https://github.com/facebook/react/pull/18212.diff', 'patch_url': 'https://github.com/facebook/react/pull/18212.patch', 'merged_at': None} | When we yarn/ci, we download electron only because it's listed in react-devtools as a dependency. We don't seem to use it for any tests or bundles though, so it's non-essential for the build. Further the electron download point is flaky, leading to ci failures like this https://circleci.com/gh/facebook/react/95743 This... | {'url': 'https://api.github.com/repos/facebook/react/issues/18212/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18212/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18211 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18211/labels{/name} | https://api.github.com/repos/facebook/react/issues/18211/comments | https://api.github.com/repos/facebook/react/issues/18211/events | https://github.com/facebook/react/issues/18211 | 575,549,702 | MDU6SXNzdWU1NzU1NDk3MDI= | 18,211 | Bug: SVG is not rendering after ant version 4 | {'login': 'adorearun', 'id': 16375751, 'node_id': 'MDQ6VXNlcjE2Mzc1NzUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/16375751?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/adorearun', 'html_url': 'https://github.com/adorearun', 'followers_url': 'https://api.github.com/users/adorearun/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'adorearun', 'id': 16375751.0, 'node_id': 'MDQ6VXNlcjE2Mzc1NzUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/16375751?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/adorearun', 'html_url': 'https://github.com/adorearun', 'followers_url': 'https://api.github.com/users/adorearun/follo... | [{'login': 'adorearun', 'id': 16375751, 'node_id': 'MDQ6VXNlcjE2Mzc1NzUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/16375751?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/adorearun', 'html_url': 'https://github.com/adorearun', 'followers_url': 'https://api.github.com/users/adorearun/follow... | null | [
"@adorearun What makes you think this is a React bug?\r\n\r\nFrom the limited amount of info in the description, I would suggest filing it in the Ant repo.",
"Sorry about the confusion , closing it.",
"No worries :)"
] | 2020-03-04 16:20:00 | 2020-03-04 20:57:51 | 2020-03-04 17:53:47 | NONE | null | null | null | I am using ant in my application which has gmaps. I also render markers using custom svg in maps. I am testing latest ant version 4 in my application , as soon as I upgrade to latest version 4 all markers which are supposed to show in my gmaps is not visible. there were no console logs or issues in browser.
React ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18211/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18211/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18210 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18210/labels{/name} | https://api.github.com/repos/facebook/react/issues/18210/comments | https://api.github.com/repos/facebook/react/issues/18210/events | https://github.com/facebook/react/pull/18210 | 575,373,624 | MDExOlB1bGxSZXF1ZXN0MzgzNTMyOTgw | 18,210 | Modern Event System: Add support for internal FB Primer | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18210/builds/13367) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-04 12:47:29 | 2020-03-05 09:00:00 | 2020-03-04 23:42:00 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18210', 'html_url': 'https://github.com/facebook/react/pull/18210', 'diff_url': 'https://github.com/facebook/react/pull/18210.diff', 'patch_url': 'https://github.com/facebook/react/pull/18210.patch', 'merged_at': datetime.datetime(2020, 3, 4, 23, 42)} | This PR exposes a new flag to be used with the modern event system: `enableLegacyFBPrimerSupport`. This flag should be enabled in non-experimental internal bundles only.
When this flag is enabled, we attempt to detect internal FB Primer event heuristics, so we know to defer the internal React dispatching till after ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18210/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18210/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18209 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18209/labels{/name} | https://api.github.com/repos/facebook/react/issues/18209/comments | https://api.github.com/repos/facebook/react/issues/18209/events | https://github.com/facebook/react/issues/18209 | 575,337,279 | MDU6SXNzdWU1NzUzMzcyNzk= | 18,209 | Bug: | {'login': 'fantasticsoul', 'id': 7334950, 'node_id': 'MDQ6VXNlcjczMzQ5NTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7334950?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fantasticsoul', 'html_url': 'https://github.com/fantasticsoul', 'followers_url': 'https://api.github.com/users/fantast... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is expected behaviour for Strict mode in development, it helps to surface any possible bugs https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects",
"so can react supply some api to let developer know is this render called by strict-mode, In a sense, it is like a shadow call, but I sug... | 2020-03-04 11:44:57 | 2020-03-04 14:25:06 | 2020-03-04 12:16:25 | NONE | null | null | null | React version: 16.12.0
## Steps To Reproduce
1. wrap root node with `<React.Strict>`
2. all the component will been initialized 2 times
Link to code example:
[online-demo](https://codesandbox.io/s/test-strict-mode-y14zb)
```js
import React from "react";
export function FnDemo(){
const [state, setter] =... | {'url': 'https://api.github.com/repos/facebook/react/issues/18209/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18209/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18208 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18208/labels{/name} | https://api.github.com/repos/facebook/react/issues/18208/comments | https://api.github.com/repos/facebook/react/issues/18208/events | https://github.com/facebook/react/issues/18208 | 575,311,325 | MDU6SXNzdWU1NzUzMTEzMjU= | 18,208 | Bug: [eslint-plugin-react-hooks] recommended config rules did not work | {'login': 'bobaaaaa', 'id': 733158, 'node_id': 'MDQ6VXNlcjczMzE1OA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/733158?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bobaaaaa', 'html_url': 'https://github.com/bobaaaaa', 'followers_url': 'https://api.github.com/users/bobaaaaa/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}] | closed | true | null | [] | null | [
"The commit that landed that behaviour (https://github.com/facebook/react/pull/14762) hasn't been released yet. We could probably do a release sometime, but the workaround right now is to copy paste the recommended config. I'll leave this open till we do. ",
"I don't want to put anything in `rules`, here is my wo... | 2020-03-04 10:59:24 | 2020-08-21 17:33:22 | 2020-05-01 16:04:13 | NONE | resolved | null | null | Since the latest plugin version (2.5.0) there should be a recommended config for `eslint-plugin-react-hooks`.
See: https://github.com/facebook/react/tree/master/packages/eslint-plugin-react-hooks
PR: #14762
Unfortunately this config did not work. I'am pretty sure the bundled `index.js` did not include the expect... | {'url': 'https://api.github.com/repos/facebook/react/issues/18208/reactions', 'total_count': 5, '+1': 5, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18208/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18207 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18207/labels{/name} | https://api.github.com/repos/facebook/react/issues/18207/comments | https://api.github.com/repos/facebook/react/issues/18207/events | https://github.com/facebook/react/pull/18207 | 575,279,689 | MDExOlB1bGxSZXF1ZXN0MzgzNDU0MDY3 | 18,207 | Updated React Native Website URL | {'login': 'visshaljagtap', 'id': 35190080, 'node_id': 'MDQ6VXNlcjM1MTkwMDgw', 'avatar_url': 'https://avatars.githubusercontent.com/u/35190080?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/visshaljagtap', 'html_url': 'https://github.com/visshaljagtap', 'followers_url': 'https://api.github.com/users/vissh... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 3468faa212ab0e1d1eb6931... | 2020-03-04 10:09:04 | 2020-03-04 12:10:49 | 2020-03-04 12:10:48 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18207', 'html_url': 'https://github.com/facebook/react/pull/18207', 'diff_url': 'https://github.com/facebook/react/pull/18207.diff', 'patch_url': 'https://github.com/facebook/react/pull/18207.patch', 'merged_at': datetime.datetime(2020, 3, 4, 12, 10, 48)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18207/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18207/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18206 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18206/labels{/name} | https://api.github.com/repos/facebook/react/issues/18206/comments | https://api.github.com/repos/facebook/react/issues/18206/events | https://github.com/facebook/react/issues/18206 | 575,086,878 | MDU6SXNzdWU1NzUwODY4Nzg= | 18,206 | Bug: UI was stuck when TextField focus changed | {'login': 'uldh', 'id': 7122457, 'node_id': 'MDQ6VXNlcjcxMjI0NTc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7122457?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/uldh', 'html_url': 'https://github.com/uldh', 'followers_url': 'https://api.github.com/users/uldh/followers', 'following_url': ... | [{'id': 1168115654, 'node_id': 'MDU6TGFiZWwxMTY4MTE1NjU0', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Support%20Redirect', 'name': 'Resolution: Support Redirect', 'color': '106099', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"no matter in native view or web or rn view, all stuck when textfield focus changed, for example when begin edit or end edit",
"If you believe this is a bug in React, please open an issue with the information requested in the issue template.\r\n\r\nIf you have a support question, please check our community suppor... | 2020-03-04 02:14:46 | 2020-04-13 20:15:17 | 2020-04-13 20:15:17 | NONE | null | null | null | ios simulator | {'url': 'https://api.github.com/repos/facebook/react/issues/18206/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18206/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18205 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18205/labels{/name} | https://api.github.com/repos/facebook/react/issues/18205/comments | https://api.github.com/repos/facebook/react/issues/18205/events | https://github.com/facebook/react/issues/18205 | 574,930,675 | MDU6SXNzdWU1NzQ5MzA2NzU= | 18,205 | Bug: backend.js Uncaught TypeError: Cannot read property 'sub' of undefined | {'login': 'steida', 'id': 66249, 'node_id': 'MDQ6VXNlcjY2MjQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/66249?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/steida', 'html_url': 'https://github.com/steida', 'followers_url': 'https://api.github.com/users/steida/followers', 'following_url': ... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"DevTools only injects if the document `contentType` is `text/html` (see #17739). This change also required adding some checks for \"'sub' of undefined\" (see #17848).\r\n\r\nUnfortunately the first change was released in v4.4.0 (January 3, 2020) and the second change has not yet been released. So this is a known i... | 2020-03-03 20:44:52 | 2020-03-03 23:28:52 | 2020-03-03 23:28:52 | NONE | null | null | null | ```
backend.js:32 Uncaught TypeError: Cannot read property 'sub' of undefined
at g (backend.js:32)
at e (backend.js:8)
```
It happens when a server returns a string without HTML. I suppose React dev tools expect DOM.
![Screenshot 2020-03-03 at 21 43 42](https://user-images.githubusercontent.com/66249/... | {'url': 'https://api.github.com/repos/facebook/react/issues/18205/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18205/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18204 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18204/labels{/name} | https://api.github.com/repos/facebook/react/issues/18204/comments | https://api.github.com/repos/facebook/react/issues/18204/events | https://github.com/facebook/react/pull/18204 | 574,872,022 | MDExOlB1bGxSZXF1ZXN0MzgzMTE4MjQ5 | 18,204 | Fix flow types | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18204/builds/13011) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-03 18:55:49 | 2020-03-03 20:46:28 | 2020-03-03 20:46:24 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18204', 'html_url': 'https://github.com/facebook/react/pull/18204', 'diff_url': 'https://github.com/facebook/react/pull/18204.diff', 'patch_url': 'https://github.com/facebook/react/pull/18204.patch', 'merged_at': datetime.datetime(2020, 3, 3, 20, 46, 24)} | While reviewing #17934, I spotted some Flow problems that should have been caught. After investigating, this turned out to be caused by a missing `@flow` pragma in the main `React.js` file which was causing a lot of React APIs to be `any` types for DevTools and the interactions package. | {'url': 'https://api.github.com/repos/facebook/react/issues/18204/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18204/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18203 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18203/labels{/name} | https://api.github.com/repos/facebook/react/issues/18203/comments | https://api.github.com/repos/facebook/react/issues/18203/events | https://github.com/facebook/react/pull/18203 | 574,851,787 | MDExOlB1bGxSZXF1ZXN0MzgzMTAxOTU2 | 18,203 | Use accumulateTwoPhaseDispatchesSingle directly | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18203/builds/13004) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-03 18:16:46 | 2020-03-05 00:38:00 | 2020-03-05 00:04:28 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18203', 'html_url': 'https://github.com/facebook/react/pull/18203', 'diff_url': 'https://github.com/facebook/react/pull/18203.diff', 'patch_url': 'https://github.com/facebook/react/pull/18203.patch', 'merged_at': datetime.datetime(2020, 3, 5, 0, 4, 27)} | I noticed this when working on the modern event system, so thought I'd add the improvement separately.
We only accumulate two phase dispatches on a single event. So passing it to `accumulateTwoPhaseDispatches` is unecessary in a bunch of places and is just overhead and runtime indirection.
Furthermore, with the m... | {'url': 'https://api.github.com/repos/facebook/react/issues/18203/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18203/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18202 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18202/labels{/name} | https://api.github.com/repos/facebook/react/issues/18202/comments | https://api.github.com/repos/facebook/react/issues/18202/events | https://github.com/facebook/react/pull/18202 | 574,799,835 | MDExOlB1bGxSZXF1ZXN0MzgzMDU5NzMw | 18,202 | Disallow unnecessary dependencies in empty useEffect hook | {'login': 'soonoo', 'id': 5436405, 'node_id': 'MDQ6VXNlcjU0MzY0MDU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5436405?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/soonoo', 'html_url': 'https://github.com/soonoo', 'followers_url': 'https://api.github.com/users/soonoo/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18202/builds/12990) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-03 16:45:42 | 2020-03-08 14:57:14 | 2020-03-08 14:57:14 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18202', 'html_url': 'https://github.com/facebook/react/pull/18202', 'diff_url': 'https://github.com/facebook/react/pull/18202.diff', 'patch_url': 'https://github.com/facebook/react/pull/18202.patch', 'merged_at': None} | I admit that there are some valid use cases for over-specifying dependencies in `useEffect`.
Current eslint plugin for hooks however allows over-specifying dependencies even if nothing is done in `useEffect`.
https://github.com/facebook/react/blob/8e6a08ea4f3beb2127ec3d1595cf5f83df5816b6/packages/eslint-plugin-re... | {'url': 'https://api.github.com/repos/facebook/react/issues/18202/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18202/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18201 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18201/labels{/name} | https://api.github.com/repos/facebook/react/issues/18201/comments | https://api.github.com/repos/facebook/react/issues/18201/events | https://github.com/facebook/react/pull/18201 | 574,755,857 | MDExOlB1bGxSZXF1ZXN0MzgzMDIzMTc1 | 18,201 | Modern Event System: Support nested portal/root boundaries | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18201/builds/12970) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-03 15:39:40 | 2020-03-05 09:00:22 | 2020-03-05 09:00:14 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18201', 'html_url': 'https://github.com/facebook/react/pull/18201', 'diff_url': 'https://github.com/facebook/react/pull/18201.diff', 'patch_url': 'https://github.com/facebook/react/pull/18201.patch', 'merged_at': datetime.datetime(2020, 3, 5, 9, 0, 14)} | This PR adds support for multiple nested portal/root boundaries to the modern event system fork. Specifically, where you embed another React root or portal into an existing React sub-tree. Event propagation and the filtering and finding of ancestors is an important role here, and similar to the legacy event system, req... | {'url': 'https://api.github.com/repos/facebook/react/issues/18201/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18201/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18200 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18200/labels{/name} | https://api.github.com/repos/facebook/react/issues/18200/comments | https://api.github.com/repos/facebook/react/issues/18200/events | https://github.com/facebook/react/issues/18200 | 574,695,550 | MDU6SXNzdWU1NzQ2OTU1NTA= | 18,200 | Feature: extend propTypes functionality | {'login': 'adeelibr', 'id': 16651811, 'node_id': 'MDQ6VXNlcjE2NjUxODEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/16651811?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/adeelibr', 'html_url': 'https://github.com/adeelibr', 'followers_url': 'https://api.github.com/users/adeelibr/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"If you think this is valid feature request. I would love to help on this issue, I would need help on guidance though :)",
"Hi, we don't plan to add more features to PropTypes. However, this probably does what you want:\r\n\r\n```js\r\nChild.propTypes = {\r\n a: PropTypes.string,\r\n b: PropTypes.string,\r\n .... | 2020-03-03 14:11:07 | 2020-03-03 14:15:11 | 2020-03-03 14:15:11 | NONE | null | null | null | React version: Latest
## More of a feature request 😄
```
const Parent = ({ x, y }) => <p>{x}{y}</p>;
Parent.propTypes = {
x: PropTypes.string,
y: PropTypes.string,
};
const Child = ({ a, b, x, y }) => {
return (
<div>
<Parent x={x} y={y} />
<p>{a}</p>
<p>{b}</p>
</d... | {'url': 'https://api.github.com/repos/facebook/react/issues/18200/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18200/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18199 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18199/labels{/name} | https://api.github.com/repos/facebook/react/issues/18199/comments | https://api.github.com/repos/facebook/react/issues/18199/events | https://github.com/facebook/react/issues/18199 | 574,364,672 | MDU6SXNzdWU1NzQzNjQ2NzI= | 18,199 | Bug: Certain uses of render props result in remounts on every render | {'login': 'Rinaldo', 'id': 34190720, 'node_id': 'MDQ6VXNlcjM0MTkwNzIw', 'avatar_url': 'https://avatars.githubusercontent.com/u/34190720?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Rinaldo', 'html_url': 'https://github.com/Rinaldo', 'followers_url': 'https://api.github.com/users/Rinaldo/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You were writing `const Component = props => <BaseComp state={state} setState={setState} {...props} />` in the first example and `createFrame` in the second. So in both examples, a new type of component is generated on every render. This a hint that React should unmount the old component and mount the new one inst... | 2020-03-03 01:58:26 | 2022-11-06 10:53:31 | 2020-03-03 17:15:13 | NONE | null | null | null | #### React version: 16.13
Both of the following code snippets produce an input component that loses focus on render:
[Sandbox](https://codesandbox.io/s/floral-cherry-xcnvf)
```js
// render prop is passed a component it can render
const Wizard = ({ components, render }) => {
const [state, setState] = React.use... | {'url': 'https://api.github.com/repos/facebook/react/issues/18199/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18199/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18198 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18198/labels{/name} | https://api.github.com/repos/facebook/react/issues/18198/comments | https://api.github.com/repos/facebook/react/issues/18198/events | https://github.com/facebook/react/issues/18198 | 574,213,936 | MDU6SXNzdWU1NzQyMTM5MzY= | 18,198 | Bug: Child component Ref current is null | {'login': 'dream811', 'id': 45660446, 'node_id': 'MDQ6VXNlcjQ1NjYwNDQ2', 'avatar_url': 'https://avatars.githubusercontent.com/u/45660446?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dream811', 'html_url': 'https://github.com/dream811', 'followers_url': 'https://api.github.com/users/dream811/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I dont think this is an issue per se. It's just a matter of how refs work. You can use a callback to achieve your intended outcome.\r\n\r\n[Here is an example from the docs](https://reactjs.org/docs/hooks-faq.html#how-can-i-measure-a-dom-node)\r\n\r\n```\r\nimport React, { useCallback, useRef } from \"react\";\r\n... | 2020-03-02 20:03:41 | 2020-03-03 15:20:49 | 2020-03-03 15:20:48 | NONE | null | null | null | <!--
I am going to use React.createRef() to call child component's method in parent component.
when I use this for normal tag, it works well.
but doesn't work for custom component.
-->
```
React version:
16.8.6
## Steps To Reproduce
import AUserList from '../AUserList';
class AUsers extends Component {
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18198/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18198/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18197 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18197/labels{/name} | https://api.github.com/repos/facebook/react/issues/18197/comments | https://api.github.com/repos/facebook/react/issues/18197/events | https://github.com/facebook/react/issues/18197 | 574,131,005 | MDU6SXNzdWU1NzQxMzEwMDU= | 18,197 | Bug: Switching type of button causes it to submit the parent form | {'login': 'batzz-00', 'id': 24255122, 'node_id': 'MDQ6VXNlcjI0MjU1MTIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/24255122?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/batzz-00', 'html_url': 'https://github.com/batzz-00', 'followers_url': 'https://api.github.com/users/batzz-00/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I think it's how browser works.\r\nhttps://codesandbox.io/s/gracious-morning-1ikef",
"Yeah it seems so, my bad. Thought it was something to do with Reacts SyntheticEvent wrapper but I guess not! For anyone that gets this issue the easiest (though ugly) way to do this seems to be to simply wrap a settimeout to th... | 2020-03-02 17:30:56 | 2020-03-03 09:12:20 | 2020-03-03 09:11:15 | NONE | null | null | null | Just react on its own, no extra packages. I'm not sure if this is intended behaviour, or if there are any related issues. If it is intended what is the suggested approach to stop it from happening?
React version: 16.12
## Steps To Reproduce
1. Create a simple component with one element in the state type that d... | {'url': 'https://api.github.com/repos/facebook/react/issues/18197/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18197/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18196 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18196/labels{/name} | https://api.github.com/repos/facebook/react/issues/18196/comments | https://api.github.com/repos/facebook/react/issues/18196/events | https://github.com/facebook/react/pull/18196 | 574,087,955 | MDExOlB1bGxSZXF1ZXN0MzgyNDc3NzE1 | 18,196 | Testing builds | {'login': 'threepointone', 'id': 18808, 'node_id': 'MDQ6VXNlcjE4ODA4', 'avatar_url': 'https://avatars.githubusercontent.com/u/18808?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/threepointone', 'html_url': 'https://github.com/threepointone', 'followers_url': 'https://api.github.com/users/threepointone/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18196/builds/13177) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-02 16:22:01 | 2022-10-20 20:41:13 | 2022-10-20 20:41:13 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18196', 'html_url': 'https://github.com/facebook/react/pull/18196', 'diff_url': 'https://github.com/facebook/react/pull/18196.diff', 'patch_url': 'https://github.com/facebook/react/pull/18196.patch', 'merged_at': None} | We removed this in https://github.com/facebook/react/pull/18138 to unblock 16.13. This PR brings them back, with some changes -
- testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing`
- added back to `bundles.js`
- introduces the `__TESTING__` global. Not used to generate the actual builds... | {'url': 'https://api.github.com/repos/facebook/react/issues/18196/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18196/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18195 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18195/labels{/name} | https://api.github.com/repos/facebook/react/issues/18195/comments | https://api.github.com/repos/facebook/react/issues/18195/events | https://github.com/facebook/react/pull/18195 | 573,986,791 | MDExOlB1bGxSZXF1ZXN0MzgyMzk0Mzk2 | 18,195 | Modern Event System: add plugin handling and forked paths | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18195/builds/12967) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-02 13:48:34 | 2020-03-03 14:37:10 | 2020-03-03 14:37:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18195', 'html_url': 'https://github.com/facebook/react/pull/18195', 'diff_url': 'https://github.com/facebook/react/pull/18195.diff', 'patch_url': 'https://github.com/facebook/react/pull/18195.patch', 'merged_at': datetime.datetime(2020, 3, 3, 14, 37, 7)} | This PR adds more of the modern event system logic, enough that based single root/non-portal logic now works and removing the flag should result in most tests passing. Note: this PR does not affect the existing legacy event system, and the only real changes are to the new modern event system (which is behind a flag any... | {'url': 'https://api.github.com/repos/facebook/react/issues/18195/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 2, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18195/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18194 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18194/labels{/name} | https://api.github.com/repos/facebook/react/issues/18194/comments | https://api.github.com/repos/facebook/react/issues/18194/events | https://github.com/facebook/react/pull/18194 | 573,926,739 | MDExOlB1bGxSZXF1ZXN0MzgyMzQ0NDAy | 18,194 | Refine PressLegacy blur logic to account for IE11 issue. | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18194/builds/12792) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-02 12:00:12 | 2020-03-02 13:42:53 | 2020-03-02 13:42:47 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18194', 'html_url': 'https://github.com/facebook/react/pull/18194', 'diff_url': 'https://github.com/facebook/react/pull/18194.diff', 'patch_url': 'https://github.com/facebook/react/pull/18194.patch', 'merged_at': datetime.datetime(2020, 3, 2, 13, 42, 47)} | This PR fixes an issues that was created in https://github.com/facebook/react/pull/18125. Notbaly, the issue was that IE11 fires `blur` events with a `null` `relatedTarget` when you click a focusable node.
Really, we never really needed the `relatedTarget`. Instead we can use the other part of the logic that checks ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18194/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18194/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18193 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18193/labels{/name} | https://api.github.com/repos/facebook/react/issues/18193/comments | https://api.github.com/repos/facebook/react/issues/18193/events | https://github.com/facebook/react/issues/18193 | 573,813,946 | MDU6SXNzdWU1NzM4MTM5NDY= | 18,193 | Bug: ServiceWorker MIME Type Error ('text/html') on register | {'login': 'SeanMoody', 'id': 44378095, 'node_id': 'MDQ6VXNlcjQ0Mzc4MDk1', 'avatar_url': 'https://avatars.githubusercontent.com/u/44378095?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/SeanMoody', 'html_url': 'https://github.com/SeanMoody', 'followers_url': 'https://api.github.com/users/SeanMoody/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Please file this issue at https://github.com/facebook/create-react-app/issues"
] | 2020-03-02 08:53:51 | 2020-03-02 09:19:31 | 2020-03-02 09:19:31 | NONE | null | null | null | Service worker is giving the following error when attempting to register:
Error during service worker registration: DOMException: Failed to register a ServiceWorker for scope ('http://localhost:3000/') with script ('http://localhost:3000/sw.js'): The script has an unsupported MIME type ('text/html').
console.<compute... | {'url': 'https://api.github.com/repos/facebook/react/issues/18193/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18193/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18192 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18192/labels{/name} | https://api.github.com/repos/facebook/react/issues/18192/comments | https://api.github.com/repos/facebook/react/issues/18192/events | https://github.com/facebook/react/issues/18192 | 573,593,125 | MDU6SXNzdWU1NzM1OTMxMjU= | 18,192 | Bug: Cannot read property 'duration' of undefined | {'login': 'ahsanplusplus', 'id': 46662667, 'node_id': 'MDQ6VXNlcjQ2NjYyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/46662667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ahsanplusplus', 'html_url': 'https://github.com/ahsanplusplus', 'followers_url': 'https://api.github.com/users/ahsan... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'ahsanplusplus', 'id': 46662667.0, 'node_id': 'MDQ6VXNlcjQ2NjYyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/46662667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ahsanplusplus', 'html_url': 'https://github.com/ahsanplusplus', 'followers_url': 'https://api.github.com/users/ahs... | [{'login': 'ahsanplusplus', 'id': 46662667, 'node_id': 'MDQ6VXNlcjQ2NjYyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/46662667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ahsanplusplus', 'html_url': 'https://github.com/ahsanplusplus', 'followers_url': 'https://api.github.com/users/ahsa... | null | [
"This is a really sparse issue description :smile: Can you provide some more information on how you're reproducing the error you're seeing?",
"Duplicate of #18044 ",
"Closing due to lack of response from OP and because it also seems to be a duplicate."
] | 2020-03-01 18:34:31 | 2020-03-11 16:03:51 | 2020-03-11 16:03:50 | NONE | null | null | null | This error happens in devtools (when running devtools shell), I didn't investigate it in detail, but seemingly the reason is that inside InteractionListItem.js we are trying to access commitData[commitIndex].duration however in some cases commitData is an array one index smaller than commitIndex. | {'url': 'https://api.github.com/repos/facebook/react/issues/18192/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18192/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18191 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18191/labels{/name} | https://api.github.com/repos/facebook/react/issues/18191/comments | https://api.github.com/repos/facebook/react/issues/18191/events | https://github.com/facebook/react/issues/18191 | 573,548,253 | MDU6SXNzdWU1NzM1NDgyNTM= | 18,191 | Bug: In DevTools useCallback doesn't keep a stable value | {'login': 'ignas-sedunovas', 'id': 3921290, 'node_id': 'MDQ6VXNlcjM5MjEyOTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3921290?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ignas-sedunovas', 'html_url': 'https://github.com/ignas-sedunovas', 'followers_url': 'https://api.github.com/users/i... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This relates to the discussion on #18177 (and #18190).\r\n\r\n### Why does this have anything to do with DevTools?\r\n\r\nDevTools shallowly re-renders components that use hooks in order to build up the map of hook-to-value to show in the selected properties panel. ([Read more about this here if you're interested.... | 2020-03-01 13:36:31 | 2020-03-08 16:14:25 | 2020-03-03 17:35:31 | NONE | null | null | null | React version: 16.13.0
## Steps To Reproduce
1. Create a callback with `useCallback` and empty deps array
2. Create a value with `useMemo` and empty deps array
3. Create a sanity check to throw an error when callback doesn't change together with value
4. Inspect the component in React DevTools
Link to code ex... | {'url': 'https://api.github.com/repos/facebook/react/issues/18191/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18191/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18190 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18190/labels{/name} | https://api.github.com/repos/facebook/react/issues/18190/comments | https://api.github.com/repos/facebook/react/issues/18190/events | https://github.com/facebook/react/issues/18190 | 573,295,014 | MDU6SXNzdWU1NzMyOTUwMTQ= | 18,190 | Bug: Can react supply a api named 'isDevToolSomeDomClicked' or 'getLatestSetter', I really need it. | {'login': 'fantasticsoul', 'id': 7334950, 'node_id': 'MDQ6VXNlcjczMzQ5NTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7334950?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fantasticsoul', 'html_url': 'https://github.com/fantasticsoul', 'followers_url': 'https://api.github.com/users/fantast... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"concent features [demo list](https://codesandbox.io/s/green-tdd-g2mcr)",
"Furthermore, I have try the code below:\r\n```js\r\nimport React, { useState, useEffect } from \"react\";\r\n\r\nconst fnWrapper = {setCount:()=>{}};\r\n\r\nexport default function DemoCounter() {\r\n console.log(\"render DemoCounter \" +... | 2020-02-29 13:26:44 | 2020-03-02 17:30:45 | 2020-02-29 17:48:09 | NONE | null | null | null | React version: 16.12.0
## Description
I need an api or a global variable to know whether the dom node in react-dev-tool panel clicked or not.
## Steps To Reproduce
[see the issue](https://github.com/facebook/react/issues/18177)
I finally resolve this problem in the issue above, but I really need react expose a... | {'url': 'https://api.github.com/repos/facebook/react/issues/18190/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18190/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18189 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18189/labels{/name} | https://api.github.com/repos/facebook/react/issues/18189/comments | https://api.github.com/repos/facebook/react/issues/18189/events | https://github.com/facebook/react/pull/18189 | 573,263,846 | MDExOlB1bGxSZXF1ZXN0MzgxODI3MDkz | 18,189 | Do not warn when a controlled input has `onInput` handler. | {'login': 'utkarshkukreti', 'id': 217126, 'node_id': 'MDQ6VXNlcjIxNzEyNg==', 'avatar_url': 'https://avatars.githubusercontent.com/u/217126?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/utkarshkukreti', 'html_url': 'https://github.com/utkarshkukreti', 'followers_url': 'https://api.github.com/users/utkars... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @utkarshkukreti! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing ... | 2020-02-29 09:47:22 | 2020-04-01 18:58:08 | 2020-04-01 18:58:08 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18189', 'html_url': 'https://github.com/facebook/react/pull/18189', 'diff_url': 'https://github.com/facebook/react/pull/18189.diff', 'patch_url': 'https://github.com/facebook/react/pull/18189.patch', 'merged_at': datetime.datetime(2020, 4, 1, 18, 58, 8)} | ## Summary
`onInput` behaves the same as `onChange` for controlled inputs as far as I know, so React should not print the following warning when `onInput` is present.
> Failed prop type: You provided a `value` prop to a form field without an `onChange` handler. This will render a read-only field. If the field sho... | {'url': 'https://api.github.com/repos/facebook/react/issues/18189/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18189/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18188 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18188/labels{/name} | https://api.github.com/repos/facebook/react/issues/18188/comments | https://api.github.com/repos/facebook/react/issues/18188/events | https://github.com/facebook/react/issues/18188 | 573,136,750 | MDU6SXNzdWU1NzMxMzY3NTA= | 18,188 | Bug: React Developer Tools conflicts with Firefox sass sourcemaps on webpack | {'login': 'alvaro-escalante', 'id': 14359910, 'node_id': 'MDQ6VXNlcjE0MzU5OTEw', 'avatar_url': 'https://avatars.githubusercontent.com/u/14359910?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/alvaro-escalante', 'html_url': 'https://github.com/alvaro-escalante', 'followers_url': 'https://api.github.com/us... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"This seems like a sass loader or webpack. Issue not a React one?",
"It’s not clear from this issue what this has to do with React. By “add-on” do you mean React dev tools? How would the devtools affect your situation? Please describe an exact set of steps, with screenshots, to reproduce this locally. ",
"I mea... | 2020-02-29 03:19:51 | 2020-03-03 18:40:20 | 2020-03-03 13:34:09 | NONE | null | null | null | The React Developer Tools add-on conflicts with Firefox source maps displaying just `inline` for all sass partials, works on Google Chrome. When the add-on is disabled it all works fine again.
React version: 16.13.0
Firefox version: 74
## Steps To Reproduce
1. Use `style-loader`, `css-loader` and `sass-loade... | {'url': 'https://api.github.com/repos/facebook/react/issues/18188/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18188/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18187 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18187/labels{/name} | https://api.github.com/repos/facebook/react/issues/18187/comments | https://api.github.com/repos/facebook/react/issues/18187/events | https://github.com/facebook/react/pull/18187 | 573,101,461 | MDExOlB1bGxSZXF1ZXN0MzgxNjc3ODY4 | 18,187 | Bump react-shallow-renderer to 16.13.1 | {'login': 'NMinhNguyen', 'id': 2852660, 'node_id': 'MDQ6VXNlcjI4NTI2NjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2852660?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/NMinhNguyen', 'html_url': 'https://github.com/NMinhNguyen', 'followers_url': 'https://api.github.com/users/NMinhNguyen/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18187/builds/15115) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-29 01:47:39 | 2020-03-17 00:36:14 | 2020-03-17 00:35:29 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18187', 'html_url': 'https://github.com/facebook/react/pull/18187', 'diff_url': 'https://github.com/facebook/react/pull/18187.diff', 'patch_url': 'https://github.com/facebook/react/pull/18187.patch', 'merged_at': datetime.datetime(2020, 3, 17, 0, 35, 29)} | See https://github.com/webpack/webpack/issues/7973
### Most recent edit
I've now removed the `module` field from `react-shallow-renderer` to avoid ESM/CJS interop issues and published v16.13.1 of the package (see related PR https://github.com/NMinhNguyen/react-shallow-renderer/pull/34).
### Edit
Just came a... | {'url': 'https://api.github.com/repos/facebook/react/issues/18187/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18187/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18186 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18186/labels{/name} | https://api.github.com/repos/facebook/react/issues/18186/comments | https://api.github.com/repos/facebook/react/issues/18186/events | https://github.com/facebook/react/pull/18186 | 573,081,673 | MDExOlB1bGxSZXF1ZXN0MzgxNjYwNTUx | 18,186 | Only use Rollup's CommonJS plugin for "react-art" | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18186/builds/12602) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-29 00:34:29 | 2020-02-29 00:48:30 | 2020-02-29 00:46:17 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18186', 'html_url': 'https://github.com/facebook/react/pull/18186', 'diff_url': 'https://github.com/facebook/react/pull/18186.diff', 'patch_url': 'https://github.com/facebook/react/pull/18186.patch', 'merged_at': datetime.datetime(2020, 2, 29, 0, 46, 17)} | This upgrades the shallow renderer dep, and properly make react-debug-tools and jest-react depend on object-assign as an external dependency instead of compiling it in.
This means that "art" is our only CJS dependency that needs to be compiled with Rollup. So we can now disable the CJS plugin for everything else. Th... | {'url': 'https://api.github.com/repos/facebook/react/issues/18186/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18186/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18185 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18185/labels{/name} | https://api.github.com/repos/facebook/react/issues/18185/comments | https://api.github.com/repos/facebook/react/issues/18185/events | https://github.com/facebook/react/pull/18185 | 573,067,832 | MDExOlB1bGxSZXF1ZXN0MzgxNjQ4ODU3 | 18,185 | Update react-shallow-renderer from 16.12.0 to 16.13.0 | {'login': 'NMinhNguyen', 'id': 2852660, 'node_id': 'MDQ6VXNlcjI4NTI2NjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2852660?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/NMinhNguyen', 'html_url': 'https://github.com/NMinhNguyen', 'followers_url': 'https://api.github.com/users/NMinhNguyen/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18185/builds/12597) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-28 23:44:07 | 2020-02-29 00:46:37 | 2020-02-29 00:35:53 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18185', 'html_url': 'https://github.com/facebook/react/pull/18185', 'diff_url': 'https://github.com/facebook/react/pull/18185.diff', 'patch_url': 'https://github.com/facebook/react/pull/18185.patch', 'merged_at': datetime.datetime(2020, 2, 29, 0, 35, 52)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18185/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18185/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18184 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18184/labels{/name} | https://api.github.com/repos/facebook/react/issues/18184/comments | https://api.github.com/repos/facebook/react/issues/18184/events | https://github.com/facebook/react/pull/18184 | 573,052,243 | MDExOlB1bGxSZXF1ZXN0MzgxNjM1NTc2 | 18,184 | Refine isFiberSuspenseAndTimedOut | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18184/builds/12809) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-28 22:58:35 | 2020-03-02 14:15:47 | 2020-03-02 14:15:43 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18184', 'html_url': 'https://github.com/facebook/react/pull/18184', 'diff_url': 'https://github.com/facebook/react/pull/18184.diff', 'patch_url': 'https://github.com/facebook/react/pull/18184.patch', 'merged_at': datetime.datetime(2020, 3, 2, 14, 15, 43)} | This changes the `isFiberSuspenseAndTimedOut` implementation based on Sebastian's feedback below:
> I think you might need to check for fiber.memoizedState.dehydrated === null here. If dehydrated is non-null it's a not-yet hydrated boundary. I believe child will be null in that case. | {'url': 'https://api.github.com/repos/facebook/react/issues/18184/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18184/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18183 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18183/labels{/name} | https://api.github.com/repos/facebook/react/issues/18183/comments | https://api.github.com/repos/facebook/react/issues/18183/events | https://github.com/facebook/react/issues/18183 | 573,018,935 | MDU6SXNzdWU1NzMwMTg5MzU= | 18,183 | useMutableSource and hydration | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"How would the `registerMutableSourceForHydration` API in #18771 work with libraries that create mutable sources during render (ex. [this](https://codesandbox.io/s/react-redux-usemutablesource-eyxoe) or [this](https://codesandbox.io/s/blissful-babbage-24uu3))?\r\n\r\n(posting here so as not to clutter the PR)",
"... | 2020-02-28 21:38:11 | 2020-05-21 23:00:47 | 2020-05-21 23:00:47 | CONTRIBUTOR | null | null | null | Follow up to PR #18000 and RFC https://github.com/reactjs/rfcs/pull/147
The new `useMutableSource` hook will need at least one additional API to be able to support server rendering and hydration. This API would likely be on the React root (the object returned by `createRoot`) and would enable mutable sources to have... | {'url': 'https://api.github.com/repos/facebook/react/issues/18183/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18183/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18182 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18182/labels{/name} | https://api.github.com/repos/facebook/react/issues/18182/comments | https://api.github.com/repos/facebook/react/issues/18182/events | https://github.com/facebook/react/pull/18182 | 573,010,144 | MDExOlB1bGxSZXF1ZXN0MzgxNTk5NzU3 | 18,182 | [Native] Enable and remove targetAsInstance feature flag. | {'login': 'TheSavior', 'id': 249164, 'node_id': 'MDQ6VXNlcjI0OTE2NA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/249164?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/TheSavior', 'html_url': 'https://github.com/TheSavior', 'followers_url': 'https://api.github.com/users/TheSavior/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18182/builds/12587) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-28 21:18:32 | 2020-02-28 21:45:48 | 2020-02-28 21:45:43 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18182', 'html_url': 'https://github.com/facebook/react/pull/18182', 'diff_url': 'https://github.com/facebook/react/pull/18182.diff', 'patch_url': 'https://github.com/facebook/react/pull/18182.patch', 'merged_at': datetime.datetime(2020, 2, 28, 21, 45, 43)} | ## Summary
This has been enabled by default in React Native at Facebook and additional changes have landed that require this to be enabled. Removing the flag.
## Test Plan
Flag is already enabled at FB and verified. Jest, for the removal changes | {'url': 'https://api.github.com/repos/facebook/react/issues/18182/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18182/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18181 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18181/labels{/name} | https://api.github.com/repos/facebook/react/issues/18181/comments | https://api.github.com/repos/facebook/react/issues/18181/events | https://github.com/facebook/react/pull/18181 | 572,950,664 | MDExOlB1bGxSZXF1ZXN0MzgxNTQ5OTE4 | 18,181 | Change ReactVersion from CJS to ES module | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"`scripts/tasks/version-check.js` requires this file, yes. It's used by `scripts/release/utils.js`, which is used by `scripts/release/ci-update-package-versions` so...presumably this PR will fail?",
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build ... | 2020-02-28 19:13:30 | 2020-02-28 21:09:03 | 2020-02-28 21:09:03 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18181', 'html_url': 'https://github.com/facebook/react/pull/18181', 'diff_url': 'https://github.com/facebook/react/pull/18181.diff', 'patch_url': 'https://github.com/facebook/react/pull/18181.patch', 'merged_at': datetime.datetime(2020, 2, 28, 21, 9, 3)} | We need this to get rid of CJS in the build tool chain. | {'url': 'https://api.github.com/repos/facebook/react/issues/18181/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18181/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18180 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18180/labels{/name} | https://api.github.com/repos/facebook/react/issues/18180/comments | https://api.github.com/repos/facebook/react/issues/18180/events | https://github.com/facebook/react/pull/18180 | 572,910,338 | MDExOlB1bGxSZXF1ZXN0MzgxNTE2NDg4 | 18,180 | Check in a forked version of object-assign only for UMD builds | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18180/builds/12574) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-28 17:50:33 | 2020-02-28 19:14:10 | 2020-02-28 19:14:10 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18180', 'html_url': 'https://github.com/facebook/react/pull/18180', 'diff_url': 'https://github.com/facebook/react/pull/18180.diff', 'patch_url': 'https://github.com/facebook/react/pull/18180.patch', 'merged_at': datetime.datetime(2020, 2, 28, 19, 14, 10)} | This one uses ES modules so that we can inline it into UMD builds.
We could wait for object-assign to make an ESM export but we're going to remove this dependency and assume global polyfills in the next version anyway. However, we'd have to figure out how to keep the copyright header and it'll get counted in terms o... | {'url': 'https://api.github.com/repos/facebook/react/issues/18180/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18180/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18179 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18179/labels{/name} | https://api.github.com/repos/facebook/react/issues/18179/comments | https://api.github.com/repos/facebook/react/issues/18179/events | https://github.com/facebook/react/pull/18179 | 572,898,697 | MDExOlB1bGxSZXF1ZXN0MzgxNTA2NjY0 | 18,179 | More event system cleanup and scaffolding | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18179/builds/12588) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-28 17:29:46 | 2020-03-02 10:59:12 | 2020-03-02 10:59:08 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18179', 'html_url': 'https://github.com/facebook/react/pull/18179', 'diff_url': 'https://github.com/facebook/react/pull/18179.diff', 'patch_url': 'https://github.com/facebook/react/pull/18179.patch', 'merged_at': datetime.datetime(2020, 3, 2, 10, 59, 8)} | This PR is another step towards adding a forked modern event system that uses roots. Before we get to that stage, we need to do some cleanup and add some parts of the scaffolding.
Specifically, this PR does the following:
- fork `ensureListeningTo` to accept modern/legacy events
- wrap `legacyTrapBubbledEvent` ca... | {'url': 'https://api.github.com/repos/facebook/react/issues/18179/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18179/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18178 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18178/labels{/name} | https://api.github.com/repos/facebook/react/issues/18178/comments | https://api.github.com/repos/facebook/react/issues/18178/events | https://github.com/facebook/react/issues/18178 | 572,818,021 | MDU6SXNzdWU1NzI4MTgwMjE= | 18,178 | Bug: too hard to fix "Cannot update a component from inside the function body of a different component." | {'login': 'finom', 'id': 1082083, 'node_id': 'MDQ6VXNlcjEwODIwODM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1082083?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/finom', 'html_url': 'https://github.com/finom', 'followers_url': 'https://api.github.com/users/finom/followers', 'following_ur... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}] | closed | true | null | [] | null | [
"I wish we had added this warning earlier. I'm sorry we didn't. It was an oversight with the introduction of Hooks. I believe this must be caused by newer code that uses Hooks, because there was already the same warning for classes much earlier so any earlier code would've already seen this warning.\r\n\r\nNote tha... | 2020-02-28 15:15:25 | 2020-03-30 23:33:27 | 2020-03-18 00:07:15 | NONE | resolved | null | null | # Note: React 16.13.1 fixed some cases where this was overfiring. If upgrading React and ReactDOM to 16.13.1 doesn't fix the warning, read this: https://github.com/facebook/react/issues/18178#issuecomment-595846312
----
React version:
16.13.0
## Steps To Reproduce
1. Build a time machine.
2. Go to the ye... | {'url': 'https://api.github.com/repos/facebook/react/issues/18178/reactions', 'total_count': 29, '+1': 26, '-1': 0, 'laugh': 3, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18178/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18177 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18177/labels{/name} | https://api.github.com/repos/facebook/react/issues/18177/comments | https://api.github.com/repos/facebook/react/issues/18177/events | https://github.com/facebook/react/issues/18177 | 572,801,992 | MDU6SXNzdWU1NzI4MDE5OTI= | 18,177 | Bug: hook return setter losts its effect when assign it to some obj after click its dom node in react-dev-tool | {'login': 'fantasticsoul', 'id': 7334950, 'node_id': 'MDQ6VXNlcjczMzQ5NTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7334950?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fantasticsoul', 'html_url': 'https://github.com/fantasticsoul', 'followers_url': 'https://api.github.com/users/fantast... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I just assign the latest setter to fnWrapper.setCount in every render period but I don't know why it does's work as I imagine.",
"What you're doing in the hook above - setting properties on an external object `fnWrapper` during render, or mutating a ref like `f` during render - is a **side effect** and [**is not... | 2020-02-28 14:48:20 | 2020-03-02 17:38:34 | 2020-02-28 17:18:58 | NONE | null | null | null | React version: 16.12.0
## description
hook return setter to lost its effect when assign it to some obj after click its dom node in react-dev-tool. [prev closed issue](https://github.com/facebook/react/issues/16519)
## Steps To Reproduce
1. open react-dev-tool
2. click the dom node in the panel
3. input conten... | {'url': 'https://api.github.com/repos/facebook/react/issues/18177/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18177/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18176 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18176/labels{/name} | https://api.github.com/repos/facebook/react/issues/18176/comments | https://api.github.com/repos/facebook/react/issues/18176/events | https://github.com/facebook/react/issues/18176 | 572,677,472 | MDU6SXNzdWU1NzI2Nzc0NzI= | 18,176 | [eslint-plugin-react-hooks] Bug: exhaustive-deps not working with function declaration | {'login': 'yuriy-sng', 'id': 60257988, 'node_id': 'MDQ6VXNlcjYwMjU3OTg4', 'avatar_url': 'https://avatars.githubusercontent.com/u/60257988?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yuriy-sng', 'html_url': 'https://github.com/yuriy-sng', 'followers_url': 'https://api.github.com/users/yuriy-sng/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Never do this. There is no good reason to do this, but it is very hard to make `exhaustive-deps` support this pattern",
"> Never do this. There is no good reason to do this, but it is very hard to make `exhaustive-deps` support this pattern\r\n\r\nThis is good point.\r\nFor effect reusage it would be better to u... | 2020-02-28 10:49:38 | 2020-03-03 17:19:07 | 2020-03-03 17:16:27 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
When extracting a `useEffect` callback from inline to a funcion declaration, the... | {'url': 'https://api.github.com/repos/facebook/react/issues/18176/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18176/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18165 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18165/labels{/name} | https://api.github.com/repos/facebook/react/issues/18165/comments | https://api.github.com/repos/facebook/react/issues/18165/events | https://github.com/facebook/react/pull/18165 | 572,429,753 | MDExOlB1bGxSZXF1ZXN0MzgxMTI4NDU2 | 18,165 | Move remaining things to named exports | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18165/builds/12485) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-27 23:43:01 | 2020-02-28 01:18:56 | 2020-02-28 01:18:56 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18165', 'html_url': 'https://github.com/facebook/react/pull/18165', 'diff_url': 'https://github.com/facebook/react/pull/18165.diff', 'patch_url': 'https://github.com/facebook/react/pull/18165.patch', 'merged_at': datetime.datetime(2020, 2, 28, 1, 18, 56)} | The interesting case here is the noop renderers. The wrappers around the reconciler now changed to use a local export that gets mutated.
ReactNoop and ReactNoopPersistent now have to destructure the object to list out the names it's going to export. We should probably refactor ReactNoop away from createReactNoop. Es... | {'url': 'https://api.github.com/repos/facebook/react/issues/18165/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18165/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18159 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18159/labels{/name} | https://api.github.com/repos/facebook/react/issues/18159/comments | https://api.github.com/repos/facebook/react/issues/18159/events | https://github.com/facebook/react/pull/18159 | 572,325,235 | MDExOlB1bGxSZXF1ZXN0MzgxMDQ1ODMz | 18,159 | [RN] Add an early invariant to debug a mystery crash | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18159/builds/12448) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-27 20:02:50 | 2020-02-28 11:56:37 | 2020-02-28 11:56:37 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18159', 'html_url': 'https://github.com/facebook/react/pull/18159', 'diff_url': 'https://github.com/facebook/react/pull/18159.diff', 'patch_url': 'https://github.com/facebook/react/pull/18159.patch', 'merged_at': datetime.datetime(2020, 2, 28, 11, 56, 37)} | See D20130868 and t62461245. We've only been seeing it on RN in production, and we don't understand how this is possible. Trying to gather more details. I've turned it off in all configs except RN FB. | {'url': 'https://api.github.com/repos/facebook/react/issues/18159/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18159/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18157 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18157/labels{/name} | https://api.github.com/repos/facebook/react/issues/18157/comments | https://api.github.com/repos/facebook/react/issues/18157/events | https://github.com/facebook/react/pull/18157 | 572,313,269 | MDExOlB1bGxSZXF1ZXN0MzgxMDM2NzMy | 18,157 | Remove shallow Node builds | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18157/builds/12444) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-27 19:42:47 | 2020-02-27 22:11:41 | 2020-02-27 22:11:41 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18157', 'html_url': 'https://github.com/facebook/react/pull/18157', 'diff_url': 'https://github.com/facebook/react/pull/18157.diff', 'patch_url': 'https://github.com/facebook/react/pull/18157.patch', 'merged_at': datetime.datetime(2020, 2, 27, 22, 11, 41)} | This is just a forwarding module. We can hardcode it.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18157/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18157/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18156 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18156/labels{/name} | https://api.github.com/repos/facebook/react/issues/18156/comments | https://api.github.com/repos/facebook/react/issues/18156/events | https://github.com/facebook/react/pull/18156 | 572,307,641 | MDExOlB1bGxSZXF1ZXN0MzgxMDMyMzcy | 18,156 | [Fabric] Fix targetAsInstance dispatchEvent "cannot read property of null" | {'login': 'JoshuaGross', 'id': 70602, 'node_id': 'MDQ6VXNlcjcwNjAy', 'avatar_url': 'https://avatars.githubusercontent.com/u/70602?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JoshuaGross', 'html_url': 'https://github.com/JoshuaGross', 'followers_url': 'https://api.github.com/users/JoshuaGross/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18156/builds/12463) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-27 19:33:27 | 2020-02-28 02:00:47 | 2020-02-28 01:23:26 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18156', 'html_url': 'https://github.com/facebook/react/pull/18156', 'diff_url': 'https://github.com/facebook/react/pull/18156.diff', 'patch_url': 'https://github.com/facebook/react/pull/18156.patch', 'merged_at': datetime.datetime(2020, 2, 28, 1, 23, 25)} | ## Summary
In some cases in prod testing, the `targetFiber` here in `dispatchEvent` does not have a stateNode. If we try to get `canonical` directly from stateNode, it will crash. We already check that `targetFiber` is non-null before continuing, I think it makes sense to check stateNode as well.
It's unclear to ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18156/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18156/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18155 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18155/labels{/name} | https://api.github.com/repos/facebook/react/issues/18155/comments | https://api.github.com/repos/facebook/react/issues/18155/events | https://github.com/facebook/react/pull/18155 | 572,301,959 | MDExOlB1bGxSZXF1ZXN0MzgxMDI3OTQ2 | 18,155 | Refactor Portal Fiber parts for event system changes | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18155/builds/12439) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-27 19:24:09 | 2020-02-28 11:20:21 | 2020-02-28 11:20:21 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18155', 'html_url': 'https://github.com/facebook/react/pull/18155', 'diff_url': 'https://github.com/facebook/react/pull/18155.diff', 'patch_url': 'https://github.com/facebook/react/pull/18155.patch', 'merged_at': None} | This PR makes some changes to how we store the root container instance in context, and instead makes it so we store the root fiber instead. I've also added a Flow node for portal containers and also made it so that portal contains also have a `current` field, like root fiber containers do (this is needed for later chan... | {'url': 'https://api.github.com/repos/facebook/react/issues/18155/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18155/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18153 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18153/labels{/name} | https://api.github.com/repos/facebook/react/issues/18153/comments | https://api.github.com/repos/facebook/react/issues/18153/events | https://github.com/facebook/react/pull/18153 | 572,263,302 | MDExOlB1bGxSZXF1ZXN0MzgwOTk3Njc0 | 18,153 | Don't build shallow renderer for FB | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18153/builds/12424) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-27 18:13:02 | 2020-02-27 19:44:26 | 2020-02-27 18:17:59 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18153', 'html_url': 'https://github.com/facebook/react/pull/18153', 'diff_url': 'https://github.com/facebook/react/pull/18153.diff', 'patch_url': 'https://github.com/facebook/react/pull/18153.patch', 'merged_at': datetime.datetime(2020, 2, 27, 18, 17, 59)} | We're now getting it from npm (`react-shallow-renderer`) so we don't need this bundle.
Related diff: D20142456. | {'url': 'https://api.github.com/repos/facebook/react/issues/18153/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18153/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18152 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18152/labels{/name} | https://api.github.com/repos/facebook/react/issues/18152/comments | https://api.github.com/repos/facebook/react/issues/18152/events | https://github.com/facebook/react/pull/18152 | 572,181,302 | MDExOlB1bGxSZXF1ZXN0MzgwOTMyMjk0 | 18,152 | Run test-prod job for experimental builds | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18152/builds/12412) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-27 16:03:01 | 2020-02-27 16:21:42 | 2020-02-27 16:21:37 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18152', 'html_url': 'https://github.com/facebook/react/pull/18152', 'diff_url': 'https://github.com/facebook/react/pull/18152.diff', 'patch_url': 'https://github.com/facebook/react/pull/18152.patch', 'merged_at': datetime.datetime(2020, 2, 27, 16, 21, 37)} | We forgot to run it, so it regressed. This is supposed to fail. Once it fails, I'll push a fix. | {'url': 'https://api.github.com/repos/facebook/react/issues/18152/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18152/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18151 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18151/labels{/name} | https://api.github.com/repos/facebook/react/issues/18151/comments | https://api.github.com/repos/facebook/react/issues/18151/events | https://github.com/facebook/react/issues/18151 | 572,124,046 | MDU6SXNzdWU1NzIxMjQwNDY= | 18,151 | Bug: Latest version breaks? | {'login': 'DavidLozzi', 'id': 3543383, 'node_id': 'MDQ6VXNlcjM1NDMzODM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3543383?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/DavidLozzi', 'html_url': 'https://github.com/DavidLozzi', 'followers_url': 'https://api.github.com/users/DavidLozzi/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You're probably behind a proxy or something like this.",
"bingo, i was :("
] | 2020-02-27 14:26:58 | 2020-02-29 17:08:19 | 2020-02-27 14:33:01 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1. npm install react-test-renderer
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18151/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18151/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18149 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18149/labels{/name} | https://api.github.com/repos/facebook/react/issues/18149/comments | https://api.github.com/repos/facebook/react/issues/18149/events | https://github.com/facebook/react/pull/18149 | 572,084,945 | MDExOlB1bGxSZXF1ZXN0MzgwODUxMDU2 | 18,149 | test(getComponentName): Increase test coverage | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18149/builds/15255) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-27 13:29:48 | 2020-03-17 21:47:53 | 2020-03-17 21:47:25 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18149', 'html_url': 'https://github.com/facebook/react/pull/18149', 'diff_url': 'https://github.com/facebook/react/pull/18149.diff', 'patch_url': 'https://github.com/facebook/react/pull/18149.patch', 'merged_at': datetime.datetime(2020, 3, 17, 21, 47, 25)} | ## Summary
Increases coverage of `getComponentName` to increase likely-hood of #15638 being accepted.
The usages of `getComponentName` that are still uncovered are included in 2979a97af8b12d7842f3824c2ca27cfe0649482b. They either affect react-native (don't know how this is tested), affect messages for possibly i... | {'url': 'https://api.github.com/repos/facebook/react/issues/18149/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 2, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18149/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18148 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18148/labels{/name} | https://api.github.com/repos/facebook/react/issues/18148/comments | https://api.github.com/repos/facebook/react/issues/18148/events | https://github.com/facebook/react/issues/18148 | 571,947,174 | MDU6SXNzdWU1NzE5NDcxNzQ= | 18,148 | Bug: No matching version found for scheduler@^0.19.0 | {'login': 'musashiM82', 'id': 41707194, 'node_id': 'MDQ6VXNlcjQxNzA3MTk0', 'avatar_url': 'https://avatars.githubusercontent.com/u/41707194?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/musashiM82', 'html_url': 'https://github.com/musashiM82', 'followers_url': 'https://api.github.com/users/musashiM82/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The registry is always a bit lagging behind. Babel has the same issue. Give it a few hours and it should work. \r\n\r\n[`scheduler@0.19.0`](https://www.npmjs.com/package/scheduler/v/0.19.0) is actually released.",
"I know... I had same issue with babel in the past. \r\nhow many hours should I wait? I cant force... | 2020-02-27 09:46:22 | 2020-02-27 12:49:46 | 2020-02-27 12:49:45 | NONE | null | null | null | Error "No matching version found for scheduler@^0.19.0" during npm i
React version: 16.8
## The current behavior
<img width="558" alt="Schermata 2020-02-27 alle 10 44 30" src="https://user-images.githubusercontent.com/41707194/75432089-27e71c00-594e-11ea-8998-73366ba262f0.png">
## The expected behavior
inst... | {'url': 'https://api.github.com/repos/facebook/react/issues/18148/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18148/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18147 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18147/labels{/name} | https://api.github.com/repos/facebook/react/issues/18147/comments | https://api.github.com/repos/facebook/react/issues/18147/events | https://github.com/facebook/react/issues/18147 | 571,925,585 | MDU6SXNzdWU1NzE5MjU1ODU= | 18,147 | [React DevTools] Bug: Cannot update a component from inside the function body of a different component. | {'login': 'lxsmnsyc', 'id': 4783372, 'node_id': 'MDQ6VXNlcjQ3ODMzNzI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4783372?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lxsmnsyc', 'html_url': 'https://github.com/lxsmnsyc', 'followers_url': 'https://api.github.com/users/lxsmnsyc/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I have this issue too. @LXSMNSYC what was the solution?\r\n\r\n",
"@samparnell apparently when I encountered this \"problem\", I wasn't aware about the changelogs, and so I read it and at the very beginning of the logs: https://reactjs.org/blog/2020/02/26/react-v16.13.0.html, the warning is indicated there.\r\... | 2020-02-27 09:08:35 | 2020-09-30 17:01:47 | 2020-02-27 12:45:29 | NONE | null | null | null | After updating React to 16.13, I am receiving this error, which is pretty cryptic and only occurs on that update (16.12 works fine)
<img width="639" alt="Screen Shot 2020-02-27 at 5 07 33 PM" src="https://user-images.githubusercontent.com/4783372/75428761-a7431280-5983-11ea-9ad9-f8f6157a485e.png">
Demo can be found... | {'url': 'https://api.github.com/repos/facebook/react/issues/18147/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18147/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18146 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18146/labels{/name} | https://api.github.com/repos/facebook/react/issues/18146/comments | https://api.github.com/repos/facebook/react/issues/18146/events | https://github.com/facebook/react/issues/18146 | 571,914,085 | MDU6SXNzdWU1NzE5MTQwODU= | 18,146 | Bug: React DevTools ignores displayName on React.memo components | {'login': 'lxender', 'id': 20384895, 'node_id': 'MDQ6VXNlcjIwMzg0ODk1', 'avatar_url': 'https://avatars.githubusercontent.com/u/20384895?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lxender', 'html_url': 'https://github.com/lxender', 'followers_url': 'https://api.github.com/users/lxender/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Looks like a duplicate of #18026",
"Oh yea, sorry"
] | 2020-02-27 08:46:47 | 2020-02-27 10:52:07 | 2020-02-27 10:52:07 | NONE | null | null | null | Components wrapped in React.memo don't have a display name in the "components" tab of React DevTools.
React version: 16.13
## Steps To Reproduce
1. create a component that uses React.memo
2. name the component using "displayName"
3. open DevTools
4. the component will not use the name from step 2
```jsx
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18146/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18146/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18145 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18145/labels{/name} | https://api.github.com/repos/facebook/react/issues/18145/comments | https://api.github.com/repos/facebook/react/issues/18145/events | https://github.com/facebook/react/pull/18145 | 571,760,973 | MDExOlB1bGxSZXF1ZXN0MzgwNTg5Mjg1 | 18,145 | Convert the rest of react-dom and react-test-renderer to Named Exports | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18145/builds/12322) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-27 01:25:20 | 2020-02-27 02:07:28 | 2020-02-27 02:04:33 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18145', 'html_url': 'https://github.com/facebook/react/pull/18145', 'diff_url': 'https://github.com/facebook/react/pull/18145.diff', 'patch_url': 'https://github.com/facebook/react/pull/18145.patch', 'merged_at': datetime.datetime(2020, 2, 27, 2, 4, 33)} | Nothing interesting here except that ReactShallowRenderer currently exports a class with a static method instead of an object.
I think the public API is probably just meant to be createRenderer but currently the whole class is exposed. So this means that we have to keep it as default export. We could potentially als... | {'url': 'https://api.github.com/repos/facebook/react/issues/18145/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18145/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18144 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18144/labels{/name} | https://api.github.com/repos/facebook/react/issues/18144/comments | https://api.github.com/repos/facebook/react/issues/18144/events | https://github.com/facebook/react/pull/18144 | 571,748,743 | MDExOlB1bGxSZXF1ZXN0MzgwNTc5Nzcy | 18,144 | Replace ReactShallowRenderer with a dependency | {'login': 'NMinhNguyen', 'id': 2852660, 'node_id': 'MDQ6VXNlcjI4NTI2NjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2852660?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/NMinhNguyen', 'html_url': 'https://github.com/NMinhNguyen', 'followers_url': 'https://api.github.com/users/NMinhNguyen/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18144/builds/12331) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-27 00:46:57 | 2020-02-27 19:47:25 | 2020-02-27 18:10:26 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18144', 'html_url': 'https://github.com/facebook/react/pull/18144', 'diff_url': 'https://github.com/facebook/react/pull/18144.diff', 'patch_url': 'https://github.com/facebook/react/pull/18144.patch', 'merged_at': datetime.datetime(2020, 2, 27, 18, 10, 26)} | Closes #17321.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is d... | {'url': 'https://api.github.com/repos/facebook/react/issues/18144/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18144/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18143 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18143/labels{/name} | https://api.github.com/repos/facebook/react/issues/18143/comments | https://api.github.com/repos/facebook/react/issues/18143/events | https://github.com/facebook/react/pull/18143 | 571,641,815 | MDExOlB1bGxSZXF1ZXN0MzgwNDkxMzg3 | 18,143 | update version numbers for 16.13 | {'login': 'threepointone', 'id': 18808, 'node_id': 'MDQ6VXNlcjE4ODA4', 'avatar_url': 'https://avatars.githubusercontent.com/u/18808?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/threepointone', 'html_url': 'https://github.com/threepointone', 'followers_url': 'https://api.github.com/users/threepointone/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18143/builds/12289) or the icon next to each commit SHA.",
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 ... | 2020-02-26 20:32:43 | 2020-02-27 16:46:46 | 2020-02-26 20:33:29 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18143', 'html_url': 'https://github.com/facebook/react/pull/18143', 'diff_url': 'https://github.com/facebook/react/pull/18143.diff', 'patch_url': 'https://github.com/facebook/react/pull/18143.patch', 'merged_at': datetime.datetime(2020, 2, 26, 20, 33, 29)} | also includes a bugfix when downloading error codes from circleci.
[merging this right now, tagging reviewers just in case]
| {'url': 'https://api.github.com/repos/facebook/react/issues/18143/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18143/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18142 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18142/labels{/name} | https://api.github.com/repos/facebook/react/issues/18142/comments | https://api.github.com/repos/facebook/react/issues/18142/events | https://github.com/facebook/react/issues/18142 | 571,621,778 | MDU6SXNzdWU1NzE2MjE3Nzg= | 18,142 | Bug: ENOTFOUND -3008 on react-scripts start without root permissions | {'login': 'NathanPB', 'id': 18128642, 'node_id': 'MDQ6VXNlcjE4MTI4NjQy', 'avatar_url': 'https://avatars.githubusercontent.com/u/18128642?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/NathanPB', 'html_url': 'https://github.com/NathanPB', 'followers_url': 'https://api.github.com/users/NathanPB/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Please file this in https://github.com/facebook/create-react-app/."
] | 2020-02-26 19:58:31 | 2020-02-26 21:10:36 | 2020-02-26 21:10:35 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
When I try to run ``react-scripts start`` in a react project the command crashes... | {'url': 'https://api.github.com/repos/facebook/react/issues/18142/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18142/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18141 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18141/labels{/name} | https://api.github.com/repos/facebook/react/issues/18141/comments | https://api.github.com/repos/facebook/react/issues/18141/events | https://github.com/facebook/react/issues/18141 | 571,618,853 | MDU6SXNzdWU1NzE2MTg4NTM= | 18,141 | Bug: [Sync mode] Effects are not re-run after suspense completes | {'login': '1000hz', 'id': 1395018, 'node_id': 'MDQ6VXNlcjEzOTUwMTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1395018?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/1000hz', 'html_url': 'https://github.com/1000hz', 'followers_url': 'https://api.github.com/users/1000hz/followers', 'followin... | [{'id': 40929156, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Ng==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Wontfix', 'name': 'Resolution: Wontfix', 'color': 'ffffff', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/re... | closed | false | null | [] | null | [
"cc @lunaruan in case this ties into the hidden stuff any.",
"My understanding is that this is **not possible to fix in the legacy (`ReactDOM.render`) mode**. Sorry. It's a quirk of the legacy mode which we can't fix without introducing other breaking changes. This is **solved in Blocking Mode and Concurrent Mode... | 2020-02-26 19:53:30 | 2022-03-29 22:43:48 | 2020-02-26 21:19:03 | NONE | null | null | null | As reported in #14536, React mounts suspended components to the DOM with `display:none` and fires effects before the components are visible. Once suspense has completed, effects are not re-run. This means that any component that reads layout info from the DOM becomes visible with content based on a stale layout.
Rea... | {'url': 'https://api.github.com/repos/facebook/react/issues/18141/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18141/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18140 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18140/labels{/name} | https://api.github.com/repos/facebook/react/issues/18140/comments | https://api.github.com/repos/facebook/react/issues/18140/events | https://github.com/facebook/react/pull/18140 | 571,610,610 | MDExOlB1bGxSZXF1ZXN0MzgwNDY1OTU1 | 18,140 | Option to use devtools with csp | {'login': 'ruslan-shuster', 'id': 58134692, 'node_id': 'MDQ6VXNlcjU4MTM0Njky', 'avatar_url': 'https://avatars.githubusercontent.com/u/58134692?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ruslan-shuster', 'html_url': 'https://github.com/ruslan-shuster', 'followers_url': 'https://api.github.com/users/ru... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18140/builds/12286) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-26 19:37:42 | 2020-07-25 07:05:47 | 2020-07-25 07:05:47 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18140', 'html_url': 'https://github.com/facebook/react/pull/18140', 'diff_url': 'https://github.com/facebook/react/pull/18140.diff', 'patch_url': 'https://github.com/facebook/react/pull/18140.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18140/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 2, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18140/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18139 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18139/labels{/name} | https://api.github.com/repos/facebook/react/issues/18139/comments | https://api.github.com/repos/facebook/react/issues/18139/events | https://github.com/facebook/react/issues/18139 | 571,585,564 | MDU6SXNzdWU1NzE1ODU1NjQ= | 18,139 | Bug: componentDidMount fires before lazy-loaded components are mounted | {'login': 'logan2z', 'id': 16979104, 'node_id': 'MDQ6VXNlcjE2OTc5MTA0', 'avatar_url': 'https://avatars.githubusercontent.com/u/16979104?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/logan2z', 'html_url': 'https://github.com/logan2z', 'followers_url': 'https://api.github.com/users/logan2z/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Maybe do this instead?\r\nThe callback is executed when the lazy SomeComponent is mounted.\r\n\r\n```jsx\r\nconst SomeComponent = React.lazy(() => import(\"./SomeComponent\"));\r\n\r\nclass Comp extends React.Component {\r\n someComponentMounted(el) {\r\n el.blur();\r\n }\r\n\r\n render() {\r\n return (\r... | 2020-02-26 18:50:31 | 2020-03-16 20:57:34 | 2020-03-16 20:57:34 | NONE | null | null | null | In a component with child components that are lazy loaded using React.lazy, the component's componendDidMount() callback is fired before the lazy-loaded children are loaded/mounted. This makes it very difficult to perform logic on child components (eg. calling a component method via a ref, using ReactDOM.findDOMNode o... | {'url': 'https://api.github.com/repos/facebook/react/issues/18139/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18139/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18138 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18138/labels{/name} | https://api.github.com/repos/facebook/react/issues/18138/comments | https://api.github.com/repos/facebook/react/issues/18138/events | https://github.com/facebook/react/pull/18138 | 571,328,107 | MDExOlB1bGxSZXF1ZXN0MzgwMjI2NjM1 | 18,138 | Remove react-dom OSS testing builds | {'login': 'threepointone', 'id': 18808, 'node_id': 'MDQ6VXNlcjE4ODA4', 'avatar_url': 'https://avatars.githubusercontent.com/u/18808?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/threepointone', 'html_url': 'https://github.com/threepointone', 'followers_url': 'https://api.github.com/users/threepointone/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18138/builds/12237) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-26 12:46:12 | 2020-02-26 13:13:01 | 2020-02-26 13:12:56 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18138', 'html_url': 'https://github.com/facebook/react/pull/18138', 'diff_url': 'https://github.com/facebook/react/pull/18138.diff', 'patch_url': 'https://github.com/facebook/react/pull/18138.patch', 'merged_at': datetime.datetime(2020, 2, 26, 13, 12, 55)} | The testing build versions of react-dom are included in the OSS builds right now, but we're not ready to share them yet. This PR removes them for now (back soon for the next release).
Do your magic, CI.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18138/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18138/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18137 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18137/labels{/name} | https://api.github.com/repos/facebook/react/issues/18137/comments | https://api.github.com/repos/facebook/react/issues/18137/events | https://github.com/facebook/react/pull/18137 | 571,054,515 | MDExOlB1bGxSZXF1ZXN0Mzc5OTk1NzEw | 18,137 | Remove /testing entry point from 'react' package | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18137/builds/12153) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-26 04:03:44 | 2020-02-26 10:48:52 | 2020-02-26 10:48:35 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18137', 'html_url': 'https://github.com/facebook/react/pull/18137', 'diff_url': 'https://github.com/facebook/react/pull/18137.diff', 'patch_url': 'https://github.com/facebook/react/pull/18137.patch', 'merged_at': datetime.datetime(2020, 2, 26, 10, 48, 35)} | We're not actually building this entry point so it doesn't point to anything. I can't think of a reason we'd need to fork the isomorphic one. We don't really fork it for anything since it's so generic to work with all renderers.
Since /profiling doesn't have this, it might confuse the story if we made people alias t... | {'url': 'https://api.github.com/repos/facebook/react/issues/18137/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18137/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18136 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18136/labels{/name} | https://api.github.com/repos/facebook/react/issues/18136/comments | https://api.github.com/repos/facebook/react/issues/18136/events | https://github.com/facebook/react/pull/18136 | 571,038,901 | MDExOlB1bGxSZXF1ZXN0Mzc5OTgzMTU2 | 18,136 | Convert React Native builds to named exports | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18136/builds/12150) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-26 03:11:12 | 2020-02-27 19:33:45 | 2020-02-27 19:33:45 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18136', 'html_url': 'https://github.com/facebook/react/pull/18136', 'diff_url': 'https://github.com/facebook/react/pull/18136.diff', 'patch_url': 'https://github.com/facebook/react/pull/18136.patch', 'merged_at': datetime.datetime(2020, 2, 27, 19, 33, 45)} | These don't need any forks because we always export the same things atm.
They still build to CJS though atm. | {'url': 'https://api.github.com/repos/facebook/react/issues/18136/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18136/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18135 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18135/labels{/name} | https://api.github.com/repos/facebook/react/issues/18135/comments | https://api.github.com/repos/facebook/react/issues/18135/events | https://github.com/facebook/react/pull/18135 | 571,015,298 | MDExOlB1bGxSZXF1ZXN0Mzc5OTYzNTQ5 | 18,135 | Remove unnecessary warnings | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18135/builds/12142) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-26 02:08:10 | 2020-02-27 02:14:31 | 2020-02-27 02:14:31 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18135', 'html_url': 'https://github.com/facebook/react/pull/18135', 'diff_url': 'https://github.com/facebook/react/pull/18135.diff', 'patch_url': 'https://github.com/facebook/react/pull/18135.patch', 'merged_at': datetime.datetime(2020, 2, 27, 2, 14, 31)} | These don't seem particularly useful anymore.
- *Shady* DOM: too niche
- setState in getChildContext: too niche and lets us simplify some spread out code
- maxDuration: gone, never stable | {'url': 'https://api.github.com/repos/facebook/react/issues/18135/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18135/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18134 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18134/labels{/name} | https://api.github.com/repos/facebook/react/issues/18134/comments | https://api.github.com/repos/facebook/react/issues/18134/events | https://github.com/facebook/react/issues/18134 | 570,982,596 | MDU6SXNzdWU1NzA5ODI1OTY= | 18,134 | setState takes type State but it should be Partial<State> | {'login': 'ORESoftware', 'id': 11139560, 'node_id': 'MDQ6VXNlcjExMTM5NTYw', 'avatar_url': 'https://avatars.githubusercontent.com/u/11139560?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ORESoftware', 'html_url': 'https://github.com/ORESoftware', 'followers_url': 'https://api.github.com/users/ORESoftware... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The useState hook isn't like setState in a class it completely replaces the previous value on update. So \"partial\" updates like your example would leave state without hotReloadState"
] | 2020-02-26 01:12:49 | 2020-02-26 01:47:43 | 2020-02-26 01:47:43 | NONE | null | null | null | Not sure where TS typing complaints belong, I have this one:
As far as I know it should be `Partial<State>` not `State` for the type. Here is the type of setState()
``... | {'url': 'https://api.github.com/repos/facebook/react/issues/18134/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18134/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18133 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18133/labels{/name} | https://api.github.com/repos/facebook/react/issues/18133/comments | https://api.github.com/repos/facebook/react/issues/18133/events | https://github.com/facebook/react/pull/18133 | 570,950,013 | MDExOlB1bGxSZXF1ZXN0Mzc5OTA0NjY4 | 18,133 | Add a flag to disable module pattern components | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18133/builds/12134) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-26 00:20:17 | 2020-03-06 18:46:38 | 2020-03-06 18:46:33 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18133', 'html_url': 'https://github.com/facebook/react/pull/18133', 'diff_url': 'https://github.com/facebook/react/pull/18133.diff', 'patch_url': 'https://github.com/facebook/react/pull/18133.patch', 'merged_at': datetime.datetime(2020, 3, 6, 18, 46, 33)} | This was already very niche and the warning doesn't fire on WWW. Let's disable these completely in the modern WWW build and stop doing these three checks for every element returned from a function? | {'url': 'https://api.github.com/repos/facebook/react/issues/18133/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18133/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18132 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18132/labels{/name} | https://api.github.com/repos/facebook/react/issues/18132/comments | https://api.github.com/repos/facebook/react/issues/18132/events | https://github.com/facebook/react/pull/18132 | 570,939,676 | MDExOlB1bGxSZXF1ZXN0Mzc5ODk1MjY2 | 18,132 | Remove unused flag | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18132/builds/12133) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-26 00:04:19 | 2020-02-27 12:58:16 | 2020-02-27 12:58:16 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18132', 'html_url': 'https://github.com/facebook/react/pull/18132', 'diff_url': 'https://github.com/facebook/react/pull/18132.diff', 'patch_url': 'https://github.com/facebook/react/pull/18132.patch', 'merged_at': datetime.datetime(2020, 2, 27, 12, 58, 16)} | This is always true. | {'url': 'https://api.github.com/repos/facebook/react/issues/18132/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18132/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18131 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18131/labels{/name} | https://api.github.com/repos/facebook/react/issues/18131/comments | https://api.github.com/repos/facebook/react/issues/18131/events | https://github.com/facebook/react/issues/18131 | 570,893,387 | MDU6SXNzdWU1NzA4OTMzODc= | 18,131 | EventListeners can not get states after changing | {'login': 'nimahkh', 'id': 12640517, 'node_id': 'MDQ6VXNlcjEyNjQwNTE3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12640517?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nimahkh', 'html_url': 'https://github.com/nimahkh', 'followers_url': 'https://api.github.com/users/nimahkh/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"For who they have same problem: \r\nI just change the document to my current DOM:\r\n\r\n```\r\nfunction listen(e){\r\n e.currentTag.addEventListener(\"keydown\", (e)=>detectDelete(e,states), false);\r\n };\r\n```",
"@nimahkh You have to remove listener each time when you change onKeyDown and add listene... | 2020-02-25 22:52:19 | 2020-02-29 07:20:45 | 2020-02-26 00:07:26 | NONE | null | null | null | Hello guys.
I want to click on some boxes and access to delete them with the "delete" button.
```
React.useEffect(() => {
document.addEventListener("keydown", (e)=>detectDelete(e), false);
}, []);
```
> Now the detectDelete can not find that the states are changed.
**so I change the code to this:*... | {'url': 'https://api.github.com/repos/facebook/react/issues/18131/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18131/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18130 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18130/labels{/name} | https://api.github.com/repos/facebook/react/issues/18130/comments | https://api.github.com/repos/facebook/react/issues/18130/events | https://github.com/facebook/react/pull/18130 | 570,872,477 | MDExOlB1bGxSZXF1ZXN0Mzc5ODM0ODIz | 18,130 | Update ReactDebugHooks to handle composite hooks | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18130/builds/12115) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-25 22:18:34 | 2020-02-26 18:25:07 | 2020-02-26 17:28:35 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18130', 'html_url': 'https://github.com/facebook/react/pull/18130', 'diff_url': 'https://github.com/facebook/react/pull/18130.diff', 'patch_url': 'https://github.com/facebook/react/pull/18130.patch', 'merged_at': datetime.datetime(2020, 2, 26, 17, 28, 35)} | The `useState` hook has always composed the `useReducer` hook. 1:1 composition like this is fine.
But some more recent hooks (e.g. `useTransition`, `useDeferredValue`) compose multiple hooks internally. This breaks `react-debug-tools` because it causes off-by-N errors when the debug tools re-renders the function.
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18130/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18130/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18129 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18129/labels{/name} | https://api.github.com/repos/facebook/react/issues/18129/comments | https://api.github.com/repos/facebook/react/issues/18129/events | https://github.com/facebook/react/pull/18129 | 570,678,406 | MDExOlB1bGxSZXF1ZXN0Mzc5NjczNTQ2 | 18,129 | our addition | {'login': 'Abubakarauta', 'id': 61149266, 'node_id': 'MDQ6VXNlcjYxMTQ5MjY2', 'avatar_url': 'https://avatars.githubusercontent.com/u/61149266?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Abubakarauta', 'html_url': 'https://github.com/Abubakarauta', 'followers_url': 'https://api.github.com/users/Abubakar... | [] | closed | false | null | [] | null | [
"Hi @Abubakarauta! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on... | 2020-02-25 16:06:21 | 2020-02-25 16:57:03 | 2020-02-25 16:57:03 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18129', 'html_url': 'https://github.com/facebook/react/pull/18129', 'diff_url': 'https://github.com/facebook/react/pull/18129.diff', 'patch_url': 'https://github.com/facebook/react/pull/18129.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18129/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18129/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18128 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18128/labels{/name} | https://api.github.com/repos/facebook/react/issues/18128/comments | https://api.github.com/repos/facebook/react/issues/18128/events | https://github.com/facebook/react/issues/18128 | 570,670,095 | MDU6SXNzdWU1NzA2NzAwOTU= | 18,128 | Bug: input won't trigger onChange after a chain of setStates | {'login': 'voliva', 'id': 5365487, 'node_id': 'MDQ6VXNlcjUzNjU0ODc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5365487?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/voliva', 'html_url': 'https://github.com/voliva', 'followers_url': 'https://api.github.com/users/voliva/followers', 'followin... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}] | closed | false | {'login': 'acdlite', 'id': 3624098.0, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'fo... | [{'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'fol... | null | [
"Update: I've bisected this happens just after #15650 merged.\r\n\r\nEdit: I've also tracked this happens because the change event is not generated. By the time ChangeEventPlugin.js runs because of the native `input` event, react has reset the input's value to the one on the state (because now flushing passive effe... | 2020-02-25 15:54:28 | 2021-06-23 21:19:53 | 2021-06-23 21:19:53 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React-dom version: 16.9.0 to 16.12.0 (latest)
This bug was not present in 16.... | {'url': 'https://api.github.com/repos/facebook/react/issues/18128/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18128/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18127 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18127/labels{/name} | https://api.github.com/repos/facebook/react/issues/18127/comments | https://api.github.com/repos/facebook/react/issues/18127/events | https://github.com/facebook/react/pull/18127 | 570,669,316 | MDExOlB1bGxSZXF1ZXN0Mzc5NjY1ODU2 | 18,127 | Remove runtime dependency on prop-types | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18127/builds/12489) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-25 15:53:24 | 2020-03-26 20:52:45 | 2020-02-28 01:21:55 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18127', 'html_url': 'https://github.com/facebook/react/pull/18127', 'diff_url': 'https://github.com/facebook/react/pull/18127.diff', 'patch_url': 'https://github.com/facebook/react/pull/18127.patch', 'merged_at': datetime.datetime(2020, 2, 28, 1, 21, 55)} | This is to unblock the ESM work. There is no good story for using a CJS dependency so let's just inline this back. I lost the last argument because `console.error` now "sees" the stack again. | {'url': 'https://api.github.com/repos/facebook/react/issues/18127/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 1, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18127/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18126 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18126/labels{/name} | https://api.github.com/repos/facebook/react/issues/18126/comments | https://api.github.com/repos/facebook/react/issues/18126/events | https://github.com/facebook/react/pull/18126 | 570,608,338 | MDExOlB1bGxSZXF1ZXN0Mzc5NjE0MDU4 | 18,126 | Add @nolint to FB bundle headers | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18126/builds/12070) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-25 14:27:06 | 2020-02-25 15:24:22 | 2020-02-25 14:45:32 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18126', 'html_url': 'https://github.com/facebook/react/pull/18126', 'diff_url': 'https://github.com/facebook/react/pull/18126.diff', 'patch_url': 'https://github.com/facebook/react/pull/18126.patch', 'merged_at': datetime.datetime(2020, 2, 25, 14, 45, 32)} | Let's add the @nolint header to the FB/RN bundles so that we don't run FB eslint on the bundles internally. | {'url': 'https://api.github.com/repos/facebook/react/issues/18126/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18126/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18125 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18125/labels{/name} | https://api.github.com/repos/facebook/react/issues/18125/comments | https://api.github.com/repos/facebook/react/issues/18125/events | https://github.com/facebook/react/pull/18125 | 570,588,537 | MDExOlB1bGxSZXF1ZXN0Mzc5NTk3NjEz | 18,125 | [react-interactions] Ensure blur to window disengages press | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18125/builds/12066) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-25 13:56:01 | 2020-02-25 16:48:56 | 2020-02-25 14:14:20 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18125', 'html_url': 'https://github.com/facebook/react/pull/18125', 'diff_url': 'https://github.com/facebook/react/pull/18125.diff', 'patch_url': 'https://github.com/facebook/react/pull/18125.patch', 'merged_at': datetime.datetime(2020, 2, 25, 14, 14, 20)} | This PR fixes an issue that was found internally. Specifically, if you engage a press and then a browser dialog opens, we should ensure that the press disengages. Otherwise, without this change the press with remain engaged. Also added a regression test to ensure we keep this behavior in the future. It also handles the... | {'url': 'https://api.github.com/repos/facebook/react/issues/18125/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18125/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18124 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18124/labels{/name} | https://api.github.com/repos/facebook/react/issues/18124/comments | https://api.github.com/repos/facebook/react/issues/18124/events | https://github.com/facebook/react/pull/18124 | 570,583,854 | MDExOlB1bGxSZXF1ZXN0Mzc5NTkzNjU2 | 18,124 | Changelog for 16.13.0 | {'login': 'threepointone', 'id': 18808, 'node_id': 'MDQ6VXNlcjE4ODA4', 'avatar_url': 'https://avatars.githubusercontent.com/u/18808?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/threepointone', 'html_url': 'https://github.com/threepointone', 'followers_url': 'https://api.github.com/users/threepointone/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18124/builds/12287) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-02-25 13:48:15 | 2020-02-26 20:21:15 | 2020-02-26 20:15:02 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18124', 'html_url': 'https://github.com/facebook/react/pull/18124', 'diff_url': 'https://github.com/facebook/react/pull/18124.diff', 'patch_url': 'https://github.com/facebook/react/pull/18124.patch', 'merged_at': datetime.datetime(2020, 2, 26, 20, 15, 1)} | ## 16.13.0 (March 2, 2020)
### React
* Warn when a string ref is used in a manner that's not amenable to a future codemod ([@lunaruan](https://github.com/lunaruan) in [#17864](https://github.com/facebook/react/pull/17864))
* Deprecate `React.createFactory()` ([@trueadm](https://github.com/trueadm) in [#17878](h... | {'url': 'https://api.github.com/repos/facebook/react/issues/18124/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18124/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18123 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18123/labels{/name} | https://api.github.com/repos/facebook/react/issues/18123/comments | https://api.github.com/repos/facebook/react/issues/18123/events | https://github.com/facebook/react/issues/18123 | 570,528,062 | MDU6SXNzdWU1NzA1MjgwNjI= | 18,123 | Discussion: useEffect hook with array dependency that has a default value causes render loop | {'login': 'gregor-mueller', 'id': 28727932, 'node_id': 'MDQ6VXNlcjI4NzI3OTMy', 'avatar_url': 'https://avatars.githubusercontent.com/u/28727932?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gregor-mueller', 'html_url': 'https://github.com/gregor-mueller', 'followers_url': 'https://api.github.com/users/gr... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"The pitfall or gotcha, is going into endless loop with code like these. \r\n\r\n```jsx \r\nfunction MyComponent({ arrayProp = [], title, onEvent }) { \r\n // arrayProp default prop value is a new object on every render\r\n\r\n useEffect(() => {\r\n console.log(\"arrayProp effect\", arrayProp);\r\n onEvent... | 2020-02-25 12:14:38 | 2021-10-19 23:50:48 | 2020-10-12 01:57:16 | NONE | null | null | null | So maybe this is not a bug (because it's default JavaScript behavior) but a pitfall that should be documented in the `useEffect`-section of the hooks documentation. I'm not quite sure because it feels like react should handle this as default value assignment on destructuring functional component props is recommended.
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18123/reactions', 'total_count': 16, '+1': 14, '-1': 1, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18123/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18122 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18122/labels{/name} | https://api.github.com/repos/facebook/react/issues/18122/comments | https://api.github.com/repos/facebook/react/issues/18122/events | https://github.com/facebook/react/issues/18122 | 570,502,799 | MDU6SXNzdWU1NzA1MDI3OTk= | 18,122 | ReactJS POSTrequest does'nt work(404) but GETrequest works | {'login': 'Bhass99', 'id': 39690995, 'node_id': 'MDQ6VXNlcjM5NjkwOTk1', 'avatar_url': 'https://avatars.githubusercontent.com/u/39690995?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Bhass99', 'html_url': 'https://github.com/Bhass99', 'followers_url': 'https://api.github.com/users/Bhass99/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This has no relation to React, which is a UI library. "
] | 2020-02-25 11:28:15 | 2020-02-25 11:32:29 | 2020-02-25 11:32:29 | NONE | null | null | null | I have a very strange problem, when I POST to my PHP file it returns a 404 status code and when I do a GET request it gets me a status code of 200. I have tried my requests with XMLHttpRequest, Fetch, Axios and jquery but all give the same response. What am I doing wrong?
These are my ajax requests
const body = {... | {'url': 'https://api.github.com/repos/facebook/react/issues/18122/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18122/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18121 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18121/labels{/name} | https://api.github.com/repos/facebook/react/issues/18121/comments | https://api.github.com/repos/facebook/react/issues/18121/events | https://github.com/facebook/react/issues/18121 | 570,482,334 | MDU6SXNzdWU1NzA0ODIzMzQ= | 18,121 | Bug: Image not loading in the production build | {'login': 'naveenneog', 'id': 40742835, 'node_id': 'MDQ6VXNlcjQwNzQyODM1', 'avatar_url': 'https://avatars.githubusercontent.com/u/40742835?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/naveenneog', 'html_url': 'https://github.com/naveenneog', 'followers_url': 'https://api.github.com/users/naveenneog/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Can you move this issue to the `create-react-app` rep? -> https://github.com/facebook/create-react-app Thanks!",
"Opening this issue in https://github.com/facebook/create-react-app Thanks! and closing this"
] | 2020-02-25 10:53:02 | 2020-02-25 12:31:38 | 2020-02-25 12:31:38 | NONE | null | null | null | I am using the images by doing the `import IMG from '../path/a.png' way.`
After the` npm run build ` the static/media contains only some images with hashed name others could be embedded in the logo.5d5d9eef.svg . In the production server where this is deployed. I don't see the images rendered which are hashed with dat... | {'url': 'https://api.github.com/repos/facebook/react/issues/18121/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18121/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18120 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18120/labels{/name} | https://api.github.com/repos/facebook/react/issues/18120/comments | https://api.github.com/repos/facebook/react/issues/18120/events | https://github.com/facebook/react/issues/18120 | 570,481,190 | MDU6SXNzdWU1NzA0ODExOTA= | 18,120 | Bug: Some images are generated with format data:image/png;base64,iV......w0K prefixes and not loading in the production build | {'login': 'naveenneog', 'id': 40742835, 'node_id': 'MDQ6VXNlcjQwNzQyODM1', 'avatar_url': 'https://avatars.githubusercontent.com/u/40742835?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/naveenneog', 'html_url': 'https://github.com/naveenneog', 'followers_url': 'https://api.github.com/users/naveenneog/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2020-02-25 10:51:06 | 2020-02-25 10:53:45 | 2020-02-25 10:53:45 | NONE | null | null | null | <!--
My React version in Package.json `"version": "0.1.0",`
I am using the images by doing the `import IMG from '../path/a.png' way.`
After the` npm run build ` the static/media contains only some images with hashed name others could be embedded in the logo.5d5d9eef.svg . In the production server where this is depl... | {'url': 'https://api.github.com/repos/facebook/react/issues/18120/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18120/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18119 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18119/labels{/name} | https://api.github.com/repos/facebook/react/issues/18119/comments | https://api.github.com/repos/facebook/react/issues/18119/events | https://github.com/facebook/react/pull/18119 | 570,324,436 | MDExOlB1bGxSZXF1ZXN0Mzc5Mzc2Mjc0 | 18,119 | Fixed a spelling mistake in a comment. | {'login': 'steveharrison', 'id': 1661692, 'node_id': 'MDQ6VXNlcjE2NjE2OTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1661692?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/steveharrison', 'html_url': 'https://github.com/steveharrison', 'followers_url': 'https://api.github.com/users/steveha... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @steveharrison! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing o... | 2020-02-25 05:36:15 | 2020-02-26 05:48:07 | 2020-02-26 05:01:09 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18119', 'html_url': 'https://github.com/facebook/react/pull/18119', 'diff_url': 'https://github.com/facebook/react/pull/18119.diff', 'patch_url': 'https://github.com/facebook/react/pull/18119.patch', 'merged_at': datetime.datetime(2020, 2, 26, 5, 1, 9)} | I'm beginning my journey to becoming a major React contributor! 😛 | {'url': 'https://api.github.com/repos/facebook/react/issues/18119/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18119/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18118 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18118/labels{/name} | https://api.github.com/repos/facebook/react/issues/18118/comments | https://api.github.com/repos/facebook/react/issues/18118/events | https://github.com/facebook/react/issues/18118 | 570,179,299 | MDU6SXNzdWU1NzAxNzkyOTk= | 18,118 | Hooks - should use a special character in front of them. i.e. @myHook | {'login': 'zanecurrie', 'id': 37783074, 'node_id': 'MDQ6VXNlcjM3NzgzMDc0', 'avatar_url': 'https://avatars.githubusercontent.com/u/37783074?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zanecurrie', 'html_url': 'https://github.com/zanecurrie', 'followers_url': 'https://api.github.com/users/zanecurrie/fol... | [] | closed | false | null | [] | null | [
"Thank you for sharing the suggestion!\r\n\r\nThe naming convention for hooks is pretty established at this point though. Changing it would add a lot of churn to the entire ecosystem.\r\n\r\n😄 Thanks again and I'm going to close this for now."
] | 2020-02-24 22:12:10 | 2020-02-25 02:30:41 | 2020-02-25 02:30:41 | NONE | null | null | null | 👉 Please follow one of these issue templates:
- https://github.com/facebook/react/issues/new/choose
Note: to keep the backlog clean and actionable, issues may be immediately closed if they do not follow one of the above issue templates.
With regards to hooks naming conventions...
They could use a special chara... | {'url': 'https://api.github.com/repos/facebook/react/issues/18118/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18118/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18117 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18117/labels{/name} | https://api.github.com/repos/facebook/react/issues/18117/comments | https://api.github.com/repos/facebook/react/issues/18117/events | https://github.com/facebook/react/issues/18117 | 570,149,126 | MDU6SXNzdWU1NzAxNDkxMjY= | 18,117 | Bug: component re-rendered in concurrent mode when useState initialiser uses console.log | {'login': 'joefreeman', 'id': 535128, 'node_id': 'MDQ6VXNlcjUzNTEyOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/535128?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/joefreeman', 'html_url': 'https://github.com/joefreeman', 'followers_url': 'https://api.github.com/users/joefreeman/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"> This outputs: \"1\". With the console.log uncommented, this outputs: \"1 2 1 2\" (i.e., App is re-rendered, and the useState initialiser is run twice).\r\n\r\nThis isn't quite right. :smile: If you comment out the `console.log(\"2\")` line, you'll still see \"1\" logged twice.\r\n\r\nThat's because this demo app... | 2020-02-24 21:11:59 | 2020-02-25 16:52:24 | 2020-02-25 02:33:44 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
```json
"react": "^0.0.0-experimental-5de5b6150",
"react-dom":... | {'url': 'https://api.github.com/repos/facebook/react/issues/18117/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18117/timeline | null | completed | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.