url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/28707 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28707/labels{/name} | https://api.github.com/repos/facebook/react/issues/28707/comments | https://api.github.com/repos/facebook/react/issues/28707/events | https://github.com/facebook/react/pull/28707 | 2,218,938,552 | PR_kwDOAJy2Ks5rWngY | 28,707 | Bump nvmrc to Node.js v18 | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"I think this might fix the build issues from #28704.",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6e650109999e5f483fcb910ff20fe8148a566cb2...8138d816849b489e5e7ac9efe68bbf489579cb27\n\n## Critical size changes\n\nIncludes critical produ... | 2024-04-01 19:42:34 | 2024-04-02 14:04:19 | 2024-04-02 14:04:19 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28707', 'html_url': 'https://github.com/facebook/react/pull/28707', 'diff_url': 'https://github.com/facebook/react/pull/28707.diff', 'patch_url': 'https://github.com/facebook/react/pull/28707.patch', 'merged_at': datetime.datetime(2024, 4, 2, 14, 4, 19)} | Bump nvmrc to Node.js v18
Node.js v16 is long deprecated, seems like for v20 there's some more stuff to fix.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/28707).
* #28704
* __->__ #28707 | {'url': 'https://api.github.com/repos/facebook/react/issues/28707/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28707/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28706 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28706/labels{/name} | https://api.github.com/repos/facebook/react/issues/28706/comments | https://api.github.com/repos/facebook/react/issues/28706/events | https://github.com/facebook/react/pull/28706 | 2,218,923,773 | PR_kwDOAJy2Ks5rWkPz | 28,706 | [be] Remove unused, experimental getCacheSignal API | {'login': 'josephsavona', 'id': 6425824, 'node_id': 'MDQ6VXNlcjY0MjU4MjQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6425824?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/josephsavona', 'html_url': 'https://github.com/josephsavona', 'followers_url': 'https://api.github.com/users/josephsavo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 48ec17b865f439754fcdaa289ef0aa98f15a05c2...084402b71d227ce5fc3bf05ab579c2e653489217\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-04-01 19:33:35 | 2024-04-02 17:54:31 | 2024-04-02 17:54:31 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28706', 'html_url': 'https://github.com/facebook/react/pull/28706', 'diff_url': 'https://github.com/facebook/react/pull/28706.diff', 'patch_url': 'https://github.com/facebook/react/pull/28706.patch', 'merged_at': datetime.datetime(2024, 4, 2, 17, 54, 31)} | Similar to #28698, this removes the `unstable_getCacheSignal()` API since we don't intend to ship this to stable. | {'url': 'https://api.github.com/repos/facebook/react/issues/28706/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28706/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28705 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28705/labels{/name} | https://api.github.com/repos/facebook/react/issues/28705/comments | https://api.github.com/repos/facebook/react/issues/28705/events | https://github.com/facebook/react/pull/28705 | 2,218,888,321 | PR_kwDOAJy2Ks5rWcZK | 28,705 | Update RTR readme | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8833338c8f929281cd1f2d39e11dd2b5e0739f10...cdb9123874ba654656bf600c1ae857fc63127f58\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-04-01 19:12:52 | 2024-04-02 15:41:34 | 2024-04-02 15:41:31 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28705', 'html_url': 'https://github.com/facebook/react/pull/28705', 'diff_url': 'https://github.com/facebook/react/pull/28705.diff', 'patch_url': 'https://github.com/facebook/react/pull/28705.patch', 'merged_at': datetime.datetime(2024, 4, 2, 15, 41, 31)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/28705/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28705/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28704 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28704/labels{/name} | https://api.github.com/repos/facebook/react/issues/28704/comments | https://api.github.com/repos/facebook/react/issues/28704/events | https://github.com/facebook/react/pull/28704 | 2,218,836,695 | PR_kwDOAJy2Ks5rWRGd | 28,704 | Upgrade to Rollup 4 | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Looks like there are some issues with the node version used in CI",
"Okay, I guess more CI stuff needs to be upgraded first. Skipping this"
] | 2024-04-01 18:38:45 | 2024-04-02 00:44:41 | 2024-04-02 00:44:41 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28704', 'html_url': 'https://github.com/facebook/react/pull/28704', 'diff_url': 'https://github.com/facebook/react/pull/28704.diff', 'patch_url': 'https://github.com/facebook/react/pull/28704.patch', 'merged_at': None} | Was looking at the rollup script and while nothing else came out of those attempts, this at least upgrades to the latest version of Rollup.
Diffed the built output and the only difference I noticed was that some more comments are preserved now in dev builds.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with... | {'url': 'https://api.github.com/repos/facebook/react/issues/28704/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28704/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28703 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28703/labels{/name} | https://api.github.com/repos/facebook/react/issues/28703/comments | https://api.github.com/repos/facebook/react/issues/28703/events | https://github.com/facebook/react/pull/28703 | 2,218,832,502 | PR_kwDOAJy2Ks5rWQLP | 28,703 | Remove dynamic www flag for disableInputAttributeSyncing | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8833338c8f929281cd1f2d39e11dd2b5e0739f10...57b65018ae7dfd79a8f125feb446f2bdef0d9448\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-04-01 18:35:45 | 2024-04-02 14:57:23 | 2024-04-02 14:57:23 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28703', 'html_url': 'https://github.com/facebook/react/pull/28703', 'diff_url': 'https://github.com/facebook/react/pull/28703.diff', 'patch_url': 'https://github.com/facebook/react/pull/28703.patch', 'merged_at': datetime.datetime(2024, 4, 2, 14, 57, 23)} | Remove dynamic www flag for disableInputAttributeSyncing
| {'url': 'https://api.github.com/repos/facebook/react/issues/28703/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28703/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28702 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28702/labels{/name} | https://api.github.com/repos/facebook/react/issues/28702/comments | https://api.github.com/repos/facebook/react/issues/28702/events | https://github.com/facebook/react/pull/28702 | 2,218,832,460 | PR_kwDOAJy2Ks5rWQKn | 28,702 | Remove flag codemod | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5ab97b73457e2da72749322a1925a970a967f3bc...db9cf82138fd132848f7f766c25bb8d1b3304860\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-04-01 18:35:43 | 2024-04-01 18:40:35 | 2024-04-01 18:35:55 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28702', 'html_url': 'https://github.com/facebook/react/pull/28702', 'diff_url': 'https://github.com/facebook/react/pull/28702.diff', 'patch_url': 'https://github.com/facebook/react/pull/28702.patch', 'merged_at': None} | Remove flag codemod
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/28702).
* #28703
* __->__ #28702 | {'url': 'https://api.github.com/repos/facebook/react/issues/28702/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28702/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28701 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28701/labels{/name} | https://api.github.com/repos/facebook/react/issues/28701/comments | https://api.github.com/repos/facebook/react/issues/28701/events | https://github.com/facebook/react/pull/28701 | 2,218,744,471 | PR_kwDOAJy2Ks5rV8lp | 28,701 | Hardcode enableLegacyFBSupport flag | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: e3afd026c8d922b008c2759eec48297d518e7634...38cac23c2a621e95a00b17dc18884169f06c9e9d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-04-01 17:46:22 | 2024-04-02 15:35:22 | 2024-04-02 15:35:19 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28701', 'html_url': 'https://github.com/facebook/react/pull/28701', 'diff_url': 'https://github.com/facebook/react/pull/28701.diff', 'patch_url': 'https://github.com/facebook/react/pull/28701.patch', 'merged_at': datetime.datetime(2024, 4, 2, 15, 35, 18)} | Hardcode enableLegacyFBSupport flag
| {'url': 'https://api.github.com/repos/facebook/react/issues/28701/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28701/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28700 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28700/labels{/name} | https://api.github.com/repos/facebook/react/issues/28700/comments | https://api.github.com/repos/facebook/react/issues/28700/events | https://github.com/facebook/react/issues/28700 | 2,218,719,059 | I_kwDOAJy2Ks6EPvdT | 28,700 | Bug: Additional updater function call is not ignored in Strict Mode | {'login': 'ayloncarrijo', 'id': 77859081, 'node_id': 'MDQ6VXNlcjc3ODU5MDgx', 'avatar_url': 'https://avatars.githubusercontent.com/u/77859081?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ayloncarrijo', 'html_url': 'https://github.com/ayloncarrijo', 'followers_url': 'https://api.github.com/users/ayloncar... | [{'id': 1983406161, 'node_id': 'MDU6TGFiZWwxOTgzNDA2MTYx', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Expected%20Behavior', 'name': 'Resolution: Expected Behavior', 'color': '8c98d8', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"In React 18, StrictMode started double invoking effects. This is why you're seeing an additional call of the state updater function because we're invoking the function passed to `useEffect` again which calls `setState` again.\r\n\r\nThe docs describe the intention behind this change in more detail: https://react.d... | 2024-04-01 17:30:45 | 2024-04-02 13:00:12 | 2024-04-02 13:00:06 | NONE | null | null | null | When calling a setState with an updater function inside a useEffect, the additional call made in Strict Mode is not ignored, producing an unexpected state. The same behavior is NOT seen in React 17. From the docs:
> In Strict Mode, React will call your updater function twice in order to [help you find accidental imp... | {'url': 'https://api.github.com/repos/facebook/react/issues/28700/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28700/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28699 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28699/labels{/name} | https://api.github.com/repos/facebook/react/issues/28699/comments | https://api.github.com/repos/facebook/react/issues/28699/events | https://github.com/facebook/react/pull/28699 | 2,218,690,347 | PR_kwDOAJy2Ks5rVwic | 28,699 | Cleanup enableUseRefAccessWarning flag | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 7a2609eedc571049a3272e60d5f7d84601ffca3f...ab84793cbc6ec2db5cce83e268d8e4adbe56c131\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-04-01 17:15:12 | 2024-04-03 17:35:42 | 2024-04-03 17:35:38 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28699', 'html_url': 'https://github.com/facebook/react/pull/28699', 'diff_url': 'https://github.com/facebook/react/pull/28699.diff', 'patch_url': 'https://github.com/facebook/react/pull/28699.patch', 'merged_at': datetime.datetime(2024, 4, 3, 17, 35, 38)} | Cleanup enableUseRefAccessWarning flag
I don't think this flag has a path forward in the current implementation. The detection by stack trace is too brittle to detect the lazy initialization pattern reliably (see e.g. some internal tests that expect the warning because they use lazy intialization, but a slightly diffe... | {'url': 'https://api.github.com/repos/facebook/react/issues/28699/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28699/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28698 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28698/labels{/name} | https://api.github.com/repos/facebook/react/issues/28698/comments | https://api.github.com/repos/facebook/react/issues/28698/events | https://github.com/facebook/react/pull/28698 | 2,218,665,213 | PR_kwDOAJy2Ks5rVrBd | 28,698 | [be] Remove unshipped experimental <Cache> element type | {'login': 'josephsavona', 'id': 6425824, 'node_id': 'MDQ6VXNlcjY0MjU4MjQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6425824?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/josephsavona', 'html_url': 'https://github.com/josephsavona', 'followers_url': 'https://api.github.com/users/josephsavo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 95e6f032cf59f27b41e150e8a7746ee689acf634...3d16070c16985c59c748e786863c180adceff550\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-04-01 16:58:57 | 2024-04-02 14:57:08 | 2024-04-02 14:57:08 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28698', 'html_url': 'https://github.com/facebook/react/pull/28698', 'diff_url': 'https://github.com/facebook/react/pull/28698.diff', 'patch_url': 'https://github.com/facebook/react/pull/28698.patch', 'merged_at': datetime.datetime(2024, 4, 2, 14, 57, 8)} | Removes the `<Cache />` element type since we're going with a simpler caching strategy. | {'url': 'https://api.github.com/repos/facebook/react/issues/28698/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28698/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28697 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28697/labels{/name} | https://api.github.com/repos/facebook/react/issues/28697/comments | https://api.github.com/repos/facebook/react/issues/28697/events | https://github.com/facebook/react/pull/28697 | 2,218,654,532 | PR_kwDOAJy2Ks5rVoqp | 28,697 | Upgrade flow to 0.232.0 | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 93f91795a0c71bae4aadd7f082b91de0068a0f91...5f68f8142bdf0dc2c21ccd5b90f65773ea919c7f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-04-01 16:52:45 | 2024-04-02 14:40:08 | 2024-04-02 14:40:03 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28697', 'html_url': 'https://github.com/facebook/react/pull/28697', 'diff_url': 'https://github.com/facebook/react/pull/28697.diff', 'patch_url': 'https://github.com/facebook/react/pull/28697.patch', 'merged_at': datetime.datetime(2024, 4, 2, 14, 40, 3)} | Upgrade flow to 0.232.0
| {'url': 'https://api.github.com/repos/facebook/react/issues/28697/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28697/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28696 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28696/labels{/name} | https://api.github.com/repos/facebook/react/issues/28696/comments | https://api.github.com/repos/facebook/react/issues/28696/events | https://github.com/facebook/react/pull/28696 | 2,218,636,561 | PR_kwDOAJy2Ks5rVktu | 28,696 | Land useModernStrictMode in www | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2024-04-01 16:41:11 | 2024-04-01 17:05:11 | 2024-04-01 17:05:08 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28696', 'html_url': 'https://github.com/facebook/react/pull/28696', 'diff_url': 'https://github.com/facebook/react/pull/28696.diff', 'patch_url': 'https://github.com/facebook/react/pull/28696.patch', 'merged_at': datetime.datetime(2024, 4, 1, 17, 5, 8)} | this has landed | {'url': 'https://api.github.com/repos/facebook/react/issues/28696/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28696/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28695 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28695/labels{/name} | https://api.github.com/repos/facebook/react/issues/28695/comments | https://api.github.com/repos/facebook/react/issues/28695/events | https://github.com/facebook/react/pull/28695 | 2,218,522,329 | PR_kwDOAJy2Ks5rVLaZ | 28,695 | Convert deprecated stalebot to github action | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: df95577db0d1d7ca383f281bc1d9e6ba5579bef2...811512a80efefd57edbb2d706e94282d85331490\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-04-01 15:39:49 | 2024-04-01 18:32:34 | 2024-04-01 18:32:28 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28695', 'html_url': 'https://github.com/facebook/react/pull/28695', 'diff_url': 'https://github.com/facebook/react/pull/28695.diff', 'patch_url': 'https://github.com/facebook/react/pull/28695.patch', 'merged_at': datetime.datetime(2024, 4, 1, 18, 32, 28)} | ## Summary
This repo uses [Stalebot](https://github.com/probot/stale) to manage stale Issues and PRs. Stalebot hasn't been maintained for a couple of years and is officially archived. The number of open Issues and PRs has increased rapidly since early 2022. Some of this looks like issues with Stalebot reliability wh... | {'url': 'https://api.github.com/repos/facebook/react/issues/28695/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28695/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28694 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28694/labels{/name} | https://api.github.com/repos/facebook/react/issues/28694/comments | https://api.github.com/repos/facebook/react/issues/28694/events | https://github.com/facebook/react/issues/28694 | 2,217,109,393 | I_kwDOAJy2Ks6EJmeR | 28,694 | Bug: Internal React error: Expected static flag was missing. | {'login': 'Fun117', 'id': 141471450, 'node_id': 'U_kgDOCG6u2g', 'avatar_url': 'https://avatars.githubusercontent.com/u/141471450?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Fun117', 'html_url': 'https://github.com/Fun117', 'followers_url': 'https://api.github.com/users/Fun117/followers', 'following_ur... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Definitely ",
"Hey there @Fun117 👋\r\n\r\nThanks for opening this issue! To help us fix the problem you're experiencing, could you please do two things for me:\r\n\r\n1. Create a [minimal, reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) demonstrating this bug. I'd start by rem... | 2024-03-31 17:52:52 | 2024-04-04 13:13:10 | 2024-04-04 13:13:10 | NONE | null | null | null | This error arose while implementing a feature to collapse reply comments in the comment section of a website. You can find the potentially problematic code [here](https://codesandbox.io/s/github/Fun117/my-react-issues?file=/src/components/client/elements/comments.tsx#57).
**Versions:**
- Next.js: 14.1.3
- React: 1... | {'url': 'https://api.github.com/repos/facebook/react/issues/28694/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 1, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28694/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28693 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28693/labels{/name} | https://api.github.com/repos/facebook/react/issues/28693/comments | https://api.github.com/repos/facebook/react/issues/28693/events | https://github.com/facebook/react/pull/28693 | 2,217,071,293 | PR_kwDOAJy2Ks5rQQD6 | 28,693 | Clean up console.log tests | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: df95577db0d1d7ca383f281bc1d9e6ba5579bef2...42b41896a62ad27ff87c03f2a657b617f3c53358\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-31 16:26:26 | 2024-04-01 14:50:52 | 2024-04-01 14:50:49 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28693', 'html_url': 'https://github.com/facebook/react/pull/28693', 'diff_url': 'https://github.com/facebook/react/pull/28693.diff', 'patch_url': 'https://github.com/facebook/react/pull/28693.patch', 'merged_at': datetime.datetime(2024, 4, 1, 14, 50, 49)} | Followups to https://github.com/facebook/react/pull/28680
One of these test don't need to use `console.log`.
The others are specifically testing `console.log` behavior, so I added a comment. | {'url': 'https://api.github.com/repos/facebook/react/issues/28693/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28693/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28692 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28692/labels{/name} | https://api.github.com/repos/facebook/react/issues/28692/comments | https://api.github.com/repos/facebook/react/issues/28692/events | https://github.com/facebook/react/pull/28692 | 2,217,059,864 | PR_kwDOAJy2Ks5rQN3I | 28,692 | [ESLint] Update README links to react.dev | {'login': 'jfgreffier', 'id': 12395973, 'node_id': 'MDQ6VXNlcjEyMzk1OTcz', 'avatar_url': 'https://avatars.githubusercontent.com/u/12395973?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jfgreffier', 'html_url': 'https://github.com/jfgreffier', 'followers_url': 'https://api.github.com/users/jfgreffier/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: df95577db0d1d7ca383f281bc1d9e6ba5579bef2...03f7ed2bce8c5d4410b68a1ff2b9407a31bb3b45\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-31 15:59:54 | 2024-04-01 14:52:34 | 2024-04-01 14:52:34 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28692', 'html_url': 'https://github.com/facebook/react/pull/28692', 'diff_url': 'https://github.com/facebook/react/pull/28692.diff', 'patch_url': 'https://github.com/facebook/react/pull/28692.patch', 'merged_at': datetime.datetime(2024, 4, 1, 14, 52, 34)} | Update ESLint plugin README to redirect to https://react.dev for more details (instead of legacy docs)
| {'url': 'https://api.github.com/repos/facebook/react/issues/28692/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28692/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28691 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28691/labels{/name} | https://api.github.com/repos/facebook/react/issues/28691/comments | https://api.github.com/repos/facebook/react/issues/28691/events | https://github.com/facebook/react/pull/28691 | 2,216,800,155 | PR_kwDOAJy2Ks5rPaAi | 28,691 | fix(eslint-plugin): ExhaustiveDeps: Auto fixing should add a dependency array to `useMemo` and `useCallback` | {'login': 'AhmedBaset', 'id': 82659015, 'node_id': 'MDQ6VXNlcjgyNjU5MDE1', 'avatar_url': 'https://avatars.githubusercontent.com/u/82659015?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AhmedBaset', 'html_url': 'https://github.com/AhmedBaset', 'followers_url': 'https://api.github.com/users/AhmedBaset/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: df95577db0d1d7ca383f281bc1d9e6ba5579bef2...65c27ef9e8a23f6215cdd3cbc57bbdfea97b8087\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-31 06:10:06 | 2024-03-31 06:35:24 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28691', 'html_url': 'https://github.com/facebook/react/pull/28691', 'diff_url': 'https://github.com/facebook/react/pull/28691.diff', 'patch_url': 'https://github.com/facebook/react/pull/28691.patch', 'merged_at': None} | ## Summary
`useMemo` and `useCallback` accept two required parameters. Currently, when including unstable reference in Effect/Memo/Callback dependency array, the eslint plugin will suggest to wrap the unstable reference with `useCallback`/`useMemo`
> The {reference} function makes the dependencies of useCallback ... | {'url': 'https://api.github.com/repos/facebook/react/issues/28691/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28691/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28690 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28690/labels{/name} | https://api.github.com/repos/facebook/react/issues/28690/comments | https://api.github.com/repos/facebook/react/issues/28690/events | https://github.com/facebook/react/issues/28690 | 2,216,768,995 | I_kwDOAJy2Ks6EITXj | 28,690 | Bug: متجر الكتروني | {'login': 'Aliqateebah', 'id': 109043364, 'node_id': 'U_kgDOBn_epA', 'avatar_url': 'https://avatars.githubusercontent.com/u/109043364?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Aliqateebah', 'html_url': 'https://github.com/Aliqateebah', 'followers_url': 'https://api.github.com/users/Aliqateebah/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2024-03-31 04:11:55 | 2024-03-31 04:12:33 | 2024-03-31 04:12:33 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get fixed much fast... | {'url': 'https://api.github.com/repos/facebook/react/issues/28690/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28690/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28688 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28688/labels{/name} | https://api.github.com/repos/facebook/react/issues/28688/comments | https://api.github.com/repos/facebook/react/issues/28688/events | https://github.com/facebook/react/pull/28688 | 2,216,702,087 | PR_kwDOAJy2Ks5rPHkD | 28,688 | Correct types for functions stored in useState | {'login': 'totalolage', 'id': 41711263, 'node_id': 'MDQ6VXNlcjQxNzExMjYz', 'avatar_url': 'https://avatars.githubusercontent.com/u/41711263?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/totalolage', 'html_url': 'https://github.com/totalolage', 'followers_url': 'https://api.github.com/users/totalolage/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5d4b7587da52dd81bc5c366b909c4511e2970cd1...4d951ea9be1d1c2ee3487249a279e42c4c900f2f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-30 23:34:48 | 2024-04-02 08:09:38 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28688', 'html_url': 'https://github.com/facebook/react/pull/28688', 'diff_url': 'https://github.com/facebook/react/pull/28688.diff', 'patch_url': 'https://github.com/facebook/react/pull/28688.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/28688/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28688/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28687 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28687/labels{/name} | https://api.github.com/repos/facebook/react/issues/28687/comments | https://api.github.com/repos/facebook/react/issues/28687/events | https://github.com/facebook/react/issues/28687 | 2,216,601,653 | I_kwDOAJy2Ks6EHqg1 | 28,687 | Bug: when useEffect's dependency array is empty | {'login': 'GeorgeHcc', 'id': 72842677, 'node_id': 'MDQ6VXNlcjcyODQyNjc3', 'avatar_url': 'https://avatars.githubusercontent.com/u/72842677?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/GeorgeHcc', 'html_url': 'https://github.com/GeorgeHcc', 'followers_url': 'https://api.github.com/users/GeorgeHcc/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2024-03-30 17:49:31 | 2024-03-30 17:49:48 | 2024-03-30 17:49:48 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/28687/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28687/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28686 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28686/labels{/name} | https://api.github.com/repos/facebook/react/issues/28686/comments | https://api.github.com/repos/facebook/react/issues/28686/events | https://github.com/facebook/react/pull/28686 | 2,216,501,942 | PR_kwDOAJy2Ks5rOgvD | 28,686 | Finish cleaning up digest from onRecoverableError | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b9149cc6e6442389accf1f7c34a77ba2e6e52b5e...342a0267e152320a705803cefb3bfd1ff0413585\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-30 14:46:47 | 2024-03-30 22:32:21 | 2024-03-30 22:32:20 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28686', 'html_url': 'https://github.com/facebook/react/pull/28686', 'diff_url': 'https://github.com/facebook/react/pull/28686.diff', 'patch_url': 'https://github.com/facebook/react/pull/28686.patch', 'merged_at': datetime.datetime(2024, 3, 30, 22, 32, 20)} | Don't need to track it separately on the captured value anymore.
Shouldn't be in the types.
I used a getter for the warning instead because Proxies are kind of heavy weight options for this kind of warning. We typically use getters.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28686/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28686/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28685 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28685/labels{/name} | https://api.github.com/repos/facebook/react/issues/28685/comments | https://api.github.com/repos/facebook/react/issues/28685/events | https://github.com/facebook/react/issues/28685 | 2,216,371,658 | I_kwDOAJy2Ks6EGyXK | 28,685 | Bug: | {'login': 'Ahmed30mara2018', 'id': 158719383, 'node_id': 'U_kgDOCXXdlw', 'avatar_url': 'https://avatars.githubusercontent.com/u/158719383?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Ahmed30mara2018', 'html_url': 'https://github.com/Ahmed30mara2018', 'followers_url': 'https://api.github.com/users/Ahmed... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hey @Ahmed30mara2018 👋\r\n\r\nDo you have a bug with React.js that you would like to report?\r\n\r\nPlease do not use this repo to test GitHub's features. You can [create your own repo](https://docs.github.com/en/repositories/creating-and-managing-repositories/quickstart-for-repositories) to do that.\r\n\r\nThank... | 2024-03-30 10:13:21 | 2024-04-05 02:31:31 | 2024-04-05 02:31:31 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get fixed much fast... | {'url': 'https://api.github.com/repos/facebook/react/issues/28685/reactions', 'total_count': 4, '+1': 0, '-1': 3, 'laugh': 0, 'hooray': 0, 'confused': 1, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28685/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28684 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28684/labels{/name} | https://api.github.com/repos/facebook/react/issues/28684/comments | https://api.github.com/repos/facebook/react/issues/28684/events | https://github.com/facebook/react/pull/28684 | 2,216,066,744 | PR_kwDOAJy2Ks5rNI62 | 28,684 | Include regular stack trace in serialized errors from Fizz | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cc56bed38cbe5a5c76dfdc4e9c642fab4884a3fc...e4d259117cf4b1448c165250e17cf68ab22f9331\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 22:51:41 | 2024-03-30 15:08:54 | 2024-03-30 15:08:54 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28684', 'html_url': 'https://github.com/facebook/react/pull/28684', 'diff_url': 'https://github.com/facebook/react/pull/28684.diff', 'patch_url': 'https://github.com/facebook/react/pull/28684.patch', 'merged_at': datetime.datetime(2024, 3, 30, 15, 8, 54)} | We previously only included the component stack.
Cleaned up the fields in Fizz server that wasn't using consistent hidden classes in dev vs prod.
Added a prefix to errors serialized from server rendering. It can be a bit confusing to see where this error came from otherwise since it didn't come from elsewhere... | {'url': 'https://api.github.com/repos/facebook/react/issues/28684/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28684/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28683 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28683/labels{/name} | https://api.github.com/repos/facebook/react/issues/28683/comments | https://api.github.com/repos/facebook/react/issues/28683/events | https://github.com/facebook/react/pull/28683 | 2,216,039,122 | PR_kwDOAJy2Ks5rNDGT | 28,683 | docs: update code of conduct links in README.md | {'login': 'ahmoin', 'id': 123082059, 'node_id': 'U_kgDOB1YVSw', 'avatar_url': 'https://avatars.githubusercontent.com/u/123082059?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ahmoin', 'html_url': 'https://github.com/ahmoin', 'followers_url': 'https://api.github.com/users/ahmoin/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5d4b7587da52dd81bc5c366b909c4511e2970cd1...085489dcfca1616bbd0e15ecf2d16083c7cfbf6c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 22:04:55 | 2024-03-31 18:43:49 | 2024-03-31 18:43:49 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28683', 'html_url': 'https://github.com/facebook/react/pull/28683', 'diff_url': 'https://github.com/facebook/react/pull/28683.diff', 'patch_url': 'https://github.com/facebook/react/pull/28683.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/28683/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28683/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28682 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28682/labels{/name} | https://api.github.com/repos/facebook/react/issues/28682/comments | https://api.github.com/repos/facebook/react/issues/28682/events | https://github.com/facebook/react/pull/28682 | 2,216,035,824 | PR_kwDOAJy2Ks5rNCbM | 28,682 | Test setting prop to undefined in ReactDOMComponent | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5d4b7587da52dd81bc5c366b909c4511e2970cd1...894191cd9478988cd7f43d2f3c616e91482690b6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 21:59:52 | 2024-03-29 22:29:40 | 2024-03-29 22:29:40 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28682', 'html_url': 'https://github.com/facebook/react/pull/28682', 'diff_url': 'https://github.com/facebook/react/pull/28682.diff', 'patch_url': 'https://github.com/facebook/react/pull/28682.patch', 'merged_at': None} | Test setting prop to undefined in ReactDOMComponent
| {'url': 'https://api.github.com/repos/facebook/react/issues/28682/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28682/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28681 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28681/labels{/name} | https://api.github.com/repos/facebook/react/issues/28681/comments | https://api.github.com/repos/facebook/react/issues/28681/events | https://github.com/facebook/react/pull/28681 | 2,216,026,912 | PR_kwDOAJy2Ks5rNAhV | 28,681 | Reland #28672: Remove IndeterminateComponent | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 23b32d3f8d273c87f114ad3ec2dcd44d16a5c624...e8d3c6b464221db79d8f08f78cd663400f1f5b04\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 21:46:50 | 2024-04-03 00:42:46 | 2024-04-03 00:42:43 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28681', 'html_url': 'https://github.com/facebook/react/pull/28681', 'diff_url': 'https://github.com/facebook/react/pull/28681.diff', 'patch_url': 'https://github.com/facebook/react/pull/28681.patch', 'merged_at': datetime.datetime(2024, 4, 3, 0, 42, 43)} | This PR relands #28672 on top of the flag removal and the test demonstrating a breakage in Suspense for legacy mode.
React has deprecated module pattern Function Components for many years at this point. Supporting this pattern required React to have a concept of an indeterminate component so that when a component fi... | {'url': 'https://api.github.com/repos/facebook/react/issues/28681/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28681/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28680 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28680/labels{/name} | https://api.github.com/repos/facebook/react/issues/28680/comments | https://api.github.com/repos/facebook/react/issues/28680/events | https://github.com/facebook/react/pull/28680 | 2,215,974,029 | PR_kwDOAJy2Ks5rM1Wx | 28,680 | Suppress console output in unit tests | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2aed507a76a0b1524426c398897cbe47d80c51e5...6584708806c3ca4112dea49a657fb51933727ec1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 20:39:49 | 2024-04-01 19:53:56 | 2024-03-30 16:36:23 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28680', 'html_url': 'https://github.com/facebook/react/pull/28680', 'diff_url': 'https://github.com/facebook/react/pull/28680.diff', 'patch_url': 'https://github.com/facebook/react/pull/28680.patch', 'merged_at': datetime.datetime(2024, 3, 30, 16, 36, 23)} | ## Summary
Changes all unit tests that were spewing console output via `console.log` to no longer do so.
This will help reduce logspew and simplify parsing the reported Jest results.
## How did you test this change?
See no more logspew when running unit tests.
```
$ yarn test
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/28680/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28680/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28679 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28679/labels{/name} | https://api.github.com/repos/facebook/react/issues/28679/comments | https://api.github.com/repos/facebook/react/issues/28679/events | https://github.com/facebook/react/pull/28679 | 2,215,950,840 | PR_kwDOAJy2Ks5rMwnL | 28,679 | Clarify RTR native feature flags are fb specific | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6cd6ba703de77e332ab201518b6e30e47cd49aaf...c6a7756935bc2514d67f8a5913803ba93a925b72\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 20:15:44 | 2024-04-01 14:56:32 | 2024-04-01 14:56:28 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28679', 'html_url': 'https://github.com/facebook/react/pull/28679', 'diff_url': 'https://github.com/facebook/react/pull/28679.diff', 'patch_url': 'https://github.com/facebook/react/pull/28679.patch', 'merged_at': datetime.datetime(2024, 4, 1, 14, 56, 28)} | Make it more clear that these flags aren't used in RN OSS.
- Rename `packages/shared/forks/ReactFeatureFlags.test-renderer.native.js` to `packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js`
- Remove RN OSS build cases consuming the feature flags since there is no RN OSS RTR build. | {'url': 'https://api.github.com/repos/facebook/react/issues/28679/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28679/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28678 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28678/labels{/name} | https://api.github.com/repos/facebook/react/issues/28678/comments | https://api.github.com/repos/facebook/react/issues/28678/events | https://github.com/facebook/react/pull/28678 | 2,215,945,162 | PR_kwDOAJy2Ks5rMvag | 28,678 | Mock modules in tests using `Module` | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 425f72bdd4263dcaba829cf52545309bbfde56b4...84446de453da7a5565cc621aefcbdfe803e367f1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 20:09:27 | 2024-03-29 20:19:57 | 2024-03-29 20:19:55 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28678', 'html_url': 'https://github.com/facebook/react/pull/28678', 'diff_url': 'https://github.com/facebook/react/pull/28678.diff', 'patch_url': 'https://github.com/facebook/react/pull/28678.patch', 'merged_at': datetime.datetime(2024, 3, 29, 20, 19, 55)} | ## Summary
Fixes a type validation error introduced in newer versions of Node.js when calling `Module.prototype._compile` in our unit tests. (I tried but have yet to pinpoint the precise change in Node.js that introduced this vaildation.)
The specific error that currently occurs when running unit tests with Node.... | {'url': 'https://api.github.com/repos/facebook/react/issues/28678/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28678/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28677 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28677/labels{/name} | https://api.github.com/repos/facebook/react/issues/28677/comments | https://api.github.com/repos/facebook/react/issues/28677/events | https://github.com/facebook/react/pull/28677 | 2,215,871,289 | PR_kwDOAJy2Ks5rMft8 | 28,677 | Align React Native OSS/Test Feature Flags | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 23b32d3f8d273c87f114ad3ec2dcd44d16a5c624...e7db8ea85759942f242486a4ac578de5289984e7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 19:00:02 | 2024-03-29 19:47:03 | 2024-03-29 19:47:00 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28677', 'html_url': 'https://github.com/facebook/react/pull/28677', 'diff_url': 'https://github.com/facebook/react/pull/28677.diff', 'patch_url': 'https://github.com/facebook/react/pull/28677.patch', 'merged_at': datetime.datetime(2024, 3, 29, 19, 47)} | ## Summary
Makes a few changes to align React Native feature flags for open source and internal test renderer configurations.
* Enable `enableSchedulingProfiler` for profiling builds.
* Align `ReactFeatureFlags.test-renderer.native.js` (with `ReactFeatureFlags.native-fb.js`).
* Enable `enableUseMemoCacheHook`... | {'url': 'https://api.github.com/repos/facebook/react/issues/28677/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28677/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28676 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28676/labels{/name} | https://api.github.com/repos/facebook/react/issues/28676/comments | https://api.github.com/repos/facebook/react/issues/28676/events | https://github.com/facebook/react/pull/28676 | 2,215,866,722 | PR_kwDOAJy2Ks5rMevS | 28,676 | Land enableNewBooleanProps everywhere | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 23b32d3f8d273c87f114ad3ec2dcd44d16a5c624...bba88838f56cb841a2f1b2d2d7301173a4f0a1cb\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 18:55:27 | 2024-04-02 12:39:56 | 2024-03-29 20:02:32 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28676', 'html_url': 'https://github.com/facebook/react/pull/28676', 'diff_url': 'https://github.com/facebook/react/pull/28676.diff', 'patch_url': 'https://github.com/facebook/react/pull/28676.patch', 'merged_at': datetime.datetime(2024, 3, 29, 20, 2, 32)} | Rolled out internally. Removing flag. | {'url': 'https://api.github.com/repos/facebook/react/issues/28676/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28676/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28675 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28675/labels{/name} | https://api.github.com/repos/facebook/react/issues/28675/comments | https://api.github.com/repos/facebook/react/issues/28675/events | https://github.com/facebook/react/pull/28675 | 2,215,866,470 | PR_kwDOAJy2Ks5rMerj | 28,675 | Don't let error boundaries catch errors during hydration | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cc56bed38cbe5a5c76dfdc4e9c642fab4884a3fc...08533764324af9ada25a84b1316b5ffd23e00f7c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 18:55:17 | 2024-03-29 20:43:22 | 2024-03-29 20:43:22 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28675', 'html_url': 'https://github.com/facebook/react/pull/28675', 'diff_url': 'https://github.com/facebook/react/pull/28675.diff', 'patch_url': 'https://github.com/facebook/react/pull/28675.patch', 'merged_at': datetime.datetime(2024, 3, 29, 20, 43, 22)} | When an error boundary catches an error during hydration it'll try to render the error state which will then try to hydrate that state, causing hydration warnings.
When an error happens inside a Suspense boundary during hydration, we instead let the boundary catch it and restart a client render from there. However, ... | {'url': 'https://api.github.com/repos/facebook/react/issues/28675/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28675/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28674 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28674/labels{/name} | https://api.github.com/repos/facebook/react/issues/28674/comments | https://api.github.com/repos/facebook/react/issues/28674/events | https://github.com/facebook/react/pull/28674 | 2,215,711,667 | PR_kwDOAJy2Ks5rL8cn | 28,674 | Test for ReactTestRenderer | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a73c3450e1b528fa6cb3e94fa4d4359c7a4b61f1...633df5a23cc83dbc2c1e43f7d49623709c65bd41\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 17:05:22 | 2024-03-29 18:01:50 | 2024-03-29 18:01:46 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28674', 'html_url': 'https://github.com/facebook/react/pull/28674', 'diff_url': 'https://github.com/facebook/react/pull/28674.diff', 'patch_url': 'https://github.com/facebook/react/pull/28674.patch', 'merged_at': datetime.datetime(2024, 3, 29, 18, 1, 46)} | This is a repro for a breakage that #28672 would introduce for legacy sync rendering. | {'url': 'https://api.github.com/repos/facebook/react/issues/28674/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28674/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28673 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28673/labels{/name} | https://api.github.com/repos/facebook/react/issues/28673/comments | https://api.github.com/repos/facebook/react/issues/28673/events | https://github.com/facebook/react/pull/28673 | 2,215,661,744 | PR_kwDOAJy2Ks5rLxYh | 28,673 | Revert "Remove zoom from special cases list" | {'login': 'sophiebits', 'id': 6820, 'node_id': 'MDQ6VXNlcjY4MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sophiebits', 'html_url': 'https://github.com/sophiebits', 'followers_url': 'https://api.github.com/users/sophiebits/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a73c3450e1b528fa6cb3e94fa4d4359c7a4b61f1...c77686bc3b4cd2f1af4ca59f90707cbbd58cfedf\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 16:32:05 | 2024-03-29 17:39:12 | 2024-03-29 17:39:12 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28673', 'html_url': 'https://github.com/facebook/react/pull/28673', 'diff_url': 'https://github.com/facebook/react/pull/28673.diff', 'patch_url': 'https://github.com/facebook/react/pull/28673.patch', 'merged_at': datetime.datetime(2024, 3, 29, 17, 39, 12)} | Reverts facebook/react#26631
This got specced: https://github.com/w3c/csswg-drafts/pull/9699
I left msZoom because it seems plausible someone will still be using it for backwards compat. | {'url': 'https://api.github.com/repos/facebook/react/issues/28673/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28673/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28672 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28672/labels{/name} | https://api.github.com/repos/facebook/react/issues/28672/comments | https://api.github.com/repos/facebook/react/issues/28672/events | https://github.com/facebook/react/pull/28672 | 2,215,560,428 | PR_kwDOAJy2Ks5rLbda | 28,672 | Refactor to remove IndeterminateComponent | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 23b32d3f8d273c87f114ad3ec2dcd44d16a5c624...2bd3f3b31b43fe6f89d42e70a86380ab3779db18\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 15:17:41 | 2024-03-29 21:52:13 | 2024-03-29 21:52:10 | MEMBER | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/28672', 'html_url': 'https://github.com/facebook/react/pull/28672', 'diff_url': 'https://github.com/facebook/react/pull/28672.diff', 'patch_url': 'https://github.com/facebook/react/pull/28672.patch', 'merged_at': None} | Refactor to remove IndeterminateComponent
| {'url': 'https://api.github.com/repos/facebook/react/issues/28672/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28672/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28671 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28671/labels{/name} | https://api.github.com/repos/facebook/react/issues/28671/comments | https://api.github.com/repos/facebook/react/issues/28671/events | https://github.com/facebook/react/pull/28671 | 2,215,494,920 | PR_kwDOAJy2Ks5rLNPm | 28,671 | Remove module pattern function component support (flag only) | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f2690747239533fa266612d2d4dd9ae88ea92fbc...9a33649c1fee93d6f5123aaebb17ef40f3e4f227\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 14:30:56 | 2024-03-29 15:16:21 | 2024-03-29 15:16:17 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28671', 'html_url': 'https://github.com/facebook/react/pull/28671', 'diff_url': 'https://github.com/facebook/react/pull/28671.diff', 'patch_url': 'https://github.com/facebook/react/pull/28671.patch', 'merged_at': datetime.datetime(2024, 3, 29, 15, 16, 17)} | Remove module pattern function component support (flag only)
> This is a redo of #27742, but only including the flag removal, excluding further simplifications.
The module pattern
```
function MyComponent() {
return {
render() {
return this.state.foo
}
}
}
```
has been deprecated for approximately... | {'url': 'https://api.github.com/repos/facebook/react/issues/28671/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28671/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28670 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28670/labels{/name} | https://api.github.com/repos/facebook/react/issues/28670/comments | https://api.github.com/repos/facebook/react/issues/28670/events | https://github.com/facebook/react/pull/28670 | 2,215,406,664 | PR_kwDOAJy2Ks5rK5Kh | 28,670 | Revert "Remove module pattern function component support" | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cc56bed38cbe5a5c76dfdc4e9c642fab4884a3fc...0da7d96c1978ec86975cec9dadf8af23e7ab7050\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 13:49:45 | 2024-03-29 14:10:23 | 2024-03-29 14:10:11 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28670', 'html_url': 'https://github.com/facebook/react/pull/28670', 'diff_url': 'https://github.com/facebook/react/pull/28670.diff', 'patch_url': 'https://github.com/facebook/react/pull/28670.patch', 'merged_at': datetime.datetime(2024, 3, 29, 14, 10, 11)} | This breaks internal tests, so must be something in the refactor. Since it's the top commit let's revert and split into two PRs, one that removes the flag and one that does the refactor, so we can find the bug. | {'url': 'https://api.github.com/repos/facebook/react/issues/28670/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28670/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28669 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28669/labels{/name} | https://api.github.com/repos/facebook/react/issues/28669/comments | https://api.github.com/repos/facebook/react/issues/28669/events | https://github.com/facebook/react/pull/28669 | 2,215,391,686 | PR_kwDOAJy2Ks5rK1yk | 28,669 | [Flight] Update stale blocked values in `createModelResolver` | {'login': 'unstubbable', 'id': 761683, 'node_id': 'MDQ6VXNlcjc2MTY4Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/761683?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/unstubbable', 'html_url': 'https://github.com/unstubbable', 'followers_url': 'https://api.github.com/users/unstubbable/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f2690747239533fa266612d2d4dd9ae88ea92fbc...32c5b0b9d10fe57b2b511c5e958ec5f51f11ff5b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-29 13:42:35 | 2024-04-02 08:08:02 | 2024-04-01 16:37:27 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28669', 'html_url': 'https://github.com/facebook/react/pull/28669', 'diff_url': 'https://github.com/facebook/react/pull/28669.diff', 'patch_url': 'https://github.com/facebook/react/pull/28669.patch', 'merged_at': datetime.datetime(2024, 4, 1, 16, 37, 27)} | Alternative to #28620.
Instead of emitting lazy references to not-yet-emitted models in the Flight Server, this fixes the observed issue in https://github.com/unstubbable/ai-rsc-test/pull/1 by adjusting the lazy model resolution in the Flight Client to update stale blocked root models, before assigning them as chunk... | {'url': 'https://api.github.com/repos/facebook/react/issues/28669/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28669/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28668 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28668/labels{/name} | https://api.github.com/repos/facebook/react/issues/28668/comments | https://api.github.com/repos/facebook/react/issues/28668/events | https://github.com/facebook/react/pull/28668 | 2,213,991,810 | PR_kwDOAJy2Ks5rGFvQ | 28,668 | Warn when using useFormState | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 63651c49e068a04cdc6ee1e2fa9c6125167987d2...9b39940bc918a8627fed9949c0c43d097aedab8a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-28 19:39:22 | 2024-03-29 17:40:57 | 2024-03-29 17:40:54 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28668', 'html_url': 'https://github.com/facebook/react/pull/28668', 'diff_url': 'https://github.com/facebook/react/pull/28668.diff', 'patch_url': 'https://github.com/facebook/react/pull/28668.patch', 'merged_at': datetime.datetime(2024, 3, 29, 17, 40, 54)} | ## Overview
useFormState has been replaced with useActionState. Warn when it's used.
Also removes the `experimental_useFormState` warnings. | {'url': 'https://api.github.com/repos/facebook/react/issues/28668/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28668/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28667 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28667/labels{/name} | https://api.github.com/repos/facebook/react/issues/28667/comments | https://api.github.com/repos/facebook/react/issues/28667/events | https://github.com/facebook/react/issues/28667 | 2,213,855,720 | I_kwDOAJy2Ks6D9MHo | 28,667 | Please allow indie developers to impelement Facebook Login without business verification | {'login': 'umutakmak', 'id': 65496952, 'node_id': 'MDQ6VXNlcjY1NDk2OTUy', 'avatar_url': 'https://avatars.githubusercontent.com/u/65496952?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/umutakmak', 'html_url': 'https://github.com/umutakmak', 'followers_url': 'https://api.github.com/users/umutakmak/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This repo is for issues specific to React, we're not related to Facebook Login"
] | 2024-03-28 18:19:50 | 2024-03-28 21:33:35 | 2024-03-28 21:33:35 | NONE | null | null | null | Some support pages link to an "individual verification" method for using Facebook Login in apps but i can't seem to find it now. My meta console says I have to verify my business. Is this a bug? Why would anyone HAVE TO own a business to implement facebook login? Can you clerify if this is a bug or Meta just don't like... | {'url': 'https://api.github.com/repos/facebook/react/issues/28667/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28667/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28666 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28666/labels{/name} | https://api.github.com/repos/facebook/react/issues/28666/comments | https://api.github.com/repos/facebook/react/issues/28666/events | https://github.com/facebook/react/issues/28666 | 2,213,748,683 | I_kwDOAJy2Ks6D8x_L | 28,666 | Bug: componentDidMountCalled before ref is set | {'login': 'CodeMedic42', 'id': 7494201, 'node_id': 'MDQ6VXNlcjc0OTQyMDE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7494201?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/CodeMedic42', 'html_url': 'https://github.com/CodeMedic42', 'followers_url': 'https://api.github.com/users/CodeMedic42/f... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [
"Added a couple of more `debugger`s.\r\n\r\nResult:\r\n **Test** > **Bar1** > **Ex1.render()** > **Ex2.render()** > **Ex2.componentDidMount()** > **Ex1** > **Ex2.componentDidMount()**\r\n\r\nFurther investigation is needed and maybe someone can explain if this is intentional behavior.\r\n\r\n<details>\r\n <summary... | 2024-03-28 17:21:21 | 2024-03-31 16:43:17 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
I have encountered an issue where a class componentDidMount method is called bef... | {'url': 'https://api.github.com/repos/facebook/react/issues/28666/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28666/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28665 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28665/labels{/name} | https://api.github.com/repos/facebook/react/issues/28665/comments | https://api.github.com/repos/facebook/react/issues/28665/events | https://github.com/facebook/react/pull/28665 | 2,212,278,397 | PR_kwDOAJy2Ks5rAPo9 | 28,665 | Don't log onRecoverableError if the current commit fail | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 323b6e98a76fe6ee721f10d327a9a682334d1a97...493035b612f83aa782ff47e206db7a608bc72745\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-28 03:31:59 | 2024-03-28 14:39:49 | 2024-03-28 14:39:49 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28665', 'html_url': 'https://github.com/facebook/react/pull/28665', 'diff_url': 'https://github.com/facebook/react/pull/28665.diff', 'patch_url': 'https://github.com/facebook/react/pull/28665.patch', 'merged_at': datetime.datetime(2024, 3, 28, 14, 39, 49)} | We didn't recover after all.
Currently we might log a recoverable error in the recovery pass. E.g. the SSR server had an error. Then the client component fails to render which errors again. This ends up double logging.
So if we fail to actually complete a fully successful commit, we ignore any recoverable errors ... | {'url': 'https://api.github.com/repos/facebook/react/issues/28665/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28665/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28664 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28664/labels{/name} | https://api.github.com/repos/facebook/react/issues/28664/comments | https://api.github.com/repos/facebook/react/issues/28664/events | https://github.com/facebook/react/pull/28664 | 2,212,143,745 | PR_kwDOAJy2Ks5q_yul | 28,664 | Remove errorHydratingContainer | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9f33f699e4f832971dc0f2047129f832655a3b6d...8d49499d1e9cf3c542087bb33265152e639b653f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-28 00:59:14 | 2024-03-28 03:48:18 | 2024-03-28 03:48:18 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28664', 'html_url': 'https://github.com/facebook/react/pull/28664', 'diff_url': 'https://github.com/facebook/react/pull/28664.diff', 'patch_url': 'https://github.com/facebook/react/pull/28664.patch', 'merged_at': datetime.datetime(2024, 3, 28, 3, 48, 18)} | I originally added this in #21021 but I didn't mention why and I don't quite remember why. Maybe because there were no other message? However at the time the recoverable errors mechanism didn't exist.
Today I believe all cases where this happens will trigger another recoverable error. Namely these two:
https://gi... | {'url': 'https://api.github.com/repos/facebook/react/issues/28664/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28664/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28663 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28663/labels{/name} | https://api.github.com/repos/facebook/react/issues/28663/comments | https://api.github.com/repos/facebook/react/issues/28663/events | https://github.com/facebook/react/pull/28663 | 2,211,783,943 | PR_kwDOAJy2Ks5q-kBZ | 28,663 | Dymanic favorSafetyOverHydrationPerf | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8436bcca6287077a5409b3c9180f8af0361b16a5...b718c4007cd3d66d05c1a85c7e5c032d0c89c38b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-27 19:55:22 | 2024-03-27 21:43:25 | 2024-03-27 21:43:25 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28663', 'html_url': 'https://github.com/facebook/react/pull/28663', 'diff_url': 'https://github.com/facebook/react/pull/28663.diff', 'patch_url': 'https://github.com/facebook/react/pull/28663.patch', 'merged_at': datetime.datetime(2024, 3, 27, 21, 43, 25)} | For rollout | {'url': 'https://api.github.com/repos/facebook/react/issues/28663/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28663/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28662 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28662/labels{/name} | https://api.github.com/repos/facebook/react/issues/28662/comments | https://api.github.com/repos/facebook/react/issues/28662/events | https://github.com/facebook/react/pull/28662 | 2,211,379,020 | PR_kwDOAJy2Ks5q9WpO | 28,662 | Make ART Concurrent if Legacy Mode is disabled | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 48ec17b865f439754fcdaa289ef0aa98f15a05c2...3e3589f69bf8ed6124ad1831e011b2fccddde2be\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-27 17:31:08 | 2024-04-02 19:00:30 | 2024-04-02 19:00:30 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28662', 'html_url': 'https://github.com/facebook/react/pull/28662', 'diff_url': 'https://github.com/facebook/react/pull/28662.diff', 'patch_url': 'https://github.com/facebook/react/pull/28662.patch', 'merged_at': datetime.datetime(2024, 4, 2, 19, 0, 30)} | Pulling this out of #28657.
This runs react-art in concurrent mode if disableLegacyMode is true. Effectively this means that the OSS version will be in concurrent mode and the `.modern.js` version for Meta will be in concurrent mode, once the flag flips for modern, but the `.classic.js` version for Meta will be in l... | {'url': 'https://api.github.com/repos/facebook/react/issues/28662/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28662/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28661 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28661/labels{/name} | https://api.github.com/repos/facebook/react/issues/28661/comments | https://api.github.com/repos/facebook/react/issues/28661/events | https://github.com/facebook/react/pull/28661 | 2,210,900,290 | PR_kwDOAJy2Ks5q7viB | 28,661 | Update index.js | {'login': 'canshn8', 'id': 99124310, 'node_id': 'U_kgDOBeiEVg', 'avatar_url': 'https://avatars.githubusercontent.com/u/99124310?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/canshn8', 'html_url': 'https://github.com/canshn8', 'followers_url': 'https://api.github.com/users/canshn8/followers', 'following_... | [] | closed | false | null | [] | null | [
"Hi @canshn8! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for u... | 2024-03-27 14:05:21 | 2024-03-27 14:10:17 | 2024-03-27 14:07:19 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28661', 'html_url': 'https://github.com/facebook/react/pull/28661', 'diff_url': 'https://github.com/facebook/react/pull/28661.diff', 'patch_url': 'https://github.com/facebook/react/pull/28661.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/28661/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28661/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28660 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28660/labels{/name} | https://api.github.com/repos/facebook/react/issues/28660/comments | https://api.github.com/repos/facebook/react/issues/28660/events | https://github.com/facebook/react/pull/28660 | 2,210,834,244 | PR_kwDOAJy2Ks5q7hMW | 28,660 | Remove orphaned disableJavaScriptURLs reference | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a0537160771bafae90c6fd3154eeead2f2c903e7...a9f8737d36f93be51f08185be64d32eb62e8e6f2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-27 13:38:34 | 2024-03-27 13:53:44 | 2024-03-27 13:53:42 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28660', 'html_url': 'https://github.com/facebook/react/pull/28660', 'diff_url': 'https://github.com/facebook/react/pull/28660.diff', 'patch_url': 'https://github.com/facebook/react/pull/28660.patch', 'merged_at': datetime.datetime(2024, 3, 27, 13, 53, 42)} | Was removed in https://github.com/facebook/react/pull/28615 but didn't land cleanly.
Fixes `yarn flow dom-node` on `main`:https://app.circleci.com/jobs/github/facebook/react/813807
| {'url': 'https://api.github.com/repos/facebook/react/issues/28660/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28660/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28659 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28659/labels{/name} | https://api.github.com/repos/facebook/react/issues/28659/comments | https://api.github.com/repos/facebook/react/issues/28659/events | https://github.com/facebook/react/issues/28659 | 2,210,177,817 | I_kwDOAJy2Ks6DvKMZ | 28,659 | Bug: Expected a suspended thenable. | {'login': 'andreisocaciu', 'id': 15923667, 'node_id': 'MDQ6VXNlcjE1OTIzNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/15923667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/andreisocaciu', 'html_url': 'https://github.com/andreisocaciu', 'followers_url': 'https://api.github.com/users/andre... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [
"can you provide some code reproduction?"
] | 2024-03-27 08:35:25 | 2024-03-31 16:07:27 | null | NONE | null | null | null | I was working in a NextJS app router (in a React Server Component), and I get this error:
```
⨯ Error: Expected a suspended thenable. This is a bug in React. Please file an issue.
at stringify (<anonymous>)
⨯ Error: Expected a suspended thenable. This is a bug in React. Please file an issue.
at stringify... | {'url': 'https://api.github.com/repos/facebook/react/issues/28659/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 1, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28659/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28658 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28658/labels{/name} | https://api.github.com/repos/facebook/react/issues/28658/comments | https://api.github.com/repos/facebook/react/issues/28658/events | https://github.com/facebook/react/issues/28658 | 2,210,006,797 | I_kwDOAJy2Ks6DugcN | 28,658 | Bug: [PPR] Resume failed when "moduleLoading === undefined" in function prepareDestinationWithChunks | {'login': 'gaoachao', 'id': 91231822, 'node_id': 'MDQ6VXNlcjkxMjMxODIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/91231822?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaoachao', 'html_url': 'https://github.com/gaoachao', 'followers_url': 'https://api.github.com/users/gaoachao/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [] | 2024-03-27 06:48:48 | 2024-03-27 07:31:19 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
experimental
## Steps To Reproduce
```tsx
const serverRespons... | {'url': 'https://api.github.com/repos/facebook/react/issues/28658/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28658/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28657 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28657/labels{/name} | https://api.github.com/repos/facebook/react/issues/28657/comments | https://api.github.com/repos/facebook/react/issues/28657/events | https://github.com/facebook/react/pull/28657 | 2,209,886,759 | PR_kwDOAJy2Ks5q4SgL | 28,657 | Use the disableLegacyMode where ever we check the ConcurrentMode mode | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5998a775194f491afa5d3badd9afe9ceaf12845e...2e729cc9876650f070bb6c9b33b504cffba995cc\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-27 05:20:13 | 2024-04-03 01:07:29 | 2024-04-03 01:07:28 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28657', 'html_url': 'https://github.com/facebook/react/pull/28657', 'diff_url': 'https://github.com/facebook/react/pull/28657.diff', 'patch_url': 'https://github.com/facebook/react/pull/28657.patch', 'merged_at': datetime.datetime(2024, 4, 3, 1, 7, 28)} | Saves some bytes and ensures that we're actually disabling it.
Turns out this flag wasn't disabling React Native/Fabric, React Noop and React ART legacy modes so those are updated too.
Should be rebased on #28681. | {'url': 'https://api.github.com/repos/facebook/react/issues/28657/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28657/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28656 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28656/labels{/name} | https://api.github.com/repos/facebook/react/issues/28656/comments | https://api.github.com/repos/facebook/react/issues/28656/events | https://github.com/facebook/react/pull/28656 | 2,209,863,814 | PR_kwDOAJy2Ks5q4Ncx | 28,656 | Move ReactDOMLegacy implementation into RootFB | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"@sebmarkbage the underlying landed",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5de8703646cdd3838cb1686f761b10c0692743aa...12ab8d6c121c0fa2a9eb00673f6509c651fbe495\n\n## Critical size changes\n\nIncludes critical production bundles, as ... | 2024-03-27 05:02:36 | 2024-04-03 01:56:23 | 2024-04-03 01:56:23 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28656', 'html_url': 'https://github.com/facebook/react/pull/28656', 'diff_url': 'https://github.com/facebook/react/pull/28656.diff', 'patch_url': 'https://github.com/facebook/react/pull/28656.patch', 'merged_at': datetime.datetime(2024, 4, 3, 1, 56, 23)} | Only the FB entry point has legacy mode now so we can move the remaining code in there.
Also enable disableLegacyMode in modern www builds since it doesn't expose those entry points.
Now dependent on #28709. | {'url': 'https://api.github.com/repos/facebook/react/issues/28656/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28656/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28655 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28655/labels{/name} | https://api.github.com/repos/facebook/react/issues/28655/comments | https://api.github.com/repos/facebook/react/issues/28655/events | https://github.com/facebook/react/pull/28655 | 2,209,670,095 | PR_kwDOAJy2Ks5q3jR8 | 28,655 | Add Flag to Favor Hydration Performance over User Safety | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2ec2aaea98588178525f83495669e11e96815a00...b41df972adbcff852d94604909a1fb1b4975f808\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-27 02:08:40 | 2024-03-29 22:01:22 | 2024-03-27 02:52:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28655', 'html_url': 'https://github.com/facebook/react/pull/28655', 'diff_url': 'https://github.com/facebook/react/pull/28655.diff', 'patch_url': 'https://github.com/facebook/react/pull/28655.patch', 'merged_at': datetime.datetime(2024, 3, 27, 2, 52, 47)} | If false, this ignores text comparison checks during hydration at the risk of privacy safety.
Since React 18 we recreate the DOM starting from the nearest Suspense boundary if any of the text content mismatches. This ensures that if we have nodes that otherwise line up correctly such as if they're the same type of C... | {'url': 'https://api.github.com/repos/facebook/react/issues/28655/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28655/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28654 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28654/labels{/name} | https://api.github.com/repos/facebook/react/issues/28654/comments | https://api.github.com/repos/facebook/react/issues/28654/events | https://github.com/facebook/react/pull/28654 | 2,209,617,137 | PR_kwDOAJy2Ks5q3YJR | 28,654 | Support suppressHydrationWarning for element-ish text | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This isn't rebased and it doesn't cover all cases but I think since this is basically just the same as enabling it everywhere, this is probably safer/easier: #28655",
"Yeah your PR is better"
] | 2024-03-27 01:07:17 | 2024-03-27 02:26:26 | 2024-03-27 02:26:26 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28654', 'html_url': 'https://github.com/facebook/react/pull/28654', 'diff_url': 'https://github.com/facebook/react/pull/28654.diff', 'patch_url': 'https://github.com/facebook/react/pull/28654.patch', 'merged_at': None} | This would allow setting `suppressHydrationWarning` on element-ish text nodes:
```js
const obj = {
$$typeof: Symbol.for('react.element'),
type: props => props.content,
ref: null,
key: null,
props: {
suppressHydrationWarning: true,
content: isClient ? 'Client Text' : 'Server Text',
},
... | {'url': 'https://api.github.com/repos/facebook/react/issues/28654/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28654/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28653 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28653/labels{/name} | https://api.github.com/repos/facebook/react/issues/28653/comments | https://api.github.com/repos/facebook/react/issues/28653/events | https://github.com/facebook/react/pull/28653 | 2,209,531,438 | PR_kwDOAJy2Ks5q3Fgq | 28,653 | Back out #28476 and #28458 | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4b8dfd6215bf855402ae1a94cb0ae4f467afca9a...0f3b7771a960c8c239a642cf1279969d3b47f7ae\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-26 23:38:17 | 2024-03-28 16:53:10 | 2024-03-28 16:53:07 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28653', 'html_url': 'https://github.com/facebook/react/pull/28653', 'diff_url': 'https://github.com/facebook/react/pull/28653.diff', 'patch_url': 'https://github.com/facebook/react/pull/28653.patch', 'merged_at': None} | www had to revert the flag. We might need to wait on this until that is sorted out.
Back out "Move Hydration Warnings from the DOM Config into the Fiber reconciliation (#28476)"
Original commit changeset: 4b8dfd6215bf
Back out "Remove enableClientRenderFallbackOnTextMismatch flag (#28458)"
Original commit chang... | {'url': 'https://api.github.com/repos/facebook/react/issues/28653/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28653/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28652 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28652/labels{/name} | https://api.github.com/repos/facebook/react/issues/28652/comments | https://api.github.com/repos/facebook/react/issues/28652/events | https://github.com/facebook/react/pull/28652 | 2,209,299,773 | PR_kwDOAJy2Ks5q2SHo | 28,652 | Update error messages | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1a6d36b1a3ec43cb5700e28d7315b3aa2822365d...42dfd6b5803f0491fcdf1e6433ec23eb8ad7c1c3\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-26 20:49:10 | 2024-03-26 21:25:57 | 2024-03-26 21:25:53 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28652', 'html_url': 'https://github.com/facebook/react/pull/28652', 'diff_url': 'https://github.com/facebook/react/pull/28652.diff', 'patch_url': 'https://github.com/facebook/react/pull/28652.patch', 'merged_at': datetime.datetime(2024, 3, 26, 21, 25, 53)} | ## Overview
The error messages that say:
> ReactDOM.hydrate is no longer supported in React 18
Don't make sense in the React 19 release. Instead, they should say:
> ReactDOM.hydrate was removed in React 19.
For legacy mode, they should say:
> ReactDOM.hydrate has not been supported since React 18. | {'url': 'https://api.github.com/repos/facebook/react/issues/28652/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28652/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28651 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28651/labels{/name} | https://api.github.com/repos/facebook/react/issues/28651/comments | https://api.github.com/repos/facebook/react/issues/28651/events | https://github.com/facebook/react/issues/28651 | 2,209,242,409 | I_kwDOAJy2Ks6Drl0p | 28,651 | Bug: script element not suspending in canary | {'login': 'davecardwell', 'id': 7639, 'node_id': 'MDQ6VXNlcjc2Mzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7639?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/davecardwell', 'html_url': 'https://github.com/davecardwell', 'followers_url': 'https://api.github.com/users/davecardwell/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [] | 2024-03-26 20:23:57 | 2024-03-26 20:23:57 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: `18.3.0-canary-c3048aab4-20240326`
> If you supply an `src` an... | {'url': 'https://api.github.com/repos/facebook/react/issues/28651/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28651/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28650 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28650/labels{/name} | https://api.github.com/repos/facebook/react/issues/28650/comments | https://api.github.com/repos/facebook/react/issues/28650/events | https://github.com/facebook/react/pull/28650 | 2,209,210,343 | PR_kwDOAJy2Ks5q19-b | 28,650 | Remove unmountComponentAtNode outside of legacy mode | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 56efb2e2271492288b1ba37c247df2a65d9046b7...c7a93d84fc88ef131c1186e8e147478c92c68ece\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-26 20:05:36 | 2024-03-26 20:49:43 | 2024-03-26 20:32:43 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28650', 'html_url': 'https://github.com/facebook/react/pull/28650', 'diff_url': 'https://github.com/facebook/react/pull/28650.diff', 'patch_url': 'https://github.com/facebook/react/pull/28650.patch', 'merged_at': datetime.datetime(2024, 3, 26, 20, 32, 43)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/28650/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28650/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28649 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28649/labels{/name} | https://api.github.com/repos/facebook/react/issues/28649/comments | https://api.github.com/repos/facebook/react/issues/28649/events | https://github.com/facebook/react/pull/28649 | 2,209,152,336 | PR_kwDOAJy2Ks5q1xWL | 28,649 | Bump express from 4.18.2 to 4.19.2 | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 56efb2e2271492288b1ba37c247df2a65d9046b7...a5a782a69358b60fa26b6985d77ab57acde8bef9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-26 19:34:01 | 2024-03-26 19:51:14 | 2024-03-26 19:51:05 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28649', 'html_url': 'https://github.com/facebook/react/pull/28649', 'diff_url': 'https://github.com/facebook/react/pull/28649.diff', 'patch_url': 'https://github.com/facebook/react/pull/28649.patch', 'merged_at': None} | Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/expressjs/express/releases">express's releases</a>.</em></p>
<blockquote>
<h2>4.19.2</h2>
<h2>What's Changed</h2>
<ul>
<li><a href="https://github.com/e... | {'url': 'https://api.github.com/repos/facebook/react/issues/28649/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28649/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28648 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28648/labels{/name} | https://api.github.com/repos/facebook/react/issues/28648/comments | https://api.github.com/repos/facebook/react/issues/28648/events | https://github.com/facebook/react/pull/28648 | 2,209,151,623 | PR_kwDOAJy2Ks5q1xMN | 28,648 | Bump express from 4.17.1 to 4.19.2 in /fixtures/concurrent/time-slicing | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 56efb2e2271492288b1ba37c247df2a65d9046b7...63484a3b04e21c0bd3333757cccf0d47ec799102\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-26 19:33:33 | 2024-03-26 19:51:14 | 2024-03-26 19:51:05 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28648', 'html_url': 'https://github.com/facebook/react/pull/28648', 'diff_url': 'https://github.com/facebook/react/pull/28648.diff', 'patch_url': 'https://github.com/facebook/react/pull/28648.patch', 'merged_at': None} | Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.19.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/expressjs/express/releases">express's releases</a>.</em></p>
<blockquote>
<h2>4.19.2</h2>
<h2>What's Changed</h2>
<ul>
<li><a href="https://github.com/e... | {'url': 'https://api.github.com/repos/facebook/react/issues/28648/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28648/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28647 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28647/labels{/name} | https://api.github.com/repos/facebook/react/issues/28647/comments | https://api.github.com/repos/facebook/react/issues/28647/events | https://github.com/facebook/react/pull/28647 | 2,209,048,829 | PR_kwDOAJy2Ks5q1aTf | 28,647 | Enable feature flags for v19 | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: dc545c8d6eaca87c8d5cabfab6e1c768ecafe426...891485c0b419412245031ea009ce517701951c67\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-26 18:45:58 | 2024-04-03 03:33:14 | 2024-04-03 03:33:14 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28647', 'html_url': 'https://github.com/facebook/react/pull/28647', 'diff_url': 'https://github.com/facebook/react/pull/28647.diff', 'patch_url': 'https://github.com/facebook/react/pull/28647.patch', 'merged_at': datetime.datetime(2024, 4, 3, 3, 33, 14)} | The canary channel now represents v19, so we can turn these flags on. | {'url': 'https://api.github.com/repos/facebook/react/issues/28647/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28647/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28646 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28646/labels{/name} | https://api.github.com/repos/facebook/react/issues/28646/comments | https://api.github.com/repos/facebook/react/issues/28646/events | https://github.com/facebook/react/pull/28646 | 2,209,017,831 | PR_kwDOAJy2Ks5q1Tc1 | 28,646 | Bump canary versions to v19-canary | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"itshappening\r\n\r\n",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 738993da0b32508e275627d60ace58d972af464b...be087de49be381fe63897be8358a8fd765a0b718\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any ch... | 2024-03-26 18:32:47 | 2024-03-26 19:31:58 | 2024-03-26 19:31:58 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28646', 'html_url': 'https://github.com/facebook/react/pull/28646', 'diff_url': 'https://github.com/facebook/react/pull/28646.diff', 'patch_url': 'https://github.com/facebook/react/pull/28646.patch', 'merged_at': datetime.datetime(2024, 3, 26, 19, 31, 58)} | This bumps the canary versions to v19 to communicate that the next release will be a major. Once this lands, we can start merging breaking changes into `main`. | {'url': 'https://api.github.com/repos/facebook/react/issues/28646/reactions', 'total_count': 4, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 4, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28646/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28645 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28645/labels{/name} | https://api.github.com/repos/facebook/react/issues/28645/comments | https://api.github.com/repos/facebook/react/issues/28645/events | https://github.com/facebook/react/pull/28645 | 2,208,879,048 | PR_kwDOAJy2Ks5q01Cl | 28,645 | Turn on enableRenderableContext in experimental | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 95319ab5afd384f5858f7c080573b9736e6b2f9c...e329067410ad36562aaa522018c01a1ef3f601e9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-26 17:29:59 | 2024-03-26 18:17:48 | 2024-03-26 18:17:44 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28645', 'html_url': 'https://github.com/facebook/react/pull/28645', 'diff_url': 'https://github.com/facebook/react/pull/28645.diff', 'patch_url': 'https://github.com/facebook/react/pull/28645.patch', 'merged_at': datetime.datetime(2024, 3, 26, 18, 17, 44)} | Let's get this into experimental to get more usage and allow other renderers to test against the changes easier. | {'url': 'https://api.github.com/repos/facebook/react/issues/28645/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28645/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28644 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28644/labels{/name} | https://api.github.com/repos/facebook/react/issues/28644/comments | https://api.github.com/repos/facebook/react/issues/28644/events | https://github.com/facebook/react/pull/28644 | 2,208,784,937 | PR_kwDOAJy2Ks5q0gW1 | 28,644 | Replace 'var' with 'let' or 'const' for Scheduler.js | {'login': 'shaojie-li', 'id': 10344966, 'node_id': 'MDQ6VXNlcjEwMzQ0OTY2', 'avatar_url': 'https://avatars.githubusercontent.com/u/10344966?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shaojie-li', 'html_url': 'https://github.com/shaojie-li', 'followers_url': 'https://api.github.com/users/shaojie-li/fol... | [] | closed | false | null | [] | null | [
"Hi @shaojie-li! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order fo... | 2024-03-26 16:50:04 | 2024-03-26 16:55:14 | 2024-03-26 16:52:41 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28644', 'html_url': 'https://github.com/facebook/react/pull/28644', 'diff_url': 'https://github.com/facebook/react/pull/28644.diff', 'patch_url': 'https://github.com/facebook/react/pull/28644.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/28644/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28644/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28643 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28643/labels{/name} | https://api.github.com/repos/facebook/react/issues/28643/comments | https://api.github.com/repos/facebook/react/issues/28643/events | https://github.com/facebook/react/pull/28643 | 2,208,530,032 | PR_kwDOAJy2Ks5qznup | 28,643 | Fix tests on main | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Looks like there's still an undefined variable here:\r\n\r\n```\r\n/home/circleci/project/packages/react-reconciler/src/__tests__/ReactSuspense-test.internal.js\r\n 317:18 error 'ReactTestRenderer' is not defined no-undef\r\n```",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: d... | 2024-03-26 15:09:18 | 2024-03-26 15:26:45 | 2024-03-26 15:26:42 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28643', 'html_url': 'https://github.com/facebook/react/pull/28643', 'diff_url': 'https://github.com/facebook/react/pull/28643.diff', 'patch_url': 'https://github.com/facebook/react/pull/28643.patch', 'merged_at': datetime.datetime(2024, 3, 26, 15, 26, 42)} | Not sure how these broke when merging https://github.com/facebook/react/pull/28299 and https://github.com/facebook/react/pull/28361 | {'url': 'https://api.github.com/repos/facebook/react/issues/28643/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28643/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28642 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28642/labels{/name} | https://api.github.com/repos/facebook/react/issues/28642/comments | https://api.github.com/repos/facebook/react/issues/28642/events | https://github.com/facebook/react/pull/28642 | 2,207,928,790 | PR_kwDOAJy2Ks5qxi5M | 28,642 | Bump express from 4.17.1 to 4.19.2 in /fixtures/dom | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: c3048aab4c3346dca90ab0052a89fdb48450570f...fa8289653cff41e7b4c5e5a6dd7c787de2fb6a0a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-26 11:02:34 | 2024-03-26 19:51:13 | 2024-03-26 19:51:04 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28642', 'html_url': 'https://github.com/facebook/react/pull/28642', 'diff_url': 'https://github.com/facebook/react/pull/28642.diff', 'patch_url': 'https://github.com/facebook/react/pull/28642.patch', 'merged_at': None} | Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.19.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/expressjs/express/releases">express's releases</a>.</em></p>
<blockquote>
<h2>4.19.2</h2>
<h2>What's Changed</h2>
<ul>
<li><a href="https://github.com/e... | {'url': 'https://api.github.com/repos/facebook/react/issues/28642/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28642/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28641 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28641/labels{/name} | https://api.github.com/repos/facebook/react/issues/28641/comments | https://api.github.com/repos/facebook/react/issues/28641/events | https://github.com/facebook/react/pull/28641 | 2,207,209,461 | PR_kwDOAJy2Ks5qvEAj | 28,641 | Make onUncaughtError and onCaughtError Configurable | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6786563f3cbbc9b16d5a8187207b5bd904386e53...14edf65e637f9e434e8005fc08acdf49f55ddb75\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-26 04:18:46 | 2024-03-27 04:51:37 | 2024-03-27 04:51:37 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28641', 'html_url': 'https://github.com/facebook/react/pull/28641', 'diff_url': 'https://github.com/facebook/react/pull/28641.diff', 'patch_url': 'https://github.com/facebook/react/pull/28641.patch', 'merged_at': datetime.datetime(2024, 3, 27, 4, 51, 37)} | Stacked on #28627.
This makes error logging configurable using these `createRoot`/`hydrateRoot` options:
```
onUncaughtError(error: mixed, errorInfo: {componentStack?: ?string}) => void
onCaughtError(error: mixed, errorInfo: {componentStack?: ?string, errorBoundary?: ?React.Component<any, any>}) => void
onReco... | {'url': 'https://api.github.com/repos/facebook/react/issues/28641/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 3, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28641/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28640 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28640/labels{/name} | https://api.github.com/repos/facebook/react/issues/28640/comments | https://api.github.com/repos/facebook/react/issues/28640/events | https://github.com/facebook/react/pull/28640 | 2,206,972,103 | PR_kwDOAJy2Ks5quRGV | 28,640 | Bump express from 4.16.2 to 4.19.2 in /fixtures/packaging/brunch/dev | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: c3048aab4c3346dca90ab0052a89fdb48450570f...24e8202800f2f9543d8b367ec962985e5428bc69\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-26 00:19:32 | 2024-03-26 19:51:12 | 2024-03-26 19:51:04 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28640', 'html_url': 'https://github.com/facebook/react/pull/28640', 'diff_url': 'https://github.com/facebook/react/pull/28640.diff', 'patch_url': 'https://github.com/facebook/react/pull/28640.patch', 'merged_at': None} | Bumps [express](https://github.com/expressjs/express) from 4.16.2 to 4.19.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/expressjs/express/releases">express's releases</a>.</em></p>
<blockquote>
<h2>4.19.2</h2>
<h2>What's Changed</h2>
<ul>
<li><a href="https://github.com/e... | {'url': 'https://api.github.com/repos/facebook/react/issues/28640/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28640/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28639 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28639/labels{/name} | https://api.github.com/repos/facebook/react/issues/28639/comments | https://api.github.com/repos/facebook/react/issues/28639/events | https://github.com/facebook/react/pull/28639 | 2,206,954,138 | PR_kwDOAJy2Ks5quNUk | 28,639 | Cleanup `alwaysThrottleDisappearingFallbacks` Flag | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5a75f9e78544fa6d052aff7fe99607e48f35b979...4d3e93560b132e311b7f411a2a83a2e8e7e335eb\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-25 23:59:16 | 2024-03-26 17:01:43 | 2024-03-26 17:01:38 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28639', 'html_url': 'https://github.com/facebook/react/pull/28639', 'diff_url': 'https://github.com/facebook/react/pull/28639.diff', 'patch_url': 'https://github.com/facebook/react/pull/28639.patch', 'merged_at': datetime.datetime(2024, 3, 26, 17, 1, 38)} | ## Summary
After realizing that this feature flag is entangled with `alwaysThrottleRetries`, we're going to undo https://github.com/facebook/react/pull/28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/28639/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28639/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28638 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28638/labels{/name} | https://api.github.com/repos/facebook/react/issues/28638/comments | https://api.github.com/repos/facebook/react/issues/28638/events | https://github.com/facebook/react/pull/28638 | 2,206,934,436 | PR_kwDOAJy2Ks5quJIo | 28,638 | Bump express from 4.16.2 to 4.19.2 in /fixtures/expiration | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5a75f9e78544fa6d052aff7fe99607e48f35b979...ffe1c5dcf35f17f69f62078ef6d52b40a8fa8868\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-25 23:38:11 | 2024-03-26 19:51:11 | 2024-03-26 19:51:03 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28638', 'html_url': 'https://github.com/facebook/react/pull/28638', 'diff_url': 'https://github.com/facebook/react/pull/28638.diff', 'patch_url': 'https://github.com/facebook/react/pull/28638.patch', 'merged_at': None} | Bumps [express](https://github.com/expressjs/express) from 4.16.2 to 4.19.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/expressjs/express/releases">express's releases</a>.</em></p>
<blockquote>
<h2>4.19.2</h2>
<h2>What's Changed</h2>
<ul>
<li><a href="https://github.com/e... | {'url': 'https://api.github.com/repos/facebook/react/issues/28638/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28638/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28637 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28637/labels{/name} | https://api.github.com/repos/facebook/react/issues/28637/comments | https://api.github.com/repos/facebook/react/issues/28637/events | https://github.com/facebook/react/pull/28637 | 2,206,934,269 | PR_kwDOAJy2Ks5quJGN | 28,637 | Bump express from 4.16.2 to 4.19.2 in /fixtures/packaging/brunch/prod | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5a75f9e78544fa6d052aff7fe99607e48f35b979...3115b1a1f8a62340a376027b8d15152dd9325c08\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-25 23:37:59 | 2024-03-26 19:51:11 | 2024-03-26 19:51:02 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28637', 'html_url': 'https://github.com/facebook/react/pull/28637', 'diff_url': 'https://github.com/facebook/react/pull/28637.diff', 'patch_url': 'https://github.com/facebook/react/pull/28637.patch', 'merged_at': None} | Bumps [express](https://github.com/expressjs/express) from 4.16.2 to 4.19.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/expressjs/express/releases">express's releases</a>.</em></p>
<blockquote>
<h2>4.19.2</h2>
<h2>What's Changed</h2>
<ul>
<li><a href="https://github.com/e... | {'url': 'https://api.github.com/repos/facebook/react/issues/28637/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28637/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28636 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28636/labels{/name} | https://api.github.com/repos/facebook/react/issues/28636/comments | https://api.github.com/repos/facebook/react/issues/28636/events | https://github.com/facebook/react/pull/28636 | 2,206,782,833 | PR_kwDOAJy2Ks5qto2i | 28,636 | Bump express from 4.15.4 to 4.19.2 in /fixtures/attribute-behavior | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5a75f9e78544fa6d052aff7fe99607e48f35b979...f42291f6a4eb0207458206a87da433fadc826854\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-25 21:49:30 | 2024-03-26 19:51:10 | 2024-03-26 19:51:02 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28636', 'html_url': 'https://github.com/facebook/react/pull/28636', 'diff_url': 'https://github.com/facebook/react/pull/28636.diff', 'patch_url': 'https://github.com/facebook/react/pull/28636.patch', 'merged_at': None} | Bumps [express](https://github.com/expressjs/express) from 4.15.4 to 4.19.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/expressjs/express/releases">express's releases</a>.</em></p>
<blockquote>
<h2>4.19.2</h2>
<h2>What's Changed</h2>
<ul>
<li><a href="https://github.com/e... | {'url': 'https://api.github.com/repos/facebook/react/issues/28636/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28636/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28635 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28635/labels{/name} | https://api.github.com/repos/facebook/react/issues/28635/comments | https://api.github.com/repos/facebook/react/issues/28635/events | https://github.com/facebook/react/pull/28635 | 2,206,739,329 | PR_kwDOAJy2Ks5qtfVa | 28,635 | Add support for preload media to ReactDOM | {'login': 'mariusc23', 'id': 465310, 'node_id': 'MDQ6VXNlcjQ2NTMxMA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/465310?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mariusc23', 'html_url': 'https://github.com/mariusc23', 'followers_url': 'https://api.github.com/users/mariusc23/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5a75f9e78544fa6d052aff7fe99607e48f35b979...281a48c7e8db3d0cf1546f4eef5868fa8a36e255\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-25 21:18:15 | 2024-03-28 17:04:59 | 2024-03-28 17:04:59 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28635', 'html_url': 'https://github.com/facebook/react/pull/28635', 'diff_url': 'https://github.com/facebook/react/pull/28635.diff', 'patch_url': 'https://github.com/facebook/react/pull/28635.patch', 'merged_at': datetime.datetime(2024, 3, 28, 17, 4, 59)} | ## Summary
This PR adds support for `media` option to `ReactDOM.preload()`, which is needed when images differ between screen sizes (for example mobile vs desktop).
Tests copied from https://github.com/facebook/react/pull/27129 (thanks @damnsamn!)
## How did you test this change?
Ran the tests from https://... | {'url': 'https://api.github.com/repos/facebook/react/issues/28635/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28635/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28634 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28634/labels{/name} | https://api.github.com/repos/facebook/react/issues/28634/comments | https://api.github.com/repos/facebook/react/issues/28634/events | https://github.com/facebook/react/pull/28634 | 2,206,716,490 | PR_kwDOAJy2Ks5qtaUz | 28,634 | Bump express from 4.14.0 to 4.19.2 in /fixtures/fiber-debugger | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5a75f9e78544fa6d052aff7fe99607e48f35b979...1178c5943673b493b811cff380475407e6b01860\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-25 21:04:29 | 2024-03-26 19:51:10 | 2024-03-26 19:51:01 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28634', 'html_url': 'https://github.com/facebook/react/pull/28634', 'diff_url': 'https://github.com/facebook/react/pull/28634.diff', 'patch_url': 'https://github.com/facebook/react/pull/28634.patch', 'merged_at': None} | Bumps [express](https://github.com/expressjs/express) from 4.14.0 to 4.19.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/expressjs/express/releases">express's releases</a>.</em></p>
<blockquote>
<h2>4.19.2</h2>
<h2>What's Changed</h2>
<ul>
<li><a href="https://github.com/e... | {'url': 'https://api.github.com/repos/facebook/react/issues/28634/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28634/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28633 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28633/labels{/name} | https://api.github.com/repos/facebook/react/issues/28633/comments | https://api.github.com/repos/facebook/react/issues/28633/events | https://github.com/facebook/react/pull/28633 | 2,206,612,788 | PR_kwDOAJy2Ks5qtEfR | 28,633 | Switch facebook-www build version to file content hash | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5a75f9e78544fa6d052aff7fe99607e48f35b979...16889431988e24ce27bb7797e6cb311be20c7cc9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-25 20:12:10 | 2024-03-26 16:13:50 | 2024-03-26 16:13:46 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28633', 'html_url': 'https://github.com/facebook/react/pull/28633', 'diff_url': 'https://github.com/facebook/react/pull/28633.diff', 'patch_url': 'https://github.com/facebook/react/pull/28633.patch', 'merged_at': datetime.datetime(2024, 3, 26, 16, 13, 46)} | Unifies the React version string pattern with RN just to simplify the build script a tiny bit and not have 2 mechanisms for the Meta-internal build. | {'url': 'https://api.github.com/repos/facebook/react/issues/28633/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28633/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28632 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28632/labels{/name} | https://api.github.com/repos/facebook/react/issues/28632/comments | https://api.github.com/repos/facebook/react/issues/28632/events | https://github.com/facebook/react/pull/28632 | 2,206,508,381 | PR_kwDOAJy2Ks5qstQY | 28,632 | Add useActionState to CHANGELOG-canary.md | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5a75f9e78544fa6d052aff7fe99607e48f35b979...4b0a58dbdccb85de0c85525fcb68a35ae5e929e6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-25 19:18:09 | 2024-03-26 17:15:13 | 2024-03-26 17:15:08 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28632', 'html_url': 'https://github.com/facebook/react/pull/28632', 'diff_url': 'https://github.com/facebook/react/pull/28632.diff', 'patch_url': 'https://github.com/facebook/react/pull/28632.patch', 'merged_at': datetime.datetime(2024, 3, 26, 17, 15, 8)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/28632/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28632/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28631 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28631/labels{/name} | https://api.github.com/repos/facebook/react/issues/28631/comments | https://api.github.com/repos/facebook/react/issues/28631/events | https://github.com/facebook/react/pull/28631 | 2,206,493,017 | PR_kwDOAJy2Ks5qsp4u | 28,631 | s/form state/action state | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5a75f9e78544fa6d052aff7fe99607e48f35b979...b2d4c124db1840c921eefcdeeb071588f99c6d03\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-25 19:09:54 | 2024-03-28 15:34:34 | 2024-03-28 15:34:25 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28631', 'html_url': 'https://github.com/facebook/react/pull/28631', 'diff_url': 'https://github.com/facebook/react/pull/28631.diff', 'patch_url': 'https://github.com/facebook/react/pull/28631.patch', 'merged_at': datetime.datetime(2024, 3, 28, 15, 34, 25)} | Rename internals from "form state" to "action state" | {'url': 'https://api.github.com/repos/facebook/react/issues/28631/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28631/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28630 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28630/labels{/name} | https://api.github.com/repos/facebook/react/issues/28630/comments | https://api.github.com/repos/facebook/react/issues/28630/events | https://github.com/facebook/react/pull/28630 | 2,206,412,077 | PR_kwDOAJy2Ks5qsX3b | 28,630 | Fix alwaysThrottleDisappearingFallbacks | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5a75f9e78544fa6d052aff7fe99607e48f35b979...fc72ca90750ff04f98d78230497d4e8b4174ccfd\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-25 18:29:30 | 2024-03-26 16:10:26 | 2024-03-26 16:10:25 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28630', 'html_url': 'https://github.com/facebook/react/pull/28630', 'diff_url': 'https://github.com/facebook/react/pull/28630.diff', 'patch_url': 'https://github.com/facebook/react/pull/28630.patch', 'merged_at': None} | For `alwaysThrottleDisappearingFallbacks`, we need to update the workloop to throttle when the root completes. This fixes the bug found in https://github.com/facebook/react/pull/28629. | {'url': 'https://api.github.com/repos/facebook/react/issues/28630/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28630/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28629 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28629/labels{/name} | https://api.github.com/repos/facebook/react/issues/28629/comments | https://api.github.com/repos/facebook/react/issues/28629/events | https://github.com/facebook/react/pull/28629 | 2,206,392,676 | PR_kwDOAJy2Ks5qsTsr | 28,629 | Fix gating for alwaysThrottleDisappearingFallbacks | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5a75f9e78544fa6d052aff7fe99607e48f35b979...5dbe02c9cffcee699a6ccc05e5204f355bfd5e84\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-25 18:17:37 | 2024-03-26 16:10:31 | 2024-03-26 16:10:31 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28629', 'html_url': 'https://github.com/facebook/react/pull/28629', 'diff_url': 'https://github.com/facebook/react/pull/28629.diff', 'patch_url': 'https://github.com/facebook/react/pull/28629.patch', 'merged_at': None} | If you turn off these flags independently:
- alwaysThrottleDisappearingFallbacks
- alwaysThrottleRetries
You'll see that this behavior only works if both flags are enabled. I updated the flags with the correct gating.
Alternatively, we could fix the behavior: https://github.com/facebook/react/pull/28630 | {'url': 'https://api.github.com/repos/facebook/react/issues/28629/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28629/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28628 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28628/labels{/name} | https://api.github.com/repos/facebook/react/issues/28628/comments | https://api.github.com/repos/facebook/react/issues/28628/events | https://github.com/facebook/react/pull/28628 | 2,206,359,711 | PR_kwDOAJy2Ks5qsMfY | 28,628 | fix[devtools/ci]: split profiling cache test for different react versions and toEqual checker | {'login': 'hoxyq', 'id': 28902667, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2024-03-25 17:58:30 | 2024-03-26 10:55:11 | 2024-03-26 10:55:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28628', 'html_url': 'https://github.com/facebook/react/pull/28628', 'diff_url': 'https://github.com/facebook/react/pull/28628.diff', 'patch_url': 'https://github.com/facebook/react/pull/28628.patch', 'merged_at': datetime.datetime(2024, 3, 26, 10, 55, 7)} | This should fix the failing backwards-compatibility tests on CI:
- https://app.circleci.com/pipelines/github/facebook/react/51347/workflows/9d319db5-7a29-4e9a-a3a0-8d49a24ee9bd/jobs/809381
- https://app.circleci.com/pipelines/github/facebook/react/51347/workflows/9d319db5-7a29-4e9a-a3a0-8d49a24ee9bd/jobs/809386
St... | {'url': 'https://api.github.com/repos/facebook/react/issues/28628/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28628/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28627 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28627/labels{/name} | https://api.github.com/repos/facebook/react/issues/28627/comments | https://api.github.com/repos/facebook/react/issues/28627/events | https://github.com/facebook/react/pull/28627 | 2,206,070,838 | PR_kwDOAJy2Ks5qrM3k | 28,627 | [Fiber] Don't Rethrow Errors at the Root | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5910eb34567a8699d1faa73b546baafd94f26411...0928d917756f4f01e067bfc70e7057ceaf1dc378\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-25 15:43:35 | 2024-03-27 03:44:08 | 2024-03-27 03:44:08 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28627', 'html_url': 'https://github.com/facebook/react/pull/28627', 'diff_url': 'https://github.com/facebook/react/pull/28627.diff', 'patch_url': 'https://github.com/facebook/react/pull/28627.patch', 'merged_at': datetime.datetime(2024, 3, 27, 3, 44, 7)} | Stacked on top of #28498 for test fixes.
### Don't Rethrow
When we started React it was 1:1 setState calls a series of renders and if they error, it errors where the setState was called. Simple. However, then batching came and the error actually got thrown somewhere else. With concurrent mode, it's not even possi... | {'url': 'https://api.github.com/repos/facebook/react/issues/28627/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28627/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28626 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28626/labels{/name} | https://api.github.com/repos/facebook/react/issues/28626/comments | https://api.github.com/repos/facebook/react/issues/28626/events | https://github.com/facebook/react/issues/28626 | 2,205,937,303 | I_kwDOAJy2Ks6De-6X | 28,626 | Bug: Rapid click fails to catch the onClick event properly | {'login': 'qkrdmstlr3', 'id': 26402298, 'node_id': 'MDQ6VXNlcjI2NDAyMjk4', 'avatar_url': 'https://avatars.githubusercontent.com/u/26402298?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/qkrdmstlr3', 'html_url': 'https://github.com/qkrdmstlr3', 'followers_url': 'https://api.github.com/users/qkrdmstlr3/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [] | 2024-03-25 14:47:42 | 2024-03-25 14:47:42 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.2.0
## Steps To Reproduce
1. Open the address attached b... | {'url': 'https://api.github.com/repos/facebook/react/issues/28626/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28626/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28625 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28625/labels{/name} | https://api.github.com/repos/facebook/react/issues/28625/comments | https://api.github.com/repos/facebook/react/issues/28625/events | https://github.com/facebook/react/pull/28625 | 2,204,382,681 | PR_kwDOAJy2Ks5qlfaT | 28,625 | Add Type: Feature Request to stalebot ignore | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f09e1599d631051a559974578a6d4c06effd95eb...ccd0aeb83e77d89811d7c408d4e90275cb0420fe\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-24 14:36:03 | 2024-03-24 16:48:12 | 2024-03-24 16:48:12 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28625', 'html_url': 'https://github.com/facebook/react/pull/28625', 'diff_url': 'https://github.com/facebook/react/pull/28625.diff', 'patch_url': 'https://github.com/facebook/react/pull/28625.patch', 'merged_at': datetime.datetime(2024, 3, 24, 16, 48, 12)} | Prevent issues like https://github.com/facebook/react/issues/12525 from closing due to inactivity. | {'url': 'https://api.github.com/repos/facebook/react/issues/28625/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28625/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28624 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28624/labels{/name} | https://api.github.com/repos/facebook/react/issues/28624/comments | https://api.github.com/repos/facebook/react/issues/28624/events | https://github.com/facebook/react/issues/28624 | 2,204,344,507 | I_kwDOAJy2Ks6DY6C7 | 28,624 | Naming convention | {'login': 'MiloosN5', 'id': 56539570, 'node_id': 'MDQ6VXNlcjU2NTM5NTcw', 'avatar_url': 'https://avatars.githubusercontent.com/u/56539570?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MiloosN5', 'html_url': 'https://github.com/MiloosN5', 'followers_url': 'https://api.github.com/users/MiloosN5/followers',... | [] | closed | false | null | [] | null | [
"Unfortunately, this issue tracker is for reporting bugs in React, and is not a support forum for using React and we don't offer opinions on patterns like naming conventions. We want you to find the answer you're looking for, so we suggest posting one of the Community Forums: https://react.dev/community"
] | 2024-03-24 13:10:32 | 2024-03-24 19:39:40 | 2024-03-24 19:39:40 | NONE | null | null | null | Hello to everyone! I know that naming convention for the React components are not fixed, but I have situation that confuse me. I want my projects to have multiple different buttons. I prefer using BEM naming convention, but I don't know is it good to use for Component naming or just for CSS className? For me, the follo... | {'url': 'https://api.github.com/repos/facebook/react/issues/28624/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28624/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28623 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28623/labels{/name} | https://api.github.com/repos/facebook/react/issues/28623/comments | https://api.github.com/repos/facebook/react/issues/28623/events | https://github.com/facebook/react/pull/28623 | 2,204,227,139 | PR_kwDOAJy2Ks5qlBFo | 28,623 | Update README.md | {'login': 'bharathkumar369', 'id': 138674883, 'node_id': 'U_kgDOCEQCww', 'avatar_url': 'https://avatars.githubusercontent.com/u/138674883?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bharathkumar369', 'html_url': 'https://github.com/bharathkumar369', 'followers_url': 'https://api.github.com/users/bhara... | [] | closed | false | null | [] | null | [
"Hi @bharathkumar369! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn ord... | 2024-03-24 07:40:09 | 2024-03-24 18:25:48 | 2024-03-24 18:25:48 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28623', 'html_url': 'https://github.com/facebook/react/pull/28623', 'diff_url': 'https://github.com/facebook/react/pull/28623.diff', 'patch_url': 'https://github.com/facebook/react/pull/28623.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/28623/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28623/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28622 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28622/labels{/name} | https://api.github.com/repos/facebook/react/issues/28622/comments | https://api.github.com/repos/facebook/react/issues/28622/events | https://github.com/facebook/react/issues/28622 | 2,204,198,721 | I_kwDOAJy2Ks6DYWdB | 28,622 | In react fiber, is didReceiveUpdate related to dirty checking? | {'login': 'Low-ProFiles', 'id': 69390311, 'node_id': 'MDQ6VXNlcjY5MzkwMzEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/69390311?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Low-ProFiles', 'html_url': 'https://github.com/Low-ProFiles', 'followers_url': 'https://api.github.com/users/Low-ProF... | [] | open | false | null | [] | null | [
"The 1st condition directly relates to the usage of dirty checking, but the other two do not. But, they work in the same way after detecting a change. (Change of context in the component or change of the component in total). So, it is not totally related to dirty checking but it uses dirty checking as a small part.... | 2024-03-24 06:12:01 | 2024-05-06 17:54:04 | null | NONE | null | null | null | https://github.com/facebook/react/blob/f09e1599d631051a559974578a6d4c06effd95eb/packages/react-reconciler/src/ReactFiberBeginWork.js#L620
I have some question while looking for ReactFiberBeginWork.js file.
**Is didReceiveUpdate related to dirty checking?**
when ```didReceiveUpdate = true``` called, it has to sat... | {'url': 'https://api.github.com/repos/facebook/react/issues/28622/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28622/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28621 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28621/labels{/name} | https://api.github.com/repos/facebook/react/issues/28621/comments | https://api.github.com/repos/facebook/react/issues/28621/events | https://github.com/facebook/react/pull/28621 | 2,203,972,473 | PR_kwDOAJy2Ks5qkOXR | 28,621 | Bump webpack-dev-middleware from 5.3.3 to 5.3.4 | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 527ed72bfd9f5c0045da468ad01db968a9961ad7...0f47e5700f9f79d2adb03d302a74257e305a1daa\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-23 17:29:01 | 2024-03-25 17:36:10 | 2024-03-25 17:36:03 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28621', 'html_url': 'https://github.com/facebook/react/pull/28621', 'diff_url': 'https://github.com/facebook/react/pull/28621.diff', 'patch_url': 'https://github.com/facebook/react/pull/28621.patch', 'merged_at': datetime.datetime(2024, 3, 25, 17, 36, 3)} | Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/webpack/webpack-dev-middleware/releases">webpack-dev-middleware's releases</a>.</em></p>
<blockquote>
<h2>v5.3.4</h2>
<h3><a h... | {'url': 'https://api.github.com/repos/facebook/react/issues/28621/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28621/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28620 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28620/labels{/name} | https://api.github.com/repos/facebook/react/issues/28620/comments | https://api.github.com/repos/facebook/react/issues/28620/events | https://github.com/facebook/react/pull/28620 | 2,203,952,862 | PR_kwDOAJy2Ks5qkKb7 | 28,620 | [Flight] Use lazy ID if referenced model chunk was not emitted yet | {'login': 'unstubbable', 'id': 761683, 'node_id': 'MDQ6VXNlcjc2MTY4Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/761683?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/unstubbable', 'html_url': 'https://github.com/unstubbable', 'followers_url': 'https://api.github.com/users/unstubbable/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f09e1599d631051a559974578a6d4c06effd95eb...3b41b85c5de0f23b205c765a485a4f8d8266083b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-23 16:35:42 | 2024-04-02 08:13:25 | 2024-04-02 08:13:22 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28620', 'html_url': 'https://github.com/facebook/react/pull/28620', 'diff_url': 'https://github.com/facebook/react/pull/28620.diff', 'patch_url': 'https://github.com/facebook/react/pull/28620.patch', 'merged_at': None} | ## Summary
With this change, we keep track of emitted model chunk IDs. This allows us to properly decide whether to use a value ID or a lazy ID for a referenced model.
fixes #28595
## How did you test this change?
- `yarn test -r=stable packages/react-server-dom-webpack/src/__tests__/ReactFlightDOM-test.js`... | {'url': 'https://api.github.com/repos/facebook/react/issues/28620/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28620/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28619 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28619/labels{/name} | https://api.github.com/repos/facebook/react/issues/28619/comments | https://api.github.com/repos/facebook/react/issues/28619/events | https://github.com/facebook/react/issues/28619 | 2,203,928,620 | I_kwDOAJy2Ks6DXUgs | 28,619 | custom use directives + using closure serializer | {'login': 'harrysolovay', 'id': 4893548, 'node_id': 'MDQ6VXNlcjQ4OTM1NDg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4893548?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/harrysolovay', 'html_url': 'https://github.com/harrysolovay', 'followers_url': 'https://api.github.com/users/harrysolov... | [] | open | false | null | [] | null | [] | 2024-03-23 15:33:51 | 2024-03-23 15:33:51 | null | NONE | null | null | null | I'd like guidance around reusing the (canary) compiler's closure serializer. It seems the "use [env]" directive approach could work well for a wide range of multi-env use cases. I'm not sure if the React team's intention is to make this pluggable / if there's a good approach to patching it today... but any guidance wou... | {'url': 'https://api.github.com/repos/facebook/react/issues/28619/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28619/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28618 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28618/labels{/name} | https://api.github.com/repos/facebook/react/issues/28618/comments | https://api.github.com/repos/facebook/react/issues/28618/events | https://github.com/facebook/react/pull/28618 | 2,203,776,533 | PR_kwDOAJy2Ks5qjoXJ | 28,618 | Bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /fixtures/flight | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 527ed72bfd9f5c0045da468ad01db968a9961ad7...685b2dcc7f78dadf3d1adf06962584f8e334a4ed\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-23 08:45:29 | 2024-03-25 17:37:18 | 2024-03-25 17:37:11 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28618', 'html_url': 'https://github.com/facebook/react/pull/28618', 'diff_url': 'https://github.com/facebook/react/pull/28618.diff', 'patch_url': 'https://github.com/facebook/react/pull/28618.patch', 'merged_at': datetime.datetime(2024, 3, 25, 17, 37, 11)} | Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/webpack/webpack-dev-middleware/releases">webpack-dev-middleware's releases</a>.</em></p>
<blockquote>
<h2>v5.3.4</h2>
<h3><a h... | {'url': 'https://api.github.com/repos/facebook/react/issues/28618/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28618/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28617 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28617/labels{/name} | https://api.github.com/repos/facebook/react/issues/28617/comments | https://api.github.com/repos/facebook/react/issues/28617/events | https://github.com/facebook/react/pull/28617 | 2,203,125,610 | PR_kwDOAJy2Ks5qhbIe | 28,617 | Make enableBigIntSupport a dynamic flag for Meta | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b35be36fb4a3fb3713ecb252f20ca1050a29122f...98ae796be698325397a5ef980290d49674d091eb\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-22 18:56:32 | 2024-03-25 17:52:27 | 2024-03-25 17:48:22 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28617', 'html_url': 'https://github.com/facebook/react/pull/28617', 'diff_url': 'https://github.com/facebook/react/pull/28617.diff', 'patch_url': 'https://github.com/facebook/react/pull/28617.patch', 'merged_at': datetime.datetime(2024, 3, 25, 17, 48, 22)} | Make enableBigIntSupport a dynamic flag for Meta
Should be an easy launch, but let's make this a dynamic flag to be safe.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28617/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28617/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28616 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28616/labels{/name} | https://api.github.com/repos/facebook/react/issues/28616/comments | https://api.github.com/repos/facebook/react/issues/28616/events | https://github.com/facebook/react/pull/28616 | 2,203,032,505 | PR_kwDOAJy2Ks5qhGbw | 28,616 | Fix test after merge conflict | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5c65b27587c0507d66a84e055de948fc62d471d4...5c7f5925a8f6b43d63e473151c8564424c8151dc\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-22 18:00:45 | 2024-03-22 18:07:27 | 2024-03-22 18:05:55 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28616', 'html_url': 'https://github.com/facebook/react/pull/28616', 'diff_url': 'https://github.com/facebook/react/pull/28616.diff', 'patch_url': 'https://github.com/facebook/react/pull/28616.patch', 'merged_at': datetime.datetime(2024, 3, 22, 18, 5, 55)} | Something went wrong when rebasing #28491 and renaming the hook. | {'url': 'https://api.github.com/repos/facebook/react/issues/28616/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28616/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28615 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28615/labels{/name} | https://api.github.com/repos/facebook/react/issues/28615/comments | https://api.github.com/repos/facebook/react/issues/28615/events | https://github.com/facebook/react/pull/28615 | 2,202,826,928 | PR_kwDOAJy2Ks5qgaA6 | 28,615 | [Breaking] Remove disableJavaScriptURLs | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 67081159377b438b48e3c2f2278af8e5f56b9f64...236181f046faf5c2e0080093d8a5e0c655a25892\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-22 16:03:00 | 2024-03-27 03:45:34 | 2024-03-27 03:45:34 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28615', 'html_url': 'https://github.com/facebook/react/pull/28615', 'diff_url': 'https://github.com/facebook/react/pull/28615.diff', 'patch_url': 'https://github.com/facebook/react/pull/28615.patch', 'merged_at': datetime.datetime(2024, 3, 27, 3, 45, 34)} | ## Overview
This has landed, so we can remove the flag
## Changelog
This change blocks using javascript URLs such as:
```html
<a href="javascript:notfine">p0wned</a>
```
We previously announced dropping support for this via a warning:
> A future version of React will block javascript: URLs as a secu... | {'url': 'https://api.github.com/repos/facebook/react/issues/28615/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28615/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28614 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28614/labels{/name} | https://api.github.com/repos/facebook/react/issues/28614/comments | https://api.github.com/repos/facebook/react/issues/28614/events | https://github.com/facebook/react/pull/28614 | 2,202,744,721 | PR_kwDOAJy2Ks5qgIFz | 28,614 | Cleanup enableFormActions flag | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f09e1599d631051a559974578a6d4c06effd95eb...dfc84616a9f911f278a4c50b2cad7fbda800e3ab\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-22 15:19:17 | 2024-03-25 17:56:15 | 2024-03-25 17:25:15 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28614', 'html_url': 'https://github.com/facebook/react/pull/28614', 'diff_url': 'https://github.com/facebook/react/pull/28614.diff', 'patch_url': 'https://github.com/facebook/react/pull/28614.patch', 'merged_at': datetime.datetime(2024, 3, 25, 17, 25, 15)} | Cleanup enableFormActions flag
| {'url': 'https://api.github.com/repos/facebook/react/issues/28614/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28614/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28613 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28613/labels{/name} | https://api.github.com/repos/facebook/react/issues/28613/comments | https://api.github.com/repos/facebook/react/issues/28613/events | https://github.com/facebook/react/pull/28613 | 2,202,564,187 | PR_kwDOAJy2Ks5qfgKB | 28,613 | Cleanup enableFloat flag | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fee786a057774ab687aff765345dd86fce534ab2...5a7e84590859e5906d24336f208bba44acca565d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-22 13:58:27 | 2024-03-25 17:56:19 | 2024-03-22 16:22:30 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28613', 'html_url': 'https://github.com/facebook/react/pull/28613', 'diff_url': 'https://github.com/facebook/react/pull/28613.diff', 'patch_url': 'https://github.com/facebook/react/pull/28613.patch', 'merged_at': datetime.datetime(2024, 3, 22, 16, 22, 30)} | Cleanup enableFloat flag
| {'url': 'https://api.github.com/repos/facebook/react/issues/28613/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28613/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28612 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28612/labels{/name} | https://api.github.com/repos/facebook/react/issues/28612/comments | https://api.github.com/repos/facebook/react/issues/28612/events | https://github.com/facebook/react/issues/28612 | 2,202,087,679 | I_kwDOAJy2Ks6DQTD_ | 28,612 | Bug: react-intl formatMessage cannot format message with param that neat by Single quotation mark | {'login': 'liqQi', 'id': 15689969, 'node_id': 'MDQ6VXNlcjE1Njg5OTY5', 'avatar_url': 'https://avatars.githubusercontent.com/u/15689969?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/liqQi', 'html_url': 'https://github.com/liqQi', 'followers_url': 'https://api.github.com/users/liqQi/followers', 'following_... | [{'id': 1168115654, 'node_id': 'MDU6TGFiZWwxMTY4MTE1NjU0', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Support%20Redirect', 'name': 'Resolution: Support Redirect', 'color': '106099', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"Is this relevant to react? Have you tried with other i18n JS packages?",
"> Is this relevant to react? Have you tried with other i18n JS packages?\r\n\r\nno, i18n just is a simple encapsulation of IntlShape，\r\nthe code like this:\r\n`\r\n\r\nimport {IntlShape } from './react-intl'\r\nexport type Intl = IntlSha... | 2024-03-22 09:37:30 | 2024-03-22 13:43:35 | 2024-03-22 13:43:29 | NONE | null | null | null | if I hava a message define like:
`
{
"message.id":'this is a france message, contains d\'{param}'
}
`
then I format message like this:
`
i18n.formatMessage({id:'message.id'},{param:'value'})
`
and the result will be :
`
this is a france message, contains d'{param}
`
it look like it can't recognize param... | {'url': 'https://api.github.com/repos/facebook/react/issues/28612/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28612/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28611 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28611/labels{/name} | https://api.github.com/repos/facebook/react/issues/28611/comments | https://api.github.com/repos/facebook/react/issues/28611/events | https://github.com/facebook/react/pull/28611 | 2,201,148,980 | PR_kwDOAJy2Ks5qapgr | 28,611 | [Fizz] Recover from errors thrown by progressive enhancement form generation | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4939017ffe2e04a94efca0f48b661bc778a6fa4...5ba7fda50f39a25c6db2e44a90348682ae92fa02\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-21 20:43:59 | 2024-03-21 23:51:39 | 2024-03-21 23:51:39 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28611', 'html_url': 'https://github.com/facebook/react/pull/28611', 'diff_url': 'https://github.com/facebook/react/pull/28611.diff', 'patch_url': 'https://github.com/facebook/react/pull/28611.patch', 'merged_at': datetime.datetime(2024, 3, 21, 23, 51, 39)} | This a follow up to #28564. It's alternative to #28609 which takes #28610 into account.
It used to be possible to return JSX from an action with `useActionState`.
```js
async function action(errors, payload) {
"use server";
try {
...
} catch (x) {
return <div>Error message</div>;
}
}
```
... | {'url': 'https://api.github.com/repos/facebook/react/issues/28611/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28611/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28610 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28610/labels{/name} | https://api.github.com/repos/facebook/react/issues/28610/comments | https://api.github.com/repos/facebook/react/issues/28610/events | https://github.com/facebook/react/pull/28610 | 2,201,095,878 | PR_kwDOAJy2Ks5qadvU | 28,610 | [Flight Reply] Don't allow Symbols to be passed to a reply | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4939017ffe2e04a94efca0f48b661bc778a6fa4...bd8f964a08fb5298f61423a332a4b6cd54cbf594\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-21 20:15:56 | 2024-03-21 20:55:17 | 2024-03-21 20:53:02 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28610', 'html_url': 'https://github.com/facebook/react/pull/28610', 'diff_url': 'https://github.com/facebook/react/pull/28610.diff', 'patch_url': 'https://github.com/facebook/react/pull/28610.patch', 'merged_at': datetime.datetime(2024, 3, 21, 20, 53, 2)} | As mentioned in #28609 there's a potential security risk if you allow a passed value to the server to spoof Elements because it allows a hacker to POST cross origin. This is only an issue if your framework allows this which it shouldn't but it seems like we should provide an extra layer of security here.
```js
func... | {'url': 'https://api.github.com/repos/facebook/react/issues/28610/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28610/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28609 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28609/labels{/name} | https://api.github.com/repos/facebook/react/issues/28609/comments | https://api.github.com/repos/facebook/react/issues/28609/events | https://github.com/facebook/react/pull/28609 | 2,201,083,448 | PR_kwDOAJy2Ks5qabHq | 28,609 | [DO NOT LAND] Allow Previously Seen Client References to be Passed Back to a Reply | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4939017ffe2e04a94efca0f48b661bc778a6fa4...1d26103cd3ba49e74b9780ab049657e6ed88862b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-21 20:10:36 | 2024-03-22 00:03:55 | 2024-03-22 00:03:55 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/28609', 'html_url': 'https://github.com/facebook/react/pull/28609', 'diff_url': 'https://github.com/facebook/react/pull/28609.diff', 'patch_url': 'https://github.com/facebook/react/pull/28609.patch', 'merged_at': None} | This was a follow up https://github.com/facebook/react/pull/28564 but I now feel uncomfortable with this solution due to security implications. I'm only opening it for reference. Instead I propose locking it down further in #28610 and instead to allow existing code to work we land #28611.
This PR tracks Client Refer... | {'url': 'https://api.github.com/repos/facebook/react/issues/28609/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28609/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28608 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28608/labels{/name} | https://api.github.com/repos/facebook/react/issues/28608/comments | https://api.github.com/repos/facebook/react/issues/28608/events | https://github.com/facebook/react/pull/28608 | 2,200,593,381 | PR_kwDOAJy2Ks5qYut8 | 28,608 | [RFC][ReactIs]: extract client/server reference types | {'login': 'kspeyanski', 'id': 30626787, 'node_id': 'MDQ6VXNlcjMwNjI2Nzg3', 'avatar_url': 'https://avatars.githubusercontent.com/u/30626787?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kspeyanski', 'html_url': 'https://github.com/kspeyanski', 'followers_url': 'https://api.github.com/users/kspeyanski/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @kspeyanski! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order fo... | 2024-03-21 16:08:25 | 2024-04-02 09:45:42 | 2024-03-30 07:17:35 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28608', 'html_url': 'https://github.com/facebook/react/pull/28608', 'diff_url': 'https://github.com/facebook/react/pull/28608.diff', 'patch_url': 'https://github.com/facebook/react/pull/28608.patch', 'merged_at': None} | ## Summary
Hello 👋.
I'm working on an experimental universal react components which are supposed to operate in server-only, server-client (RSC + `use client`) or client-only environments. Obviously not everything could be "universal" so there are a couple of caveats which require conditional passing of props fro... | {'url': 'https://api.github.com/repos/facebook/react/issues/28608/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28608/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28607 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28607/labels{/name} | https://api.github.com/repos/facebook/react/issues/28607/comments | https://api.github.com/repos/facebook/react/issues/28607/events | https://github.com/facebook/react/pull/28607 | 2,200,570,299 | PR_kwDOAJy2Ks5qYplW | 28,607 | [Fizz][Legacy] Remove renderToNodeStream | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2b036d3f1f016fbe8b121d223d96f09e785b97e1...ad3be49b803276983fe42a1070bbdb07a35aa62c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2024-03-21 15:58:49 | 2024-03-27 19:02:39 | 2024-03-27 19:02:36 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28607', 'html_url': 'https://github.com/facebook/react/pull/28607', 'diff_url': 'https://github.com/facebook/react/pull/28607.diff', 'patch_url': 'https://github.com/facebook/react/pull/28607.patch', 'merged_at': datetime.datetime(2024, 3, 27, 19, 2, 36)} | Stacked on #28606
renderToNodeStream has been deprecated since React 18 with a warning indicating users should upgrade to renderToPipeableStream. This change removes renderToNodeStream | {'url': 'https://api.github.com/repos/facebook/react/issues/28607/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28607/timeline | null | null | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.