url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/22731 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22731/labels{/name} | https://api.github.com/repos/facebook/react/issues/22731/comments | https://api.github.com/repos/facebook/react/issues/22731/events | https://github.com/facebook/react/issues/22731 | 1,049,106,448 | I_kwDOAJy2Ks4-iBgQ | 22,731 | Timeline: Nested update warning logic flaw | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"As a side note, given that React heuristics like this may change between releases (as happened with \"click\" event behavior) we may need to rethink the source of Timeline warnings. Maybe these warnings belong inside of React itself (DEV and profiling builds) and should be communicated to DevTools using some stand... | 2021-11-09 20:45:50 | 2022-04-17 19:27:21 | null | CONTRIBUTOR | null | null | null | Timeline shows the following nested update warning when a synchronous update causes an event handler to run long:
> A big nested update was scheduled during layout. Nested updates require React to re-render synchronously before the browser can paint. Consider delaying this update by moving it to a passive effect (useE... | {'url': 'https://api.github.com/repos/facebook/react/issues/22731/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22731/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22730 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22730/labels{/name} | https://api.github.com/repos/facebook/react/issues/22730/comments | https://api.github.com/repos/facebook/react/issues/22730/events | https://github.com/facebook/react/pull/22730 | 1,049,073,374 | PR_kwDOAJy2Ks4uT0y9 | 22,730 | Add Scheduling Profiler GK link to Timeline UI for FB build | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2021-11-09 20:22:33 | 2021-11-09 21:10:53 | 2021-11-09 21:10:48 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22730', 'html_url': 'https://github.com/facebook/react/pull/22730', 'diff_url': 'https://github.com/facebook/react/pull/22730.diff', 'patch_url': 'https://github.com/facebook/react/pull/22730.patch', 'merged_at': datetime.datetime(2021, 11, 9, 21, 10, 48)} | This is a constant source of confusion for FB engineers trying to figure out why Chrome profiling data does not have any React marks.
Internal Facebook build will now show the following additional line:
<img width="524" alt="Screen Shot 2021-11-09 at 3 23 21 PM" src="https://user-images.githubusercontent.com/29597/... | {'url': 'https://api.github.com/repos/facebook/react/issues/22730/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22730/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22729 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22729/labels{/name} | https://api.github.com/repos/facebook/react/issues/22729/comments | https://api.github.com/repos/facebook/react/issues/22729/events | https://github.com/facebook/react/issues/22729 | 1,048,875,179 | I_kwDOAJy2Ks4-hJCr | 22,729 | The tutorial is broken a bit | {'login': 'gyanendrasng', 'id': 63923409, 'node_id': 'MDQ6VXNlcjYzOTIzNDA5', 'avatar_url': 'https://avatars.githubusercontent.com/u/63923409?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gyanendrasng', 'html_url': 'https://github.com/gyanendrasng', 'followers_url': 'https://api.github.com/users/gyanendr... | [] | closed | false | null | [] | null | [
"> but it will give you an error, the () should be removed from this.props.onClick()\r\n\r\nI don't think that sounds correct. What error are you seeing?\r\n\r\nNotice that the example is:\r\n```js\r\n<button\r\n className=\"square\"\r\n onClick={() => this.props.onClick()}\r\n>\r\n```\r\n\r\nNot this:\r\n```js\r... | 2021-11-09 17:21:23 | 2021-11-10 15:55:42 | 2021-11-09 19:19:07 | NONE | null | null | null | on this url
https://reactjs.org/tutorial/tutorial.html
under section lift state up,
class Square extends React.Component {
render() {
return (
<button
className="square"
onClick={() => this.props.onClick()}
>
{this.props.value}
</button>
);
}
}
... | {'url': 'https://api.github.com/repos/facebook/react/issues/22729/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22729/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22728 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22728/labels{/name} | https://api.github.com/repos/facebook/react/issues/22728/comments | https://api.github.com/repos/facebook/react/issues/22728/events | https://github.com/facebook/react/issues/22728 | 1,048,273,505 | I_kwDOAJy2Ks4-e2Jh | 22,728 | Bug: I dont like it | {'login': 'gaganjot99', 'id': 73100470, 'node_id': 'MDQ6VXNlcjczMTAwNDcw', 'avatar_url': 'https://avatars.githubusercontent.com/u/73100470?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaganjot99', 'html_url': 'https://github.com/gaganjot99', 'followers_url': 'https://api.github.com/users/gaganjot99/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2021-11-09 07:25:46 | 2021-11-09 07:26:27 | 2021-11-09 07:26:27 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/22728/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22728/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22727 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22727/labels{/name} | https://api.github.com/repos/facebook/react/issues/22727/comments | https://api.github.com/repos/facebook/react/issues/22727/events | https://github.com/facebook/react/issues/22727 | 1,048,225,813 | I_kwDOAJy2Ks4-eqgV | 22,727 | [DevTools Bug]: Chrome extension's settings reset after every reload | {'login': 'Guris', 'id': 1776912, 'node_id': 'MDQ6VXNlcjE3NzY5MTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1776912?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Guris', 'html_url': 'https://github.com/Guris', 'followers_url': 'https://api.github.com/users/Guris/followers', 'following_ur... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | {'login': 'Guris', 'id': 1776912.0, 'node_id': 'MDQ6VXNlcjE3NzY5MTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1776912?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Guris', 'html_url': 'https://github.com/Guris', 'followers_url': 'https://api.github.com/users/Guris/followers', 'following_... | [{'login': 'Guris', 'id': 1776912, 'node_id': 'MDQ6VXNlcjE3NzY5MTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1776912?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Guris', 'html_url': 'https://github.com/Guris', 'followers_url': 'https://api.github.com/users/Guris/followers', 'following_u... | null | [
"I have just checked and I am unable to reproduce this. Given that this is the first time I've heard this issue being reported, I suspect there's something specific about maybe your browser (e.g. which other extensions you have installed) or something else on your end.\r\n\r\nHave you tried just uninstalling and re... | 2021-11-09 06:08:26 | 2022-12-10 07:44:22 | null | NONE | null | null | null | ### Website or app
Chrome 95.0.4638.69 (Official Build) (64-bit), DevTools version 4.21.0-2f8f60ca8
### Repro steps
1. Open Chrome dev tools
2. Switch to Components or Profiler tab
3. Select settings and change for example "Highlight updates when components render."
4. Reload window
5. Get back to settings - ch... | {'url': 'https://api.github.com/repos/facebook/react/issues/22727/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22727/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22726 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22726/labels{/name} | https://api.github.com/repos/facebook/react/issues/22726/comments | https://api.github.com/repos/facebook/react/issues/22726/events | https://github.com/facebook/react/pull/22726 | 1,048,201,029 | PR_kwDOAJy2Ks4uQ9TH | 22,726 | [Fizz/Flight] Don't start writing to the stream if it's already full | {'login': 'devknoll', 'id': 1477230, 'node_id': 'MDQ6VXNlcjE0NzcyMzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1477230?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/devknoll', 'html_url': 'https://github.com/devknoll', 'followers_url': 'https://api.github.com/users/devknoll/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2b77ab26adc2601dc223ede75ff4d19bc19c8684...8b6d8282f61d2ea84d16701c1a092cb587c43ff4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-09 05:16:37 | 2022-03-17 05:16:48 | 2022-03-17 05:16:48 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22726', 'html_url': 'https://github.com/facebook/react/pull/22726', 'diff_url': 'https://github.com/facebook/react/pull/22726.diff', 'patch_url': 'https://github.com/facebook/react/pull/22726.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22726/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22726/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22725 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22725/labels{/name} | https://api.github.com/repos/facebook/react/issues/22725/comments | https://api.github.com/repos/facebook/react/issues/22725/events | https://github.com/facebook/react/pull/22725 | 1,047,935,675 | PR_kwDOAJy2Ks4uQGmo | 22,725 | Added more context to invalid text string errors | {'login': 'EvanBacon', 'id': 9664363, 'node_id': 'MDQ6VXNlcjk2NjQzNjM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9664363?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/EvanBacon', 'html_url': 'https://github.com/EvanBacon', 'followers_url': 'https://api.github.com/users/EvanBacon/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2db6d6a5a7a2ecf74610d5a55732d6753b15b836...871c7c775f29dfabf9282b5c5e6aa2fbcbc753cf\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-08 21:25:05 | 2024-04-17 15:36:02 | 2024-04-17 15:36:02 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22725', 'html_url': 'https://github.com/facebook/react/pull/22725', 'diff_url': 'https://github.com/facebook/react/pull/22725.diff', 'patch_url': 'https://github.com/facebook/react/pull/22725.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22725/reactions', 'total_count': 10, '+1': 10, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22725/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22723 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22723/labels{/name} | https://api.github.com/repos/facebook/react/issues/22723/comments | https://api.github.com/repos/facebook/react/issues/22723/events | https://github.com/facebook/react/pull/22723 | 1,047,799,021 | PR_kwDOAJy2Ks4uPqFK | 22,723 | Adding new Performance Insight feature to React devtools | {'login': 'KamranAsif', 'id': 2875524, 'node_id': 'MDQ6VXNlcjI4NzU1MjQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2875524?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/KamranAsif', 'html_url': 'https://github.com/KamranAsif', 'followers_url': 'https://api.github.com/users/KamranAsif/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Hi @KamranAsif! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order fo... | 2021-11-08 18:43:07 | 2022-03-29 02:07:10 | 2022-03-29 01:56:20 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22723', 'html_url': 'https://github.com/facebook/react/pull/22723', 'diff_url': 'https://github.com/facebook/react/pull/22723.diff', 'patch_url': 'https://github.com/facebook/react/pull/22723.patch', 'merged_at': None} | ## Summary
I've spent a lot of time debugging React performance in the last year. I've often seem the same issues around memoization and state management and even created some guides internally at FB.
I started poking around at the devtools and saw a lot of this manual investigation can be done automatically. I a... | {'url': 'https://api.github.com/repos/facebook/react/issues/22723/reactions', 'total_count': 21, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 5, 'confused': 0, 'heart': 7, 'rocket': 2, 'eyes': 7} | https://api.github.com/repos/facebook/react/issues/22723/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22722 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22722/labels{/name} | https://api.github.com/repos/facebook/react/issues/22722/comments | https://api.github.com/repos/facebook/react/issues/22722/events | https://github.com/facebook/react/pull/22722 | 1,047,484,221 | PR_kwDOAJy2Ks4uOn6g | 22,722 | Fix a few minor typos | {'login': 'KonstHardy', 'id': 46906648, 'node_id': 'MDQ6VXNlcjQ2OTA2NjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/46906648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/KonstHardy', 'html_url': 'https://github.com/KonstHardy', 'followers_url': 'https://api.github.com/users/KonstHardy/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 327d5c48454aaee0d78fa69b7ef96a14605bf93b...cbd8ad726bf14e439eb4fff8cdc28c8866d84c75\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-08 13:59:10 | 2021-11-15 19:41:40 | 2021-11-15 15:57:31 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22722', 'html_url': 'https://github.com/facebook/react/pull/22722', 'diff_url': 'https://github.com/facebook/react/pull/22722.diff', 'patch_url': 'https://github.com/facebook/react/pull/22722.patch', 'merged_at': None} | Hello,
I've found some minor typos in the documentation, solved with this PR.
Fix typo:
we we -> we
typechecking -> type checking
typecheck -> type check
reentrancy -> re-entrance | {'url': 'https://api.github.com/repos/facebook/react/issues/22722/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22722/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22721 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22721/labels{/name} | https://api.github.com/repos/facebook/react/issues/22721/comments | https://api.github.com/repos/facebook/react/issues/22721/events | https://github.com/facebook/react/issues/22721 | 1,047,044,928 | I_kwDOAJy2Ks4-aKNA | 22,721 | How to resuse same component without remounting it and access anywhere in dom tree? | {'login': 'yg-yash', 'id': 45752285, 'node_id': 'MDQ6VXNlcjQ1NzUyMjg1', 'avatar_url': 'https://avatars.githubusercontent.com/u/45752285?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yg-yash', 'html_url': 'https://github.com/yg-yash', 'followers_url': 'https://api.github.com/users/yg-yash/followers', 'fo... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | open | false | null | [] | null | [
"It's impossible. Browsers can preserve a DOM element if its siblings change, but as soon as its parent or parent's parent (and so on) changes, it's game over. Use a portal. Also, use stackoverflow for programming questions. Issues are for bugs in this repo.",
"Try some solutions like react portals.",
"Use Reac... | 2021-11-08 05:49:03 | 2021-12-19 17:57:04 | null | NONE | null | null | null | i am creating a streaming app in react js my use case is this there is a camera component which is defined on the top level in App.js i want that component to be rendered at top level as well as inside any child component everywhere in dom which same component instance and state so that camera should not be remount and... | {'url': 'https://api.github.com/repos/facebook/react/issues/22721/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22721/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22720 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22720/labels{/name} | https://api.github.com/repos/facebook/react/issues/22720/comments | https://api.github.com/repos/facebook/react/issues/22720/events | https://github.com/facebook/react/issues/22720 | 1,047,028,781 | I_kwDOAJy2Ks4-aGQt | 22,720 | Bug: Debugger triggered twice in StrictMode | {'login': 'hxse', 'id': 22582226, 'node_id': 'MDQ6VXNlcjIyNTgyMjI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/22582226?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hxse', 'html_url': 'https://github.com/hxse', 'followers_url': 'https://api.github.com/users/hxse/followers', 'following_url'... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"触发两次是正确的。 可以参考 https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects",
"> 触发两次是正确的。 可以参考 https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects\r\n\r\nI know there will be two calls, but there shouldn't be twice `debugger` triggered because the `console.log` only tri... | 2021-11-08 05:13:28 | 2021-11-09 13:34:28 | 2021-11-09 13:34:27 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
"react": "^17.0.0"
"vite": "^2.6.4"
"@vitejs/plugin-reac... | {'url': 'https://api.github.com/repos/facebook/react/issues/22720/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22720/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22719 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22719/labels{/name} | https://api.github.com/repos/facebook/react/issues/22719/comments | https://api.github.com/repos/facebook/react/issues/22719/events | https://github.com/facebook/react/pull/22719 | 1,046,855,454 | PR_kwDOAJy2Ks4uMmG1 | 22,719 | Use consistent dependency versions across all workspaces | {'login': 'ddzz', 'id': 3535749, 'node_id': 'MDQ6VXNlcjM1MzU3NDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3535749?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ddzz', 'html_url': 'https://github.com/ddzz', 'followers_url': 'https://api.github.com/users/ddzz/followers', 'following_url': ... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Sorry, just saw this. Would you mind rebasing?",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 726ba80298dad46b331aca1bcb71ca9b2004ed91...a67d0c594364a241a84c7438f185e4925edfbaf3\n\n## Critical size changes\n\nIncludes critical production ... | 2021-11-07 21:35:03 | 2022-04-16 18:35:19 | 2022-04-16 18:35:11 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22719', 'html_url': 'https://github.com/facebook/react/pull/22719', 'diff_url': 'https://github.com/facebook/react/pull/22719.diff', 'patch_url': 'https://github.com/facebook/react/pull/22719.patch', 'merged_at': None} | ## Summary
There are version inconsistencies among the dependencies in this repo. This PR modifies all workspaces to use the highest version present for all inconsistencies. This makes upgrading dependencies simpler, and reduces the likelihood of unexpected behavior across the repo due to differing versions. This also... | {'url': 'https://api.github.com/repos/facebook/react/issues/22719/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22719/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22718 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22718/labels{/name} | https://api.github.com/repos/facebook/react/issues/22718/comments | https://api.github.com/repos/facebook/react/issues/22718/events | https://github.com/facebook/react/issues/22718 | 1,046,833,772 | I_kwDOAJy2Ks4-ZWps | 22,718 | Bug: Parent <details> onToggle handler called when child <details> onToggle handler is triggered | {'login': 'jordanbtucker', 'id': 468153, 'node_id': 'MDQ6VXNlcjQ2ODE1Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/468153?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jordanbtucker', 'html_url': 'https://github.com/jordanbtucker', 'followers_url': 'https://api.github.com/users/jordanbtu... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | null | [] | null | [
"My current work around is to call `event.stopPropagation()` in the child handler. However, `event.bubbles === false`, so that's not something that should be required.",
"it seems that react allready has a plan about it. https://github.com/facebook/react/blob/main/packages/react-dom/src/events/plugins/SimpleEve... | 2021-11-07 19:48:36 | 2022-11-04 23:41:11 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.2
## Steps To Reproduce
1. Declare a `<details>` eleme... | {'url': 'https://api.github.com/repos/facebook/react/issues/22718/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22718/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22717 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22717/labels{/name} | https://api.github.com/repos/facebook/react/issues/22717/comments | https://api.github.com/repos/facebook/react/issues/22717/events | https://github.com/facebook/react/pull/22717 | 1,046,807,646 | PR_kwDOAJy2Ks4uMdUC | 22,717 | fix(devtools): accept json file in import fileinput | {'login': 'jyash97', 'id': 22376783, 'node_id': 'MDQ6VXNlcjIyMzc2Nzgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/22376783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jyash97', 'html_url': 'https://github.com/jyash97', 'followers_url': 'https://api.github.com/users/jyash97/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hey @bvaughn \r\n\r\nWhenever you get chance take look at this change, this helps in identfying json files in file menu.",
"> Loading profile can accept all files which breaks the functionality of parsing the data since devtools only accept .json file.\r\n\r\nCan you explain what it means by \"breaks the functio... | 2021-11-07 17:43:53 | 2021-11-09 04:39:05 | 2021-11-08 21:35:35 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22717', 'html_url': 'https://github.com/facebook/react/pull/22717', 'diff_url': 'https://github.com/facebook/react/pull/22717.diff', 'patch_url': 'https://github.com/facebook/react/pull/22717.patch', 'merged_at': datetime.datetime(2021, 11, 8, 21, 35, 35)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22717/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22717/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22716 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22716/labels{/name} | https://api.github.com/repos/facebook/react/issues/22716/comments | https://api.github.com/repos/facebook/react/issues/22716/events | https://github.com/facebook/react/pull/22716 | 1,046,803,235 | PR_kwDOAJy2Ks4uMch2 | 22,716 | fix(devtools): expose css vars to reach-ui portal components | {'login': 'jyash97', 'id': 22376783, 'node_id': 'MDQ6VXNlcjIyMzc2Nzgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/22376783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jyash97', 'html_url': 'https://github.com/jyash97', 'followers_url': 'https://api.github.com/users/jyash97/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Might need help with Flow types here. ",
"CI's pointing out a couple of minor erros:\r\n\r\n### Lint\r\n```\r\n/home/circleci/project/packages/react-devtools-shared/src/devtools/views/Settings/SettingsContext.js\r\n 261:10 error 'updateStyleHelper' is defined but never used no-unused-vars\r\n```\r\n\r\n### F... | 2021-11-07 17:23:57 | 2021-11-08 20:17:23 | 2021-11-08 20:17:23 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22716', 'html_url': 'https://github.com/facebook/react/pull/22716', 'diff_url': 'https://github.com/facebook/react/pull/22716.diff', 'patch_url': 'https://github.com/facebook/react/pull/22716.patch', 'merged_at': datetime.datetime(2021, 11, 8, 20, 17, 22)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22716/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22716/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22715 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22715/labels{/name} | https://api.github.com/repos/facebook/react/issues/22715/comments | https://api.github.com/repos/facebook/react/issues/22715/events | https://github.com/facebook/react/pull/22715 | 1,046,642,689 | PR_kwDOAJy2Ks4uL_DB | 22,715 | Fix some typos | {'login': '180909', 'id': 70465953, 'node_id': 'MDQ6VXNlcjcwNDY1OTUz', 'avatar_url': 'https://avatars.githubusercontent.com/u/70465953?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/180909', 'html_url': 'https://github.com/180909', 'followers_url': 'https://api.github.com/users/180909/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 327d5c48454aaee0d78fa69b7ef96a14605bf93b...0b87f5965e041e70a830ad0c2013ebd512b581db\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-07 02:21:45 | 2021-11-15 15:58:22 | 2021-11-15 15:58:22 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22715', 'html_url': 'https://github.com/facebook/react/pull/22715', 'diff_url': 'https://github.com/facebook/react/pull/22715.diff', 'patch_url': 'https://github.com/facebook/react/pull/22715.patch', 'merged_at': datetime.datetime(2021, 11, 15, 15, 58, 22)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22715/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22715/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22714 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22714/labels{/name} | https://api.github.com/repos/facebook/react/issues/22714/comments | https://api.github.com/repos/facebook/react/issues/22714/events | https://github.com/facebook/react/issues/22714 | 1,046,626,224 | I_kwDOAJy2Ks4-Yj-w | 22,714 | Safari performance while adding list items | {'login': 'MayuraRam', 'id': 23691819, 'node_id': 'MDQ6VXNlcjIzNjkxODE5', 'avatar_url': 'https://avatars.githubusercontent.com/u/23691819?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MayuraRam', 'html_url': 'https://github.com/MayuraRam', 'followers_url': 'https://api.github.com/users/MayuraRam/followe... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"有点好奇， Safari 比chrome慢了多少？ ",
"> I am using React version 17.0.2 and running an app on Safari 15.1. The component adds 20 list items at a time. The list item contains three divs, one span element and one img element. I am using a reducer to load the data. After Adding the DOM elements, there is scroll event happe... | 2021-11-07 00:19:29 | 2024-04-17 15:36:03 | 2024-04-17 15:36:03 | NONE | null | null | null | I am using React version 17.0.2 and running an app on Safari 15.1. The component adds 20 list items at a time. The list item contains three divs, one span element and one img element. I am using a reducer to load the data. After Adding the DOM elements, there is scroll event happening to show the list at the bottom. ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22714/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22714/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/22713 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22713/labels{/name} | https://api.github.com/repos/facebook/react/issues/22713/comments | https://api.github.com/repos/facebook/react/issues/22713/events | https://github.com/facebook/react/pull/22713 | 1,046,553,194 | PR_kwDOAJy2Ks4uLvK1 | 22,713 | Fixed else statment for ReactDomServerFormatConfig.js (#22309) | {'login': 'omarfarah123', 'id': 76454677, 'node_id': 'MDQ6VXNlcjc2NDU0Njc3', 'avatar_url': 'https://avatars.githubusercontent.com/u/76454677?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/omarfarah123', 'html_url': 'https://github.com/omarfarah123', 'followers_url': 'https://api.github.com/users/omarfara... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Hi @omarfarah123! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order ... | 2021-11-06 17:10:47 | 2024-04-17 15:36:06 | 2024-04-17 15:36:05 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22713', 'html_url': 'https://github.com/facebook/react/pull/22713', 'diff_url': 'https://github.com/facebook/react/pull/22713.diff', 'patch_url': 'https://github.com/facebook/react/pull/22713.patch', 'merged_at': None} |
## Summary
https://github.com/facebook/react/issues/22309
Preventing an override of a variable.
## How did you test this change?
Same Functionality
Unit test still passed no need for another unit test.
| {'url': 'https://api.github.com/repos/facebook/react/issues/22713/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22713/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22712 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22712/labels{/name} | https://api.github.com/repos/facebook/react/issues/22712/comments | https://api.github.com/repos/facebook/react/issues/22712/events | https://github.com/facebook/react/issues/22712 | 1,046,550,477 | I_kwDOAJy2Ks4-YRfN | 22,712 | Bug: when initialArg changes, useReducer should update the state accordingly | {'login': 'tavoyne', 'id': 29731597, 'node_id': 'MDQ6VXNlcjI5NzMxNTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29731597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tavoyne', 'html_url': 'https://github.com/tavoyne', 'followers_url': 'https://api.github.com/users/tavoyne/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [
"Hey nice write up. ",
"I can confirm I am doing something very similar and it took me a week to figure out this was a framework issue. Would appreciate if this was addressed.",
"I have a similar form. When fetching the initial data from server using `RTK Query `, initialArg does not updates. \r\n\r\n",
"Thi... | 2021-11-06 16:57:08 | 2024-04-17 15:36:06 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
**TL;DR**: After the first render, `useReducer` doesn't react to changes in the ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22712/reactions', 'total_count': 6, '+1': 3, '-1': 2, 'laugh': 0, 'hooray': 0, 'confused': 1, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22712/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22711 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22711/labels{/name} | https://api.github.com/repos/facebook/react/issues/22711/comments | https://api.github.com/repos/facebook/react/issues/22711/events | https://github.com/facebook/react/issues/22711 | 1,046,520,922 | I_kwDOAJy2Ks4-YKRa | 22,711 | Bug: | {'login': 'joeybobbes', 'id': 92046241, 'node_id': 'U_kgDOBXyDoQ', 'avatar_url': 'https://avatars.githubusercontent.com/u/92046241?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/joeybobbes', 'html_url': 'https://github.com/joeybobbes', 'followers_url': 'https://api.github.com/users/joeybobbes/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2021-11-06 14:27:30 | 2021-11-06 14:27:44 | 2021-11-06 14:27:44 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/22711/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22711/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22710 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22710/labels{/name} | https://api.github.com/repos/facebook/react/issues/22710/comments | https://api.github.com/repos/facebook/react/issues/22710/events | https://github.com/facebook/react/pull/22710 | 1,046,516,343 | PR_kwDOAJy2Ks4uLoeJ | 22,710 | Delete unused Circle CI scripts. | {'login': 'elas7', 'id': 7537033, 'node_id': 'MDQ6VXNlcjc1MzcwMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7537033?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/elas7', 'html_url': 'https://github.com/elas7', 'followers_url': 'https://api.github.com/users/elas7/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: ee069065db449194a62a5c0dc2f8f6b61fa5e1b8...e2dcb5c834416279b3a565a7c4d4f2573c181ab3\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-06 14:03:28 | 2021-11-06 14:23:40 | 2021-11-06 14:16:49 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22710', 'html_url': 'https://github.com/facebook/react/pull/22710', 'diff_url': 'https://github.com/facebook/react/pull/22710.diff', 'patch_url': 'https://github.com/facebook/react/pull/22710.patch', 'merged_at': datetime.datetime(2021, 11, 6, 14, 16, 49)} | This PR deletes several Circle CI script files from `/scripts/circleci` and `/scripts/release` that are not used anymore.
**Deleted files:**
- `/scripts/circleci/add_build_info_json.sh` and `/scripts/release/ci-add-build-info-json.js`
- Introduced in #14260
- The last reference was removed in 2375670
- `/scr... | {'url': 'https://api.github.com/repos/facebook/react/issues/22710/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22710/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22709 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22709/labels{/name} | https://api.github.com/repos/facebook/react/issues/22709/comments | https://api.github.com/repos/facebook/react/issues/22709/events | https://github.com/facebook/react/issues/22709 | 1,046,502,474 | I_kwDOAJy2Ks4-YFxK | 22,709 | SetState in useCallback or without useCallback | {'login': 'ineffablep', 'id': 5001426, 'node_id': 'MDQ6VXNlcjUwMDE0MjY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5001426?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ineffablep', 'html_url': 'https://github.com/ineffablep', 'followers_url': 'https://api.github.com/users/ineffablep/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1168115654, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"> In this code we are setting setState in onCheckChange, without useCallback, does it mean React create onCheckChange function every re-render?\r\n\r\nyes\r\n\r\n> Can we handle without re-creation every render without useCallback\r\n\r\nno i don't think you can do that without `useCallback` in a function componen... | 2021-11-06 12:48:18 | 2022-04-29 09:20:08 | 2022-04-29 09:20:03 | NONE | null | null | null | This looks simple example to pinpoint the scenario, this example not reflect real-time large applications.
So I want to understand which one is better to approach with useCallback or without useCallback.
As per documentation, useCallback memories function in memory and don't create every render, so do we need to... | {'url': 'https://api.github.com/repos/facebook/react/issues/22709/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22709/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22706 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22706/labels{/name} | https://api.github.com/repos/facebook/react/issues/22706/comments | https://api.github.com/repos/facebook/react/issues/22706/events | https://github.com/facebook/react/pull/22706 | 1,046,133,917 | PR_kwDOAJy2Ks4uKdAG | 22,706 | Timeline: Improved snapshot view | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2021-11-05 18:33:39 | 2021-11-08 17:28:36 | 2021-11-08 17:28:34 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22706', 'html_url': 'https://github.com/facebook/react/pull/22706', 'diff_url': 'https://github.com/facebook/react/pull/22706.diff', 'patch_url': 'https://github.com/facebook/react/pull/22706.patch', 'merged_at': datetime.datetime(2021, 11, 8, 17, 28, 34)} | Resize snapshots canvas area more intelligently, based on native height.
Resize hover tooltips better, based on aspect ratio and viewport dimensions.
Show scrubber bar like Chrome does.
Resolves #22705
### Before
 | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [] | 2021-11-05 15:59:49 | 2021-11-08 17:28:34 | 2021-11-08 17:28:34 | CONTRIBUTOR | null | null | null | For example:
<img width="1904" alt="Screen Shot 2021-11-05 at 11 59 05 AM" src="https://user-images.githubusercontent.com/29597/140540816-25d6d47b-7aea-4121-aeaa-565accc65b1f.png">
| {'url': 'https://api.github.com/repos/facebook/react/issues/22705/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22705/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22704 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22704/labels{/name} | https://api.github.com/repos/facebook/react/issues/22704/comments | https://api.github.com/repos/facebook/react/issues/22704/events | https://github.com/facebook/react/issues/22704 | 1,045,947,205 | I_kwDOAJy2Ks4-V-NF | 22,704 | [ESLint Bug]: Rules of Hooks breaks with IIFEs | {'login': 'JamesGelok', 'id': 23425952, 'node_id': 'MDQ6VXNlcjIzNDI1OTUy', 'avatar_url': 'https://avatars.githubusercontent.com/u/23425952?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JamesGelok', 'html_url': 'https://github.com/JamesGelok', 'followers_url': 'https://api.github.com/users/JamesGelok/fol... | [] | closed | false | null | [] | null | [
"The lint rules aren't meant to be perfect, they're mostly just heuristics. This rule also triggers for components that define hooks using `useCallback`. That said if you want to submit a PR for the rule to identify IIFE's then I'd be happy to take a look.\r\n\r\n",
"> The lint rules aren't meant to be perfect, t... | 2021-11-05 15:01:38 | 2021-11-05 19:26:25 | 2021-11-05 18:33:12 | NONE | null | null | null | ### Summary
It seems like the rules of hooks break on [IIFE](https://developer.mozilla.org/en-US/docs/Glossary/IIFE)s when it seems like they shouldn't.
[This codesandbox is the best way to see what I'm talking about.](https://codesandbox.io/s/rules-of-hooks-trouble-with-iife-kz1f7?file=/src/index.tsx) However, I... | {'url': 'https://api.github.com/repos/facebook/react/issues/22704/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22704/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22703 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22703/labels{/name} | https://api.github.com/repos/facebook/react/issues/22703/comments | https://api.github.com/repos/facebook/react/issues/22703/events | https://github.com/facebook/react/issues/22703 | 1,045,721,077 | I_kwDOAJy2Ks4-VG_1 | 22,703 | [DevTools Bug]: Components without own dimensions not highlighted at all | {'login': 'Andarist', 'id': 9800850, 'node_id': 'MDQ6VXNlcjk4MDA4NTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9800850?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Andarist', 'html_url': 'https://github.com/Andarist', 'followers_url': 'https://api.github.com/users/Andarist/followers', '... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | null | [] | null | [
"This kind of makes sense. The topmost DOM element rendered by your component has a size of 0x0. (DevTools doesn't traverse the DOM to measure each child. That would be pretty expensive.)\r\n\r\nMaybe we could add a special case for this somehow? Not sure.\r\n\r\nPRs/suggestions welcome.",
"After thinking about t... | 2021-11-05 11:16:58 | 2021-11-09 13:27:43 | null | CONTRIBUTOR | null | null | null | ### Website or app
https://codesandbox.io/s/trusting-night-35uuz?file=/src/App.js
### Repro steps
Create a fixed element with an absolute child like this:
```js
return (
<div style={{ position: "fixed", left: point.x, top: point.y }}>
<div
style={{
position: "absolute",
... | {'url': 'https://api.github.com/repos/facebook/react/issues/22703/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22703/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22702 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22702/labels{/name} | https://api.github.com/repos/facebook/react/issues/22702/comments | https://api.github.com/repos/facebook/react/issues/22702/events | https://github.com/facebook/react/issues/22702 | 1,045,531,163 | I_kwDOAJy2Ks4-UYob | 22,702 | Bug: Failed to execute 'insertBefore' on 'Node' And Failed to execute 'removeChild' on 'Node' with Chrome translate | {'login': '1291669609', 'id': 67503071, 'node_id': 'MDQ6VXNlcjY3NTAzMDcx', 'avatar_url': 'https://avatars.githubusercontent.com/u/67503071?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/1291669609', 'html_url': 'https://github.com/1291669609', 'followers_url': 'https://api.github.com/users/1291669609/fol... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/la... | open | false | null | [] | null | [
"This looks like a duplicate of #17256\r\n\r\n---\r\n\r\n这看起来像 #17256 的副本",
"Also possible duplicate of https://github.com/facebook/react/issues/11538. See https://github.com/facebook/react/issues/11538#issuecomment-417504600 for the latest update.",
"This is a widespread problem with a long history, and the so... | 2021-11-05 07:42:28 | 2024-05-05 07:57:38 | null | NONE | null | null | null | ```js
const [oneShow, setOneShow] = useState(false);
const [twoShow, setTwoShow] = useState(true);
return (
<div>
<h1>插入节点错误</h1>
<div>
<span>（{oneShow && '插入节点' }）</span>
</div>
<button onClick={() => {
setOneShow(true)
}}>触发
</button>
... | {'url': 'https://api.github.com/repos/facebook/react/issues/22702/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22702/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22701 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22701/labels{/name} | https://api.github.com/repos/facebook/react/issues/22701/comments | https://api.github.com/repos/facebook/react/issues/22701/events | https://github.com/facebook/react/pull/22701 | 1,045,230,970 | PR_kwDOAJy2Ks4uHgmD | 22,701 | Fix small typos | {'login': 'KonstHardy', 'id': 46906648, 'node_id': 'MDQ6VXNlcjQ2OTA2NjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/46906648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/KonstHardy', 'html_url': 'https://github.com/KonstHardy', 'followers_url': 'https://api.github.com/users/KonstHardy/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 13455d26d1904519c53686d6f295d4eb50b6c2fc...d9dd98403b36e6de2b469706be7ad10405d57c96\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-04 21:35:13 | 2021-11-08 13:46:49 | 2021-11-04 23:49:06 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22701', 'html_url': 'https://github.com/facebook/react/pull/22701', 'diff_url': 'https://github.com/facebook/react/pull/22701.diff', 'patch_url': 'https://github.com/facebook/react/pull/22701.patch', 'merged_at': datetime.datetime(2021, 11, 4, 23, 49, 6)} | Hello,
I've found some minor typos in the documentation, solved with this PR.
Fix typo:
overriden -> overridden
typechecks -> type checks
hard coded -> hardcoded | {'url': 'https://api.github.com/repos/facebook/react/issues/22701/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22701/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22700 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22700/labels{/name} | https://api.github.com/repos/facebook/react/issues/22700/comments | https://api.github.com/repos/facebook/react/issues/22700/events | https://github.com/facebook/react/issues/22700 | 1,045,063,244 | I_kwDOAJy2Ks4-SmZM | 22,700 | Use html native event handler <img> with React SSR. | {'login': 'dilumst', 'id': 75817409, 'node_id': 'MDQ6VXNlcjc1ODE3NDA5', 'avatar_url': 'https://avatars.githubusercontent.com/u/75817409?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dilumst', 'html_url': 'https://github.com/dilumst', 'followers_url': 'https://api.github.com/users/dilumst/followers', 'fo... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | open | false | null | [] | null | [] | 2021-11-04 18:21:57 | 2021-11-04 18:21:57 | null | NONE | null | null | null | Similar to this
https://github.com/facebook/react/issues/15446
I have react APP that will do server render first to create html markup then do client render on browser again.
my app returns:
`<img classname="classA" src="invalid-src" fallbacksrc="valid-src" style="visibility:hidden"/>
`
I am trying to us... | {'url': 'https://api.github.com/repos/facebook/react/issues/22700/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22700/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22699 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22699/labels{/name} | https://api.github.com/repos/facebook/react/issues/22699/comments | https://api.github.com/repos/facebook/react/issues/22699/events | https://github.com/facebook/react/pull/22699 | 1,045,058,364 | PR_kwDOAJy2Ks4uG7oa | 22,699 | [Fabric] Clear host instance fields | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 13455d26d1904519c53686d6f295d4eb50b6c2fc...497aac2a663823b8b3036176ba151a523c16409a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-04 18:15:31 | 2021-11-05 01:28:18 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22699', 'html_url': 'https://github.com/facebook/react/pull/22699', 'diff_url': 'https://github.com/facebook/react/pull/22699.diff', 'patch_url': 'https://github.com/facebook/react/pull/22699.patch', 'merged_at': None} | We didn't implement this method. I don't know if we should, but seems like refs could hold host instances, so they could leak. So it might be good to disconnect the props and the fiber pointers. I edited the existing methods to remove non-null assumptions. Not sure if there is other code in RN reading these. | {'url': 'https://api.github.com/repos/facebook/react/issues/22699/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22699/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22698 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22698/labels{/name} | https://api.github.com/repos/facebook/react/issues/22698/comments | https://api.github.com/repos/facebook/react/issues/22698/events | https://github.com/facebook/react/pull/22698 | 1,044,948,138 | PR_kwDOAJy2Ks4uGkl- | 22,698 | Fix benchmark runner. | {'login': 'elas7', 'id': 7537033, 'node_id': 'MDQ6VXNlcjc1MzcwMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7537033?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/elas7', 'html_url': 'https://github.com/elas7', 'followers_url': 'https://api.github.com/users/elas7/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request has been automatically marked as stale. **If this pull request is still relevant, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.",
"Closing this pull r... | 2021-11-04 16:22:47 | 2024-04-17 15:36:07 | 2024-04-17 15:36:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22698', 'html_url': 'https://github.com/facebook/react/pull/22698', 'diff_url': 'https://github.com/facebook/react/pull/22698.diff', 'patch_url': 'https://github.com/facebook/react/pull/22698.patch', 'merged_at': None} | - Fix paths to point to `node_modules/.../umd`. (Previously, [another PR](https://github.com/facebook/react/pull/18473) did the same for the paths in `/fixtures`).
- Update `chrome-launcher` and `nodegit` to the latest versions.
<details>
```
bench $ yarn start
yarn run v1.22.15
warning package.json: No lic... | {'url': 'https://api.github.com/repos/facebook/react/issues/22698/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22698/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22697 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22697/labels{/name} | https://api.github.com/repos/facebook/react/issues/22697/comments | https://api.github.com/repos/facebook/react/issues/22697/events | https://github.com/facebook/react/pull/22697 | 1,044,907,385 | PR_kwDOAJy2Ks4uGcEg | 22,697 | fix exponential search in getHostSibling function | {'login': 'guojin-long', 'id': 89032119, 'node_id': 'MDQ6VXNlcjg5MDMyMTE5', 'avatar_url': 'https://avatars.githubusercontent.com/u/89032119?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/guojin-long', 'html_url': 'https://github.com/guojin-long', 'followers_url': 'https://api.github.com/users/guojin-long... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1bf6deb865052111474f2988bb831de13d09c560...2ad3ed3a6c63486290c148eeb83d64bf90fdbe04\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-04 15:44:41 | 2022-11-25 00:48:10 | 2022-11-25 00:48:10 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22697', 'html_url': 'https://github.com/facebook/react/pull/22697', 'diff_url': 'https://github.com/facebook/react/pull/22697.diff', 'patch_url': 'https://github.com/facebook/react/pull/22697.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22697/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22697/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22696 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22696/labels{/name} | https://api.github.com/repos/facebook/react/issues/22696/comments | https://api.github.com/repos/facebook/react/issues/22696/events | https://github.com/facebook/react/pull/22696 | 1,044,861,971 | PR_kwDOAJy2Ks4uGSjY | 22,696 | Cleaned up remaining "scheduling profiler" references in DevTools | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2021-11-04 15:03:40 | 2021-11-04 15:40:47 | 2021-11-04 15:40:46 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22696', 'html_url': 'https://github.com/facebook/react/pull/22696', 'diff_url': 'https://github.com/facebook/react/pull/22696.diff', 'patch_url': 'https://github.com/facebook/react/pull/22696.patch', 'merged_at': datetime.datetime(2021, 11, 4, 15, 40, 46)} | I think everything now references "Timeline" except for React feature flags. This didn't seem worth renaming, since it's also wired up to an internal GK at Facebook.
This PR is probably easiest to review by commit. | {'url': 'https://api.github.com/repos/facebook/react/issues/22696/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22696/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22695 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22695/labels{/name} | https://api.github.com/repos/facebook/react/issues/22695/comments | https://api.github.com/repos/facebook/react/issues/22695/events | https://github.com/facebook/react/pull/22695 | 1,044,520,680 | PR_kwDOAJy2Ks4uFWlD | 22,695 | fix: document can be `null`, not just `undefined` | {'login': 'SimenB', 'id': 1404810, 'node_id': 'MDQ6VXNlcjE0MDQ4MTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1404810?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/SimenB', 'html_url': 'https://github.com/SimenB', 'followers_url': 'https://api.github.com/users/SimenB/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 51c558aeb6f5b0ae639d975fd4044007a73115c1...addfc4cd50259873fd0e2df8d7b07767bcfdab93\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-04 09:33:38 | 2021-11-24 21:03:40 | 2021-11-24 20:51:15 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22695', 'html_url': 'https://github.com/facebook/react/pull/22695', 'diff_url': 'https://github.com/facebook/react/pull/22695.diff', 'patch_url': 'https://github.com/facebook/react/pull/22695.patch', 'merged_at': datetime.datetime(2021, 11, 24, 20, 51, 15)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22695/reactions', 'total_count': 5, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22695/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22694 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22694/labels{/name} | https://api.github.com/repos/facebook/react/issues/22694/comments | https://api.github.com/repos/facebook/react/issues/22694/events | https://github.com/facebook/react/pull/22694 | 1,044,479,523 | PR_kwDOAJy2Ks4uFOFc | 22,694 | Company name change, Facebook -> Meta. | {'login': 'oz9un', 'id': 57866851, 'node_id': 'MDQ6VXNlcjU3ODY2ODUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/57866851?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/oz9un', 'html_url': 'https://github.com/oz9un', 'followers_url': 'https://api.github.com/users/oz9un/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"I just changed the comment lines, can you help me about circlecei: sync_reconciler_forks test? @facebook-github-bot ",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 51c558aeb6f5b0ae639d975fd4044007a73115c1...9a50f9f501d78eb53d291117b818729... | 2021-11-04 08:41:23 | 2021-11-04 10:33:30 | 2021-11-04 10:33:29 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22694', 'html_url': 'https://github.com/facebook/react/pull/22694', 'diff_url': 'https://github.com/facebook/react/pull/22694.diff', 'patch_url': 'https://github.com/facebook/react/pull/22694.patch', 'merged_at': None} | Hi!
All occurrences of 'Facebook, Inc' have been changed to 'Meta, Inc'.
Because there are not any coding difference, I did not run any tests.
Hope to see you in Metaverse!,
Ozgun Kultekin. | {'url': 'https://api.github.com/repos/facebook/react/issues/22694/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22694/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22693 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22693/labels{/name} | https://api.github.com/repos/facebook/react/issues/22693/comments | https://api.github.com/repos/facebook/react/issues/22693/events | https://github.com/facebook/react/pull/22693 | 1,044,471,824 | PR_kwDOAJy2Ks4uFMhR | 22,693 | Company name change, Facebook -> Meta. | {'login': 'oz9un', 'id': 57866851, 'node_id': 'MDQ6VXNlcjU3ODY2ODUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/57866851?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/oz9un', 'html_url': 'https://github.com/oz9un', 'followers_url': 'https://api.github.com/users/oz9un/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @oz9un! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us ... | 2021-11-04 08:30:37 | 2021-11-04 09:34:23 | 2021-11-04 08:37:42 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22693', 'html_url': 'https://github.com/facebook/react/pull/22693', 'diff_url': 'https://github.com/facebook/react/pull/22693.diff', 'patch_url': 'https://github.com/facebook/react/pull/22693.patch', 'merged_at': None} | Hi!
All occurrences of 'Facebook, Inc' have been changed to 'Meta, Inc'.
Because there are not any coding difference, I did not run any tests.
Hope to see you in Metaverse!,
Ozgun Kultekin. | {'url': 'https://api.github.com/repos/facebook/react/issues/22693/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22693/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22692 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22692/labels{/name} | https://api.github.com/repos/facebook/react/issues/22692/comments | https://api.github.com/repos/facebook/react/issues/22692/events | https://github.com/facebook/react/issues/22692 | 1,044,380,796 | I_kwDOAJy2Ks4-P_x8 | 22,692 | [React 18] Selective Hydration fails hydration when using context api | {'login': 'maraisr', 'id': 599459, 'node_id': 'MDQ6VXNlcjU5OTQ1OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/599459?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/maraisr', 'html_url': 'https://github.com/maraisr', 'followers_url': 'https://api.github.com/users/maraisr/followers', 'follow... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | open | false | null | [] | null | [
"cc @theKashey ",
"As I understand - any context update invalidates all dehydrated `SuspenseComponent`s. Not sure is it a feature or a bug, and is there any extra flag on Suspense to control this behavior.",
"Perhaps an EventHorizon aka `memo` we can wrap and all is good. As context update not necessarily alter... | 2021-11-04 05:34:09 | 2021-12-09 21:35:20 | null | NONE | null | null | null | Based on the selective hydration example provided by @gaearon ??
https://codesandbox.io/s/mystifying-haibt-39oed
Look out for 👉
One can see that hydrating html does in fact fail when using Context... | {'url': 'https://api.github.com/repos/facebook/react/issues/22692/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22692/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22691 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22691/labels{/name} | https://api.github.com/repos/facebook/react/issues/22691/comments | https://api.github.com/repos/facebook/react/issues/22691/events | https://github.com/facebook/react/pull/22691 | 1,044,062,034 | PR_kwDOAJy2Ks4uD42a | 22,691 | Renamed packages/react-devtools-scheduling-profiler to packages/react-devtools-timeline | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 51c558aeb6f5b0ae639d975fd4044007a73115c1...8f94ea165038b2c5fda69f75ce4001f2a79acdb8\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-03 20:02:23 | 2021-11-04 14:02:08 | 2021-11-04 14:02:06 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22691', 'html_url': 'https://github.com/facebook/react/pull/22691', 'diff_url': 'https://github.com/facebook/react/pull/22691.diff', 'patch_url': 'https://github.com/facebook/react/pull/22691.patch', 'merged_at': datetime.datetime(2021, 11, 4, 14, 2, 6)} | Builds on top of #22690
This PR is just a git move (with a few lines updated to change imports to match). | {'url': 'https://api.github.com/repos/facebook/react/issues/22691/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22691/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22690 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22690/labels{/name} | https://api.github.com/repos/facebook/react/issues/22690/comments | https://api.github.com/repos/facebook/react/issues/22690/events | https://github.com/facebook/react/pull/22690 | 1,043,940,678 | PR_kwDOAJy2Ks4uDeE2 | 22,690 | Rename (some) "scheduling profiler" references to "timeline" | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 255221c86930e31c144713eb466bf0a00ab8fd7e...8750e8d73a2571c24b2e366a6a8c295fa155f663\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-03 18:32:26 | 2021-11-03 19:10:31 | 2021-11-03 19:10:29 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22690', 'html_url': 'https://github.com/facebook/react/pull/22690', 'diff_url': 'https://github.com/facebook/react/pull/22690.diff', 'patch_url': 'https://github.com/facebook/react/pull/22690.patch', 'merged_at': datetime.datetime(2021, 11, 3, 19, 10, 29)} | Rename some code references:
* User facing "Scheduling" label
* TODO comments
* CSS colors
Not included:
* Package names
* Feature flag name | {'url': 'https://api.github.com/repos/facebook/react/issues/22690/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22690/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22689 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22689/labels{/name} | https://api.github.com/repos/facebook/react/issues/22689/comments | https://api.github.com/repos/facebook/react/issues/22689/events | https://github.com/facebook/react/issues/22689 | 1,043,939,816 | I_kwDOAJy2Ks4-OUHo | 22,689 | [DevTools Bug] dispatcher.useId is not a function | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"This issue should be transient and should only affect people using the 18 alpha/beta release.\r\n\r\n#22644 landed two days ago (which added the `useId` hook) and the most recent DevTools release was made 3 days ago. Once the next release goes out, support for `useId` will be included.",
"Would it make sense to ... | 2021-11-03 18:31:39 | 2021-12-21 19:37:00 | 2021-12-21 19:31:43 | COLLABORATOR | null | null | null | ### Website or app
https://c8wik.csb.app/
### Repro steps
1. open https://c8wik.csb.app/
2. Inspect `App`
### How often does this bug happen?
Every time
### DevTools package (automated)
react-devtools-extensions
### DevTools version (automated)
4.21.0-2f8f60ca8
### Error message (automated)
dispatcher.useId... | {'url': 'https://api.github.com/repos/facebook/react/issues/22689/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22689/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22688 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22688/labels{/name} | https://api.github.com/repos/facebook/react/issues/22688/comments | https://api.github.com/repos/facebook/react/issues/22688/events | https://github.com/facebook/react/pull/22688 | 1,043,920,759 | PR_kwDOAJy2Ks4uDZ5c | 22,688 | Fix module-boundary wrappers | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 255221c86930e31c144713eb466bf0a00ab8fd7e...7f91d9d5f5902512a7a1cfd0cec0731d93de9e6d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-03 18:12:23 | 2021-11-04 14:41:27 | 2021-11-04 14:40:35 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22688', 'html_url': 'https://github.com/facebook/react/pull/22688', 'diff_url': 'https://github.com/facebook/react/pull/22688.diff', 'patch_url': 'https://github.com/facebook/react/pull/22688.patch', 'merged_at': datetime.datetime(2021, 11, 4, 14, 40, 35)} | Resolves #22673
Also fixes the scope of `'use strict';` (which the previous change had bumped slightly down in the function, breaking it).
---
Before I added the module boundary wrappers:
```js
/** @license React vundefined
* react.development.js
*
* Copyright (c) Facebook, Inc. and its affiliates.
*
... | {'url': 'https://api.github.com/repos/facebook/react/issues/22688/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22688/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22687 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22687/labels{/name} | https://api.github.com/repos/facebook/react/issues/22687/comments | https://api.github.com/repos/facebook/react/issues/22687/events | https://github.com/facebook/react/pull/22687 | 1,043,915,160 | PR_kwDOAJy2Ks4uDYvZ | 22,687 | Remove duplicate header comment that resulted from build time module-boundary wrapper code | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2021-11-03 18:06:12 | 2021-11-03 18:10:42 | 2021-11-03 18:08:33 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22687', 'html_url': 'https://github.com/facebook/react/pull/22687', 'diff_url': 'https://github.com/facebook/react/pull/22687.diff', 'patch_url': 'https://github.com/facebook/react/pull/22687.patch', 'merged_at': None} | Resolves #22673
Also fixes the scope of `'use strict';` (which had been moved below the header in the previous commit, which I think breaks its functionality).
---
Before I added the module boundary wrappers:
```js
/** @license React vundefined
* react.development.js
*
* Copyright (c) Facebook, Inc. and ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22687/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22687/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22686 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22686/labels{/name} | https://api.github.com/repos/facebook/react/issues/22686/comments | https://api.github.com/repos/facebook/react/issues/22686/events | https://github.com/facebook/react/issues/22686 | 1,043,755,112 | I_kwDOAJy2Ks4-NnBo | 22,686 | Named hooks parsing fails for certain Code Sandbox examples | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"I am no longer able to reproduce this bug today. Interesting."
] | 2021-11-03 15:37:15 | 2021-11-04 14:22:26 | 2021-11-04 14:22:26 | CONTRIBUTOR | null | null | null | Noticed some parsing bugs when writing some example code for React conf. Taking this Sandbox...
https://codesandbox.io/s/keen-bartik-udlpn?file=/src/App.js:58-341
---
This fails by loading neither hook:
```js
function Example({ defaultName = "-", defaultLocation = "-" }) {
const [name, setName] = useState("-"... | {'url': 'https://api.github.com/repos/facebook/react/issues/22686/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22686/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22685 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22685/labels{/name} | https://api.github.com/repos/facebook/react/issues/22685/comments | https://api.github.com/repos/facebook/react/issues/22685/events | https://github.com/facebook/react/issues/22685 | 1,043,642,935 | I_kwDOAJy2Ks4-NLo3 | 22,685 | Bug: use-sync-external-store fails to install via npm | {'login': 'lilactown', 'id': 2687140, 'node_id': 'MDQ6VXNlcjI2ODcxNDA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2687140?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lilactown', 'html_url': 'https://github.com/lilactown', 'followers_url': 'https://api.github.com/users/lilactown/followers... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"@gaearon It's impossible to install use-sync-external-store even with --force or --legacy-peer-deps. How we are supposed to test it? Should we copy-paste it instead? Thank you.",
"This was because the release tagged \"latest\" was a placeholder release that I published before anything had actually been implement... | 2021-11-03 14:06:08 | 2022-02-18 17:10:20 | 2022-02-18 17:10:20 | NONE | null | null | null | When trying to install the `use-sync-external-store` package via npm, I receive an error that it depends on a version of React that doesn't seem to exist.
React version: 17
## Steps To Reproduce
1. `mkdir example && cd example && npm init`
2. `npm i react react-dom use-sync-external-store`
## The current b... | {'url': 'https://api.github.com/repos/facebook/react/issues/22685/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22685/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22684 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22684/labels{/name} | https://api.github.com/repos/facebook/react/issues/22684/comments | https://api.github.com/repos/facebook/react/issues/22684/events | https://github.com/facebook/react/issues/22684 | 1,043,468,253 | I_kwDOAJy2Ks4-Mg_d | 22,684 | Bug: <picture> fetches both <source> and <img> image in Safari on macOS and iOS | {'login': 'simonjohansson', 'id': 736248, 'node_id': 'MDQ6VXNlcjczNjI0OA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/736248?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/simonjohansson', 'html_url': 'https://github.com/simonjohansson', 'followers_url': 'https://api.github.com/users/simonj... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Possible related? https://github.com/facebook/react/issues/20682",
"👋 ",
"I am having a similar issue but with Vue2. So my hunch is that this is a browser issue instead of a React issue. Although it could also be something related to how the virtual dom is implemented. ",
"> Possible related? #20682\r\n\r\n... | 2021-11-03 11:59:30 | 2024-04-17 15:36:09 | 2024-04-17 15:36:09 | NONE | null | null | null | ```
<picture>
<source srcset="https://via.placeholder.com/300x300.webp?text=webp" type="image/webp">
<source srcset="https://via.placeholder.com/300x300.jpg?text=jpg" type="image/jpg">
<img src="https://via.placeholder.com/300x300.jpg?text=jpg">
</picture>
```
Will request **both** `300x300.jpg` and `30... | {'url': 'https://api.github.com/repos/facebook/react/issues/22684/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22684/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/22683 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22683/labels{/name} | https://api.github.com/repos/facebook/react/issues/22683/comments | https://api.github.com/repos/facebook/react/issues/22683/events | https://github.com/facebook/react/pull/22683 | 1,043,393,740 | PR_kwDOAJy2Ks4uB3Tc | 22,683 | Deleted unnecessary console logs | {'login': 'tensenrey', 'id': 67154333, 'node_id': 'MDQ6VXNlcjY3MTU0MzMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/67154333?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tensenrey', 'html_url': 'https://github.com/tensenrey', 'followers_url': 'https://api.github.com/users/tensenrey/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9fb3442250cf198782a08024195fcc5402479160...77cced766e3be5972d34274515b64cdb932f39b8\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-03 10:56:03 | 2021-11-03 14:14:24 | 2021-11-03 14:14:23 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22683', 'html_url': 'https://github.com/facebook/react/pull/22683', 'diff_url': 'https://github.com/facebook/react/pull/22683.diff', 'patch_url': 'https://github.com/facebook/react/pull/22683.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22683/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22683/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22682 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22682/labels{/name} | https://api.github.com/repos/facebook/react/issues/22682/comments | https://api.github.com/repos/facebook/react/issues/22682/events | https://github.com/facebook/react/issues/22682 | 1,042,947,860 | I_kwDOAJy2Ks4-Kh8U | 22,682 | Bug: | {'login': 'Sarkar44', 'id': 92143868, 'node_id': 'U_kgDOBX4A_A', 'avatar_url': 'https://avatars.githubusercontent.com/u/92143868?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Sarkar44', 'html_url': 'https://github.com/Sarkar44', 'followers_url': 'https://api.github.com/users/Sarkar44/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Confirm status"
] | 2021-11-02 23:55:13 | 2021-11-08 23:11:05 | 2021-11-03 06:44:12 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get fixed much fast... | {'url': 'https://api.github.com/repos/facebook/react/issues/22682/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22682/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22681 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22681/labels{/name} | https://api.github.com/repos/facebook/react/issues/22681/comments | https://api.github.com/repos/facebook/react/issues/22681/events | https://github.com/facebook/react/pull/22681 | 1,042,944,968 | PR_kwDOAJy2Ks4uAlHp | 22,681 | Fix useId in strict mode | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9fb3442250cf198782a08024195fcc5402479160...23372a560cd9dae230ffe114fbb647eb9a133bc7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-02 23:48:20 | 2021-11-03 00:59:17 | 2021-11-03 00:59:17 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22681', 'html_url': 'https://github.com/facebook/react/pull/22681', 'diff_url': 'https://github.com/facebook/react/pull/22681.diff', 'patch_url': 'https://github.com/facebook/react/pull/22681.patch', 'merged_at': datetime.datetime(2021, 11, 3, 0, 59, 17)} | Fixes bug reported by @eps1lon here: https://github.com/reactwg/react-18/discussions/111#discussioncomment-1576876
In strict mode, `renderWithHooks` is called twice to flush out side effects.
Modifying the tree context (`pushTreeId` and `pushTreeFork`) is effectful, so before this fix, the tree context was alloca... | {'url': 'https://api.github.com/repos/facebook/react/issues/22681/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22681/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22680 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22680/labels{/name} | https://api.github.com/repos/facebook/react/issues/22680/comments | https://api.github.com/repos/facebook/react/issues/22680/events | https://github.com/facebook/react/pull/22680 | 1,042,647,885 | PR_kwDOAJy2Ks4t_yzy | 22,680 | Replay capture phase for continuous events | {'login': 'salazarm', 'id': 2286579, 'node_id': 'MDQ6VXNlcjIyODY1Nzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2286579?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/salazarm', 'html_url': 'https://github.com/salazarm', 'followers_url': 'https://api.github.com/users/salazarm/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4ff5f5719b348d9d8db14aaa49a48532defb4ab7...bfe806256917218b4e7b6cd2e8c467d03a8d2976\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-02 17:48:17 | 2022-02-10 14:27:38 | 2021-12-02 14:34:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22680', 'html_url': 'https://github.com/facebook/react/pull/22680', 'diff_url': 'https://github.com/facebook/react/pull/22680.diff', 'patch_url': 'https://github.com/facebook/react/pull/22680.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22680/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22680/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22679 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22679/labels{/name} | https://api.github.com/repos/facebook/react/issues/22679/comments | https://api.github.com/repos/facebook/react/issues/22679/events | https://github.com/facebook/react/pull/22679 | 1,042,516,160 | PR_kwDOAJy2Ks4t_XWY | 22,679 | prettify code build js | {'login': 'tensenrey', 'id': 67154333, 'node_id': 'MDQ6VXNlcjY3MTU0MzMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/67154333?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tensenrey', 'html_url': 'https://github.com/tensenrey', 'followers_url': 'https://api.github.com/users/tensenrey/followe... | [] | closed | false | null | [] | null | [
"Hi @DmitryqV! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for ... | 2021-11-02 15:35:56 | 2021-11-02 15:59:37 | 2021-11-02 15:59:29 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22679', 'html_url': 'https://github.com/facebook/react/pull/22679', 'diff_url': 'https://github.com/facebook/react/pull/22679.diff', 'patch_url': 'https://github.com/facebook/react/pull/22679.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22679/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22679/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22678 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22678/labels{/name} | https://api.github.com/repos/facebook/react/issues/22678/comments | https://api.github.com/repos/facebook/react/issues/22678/events | https://github.com/facebook/react/issues/22678 | 1,042,407,845 | I_kwDOAJy2Ks4-IeGl | 22,678 | Improve DevTools CSS variables situation | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"I was looking into it and here is what I have in mind: \r\n\r\nExposing all vars using `style` prop to reach-ui components which will be rendered in Portal (outside the rendered DOM), and we can create wrapper component or re-export the same component by passing all vars:\r\n\r\n```\r\n// lib/reach-ui/MenuList.js\... | 2021-11-02 14:03:53 | 2021-11-08 20:17:22 | 2021-11-08 20:17:22 | CONTRIBUTOR | null | null | null | Related to this comment: https://github.com/facebook/react/pull/22660#pullrequestreview-795368779
The majority of DevTools theme colors are stored in `packages/react-devtools-shared/src/constants`:
https://github.com/facebook/react/blob/5cccacd131242bdea2c2fe4b33fac50d2e3132b4/packages/react-devtools-shared/src/con... | {'url': 'https://api.github.com/repos/facebook/react/issues/22678/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22678/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22677 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22677/labels{/name} | https://api.github.com/repos/facebook/react/issues/22677/comments | https://api.github.com/repos/facebook/react/issues/22677/events | https://github.com/facebook/react/issues/22677 | 1,042,046,690 | I_kwDOAJy2Ks4-HF7i | 22,677 | Profiler doesn't work | {'login': 'Deribolot', 'id': 29717133, 'node_id': 'MDQ6VXNlcjI5NzE3MTMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/29717133?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Deribolot', 'html_url': 'https://github.com/Deribolot', 'followers_url': 'https://api.github.com/users/Deribolot/followe... | [{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Needs%20More%20Information', 'name': 'Resolution: Needs More Information', 'color': 'fffde7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU='... | closed | false | {'login': 'Deribolot', 'id': 29717133.0, 'node_id': 'MDQ6VXNlcjI5NzE3MTMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/29717133?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Deribolot', 'html_url': 'https://github.com/Deribolot', 'followers_url': 'https://api.github.com/users/Deribolot/follo... | [{'login': 'Deribolot', 'id': 29717133, 'node_id': 'MDQ6VXNlcjI5NzE3MTMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/29717133?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Deribolot', 'html_url': 'https://github.com/Deribolot', 'followers_url': 'https://api.github.com/users/Deribolot/follow... | null | [
"@Deribolot We need more information than \"it doesn't work\". What does it do? What are the repro instructions?",
"I'm going to close this issue because it doesn't have enough info for one of us to reproduce it."
] | 2021-11-02 09:04:15 | 2021-11-03 19:55:32 | 2021-11-03 19:55:32 | NONE | null | null | null | Chrome 95.0.4638.69 React 16.8
It worked in 95.0.4638.54 | {'url': 'https://api.github.com/repos/facebook/react/issues/22677/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22677/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22676 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22676/labels{/name} | https://api.github.com/repos/facebook/react/issues/22676/comments | https://api.github.com/repos/facebook/react/issues/22676/events | https://github.com/facebook/react/pull/22676 | 1,041,897,663 | PR_kwDOAJy2Ks4t9gMJ | 22,676 | Improved workers filenames in devtools-inline | {'login': 'akgupta0777', 'id': 51379307, 'node_id': 'MDQ6VXNlcjUxMzc5MzA3', 'avatar_url': 'https://avatars.githubusercontent.com/u/51379307?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/akgupta0777', 'html_url': 'https://github.com/akgupta0777', 'followers_url': 'https://api.github.com/users/akgupta0777... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2021-11-02 05:26:09 | 2021-11-02 14:30:37 | 2021-11-02 14:30:37 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22676', 'html_url': 'https://github.com/facebook/react/pull/22676', 'diff_url': 'https://github.com/facebook/react/pull/22676.diff', 'patch_url': 'https://github.com/facebook/react/pull/22676.patch', 'merged_at': datetime.datetime(2021, 11, 2, 14, 30, 37)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22676/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22676/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22675 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22675/labels{/name} | https://api.github.com/repos/facebook/react/issues/22675/comments | https://api.github.com/repos/facebook/react/issues/22675/events | https://github.com/facebook/react/pull/22675 | 1,041,690,130 | PR_kwDOAJy2Ks4t82BZ | 22,675 | useId: Add regression test for bottom-up passing | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8c4a05b8fb83624d5442f74138e7f263d666fd5d...cbbf54a7903cb9aebef3651b0712a798a0b2ffb2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-01 22:14:02 | 2021-11-23 23:06:02 | 2021-11-23 22:55:32 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22675', 'html_url': 'https://github.com/facebook/react/pull/22675', 'diff_url': 'https://github.com/facebook/react/pull/22675.diff', 'patch_url': 'https://github.com/facebook/react/pull/22675.patch', 'merged_at': None} |
## Summary
Passing test for https://github.com/facebook/react/issues/20127. Was failing with `useOpaqueIdentifier`.
The `useId` tests didn't have any test with passing the value to another component via `useEffect`. Im not particulary bought into this specific pattern. Mostly filing this to get clarification wh... | {'url': 'https://api.github.com/repos/facebook/react/issues/22675/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22675/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22674 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22674/labels{/name} | https://api.github.com/repos/facebook/react/issues/22674/comments | https://api.github.com/repos/facebook/react/issues/22674/events | https://github.com/facebook/react/pull/22674 | 1,041,674,949 | PR_kwDOAJy2Ks4t8yvB | 22,674 | Upgrade useId to alpha channel | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 75f3ddebfa0d9885ce8df42571cf0c09ad6c0a3b...34b52624223614a452600e0d8e9d1d56466631d9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-01 21:53:21 | 2021-11-01 22:26:43 | 2021-11-01 22:26:43 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22674', 'html_url': 'https://github.com/facebook/react/pull/22674', 'diff_url': 'https://github.com/facebook/react/pull/22674.diff', 'patch_url': 'https://github.com/facebook/react/pull/22674.patch', 'merged_at': datetime.datetime(2021, 11, 1, 22, 26, 43)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/22674/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22674/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22673 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22673/labels{/name} | https://api.github.com/repos/facebook/react/issues/22673/comments | https://api.github.com/repos/facebook/react/issues/22673/events | https://github.com/facebook/react/issues/22673 | 1,041,671,598 | I_kwDOAJy2Ks4-FqWu | 22,673 | Avoid duplicate boilerplate header | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 71502270, 'node_id': 'MDU6TGFiZWw3MTUwMjI3MA==', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Build%20Infrastructure', 'name': 'Component: Build Infrastructure', 'color': 'f9d0c4', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [] | 2021-11-01 21:47:08 | 2021-11-04 14:40:35 | 2021-11-04 14:40:35 | CONTRIBUTOR | null | null | null | Follow up on @rickhanlonii's comment: https://github.com/facebook/react/pull/22670#issuecomment-956569098 | {'url': 'https://api.github.com/repos/facebook/react/issues/22673/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22673/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22672 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22672/labels{/name} | https://api.github.com/repos/facebook/react/issues/22672/comments | https://api.github.com/repos/facebook/react/issues/22672/events | https://github.com/facebook/react/pull/22672 | 1,041,662,825 | PR_kwDOAJy2Ks4t8wRS | 22,672 | Remove experimental useOpaqueIdentifier API | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: ebf9ae8579230e7b1ed0b1d243e1cf802f56938b...7553c20a1db0409d06312a531b21ce179381cbef\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-01 21:32:40 | 2021-11-01 22:02:39 | 2021-11-01 22:02:39 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22672', 'html_url': 'https://github.com/facebook/react/pull/22672', 'diff_url': 'https://github.com/facebook/react/pull/22672.diff', 'patch_url': 'https://github.com/facebook/react/pull/22672.patch', 'merged_at': datetime.datetime(2021, 11, 1, 22, 2, 39)} | useId is the updated version of this API. | {'url': 'https://api.github.com/repos/facebook/react/issues/22672/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22672/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22671 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22671/labels{/name} | https://api.github.com/repos/facebook/react/issues/22671/comments | https://api.github.com/repos/facebook/react/issues/22671/events | https://github.com/facebook/react/issues/22671 | 1,041,560,771 | I_kwDOAJy2Ks4-FPTD | 22,671 | Many errors in console even using Error Boundary | {'login': 'BiancaArtola', 'id': 21174759, 'node_id': 'MDQ6VXNlcjIxMTc0NzU5', 'avatar_url': 'https://avatars.githubusercontent.com/u/21174759?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/BiancaArtola', 'html_url': 'https://github.com/BiancaArtola', 'followers_url': 'https://api.github.com/users/BiancaAr... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"Duplicate of: https://github.com/facebook/react/issues/15069"
] | 2021-11-01 20:08:03 | 2021-11-13 21:12:48 | 2021-11-13 21:12:44 | NONE | null | null | null | React version: 17.0.2
Relay version: 12.0.0
## Steps To Reproduce
1. Wrap a component with an ErrorBoundary class to manage errors. Something like this:
```
<ErrorBoundary FallbackComponent={ErrorFallback}>
<Suspense
fallback={
<LoaderContainer>
<Loader... | {'url': 'https://api.github.com/repos/facebook/react/issues/22671/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22671/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22670 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22670/labels{/name} | https://api.github.com/repos/facebook/react/issues/22670/comments | https://api.github.com/repos/facebook/react/issues/22670/events | https://github.com/facebook/react/pull/22670 | 1,041,555,834 | PR_kwDOAJy2Ks4t8hzq | 22,670 | Remove @flow pragma comment from module registration start/stop templates | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a0d991fe6587ad1cd1a97230f62f82c7cb6b9a40...484bf0c7eece038fdeab0244c86f3df19d46177c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-01 20:04:52 | 2021-11-01 21:47:34 | 2021-11-01 21:46:09 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22670', 'html_url': 'https://github.com/facebook/react/pull/22670', 'diff_url': 'https://github.com/facebook/react/pull/22670.diff', 'patch_url': 'https://github.com/facebook/react/pull/22670.patch', 'merged_at': datetime.datetime(2021, 11, 1, 21, 46, 9)} | This results in a duplicate `@flow` pragma in built bundles, which breaks xplat CI. | {'url': 'https://api.github.com/repos/facebook/react/issues/22670/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22670/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22669 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22669/labels{/name} | https://api.github.com/repos/facebook/react/issues/22669/comments | https://api.github.com/repos/facebook/react/issues/22669/events | https://github.com/facebook/react/pull/22669 | 1,041,516,870 | PR_kwDOAJy2Ks4t8cYH | 22,669 | Fix DevTools advanced tooltip display conditional check | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"Looks like HEAD of `main` is broken. Ignore CI failures on this diff."
] | 2021-11-01 19:30:05 | 2021-11-02 15:02:47 | 2021-11-02 15:02:45 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22669', 'html_url': 'https://github.com/facebook/react/pull/22669', 'diff_url': 'https://github.com/facebook/react/pull/22669.diff', 'patch_url': 'https://github.com/facebook/react/pull/22669.patch', 'merged_at': datetime.datetime(2021, 11, 2, 15, 2, 45)} | Previously we would not show the advanced tooltip format unless we had effect durations. This meant that commits with no effects would not properly show their priority level.
Noticed this while creating example content for conf keynote. | {'url': 'https://api.github.com/repos/facebook/react/issues/22669/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22669/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22668 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22668/labels{/name} | https://api.github.com/repos/facebook/react/issues/22668/comments | https://api.github.com/repos/facebook/react/issues/22668/events | https://github.com/facebook/react/pull/22668 | 1,041,286,367 | PR_kwDOAJy2Ks4t7sLM | 22,668 | Fixed up unwindInterruptedWorkBug | {'login': 'Biki-das', 'id': 72331432, 'node_id': 'MDQ6VXNlcjcyMzMxNDMy', 'avatar_url': 'https://avatars.githubusercontent.com/u/72331432?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Biki-das', 'html_url': 'https://github.com/Biki-das', 'followers_url': 'https://api.github.com/users/Biki-das/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a0d991fe6587ad1cd1a97230f62f82c7cb6b9a40...d90fa1b6759a74829bc5df9b550ec5c0b7398423\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-01 15:14:11 | 2024-04-17 15:36:11 | 2024-04-17 15:36:10 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22668', 'html_url': 'https://github.com/facebook/react/pull/22668', 'diff_url': 'https://github.com/facebook/react/pull/22668.diff', 'patch_url': 'https://github.com/facebook/react/pull/22668.patch', 'merged_at': None} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/22668/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22668/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22667 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22667/labels{/name} | https://api.github.com/repos/facebook/react/issues/22667/comments | https://api.github.com/repos/facebook/react/issues/22667/events | https://github.com/facebook/react/pull/22667 | 1,041,241,531 | PR_kwDOAJy2Ks4t7ixf | 22,667 | Varibles should not be initialized to undefined | {'login': 'Biki-das', 'id': 72331432, 'node_id': 'MDQ6VXNlcjcyMzMxNDMy', 'avatar_url': 'https://avatars.githubusercontent.com/u/72331432?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Biki-das', 'html_url': 'https://github.com/Biki-das', 'followers_url': 'https://api.github.com/users/Biki-das/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a0d991fe6587ad1cd1a97230f62f82c7cb6b9a40...d21dabb0d48ed49f80bbfbec69a40a446b101d8c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-01 14:31:21 | 2021-11-01 14:37:26 | 2021-11-01 14:37:26 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22667', 'html_url': 'https://github.com/facebook/react/pull/22667', 'diff_url': 'https://github.com/facebook/react/pull/22667.diff', 'patch_url': 'https://github.com/facebook/react/pull/22667.patch', 'merged_at': None} | fix #22666 | {'url': 'https://api.github.com/repos/facebook/react/issues/22667/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22667/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22666 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22666/labels{/name} | https://api.github.com/repos/facebook/react/issues/22666/comments | https://api.github.com/repos/facebook/react/issues/22666/events | https://github.com/facebook/react/issues/22666 | 1,041,218,486 | I_kwDOAJy2Ks4-D7u2 | 22,666 | Bug: Variables should not be initialized to `undefined` | {'login': 'Biki-das', 'id': 72331432, 'node_id': 'MDQ6VXNlcjcyMzMxNDMy', 'avatar_url': 'https://avatars.githubusercontent.com/u/72331432?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Biki-das', 'html_url': 'https://github.com/Biki-das', 'followers_url': 'https://api.github.com/users/Biki-das/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I don't think we need an issue to track this. Seems like more of a stylistic preference. :) Going to close this. Hope that's okay!"
] | 2021-11-01 14:10:42 | 2021-11-01 14:47:10 | 2021-11-01 14:24:41 | CONTRIBUTOR | null | null | null | found certain files where variables were initialized to `undefined` which is sort of an anti pattern because JS seems to put undefined by default if no value is assigned
file links -:
packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js - Line no-29
packages/react-dom/src/__tests__/ReactDOMServerIntegrat... | {'url': 'https://api.github.com/repos/facebook/react/issues/22666/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22666/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22665 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22665/labels{/name} | https://api.github.com/repos/facebook/react/issues/22665/comments | https://api.github.com/repos/facebook/react/issues/22665/events | https://github.com/facebook/react/pull/22665 | 1,040,639,346 | PR_kwDOAJy2Ks4t5joF | 22,665 | Pin CI to Node 14 | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6c7ef3fce5547da5db3d400ccf95a5023f8891f4...a5b0cff90fd7db6cd09e24779061700db24e8809\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-01 00:58:13 | 2021-11-01 01:02:59 | 2021-11-01 01:01:39 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22665', 'html_url': 'https://github.com/facebook/react/pull/22665', 'diff_url': 'https://github.com/facebook/react/pull/22665.diff', 'patch_url': 'https://github.com/facebook/react/pull/22665.patch', 'merged_at': datetime.datetime(2021, 11, 1, 1, 1, 39)} | CI starting running Node 16, which breaks some of our tests because the error message text for undefined property access has changed.
We should pin to Node 14 until we are able to update the messages. | {'url': 'https://api.github.com/repos/facebook/react/issues/22665/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22665/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22664 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22664/labels{/name} | https://api.github.com/repos/facebook/react/issues/22664/comments | https://api.github.com/repos/facebook/react/issues/22664/events | https://github.com/facebook/react/pull/22664 | 1,040,629,948 | PR_kwDOAJy2Ks4t5hr3 | 22,664 | Re-land #22292 (Remove useMutableSource from open source build) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9db8713f9d08c1956939e33cc2da25c867748263...adacff0bea0bf5c71aabdb6161806c6a56555cd3\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-11-01 00:34:30 | 2021-11-12 20:36:47 | 2021-11-01 04:39:51 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22664', 'html_url': 'https://github.com/facebook/react/pull/22664', 'diff_url': 'https://github.com/facebook/react/pull/22664.diff', 'patch_url': 'https://github.com/facebook/react/pull/22664.patch', 'merged_at': datetime.datetime(2021, 11, 1, 4, 39, 51)} | I had to revert #22292 because there are some internal callers of useMutableSource that we haven't migrated yet. This removes useMutableSource from the open source build but keeps it in the internal one. | {'url': 'https://api.github.com/repos/facebook/react/issues/22664/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22664/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22663 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22663/labels{/name} | https://api.github.com/repos/facebook/react/issues/22663/comments | https://api.github.com/repos/facebook/react/issues/22663/events | https://github.com/facebook/react/issues/22663 | 1,040,584,953 | I_kwDOAJy2Ks4-BhD5 | 22,663 | Navigating to a new tab with DevTools open does not load Components tree | {'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', '... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https:/... | closed | false | {'login': 'jstejada', 'id': 1271509.0, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers',... | [{'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', ... | null | [
"Can i possibly work on this? ",
"Also reproducible in version 4.20.2 (10/25/2021) in chrome browser. reactjs.org works fine and tree is loaded but as soon as we go to facebook.com it doesn't.",
"> Also reproducible in version 4.20.2 (10/25/2021) in chrome browser. reactjs.org works fine and tree is loaded but ... | 2021-10-31 21:21:16 | 2024-04-17 15:36:12 | 2024-04-17 15:36:12 | CONTRIBUTOR | null | null | null | ## Repro
This is reproducible in version v4.21.0 (even after reverting logic to detect duplicate extensions)
1. Load reactjs.org and open DevTools
2. Observe Component tree loads correctly
3. Navigate to facebook.com
4. Component tree does not load
5. Open Chrome DevTools for the extension and observe the fol... | {'url': 'https://api.github.com/repos/facebook/react/issues/22663/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22663/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/22662 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22662/labels{/name} | https://api.github.com/repos/facebook/react/issues/22662/comments | https://api.github.com/repos/facebook/react/issues/22662/events | https://github.com/facebook/react/pull/22662 | 1,040,580,586 | PR_kwDOAJy2Ks4t5X7a | 22,662 | Upgrade useSyncExternalStore to alpha channel | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9c8161ba81220143e7f87bd901697e46b14d8968...14d177f6e823412bd7352620b73651784a786b98\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-10-31 21:00:51 | 2021-10-31 22:38:03 | 2021-10-31 22:38:03 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22662', 'html_url': 'https://github.com/facebook/react/pull/22662', 'diff_url': 'https://github.com/facebook/react/pull/22662.diff', 'patch_url': 'https://github.com/facebook/react/pull/22662.patch', 'merged_at': datetime.datetime(2021, 10, 31, 22, 38, 3)} | Also renames `useSyncExternalStoreExtra` to `useSyncExternalStoreWithSelector`.
- 'use-sync-external-store/shim' -> A shim for `useSyncExternalStore` that works in React 16 and 17 (any release that supports hooks). The module will first check if the built-in React API exists, before falling back to the shim.
- 'use... | {'url': 'https://api.github.com/repos/facebook/react/issues/22662/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22662/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22661 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22661/labels{/name} | https://api.github.com/repos/facebook/react/issues/22661/comments | https://api.github.com/repos/facebook/react/issues/22661/events | https://github.com/facebook/react/pull/22661 | 1,040,577,742 | PR_kwDOAJy2Ks4t5Xaf | 22,661 | React DevTools 4.20.2 -> 4.21.0 | {'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [] | 2021-10-31 20:45:58 | 2021-10-31 23:19:03 | 2021-10-31 23:19:03 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22661', 'html_url': 'https://github.com/facebook/react/pull/22661', 'diff_url': 'https://github.com/facebook/react/pull/22661.diff', 'patch_url': 'https://github.com/facebook/react/pull/22661.patch', 'merged_at': datetime.datetime(2021, 10, 31, 23, 19, 2)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/22661/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22661/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22660 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22660/labels{/name} | https://api.github.com/repos/facebook/react/issues/22660/comments | https://api.github.com/repos/facebook/react/issues/22660/events | https://github.com/facebook/react/pull/22660 | 1,040,255,399 | PR_kwDOAJy2Ks4t4acf | 22,660 | fix(devtools): update menu list css | {'login': 'jyash97', 'id': 22376783, 'node_id': 'MDQ6VXNlcjIyMzc2Nzgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/22376783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jyash97', 'html_url': 'https://github.com/jyash97', 'followers_url': 'https://api.github.com/users/jyash97/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hey @bvaughn 👋\r\n\r\nCan you take a look at this changes, whenever you get time ?",
"Many CI check seems to be failing now. Any idea?\r\n\r\nLooks unrelated to the changes I did in latest commit ",
"Can you try rebasing on `main` ?\r\n\r\n```sh\r\ngit rebase main\r\n```",
"> Now the only thing that's brok... | 2021-10-30 17:26:20 | 2021-11-07 20:09:56 | 2021-11-07 17:29:38 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22660', 'html_url': 'https://github.com/facebook/react/pull/22660', 'diff_url': 'https://github.com/facebook/react/pull/22660.diff', 'patch_url': 'https://github.com/facebook/react/pull/22660.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22660/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22660/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22659 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22659/labels{/name} | https://api.github.com/repos/facebook/react/issues/22659/comments | https://api.github.com/repos/facebook/react/issues/22659/events | https://github.com/facebook/react/pull/22659 | 1,040,230,847 | PR_kwDOAJy2Ks4t4V67 | 22,659 | Removed console.error | {'login': 'Biki-das', 'id': 72331432, 'node_id': 'MDQ6VXNlcjcyMzMxNDMy', 'avatar_url': 'https://avatars.githubusercontent.com/u/72331432?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Biki-das', 'html_url': 'https://github.com/Biki-das', 'followers_url': 'https://api.github.com/users/Biki-das/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9c8161ba81220143e7f87bd901697e46b14d8968...375bf7daa33a09a9da4ae8921dfeaca8cf3aec91\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-10-30 15:49:45 | 2024-04-17 15:36:14 | 2024-04-17 15:36:13 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22659', 'html_url': 'https://github.com/facebook/react/pull/22659', 'diff_url': 'https://github.com/facebook/react/pull/22659.diff', 'patch_url': 'https://github.com/facebook/react/pull/22659.patch', 'merged_at': None} | Hi! Removed console error of this:
**Warning: useLayoutEffect does nothing on the server, because its effect cannot be encoded into the server renderer's output format. This will lead to a mismatch between the initial, non-hydrated UI and the intended UI. To avoid this, useLayoutEffect should only be used in compone... | {'url': 'https://api.github.com/repos/facebook/react/issues/22659/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22659/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22658 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22658/labels{/name} | https://api.github.com/repos/facebook/react/issues/22658/comments | https://api.github.com/repos/facebook/react/issues/22658/events | https://github.com/facebook/react/issues/22658 | 1,040,074,949 | I_kwDOAJy2Ks49_kjF | 22,658 | Bug: State getting reset / (items getting removed) when adding new element to Array | {'login': 'rayanfer32', 'id': 37145078, 'node_id': 'MDQ6VXNlcjM3MTQ1MDc4', 'avatar_url': 'https://avatars.githubusercontent.com/u/37145078?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rayanfer32', 'html_url': 'https://github.com/rayanfer32', 'followers_url': 'https://api.github.com/users/rayanfer32/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You can use *Functional updates* to update the state and it will work:\r\n```bash\r\n setTableRowElements((tableRowElements) => [...tableRowElements, newRow]);\r\n```",
"What was causing the issue over here actually :disappointed: ",
"At that point in your code the array `tableRowElements` is not yet updated. ... | 2021-10-30 07:16:32 | 2021-10-30 16:34:51 | 2021-10-30 16:34:51 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.2
## Steps To Reproduce
1. calling addRow function
... | {'url': 'https://api.github.com/repos/facebook/react/issues/22658/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22658/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22657 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22657/labels{/name} | https://api.github.com/repos/facebook/react/issues/22657/comments | https://api.github.com/repos/facebook/react/issues/22657/events | https://github.com/facebook/react/pull/22657 | 1,040,071,684 | PR_kwDOAJy2Ks4t4CV7 | 22,657 | chore: fix comment typo | {'login': 'hanhan9449', 'id': 28822945, 'node_id': 'MDQ6VXNlcjI4ODIyOTQ1', 'avatar_url': 'https://avatars.githubusercontent.com/u/28822945?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hanhan9449', 'html_url': 'https://github.com/hanhan9449', 'followers_url': 'https://api.github.com/users/hanhan9449/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @hanhan9449! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order fo... | 2021-10-30 06:57:49 | 2021-11-15 15:58:30 | 2021-11-15 15:58:30 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22657', 'html_url': 'https://github.com/facebook/react/pull/22657', 'diff_url': 'https://github.com/facebook/react/pull/22657.diff', 'patch_url': 'https://github.com/facebook/react/pull/22657.patch', 'merged_at': datetime.datetime(2021, 11, 15, 15, 58, 30)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22657/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22657/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22656 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22656/labels{/name} | https://api.github.com/repos/facebook/react/issues/22656/comments | https://api.github.com/repos/facebook/react/issues/22656/events | https://github.com/facebook/react/issues/22656 | 1,040,046,166 | I_kwDOAJy2Ks49_dhW | 22,656 | Bug: "The above error…" should appear after the error message but appears before (for some errors) | {'login': 'sophiebits', 'id': 6820, 'node_id': 'MDQ6VXNlcjY4MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sophiebits', 'html_url': 'https://github.com/sophiebits', 'followers_url': 'https://api.github.com/users/sophiebits/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 3440913459, 'node_id': 'LA_kwDOAJy2Ks7NGCwz', 'url': 'https://api.github.com/repos/facebook/react/label... | open | false | null | [] | null | [
"The input tag should not have any children. Instead of this you should use input and label tag if you want to write text out of input area.",
"Hi @aniler0 – I'm aware. :) But when someone makes this mistake, the reporting of the error should be a little different than it is today, and that's what this bug is abo... | 2021-10-30 04:24:28 | 2023-06-03 21:49:50 | null | COLLABORATOR | null | null | null | React version: both latest (17.0.2) and next (18.0.0-alpha-9c8161ba8-20211028)
## Steps To Reproduce
1. Render `<input>hello</input>` to trigger the "input is a void element tag" error
Link to code example: https://codesandbox.io/s/cocky-matan-ydmys
## The current behavior
Two log lines appear:
1. "The ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22656/reactions', 'total_count': 8, '+1': 8, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22656/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22655 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22655/labels{/name} | https://api.github.com/repos/facebook/react/issues/22655/comments | https://api.github.com/repos/facebook/react/issues/22655/events | https://github.com/facebook/react/issues/22655 | 1,039,993,635 | I_kwDOAJy2Ks49_Qsj | 22,655 | Bug: | {'login': 'cikay', 'id': 24587499, 'node_id': 'MDQ6VXNlcjI0NTg3NDk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/24587499?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cikay', 'html_url': 'https://github.com/cikay', 'followers_url': 'https://api.github.com/users/cikay/followers', 'following_... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hi @cikay, did you encounter any particular issue on component render that made you think of this solution? I am curious to understand the root issue you want to solve here ",
"In the example above, any primitive value (like `count`) would be forever closed over as the initial value (e.g. 0) when the inner \"com... | 2021-10-29 23:50:11 | 2021-11-03 17:46:13 | 2021-11-03 17:46:12 | NONE | null | null | null | I am curious why you do not define the components like the following instead. You have to invoke the component and its returned value for the first time and to re-render the only thing that needs to be done is invoke the returned value which is a function as well.
## The expected definitation
```js
function ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22655/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22655/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22654 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22654/labels{/name} | https://api.github.com/repos/facebook/react/issues/22654/comments | https://api.github.com/repos/facebook/react/issues/22654/events | https://github.com/facebook/react/issues/22654 | 1,039,612,406 | I_kwDOAJy2Ks499zn2 | 22,654 | Bug: setState bail out doesn't work sometimes when updating from an effect | {'login': 'Andarist', 'id': 9800850, 'node_id': 'MDQ6VXNlcjk4MDA4NTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9800850?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Andarist', 'html_url': 'https://github.com/Andarist', 'followers_url': 'https://api.github.com/users/Andarist/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I think this is the same issue as https://github.com/facebook/react/issues/18098. @Andarist Could you check if this is in fact the same issue or explain what the differences are?",
"It looks close enough - thanks for taking a look, I was searching for similar issues but apparently, I've missed this one. "
] | 2021-10-29 14:12:55 | 2021-10-29 14:43:00 | 2021-10-29 14:43:00 | CONTRIBUTOR | null | null | null | ## Description
The codesandboxed example doesnt make much sense, but I've stumbled upon this when trying to handle source change gracefully with `useSubscription`. I've wanted to rely on the bail-out behavior that is documented [here](https://beta.reactjs.org/reference/usestate#passing-the-same-value-to-setstate) bu... | {'url': 'https://api.github.com/repos/facebook/react/issues/22654/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22654/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22653 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22653/labels{/name} | https://api.github.com/repos/facebook/react/issues/22653/comments | https://api.github.com/repos/facebook/react/issues/22653/events | https://github.com/facebook/react/issues/22653 | 1,039,518,900 | I_kwDOAJy2Ks499cy0 | 22,653 | Bug: spread should be sported in jsx | {'login': '44Chann', 'id': 58499162, 'node_id': 'MDQ6VXNlcjU4NDk5MTYy', 'avatar_url': 'https://avatars.githubusercontent.com/u/58499162?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/44Chann', 'html_url': 'https://github.com/44Chann', 'followers_url': 'https://api.github.com/users/44Chann/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2021-10-29 12:31:54 | 2021-10-29 14:35:00 | 2021-10-29 14:35:00 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/22653/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22653/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22652 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22652/labels{/name} | https://api.github.com/repos/facebook/react/issues/22652/comments | https://api.github.com/repos/facebook/react/issues/22652/events | https://github.com/facebook/react/issues/22652 | 1,039,310,873 | I_kwDOAJy2Ks498qAZ | 22,652 | Bug: | {'login': 'Nwawfbgmc34-358', 'id': 93374136, 'node_id': 'U_kgDOBZDGuA', 'avatar_url': 'https://avatars.githubusercontent.com/u/93374136?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Nwawfbgmc34-358', 'html_url': 'https://github.com/Nwawfbgmc34-358', 'followers_url': 'https://api.github.com/users/Nwawfbg... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2021-10-29 08:28:41 | 2021-10-29 08:29:03 | 2021-10-29 08:29:03 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/22652/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22652/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22651 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22651/labels{/name} | https://api.github.com/repos/facebook/react/issues/22651/comments | https://api.github.com/repos/facebook/react/issues/22651/events | https://github.com/facebook/react/issues/22651 | 1,039,193,851 | I_kwDOAJy2Ks498Nb7 | 22,651 | removeEventListner is not working in useEffect return. | {'login': 'chahakshah111', 'id': 81607081, 'node_id': 'MDQ6VXNlcjgxNjA3MDgx', 'avatar_url': 'https://avatars.githubusercontent.com/u/81607081?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/chahakshah111', 'html_url': 'https://github.com/chahakshah111', 'followers_url': 'https://api.github.com/users/chaha... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"You should code like this to remove an eventListener handler.\r\n```\r\nuseEffect(() => {\r\n props.getTradesData();\r\n let interval = setInterval(() => {\r\n props.getTradesData();\r\n }, 5000);\r\n\r\n const fn = () => {\r\n if (document.visibilityState === 'visible') {\r\n console.log(\"visible\... | 2021-10-29 05:51:44 | 2021-10-29 06:26:59 | 2021-10-29 06:26:59 | NONE | null | null | null | I'm removing an event in useEffect return function but I'm not seeing any message in console whenever component unmount. So after even unmounting component I'm seeing "visible" in console whenever I change my tab.
`
useEffect(() => {
props.getTradesData();
let interval = setInterval(() => {
p... | {'url': 'https://api.github.com/repos/facebook/react/issues/22651/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22651/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22650 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22650/labels{/name} | https://api.github.com/repos/facebook/react/issues/22650/comments | https://api.github.com/repos/facebook/react/issues/22650/events | https://github.com/facebook/react/issues/22650 | 1,039,035,115 | I_kwDOAJy2Ks497mrr | 22,650 | React 18 - Internal React error if throwing on hook cleanup function. | {'login': 'andrew-w-ross', 'id': 14924726, 'node_id': 'MDQ6VXNlcjE0OTI0NzI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/14924726?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/andrew-w-ross', 'html_url': 'https://github.com/andrew-w-ross', 'followers_url': 'https://api.github.com/users/andre... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710400704, 'node_id': 'MDU6TGFiZWw3MTA0MDA3MDQ=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | null | [] | null | [
"I’m also experiencing this with other React versions on React Native, as well as with React 17.0.x production builds (but not dev builds) on web. See the above-linked RN issue.",
"@gaearon If anyone has not yet picked this yet, may I give it a shot?",
"This warning comes up a lot after I've upgraded to RN 0.67... | 2021-10-28 23:37:02 | 2023-06-14 08:13:38 | null | NONE | null | null | null | Running the following test:
```javascript
import React, { useEffect } from "react";
import { create } from "react-test-renderer";
const Boom = () => {
useEffect(() => {
return () => {
throw new Error("Boom");
};
}, []);
return null;
};
it("prints an error to t... | {'url': 'https://api.github.com/repos/facebook/react/issues/22650/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22650/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22649 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22649/labels{/name} | https://api.github.com/repos/facebook/react/issues/22649/comments | https://api.github.com/repos/facebook/react/issues/22649/events | https://github.com/facebook/react/pull/22649 | 1,038,932,778 | PR_kwDOAJy2Ks4t0YxQ | 22,649 | [DevTools] Add open in editor | {'login': 'ezzak', 'id': 20268283, 'node_id': 'MDQ6VXNlcjIwMjY4Mjgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/20268283?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ezzak', 'html_url': 'https://github.com/ezzak', 'followers_url': 'https://api.github.com/users/ezzak/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"Give me a few minutes. I'll take a look this morning.",
"@Sarkar44 If you have specific suggestions or ideas, they're welcome, but please don't leave vague comments on PRs. (I've noticed a few comments in the past 24 hours like this so I'm mentioning it explicitly.)",
"Updated to make the url configurable:\r\n... | 2021-10-28 20:37:01 | 2021-11-03 16:41:44 | 2021-11-03 15:27:30 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22649', 'html_url': 'https://github.com/facebook/react/pull/22649', 'diff_url': 'https://github.com/facebook/react/pull/22649.diff', 'patch_url': 'https://github.com/facebook/react/pull/22649.patch', 'merged_at': datetime.datetime(2021, 11, 3, 15, 27, 30)} | ## Summary
Add ability to view the current component in your code editor.
## Test Plan
Open with vscode (default behavior):
https://user-images.githubusercontent.com/20268283/139626389-81eda89a-2f69-4e6b-8a2b-2df6f6e093e7.mov
Open in sublime (customized behavior):
https://user-images.githubuserconte... | {'url': 'https://api.github.com/repos/facebook/react/issues/22649/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22649/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22648 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22648/labels{/name} | https://api.github.com/repos/facebook/react/issues/22648/comments | https://api.github.com/repos/facebook/react/issues/22648/events | https://github.com/facebook/react/pull/22648 | 1,038,804,705 | PR_kwDOAJy2Ks4tz9WE | 22,648 | Updating Purecomponent code | {'login': 'Biki-das', 'id': 72331432, 'node_id': 'MDQ6VXNlcjcyMzMxNDMy', 'avatar_url': 'https://avatars.githubusercontent.com/u/72331432?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Biki-das', 'html_url': 'https://github.com/Biki-das', 'followers_url': 'https://api.github.com/users/Biki-das/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9c8161ba81220143e7f87bd901697e46b14d8968...d578c7f8bd4f0a11467ba27dd3564f5b1ece19de\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-10-28 18:12:49 | 2021-11-21 13:56:57 | 2021-11-21 13:56:57 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22648', 'html_url': 'https://github.com/facebook/react/pull/22648', 'diff_url': 'https://github.com/facebook/react/pull/22648.diff', 'patch_url': 'https://github.com/facebook/react/pull/22648.patch', 'merged_at': None} | tried to reduce some redundant logic and i used the `Object.create` instead of the `newObject` | {'url': 'https://api.github.com/repos/facebook/react/issues/22648/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22648/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22647 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22647/labels{/name} | https://api.github.com/repos/facebook/react/issues/22647/comments | https://api.github.com/repos/facebook/react/issues/22647/events | https://github.com/facebook/react/pull/22647 | 1,038,768,239 | PR_kwDOAJy2Ks4tz1Y4 | 22,647 | [do not merge] Test PR | {'login': 'salazarm', 'id': 2286579, 'node_id': 'MDQ6VXNlcjIyODY1Nzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2286579?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/salazarm', 'html_url': 'https://github.com/salazarm', 'followers_url': 'https://api.github.com/users/salazarm/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fdc1d617a44cb9015c3bac3a6341b5af3311faf6...4b41b762053dd4ca7cd7f4a0de10fe9ac09a7e1a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-10-28 17:38:34 | 2022-02-10 14:27:32 | 2022-02-10 14:27:32 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22647', 'html_url': 'https://github.com/facebook/react/pull/22647', 'diff_url': 'https://github.com/facebook/react/pull/22647.diff', 'patch_url': 'https://github.com/facebook/react/pull/22647.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22647/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22647/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22646 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22646/labels{/name} | https://api.github.com/repos/facebook/react/issues/22646/comments | https://api.github.com/repos/facebook/react/issues/22646/events | https://github.com/facebook/react/issues/22646 | 1,038,663,734 | I_kwDOAJy2Ks496MA2 | 22,646 | Add e2e tests for inline package | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 71502270, 'node_id': 'MDU6TGFiZWw3MTUwMjI3MA==', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Build%20Infrastructure', 'name': 'Component: Build Infrastructure', 'color': 'f9d0c4', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': ... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Speaking of libraries which one we should use, `Cypress` or `jest-puppeteer` for E2E testing ? I think Cypress is a great choice.",
"Would like to work on this, Puppeter would be a good choice for this",
"If we use puppeteer we can only test extension on chrome.\r\nBut with cypress E2E tests can run on firefox... | 2021-10-28 15:38:19 | 2022-01-04 15:28:03 | 2022-01-04 15:28:03 | CONTRIBUTOR | null | null | null | DevTools has good unit test coverage but no e2e test coverage. This is because the support for testing _extensions_ is pretty limited in e2e testing libraries. That being said, we could probably get 80% of the value of e2e testing leveraging our `react-devtools-inline` package.
We should create a few example tests (... | {'url': 'https://api.github.com/repos/facebook/react/issues/22646/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 3, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22646/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22645 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22645/labels{/name} | https://api.github.com/repos/facebook/react/issues/22645/comments | https://api.github.com/repos/facebook/react/issues/22645/events | https://github.com/facebook/react/pull/22645 | 1,038,619,232 | PR_kwDOAJy2Ks4tzWck | 22,645 | Reapply changes from #22631 | {'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | {'login': 'jstejada', 'id': 1271509.0, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers',... | [{'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', ... | null | [
"@Sarkar44 Not sure what your comment is referencing but this PR has already been merged."
] | 2021-10-28 14:56:31 | 2021-10-29 14:07:05 | 2021-10-28 15:04:27 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22645', 'html_url': 'https://github.com/facebook/react/pull/22645', 'diff_url': 'https://github.com/facebook/react/pull/22645.diff', 'patch_url': 'https://github.com/facebook/react/pull/22645.patch', 'merged_at': datetime.datetime(2021, 10, 28, 15, 4, 27)} | Accidentally reverted these in #22638
Audited the commits listed here to make sure none of those changes were missed: https://github.com/facebook/react/pull/22638#issuecomment-953875125 | {'url': 'https://api.github.com/repos/facebook/react/issues/22645/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22645/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22644 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22644/labels{/name} | https://api.github.com/repos/facebook/react/issues/22644/comments | https://api.github.com/repos/facebook/react/issues/22644/events | https://github.com/facebook/react/pull/22644 | 1,038,569,509 | PR_kwDOAJy2Ks4tzMCQ | 22,644 | useId | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a0d991fe6587ad1cd1a97230f62f82c7cb6b9a40...371302f0144079a7b9f04c3c485ee19cf82b936f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-10-28 14:12:09 | 2021-11-02 16:23:37 | 2021-11-01 20:30:45 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22644', 'html_url': 'https://github.com/facebook/react/pull/22644', 'diff_url': 'https://github.com/facebook/react/pull/22644.diff', 'patch_url': 'https://github.com/facebook/react/pull/22644.patch', 'merged_at': datetime.datetime(2021, 11, 1, 20, 30, 45)} | - [x] Incremental hydration
- [x] Empty nodes inside arrays
- [x] Long sequences (> 32 bits)
- [x] Add comments to explain the id generation algorithm
- [x] In Fiber, find better way to get the number of children in the current set. Might need to store this on the parent fiber. [Ended up storing this on the context... | {'url': 'https://api.github.com/repos/facebook/react/issues/22644/reactions', 'total_count': 37, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 18, 'confused': 0, 'heart': 10, 'rocket': 0, 'eyes': 7} | https://api.github.com/repos/facebook/react/issues/22644/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22643 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22643/labels{/name} | https://api.github.com/repos/facebook/react/issues/22643/comments | https://api.github.com/repos/facebook/react/issues/22643/events | https://github.com/facebook/react/issues/22643 | 1,038,559,348 | I_kwDOAJy2Ks495yh0 | 22,643 | React 18: hydrateRoot does not issue hydration warnings if initial children is missing | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"```js\r\nconst root = hydrateRoot(container);\r\nroot.render(<input />);\r\n```\r\n-- https://codesandbox.io/s/react-18-bad-hydrateroot-usage-fdkep7\r\n\r\nnow issues both a warning for incorrect usage of `hydrateRoot` and a recoverable error because `root.render` issues an early update before hydration could fini... | 2021-10-28 14:03:30 | 2022-03-05 11:50:37 | 2022-03-05 11:50:37 | COLLABORATOR | null | null | null | I just realized that the way I was using the new `hydrateRoot` API was completely wrong. Unfortunately, React issued no warnings when omitting the initial children like so
```jsx
const container = document.getElementById("root");
container.innerHTML = renderToString(<input />);
const root = hydrateRoot(containe... | {'url': 'https://api.github.com/repos/facebook/react/issues/22643/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22643/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22642 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22642/labels{/name} | https://api.github.com/repos/facebook/react/issues/22642/comments | https://api.github.com/repos/facebook/react/issues/22642/events | https://github.com/facebook/react/pull/22642 | 1,038,171,980 | PR_kwDOAJy2Ks4tx4nz | 22,642 | Repair support for eslint 8 | {'login': 'klassm', 'id': 498976, 'node_id': 'MDQ6VXNlcjQ5ODk3Ng==', 'avatar_url': 'https://avatars.githubusercontent.com/u/498976?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/klassm', 'html_url': 'https://github.com/klassm', 'followers_url': 'https://api.github.com/users/klassm/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2021-10-28 07:24:53 | 2021-10-28 07:27:52 | 2021-10-28 07:27:51 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22642', 'html_url': 'https://github.com/facebook/react/pull/22642', 'diff_url': 'https://github.com/facebook/react/pull/22642.diff', 'patch_url': 'https://github.com/facebook/react/pull/22642.patch', 'merged_at': None} |
## Summary
When currently running eslint with eslint-plugin-react-hooks enabled, the build fails with "Rules with suggestions must set the `meta.hasSuggestions` property to `true`.".
When actually setting this property, the error goes away.
## How did you test this change?
I tried out the change in an actua... | {'url': 'https://api.github.com/repos/facebook/react/issues/22642/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22642/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22641 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22641/labels{/name} | https://api.github.com/repos/facebook/react/issues/22641/comments | https://api.github.com/repos/facebook/react/issues/22641/events | https://github.com/facebook/react/issues/22641 | 1,038,112,815 | I_kwDOAJy2Ks494Fgv | 22,641 | Bug: Errno:-2; code:'ENOENT', why FF stable is set to detect first ? why not a choice? | {'login': 'RajrupDasid', 'id': 60233333, 'node_id': 'MDQ6VXNlcjYwMjMzMzMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/60233333?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/RajrupDasid', 'html_url': 'https://github.com/RajrupDasid', 'followers_url': 'https://api.github.com/users/RajrupDasid... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2021-10-28 05:58:34 | 2022-07-17 18:50:03 | 2022-07-17 18:50:03 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:17.0.1
## Steps To Reproduce
1.On Manjaro after uninstalling... | {'url': 'https://api.github.com/repos/facebook/react/issues/22641/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22641/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22640 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22640/labels{/name} | https://api.github.com/repos/facebook/react/issues/22640/comments | https://api.github.com/repos/facebook/react/issues/22640/events | https://github.com/facebook/react/issues/22640 | 1,038,007,562 | I_kwDOAJy2Ks493r0K | 22,640 | [react-is] The major versions of react and react-is must be peerDependencies related. | {'login': 'ashidaharo', 'id': 47776825, 'node_id': 'MDQ6VXNlcjQ3Nzc2ODI1', 'avatar_url': 'https://avatars.githubusercontent.com/u/47776825?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ashidaharo', 'html_url': 'https://github.com/ashidaharo', 'followers_url': 'https://api.github.com/users/ashidaharo/fol... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | open | false | null | [] | null | [
"...When I think about it again after creating this issue, it seems to be a problem with react 17.\r\nReact 17 claims to \"React 17 enables gradual React upgrades.\" However, react-is, which implicitly depends on react, is clearly not well adapted to such behavior.",
"See https://github.com/facebook/react/issues/... | 2021-10-28 02:05:16 | 2021-10-28 13:34:27 | null | NONE | null | null | null | (This is not directly related to React 18, but it is a discussion about breaking changes, so I'm proposing it as a topic for the next major release.)
Clearly react-is works on the assumption that it will be used with a matching version of react.
Therefore, **react should be listed as a peerDependencies of react-is.**... | {'url': 'https://api.github.com/repos/facebook/react/issues/22640/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22640/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22639 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22639/labels{/name} | https://api.github.com/repos/facebook/react/issues/22639/comments | https://api.github.com/repos/facebook/react/issues/22639/events | https://github.com/facebook/react/pull/22639 | 1,037,952,886 | PR_kwDOAJy2Ks4txL00 | 22,639 | fix typo in comment, guarangee -> guarantee | {'login': 'LizhenQiao', 'id': 52768839, 'node_id': 'MDQ6VXNlcjUyNzY4ODM5', 'avatar_url': 'https://avatars.githubusercontent.com/u/52768839?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/LizhenQiao', 'html_url': 'https://github.com/LizhenQiao', 'followers_url': 'https://api.github.com/users/LizhenQiao/fol... | [] | closed | false | null | [] | null | [
"Hi @LizhenQiao! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order fo... | 2021-10-27 23:53:56 | 2021-11-15 15:53:44 | 2021-11-15 15:53:44 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22639', 'html_url': 'https://github.com/facebook/react/pull/22639', 'diff_url': 'https://github.com/facebook/react/pull/22639.diff', 'patch_url': 'https://github.com/facebook/react/pull/22639.patch', 'merged_at': None} | ## Summary
Fixed minor typo in comment.
guarangee -> guarantee | {'url': 'https://api.github.com/repos/facebook/react/issues/22639/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22639/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22638 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22638/labels{/name} | https://api.github.com/repos/facebook/react/issues/22638/comments | https://api.github.com/repos/facebook/react/issues/22638/events | https://github.com/facebook/react/pull/22638 | 1,037,787,034 | PR_kwDOAJy2Ks4twpSC | 22,638 | Revert logic for checking for duplicate installations of DevTools | {'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | {'login': 'jstejada', 'id': 1271509.0, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers',... | [{'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', ... | null | [
"I think this PR reverted #22631 by accident. I spot checked and _I don't think_ anything else got reverted, so maybe we're okay to just re-add that change.\r\n\r\nIf we wanted to be really careful though, maybe we should revert this commit itself (using `git revert`) and then revert the duplicate detection feature... | 2021-10-27 19:30:28 | 2021-10-28 14:01:44 | 2021-10-27 20:34:44 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22638', 'html_url': 'https://github.com/facebook/react/pull/22638', 'diff_url': 'https://github.com/facebook/react/pull/22638.diff', 'patch_url': 'https://github.com/facebook/react/pull/22638.patch', 'merged_at': datetime.datetime(2021, 10, 27, 20, 34, 44)} | ## Summary
This commit fully reverts the logic to check for duplicate extensions, since it /seems/ to be the root cause of https://github.com/facebook/react/issues/22636.
This is unconfirmed, since we haven't been able to get a reliable repro case for it, and there seem to be different types of ways in this can h... | {'url': 'https://api.github.com/repos/facebook/react/issues/22638/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22638/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22637 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22637/labels{/name} | https://api.github.com/repos/facebook/react/issues/22637/comments | https://api.github.com/repos/facebook/react/issues/22637/events | https://github.com/facebook/react/pull/22637 | 1,037,747,601 | PR_kwDOAJy2Ks4twgwA | 22,637 | More robust act async detection | {'login': 'getsaf', 'id': 10538908, 'node_id': 'MDQ6VXNlcjEwNTM4OTA4', 'avatar_url': 'https://avatars.githubusercontent.com/u/10538908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/getsaf', 'html_url': 'https://github.com/getsaf', 'followers_url': 'https://api.github.com/users/getsaf/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Hi @getsaf! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us... | 2021-10-27 18:49:51 | 2024-04-17 15:36:15 | 2024-04-17 15:36:15 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22637', 'html_url': 'https://github.com/facebook/react/pull/22637', 'diff_url': 'https://github.com/facebook/react/pull/22637.diff', 'patch_url': 'https://github.com/facebook/react/pull/22637.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22637/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 2, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22637/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22636 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22636/labels{/name} | https://api.github.com/repos/facebook/react/issues/22636/comments | https://api.github.com/repos/facebook/react/issues/22636/events | https://github.com/facebook/react/issues/22636 | 1,037,640,841 | I_kwDOAJy2Ks492SSJ | 22,636 | DevTools can't load Components tree in Components Tab | {'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', '... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | {'login': 'jstejada', 'id': 1271509.0, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers',... | [{'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', ... | null | [
"I seem to be having same issue, Component tree is no longer loaded recently....\r\n\r\n\r\n",
"> I seem to be having same issue, Component tree is no longer loaded recently....\r\n> \r\n> ![image](https... | 2021-10-27 16:49:04 | 2022-04-27 05:37:18 | null | CONTRIBUTOR | null | null | null | ## Summary
There's a mix of several different issues that result in the Components tree not being able to load, which happens inconsistently.
In some cases, after trying out a different build of DevTools with a potential fix, the issue seems to fully resolve itself, even after going back to using the "bad" build... | {'url': 'https://api.github.com/repos/facebook/react/issues/22636/reactions', 'total_count': 7, '+1': 7, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22636/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22635 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22635/labels{/name} | https://api.github.com/repos/facebook/react/issues/22635/comments | https://api.github.com/repos/facebook/react/issues/22635/events | https://github.com/facebook/react/pull/22635 | 1,037,604,621 | PR_kwDOAJy2Ks4twD5m | 22,635 | DevTools supports ENV-injected version for better internal bug reports | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2021-10-27 16:10:15 | 2021-10-28 21:15:32 | 2021-10-27 21:18:48 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22635', 'html_url': 'https://github.com/facebook/react/pull/22635', 'diff_url': 'https://github.com/facebook/react/pull/22635.diff', 'patch_url': 'https://github.com/facebook/react/pull/22635.patch', 'merged_at': datetime.datetime(2021, 10, 27, 21, 18, 48)} | Internal version numbers use a 4-digit format (e.g. 4.20.2.0) but the version shown in the settings dialog is the 3-digit format, plus a Git commit hash (e.g. 4.20.2-c213030b4). This means we have to map between the two when internal users report DevTools bugs, which can be a little confusing.
Internally, the 4-digi... | {'url': 'https://api.github.com/repos/facebook/react/issues/22635/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22635/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22634 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22634/labels{/name} | https://api.github.com/repos/facebook/react/issues/22634/comments | https://api.github.com/repos/facebook/react/issues/22634/events | https://github.com/facebook/react/issues/22634 | 1,037,495,739 | I_kwDOAJy2Ks491u27 | 22,634 | Await detection in act() is not compatible with react-native | {'login': 'getsaf', 'id': 10538908, 'node_id': 'MDQ6VXNlcjEwNTM4OTA4', 'avatar_url': 'https://avatars.githubusercontent.com/u/10538908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/getsaf', 'html_url': 'https://github.com/getsaf', 'followers_url': 'https://api.github.com/users/getsaf/followers', 'follow... | [{'id': 139734344, 'node_id': 'MDU6TGFiZWwxMzk3MzQzNDQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Test%20Utils', 'name': 'Component: Test Utils', 'color': 'eb6420', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github... | closed | false | null | [] | null | [
"@getsaf Having the same issue and your patch worked like a charm",
"let's commit this fix.",
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioriti... | 2021-10-27 14:29:46 | 2024-04-17 15:36:17 | 2024-04-17 15:36:16 | NONE | null | null | null | I'm posting this here to get some feedback on a potential fix for this issue. I have a work-around (see below) but would like some guidance on whether or not this workaround is sand and satisfies the original intent of the await detection.
[Related issue in `@testing-library/react-native` repo](https://github.com/ca... | {'url': 'https://api.github.com/repos/facebook/react/issues/22634/reactions', 'total_count': 8, '+1': 8, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22634/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/22633 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22633/labels{/name} | https://api.github.com/repos/facebook/react/issues/22633/comments | https://api.github.com/repos/facebook/react/issues/22633/events | https://github.com/facebook/react/issues/22633 | 1,037,234,908 | I_kwDOAJy2Ks490vLc | 22,633 | Bug: `Cannot update a component (xxx) while rendering a different component (yyy)` on user click | {'login': 'alicerocheman', 'id': 21168856, 'node_id': 'MDQ6VXNlcjIxMTY4ODU2', 'avatar_url': 'https://avatars.githubusercontent.com/u/21168856?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/alicerocheman', 'html_url': 'https://github.com/alicerocheman', 'followers_url': 'https://api.github.com/users/alice... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"I couldn't find a reference for this, but it's possible that *you're not allowed to do side-effects in the updater-function you pass to a `setState`*.\r\n(i'm assuming `setIsOpen` comes from a `const [isOpen, setIsOpen] = useState(...)`).\r\n\r\nI.e. I don't think something like this is allowed:\r\n```js\r\nconst ... | 2021-10-27 10:15:00 | 2024-04-17 16:04:18 | 2024-04-17 16:04:17 | NONE | null | null | null | I'm encountering the `Cannot update a component (xxx) while rendering a different component (yyy)` on **user click**.
The state setter is called inside a useCallback, which is called several components "below", inside a useCallback.
As the user decides when they click, I don't understand how I could prevent this err... | {'url': 'https://api.github.com/repos/facebook/react/issues/22633/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22633/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/22632 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22632/labels{/name} | https://api.github.com/repos/facebook/react/issues/22632/comments | https://api.github.com/repos/facebook/react/issues/22632/events | https://github.com/facebook/react/pull/22632 | 1,037,137,561 | PR_kwDOAJy2Ks4tujcp | 22,632 | mark webpack as optional for react-server-dom-webpack | {'login': 'huozhi', 'id': 4800338, 'node_id': 'MDQ6VXNlcjQ4MDAzMzg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4800338?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/huozhi', 'html_url': 'https://github.com/huozhi', 'followers_url': 'https://api.github.com/users/huozhi/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @huozhi! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us... | 2021-10-27 08:40:05 | 2021-10-27 21:07:27 | 2021-10-27 21:07:24 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22632', 'html_url': 'https://github.com/facebook/react/pull/22632', 'diff_url': 'https://github.com/facebook/react/pull/22632.diff', 'patch_url': 'https://github.com/facebook/react/pull/22632.patch', 'merged_at': None} | ## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
Mark webpack as optional peer depdenency for case that when flight plugin is not been used.
| {'url': 'https://api.github.com/repos/facebook/react/issues/22632/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22632/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22631 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22631/labels{/name} | https://api.github.com/repos/facebook/react/issues/22631/comments | https://api.github.com/repos/facebook/react/issues/22631/events | https://github.com/facebook/react/pull/22631 | 1,036,769,048 | PR_kwDOAJy2Ks4ttXtG | 22,631 | Enable 'Reload and Start Profiling' for Microsoft Edge | {'login': 'eoandersson', 'id': 24208371, 'node_id': 'MDQ6VXNlcjI0MjA4Mzcx', 'avatar_url': 'https://avatars.githubusercontent.com/u/24208371?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eoandersson', 'html_url': 'https://github.com/eoandersson', 'followers_url': 'https://api.github.com/users/eoandersson... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Unsubscribe\n\nOn Wed, Oct 27, 2021, 3:22 AM Erik Andersson ***@***.***>\nwrote:\n\n> Summary\n>\n> The 'Reload and Start Profiling' button was disabled for Microsoft Edge,\n> as noted in issue #22630 <https://github.com/facebook/react/issues/22630>.\n> This change enables it instead.\n> How did you test this chan... | 2021-10-26 21:45:23 | 2021-10-27 15:31:17 | 2021-10-27 14:20:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22631', 'html_url': 'https://github.com/facebook/react/pull/22631', 'diff_url': 'https://github.com/facebook/react/pull/22631.diff', 'patch_url': 'https://github.com/facebook/react/pull/22631.patch', 'merged_at': datetime.datetime(2021, 10, 27, 14, 20, 7)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22631/reactions', 'total_count': 5, '+1': 1, '-1': 0, 'laugh': 1, 'hooray': 1, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/22631/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22630 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22630/labels{/name} | https://api.github.com/repos/facebook/react/issues/22630/comments | https://api.github.com/repos/facebook/react/issues/22630/events | https://github.com/facebook/react/issues/22630 | 1,036,539,142 | I_kwDOAJy2Ks49yFUG | 22,630 | [DevTools Bug]: "Reload and start profiling" button is missing on Microsoft Edge | {'login': 'yifanwww', 'id': 55199350, 'node_id': 'MDQ6VXNlcjU1MTk5MzUw', 'avatar_url': 'https://avatars.githubusercontent.com/u/55199350?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yifanwww', 'html_url': 'https://github.com/yifanwww', 'followers_url': 'https://api.github.com/users/yifanwww/followers',... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"From what I can gather, in React this feature is currently only enabled for the Chrome extension, see here: https://github.com/facebook/react/blob/main/packages/react-devtools-extensions/src/main.js#L206\r\n\r\nIf this is something that should be included for the Edge extension as well I'd be happy to work on this... | 2021-10-26 16:59:53 | 2024-01-22 15:57:10 | 2021-10-27 17:14:04 | NONE | null | null | null | ### Website or app
Any development URL are ok
### Repro steps
1. Open the React Developer Tools extension on Chrome and navigate to the Profiler tab. Note the presence of the "Reload and start profiling" button.
2. Open the React Developer Tools extension on Microsoft Edge and navigate to the Profiler tab. Note the... | {'url': 'https://api.github.com/repos/facebook/react/issues/22630/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22630/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22629 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22629/labels{/name} | https://api.github.com/repos/facebook/react/issues/22629/comments | https://api.github.com/repos/facebook/react/issues/22629/events | https://github.com/facebook/react/pull/22629 | 1,036,373,149 | PR_kwDOAJy2Ks4tsEqq | 22,629 | Throw on hydration mismatch and force client rendering if boundary hasn't suspended within concurrent root | {'login': 'salazarm', 'id': 2286579, 'node_id': 'MDQ6VXNlcjIyODY1Nzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2286579?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/salazarm', 'html_url': 'https://github.com/salazarm', 'followers_url': 'https://api.github.com/users/salazarm/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 327d5c48454aaee0d78fa69b7ef96a14605bf93b...646472f5f2ca1442ba64f86f7d42bae693546548\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-10-26 14:28:32 | 2022-02-10 14:28:08 | 2021-11-09 18:40:50 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22629', 'html_url': 'https://github.com/facebook/react/pull/22629', 'diff_url': 'https://github.com/facebook/react/pull/22629.diff', 'patch_url': 'https://github.com/facebook/react/pull/22629.patch', 'merged_at': datetime.datetime(2021, 11, 9, 18, 40, 50)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22629/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22629/timeline | null | null | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.