url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/22219 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22219/labels{/name} | https://api.github.com/repos/facebook/react/issues/22219/comments | https://api.github.com/repos/facebook/react/issues/22219/events | https://github.com/facebook/react/issues/22219 | 983,560,156 | MDU6SXNzdWU5ODM1NjAxNTY= | 22,219 | Bug: React Command Prompt npm is Not Working | {'login': 'nallalayaswanth', 'id': 80120828, 'node_id': 'MDQ6VXNlcjgwMTIwODI4', 'avatar_url': 'https://avatars.githubusercontent.com/u/80120828?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nallalayaswanth', 'html_url': 'https://github.com/nallalayaswanth', 'followers_url': 'https://api.github.com/users... | [{'id': 1168115654, 'node_id': 'MDU6TGFiZWwxMTY4MTE1NjU0', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Support%20Redirect', 'name': 'Resolution: Support Redirect', 'color': '106099', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"Sorry to hear you're having trouble.\r\n\r\nThis repository is only for problems related to the React library. For Create React App please [file an issue in facebook/create-react-app](https://github.com/facebook/create-react-app/issues/new/choose)."
] | 2021-08-31 07:58:01 | 2021-08-31 08:08:50 | 2021-08-31 08:08:36 | NONE | null | null | null |
React version: 17.0.2
Node Version : v16
## Steps To Reproduce
1.npx create-react-app react-project
2.cd my react-project
3.npm start
## The current behavior
1.Extension reports: npm ERR! code EUNSUPPORTEDPROTOCOL
Note: While Executing a project Npm Error is coming and there is a bug on that n... | {'url': 'https://api.github.com/repos/facebook/react/issues/22219/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22219/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22218 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22218/labels{/name} | https://api.github.com/repos/facebook/react/issues/22218/comments | https://api.github.com/repos/facebook/react/issues/22218/events | https://github.com/facebook/react/pull/22218 | 983,558,877 | MDExOlB1bGxSZXF1ZXN0NzIzMTE1ODU3 | 22,218 | Anunay Contribution | {'login': 'anunaytiwari2', 'id': 88381579, 'node_id': 'MDQ6VXNlcjg4MzgxNTc5', 'avatar_url': 'https://avatars.githubusercontent.com/u/88381579?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anunaytiwari2', 'html_url': 'https://github.com/anunaytiwari2', 'followers_url': 'https://api.github.com/users/anuna... | [] | closed | false | null | [] | null | [
"Hi @anunaytiwari2! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order... | 2021-08-31 07:56:28 | 2021-09-06 18:57:21 | 2021-09-06 18:57:21 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22218', 'html_url': 'https://github.com/facebook/react/pull/22218', 'diff_url': 'https://github.com/facebook/react/pull/22218.diff', 'patch_url': 'https://github.com/facebook/react/pull/22218.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22218/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22218/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22217 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22217/labels{/name} | https://api.github.com/repos/facebook/react/issues/22217/comments | https://api.github.com/repos/facebook/react/issues/22217/events | https://github.com/facebook/react/pull/22217 | 983,528,471 | MDExOlB1bGxSZXF1ZXN0NzIzMDkwMTky | 22,217 | Dynamic chunkFileName added #22115 | {'login': 'aditianshu', 'id': 55697933, 'node_id': 'MDQ6VXNlcjU1Njk3OTMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/55697933?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aditianshu', 'html_url': 'https://github.com/aditianshu', 'followers_url': 'https://api.github.com/users/aditianshu/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"Hi @aditianshu! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order fo... | 2021-08-31 07:17:06 | 2024-04-10 12:04:50 | 2024-04-10 12:04:50 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22217', 'html_url': 'https://github.com/facebook/react/pull/22217', 'diff_url': 'https://github.com/facebook/react/pull/22217.diff', 'patch_url': 'https://github.com/facebook/react/pull/22217.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22217/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22217/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22216 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22216/labels{/name} | https://api.github.com/repos/facebook/react/issues/22216/comments | https://api.github.com/repos/facebook/react/issues/22216/events | https://github.com/facebook/react/issues/22216 | 983,251,800 | MDU6SXNzdWU5ODMyNTE4MDA= | 22,216 | React 18 Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object. Check the render method of `App`. | {'login': 'JadeClay', 'id': 58127404, 'node_id': 'MDQ6VXNlcjU4MTI3NDA0', 'avatar_url': 'https://avatars.githubusercontent.com/u/58127404?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JadeClay', 'html_url': 'https://github.com/JadeClay', 'followers_url': 'https://api.github.com/users/JadeClay/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"if () {} else { } 外面再包裹个 { }\r\n\r\n render(){\r\n {\r\n if(this.state.show){\r\n return(\r\n <div className=\"StickyNotes\">\r\n <p>{this.props.data.id} - {this.props.data.description} - {this.props.data.title}</p>\r\n \r\n <div className=\"Actions\">\r\n ... | 2021-08-30 22:14:08 | 2021-08-31 15:33:43 | 2021-08-31 12:15:44 | NONE | null | null | null | Im trying to make an Sticky Application, and for that I coded two components. One is the container, that render every sticky component inside it, and the second uses the data that is given to it from a JSON.
```
class App extends React.Component {
state = {
notes: tasks
}
render(){
return <Stic... | {'url': 'https://api.github.com/repos/facebook/react/issues/22216/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22216/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22215 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22215/labels{/name} | https://api.github.com/repos/facebook/react/issues/22215/comments | https://api.github.com/repos/facebook/react/issues/22215/events | https://github.com/facebook/react/pull/22215 | 983,216,747 | MDExOlB1bGxSZXF1ZXN0NzIyODMxMjEy | 22,215 | Add consoleManagedByDevToolsDuringStrictMode feature flag in DevTools | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2021-08-30 21:22:06 | 2021-08-30 22:16:54 | 2021-08-30 22:16:53 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22215', 'html_url': 'https://github.com/facebook/react/pull/22215', 'diff_url': 'https://github.com/facebook/react/pull/22215.diff', 'patch_url': 'https://github.com/facebook/react/pull/22215.patch', 'merged_at': datetime.datetime(2021, 8, 30, 22, 16, 53)} | Right now we don't have support to read the React DevTools settings before initial render on React Native. This PR adds a DevTools feature flag to always disable double logging console logs on React Native until React Native adds support for synchronously reading settings in the future
| {'url': 'https://api.github.com/repos/facebook/react/issues/22215/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22215/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22214 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22214/labels{/name} | https://api.github.com/repos/facebook/react/issues/22214/comments | https://api.github.com/repos/facebook/react/issues/22214/events | https://github.com/facebook/react/issues/22214 | 983,025,755 | MDU6SXNzdWU5ODMwMjU3NTU= | 22,214 | Bug: Nested ReactDOMServer.renderToString calls cause React hooks to throw invalid hook exception | {'login': 'burhanbvk', 'id': 3274975, 'node_id': 'MDQ6VXNlcjMyNzQ5NzU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3274975?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/burhanbvk', 'html_url': 'https://github.com/burhanbvk', 'followers_url': 'https://api.github.com/users/burhanbvk/followers... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710332294, 'node_id': 'MDU6TGFiZWw3MTAzMzIyOTQ=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | null | [] | null | [
"IMO bug reports without titles are less likely to be looked at. You might want to update it.",
"Thanks!",
"Do you want to send a fix? We're probably not restoring the \"current dispatcher\" somewhere.",
"That was my initial suspicion as well but it doesn't seem to be case. It is the `resetHooksState` being c... | 2021-08-30 17:24:22 | 2023-08-16 06:42:03 | null | NONE | null | null | null | When you make a nested ReactDOMServer.renderToString call (i.e. call ReactDOMServer.renderToString from within a component rendered using ReactDOMServer.renderToString), you can not use any hooks after the second call. Custom hooks work, but React hooks throw a invalid hook call error.
Not sure if this is an acceptabl... | {'url': 'https://api.github.com/repos/facebook/react/issues/22214/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/22214/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22213 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22213/labels{/name} | https://api.github.com/repos/facebook/react/issues/22213/comments | https://api.github.com/repos/facebook/react/issues/22213/events | https://github.com/facebook/react/pull/22213 | 982,996,507 | MDExOlB1bGxSZXF1ZXN0NzIyNjUyNTU3 | 22,213 | remove superfluous runtime type check | {'login': 'matthargett', 'id': 1550766, 'node_id': 'MDQ6VXNlcjE1NTA3NjY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1550766?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/matthargett', 'html_url': 'https://github.com/matthargett', 'followers_url': 'https://api.github.com/users/matthargett/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"CI failures appear to be unrelated:\r\n```\r\nCached paths:\r\n * /home/circleci/project/node_modules\r\n\r\nDownloading cache archive...\r\n\r\nfile size mismatch in downloaded cache archive, downloaded: 221751781, stored size: 221751534\r\n```",
"Not all of our code is fully flowified or sound (some are any's... | 2021-08-30 16:50:11 | 2024-04-10 12:04:52 | 2024-04-10 12:04:51 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22213', 'html_url': 'https://github.com/facebook/react/pull/22213', 'diff_url': 'https://github.com/facebook/react/pull/22213.diff', 'patch_url': 'https://github.com/facebook/react/pull/22213.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22213/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22213/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22212 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22212/labels{/name} | https://api.github.com/repos/facebook/react/issues/22212/comments | https://api.github.com/repos/facebook/react/issues/22212/events | https://github.com/facebook/react/issues/22212 | 982,926,378 | MDU6SXNzdWU5ODI5MjYzNzg= | 22,212 | Bug: input onChange not triggered when input value is changed through ref current stepDown/Up functions | {'login': 'VilleMiekkoja', 'id': 2777633, 'node_id': 'MDQ6VXNlcjI3Nzc2MzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2777633?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/VilleMiekkoja', 'html_url': 'https://github.com/VilleMiekkoja', 'followers_url': 'https://api.github.com/users/VilleMi... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"What you are doing is like doing `textInput.current.value = 'a'`, which will change the ui but not trigger onChange. Instead of using stepDown, I think the more proper fix would be to directly calling `props.onChange` to change value.",
"This issue has been automatically marked as stale. **If this issue is still... | 2021-08-30 15:35:37 | 2024-04-10 12:04:53 | 2024-04-10 12:04:53 | NONE | null | null | null | Input with type number does not trigger onChange if native stepper functions are called through react ref current like this:
`inputRef.current.stepDown();`
If you press the step functions of a fully native (no react) number input, then the onChange will get called. But somehow it will not get called if they are c... | {'url': 'https://api.github.com/repos/facebook/react/issues/22212/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22212/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/22211 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22211/labels{/name} | https://api.github.com/repos/facebook/react/issues/22211/comments | https://api.github.com/repos/facebook/react/issues/22211/events | https://github.com/facebook/react/pull/22211 | 982,832,218 | MDExOlB1bGxSZXF1ZXN0NzIyNTIzNDI1 | 22,211 | Initial shim of useSyncExternalStore | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 3385b377f715af2a02ab00c0fa7dd3933d73a13a...505c398609d8938c594c240ab410a398eabf0c62\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-30 14:05:58 | 2021-09-04 15:51:38 | 2021-09-02 00:52:38 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22211', 'html_url': 'https://github.com/facebook/react/pull/22211', 'diff_url': 'https://github.com/facebook/react/pull/22211.diff', 'patch_url': 'https://github.com/facebook/react/pull/22211.patch', 'merged_at': datetime.datetime(2021, 9, 2, 0, 52, 38)} | This sets up an initial shim implementation of useSyncExternalStore, via the use-sync-external-store package. It's designed to mimic the behavior of the built-in API, but is backwards compatible to any version of React that supports hooks.
I have not yet implemented the built-in API, but once it exists, the use-sync... | {'url': 'https://api.github.com/repos/facebook/react/issues/22211/reactions', 'total_count': 11, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 4, 'rocket': 0, 'eyes': 6} | https://api.github.com/repos/facebook/react/issues/22211/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22210 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22210/labels{/name} | https://api.github.com/repos/facebook/react/issues/22210/comments | https://api.github.com/repos/facebook/react/issues/22210/events | https://github.com/facebook/react/pull/22210 | 982,612,208 | MDExOlB1bGxSZXF1ZXN0NzIyMzM4NzUw | 22,210 | Update config.yml | {'login': 'Anushreya28', 'id': 85949772, 'node_id': 'MDQ6VXNlcjg1OTQ5Nzcy', 'avatar_url': 'https://avatars.githubusercontent.com/u/85949772?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Anushreya28', 'html_url': 'https://github.com/Anushreya28', 'followers_url': 'https://api.github.com/users/Anushreya28... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"chat bot",
"It's not clear what this change is about. The \"chat bot\" comment makes me a little suspicious, so I'm going to close the PR."
] | 2021-08-30 09:54:52 | 2021-08-30 20:24:30 | 2021-08-30 20:24:30 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22210', 'html_url': 'https://github.com/facebook/react/pull/22210', 'diff_url': 'https://github.com/facebook/react/pull/22210.diff', 'patch_url': 'https://github.com/facebook/react/pull/22210.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22210/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22210/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22209 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22209/labels{/name} | https://api.github.com/repos/facebook/react/issues/22209/comments | https://api.github.com/repos/facebook/react/issues/22209/events | https://github.com/facebook/react/issues/22209 | 982,419,143 | MDU6SXNzdWU5ODI0MTkxNDM= | 22,209 | Suggestion: React 18 (PureComponent) | {'login': 'zdu-strong', 'id': 48673442, 'node_id': 'MDQ6VXNlcjQ4NjczNDQy', 'avatar_url': 'https://avatars.githubusercontent.com/u/48673442?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zdu-strong', 'html_url': 'https://github.com/zdu-strong', 'followers_url': 'https://api.github.com/users/zdu-strong/fol... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"This looks like a substantial change being proposed. :smile: Changes like this should go through our RFC process:\r\nhttps://github.com/reactjs/rfcs#react-rfcs\r\n\r\nThe RFC process is a great opportunity to get more eyeballs on your proposal before it becomes a part of a released version of React. Quite often, e... | 2021-08-30 05:59:36 | 2021-08-30 14:32:38 | 2021-08-30 14:32:38 | NONE | null | null | null | Hello, I am a programmer.
When I use PureComponent, it is very efficient. But React does not provide a setState method that can modify immutable data structures.
Therefore, the immer library is used in the setState method to implement the modification of immutable data.
You can consider absorbing immer, and then pro... | {'url': 'https://api.github.com/repos/facebook/react/issues/22209/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22209/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22208 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22208/labels{/name} | https://api.github.com/repos/facebook/react/issues/22208/comments | https://api.github.com/repos/facebook/react/issues/22208/events | https://github.com/facebook/react/pull/22208 | 982,277,200 | MDExOlB1bGxSZXF1ZXN0NzIyMDcxNjMy | 22,208 | Switched some ternary operators to more simples || operators | {'login': 'ArthurDeveloper', 'id': 73297053, 'node_id': 'MDQ6VXNlcjczMjk3MDUz', 'avatar_url': 'https://avatars.githubusercontent.com/u/73297053?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ArthurDeveloper', 'html_url': 'https://github.com/ArthurDeveloper', 'followers_url': 'https://api.github.com/users... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 46a0f050aacd8b2159b8db99b599a4b69e682189...e9024af3b598b5d99611dc373dfbb980c24f04f7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-30 01:16:00 | 2021-09-06 18:58:27 | 2021-09-06 18:58:27 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22208', 'html_url': 'https://github.com/facebook/react/pull/22208', 'diff_url': 'https://github.com/facebook/react/pull/22208.diff', 'patch_url': 'https://github.com/facebook/react/pull/22208.patch', 'merged_at': None} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/22208/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22208/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22207 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22207/labels{/name} | https://api.github.com/repos/facebook/react/issues/22207/comments | https://api.github.com/repos/facebook/react/issues/22207/events | https://github.com/facebook/react/pull/22207 | 982,256,398 | MDExOlB1bGxSZXF1ZXN0NzIyMDU0Njg5 | 22,207 | Switched some ternary operators to more simple null coalescence operators | {'login': 'ArthurDeveloper', 'id': 73297053, 'node_id': 'MDQ6VXNlcjczMjk3MDUz', 'avatar_url': 'https://avatars.githubusercontent.com/u/73297053?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ArthurDeveloper', 'html_url': 'https://github.com/ArthurDeveloper', 'followers_url': 'https://api.github.com/users... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @ArthurDeveloper! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn ord... | 2021-08-30 00:42:23 | 2021-08-30 01:13:25 | 2021-08-30 01:13:13 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22207', 'html_url': 'https://github.com/facebook/react/pull/22207', 'diff_url': 'https://github.com/facebook/react/pull/22207.diff', 'patch_url': 'https://github.com/facebook/react/pull/22207.patch', 'merged_at': None} | This make the code more simple to read. | {'url': 'https://api.github.com/repos/facebook/react/issues/22207/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22207/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22206 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22206/labels{/name} | https://api.github.com/repos/facebook/react/issues/22206/comments | https://api.github.com/repos/facebook/react/issues/22206/events | https://github.com/facebook/react/issues/22206 | 982,072,230 | MDU6SXNzdWU5ODIwNzIyMzA= | 22,206 | React Port always in use | {'login': 'aidanwardman', 'id': 33998784, 'node_id': 'MDQ6VXNlcjMzOTk4Nzg0', 'avatar_url': 'https://avatars.githubusercontent.com/u/33998784?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aidanwardman', 'html_url': 'https://github.com/aidanwardman', 'followers_url': 'https://api.github.com/users/aidanwar... | [] | closed | false | null | [] | null | [
"Doesn't sound like you're talking about React here. React doesn't have anything to do with ports. Are you thinking about create-react-app? If so, that's a different repository with different maintainers:\r\nhttps://github.com/facebook/create-react-app/issues/\r\n\r\nThough realistically you should probably post so... | 2021-08-29 11:19:22 | 2021-08-29 17:21:24 | 2021-08-29 17:21:24 | NONE | null | null | null | It doesn't seem to matter what port I use, react always thinks it's in use, how can I get around this? It's causing trouble for having a static port for mapping.
? Something is already running on port 12345.
Would you like to run the app on another port instead? › (Y/n)
Running on:
- CentOS 8 | {'url': 'https://api.github.com/repos/facebook/react/issues/22206/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22206/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22205 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22205/labels{/name} | https://api.github.com/repos/facebook/react/issues/22205/comments | https://api.github.com/repos/facebook/react/issues/22205/events | https://github.com/facebook/react/pull/22205 | 982,019,711 | MDExOlB1bGxSZXF1ZXN0NzIxOTAyNjEy | 22,205 | changes by shubham | {'login': 'lovevil7', 'id': 89649291, 'node_id': 'MDQ6VXNlcjg5NjQ5Mjkx', 'avatar_url': 'https://avatars.githubusercontent.com/u/89649291?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lovevil7', 'html_url': 'https://github.com/lovevil7', 'followers_url': 'https://api.github.com/users/lovevil7/followers',... | [] | closed | false | null | [] | null | [
"Hi @lovevil7! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for ... | 2021-08-29 07:29:20 | 2021-08-29 17:23:03 | 2021-08-29 17:23:03 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22205', 'html_url': 'https://github.com/facebook/react/pull/22205', 'diff_url': 'https://github.com/facebook/react/pull/22205.diff', 'patch_url': 'https://github.com/facebook/react/pull/22205.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22205/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22205/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22204 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22204/labels{/name} | https://api.github.com/repos/facebook/react/issues/22204/comments | https://api.github.com/repos/facebook/react/issues/22204/events | https://github.com/facebook/react/issues/22204 | 981,997,038 | MDU6SXNzdWU5ODE5OTcwMzg= | 22,204 | Bug: Unsupported window.navigator.clipboard | {'login': 'yhojann-cl', 'id': 2144779, 'node_id': 'MDQ6VXNlcjIxNDQ3Nzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2144779?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yhojann-cl', 'html_url': 'https://github.com/yhojann-cl', 'followers_url': 'https://api.github.com/users/yhojann-cl/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'yhojann-cl', 'id': 2144779.0, 'node_id': 'MDQ6VXNlcjIxNDQ3Nzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2144779?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yhojann-cl', 'html_url': 'https://github.com/yhojann-cl', 'followers_url': 'https://api.github.com/users/yhojann-cl/fol... | [{'login': 'yhojann-cl', 'id': 2144779, 'node_id': 'MDQ6VXNlcjIxNDQ3Nzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2144779?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yhojann-cl', 'html_url': 'https://github.com/yhojann-cl', 'followers_url': 'https://api.github.com/users/yhojann-cl/foll... | null | [
"This doesn't sound like something that has anything to do with React, but you haven't provided enough info for someone to be about to know.\r\n\r\nPlease help us by providing a link to a CodeSandbox (https://codesandbox.io/s/new), a repository on GitHub, or a minimal code example that reproduces the problem. (Scre... | 2021-08-29 05:11:36 | 2021-08-30 03:28:10 | 2021-08-29 20:51:55 | NONE | null | null | null | React version: 17.0.2
Browser: Mozilla Firefox 91.0.2
O.S: GNU/Linux, Ubuntu 20.04 LTS
Node: v14.17.5
## Steps To Reproduce
Write component with:
```
console.log(window.navigator);
console.log(window.navigator.clipboard);
```
## The current behavior
`window.navigator` is resolved fine but `window.n... | {'url': 'https://api.github.com/repos/facebook/react/issues/22204/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22204/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22203 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22203/labels{/name} | https://api.github.com/repos/facebook/react/issues/22203/comments | https://api.github.com/repos/facebook/react/issues/22203/events | https://github.com/facebook/react/pull/22203 | 981,917,488 | MDExOlB1bGxSZXF1ZXN0NzIxODM5MzYy | 22,203 | Fix typo in ReactDOMServerFormatConfig.js | {'login': 'KonstHardy', 'id': 46906648, 'node_id': 'MDQ6VXNlcjQ2OTA2NjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/46906648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/KonstHardy', 'html_url': 'https://github.com/KonstHardy', 'followers_url': 'https://api.github.com/users/KonstHardy/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8723e772b98d1a61aa0170981483c4da1e9237c5...af8749b2309546fd06c8b3f201498b91e02fb29e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-28 20:03:53 | 2021-09-06 18:58:46 | 2021-09-06 18:58:46 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22203', 'html_url': 'https://github.com/facebook/react/pull/22203', 'diff_url': 'https://github.com/facebook/react/pull/22203.diff', 'patch_url': 'https://github.com/facebook/react/pull/22203.patch', 'merged_at': datetime.datetime(2021, 9, 6, 18, 58, 46)} | Fix typo:
TOOD -> TODO | {'url': 'https://api.github.com/repos/facebook/react/issues/22203/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22203/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22202 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22202/labels{/name} | https://api.github.com/repos/facebook/react/issues/22202/comments | https://api.github.com/repos/facebook/react/issues/22202/events | https://github.com/facebook/react/pull/22202 | 981,884,000 | MDExOlB1bGxSZXF1ZXN0NzIxODE3NDYz | 22,202 | Set up use-sync-external-store package | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8723e772b98d1a61aa0170981483c4da1e9237c5...00f017b281f85693d556aeba014e2e4c0eb81b43\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-28 17:11:58 | 2021-08-28 20:57:47 | 2021-08-28 20:57:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22202', 'html_url': 'https://github.com/facebook/react/pull/22202', 'diff_url': 'https://github.com/facebook/react/pull/22202.diff', 'patch_url': 'https://github.com/facebook/react/pull/22202.patch', 'merged_at': datetime.datetime(2021, 8, 28, 20, 57, 47)} | This package will be a shim for the built-in useSyncExternalStore API (not yet implemented). | {'url': 'https://api.github.com/repos/facebook/react/issues/22202/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22202/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22201 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22201/labels{/name} | https://api.github.com/repos/facebook/react/issues/22201/comments | https://api.github.com/repos/facebook/react/issues/22201/events | https://github.com/facebook/react/pull/22201 | 981,832,637 | MDExOlB1bGxSZXF1ZXN0NzIxNzg0NzUx | 22,201 | devtools: Display StrictMode by default | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"> I would be open to removing the \"other\" element filter type though, if it's actually not doing anything. If you'd like to update this PR to do that, or post a new PR, that'd be appreciated!\r\n\r\nI'll open a new one to keep the context visible.\r\n\r\n > I don't think I agree with the spirit of #21974. There'... | 2021-08-28 13:16:18 | 2021-08-31 12:15:26 | 2021-08-30 20:10:44 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22201', 'html_url': 'https://github.com/facebook/react/pull/22201', 'diff_url': 'https://github.com/facebook/react/pull/22201.diff', 'patch_url': 'https://github.com/facebook/react/pull/22201.patch', 'merged_at': None} | ## Summary
Closes https://github.com/facebook/react/issues/21974
The "other" element type filter in devtools is currently in a weird spot (from a user and implementation perspective).
The "other" element type filter filters every component for which the computed devtools element type is `ElementTypeOtherOrUnkn... | {'url': 'https://api.github.com/repos/facebook/react/issues/22201/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22201/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22200 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22200/labels{/name} | https://api.github.com/repos/facebook/react/issues/22200/comments | https://api.github.com/repos/facebook/react/issues/22200/events | https://github.com/facebook/react/pull/22200 | 981,796,219 | MDExOlB1bGxSZXF1ZXN0NzIxNzU5ODY0 | 22,200 | devtools: Don't display hook index of useContext | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2021-08-28 10:08:19 | 2021-08-30 19:44:14 | 2021-08-30 19:44:13 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22200', 'html_url': 'https://github.com/facebook/react/pull/22200', 'diff_url': 'https://github.com/facebook/react/pull/22200.diff', 'patch_url': 'https://github.com/facebook/react/pull/22200.patch', 'merged_at': datetime.datetime(2021, 8, 30, 19, 44, 13)} |
## Summary
Resolves https://github.com/facebook/react/pull/20998#issuecomment-865491587
`useContext` will no longer display a (wrong) hook index since it has none (with regards to the hook indices displayed during profiling). This should also affect `useDebugValue` since it also has no ID.
Alternatively, we ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22200/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22200/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22199 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22199/labels{/name} | https://api.github.com/repos/facebook/react/issues/22199/comments | https://api.github.com/repos/facebook/react/issues/22199/events | https://github.com/facebook/react/pull/22199 | 981,678,731 | MDExOlB1bGxSZXF1ZXN0NzIxNjc4NDky | 22,199 | Added Separate DevTools Feature Flags for react-devtools-core | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [] | 2021-08-28 00:33:48 | 2021-08-30 21:12:53 | 2021-08-30 21:12:53 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22199', 'html_url': 'https://github.com/facebook/react/pull/22199', 'diff_url': 'https://github.com/facebook/react/pull/22199.diff', 'patch_url': 'https://github.com/facebook/react/pull/22199.patch', 'merged_at': datetime.datetime(2021, 8, 30, 21, 12, 53)} | This PR adds separate DevTools feature flag configurations for `react-devtools-core`. It also breaks the builds down into facebook specific and open source flags so we can experiment in React Native.
Tested `yarn build:standalone`, `yarn build:backend`, `yarn build:standalone:crx`, and `yarn build:backend:crx` and i... | {'url': 'https://api.github.com/repos/facebook/react/issues/22199/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22199/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22198 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22198/labels{/name} | https://api.github.com/repos/facebook/react/issues/22198/comments | https://api.github.com/repos/facebook/react/issues/22198/events | https://github.com/facebook/react/pull/22198 | 981,636,525 | MDExOlB1bGxSZXF1ZXN0NzIxNjQ1NjE1 | 22,198 | DevTools: Improve named hooks network caching | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"> my only other question is about our test plan? did you test the newer logic to cache source files as they are loaded? not a blocker, but wondering if it's worth adding tests for the new layers of caching? \r\n\r\nI tested this layer manually, but not programmatically.\r\n\r\nWe don't have any test coverage for t... | 2021-08-27 22:26:15 | 2021-09-01 18:10:09 | 2021-09-01 18:10:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22198', 'html_url': 'https://github.com/facebook/react/pull/22198', 'diff_url': 'https://github.com/facebook/react/pull/22198.diff', 'patch_url': 'https://github.com/facebook/react/pull/22198.patch', 'merged_at': datetime.datetime(2021, 9, 1, 18, 10, 7)} | While testing the recently-launched named hooks feature, I noticed that one of the two big performance bottlenecks is fetching the source file. This was unexpected since the source file has already been loaded by the page. (After all, DevTools is inspecting a component defined in that same file.)
Based on a suggesti... | {'url': 'https://api.github.com/repos/facebook/react/issues/22198/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22198/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22197 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22197/labels{/name} | https://api.github.com/repos/facebook/react/issues/22197/comments | https://api.github.com/repos/facebook/react/issues/22197/events | https://github.com/facebook/react/pull/22197 | 981,577,477 | MDExOlB1bGxSZXF1ZXN0NzIxNTk4Mjc3 | 22,197 | DRAFT PR | {'login': 'Albert-Jokelin', 'id': 25264572, 'node_id': 'MDQ6VXNlcjI1MjY0NTcy', 'avatar_url': 'https://avatars.githubusercontent.com/u/25264572?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Albert-Jokelin', 'html_url': 'https://github.com/Albert-Jokelin', 'followers_url': 'https://api.github.com/users/Al... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Great to see you trying to get into open source.\r\n\r\nPlease experiment with markdown (e.g. https://dillinger.io/) or pull requests (see https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request for further documentation) on a personal repository. Opening Pull Requests... | 2021-08-27 20:33:07 | 2024-04-10 12:04:56 | 2024-04-10 12:04:54 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22197', 'html_url': 'https://github.com/facebook/react/pull/22197', 'diff_url': 'https://github.com/facebook/react/pull/22197.diff', 'patch_url': 'https://github.com/facebook/react/pull/22197.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22197/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22197/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22196 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22196/labels{/name} | https://api.github.com/repos/facebook/react/issues/22196/comments | https://api.github.com/repos/facebook/react/issues/22196/events | https://github.com/facebook/react/pull/22196 | 981,551,999 | MDExOlB1bGxSZXF1ZXN0NzIxNTc3ODky | 22,196 | Add consoleManagedByDevToolsDuringStrictMode feature flag in React Reconciler | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8723e772b98d1a61aa0170981483c4da1e9237c5...260ab262ef859d2b4342e1e9b18f91f7f361bf7e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-27 19:55:12 | 2021-09-06 21:00:43 | 2021-09-01 18:56:52 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22196', 'html_url': 'https://github.com/facebook/react/pull/22196', 'diff_url': 'https://github.com/facebook/react/pull/22196.diff', 'patch_url': 'https://github.com/facebook/react/pull/22196.patch', 'merged_at': datetime.datetime(2021, 9, 1, 18, 56, 52)} | Right now we don't have support to read the React DevTools settings before initial render on React Native. This PR adds a React feature flag to always disable double logging console logs on React Native until React Native adds support for synchronously reading settings in the future | {'url': 'https://api.github.com/repos/facebook/react/issues/22196/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22196/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22195 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22195/labels{/name} | https://api.github.com/repos/facebook/react/issues/22195/comments | https://api.github.com/repos/facebook/react/issues/22195/events | https://github.com/facebook/react/issues/22195 | 981,538,381 | MDU6SXNzdWU5ODE1MzgzODE= | 22,195 | A11y related Bug: onKeyPress doesn't trigger on element (tabindex="0") when narrator is on | {'login': 'daihuaye', 'id': 764050, 'node_id': 'MDQ6VXNlcjc2NDA1MA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/764050?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/daihuaye', 'html_url': 'https://github.com/daihuaye', 'followers_url': 'https://api.github.com/users/daihuaye/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Change setCount to setCount(count +1);",
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information,... | 2021-08-27 19:33:57 | 2024-04-10 13:03:24 | 2024-04-10 13:03:23 | NONE | null | null | null |
React version: 17.0.2
System: Window 10
## Steps To Reproduce
1. Turn on Narrator app (Native app in Window)
2. go to the link https://q799n.csb.app/
3. use tab navigate to the Div element
4. Press any keys
Link to code example:
https://codesandbox.io/s/loving-frost-q799n?file=/src/App.js
```js
i... | {'url': 'https://api.github.com/repos/facebook/react/issues/22195/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22195/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/22194 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22194/labels{/name} | https://api.github.com/repos/facebook/react/issues/22194/comments | https://api.github.com/repos/facebook/react/issues/22194/events | https://github.com/facebook/react/issues/22194 | 981,484,931 | MDU6SXNzdWU5ODE0ODQ5MzE= | 22,194 | Bug: React Command Prompt npm is not working | {'login': 'tejadasari985', 'id': 46372941, 'node_id': 'MDQ6VXNlcjQ2MzcyOTQx', 'avatar_url': 'https://avatars.githubusercontent.com/u/46372941?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tejadasari985', 'html_url': 'https://github.com/tejadasari985', 'followers_url': 'https://api.github.com/users/tejad... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1168115654, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"#22194\r\n\r\n",
"cd your path... Drive C:/..\r\nnpm install -g create-react-app\r\ncreate-react-app your_fileName\r\nsome time wait process npm install all related node module after\r\nnpm start\r\... | 2021-08-27 18:17:41 | 2021-09-09 09:17:41 | 2021-08-28 07:57:33 | NONE | null | null | null | React version 6.14.3
## Steps To Reproduce
1.npx create-react-app react-project
2.cd my react-project
3.npm start
## The current behavior
Extension reports: npm ERR! code EUNSUPPORTEDPROTOCOL
2.npm ERR! Unsupported URL Type "link:": link:./scripts/eslint-rules
## The expected behavior
React Project To ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22194/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22194/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22193 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22193/labels{/name} | https://api.github.com/repos/facebook/react/issues/22193/comments | https://api.github.com/repos/facebook/react/issues/22193/events | https://github.com/facebook/react/pull/22193 | 981,463,775 | MDExOlB1bGxSZXF1ZXN0NzIxNTA4NTcz | 22,193 | Adding Log Statements | {'login': 'srivastava1234', 'id': 42956262, 'node_id': 'MDQ6VXNlcjQyOTU2MjYy', 'avatar_url': 'https://avatars.githubusercontent.com/u/42956262?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/srivastava1234', 'html_url': 'https://github.com/srivastava1234', 'followers_url': 'https://api.github.com/users/sr... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8723e772b98d1a61aa0170981483c4da1e9237c5...5d235410edd7d49f7ec26dfcaff9589e852ea20a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-27 17:48:34 | 2021-08-27 21:49:05 | 2021-08-27 21:49:04 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22193', 'html_url': 'https://github.com/facebook/react/pull/22193', 'diff_url': 'https://github.com/facebook/react/pull/22193.diff', 'patch_url': 'https://github.com/facebook/react/pull/22193.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22193/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22193/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22192 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22192/labels{/name} | https://api.github.com/repos/facebook/react/issues/22192/comments | https://api.github.com/repos/facebook/react/issues/22192/events | https://github.com/facebook/react/issues/22192 | 981,455,580 | MDU6SXNzdWU5ODE0NTU1ODA= | 22,192 | Duplicate of https://github.com/facebook/react/issues/22152 | {'login': 'tejadasari985', 'id': 46372941, 'node_id': 'MDQ6VXNlcjQ2MzcyOTQx', 'avatar_url': 'https://avatars.githubusercontent.com/u/46372941?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tejadasari985', 'html_url': 'https://github.com/tejadasari985', 'followers_url': 'https://api.github.com/users/tejad... | [] | closed | false | null | [] | null | [] | 2021-08-27 17:36:07 | 2021-08-27 17:38:23 | 2021-08-27 17:38:23 | NONE | null | null | null | Duplicate of https://github.com/facebook/react/issues/22152
_Originally posted by @eps1lon in https://github.com/facebook/react/issues/22188#issuecomment-907351596_ | {'url': 'https://api.github.com/repos/facebook/react/issues/22192/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22192/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22191 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22191/labels{/name} | https://api.github.com/repos/facebook/react/issues/22191/comments | https://api.github.com/repos/facebook/react/issues/22191/events | https://github.com/facebook/react/pull/22191 | 981,436,686 | MDExOlB1bGxSZXF1ZXN0NzIxNDg3MDk1 | 22,191 | minor changes | {'login': 'srivastava1234', 'id': 42956262, 'node_id': 'MDQ6VXNlcjQyOTU2MjYy', 'avatar_url': 'https://avatars.githubusercontent.com/u/42956262?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/srivastava1234', 'html_url': 'https://github.com/srivastava1234', 'followers_url': 'https://api.github.com/users/sr... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8723e772b98d1a61aa0170981483c4da1e9237c5...8295f30f1b345e1ec84e06713b2a0bb85d7ec8e4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-27 17:09:04 | 2021-08-27 17:32:01 | 2021-08-27 17:31:37 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22191', 'html_url': 'https://github.com/facebook/react/pull/22191', 'diff_url': 'https://github.com/facebook/react/pull/22191.diff', 'patch_url': 'https://github.com/facebook/react/pull/22191.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22191/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22191/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22190 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22190/labels{/name} | https://api.github.com/repos/facebook/react/issues/22190/comments | https://api.github.com/repos/facebook/react/issues/22190/events | https://github.com/facebook/react/issues/22190 | 981,360,035 | MDU6SXNzdWU5ODEzNjAwMzU= | 22,190 | Bug: | {'login': 'tejadasari985', 'id': 46372941, 'node_id': 'MDQ6VXNlcjQ2MzcyOTQx', 'avatar_url': 'https://avatars.githubusercontent.com/u/46372941?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tejadasari985', 'html_url': 'https://github.com/tejadasari985', 'followers_url': 'https://api.github.com/users/tejad... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2021-08-27 15:28:05 | 2021-08-27 15:28:15 | 2021-08-27 15:28:15 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/22190/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22190/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22189 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22189/labels{/name} | https://api.github.com/repos/facebook/react/issues/22189/comments | https://api.github.com/repos/facebook/react/issues/22189/events | https://github.com/facebook/react/issues/22189 | 981,359,557 | MDU6SXNzdWU5ODEzNTk1NTc= | 22,189 | React 18 | {'login': 'tejadasari985', 'id': 46372941, 'node_id': 'MDQ6VXNlcjQ2MzcyOTQx', 'avatar_url': 'https://avatars.githubusercontent.com/u/46372941?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tejadasari985', 'html_url': 'https://github.com/tejadasari985', 'followers_url': 'https://api.github.com/users/tejad... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"Likely spam. See https://github.com/facebook/react/issues/22188"
] | 2021-08-27 15:27:34 | 2021-08-27 17:17:15 | 2021-08-27 17:17:15 | NONE | null | null | null | <!--
Ask a question or share feedback about the React 18 release here.
-->
If You Having Any Issues Please Contact Me I will help You
code will submit on 1 day | {'url': 'https://api.github.com/repos/facebook/react/issues/22189/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22189/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22188 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22188/labels{/name} | https://api.github.com/repos/facebook/react/issues/22188/comments | https://api.github.com/repos/facebook/react/issues/22188/events | https://github.com/facebook/react/issues/22188 | 981,356,869 | MDU6SXNzdWU5ODEzNTY4Njk= | 22,188 | [Blocks Fixture] Migrate to built-in <Cache> API and regression test | {'login': 'tejadasari985', 'id': 46372941, 'node_id': 'MDQ6VXNlcjQ2MzcyOTQx', 'avatar_url': 'https://avatars.githubusercontent.com/u/46372941?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tejadasari985', 'html_url': 'https://github.com/tejadasari985', 'followers_url': 'https://api.github.com/users/tejad... | [] | closed | false | null | [] | null | [
"\r\nhttps://user-images.githubusercontent.com/46372941/131151327-3cd14235-b669-41e6-98de-c8d88a191c19.mov\r\n\r\n",
"Duplicate of https://github.com/facebook/react/issues/22152"
] | 2021-08-27 15:24:25 | 2021-08-27 17:14:39 | 2021-08-27 17:14:39 | NONE | null | null | null | This is task list issue.
"Blocks" fixture app which made by built-in API, 'react-fetch', Server Component combination that useful to play new features v18 later.
But current one is broken because importing removed older Cache API module.
And difficult to notice that regression because there are no tests.
So I p... | {'url': 'https://api.github.com/repos/facebook/react/issues/22188/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22188/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22187 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22187/labels{/name} | https://api.github.com/repos/facebook/react/issues/22187/comments | https://api.github.com/repos/facebook/react/issues/22187/events | https://github.com/facebook/react/issues/22187 | 981,063,788 | MDU6SXNzdWU5ODEwNjM3ODg= | 22,187 | Bug: Cannot set property 'memoizedState' of null | {'login': 'sanjeevkumarray', 'id': 53333326, 'node_id': 'MDQ6VXNlcjUzMzMzMzI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/53333326?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sanjeevkumarray', 'html_url': 'https://github.com/sanjeevkumarray', 'followers_url': 'https://api.github.com/users... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"first issues",
"I'm sorry you experienced this bug! 🙇 \r\n\r\nLooks like this problem was already reported though (#16416) so I'm going to mark this issue as a duplicate and close it. If you have additional context that might help us repro this problem, please leave a comment on the other issue!\r\n\r\nThank yo... | 2021-08-27 09:39:16 | 2021-08-27 17:33:28 | 2021-08-27 17:33:23 | NONE | null | null | null | Do you want to request a feature or report a bug?
A bug?
What is the current behavior?
Cannot set property 'memoizedState' of null
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your cod... | {'url': 'https://api.github.com/repos/facebook/react/issues/22187/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22187/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22186 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22186/labels{/name} | https://api.github.com/repos/facebook/react/issues/22186/comments | https://api.github.com/repos/facebook/react/issues/22186/events | https://github.com/facebook/react/issues/22186 | 981,050,628 | MDU6SXNzdWU5ODEwNTA2Mjg= | 22,186 | Bug: Context updated but components doesn't | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"@wgxh-cli presuming the listed \"current behavior\" and \"expected behavior\" are the wrong way around above, this is happening because `inc` and `dec` are directly mutating a value, meaning that React doesn't track this change. This can be fixed by moving `count` into state (via the `useState` hook), and having `... | 2021-08-27 09:22:10 | 2021-08-28 10:12:25 | 2021-08-28 07:50:19 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: Latest
## Steps To Reproduce
1. Create a context and provid... | {'url': 'https://api.github.com/repos/facebook/react/issues/22186/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22186/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22185 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22185/labels{/name} | https://api.github.com/repos/facebook/react/issues/22185/comments | https://api.github.com/repos/facebook/react/issues/22185/events | https://github.com/facebook/react/pull/22185 | 981,008,148 | MDExOlB1bGxSZXF1ZXN0NzIxMTM1NzE1 | 22,185 | Better Logs | {'login': 'srivastava1234', 'id': 42956262, 'node_id': 'MDQ6VXNlcjQyOTU2MjYy', 'avatar_url': 'https://avatars.githubusercontent.com/u/42956262?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/srivastava1234', 'html_url': 'https://github.com/srivastava1234', 'followers_url': 'https://api.github.com/users/sr... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8723e772b98d1a61aa0170981483c4da1e9237c5...2f8615282b3cf2acd8a868968a39cfde4a6926bd\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-27 08:31:08 | 2021-08-27 17:30:54 | 2021-08-27 17:30:54 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22185', 'html_url': 'https://github.com/facebook/react/pull/22185', 'diff_url': 'https://github.com/facebook/react/pull/22185.diff', 'patch_url': 'https://github.com/facebook/react/pull/22185.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22185/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22185/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22184 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22184/labels{/name} | https://api.github.com/repos/facebook/react/issues/22184/comments | https://api.github.com/repos/facebook/react/issues/22184/events | https://github.com/facebook/react/pull/22184 | 980,743,477 | MDExOlB1bGxSZXF1ZXN0NzIwOTI1NDMz | 22,184 | Add custom element property support behind a flag | {'login': 'josepharhar', 'id': 7681467, 'node_id': 'MDQ6VXNlcjc2ODE0Njc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7681467?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/josepharhar', 'html_url': 'https://github.com/josepharhar', 'followers_url': 'https://api.github.com/users/josepharhar/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @josepharhar! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order f... | 2021-08-27 00:09:17 | 2024-03-01 20:19:19 | 2021-12-08 15:11:43 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22184', 'html_url': 'https://github.com/facebook/react/pull/22184', 'diff_url': 'https://github.com/facebook/react/pull/22184.diff', 'patch_url': 'https://github.com/facebook/react/pull/22184.patch', 'merged_at': datetime.datetime(2021, 12, 8, 15, 11, 43)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22184/reactions', 'total_count': 150, '+1': 74, '-1': 0, 'laugh': 0, 'hooray': 37, 'confused': 0, 'heart': 39, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22184/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22183 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22183/labels{/name} | https://api.github.com/repos/facebook/react/issues/22183/comments | https://api.github.com/repos/facebook/react/issues/22183/events | https://github.com/facebook/react/issues/22183 | 980,516,840 | MDU6SXNzdWU5ODA1MTY4NDA= | 22,183 | Bug: | {'login': 'thuongSyn', 'id': 88447687, 'node_id': 'MDQ6VXNlcjg4NDQ3Njg3', 'avatar_url': 'https://avatars.githubusercontent.com/u/88447687?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/thuongSyn', 'html_url': 'https://github.com/thuongSyn', 'followers_url': 'https://api.github.com/users/thuongSyn/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2021-08-26 18:13:21 | 2021-08-26 18:22:04 | 2021-08-26 18:22:04 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get fixed much fast... | {'url': 'https://api.github.com/repos/facebook/react/issues/22183/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22183/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22182 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22182/labels{/name} | https://api.github.com/repos/facebook/react/issues/22182/comments | https://api.github.com/repos/facebook/react/issues/22182/events | https://github.com/facebook/react/pull/22182 | 980,501,618 | MDExOlB1bGxSZXF1ZXN0NzIwNzI3Mjk1 | 22,182 | Better Logs | {'login': 'srivastava1234', 'id': 42956262, 'node_id': 'MDQ6VXNlcjQyOTU2MjYy', 'avatar_url': 'https://avatars.githubusercontent.com/u/42956262?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/srivastava1234', 'html_url': 'https://github.com/srivastava1234', 'followers_url': 'https://api.github.com/users/sr... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0ba0564aeea73b496264b6b2031b990a783cc142...3f37aa713249657ce30d143bc7f551c5c22a9cde\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-26 17:53:33 | 2021-08-26 19:56:01 | 2021-08-26 19:56:01 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22182', 'html_url': 'https://github.com/facebook/react/pull/22182', 'diff_url': 'https://github.com/facebook/react/pull/22182.diff', 'patch_url': 'https://github.com/facebook/react/pull/22182.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22182/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22182/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22181 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22181/labels{/name} | https://api.github.com/repos/facebook/react/issues/22181/comments | https://api.github.com/repos/facebook/react/issues/22181/events | https://github.com/facebook/react/pull/22181 | 980,340,900 | MDExOlB1bGxSZXF1ZXN0NzIwNTk3NjQx | 22,181 | [DevTools] Only call SourceMapConsumer.originalPositionFor once | {'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"I just realized that I'm refactoring this code (#22198) because of the network cache issue, and we're going to clash. I made sure to rebase before starting, but I hadn't realized that this change never got merged. Now I'm pretty far into the refactor. Can we hold off on landing this for now?",
"@bvaughn rebased ... | 2021-08-26 14:53:28 | 2021-09-07 15:37:47 | 2021-09-07 14:39:56 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22181', 'html_url': 'https://github.com/facebook/react/pull/22181', 'diff_url': 'https://github.com/facebook/react/pull/22181.diff', 'patch_url': 'https://github.com/facebook/react/pull/22181.patch', 'merged_at': datetime.datetime(2021, 9, 7, 14, 39, 56)} | ## Summary
This commit was extracted from my draft profiling commit (#22167). As part of profiling I decided to make a refactor to only call `originalPositionFor` once. I don't think this actually affects performance much, since only the first call is the really expensive one, but I figured it might be worth still t... | {'url': 'https://api.github.com/repos/facebook/react/issues/22181/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22181/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22180 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22180/labels{/name} | https://api.github.com/repos/facebook/react/issues/22180/comments | https://api.github.com/repos/facebook/react/issues/22180/events | https://github.com/facebook/react/pull/22180 | 980,313,158 | MDExOlB1bGxSZXF1ZXN0NzIwNTc1MDAx | 22,180 | [DevTools] Add utils for perfomance marks | {'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"bikeshedding: for context, the reason i used the `with*` naming is kind of to indicate that i'm \"wrapping\" it in something, in this case performance marks. using a name that's a verb like `measureSyncCode` or something makes me think that we're returning a measurement, or something of that sort, but also not a b... | 2021-08-26 14:27:36 | 2021-08-30 21:17:12 | 2021-08-26 17:05:15 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22180', 'html_url': 'https://github.com/facebook/react/pull/22180', 'diff_url': 'https://github.com/facebook/react/pull/22180.diff', 'patch_url': 'https://github.com/facebook/react/pull/22180.patch', 'merged_at': datetime.datetime(2021, 8, 26, 17, 5, 15)} | ## Summary
When rebasing my profiling PR (#22167) I encountered a lot of merge conflicts, so I figured it might make sense to provide similar utils for performance marks, both to make it easier to manage my merge conflicts, but also a lot of the branching introduced into the code.
Just a proposal, so let me know... | {'url': 'https://api.github.com/repos/facebook/react/issues/22180/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22180/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22179 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22179/labels{/name} | https://api.github.com/repos/facebook/react/issues/22179/comments | https://api.github.com/repos/facebook/react/issues/22179/events | https://github.com/facebook/react/issues/22179 | 980,245,541 | MDU6SXNzdWU5ODAyNDU1NDE= | 22,179 | [Proposal] allow shorthand props | {'login': 'fiskpatte', 'id': 12701752, 'node_id': 'MDQ6VXNlcjEyNzAxNzUy', 'avatar_url': 'https://avatars.githubusercontent.com/u/12701752?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fiskpatte', 'html_url': 'https://github.com/fiskpatte', 'followers_url': 'https://api.github.com/users/fiskpatte/followe... | [] | closed | false | null | [] | null | [
"well I try to fix this...",
"This has been proposed a few times: #9696, #9707, #13967, #15731, #20164, #21236, #22039\r\n\r\nThe place to request/suggest this is the JSX repo though, specifically: https://github.com/facebook/jsx/issues/23\r\n\r\nI'm going to close this issue and suggest you join the discussion o... | 2021-08-26 13:25:46 | 2021-08-26 18:23:21 | 2021-08-26 18:23:20 | NONE | null | null | null | I do this all the time:
`<ComponentName propA={propA} propB={propB} propC={propC} />`
and would love to do
`<ComponentName propA propB propC />`
It currently only works with boolean values.
Can it be fixed for all?
| {'url': 'https://api.github.com/repos/facebook/react/issues/22179/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22179/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22178 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22178/labels{/name} | https://api.github.com/repos/facebook/react/issues/22178/comments | https://api.github.com/repos/facebook/react/issues/22178/events | https://github.com/facebook/react/issues/22178 | 979,893,865 | MDU6SXNzdWU5Nzk4OTM4NjU= | 22,178 | [Proposal] useState should return a reset function | {'login': 'theninthsky', 'id': 39136331, 'node_id': 'MDQ6VXNlcjM5MTM2MzMx', 'avatar_url': 'https://avatars.githubusercontent.com/u/39136331?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/theninthsky', 'html_url': 'https://github.com/theninthsky', 'followers_url': 'https://api.github.com/users/theninthsky... | [] | closed | false | null | [] | null | [
"Super nice, useful and explicit. Can't wait for it to be applied!",
"Great suggestion.\r\nLet's code it and suggest a ready to use implementation.",
"Well, I love to have this feature...and I already started working on this...\r\n",
"I'm not onboard with this, and I imagine this is a fairly common request\r\... | 2021-08-26 06:45:37 | 2021-08-26 17:50:42 | 2021-08-26 17:50:42 | NONE | null | null | null | I think useState should return a third parameter (function) that will reset the state value to it's initial state.
```
const [filters, setFilters, resetFilters] = useState({ name: 'John Smith', age: 18 })
setFilters({ name: 'Mark Smith', age: 24 })
resetFilters() // should revert filters to { name: 'John Smith... | {'url': 'https://api.github.com/repos/facebook/react/issues/22178/reactions', 'total_count': 7, '+1': 6, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/22178/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22177 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22177/labels{/name} | https://api.github.com/repos/facebook/react/issues/22177/comments | https://api.github.com/repos/facebook/react/issues/22177/events | https://github.com/facebook/react/pull/22177 | 979,849,407 | MDExOlB1bGxSZXF1ZXN0NzIwMTkzMzkz | 22,177 | Update console.js | {'login': 'vidhisinha2002', 'id': 72182782, 'node_id': 'MDQ6VXNlcjcyMTgyNzgy', 'avatar_url': 'https://avatars.githubusercontent.com/u/72182782?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vidhisinha2002', 'html_url': 'https://github.com/vidhisinha2002', 'followers_url': 'https://api.github.com/users/vi... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @vidhisinha2002! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn orde... | 2021-08-26 05:26:32 | 2021-08-26 06:56:48 | 2021-08-26 06:56:48 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22177', 'html_url': 'https://github.com/facebook/react/pull/22177', 'diff_url': 'https://github.com/facebook/react/pull/22177.diff', 'patch_url': 'https://github.com/facebook/react/pull/22177.patch', 'merged_at': None} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/22177/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22177/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22176 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22176/labels{/name} | https://api.github.com/repos/facebook/react/issues/22176/comments | https://api.github.com/repos/facebook/react/issues/22176/events | https://github.com/facebook/react/pull/22176 | 979,768,635 | MDExOlB1bGxSZXF1ZXN0NzIwMTMwNTQw | 22,176 | [DevTools] Add performance marks for individual fetch() requests | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [] | 2021-08-26 02:32:12 | 2021-08-26 15:15:52 | 2021-08-26 13:19:00 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22176', 'html_url': 'https://github.com/facebook/react/pull/22176', 'diff_url': 'https://github.com/facebook/react/pull/22176.diff', 'patch_url': 'https://github.com/facebook/react/pull/22176.patch', 'merged_at': datetime.datetime(2021, 8, 26, 13, 19)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/22176/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22176/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22175 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22175/labels{/name} | https://api.github.com/repos/facebook/react/issues/22175/comments | https://api.github.com/repos/facebook/react/issues/22175/events | https://github.com/facebook/react/pull/22175 | 979,674,463 | MDExOlB1bGxSZXF1ZXN0NzIwMDUxNTU3 | 22,175 | [DevTools] Throw error in console without interfering with logs | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2021-08-25 22:43:53 | 2021-08-30 21:37:50 | 2021-08-30 21:37:50 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22175', 'html_url': 'https://github.com/facebook/react/pull/22175', 'diff_url': 'https://github.com/facebook/react/pull/22175.diff', 'patch_url': 'https://github.com/facebook/react/pull/22175.patch', 'merged_at': datetime.datetime(2021, 8, 30, 21, 37, 50)} | This PR uses `setTimeout` to throw an error outside the overridden console method so DevTools and React internal errors will still throw without interfering with logging | {'url': 'https://api.github.com/repos/facebook/react/issues/22175/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22175/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22174 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22174/labels{/name} | https://api.github.com/repos/facebook/react/issues/22174/comments | https://api.github.com/repos/facebook/react/issues/22174/events | https://github.com/facebook/react/pull/22174 | 979,540,850 | MDExOlB1bGxSZXF1ZXN0NzE5OTM3OTY4 | 22,174 | Fix a string interpolation typo in ReactHooks test | {'login': 'matthargett', 'id': 1550766, 'node_id': 'MDQ6VXNlcjE1NTA3NjY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1550766?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/matthargett', 'html_url': 'https://github.com/matthargett', 'followers_url': 'https://api.github.com/users/matthargett/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b9964684bd8c909fc3d88f1cd47aa1f45ea7ba32...0dbb2cbbfac2b2dae22f4a215b107d82b31c6429\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-25 19:11:31 | 2021-08-26 19:37:16 | 2021-08-26 19:35:06 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22174', 'html_url': 'https://github.com/facebook/react/pull/22174', 'diff_url': 'https://github.com/facebook/react/pull/22174.diff', 'patch_url': 'https://github.com/facebook/react/pull/22174.patch', 'merged_at': datetime.datetime(2021, 8, 26, 19, 35, 6)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22174/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22174/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22173 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22173/labels{/name} | https://api.github.com/repos/facebook/react/issues/22173/comments | https://api.github.com/repos/facebook/react/issues/22173/events | https://github.com/facebook/react/pull/22173 | 979,504,431 | MDExOlB1bGxSZXF1ZXN0NzE5OTA3MzIx | 22,173 | Added performance timings to DevTools named hooks parsing | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2021-08-25 18:22:41 | 2021-08-26 16:04:26 | 2021-08-25 19:39:15 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22173', 'html_url': 'https://github.com/facebook/react/pull/22173', 'diff_url': 'https://github.com/facebook/react/pull/22173.diff', 'patch_url': 'https://github.com/facebook/react/pull/22173.patch', 'merged_at': datetime.datetime(2021, 8, 25, 19, 39, 15)} | This can be turned on or off (statically) via a new `__PERFORMANCE_PROFILE__` flag in `react-devtools-shared/src/constants`. For now, it's _disabled_, but it's useful to turn on when performance profiling.
When enabled, the flag will generate measures like:
<img width="1056" alt="Screen Shot 2021-08-25 at 10 57 3... | {'url': 'https://api.github.com/repos/facebook/react/issues/22173/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22173/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22172 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22172/labels{/name} | https://api.github.com/repos/facebook/react/issues/22172/comments | https://api.github.com/repos/facebook/react/issues/22172/events | https://github.com/facebook/react/pull/22172 | 979,249,521 | MDExOlB1bGxSZXF1ZXN0NzE5Njg1NzQ4 | 22,172 | Improved Logs | {'login': 'localhostd3veloper', 'id': 64231917, 'node_id': 'MDQ6VXNlcjY0MjMxOTE3', 'avatar_url': 'https://avatars.githubusercontent.com/u/64231917?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/localhostd3veloper', 'html_url': 'https://github.com/localhostd3veloper', 'followers_url': 'https://api.github.... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @localhostd3veloper! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn ... | 2021-08-25 14:53:54 | 2021-08-26 18:04:28 | 2021-08-26 18:03:54 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22172', 'html_url': 'https://github.com/facebook/react/pull/22172', 'diff_url': 'https://github.com/facebook/react/pull/22172.diff', 'patch_url': 'https://github.com/facebook/react/pull/22172.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22172/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22172/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22171 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22171/labels{/name} | https://api.github.com/repos/facebook/react/issues/22171/comments | https://api.github.com/repos/facebook/react/issues/22171/events | https://github.com/facebook/react/pull/22171 | 978,740,382 | MDExOlB1bGxSZXF1ZXN0NzE5MjczNjkw | 22,171 | Typo fixed in react-devtools changelog.md file | {'login': 'k1499', 'id': 75879688, 'node_id': 'MDQ6VXNlcjc1ODc5Njg4', 'avatar_url': 'https://avatars.githubusercontent.com/u/75879688?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/k1499', 'html_url': 'https://github.com/k1499', 'followers_url': 'https://api.github.com/users/k1499/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @k1499! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us ... | 2021-08-25 05:41:58 | 2021-09-06 19:05:15 | 2021-09-06 19:05:15 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22171', 'html_url': 'https://github.com/facebook/react/pull/22171', 'diff_url': 'https://github.com/facebook/react/pull/22171.diff', 'patch_url': 'https://github.com/facebook/react/pull/22171.patch', 'merged_at': datetime.datetime(2021, 9, 6, 19, 5, 15)} | ## Summary
Fixed a trivial typo in changelog.md file in react-devtools folder(depedency->dependency).
## Test Plan
No explict testing was done as it was a minor change in the documentation.
| {'url': 'https://api.github.com/repos/facebook/react/issues/22171/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22171/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22170 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22170/labels{/name} | https://api.github.com/repos/facebook/react/issues/22170/comments | https://api.github.com/repos/facebook/react/issues/22170/events | https://github.com/facebook/react/pull/22170 | 978,542,248 | MDExOlB1bGxSZXF1ZXN0NzE5MTEzNDE4 | 22,170 | DevTools release script updates: | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | {'login': 'jstejada', 'id': 1271509.0, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers',... | [{'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', ... | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 582858083ee5de37e32f5a6b72654415774ad162...00a4d9e6b369d83f1dff0f7747e6ed0081ad896f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-24 22:46:53 | 2022-12-24 13:39:42 | 2021-08-24 22:59:35 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22170', 'html_url': 'https://github.com/facebook/react/pull/22170', 'diff_url': 'https://github.com/facebook/react/pull/22170.diff', 'patch_url': 'https://github.com/facebook/react/pull/22170.patch', 'merged_at': datetime.datetime(2021, 8, 24, 22, 59, 35)} | 1. Add [README](https://github.com/bvaughn/react/blob/devtools-release-script/scripts/devtools/README.md) documenting new release scripts
2. Split release script into separate prepare, build, and publish scripts.
## Prepare script
https://user-images.githubusercontent.com/29597/130699606-4e36b4af-ea4d-4f8c-90df-... | {'url': 'https://api.github.com/repos/facebook/react/issues/22170/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22170/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22169 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22169/labels{/name} | https://api.github.com/repos/facebook/react/issues/22169/comments | https://api.github.com/repos/facebook/react/issues/22169/events | https://github.com/facebook/react/pull/22169 | 978,501,300 | MDExOlB1bGxSZXF1ZXN0NzE5MDc4NDky | 22,169 | RFC: useStateRef hook | {'login': 'behnammodi', 'id': 1549069, 'node_id': 'MDQ6VXNlcjE1NDkwNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1549069?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/behnammodi', 'html_url': 'https://github.com/behnammodi', 'followers_url': 'https://api.github.com/users/behnammodi/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Please see my reply here: https://github.com/reactjs/rfcs/issues/199#issuecomment-905028185"
] | 2021-08-24 21:29:04 | 2021-08-24 22:52:59 | 2021-08-24 22:52:59 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22169', 'html_url': 'https://github.com/facebook/react/pull/22169', 'diff_url': 'https://github.com/facebook/react/pull/22169.diff', 'patch_url': 'https://github.com/facebook/react/pull/22169.patch', 'merged_at': None} | I start with an example:
```js
const [count, setCount] = useState();
useEffect(() => {
const handleVisibiltuy = () => {
console.log(count);
};
document.addEventListener('visibilitychange', handleVisibiltuy);
return () => document.removeEventListener('visibilitychange', handleVisibiltuy);
}, [... | {'url': 'https://api.github.com/repos/facebook/react/issues/22169/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22169/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22168 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22168/labels{/name} | https://api.github.com/repos/facebook/react/issues/22168/comments | https://api.github.com/repos/facebook/react/issues/22168/events | https://github.com/facebook/react/issues/22168 | 978,427,841 | MDU6SXNzdWU5Nzg0Mjc4NDE= | 22,168 | [Feature Request][eslint-plugin-react-hooks] no-ref-checks, display error when using useRef's return value as condition | {'login': 'johnrom', 'id': 1881482, 'node_id': 'MDQ6VXNlcjE4ODE0ODI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1881482?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/johnrom', 'html_url': 'https://github.com/johnrom', 'followers_url': 'https://api.github.com/users/johnrom/followers', 'foll... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/... | open | false | null | [] | null | [
"> ```diff\r\n> // I missed this\r\n> - if (!thing) {\r\n> + if (!thing.current) {\r\n> ```\r\n\r\nSince you're using TypeScript, have you tried the [`@typescript-eslint/no-unnecessary-condition`](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unnecessary-con... | 2021-08-24 19:46:09 | 2024-02-21 04:18:35 | null | NONE | null | null | null | https://github.com/reactjs/rfcs/issues/198
https://github.com/yannickcr/eslint-plugin-react/issues/3042
Not sure whether this belongs in `eslint-plugin-react-hooks` or `eslint-plugin-react`, but a contributor at the latter suggested this to be a more appropriate place. I've opened an issue instead of an RFC to disc... | {'url': 'https://api.github.com/repos/facebook/react/issues/22168/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22168/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22167 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22167/labels{/name} | https://api.github.com/repos/facebook/react/issues/22167/comments | https://api.github.com/repos/facebook/react/issues/22167/events | https://github.com/facebook/react/pull/22167 | 978,343,387 | MDExOlB1bGxSZXF1ZXN0NzE4OTQ3MTY4 | 22,167 | [DevTools] RFC: log profiling events under __PROFILE__ flag | {'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"oops, a few unrelated changes got added to this PR (some refactoring of the calls to `originalPositionFor`) it's still good to take a look but i'll split those up",
"I forwarded the mail to the wrong group. I'm sorry from the bottom of my\nheart\n\nเมื่อ พ. 25 ส.ค. 2564 เวลา 05:58 Brian Vaughn ***@***.***>\nเขี... | 2021-08-24 17:51:19 | 2021-09-12 21:15:36 | 2021-09-09 15:51:30 | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/22167', 'html_url': 'https://github.com/facebook/react/pull/22167', 'diff_url': 'https://github.com/facebook/react/pull/22167.diff', 'patch_url': 'https://github.com/facebook/react/pull/22167.patch', 'merged_at': None} | ## Summary
This commit is being used as proposal for adding a logger (`EventLogger`) that records events happening in the DevTools runtime. In particular, this code was used for collecting profiling data to measure the performance of `parseHookNames`.
The current `EventLogger` can be extended to log and collect d... | {'url': 'https://api.github.com/repos/facebook/react/issues/22167/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22167/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22166 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22166/labels{/name} | https://api.github.com/repos/facebook/react/issues/22166/comments | https://api.github.com/repos/facebook/react/issues/22166/events | https://github.com/facebook/react/issues/22166 | 978,309,592 | MDU6SXNzdWU5NzgzMDk1OTI= | 22,166 | Close my error | {'login': 'jmcreaney', 'id': 36700947, 'node_id': 'MDQ6VXNlcjM2NzAwOTQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/36700947?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jmcreaney', 'html_url': 'https://github.com/jmcreaney', 'followers_url': 'https://api.github.com/users/jmcreaney/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"It doesn't look like this bug report has enough info for one of us to reproduce it.\r\n\r\nPlease provide a CodeSandbox (https://react.new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. \r\n\r\nHere are some tips for providing a minimal example: https://stackover... | 2021-08-24 17:06:03 | 2021-08-24 18:57:01 | 2021-08-24 18:57:01 | NONE | null | null | null | <!--
I am trying to pull a list of names and display them and every time I do the pull the names are concatenated ever render leaving me with a long list of duplicate data. The setState([]) does not reset the array but nothing.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get fi... | {'url': 'https://api.github.com/repos/facebook/react/issues/22166/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22166/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22165 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22165/labels{/name} | https://api.github.com/repos/facebook/react/issues/22165/comments | https://api.github.com/repos/facebook/react/issues/22165/events | https://github.com/facebook/react/pull/22165 | 978,299,652 | MDExOlB1bGxSZXF1ZXN0NzE4OTExNDg2 | 22,165 | Add maxYieldMs feature flag in Scheduler | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b0b53ae2c1f38a7bf82b537dafb5f60f1bf14d0d...51df6ffa3a132b0aa60093dd7fa77d1b667b5429\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-24 16:53:49 | 2021-08-24 17:05:28 | 2021-08-24 17:03:07 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22165', 'html_url': 'https://github.com/facebook/react/pull/22165', 'diff_url': 'https://github.com/facebook/react/pull/22165.diff', 'patch_url': 'https://github.com/facebook/react/pull/22165.patch', 'merged_at': datetime.datetime(2021, 8, 24, 17, 3, 7)} | Missed this in https://github.com/facebook/react/pull/22105 | {'url': 'https://api.github.com/repos/facebook/react/issues/22165/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22165/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22164 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22164/labels{/name} | https://api.github.com/repos/facebook/react/issues/22164/comments | https://api.github.com/repos/facebook/react/issues/22164/events | https://github.com/facebook/react/issues/22164 | 978,160,338 | MDU6SXNzdWU5NzgxNjAzMzg= | 22,164 | Bug: Types should not use the `any` type hack | {'login': 'SRachamim', 'id': 1595323, 'node_id': 'MDQ6VXNlcjE1OTUzMjM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1595323?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/SRachamim', 'html_url': 'https://github.com/SRachamim', 'followers_url': 'https://api.github.com/users/SRachamim/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"TypeScript types for React are not maintained by the React team. They live in the DefinitelyTyped repository, here: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts\r\n\r\nYou should probably file this issue in that repository:\r\nhttps://github.com/DefinitelyTyped/DefinitelyTy... | 2021-08-24 14:26:03 | 2021-08-24 22:53:10 | 2021-08-24 22:53:10 | NONE | null | null | null | _React_ types use `any`. For example, `useCallback`:
```typescript
function useCallback<T extends (...args: any[]) => any>(callback: T, deps: DependencyList): T;
```
The `any` is a workaround to turn-off the type system. I don't expect 3rd party libraries to use it. Even when this type is to the right of `exten... | {'url': 'https://api.github.com/repos/facebook/react/issues/22164/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22164/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22163 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22163/labels{/name} | https://api.github.com/repos/facebook/react/issues/22163/comments | https://api.github.com/repos/facebook/react/issues/22163/events | https://github.com/facebook/react/issues/22163 | 977,937,269 | MDU6SXNzdWU5Nzc5MzcyNjk= | 22,163 | RFC: useStateRef | {'login': 'behnammodi', 'id': 1549069, 'node_id': 'MDQ6VXNlcjE1NDkwNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1549069?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/behnammodi', 'html_url': 'https://github.com/behnammodi', 'followers_url': 'https://api.github.com/users/behnammodi/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Is this still an issue? ",
"> Is this still an issue?\r\n\r\nare you joking?",
"> > Is this still an issue?\r\n> \r\n> are you joking?\r\n\r\nI'm Not. ",
"> > > Is this still an issue?\r\n> > \r\n> > \r\n> > are you joking?\r\n> \r\n> I'm Not.\r\n\r\nYes this is an issue",
"> > > > Is this still an issue?\... | 2021-08-24 10:14:07 | 2021-08-24 19:52:48 | 2021-08-24 19:52:47 | CONTRIBUTOR | null | null | null | Unfortunately, I couldn't find the best place to ask about that:
I start with an example:
```js
const [count, setCount] = useState();
useEffect(() => {
const handleVisibiltuy = () => {
console.log(count);
};
document.addEventListener('visibilitychange', handleVisibiltuy);
return () => docum... | {'url': 'https://api.github.com/repos/facebook/react/issues/22163/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22163/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22162 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22162/labels{/name} | https://api.github.com/repos/facebook/react/issues/22162/comments | https://api.github.com/repos/facebook/react/issues/22162/events | https://github.com/facebook/react/issues/22162 | 977,750,699 | MDU6SXNzdWU5Nzc3NTA2OTk= | 22,162 | Unable to use React developer tool in Chrome and FireFox - "This is a restricted browser page. React devtools cannot access this page." | {'login': 'sdkdeepa', 'id': 19764585, 'node_id': 'MDQ6VXNlcjE5NzY0NTg1', 'avatar_url': 'https://avatars.githubusercontent.com/u/19764585?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sdkdeepa', 'html_url': 'https://github.com/sdkdeepa', 'followers_url': 'https://api.github.com/users/sdkdeepa/followers',... | [{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Needs%20More%20Information', 'name': 'Resolution: Needs More Information', 'color': 'fffde7', 'default': False, 'description': None}] | closed | false | {'login': 'sdkdeepa', 'id': 19764585.0, 'node_id': 'MDQ6VXNlcjE5NzY0NTg1', 'avatar_url': 'https://avatars.githubusercontent.com/u/19764585?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sdkdeepa', 'html_url': 'https://github.com/sdkdeepa', 'followers_url': 'https://api.github.com/users/sdkdeepa/followers... | [{'login': 'sdkdeepa', 'id': 19764585, 'node_id': 'MDQ6VXNlcjE5NzY0NTg1', 'avatar_url': 'https://avatars.githubusercontent.com/u/19764585?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sdkdeepa', 'html_url': 'https://github.com/sdkdeepa', 'followers_url': 'https://api.github.com/users/sdkdeepa/followers'... | null | [
"The \"page\" in question is a blank tab, right? The React DevTools extension can't run on a blank tab (nor any extension to my knowledge). Can you please provide a little more detail about what you're trying to do?",
"@bvaughn - my bad. I was not on a react app page. Let me close this issue. Sorry about that !\r... | 2021-08-24 06:27:13 | 2021-08-25 19:30:28 | 2021-08-25 19:08:39 | NONE | null | null | null | 
Following this https://github.com/facebook/react/tree/main/packages/react-devtools#the-react-tab-doesnt-show-up
Does not help.
steps
1. Checked "Allow access to file U... | {'url': 'https://api.github.com/repos/facebook/react/issues/22162/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22162/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22161 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22161/labels{/name} | https://api.github.com/repos/facebook/react/issues/22161/comments | https://api.github.com/repos/facebook/react/issues/22161/events | https://github.com/facebook/react/pull/22161 | 977,692,522 | MDExOlB1bGxSZXF1ZXN0NzE4NDAwMDYy | 22,161 | Automated DevTools release process | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bd5bf555e1167e7088a4391e5cd419dccb39714c...42cea6e6179b67b93ddc877e3e68ae283245b56c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-24 04:31:31 | 2023-09-18 04:44:02 | 2021-08-24 18:05:51 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22161', 'html_url': 'https://github.com/facebook/react/pull/22161', 'diff_url': 'https://github.com/facebook/react/pull/22161.diff', 'patch_url': 'https://github.com/facebook/react/pull/22161.patch', 'merged_at': datetime.datetime(2021, 8, 24, 18, 5, 51)} | - [x] Automate Git commit
- [x] Automate build and `yarn build` and `npm publish` steps
- [x] Add publish instructions for extension stores
https://user-images.githubusercontent.com/29597/130663304-85272de1-2b86-4dc5-90ac-ed44cf26cad7.mp4
| {'url': 'https://api.github.com/repos/facebook/react/issues/22161/reactions', 'total_count': 5, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 1, 'heart': 1, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22161/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22160 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22160/labels{/name} | https://api.github.com/repos/facebook/react/issues/22160/comments | https://api.github.com/repos/facebook/react/issues/22160/events | https://github.com/facebook/react/pull/22160 | 977,546,916 | MDExOlB1bGxSZXF1ZXN0NzE4Mjc3MDUy | 22,160 | DevTools: Replaced WeakMap with LRU for inspected element cache | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2021-08-23 23:00:25 | 2021-08-24 17:42:09 | 2021-08-23 23:22:32 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22160', 'html_url': 'https://github.com/facebook/react/pull/22160', 'diff_url': 'https://github.com/facebook/react/pull/22160.diff', 'patch_url': 'https://github.com/facebook/react/pull/22160.patch', 'merged_at': datetime.datetime(2021, 8, 23, 23, 22, 31)} | We use an LRU for this rather than a WeakMap because of how the "no-change" optimization works.
When the frontend polls the backend for an update on the element that's currently inspected, the backend will send a "no-change" message if the element hasn't updated (rendered) since the last time it was asked. In this c... | {'url': 'https://api.github.com/repos/facebook/react/issues/22160/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22160/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22159 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22159/labels{/name} | https://api.github.com/repos/facebook/react/issues/22159/comments | https://api.github.com/repos/facebook/react/issues/22159/events | https://github.com/facebook/react/issues/22159 | 976,820,839 | MDU6SXNzdWU5NzY4MjA4Mzk= | 22,159 | Bug: Allow multiple instance of React (or inject one into the other) | {'login': 'grantila', 'id': 5362579, 'node_id': 'MDQ6VXNlcjUzNjI1Nzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5362579?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/grantila', 'html_url': 'https://github.com/grantila', 'followers_url': 'https://api.github.com/users/grantila/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"For some extra context, it **is** possible to hack around this, but there's no official \"supported\" way, which is what I'm after.\r\n\r\nIn the example above, when fetching React from a `<script>` tag, it'll add itself to `window.React`, so that **is** overwriteable (as long as you overwrite it *after* it's been... | 2021-08-23 09:23:44 | 2024-04-17 17:03:29 | 2024-04-17 17:03:28 | NONE | null | null | null | _FYI; Not sure if this is a bug or a feature request. It's a problem that is surprising when it happens, and there's no workaround I'm aware of._
Now that since 17, React is supposed to more easily be upgradable in that using components from an older/newer React in a different version will still work (and be support... | {'url': 'https://api.github.com/repos/facebook/react/issues/22159/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22159/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/22158 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22158/labels{/name} | https://api.github.com/repos/facebook/react/issues/22158/comments | https://api.github.com/repos/facebook/react/issues/22158/events | https://github.com/facebook/react/pull/22158 | 976,741,346 | MDExOlB1bGxSZXF1ZXN0NzE3NTkxNzgz | 22,158 | Update .prettierrc.js | {'login': 'Paramchoudhary', 'id': 69947192, 'node_id': 'MDQ6VXNlcjY5OTQ3MTky', 'avatar_url': 'https://avatars.githubusercontent.com/u/69947192?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Paramchoudhary', 'html_url': 'https://github.com/Paramchoudhary', 'followers_url': 'https://api.github.com/users/Pa... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @paramedi! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for ... | 2021-08-23 07:58:01 | 2021-08-28 08:35:49 | 2021-08-23 19:02:44 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22158', 'html_url': 'https://github.com/facebook/react/pull/22158', 'diff_url': 'https://github.com/facebook/react/pull/22158.diff', 'patch_url': 'https://github.com/facebook/react/pull/22158.patch', 'merged_at': None} | I change one extra line **in** this code which make code lengthy. | {'url': 'https://api.github.com/repos/facebook/react/issues/22158/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22158/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22157 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22157/labels{/name} | https://api.github.com/repos/facebook/react/issues/22157/comments | https://api.github.com/repos/facebook/react/issues/22157/events | https://github.com/facebook/react/pull/22157 | 976,617,744 | MDExOlB1bGxSZXF1ZXN0NzE3NDg5MDk5 | 22,157 | add more detailed error handling if profiling data does not have any React marks | {'login': 'byronluk', 'id': 34072411, 'node_id': 'MDQ6VXNlcjM0MDcyNDEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/34072411?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/byronluk', 'html_url': 'https://github.com/byronluk', 'followers_url': 'https://api.github.com/users/byronluk/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"> Thanks!\r\n\r\nThank you for the help 😄 "
] | 2021-08-23 04:34:25 | 2021-08-26 03:55:29 | 2021-08-23 15:01:01 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22157', 'html_url': 'https://github.com/facebook/react/pull/22157', 'diff_url': 'https://github.com/facebook/react/pull/22157.diff', 'patch_url': 'https://github.com/facebook/react/pull/22157.patch', 'merged_at': datetime.datetime(2021, 8, 23, 15, 1)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22157/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22157/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22156 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22156/labels{/name} | https://api.github.com/repos/facebook/react/issues/22156/comments | https://api.github.com/repos/facebook/react/issues/22156/events | https://github.com/facebook/react/pull/22156 | 976,441,689 | MDExOlB1bGxSZXF1ZXN0NzE3MzU0ODA0 | 22,156 | Yarn replace-fork should not silently error | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fc3b6a4118de30ae76f67c2be3d463679c11f4b7...5e1b71f181aecf2904cf6474e64eeabe5ca91969\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-22 18:37:05 | 2021-08-22 20:53:09 | 2021-08-22 20:53:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22156', 'html_url': 'https://github.com/facebook/react/pull/22156', 'diff_url': 'https://github.com/facebook/react/pull/22156.diff', 'patch_url': 'https://github.com/facebook/react/pull/22156.patch', 'merged_at': datetime.datetime(2021, 8, 22, 20, 53, 7)} | If the Yarn `replace-fork` script fails while running the lint sub-command, catch and report the error. (Previously this error was being swallowed and causing CI to incorrectly report a different problem.)
Relates to #21998, #22151 | {'url': 'https://api.github.com/repos/facebook/react/issues/22156/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22156/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22155 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22155/labels{/name} | https://api.github.com/repos/facebook/react/issues/22155/comments | https://api.github.com/repos/facebook/react/issues/22155/events | https://github.com/facebook/react/pull/22155 | 976,340,747 | MDExOlB1bGxSZXF1ZXN0NzE3Mjg1NTI5 | 22,155 | Fixed writing mistakes in readme | {'login': 'PasinduDushan', 'id': 57533877, 'node_id': 'MDQ6VXNlcjU3NTMzODc3', 'avatar_url': 'https://avatars.githubusercontent.com/u/57533877?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/PasinduDushan', 'html_url': 'https://github.com/PasinduDushan', 'followers_url': 'https://api.github.com/users/Pasin... | [] | closed | false | null | [] | null | [
"Hi @PasinduDushan! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order... | 2021-08-22 10:23:08 | 2021-08-22 10:31:54 | 2021-08-22 10:31:43 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22155', 'html_url': 'https://github.com/facebook/react/pull/22155', 'diff_url': 'https://github.com/facebook/react/pull/22155.diff', 'patch_url': 'https://github.com/facebook/react/pull/22155.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22155/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22155/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22154 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22154/labels{/name} | https://api.github.com/repos/facebook/react/issues/22154/comments | https://api.github.com/repos/facebook/react/issues/22154/events | https://github.com/facebook/react/pull/22154 | 976,334,833 | MDExOlB1bGxSZXF1ZXN0NzE3MjgxMjk5 | 22,154 | Fix a few typos | {'login': 'bowen31337', 'id': 3508255, 'node_id': 'MDQ6VXNlcjM1MDgyNTU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3508255?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bowen31337', 'html_url': 'https://github.com/bowen31337', 'followers_url': 'https://api.github.com/users/bowen31337/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2021-08-22 09:50:10 | 2021-09-11 04:08:43 | 2021-08-22 18:11:36 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22154', 'html_url': 'https://github.com/facebook/react/pull/22154', 'diff_url': 'https://github.com/facebook/react/pull/22154.diff', 'patch_url': 'https://github.com/facebook/react/pull/22154.patch', 'merged_at': datetime.datetime(2021, 8, 22, 18, 11, 36)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22154/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22154/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22153 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22153/labels{/name} | https://api.github.com/repos/facebook/react/issues/22153/comments | https://api.github.com/repos/facebook/react/issues/22153/events | https://github.com/facebook/react/issues/22153 | 976,305,403 | MDU6SXNzdWU5NzYzMDU0MDM= | 22,153 | React 18 and next.js | {'login': 'Padmanabh82', 'id': 70370670, 'node_id': 'MDQ6VXNlcjcwMzcwNjcw', 'avatar_url': 'https://avatars.githubusercontent.com/u/70370670?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Padmanabh82', 'html_url': 'https://github.com/Padmanabh82', 'followers_url': 'https://api.github.com/users/Padmanabh82... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"Please tell why are people dislike it",
"If there are any negative point tell me",
"One of React's strengths is that it provides a relatively small API, and lets you build what you need on top of that.\r\n\r\nTake the things you're asking for as an example: for my job, we would not need any of them, so adding ... | 2021-08-22 07:07:58 | 2021-08-25 07:10:25 | 2021-08-23 18:34:56 | NONE | null | null | null | react is so plain.we have to write bunch of code for small things, so i think react should include all functions (code) of next.js, for one or two functionality we have to change whole framework or make a new project and write whole bunch of code for it and there many opensource frameworks like next.js from which we ca... | {'url': 'https://api.github.com/repos/facebook/react/issues/22153/reactions', 'total_count': 14, '+1': 1, '-1': 12, 'laugh': 0, 'hooray': 0, 'confused': 1, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22153/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22152 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22152/labels{/name} | https://api.github.com/repos/facebook/react/issues/22152/comments | https://api.github.com/repos/facebook/react/issues/22152/events | https://github.com/facebook/react/issues/22152 | 976,209,179 | MDU6SXNzdWU5NzYyMDkxNzk= | 22,152 | [Blocks Fixture] Migrate to built-in <Cache> API and regression test | {'login': 'ryota-murakami', 'id': 5501268, 'node_id': 'MDQ6VXNlcjU1MDEyNjg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5501268?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ryota-murakami', 'html_url': 'https://github.com/ryota-murakami', 'followers_url': 'https://api.github.com/users/ryot... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"I want to work on this issue could you please explain a bit more about this issue.\r\n",
"@ryota-murakami I'd like to contribute\r\n/assign",
"I'd like to contribute as well :)",
"i have a technical assesment for internship .Id like to contribute to this as well ",
"can i contribute to this too as i am a b... | 2021-08-21 19:48:36 | 2024-04-17 17:03:31 | 2024-04-17 17:03:30 | CONTRIBUTOR | null | null | null | # Summary
This is task list issue.
"Blocks" fixture app which made by [built-in <Cache> API](https://github.com/reactwg/react-18/discussions/25), 'react-fetch', [Server Component](https://reactjs.org/blog/2020/12/21/data-fetching-with-react-server-components.html) combination that useful to play new features v18 la... | {'url': 'https://api.github.com/repos/facebook/react/issues/22152/reactions', 'total_count': 4, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22152/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/22151 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22151/labels{/name} | https://api.github.com/repos/facebook/react/issues/22151/comments | https://api.github.com/repos/facebook/react/issues/22151/events | https://github.com/facebook/react/pull/22151 | 976,204,970 | MDExOlB1bGxSZXF1ZXN0NzE3MTk3ODM3 | 22,151 | [Blocks Fixture] fix broken fixture ServerComponent app | {'login': 'ryota-murakami', 'id': 5501268, 'node_id': 'MDQ6VXNlcjU1MDEyNjg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5501268?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ryota-murakami', 'html_url': 'https://github.com/ryota-murakami', 'followers_url': 'https://api.github.com/users/ryot... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"@gaearon I think you are best reviewer as a original author. \r\nPlease feel free to feedback when if you have a plenty time! 😄",
"Not sure why the `replace-fork` CI fails for non-reconciler stuff like this. Looks like our script is broken.",
"@bvaughn Hello Brian👋 This is Sunday so could you have plenty r... | 2021-08-21 19:25:41 | 2024-04-10 13:03:29 | 2024-04-10 13:03:28 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22151', 'html_url': 'https://github.com/facebook/react/pull/22151', 'diff_url': 'https://github.com/facebook/react/pull/22151.diff', 'patch_url': 'https://github.com/facebook/react/pull/22151.patch', 'merged_at': None} | ## Summary
- https://github.com/facebook/react/pull/20315
Since removed 'react/unstable-cache' entry point by above PR, **Blocks not working** with error on the next line.
`import {createCache, CacheProvider} from 'react/unstable-cache';`
## Test Plan
I've planning adding test by [Cypress](https://www.c... | {'url': 'https://api.github.com/repos/facebook/react/issues/22151/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22151/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22150 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22150/labels{/name} | https://api.github.com/repos/facebook/react/issues/22150/comments | https://api.github.com/repos/facebook/react/issues/22150/events | https://github.com/facebook/react/pull/22150 | 976,199,123 | MDExOlB1bGxSZXF1ZXN0NzE3MTkzODg1 | 22,150 | Fix typo in preprocessData.js | {'login': 'KonstHardy', 'id': 46906648, 'node_id': 'MDQ6VXNlcjQ2OTA2NjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/46906648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/KonstHardy', 'html_url': 'https://github.com/KonstHardy', 'followers_url': 'https://api.github.com/users/KonstHardy/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2021-08-21 18:52:31 | 2021-08-22 17:37:36 | 2021-08-22 17:37:36 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22150', 'html_url': 'https://github.com/facebook/react/pull/22150', 'diff_url': 'https://github.com/facebook/react/pull/22150.diff', 'patch_url': 'https://github.com/facebook/react/pull/22150.patch', 'merged_at': datetime.datetime(2021, 8, 22, 17, 37, 36)} | Fix typo:
SUSPEND_DURING_UPATE -> SUSPEND_DURING_UPDATE
| {'url': 'https://api.github.com/repos/facebook/react/issues/22150/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22150/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22149 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22149/labels{/name} | https://api.github.com/repos/facebook/react/issues/22149/comments | https://api.github.com/repos/facebook/react/issues/22149/events | https://github.com/facebook/react/issues/22149 | 975,963,061 | MDU6SXNzdWU5NzU5NjMwNjE= | 22,149 | Expecting hasShadowRoot from global scope | {'login': 'Ontopic', 'id': 1599991, 'node_id': 'MDQ6VXNlcjE1OTk5OTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1599991?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Ontopic', 'html_url': 'https://github.com/Ontopic', 'followers_url': 'https://api.github.com/users/Ontopic/followers', 'foll... | [{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Needs%20More%20Information', 'name': 'Resolution: Needs More Information', 'color': 'fffde7', 'default': False, 'description': None}
{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI='... | open | false | null | [] | null | [
"I see no code accessing `hasShadowRoot` inside React. What points to React being the culprit?"
] | 2021-08-20 22:40:21 | 2021-09-06 20:45:35 | null | NONE | null | null | null | Think hasShadowRoot was added with a debug flag for ```if (CHROME && hasShadowRoot)``` (grepping or acking that should bring you to the culprit). This breaks Chromium builds in Chrome and Electron.
For anyone riding the 18 wave;
```
// somehwere above your entry / bundle
globalThis.hasShadowRoot = () => true... | {'url': 'https://api.github.com/repos/facebook/react/issues/22149/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22149/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22148 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22148/labels{/name} | https://api.github.com/repos/facebook/react/issues/22148/comments | https://api.github.com/repos/facebook/react/issues/22148/events | https://github.com/facebook/react/pull/22148 | 975,943,575 | MDExOlB1bGxSZXF1ZXN0NzE3MDE2NjMz | 22,148 | [DevTools] Keep query params in extracted source map urls | {'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2021-08-20 21:53:02 | 2021-08-20 22:06:59 | 2021-08-20 22:04:30 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22148', 'html_url': 'https://github.com/facebook/react/pull/22148', 'diff_url': 'https://github.com/facebook/react/pull/22148.diff', 'patch_url': 'https://github.com/facebook/react/pull/22148.patch', 'merged_at': datetime.datetime(2021, 8, 20, 22, 4, 30)} | ## Summary
Our current logic for extracting source map urls assumed that the url contained no query params (e.g. `?foo=bar`), and when extracting the url we would cut off the query params. I noticed this during internal testing, since removing the query params would cause loading source maps to fail.
This commit ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22148/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22148/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22147 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22147/labels{/name} | https://api.github.com/repos/facebook/react/issues/22147/comments | https://api.github.com/repos/facebook/react/issues/22147/events | https://github.com/facebook/react/pull/22147 | 975,762,495 | MDExOlB1bGxSZXF1ZXN0NzE2ODY2NDUx | 22,147 | DevTools: Reset cached indices in Store after elements reordered | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"nice! thanks for the extra test!",
"Good use case of `toMatchInlineSnapshot()`\u0010, this make easy to understand what is the correct expectation with visually."
] | 2021-08-20 16:38:38 | 2021-08-20 18:16:08 | 2021-08-20 16:53:28 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22147', 'html_url': 'https://github.com/facebook/react/pull/22147', 'diff_url': 'https://github.com/facebook/react/pull/22147.diff', 'patch_url': 'https://github.com/facebook/react/pull/22147.patch', 'merged_at': datetime.datetime(2021, 8, 20, 16, 53, 28)} | Any time the tree changes (elements added, removed, or re-ordered) our cached id-to-index map might be invalid. Reset it more aggressively on tree operations and recompute it lazily.
This PR adds a new test (failing without this change and passing with it).
Follow up to PR #22144. | {'url': 'https://api.github.com/repos/facebook/react/issues/22147/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22147/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22146 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22146/labels{/name} | https://api.github.com/repos/facebook/react/issues/22146/comments | https://api.github.com/repos/facebook/react/issues/22146/events | https://github.com/facebook/react/pull/22146 | 975,644,837 | MDExOlB1bGxSZXF1ZXN0NzE2NzY2NjY1 | 22,146 | indexOf method could return -1, Potential bug | {'login': 'mdrazak2001', 'id': 60781022, 'node_id': 'MDQ6VXNlcjYwNzgxMDIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/60781022?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mdrazak2001', 'html_url': 'https://github.com/mdrazak2001', 'followers_url': 'https://api.github.com/users/mdrazak2001... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"In JavaScript you can't get a segmentation error (unless the engine is buggy). You'll get `undefined` which will fall through to the `default` case which already throws the desired error. So this is not necessary.",
"Correction: since we're not reading from array by index but doing string manipulation, what woul... | 2021-08-20 14:07:47 | 2021-09-06 19:09:19 | 2021-09-06 19:06:53 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22146', 'html_url': 'https://github.com/facebook/react/pull/22146', 'diff_url': 'https://github.com/facebook/react/pull/22146.diff', 'patch_url': 'https://github.com/facebook/react/pull/22146.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22146/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22146/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22145 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22145/labels{/name} | https://api.github.com/repos/facebook/react/issues/22145/comments | https://api.github.com/repos/facebook/react/issues/22145/events | https://github.com/facebook/react/pull/22145 | 975,624,582 | MDExOlB1bGxSZXF1ZXN0NzE2NzQ5MjY2 | 22,145 | Avoiding_indexOf_error | {'login': 'mdrazak2001', 'id': 60781022, 'node_id': 'MDQ6VXNlcjYwNzgxMDIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/60781022?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mdrazak2001', 'html_url': 'https://github.com/mdrazak2001', 'followers_url': 'https://api.github.com/users/mdrazak2001... | [] | closed | false | null | [] | null | [
"Hi @mdrazak2001! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order f... | 2021-08-20 13:43:59 | 2021-08-20 13:59:41 | 2021-08-20 13:57:22 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22145', 'html_url': 'https://github.com/facebook/react/pull/22145', 'diff_url': 'https://github.com/facebook/react/pull/22145.diff', 'patch_url': 'https://github.com/facebook/react/pull/22145.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22145/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22145/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22144 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22144/labels{/name} | https://api.github.com/repos/facebook/react/issues/22144/comments | https://api.github.com/repos/facebook/react/issues/22144/events | https://github.com/facebook/react/pull/22144 | 975,444,988 | MDExOlB1bGxSZXF1ZXN0NzE2NTkzNTAy | 22,144 | DevTools: update error indices when elements are added/removed | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Happy to land this as is (since it clearly improves the currently broken behavior) but if you're willing to address the comment we both left too, that'd be awesome. Your call!",
"Something about this nags at me. Looking back at the bug report video:\r\n\r\nhttps://user-images.githubusercontent.com/29597/13015515... | 2021-08-20 09:41:25 | 2021-08-20 16:41:42 | 2021-08-20 15:55:42 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22144', 'html_url': 'https://github.com/facebook/react/pull/22144', 'diff_url': 'https://github.com/facebook/react/pull/22144.diff', 'patch_url': 'https://github.com/facebook/react/pull/22144.patch', 'merged_at': datetime.datetime(2021, 8, 20, 15, 55, 42)} | ## Summary
Closes https://github.com/facebook/react/issues/22143
First commit has the current behavior. Second commit the fix (making it easier to spot the change in behavior).
## Test Plan
- [x] tested behavior in shell
- [x] CI green (failure is unrelated and probably just needs a restart)
| {'url': 'https://api.github.com/repos/facebook/react/issues/22144/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22144/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22143 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22143/labels{/name} | https://api.github.com/repos/facebook/react/issues/22143/comments | https://api.github.com/repos/facebook/react/issues/22143/events | https://github.com/facebook/react/issues/22143 | 975,116,326 | MDU6SXNzdWU5NzUxMTYzMjY= | 22,143 | DevTools scroll-to error or warning feature broken | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"I cannot reproduce this unless I'm doing something wrong, tested with errors here\r\n\r\n\r\n\r\nThe part where it is selected outside of the view is because of the recording, it never goes behind the... | 2021-08-19 23:04:36 | 2021-08-20 15:55:42 | 2021-08-20 15:55:42 | CONTRIBUTOR | null | null | null | Not sure when this happened, but the feature got broken:
https://user-images.githubusercontent.com/29597/130155150-18fbca13-42d7-4d7d-831e-8db4a9672d94.mp4
Using the up/down arrows to navigate the list works fine, but jumping to the next/previous component with a warning or error doesn't quite work correctly. (Th... | {'url': 'https://api.github.com/repos/facebook/react/issues/22143/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22143/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22142 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22142/labels{/name} | https://api.github.com/repos/facebook/react/issues/22142/comments | https://api.github.com/repos/facebook/react/issues/22142/events | https://github.com/facebook/react/pull/22142 | 975,053,712 | MDExOlB1bGxSZXF1ZXN0NzE2MjY1ODgw | 22,142 | Add aria-description to the list of known ARIA attributes | {'login': 'mahyareb', 'id': 42976936, 'node_id': 'MDQ6VXNlcjQyOTc2OTM2', 'avatar_url': 'https://avatars.githubusercontent.com/u/42976936?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mahyareb', 'html_url': 'https://github.com/mahyareb', 'followers_url': 'https://api.github.com/users/mahyareb/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @mahyareb! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for ... | 2021-08-19 21:13:13 | 2021-09-06 19:16:46 | 2021-09-06 19:12:51 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22142', 'html_url': 'https://github.com/facebook/react/pull/22142', 'diff_url': 'https://github.com/facebook/react/pull/22142.diff', 'patch_url': 'https://github.com/facebook/react/pull/22142.patch', 'merged_at': datetime.datetime(2021, 9, 6, 19, 12, 51)} | https://w3c.github.io/aria/#aria-description is a valid aria property.
https://github.com/facebook/react/issues/21035 | {'url': 'https://api.github.com/repos/facebook/react/issues/22142/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22142/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22141 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22141/labels{/name} | https://api.github.com/repos/facebook/react/issues/22141/comments | https://api.github.com/repos/facebook/react/issues/22141/events | https://github.com/facebook/react/pull/22141 | 974,977,764 | MDExOlB1bGxSZXF1ZXN0NzE2MjAxODM3 | 22,141 | Replace react-virtualized-auto-sizer with ResizeObserver | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 64f83a6fd24ddfcc74607e0e55b3fc9fe0d3c9b3...da94194acebb3e055a54097a4fde828e99a9d07b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-19 19:29:18 | 2024-04-17 16:04:48 | 2024-04-17 16:04:48 | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/22141', 'html_url': 'https://github.com/facebook/react/pull/22141', 'diff_url': 'https://github.com/facebook/react/pull/22141.diff', 'patch_url': 'https://github.com/facebook/react/pull/22141.patch', 'merged_at': None} | Resolves #22122
Note that the code currently committed _fixes_ the issue for Chrome, and supports standalone and inline packages, but fails on Firefox because `ResizeObserver` callbacks never seem to get fired.
I'm going to leave this for the moment and try a potential alternate fix. | {'url': 'https://api.github.com/repos/facebook/react/issues/22141/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22141/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22140 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22140/labels{/name} | https://api.github.com/repos/facebook/react/issues/22140/comments | https://api.github.com/repos/facebook/react/issues/22140/events | https://github.com/facebook/react/pull/22140 | 974,966,343 | MDExOlB1bGxSZXF1ZXN0NzE2MTkxOTcy | 22,140 | [Scheduler] Add tests for isInputPending | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d54be90be658afca13c3f882ff28de14e0bd35ad...2550a00276a99d14ce7ded8e6665d5714d157006\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-19 19:13:05 | 2021-08-20 14:02:04 | 2021-08-20 13:57:29 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22140', 'html_url': 'https://github.com/facebook/react/pull/22140', 'diff_url': 'https://github.com/facebook/react/pull/22140.diff', 'patch_url': 'https://github.com/facebook/react/pull/22140.patch', 'merged_at': datetime.datetime(2021, 8, 20, 13, 57, 29)} | This feature was already implemented but we didn't have any tests. So I wrote some. | {'url': 'https://api.github.com/repos/facebook/react/issues/22140/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22140/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22139 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22139/labels{/name} | https://api.github.com/repos/facebook/react/issues/22139/comments | https://api.github.com/repos/facebook/react/issues/22139/events | https://github.com/facebook/react/pull/22139 | 974,965,693 | MDExOlB1bGxSZXF1ZXN0NzE2MTkxMzgx | 22,139 | Set up test infra for dynamic Scheduler flags | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 64f83a6fd24ddfcc74607e0e55b3fc9fe0d3c9b3...a3003d4c7ca5ba3662e0d56d3f072a09879822f9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-19 19:12:11 | 2021-08-20 13:56:20 | 2021-08-20 13:56:20 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22139', 'html_url': 'https://github.com/facebook/react/pull/22139', 'diff_url': 'https://github.com/facebook/react/pull/22139.diff', 'patch_url': 'https://github.com/facebook/react/pull/22139.patch', 'merged_at': datetime.datetime(2021, 8, 20, 13, 56, 20)} | I copied the set up we use for React.
In the www-variant test job, the Scheduler `__VARIANT__` flags will be `true`. When writing a test, we can read the value of the flag with the `gate` pragma and method.
(Since these packages are currently released in lockstep, maybe we should remove SchedulerFeatureFlags and ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22139/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22139/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22138 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22138/labels{/name} | https://api.github.com/repos/facebook/react/issues/22138/comments | https://api.github.com/repos/facebook/react/issues/22138/events | https://github.com/facebook/react/issues/22138 | 974,938,058 | MDU6SXNzdWU5NzQ5MzgwNTg= | 22,138 | [DevTools Bug]: React Profiler: Flamegraph section overflows and not resizable | {'login': 'shogunsea', 'id': 2238944, 'node_id': 'MDQ6VXNlcjIyMzg5NDQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2238944?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shogunsea', 'html_url': 'https://github.com/shogunsea', 'followers_url': 'https://api.github.com/users/shogunsea/followers... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | null | [] | null | [
"I'm Working on this Issue.. Can you explain me in brief about the issue? ",
"Hey! Thanks for reporting!\r\n\r\nI tried profiling an app with a large component tree but unfortunately I can't repro this issue. Could you provide a more concrete repro case?\r\n\r\n since I couldn't find any production site with a *developme... | {'url': 'https://api.github.com/repos/facebook/react/issues/22138/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22138/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22137 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22137/labels{/name} | https://api.github.com/repos/facebook/react/issues/22137/comments | https://api.github.com/repos/facebook/react/issues/22137/events | https://github.com/facebook/react/issues/22137 | 974,935,110 | MDU6SXNzdWU5NzQ5MzUxMTA= | 22,137 | [DevTools Bug]: Flamegraph section overflows and not resizable | {'login': 'shogunsea', 'id': 2238944, 'node_id': 'MDQ6VXNlcjIyMzg5NDQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2238944?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shogunsea', 'html_url': 'https://github.com/shogunsea', 'followers_url': 'https://api.github.com/users/shogunsea/followers... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'shogunsea', 'id': 2238944.0, 'node_id': 'MDQ6VXNlcjIyMzg5NDQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2238944?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shogunsea', 'html_url': 'https://github.com/shogunsea', 'followers_url': 'https://api.github.com/users/shogunsea/followe... | [{'login': 'shogunsea', 'id': 2238944, 'node_id': 'MDQ6VXNlcjIyMzg5NDQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2238944?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shogunsea', 'html_url': 'https://github.com/shogunsea', 'followers_url': 'https://api.github.com/users/shogunsea/follower... | null | [
"@shogunsea: We're sorry you've seen this error. ❤️\n\nIt looks like you forgot to specify a valid URL. (This means that we will not be able to reproduce the problem you're reporting.)\n\nPlease help us by providing a link to a CodeSandbox (https://codesandbox.io/s/new), a repository on GitHub, or a minimal code ex... | 2021-08-19 18:29:50 | 2021-08-19 18:30:04 | 2021-08-19 18:30:04 | NONE | null | null | null | ### Website or app
any site
### Repro steps
I have a page that has lots of component so the component tree is pretty long, when I profile on it, the flamechart just overflows by default and I have to put it fullscreen to see the "why did this render" side bar
} | We have successfully integrated react-devtools-inline in the [Replay frontend](https://github.com/RecordReplay/devtools). Now we want to [disable some features in the UI](https://github.com/RecordReplay/devtools/issues/2389#issuecomment-899673657) that either make no sense in our setting or haven't been implemented yet... | {'url': 'https://api.github.com/repos/facebook/react/issues/22136/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22136/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22135 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22135/labels{/name} | https://api.github.com/repos/facebook/react/issues/22135/comments | https://api.github.com/repos/facebook/react/issues/22135/events | https://github.com/facebook/react/issues/22135 | 974,790,822 | MDU6SXNzdWU5NzQ3OTA4MjI= | 22,135 | [DevTools Bug]: Context & useContext,some child component don‘t rerender,but highlight! | {'login': 'bigbigDreamer', 'id': 39019913, 'node_id': 'MDQ6VXNlcjM5MDE5OTEz', 'avatar_url': 'https://avatars.githubusercontent.com/u/39019913?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bigbigDreamer', 'html_url': 'https://github.com/bigbigDreamer', 'followers_url': 'https://api.github.com/users/bigbi... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Hey! Thanks for reporting!\r\n\r\n What you're seeing is not actually a bug. In your app, `AppProvider` rerenders in response to count updating as a result of the button click, and it is the parent of `child1` and `child2`, which is why you are seeing both highlighted. Closing this issue but feel free to reopen if... | 2021-08-19 15:29:35 | 2022-01-07 08:56:05 | 2021-08-19 21:19:44 | NONE | null | null | null | ### Website or app
https://codesandbox.io/embed/confident-kare-lzzko?fontsize=14&hidenavigation=1&theme=dark
### Repro steps
# Bug Desc: Context & useContext,some child component don‘t rerender,but highlight!
1. Open React Devtools
2.
, we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order... | 2021-08-19 13:52:39 | 2021-09-06 18:59:29 | 2021-09-06 18:59:28 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22134', 'html_url': 'https://github.com/facebook/react/pull/22134', 'diff_url': 'https://github.com/facebook/react/pull/22134.diff', 'patch_url': 'https://github.com/facebook/react/pull/22134.patch', 'merged_at': None} | ## Should not already be working" in Firefox after a breakpoint/alert #17355
Fixing Bug patch error Mozilla Firefox Browser with version 90
| {'url': 'https://api.github.com/repos/facebook/react/issues/22134/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22134/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22133 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22133/labels{/name} | https://api.github.com/repos/facebook/react/issues/22133/comments | https://api.github.com/repos/facebook/react/issues/22133/events | https://github.com/facebook/react/issues/22133 | 974,650,056 | MDU6SXNzdWU5NzQ2NTAwNTY= | 22,133 | refs for function components as first class citizens | {'login': 'KutnerUri', 'id': 5400361, 'node_id': 'MDQ6VXNlcjU0MDAzNjE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5400361?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/KutnerUri', 'html_url': 'https://github.com/KutnerUri', 'followers_url': 'https://api.github.com/users/KutnerUri/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2021-08-19 13:12:41 | 2022-04-29 15:08:44 | 2022-04-29 15:08:43 | NONE | null | null | null | I'm looking everywhere, but I can't seem to find an official answer.
It seems `ref`s are discouraged, and developers are required to use `forwardRef`, or pass ref as a separate prop (i.e. `forwardRef={ref}`).
`ref` are very important when access to the DOM is required, usually when a measurement is needed.
Exampl... | {'url': 'https://api.github.com/repos/facebook/react/issues/22133/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22133/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22132 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22132/labels{/name} | https://api.github.com/repos/facebook/react/issues/22132/comments | https://api.github.com/repos/facebook/react/issues/22132/events | https://github.com/facebook/react/issues/22132 | 974,373,662 | MDU6SXNzdWU5NzQzNzM2NjI= | 22,132 | Feature request: adding a `triggers` optional array to `useEffect` | {'login': 'eric-burel', 'id': 7983005, 'node_id': 'MDQ6VXNlcjc5ODMwMDU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7983005?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eric-burel', 'html_url': 'https://github.com/eric-burel', 'followers_url': 'https://api.github.com/users/eric-burel/follo... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"It might be great indeed to have a mechanism to control the ```useEffect``` trigger. \r\nEither by passing a list of \"triggers\" as @eric-burel suggests or have a ```shouldTrigger``` function as ```useEffect``` last argument that takes the previous and next dependencies state array as argument and returns a boole... | 2021-08-19 07:46:48 | 2024-04-17 16:04:50 | 2024-04-17 16:04:50 | NONE | null | null | null | Currently, `useEffect` accepts an array of dependencies as its second parameters. It must be filled with all values used by the effect callback, to make the call consistent.
However, this array of dependencies have itself a side-effect... of triggering the effect.
Therefore, it is not really just a dependency arr... | {'url': 'https://api.github.com/repos/facebook/react/issues/22132/reactions', 'total_count': 35, '+1': 30, '-1': 1, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 4, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22132/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/22131 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22131/labels{/name} | https://api.github.com/repos/facebook/react/issues/22131/comments | https://api.github.com/repos/facebook/react/issues/22131/events | https://github.com/facebook/react/issues/22131 | 974,331,875 | MDU6SXNzdWU5NzQzMzE4NzU= | 22,131 | Potential expensive operation optimisation | {'login': 'ishmum123', 'id': 9882721, 'node_id': 'MDQ6VXNlcjk4ODI3MjE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9882721?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ishmum123', 'html_url': 'https://github.com/ishmum123', 'followers_url': 'https://api.github.com/users/ishmum123/followers... | [] | closed | false | null | [] | null | [
"I'd like to take this one, is it free @ishmum123 ? But I see no exported types ReactFiberHostConfig, is it how it should be ? any help?",
"Thanks but micro-optimizations without context like this are often [misleading](https://mrale.ph/blog/2014/12/24/array-length-caching.html). Happy to revisit if you can show ... | 2021-08-19 06:50:14 | 2021-09-21 15:27:51 | 2021-09-21 15:27:51 | NONE | null | null | null | This seems to be an expensive operation -
https://github.com/facebook/react/blob/aa25824f3ebbdbbea01be48417f2f99251be1a12/packages/react-reconciler/src/ReactFiberTreeReflection.js#L325
used in loops in -
i) https://github.com/facebook/react/blob/aa25824f3ebbdbbea01be48417f2f99251be1a12/packages/react-reconciler... | {'url': 'https://api.github.com/repos/facebook/react/issues/22131/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22131/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22130 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22130/labels{/name} | https://api.github.com/repos/facebook/react/issues/22130/comments | https://api.github.com/repos/facebook/react/issues/22130/events | https://github.com/facebook/react/pull/22130 | 974,136,234 | MDExOlB1bGxSZXF1ZXN0NzE1NDg1NzM5 | 22,130 | Scheduling profiler: Fix tooltip wheel event regression | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [] | 2021-08-18 23:42:34 | 2021-08-18 23:51:36 | 2021-08-18 23:51:34 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22130', 'html_url': 'https://github.com/facebook/react/pull/22130', 'diff_url': 'https://github.com/facebook/react/pull/22130.diff', 'patch_url': 'https://github.com/facebook/react/pull/22130.patch', 'merged_at': datetime.datetime(2021, 8, 18, 23, 51, 34)} | Panning horizontally via mouse wheel used to allow you to scrub over snapshot images. This was accidentally broken by a recent change. The core of the fix for this was to update `useSmartTooltip()` to remove the dependencies array so that a newly rendered tooltip is positioned even if the mouseX/mouseY coordinates don'... | {'url': 'https://api.github.com/repos/facebook/react/issues/22130/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22130/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22129 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22129/labels{/name} | https://api.github.com/repos/facebook/react/issues/22129/comments | https://api.github.com/repos/facebook/react/issues/22129/events | https://github.com/facebook/react/pull/22129 | 974,096,500 | MDExOlB1bGxSZXF1ZXN0NzE1NDUxMzA2 | 22,129 | [DevTools] Using array destructuring without assigning first variable does not error | {'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [] | 2021-08-18 22:13:58 | 2021-08-19 16:34:20 | 2021-08-18 22:26:58 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22129', 'html_url': 'https://github.com/facebook/react/pull/22129', 'diff_url': 'https://github.com/facebook/react/pull/22129.diff', 'patch_url': 'https://github.com/facebook/react/pull/22129.patch', 'merged_at': datetime.datetime(2021, 8, 18, 22, 26, 58)} | ## Summary
Before this commit, if a hook returned an array the was destructured, but without assigning a variable to the first element in the array, this would produce an error. This was detected via internal testing.
This commit fixes that and adds regression tests.
## Test Plan
- yarn flow
- yarn test
... | {'url': 'https://api.github.com/repos/facebook/react/issues/22129/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22129/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22128 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22128/labels{/name} | https://api.github.com/repos/facebook/react/issues/22128/comments | https://api.github.com/repos/facebook/react/issues/22128/events | https://github.com/facebook/react/pull/22128 | 974,093,080 | MDExOlB1bGxSZXF1ZXN0NzE1NDQ4Mjc5 | 22,128 | [DevTools] Support object destructuring pattern without runtime errors | {'login': 'jstejada', 'id': 1271509, 'node_id': 'MDQ6VXNlcjEyNzE1MDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1271509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jstejada', 'html_url': 'https://github.com/jstejada', 'followers_url': 'https://api.github.com/users/jstejada/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [] | 2021-08-18 22:08:28 | 2021-08-18 22:22:39 | 2021-08-18 22:17:29 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22128', 'html_url': 'https://github.com/facebook/react/pull/22128', 'diff_url': 'https://github.com/facebook/react/pull/22128.diff', 'patch_url': 'https://github.com/facebook/react/pull/22128.patch', 'merged_at': datetime.datetime(2021, 8, 18, 22, 17, 29)} | ## Summary
Before this commit, if a hook returned an object and we declared a variable using object destructuring on the returned value, we would produce a runtime error. This was detected via internal testing.
This commit fixes that and adds regression tests.
## Test Plan
- yarn flow
- yarn test
- yarn... | {'url': 'https://api.github.com/repos/facebook/react/issues/22128/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22128/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22127 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22127/labels{/name} | https://api.github.com/repos/facebook/react/issues/22127/comments | https://api.github.com/repos/facebook/react/issues/22127/events | https://github.com/facebook/react/issues/22127 | 973,962,114 | MDU6SXNzdWU5NzM5NjIxMTQ= | 22,127 | Standalone DevTools Profiler should work with no connected clients | {'login': 'mrkev', 'id': 1285131, 'node_id': 'MDQ6VXNlcjEyODUxMzE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1285131?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mrkev', 'html_url': 'https://github.com/mrkev', 'followers_url': 'https://api.github.com/users/mrkev/followers', 'following_ur... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/f... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"The messaging on this splash page is pretty important. Maybe we could keep it, but somehow show it inside of the Components tab– and the Profiler tab could be functional in a read-only (import only) form.",
"That sounds like a good idea, yeah. If the components tab is the one that shows first by default too, peo... | 2021-08-18 18:52:43 | 2021-10-14 12:31:59 | 2021-10-14 12:31:59 | CONTRIBUTOR | null | null | null | When the standalone DevTools are opened without a running React application, this is what's currently shown:
<img width="912" alt="Screen Shot 2021-08-18 at 1 47 49 PM" src="https://user-images.githubusercontent.com/1285131/129954886-681cfa9f-17dd-4ac0-8989-2e08a0d173fc.png">
Being able to use the standalone app ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22127/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22127/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22126 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22126/labels{/name} | https://api.github.com/repos/facebook/react/issues/22126/comments | https://api.github.com/repos/facebook/react/issues/22126/events | https://github.com/facebook/react/pull/22126 | 973,875,876 | MDExOlB1bGxSZXF1ZXN0NzE1MjYzMjY4 | 22,126 | Replace "source-map" library with "source-map-js" | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/f... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: aa25824f3ebbdbbea01be48417f2f99251be1a12...c65364d604ae71e80462953a9f24d392c39c02e5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-08-18 16:54:36 | 2021-08-19 15:26:40 | 2021-08-19 15:25:38 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/22126', 'html_url': 'https://github.com/facebook/react/pull/22126', 'diff_url': 'https://github.com/facebook/react/pull/22126.diff', 'patch_url': 'https://github.com/facebook/react/pull/22126.patch', 'merged_at': datetime.datetime(2021, 8, 19, 15, 25, 38)} | Relates to #22116
Replace the ["source-map"](https://www.npmjs.com/package/source-map) library with ["source-map-js"](https://www.npmjs.com/package/source-map-js).
I did some light spot checking (using some slower-to-parse Facebook components) and here are the results:
Parsing hooks for component A:
* `sourc... | {'url': 'https://api.github.com/repos/facebook/react/issues/22126/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22126/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/22125 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22125/labels{/name} | https://api.github.com/repos/facebook/react/issues/22125/comments | https://api.github.com/repos/facebook/react/issues/22125/events | https://github.com/facebook/react/issues/22125 | 973,805,216 | MDU6SXNzdWU5NzM4MDUyMTY= | 22,125 | Bug: | {'login': 'SHROYETA20', 'id': 73007794, 'node_id': 'MDQ6VXNlcjczMDA3Nzk0', 'avatar_url': 'https://avatars.githubusercontent.com/u/73007794?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/SHROYETA20', 'html_url': 'https://github.com/SHROYETA20', 'followers_url': 'https://api.github.com/users/SHROYETA20/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2021-08-18 15:30:26 | 2021-08-18 15:30:36 | 2021-08-18 15:30:36 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/22125/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22125/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22124 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22124/labels{/name} | https://api.github.com/repos/facebook/react/issues/22124/comments | https://api.github.com/repos/facebook/react/issues/22124/events | https://github.com/facebook/react/issues/22124 | 973,739,445 | MDU6SXNzdWU5NzM3Mzk0NDU= | 22,124 | Bug: | {'login': 'mishrajisubhankar', 'id': 89147133, 'node_id': 'MDQ6VXNlcjg5MTQ3MTMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/89147133?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mishrajisubhankar', 'html_url': 'https://github.com/mishrajisubhankar', 'followers_url': 'https://api.github.com... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"bug issuse",
"I'm closing this issue because it seems to have been opened by mistake. If you meant to open an issue, please feel in all of the required fields next time (describing the bug and how to reproduce it)."
] | 2021-08-18 14:38:32 | 2021-08-18 14:55:45 | 2021-08-18 14:52:44 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/22124/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22124/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22123 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22123/labels{/name} | https://api.github.com/repos/facebook/react/issues/22123/comments | https://api.github.com/repos/facebook/react/issues/22123/events | https://github.com/facebook/react/issues/22123 | 973,468,559 | MDU6SXNzdWU5NzM0Njg1NTk= | 22,123 | [DevTools Bug]: Profiler freezes when navigating through commits | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"I cannot reproduce this(the crash) but I experience some freeze periods when changing commits, I tried `localhost:3000/components/slider` on Linux with Brave and on Windows with Chromium, both have a little freeze when changing commits, the machines are different and it is worse on the Linux one. The bigger the vi... | 2021-08-18 09:33:30 | 2021-08-20 18:08:23 | 2021-08-20 18:08:23 | COLLABORATOR | null | null | null | ### Website or app
https://github.com/eps1lon/material-ui/tree/757f6cf571557f8b03a372db5c7cc1cf3837c944
### Repro steps
1. Enable chrome://flags/#enable-throttle-display-none-and-visibility-hidden-cross-origin-iframes
1. goto https://611f52616dca6500083055f2--material-ui.netlify.app/components/slider/#Continu... | {'url': 'https://api.github.com/repos/facebook/react/issues/22123/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22123/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22122 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22122/labels{/name} | https://api.github.com/repos/facebook/react/issues/22122/comments | https://api.github.com/repos/facebook/react/issues/22122/events | https://github.com/facebook/react/issues/22122 | 973,457,690 | MDU6SXNzdWU5NzM0NTc2OTA= | 22,122 | [DevTools Bug]: Cannot hover/click elements after scrolling | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"cant reproduce on windows, firefox or chrome, filters disabled",
"Reproducing on Chrome Version 92.0.4515.131 Ubuntu 20.04. @iunfixit Which version of Chrome are you using?",
"92.0.4515.159",
"> 92.0.4515.159\r\n\r\nCan reproduce on 92.0.4515.159 as well.",
"Chromium 92.0.4515.0 on Windows, I can try on Li... | 2021-08-18 09:21:06 | 2022-05-11 20:51:33 | null | COLLABORATOR | null | null | null | ### Website or app
https://9tdhf.csb.app/
### Repro steps
1. disable any component filter
2. scroll component tree
3. hover any element
https://user-images.githubusercontent.com/12292047/129872819-0e3c06aa-fc24-4c15-84c7-73940eb136b3.mp4
### How often does this bug happen?
Every time
### DevTools package... | {'url': 'https://api.github.com/repos/facebook/react/issues/22122/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22122/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/22121 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22121/labels{/name} | https://api.github.com/repos/facebook/react/issues/22121/comments | https://api.github.com/repos/facebook/react/issues/22121/events | https://github.com/facebook/react/issues/22121 | 973,389,228 | MDU6SXNzdWU5NzMzODkyMjg= | 22,121 | update fbjs to remove the vulnerability | {'login': 'evansrobert', 'id': 88469407, 'node_id': 'MDQ6VXNlcjg4NDY5NDA3', 'avatar_url': 'https://avatars.githubusercontent.com/u/88469407?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/evansrobert', 'html_url': 'https://github.com/evansrobert', 'followers_url': 'https://api.github.com/users/evansrobert... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"> I do not know if this vulnerability actually affects react\r\n\r\nNo, it does not. React doesn’t use that module at all, so it’s not in your bundle. (Effectively it’s an unused transitive dependency.)\r\n\r\n> is there any posibility that you could release an update version for 15.7.* (ie 15.7.1) that introduces... | 2021-08-18 08:03:44 | 2021-08-18 11:46:24 | 2021-08-18 11:46:23 | NONE | null | null | null | ### Subject of the issue
**react@15.7.0** requires **node-fetch@1.7.3**, which has a security problem (see: [**CVE-2020-15168**](https://snyk.io/vuln/SNYK-JS-NODEFETCH-674311)):
`react@15.7.0 ➔ fbjs@0.8.17 ➔ isomorphic-fetch@2.2.1 ➔ node-fetch@1.7.3`
I do not know if this vulnerability actually affects **react**, ... | {'url': 'https://api.github.com/repos/facebook/react/issues/22121/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22121/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/22120 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/22120/labels{/name} | https://api.github.com/repos/facebook/react/issues/22120/comments | https://api.github.com/repos/facebook/react/issues/22120/events | https://github.com/facebook/react/issues/22120 | 973,334,760 | MDU6SXNzdWU5NzMzMzQ3NjA= | 22,120 | Bug: | {'login': 'Pranav127', 'id': 69231697, 'node_id': 'MDQ6VXNlcjY5MjMxNjk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/69231697?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Pranav127', 'html_url': 'https://github.com/Pranav127', 'followers_url': 'https://api.github.com/users/Pranav127/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"<!--\r\n Please provide a clear and concise description of what the bug is. Include\r\n screenshots if needed. Please test using the latest version of the relevant\r\n React packages to make sure your issue has not already been fixed.\r\n-->\r\n\r\nReact version:\r\n\r\n## Steps To Reproduce\r\n\r\n1.\r\n2.\r\n... | 2021-08-18 06:49:28 | 2021-08-18 14:55:50 | 2021-08-18 14:53:51 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/22120/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/22120/timeline | null | completed | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.