url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/21917 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21917/labels{/name} | https://api.github.com/repos/facebook/react/issues/21917/comments | https://api.github.com/repos/facebook/react/issues/21917/events | https://github.com/facebook/react/pull/21917 | 948,181,108 | MDExOlB1bGxSZXF1ZXN0NjkzMDU3ODg1 | 21,917 | Bump urijs from 1.19.2 to 1.19.7 in /fixtures/dom | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 3f62dec84aba5d7ae6dfc73d68752254e8f06384...379696ccebab0301d4ff60f94f2296855c686661\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-20 02:08:18 | 2021-07-20 02:29:03 | 2021-07-20 02:28:26 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21917', 'html_url': 'https://github.com/facebook/react/pull/21917', 'diff_url': 'https://github.com/facebook/react/pull/21917.diff', 'patch_url': 'https://github.com/facebook/react/pull/21917.patch', 'merged_at': None} | Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.2 to 1.19.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/medialize/URI.js/releases">urijs's releases</a>.</em></p>
<blockquote>
<h2>1.19.7 (July 14th 2021)</h2>
<ul>
<li><strong>SECURITY</strong> fixing <a href="... | {'url': 'https://api.github.com/repos/facebook/react/issues/21917/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21917/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21916 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21916/labels{/name} | https://api.github.com/repos/facebook/react/issues/21916/comments | https://api.github.com/repos/facebook/react/issues/21916/events | https://github.com/facebook/react/pull/21916 | 948,180,778 | MDExOlB1bGxSZXF1ZXN0NjkzMDU3NTg1 | 21,916 | Bump urijs from 1.18.12 to 1.19.7 in /fixtures/attribute-behavior | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 3f62dec84aba5d7ae6dfc73d68752254e8f06384...53fbeef7c4905bf114ee1e16eeae91b56fb53e76\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-20 02:07:53 | 2021-07-20 02:29:03 | 2021-07-20 02:28:24 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21916', 'html_url': 'https://github.com/facebook/react/pull/21916', 'diff_url': 'https://github.com/facebook/react/pull/21916.diff', 'patch_url': 'https://github.com/facebook/react/pull/21916.patch', 'merged_at': None} | Bumps [urijs](https://github.com/medialize/URI.js) from 1.18.12 to 1.19.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/medialize/URI.js/releases">urijs's releases</a>.</em></p>
<blockquote>
<h2>1.19.7 (July 14th 2021)</h2>
<ul>
<li><strong>SECURITY</strong> fixing <a href=... | {'url': 'https://api.github.com/repos/facebook/react/issues/21916/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21916/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21915 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21915/labels{/name} | https://api.github.com/repos/facebook/react/issues/21915/comments | https://api.github.com/repos/facebook/react/issues/21915/events | https://github.com/facebook/react/pull/21915 | 948,180,438 | MDExOlB1bGxSZXF1ZXN0NjkzMDU3MjY2 | 21,915 | Bump urijs from 1.19.0 to 1.19.7 in /fixtures/expiration | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 3f62dec84aba5d7ae6dfc73d68752254e8f06384...811b34b260ddf95a7476908301e1bb19f0350da0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-20 02:07:29 | 2021-07-20 02:29:03 | 2021-07-20 02:28:21 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21915', 'html_url': 'https://github.com/facebook/react/pull/21915', 'diff_url': 'https://github.com/facebook/react/pull/21915.diff', 'patch_url': 'https://github.com/facebook/react/pull/21915.patch', 'merged_at': None} | Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.0 to 1.19.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/medialize/URI.js/releases">urijs's releases</a>.</em></p>
<blockquote>
<h2>1.19.7 (July 14th 2021)</h2>
<ul>
<li><strong>SECURITY</strong> fixing <a href="... | {'url': 'https://api.github.com/repos/facebook/react/issues/21915/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21915/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21914 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21914/labels{/name} | https://api.github.com/repos/facebook/react/issues/21914/comments | https://api.github.com/repos/facebook/react/issues/21914/events | https://github.com/facebook/react/issues/21914 | 948,168,791 | MDU6SXNzdWU5NDgxNjg3OTE= | 21,914 | Bug: useEffect not running with back-to-back renders despite dependencies changing | {'login': 'mogzol', 'id': 11789801, 'node_id': 'MDQ6VXNlcjExNzg5ODAx', 'avatar_url': 'https://avatars.githubusercontent.com/u/11789801?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mogzol', 'html_url': 'https://github.com/mogzol', 'followers_url': 'https://api.github.com/users/mogzol/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Thanks for the feedback.\r\n\r\nThe ESLint warning from `react-hooks/exhaustive-deps` already mentions this problem:\r\n> 'ref.current' aren't valid dependencies because mutating them doesn't re-render the component.\r\n\r\nIf you want to \"make a ref reactive\" you can read and write the value with `useState` ins... | 2021-07-20 01:50:15 | 2021-07-20 17:19:10 | 2021-07-20 06:35:06 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.2
## Steps To Reproduce
Please see the example linked ... | {'url': 'https://api.github.com/repos/facebook/react/issues/21914/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21914/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21913 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21913/labels{/name} | https://api.github.com/repos/facebook/react/issues/21913/comments | https://api.github.com/repos/facebook/react/issues/21913/events | https://github.com/facebook/react/pull/21913 | 948,058,671 | MDExOlB1bGxSZXF1ZXN0NjkyOTUwOTM4 | 21,913 | [Experimental] Add useInsertionEffect | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | {'login': 'rickhanlonii', 'id': 2440089.0, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanl... | [{'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlo... | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 81db4eb1d1178cb84b8b20df090a952f9dffac7d...ab6ad9fc0c25d08b148aee69958e4764ca10d1f1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-19 21:56:32 | 2021-09-14 16:52:04 | 2021-09-14 14:27:09 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21913', 'html_url': 'https://github.com/facebook/react/pull/21913', 'diff_url': 'https://github.com/facebook/react/pull/21913.diff', 'patch_url': 'https://github.com/facebook/react/pull/21913.patch', 'merged_at': datetime.datetime(2021, 9, 14, 14, 27, 9)} | ## Overview
Adds back the experimental `useMutationEffect` [hook](https://github.com/facebook/react/pull/14336) as `useInsertionEffect`, initially intended for stylesheet libraries.
## Semantics
This hook is called right before mutations are made to the host, to allow inserting dependencies of the soon-to-be m... | {'url': 'https://api.github.com/repos/facebook/react/issues/21913/reactions', 'total_count': 13, '+1': 10, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 3} | https://api.github.com/repos/facebook/react/issues/21913/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21912 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21912/labels{/name} | https://api.github.com/repos/facebook/react/issues/21912/comments | https://api.github.com/repos/facebook/react/issues/21912/events | https://github.com/facebook/react/issues/21912 | 947,633,743 | MDU6SXNzdWU5NDc2MzM3NDM= | 21,912 | Bug: Potential bug in “official” useInterval example | {'login': 'gmoniava', 'id': 77232558, 'node_id': 'MDQ6VXNlcjc3MjMyNTU4', 'avatar_url': 'https://avatars.githubusercontent.com/u/77232558?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gmoniava', 'html_url': 'https://github.com/gmoniava', 'followers_url': 'https://api.github.com/users/gmoniava/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 710375792, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"The report on Stack Overflow doesn't look like a bug to me.\r\n\r\nThe answer that suggests updating the ref during render would be a side effect, which [should be avoided because it will cause problems](https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects).\r\n\r\n> The demo shows that the ... | 2021-07-19 13:06:30 | 2021-07-26 14:17:05 | 2021-07-19 13:45:06 | NONE | null | null | null | Maybe this is not a bug of react, but this is related to a blog post by react team member; many people have probably read or used that post.
The bug is explained here: https://stackoverflow.com/questions/68407187/potential-bug-in-official-useinterval-example
I think feedback from react team would be useful. | {'url': 'https://api.github.com/repos/facebook/react/issues/21912/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21912/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21911 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21911/labels{/name} | https://api.github.com/repos/facebook/react/issues/21911/comments | https://api.github.com/repos/facebook/react/issues/21911/events | https://github.com/facebook/react/issues/21911 | 947,573,281 | MDU6SXNzdWU5NDc1NzMyODE= | 21,911 | Bug: The high CPU in the React GPU rendering process causes the page to freeze。 | {'login': 'enjoy-wind', 'id': 39360554, 'node_id': 'MDQ6VXNlcjM5MzYwNTU0', 'avatar_url': 'https://avatars.githubusercontent.com/u/39360554?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/enjoy-wind', 'html_url': 'https://github.com/enjoy-wind', 'followers_url': 'https://api.github.com/users/enjoy-wind/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'enjoy-wind', 'id': 39360554.0, 'node_id': 'MDQ6VXNlcjM5MzYwNTU0', 'avatar_url': 'https://avatars.githubusercontent.com/u/39360554?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/enjoy-wind', 'html_url': 'https://github.com/enjoy-wind', 'followers_url': 'https://api.github.com/users/enjoy-wind/f... | [{'login': 'enjoy-wind', 'id': 39360554, 'node_id': 'MDQ6VXNlcjM5MzYwNTU0', 'avatar_url': 'https://avatars.githubusercontent.com/u/39360554?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/enjoy-wind', 'html_url': 'https://github.com/enjoy-wind', 'followers_url': 'https://api.github.com/users/enjoy-wind/fo... | null | [
"Unfortunately, it doesn't look like this issue has enough info for one of us to reproduce it though. This means that **it's going to be very hard for us to fix**.\r\n\r\nPlease help us by providing a link to a CodeSandbox (https://codesandbox.io/s/new), a repository on GitHub, or a minimal code example that reprod... | 2021-07-19 11:52:38 | 2022-03-30 01:33:34 | 2022-03-30 01:33:34 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 15.3
## Steps To Reproduce
CONIF: CPU：2G Browser: Chrome/9... | {'url': 'https://api.github.com/repos/facebook/react/issues/21911/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21911/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21910 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21910/labels{/name} | https://api.github.com/repos/facebook/react/issues/21910/comments | https://api.github.com/repos/facebook/react/issues/21910/events | https://github.com/facebook/react/issues/21910 | 947,461,653 | MDU6SXNzdWU5NDc0NjE2NTM= | 21,910 | Discussion: break up `import()` that are NOT doing ES import work ? | {'login': 'headwindz', 'id': 7504237, 'node_id': 'MDQ6VXNlcjc1MDQyMzc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7504237?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/headwindz', 'html_url': 'https://github.com/headwindz', 'followers_url': 'https://api.github.com/users/headwindz/followers... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"`import()` is a ES6 feature has been widely supported. https://caniuse.com/?search=import()\r\nAnd React.lazy() uses it to support Suspense Component, which is a core part of React Concurrent. If you don't use Suspense, I guess, the block of it won't give rise to any issue in your case. ",
"I _think_ the request... | 2021-07-19 09:32:33 | 2021-09-06 20:21:09 | 2021-09-06 20:21:09 | CONTRIBUTOR | null | null | null | # Background information
I have been developing a [fimga](https://www.figma.com/) plugin and recently get an exact error as described in https://github.com/figma/plugin-typings/issues/36. The root cause is that the [Secure ECMAScript (SES)](https://github.com/endojs/endo/tree/master/packages/ses) in figma tries to b... | {'url': 'https://api.github.com/repos/facebook/react/issues/21910/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21910/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21909 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21909/labels{/name} | https://api.github.com/repos/facebook/react/issues/21909/comments | https://api.github.com/repos/facebook/react/issues/21909/events | https://github.com/facebook/react/issues/21909 | 947,002,575 | MDU6SXNzdWU5NDcwMDI1NzU= | 21,909 | typescript Missing multi forward ref ability | {'login': 'RayLuxembourg', 'id': 15327989, 'node_id': 'MDQ6VXNlcjE1MzI3OTg5', 'avatar_url': 'https://avatars.githubusercontent.com/u/15327989?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/RayLuxembourg', 'html_url': 'https://github.com/RayLuxembourg', 'followers_url': 'https://api.github.com/users/RayLu... | [] | closed | false | null | [] | null | [
"@RayLuxembourg The typedefs for react are in the [`@types/react`](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) package, so that repo may be a better place for this issue. Also, a code example would make it easier to understand the problem",
"The React team doesn't maintain the Type... | 2021-07-18 10:29:57 | 2021-07-18 15:36:13 | 2021-07-18 15:36:13 | NONE | null | null | null | **Description:**
Allow passing multiple refs using forward ref or new function that accepts refs as object containing multiple refs
Currently typescript will throw errors but it works.
Seems like only a type issue. | {'url': 'https://api.github.com/repos/facebook/react/issues/21909/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21909/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21908 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21908/labels{/name} | https://api.github.com/repos/facebook/react/issues/21908/comments | https://api.github.com/repos/facebook/react/issues/21908/events | https://github.com/facebook/react/pull/21908 | 946,965,865 | MDExOlB1bGxSZXF1ZXN0NjkyMDM5NTk5 | 21,908 | react-devtools: set icon on macos | {'login': 'christian-schulze', 'id': 239226, 'node_id': 'MDQ6VXNlcjIzOTIyNg==', 'avatar_url': 'https://avatars.githubusercontent.com/u/239226?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/christian-schulze', 'html_url': 'https://github.com/christian-schulze', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 262ff7ad2c4a018de9992731fcf8a8f9c91083d8...e776fd918e52a0a513c32ce081da736526b531cc\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-18 06:47:47 | 2021-07-19 14:26:42 | 2021-07-19 14:26:41 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21908', 'html_url': 'https://github.com/facebook/react/pull/21908', 'diff_url': 'https://github.com/facebook/react/pull/21908.diff', 'patch_url': 'https://github.com/facebook/react/pull/21908.patch', 'merged_at': datetime.datetime(2021, 7, 19, 14, 26, 41)} | ## Summary
Running `react-devtools` on MacOS shows the default electron icon in the dock.
## Test Plan
```bash
cd packages/react-devtools/
yarn start
```
Observe that the dock icon is now the correct react icon.
| {'url': 'https://api.github.com/repos/facebook/react/issues/21908/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21908/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21903 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21903/labels{/name} | https://api.github.com/repos/facebook/react/issues/21903/comments | https://api.github.com/repos/facebook/react/issues/21903/events | https://github.com/facebook/react/issues/21903 | 946,836,619 | MDU6SXNzdWU5NDY4MzY2MTk= | 21,903 | React 18 let's make ref.currant to be reactive value | {'login': 'MaxmaxmaximusAWS', 'id': 69426460, 'node_id': 'MDQ6VXNlcjY5NDI2NDYw', 'avatar_url': 'https://avatars.githubusercontent.com/u/69426460?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MaxmaxmaximusAWS', 'html_url': 'https://github.com/MaxmaxmaximusAWS', 'followers_url': 'https://api.github.com/us... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | open | false | null | [] | null | [
"Making refs \"reactive\" as you say would essentially make them the same as the `useState` hook. If you want a value that ensures a re-render on change, use the state hook. Can you explain why that would not be sufficient?\r\n\r\n---\r\n\r\n**Edit** To be clear, the issue is not that a change in ref value won't re... | 2021-07-17 14:39:21 | 2023-05-18 20:50:26 | null | NONE | null | null | null | Let's add this hook as part of the core. Since this is a common need, many people often ask the question "Why does useEffect not sense ref.current changes?"
```js
// approximate implementation
const useReactiveRef = (defaultValue) => {
const [current, ref] = useState(defaultValue)
ref.current = current
re... | {'url': 'https://api.github.com/repos/facebook/react/issues/21903/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21903/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/21902 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21902/labels{/name} | https://api.github.com/repos/facebook/react/issues/21902/comments | https://api.github.com/repos/facebook/react/issues/21902/events | https://github.com/facebook/react/pull/21902 | 946,696,679 | MDExOlB1bGxSZXF1ZXN0NjkxODI3MTYx | 21,902 | DevTools: Parse named source AST in a worker | {'login': 'tsirlucas', 'id': 18744505, 'node_id': 'MDQ6VXNlcjE4NzQ0NTA1', 'avatar_url': 'https://avatars.githubusercontent.com/u/18744505?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tsirlucas', 'html_url': 'https://github.com/tsirlucas', 'followers_url': 'https://api.github.com/users/tsirlucas/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 310187264d01a31bc3079358f13662d31a079d9e...d2b962de0de1878b5ff6aed6e2d64e846edac7c0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-17 03:19:51 | 2021-07-21 16:16:09 | 2021-07-21 16:16:08 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21902', 'html_url': 'https://github.com/facebook/react/pull/21902', 'diff_url': 'https://github.com/facebook/react/pull/21902.diff', 'patch_url': 'https://github.com/facebook/react/pull/21902.patch', 'merged_at': datetime.datetime(2021, 7, 21, 16, 16, 8)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/21902/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21902/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21901 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21901/labels{/name} | https://api.github.com/repos/facebook/react/issues/21901/comments | https://api.github.com/repos/facebook/react/issues/21901/events | https://github.com/facebook/react/pull/21901 | 946,623,465 | MDExOlB1bGxSZXF1ZXN0NjkxNzY2MjA2 | 21,901 | Implement enableSuspenseLayoutEffectSemantics in Fabric | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 34600f4fadf526028a21c94030510fbed20e4665...1c469c719273cfa1841a1d46a6d425990554b017\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-16 22:07:17 | 2021-07-16 22:58:12 | 2021-07-16 22:58:12 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21901', 'html_url': 'https://github.com/facebook/react/pull/21901', 'diff_url': 'https://github.com/facebook/react/pull/21901.diff', 'patch_url': 'https://github.com/facebook/react/pull/21901.patch', 'merged_at': datetime.datetime(2021, 7, 16, 22, 58, 12)} | Similar to #21898, but for "disappear" logic. Previously this lived inside `hideOrUnhideAllChildren`, the function that mutates the nearest DOM nodes to override their `display` style.
This makes the feature work in persistent mode (Fabric); it didn't before because `hideOrUnhideAllChildren` only runs in mutation mo... | {'url': 'https://api.github.com/repos/facebook/react/issues/21901/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21901/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21900 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21900/labels{/name} | https://api.github.com/repos/facebook/react/issues/21900/comments | https://api.github.com/repos/facebook/react/issues/21900/events | https://github.com/facebook/react/issues/21900 | 946,579,073 | MDU6SXNzdWU5NDY1NzkwNzM= | 21,900 | [DevTools] Refactor imperative theme code | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}
{'id': 725156255, 'node_id': 'MDU6TGFiZWw3MjUxNTYyNTU=', 'url': 'https://... | closed | false | {'login': 'houssemchebeb', 'id': 59608551.0, 'node_id': 'MDQ6VXNlcjU5NjA4NTUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/59608551?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/houssemchebeb', 'html_url': 'https://github.com/houssemchebeb', 'followers_url': 'https://api.github.com/users/hou... | [{'login': 'houssemchebeb', 'id': 59608551, 'node_id': 'MDQ6VXNlcjU5NjA4NTUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/59608551?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/houssemchebeb', 'html_url': 'https://github.com/houssemchebeb', 'followers_url': 'https://api.github.com/users/hous... | null | [
"Hi @bvaughn, can i take this ?",
"This issue is all yours @houssemchebeb 😄\r\n\r\nI've added the **\"good first issue (taken)\"** label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up fo... | 2021-07-16 20:31:08 | 2021-08-02 15:20:12 | 2021-08-02 15:20:12 | CONTRIBUTOR | null | null | null | DevTools defaults a "light" and a "dark" theme in a root-level CSS file:
https://github.com/facebook/react/blob/310187264d01a31bc3079358f13662d31a079d9e/packages/react-devtools-shared/src/devtools/views/root.css#L1-L188
The current theme value ("light", "dark", or "auto") is stored in the [`ThemeContext`](https://g... | {'url': 'https://api.github.com/repos/facebook/react/issues/21900/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21900/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21899 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21899/labels{/name} | https://api.github.com/repos/facebook/react/issues/21899/comments | https://api.github.com/repos/facebook/react/issues/21899/events | https://github.com/facebook/react/issues/21899 | 946,515,335 | MDU6SXNzdWU5NDY1MTUzMzU= | 21,899 | Bug: Transactions with React Context data store are aggregated when called within same function | {'login': 'l-monninger', 'id': 79056955, 'node_id': 'MDQ6VXNlcjc5MDU2OTU1', 'avatar_url': 'https://avatars.githubusercontent.com/u/79056955?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/l-monninger', 'html_url': 'https://github.com/l-monninger', 'followers_url': 'https://api.github.com/users/l-monninger... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The code in the PasteBin is formatted a bit awkwardly. But as far as I can tell, this is entirely standard React batching behavior. Multiple state updates queued in a single event handler will all be batched into one render pass:\r\n\r\nhttps://blog.isquaredsoftware.com/2020/05/blogged-answers-a-mostly-complete-... | 2021-07-16 18:38:05 | 2021-07-17 15:47:48 | 2021-07-17 14:56:29 | NONE | null | null | null | I've made a SO post about this [here](https://stackoverflow.com/questions/68412614/react-context-updates-in-same-function-body-are-aggregated-as-a-single-transacti). I'm not sure that this is a bug, as it is something I can work around. I am more interested in understanding why this should or shouldn't be expected beha... | {'url': 'https://api.github.com/repos/facebook/react/issues/21899/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21899/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21898 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21898/labels{/name} | https://api.github.com/repos/facebook/react/issues/21898/comments | https://api.github.com/repos/facebook/react/issues/21898/events | https://github.com/facebook/react/pull/21898 | 946,498,929 | MDExOlB1bGxSZXF1ZXN0NjkxNjYyNjY1 | 21,898 | Refactor "reappear" logic into its own traversal | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 310187264d01a31bc3079358f13662d31a079d9e...5a1691659c22103b365461ee80ef37eede7cf830\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-16 18:10:48 | 2021-07-16 22:05:39 | 2021-07-16 22:05:39 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21898', 'html_url': 'https://github.com/facebook/react/pull/21898', 'diff_url': 'https://github.com/facebook/react/pull/21898.diff', 'patch_url': 'https://github.com/facebook/react/pull/21898.patch', 'merged_at': datetime.datetime(2021, 7, 16, 22, 5, 39)} | When a Suspense boundary switches to its fallback state — or similarly, when an Offscreen boundary switches from visible to hidden — we unmount all its layout effects. When it resolves — or when Offscreen switches back to visible — we mount them again. This "reappearing" logic currently happens in the same commit phase... | {'url': 'https://api.github.com/repos/facebook/react/issues/21898/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21898/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21897 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21897/labels{/name} | https://api.github.com/repos/facebook/react/issues/21897/comments | https://api.github.com/repos/facebook/react/issues/21897/events | https://github.com/facebook/react/pull/21897 | 946,464,115 | MDExOlB1bGxSZXF1ZXN0NjkxNjMzNjg4 | 21,897 | [DRAFT] Import scheduling profiler into DevTools Profiler | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 25f09e3e4e900fc5d510243ce9ed3272d0af59e7...ab1efcfd5b13cb9f2f887c53e4cf07449a9c500c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-16 17:10:55 | 2021-07-22 18:01:31 | 2021-07-22 17:58:57 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21897', 'html_url': 'https://github.com/facebook/react/pull/21897', 'diff_url': 'https://github.com/facebook/react/pull/21897.diff', 'patch_url': 'https://github.com/facebook/react/pull/21897.patch', 'merged_at': datetime.datetime(2021, 7, 22, 17, 58, 57)} | Related to #21866; alternate for #19892.
- [x] Import scheduling profiler into Profiler tab
- [x] Disable Vercel deploy script for old standalone scheduling profiler
- [x] Hide right panel when scheduling profiler is open (more horizontal space)
- [x] Make sure new profiler colors have light and dark theme varian... | {'url': 'https://api.github.com/repos/facebook/react/issues/21897/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 3, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21897/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21896 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21896/labels{/name} | https://api.github.com/repos/facebook/react/issues/21896/comments | https://api.github.com/repos/facebook/react/issues/21896/events | https://github.com/facebook/react/pull/21896 | 945,965,746 | MDExOlB1bGxSZXF1ZXN0NjkxMjEzODg3 | 21,896 | Added VS Code Badge | {'login': 'anilloutombam', 'id': 23106365, 'node_id': 'MDQ6VXNlcjIzMTA2MzY1', 'avatar_url': 'https://avatars.githubusercontent.com/u/23106365?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anilloutombam', 'html_url': 'https://github.com/anilloutombam', 'followers_url': 'https://api.github.com/users/anill... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @anilloutombam! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order... | 2021-07-16 05:47:05 | 2021-07-19 21:20:28 | 2021-07-19 21:20:28 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21896', 'html_url': 'https://github.com/facebook/react/pull/21896', 'diff_url': 'https://github.com/facebook/react/pull/21896.diff', 'patch_url': 'https://github.com/facebook/react/pull/21896.patch', 'merged_at': None} | Click badge to open on VS Code directly.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please m... | {'url': 'https://api.github.com/repos/facebook/react/issues/21896/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21896/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21895 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21895/labels{/name} | https://api.github.com/repos/facebook/react/issues/21895/comments | https://api.github.com/repos/facebook/react/issues/21895/events | https://github.com/facebook/react/issues/21895 | 945,932,583 | MDU6SXNzdWU5NDU5MzI1ODM= | 21,895 | react developer tools | {'login': 'vassadia', 'id': 48137825, 'node_id': 'MDQ6VXNlcjQ4MTM3ODI1', 'avatar_url': 'https://avatars.githubusercontent.com/u/48137825?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vassadia', 'html_url': 'https://github.com/vassadia', 'followers_url': 'https://api.github.com/users/vassadia/followers',... | [{'id': 40929155, 'node_id': 'MDU6TGFiZWw0MDkyOTE1NQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Question', 'name': 'Type: Question', 'color': 'cc317c', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebo... | closed | false | null | [] | null | [
"The Components and Profiler tabs will only be visible when you're viewing a website that uses React. Try opening [reactjs.org](https://www.reactjs.org) as an example.\r\n\r\nIf that doesn't work, please also try restarting your browser."
] | 2021-07-16 04:26:13 | 2021-07-16 13:58:18 | 2021-07-16 13:58:03 | NONE | null | null | null | I successfully installed the extensions but i am not able to see the the news tabs ( components and react | {'url': 'https://api.github.com/repos/facebook/react/issues/21895/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21895/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21894 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21894/labels{/name} | https://api.github.com/repos/facebook/react/issues/21894/comments | https://api.github.com/repos/facebook/react/issues/21894/events | https://github.com/facebook/react/pull/21894 | 945,923,896 | MDExOlB1bGxSZXF1ZXN0NjkxMTc4ODIz | 21,894 | Remove named hooks feature flag | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: e26cb8f86db0936e14682c39e2d26373fa6f433d...214b6e1f13c2a74c113223637e22e63d928aa300\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-16 04:05:57 | 2021-07-16 04:14:21 | 2021-07-16 04:14:20 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21894', 'html_url': 'https://github.com/facebook/react/pull/21894', 'diff_url': 'https://github.com/facebook/react/pull/21894.diff', 'patch_url': 'https://github.com/facebook/react/pull/21894.patch', 'merged_at': datetime.datetime(2021, 7, 16, 4, 14, 20)} | This feature is ready for launch. | {'url': 'https://api.github.com/repos/facebook/react/issues/21894/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21894/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21891 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21891/labels{/name} | https://api.github.com/repos/facebook/react/issues/21891/comments | https://api.github.com/repos/facebook/react/issues/21891/events | https://github.com/facebook/react/pull/21891 | 945,804,592 | MDExOlB1bGxSZXF1ZXN0NjkxMDgwMDQ1 | 21,891 | Clear named hooks Suspense and AST cache after a Fast Refresh | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Not sure how feasible it is to create an end-to-end test that combines Fast Refresh + DevTools + named hooks parsing (with mock `fetch`). I'll sleep on it.",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 682bbd0e7212df0bfe1d8017284e2822d28... | 2021-07-15 22:47:28 | 2021-07-16 03:39:50 | 2021-07-16 03:39:30 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21891', 'html_url': 'https://github.com/facebook/react/pull/21891', 'diff_url': 'https://github.com/facebook/react/pull/21891.diff', 'patch_url': 'https://github.com/facebook/react/pull/21891.patch', 'merged_at': datetime.datetime(2021, 7, 16, 3, 39, 30)} | Observe when Fast Refresh tells React to schedule a refresh and clear any cached hook names metadata.
Resolves #21796
- [x] Clear Suspense cache after Fast Refresh scheduled
- [ ] Add unit test(s) | {'url': 'https://api.github.com/repos/facebook/react/issues/21891/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21891/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21890 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21890/labels{/name} | https://api.github.com/repos/facebook/react/issues/21890/comments | https://api.github.com/repos/facebook/react/issues/21890/events | https://github.com/facebook/react/issues/21890 | 945,709,525 | MDU6SXNzdWU5NDU3MDk1MjU= | 21,890 | [DevTools] Global console log | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https:/... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2021-07-15 20:01:27 | 2024-04-10 13:03:57 | 2024-04-10 13:03:57 | CONTRIBUTOR | null | null | null | Builds on top of #21889.
Console logs are currently scattered and confusing (e.g. double rendering may show logs twice, logs printed before a component suspends may appear to be truncated unexpected and then later printed again when retrying). Overall the sequence of logs in the console can be confusing.
The DevT... | {'url': 'https://api.github.com/repos/facebook/react/issues/21890/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21890/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/21889 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21889/labels{/name} | https://api.github.com/repos/facebook/react/issues/21889/comments | https://api.github.com/repos/facebook/react/issues/21889/events | https://github.com/facebook/react/issues/21889 | 945,705,110 | MDU6SXNzdWU5NDU3MDUxMTA= | 21,889 | [DevTools] Console logging and StrictMode double rendering | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'lunaruan', 'id': 2735514.0, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers',... | [{'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', ... | null | [
"I would like to work on this. If nobody is working on this. I can start working on exposing new debugging preferences as mentioned above. Could you please clarify the second point about adding an API for DevTools and React to communicate.\r\n\r\n@bvaughn ",
"Thanks for the offer, @ziauddin-copods, but Luna Ruan ... | 2021-07-15 19:54:27 | 2021-08-25 22:35:38 | 2021-08-25 22:35:38 | CONTRIBUTOR | null | null | null | React currently suppress all console logs while double rendering (or double invoking render phase lifecycles) to reduce console noise, e.g.:
https://github.com/facebook/react/blob/310187264d01a31bc3079358f13662d31a079d9e/packages/react-reconciler/src/ReactFiberBeginWork.new.js#L366-L384
Unfortunately this often cau... | {'url': 'https://api.github.com/repos/facebook/react/issues/21889/reactions', 'total_count': 7, '+1': 7, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21889/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21888 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21888/labels{/name} | https://api.github.com/repos/facebook/react/issues/21888/comments | https://api.github.com/repos/facebook/react/issues/21888/events | https://github.com/facebook/react/issues/21888 | 945,680,794 | MDU6SXNzdWU5NDU2ODA3OTQ= | 21,888 | Bug: Useeffect Dependency List Dosent Recorgnise optional chaining | {'login': 'pappyJ', 'id': 65920240, 'node_id': 'MDQ6VXNlcjY1OTIwMjQw', 'avatar_url': 'https://avatars.githubusercontent.com/u/65920240?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pappyJ', 'html_url': 'https://github.com/pappyJ', 'followers_url': 'https://api.github.com/users/pappyJ/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2021-07-15 19:16:34 | 2024-04-10 13:03:59 | 2024-04-10 13:03:58 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.Write code with side effects inside... | {'url': 'https://api.github.com/repos/facebook/react/issues/21888/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21888/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/21887 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21887/labels{/name} | https://api.github.com/repos/facebook/react/issues/21887/comments | https://api.github.com/repos/facebook/react/issues/21887/events | https://github.com/facebook/react/pull/21887 | 945,568,630 | MDExOlB1bGxSZXF1ZXN0NjkwODc5OTAw | 21,887 | Clean up flushSync flow types | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d5de45820ae6beda46c34f8737f1861c85642a65...c92143c84e2139529201d05757a57fa4f2b18fc5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-15 16:37:38 | 2021-07-16 14:38:00 | 2021-07-16 14:37:57 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21887', 'html_url': 'https://github.com/facebook/react/pull/21887', 'diff_url': 'https://github.com/facebook/react/pull/21887.diff', 'patch_url': 'https://github.com/facebook/react/pull/21887.patch', 'merged_at': datetime.datetime(2021, 7, 16, 14, 37, 57)} | ## Overview
Makes the callback function optional and cleans up the type to make it consistent and correct everywhere. | {'url': 'https://api.github.com/repos/facebook/react/issues/21887/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21887/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21886 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21886/labels{/name} | https://api.github.com/repos/facebook/react/issues/21886/comments | https://api.github.com/repos/facebook/react/issues/21886/events | https://github.com/facebook/react/pull/21886 | 945,509,329 | MDExOlB1bGxSZXF1ZXN0NjkwODI5Nzc3 | 21,886 | Cache local reference to global Promise | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d5de45820ae6beda46c34f8737f1861c85642a65...61b34e779efb8f580a70994cd0b3141ac5ac5537\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-15 15:30:58 | 2021-08-06 06:23:33 | 2021-07-15 16:39:57 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21886', 'html_url': 'https://github.com/facebook/react/pull/21886', 'diff_url': 'https://github.com/facebook/react/pull/21886.diff', 'patch_url': 'https://github.com/facebook/react/pull/21886.patch', 'merged_at': datetime.datetime(2021, 7, 15, 16, 39, 57)} | # Overview
This will help prevent a polyfill overriding it later. | {'url': 'https://api.github.com/repos/facebook/react/issues/21886/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21886/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21885 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21885/labels{/name} | https://api.github.com/repos/facebook/react/issues/21885/comments | https://api.github.com/repos/facebook/react/issues/21885/events | https://github.com/facebook/react/pull/21885 | 945,220,731 | MDExOlB1bGxSZXF1ZXN0NjkwNTgwNjQw | 21,885 | [DevTools] Disable sizeBot on DevTools Rull Request | {'login': 'ryota-murakami', 'id': 5501268, 'node_id': 'MDQ6VXNlcjU1MDEyNjg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5501268?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ryota-murakami', 'html_url': 'https://github.com/ryota-murakami', 'followers_url': 'https://api.github.com/users/ryot... | [{'id': 71502270, 'node_id': 'MDU6TGFiZWw3MTUwMjI3MA==', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Build%20Infrastructure', 'name': 'Component: Build Infrastructure', 'color': 'f9d0c4', 'default': False, 'description': None}
{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': ... | closed | false | null | [] | null | [
"@bvaughn I implemented logic to check wether Devtools package files only committed. \r\nHow is that?",
"Thank you for your review!"
] | 2021-07-15 10:10:26 | 2021-08-02 14:19:05 | 2021-08-02 13:51:54 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21885', 'html_url': 'https://github.com/facebook/react/pull/21885', 'diff_url': 'https://github.com/facebook/react/pull/21885.diff', 'patch_url': 'https://github.com/facebook/react/pull/21885.patch', 'merged_at': datetime.datetime(2021, 8, 2, 13, 51, 54)} | Because DevTools code doesn't affect production bundle size.
Meaningless sizeBot comment give us frastration within Pull Request discussion. | {'url': 'https://api.github.com/repos/facebook/react/issues/21885/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21885/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21884 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21884/labels{/name} | https://api.github.com/repos/facebook/react/issues/21884/comments | https://api.github.com/repos/facebook/react/issues/21884/events | https://github.com/facebook/react/issues/21884 | 944,965,297 | MDU6SXNzdWU5NDQ5NjUyOTc= | 21,884 | Bug: useState set the same value, trigger the render | {'login': 'ry596384086', 'id': 47969261, 'node_id': 'MDQ6VXNlcjQ3OTY5MjYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/47969261?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ry596384086', 'html_url': 'https://github.com/ry596384086', 'followers_url': 'https://api.github.com/users/ry596384086... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"hi dear. . this is not a bug , this is expected behavior of useState because when the value of useState is not change it will not create new memory pointer and will not rerender the component because nothing is changed. . when you click on Test button it will change the memory pointer of the object where useStat... | 2021-07-15 03:33:35 | 2024-04-10 13:04:01 | 2024-04-10 13:04:00 | NONE | null | null | null | <!-- Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not... | {'url': 'https://api.github.com/repos/facebook/react/issues/21884/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21884/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/21883 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21883/labels{/name} | https://api.github.com/repos/facebook/react/issues/21883/comments | https://api.github.com/repos/facebook/react/issues/21883/events | https://github.com/facebook/react/issues/21883 | 944,882,409 | MDU6SXNzdWU5NDQ4ODI0MDk= | 21,883 | START | {'login': 'Jurgen-i-m', 'id': 86752005, 'node_id': 'MDQ6VXNlcjg2NzUyMDA1', 'avatar_url': 'https://avatars.githubusercontent.com/u/86752005?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Jurgen-i-m', 'html_url': 'https://github.com/Jurgen-i-m', 'followers_url': 'https://api.github.com/users/Jurgen-i-m/fol... | [] | closed | false | null | [] | null | [] | 2021-07-15 00:03:57 | 2021-07-15 00:38:37 | 2021-07-15 00:38:37 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/21883/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21883/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21882 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21882/labels{/name} | https://api.github.com/repos/facebook/react/issues/21882/comments | https://api.github.com/repos/facebook/react/issues/21882/events | https://github.com/facebook/react/issues/21882 | 944,850,840 | MDU6SXNzdWU5NDQ4NTA4NDA= | 21,882 | view components tree | {'login': 'fbaura', 'id': 75816403, 'node_id': 'MDQ6VXNlcjc1ODE2NDAz', 'avatar_url': 'https://avatars.githubusercontent.com/u/75816403?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fbaura', 'html_url': 'https://github.com/fbaura', 'followers_url': 'https://api.github.com/users/fbaura/followers', 'follow... | [{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Needs%20More%20Information', 'name': 'Resolution: Needs More Information', 'color': 'fffde7', 'default': False, 'description': None}] | closed | false | {'login': 'fbaura', 'id': 75816403.0, 'node_id': 'MDQ6VXNlcjc1ODE2NDAz', 'avatar_url': 'https://avatars.githubusercontent.com/u/75816403?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fbaura', 'html_url': 'https://github.com/fbaura', 'followers_url': 'https://api.github.com/users/fbaura/followers', 'foll... | [{'login': 'fbaura', 'id': 75816403, 'node_id': 'MDQ6VXNlcjc1ODE2NDAz', 'avatar_url': 'https://avatars.githubusercontent.com/u/75816403?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fbaura', 'html_url': 'https://github.com/fbaura', 'followers_url': 'https://api.github.com/users/fbaura/followers', 'follo... | null | [
"@fbaura What's this issue about?",
"I'm going to close this issue because it doesn't have enough info for one of us to respond to it. We can re-open it later if you update it!"
] | 2021-07-14 22:46:04 | 2021-07-15 16:30:54 | 2021-07-15 16:30:46 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/21882/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21882/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21881 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21881/labels{/name} | https://api.github.com/repos/facebook/react/issues/21881/comments | https://api.github.com/repos/facebook/react/issues/21881/events | https://github.com/facebook/react/pull/21881 | 944,590,697 | MDExOlB1bGxSZXF1ZXN0NjkwMDQ5MDMy | 21,881 | Add comment support to `@gate` pragma | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 81346764bb62dc3fb04ccbf7f507cd390a249840...1d966bab55ec2637386e3553fcb614bc80ef4fea\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-14 16:14:41 | 2021-07-14 17:36:24 | 2021-07-14 17:36:24 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21881', 'html_url': 'https://github.com/facebook/react/pull/21881', 'diff_url': 'https://github.com/facebook/react/pull/21881.diff', 'patch_url': 'https://github.com/facebook/react/pull/21881.patch', 'merged_at': datetime.datetime(2021, 7, 14, 17, 36, 24)} | So you can more easily comment on why a test is gated. | {'url': 'https://api.github.com/repos/facebook/react/issues/21881/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21881/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21880 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21880/labels{/name} | https://api.github.com/repos/facebook/react/issues/21880/comments | https://api.github.com/repos/facebook/react/issues/21880/events | https://github.com/facebook/react/pull/21880 | 944,524,844 | MDExOlB1bGxSZXF1ZXN0Njg5OTk1NTA4 | 21,880 | Run persistent tests in more configurations in CI | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9090257e6edec44a09a4cd5723d1d0f7ce2ab7c4...238d97719988679e3f1beacd920d5603f98b404b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-14 15:06:25 | 2021-07-14 15:40:20 | 2021-07-14 15:40:20 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21880', 'html_url': 'https://github.com/facebook/react/pull/21880', 'diff_url': 'https://github.com/facebook/react/pull/21880.diff', 'patch_url': 'https://github.com/facebook/react/pull/21880.patch', 'merged_at': datetime.datetime(2021, 7, 14, 15, 40, 20)} | I noticed that `enableSuspenseLayoutEffectSemantics` is not fully implemented in persistent mode. I believe this was an oversight because we don't have a CI job that runs tests in persistent mode and with experimental flags enabled.
This adds additional test configurations to the CI job so we don't miss stuff like t... | {'url': 'https://api.github.com/repos/facebook/react/issues/21880/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21880/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21879 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21879/labels{/name} | https://api.github.com/repos/facebook/react/issues/21879/comments | https://api.github.com/repos/facebook/react/issues/21879/events | https://github.com/facebook/react/pull/21879 | 944,483,807 | MDExOlB1bGxSZXF1ZXN0Njg5OTYxMTM2 | 21,879 | devtools: Add `ref` to inspect element view | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/reac... | open | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"I think I dig this change overall. I'm going to poke at the UI a little. May have a nit or two.",
"> The UI feels a bit lost since we only have a single value in this new section. Ideally we'd have the `key` in the view too so we could create a \"Misc\" view. \r\n\r\nThe `key` is shown as part of the name up top... | 2021-07-14 14:23:54 | 2022-07-03 08:49:18 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21879', 'html_url': 'https://github.com/facebook/react/pull/21879', 'diff_url': 'https://github.com/facebook/react/pull/21879.diff', 'patch_url': 'https://github.com/facebook/react/pull/21879.patch', 'merged_at': None} | ## Summary
Displays the `ref` of an inspected element if the element has one. Was a bit difficult to track a particular ref through a somewhat larger component tree.
Ref to a class instance
... | {'url': 'https://api.github.com/repos/facebook/react/issues/21879/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21879/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21878 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21878/labels{/name} | https://api.github.com/repos/facebook/react/issues/21878/comments | https://api.github.com/repos/facebook/react/issues/21878/events | https://github.com/facebook/react/issues/21878 | 944,429,776 | MDU6SXNzdWU5NDQ0Mjk3NzY= | 21,878 | [Proposal] Add extra props argument when calling getChildHostContext | {'login': 'pirelenito', 'id': 6001, 'node_id': 'MDQ6VXNlcjYwMDE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6001?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pirelenito', 'html_url': 'https://github.com/pirelenito', 'followers_url': 'https://api.github.com/users/pirelenito/followers', 'fo... | [] | closed | false | null | [] | null | [
"Hi! We've found an alternative solution that no longer requires this API change.",
"@pirelenito purely out of curiosity, what was the alternate solution? Might be worth documenting in case anyone else runs into a similar situation."
] | 2021-07-14 13:27:50 | 2021-09-27 22:47:39 | 2021-09-26 19:28:43 | NONE | null | null | null | Hi 👋
We are building a custom React renderer using the `react-reconciler` package and we ran in a situation where we would need to have access to the props of a instance in the call to `getChildHostContext`.
In short, here is the pseudo-code of what we need:
```tsx
const hostConfig = {
/**
* Our root... | {'url': 'https://api.github.com/repos/facebook/react/issues/21878/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21878/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21877 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21877/labels{/name} | https://api.github.com/repos/facebook/react/issues/21877/comments | https://api.github.com/repos/facebook/react/issues/21877/events | https://github.com/facebook/react/issues/21877 | 944,372,203 | MDU6SXNzdWU5NDQzNzIyMDM= | 21,877 | Bug: Error should have queue. this is likely a bug in react. | {'login': 'Annu2013', 'id': 40827668, 'node_id': 'MDQ6VXNlcjQwODI3NjY4', 'avatar_url': 'https://avatars.githubusercontent.com/u/40827668?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Annu2013', 'html_url': 'https://github.com/Annu2013', 'followers_url': 'https://api.github.com/users/Annu2013/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'Annu2013', 'id': 40827668.0, 'node_id': 'MDQ6VXNlcjQwODI3NjY4', 'avatar_url': 'https://avatars.githubusercontent.com/u/40827668?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Annu2013', 'html_url': 'https://github.com/Annu2013', 'followers_url': 'https://api.github.com/users/Annu2013/followers... | [{'login': 'Annu2013', 'id': 40827668, 'node_id': 'MDQ6VXNlcjQwODI3NjY4', 'avatar_url': 'https://avatars.githubusercontent.com/u/40827668?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Annu2013', 'html_url': 'https://github.com/Annu2013', 'followers_url': 'https://api.github.com/users/Annu2013/followers'... | null | [
"Hi!\r\n\r\nI'm sorry you ran into this problem 😦 \r\n\r\nUnfortunately, it doesn't look like this issue has enough info for one of us to reproduce it though. This means that **it's going to be very hard for us to fix**.\r\n\r\nPlease help us by providing a link to a CodeSandbox (https://codesandbox.io/s/new), a r... | 2021-07-14 12:21:06 | 2021-07-19 14:16:30 | 2021-07-19 14:16:30 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
![image](https://user-images.githubusercontent.com/40827668/125621023-d8117c6b-47f... | {'url': 'https://api.github.com/repos/facebook/react/issues/21877/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21877/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21876 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21876/labels{/name} | https://api.github.com/repos/facebook/react/issues/21876/comments | https://api.github.com/repos/facebook/react/issues/21876/events | https://github.com/facebook/react/issues/21876 | 944,352,954 | MDU6SXNzdWU5NDQzNTI5NTQ= | 21,876 | [React 18] Bug: `Maximum update depth exceeded` on the `ref` prop when suspending | {'login': 'enisdenjo', 'id': 11807600, 'node_id': 'MDQ6VXNlcjExODA3NjAw', 'avatar_url': 'https://avatars.githubusercontent.com/u/11807600?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/enisdenjo', 'html_url': 'https://github.com/enisdenjo', 'followers_url': 'https://api.github.com/users/enisdenjo/followe... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"I wonder if https://github.com/facebook/react/pull/21875 fixes this. ",
"Yeah it does.\r\nhttps://codesandbox.io/s/ref-set-too-many-times-forked-jl54z?file=/package.json"
] | 2021-07-14 11:58:30 | 2021-07-14 17:37:11 | 2021-07-14 17:37:11 | NONE | null | null | null | Functional `ref` prop throws a `Maximum update depth exceeded` error when suspending.
React version: `18.0.0-alpha-464f27572-20210713`
## Steps To Reproduce
1. Click on the `suspend` button: https://codesandbox.io/s/ref-set-too-many-times-jm0c3?file=/src/App.js.
## The current behavior
Clicking on the `s... | {'url': 'https://api.github.com/repos/facebook/react/issues/21876/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21876/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21875 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21875/labels{/name} | https://api.github.com/repos/facebook/react/issues/21875/comments | https://api.github.com/repos/facebook/react/issues/21875/events | https://github.com/facebook/react/pull/21875 | 943,972,096 | MDExOlB1bGxSZXF1ZXN0Njg5NTI0NjE3 | 21,875 | [Bugfix] Don't hide/unhide unless visibility changes | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Does it fix https://github.com/facebook/react/pull/21853#issuecomment-878500750 too?",
"@gaearon yes",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 81346764bb62dc3fb04ccbf7f507cd390a249840...ca72f59db27225025778f49bd92372bc1be897a0\n\n#... | 2021-07-14 02:21:03 | 2021-07-14 17:37:11 | 2021-07-14 17:37:11 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21875', 'html_url': 'https://github.com/facebook/react/pull/21875', 'diff_url': 'https://github.com/facebook/react/pull/21875.diff', 'patch_url': 'https://github.com/facebook/react/pull/21875.patch', 'merged_at': datetime.datetime(2021, 7, 14, 17, 37, 10)} | Instead of the Update flag, which is also used for other side-effects, like refs.
I originally added the Visibility flag for this purpose in #20043 but it got reverted last winter when we were bisecting the effects refactor.
Fixes #21853
Fixes #21876 | {'url': 'https://api.github.com/repos/facebook/react/issues/21875/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21875/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21874 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21874/labels{/name} | https://api.github.com/repos/facebook/react/issues/21874/comments | https://api.github.com/repos/facebook/react/issues/21874/events | https://github.com/facebook/react/pull/21874 | 943,893,275 | MDExOlB1bGxSZXF1ZXN0Njg5NDU4MjIy | 21,874 | DevTools: Named hooks supports "cheap-module-source-map" | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a97b5ac078499e33bbcf937935ab7139a317bac4...e82964a7c91f27f0eed23ea3d03047e16e0a0ae5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-13 23:09:17 | 2021-07-14 18:37:29 | 2021-07-14 18:37:28 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21874', 'html_url': 'https://github.com/facebook/react/pull/21874', 'diff_url': 'https://github.com/facebook/react/pull/21874.diff', 'patch_url': 'https://github.com/facebook/react/pull/21874.patch', 'merged_at': datetime.datetime(2021, 7, 14, 18, 37, 27)} | "cheap-module-source-map" is the default source-map generation mode used in created-react-dev mode because of speed. The major trade-off is that the source maps generated don't contain column numbers, so DevTools needs to be more lenient when matching AST nodes in this mode.
In this case, it can ignore column number... | {'url': 'https://api.github.com/repos/facebook/react/issues/21874/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21874/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21871 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21871/labels{/name} | https://api.github.com/repos/facebook/react/issues/21871/comments | https://api.github.com/repos/facebook/react/issues/21871/events | https://github.com/facebook/react/pull/21871 | 943,802,119 | MDExOlB1bGxSZXF1ZXN0Njg5Mzc5NjYz | 21,871 | DevTools: Ignore multiple sourceMappingUrls for external source maps | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 14bac6193a334eda42e727336e8967419f08f5df...9fc994c12511e95497affca9b4c0636debb0c38d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-13 20:28:48 | 2021-07-13 20:39:30 | 2021-07-13 20:39:29 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21871', 'html_url': 'https://github.com/facebook/react/pull/21871', 'diff_url': 'https://github.com/facebook/react/pull/21871.diff', 'patch_url': 'https://github.com/facebook/react/pull/21871.patch', 'merged_at': datetime.datetime(2021, 7, 13, 20, 39, 29)} | Added an edge case regression test and bugfix.
Resolves #21870 | {'url': 'https://api.github.com/repos/facebook/react/issues/21871/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21871/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21870 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21870/labels{/name} | https://api.github.com/repos/facebook/react/issues/21870/comments | https://api.github.com/repos/facebook/react/issues/21870/events | https://github.com/facebook/react/issues/21870 | 943,775,759 | MDU6SXNzdWU5NDM3NzU3NTk= | 21,870 | [DevTools] Handle sources that contain the string "sourceMappingURL=" | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [] | 2021-07-13 19:52:12 | 2021-07-13 20:39:29 | 2021-07-13 20:39:29 | CONTRIBUTOR | null | null | null | It's possible that a source file may contain the string "sourceMappingURL=" _in the source_ (not part of the source map). For example, if we were to parse the source code for `parseHookNames`, the regex `/ ?sourceMappingURL=([^\s'"]+)/gm` would match itself.
We should have some logic in place for filtering out inval... | {'url': 'https://api.github.com/repos/facebook/react/issues/21870/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21870/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21869 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21869/labels{/name} | https://api.github.com/repos/facebook/react/issues/21869/comments | https://api.github.com/repos/facebook/react/issues/21869/events | https://github.com/facebook/react/pull/21869 | 943,740,710 | MDExOlB1bGxSZXF1ZXN0Njg5MzI2NTUx | 21,869 | Allow components to render undefined | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bfa50f827241300d6674eeb99b9efab1ac9a5c40...8e9173d008a67835c0ead2a00d4029247f31e1a3\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-13 19:01:39 | 2021-07-24 16:55:50 | 2021-07-13 19:48:11 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21869', 'html_url': 'https://github.com/facebook/react/pull/21869', 'diff_url': 'https://github.com/facebook/react/pull/21869.diff', 'patch_url': 'https://github.com/facebook/react/pull/21869.patch', 'merged_at': datetime.datetime(2021, 7, 13, 19, 48, 11)} | Can be checked by a lint rule instead. | {'url': 'https://api.github.com/repos/facebook/react/issues/21869/reactions', 'total_count': 64, '+1': 15, '-1': 1, 'laugh': 0, 'hooray': 19, 'confused': 0, 'heart': 9, 'rocket': 8, 'eyes': 12} | https://api.github.com/repos/facebook/react/issues/21869/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21868 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21868/labels{/name} | https://api.github.com/repos/facebook/react/issues/21868/comments | https://api.github.com/repos/facebook/react/issues/21868/events | https://github.com/facebook/react/issues/21868 | 943,673,001 | MDU6SXNzdWU5NDM2NzMwMDE= | 21,868 | [DevTools] Named hooks compatibility for create-react-app DEV mode | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Digging into this further and one thing I notice that seems unexpected is that the `fileName` from the parsed stack for a CRA app is something like `\"static/js/main.chunk.js\"` where as the 'source-map' \"source\" is e.g. `\"App.js\"`.\r\n\r\nI can create a test app (using CRA) that has a file `error.js`:\r\n```j... | 2021-07-13 17:38:20 | 2021-07-14 18:37:28 | 2021-07-14 18:37:28 | CONTRIBUTOR | null | null | null | Something about the source maps config causes problems for a simple create-react-app running in DEV mode. Column numbers are always reported as 0 (by 'source-maps') which causes the AST node matching to fail so hook names can't be located. We should really fix this, since a lot of people use create-react-app for protot... | {'url': 'https://api.github.com/repos/facebook/react/issues/21868/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21868/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21867 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21867/labels{/name} | https://api.github.com/repos/facebook/react/issues/21867/comments | https://api.github.com/repos/facebook/react/issues/21867/events | https://github.com/facebook/react/pull/21867 | 943,667,294 | MDExOlB1bGxSZXF1ZXN0Njg5MjY1NzM0 | 21,867 | Enable scheduling profiler flag for react-dom profiling builds | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 64bbd7a7f1b7874ffcbfc69fa87be4f606e5adc5...137e92625bb6f2ec93825795569f8094d61f522a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-13 17:31:47 | 2021-07-13 17:41:20 | 2021-07-13 17:41:19 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21867', 'html_url': 'https://github.com/facebook/react/pull/21867', 'diff_url': 'https://github.com/facebook/react/pull/21867.diff', 'patch_url': 'https://github.com/facebook/react/pull/21867.patch', 'merged_at': datetime.datetime(2021, 7, 13, 17, 41, 19)} | Relates to #21866 | {'url': 'https://api.github.com/repos/facebook/react/issues/21867/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21867/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21866 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21866/labels{/name} | https://api.github.com/repos/facebook/react/issues/21866/comments | https://api.github.com/repos/facebook/react/issues/21866/events | https://github.com/facebook/react/issues/21866 | 943,661,993 | MDU6SXNzdWU5NDM2NjE5OTM= | 21,866 | [DevTools] Scheduling Profiler umbrella task | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https:/... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Note some prerequisite was done in #19892",
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional informati... | 2021-07-13 17:25:27 | 2024-04-10 14:03:18 | 2024-04-10 14:03:18 | CONTRIBUTOR | null | null | null | The [Scheduling Profiler](https://github.com/facebook/react/tree/main/packages/react-devtools-scheduling-profiler) is currently only accessible at [react-scheduling-profiler.vercel.app](https://react-scheduling-profiler.vercel.app/) and very few people know about it. Furthermore, the User Timing API marks that power th... | {'url': 'https://api.github.com/repos/facebook/react/issues/21866/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21866/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/21865 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21865/labels{/name} | https://api.github.com/repos/facebook/react/issues/21865/comments | https://api.github.com/repos/facebook/react/issues/21865/events | https://github.com/facebook/react/pull/21865 | 943,637,349 | MDExOlB1bGxSZXF1ZXN0Njg5MjM5OTI1 | 21,865 | Adjust Error stack columns numbers by 1 | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4ecd85e8628d1fdfe77c5615934de40af7d9537...7a6f71cc767979509333982ad2afce9016e3018d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-13 16:57:27 | 2021-07-13 17:28:03 | 2021-07-13 17:28:01 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21865', 'html_url': 'https://github.com/facebook/react/pull/21865', 'diff_url': 'https://github.com/facebook/react/pull/21865.diff', 'patch_url': 'https://github.com/facebook/react/pull/21865.patch', 'merged_at': datetime.datetime(2021, 7, 13, 17, 28, 1)} | Follow up for https://github.com/facebook/react/pull/21833#discussion_r666831276. Resolves #21792.
This change accounts for differences between error stacks (1-based) and ASTs (0-based). In practice this change should not make an observable difference.
In practice, the change should never matter, because we are m... | {'url': 'https://api.github.com/repos/facebook/react/issues/21865/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21865/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21864 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21864/labels{/name} | https://api.github.com/repos/facebook/react/issues/21864/comments | https://api.github.com/repos/facebook/react/issues/21864/events | https://github.com/facebook/react/pull/21864 | 943,455,935 | MDExOlB1bGxSZXF1ZXN0Njg5MDgzNjI4 | 21,864 | Fix DevTools console announcement being suppressed by Fast Refresh | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4ecd85e8628d1fdfe77c5615934de40af7d9537...71ae3e68c65b8a9b8c6d79632af5ba744bab7073\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-13 14:18:11 | 2021-07-13 14:41:51 | 2021-07-13 14:41:51 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21864', 'html_url': 'https://github.com/facebook/react/pull/21864', 'diff_url': 'https://github.com/facebook/react/pull/21864.diff', 'patch_url': 'https://github.com/facebook/react/pull/21864.patch', 'merged_at': datetime.datetime(2021, 7, 13, 14, 41, 51)} | We show a console message in DEV for supported browsers that encourages you to install React DevTools. This isn't new: we've been showing this message for many years.
However, we've accidentally regressed because both DevTools and Fast Refresh Runtime install a global hook. So if you don't have the browser extension... | {'url': 'https://api.github.com/repos/facebook/react/issues/21864/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21864/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21863 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21863/labels{/name} | https://api.github.com/repos/facebook/react/issues/21863/comments | https://api.github.com/repos/facebook/react/issues/21863/events | https://github.com/facebook/react/pull/21863 | 943,416,450 | MDExOlB1bGxSZXF1ZXN0Njg5MDQ3ODk4 | 21,863 | Fix link to fbjs | {'login': 'e-hosseini', 'id': 53467610, 'node_id': 'MDQ6VXNlcjUzNDY3NjEw', 'avatar_url': 'https://avatars.githubusercontent.com/u/53467610?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/e-hosseini', 'html_url': 'https://github.com/e-hosseini', 'followers_url': 'https://api.github.com/users/e-hosseini/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4ecd85e8628d1fdfe77c5615934de40af7d9537...235509eb8a4e9955b309b309462d457e156bcdc7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-13 13:52:37 | 2021-07-13 14:55:33 | 2021-07-13 14:55:33 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21863', 'html_url': 'https://github.com/facebook/react/pull/21863', 'diff_url': 'https://github.com/facebook/react/pull/21863.diff', 'patch_url': 'https://github.com/facebook/react/pull/21863.patch', 'merged_at': datetime.datetime(2021, 7, 13, 14, 55, 33)} |
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. For... | {'url': 'https://api.github.com/repos/facebook/react/issues/21863/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21863/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21862 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21862/labels{/name} | https://api.github.com/repos/facebook/react/issues/21862/comments | https://api.github.com/repos/facebook/react/issues/21862/events | https://github.com/facebook/react/pull/21862 | 943,342,581 | MDExOlB1bGxSZXF1ZXN0Njg4OTgxMDEz | 21,862 | Update link to flow | {'login': 'e-hosseini', 'id': 53467610, 'node_id': 'MDQ6VXNlcjUzNDY3NjEw', 'avatar_url': 'https://avatars.githubusercontent.com/u/53467610?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/e-hosseini', 'html_url': 'https://github.com/e-hosseini', 'followers_url': 'https://api.github.com/users/e-hosseini/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4ecd85e8628d1fdfe77c5615934de40af7d9537...676d6a96414e5fb2aa0cb289641352b219c7173f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-13 13:02:41 | 2021-07-13 14:55:55 | 2021-07-13 14:55:55 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21862', 'html_url': 'https://github.com/facebook/react/pull/21862', 'diff_url': 'https://github.com/facebook/react/pull/21862.diff', 'patch_url': 'https://github.com/facebook/react/pull/21862.patch', 'merged_at': datetime.datetime(2021, 7, 13, 14, 55, 54)} |
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. For... | {'url': 'https://api.github.com/repos/facebook/react/issues/21862/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21862/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21861 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21861/labels{/name} | https://api.github.com/repos/facebook/react/issues/21861/comments | https://api.github.com/repos/facebook/react/issues/21861/events | https://github.com/facebook/react/pull/21861 | 943,330,792 | MDExOlB1bGxSZXF1ZXN0Njg4OTcwNTQw | 21,861 | Update link to flow | {'login': 'e-hosseini', 'id': 53467610, 'node_id': 'MDQ6VXNlcjUzNDY3NjEw', 'avatar_url': 'https://avatars.githubusercontent.com/u/53467610?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/e-hosseini', 'html_url': 'https://github.com/e-hosseini', 'followers_url': 'https://api.github.com/users/e-hosseini/fol... | [] | closed | false | null | [] | null | [
"Hi @dh-hosseini! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order f... | 2021-07-13 12:54:02 | 2021-07-13 13:01:03 | 2021-07-13 13:01:03 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21861', 'html_url': 'https://github.com/facebook/react/pull/21861', 'diff_url': 'https://github.com/facebook/react/pull/21861.diff', 'patch_url': 'https://github.com/facebook/react/pull/21861.patch', 'merged_at': None} | `main` branch does not exist in the `flow` project and it is `master`.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submit... | {'url': 'https://api.github.com/repos/facebook/react/issues/21861/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21861/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21858 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21858/labels{/name} | https://api.github.com/repos/facebook/react/issues/21858/comments | https://api.github.com/repos/facebook/react/issues/21858/events | https://github.com/facebook/react/issues/21858 | 942,807,060 | MDU6SXNzdWU5NDI4MDcwNjA= | 21,858 | Bug: (hooks, ts) useEffect return type | {'login': 'y-nk', 'id': 411625, 'node_id': 'MDQ6VXNlcjQxMTYyNQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/411625?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/y-nk', 'html_url': 'https://github.com/y-nk', 'followers_url': 'https://api.github.com/users/y-nk/followers', 'following_url': 'h... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1168115654, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Thanks for the feedback.\r\n\r\nThe types aren't hosted in this repo. For TypeScript you want to file this against https://github.com/DefinitelyTyped/DefinitelyTyped/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc.\r\n\r\nThough I don't think we do want to relax the types since I suspect that most returns would ... | 2021-07-13 06:06:27 | 2021-07-13 06:37:18 | 2021-07-13 06:37:18 | NONE | null | null | null | React version: 17
## Steps To Reproduce
```
useEffect(
() => !bool && funcThatReturnDestroyerFunc(dep),
[dep],
)
```
## The current behavior
Breaks because type returned by the create function must be of `void | () => void`
## The expected behavior
We should relax and allow `type Destroyer =... | {'url': 'https://api.github.com/repos/facebook/react/issues/21858/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21858/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21857 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21857/labels{/name} | https://api.github.com/repos/facebook/react/issues/21857/comments | https://api.github.com/repos/facebook/react/issues/21857/events | https://github.com/facebook/react/pull/21857 | 942,489,397 | MDExOlB1bGxSZXF1ZXN0Njg4MjEyNzc5 | 21,857 | Update test comments with explanations | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 87b67d319fed725fafe06fb1bfd1b4a672e5a629...02656e80964381684c01f72fc5c97c4982238094\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-12 22:07:27 | 2021-07-19 19:07:41 | 2021-07-19 19:07:38 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21857', 'html_url': 'https://github.com/facebook/react/pull/21857', 'diff_url': 'https://github.com/facebook/react/pull/21857.diff', 'patch_url': 'https://github.com/facebook/react/pull/21857.patch', 'merged_at': datetime.datetime(2021, 7, 19, 19, 7, 38)} | I understand this well enough to explain these now. | {'url': 'https://api.github.com/repos/facebook/react/issues/21857/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21857/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21856 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21856/labels{/name} | https://api.github.com/repos/facebook/react/issues/21856/comments | https://api.github.com/repos/facebook/react/issues/21856/events | https://github.com/facebook/react/issues/21856 | 942,448,417 | MDU6SXNzdWU5NDI0NDg0MTc= | 21,856 | [DevTools] Show which hooks (names) changed in the Profiler | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https:/... | open | false | null | [] | null | [
"You're welcome to take a pass at this, @Fahme.\r\n\r\nIt's a pretty large task and it would need to be self-guided (minimal support from me), but if you're interested- that's awesome.",
"> You're welcome to take a pass at this, @Fahme.\r\n> \r\n> It's a pretty large task and it would need to be self-guided (mini... | 2021-07-12 21:06:23 | 2024-02-26 16:35:28 | null | CONTRIBUTOR | null | null | null | Hooks are the preferred way for writing stateful React components, but there are a few things about them that still lag behind the class component API: profiling (since DevTools just shows “hooks changed” rather than which ones changed).
Building on top of the initial named hooks release _and_ the experimental `enab... | {'url': 'https://api.github.com/repos/facebook/react/issues/21856/reactions', 'total_count': 58, '+1': 45, '-1': 0, 'laugh': 0, 'hooray': 13, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21856/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/21855 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21855/labels{/name} | https://api.github.com/repos/facebook/react/issues/21855/comments | https://api.github.com/repos/facebook/react/issues/21855/events | https://github.com/facebook/react/issues/21855 | 942,446,430 | MDU6SXNzdWU5NDI0NDY0MzA= | 21,855 | [DevTools] Parse named source AST in a worker | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2021-07-12 21:04:01 | 2021-07-21 16:16:08 | 2021-07-21 16:16:08 | CONTRIBUTOR | null | null | null | Hooks are the preferred way for writing stateful React components, but there are a few things about them that still lag behind the class component API: inspecting state in DevTools (since hooks aren’t “named”). Even now that this feature has been released, it remains disabled by default because the size of DEV bundles ... | {'url': 'https://api.github.com/repos/facebook/react/issues/21855/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21855/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21854 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21854/labels{/name} | https://api.github.com/repos/facebook/react/issues/21854/comments | https://api.github.com/repos/facebook/react/issues/21854/events | https://github.com/facebook/react/pull/21854 | 942,330,948 | MDExOlB1bGxSZXF1ZXN0Njg4MDc0NDg1 | 21,854 | Capture suspense boundaries with undefined fallbacks | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bfa50f827241300d6674eeb99b9efab1ac9a5c40...dc591cff99dcadd6bdf54a96ef10ebaecabcb0b5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-12 18:28:23 | 2021-07-12 18:50:37 | 2021-07-12 18:50:34 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21854', 'html_url': 'https://github.com/facebook/react/pull/21854', 'diff_url': 'https://github.com/facebook/react/pull/21854.diff', 'patch_url': 'https://github.com/facebook/react/pull/21854.patch', 'merged_at': datetime.datetime(2021, 7, 12, 18, 50, 33)} | Land this to main instead of master | {'url': 'https://api.github.com/repos/facebook/react/issues/21854/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21854/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21853 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21853/labels{/name} | https://api.github.com/repos/facebook/react/issues/21853/comments | https://api.github.com/repos/facebook/react/issues/21853/events | https://github.com/facebook/react/pull/21853 | 942,204,204 | MDExOlB1bGxSZXF1ZXN0Njg3OTY1MDQy | 21,853 | Suspense layout effects: Failing test case | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | {'login': 'acdlite', 'id': 3624098.0, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'fo... | [{'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'fol... | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bfa50f827241300d6674eeb99b9efab1ac9a5c40...6dd99458627a99873fb1bf06b45192ef4b1deec2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-12 15:54:36 | 2021-07-14 17:37:10 | 2021-07-14 17:37:10 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21853', 'html_url': 'https://github.com/facebook/react/pull/21853', 'diff_url': 'https://github.com/facebook/react/pull/21853.diff', 'patch_url': 'https://github.com/facebook/react/pull/21853.patch', 'merged_at': None} | The key components to this are:
1. State updater function as a `ref` setter.
2. Render-phase update, e.g. mirrored props-to-state ([not a generally recommended patter](https://reactjs.org/blog/2018/06/07/you-probably-dont-need-derived-state.html#anti-pattern-unconditionally-copying-props-to-state)).
3. Suspend in an... | {'url': 'https://api.github.com/repos/facebook/react/issues/21853/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21853/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21852 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21852/labels{/name} | https://api.github.com/repos/facebook/react/issues/21852/comments | https://api.github.com/repos/facebook/react/issues/21852/events | https://github.com/facebook/react/pull/21852 | 942,174,751 | MDExOlB1bGxSZXF1ZXN0Njg3OTQwMTUz | 21,852 | Tidy up early bailout logic at start of begin phase | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 419cc9c3799bc296c3c2a2c93880826aca680886...d8d34b8ad9e1958d92634e54b4c93443f7c90762\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-12 15:20:06 | 2021-07-29 13:59:59 | 2021-07-29 13:59:59 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21852', 'html_url': 'https://github.com/facebook/react/pull/21852', 'diff_url': 'https://github.com/facebook/react/pull/21852.diff', 'patch_url': 'https://github.com/facebook/react/pull/21852.patch', 'merged_at': datetime.datetime(2021, 7, 29, 13, 59, 59)} | An early bailout is when there are no scheduled changes to props, state, or context, so we bail out at the start of the begin phase without running the component body.
The logic in this path is getting hard to follow, so I refactored it a bit. There shouldn't be any behavioral change.
I suggest reviewing each com... | {'url': 'https://api.github.com/repos/facebook/react/issues/21852/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/21852/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21851 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21851/labels{/name} | https://api.github.com/repos/facebook/react/issues/21851/comments | https://api.github.com/repos/facebook/react/issues/21851/events | https://github.com/facebook/react/issues/21851 | 942,135,140 | MDU6SXNzdWU5NDIxMzUxNDA= | 21,851 | Bug: event Handler on React Component not invoked when React Component is rendered inside a Web Component | {'login': 'AChaoZJU', 'id': 17509647, 'node_id': 'MDQ6VXNlcjE3NTA5NjQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/17509647?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AChaoZJU', 'html_url': 'https://github.com/AChaoZJU', 'followers_url': 'https://api.github.com/users/AChaoZJU/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hi,\r\n\r\nI did some call stack trace while the `onClick` event was triggered, it was first captured by the G6 library and handled in a handler defined for the menu plugin.\r\n\r\nTo elaborate this, I here paste the code I found while doing the trace.\r\n```\r\n Menu.prototype.onMenuShow = function (e) {\r\n ... | 2021-07-12 14:40:13 | 2021-09-02 10:11:10 | 2021-09-02 10:11:09 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.2
## Steps To Reproduce
I wrap the react component with ... | {'url': 'https://api.github.com/repos/facebook/react/issues/21851/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21851/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21850 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21850/labels{/name} | https://api.github.com/repos/facebook/react/issues/21850/comments | https://api.github.com/repos/facebook/react/issues/21850/events | https://github.com/facebook/react/issues/21850 | 942,094,283 | MDU6SXNzdWU5NDIwOTQyODM= | 21,850 | React 18 : useState 'sharing' state value between components of the same type | {'login': 'DiegoHerrera262', 'id': 59120315, 'node_id': 'MDQ6VXNlcjU5MTIwMzE1', 'avatar_url': 'https://avatars.githubusercontent.com/u/59120315?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/DiegoHerrera262', 'html_url': 'https://github.com/DiegoHerrera262', 'followers_url': 'https://api.github.com/users... | [{'id': 40929155, 'node_id': 'MDU6TGFiZWw0MDkyOTE1NQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Question', 'name': 'Type: Question', 'color': 'cc317c', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Unless I'm misreading, you just need to add a `key` to your tables so that React knows they are _different_. (Otherwise React has no way of knowing you want them to be different \"instances\")\r\n\r\nThis pattern is kind of mentioned in a blog post:\r\nhttps://reactjs.org/blog/2018/06/07/you-probably-dont-need-der... | 2021-07-12 13:59:15 | 2021-07-12 14:22:06 | 2021-07-12 14:22:06 | NONE | null | null | null | <!--
Ask a question or share feedback about the React 18 release here.
-->
I created a custom table component that has pagination, search bar and export to excel button. The main usage of the component is as follows:
```jsx
<ClientsTable
dataset={sellsInfo}
Headers={sellsInfoHeaders}
downloadFile... | {'url': 'https://api.github.com/repos/facebook/react/issues/21850/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21850/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21849 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21849/labels{/name} | https://api.github.com/repos/facebook/react/issues/21849/comments | https://api.github.com/repos/facebook/react/issues/21849/events | https://github.com/facebook/react/issues/21849 | 941,984,087 | MDU6SXNzdWU5NDE5ODQwODc= | 21,849 | Should have a queue. This is likely a bug in React. Please file an issue.Bug: | {'login': 'aanarkulov', 'id': 35723065, 'node_id': 'MDQ6VXNlcjM1NzIzMDY1', 'avatar_url': 'https://avatars.githubusercontent.com/u/35723065?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aanarkulov', 'html_url': 'https://github.com/aanarkulov', 'followers_url': 'https://api.github.com/users/aanarkulov/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'aanarkulov', 'id': 35723065.0, 'node_id': 'MDQ6VXNlcjM1NzIzMDY1', 'avatar_url': 'https://avatars.githubusercontent.com/u/35723065?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aanarkulov', 'html_url': 'https://github.com/aanarkulov', 'followers_url': 'https://api.github.com/users/aanarkulov/f... | [{'login': 'aanarkulov', 'id': 35723065, 'node_id': 'MDQ6VXNlcjM1NzIzMDY1', 'avatar_url': 'https://avatars.githubusercontent.com/u/35723065?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aanarkulov', 'html_url': 'https://github.com/aanarkulov', 'followers_url': 'https://api.github.com/users/aanarkulov/fo... | null | [
"Hi @aanarkulov\r\n\r\nI'm sorry you ran into this problem 😦 \r\n\r\nUnfortunately, it doesn't look like this issue has enough info for one of us to reproduce it though. This means that **it's going to be very hard for us to fix**.\r\n\r\nPlease help us by providing a link to a CodeSandbox (https://codesandbox.io/... | 2021-07-12 11:57:43 | 2021-07-14 22:54:33 | 2021-07-14 22:54:33 | NONE | null | null | null | https://sentry.io/share/issue/9b4a3b588cd34fcea5f2d461516afd2b/ | {'url': 'https://api.github.com/repos/facebook/react/issues/21849/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21849/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21848 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21848/labels{/name} | https://api.github.com/repos/facebook/react/issues/21848/comments | https://api.github.com/repos/facebook/react/issues/21848/events | https://github.com/facebook/react/issues/21848 | 941,753,264 | MDU6SXNzdWU5NDE3NTMyNjQ= | 21,848 | React 18: having Invalid hook call problem with rendering app wrapped by React.StrictMode | {'login': 'julia-dizhak', 'id': 1140769, 'node_id': 'MDQ6VXNlcjExNDA3Njk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1140769?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/julia-dizhak', 'html_url': 'https://github.com/julia-dizhak', 'followers_url': 'https://api.github.com/users/julia-dizh... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Thanks for the feedback.\r\n\r\nI suspect that your package manager installed both React 18 and 17. Multiple React versions is one of the reasons for the \"invalid hook call\" error message.\r\n\r\nThis might be due to dependencies requiring React 17 via peer dependencies.\r\n\r\nWhat package manager are you using... | 2021-07-12 07:22:36 | 2021-07-12 16:27:56 | 2021-07-12 16:27:56 | NONE | null | null | null | I have a problem with rendering app after migrating to 18 version
```
const root = ReactDOM.createRoot(document.getElementById('root'));
const AppTest = () => <div>test react alpha 18</div>;
root.render(<React.StrictMode><App /></React.StrictMode>)
```
`
I have Invalid hook call warning in console
`
node i... | {'url': 'https://api.github.com/repos/facebook/react/issues/21848/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21848/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21847 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21847/labels{/name} | https://api.github.com/repos/facebook/react/issues/21847/comments | https://api.github.com/repos/facebook/react/issues/21847/events | https://github.com/facebook/react/issues/21847 | 941,545,121 | MDU6SXNzdWU5NDE1NDUxMjE= | 21,847 | Bug: video and audio elements invoking wasteful dispatches when there are no related handlers declared | {'login': 'ArmorDarks', 'id': 4460311, 'node_id': 'MDQ6VXNlcjQ0NjAzMTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4460311?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ArmorDarks', 'html_url': 'https://github.com/ArmorDarks', 'followers_url': 'https://api.github.com/users/ArmorDarks/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2021-07-11 22:37:42 | 2024-04-17 16:04:59 | 2024-04-17 16:04:58 | NONE | null | null | null | React version: 17.0.2
## Steps To Reproduce
1. Render video or audio element with auto played source using React
2. Do not declare any `on*` handlers on the element
3. Run performance recording while not touching anything on the page
Link to code example: https://jsfiddle.net/ArmorDarks/2ugd80tm/2/
## The... | {'url': 'https://api.github.com/repos/facebook/react/issues/21847/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21847/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/21846 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21846/labels{/name} | https://api.github.com/repos/facebook/react/issues/21846/comments | https://api.github.com/repos/facebook/react/issues/21846/events | https://github.com/facebook/react/pull/21846 | 941,293,376 | MDExOlB1bGxSZXF1ZXN0Njg3MjE1MjEx | 21,846 | Bugfix: Flush legacy sync passive effects at beginning of event | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cb8afda183e9c931978279d3a1706d1d9c905484...12a4f0b70018333844d81d82450cff7827474949\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-10 17:38:58 | 2021-07-10 20:10:26 | 2021-07-10 18:15:11 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21846', 'html_url': 'https://github.com/facebook/react/pull/21846', 'diff_url': 'https://github.com/facebook/react/pull/21846.diff', 'patch_url': 'https://github.com/facebook/react/pull/21846.patch', 'merged_at': datetime.datetime(2021, 7, 10, 18, 15, 11)} | In concurrent roots, if a render is synchronous, we flush its passive effects synchronously. In legacy roots, we don't do this because all updates are synchronous — so we need to flush at the beginning of the next event. This is how `discreteUpdates` worked. | {'url': 'https://api.github.com/repos/facebook/react/issues/21846/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21846/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21845 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21845/labels{/name} | https://api.github.com/repos/facebook/react/issues/21845/comments | https://api.github.com/repos/facebook/react/issues/21845/events | https://github.com/facebook/react/issues/21845 | 941,171,291 | MDU6SXNzdWU5NDExNzEyOTE= | 21,845 | Bug: import preact component with hooks in React Page | {'login': 'andyzys', 'id': 5431879, 'node_id': 'MDQ6VXNlcjU0MzE4Nzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5431879?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/andyzys', 'html_url': 'https://github.com/andyzys', 'followers_url': 'https://api.github.com/users/andyzys/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"fixed"
] | 2021-07-10 04:37:00 | 2021-07-10 10:05:31 | 2021-07-10 10:04:15 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/21845/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21845/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21844 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21844/labels{/name} | https://api.github.com/repos/facebook/react/issues/21844/comments | https://api.github.com/repos/facebook/react/issues/21844/events | https://github.com/facebook/react/issues/21844 | 940,790,936 | MDU6SXNzdWU5NDA3OTA5MzY= | 21,844 | Strict effects and unmounted ref flag | {'login': 'otakustay', 'id': 639549, 'node_id': 'MDQ6VXNlcjYzOTU0OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/639549?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/otakustay', 'html_url': 'https://github.com/otakustay', 'followers_url': 'https://api.github.com/users/otakustay/followers',... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"> With react 18's strict effect, the intentional \"mount -> unmount -> mount\" steps may break some unmounted ref implements, the [ahooks implementation](https://github.com/alibaba/hooks/blob/7b026c03dde61449b051bb63ba68507115227cda/packages/hooks/src/useUnmountedRef/index.ts) is incorrect while the [react-use imp... | 2021-07-09 13:57:58 | 2021-07-10 20:21:21 | 2021-07-10 09:27:17 | CONTRIBUTOR | null | null | null | Posting this issue to share a common phenomenon related to strict effect, I have created a sandbox to demonstrate this issue: https://codesandbox.io/s/unmount-guard-in-strict-effect-5eneb?file=/src/App.js
Previously this is a common practice to have a `unmounted` ref indicating whether current component is unmounted... | {'url': 'https://api.github.com/repos/facebook/react/issues/21844/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21844/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21843 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21843/labels{/name} | https://api.github.com/repos/facebook/react/issues/21843/comments | https://api.github.com/repos/facebook/react/issues/21843/events | https://github.com/facebook/react/pull/21843 | 940,407,600 | MDExOlB1bGxSZXF1ZXN0Njg2NDgzMjY3 | 21,843 | Revert "Revert "Use `act()` in ReactFabric tests"" | {'login': 'sujatakhadka111', 'id': 79244497, 'node_id': 'MDQ6VXNlcjc5MjQ0NDk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/79244497?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sujatakhadka111', 'html_url': 'https://github.com/sujatakhadka111', 'followers_url': 'https://api.github.com/users... | [] | closed | false | null | [] | null | [
"Hi @sujatakhadka111! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn ord... | 2021-07-09 04:34:01 | 2021-07-09 18:19:49 | 2021-07-09 18:19:49 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21843', 'html_url': 'https://github.com/facebook/react/pull/21843', 'diff_url': 'https://github.com/facebook/react/pull/21843.diff', 'patch_url': 'https://github.com/facebook/react/pull/21843.patch', 'merged_at': None} | Reverts facebook/react#21840 | {'url': 'https://api.github.com/repos/facebook/react/issues/21843/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21843/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21842 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21842/labels{/name} | https://api.github.com/repos/facebook/react/issues/21842/comments | https://api.github.com/repos/facebook/react/issues/21842/events | https://github.com/facebook/react/pull/21842 | 940,361,934 | MDExOlB1bGxSZXF1ZXN0Njg2NDQ0ODk3 | 21,842 | Add test for #21837 | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f85f429d55f3f13bd741b4e4a06e3fcc54f2330c...df9a6ce33dfacf93c4cc165c02f486ec3efe89c0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-09 02:37:06 | 2021-07-09 03:01:29 | 2021-07-09 03:01:29 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21842', 'html_url': 'https://github.com/facebook/react/pull/21842', 'diff_url': 'https://github.com/facebook/react/pull/21842.diff', 'patch_url': 'https://github.com/facebook/react/pull/21842.patch', 'merged_at': datetime.datetime(2021, 7, 9, 3, 1, 29)} | Taken from https://github.com/facebook/react/pull/21837#issuecomment-876788973 | {'url': 'https://api.github.com/repos/facebook/react/issues/21842/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21842/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21841 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21841/labels{/name} | https://api.github.com/repos/facebook/react/issues/21841/comments | https://api.github.com/repos/facebook/react/issues/21841/events | https://github.com/facebook/react/pull/21841 | 940,358,376 | MDExOlB1bGxSZXF1ZXN0Njg2NDQyMDMy | 21,841 | Use `act()` in ReactFabric tests | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 84639ab53fcb83c5d4806b5d791bb07992c40bf1...a5682be6850fa0f132c2b8d4a72528db21d0d9dd\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-09 02:27:26 | 2021-07-09 02:35:47 | 2021-07-09 02:35:46 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21841', 'html_url': 'https://github.com/facebook/react/pull/21841', 'diff_url': 'https://github.com/facebook/react/pull/21841.diff', 'patch_url': 'https://github.com/facebook/react/pull/21841.patch', 'merged_at': datetime.datetime(2021, 7, 9, 2, 35, 46)} | Re-landing #21839
The public `act` API is not supported in production mode, only development. But in the React repo, we run our tests in both production and development mode, because we're testing React itself.
When writing tests in the React repo, we use a special, internal-only implementation of `act` that work... | {'url': 'https://api.github.com/repos/facebook/react/issues/21841/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21841/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21840 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21840/labels{/name} | https://api.github.com/repos/facebook/react/issues/21840/comments | https://api.github.com/repos/facebook/react/issues/21840/events | https://github.com/facebook/react/pull/21840 | 940,255,039 | MDExOlB1bGxSZXF1ZXN0Njg2MzU0MzAw | 21,840 | Revert "Use `act()` in ReactFabric tests" | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"> Reverts #21839\r\n\r\nhhhhhhhhhhhhhhhhhhh"
] | 2021-07-08 22:05:48 | 2021-07-09 04:16:06 | 2021-07-08 22:05:52 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21840', 'html_url': 'https://github.com/facebook/react/pull/21840', 'diff_url': 'https://github.com/facebook/react/pull/21840.diff', 'patch_url': 'https://github.com/facebook/react/pull/21840.patch', 'merged_at': datetime.datetime(2021, 7, 8, 22, 5, 52)} | Reverts facebook/react#21839 | {'url': 'https://api.github.com/repos/facebook/react/issues/21840/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21840/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21839 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21839/labels{/name} | https://api.github.com/repos/facebook/react/issues/21839/comments | https://api.github.com/repos/facebook/react/issues/21839/events | https://github.com/facebook/react/pull/21839 | 940,247,498 | MDExOlB1bGxSZXF1ZXN0Njg2MzQ3Nzc5 | 21,839 | Use `act()` in ReactFabric tests | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Looks good! Accepting to unblock, tests are still failing",
"Apparently, `act()` is not supported in production runs of the tests? Ehh… no idea what's going on, going to revert for now."
] | 2021-07-08 21:51:04 | 2021-07-08 22:05:41 | 2021-07-08 22:02:02 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21839', 'html_url': 'https://github.com/facebook/react/pull/21839', 'diff_url': 'https://github.com/facebook/react/pull/21839.diff', 'patch_url': 'https://github.com/facebook/react/pull/21839.patch', 'merged_at': datetime.datetime(2021, 7, 8, 22, 2, 2)} | ## Summary
Refactors `ReactFabric-test.internal.js` to use `act()` when invoking `ReactFabric.render`, where possible. This ensures that effects and reconciliation are fully operational before making assertions.
## Test Plan
Run `yarn test ReactFabric-test.internal.js`. | {'url': 'https://api.github.com/repos/facebook/react/issues/21839/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21839/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21838 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21838/labels{/name} | https://api.github.com/repos/facebook/react/issues/21838/comments | https://api.github.com/repos/facebook/react/issues/21838/events | https://github.com/facebook/react/pull/21838 | 940,231,774 | MDExOlB1bGxSZXF1ZXN0Njg2MzM0MDMx | 21,838 | DevTools: Scroll to first error or warning by click on error or warning icon | {'login': 'behnammodi', 'id': 1549069, 'node_id': 'MDQ6VXNlcjE1NDkwNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1549069?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/behnammodi', 'html_url': 'https://github.com/behnammodi', 'followers_url': 'https://api.github.com/users/behnammodi/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"The up/down arrow buttons let you step through errors and warnings. This UI was patterned after UIs like Chrome's find-in-page or Sublime's file search.\r\n\r\nI'm not sure I think that clicking on the icons themselves is that intuitive. Can you point me at some reference UIs that work this way maybe?",
"You can... | 2021-07-08 21:21:54 | 2022-12-16 21:47:18 | 2021-07-13 13:39:05 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21838', 'html_url': 'https://github.com/facebook/react/pull/21838', 'diff_url': 'https://github.com/facebook/react/pull/21838.diff', 'patch_url': 'https://github.com/facebook/react/pull/21838.patch', 'merged_at': None} | Now, we can click on error or warning icon to scroll to first error or warning
<img width="583" alt="Screen Shot 2021-07-09 at 01 50 42" src="https://user-images.githubusercontent.com/1549069/124992365-1771a600-e058-11eb-93a0-ee5c85ad1ad5.png">
| {'url': 'https://api.github.com/repos/facebook/react/issues/21838/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21838/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21837 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21837/labels{/name} | https://api.github.com/repos/facebook/react/issues/21837/comments | https://api.github.com/repos/facebook/react/issues/21837/events | https://github.com/facebook/react/pull/21837 | 940,222,975 | MDExOlB1bGxSZXF1ZXN0Njg2MzI2Mzgy | 21,837 | Guard against reused fibers in React Native commands | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Some things in React warn if they are called after a component has unmounted, like setState, right? Should there be a similar warning here?",
"Adding a test. I will be stacking this on top of https://github.com/facebook/react/pull/21839.",
"I'm going to proceed without the test for now because I cannot use `ac... | 2021-07-08 21:07:18 | 2021-07-09 07:48:15 | 2021-07-08 23:01:51 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21837', 'html_url': 'https://github.com/facebook/react/pull/21837', 'diff_url': 'https://github.com/facebook/react/pull/21837.diff', 'patch_url': 'https://github.com/facebook/react/pull/21837.patch', 'merged_at': datetime.datetime(2021, 7, 8, 23, 1, 51)} | ## Summary
If either `dispatchCommand` or `sendAccessibilityEvent` are called on a handle that has been unmounted, they can throw a TypeError because `stateNode` may be null. This changes the methods to be resilient to those cases.
## Test Plan
Ran `yarn flow fabric` and `yarn flow native` successfully.
Ran `... | {'url': 'https://api.github.com/repos/facebook/react/issues/21837/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21837/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21836 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21836/labels{/name} | https://api.github.com/repos/facebook/react/issues/21836/comments | https://api.github.com/repos/facebook/react/issues/21836/events | https://github.com/facebook/react/pull/21836 | 940,209,280 | MDExOlB1bGxSZXF1ZXN0Njg2MzE1MjQx | 21,836 | DevTools: Show numbers of children by hover or select element | {'login': 'behnammodi', 'id': 1549069, 'node_id': 'MDQ6VXNlcjE1NDkwNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1549069?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/behnammodi', 'html_url': 'https://github.com/behnammodi', 'followers_url': 'https://api.github.com/users/behnammodi/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Out of curiosity, what's the motivation for this feature? I think adding a hover action that changes what's displayed in a row would open up some edge cases (for DevTools [automatic tab sizing](https://github.com/facebook/react/blob/master/packages/react-devtools/CHANGELOG.md#no-more-horizontal-scrolling)) that I'... | 2021-07-08 20:47:09 | 2021-07-14 18:38:01 | 2021-07-14 18:38:00 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21836', 'html_url': 'https://github.com/facebook/react/pull/21836', 'diff_url': 'https://github.com/facebook/react/pull/21836.diff', 'patch_url': 'https://github.com/facebook/react/pull/21836.patch', 'merged_at': None} | For knowing numbers of children by hover or select element
<img width="266" alt="Screen Shot 2021-07-09 at 01 12 18" src="https://user-images.githubusercontent.com/1549069/124988320-17bb7280-e053-11eb-8afe-501d9a0ceecc.png">
| {'url': 'https://api.github.com/repos/facebook/react/issues/21836/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21836/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21835 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21835/labels{/name} | https://api.github.com/repos/facebook/react/issues/21835/comments | https://api.github.com/repos/facebook/react/issues/21835/events | https://github.com/facebook/react/pull/21835 | 940,204,155 | MDExOlB1bGxSZXF1ZXN0Njg2MzExMTEx | 21,835 | DevTools: Don't load source files contaning only unnamed hooks | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f52b73f9d0a9adbdb2815af440b2edd6b5627ff0...2cdb5e2f7e802d53eed4c4d1ea654517fc85d63d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-08 20:39:34 | 2021-07-08 20:46:19 | 2021-07-08 20:46:17 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21835', 'html_url': 'https://github.com/facebook/react/pull/21835', 'diff_url': 'https://github.com/facebook/react/pull/21835.diff', 'patch_url': 'https://github.com/facebook/react/pull/21835.patch', 'merged_at': datetime.datetime(2021, 7, 8, 20, 46, 17)} | Filter these out earlier and avoid the extra processing.
Resolves #21834 | {'url': 'https://api.github.com/repos/facebook/react/issues/21835/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21835/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21834 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21834/labels{/name} | https://api.github.com/repos/facebook/react/issues/21834/comments | https://api.github.com/repos/facebook/react/issues/21834/events | https://github.com/facebook/react/issues/21834 | 940,184,704 | MDU6SXNzdWU5NDAxODQ3MDQ= | 21,834 | [DevTools] Skip loading and parsing source for unnamed built-in hooks | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [] | 2021-07-08 20:11:17 | 2021-07-08 20:47:40 | 2021-07-08 20:46:17 | CONTRIBUTOR | null | null | null | Hooks like `useEffect` or `useLayoutEffect` will _never_ have names, so if a the only hooks for a given source file are these "unnamed" built-in hooks, we should skip loading the source code. | {'url': 'https://api.github.com/repos/facebook/react/issues/21834/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21834/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21833 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21833/labels{/name} | https://api.github.com/repos/facebook/react/issues/21833/comments | https://api.github.com/repos/facebook/react/issues/21833/events | https://github.com/facebook/react/pull/21833 | 940,178,304 | MDExOlB1bGxSZXF1ZXN0Njg2Mjg4ODg2 | 21,833 | DevTools: Update named hooks match to use column number also | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 92af60afb2a229c0b70d360a80e24e4f7fd394aa...c170b880e8d7ed0fdfb3e04eae828d29037f8ba3\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-08 20:02:16 | 2021-07-13 16:57:40 | 2021-07-08 20:12:23 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21833', 'html_url': 'https://github.com/facebook/react/pull/21833', 'diff_url': 'https://github.com/facebook/react/pull/21833.diff', 'patch_url': 'https://github.com/facebook/react/pull/21833.patch', 'merged_at': datetime.datetime(2021, 7, 8, 20, 12, 23)} | This prevents edge cases where AST nodes are incorrectly matched.
Resolves #21792 | {'url': 'https://api.github.com/repos/facebook/react/issues/21833/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21833/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21832 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21832/labels{/name} | https://api.github.com/repos/facebook/react/issues/21832/comments | https://api.github.com/repos/facebook/react/issues/21832/events | https://github.com/facebook/react/issues/21832 | 940,101,155 | MDU6SXNzdWU5NDAxMDExNTU= | 21,832 | Bug: | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2021-07-08 18:06:50 | 2021-07-08 18:07:36 | 2021-07-08 18:07:30 | CONTRIBUTOR | null | null | null | Accidental issue. | {'url': 'https://api.github.com/repos/facebook/react/issues/21832/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21832/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21831 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21831/labels{/name} | https://api.github.com/repos/facebook/react/issues/21831/comments | https://api.github.com/repos/facebook/react/issues/21831/events | https://github.com/facebook/react/pull/21831 | 940,081,443 | MDExOlB1bGxSZXF1ZXN0Njg2MjA2MDgw | 21,831 | DevTool: hook names cache no longer loses entries between selection | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8b34d5a905a17e95b5b9b515b60acbb2370f3603...fa50a4b6c3cbbd32a7e6d08ffd229b4d7fa84098\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-08 17:38:24 | 2021-07-08 17:54:18 | 2021-07-08 17:54:17 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21831', 'html_url': 'https://github.com/facebook/react/pull/21831', 'diff_url': 'https://github.com/facebook/react/pull/21831.diff', 'patch_url': 'https://github.com/facebook/react/pull/21831.patch', 'merged_at': datetime.datetime(2021, 7, 8, 17, 54, 16)} | Made several changes to the hooks name cache to avoid losing cached data between selected elements:
1. No longer use React-managed cache. This had the unfortunate side effect of the inspected element cache also clearing the hook names cache. For now, instead, a module-level WeakMap cache is used. This isn't great but ... | {'url': 'https://api.github.com/repos/facebook/react/issues/21831/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21831/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21830 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21830/labels{/name} | https://api.github.com/repos/facebook/react/issues/21830/comments | https://api.github.com/repos/facebook/react/issues/21830/events | https://github.com/facebook/react/issues/21830 | 939,981,337 | MDU6SXNzdWU5Mzk5ODEzMzc= | 21,830 | Bug: [eslint-plugin-react-hooks] Functions returning new dates should be flagged as missing dependencies | {'login': 'amanmahajan7', 'id': 1452717, 'node_id': 'MDQ6VXNlcjE0NTI3MTc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1452717?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/amanmahajan7', 'html_url': 'https://github.com/amanmahajan7', 'followers_url': 'https://api.github.com/users/amanmahaja... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"> Should flag getCurrentDate as missing dependency\r\n\r\nAnd what that dependency would be?",
"`getCurrentDate` as it used inside `useMemo`",
"Well, `getCurrentDate` doesn't actually capture any local variables, hence this behaviour. What you propose would basically disable `useMemo` in this case (since `getC... | 2021-07-08 15:31:01 | 2021-08-24 21:25:42 | 2021-08-24 21:25:41 | NONE | null | null | null | React version: 17.0.1
## Steps To Reproduce
```
import "./styles.css";
import { useMemo, useState } from "react";
export default function App() {
const [, rerender] = useState({});
function getCurrentDate() {
return new Date();
}
const currentTime = useMemo(() => {
return getCurrentD... | {'url': 'https://api.github.com/repos/facebook/react/issues/21830/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21830/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21829 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21829/labels{/name} | https://api.github.com/repos/facebook/react/issues/21829/comments | https://api.github.com/repos/facebook/react/issues/21829/events | https://github.com/facebook/react/pull/21829 | 939,879,416 | MDExOlB1bGxSZXF1ZXN0Njg2MDMyNTA2 | 21,829 | [package:react-dom] updateREADME's Class Component to Function Component | {'login': 'ryota-murakami', 'id': 5501268, 'node_id': 'MDQ6VXNlcjU1MDEyNjg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5501268?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ryota-murakami', 'html_url': 'https://github.com/ryota-murakami', 'followers_url': 'https://api.github.com/users/ryot... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"In CircleCI, `Error: Base commit is broken` ? 🤔\r\n\r\nI would re-run this task but nothing permission...\r\n\r\n<img width=\"965\" alt=\"Screen Shot 2021-07-14 at 15 01 23\" src=\"https://user-images.githubusercontent.com/5501268/125571102-20ede2c8-2499-4965-b93b-f6c3359addb5.png\">\r\n",
"sure, thanks."
] | 2021-07-08 13:47:40 | 2021-09-06 20:23:18 | 2021-09-06 20:23:13 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21829', 'html_url': 'https://github.com/facebook/react/pull/21829', 'diff_url': 'https://github.com/facebook/react/pull/21829.diff', 'patch_url': 'https://github.com/facebook/react/pull/21829.patch', 'merged_at': datetime.datetime(2021, 9, 6, 20, 23, 13)} | ## Summary
The summary is the same as the title.
## Why
In these day many developer facing this content while opening `package.json` with modern editor like this.
<img width="652" alt="Screen Shot 2021-07-08 at 22 37 32" src="https://user-images.githubusercontent.com/5501268/124931983-a9b88080-e03d-11eb-8761-4c... | {'url': 'https://api.github.com/repos/facebook/react/issues/21829/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21829/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21828 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21828/labels{/name} | https://api.github.com/repos/facebook/react/issues/21828/comments | https://api.github.com/repos/facebook/react/issues/21828/events | https://github.com/facebook/react/issues/21828 | 939,480,451 | MDU6SXNzdWU5Mzk0ODA0NTE= | 21,828 | [Devtools] Indicate or print which element causes suspense fallback | {'login': 'otakustay', 'id': 639549, 'node_id': 'MDQ6VXNlcjYzOTU0OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/639549?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/otakustay', 'html_url': 'https://github.com/otakustay', 'followers_url': 'https://api.github.com/users/otakustay/followers',... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/... | open | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2021-07-08 05:19:31 | 2022-01-09 10:06:03 | null | CONTRIBUTOR | null | null | null | In a deep component tree, we sometimes modify a deeply nested component to use suspense but failed to wrap `Suspense` at a suitable place, this causes the root `Suspense` into fallback and is hard to location where this fallback is introduced.
"Whether a component is throwing Promise" is an implicit convention of co... | {'url': 'https://api.github.com/repos/facebook/react/issues/21828/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21828/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/21827 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21827/labels{/name} | https://api.github.com/repos/facebook/react/issues/21827/comments | https://api.github.com/repos/facebook/react/issues/21827/events | https://github.com/facebook/react/issues/21827 | 939,444,379 | MDU6SXNzdWU5Mzk0NDQzNzk= | 21,827 | [Devtools] Make link style value clickable | {'login': 'otakustay', 'id': 639549, 'node_id': 'MDQ6VXNlcjYzOTU0OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/639549?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/otakustay', 'html_url': 'https://github.com/otakustay', 'followers_url': 'https://api.github.com/users/otakustay/followers',... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https:/... | closed | false | null | [] | null | [
"Hello,\r\n\r\nI am very interested in starting to contribute to this project and I would like to grab this issue since it seems quite easy to start but I've never set up this devtools project so I am little nervous. If I could be pointed in right direction with docs (I saw architecture and dev workflow from issue ... | 2021-07-08 04:02:20 | 2024-04-17 18:04:35 | 2024-04-17 18:04:34 | CONTRIBUTOR | null | null | null | I didn't find a suitable place to open feature request of react devtools.
We're developing a babel plugin to inject a `useDebugValue` into every component so that developers can immediately see the source file path of inspecting component like:
: solve some code smell | {'login': 'liuarui', 'id': 47778908, 'node_id': 'MDQ6VXNlcjQ3Nzc4OTA4', 'avatar_url': 'https://avatars.githubusercontent.com/u/47778908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/liuarui', 'html_url': 'https://github.com/liuarui', 'followers_url': 'https://api.github.com/users/liuarui/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"It seems that Circleci has a problem, I am trying to restart Check",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 241485a2c4db75f42baf62c68f54e7cdef101c31...3dd171a05628e29bb6b8a356317b298dbab25d9f\n\n## Critical size changes\n\nIncludes ... | 2021-07-08 03:26:56 | 2021-07-08 15:34:53 | 2021-07-08 15:05:08 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21826', 'html_url': 'https://github.com/facebook/react/pull/21826', 'diff_url': 'https://github.com/facebook/react/pull/21826.diff', 'patch_url': 'https://github.com/facebook/react/pull/21826.patch', 'merged_at': None} | ## Summary
When I learn the react source, I found some small errors that don't affect code execution.
Refactor some `react/jsx` `ReactJSXElement.js` code
## Test Plan
just refactor, and I have passed the local test
| {'url': 'https://api.github.com/repos/facebook/react/issues/21826/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21826/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21825 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21825/labels{/name} | https://api.github.com/repos/facebook/react/issues/21825/comments | https://api.github.com/repos/facebook/react/issues/21825/events | https://github.com/facebook/react/pull/21825 | 939,422,959 | MDExOlB1bGxSZXF1ZXN0Njg1NjQ2ODY4 | 21,825 | refactor(react-jsx): solve some code smell | {'login': 'liuarui', 'id': 47778908, 'node_id': 'MDQ6VXNlcjQ3Nzc4OTA4', 'avatar_url': 'https://avatars.githubusercontent.com/u/47778908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/liuarui', 'html_url': 'https://github.com/liuarui', 'followers_url': 'https://api.github.com/users/liuarui/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"It seems that Circleci has some questions, I will trigger it to try.",
"close ,open new pr"
] | 2021-07-08 03:07:25 | 2021-07-08 03:26:16 | 2021-07-08 03:26:16 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21825', 'html_url': 'https://github.com/facebook/react/pull/21825', 'diff_url': 'https://github.com/facebook/react/pull/21825.diff', 'patch_url': 'https://github.com/facebook/react/pull/21825.patch', 'merged_at': None} | ## Summary
When I learn the react source, I found some small errors that don't affect code execution.
Refactor some `react/jsx` `ReactJSXElement.js` code
## Test Plan
just refactor, and I have passed the local test
| {'url': 'https://api.github.com/repos/facebook/react/issues/21825/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21825/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21824 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21824/labels{/name} | https://api.github.com/repos/facebook/react/issues/21824/comments | https://api.github.com/repos/facebook/react/issues/21824/events | https://github.com/facebook/react/pull/21824 | 939,391,625 | MDExOlB1bGxSZXF1ZXN0Njg1NjIxMzQy | 21,824 | [SSR2 Fixture] Delete duplicate DOCTYPE | {'login': 'taichiyi', 'id': 11924426, 'node_id': 'MDQ6VXNlcjExOTI0NDI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/11924426?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/taichiyi', 'html_url': 'https://github.com/taichiyi', 'followers_url': 'https://api.github.com/users/taichiyi/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8b34d5a905a17e95b5b9b515b60acbb2370f3603...a408fb02d9491c06eec57f8a98db35f8d18135a9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-08 01:49:45 | 2021-07-08 02:11:55 | 2021-07-08 02:11:42 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21824', 'html_url': 'https://github.com/facebook/react/pull/21824', 'diff_url': 'https://github.com/facebook/react/pull/21824.diff', 'patch_url': 'https://github.com/facebook/react/pull/21824.patch', 'merged_at': datetime.datetime(2021, 7, 8, 2, 11, 42)} | before
after
| {'url': 'https://api.github.com/repos/facebook/react/issues/21824/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21824/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21823 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21823/labels{/name} | https://api.github.com/repos/facebook/react/issues/21823/comments | https://api.github.com/repos/facebook/react/issues/21823/events | https://github.com/facebook/react/pull/21823 | 939,383,614 | MDExOlB1bGxSZXF1ZXN0Njg1NjE0OTQz | 21,823 | [fizz] Add comments about task | {'login': 'taichiyi', 'id': 11924426, 'node_id': 'MDQ6VXNlcjExOTI0NDI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/11924426?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/taichiyi', 'html_url': 'https://github.com/taichiyi', 'followers_url': 'https://api.github.com/users/taichiyi/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8b34d5a905a17e95b5b9b515b60acbb2370f3603...0f87861b17fc3f538bfd48b45b44440fafb32185\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-08 01:27:23 | 2024-04-10 13:53:50 | 2024-04-10 13:53:49 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21823', 'html_url': 'https://github.com/facebook/react/pull/21823', 'diff_url': 'https://github.com/facebook/react/pull/21823.diff', 'patch_url': 'https://github.com/facebook/react/pull/21823.patch', 'merged_at': None} | Add comments about task | {'url': 'https://api.github.com/repos/facebook/react/issues/21823/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21823/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21822 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21822/labels{/name} | https://api.github.com/repos/facebook/react/issues/21822/comments | https://api.github.com/repos/facebook/react/issues/21822/events | https://github.com/facebook/react/issues/21822 | 939,305,907 | MDU6SXNzdWU5MzkzMDU5MDc= | 21,822 | [DevTools] Make sure named hooks Suspense cache is persisting between elements | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Update: I am seeing what looks items getting evicted from the Suspense cache unexpectedly.\r\n\r\nI added logging and verified that the elements are referentially equal between selections, but the cache is `returning` undefined – (the `WeakMap` has fewer items in it than it should). I changed from a `WeakMap` to a... | 2021-07-07 22:19:13 | 2021-07-08 17:54:17 | 2021-07-08 17:54:17 | CONTRIBUTOR | null | null | null | It currently looks like the `map.get(element)` returns `undefined` even for previously-loaded elements. Are we evicting from the cache prematurely? Why?
Our second level caching (inside of `parseHookNames`) is working but this is still resulting in a lot of unnecessary work. | {'url': 'https://api.github.com/repos/facebook/react/issues/21822/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21822/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21821 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21821/labels{/name} | https://api.github.com/repos/facebook/react/issues/21821/comments | https://api.github.com/repos/facebook/react/issues/21821/events | https://github.com/facebook/react/pull/21821 | 939,292,743 | MDExOlB1bGxSZXF1ZXN0Njg1NTM3MDk2 | 21,821 | Reset inspected element cache in the event of an error | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 241485a2c4db75f42baf62c68f54e7cdef101c31...14b8286147597e12af24d45943e26b9d7b26c46a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-07 21:55:34 | 2021-07-08 18:07:17 | 2021-07-08 18:07:15 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21821', 'html_url': 'https://github.com/facebook/react/pull/21821', 'diff_url': 'https://github.com/facebook/react/pull/21821.diff', 'patch_url': 'https://github.com/facebook/react/pull/21821.patch', 'merged_at': datetime.datetime(2021, 7, 8, 18, 7, 15)} | This prevents React from immediately erroring again when re-rendering (since the previous error would have been stored in the Suspense cache)
Resolves #21819 | {'url': 'https://api.github.com/repos/facebook/react/issues/21821/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21821/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21820 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21820/labels{/name} | https://api.github.com/repos/facebook/react/issues/21820/comments | https://api.github.com/repos/facebook/react/issues/21820/events | https://github.com/facebook/react/pull/21820 | 939,220,733 | MDExOlB1bGxSZXF1ZXN0Njg1NDc2Mzc1 | 21,820 | DevTools show error icon when hook name parsing fails | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9ccc25a0ea322b39ea04f8dfc03620ea90e0da94...a5d9717a28825404a4abe51071c7579e380d5ab5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-07 20:06:26 | 2021-07-07 20:27:40 | 2021-07-07 20:27:39 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21820', 'html_url': 'https://github.com/facebook/react/pull/21820', 'diff_url': 'https://github.com/facebook/react/pull/21820.diff', 'patch_url': 'https://github.com/facebook/react/pull/21820.patch', 'merged_at': datetime.datetime(2021, 7, 7, 20, 27, 39)} | Resolves #21817
| {'url': 'https://api.github.com/repos/facebook/react/issues/21820/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21820/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21819 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21819/labels{/name} | https://api.github.com/repos/facebook/react/issues/21819/comments | https://api.github.com/repos/facebook/react/issues/21819/events | https://github.com/facebook/react/issues/21819 | 939,194,635 | MDU6SXNzdWU5MzkxOTQ2MzU= | 21,819 | [DevTools] Improve "retry" function for inspected component props/state/hooks | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"`<CometPressable>` is good example of a component that currently fails silently due to a parsing error. (Not sure why the error itself is happening but for now, maybe our Flow parser is old? it's a good repro though.)"
] | 2021-07-07 19:27:38 | 2021-07-08 18:07:15 | 2021-07-08 18:07:15 | CONTRIBUTOR | null | null | null | Currently if an error occurs when inspecting a component, an error overlay is shown in the right hand side of DevTools along with a "dismiss" button to allow the inspection to be retried. However, currently this "retry" does not clear the entry from the cache and so it will immediately fail again if the same component ... | {'url': 'https://api.github.com/repos/facebook/react/issues/21819/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21819/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21818 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21818/labels{/name} | https://api.github.com/repos/facebook/react/issues/21818/comments | https://api.github.com/repos/facebook/react/issues/21818/events | https://github.com/facebook/react/issues/21818 | 939,192,623 | MDU6SXNzdWU5MzkxOTI2MjM= | 21,818 | [DevTools] Named hooks transient errors | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"`<CometPressable>` is another example that (silently) fails to parse any names.\r\n\r\n**Edit** I believe this is because the selected component type is `forwardRef` rather than a function component.",
"I think this was actually because the hooks objects get recreated between inspections. Switch to keying them b... | 2021-07-07 19:24:33 | 2021-07-08 17:56:11 | 2021-07-08 17:56:11 | CONTRIBUTOR | null | null | null | Sometimes named hooks inspection will seemingly fail the first time then work the second time. (e.g. using a DEV build of Facebook.com, the `<CometTheme>` component currently does this).
I _think_ this might indicate a timeout during inspection? (So the retry is fast because everything is cached.) | {'url': 'https://api.github.com/repos/facebook/react/issues/21818/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21818/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21817 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21817/labels{/name} | https://api.github.com/repos/facebook/react/issues/21817/comments | https://api.github.com/repos/facebook/react/issues/21817/events | https://github.com/facebook/react/issues/21817 | 939,191,947 | MDU6SXNzdWU5MzkxOTE5NDc= | 21,817 | [DevTools] Named hooks error badge | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [] | 2021-07-07 19:23:34 | 2021-07-07 20:27:39 | 2021-07-07 20:27:39 | CONTRIBUTOR | null | null | null | The named hooks cache returns `Array<string | null> | null` The first (mixed array of string and null) indicates an overall success, even if some names couldn't be inferred. The second indicates an error (e.g. couldn't locate or load source map).
In the event of the 2nd response type, the UI currently does nothing (... | {'url': 'https://api.github.com/repos/facebook/react/issues/21817/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21817/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21816 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21816/labels{/name} | https://api.github.com/repos/facebook/react/issues/21816/comments | https://api.github.com/repos/facebook/react/issues/21816/events | https://github.com/facebook/react/pull/21816 | 939,174,552 | MDExOlB1bGxSZXF1ZXN0Njg1NDM2Nzc3 | 21,816 | Reverting recent flushSync changes | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b6258b05f4ea16776557bc370ee0892604504d8f...7795b3e71c35e9be17aa7317d4eb38528c8c49e4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-07 19:00:23 | 2021-07-07 19:07:57 | 2021-07-07 19:07:56 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21816', 'html_url': 'https://github.com/facebook/react/pull/21816', 'diff_url': 'https://github.com/facebook/react/pull/21816.diff', 'patch_url': 'https://github.com/facebook/react/pull/21816.patch', 'merged_at': datetime.datetime(2021, 7, 7, 19, 7, 55)} | Revert #21776 and #21775 as both cause regressions when syncing to www.
T95006418 has all of the regression details. | {'url': 'https://api.github.com/repos/facebook/react/issues/21816/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21816/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21815 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21815/labels{/name} | https://api.github.com/repos/facebook/react/issues/21815/comments | https://api.github.com/repos/facebook/react/issues/21815/events | https://github.com/facebook/react/pull/21815 | 939,147,144 | MDExOlB1bGxSZXF1ZXN0Njg1NDEzNDYy | 21,815 | DevTools named hooks: Support FLow syntax | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9c7f29ebe75a7546e59038123d3b0c3515bec916...7d0292e3bb5b479a1cda7ab74f00b997b85732ad\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-07 18:21:22 | 2021-07-07 18:29:43 | 2021-07-07 18:29:41 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21815', 'html_url': 'https://github.com/facebook/react/pull/21815', 'diff_url': 'https://github.com/facebook/react/pull/21815.diff', 'patch_url': 'https://github.com/facebook/react/pull/21815.patch', 'merged_at': datetime.datetime(2021, 7, 7, 18, 29, 41)} | Detect Flow pragma (@flow) and use Flow plug-in instead of TypeScript (default)
Resolves #21793 | {'url': 'https://api.github.com/repos/facebook/react/issues/21815/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21815/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21814 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21814/labels{/name} | https://api.github.com/repos/facebook/react/issues/21814/comments | https://api.github.com/repos/facebook/react/issues/21814/events | https://github.com/facebook/react/pull/21814 | 939,143,241 | MDExOlB1bGxSZXF1ZXN0Njg1NDEwMDM1 | 21,814 | DevTooks: Don't dehydrate hook source fileNames | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9c7f29ebe75a7546e59038123d3b0c3515bec916...42c59ffaad65721ab5d05346dfb995e99ad806aa\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-07-07 18:16:12 | 2021-07-07 18:24:19 | 2021-07-07 18:24:18 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21814', 'html_url': 'https://github.com/facebook/react/pull/21814', 'diff_url': 'https://github.com/facebook/react/pull/21814.diff', 'patch_url': 'https://github.com/facebook/react/pull/21814.patch', 'merged_at': datetime.datetime(2021, 7, 7, 18, 24, 18)} | This can cause long file names (URLs) to be truncated which in turn will break named hooks code (since it needs to load those file names).
Also fix an issue where an absolute URL was being converted into an incorrect URL.
Resolves #21811 | {'url': 'https://api.github.com/repos/facebook/react/issues/21814/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21814/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21812 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21812/labels{/name} | https://api.github.com/repos/facebook/react/issues/21812/comments | https://api.github.com/repos/facebook/react/issues/21812/events | https://github.com/facebook/react/issues/21812 | 939,062,805 | MDU6SXNzdWU5MzkwNjI4MDU= | 21,812 | Bug: onContextMenu not fired in iOS 13 and later | {'login': 'robatwilliams', 'id': 3041926, 'node_id': 'MDQ6VXNlcjMwNDE5MjY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3041926?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/robatwilliams', 'html_url': 'https://github.com/robatwilliams', 'followers_url': 'https://api.github.com/users/robatwi... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"They're not fired in iOS 12 either",
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, ple... | 2021-07-07 16:27:09 | 2024-04-10 16:48:26 | 2024-04-10 13:53:51 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
From v13 onwards, iOS doesn't fire `contextmenu` events on long-press. It only dis... | {'url': 'https://api.github.com/repos/facebook/react/issues/21812/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21812/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/21811 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21811/labels{/name} | https://api.github.com/repos/facebook/react/issues/21811/comments | https://api.github.com/repos/facebook/react/issues/21811/events | https://github.com/facebook/react/issues/21811 | 939,003,467 | MDU6SXNzdWU5MzkwMDM0Njc= | 21,811 | [DevTools] Don't serialize hook source fileNames (URLs) | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [] | 2021-07-07 15:18:56 | 2021-07-07 18:24:18 | 2021-07-07 18:24:18 | CONTRIBUTOR | null | null | null | This can cause long file names (URLs) to be truncated which in turn will break named hooks code (since it needs to load those file names). | {'url': 'https://api.github.com/repos/facebook/react/issues/21811/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21811/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21810 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21810/labels{/name} | https://api.github.com/repos/facebook/react/issues/21810/comments | https://api.github.com/repos/facebook/react/issues/21810/events | https://github.com/facebook/react/issues/21810 | 938,984,369 | MDU6SXNzdWU5Mzg5ODQzNjk= | 21,810 | Bug: unstable_flushDiscreteUpdates when rendering <video muted /> | {'login': 'reaktivo', 'id': 13637, 'node_id': 'MDQ6VXNlcjEzNjM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/13637?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/reaktivo', 'html_url': 'https://github.com/reaktivo', 'followers_url': 'https://api.github.com/users/reaktivo/followers', 'followin... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2021-07-07 14:59:18 | 2022-03-30 01:35:59 | 2022-03-30 01:35:59 | NONE | null | null | null | React version: 17.0.2
## Steps To Reproduce
1. Rendering `<video muted />` triggers "Warning: unstable_flushDiscreteUpdates: Cannot flush updates when React is already rendering"
```jsx
import * as React from "react";
import * as ReactDOM from "react-dom";
test("should render without calling console error... | {'url': 'https://api.github.com/repos/facebook/react/issues/21810/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21810/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21809 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21809/labels{/name} | https://api.github.com/repos/facebook/react/issues/21809/comments | https://api.github.com/repos/facebook/react/issues/21809/events | https://github.com/facebook/react/issues/21809 | 938,877,612 | MDU6SXNzdWU5Mzg4Nzc2MTI= | 21,809 | Bug: Safari does not load lazy-imported components when re-entering site | {'login': 'ksendra', 'id': 5622744, 'node_id': 'MDQ6VXNlcjU2MjI3NDQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5622744?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ksendra', 'html_url': 'https://github.com/ksendra', 'followers_url': 'https://api.github.com/users/ksendra/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Update: same behavior occurs on macOS Safari (14.1.1 for Big Sur). Although this does not occur on Safari Technology Preview version.",
"I ran into a quite same issue with React v17.0.2. But my react app does not load for the first time to access it through Safari, a blank page is displayed and when I reload the... | 2021-07-07 13:10:14 | 2024-04-17 18:04:35 | 2024-04-17 18:04:35 | NONE | null | null | null | On the iOS version of Safari lazy load of components (with React.lazy) does not always work correctly. If you enter the website everything works fine, but if you then close Safari through the app drawer and open it up again - the website does not load the components again and the site is stuck in Suspense fallback. The... | {'url': 'https://api.github.com/repos/facebook/react/issues/21809/reactions', 'total_count': 10, '+1': 10, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21809/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/21808 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21808/labels{/name} | https://api.github.com/repos/facebook/react/issues/21808/comments | https://api.github.com/repos/facebook/react/issues/21808/events | https://github.com/facebook/react/issues/21808 | 938,694,344 | MDU6SXNzdWU5Mzg2OTQzNDQ= | 21,808 | useEffect in React 18 (StrictMode) gets called twice. | {'login': 'kuzn5298', 'id': 84848052, 'node_id': 'MDQ6VXNlcjg0ODQ4MDUy', 'avatar_url': 'https://avatars.githubusercontent.com/u/84848052?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kuzn5298', 'html_url': 'https://github.com/kuzn5298', 'followers_url': 'https://api.github.com/users/kuzn5298/followers',... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"Yes that's what the doc are pointing out and specially : \r\n```\r\nStarting with React 17, React automatically modifies the console methods like console.log() \r\nto silence the logs in the second call to lifecycle functions. \r\nHowever, it may cause undesired behavior in certain cases where a workaround can be ... | 2021-07-07 09:38:07 | 2021-07-07 11:12:35 | 2021-07-07 11:12:35 | NONE | null | null | null | Why is useEffect called twice in React 18 with StrictMode (if I set deps to be an empty array)?
Expected behavior:
Strange behavior:
![image](https://user-images.githubusercontent.com/84848052/124736... | {'url': 'https://api.github.com/repos/facebook/react/issues/21808/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21808/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21807 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21807/labels{/name} | https://api.github.com/repos/facebook/react/issues/21807/comments | https://api.github.com/repos/facebook/react/issues/21807/events | https://github.com/facebook/react/issues/21807 | 938,630,412 | MDU6SXNzdWU5Mzg2MzA0MTI= | 21,807 | React's JSX doesn't support namespace tags How do I set `throwIfNamespace: false` | {'login': 'krishnadevz', 'id': 42638797, 'node_id': 'MDQ6VXNlcjQyNjM4Nzk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/42638797?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/krishnadevz', 'html_url': 'https://github.com/krishnadevz', 'followers_url': 'https://api.github.com/users/krishnadevz... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2021-07-07 08:26:52 | 2024-04-17 18:04:37 | 2024-04-17 18:04:37 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
Error
> ./src/components/svg/traveller.js
> SyntaxError: /home/krishnadevz/ja... | {'url': 'https://api.github.com/repos/facebook/react/issues/21807/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21807/timeline | null | not_planned | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.