url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/21089 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21089/labels{/name} | https://api.github.com/repos/facebook/react/issues/21089/comments | https://api.github.com/repos/facebook/react/issues/21089/events | https://github.com/facebook/react/pull/21089 | 840,576,338 | MDExOlB1bGxSZXF1ZXN0NjAwNDQyOTEw | 21,089 | Use Lane to track root callback priority | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4a99c5c3a780d8178d9278c29d0b7f44be6a0dce...2a8211f3d1121ba989aedbf3bca182edc8aeec33\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-25 05:37:04 | 2021-03-28 20:58:46 | 2021-03-28 20:58:46 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21089', 'html_url': 'https://github.com/facebook/react/pull/21089', 'diff_url': 'https://github.com/facebook/react/pull/21089.diff', 'patch_url': 'https://github.com/facebook/react/pull/21089.patch', 'merged_at': datetime.datetime(2021, 3, 28, 20, 58, 46)} | Instead of LanePriority.
I'm removing all uses of LanePriority so I can delete it. | {'url': 'https://api.github.com/repos/facebook/react/issues/21089/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21089/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21088 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21088/labels{/name} | https://api.github.com/repos/facebook/react/issues/21088/comments | https://api.github.com/repos/facebook/react/issues/21088/events | https://github.com/facebook/react/pull/21088 | 840,571,019 | MDExOlB1bGxSZXF1ZXN0NjAwNDM4MjU4 | 21,088 | Use highest priority lane to detect interruptions | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 148f8e497c7d37a3c7ab99f01dec2692427272b1...92415819bd3cb47a7a47c9fe3f67b576c1c259c1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-25 05:26:17 | 2021-03-25 16:36:18 | 2021-03-25 16:36:18 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21088', 'html_url': 'https://github.com/facebook/react/pull/21088', 'diff_url': 'https://github.com/facebook/react/pull/21088.diff', 'patch_url': 'https://github.com/facebook/react/pull/21088.patch', 'merged_at': datetime.datetime(2021, 3, 25, 16, 36, 17)} | Instead of LanePriority.
I'm removing all uses of LanePriority so I can delete it. | {'url': 'https://api.github.com/repos/facebook/react/issues/21088/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21088/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21087 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21087/labels{/name} | https://api.github.com/repos/facebook/react/issues/21087/comments | https://api.github.com/repos/facebook/react/issues/21087/events | https://github.com/facebook/react/pull/21087 | 840,570,484 | MDExOlB1bGxSZXF1ZXN0NjAwNDM3Nzky | 21,087 | Remove LanePriority from computeExpirationTime | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 148f8e497c7d37a3c7ab99f01dec2692427272b1...ff71116c85a5900056a1496b7f3743798029f58e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-25 05:25:15 | 2021-03-25 16:32:15 | 2021-03-25 16:32:15 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21087', 'html_url': 'https://github.com/facebook/react/pull/21087', 'diff_url': 'https://github.com/facebook/react/pull/21087.diff', 'patch_url': 'https://github.com/facebook/react/pull/21087.patch', 'merged_at': datetime.datetime(2021, 3, 25, 16, 32, 14)} | I'm removing all uses of LanePriority so I can delete it. | {'url': 'https://api.github.com/repos/facebook/react/issues/21087/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21087/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21086 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21086/labels{/name} | https://api.github.com/repos/facebook/react/issues/21086/comments | https://api.github.com/repos/facebook/react/issues/21086/events | https://github.com/facebook/react/pull/21086 | 840,570,159 | MDExOlB1bGxSZXF1ZXN0NjAwNDM3NTEw | 21,086 | Remove LanePriority from getBumpedLaneForHydration | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 148f8e497c7d37a3c7ab99f01dec2692427272b1...7e8918ad86aaf4cddd22cd492b4c7f6a0e836c2b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-25 05:24:34 | 2021-03-25 16:27:37 | 2021-03-25 16:27:37 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21086', 'html_url': 'https://github.com/facebook/react/pull/21086', 'diff_url': 'https://github.com/facebook/react/pull/21086.diff', 'patch_url': 'https://github.com/facebook/react/pull/21086.patch', 'merged_at': datetime.datetime(2021, 3, 25, 16, 27, 37)} | I'm removing all uses of LanePriority so I can delete it. | {'url': 'https://api.github.com/repos/facebook/react/issues/21086/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21086/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21083 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21083/labels{/name} | https://api.github.com/repos/facebook/react/issues/21083/comments | https://api.github.com/repos/facebook/react/issues/21083/events | https://github.com/facebook/react/pull/21083 | 840,545,553 | MDExOlB1bGxSZXF1ZXN0NjAwNDE2NTk2 | 21,083 | Entangled expired lanes with SyncLane | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 148f8e497c7d37a3c7ab99f01dec2692427272b1...d96c75780cd5460bbb7faee67c9b2a27d87e1fb6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-25 04:28:33 | 2021-03-25 16:24:50 | 2021-03-25 16:24:49 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21083', 'html_url': 'https://github.com/facebook/react/pull/21083', 'diff_url': 'https://github.com/facebook/react/pull/21083.diff', 'patch_url': 'https://github.com/facebook/react/pull/21083.patch', 'merged_at': datetime.datetime(2021, 3, 25, 16, 24, 49)} | Makes the implementation simpler. Expiration is now a special case of entanglement.
Also fixes an issue where expired lanes weren't batched with normal sync updates. (See deleted TODO comment in test.) | {'url': 'https://api.github.com/repos/facebook/react/issues/21083/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21083/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21082 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21082/labels{/name} | https://api.github.com/repos/facebook/react/issues/21082/comments | https://api.github.com/repos/facebook/react/issues/21082/events | https://github.com/facebook/react/pull/21082 | 840,353,396 | MDExOlB1bGxSZXF1ZXN0NjAwMjQ0ODIz | 21,082 | Use EventPriority to track update priority | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 148f8e497c7d37a3c7ab99f01dec2692427272b1...4b7ff7f0527b7d5ff88bb80e51d1bce8304dff02\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-24 23:50:40 | 2021-03-25 16:21:41 | 2021-03-25 16:21:41 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21082', 'html_url': 'https://github.com/facebook/react/pull/21082', 'diff_url': 'https://github.com/facebook/react/pull/21082.diff', 'patch_url': 'https://github.com/facebook/react/pull/21082.patch', 'merged_at': datetime.datetime(2021, 3, 25, 16, 21, 41)} | Instead of LanePriority. Internally, EventPriority is just a lane, so this skips an extra conversion. Since EventPriority is a "public" (to the host config) type, I was also able to remove some deep imports of the Lane module.
This gets us most of the way to deleting the LanePriority entirely. | {'url': 'https://api.github.com/repos/facebook/react/issues/21082/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21082/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21081 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21081/labels{/name} | https://api.github.com/repos/facebook/react/issues/21081/comments | https://api.github.com/repos/facebook/react/issues/21081/events | https://github.com/facebook/react/pull/21081 | 840,331,779 | MDExOlB1bGxSZXF1ZXN0NjAwMjI0MzUz | 21,081 | Add @noinline directive to getBumpedLaneForHydration | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 148f8e497c7d37a3c7ab99f01dec2692427272b1...d6c89d760424a52a90d664d1e1966c9728987466\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-24 23:34:09 | 2022-10-20 20:42:03 | 2022-10-20 20:42:03 | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/21081', 'html_url': 'https://github.com/facebook/react/pull/21081', 'diff_url': 'https://github.com/facebook/react/pull/21081.diff', 'patch_url': 'https://github.com/facebook/react/pull/21081.patch', 'merged_at': None} | **Edit**: Moving this back into draft for now; see this comment https://github.com/facebook/react/pull/21081#issuecomment-806257915
---
During compilation, `getBumpedLaneForHydration` was being inlined in a way that breaks the local `lane` variable (making it possible for that variable to have an `undefined` valu... | {'url': 'https://api.github.com/repos/facebook/react/issues/21081/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21081/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21080 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21080/labels{/name} | https://api.github.com/repos/facebook/react/issues/21080/comments | https://api.github.com/repos/facebook/react/issues/21080/events | https://github.com/facebook/react/pull/21080 | 840,278,114 | MDExOlB1bGxSZXF1ZXN0NjAwMTczNjM2 | 21,080 | React Fabric: Support passing nativeViewTag to getInspectorDataForViewAtPoint callback, for React DevTools compat | {'login': 'JoshuaGross', 'id': 70602, 'node_id': 'MDQ6VXNlcjcwNjAy', 'avatar_url': 'https://avatars.githubusercontent.com/u/70602?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JoshuaGross', 'html_url': 'https://github.com/JoshuaGross', 'followers_url': 'https://api.github.com/users/JoshuaGross/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 148f8e497c7d37a3c7ab99f01dec2692427272b1...95438258d44cefb7f13ff9639c7b840911fc564c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-24 22:54:28 | 2021-03-26 00:17:33 | 2021-03-25 23:23:40 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21080', 'html_url': 'https://github.com/facebook/react/pull/21080', 'diff_url': 'https://github.com/facebook/react/pull/21080.diff', 'patch_url': 'https://github.com/facebook/react/pull/21080.patch', 'merged_at': datetime.datetime(2021, 3, 25, 23, 23, 40)} | React Fabric: Support passing nativeViewTag to getInspectorDataForViewAtPoint callback, for React DevTools compat
## Summary
React DevTools needs a React Tag to highlight a component. Fabric tries not to expose this, but we can expose it "temporarily" ;) for React DevTools compat.
React DevTools will need to b... | {'url': 'https://api.github.com/repos/facebook/react/issues/21080/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21080/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21079 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21079/labels{/name} | https://api.github.com/repos/facebook/react/issues/21079/comments | https://api.github.com/repos/facebook/react/issues/21079/events | https://github.com/facebook/react/pull/21079 | 840,155,460 | MDExOlB1bGxSZXF1ZXN0NjAwMDYyMDM5 | 21,079 | Proposed new Suspense layout effect semantics | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | {'login': 'rickhanlonii', 'id': 2440089.0, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanl... | [{'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlo... | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b48b38af68c27fd401fe4b923a8fa0b229693cd4...8c191e84eab2c0d1d48d9589a04152d44ce080a8\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-24 20:52:45 | 2021-04-06 13:21:05 | 2021-04-06 13:21:03 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21079', 'html_url': 'https://github.com/facebook/react/pull/21079', 'diff_url': 'https://github.com/facebook/react/pull/21079.diff', 'patch_url': 'https://github.com/facebook/react/pull/21079.patch', 'merged_at': datetime.datetime(2021, 4, 6, 13, 21, 3)} | This PR contains a proposed change to layout effect semantics within Suspense subtrees: If a component mounts within a Suspense boundary and is later hidden (because of something else suspending) React will cleanup that component’s layout effects (including React-managed refs).
This change will hopefully fix existin... | {'url': 'https://api.github.com/repos/facebook/react/issues/21079/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/21079/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21078 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21078/labels{/name} | https://api.github.com/repos/facebook/react/issues/21078/comments | https://api.github.com/repos/facebook/react/issues/21078/events | https://github.com/facebook/react/issues/21078 | 840,056,221 | MDU6SXNzdWU4NDAwNTYyMjE= | 21,078 | Bug: Incorrect error message | {'login': 'toschlog', 'id': 25090868, 'node_id': 'MDQ6VXNlcjI1MDkwODY4', 'avatar_url': 'https://avatars.githubusercontent.com/u/25090868?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/toschlog', 'html_url': 'https://github.com/toschlog', 'followers_url': 'https://api.github.com/users/toschlog/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This is a lint error message, so you don't need to send the whole file. You just need to send the component in which this happens.",
"Ok. Can I submit a source file privately? \r\n\r\nI'm able to make the error go away by adding a lot of eslint-disable-next-line comments, so that's good.\r\n\r\n\r\n",
"You c... | 2021-03-24 18:55:19 | 2024-04-17 18:04:52 | 2024-04-17 18:04:51 | NONE | null | null | null | I'm getting this error message:
React Hook "useStyles" is called conditionally. React Hooks must be called in the exact same order in every component render
However, I'm pretty darn sure that I'm not actually calling useStyles conditionally. Also, the error messages come and go if I comment out unrelated code.... | {'url': 'https://api.github.com/repos/facebook/react/issues/21078/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21078/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/21077 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21077/labels{/name} | https://api.github.com/repos/facebook/react/issues/21077/comments | https://api.github.com/repos/facebook/react/issues/21077/events | https://github.com/facebook/react/pull/21077 | 840,037,875 | MDExOlB1bGxSZXF1ZXN0NTk5OTU5ODEw | 21,077 | Add pointerenter/leave priorities | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fb8c1917e9985f83032f642e5db8b9abf089653e...4f5582fa5b2471770a86ca3e1ac89428d4759130\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-24 18:35:31 | 2022-11-29 22:23:31 | 2021-03-24 19:57:17 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21077', 'html_url': 'https://github.com/facebook/react/pull/21077', 'diff_url': 'https://github.com/facebook/react/pull/21077.diff', 'patch_url': 'https://github.com/facebook/react/pull/21077.patch', 'merged_at': datetime.datetime(2021, 3, 24, 19, 57, 17)} | Fixes https://github.com/facebook/react/issues/16376.
I already added the rest but I missed these two. | {'url': 'https://api.github.com/repos/facebook/react/issues/21077/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21077/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21076 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21076/labels{/name} | https://api.github.com/repos/facebook/react/issues/21076/comments | https://api.github.com/repos/facebook/react/issues/21076/events | https://github.com/facebook/react/pull/21076 | 839,935,639 | MDExOlB1bGxSZXF1ZXN0NTk5ODY5NTc4 | 21,076 | Remove server side lower casing warning | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fb8c1917e9985f83032f642e5db8b9abf089653e...e2130df6447bb5de6ef95bfada9d8a8104f05bf2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-24 17:02:07 | 2021-04-01 00:57:17 | 2021-04-01 00:57:17 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21076', 'html_url': 'https://github.com/facebook/react/pull/21076', 'diff_url': 'https://github.com/facebook/react/pull/21076.diff', 'patch_url': 'https://github.com/facebook/react/pull/21076.patch', 'merged_at': None} | It's the only thing (outside selected value which has its own complexities with suspense) that's contextual. It's not worth adding a host config at runtime for this. So I'm removing it for parity.
We have this warning on the client. We don't have other warnings like ancestor nesting on the server anyway. We can inst... | {'url': 'https://api.github.com/repos/facebook/react/issues/21076/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21076/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21075 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21075/labels{/name} | https://api.github.com/repos/facebook/react/issues/21075/comments | https://api.github.com/repos/facebook/react/issues/21075/events | https://github.com/facebook/react/issues/21075 | 839,927,904 | MDU6SXNzdWU4Mzk5Mjc5MDQ= | 21,075 | Feature Suggestion: Pass React Hook factory dependencies as arguments to the factory | {'login': 'yassine', 'id': 2080345, 'node_id': 'MDQ6VXNlcjIwODAzNDU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2080345?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yassine', 'html_url': 'https://github.com/yassine', 'followers_url': 'https://api.github.com/users/yassine/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"It's intentional that Hooks don't work like this, and instead nudge you towards writing things in the render scope. So that it's always easy to capture more props/state if needed without changing a bunch of signatures. Or people microoptimizing by trying to move the closures out. I understand why you're trying to ... | 2021-03-24 16:53:08 | 2021-03-24 17:12:44 | 2021-03-24 16:56:54 | NONE | null | null | null | Currently, there is no way for accessing the array dependencies of a given React Hook in an optimal way (Function.bind can help but yet it is not optimal). Passing the array of dependencies to the hook factories such as in useMemo, useCallback, useLayoutEffect can be handy at many sides:
- Putting the factory outsid... | {'url': 'https://api.github.com/repos/facebook/react/issues/21075/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21075/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21074 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21074/labels{/name} | https://api.github.com/repos/facebook/react/issues/21074/comments | https://api.github.com/repos/facebook/react/issues/21074/events | https://github.com/facebook/react/pull/21074 | 839,880,873 | MDExOlB1bGxSZXF1ZXN0NTk5ODIzNzAy | 21,074 | fix(fast-refresh): fix #20417 | {'login': 'Bnaya', 'id': 1304862, 'node_id': 'MDQ6VXNlcjEzMDQ4NjI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1304862?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Bnaya', 'html_url': 'https://github.com/Bnaya', 'followers_url': 'https://api.github.com/users/Bnaya/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 7b84dbd1697609d4df5931422c9591fe62022cb9...856e5e2ab54d5a5379f21e3ba77ec5eaba3ce1f5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-24 16:03:32 | 2021-03-28 06:14:38 | 2021-03-28 06:14:38 | NONE | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/21074', 'html_url': 'https://github.com/facebook/react/pull/21074', 'diff_url': 'https://github.com/facebook/react/pull/21074.diff', 'patch_url': 'https://github.com/facebook/react/pull/21074.patch', 'merged_at': None} | When no signatures on both sides, consider as not equal signature,
forcing remount and not refresh
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are ... | {'url': 'https://api.github.com/repos/facebook/react/issues/21074/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21074/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21073 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21073/labels{/name} | https://api.github.com/repos/facebook/react/issues/21073/comments | https://api.github.com/repos/facebook/react/issues/21073/events | https://github.com/facebook/react/pull/21073 | 839,876,994 | MDExOlB1bGxSZXF1ZXN0NTk5ODIwMzc2 | 21,073 | Don't use nested objects to "namespace" namespace constants | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"looks like you missed some.",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 7b84dbd1697609d4df5931422c9591fe62022cb9...d510162d1dca003a5162ba3f9aa6392a6ad1b5b2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as... | 2021-03-24 15:59:43 | 2021-03-24 16:58:23 | 2021-03-24 16:58:23 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21073', 'html_url': 'https://github.com/facebook/react/pull/21073', 'diff_url': 'https://github.com/facebook/react/pull/21073.diff', 'patch_url': 'https://github.com/facebook/react/pull/21073.patch', 'merged_at': datetime.datetime(2021, 3, 24, 16, 58, 23)} | Not sure if closure is smart enough but as a pattern we don't gamble. | {'url': 'https://api.github.com/repos/facebook/react/issues/21073/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 1, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21073/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21072 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21072/labels{/name} | https://api.github.com/repos/facebook/react/issues/21072/comments | https://api.github.com/repos/facebook/react/issues/21072/events | https://github.com/facebook/react/pull/21072 | 839,743,065 | MDExOlB1bGxSZXF1ZXN0NTk5NzA3MjUx | 21,072 | Make time-slicing opt-in | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | {'login': 'rickhanlonii', 'id': 2440089.0, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanl... | [{'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlo... | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8a4a59c725a9cc2defafd7ea4d2ae46dadd1daec...7e9bb7bfa1942335506f28658cbcec699636ef41\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-24 13:48:31 | 2021-04-10 22:17:35 | 2021-04-09 23:50:10 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21072', 'html_url': 'https://github.com/facebook/react/pull/21072', 'diff_url': 'https://github.com/facebook/react/pull/21072.diff', 'patch_url': 'https://github.com/facebook/react/pull/21072.patch', 'merged_at': datetime.datetime(2021, 4, 9, 23, 50, 10)} | ## Overview
This PR adds a new flag to synchronously flush updates in a task by default.
This has the practical effect of **making time-slicing optional in the next major version**.
### Motivation
As we've iterated on concurrent features like `Suspense` and `startTransition`, we've seen the benefits of [Tim... | {'url': 'https://api.github.com/repos/facebook/react/issues/21072/reactions', 'total_count': 15, '+1': 11, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 4} | https://api.github.com/repos/facebook/react/issues/21072/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21071 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21071/labels{/name} | https://api.github.com/repos/facebook/react/issues/21071/comments | https://api.github.com/repos/facebook/react/issues/21071/events | https://github.com/facebook/react/issues/21071 | 839,730,732 | MDU6SXNzdWU4Mzk3MzA3MzI= | 21,071 | Bug: | {'login': 'ShravanSunder', 'id': 5294949, 'node_id': 'MDQ6VXNlcjUyOTQ5NDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5294949?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ShravanSunder', 'html_url': 'https://github.com/ShravanSunder', 'followers_url': 'https://api.github.com/users/Shravan... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"was caused by using a hook within a hook. closing due to user error"
] | 2021-03-24 13:35:17 | 2021-03-24 13:48:23 | 2021-03-24 13:48:23 | NONE | null | null | null | React version: 17.x; yarn package latest
```
react-dom.development.js?61bb:15225 Uncaught Error: Should have a queue. This is likely a bug in React. Please file an issue.
at updateReducer (react-dom.development.js?61bb:15225)
at updateState (react-dom.development.js?61bb:15641)
at Object.useState (re... | {'url': 'https://api.github.com/repos/facebook/react/issues/21071/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21071/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21070 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21070/labels{/name} | https://api.github.com/repos/facebook/react/issues/21070/comments | https://api.github.com/repos/facebook/react/issues/21070/events | https://github.com/facebook/react/issues/21070 | 839,591,050 | MDU6SXNzdWU4Mzk1OTEwNTA= | 21,070 | asdf | {'login': 'ravikrishnudu', 'id': 52109411, 'node_id': 'MDQ6VXNlcjUyMTA5NDEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/52109411?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ravikrishnudu', 'html_url': 'https://github.com/ravikrishnudu', 'followers_url': 'https://api.github.com/users/ravik... | [{'id': 2392325672, 'node_id': 'MDU6TGFiZWwyMzkyMzI1Njcy', 'url': 'https://api.github.com/repos/facebook/react/labels/invalid', 'name': 'invalid', 'color': 'ffefc4', 'default': True, 'description': ''}] | closed | false | null | [] | null | [] | 2021-03-24 10:44:57 | 2021-03-24 10:55:31 | 2021-03-24 10:54:09 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/21070/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21070/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21069 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21069/labels{/name} | https://api.github.com/repos/facebook/react/issues/21069/comments | https://api.github.com/repos/facebook/react/issues/21069/events | https://github.com/facebook/react/issues/21069 | 839,591,045 | MDU6SXNzdWU4Mzk1OTEwNDU= | 21,069 | asdf | {'login': 'ravikrishnudu', 'id': 52109411, 'node_id': 'MDQ6VXNlcjUyMTA5NDEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/52109411?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ravikrishnudu', 'html_url': 'https://github.com/ravikrishnudu', 'followers_url': 'https://api.github.com/users/ravik... | [{'id': 2392325672, 'node_id': 'MDU6TGFiZWwyMzkyMzI1Njcy', 'url': 'https://api.github.com/repos/facebook/react/labels/invalid', 'name': 'invalid', 'color': 'ffefc4', 'default': True, 'description': ''}] | closed | false | null | [] | null | [] | 2021-03-24 10:44:57 | 2021-03-24 10:54:55 | 2021-03-24 10:54:06 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/21069/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21069/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21068 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21068/labels{/name} | https://api.github.com/repos/facebook/react/issues/21068/comments | https://api.github.com/repos/facebook/react/issues/21068/events | https://github.com/facebook/react/issues/21068 | 839,591,043 | MDU6SXNzdWU4Mzk1OTEwNDM= | 21,068 | asdf | {'login': 'ravikrishnudu', 'id': 52109411, 'node_id': 'MDQ6VXNlcjUyMTA5NDEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/52109411?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ravikrishnudu', 'html_url': 'https://github.com/ravikrishnudu', 'followers_url': 'https://api.github.com/users/ravik... | [{'id': 2392325672, 'node_id': 'MDU6TGFiZWwyMzkyMzI1Njcy', 'url': 'https://api.github.com/repos/facebook/react/labels/invalid', 'name': 'invalid', 'color': 'ffefc4', 'default': True, 'description': ''}] | closed | false | null | [] | null | [] | 2021-03-24 10:44:57 | 2021-03-24 10:54:50 | 2021-03-24 10:54:08 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/21068/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21068/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21067 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21067/labels{/name} | https://api.github.com/repos/facebook/react/issues/21067/comments | https://api.github.com/repos/facebook/react/issues/21067/events | https://github.com/facebook/react/issues/21067 | 839,591,034 | MDU6SXNzdWU4Mzk1OTEwMzQ= | 21,067 | asdf | {'login': 'ravikrishnudu', 'id': 52109411, 'node_id': 'MDQ6VXNlcjUyMTA5NDEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/52109411?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ravikrishnudu', 'html_url': 'https://github.com/ravikrishnudu', 'followers_url': 'https://api.github.com/users/ravik... | [{'id': 2392325672, 'node_id': 'MDU6TGFiZWwyMzkyMzI1Njcy', 'url': 'https://api.github.com/repos/facebook/react/labels/invalid', 'name': 'invalid', 'color': 'ffefc4', 'default': True, 'description': ''}] | closed | false | null | [] | null | [] | 2021-03-24 10:44:56 | 2021-03-24 10:54:23 | 2021-03-24 10:54:11 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/21067/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21067/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21066 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21066/labels{/name} | https://api.github.com/repos/facebook/react/issues/21066/comments | https://api.github.com/repos/facebook/react/issues/21066/events | https://github.com/facebook/react/issues/21066 | 839,591,008 | MDU6SXNzdWU4Mzk1OTEwMDg= | 21,066 | asdf | {'login': 'ravikrishnudu', 'id': 52109411, 'node_id': 'MDQ6VXNlcjUyMTA5NDEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/52109411?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ravikrishnudu', 'html_url': 'https://github.com/ravikrishnudu', 'followers_url': 'https://api.github.com/users/ravik... | [{'id': 2392325672, 'node_id': 'MDU6TGFiZWwyMzkyMzI1Njcy', 'url': 'https://api.github.com/repos/facebook/react/labels/invalid', 'name': 'invalid', 'color': 'ffefc4', 'default': True, 'description': ''}] | closed | false | null | [] | null | [] | 2021-03-24 10:44:55 | 2021-03-24 10:54:19 | 2021-03-24 10:54:12 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/21066/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21066/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21065 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21065/labels{/name} | https://api.github.com/repos/facebook/react/issues/21065/comments | https://api.github.com/repos/facebook/react/issues/21065/events | https://github.com/facebook/react/pull/21065 | 839,327,068 | MDExOlB1bGxSZXF1ZXN0NTk5MzU5NDky | 21,065 | Make opaque EventPriority type a Lane internally | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 7b84dbd1697609d4df5931422c9591fe62022cb9...4f09483ea8a079768917576e68275ce619b462e5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-24 04:13:06 | 2021-03-24 17:00:33 | 2021-03-24 16:55:24 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21065', 'html_url': 'https://github.com/facebook/react/pull/21065', 'diff_url': 'https://github.com/facebook/react/pull/21065.diff', 'patch_url': 'https://github.com/facebook/react/pull/21065.patch', 'merged_at': datetime.datetime(2021, 3, 24, 16, 55, 24)} | Instead of LanePriority, we can use a Lane and skip the extra conversion. Eventually I want to get rid of LanePriority completely. | {'url': 'https://api.github.com/repos/facebook/react/issues/21065/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21065/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21064 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21064/labels{/name} | https://api.github.com/repos/facebook/react/issues/21064/comments | https://api.github.com/repos/facebook/react/issues/21064/events | https://github.com/facebook/react/issues/21064 | 839,314,520 | MDU6SXNzdWU4MzkzMTQ1MjA= | 21,064 | Bug: `display: none` on react component with linearGradient svg also affects svgs outside component | {'login': 'kimbaudi', 'id': 1864092, 'node_id': 'MDQ6VXNlcjE4NjQwOTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1864092?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kimbaudi', 'html_url': 'https://github.com/kimbaudi', 'followers_url': 'https://api.github.com/users/kimbaudi/followers', '... | [{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20DOM', 'name': 'Component: DOM', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/faceb... | closed | false | null | [] | null | [
"I think I have an idea why I am getting this issue. It is probably because using linearGradient in svgs require `id` so rendering multiple svgs using linearGradient will render multiple elements with the same id. I'll need to see if passing unique id as prop to the svgs w/ linearGradient solves the issue before I ... | 2021-03-24 03:45:34 | 2021-06-20 08:12:09 | 2021-03-24 14:36:08 | NONE | null | null | null | I have a svg react component with linearGradient that I render in my Header component and my main component. When I set `display: none` style to the Header component, I expect the svg in the Header component to be hidden and the svg in the main component to be visible. When I use svg without linearGradient, I get the e... | {'url': 'https://api.github.com/repos/facebook/react/issues/21064/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21064/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21063 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21063/labels{/name} | https://api.github.com/repos/facebook/react/issues/21063/comments | https://api.github.com/repos/facebook/react/issues/21063/events | https://github.com/facebook/react/pull/21063 | 839,277,533 | MDExOlB1bGxSZXF1ZXN0NTk5MzE4NDk4 | 21,063 | Fail build on deep requires in npm packages | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2c9d8efc8e8202929d3c737459050205f2848d79...495df9d0a162f48631ab0a01d8a887e8d1be49b6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-24 02:16:27 | 2021-03-24 02:43:56 | 2021-03-24 02:43:56 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21063', 'html_url': 'https://github.com/facebook/react/pull/21063', 'diff_url': 'https://github.com/facebook/react/pull/21063.diff', 'patch_url': 'https://github.com/facebook/react/pull/21063.patch', 'merged_at': datetime.datetime(2021, 3, 24, 2, 43, 55)} | This is to make it easier to spot when you need a solution like https://github.com/facebook/react/pull/21062.
Verified by importing from `react-reconciler/src/ReactEventPriorities` in the noop renderer instead of `react-reconciler/constants`. Previously this would leave a `require('react-reconciler/src/ReactEventPri... | {'url': 'https://api.github.com/repos/facebook/react/issues/21063/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21063/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21062 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21062/labels{/name} | https://api.github.com/repos/facebook/react/issues/21062/comments | https://api.github.com/repos/facebook/react/issues/21062/events | https://github.com/facebook/react/pull/21062 | 839,265,198 | MDExOlB1bGxSZXF1ZXN0NTk5MzA4MTM2 | 21,062 | Add react-reconciler/constants entry point | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d0eaf782930b6e6c575f50bf688e667b9f6795b7...cb2c3cac95b4eb7dbb483fcd39baa59157e31d7a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-24 01:50:34 | 2021-03-24 02:13:44 | 2021-03-24 02:13:44 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21062', 'html_url': 'https://github.com/facebook/react/pull/21062', 'diff_url': 'https://github.com/facebook/react/pull/21062.diff', 'patch_url': 'https://github.com/facebook/react/pull/21062.patch', 'merged_at': datetime.datetime(2021, 3, 24, 2, 13, 44)} | Follow-up to https://github.com/facebook/react/pull/21060. Fixes the README instructions too. | {'url': 'https://api.github.com/repos/facebook/react/issues/21062/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21062/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21061 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21061/labels{/name} | https://api.github.com/repos/facebook/react/issues/21061/comments | https://api.github.com/repos/facebook/react/issues/21061/events | https://github.com/facebook/react/pull/21061 | 839,043,333 | MDExOlB1bGxSZXF1ZXN0NTk5MTE4NTM2 | 21,061 | Delete SyncBatchedLane | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 25bfa287f6c49950d8ea16f542716835683442d6...7fe6a732eb384ce7e8bd8c6798a8a72d6c6cc82a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-23 19:21:01 | 2021-03-24 19:04:23 | 2021-03-24 19:04:19 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21061', 'html_url': 'https://github.com/facebook/react/pull/21061', 'diff_url': 'https://github.com/facebook/react/pull/21061.diff', 'patch_url': 'https://github.com/facebook/react/pull/21061.patch', 'merged_at': datetime.datetime(2021, 3, 24, 19, 4, 19)} | ## Overview
This is no longer needed - we deleted the blocking root. | {'url': 'https://api.github.com/repos/facebook/react/issues/21061/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21061/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21060 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21060/labels{/name} | https://api.github.com/repos/facebook/react/issues/21060/comments | https://api.github.com/repos/facebook/react/issues/21060/events | https://github.com/facebook/react/pull/21060 | 839,003,908 | MDExOlB1bGxSZXF1ZXN0NTk5MDg2MDUx | 21,060 | Move priorities to separate import to break cycle | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 25bfa287f6c49950d8ea16f542716835683442d6...0557a49dc7dc70d663693faddd5a8421d9e973ca\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-23 18:27:34 | 2021-03-24 01:50:48 | 2021-03-23 20:57:28 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21060', 'html_url': 'https://github.com/facebook/react/pull/21060', 'diff_url': 'https://github.com/facebook/react/pull/21060.diff', 'patch_url': 'https://github.com/facebook/react/pull/21060.patch', 'merged_at': datetime.datetime(2021, 3, 23, 20, 57, 28)} | Doesn't change any behavior. Just moves stuff around.
***
The event priority constants exported by the reconciler package are meant to be used by the reconciler (host config) itself. So it doesn't make sense to export them from a module that requires them.
To break the cycle, we can move them to a separate mod... | {'url': 'https://api.github.com/repos/facebook/react/issues/21060/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21060/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21059 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21059/labels{/name} | https://api.github.com/repos/facebook/react/issues/21059/comments | https://api.github.com/repos/facebook/react/issues/21059/events | https://github.com/facebook/react/issues/21059 | 838,960,244 | MDU6SXNzdWU4Mzg5NjAyNDQ= | 21,059 | Bug: Nondeterministic first render | {'login': 'bennettdams', 'id': 29319414, 'node_id': 'MDQ6VXNlcjI5MzE5NDE0', 'avatar_url': 'https://avatars.githubusercontent.com/u/29319414?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bennettdams', 'html_url': 'https://github.com/bennettdams', 'followers_url': 'https://api.github.com/users/bennettdams... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I would not expect this to be related to batched updates, since generally effects execute _after_ paint. Although I think there might be some cases where we flush them more eagerly than necessary. I would appreciate if someone could look at:\r\n\r\n- Whether this happens in 16.x versions or is new to 17.x\r\n- Wha... | 2021-03-23 17:33:29 | 2022-03-30 01:29:26 | 2022-03-30 01:29:26 | NONE | null | null | null | It is possible that this is not a bug, but rather expected - I couldn't find any material on the internet for this particular use case though.
React version: v17.0.1
*TL;DR React sometimes renders a loading state and sometimes not, without changes in the UI. Maybe this has something to do with [batched updates]... | {'url': 'https://api.github.com/repos/facebook/react/issues/21059/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21059/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21058 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21058/labels{/name} | https://api.github.com/repos/facebook/react/issues/21058/comments | https://api.github.com/repos/facebook/react/issues/21058/events | https://github.com/facebook/react/issues/21058 | 838,934,219 | MDU6SXNzdWU4Mzg5MzQyMTk= | 21,058 | Bug: Cursor jumps to the end of input after value refresh | {'login': 'IlyaHalsky', 'id': 7192543, 'node_id': 'MDQ6VXNlcjcxOTI1NDM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7192543?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/IlyaHalsky', 'html_url': 'https://github.com/IlyaHalsky', 'followers_url': 'https://api.github.com/users/IlyaHalsky/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"That's just normal browser behaviour. You need to restore cursor position manually",
"I've tried doing so using \r\n```typescript\r\nfunction useSelectionEditableInput(inputElement: RefObject<HTMLInputElement>): (from: number, to: number) => void {\r\n const [selectionState, setSelectionState] = useState<Sele... | 2021-03-23 17:02:28 | 2021-03-24 12:50:54 | 2021-03-24 12:50:54 | NONE | null | null | null | I've ran into this issue when was trying to implement date input, in which you can adjust date by using arrow up and arrow down keys. When cursor is on month I need to add or subtract one by pressing up and down keys. When cursor is on day, same thing with days. Listed below code should work in theory, but doesn't beha... | {'url': 'https://api.github.com/repos/facebook/react/issues/21058/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21058/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21057 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21057/labels{/name} | https://api.github.com/repos/facebook/react/issues/21057/comments | https://api.github.com/repos/facebook/react/issues/21057/events | https://github.com/facebook/react/issues/21057 | 838,594,630 | MDU6SXNzdWU4Mzg1OTQ2MzA= | 21,057 | Bug: useState with class as initial state throws an error | {'login': 'jneuendorf', 'id': 6906734, 'node_id': 'MDQ6VXNlcjY5MDY3MzQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6906734?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jneuendorf', 'html_url': 'https://github.com/jneuendorf', 'followers_url': 'https://api.github.com/users/jneuendorf/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 710375792, 'node_id': 'MDU6T... | open | false | null | [] | null | [
"I don't consider this a bug.\r\n\r\nAs the issue description mentions, `useState` supports two formats:\r\n1. Eagerly initialize the value (e.g. `useState('value')`)\r\n2. [Lazily initialize the value](https://reactjs.org/docs/hooks-reference.html#lazy-initial-state) with a function (e.g. `useState(() => 'value')`... | 2021-03-23 10:51:17 | 2021-03-31 02:37:37 | null | NONE | null | null | null | Using a JavaScript class as initial state in `useState` throws an error. This is because `mountState` check if the initial state is a function by `typeof initialState === 'function'` and classes are technically functions. However since ES6+, I feel like most developers don't consider classes functions because of the le... | {'url': 'https://api.github.com/repos/facebook/react/issues/21057/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21057/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/21056 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21056/labels{/name} | https://api.github.com/repos/facebook/react/issues/21056/comments | https://api.github.com/repos/facebook/react/issues/21056/events | https://github.com/facebook/react/pull/21056 | 838,315,972 | MDExOlB1bGxSZXF1ZXN0NTk4NTE2NDkw | 21,056 | [Fizz] Expose callbacks in options for when various stages of the content is done | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 25bfa287f6c49950d8ea16f542716835683442d6...b28626fa21ee4fcf61ec790bcc237effd0db89fd\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-23 03:34:20 | 2021-09-14 21:28:17 | 2021-03-23 18:39:38 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21056', 'html_url': 'https://github.com/facebook/react/pull/21056', 'diff_url': 'https://github.com/facebook/react/pull/21056.diff', 'patch_url': 'https://github.com/facebook/react/pull/21056.patch', 'merged_at': datetime.datetime(2021, 3, 23, 18, 39, 38)} | __onError__ is called when an error happens anywhere in the tree. It can be called multiple times if it's not a fatal error. This can be used for logging or setting a status code of a request.
__onCompleteAll__ is called when all pending work is done but it may not have flushed yet. If you don't want to incrementall... | {'url': 'https://api.github.com/repos/facebook/react/issues/21056/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21056/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21055 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21055/labels{/name} | https://api.github.com/repos/facebook/react/issues/21055/comments | https://api.github.com/repos/facebook/react/issues/21055/events | https://github.com/facebook/react/issues/21055 | 838,177,756 | MDU6SXNzdWU4MzgxNzc3NTY= | 21,055 | Bug: Lazy loading a component throws Unchaught undefined | {'login': 'zenstok', 'id': 42945679, 'node_id': 'MDQ6VXNlcjQyOTQ1Njc5', 'avatar_url': 'https://avatars.githubusercontent.com/u/42945679?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zenstok', 'html_url': 'https://github.com/zenstok', 'followers_url': 'https://api.github.com/users/zenstok/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"We can't guess without a repro. My guess is something was buggy in your code but the bug was accidentally being suppressed, and now it's more visible. I can't say more without having some code to run.",
"This looks similar, where the user mistake is forgetting to actually return an import.\r\nhttps://github.com/... | 2021-03-22 23:15:57 | 2022-12-08 14:05:58 | 2021-03-24 19:40:23 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.2
## Steps To Reproduce
1. Upgrade from React 16 to Re... | {'url': 'https://api.github.com/repos/facebook/react/issues/21055/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 3} | https://api.github.com/repos/facebook/react/issues/21055/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21054 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21054/labels{/name} | https://api.github.com/repos/facebook/react/issues/21054/comments | https://api.github.com/repos/facebook/react/issues/21054/events | https://github.com/facebook/react/pull/21054 | 838,161,980 | MDExOlB1bGxSZXF1ZXN0NTk4Mzg1NTc5 | 21,054 | [Fizz] Remove already completed comment | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6c3202b1e1a4382b91de4fdc3b9bc9ed7a77619b...82b733e25f1170e8eed4e920fbf701b566a27ffd\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-22 22:40:54 | 2021-03-22 22:44:38 | 2021-03-22 22:41:23 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21054', 'html_url': 'https://github.com/facebook/react/pull/21054', 'diff_url': 'https://github.com/facebook/react/pull/21054.diff', 'patch_url': 'https://github.com/facebook/react/pull/21054.patch', 'merged_at': datetime.datetime(2021, 3, 22, 22, 41, 23)} | I already did this in #21027. | {'url': 'https://api.github.com/repos/facebook/react/issues/21054/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21054/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21053 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21053/labels{/name} | https://api.github.com/repos/facebook/react/issues/21053/comments | https://api.github.com/repos/facebook/react/issues/21053/events | https://github.com/facebook/react/issues/21053 | 838,130,529 | MDU6SXNzdWU4MzgxMzA1Mjk= | 21,053 | Bug: This may not be a bug: eslint(react-hooks/exhaustive-deps) complaining doest make sense. | {'login': 'nadeeravista', 'id': 29170666, 'node_id': 'MDQ6VXNlcjI5MTcwNjY2', 'avatar_url': 'https://avatars.githubusercontent.com/u/29170666?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nadeeravista', 'html_url': 'https://github.com/nadeeravista', 'followers_url': 'https://api.github.com/users/nadeerav... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"> I just need to listen to `gross` and set the `net` value using `setValue`. The Eslint forcing me to add both `getValue` and `setValue`. \r\n\r\nThe lint rule may be getting tripped up because you've defined `gross` in out the outer scope and the inner scope. This might be something you want to avoid since it can... | 2021-03-22 21:41:42 | 2021-03-23 01:53:47 | 2021-03-22 21:48:48 | NONE | null | null | null | This is related to react-hook Eslint. Kindly note following code is an example code.
I just need to listen to `gross` and set the `net` value using `setValue`. The Eslint forcing me to add both `getValue` and `setValue`.
In the aspect of clean code, if we force, isn't this linter makes the code more confusing. it'... | {'url': 'https://api.github.com/repos/facebook/react/issues/21053/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21053/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21052 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21052/labels{/name} | https://api.github.com/repos/facebook/react/issues/21052/comments | https://api.github.com/repos/facebook/react/issues/21052/events | https://github.com/facebook/react/pull/21052 | 838,095,162 | MDExOlB1bGxSZXF1ZXN0NTk4MzI5NTE0 | 21,052 | React 17.0.2 Changelog | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6c3202b1e1a4382b91de4fdc3b9bc9ed7a77619b...005b4fcd9d6aeeba065aa3309dea44e4df0a1493\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-22 20:45:48 | 2022-11-29 22:23:32 | 2021-03-22 21:57:59 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21052', 'html_url': 'https://github.com/facebook/react/pull/21052', 'diff_url': 'https://github.com/facebook/react/pull/21052.diff', 'patch_url': 'https://github.com/facebook/react/pull/21052.patch', 'merged_at': datetime.datetime(2021, 3, 22, 21, 57, 59)} | ## 17.0.2 (March 22, 2020)
### React DOM
* Remove an unused dependency to address the [`SharedArrayBuffer` cross-origin isolation warning](https://developer.chrome.com/blog/enabling-shared-array-buffer/). ([@koba04](https://github.com/koba04) and [@bvaughn](https://github.com/bvaughn) in [#20831](https://github.c... | {'url': 'https://api.github.com/repos/facebook/react/issues/21052/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21052/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21051 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21051/labels{/name} | https://api.github.com/repos/facebook/react/issues/21051/comments | https://api.github.com/repos/facebook/react/issues/21051/events | https://github.com/facebook/react/pull/21051 | 838,082,876 | MDExOlB1bGxSZXF1ZXN0NTk4MzE5MTY5 | 21,051 | [Not for Merge] React 17.0.2 | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/21051/builds/111932) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on comm... | 2021-03-22 20:28:03 | 2021-03-23 16:08:48 | 2021-03-23 16:08:48 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21051', 'html_url': 'https://github.com/facebook/react/pull/21051', 'diff_url': 'https://github.com/facebook/react/pull/21051.diff', 'patch_url': 'https://github.com/facebook/react/pull/21051.patch', 'merged_at': None} | Running CI for the release. | {'url': 'https://api.github.com/repos/facebook/react/issues/21051/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21051/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21050 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21050/labels{/name} | https://api.github.com/repos/facebook/react/issues/21050/comments | https://api.github.com/repos/facebook/react/issues/21050/events | https://github.com/facebook/react/issues/21050 | 837,838,917 | MDU6SXNzdWU4Mzc4Mzg5MTc= | 21,050 | Bug: setValue hooks not working! | {'login': 'berkbaski', 'id': 25839586, 'node_id': 'MDQ6VXNlcjI1ODM5NTg2', 'avatar_url': 'https://avatars.githubusercontent.com/u/25839586?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/berkbaski', 'html_url': 'https://github.com/berkbaski', 'followers_url': 'https://api.github.com/users/berkbaski/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'berkbaski', 'id': 25839586.0, 'node_id': 'MDQ6VXNlcjI1ODM5NTg2', 'avatar_url': 'https://avatars.githubusercontent.com/u/25839586?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/berkbaski', 'html_url': 'https://github.com/berkbaski', 'followers_url': 'https://api.github.com/users/berkbaski/follo... | [{'login': 'berkbaski', 'id': 25839586, 'node_id': 'MDQ6VXNlcjI1ODM5NTg2', 'avatar_url': 'https://avatars.githubusercontent.com/u/25839586?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/berkbaski', 'html_url': 'https://github.com/berkbaski', 'followers_url': 'https://api.github.com/users/berkbaski/follow... | null | [
"it's still not working when given static value.\r\n\r\n\r\n![Screen Shot 2021-03-22 at 18 29 36](https://user-images.githubusercontent.com/25839586/112015231-aeaffd80-8b3c-11e... | 2021-03-22 15:26:57 | 2021-03-24 13:04:58 | 2021-03-22 17:13:06 | NONE | null | null | null | Firstly, so easy! I was execute the setMyLocation function with values.
Secondly, i was write a console.log and then value still null.
ABSOLUTELY I didn't understand.
React version: 16.13.1
## Steps To Reproduce
![Screen Shot 2021-03-22 at 18 13 31](https://user-images.githubusercontent.com/25839586/112014... | {'url': 'https://api.github.com/repos/facebook/react/issues/21050/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21050/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21049 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21049/labels{/name} | https://api.github.com/repos/facebook/react/issues/21049/comments | https://api.github.com/repos/facebook/react/issues/21049/events | https://github.com/facebook/react/issues/21049 | 837,621,263 | MDU6SXNzdWU4Mzc2MjEyNjM= | 21,049 | Bug: `onMouseEnter` triggered twice on target when there's space around it, and ReactDOM.createPortal is used to render something else | {'login': 'benoitgrelard', 'id': 1539897, 'node_id': 'MDQ6VXNlcjE1Mzk4OTc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1539897?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/benoitgrelard', 'html_url': 'https://github.com/benoitgrelard', 'followers_url': 'https://api.github.com/users/benoitg... | [{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20DOM', 'name': 'Component: DOM', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/faceb... | open | false | null | [] | null | [
"A few more things:\r\n\r\nIt seems perhaps Fragment has a role here too. If you update the previous sandbox and replace the fragment with a `div` the bug is gone.\r\n\r\nHowever, I think there are other considerations too.\r\nFor example, this doesn't have the bug:\r\n\r\n```tsx\r\n <>\r\n <div>\r\n ... | 2021-03-22 11:25:21 | 2024-04-11 04:03:24 | null | NONE | null | null | null | React version: 17
## Steps To Reproduce
1. Hover the button
2. Note the double log produced
Link to code example: https://codesandbox.io/s/react-mouseenter-bug-uyswr?file=/src/App.js
## The current behavior
The `onMouseEnter` is triggered twice.
## The expected behavior
The `onMouseEnter` should b... | {'url': 'https://api.github.com/repos/facebook/react/issues/21049/reactions', 'total_count': 7, '+1': 7, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21049/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/21048 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21048/labels{/name} | https://api.github.com/repos/facebook/react/issues/21048/comments | https://api.github.com/repos/facebook/react/issues/21048/events | https://github.com/facebook/react/issues/21048 | 837,497,903 | MDU6SXNzdWU4Mzc0OTc5MDM= | 21,048 | Bug: react hooks gets executed two times | {'login': 'kambleaa007', 'id': 19818679, 'node_id': 'MDQ6VXNlcjE5ODE4Njc5', 'avatar_url': 'https://avatars.githubusercontent.com/u/19818679?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kambleaa007', 'html_url': 'https://github.com/kambleaa007', 'followers_url': 'https://api.github.com/users/kambleaa007... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Could you point to the particular hook that gets called twice?\r\n\r\nThough I suspect this is expected behavior considering [your app is rendered in StrictMode](https://github.com/kambleaa007/TrainingReactJS/blob/0a5ccd1fe9590467adf1d8f0477fa5fc636cd897/src/index.js#L8-L10).\r\n\r\n`React.StrictMode` executes cer... | 2021-03-22 09:10:28 | 2021-03-22 09:48:19 | 2021-03-22 09:48:12 | NONE | null | null | null | as i clicked on button only once,
call stack
after continue, it gets called again without c... | {'url': 'https://api.github.com/repos/facebook/react/issues/21048/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21048/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21047 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21047/labels{/name} | https://api.github.com/repos/facebook/react/issues/21047/comments | https://api.github.com/repos/facebook/react/issues/21047/events | https://github.com/facebook/react/issues/21047 | 837,160,681 | MDU6SXNzdWU4MzcxNjA2ODE= | 21,047 | Bug: React Refresh throws error, only on macOS | {'login': 'Nantris', 'id': 6835891, 'node_id': 'MDQ6VXNlcjY4MzU4OTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6835891?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Nantris', 'html_url': 'https://github.com/Nantris', 'followers_url': 'https://api.github.com/users/Nantris/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The code in question on line 461 of `./node_modules/react-refresh/cjs/react-refresh-runtime.development.js` is:\r\n\r\n```js\r\n hook.renderers.forEach(function (injected, id) {\r\n if (typeof injected.scheduleRefresh === 'function' && typeof injected.setRefreshHandler === 'function') {\r\n // This v... | 2021-03-21 19:21:30 | 2021-05-02 20:41:13 | 2021-03-24 16:54:50 | NONE | null | null | null | React Refresh throws error, only on macOS. I originally reported that on the React-Refresh-Webpack-Plugin, but @pmmmwh noticed the error actually seems to be coming from React Refresh itself. https://github.com/pmmmwh/react-refresh-webpack-plugin/issues/333
**React version:** 17.0.1
**Environment:** macOS 10.13.x... | {'url': 'https://api.github.com/repos/facebook/react/issues/21047/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21047/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21046 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21046/labels{/name} | https://api.github.com/repos/facebook/react/issues/21046/comments | https://api.github.com/repos/facebook/react/issues/21046/events | https://github.com/facebook/react/issues/21046 | 837,043,855 | MDU6SXNzdWU4MzcwNDM4NTU= | 21,046 | Error: "Commit tree already contains fiber 1. This is a bug in React DevTools." | {'login': 'singhdeepanshu', 'id': 38343658, 'node_id': 'MDQ6VXNlcjM4MzQzNjU4', 'avatar_url': 'https://avatars.githubusercontent.com/u/38343658?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/singhdeepanshu', 'html_url': 'https://github.com/singhdeepanshu', 'followers_url': 'https://api.github.com/users/si... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/la... | closed | false | null | [] | null | [
"I'm sorry you experienced this bug! 🙇 \r\n\r\nLooks like this problem was already reported though (#18859) so I'm going to mark this issue as a duplicate and close it. If you have additional context that might help us repro this problem, please leave a comment on the other issue!\r\n\r\nThank you~",
"@singhdeep... | 2021-03-21 10:52:59 | 2021-04-28 20:30:11 | 2021-03-21 15:21:18 | NONE | null | null | null | I was just recording through the profiler in react-dev-tools. I started the recording and stopped it.
I clicked on the arrow, select next commit and after 4-5 simultaneous clicks and got this issue.
The image is attached below for your reference.
---------------------------------------------
Please do not rem... | {'url': 'https://api.github.com/repos/facebook/react/issues/21046/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21046/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21045 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21045/labels{/name} | https://api.github.com/repos/facebook/react/issues/21045/comments | https://api.github.com/repos/facebook/react/issues/21045/events | https://github.com/facebook/react/issues/21045 | 837,030,334 | MDU6SXNzdWU4MzcwMzAzMzQ= | 21,045 | Bug: Internal state not resetting if a component replaces itself in the DOM Tree | {'login': 'DaniAkash', 'id': 6841445, 'node_id': 'MDQ6VXNlcjY4NDE0NDU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6841445?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/DaniAkash', 'html_url': 'https://github.com/DaniAkash', 'followers_url': 'https://api.github.com/users/DaniAkash/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"How would react know that it is a different tab?\r\n\r\n```\r\nactiveTab ? <AsyncSelector /> : <AsyncSelector />\r\n```\r\n\r\nThis code is just the same as writing `<AsyncSelector />`",
"The solution for this is to [use a `key`](https://reactjs.org/docs/lists-and-keys.html#keys), e.g.\r\n```js\r\n{activeTab ? <... | 2021-03-21 09:45:11 | 2021-03-21 17:06:44 | 2021-03-21 15:24:15 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.1
## Steps To Reproduce
1. I have a Tab implementation... | {'url': 'https://api.github.com/repos/facebook/react/issues/21045/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21045/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21044 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21044/labels{/name} | https://api.github.com/repos/facebook/react/issues/21044/comments | https://api.github.com/repos/facebook/react/issues/21044/events | https://github.com/facebook/react/pull/21044 | 836,890,455 | MDExOlB1bGxSZXF1ZXN0NTk3MzQ0MDk3 | 21,044 | chore: update feature request template | {'login': 'Uyadav207', 'id': 50916299, 'node_id': 'MDQ6VXNlcjUwOTE2Mjk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/50916299?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Uyadav207', 'html_url': 'https://github.com/Uyadav207', 'followers_url': 'https://api.github.com/users/Uyadav207/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @Uyadav207! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for... | 2021-03-20 19:16:17 | 2022-10-20 20:42:03 | 2022-10-20 20:42:03 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21044', 'html_url': 'https://github.com/facebook/react/pull/21044', 'diff_url': 'https://github.com/facebook/react/pull/21044.diff', 'patch_url': 'https://github.com/facebook/react/pull/21044.patch', 'merged_at': None} | Update `feature-request.md`
Mark question description as a comment, as they are for the author's eye only.
- There are number of feature requests but they are unstructured and cause difficulty for maintainers to understand the flow of the feature.
- This template will help the maintainer as well as contributor by pro... | {'url': 'https://api.github.com/repos/facebook/react/issues/21044/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21044/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21043 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21043/labels{/name} | https://api.github.com/repos/facebook/react/issues/21043/comments | https://api.github.com/repos/facebook/react/issues/21043/events | https://github.com/facebook/react/issues/21043 | 836,864,140 | MDU6SXNzdWU4MzY4NjQxNDA= | 21,043 | Feature request: Consider supporting AbortSignal/AbortController for cleanup | {'login': 'benjamingr', 'id': 1315533, 'node_id': 'MDQ6VXNlcjEzMTU1MzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1315533?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/benjamingr', 'html_url': 'https://github.com/benjamingr', 'followers_url': 'https://api.github.com/users/benjamingr/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"(I am also happy to contribute code for this - though I seriously doubt that's the blocker)",
"It seems like something that can be trivially implemented as a separate package.",
"@vkurchatkin it's always possible to wrap all the React hooks in whatever wrapper we want I think? AbortSignal is the web-platform s... | 2021-03-20 17:10:15 | 2024-04-17 18:04:54 | 2024-04-17 18:04:53 | NONE | null | null | null | Hey, I've recently worked on adding support for `AbortController/AbortSignal` in a bunch of Node.js APIs and some DOM ones and I think it would be really cool if React added support to the web platform's cancellation standard primitive.
Basically the ask is:
```js
//before
useEffect(() => {
const ac = new Ab... | {'url': 'https://api.github.com/repos/facebook/react/issues/21043/reactions', 'total_count': 15, '+1': 9, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 6, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21043/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/21042 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21042/labels{/name} | https://api.github.com/repos/facebook/react/issues/21042/comments | https://api.github.com/repos/facebook/react/issues/21042/events | https://github.com/facebook/react/issues/21042 | 836,733,257 | MDU6SXNzdWU4MzY3MzMyNTc= | 21,042 | Bug: Scheduler - SharedArrayBuffer deprected | {'login': 'rmkanda', 'id': 38713281, 'node_id': 'MDQ6VXNlcjM4NzEzMjgx', 'avatar_url': 'https://avatars.githubusercontent.com/u/38713281?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rmkanda', 'html_url': 'https://github.com/rmkanda', 'followers_url': 'https://api.github.com/users/rmkanda/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Same as https://github.com/facebook/react/issues/20829 ? 🧐 \r\n",
"Yes, this is a duplicate. ",
"React 17.0.2 was released with removed dependency on `SharedArrayBuffer` so this should be resolved."
] | 2021-03-20 06:15:05 | 2021-03-22 22:03:10 | 2021-03-20 13:27:16 | NONE | null | null | null | React version: 17.0.1
## Steps To Reproduce
1. Use latest react and check chrome console
## Issue
[Deprecation] SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
```
scheduler.developmen... | {'url': 'https://api.github.com/repos/facebook/react/issues/21042/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21042/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21041 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21041/labels{/name} | https://api.github.com/repos/facebook/react/issues/21041/comments | https://api.github.com/repos/facebook/react/issues/21041/events | https://github.com/facebook/react/pull/21041 | 836,608,341 | MDExOlB1bGxSZXF1ZXN0NTk3MTA4NDM0 | 21,041 | Detach sibling pointers in old child list | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6d3ecb70dceb225af0cd990b46d6c44b852c1d82...8066dbe5c2b1687359ee84ca6cfab685536e47cc\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-20 02:37:41 | 2021-03-23 06:12:19 | 2021-03-23 06:12:19 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21041', 'html_url': 'https://github.com/facebook/react/pull/21041', 'diff_url': 'https://github.com/facebook/react/pull/21041.diff', 'patch_url': 'https://github.com/facebook/react/pull/21041.patch', 'merged_at': None} | When a fiber is deleted, it's still part of the previous (alternate) parent fiber's list of children. Because children are a linked list, an earlier sibling that's still alive will be connected to the deleted fiber via its `alternate`:
```
live fiber
--alternate--> previous live fiber
--sibling--> deleted fiber
... | {'url': 'https://api.github.com/repos/facebook/react/issues/21041/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21041/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21040 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21040/labels{/name} | https://api.github.com/repos/facebook/react/issues/21040/comments | https://api.github.com/repos/facebook/react/issues/21040/events | https://github.com/facebook/react/pull/21040 | 836,526,688 | MDExOlB1bGxSZXF1ZXN0NTk3MDMxNTY2 | 21,040 | Remove discrete lanes and priorities | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1fafac002838ad2d75ee9eca527c356b040285ff...5fe06d62a8dced156a411b84ed3197888e82d1de\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-20 00:31:19 | 2021-03-22 16:51:40 | 2021-03-22 16:51:40 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21040', 'html_url': 'https://github.com/facebook/react/pull/21040', 'diff_url': 'https://github.com/facebook/react/pull/21040.diff', 'patch_url': 'https://github.com/facebook/react/pull/21040.patch', 'merged_at': datetime.datetime(2021, 3, 22, 16, 51, 40)} | We use SyncLane everywhere we used to use InputDiscreteLane or InputDiscreteHydrationLane. So we can delete them now, along with their associated lane priority levels. | {'url': 'https://api.github.com/repos/facebook/react/issues/21040/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21040/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21039 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21039/labels{/name} | https://api.github.com/repos/facebook/react/issues/21039/comments | https://api.github.com/repos/facebook/react/issues/21039/events | https://github.com/facebook/react/pull/21039 | 836,506,458 | MDExOlB1bGxSZXF1ZXN0NTk3MDEyNjQ0 | 21,039 | [Experiment] Add feature flag for more aggressive memory clean-up of deleted fiber trees | {'login': 'bgirard', 'id': 793565, 'node_id': 'MDQ6VXNlcjc5MzU2NQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/793565?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bgirard', 'html_url': 'https://github.com/bgirard', 'followers_url': 'https://api.github.com/users/bgirard/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 00d4f95c2ad000f40ea0c774cc1ced3a0ceb6f23...31e19771bbf0120963bb36578b5184a64fdca95f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-20 00:02:59 | 2021-04-15 20:14:26 | 2021-03-23 04:54:53 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21039', 'html_url': 'https://github.com/facebook/react/pull/21039', 'diff_url': 'https://github.com/facebook/react/pull/21039.diff', 'patch_url': 'https://github.com/facebook/react/pull/21039.patch', 'merged_at': datetime.datetime(2021, 3, 23, 4, 54, 53)} | ## Summary
Add a new feature flag called 'enableStrongMemoryCleanup' that will recursively clean-up the FiberNode memory graph on unmount. This is to experiment on improving memory usage and/or reducing leaks after unmount.
## Test Plan
Will run several memory usage scenario against this sync.
| {'url': 'https://api.github.com/repos/facebook/react/issues/21039/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21039/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21038 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21038/labels{/name} | https://api.github.com/repos/facebook/react/issues/21038/comments | https://api.github.com/repos/facebook/react/issues/21038/events | https://github.com/facebook/react/pull/21038 | 836,491,902 | MDExOlB1bGxSZXF1ZXN0NTk2OTk4ODM2 | 21,038 | Use SyncLane for discrete event hydration | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6d3ecb70dceb225af0cd990b46d6c44b852c1d82...4ddabc53ed6927637af9fe6e2cdd5bfb76b379a8\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-19 23:49:15 | 2021-03-22 16:05:43 | 2021-03-22 16:05:43 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21038', 'html_url': 'https://github.com/facebook/react/pull/21038', 'diff_url': 'https://github.com/facebook/react/pull/21038.diff', 'patch_url': 'https://github.com/facebook/react/pull/21038.patch', 'merged_at': datetime.datetime(2021, 3, 22, 16, 5, 43)} | Discrete event hydration doesn't need to be interruptible, since there's nothing higher priority than discrete events. So we can use SyncLane instead of a special hydration lane. | {'url': 'https://api.github.com/repos/facebook/react/issues/21038/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21038/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21037 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21037/labels{/name} | https://api.github.com/repos/facebook/react/issues/21037/comments | https://api.github.com/repos/facebook/react/issues/21037/events | https://github.com/facebook/react/pull/21037 | 836,374,208 | MDExOlB1bGxSZXF1ZXN0NTk2ODg5OTA1 | 21,037 | [Fizz] Use identifierPrefix to avoid conflicts within the same response | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6d3ecb70dceb225af0cd990b46d6c44b852c1d82...9490ad42a91b8876c8ae049a911fae73f660dae4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-19 21:35:01 | 2021-03-22 21:16:24 | 2021-03-22 20:10:57 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21037', 'html_url': 'https://github.com/facebook/react/pull/21037', 'diff_url': 'https://github.com/facebook/react/pull/21037.diff', 'patch_url': 'https://github.com/facebook/react/pull/21037.patch', 'merged_at': datetime.datetime(2021, 3, 22, 20, 10, 57)} | identifierPrefix as an option exists to avoid useOpaqueIdentifier conflicting when different renders are used within one HTML response.
This lets this be configured for the DOM renderer specifically since it's DOM specific whether they will conflict across trees or not.
Added a test that uses two streams/containe... | {'url': 'https://api.github.com/repos/facebook/react/issues/21037/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21037/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21036 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21036/labels{/name} | https://api.github.com/repos/facebook/react/issues/21036/comments | https://api.github.com/repos/facebook/react/issues/21036/events | https://github.com/facebook/react/issues/21036 | 836,132,547 | MDU6SXNzdWU4MzYxMzI1NDc= | 21,036 | React App Show me this Error | {'login': 'sureshjangid', 'id': 75411144, 'node_id': 'MDQ6VXNlcjc1NDExMTQ0', 'avatar_url': 'https://avatars.githubusercontent.com/u/75411144?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sureshjangid', 'html_url': 'https://github.com/sureshjangid', 'followers_url': 'https://api.github.com/users/sureshja... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'sureshjangid', 'id': 75411144.0, 'node_id': 'MDQ6VXNlcjc1NDExMTQ0', 'avatar_url': 'https://avatars.githubusercontent.com/u/75411144?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sureshjangid', 'html_url': 'https://github.com/sureshjangid', 'followers_url': 'https://api.github.com/users/suresh... | [{'login': 'sureshjangid', 'id': 75411144, 'node_id': 'MDQ6VXNlcjc1NDExMTQ0', 'avatar_url': 'https://avatars.githubusercontent.com/u/75411144?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sureshjangid', 'html_url': 'https://github.com/sureshjangid', 'followers_url': 'https://api.github.com/users/sureshj... | null | [
"Screenshots of code (files) aren't really a repro. Please share actual runnable code.",
"There shouldn't be a newline after `return`, `(` should be on the same line",
"> There shouldn't be a newline after `return`, `(` should be on the same line\r\n\r\nThank You So much, sir, For your Response. Now the code is... | 2021-03-19 15:41:25 | 2021-03-20 03:20:38 | 2021-03-20 03:20:38 | NONE | null | null | null |
![Screenshot (235)](https://user-images.githubusercontent.com/75411144... | {'url': 'https://api.github.com/repos/facebook/react/issues/21036/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21036/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21035 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21035/labels{/name} | https://api.github.com/repos/facebook/react/issues/21035/comments | https://api.github.com/repos/facebook/react/issues/21035/events | https://github.com/facebook/react/issues/21035 | 836,115,802 | MDU6SXNzdWU4MzYxMTU4MDI= | 21,035 | Bug: aria-description is a valid ARIA property | {'login': 'nordfjord', 'id': 3721521, 'node_id': 'MDQ6VXNlcjM3MjE1MjE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3721521?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nordfjord', 'html_url': 'https://github.com/nordfjord', 'followers_url': 'https://api.github.com/users/nordfjord/followers... | [{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20DOM', 'name': 'Component: DOM', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/faceb... | closed | false | null | [] | null | [
"I guess the question is what React considers a \"valid\" aria prop:\r\n1. a specific version (range) of Aria\r\n1. a version with a [particular state](https://www.w3.org/2004/02/Process-20040205/tr.html#:~:text=A%20Working%20Draft%20is%20a,public%2C%20and%20other%20technical%20organizations.&text=A%20Candidate%20R... | 2021-03-19 15:23:40 | 2021-09-06 19:13:13 | 2021-09-06 19:13:12 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.x
## Steps To Reproduce
1. `render(<div aria-description... | {'url': 'https://api.github.com/repos/facebook/react/issues/21035/reactions', 'total_count': 16, '+1': 15, '-1': 1, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21035/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21034 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21034/labels{/name} | https://api.github.com/repos/facebook/react/issues/21034/comments | https://api.github.com/repos/facebook/react/issues/21034/events | https://github.com/facebook/react/pull/21034 | 836,009,203 | MDExOlB1bGxSZXF1ZXN0NTk2NTgxMzk2 | 21,034 | Fixed primitive hook badge colors for light theme | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 154b85213a65377a67ac4f7a4a39116024bc3028...b8b2492f3a25cdcd84ca75ad336656895216334b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-19 13:43:56 | 2021-03-19 13:53:02 | 2021-03-19 13:52:59 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21034', 'html_url': 'https://github.com/facebook/react/pull/21034', 'diff_url': 'https://github.com/facebook/react/pull/21034.diff', 'patch_url': 'https://github.com/facebook/react/pull/21034.patch', 'merged_at': datetime.datetime(2021, 3, 19, 13, 52, 59)} | Resolves #21026
https://user-images.githubusercontent.com/29597/111789744-ddf21080-8897-11eb-90f3-5e23ddd506f7.mp4
| {'url': 'https://api.github.com/repos/facebook/react/issues/21034/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21034/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21033 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21033/labels{/name} | https://api.github.com/repos/facebook/react/issues/21033/comments | https://api.github.com/repos/facebook/react/issues/21033/events | https://github.com/facebook/react/issues/21033 | 835,267,916 | MDU6SXNzdWU4MzUyNjc5MTY= | 21,033 | Bug: invokeGuardedCallbackDev called too many times in dev mode | {'login': 'etomanon', 'id': 17390813, 'node_id': 'MDQ6VXNlcjE3MzkwODEz', 'avatar_url': 'https://avatars.githubusercontent.com/u/17390813?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/etomanon', 'html_url': 'https://github.com/etomanon', 'followers_url': 'https://api.github.com/users/etomanon/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'etomanon', 'id': 17390813.0, 'node_id': 'MDQ6VXNlcjE3MzkwODEz', 'avatar_url': 'https://avatars.githubusercontent.com/u/17390813?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/etomanon', 'html_url': 'https://github.com/etomanon', 'followers_url': 'https://api.github.com/users/etomanon/followers... | [{'login': 'etomanon', 'id': 17390813, 'node_id': 'MDQ6VXNlcjE3MzkwODEz', 'avatar_url': 'https://avatars.githubusercontent.com/u/17390813?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/etomanon', 'html_url': 'https://github.com/etomanon', 'followers_url': 'https://api.github.com/users/etomanon/followers'... | null | [
"It doesn't look like this bug report has enough info for one of us to reproduce it.\r\n\r\nPlease provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. Screenshots or videos can also be helpful if they help provide con... | 2021-03-18 21:14:22 | 2021-03-22 16:52:21 | 2021-03-22 16:52:21 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.1
## Steps To Reproduce
1. Create table with virtualiz... | {'url': 'https://api.github.com/repos/facebook/react/issues/21033/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21033/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21032 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21032/labels{/name} | https://api.github.com/repos/facebook/react/issues/21032/comments | https://api.github.com/repos/facebook/react/issues/21032/events | https://github.com/facebook/react/pull/21032 | 835,065,025 | MDExOlB1bGxSZXF1ZXN0NTk1Nzc4OTY2 | 21,032 | Add createBridge and createStore exports to react-devtools-inline (for Replay integration) | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 686b635b7141511a7bbe751430f6680fc5cca2e2...237f3c94b38645007a6ce3161b0618fca9e760c4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-18 17:10:05 | 2021-04-12 21:07:15 | 2021-04-12 21:07:14 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21032', 'html_url': 'https://github.com/facebook/react/pull/21032', 'diff_url': 'https://github.com/facebook/react/pull/21032.diff', 'patch_url': 'https://github.com/facebook/react/pull/21032.patch', 'merged_at': datetime.datetime(2021, 4, 12, 21, 7, 14)} | Investigating new API endpoints necessary to support a more advanced use case like Replay.io | {'url': 'https://api.github.com/repos/facebook/react/issues/21032/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21032/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21031 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21031/labels{/name} | https://api.github.com/repos/facebook/react/issues/21031/comments | https://api.github.com/repos/facebook/react/issues/21031/events | https://github.com/facebook/react/issues/21031 | 834,714,361 | MDU6SXNzdWU4MzQ3MTQzNjE= | 21,031 | Bug: Creating a portal within a shadow root breaks event handlers | {'login': 'ablamunits', 'id': 9403859, 'node_id': 'MDQ6VXNlcjk0MDM4NTk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9403859?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ablamunits', 'html_url': 'https://github.com/ablamunits', 'followers_url': 'https://api.github.com/users/ablamunits/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!",
"C... | 2021-03-18 11:47:37 | 2024-04-17 18:04:55 | 2024-04-17 18:04:54 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
With React 16 there seem to be issues related to using a portal within the shado... | {'url': 'https://api.github.com/repos/facebook/react/issues/21031/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21031/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/21030 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21030/labels{/name} | https://api.github.com/repos/facebook/react/issues/21030/comments | https://api.github.com/repos/facebook/react/issues/21030/events | https://github.com/facebook/react/issues/21030 | 834,409,219 | MDU6SXNzdWU4MzQ0MDkyMTk= | 21,030 | Bug: context value is not updated with useContext hook but it is with a Consumer component | {'login': 'tsdexter', 'id': 4126987, 'node_id': 'MDQ6VXNlcjQxMjY5ODc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4126987?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tsdexter', 'html_url': 'https://github.com/tsdexter', 'followers_url': 'https://api.github.com/users/tsdexter/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Thanks for the reproduction.\r\n\r\nThe `useContext` usage is not inside the Provider. I've unwrapped the code to illustrate what React is \"seeing\":\r\n\r\n```jsx\r\nfunction Component() {\r\n const valueUseContext = useContext(Context);\r\n const [state, setState] = useState(0);\r\n\r\n return (\r\n <Cont... | 2021-03-18 05:32:20 | 2021-03-18 14:30:34 | 2021-03-18 14:24:39 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.1
## Steps To Reproduce
1. create context
2. wrap ap... | {'url': 'https://api.github.com/repos/facebook/react/issues/21030/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21030/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21029 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21029/labels{/name} | https://api.github.com/repos/facebook/react/issues/21029/comments | https://api.github.com/repos/facebook/react/issues/21029/events | https://github.com/facebook/react/pull/21029 | 834,355,544 | MDExOlB1bGxSZXF1ZXN0NTk1MTg2ODQw | 21,029 | [Fizz] Expose maxBoundarySize as an option | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 154b85213a65377a67ac4f7a4a39116024bc3028...0fa77e1a0e4e3f639df5ab08dd6d58a5f34780b4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-18 03:30:14 | 2021-03-19 16:41:25 | 2021-03-19 16:41:25 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21029', 'html_url': 'https://github.com/facebook/react/pull/21029', 'diff_url': 'https://github.com/facebook/react/pull/21029.diff', 'patch_url': 'https://github.com/facebook/react/pull/21029.patch', 'merged_at': datetime.datetime(2021, 3, 19, 16, 41, 25)} | Bike shed now or forever hold your peace. | {'url': 'https://api.github.com/repos/facebook/react/issues/21029/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21029/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21028 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21028/labels{/name} | https://api.github.com/repos/facebook/react/issues/21028/comments | https://api.github.com/repos/facebook/react/issues/21028/events | https://github.com/facebook/react/pull/21028 | 834,329,770 | MDExOlB1bGxSZXF1ZXN0NTk1MTY3MTQx | 21,028 | [Fizz] Expose a method to explicitly start writing to a Node stream | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cf485e6f6b4d6a6e2ccfe7a12537941925316e86...3036225bcf7fe1a716072027997ef7c2162e3eee\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-18 02:27:29 | 2021-03-18 19:43:40 | 2021-03-18 19:43:40 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21028', 'html_url': 'https://github.com/facebook/react/pull/21028', 'diff_url': 'https://github.com/facebook/react/pull/21028.diff', 'patch_url': 'https://github.com/facebook/react/pull/21028.patch', 'merged_at': datetime.datetime(2021, 3, 18, 19, 43, 40)} | We use *writable* Node streams because it's the only one that lets us explicitly flush to the underlying sink. Especially when used with gzip.
However, we don't want to start writing to it until after the header has been received and perhaps part of the initial content like `<head>` has been written.
This PR make... | {'url': 'https://api.github.com/repos/facebook/react/issues/21028/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21028/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21027 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21027/labels{/name} | https://api.github.com/repos/facebook/react/issues/21027/comments | https://api.github.com/repos/facebook/react/issues/21027/events | https://github.com/facebook/react/pull/21027 | 834,314,577 | MDExOlB1bGxSZXF1ZXN0NTk1MTU1NjUy | 21,027 | [Fizz] Expose a method to abort a pending request | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 3fb11eed9a166ebab23b778662f54c449fcffad0...28c0533c33ce9da57385c65344a6925343979da5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-18 01:49:24 | 2021-03-18 16:46:16 | 2021-03-18 16:46:16 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21027', 'html_url': 'https://github.com/facebook/react/pull/21027', 'diff_url': 'https://github.com/facebook/react/pull/21027.diff', 'patch_url': 'https://github.com/facebook/react/pull/21027.patch', 'merged_at': datetime.datetime(2021, 3, 18, 16, 46, 16)} | This introduces a Set of SuspendedWork to the data structures. This is basically like an AbortSignal. In fact, it should probably be coupled with an actual AbortSignal at the same places.
For work inside a fallback, the abortSet is associated with the boundary that it's a fallback for. This lets the boundary cancel ... | {'url': 'https://api.github.com/repos/facebook/react/issues/21027/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/21027/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21026 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21026/labels{/name} | https://api.github.com/repos/facebook/react/issues/21026/comments | https://api.github.com/repos/facebook/react/issues/21026/events | https://github.com/facebook/react/issues/21026 | 834,280,905 | MDU6SXNzdWU4MzQyODA5MDU= | 21,026 | Bug: DevTools built-in hook number badges are broken for "light" theme | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [] | 2021-03-18 00:32:29 | 2021-03-19 13:52:59 | 2021-03-19 13:52:59 | CONTRIBUTOR | null | null | null | I mostly use the "dark" theme which these badges looked good in. The "light" theme is broken though. No contrast. | {'url': 'https://api.github.com/repos/facebook/react/issues/21026/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21026/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21025 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21025/labels{/name} | https://api.github.com/repos/facebook/react/issues/21025/comments | https://api.github.com/repos/facebook/react/issues/21025/events | https://github.com/facebook/react/issues/21025 | 834,220,874 | MDU6SXNzdWU4MzQyMjA4NzQ= | 21,025 | Bug: HTMLSelectElement.value doesn't update to defaultValue on form reset | {'login': 'cl8n', 'id': 9954349, 'node_id': 'MDQ6VXNlcjk5NTQzNDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9954349?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cl8n', 'html_url': 'https://github.com/cl8n', 'followers_url': 'https://api.github.com/users/cl8n/followers', 'following_url': ... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This doesn't seem like a bug to me, reset() simply revert the inputs value to the current DefaultValue, which is set only on the mounting phase\r\n\r\nAs you can see here : https://codesandbox.io/s/crimson-frost-ztcwi?file=/src/App.js\r\nIf I add a key associated with defaultValue which force the component to remo... | 2021-03-17 22:18:45 | 2024-04-17 18:04:56 | 2024-04-17 18:04:56 | NONE | null | null | null | For uncontrolled inputs, [docs here](https://github.com/facebook/react/blob/master/fixtures/dom/src/components/fixtures/text-inputs/README.md#form-reset-events) say that `reset()`ing a form should change all inputs' `value`s to `defaultValue`. This doesn't seem to be working for `HTMLSelectElement`.
React version: 1... | {'url': 'https://api.github.com/repos/facebook/react/issues/21025/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21025/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/21024 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21024/labels{/name} | https://api.github.com/repos/facebook/react/issues/21024/comments | https://api.github.com/repos/facebook/react/issues/21024/events | https://github.com/facebook/react/pull/21024 | 834,159,591 | MDExOlB1bGxSZXF1ZXN0NTk1MDM1OTEz | 21,024 | React Native: Touch Instrumentation Interface | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 119736b1c2ea0d404ad466e39138462453392008...07b8bc3e04b3b6f62d26fcd6bf2b265d1f1df4b5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-17 20:38:02 | 2021-03-17 20:47:44 | 2021-03-17 20:46:44 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21024', 'html_url': 'https://github.com/facebook/react/pull/21024', 'diff_url': 'https://github.com/facebook/react/pull/21024.diff', 'patch_url': 'https://github.com/facebook/react/pull/21024.patch', 'merged_at': datetime.datetime(2021, 3, 17, 20, 46, 44)} | ## Summary
Creates a simple touch instrumentation interface. We will be using this internally to measure touch latency as we iterate on changes to React Native.
## Test Plan
Ran `yarn flow native` and `yarn flow fabric` successfully. | {'url': 'https://api.github.com/repos/facebook/react/issues/21024/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21024/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21023 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21023/labels{/name} | https://api.github.com/repos/facebook/react/issues/21023/comments | https://api.github.com/repos/facebook/react/issues/21023/events | https://github.com/facebook/react/issues/21023 | 834,061,012 | MDU6SXNzdWU4MzQwNjEwMTI= | 21,023 | react-devtools-inline package now has react@experimental dependency | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [] | 2021-03-17 18:22:17 | 2021-03-18 14:39:10 | null | CONTRIBUTOR | null | null | null | I recently updated DevTools to use the new, experimental `getCacheForType` API (#20548) which works well for the browser and standalone extension versions, because they bundle their own version of React (the experimental release). This has left the `react-devtools-inline` package (used by e.g. Code Sandbox) in an unrel... | {'url': 'https://api.github.com/repos/facebook/react/issues/21023/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21023/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/21022 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21022/labels{/name} | https://api.github.com/repos/facebook/react/issues/21022/comments | https://api.github.com/repos/facebook/react/issues/21022/events | https://github.com/facebook/react/issues/21022 | 833,340,145 | MDU6SXNzdWU4MzMzNDAxNDU= | 21,022 | Bug: The @babel plugin-proposal-class-properties plug-in configuration is not in effect | {'login': 'Fcscanf', 'id': 27654200, 'node_id': 'MDQ6VXNlcjI3NjU0MjAw', 'avatar_url': 'https://avatars.githubusercontent.com/u/27654200?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Fcscanf', 'html_url': 'https://github.com/Fcscanf', 'followers_url': 'https://api.github.com/users/Fcscanf/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2021-03-17 02:23:06 | 2021-03-17 05:37:14 | 2021-03-17 05:37:14 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
I used the ```yarn eject``` command t... | {'url': 'https://api.github.com/repos/facebook/react/issues/21022/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21022/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21021 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21021/labels{/name} | https://api.github.com/repos/facebook/react/issues/21021/comments | https://api.github.com/repos/facebook/react/issues/21021/events | https://github.com/facebook/react/pull/21021 | 833,325,026 | MDExOlB1bGxSZXF1ZXN0NTk0MzQwNTgw | 21,021 | Don't delete trailing mismatches during hydration at the root | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1d1e49cfa453b58769e87c3c8d321024d58c948f...618232e797c421dd8241579a951422e9c7d54671\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-17 01:42:06 | 2021-03-17 15:18:42 | 2021-03-17 15:18:42 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21021', 'html_url': 'https://github.com/facebook/react/pull/21021', 'diff_url': 'https://github.com/facebook/react/pull/21021.diff', 'patch_url': 'https://github.com/facebook/react/pull/21021.patch', 'merged_at': datetime.datetime(2021, 3, 17, 15, 18, 42)} | The problem I'm trying to solve is that with Fizz, we add extra nodes to the end (segments, and scripts). If you pipe Fizz into a container, then those end up at the end of the container.
```
<div id="container">
<div>My Content</div>
<div hidden id="Segment:123">...</div>
<script>...</script>
</div>
```... | {'url': 'https://api.github.com/repos/facebook/react/issues/21021/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21021/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21020 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21020/labels{/name} | https://api.github.com/repos/facebook/react/issues/21020/comments | https://api.github.com/repos/facebook/react/issues/21020/events | https://github.com/facebook/react/pull/21020 | 833,124,065 | MDExOlB1bGxSZXF1ZXN0NTk0MTc2NDMw | 21,020 | [Fizz] Assign an ID to the first DOM element in a fallback or insert a dummy (and testing infra) | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f8979e0e28398d98dab921f17d14a5a9b5fb1b71...babefe9a679aefe19a08135ec5a3af59cc6b3806\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-16 19:21:06 | 2021-03-16 21:05:52 | 2021-03-16 21:05:52 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21020', 'html_url': 'https://github.com/facebook/react/pull/21020', 'diff_url': 'https://github.com/facebook/react/pull/21020.diff', 'patch_url': 'https://github.com/facebook/react/pull/21020.patch', 'merged_at': datetime.datetime(2021, 3, 16, 21, 5, 52)} | We need some ID attribute so that we can quickly find a Suspense boundary. This approach tries to assign or reuse the ID of the first child element of a Suspense boundary. If the first child is not an element, we insert a dummy hidden span. This breaks CSS pseudo-selectors for this case ofc.
I'm not a fan of how inv... | {'url': 'https://api.github.com/repos/facebook/react/issues/21020/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21020/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21019 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21019/labels{/name} | https://api.github.com/repos/facebook/react/issues/21019/comments | https://api.github.com/repos/facebook/react/issues/21019/events | https://github.com/facebook/react/issues/21019 | 833,115,401 | MDU6SXNzdWU4MzMxMTU0MDE= | 21,019 | Bug: Empty deps useEffect be called on re-render in HMR | {'login': 'xialvjun', 'id': 4413712, 'node_id': 'MDQ6VXNlcjQ0MTM3MTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4413712?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/xialvjun', 'html_url': 'https://github.com/xialvjun', 'followers_url': 'https://api.github.com/users/xialvjun/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is not a bug, it's intentional behavior and the only way this feature could work.\r\n\r\nWhen we update the code, we need to \"clean up\" the effects that hold onto past values (e.g. passed functions), and \"setup\" the new ones with updated values. Otherwise, the values used by your effect would be stale and... | 2021-03-16 19:08:22 | 2021-03-17 04:44:35 | 2021-03-16 22:17:18 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
Empty dependencies useEffect should be called only one time.
React version: v... | {'url': 'https://api.github.com/repos/facebook/react/issues/21019/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21019/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21018 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21018/labels{/name} | https://api.github.com/repos/facebook/react/issues/21018/comments | https://api.github.com/repos/facebook/react/issues/21018/events | https://github.com/facebook/react/pull/21018 | 832,999,900 | MDExOlB1bGxSZXF1ZXN0NTk0MDcxOTEx | 21,018 | Speed up DevTools local build script | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0203b6567c6fd6274866c853ef938241d24551ec...598091c01c45d8c8b316b44794450bc257fbb0be\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-16 16:40:54 | 2021-03-16 18:02:25 | 2021-03-16 18:02:24 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21018', 'html_url': 'https://github.com/facebook/react/pull/21018', 'diff_url': 'https://github.com/facebook/react/pull/21018.diff', 'patch_url': 'https://github.com/facebook/react/pull/21018.patch', 'merged_at': datetime.datetime(2021, 3, 16, 18, 2, 24)} | I noticed that it's building both the stable and experimental release channels of React (when it only needs the experimental channel) _and_ it's building non-node modules artifacts.
This should reduce the build time to like 25% or less of what it was before. | {'url': 'https://api.github.com/repos/facebook/react/issues/21018/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21018/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21017 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21017/labels{/name} | https://api.github.com/repos/facebook/react/issues/21017/comments | https://api.github.com/repos/facebook/react/issues/21017/events | https://github.com/facebook/react/issues/21017 | 832,735,066 | MDU6SXNzdWU4MzI3MzUwNjY= | 21,017 | Error: "value is undefined" | {'login': 'aakanshaMobiux', 'id': 75972805, 'node_id': 'MDQ6VXNlcjc1OTcyODA1', 'avatar_url': 'https://avatars.githubusercontent.com/u/75972805?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aakanshaMobiux', 'html_url': 'https://github.com/aakanshaMobiux', 'followers_url': 'https://api.github.com/users/aa... | [] | closed | false | null | [] | null | [] | 2021-03-16 12:13:41 | 2021-03-16 12:14:23 | 2021-03-16 12:14:23 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1.
2.
3.
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.10.1-f160547f47
Component stack: AutoSizeInput_AutoSizeInput@moz-extension://6771c44... | {'url': 'https://api.github.com/repos/facebook/react/issues/21017/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21017/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21016 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21016/labels{/name} | https://api.github.com/repos/facebook/react/issues/21016/comments | https://api.github.com/repos/facebook/react/issues/21016/events | https://github.com/facebook/react/pull/21016 | 832,631,008 | MDExOlB1bGxSZXF1ZXN0NTkzNzU3MjMx | 21,016 | chore: update react-reconciler README | {'login': 'susiwen8', 'id': 20318608, 'node_id': 'MDQ6VXNlcjIwMzE4NjA4', 'avatar_url': 'https://avatars.githubusercontent.com/u/20318608?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/susiwen8', 'html_url': 'https://github.com/susiwen8', 'followers_url': 'https://api.github.com/users/susiwen8/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: c9f6d0a3a8ef267fa3499782028fb1c74fae94e9...8d6a05767d4817b8d424d74d5e5273fc6b363e69\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-16 10:14:15 | 2021-03-16 11:38:41 | 2021-03-16 11:37:35 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21016', 'html_url': 'https://github.com/facebook/react/pull/21016', 'diff_url': 'https://github.com/facebook/react/pull/21016.diff', 'patch_url': 'https://github.com/facebook/react/pull/21016.patch', 'merged_at': datetime.datetime(2021, 3, 16, 11, 37, 34)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/21016/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21016/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21015 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21015/labels{/name} | https://api.github.com/repos/facebook/react/issues/21015/comments | https://api.github.com/repos/facebook/react/issues/21015/events | https://github.com/facebook/react/pull/21015 | 832,467,605 | MDExOlB1bGxSZXF1ZXN0NTkzNjIwMTIw | 21,015 | Sync `ReactNativeTypes.js` from React Native | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f8979e0e28398d98dab921f17d14a5a9b5fb1b71...9cf023012362bba431959513ddf466a3e9cec3e9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-16 06:39:52 | 2021-03-16 06:49:03 | 2021-03-16 06:49:00 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21015', 'html_url': 'https://github.com/facebook/react/pull/21015', 'diff_url': 'https://github.com/facebook/react/pull/21015.diff', 'patch_url': 'https://github.com/facebook/react/pull/21015.patch', 'merged_at': datetime.datetime(2021, 3, 16, 6, 49)} | ## Summary
Syncs `ReactNativeTypes.js` from the React Native repository.
If you're interested in breadcrumbs, see #21014.
## Test Plan
Ran `yarn flow fabric` and `yarn flow native` successfully. | {'url': 'https://api.github.com/repos/facebook/react/issues/21015/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21015/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21014 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21014/labels{/name} | https://api.github.com/repos/facebook/react/issues/21014/comments | https://api.github.com/repos/facebook/react/issues/21014/events | https://github.com/facebook/react/pull/21014 | 832,356,407 | MDExOlB1bGxSZXF1ZXN0NTkzNTI3NjY3 | 21,014 | Sync ReactNativeTypes from RN repo to React | {'login': 'JoshuaGross', 'id': 70602, 'node_id': 'MDQ6VXNlcjcwNjAy', 'avatar_url': 'https://avatars.githubusercontent.com/u/70602?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JoshuaGross', 'html_url': 'https://github.com/JoshuaGross', 'followers_url': 'https://api.github.com/users/JoshuaGross/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f8979e0e28398d98dab921f17d14a5a9b5fb1b71...ad6145ddc9f47ecefed5b2570a919f6106f5df56\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-16 02:43:04 | 2021-03-16 06:41:33 | 2021-03-16 06:41:33 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21014', 'html_url': 'https://github.com/facebook/react/pull/21014', 'diff_url': 'https://github.com/facebook/react/pull/21014.diff', 'patch_url': 'https://github.com/facebook/react/pull/21014.patch', 'merged_at': None} |
## Summary
Syncs over changes RN edited directly.
The same as https://github.com/facebook/react/pull/21012 but with some $FlowFixMes and some Flow casts removed.
This might not be the right approach, I'll need some feedback.
## Test Plan
yarn flow fabric && yarn flow native && yarn lint && yarn test | {'url': 'https://api.github.com/repos/facebook/react/issues/21014/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21014/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21013 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21013/labels{/name} | https://api.github.com/repos/facebook/react/issues/21013/comments | https://api.github.com/repos/facebook/react/issues/21013/events | https://github.com/facebook/react/pull/21013 | 832,324,719 | MDExOlB1bGxSZXF1ZXN0NTkzNTAyNjEx | 21,013 | Suggested scheduler fix for 17.1 | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f8979e0e28398d98dab921f17d14a5a9b5fb1b71...75bcff056f1181cf0755b5d5ddac1de9647922c5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-16 01:20:49 | 2021-03-23 18:13:01 | 2021-03-23 18:12:53 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21013', 'html_url': 'https://github.com/facebook/react/pull/21013', 'diff_url': 'https://github.com/facebook/react/pull/21013.diff', 'patch_url': 'https://github.com/facebook/react/pull/21013.patch', 'merged_at': None} | ## Overview
Suggested scheduler fix to use window.MessageChannel instead of global.MessageChannel. | {'url': 'https://api.github.com/repos/facebook/react/issues/21013/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21013/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21012 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21012/labels{/name} | https://api.github.com/repos/facebook/react/issues/21012/comments | https://api.github.com/repos/facebook/react/issues/21012/events | https://github.com/facebook/react/pull/21012 | 832,293,117 | MDExOlB1bGxSZXF1ZXN0NTkzNDc3NDc5 | 21,012 | Update ReactNativeTypes | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f8979e0e28398d98dab921f17d14a5a9b5fb1b71...cf7775f11d8c31fe3c7c8a2e3520670b167e3682\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-16 00:03:29 | 2021-03-16 06:41:42 | 2021-03-16 06:41:42 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21012', 'html_url': 'https://github.com/facebook/react/pull/21012', 'diff_url': 'https://github.com/facebook/react/pull/21012.diff', 'patch_url': 'https://github.com/facebook/react/pull/21012.patch', 'merged_at': None} | # Overview
Syncs over changes RN edited directly.
Flow will fail, opening for the RN team to see and iterate on. | {'url': 'https://api.github.com/repos/facebook/react/issues/21012/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21012/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21011 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21011/labels{/name} | https://api.github.com/repos/facebook/react/issues/21011/comments | https://api.github.com/repos/facebook/react/issues/21011/events | https://github.com/facebook/react/pull/21011 | 832,269,170 | MDExOlB1bGxSZXF1ZXN0NTkzNDU3OTk5 | 21,011 | Test fixture for tests | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d74559746c03d9f620e4fd338c70ce319070e0be...e19e936544b424280475c6d25bef712c91f70e5c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-15 23:07:51 | 2021-03-23 18:13:04 | 2021-03-23 18:13:04 | MEMBER | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/21011', 'html_url': 'https://github.com/facebook/react/pull/21011', 'diff_url': 'https://github.com/facebook/react/pull/21011.diff', 'patch_url': 'https://github.com/facebook/react/pull/21011.patch', 'merged_at': None} | # Do Not Merge
# Screen
<img width="1335" alt="Screen Shot 2021-03-15 at 1 25 31 PM" src="https://user-images.githubusercontent.com/2440089/111232558-b3ffcc00-85c1-11eb-96cc-89fd823b2201.png">
| {'url': 'https://api.github.com/repos/facebook/react/issues/21011/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21011/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21010 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21010/labels{/name} | https://api.github.com/repos/facebook/react/issues/21010/comments | https://api.github.com/repos/facebook/react/issues/21010/events | https://github.com/facebook/react/pull/21010 | 832,261,375 | MDExOlB1bGxSZXF1ZXN0NTkzNDUxNTI2 | 21,010 | Fix native event batching in concurrent mode | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f8979e0e28398d98dab921f17d14a5a9b5fb1b71...39ea57671dad5a5a174a67f83720e5926efd8e00\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-15 22:51:20 | 2021-03-16 17:15:06 | 2021-03-16 17:15:01 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21010', 'html_url': 'https://github.com/facebook/react/pull/21010', 'diff_url': 'https://github.com/facebook/react/pull/21010.diff', 'patch_url': 'https://github.com/facebook/react/pull/21010.patch', 'merged_at': datetime.datetime(2021, 3, 16, 17, 15)} | ## Overview
This PR fixes a bug exposed by https://github.com/facebook/react/pull/20968 where we were running a flush for legacy mode behavior in concurrent mode. | {'url': 'https://api.github.com/repos/facebook/react/issues/21010/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21010/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21009 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21009/labels{/name} | https://api.github.com/repos/facebook/react/issues/21009/comments | https://api.github.com/repos/facebook/react/issues/21009/events | https://github.com/facebook/react/pull/21009 | 832,103,906 | MDExOlB1bGxSZXF1ZXN0NTkzMzE5MjYx | 21,009 | Make Fabric noop when setJSResponder is called | {'login': 'JoshuaGross', 'id': 70602, 'node_id': 'MDQ6VXNlcjcwNjAy', 'avatar_url': 'https://avatars.githubusercontent.com/u/70602?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JoshuaGross', 'html_url': 'https://github.com/JoshuaGross', 'followers_url': 'https://api.github.com/users/JoshuaGross/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b9c4a01f71f59dc1ddf5944b0b11ec86b8218c73...147c30853f419a1bfe0e6ca53185d27b3b765022\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-15 19:00:15 | 2021-03-15 19:22:26 | 2021-03-15 19:22:26 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21009', 'html_url': 'https://github.com/facebook/react/pull/21009', 'diff_url': 'https://github.com/facebook/react/pull/21009.diff', 'patch_url': 'https://github.com/facebook/react/pull/21009.patch', 'merged_at': datetime.datetime(2021, 3, 15, 19, 22, 26)} | Revert 'Fabric-compatible implementation of feature', make Fabric noop when setJSResponder is called
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below ar... | {'url': 'https://api.github.com/repos/facebook/react/issues/21009/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21009/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21008 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21008/labels{/name} | https://api.github.com/repos/facebook/react/issues/21008/comments | https://api.github.com/repos/facebook/react/issues/21008/events | https://github.com/facebook/react/pull/21008 | 831,971,132 | MDExOlB1bGxSZXF1ZXN0NTkzMjA4Mzk1 | 21,008 | [Fizz/Flight] Allow the streaming config to decide how to precompute or compute chunks | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 00d4f95c2ad000f40ea0c774cc1ced3a0ceb6f23...f1b37b284dcd420e68ef71c59d565bdb661f884d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-15 16:16:28 | 2021-03-15 17:36:24 | 2021-03-15 17:36:24 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21008', 'html_url': 'https://github.com/facebook/react/pull/21008', 'diff_url': 'https://github.com/facebook/react/pull/21008.diff', 'patch_url': 'https://github.com/facebook/react/pull/21008.patch', 'merged_at': datetime.datetime(2021, 3, 15, 17, 36, 24)} | Some legacy environments can not encode non-strings. Those would specify both as strings. We'll do something special for binary data there.
Some environments have to encode strings (like web streams). Those would encode both as Uint8Array.
Some environments (like Node) can do either. It can be beneficial to leave... | {'url': 'https://api.github.com/repos/facebook/react/issues/21008/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21008/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21007 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21007/labels{/name} | https://api.github.com/repos/facebook/react/issues/21007/comments | https://api.github.com/repos/facebook/react/issues/21007/events | https://github.com/facebook/react/issues/21007 | 831,755,575 | MDU6SXNzdWU4MzE3NTU1NzU= | 21,007 | Bug: firebase and service-workers.js caching | {'login': 'mattbara', 'id': 16991808, 'node_id': 'MDQ6VXNlcjE2OTkxODA4', 'avatar_url': 'https://avatars.githubusercontent.com/u/16991808?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mattbara', 'html_url': 'https://github.com/mattbara', 'followers_url': 'https://api.github.com/users/mattbara/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The correct place to report this issue, as mentioned in the description of this bug report, is https://github.com/facebook/create-react-app/\r\n\r\nPlease file this issue there. This repo is for React itself, not create-react-app.",
"@bvaughn thank you.\r\nNew issue, if anyone is interested, is here: https://gi... | 2021-03-15 12:20:32 | 2021-03-15 14:55:03 | 2021-03-15 13:44:58 | NONE | null | null | null | Hi,
I have caching issue when using Firebase Hosting and React service-workers.js.
I know this problem has been previously reported here: https://github.com/facebook/create-react-app/issues/2440 , but we are in 2021 and the solution suggested is not working.
The solution is to modify the firebase.json file with... | {'url': 'https://api.github.com/repos/facebook/react/issues/21007/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21007/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21006 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21006/labels{/name} | https://api.github.com/repos/facebook/react/issues/21006/comments | https://api.github.com/repos/facebook/react/issues/21006/events | https://github.com/facebook/react/issues/21006 | 831,644,553 | MDU6SXNzdWU4MzE2NDQ1NTM= | 21,006 | Bug: e.stopPropagation() not working with OnMouseOut. | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"There are hardly any details here. I don't think this is actionable."
] | 2021-03-15 10:03:15 | 2021-03-24 15:58:34 | 2021-03-24 15:58:34 | NONE | null | null | null | notice! it seems that if I change to onMouseLeave it's working fine.
<div onMouseEnter={(e)=>{
setIsHide(false)
{!isHide && <div className="tooltip" onMouseOut={(e)=>{
e.stopPropagation();
setIsHide(true);
}}>
<div style={{padding:"17px", background:"blue"}}>&... | {'url': 'https://api.github.com/repos/facebook/react/issues/21006/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21006/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21005 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21005/labels{/name} | https://api.github.com/repos/facebook/react/issues/21005/comments | https://api.github.com/repos/facebook/react/issues/21005/events | https://github.com/facebook/react/pull/21005 | 831,593,196 | MDExOlB1bGxSZXF1ZXN0NTkyODkwOTQ0 | 21,005 | Document prerequisites for download-experimental-build | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f227e7f26b81cb1eba0c837ab2acd7fa7f91404f...d2bbb86af46a49eece65511cc2cafa4190f7bec1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-15 09:06:53 | 2021-03-15 13:48:46 | 2021-03-15 13:48:45 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21005', 'html_url': 'https://github.com/facebook/react/pull/21005', 'diff_url': 'https://github.com/facebook/react/pull/21005.diff', 'patch_url': 'https://github.com/facebook/react/pull/21005.patch', 'merged_at': datetime.datetime(2021, 3, 15, 13, 48, 45)} | ## Summary
Following https://github.com/facebook/react/blob/461cd84944c28a5715a16a19f2503c87068832d6/packages/react-devtools-extensions/README.md#L23-L26 `./scripts/release/download-experimental-build.js` is not runnable since it's not mentioned that one has the install the nested workroot first.
## Test Plan
... | {'url': 'https://api.github.com/repos/facebook/react/issues/21005/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21005/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21004 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21004/labels{/name} | https://api.github.com/repos/facebook/react/issues/21004/comments | https://api.github.com/repos/facebook/react/issues/21004/events | https://github.com/facebook/react/pull/21004 | 831,365,474 | MDExOlB1bGxSZXF1ZXN0NTkyNjk1NTU0 | 21,004 | Update devtools-extensions build script to reflect changes in local b… | {'login': 'hecerinc', 'id': 7988472, 'node_id': 'MDQ6VXNlcjc5ODg0NzI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7988472?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hecerinc', 'html_url': 'https://github.com/hecerinc', 'followers_url': 'https://api.github.com/users/hecerinc/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f227e7f26b81cb1eba0c837ab2acd7fa7f91404f...e6ae3090d35424fd92508baadf5291dbf47a45da\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-15 03:06:42 | 2021-03-15 13:46:47 | 2021-03-15 13:46:47 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21004', 'html_url': 'https://github.com/facebook/react/pull/21004', 'diff_url': 'https://github.com/facebook/react/pull/21004.diff', 'patch_url': 'https://github.com/facebook/react/pull/21004.patch', 'merged_at': datetime.datetime(2021, 3, 15, 13, 46, 46)} | ## Summary
Updates the `react-devtools-extensions` build script to reflect changes in the local build directory structure. Specifically, the current build code assumes (in the webpack conf) the existence of `<repo_root>/build/node_modules` with either a local build or pulled from remote builds.
The changes made i... | {'url': 'https://api.github.com/repos/facebook/react/issues/21004/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21004/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21003 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21003/labels{/name} | https://api.github.com/repos/facebook/react/issues/21003/comments | https://api.github.com/repos/facebook/react/issues/21003/events | https://github.com/facebook/react/issues/21003 | 831,264,826 | MDU6SXNzdWU4MzEyNjQ4MjY= | 21,003 | Bug: Can't use TypeScript generics with React.memo | {'login': 'nicholaschiang', 'id': 20798889, 'node_id': 'MDQ6VXNlcjIwNzk4ODg5', 'avatar_url': 'https://avatars.githubusercontent.com/u/20798889?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nicholaschiang', 'html_url': 'https://github.com/nicholaschiang', 'followers_url': 'https://api.github.com/users/ni... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The React team does not maintain TypeScript type definitions. Those are maintained here: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react\r\n\r\nI suggest filing an issue in the DefinitelyTyped repo 👍🏼 "
] | 2021-03-14 21:28:05 | 2021-03-15 02:52:50 | 2021-03-15 02:52:50 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.1
## Steps To Reproduce
1. Clone [this repro](https://... | {'url': 'https://api.github.com/repos/facebook/react/issues/21003/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21003/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/21002 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21002/labels{/name} | https://api.github.com/repos/facebook/react/issues/21002/comments | https://api.github.com/repos/facebook/react/issues/21002/events | https://github.com/facebook/react/issues/21002 | 831,167,999 | MDU6SXNzdWU4MzExNjc5OTk= | 21,002 | Bug: Unsupported HTML entities | {'login': 'fast-reflexes', 'id': 2438128, 'node_id': 'MDQ6VXNlcjI0MzgxMjg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2438128?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fast-reflexes', 'html_url': 'https://github.com/fast-reflexes', 'followers_url': 'https://api.github.com/users/fast-re... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"It seems React Dom has backlisted some HTML entities due to XSS attacks. Even I came across this issue and read the documents and by using dom parser I can achieve those unsupported ones, you can have a look I have used Dom parser(you can also use setDangerouslysetInnerHtml) and it will output unsupported entities... | 2021-03-14 14:16:25 | 2024-04-10 14:20:44 | 2024-04-10 14:20:43 | NONE | null | null | null | Many of the HTML entities presented at https://dev.w3.org/html5/html-author/charref are not supported by React, why is this?
## Steps To Reproduce
Check https://codesandbox.io/s/react-unsupported-html-entities-yr9rj
## The current behavior
React recognizes some entities as string literals which may cause pr... | {'url': 'https://api.github.com/repos/facebook/react/issues/21002/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21002/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/21001 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21001/labels{/name} | https://api.github.com/repos/facebook/react/issues/21001/comments | https://api.github.com/repos/facebook/react/issues/21001/events | https://github.com/facebook/react/pull/21001 | 831,100,543 | MDExOlB1bGxSZXF1ZXN0NTkyNTAxNTM5 | 21,001 | Updated .gitignore to ignore the hprof files | {'login': 'Sheharyar566', 'id': 29799626, 'node_id': 'MDQ6VXNlcjI5Nzk5NjI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/29799626?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Sheharyar566', 'html_url': 'https://github.com/Sheharyar566', 'followers_url': 'https://api.github.com/users/Sheharya... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @Sheharyar566! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order ... | 2021-03-14 08:23:31 | 2022-07-24 06:07:13 | 2022-07-24 06:07:13 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/21001', 'html_url': 'https://github.com/facebook/react/pull/21001', 'diff_url': 'https://github.com/facebook/react/pull/21001.diff', 'patch_url': 'https://github.com/facebook/react/pull/21001.patch', 'merged_at': None} | Editing the gradle properties files to increase the heap introduces the hprof files to the android (therefore, adding it to .gitignore so that no one else gets in trouble with them like I did)
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provid... | {'url': 'https://api.github.com/repos/facebook/react/issues/21001/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21001/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/21000 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/21000/labels{/name} | https://api.github.com/repos/facebook/react/issues/21000/comments | https://api.github.com/repos/facebook/react/issues/21000/events | https://github.com/facebook/react/issues/21000 | 831,034,581 | MDU6SXNzdWU4MzEwMzQ1ODE= | 21,000 | Bug: Anchors tags are not working in chromium browser | {'login': 'Xdev200', 'id': 65798140, 'node_id': 'MDQ6VXNlcjY1Nzk4MTQw', 'avatar_url': 'https://avatars.githubusercontent.com/u/65798140?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Xdev200', 'html_url': 'https://github.com/Xdev200', 'followers_url': 'https://api.github.com/users/Xdev200/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hm. This doesn't repro for me, but...worth someone looking into. 😄\r\n\r\nThat being said, please file this on the docs repo: https://github.com/reactjs/reactjs.org\r\n\r\nA different team of maintainers check and work on those issues."
] | 2021-03-14 00:48:29 | 2021-03-14 20:11:45 | 2021-03-14 20:11:27 | NONE | null | null | null | ERROR: type should be string, got "\r\n https://reactjs.org/docs/hooks-reference.html\r\nAnchor Tags are not working in the above link in the chromium-browser. \r\nBut, It only works when we open the developer tool.\r\n\r\n\r\n\r\n## Steps To Reproduce\r\n\r\n1. open the link - https://reactjs.org/docs/hooks-reference.html\r\n\r\n\r\n\r\n" | {'url': 'https://api.github.com/repos/facebook/react/issues/21000/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/21000/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/20999 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/20999/labels{/name} | https://api.github.com/repos/facebook/react/issues/20999/comments | https://api.github.com/repos/facebook/react/issues/20999/events | https://github.com/facebook/react/issues/20999 | 831,000,063 | MDU6SXNzdWU4MzEwMDAwNjM= | 20,999 | Bug: preventDefault on `onTouchMove` is not preventing scrolling on iOS | {'login': 'MadsHornbeck', 'id': 2675235, 'node_id': 'MDQ6VXNlcjI2NzUyMzU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2675235?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MadsHornbeck', 'html_url': 'https://github.com/MadsHornbeck', 'followers_url': 'https://api.github.com/users/MadsHornbe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Thanks for the report.\r\n\r\n`onTouchMove` is passive by default i.e. `cancelable` is `false`. This is intended behavior to follow Chrome's interventation with scroll/touch events on the `document`.\r\n\r\nFor more context, check out https://github.com/facebook/react/issues/19651"
] | 2021-03-13 21:27:35 | 2021-03-14 14:07:56 | 2021-03-14 14:07:52 | NONE | null | null | null | Adding a `onTouchMove` handler that calls `preventDefault` is expected to stop scrolling on iOS but doesn't.
If the same is done by manually adding the event using a ref and `addEventListener` has the expected behavior of not scrolling the page.
React version: 17.0.1
iOS safari version: 14.4
## Steps To Reprodu... | {'url': 'https://api.github.com/repos/facebook/react/issues/20999/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/20999/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/20998 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/20998/labels{/name} | https://api.github.com/repos/facebook/react/issues/20998/comments | https://api.github.com/repos/facebook/react/issues/20998/events | https://github.com/facebook/react/pull/20998 | 830,969,727 | MDExOlB1bGxSZXF1ZXN0NTkyNDExMDQ3 | 20,998 | [FB-only] Show which hooks (indices) changed when profiling | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1d1e49cfa453b58769e87c3c8d321024d58c948f...826a5da04a32b24125eb6568020983107255a217\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-13 19:11:07 | 2023-12-22 17:26:38 | 2021-03-17 16:28:21 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/20998', 'html_url': 'https://github.com/facebook/react/pull/20998', 'diff_url': 'https://github.com/facebook/react/pull/20998.diff', 'patch_url': 'https://github.com/facebook/react/pull/20998.patch', 'merged_at': datetime.datetime(2021, 3, 17, 16, 28, 21)} | I don't think this feature is broadly useful or user friendly, but @bgirard and I chatted about it and he said that it would significantly speed up his performance investigation process. I have enabled it only for Facebook DevTools builds (using the feature flag system I recently added). This is the first feature to ac... | {'url': 'https://api.github.com/repos/facebook/react/issues/20998/reactions', 'total_count': 14, '+1': 13, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/20998/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/20997 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/20997/labels{/name} | https://api.github.com/repos/facebook/react/issues/20997/comments | https://api.github.com/repos/facebook/react/issues/20997/events | https://github.com/facebook/react/issues/20997 | 830,956,087 | MDU6SXNzdWU4MzA5NTYwODc= | 20,997 | Bug: Can't build react-devtools-extensions | {'login': 'hecerinc', 'id': 7988472, 'node_id': 'MDQ6VXNlcjc5ODg0NzI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7988472?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hecerinc', 'html_url': 'https://github.com/hecerinc', 'followers_url': 'https://api.github.com/users/hecerinc/followers', '... | [{'id': 71502270, 'node_id': 'MDU6TGFiZWw3MTUwMjI3MA==', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Build%20Infrastructure', 'name': 'Component: Build Infrastructure', 'color': 'f9d0c4', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': ... | closed | false | null | [] | null | [
"Does it work if you download the latest React build rather than building it locally? The README also [shows how to do that](https://github.com/facebook/react/blob/master/packages/react-devtools-extensions/README.md#download-from-ci).\r\n\r\nI don't have a Windows machine so this isn't something I'll be likely to t... | 2021-03-13 18:15:02 | 2021-03-15 13:46:46 | 2021-03-15 13:46:46 | CONTRIBUTOR | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
I've just cloned the repo, ran `yarn`, and then `yarn build-for-devtools` as exp... | {'url': 'https://api.github.com/repos/facebook/react/issues/20997/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/20997/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/20996 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/20996/labels{/name} | https://api.github.com/repos/facebook/react/issues/20996/comments | https://api.github.com/repos/facebook/react/issues/20996/events | https://github.com/facebook/react/pull/20996 | 830,922,084 | MDExOlB1bGxSZXF1ZXN0NTkyMzc5MTE5 | 20,996 | Remove data-reactroot from server rendering and hydration heuristic | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 46491dce96e6a151706f51494edfd3cb7f09ed7f...f8c082709076f1d5ddcac41a66ed06ab25385374\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-13 15:24:37 | 2021-05-13 17:18:21 | 2021-05-13 17:18:21 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/20996', 'html_url': 'https://github.com/facebook/react/pull/20996', 'diff_url': 'https://github.com/facebook/react/pull/20996.diff', 'patch_url': 'https://github.com/facebook/react/pull/20996.patch', 'merged_at': datetime.datetime(2021, 5, 13, 17, 18, 21)} | This was used to implicitly hydrate if you call ReactDOM.render.
We've had a warning to explicitly use ReactDOM.hydrate(...) instead of ReactDOM.render(...). We can now remove this from the generated markup. (And avoid adding it to Fizz.)
This is a little strange to do now since we're trying hard to make the root... | {'url': 'https://api.github.com/repos/facebook/react/issues/20996/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/20996/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/20995 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/20995/labels{/name} | https://api.github.com/repos/facebook/react/issues/20995/comments | https://api.github.com/repos/facebook/react/issues/20995/events | https://github.com/facebook/react/pull/20995 | 830,917,187 | MDExOlB1bGxSZXF1ZXN0NTkyMzc1NzE5 | 20,995 | Clean up unused functions from SSR | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f2b6bf7c86f01ca194914e0e4305d8f430024a8c...a346344ad1782e5c03e59efb03492c2c3adb6981\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-13 15:00:58 | 2021-03-13 15:23:06 | 2021-03-13 15:23:06 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/20995', 'html_url': 'https://github.com/facebook/react/pull/20995', 'diff_url': 'https://github.com/facebook/react/pull/20995.diff', 'patch_url': 'https://github.com/facebook/react/pull/20995.patch', 'merged_at': datetime.datetime(2021, 3, 13, 15, 23, 6)} | We don't use react-id anymore. | {'url': 'https://api.github.com/repos/facebook/react/issues/20995/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/20995/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/20994 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/20994/labels{/name} | https://api.github.com/repos/facebook/react/issues/20994/comments | https://api.github.com/repos/facebook/react/issues/20994/events | https://github.com/facebook/react/pull/20994 | 830,914,467 | MDExOlB1bGxSZXF1ZXN0NTkyMzczODQz | 20,994 | [Fizz] Move DOM/Native format configs to their respective packages | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f2b6bf7c86f01ca194914e0e4305d8f430024a8c...bbcf4d1eacd70ce4fc25bf06437922c197c908b5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-13 14:47:54 | 2021-03-13 14:55:00 | 2021-03-13 14:54:59 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/20994', 'html_url': 'https://github.com/facebook/react/pull/20994', 'diff_url': 'https://github.com/facebook/react/pull/20994.diff', 'patch_url': 'https://github.com/facebook/react/pull/20994.patch', 'merged_at': datetime.datetime(2021, 3, 13, 14, 54, 59)} | These should only be used by the one package. Moving them also lets us use local dependencies like escapeTextForBrowser.
The streaming configs (Node/Browser) are different because they operate at another dimension that exists in each package.
| {'url': 'https://api.github.com/repos/facebook/react/issues/20994/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/20994/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/20993 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/20993/labels{/name} | https://api.github.com/repos/facebook/react/issues/20993/comments | https://api.github.com/repos/facebook/react/issues/20993/events | https://github.com/facebook/react/pull/20993 | 830,847,896 | MDExOlB1bGxSZXF1ZXN0NTkyMzI0NDQ2 | 20,993 | FiiPractic Test | {'login': 'airimovici', 'id': 51707553, 'node_id': 'MDQ6VXNlcjUxNzA3NTUz', 'avatar_url': 'https://avatars.githubusercontent.com/u/51707553?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/airimovici', 'html_url': 'https://github.com/airimovici', 'followers_url': 'https://api.github.com/users/airimovici/fol... | [] | closed | false | null | [] | null | [
"Hi @airimovici! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order fo... | 2021-03-13 09:00:01 | 2021-03-13 09:04:54 | 2021-03-13 09:00:27 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/20993', 'html_url': 'https://github.com/facebook/react/pull/20993', 'diff_url': 'https://github.com/facebook/react/pull/20993.diff', 'patch_url': 'https://github.com/facebook/react/pull/20993.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/20993/reactions', 'total_count': 1, '+1': 0, '-1': 1, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/20993/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/20992 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/20992/labels{/name} | https://api.github.com/repos/facebook/react/issues/20992/comments | https://api.github.com/repos/facebook/react/issues/20992/events | https://github.com/facebook/react/pull/20992 | 830,562,857 | MDExOlB1bGxSZXF1ZXN0NTkyMDY2ODI4 | 20,992 | [Fizz] Destroy the stream with an error if the root throws | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 10cc400184dfa3d5d3eb8b2e10903b87b9489cb8...91d2ed0636ac425dfc8ece448db66392dff7ab03\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2021-03-12 22:16:24 | 2021-03-13 13:55:27 | 2021-03-12 23:21:02 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/20992', 'html_url': 'https://github.com/facebook/react/pull/20992', 'diff_url': 'https://github.com/facebook/react/pull/20992.diff', 'patch_url': 'https://github.com/facebook/react/pull/20992.patch', 'merged_at': datetime.datetime(2021, 3, 12, 23, 21, 2)} | ...but not if the error happens inside a suspense boundary.
This is mostly a courtesy but it's also important for preserving legacy behavior. It's also for catching bugs in React itself that isn't inside a rendering subtree.
The main way of logging an error will be through a separate callback. Since we can log er... | {'url': 'https://api.github.com/repos/facebook/react/issues/20992/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/20992/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/20991 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/20991/labels{/name} | https://api.github.com/repos/facebook/react/issues/20991/comments | https://api.github.com/repos/facebook/react/issues/20991/events | https://github.com/facebook/react/issues/20991 | 830,494,714 | MDU6SXNzdWU4MzA0OTQ3MTQ= | 20,991 | Bug: setState behaves sync when inside a promise callback and async when not. | {'login': 'jasongornall', 'id': 6912393, 'node_id': 'MDQ6VXNlcjY5MTIzOTM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6912393?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jasongornall', 'html_url': 'https://github.com/jasongornall', 'followers_url': 'https://api.github.com/users/jasongorna... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"I recognize https://reactjs.org/docs/react-component.html#setstate This states that it **does not always immediately update the component** but when does it decide to do that and why? I'm worried this can lead to accidental bugs if this is non deterministic. Is there a way to force this to always be async for deve... | 2021-03-12 21:31:33 | 2021-03-13 20:50:52 | 2021-03-13 08:13:24 | NONE | null | null | null | <!--
behaves async when inside a promise calback and sync when not.
-->
```jsx
import ReactDOM from "react-dom";
import React, { useState } from "react";
import "./styles.css";
class Hello extends React.Component {
constructor() {
super();
this.state = { data: [] };
}
async fetchJoke(... | {'url': 'https://api.github.com/repos/facebook/react/issues/20991/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/20991/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/20990 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/20990/labels{/name} | https://api.github.com/repos/facebook/react/issues/20990/comments | https://api.github.com/repos/facebook/react/issues/20990/events | https://github.com/facebook/react/issues/20990 | 830,331,726 | MDU6SXNzdWU4MzAzMzE3MjY= | 20,990 | Bug: performing input.select() in IE11 throws a React error | {'login': 'Dremora', 'id': 242202, 'node_id': 'MDQ6VXNlcjI0MjIwMg==', 'avatar_url': 'https://avatars.githubusercontent.com/u/242202?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Dremora', 'html_url': 'https://github.com/Dremora', 'followers_url': 'https://api.github.com/users/Dremora/followers', 'follow... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 69105383, 'node_id': 'MDU6TGFiZWw2OTEwNTM4Mw==', 'url': 'https://api.github.com/repos/facebook/react/la... | closed | false | null | [] | null | [
"Codesandbox: https://codesandbox.io/s/serene-kapitsa-mw16s\r\nDeploy for IE 11 testing: https://csb-mw16s.netlify.app/\r\n\r\nInvariant is https://reactjs.org/docs/error-decoder.html?invariant=327\r\n\r\nConsole log when replaying:\r\n```\r\nSCRIPT16389: Unspecified error.\r\nreact-dom.production.min.js (123,157)\... | 2021-03-12 17:51:22 | 2022-03-29 23:06:17 | 2022-03-29 23:06:16 | NONE | null | null | null | The example below is extracted from the app with a spreadsheet-like UI, where cells become editable upon focus (can be achieved either by tabbing into the cells or clicking). The text in such cell immediately becomes selected.
The bug occurs only in IE11, as the user navigates from one such cell to another by clicki... | {'url': 'https://api.github.com/repos/facebook/react/issues/20990/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/20990/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/20989 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/20989/labels{/name} | https://api.github.com/repos/facebook/react/issues/20989/comments | https://api.github.com/repos/facebook/react/issues/20989/events | https://github.com/facebook/react/issues/20989 | 829,953,485 | MDU6SXNzdWU4Mjk5NTM0ODU= | 20,989 | Error: "getCommitTree(): Unable to reconstruct tree for root "1" and commit 7" | {'login': 'mungojam', 'id': 3154635, 'node_id': 'MDQ6VXNlcjMxNTQ2MzU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3154635?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mungojam', 'html_url': 'https://github.com/mungojam', 'followers_url': 'https://api.github.com/users/mungojam/followers', '... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/la... | closed | false | null | [] | null | [
"I'm sorry you experienced this bug! 🙇 \r\n\r\nLooks like this problem was already reported though (#19602) so I'm going to mark this issue as a duplicate and close it. If you have additional context that might help us repro this problem, please leave a comment on the other issue!\r\n\r\n(I understand that it's di... | 2021-03-12 10:01:53 | 2021-04-28 17:35:14 | 2021-03-13 17:18:05 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. Record a profile
2. Click on one of the stack frames
3. The error came up
I'll struggle to reproduce as the first time I did a profile against the same site this didn't happen and the code is not publishable
---------------------------------------------
P... | {'url': 'https://api.github.com/repos/facebook/react/issues/20989/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/20989/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/20988 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/20988/labels{/name} | https://api.github.com/repos/facebook/react/issues/20988/comments | https://api.github.com/repos/facebook/react/issues/20988/events | https://github.com/facebook/react/issues/20988 | 829,781,579 | MDU6SXNzdWU4Mjk3ODE1Nzk= | 20,988 | Bug: React appends element twice when using `document.doby.appendChild()` | {'login': 'realJustinLee', 'id': 17794470, 'node_id': 'MDQ6VXNlcjE3Nzk0NDcw', 'avatar_url': 'https://avatars.githubusercontent.com/u/17794470?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/realJustinLee', 'html_url': 'https://github.com/realJustinLee', 'followers_url': 'https://api.github.com/users/realJ... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Thanks for the report.\r\n\r\nYou're calling `document.body.appendChild(link);` in the constructor of a class component. The constructor must not have any side-effects. Rendering in StrictMode will cause React to call the constructor twice to detect these side-effects. More information about StrictMode behavior ca... | 2021-03-12 05:49:52 | 2021-03-12 08:33:32 | 2021-03-12 08:33:26 | NONE | null | null | null | React appends element twice when using `document.doby.appendChild()`
React version: 17.0.1
## Steps To Reproduce
1. Create a sample app with nix with the following code:
```
npx create-react-app test
```
2. Add a child element to the document with `document.doby.appendChild()` like demonstrat... | {'url': 'https://api.github.com/repos/facebook/react/issues/20988/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/20988/timeline | null | completed | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.