url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/19656 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19656/labels{/name} | https://api.github.com/repos/facebook/react/issues/19656/comments | https://api.github.com/repos/facebook/react/issues/19656/events | https://github.com/facebook/react/issues/19656 | 682,266,530 | MDU6SXNzdWU2ODIyNjY1MzA= | 19,656 | Bug: Running "yarn run build" failed due to missing java environment (Windows 10) | {'login': 'adibiton', 'id': 1072195, 'node_id': 'MDQ6VXNlcjEwNzIxOTU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1072195?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/adibiton', 'html_url': 'https://github.com/adibiton', 'followers_url': 'https://api.github.com/users/adibiton/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Java is required because we use the Java version of the Google closure compiler to optimize our production bundles. We used to use the JavaScript version, but it was **very slow** and also required a lot of system resources to run (>16GB of RAM).\r\n\r\nThe [contributing guide](https://reactjs.org/docs/how-to-cont... | 2020-08-20 00:33:00 | 2020-08-20 01:55:26 | 2020-08-20 01:55:26 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
16.13.1
## Steps To Reproduce
1. Clone the repo to a machine... | {'url': 'https://api.github.com/repos/facebook/react/issues/19656/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19656/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19655 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19655/labels{/name} | https://api.github.com/repos/facebook/react/issues/19655/comments | https://api.github.com/repos/facebook/react/issues/19655/events | https://github.com/facebook/react/pull/19655 | 682,132,670 | MDExOlB1bGxSZXF1ZXN0NDcwNDE2MDU1 | 19,655 | Revert "Remove onScroll bubbling flag (#19535)" | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19655/builds/47418) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-19 19:45:50 | 2020-08-19 19:54:55 | 2020-08-19 19:54:55 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19655', 'html_url': 'https://github.com/facebook/react/pull/19655', 'diff_url': 'https://github.com/facebook/react/pull/19655.diff', 'patch_url': 'https://github.com/facebook/react/pull/19655.patch', 'merged_at': datetime.datetime(2020, 8, 19, 19, 54, 55)} | This reverts commit e9721e14e4b8776c107afa3cdd7c6d664fe20c24.
This is just for temporary internal testing of a possible regression. It stays on for open source. | {'url': 'https://api.github.com/repos/facebook/react/issues/19655/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19655/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19654 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19654/labels{/name} | https://api.github.com/repos/facebook/react/issues/19654/comments | https://api.github.com/repos/facebook/react/issues/19654/events | https://github.com/facebook/react/pull/19654 | 681,984,100 | MDExOlB1bGxSZXF1ZXN0NDcwMjg1OTY3 | 19,654 | Keep onTouchStart, onTouchMove, and onWheel passive | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19654/builds/47384) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-19 16:37:17 | 2020-08-20 01:58:39 | 2020-08-19 17:42:34 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19654', 'html_url': 'https://github.com/facebook/react/pull/19654', 'diff_url': 'https://github.com/facebook/react/pull/19654.diff', 'patch_url': 'https://github.com/facebook/react/pull/19654.patch', 'merged_at': datetime.datetime(2020, 8, 19, 17, 42, 33)} | Resolves https://github.com/facebook/react/issues/19651.
This means that `e.preventDefault()` in them stays broken, like it was in React 16 due to Chrome's intervention, even though we've switched from putting them on the `document` to putting them on the root.
This makes React 17 match the React 16 behavior clos... | {'url': 'https://api.github.com/repos/facebook/react/issues/19654/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19654/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19653 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19653/labels{/name} | https://api.github.com/repos/facebook/react/issues/19653/comments | https://api.github.com/repos/facebook/react/issues/19653/events | https://github.com/facebook/react/issues/19653 | 681,974,049 | MDU6SXNzdWU2ODE5NzQwNDk= | 19,653 | Bug: Child Component State Updates Applied to Last Sibling Instead of Correct One | {'login': 'simps7b2', 'id': 9396004, 'node_id': 'MDQ6VXNlcjkzOTYwMDQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9396004?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/simps7b2', 'html_url': 'https://github.com/simps7b2', 'followers_url': 'https://api.github.com/users/simps7b2/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You forgot to put `let` or `const` before destructuring so you declared global variables by accident.\r\nThis is a fixed version. https://jsfiddle.net/gw94maky/",
"Ah, I see. Many thanks."
] | 2020-08-19 16:20:26 | 2020-08-19 20:16:31 | 2020-08-19 17:00:23 | NONE | null | null | null | I have a grid component that I am writing where a user is supposed to be able to click on a row and have that row transform into edit mode. A row in the grid is itself a component. I accomplish the transformation within the row component using the click event on cells that are editable. Once the click event fires on an... | {'url': 'https://api.github.com/repos/facebook/react/issues/19653/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19653/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19652 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19652/labels{/name} | https://api.github.com/repos/facebook/react/issues/19652/comments | https://api.github.com/repos/facebook/react/issues/19652/events | https://github.com/facebook/react/pull/19652 | 681,908,424 | MDExOlB1bGxSZXF1ZXN0NDcwMjIxODE0 | 19,652 | Remove some unnecessary repetition | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 98e5ba74dd3f25bc759607c... | 2020-08-19 14:57:16 | 2020-08-19 17:49:33 | 2020-08-19 15:26:53 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19652', 'html_url': 'https://github.com/facebook/react/pull/19652', 'diff_url': 'https://github.com/facebook/react/pull/19652.diff', 'patch_url': 'https://github.com/facebook/react/pull/19652.patch', 'merged_at': None} | Resolves #19650 | {'url': 'https://api.github.com/repos/facebook/react/issues/19652/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19652/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19651 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19651/labels{/name} | https://api.github.com/repos/facebook/react/issues/19651/comments | https://api.github.com/repos/facebook/react/issues/19651/events | https://github.com/facebook/react/issues/19651 | 681,891,694 | MDU6SXNzdWU2ODE4OTE2OTQ= | 19,651 | Touch/Wheel Event Passiveness in React 17 | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"We briefly discussed with @sebmarkbage and since the goal of 17 is to be as close to 16 as possible (while fixing interop), we're going to emulate Chrome's behavior and treat these as passive by default when attaching to roots. This doesn't solve the usability issue but that's orthogonal to the 17 release and shou... | 2020-08-19 14:35:07 | 2020-08-19 17:42:34 | 2020-08-19 17:42:34 | COLLABORATOR | null | null | null | Chrome did an ["intervention"](https://developers.google.com/web/updates/2017/01/scrolling-intervention) back in the day, breaking all React touch and wheel listeners which used `e.preventDefault()` (https://github.com/facebook/react/issues/14856) because React happened to attach them to the `document`.
In React 17,... | {'url': 'https://api.github.com/repos/facebook/react/issues/19651/reactions', 'total_count': 8, '+1': 8, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19651/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19650 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19650/labels{/name} | https://api.github.com/repos/facebook/react/issues/19650/comments | https://api.github.com/repos/facebook/react/issues/19650/events | https://github.com/facebook/react/issues/19650 | 681,883,600 | MDU6SXNzdWU2ODE4ODM2MDA= | 19,650 | Bug: | {'login': 'jiang-zhong-xi', 'id': 59865643, 'node_id': 'MDQ6VXNlcjU5ODY1NjQz', 'avatar_url': 'https://avatars.githubusercontent.com/u/59865643?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jiang-zhong-xi', 'html_url': 'https://github.com/jiang-zhong-xi', 'followers_url': 'https://api.github.com/users/ji... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"I believe this issue is referring to the following lines:\r\n\r\nhttps://github.com/facebook/react/blob/87b3e2d257e49b6d2c8e662830fc8f3c7d62f85f/packages/react-dom/src/client/ReactDOMComponent.js#L412-L415\r\n\r\nhttps://github.com/facebook/react/blob/87b3e2d257e49b6d2c8e662830fc8f3c7d62f85f/packages/react-dom/src... | 2020-08-19 14:24:30 | 2020-08-19 15:27:36 | 2020-08-19 15:27:36 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.6.1
## Steps To Reproduce
1. open source code（src\react\... | {'url': 'https://api.github.com/repos/facebook/react/issues/19650/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19650/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19649 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19649/labels{/name} | https://api.github.com/repos/facebook/react/issues/19649/comments | https://api.github.com/repos/facebook/react/issues/19649/events | https://github.com/facebook/react/issues/19649 | 681,874,090 | MDU6SXNzdWU2ODE4NzQwOTA= | 19,649 | Bug: (17.0.0-rc.0) No changes to Native Component Stacks in production environment | {'login': 'tjvantoll', 'id': 544280, 'node_id': 'MDQ6VXNlcjU0NDI4MA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/544280?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tjvantoll', 'html_url': 'https://github.com/tjvantoll', 'followers_url': 'https://api.github.com/users/tjvantoll/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"I think the difference should be in what you get in `componentStack` prop in `ErrorBoundary` (since you use that component). Not the `message`.",
"@gaearon Thanks for the reply. Just tried manually logging that with this code.\r\n\r\n``` JavaScript\r\nfunction ErrorFallback({ componentStack }) {\r\n console.log... | 2020-08-19 14:12:42 | 2021-03-24 19:03:17 | 2021-03-24 19:03:17 | NONE | null | null | null | The React 17 RC blog post states “In React 17, the component stacks are generated using a different mechanism that stitches them together from the regular native JavaScript stacks. This lets you get the fully symbolicated React component stack traces in a production environment.”
I’ve been trying to see a difference... | {'url': 'https://api.github.com/repos/facebook/react/issues/19649/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19649/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19648 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19648/labels{/name} | https://api.github.com/repos/facebook/react/issues/19648/comments | https://api.github.com/repos/facebook/react/issues/19648/events | https://github.com/facebook/react/pull/19648 | 681,866,536 | MDExOlB1bGxSZXF1ZXN0NDcwMTg2NzE0 | 19,648 | Failing test for #19608 | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19648/builds/47341) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-19 14:02:33 | 2021-02-11 16:33:57 | 2021-02-11 16:33:57 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/19648', 'html_url': 'https://github.com/facebook/react/pull/19648', 'diff_url': 'https://github.com/facebook/react/pull/19648.diff', 'patch_url': 'https://github.com/facebook/react/pull/19648.patch', 'merged_at': None} | Test from https://github.com/facebook/react/issues/19608#issuecomment-674157239. | {'url': 'https://api.github.com/repos/facebook/react/issues/19648/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19648/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19647 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19647/labels{/name} | https://api.github.com/repos/facebook/react/issues/19647/comments | https://api.github.com/repos/facebook/react/issues/19647/events | https://github.com/facebook/react/pull/19647 | 681,863,049 | MDExOlB1bGxSZXF1ZXN0NDcwMTgzODEz | 19,647 | Upgrade all @babel/* packages to fix DevTools builds | {'login': 'taneliang', 'id': 12784593, 'node_id': 'MDQ6VXNlcjEyNzg0NTkz', 'avatar_url': 'https://avatars.githubusercontent.com/u/12784593?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/taneliang', 'html_url': 'https://github.com/taneliang', 'followers_url': 'https://api.github.com/users/taneliang/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19647/builds/47338) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-19 13:58:06 | 2020-08-20 15:47:17 | 2020-08-20 15:47:17 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19647', 'html_url': 'https://github.com/facebook/react/pull/19647', 'diff_url': 'https://github.com/facebook/react/pull/19647.diff', 'patch_url': 'https://github.com/facebook/react/pull/19647.patch', 'merged_at': datetime.datetime(2020, 8, 20, 15, 47, 17)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19647/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19647/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19646 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19646/labels{/name} | https://api.github.com/repos/facebook/react/issues/19646/comments | https://api.github.com/repos/facebook/react/issues/19646/events | https://github.com/facebook/react/issues/19646 | 681,815,606 | MDU6SXNzdWU2ODE4MTU2MDY= | 19,646 | instance.render is not a function in react-dom.development.js:17160 while using this.props.children | {'login': 'sachintyagi', 'id': 763368, 'node_id': 'MDQ6VXNlcjc2MzM2OA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/763368?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sachintyagi', 'html_url': 'https://github.com/sachintyagi', 'followers_url': 'https://api.github.com/users/sachintyagi/fol... | [] | closed | false | null | [] | null | [
"This seems like a mistake:\r\n\r\n```js\r\nconst AppRoute = ({component: Comment\r\n```\r\n\r\nWhy are you renaming `component` to `Comment`? (Did you mean `Component`?) Instead the `<Component>` getting used is `Component` you imported from `React`, which is a base class without a `render` method. Hence the error... | 2020-08-19 12:52:15 | 2020-08-19 13:03:48 | 2020-08-19 12:58:10 | NONE | null | null | null | Getting below error while using {this.props.children} in component file.
**TypeError: instance.render is not a function**
finishClassComponent
D:/myreactapp/node_modules/react-dom/cjs/react-dom.development.js:17160
17157 | } else {
17158 | {
17159 | setIsRendering(true);
> 17160 | nextChildren... | {'url': 'https://api.github.com/repos/facebook/react/issues/19646/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19646/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19645 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19645/labels{/name} | https://api.github.com/repos/facebook/react/issues/19645/comments | https://api.github.com/repos/facebook/react/issues/19645/events | https://github.com/facebook/react/issues/19645 | 681,710,256 | MDU6SXNzdWU2ODE3MTAyNTY= | 19,645 | Deepcode.ai found 67 issues, 4 of which are critical ( security and defects ) | {'login': 'j-sp4', 'id': 13295935, 'node_id': 'MDQ6VXNlcjEzMjk1OTM1', 'avatar_url': 'https://avatars.githubusercontent.com/u/13295935?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/j-sp4', 'html_url': 'https://github.com/j-sp4', 'followers_url': 'https://api.github.com/users/j-sp4/followers', 'following_... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"Please don’t create 67 issues. :-)\r\n\r\nIt looks like a bunch are coming from `fixtures` and `scripts`. For the most part, except for build scripts, we don’t care about those. They are intentionally not production grade because they’re only used for our own testing.\r\n\r\nPlease feel free to file issues for thi... | 2020-08-19 09:59:33 | 2021-03-24 19:02:51 | 2021-03-24 19:02:51 | NONE | null | null | null | After running react through [deepcode.ai] (https://www.deepcode.ai/app/gh/facebook/react/d7feeb25ac8cc23133c294fa01932658023130c0/_/dashboard) 67 issues were found, I think integrating deepcode into the pipeline and into pull requests would be a good idea. Should I create a separate issue for each issue? | {'url': 'https://api.github.com/repos/facebook/react/issues/19645/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19645/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19644 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19644/labels{/name} | https://api.github.com/repos/facebook/react/issues/19644/comments | https://api.github.com/repos/facebook/react/issues/19644/events | https://github.com/facebook/react/issues/19644 | 681,599,536 | MDU6SXNzdWU2ODE1OTk1MzY= | 19,644 | Bug: react-hooks/exhaustive-deps does not recognize different signaturres | {'login': 'swissspidy', 'id': 841956, 'node_id': 'MDQ6VXNlcjg0MTk1Ng==', 'avatar_url': 'https://avatars.githubusercontent.com/u/841956?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/swissspidy', 'html_url': 'https://github.com/swissspidy', 'followers_url': 'https://api.github.com/users/swissspidy/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-08-19 07:01:23 | 2024-04-11 06:04:03 | null | NONE | null | null | null | `eslint-plugin-react-hooks` version: 4.1.2
## Steps To Reproduce
The current `additionalHooks` in the react-hooks/exhaustive-deps eslint plugin accepts a regular expression to match hook names. It always assumes the following format:
```
function useCustomHook(callback, deps) {}
```
However, this format ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19644/reactions', 'total_count': 10, '+1': 6, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 4, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19644/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/19643 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19643/labels{/name} | https://api.github.com/repos/facebook/react/issues/19643/comments | https://api.github.com/repos/facebook/react/issues/19643/events | https://github.com/facebook/react/pull/19643 | 681,504,140 | MDExOlB1bGxSZXF1ZXN0NDY5ODg2OTUw | 19,643 | Use Global Render Timeout for CPU Suspense | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19643/builds/47236) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-19 02:44:45 | 2020-08-21 23:12:48 | 2020-08-20 21:39:30 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19643', 'html_url': 'https://github.com/facebook/react/pull/19643', 'diff_url': 'https://github.com/facebook/react/pull/19643.diff', 'patch_url': 'https://github.com/facebook/react/pull/19643.patch', 'merged_at': datetime.datetime(2020, 8, 20, 21, 39, 29)} | We have a heuristic in SuspenseList for "CPU Suspense" when a render takes too long. The start time that is used for this calculation isn't very good because it's based on when the list started rendering but really it should be when the whole render started.
We've talked about using the event time as the start time ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19643/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19643/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19642 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19642/labels{/name} | https://api.github.com/repos/facebook/react/issues/19642/comments | https://api.github.com/repos/facebook/react/issues/19642/events | https://github.com/facebook/react/pull/19642 | 681,284,085 | MDExOlB1bGxSZXF1ZXN0NDY5Njk3NjI4 | 19,642 | Reproducing CI missing this test failure | {'login': 'dvargas92495', 'id': 7143571, 'node_id': 'MDQ6VXNlcjcxNDM1NzE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7143571?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dvargas92495', 'html_url': 'https://github.com/dvargas92495', 'followers_url': 'https://api.github.com/users/dvargas924... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against f850fd765c23e281bf39621... | 2020-08-18 19:35:23 | 2020-08-18 20:38:20 | 2020-08-18 20:38:15 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19642', 'html_url': 'https://github.com/facebook/react/pull/19642', 'diff_url': 'https://github.com/facebook/react/pull/19642.diff', 'patch_url': 'https://github.com/facebook/react/pull/19642.patch', 'merged_at': None} | ## Summary
Looking to address this issue https://github.com/facebook/react/issues/19229 and use it as my first foray into contributing to open source :)
## Test Plan
The first commit simply attempts to reproduce the issue. When I looked back at the CI run [found here](https://app.circleci.com/pipelines/github/... | {'url': 'https://api.github.com/repos/facebook/react/issues/19642/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19642/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19641 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19641/labels{/name} | https://api.github.com/repos/facebook/react/issues/19641/comments | https://api.github.com/repos/facebook/react/issues/19641/events | https://github.com/facebook/react/pull/19641 | 681,257,651 | MDExOlB1bGxSZXF1ZXN0NDY5Njc1NDQw | 19,641 | Updated ReadMe docs | {'login': 'harjeevs17', 'id': 38102297, 'node_id': 'MDQ6VXNlcjM4MTAyMjk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/38102297?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/harjeevs17', 'html_url': 'https://github.com/harjeevs17', 'followers_url': 'https://api.github.com/users/harjeevs17/fol... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19641/builds/47134) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-18 18:50:10 | 2022-01-09 08:42:11 | 2022-01-09 08:42:11 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19641', 'html_url': 'https://github.com/facebook/react/pull/19641', 'diff_url': 'https://github.com/facebook/react/pull/19641.diff', 'patch_url': 'https://github.com/facebook/react/pull/19641.patch', 'merged_at': None} | Updated the ReadMe docs | {'url': 'https://api.github.com/repos/facebook/react/issues/19641/reactions', 'total_count': 8, '+1': 0, '-1': 8, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19641/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19640 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19640/labels{/name} | https://api.github.com/repos/facebook/react/issues/19640/comments | https://api.github.com/repos/facebook/react/issues/19640/events | https://github.com/facebook/react/pull/19640 | 681,223,719 | MDExOlB1bGxSZXF1ZXN0NDY5NjQ3ODUw | 19,640 | fix: property list values should show whitespace | {'login': 'sammarks', 'id': 424093, 'node_id': 'MDQ6VXNlcjQyNDA5Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/424093?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sammarks', 'html_url': 'https://github.com/sammarks', 'followers_url': 'https://api.github.com/users/sammarks/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19640/builds/47115) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-18 17:50:20 | 2020-08-19 13:21:46 | 2020-08-19 12:50:47 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19640', 'html_url': 'https://github.com/facebook/react/pull/19640', 'diff_url': 'https://github.com/facebook/react/pull/19640.diff', 'patch_url': 'https://github.com/facebook/react/pull/19640.patch', 'merged_at': datetime.datetime(2020, 8, 19, 12, 50, 47)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19640/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19640/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19639 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19639/labels{/name} | https://api.github.com/repos/facebook/react/issues/19639/comments | https://api.github.com/repos/facebook/react/issues/19639/events | https://github.com/facebook/react/issues/19639 | 681,202,139 | MDU6SXNzdWU2ODEyMDIxMzk= | 19,639 | Bug: Property list does not render repeated spaces properly. | {'login': 'sammarks', 'id': 424093, 'node_id': 'MDQ6VXNlcjQyNDA5Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/424093?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sammarks', 'html_url': 'https://github.com/sammarks', 'followers_url': 'https://api.github.com/users/sammarks/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Looks like [this line](https://github.com/facebook/react/blob/master/packages/react-devtools-shared/src/devtools/views/Components/KeyValue.css#L24) is our culprit.\r\n\r\nhttps://github.com/facebook/react/blob/23595ff593b2e53ddfec2a08e848704d15d84b51/packages/react-devtools-shared/src/devtools/views/Components/Key... | 2020-08-18 17:13:11 | 2020-08-19 12:50:47 | 2020-08-19 12:50:47 | CONTRIBUTOR | null | null | null | It looks like the property inspector inside React DevTools is not rendering repeating spaces properly.
I imagine this can result in some fairly frustrating debugging sessions when doing something like string matching 😄
## Steps To Reproduce
1. Create a component that takes a string as a property.
2. Pass mu... | {'url': 'https://api.github.com/repos/facebook/react/issues/19639/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19639/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19638 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19638/labels{/name} | https://api.github.com/repos/facebook/react/issues/19638/comments | https://api.github.com/repos/facebook/react/issues/19638/events | https://github.com/facebook/react/pull/19638 | 681,085,385 | MDExOlB1bGxSZXF1ZXN0NDY5NTMzNjY2 | 19,638 | Add missing param to safelyCallDestroy() | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 1 warning: Base commit is br...\n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n<table>\n <thead>\n <tr>\n <th width=\"50\"></th>\n <th width=\"100%\" data-danger-table=\"true\">Warnings</th>\n </tr>\n </thead>\n <tbody><tr>\n <td>:warning:</td>\... | 2020-08-18 14:24:41 | 2020-08-18 16:02:14 | 2020-08-18 16:02:05 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19638', 'html_url': 'https://github.com/facebook/react/pull/19638', 'diff_url': 'https://github.com/facebook/react/pull/19638.diff', 'patch_url': 'https://github.com/facebook/react/pull/19638.patch', 'merged_at': datetime.datetime(2020, 8, 18, 16, 2, 5)} | This got broken when PR #19605 was merged. | {'url': 'https://api.github.com/repos/facebook/react/issues/19638/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19638/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19637 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19637/labels{/name} | https://api.github.com/repos/facebook/react/issues/19637/comments | https://api.github.com/repos/facebook/react/issues/19637/events | https://github.com/facebook/react/issues/19637 | 680,994,677 | MDU6SXNzdWU2ODA5OTQ2Nzc= | 19,637 | Portal Event Bubbling Use Cases | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}] | open | false | null | [] | null | [
"Gonna toss the two typical cases we run into quickly here, and hopefully follow up with some actual code and more specific actual cases of workarounds or benefits as i think of places in our code bases that have em.\r\n\r\n### Canonical Modal case\r\n\r\nFor posterity I think this is probably the canonical \"Why t... | 2020-08-18 12:16:29 | 2023-11-03 13:06:35 | null | COLLABORATOR | null | null | null | This is a spillover from https://github.com/facebook/react/issues/11387.
The goal of this issue is **not** to argue about whether the current React's behavior makes sense in all situations. Rather, it is **collect a list of use cases, both when the current behavior works well, and when it doesn't**, so that they can... | {'url': 'https://api.github.com/repos/facebook/react/issues/19637/reactions', 'total_count': 9, '+1': 6, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 3, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19637/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/19636 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19636/labels{/name} | https://api.github.com/repos/facebook/react/issues/19636/comments | https://api.github.com/repos/facebook/react/issues/19636/events | https://github.com/facebook/react/issues/19636 | 680,838,763 | MDU6SXNzdWU2ODA4Mzg3NjM= | 19,636 | [react-hooks/exhaustive-deps] Does not complain for nested dependencies if the parent object is added in dependencies array | {'login': 'gaurav5430', 'id': 12510548, 'node_id': 'MDQ6VXNlcjEyNTEwNTQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/12510548?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaurav5430', 'html_url': 'https://github.com/gaurav5430', 'followers_url': 'https://api.github.com/users/gaurav5430/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The whole notion of dependencies rests on the assumption that **the values you're specifying are immutable and are created during rendering**. Essentially, you're saying the linter doesn't handle code like this:\r\n\r\n```js\r\nlet obj = {}\r\nsetTimeout(() => {\r\n obj.foo = 'bar'\r\n})\r\n\r\nfunction MyCompone... | 2020-08-18 09:20:58 | 2020-08-18 16:52:00 | 2020-08-18 12:05:14 | CONTRIBUTOR | null | null | null | React version: 17.0.0-rc.0
## Steps To Reproduce
1. add a `useEffect` which does something with `history.location.hash` and `history.push`
2. The eslint hook complains that you should have a dependency on `history`. I understand that is because we are passing `history` as `this` to the `push` function
3. If you... | {'url': 'https://api.github.com/repos/facebook/react/issues/19636/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19636/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19635 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19635/labels{/name} | https://api.github.com/repos/facebook/react/issues/19635/comments | https://api.github.com/repos/facebook/react/issues/19635/events | https://github.com/facebook/react/issues/19635 | 680,831,592 | MDU6SXNzdWU2ODA4MzE1OTI= | 19,635 | Create react app throwing the following error | {'login': 'I-GiM', 'id': 61995586, 'node_id': 'MDQ6VXNlcjYxOTk1NTg2', 'avatar_url': 'https://avatars.githubusercontent.com/u/61995586?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/I-GiM', 'html_url': 'https://github.com/I-GiM', 'followers_url': 'https://api.github.com/users/I-GiM/followers', 'following_... | [] | closed | false | null | [] | null | [
"The error you've posted isn't a React error, so this isn't the right place to report it.\r\n\r\nAs the error text itself says:\r\n> This is related to npm not being able to find a file.\r\n\r\nI'd suggest checking out the error log that's printed in the error message (`2020-08-18T08_54_43_533Z-debug.log`) to see i... | 2020-08-18 09:10:08 | 2020-08-18 14:13:07 | 2020-08-18 14:13:06 | NONE | null | null | null | npx create-react-app does not complete because of the following error
How do I solve this?
| {'url': 'https://api.github.com/repos/facebook/react/issues/19635/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19635/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19634 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19634/labels{/name} | https://api.github.com/repos/facebook/react/issues/19634/comments | https://api.github.com/repos/facebook/react/issues/19634/events | https://github.com/facebook/react/pull/19634 | 680,771,442 | MDExOlB1bGxSZXF1ZXN0NDY5MjY3ODcw | 19,634 | Import React Concurrent Mode Profiler | {'login': 'taneliang', 'id': 12784593, 'node_id': 'MDQ6VXNlcjEyNzg0NTkz', 'avatar_url': 'https://avatars.githubusercontent.com/u/12784593?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/taneliang', 'html_url': 'https://github.com/taneliang', 'followers_url': 'https://api.github.com/users/taneliang/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19634/builds/47723) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-18 07:40:25 | 2020-08-24 03:09:29 | 2020-08-20 18:06:29 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19634', 'html_url': 'https://github.com/facebook/react/pull/19634', 'diff_url': 'https://github.com/facebook/react/pull/19634.diff', 'patch_url': 'https://github.com/facebook/react/pull/19634.patch', 'merged_at': datetime.datetime(2020, 8, 20, 18, 6, 29)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19634/reactions', 'total_count': 4, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 2, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19634/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19633 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19633/labels{/name} | https://api.github.com/repos/facebook/react/issues/19633/comments | https://api.github.com/repos/facebook/react/issues/19633/events | https://github.com/facebook/react/issues/19633 | 680,756,123 | MDU6SXNzdWU2ODA3NTYxMjM= | 19,633 | Error: "Commit tree does not contain fiber 2094. This is a bug in React DevTools." | {'login': 'nyurik', 'id': 1641515, 'node_id': 'MDQ6VXNlcjE2NDE1MTU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1641515?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nyurik', 'html_url': 'https://github.com/nyurik', 'followers_url': 'https://api.github.com/users/nyurik/followers', 'followin... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"@nyurik Can you repro this? Can you share a repro with us?",
"> @nyurik Can you repro this? Can you share a repro with us?\r\n\r\n@bvaughn unfortunately not, this was a random crash i guess.",
"Gotcha! That's unfortunate.",
"I think I have a repro:\r\n\r\n1. Open React Devtools Profiler\r\n2. Select Hide com... | 2020-08-18 07:14:13 | 2020-10-13 17:38:59 | 2020-10-13 17:38:59 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. recorded profiling results
2. browsing results by paging to the right
3. crash
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.8.2-fed4ae024
... | {'url': 'https://api.github.com/repos/facebook/react/issues/19633/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19633/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19632 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19632/labels{/name} | https://api.github.com/repos/facebook/react/issues/19632/comments | https://api.github.com/repos/facebook/react/issues/19632/events | https://github.com/facebook/react/pull/19632 | 680,706,557 | MDExOlB1bGxSZXF1ZXN0NDY5MjE0ODMz | 19,632 | fix(#19629): devtool popup page opens two same tabs on firefox | {'login': 'unbyte', 'id': 5772358, 'node_id': 'MDQ6VXNlcjU3NzIzNTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5772358?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/unbyte', 'html_url': 'https://github.com/unbyte', 'followers_url': 'https://api.github.com/users/unbyte/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19632/builds/46946) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-18 05:33:31 | 2020-08-18 14:17:01 | 2020-08-18 14:17:01 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19632', 'html_url': 'https://github.com/facebook/react/pull/19632', 'diff_url': 'https://github.com/facebook/react/pull/19632.diff', 'patch_url': 'https://github.com/facebook/react/pull/19632.patch', 'merged_at': datetime.datetime(2020, 8, 18, 14, 17, 1)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19632/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19632/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19631 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19631/labels{/name} | https://api.github.com/repos/facebook/react/issues/19631/comments | https://api.github.com/repos/facebook/react/issues/19631/events | https://github.com/facebook/react/pull/19631 | 680,681,617 | MDExOlB1bGxSZXF1ZXN0NDY5MTkzOTM5 | 19,631 | feat: backport allowing noModule attribute on script tags to React 15 | {'login': 'snyamathi', 'id': 1328852, 'node_id': 'MDQ6VXNlcjEzMjg4NTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1328852?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/snyamathi', 'html_url': 'https://github.com/snyamathi', 'followers_url': 'https://api.github.com/users/snyamathi/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @snyamathi! \n\nThank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on b... | 2020-08-18 04:32:55 | 2021-11-06 18:44:11 | 2021-11-06 18:44:09 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19631', 'html_url': 'https://github.com/facebook/react/pull/19631', 'diff_url': 'https://github.com/facebook/react/pull/19631.diff', 'patch_url': 'https://github.com/facebook/react/pull/19631.patch', 'merged_at': None} | ## Summary
This PR backports [this PR](https://github.com/facebook/react/pull/11900) which added support for the `nomodule` attribute to React 15 as well. I'm not sure how likely this is to get into a release, but we're still stuck on React 15 for a variety of reasons. It would be great if we could add support for t... | {'url': 'https://api.github.com/repos/facebook/react/issues/19631/reactions', 'total_count': 3, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19631/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19630 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19630/labels{/name} | https://api.github.com/repos/facebook/react/issues/19630/comments | https://api.github.com/repos/facebook/react/issues/19630/events | https://github.com/facebook/react/issues/19630 | 680,673,407 | MDU6SXNzdWU2ODA2NzM0MDc= | 19,630 | When will the official hook equivalents componentDidCatch be added? | {'login': 'bahuwang', 'id': 11907803, 'node_id': 'MDQ6VXNlcjExOTA3ODAz', 'avatar_url': 'https://avatars.githubusercontent.com/u/11907803?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bahuwang', 'html_url': 'https://github.com/bahuwang', 'followers_url': 'https://api.github.com/users/bahuwang/followers',... | [] | closed | false | null | [] | null | [
"No specific time commitment. When we have a good API. :-) These should be fairly uncommon anyway. ",
"@bahuwang meanwhile, feel free to use this unofficial functional component:\r\nhttps://github.com/bvaughn/react-error-boundary",
"You can also write your own once and use it throughout the project."
] | 2020-08-18 04:08:12 | 2020-08-18 12:00:18 | 2020-08-18 10:12:04 | NONE | null | null | null | According to the React docs:
```
Our goal is for Hooks to cover all use cases for classes as soon as possible. There are no Hook equivalents to the uncommon getSnapshotBeforeUpdate, getDerivedStateFromError and componentDidCatch lifecycles yet, but we plan to add them soon.
```
I wonder, is there a definite time? ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19630/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19630/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19629 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19629/labels{/name} | https://api.github.com/repos/facebook/react/issues/19629/comments | https://api.github.com/repos/facebook/react/issues/19629/events | https://github.com/facebook/react/issues/19629 | 680,403,143 | MDU6SXNzdWU2ODA0MDMxNDM= | 19,629 | Bug: Clicking the troubleshooting instructions button on the devtools opens 2 tabs | {'login': 'peppizza', 'id': 35662205, 'node_id': 'MDQ6VXNlcjM1NjYyMjA1', 'avatar_url': 'https://avatars.githubusercontent.com/u/35662205?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/peppizza', 'html_url': 'https://github.com/peppizza', 'followers_url': 'https://api.github.com/users/peppizza/followers',... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [] | 2020-08-17 17:28:59 | 2020-08-18 14:17:01 | 2020-08-18 14:17:01 | NONE | null | null | null | <!--
In the react devtools window, clicking the troubleshooting instructions link opens 2 tabs of the troubleshooting page, instead of once
-->
React version: Devtools 4.8.2
Firefox version: 79.0 64-bit
## Steps To Reproduce
1. Go to a non-react page
2. Open the devtools box
3. Click troubleshooting instr... | {'url': 'https://api.github.com/repos/facebook/react/issues/19629/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19629/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19628 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19628/labels{/name} | https://api.github.com/repos/facebook/react/issues/19628/comments | https://api.github.com/repos/facebook/react/issues/19628/events | https://github.com/facebook/react/issues/19628 | 680,397,321 | MDU6SXNzdWU2ODAzOTczMjE= | 19,628 | TypeError: Notification constructor: 'new' is required error thrown by react-dom.production.min.js:209:194 | {'login': 'tylersai', 'id': 45680003, 'node_id': 'MDQ6VXNlcjQ1NjgwMDAz', 'avatar_url': 'https://avatars.githubusercontent.com/u/45680003?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tylersai', 'html_url': 'https://github.com/tylersai', 'followers_url': 'https://api.github.com/users/tylersai/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"It was actually caused by some other part of my code from other library. Closing this one."
] | 2020-08-17 17:19:21 | 2020-08-17 17:50:53 | 2020-08-17 17:50:53 | NONE | null | null | null |
So I ran into this error when simply clicking on a Material-UI button (`^4.11.0`): <br/>
Uncaught TypeError: Failed to construct 'Notification': Please use the 'new' operator, this DOM object constructor cannot be called as a function, thrown by the line `react-dom.production.min.js:209`, caused by `scheduler.prod... | {'url': 'https://api.github.com/repos/facebook/react/issues/19628/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19628/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19627 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19627/labels{/name} | https://api.github.com/repos/facebook/react/issues/19627/comments | https://api.github.com/repos/facebook/react/issues/19627/events | https://github.com/facebook/react/pull/19627 | 680,270,268 | MDExOlB1bGxSZXF1ZXN0NDY4ODYwNjkw | 19,627 | Always skip unmounted/unmounting error boundaries | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19627/builds/46852) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-17 14:15:46 | 2021-01-30 14:40:08 | 2020-08-17 19:01:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19627', 'html_url': 'https://github.com/facebook/react/pull/19627', 'diff_url': 'https://github.com/facebook/react/pull/19627.diff', 'patch_url': 'https://github.com/facebook/react/pull/19627.patch', 'merged_at': datetime.datetime(2020, 8, 17, 19, 1, 6)} | The behavior of error boundaries for passive effects that throw during cleanup was recently changed (#19542) so that React ignores boundaries which are also unmounting in favor of still-mounted boundaries. This commit implements that same behavior for layout effects (`useLayoutEffect` and `componentWillUnmount`).
Si... | {'url': 'https://api.github.com/repos/facebook/react/issues/19627/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19627/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19626 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19626/labels{/name} | https://api.github.com/repos/facebook/react/issues/19626/comments | https://api.github.com/repos/facebook/react/issues/19626/events | https://github.com/facebook/react/issues/19626 | 679,897,069 | MDU6SXNzdWU2Nzk4OTcwNjk= | 19,626 | Bug: When I use the StrictMode component, all my components will be rendered twice. | {'login': 'janryWang', 'id': 4060976, 'node_id': 'MDQ6VXNlcjQwNjA5NzY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4060976?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/janryWang', 'html_url': 'https://github.com/janryWang', 'followers_url': 'https://api.github.com/users/janryWang/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Please see https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects, that's expected."
] | 2020-08-17 02:57:06 | 2020-08-17 03:27:19 | 2020-08-17 03:27:19 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
16.12.0
## Steps To Reproduce
Check the console
<!--
... | {'url': 'https://api.github.com/repos/facebook/react/issues/19626/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19626/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19625 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19625/labels{/name} | https://api.github.com/repos/facebook/react/issues/19625/comments | https://api.github.com/repos/facebook/react/issues/19625/events | https://github.com/facebook/react/pull/19625 | 679,785,399 | MDExOlB1bGxSZXF1ZXN0NDY4NDY3MTEy | 19,625 | refactor: remove unnecessary return statements | {'login': 'koba04', 'id': 250407, 'node_id': 'MDQ6VXNlcjI1MDQwNw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/250407?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/koba04', 'html_url': 'https://github.com/koba04', 'followers_url': 'https://api.github.com/users/koba04/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19625/builds/46594) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-16 16:41:50 | 2020-08-19 14:19:17 | 2020-08-19 13:10:41 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19625', 'html_url': 'https://github.com/facebook/react/pull/19625', 'diff_url': 'https://github.com/facebook/react/pull/19625.diff', 'patch_url': 'https://github.com/facebook/react/pull/19625.patch', 'merged_at': datetime.datetime(2020, 8, 19, 13, 10, 41)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19625/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19625/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19624 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19624/labels{/name} | https://api.github.com/repos/facebook/react/issues/19624/comments | https://api.github.com/repos/facebook/react/issues/19624/events | https://github.com/facebook/react/issues/19624 | 679,782,840 | MDU6SXNzdWU2Nzk3ODI4NDA= | 19,624 | Bug: Infinite loop in react should be short circuited, at least in dev | {'login': 'joshribakoff', 'id': 4021306, 'node_id': 'MDQ6VXNlcjQwMjEzMDY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4021306?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/joshribakoff', 'html_url': 'https://github.com/joshribakoff', 'followers_url': 'https://api.github.com/users/joshribako... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Yes, I tested the same. facing the same issue.",
"The reason is that React doesn't execute components recursively. It is lazy. Instead you can think of it as:\r\n\r\n```js\r\nwhile (nextComponent) {\r\n nextComponent = render()\r\n}\r\n```\r\n\r\nSo if you have a recursive tree, you get an infinite loop, just l... | 2020-08-16 16:25:06 | 2020-08-17 15:42:43 | 2020-08-17 12:44:40 | NONE | null | null | null | React version:
16.13.1
## Steps To Reproduce
```tsx
function App() {
return (
<App />
);
}
```
## The current behavior
Infinite loop, 100% CPU browser lock up
## The expected behavior
```tsx
function App(): any {
return App()
}
App()
```
I get this basically instantly, with a help... | {'url': 'https://api.github.com/repos/facebook/react/issues/19624/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19624/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19623 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19623/labels{/name} | https://api.github.com/repos/facebook/react/issues/19623/comments | https://api.github.com/repos/facebook/react/issues/19623/events | https://github.com/facebook/react/issues/19623 | 679,655,500 | MDU6SXNzdWU2Nzk2NTU1MDA= | 19,623 | Bug: Event Capture does not work in video environment | {'login': 'JenniferFuBook', 'id': 54613999, 'node_id': 'MDQ6VXNlcjU0NjEzOTk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/54613999?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JenniferFuBook', 'html_url': 'https://github.com/JenniferFuBook', 'followers_url': 'https://api.github.com/users/Je... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Can you make a CodeSandbox reproducing case?",
"Yes, it is https://codesandbox.io/s/sharp-nash-z01wk?file=/src/App.js.",
"@JenniferFuBook I just make a [reproduce](https://codesandbox.io/s/sweet-bartik-fuhxl?file=/src/App.js) using your first example. It shows the click event can be captured correctly, for ex... | 2020-08-15 22:58:11 | 2020-08-17 03:04:58 | 2020-08-17 03:04:58 | NONE | null | null | null | This is related to https://github.com/facebook/react/issues/18932.
It seems that the problem still exists.
React version: 17.0.0-rc.0
## Steps To Reproduce
1. Copy https://gist.github.com/JenniferFuBook/c7c9ffd6dbd4e8b4e64afe9e6c66f66c#file-appwithvideo-js and replace App.js in Create React App.
2. Name a vi... | {'url': 'https://api.github.com/repos/facebook/react/issues/19623/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19623/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19622 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19622/labels{/name} | https://api.github.com/repos/facebook/react/issues/19622/comments | https://api.github.com/repos/facebook/react/issues/19622/events | https://github.com/facebook/react/pull/19622 | 679,612,378 | MDExOlB1bGxSZXF1ZXN0NDY4MzQ0MzEy | 19,622 | fix : grammatical typo for test description | {'login': 'brijeshprasad89', 'id': 10307799, 'node_id': 'MDQ6VXNlcjEwMzA3Nzk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/10307799?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/brijeshprasad89', 'html_url': 'https://github.com/brijeshprasad89', 'followers_url': 'https://api.github.com/users... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @brijeshprasad89! \n\nThank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributin... | 2020-08-15 17:22:50 | 2021-11-15 16:36:44 | 2021-11-15 15:56:32 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19622', 'html_url': 'https://github.com/facebook/react/pull/19622', 'diff_url': 'https://github.com/facebook/react/pull/19622.diff', 'patch_url': 'https://github.com/facebook/react/pull/19622.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19622/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19622/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19621 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19621/labels{/name} | https://api.github.com/repos/facebook/react/issues/19621/comments | https://api.github.com/repos/facebook/react/issues/19621/events | https://github.com/facebook/react/pull/19621 | 679,554,982 | MDExOlB1bGxSZXF1ZXN0NDY4Mjk5NzU3 | 19,621 | fix: synchronize focused email input on blur to avoid check validity when inputting | {'login': 'jameslahm', 'id': 43805318, 'node_id': 'MDQ6VXNlcjQzODA1MzE4', 'avatar_url': 'https://avatars.githubusercontent.com/u/43805318?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jameslahm', 'html_url': 'https://github.com/jameslahm', 'followers_url': 'https://api.github.com/users/jameslahm/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19621/builds/46483) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-15 12:18:51 | 2020-08-17 13:22:54 | 2020-08-17 12:52:30 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19621', 'html_url': 'https://github.com/facebook/react/pull/19621', 'diff_url': 'https://github.com/facebook/react/pull/19621.diff', 'patch_url': 'https://github.com/facebook/react/pull/19621.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19621/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19621/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19620 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19620/labels{/name} | https://api.github.com/repos/facebook/react/issues/19620/comments | https://api.github.com/repos/facebook/react/issues/19620/events | https://github.com/facebook/react/pull/19620 | 679,398,427 | MDExOlB1bGxSZXF1ZXN0NDY4MTgwNDIx | 19,620 | docs: adding the logo in README.md | {'login': 'adnaanbheda', 'id': 25040547, 'node_id': 'MDQ6VXNlcjI1MDQwNTQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/25040547?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/adnaanbheda', 'html_url': 'https://github.com/adnaanbheda', 'followers_url': 'https://api.github.com/users/adnaanbheda... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Hi @adnaanbheda! \n\nThank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on... | 2020-08-14 20:58:49 | 2022-01-09 08:42:11 | 2022-01-09 08:42:11 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19620', 'html_url': 'https://github.com/facebook/react/pull/19620', 'diff_url': 'https://github.com/facebook/react/pull/19620.diff', 'patch_url': 'https://github.com/facebook/react/pull/19620.patch', 'merged_at': None} | ### Description
Inclusion of the React icon in README.md.
| {'url': 'https://api.github.com/repos/facebook/react/issues/19620/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19620/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19619 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19619/labels{/name} | https://api.github.com/repos/facebook/react/issues/19619/comments | https://api.github.com/repos/facebook/react/issues/19619/events | https://github.com/facebook/react/pull/19619 | 679,397,539 | MDExOlB1bGxSZXF1ZXN0NDY4MTc5NzA3 | 19,619 | Fix DevTools crash when inspecting document.all | {'login': 'omarsy', 'id': 15034695, 'node_id': 'MDQ6VXNlcjE1MDM0Njk1', 'avatar_url': 'https://avatars.githubusercontent.com/u/15034695?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/omarsy', 'html_url': 'https://github.com/omarsy', 'followers_url': 'https://api.github.com/users/omarsy/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @omarsy! \n\nThank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on beha... | 2020-08-14 20:56:41 | 2020-09-01 12:00:16 | 2020-08-21 13:31:17 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19619', 'html_url': 'https://github.com/facebook/react/pull/19619', 'diff_url': 'https://github.com/facebook/react/pull/19619.diff', 'patch_url': 'https://github.com/facebook/react/pull/19619.patch', 'merged_at': datetime.datetime(2020, 8, 21, 13, 31, 17)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19619/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19619/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19618 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19618/labels{/name} | https://api.github.com/repos/facebook/react/issues/19618/comments | https://api.github.com/repos/facebook/react/issues/19618/events | https://github.com/facebook/react/issues/19618 | 679,388,707 | MDU6SXNzdWU2NzkzODg3MDc= | 19,618 | Bug: Clicking select elements in Firefox React Devtools settings doesn't open options in detached Firefox Developer Tools window | {'login': 'benatshippabo', 'id': 66273043, 'node_id': 'MDQ6VXNlcjY2MjczMDQz', 'avatar_url': 'https://avatars.githubusercontent.com/u/66273043?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/benatshippabo', 'html_url': 'https://github.com/benatshippabo', 'followers_url': 'https://api.github.com/users/benat... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 710573595, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"Hm... I can't repro this this with Firefox 79.0 (64-bit) and React DevTools 4.8.2-fed4ae024. (Haven't seen any other reports of it either.)",
"> Hm... I can't repro this this with Firefox 79.0 (64-bit) and React DevTools 4.8.2-fed4ae024. (Haven't seen any other reports of it either.)\r\n\r\n😢 strange, my cowor... | 2020-08-14 20:34:48 | 2020-08-18 13:32:35 | 2020-08-18 01:10:47 | NONE | null | null | null | React version: 16.9
React Developer Tools: 4.8.2
Firefox: 79.0 and 80.0b8
## Steps To Reproduce
1. go to a webpage using react
2. open firefox developer tools in a detached window
3. go to React Developer Tools "Components" tab
4. open up settings:
![image](https://user-images.githubusercontent.com/66273043... | {'url': 'https://api.github.com/repos/facebook/react/issues/19618/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19618/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19617 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19617/labels{/name} | https://api.github.com/repos/facebook/react/issues/19617/comments | https://api.github.com/repos/facebook/react/issues/19617/events | https://github.com/facebook/react/pull/19617 | 679,388,331 | MDExOlB1bGxSZXF1ZXN0NDY4MTcyMDU5 | 19,617 | test: Add current behavior for label clicking in a browser | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19617/builds/46304) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-14 20:33:52 | 2021-06-11 06:31:32 | 2021-06-11 06:31:29 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19617', 'html_url': 'https://github.com/facebook/react/pull/19617', 'diff_url': 'https://github.com/facebook/react/pull/19617.diff', 'patch_url': 'https://github.com/facebook/react/pull/19617.patch', 'merged_at': None} | ## Summary
Failing test for https://github.com/facebook/react/issues/18591
## Test Plan
https://codesandbox.io/s/user-label-click-with-associated-checkbox-1zs7z?file=/public/index.html showscases the event order in a real browser (tested with Chrome 84)
| {'url': 'https://api.github.com/repos/facebook/react/issues/19617/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19617/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19616 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19616/labels{/name} | https://api.github.com/repos/facebook/react/issues/19616/comments | https://api.github.com/repos/facebook/react/issues/19616/events | https://github.com/facebook/react/pull/19616 | 679,373,190 | MDExOlB1bGxSZXF1ZXN0NDY4MTU5NjMz | 19,616 | docs: update README.md with some grammatical corrections | {'login': 'shalinikumari50', 'id': 48484815, 'node_id': 'MDQ6VXNlcjQ4NDg0ODE1', 'avatar_url': 'https://avatars.githubusercontent.com/u/48484815?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shalinikumari50', 'html_url': 'https://github.com/shalinikumari50', 'followers_url': 'https://api.github.com/users... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19616/builds/46298) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-14 19:58:32 | 2020-08-18 05:31:25 | 2020-08-18 05:31:25 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19616', 'html_url': 'https://github.com/facebook/react/pull/19616', 'diff_url': 'https://github.com/facebook/react/pull/19616.diff', 'patch_url': 'https://github.com/facebook/react/pull/19616.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19616/reactions', 'total_count': 1, '+1': 0, '-1': 1, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19616/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19615 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19615/labels{/name} | https://api.github.com/repos/facebook/react/issues/19615/comments | https://api.github.com/repos/facebook/react/issues/19615/events | https://github.com/facebook/react/pull/19615 | 679,340,142 | MDExOlB1bGxSZXF1ZXN0NDY4MTMzMjM0 | 19,615 | Permanently removed component stacks from scheduling profiler data | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19615/builds/46286) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-14 18:46:29 | 2020-08-14 19:21:18 | 2020-08-14 19:21:14 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19615', 'html_url': 'https://github.com/facebook/react/pull/19615', 'diff_url': 'https://github.com/facebook/react/pull/19615.diff', 'patch_url': 'https://github.com/facebook/react/pull/19615.patch', 'merged_at': datetime.datetime(2020, 8, 14, 19, 21, 14)} | These stacks improve the profiler data but they're expensive to generate and generating them can also cause runtime errors in larger applications (although an exact repro has been hard to nail down). Removing them for now. We can revisit adding them after this profiler has been integrated into the DevTools extension an... | {'url': 'https://api.github.com/repos/facebook/react/issues/19615/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19615/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19614 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19614/labels{/name} | https://api.github.com/repos/facebook/react/issues/19614/comments | https://api.github.com/repos/facebook/react/issues/19614/events | https://github.com/facebook/react/pull/19614 | 679,304,419 | MDExOlB1bGxSZXF1ZXN0NDY4MTAzMzc4 | 19,614 | fix: leak strict mode with UMD builds | {'login': 'koba04', 'id': 250407, 'node_id': 'MDQ6VXNlcjI1MDQwNw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/250407?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/koba04', 'html_url': 'https://github.com/koba04', 'followers_url': 'https://api.github.com/users/koba04/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19614/builds/46265) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-14 17:40:27 | 2020-08-15 14:01:49 | 2020-08-15 13:42:50 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19614', 'html_url': 'https://github.com/facebook/react/pull/19614', 'diff_url': 'https://github.com/facebook/react/pull/19614.diff', 'patch_url': 'https://github.com/facebook/react/pull/19614.patch', 'merged_at': datetime.datetime(2020, 8, 15, 13, 42, 50)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19614/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 2, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19614/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19613 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19613/labels{/name} | https://api.github.com/repos/facebook/react/issues/19613/comments | https://api.github.com/repos/facebook/react/issues/19613/events | https://github.com/facebook/react/issues/19613 | 679,265,085 | MDU6SXNzdWU2NzkyNjUwODU= | 19,613 | Suggestion: don't re-throw errors caught by boundaries (in development) | {'login': 'OliverJAsh', 'id': 921609, 'node_id': 'MDQ6VXNlcjkyMTYwOQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/921609?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/OliverJAsh', 'html_url': 'https://github.com/OliverJAsh', 'followers_url': 'https://api.github.com/users/OliverJAsh/followe... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Isn't this \"by design\", intentionally, by the react dev team, not giving too much info to the public user? ",
"This looks like it might be a duplicate of https://github.com/facebook/react/issues/10474.",
"> This looks like it might be a duplicate of #10474.\r\n\r\nI agree. Closing in favor of https://github.... | 2020-08-14 16:22:28 | 2023-09-05 12:15:47 | 2020-12-02 12:16:59 | NONE | null | null | null | We are using error boundaries to catch and handle errors inside of a React render. As for errors which occur outside of a React render (i.e. uncaught errors that happen in a timeout), we need to register an uncaught error handler (`window.addEventListener('error', …)`) to handle these separately (otherwise the user wil... | {'url': 'https://api.github.com/repos/facebook/react/issues/19613/reactions', 'total_count': 11, '+1': 11, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19613/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19612 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19612/labels{/name} | https://api.github.com/repos/facebook/react/issues/19612/comments | https://api.github.com/repos/facebook/react/issues/19612/events | https://github.com/facebook/react/issues/19612 | 679,141,465 | MDU6SXNzdWU2NzkxNDE0NjU= | 19,612 | Bug: Blocking mode and events are broken (probably) for Material UI Rating component (example) | {'login': 'ovr', 'id': 572096, 'node_id': 'MDQ6VXNlcjU3MjA5Ng==', 'avatar_url': 'https://avatars.githubusercontent.com/u/572096?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ovr', 'html_url': 'https://github.com/ovr', 'followers_url': 'https://api.github.com/users/ovr/followers', 'following_url': 'https... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710722093, 'node_id': 'MDU6TGFiZWw3MTA3MjIwOTM=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"There is a problem with the sandbox you've shared. It's using legacy `ReactDOM.render` and even so, the first click shows an error in the console:\r\n> Warning: Failed prop type: Invalid prop `value` of type `object` supplied to `ForwardRef(Rating)`, expected `number`.\r\n at Rating (https://h3k2m.csb.app/node_... | 2020-08-14 13:01:00 | 2020-12-09 16:55:11 | 2020-08-14 19:21:01 | NONE | null | null | null | React version: `0.0.0-experimental-94c0244ba`
## Steps To Reproduce
```js
import React from "react";
import Rating from "@material-ui/lab/Rating";
import "./styles.css";
export default function App() {
const [rating, setRating] = React.useState(null);
return (
<div>
Example
<Ratin... | {'url': 'https://api.github.com/repos/facebook/react/issues/19612/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19612/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19611 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19611/labels{/name} | https://api.github.com/repos/facebook/react/issues/19611/comments | https://api.github.com/repos/facebook/react/issues/19611/events | https://github.com/facebook/react/issues/19611 | 678,976,321 | MDU6SXNzdWU2Nzg5NzYzMjE= | 19,611 | Bug: click event is attached to createPortal | {'login': '615349', 'id': 39723820, 'node_id': 'MDQ6VXNlcjM5NzIzODIw', 'avatar_url': 'https://avatars.githubusercontent.com/u/39723820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/615349', 'html_url': 'https://github.com/615349', 'followers_url': 'https://api.github.com/users/615349/followers', 'follow... | [{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20DOM', 'name': 'Component: DOM', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/faceb... | open | false | null | [] | null | [
"> click event should not be added\r\n\r\nIs this about nvda announcing elements as clickable even if they aren't actually? I think adding a bit more context why the click listener should not be added would help the maintainers understanding the issue.",
"FWIW this is intentional to prevent some iOS issue if I re... | 2020-08-14 07:57:01 | 2021-11-09 17:04:38 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
16.13.1
## Steps To Reproduce
use createPortal will have c... | {'url': 'https://api.github.com/repos/facebook/react/issues/19611/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19611/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/19610 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19610/labels{/name} | https://api.github.com/repos/facebook/react/issues/19610/comments | https://api.github.com/repos/facebook/react/issues/19610/events | https://github.com/facebook/react/pull/19610 | 678,941,405 | MDExOlB1bGxSZXF1ZXN0NDY3ODA0Nzg0 | 19,610 | [COH-13535] Delete unused dom element references without breaking the… | {'login': 'venetak', 'id': 19714551, 'node_id': 'MDQ6VXNlcjE5NzE0NTUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/19714551?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/venetak', 'html_url': 'https://github.com/venetak', 'followers_url': 'https://api.github.com/users/venetak/followers', 'fo... | [] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19610/builds/46220) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-14 06:45:41 | 2020-08-14 14:02:28 | 2020-08-14 13:48:18 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19610', 'html_url': 'https://github.com/facebook/react/pull/19610', 'diff_url': 'https://github.com/facebook/react/pull/19610.diff', 'patch_url': 'https://github.com/facebook/react/pull/19610.patch', 'merged_at': None} | ## Add a patch to remove unused DOM instances that cause a memory leak
Some clients reported that using React 16.* with certain versions of V8 causes a memory leak. | {'url': 'https://api.github.com/repos/facebook/react/issues/19610/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19610/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19609 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19609/labels{/name} | https://api.github.com/repos/facebook/react/issues/19609/comments | https://api.github.com/repos/facebook/react/issues/19609/events | https://github.com/facebook/react/pull/19609 | 678,760,716 | MDExOlB1bGxSZXF1ZXN0NDY3NjU1NjEw | 19,609 | Remove `didTimeout` check from work loop | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19609/builds/46229) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-13 22:04:02 | 2020-08-14 14:54:36 | 2020-08-14 14:54:36 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19609', 'html_url': 'https://github.com/facebook/react/pull/19609', 'diff_url': 'https://github.com/facebook/react/pull/19609.diff', 'patch_url': 'https://github.com/facebook/react/pull/19609.patch', 'merged_at': datetime.datetime(2020, 8, 14, 14, 54, 36)} | ## Based on #19604
No longer need this, since we have starvation protection in userspace.
This will also allow us to remove the concept from the Scheduler package, which is nice because `postTask` doesn't currently support it. | {'url': 'https://api.github.com/repos/facebook/react/issues/19609/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19609/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19608 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19608/labels{/name} | https://api.github.com/repos/facebook/react/issues/19608/comments | https://api.github.com/repos/facebook/react/issues/19608/events | https://github.com/facebook/react/issues/19608 | 678,658,673 | MDU6SXNzdWU2Nzg2NTg2NzM= | 19,608 | Bug: (17.0.0-rc.0) Event propagation through portals is inconsistent | {'login': 'nstepien', 'id': 567105, 'node_id': 'MDQ6VXNlcjU2NzEwNQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/567105?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nstepien', 'html_url': 'https://github.com/nstepien', 'followers_url': 'https://api.github.com/users/nstepien/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Thanks for reporting!",
"I've investigated the issue and figured out why this happens.\r\nReact registers event handlers to a root container, with Portal, the root container is the container of Portal. React listens to events, which are only registered event handlers on components within Portal, at the container... | 2020-08-13 18:46:02 | 2020-08-31 11:11:37 | 2020-08-24 15:50:20 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.0-rc.0
## Steps To Reproduce
1. Open the codesandbox d... | {'url': 'https://api.github.com/repos/facebook/react/issues/19608/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19608/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19607 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19607/labels{/name} | https://api.github.com/repos/facebook/react/issues/19607/comments | https://api.github.com/repos/facebook/react/issues/19607/events | https://github.com/facebook/react/pull/19607 | 678,650,526 | MDExOlB1bGxSZXF1ZXN0NDY3NTYzMDkx | 19,607 | fix event.relatedTarget fallback logic for firefox | {'login': 'claytercek', 'id': 30105080, 'node_id': 'MDQ6VXNlcjMwMTA1MDgw', 'avatar_url': 'https://avatars.githubusercontent.com/u/30105080?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/claytercek', 'html_url': 'https://github.com/claytercek', 'followers_url': 'https://api.github.com/users/claytercek/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19607/builds/46029) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-13 18:30:59 | 2020-08-14 12:05:54 | 2020-08-14 12:05:54 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19607', 'html_url': 'https://github.com/facebook/react/pull/19607', 'diff_url': 'https://github.com/facebook/react/pull/19607.diff', 'patch_url': 'https://github.com/facebook/react/pull/19607.patch', 'merged_at': datetime.datetime(2020, 8, 14, 12, 5, 54)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19607/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19607/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19606 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19606/labels{/name} | https://api.github.com/repos/facebook/react/issues/19606/comments | https://api.github.com/repos/facebook/react/issues/19606/events | https://github.com/facebook/react/issues/19606 | 678,634,082 | MDU6SXNzdWU2Nzg2MzQwODI= | 19,606 | Bug: React 17.0.0-rc.0 doesn't trigger onFocus/onBlur on element.dispatchEvent | {'login': 'diegohaz', 'id': 3068563, 'node_id': 'MDQ6VXNlcjMwNjg1NjM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3068563?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/diegohaz', 'html_url': 'https://github.com/diegohaz', 'followers_url': 'https://api.github.com/users/diegohaz/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is expected: https://reactjs.org/blog/2020/08/10/react-v17-rc.html#aligning-with-browsers\r\n\r\n>React onFocus and onBlur events have switched to using the native focusin and focusout events under the hood, which more closely match React’s existing behavior and sometimes provide extra information.\r\n\r\nThi... | 2020-08-13 18:01:23 | 2020-08-13 18:06:25 | 2020-08-13 18:06:25 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.0-rc.0
## Steps To Reproduce
1. Programmatically dispa... | {'url': 'https://api.github.com/repos/facebook/react/issues/19606/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19606/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19605 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19605/labels{/name} | https://api.github.com/repos/facebook/react/issues/19605/comments | https://api.github.com/repos/facebook/react/issues/19605/events | https://github.com/facebook/react/pull/19605 | 678,599,332 | MDExOlB1bGxSZXF1ZXN0NDY3NTIwNzE5 | 19,605 | change destroy to safelyCallDestroy for Layout Effect Unmounts | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19605/builds/45983) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-13 17:01:01 | 2020-08-18 00:32:51 | 2020-08-18 00:32:51 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19605', 'html_url': 'https://github.com/facebook/react/pull/19605', 'diff_url': 'https://github.com/facebook/react/pull/19605.diff', 'patch_url': 'https://github.com/facebook/react/pull/19605.patch', 'merged_at': datetime.datetime(2020, 8, 18, 0, 32, 51)} | We use `safelyCallDestroy` for `commitUnmount` and passive effects unmounts but we call destroy directly in `commitHookEffectListUnmount` (AKA layout effects unmounts because we don't use this anywhere else). This PR changes the direct destroy call to `safelyCallDestroy` for consistency | {'url': 'https://api.github.com/repos/facebook/react/issues/19605/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19605/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19604 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19604/labels{/name} | https://api.github.com/repos/facebook/react/issues/19604/comments | https://api.github.com/repos/facebook/react/issues/19604/events | https://github.com/facebook/react/pull/19604 | 678,591,171 | MDExOlB1bGxSZXF1ZXN0NDY3NTEzODE3 | 19,604 | Remove wasteful checks from `shouldYield` | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19604/builds/46227) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-13 16:50:38 | 2020-08-14 14:54:37 | 2020-08-14 14:54:37 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19604', 'html_url': 'https://github.com/facebook/react/pull/19604', 'diff_url': 'https://github.com/facebook/react/pull/19604.diff', 'patch_url': 'https://github.com/facebook/react/pull/19604.patch', 'merged_at': datetime.datetime(2020, 8, 14, 14, 54, 37)} | `shouldYield` will currently return `true` if there's a higher priority task in the Scheduler queue.
Since we yield every 5ms anyway, this doesn't really have any practical benefit. On the contrary, the extra checks on every `shouldYield` call are wasteful.
| {'url': 'https://api.github.com/repos/facebook/react/issues/19604/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19604/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19603 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19603/labels{/name} | https://api.github.com/repos/facebook/react/issues/19603/comments | https://api.github.com/repos/facebook/react/issues/19603/events | https://github.com/facebook/react/pull/19603 | 678,506,088 | MDExOlB1bGxSZXF1ZXN0NDY3NDQxOTEw | 19,603 | Fix emoji character displayed in Chrome extension | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19603/builds/45962) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-13 14:59:05 | 2020-08-13 15:24:35 | 2020-08-13 15:16:36 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19603', 'html_url': 'https://github.com/facebook/react/pull/19603', 'diff_url': 'https://github.com/facebook/react/pull/19603.diff', 'patch_url': 'https://github.com/facebook/react/pull/19603.patch', 'merged_at': datetime.datetime(2020, 8, 13, 15, 16, 36)} | Resolves #19594
## Before
## After
![Screen Shot 2020-08-13 at 10 58 19 AM](https://user-images.githubusercontent.com/29597/90150751-f921fe00-dd53-11ea-88de-b72f958f7f7f.pn... | {'url': 'https://api.github.com/repos/facebook/react/issues/19603/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19603/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19602 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19602/labels{/name} | https://api.github.com/repos/facebook/react/issues/19602/comments | https://api.github.com/repos/facebook/react/issues/19602/events | https://github.com/facebook/react/issues/19602 | 678,398,101 | MDU6SXNzdWU2NzgzOTgxMDE= | 19,602 | Error: "getCommitTree(): Unable to reconstruct tree for root "1" and commit 21" | {'login': 'bhumijgupta', 'id': 30751793, 'node_id': 'MDQ6VXNlcjMwNzUxNzkz', 'avatar_url': 'https://avatars.githubusercontent.com/u/30751793?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bhumijgupta', 'html_url': 'https://github.com/bhumijgupta', 'followers_url': 'https://api.github.com/users/bhumijgupta... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Can you repro this? (Can you tell me how to repro it?)",
"I was using [Antdesign's table component](https://ant.design/components/table/) for showing the data and the error happened when prop changed from loading = true to loading = false. I cannot reproduce the bug each time. I'll try to see if I can create a p... | 2020-08-13 12:28:03 | 2021-04-28 20:23:53 | 2021-04-28 20:23:53 | CONTRIBUTOR | null | null | null | Describe what you were doing when the bug occurred:
1. I was going through the profiler result to check each render and what triggered each render
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.8.2-fe... | {'url': 'https://api.github.com/repos/facebook/react/issues/19602/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19602/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19601 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19601/labels{/name} | https://api.github.com/repos/facebook/react/issues/19601/comments | https://api.github.com/repos/facebook/react/issues/19601/events | https://github.com/facebook/react/issues/19601 | 678,368,075 | MDU6SXNzdWU2NzgzNjgwNzU= | 19,601 | React Developer Tools doesn't work on Firefox | {'login': 'catalin560', 'id': 22744333, 'node_id': 'MDQ6VXNlcjIyNzQ0MzMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/22744333?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/catalin560', 'html_url': 'https://github.com/catalin560', 'followers_url': 'https://api.github.com/users/catalin560/fol... | [{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Needs%20More%20Information', 'name': 'Resolution: Needs More Information', 'color': 'fffde7', 'default': False, 'description': None}] | closed | false | {'login': 'catalin560', 'id': 22744333.0, 'node_id': 'MDQ6VXNlcjIyNzQ0MzMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/22744333?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/catalin560', 'html_url': 'https://github.com/catalin560', 'followers_url': 'https://api.github.com/users/catalin560/f... | [{'login': 'catalin560', 'id': 22744333, 'node_id': 'MDQ6VXNlcjIyNzQ0MzMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/22744333?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/catalin560', 'html_url': 'https://github.com/catalin560', 'followers_url': 'https://api.github.com/users/catalin560/fo... | null | [
"It doesn't look like this bug report has enough info for one of us to reproduce it.\r\n\r\nPlease provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. Screenshots or videos can also be helpful if they help provide con... | 2020-08-13 11:35:16 | 2020-08-13 15:25:17 | 2020-08-13 15:25:17 | NONE | null | null | null | 
When I click on the React Developer Tools icon from the toolbar menu it says: _This page is using the development build of React_
but when I try to access either tabs in the developer tools it say... | {'url': 'https://api.github.com/repos/facebook/react/issues/19601/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19601/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19600 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19600/labels{/name} | https://api.github.com/repos/facebook/react/issues/19600/comments | https://api.github.com/repos/facebook/react/issues/19600/events | https://github.com/facebook/react/pull/19600 | 678,351,348 | MDExOlB1bGxSZXF1ZXN0NDY3MzEzNzcy | 19,600 | Remove unused argument | {'login': 'inottn', 'id': 18509404, 'node_id': 'MDQ6VXNlcjE4NTA5NDA0', 'avatar_url': 'https://avatars.githubusercontent.com/u/18509404?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/inottn', 'html_url': 'https://github.com/inottn', 'followers_url': 'https://api.github.com/users/inottn/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @inottn! \n\nThank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on beha... | 2020-08-13 11:05:45 | 2020-08-31 14:34:44 | 2020-08-13 14:11:02 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19600', 'html_url': 'https://github.com/facebook/react/pull/19600', 'diff_url': 'https://github.com/facebook/react/pull/19600.diff', 'patch_url': 'https://github.com/facebook/react/pull/19600.patch', 'merged_at': datetime.datetime(2020, 8, 13, 14, 11, 2)} | This PR just removes an unused argument. | {'url': 'https://api.github.com/repos/facebook/react/issues/19600/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19600/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19599 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19599/labels{/name} | https://api.github.com/repos/facebook/react/issues/19599/comments | https://api.github.com/repos/facebook/react/issues/19599/events | https://github.com/facebook/react/pull/19599 | 678,140,008 | MDExOlB1bGxSZXF1ZXN0NDY3MTM4MzM4 | 19,599 | Move commit passive unmount/mount to CommitWork | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19599/builds/45855) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-13 04:27:05 | 2020-08-13 18:54:55 | 2020-08-13 16:17:34 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19599', 'html_url': 'https://github.com/facebook/react/pull/19599', 'diff_url': 'https://github.com/facebook/react/pull/19599.diff', 'patch_url': 'https://github.com/facebook/react/pull/19599.patch', 'merged_at': datetime.datetime(2020, 8, 13, 16, 17, 34)} | CommitWork is meant to represent the thing that is specific to each Fiber type/tag. CommitWork/BeingWork/CompleteWork/UnwindWork all have that split. They could one day be replaced with a virtual dispatch onto a method on each Fiber type for example.
This moves the actual invocation of the effect list to CommitWork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19599/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19599/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19598 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19598/labels{/name} | https://api.github.com/repos/facebook/react/issues/19598/comments | https://api.github.com/repos/facebook/react/issues/19598/events | https://github.com/facebook/react/pull/19598 | 678,118,647 | MDExOlB1bGxSZXF1ZXN0NDY3MTIxNjU5 | 19,598 | refactor fb.me redirect link to reactjs.org/link | {'login': 'cylim', 'id': 5622951, 'node_id': 'MDQ6VXNlcjU2MjI5NTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5622951?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cylim', 'html_url': 'https://github.com/cylim', 'followers_url': 'https://api.github.com/users/cylim/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19598/builds/46771) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-13 03:20:48 | 2020-11-23 04:54:42 | 2020-08-17 12:25:51 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19598', 'html_url': 'https://github.com/facebook/react/pull/19598', 'diff_url': 'https://github.com/facebook/react/pull/19598.diff', 'patch_url': 'https://github.com/facebook/react/pull/19598.patch', 'merged_at': datetime.datetime(2020, 8, 17, 12, 25, 51)} | ref #16109
ref https://github.com/reactjs/reactjs.org/pull/3199
The reason for these quick changes is to allow developers from countries or corporations that blocked fb.me(Social Media) to view error/warning messages in detail. | {'url': 'https://api.github.com/repos/facebook/react/issues/19598/reactions', 'total_count': 31, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 26, 'confused': 0, 'heart': 5, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19598/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19597 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19597/labels{/name} | https://api.github.com/repos/facebook/react/issues/19597/comments | https://api.github.com/repos/facebook/react/issues/19597/events | https://github.com/facebook/react/issues/19597 | 678,098,071 | MDU6SXNzdWU2NzgwOTgwNzE= | 19,597 | Bug: Wont set file to state with hooks | {'login': 'psyKressX', 'id': 50396417, 'node_id': 'MDQ6VXNlcjUwMzk2NDE3', 'avatar_url': 'https://avatars.githubusercontent.com/u/50396417?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/psyKressX', 'html_url': 'https://github.com/psyKressX', 'followers_url': 'https://api.github.com/users/psyKressX/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hi, Why do you think `files` is not be set?. Here is a [reproduce](https://codesandbox.io/s/bold-shadow-56fx8?file=/src/App.js), it can work.",
"@jameslahm because in the component dev tools its still an empty array, also i set up a useEffect for files to console.log(files) and its empty, also when i send it to ... | 2020-08-13 02:21:26 | 2020-08-15 04:30:29 | 2020-08-15 04:30:29 | NONE | null | null | null | I'm having an issue where the state is refusing to be set to a file, below is a summarised version of my code
```
let [files, setFiles] = useState([]);
const handleFile = (file, index) => {
let old = [...files];
old[index] = file;
setFiles(old);
}
<input type="file" accept="image... | {'url': 'https://api.github.com/repos/facebook/react/issues/19597/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19597/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19596 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19596/labels{/name} | https://api.github.com/repos/facebook/react/issues/19596/comments | https://api.github.com/repos/facebook/react/issues/19596/events | https://github.com/facebook/react/pull/19596 | 678,096,842 | MDExOlB1bGxSZXF1ZXN0NDY3MTA1NDA0 | 19,596 | Updated react-dom readme, changed class components to function components | {'login': 'YohanTz', 'id': 37301269, 'node_id': 'MDQ6VXNlcjM3MzAxMjY5', 'avatar_url': 'https://avatars.githubusercontent.com/u/37301269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/YohanTz', 'html_url': 'https://github.com/YohanTz', 'followers_url': 'https://api.github.com/users/YohanTz/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19596/builds/45849) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-13 02:17:41 | 2020-09-26 16:48:59 | 2020-09-26 16:48:54 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19596', 'html_url': 'https://github.com/facebook/react/pull/19596', 'diff_url': 'https://github.com/facebook/react/pull/19596.diff', 'patch_url': 'https://github.com/facebook/react/pull/19596.patch', 'merged_at': None} | ## Summary
Hi, I'm a bit new to react and I saw that the react-dom `README.md` contained class components and I thought that it would be great to replace them by function components as they are lighter 😬
## Test Plan
`yarn test`
| {'url': 'https://api.github.com/repos/facebook/react/issues/19596/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19596/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19595 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19595/labels{/name} | https://api.github.com/repos/facebook/react/issues/19595/comments | https://api.github.com/repos/facebook/react/issues/19595/events | https://github.com/facebook/react/pull/19595 | 678,089,995 | MDExOlB1bGxSZXF1ZXN0NDY3MDk5OTYy | 19,595 | [Scheduler] Re-throw unhandled errors | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19595/builds/45851) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-13 01:56:23 | 2020-08-13 03:06:44 | 2020-08-13 03:06:44 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19595', 'html_url': 'https://github.com/facebook/react/pull/19595', 'diff_url': 'https://github.com/facebook/react/pull/19595.diff', 'patch_url': 'https://github.com/facebook/react/pull/19595.patch', 'merged_at': datetime.datetime(2020, 8, 13, 3, 6, 44)} | Because `postTask` returns a promise, errors inside a `postTask` callback result in the promise being rejected.
If we don't catch those errors, then the browser will report an "Unhandled promise rejection" error. This is a confusing message to see in the console, because the fact that `postTask` is a promise-based A... | {'url': 'https://api.github.com/repos/facebook/react/issues/19595/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19595/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19594 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19594/labels{/name} | https://api.github.com/repos/facebook/react/issues/19594/comments | https://api.github.com/repos/facebook/react/issues/19594/events | https://github.com/facebook/react/issues/19594 | 678,068,631 | MDU6SXNzdWU2NzgwNjg2MzE= | 19,594 | Chrome DevTools tab icon doesn't match screenshots on webstore | {'login': 'swrobel', 'id': 157270, 'node_id': 'MDQ6VXNlcjE1NzI3MA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/157270?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/swrobel', 'html_url': 'https://github.com/swrobel', 'followers_url': 'https://api.github.com/users/swrobel/followers', 'follow... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"I'm... not sure why we're using the \"⚛\" character instead of \"⚛️ \"\r\n\r\nMaybe it got messed up on (git) import between repos?\r\n\r\nEdit: Both render the same here on GitHub."
] | 2020-08-13 00:55:22 | 2020-08-13 15:16:36 | 2020-08-13 15:16:36 | NONE | null | null | null | ## The current behavior
React logo in the tab is extremely small & indecipherable
<img width="176" alt="Screen Shot 2020-08-12 at 5 54 27 PM" src="https://user-images.githubusercontent.com/157270/90082546-e3192c80-dcc4-11ea-81e0-f53cd86f6bda.png">
## The expected behavior
Should be as [shown here](https://chrome.... | {'url': 'https://api.github.com/repos/facebook/react/issues/19594/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19594/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19593 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19593/labels{/name} | https://api.github.com/repos/facebook/react/issues/19593/comments | https://api.github.com/repos/facebook/react/issues/19593/events | https://github.com/facebook/react/pull/19593 | 677,717,800 | MDExOlB1bGxSZXF1ZXN0NDY2NzkxNzI4 | 19,593 | refactor fb.me redirect link to original link | {'login': 'cylim', 'id': 5622951, 'node_id': 'MDQ6VXNlcjU2MjI5NTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5622951?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cylim', 'html_url': 'https://github.com/cylim', 'followers_url': 'https://api.github.com/users/cylim/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19593/builds/45746) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-12 14:00:36 | 2020-08-13 00:14:27 | 2020-08-13 00:14:27 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19593', 'html_url': 'https://github.com/facebook/react/pull/19593', 'diff_url': 'https://github.com/facebook/react/pull/19593.diff', 'patch_url': 'https://github.com/facebook/react/pull/19593.patch', 'merged_at': None} | ## Summary
ref #16109
The reason for these quick changes is to allow developers from countries or corporations that blocked Facebook(Social Media) to view error/warning messages in detail.
## Issues
1. I did not fix the link [https://fb.me/react-mock-scheduler](https://fb.me/react-mock-scheduler) due to it i... | {'url': 'https://api.github.com/repos/facebook/react/issues/19593/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19593/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19592 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19592/labels{/name} | https://api.github.com/repos/facebook/react/issues/19592/comments | https://api.github.com/repos/facebook/react/issues/19592/events | https://github.com/facebook/react/pull/19592 | 677,548,648 | MDExOlB1bGxSZXF1ZXN0NDY2NjQ4NDI4 | 19,592 | [react-reconciler] Optimize ReactFiberDevToolsHook for bundle size | {'login': 'wojtekmaj', 'id': 5426427, 'node_id': 'MDQ6VXNlcjU0MjY0Mjc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5426427?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/wojtekmaj', 'html_url': 'https://github.com/wojtekmaj', 'followers_url': 'https://api.github.com/users/wojtekmaj/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19592/builds/45693) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-12 09:38:25 | 2020-08-12 09:55:27 | 2020-08-12 09:55:22 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19592', 'html_url': 'https://github.com/facebook/react/pull/19592', 'diff_url': 'https://github.com/facebook/react/pull/19592.diff', 'patch_url': 'https://github.com/facebook/react/pull/19592.patch', 'merged_at': None} | ## Summary
This piece of code:
https://github.com/facebook/react/blob/db6513914f99c260090f26f0a547ee1432c934e6/packages/react-reconciler/src/ReactFiberDevToolsHook.new.js#L27-L30
can be optimized for bundle size if we reuse the same check that is performed just above:
https://github.com/facebook/react/blob/... | {'url': 'https://api.github.com/repos/facebook/react/issues/19592/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19592/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19591 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19591/labels{/name} | https://api.github.com/repos/facebook/react/issues/19591/comments | https://api.github.com/repos/facebook/react/issues/19591/events | https://github.com/facebook/react/issues/19591 | 677,517,635 | MDU6SXNzdWU2Nzc1MTc2MzU= | 19,591 | Bug: 'use strict' at global level causes issues with scripts concatenation. | {'login': 'asimen1', 'id': 12048798, 'node_id': 'MDQ6VXNlcjEyMDQ4Nzk4', 'avatar_url': 'https://avatars.githubusercontent.com/u/12048798?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/asimen1', 'html_url': 'https://github.com/asimen1', 'followers_url': 'https://api.github.com/users/asimen1/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"@bvaughn @koba04 @gaearon Thanks for the super quick handling!"
] | 2020-08-12 08:50:57 | 2020-08-17 09:34:52 | 2020-08-15 13:42:50 | NONE | null | null | null | React version: 16.13.1
Even though React's code (and other packages like ReactDOM) are wrapped in a IIFE, the code applies an **entire script** strict mode by placing a **'use strict' before any other statement**:
https://cdnjs.cloudflare.com/ajax/libs/react/16.13.1/umd/react.production.min.js
https://cdnjs.cloudf... | {'url': 'https://api.github.com/repos/facebook/react/issues/19591/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19591/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19590 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19590/labels{/name} | https://api.github.com/repos/facebook/react/issues/19590/comments | https://api.github.com/repos/facebook/react/issues/19590/events | https://github.com/facebook/react/pull/19590 | 677,281,470 | MDExOlB1bGxSZXF1ZXN0NDY2NDIzOTQ0 | 19,590 | [eslint-plugin-react-hooks] Report constant constructions | {'login': 'captbaritone', 'id': 162735, 'node_id': 'MDQ6VXNlcjE2MjczNQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/162735?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/captbaritone', 'html_url': 'https://github.com/captbaritone', 'followers_url': 'https://api.github.com/users/captbaritone... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19590/builds/46007) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-12 00:15:24 | 2020-11-12 12:25:33 | 2020-08-13 19:54:33 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19590', 'html_url': 'https://github.com/facebook/react/pull/19590', 'diff_url': 'https://github.com/facebook/react/pull/19590.diff', 'patch_url': 'https://github.com/facebook/react/pull/19590.patch', 'merged_at': datetime.datetime(2020, 8, 13, 19, 54, 33)} | ## Summary
This PR expands upon the existing logic which will report functions defined inside the render function as invalid hook dependencies.
We can now detect additional types of expressions which will result in values that will be referentially unique on each render, such as `[]` or `{}`.
```
function MyC... | {'url': 'https://api.github.com/repos/facebook/react/issues/19590/reactions', 'total_count': 13, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 9, 'confused': 0, 'heart': 3, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19590/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19589 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19589/labels{/name} | https://api.github.com/repos/facebook/react/issues/19589/comments | https://api.github.com/repos/facebook/react/issues/19589/events | https://github.com/facebook/react/issues/19589 | 677,044,240 | MDU6SXNzdWU2NzcwNDQyNDA= | 19,589 | Bug: SVG foreignObject misplaced on browser zoom in React app | {'login': 'maazadeeb', 'id': 6594255, 'node_id': 'MDQ6VXNlcjY1OTQyNTU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6594255?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/maazadeeb', 'html_url': 'https://github.com/maazadeeb', 'followers_url': 'https://api.github.com/users/maazadeeb/followers... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"What makes you suspect that this bug is caused by React and not the browser itself or antd?\r\n\r\nFor what it's worth, antd is a third party UI library. It's not something owned or maintained by the React team, so removing it from your minimal repro would probably be a good first step. (Reducing the number of pot... | 2020-08-11 17:05:18 | 2023-09-04 09:39:24 | 2022-03-30 00:56:46 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.13.1
User Agent: `Mozilla/5.0 (Macintosh; Intel Mac OS X 10_1... | {'url': 'https://api.github.com/repos/facebook/react/issues/19589/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19589/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19588 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19588/labels{/name} | https://api.github.com/repos/facebook/react/issues/19588/comments | https://api.github.com/repos/facebook/react/issues/19588/events | https://github.com/facebook/react/pull/19588 | 676,939,631 | MDExOlB1bGxSZXF1ZXN0NDY2MTUzMzcy | 19,588 | Don't stringify DOM attributes | {'login': 'koto', 'id': 128171, 'node_id': 'MDQ6VXNlcjEyODE3MQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/128171?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/koto', 'html_url': 'https://github.com/koto', 'followers_url': 'https://api.github.com/users/koto/followers', 'following_url': 'h... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19588/builds/45553) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-11 14:47:36 | 2022-10-20 23:16:09 | 2022-10-20 20:41:27 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19588', 'html_url': 'https://github.com/facebook/react/pull/19588', 'diff_url': 'https://github.com/facebook/react/pull/19588.diff', 'patch_url': 'https://github.com/facebook/react/pull/19588.patch', 'merged_at': None} | *Edit*: Updated to reflect the recent changes.
Instead of using Trusted Types feature flag, assume that the browser would stringify the attributes, so that React-DOM doesn't have to (making interpolation into node attributes "just work" regardless of the Trusted Types enforcement and availability) . Currently only I... | {'url': 'https://api.github.com/repos/facebook/react/issues/19588/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19588/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19587 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19587/labels{/name} | https://api.github.com/repos/facebook/react/issues/19587/comments | https://api.github.com/repos/facebook/react/issues/19587/events | https://github.com/facebook/react/issues/19587 | 676,815,872 | MDU6SXNzdWU2NzY4MTU4NzI= | 19,587 | DOM attribute stringification fixes | {'login': 'koto', 'id': 128171, 'node_id': 'MDQ6VXNlcjEyODE3MQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/128171?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/koto', 'html_url': 'https://github.com/koto', 'followers_url': 'https://api.github.com/users/koto/followers', 'following_url': 'h... | [{'id': 121709921, 'node_id': 'MDU6TGFiZWwxMjE3MDk5MjE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Feature%20Request', 'name': 'Type: Feature Request', 'color': 'c7def8', 'default': False, 'description': None}] | open | false | null | [] | null | [
"We briefly chatted about this with @sebmarkbage and he suggested it's still a bit too risky to put in 17.0 (for which we have an RC) but might be okay to put in 17.1 if we're confident it's not a breaking change and if there is exhaustive browser testing.",
"No worries. In the meantime I found some interactions ... | 2020-08-11 11:54:42 | 2023-07-17 08:44:17 | null | CONTRIBUTOR | null | null | null | This is regarding the discussion in #17773.
React-DOM currently stringifies DOM attribute values before passing them to `Element.setAttribute(NS)` functions. This might be unnecessary, as these functions implicitly stringify attribute values on their own (WebIDL attributes typed as `DOMString`). It also makes it d... | {'url': 'https://api.github.com/repos/facebook/react/issues/19587/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19587/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/19586 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19586/labels{/name} | https://api.github.com/repos/facebook/react/issues/19586/comments | https://api.github.com/repos/facebook/react/issues/19586/events | https://github.com/facebook/react/issues/19586 | 676,592,963 | MDU6SXNzdWU2NzY1OTI5NjM= | 19,586 | Bug: useState() not working properly with requestAnimationFrame v/s this.setState() working fine...!!! | {'login': 'KushagraMehta', 'id': 44107706, 'node_id': 'MDQ6VXNlcjQ0MTA3NzA2', 'avatar_url': 'https://avatars.githubusercontent.com/u/44107706?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/KushagraMehta', 'html_url': 'https://github.com/KushagraMehta', 'followers_url': 'https://api.github.com/users/Kusha... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hi, the cause is that useState hook will shallow equal the argument, similarly `Object.is`, if it equals, useState will not update. So `setDataArray(tmpDataArray.current);` will not update, because `tmpDataArray.current` remains constant(reference), And you can change to `setDataArray(new Uint8Array(tmpDataArray.c... | 2020-08-11 05:30:49 | 2020-08-11 12:07:34 | 2020-08-11 12:07:34 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.12.0
## Link to code example:
1. [useState()](https://codes... | {'url': 'https://api.github.com/repos/facebook/react/issues/19586/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19586/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19585 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19585/labels{/name} | https://api.github.com/repos/facebook/react/issues/19585/comments | https://api.github.com/repos/facebook/react/issues/19585/events | https://github.com/facebook/react/issues/19585 | 676,574,059 | MDU6SXNzdWU2NzY1NzQwNTk= | 19,585 | Struggling while reading codes on the docs. | {'login': 'shahriarpshuvo', 'id': 22437186, 'node_id': 'MDQ6VXNlcjIyNDM3MTg2', 'avatar_url': 'https://avatars.githubusercontent.com/u/22437186?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shahriarpshuvo', 'html_url': 'https://github.com/shahriarpshuvo', 'followers_url': 'https://api.github.com/users/sh... | [] | closed | false | null | [] | null | [
"Hey @Mr-spShuvo ,\r\nCan you refresh your browser, please? I can't reproduce the error here, mine works fine with chrome 79",
"So, I did check. It worked on my Chrome as well. But with my firefox developer edition, it's the same as before.",
"I made a mistake, it's work with firefox 79, sorry",
"Hey @judicae... | 2020-08-11 04:40:02 | 2020-08-12 07:48:41 | 2020-08-11 09:22:29 | NONE | null | null | null | Hi, there.
I'm relatively new here and trying to learn react by reading the react documentations.
But as a beginner, I found it's really hard to reading and understanding codes on the documentation website as I think there is **an design issue** as well. On the codes, some of the lines are way much off the screen an... | {'url': 'https://api.github.com/repos/facebook/react/issues/19585/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19585/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19584 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19584/labels{/name} | https://api.github.com/repos/facebook/react/issues/19584/comments | https://api.github.com/repos/facebook/react/issues/19584/events | https://github.com/facebook/react/pull/19584 | 676,511,014 | MDExOlB1bGxSZXF1ZXN0NDY1ODA5MjIy | 19,584 | Issue/#19545 | {'login': 'pfongkye', 'id': 1062699, 'node_id': 'MDQ6VXNlcjEwNjI2OTk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1062699?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pfongkye', 'html_url': 'https://github.com/pfongkye', 'followers_url': 'https://api.github.com/users/pfongkye/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Hi @pfongkye! \n\nThank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on be... | 2020-08-11 01:22:21 | 2020-08-12 17:11:59 | 2020-08-12 16:15:54 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19584', 'html_url': 'https://github.com/facebook/react/pull/19584', 'diff_url': 'https://github.com/facebook/react/pull/19584.diff', 'patch_url': 'https://github.com/facebook/react/pull/19584.patch', 'merged_at': datetime.datetime(2020, 8, 12, 16, 15, 54)} | ## Summary
Fixes #19545
The data.name in a given payload should not be a function since window.postMessage would throw an error.
If I'm on the right path, should we modify `formatDataForPreview` to take into consideration the fact that data.name can be an anonymous function?
![image](https://user-images.githu... | {'url': 'https://api.github.com/repos/facebook/react/issues/19584/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19584/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19583 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19583/labels{/name} | https://api.github.com/repos/facebook/react/issues/19583/comments | https://api.github.com/repos/facebook/react/issues/19583/events | https://github.com/facebook/react/issues/19583 | 676,509,945 | MDU6SXNzdWU2NzY1MDk5NDU= | 19,583 | Bug: Chrome Extension for DevTools Missing | {'login': 'maxehnert', 'id': 8755250, 'node_id': 'MDQ6VXNlcjg3NTUyNTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8755250?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/maxehnert', 'html_url': 'https://github.com/maxehnert', 'followers_url': 'https://api.github.com/users/maxehnert/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"It is appearing fine for me when searching for https://chrome.google.com/webstore/search/react or going to extension's page: https://chrome.google.com/webstore/detail/react-developer-tools/fmkadmapgofadopljbjfkapdkoienihi?hl=en",
"It's working fine, and I can see them \r\n![image](https://user-images.githubuserc... | 2020-08-11 01:18:25 | 2020-08-11 16:30:26 | 2020-08-11 16:30:26 | NONE | null | null | null | The chrome webstore does not appear to have the React DevTools extension listed anymore.
All the links from reactjs.org are going to a 404
React version: N/A
## Steps To Reproduce
1. Go here: https://reactjs.org/docs/optimizing-performance.html#profiling-components-with-the-devtools-profiler
2. Click link t... | {'url': 'https://api.github.com/repos/facebook/react/issues/19583/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19583/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19582 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19582/labels{/name} | https://api.github.com/repos/facebook/react/issues/19582/comments | https://api.github.com/repos/facebook/react/issues/19582/events | https://github.com/facebook/react/issues/19582 | 676,449,045 | MDU6SXNzdWU2NzY0NDkwNDU= | 19,582 | Bug: React-17.0.0-rc.0 react-reconciler focusedInstanceHandle crash | {'login': 'drcmda', 'id': 2223602, 'node_id': 'MDQ6VXNlcjIyMjM2MDI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2223602?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/drcmda', 'html_url': 'https://github.com/drcmda', 'followers_url': 'https://api.github.com/users/drcmda/followers', 'followin... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I think if you return `null` from `prepareToCommit` that would fix it.",
"(Maybe this is a good argument to make the check looser.)",
"indeed that fixed it! are there any other places it needs null?\r\n\r\nlooks better now in r3f, too. it started to run - for a while - then it wipes out the complete content of... | 2020-08-10 22:15:50 | 2022-03-21 18:32:31 | 2020-08-10 22:29:26 | NONE | null | null | null | i tried testing the rc with react-three-fiber, it crashed. so tried with a super reduced minimal renderer, here's the link for testing it: https://codesandbox.io/s/reurope-reconciler-forked-wikus?file=/src/App.js:418-492
change the color in line 13 from hotpink to something else and it crashes the reconciler
<img... | {'url': 'https://api.github.com/repos/facebook/react/issues/19582/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19582/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19581 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19581/labels{/name} | https://api.github.com/repos/facebook/react/issues/19581/comments | https://api.github.com/repos/facebook/react/issues/19581/events | https://github.com/facebook/react/pull/19581 | 676,436,748 | MDExOlB1bGxSZXF1ZXN0NDY1NzQ4NDcx | 19,581 | Append text string to <Text> error message | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Should there be a length limit? What if it's super long?",
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19581/builds/45375) or the icon next to each c... | 2020-08-10 21:48:07 | 2020-08-17 17:47:53 | 2020-08-17 17:47:49 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19581', 'html_url': 'https://github.com/facebook/react/pull/19581', 'diff_url': 'https://github.com/facebook/react/pull/19581.diff', 'patch_url': 'https://github.com/facebook/react/pull/19581.patch', 'merged_at': datetime.datetime(2020, 8, 17, 17, 47, 49)} | ## Summary
Changes the error when rendering strings outside of `<Text>` so that it includes the string text. This will make it slightly easier to identify where the error might be.
## Test Plan
- Ran `yarn test` successfully.
- Ran `yarn test-prod` successfully.
- Ran `yarn prettier` successfully.
- Ran `ya... | {'url': 'https://api.github.com/repos/facebook/react/issues/19581/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19581/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19580 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19580/labels{/name} | https://api.github.com/repos/facebook/react/issues/19580/comments | https://api.github.com/repos/facebook/react/issues/19580/events | https://github.com/facebook/react/issues/19580 | 676,380,748 | MDU6SXNzdWU2NzYzODA3NDg= | 19,580 | Bug: onChange props is being swallowed in Higher-Order-Component | {'login': 'eakl', 'id': 13681710, 'node_id': 'MDQ6VXNlcjEzNjgxNzEw', 'avatar_url': 'https://avatars.githubusercontent.com/u/13681710?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eakl', 'html_url': 'https://github.com/eakl', 'followers_url': 'https://api.github.com/users/eakl/followers', 'following_url'... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"React has no concept of higher order components; this is an abstraction that only exists in your JavaScript code. So this concept cannot be responsible for a problem related to DOM events.\r\n\r\nThere is quite a lot of code in your sandbox. Please try to reduce it to the *minimal* reproducing case so we can take ... | 2020-08-10 20:01:04 | 2020-08-11 12:08:32 | 2020-08-11 12:06:57 | NONE | null | null | null | Input with onChange props lose focus when wrapped in a Higher Order Component
Link to code example:
https://codesandbox.io/s/happy-bell-s6q0z?file=/index.js
React version: 16.13.1
## Steps To Reproduce
1. Focus on any input of **Column 2** with onChange prop
2. Type a 2-digit number (e.g. "23") on it
3... | {'url': 'https://api.github.com/repos/facebook/react/issues/19580/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19580/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19579 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19579/labels{/name} | https://api.github.com/repos/facebook/react/issues/19579/comments | https://api.github.com/repos/facebook/react/issues/19579/events | https://github.com/facebook/react/pull/19579 | 676,378,829 | MDExOlB1bGxSZXF1ZXN0NDY1NzAwMDA3 | 19,579 | Release script should understand prereleases | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19579/builds/45326) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-10 19:57:25 | 2020-08-10 20:43:49 | 2020-08-10 20:43:46 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19579', 'html_url': 'https://github.com/facebook/react/pull/19579', 'diff_url': 'https://github.com/facebook/react/pull/19579.diff', 'patch_url': 'https://github.com/facebook/react/pull/19579.patch', 'merged_at': None} | Without this change, I can't publish an RC as `next`. | {'url': 'https://api.github.com/repos/facebook/react/issues/19579/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19579/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19578 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19578/labels{/name} | https://api.github.com/repos/facebook/react/issues/19578/comments | https://api.github.com/repos/facebook/react/issues/19578/events | https://github.com/facebook/react/pull/19578 | 676,376,001 | MDExOlB1bGxSZXF1ZXN0NDY1Njk3Njc0 | 19,578 | Bump versions for 17 RC | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19578/builds/45327) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-10 19:52:01 | 2021-02-11 16:33:56 | 2021-02-11 16:33:56 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19578', 'html_url': 'https://github.com/facebook/react/pull/19578', 'diff_url': 'https://github.com/facebook/react/pull/19578.diff', 'patch_url': 'https://github.com/facebook/react/pull/19578.patch', 'merged_at': None} | Did this manually. | {'url': 'https://api.github.com/repos/facebook/react/issues/19578/reactions', 'total_count': 4, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 2, 'eyes': 2} | https://api.github.com/repos/facebook/react/issues/19578/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19577 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19577/labels{/name} | https://api.github.com/repos/facebook/react/issues/19577/comments | https://api.github.com/repos/facebook/react/issues/19577/events | https://github.com/facebook/react/pull/19577 | 676,366,084 | MDExOlB1bGxSZXF1ZXN0NDY1Njg5NTU0 | 19,577 | Remove resolutions from test renderer package.json | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19577/builds/45318) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-10 19:32:52 | 2022-11-29 22:22:14 | 2020-08-10 19:45:12 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19577', 'html_url': 'https://github.com/facebook/react/pull/19577', 'diff_url': 'https://github.com/facebook/react/pull/19577.diff', 'patch_url': 'https://github.com/facebook/react/pull/19577.patch', 'merged_at': datetime.datetime(2020, 8, 10, 19, 45, 12)} | This doesn't do anything. They're only taken into account in the top-level package.json AFAIK. | {'url': 'https://api.github.com/repos/facebook/react/issues/19577/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19577/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19576 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19576/labels{/name} | https://api.github.com/repos/facebook/react/issues/19576/comments | https://api.github.com/repos/facebook/react/issues/19576/events | https://github.com/facebook/react/issues/19576 | 676,338,845 | MDU6SXNzdWU2NzYzMzg4NDU= | 19,576 | Bug: | {'login': 'Abdaluzi', 'id': 69045409, 'node_id': 'MDQ6VXNlcjY5MDQ1NDA5', 'avatar_url': 'https://avatars.githubusercontent.com/u/69045409?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Abdaluzi', 'html_url': 'https://github.com/Abdaluzi', 'followers_url': 'https://api.github.com/users/Abdaluzi/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2020-08-10 18:44:10 | 2020-08-10 19:04:30 | 2020-08-10 19:04:30 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/19576/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19576/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19575 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19575/labels{/name} | https://api.github.com/repos/facebook/react/issues/19575/comments | https://api.github.com/repos/facebook/react/issues/19575/events | https://github.com/facebook/react/pull/19575 | 676,337,398 | MDExOlB1bGxSZXF1ZXN0NDY1NjY2Mjkz | 19,575 | Make undefined return value invariant a warning for memo and forwardRef | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19575/builds/45309) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-10 18:41:21 | 2021-02-11 15:44:16 | 2021-02-11 15:44:11 | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/19575', 'html_url': 'https://github.com/facebook/react/pull/19575', 'diff_url': 'https://github.com/facebook/react/pull/19575.diff', 'patch_url': 'https://github.com/facebook/react/pull/19575.patch', 'merged_at': None} | Opening in case we decided to make this change for v17. I don't think it's the right change though. | {'url': 'https://api.github.com/repos/facebook/react/issues/19575/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19575/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19574 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19574/labels{/name} | https://api.github.com/repos/facebook/react/issues/19574/comments | https://api.github.com/repos/facebook/react/issues/19574/events | https://github.com/facebook/react/pull/19574 | 676,334,705 | MDExOlB1bGxSZXF1ZXN0NDY1NjY0MTQ3 | 19,574 | Revert "Warn about undefined return value for memo and forwardRef" | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19574/builds/45308) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-10 18:36:24 | 2022-11-29 22:22:13 | 2020-08-10 19:19:59 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19574', 'html_url': 'https://github.com/facebook/react/pull/19574', 'diff_url': 'https://github.com/facebook/react/pull/19574.diff', 'patch_url': 'https://github.com/facebook/react/pull/19574.patch', 'merged_at': None} | Reverts facebook/react#19550
Let's not have this yet. | {'url': 'https://api.github.com/repos/facebook/react/issues/19574/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19574/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19573 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19573/labels{/name} | https://api.github.com/repos/facebook/react/issues/19573/comments | https://api.github.com/repos/facebook/react/issues/19573/events | https://github.com/facebook/react/issues/19573 | 676,230,521 | MDU6SXNzdWU2NzYyMzA1MjE= | 19,573 | Bug: react-hooks/exhaustive-deps methods used in dependencies array | {'login': 'Ayc0', 'id': 22725671, 'node_id': 'MDQ6VXNlcjIyNzI1Njcx', 'avatar_url': 'https://avatars.githubusercontent.com/u/22725671?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Ayc0', 'html_url': 'https://github.com/Ayc0', 'followers_url': 'https://api.github.com/users/Ayc0/followers', 'following_url'... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"In addition, I noticed that in TS, doing `(foo.bar as <insert type>)()` (like `(foo.bar as any)()`) was enough to properly detect the variable",
"The current behavior is correct. `foo.bar()` has different behavior than `const bar = foo.bar; bar()`:\r\n\r\n```js\r\nconst foo = {\r\n data: 1,\r\n bar(n) {\r\n ... | 2020-08-10 15:37:56 | 2020-08-10 17:16:49 | 2020-08-10 17:16:48 | NONE | null | null | null | `eslint-plugin-react-hooks` version: 4.0.8
## Steps To Reproduce
1. Create a hook with dependencies
2. Use a method on object `like foo.bar()`
3. The entire object is marked as required in the deps array instead of the method (`foo` instead of `foo.bar`)
Link to code example:
https://codesandbox.io/s/exha... | {'url': 'https://api.github.com/repos/facebook/react/issues/19573/reactions', 'total_count': 7, '+1': 7, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19573/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19572 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19572/labels{/name} | https://api.github.com/repos/facebook/react/issues/19572/comments | https://api.github.com/repos/facebook/react/issues/19572/events | https://github.com/facebook/react/issues/19572 | 676,209,318 | MDU6SXNzdWU2NzYyMDkzMTg= | 19,572 | Bug: relatedTarget is undefined in firefox | {'login': 'zoltan-mihalyi', 'id': 3788426, 'node_id': 'MDQ6VXNlcjM3ODg0MjY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3788426?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zoltan-mihalyi', 'html_url': 'https://github.com/zoltan-mihalyi', 'followers_url': 'https://api.github.com/users/zolt... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"looks like this is due to the fact that mozilla doesn't support the `fromElement` or `toElement`event property, which is what the fallback uses when relatedTarget doesn't exist. \r\n\r\nhttps://github.com/facebook/react/blob/dab0854c5e66ca74ca0591fd312d6a654e5aaaf1/packages/react-dom/src/events/SyntheticEvent.js#L... | 2020-08-10 15:08:55 | 2020-08-17 14:02:53 | 2020-08-17 14:02:53 | NONE | null | null | null | React.MouseEvent#relatedTarget is undefined in firefox on windows (should be null)
React version: 16.12.0
## Steps To Reproduce
1. create an onMouseOut event listener on a html element
2. move the mouse to the element
3. move the mouse outside the window (the mouse should not enter other html elements in the... | {'url': 'https://api.github.com/repos/facebook/react/issues/19572/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19572/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19571 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19571/labels{/name} | https://api.github.com/repos/facebook/react/issues/19571/comments | https://api.github.com/repos/facebook/react/issues/19571/events | https://github.com/facebook/react/pull/19571 | 676,148,205 | MDExOlB1bGxSZXF1ZXN0NDY1NTEwMDI0 | 19,571 | Fix double-firing mouseenter | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19571/builds/45245) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-10 13:44:13 | 2020-08-10 14:08:35 | 2020-08-10 14:08:23 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19571', 'html_url': 'https://github.com/facebook/react/pull/19571', 'diff_url': 'https://github.com/facebook/react/pull/19571.diff', 'patch_url': 'https://github.com/facebook/react/pull/19571.patch', 'merged_at': datetime.datetime(2020, 8, 10, 14, 8, 23)} | Fixes https://github.com/facebook/react/issues/19562.
Uses a test from https://github.com/facebook/react/pull/19567.
I think the intention of the original code was to detect if the node is in the React tree, but it didn't check for the root node. So if we got an event with `relatedTarget` being the container node... | {'url': 'https://api.github.com/repos/facebook/react/issues/19571/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19571/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19570 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19570/labels{/name} | https://api.github.com/repos/facebook/react/issues/19570/comments | https://api.github.com/repos/facebook/react/issues/19570/events | https://github.com/facebook/react/issues/19570 | 676,044,234 | MDU6SXNzdWU2NzYwNDQyMzQ= | 19,570 | Bug: onInput is not firing on contentEditable div in IE11 | {'login': 'cy6eria', 'id': 2938040, 'node_id': 'MDQ6VXNlcjI5MzgwNDA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2938040?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cy6eria', 'html_url': 'https://github.com/cy6eria', 'followers_url': 'https://api.github.com/users/cy6eria/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"According to MDN. The input event is just supported on text and password. On the docs, it's saying that this happens on explorer 9. But I'm pretty sure the input event is not completely supported on e11. If you try with vanilla JS code, you will see the same error. Try to use `onKeyUp` or maybe `onChange` accordin... | 2020-08-10 10:50:30 | 2022-03-30 00:55:43 | 2022-03-30 00:55:42 | NONE | null | null | null | When using onInput event on contentEditable div, the event is not being fired on IE11. It does work on Chrome 84.0.4147.105 (64-bit).
React version: 16.13.1
I can't find any service which supports IE, thats why I provide only code example.
Code example:
```
const MessageBox = () => {
const [state, setSt... | {'url': 'https://api.github.com/repos/facebook/react/issues/19570/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19570/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19569 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19569/labels{/name} | https://api.github.com/repos/facebook/react/issues/19569/comments | https://api.github.com/repos/facebook/react/issues/19569/events | https://github.com/facebook/react/issues/19569 | 676,011,524 | MDU6SXNzdWU2NzYwMTE1MjQ= | 19,569 | Missing Dependency: ReactDOMServer not available via umd | {'login': 'shirbr510', 'id': 6445074, 'node_id': 'MDQ6VXNlcjY0NDUwNzQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6445074?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shirbr510', 'html_url': 'https://github.com/shirbr510', 'followers_url': 'https://api.github.com/users/shirbr510/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You can find all builds in https://unpkg.com/browse/react-dom@16.9.0/umd/\r\n\r\nIt seems like there is a `ReactDOMServer` build available with https://unpkg.com/react-dom@16.9.0/umd/react-dom-server.browser.production.min.js.\r\n\r\nAll the links work for the latest release `react-dom@16.13.1`.\r\n\r\n> It seems ... | 2020-08-10 09:53:25 | 2020-08-10 10:55:22 | 2020-08-10 10:55:22 | NONE | null | null | null | Due to technical limitations, I'm currently using react in it's UMD form.
As far as I know, `ReactDOMServer` is both for server use and client use.
I tried to find it in `ReactDOM` global, but I was surprised that it is not included OOTB in react-dom 16.
1. Please provide us a way to consume `ReactDOMServer` as um... | {'url': 'https://api.github.com/repos/facebook/react/issues/19569/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19569/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19568 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19568/labels{/name} | https://api.github.com/repos/facebook/react/issues/19568/comments | https://api.github.com/repos/facebook/react/issues/19568/events | https://github.com/facebook/react/pull/19568 | 675,964,193 | MDExOlB1bGxSZXF1ZXN0NDY1MzU3ODg4 | 19,568 | Update outdated lockfile | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19568/builds/45183) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-10 08:36:13 | 2020-08-10 11:46:31 | 2020-08-10 10:59:38 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19568', 'html_url': 'https://github.com/facebook/react/pull/19568', 'diff_url': 'https://github.com/facebook/react/pull/19568.diff', 'patch_url': 'https://github.com/facebook/react/pull/19568.patch', 'merged_at': datetime.datetime(2020, 8, 10, 10, 59, 38)} | ## Summary
```bash
$ yarn -v
1.22.4
$ yarn install
```
in a fresh clone creates a diff in the lockfile. This might be confusing since it might not be obvious if a (potential) failures comes from this diff or the changes you made in a PR.
## Test Plan
- [ ] CI green | {'url': 'https://api.github.com/repos/facebook/react/issues/19568/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19568/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19567 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19567/labels{/name} | https://api.github.com/repos/facebook/react/issues/19567/comments | https://api.github.com/repos/facebook/react/issues/19567/events | https://github.com/facebook/react/pull/19567 | 675,781,495 | MDExOlB1bGxSZXF1ZXN0NDY1MjA5MzUx | 19,567 | test: Simulate mouseover in browser | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19567/builds/45108) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-09 22:13:13 | 2020-08-10 14:10:39 | 2020-08-10 14:10:36 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19567', 'html_url': 'https://github.com/facebook/react/pull/19567', 'diff_url': 'https://github.com/facebook/react/pull/19567.diff', 'patch_url': 'https://github.com/facebook/react/pull/19567.patch', 'merged_at': None} | ## Summary
Failing test for https://github.com/facebook/react/issues/19562
@gaearon had the right idea in https://github.com/facebook/react/issues/19562#issuecomment-671103670
## Test Plan
See https://codesandbox.io/s/simulatemousemove-in-reactnext-hnhh3 for actual browser behavior. It first uses `simulateM... | {'url': 'https://api.github.com/repos/facebook/react/issues/19567/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19567/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19566 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19566/labels{/name} | https://api.github.com/repos/facebook/react/issues/19566/comments | https://api.github.com/repos/facebook/react/issues/19566/events | https://github.com/facebook/react/pull/19566 | 675,707,796 | MDExOlB1bGxSZXF1ZXN0NDY1MTU3NjU5 | 19,566 | Speed up yarn installs in circle builds | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19566/builds/45082) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-09 14:18:46 | 2021-07-02 18:55:35 | 2020-08-11 18:05:15 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19566', 'html_url': 'https://github.com/facebook/react/pull/19566', 'diff_url': 'https://github.com/facebook/react/pull/19566.diff', 'patch_url': 'https://github.com/facebook/react/pull/19566.patch', 'merged_at': datetime.datetime(2020, 8, 11, 18, 5, 15)} | ## Overview
This PR optimizes the circle config so that we run exactly one `yarn install` across the entire workflow, which is itself cached, and then uses a node_modules cache for all subsequent jobs.
## Perf wins
In the parallel jobs you can now see that we completely removed the `yarn install` step, which sha... | {'url': 'https://api.github.com/repos/facebook/react/issues/19566/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 3, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19566/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19565 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19565/labels{/name} | https://api.github.com/repos/facebook/react/issues/19565/comments | https://api.github.com/repos/facebook/react/issues/19565/events | https://github.com/facebook/react/issues/19565 | 675,534,702 | MDU6SXNzdWU2NzU1MzQ3MDI= | 19,565 | Bug: React Portal fails PropType validation as child of BrowserRouter | {'login': 'hnipps', 'id': 18580004, 'node_id': 'MDQ6VXNlcjE4NTgwMDA0', 'avatar_url': 'https://avatars.githubusercontent.com/u/18580004?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hnipps', 'html_url': 'https://github.com/hnipps', 'followers_url': 'https://api.github.com/users/hnipps/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"`prop-types` are not maintained in this repo anymore, you might want to file this in http://github.com/facebook/prop-types.\r\n Thanks!"
] | 2020-08-08 14:34:42 | 2020-08-09 14:03:57 | 2020-08-09 14:03:56 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.3.1
## Steps To Reproduce
1. Create new React app with C... | {'url': 'https://api.github.com/repos/facebook/react/issues/19565/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19565/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19564 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19564/labels{/name} | https://api.github.com/repos/facebook/react/issues/19564/comments | https://api.github.com/repos/facebook/react/issues/19564/events | https://github.com/facebook/react/pull/19564 | 675,530,297 | MDExOlB1bGxSZXF1ZXN0NDY1MDM0Nzcw | 19,564 | Add flow to SyntheticEvent | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19564/builds/47333) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-08 14:03:58 | 2020-08-19 13:23:22 | 2020-08-19 13:16:49 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19564', 'html_url': 'https://github.com/facebook/react/pull/19564', 'diff_url': 'https://github.com/facebook/react/pull/19564.diff', 'patch_url': 'https://github.com/facebook/react/pull/19564.patch', 'merged_at': datetime.datetime(2020, 8, 19, 13, 16, 49)} | ## Summary
Type-check `SyntheticEvent` and unsound usage.
According to the types there were a lot of unnecessary guards against `event._reactName` being `null`. Removing all these checks does not fail any tests but produces unsound types. The origin of `_reactName` being `null` is https://github.com/facebook/reac... | {'url': 'https://api.github.com/repos/facebook/react/issues/19564/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19564/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19563 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19563/labels{/name} | https://api.github.com/repos/facebook/react/issues/19563/comments | https://api.github.com/repos/facebook/react/issues/19563/events | https://github.com/facebook/react/issues/19563 | 675,505,889 | MDU6SXNzdWU2NzU1MDU4ODk= | 19,563 | Bug: Cursor of controlled input of type email jumps to the beginning of input while deleting | {'login': 'MrDonArmando', 'id': 46261899, 'node_id': 'MDQ6VXNlcjQ2MjYxODk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/46261899?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MrDonArmando', 'html_url': 'https://github.com/MrDonArmando', 'followers_url': 'https://api.github.com/users/MrDonArm... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"I can't reproduce the behavior described using Chrome, Firefox, or Safari (MacOS 10.15.6).",
"@bvaughn I checked it only on Windows 10 and Ubuntu 20.04",
"I can repro.",
"This is the same as https://github.com/facebook/react/issues/15418."
] | 2020-08-08 10:50:56 | 2020-08-17 12:53:09 | 2020-08-17 12:53:09 | NONE | null | null | null | At least 2 words needs to be typed. Then after deleting first one from the end cursor jumps to the beginning of input. It happens only for input of type email so it's supposed to be one word(email) but let's say that user typed second word by mistake and then trying to delete cursor jumps to the end. It happens on Chro... | {'url': 'https://api.github.com/repos/facebook/react/issues/19563/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19563/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19562 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19562/labels{/name} | https://api.github.com/repos/facebook/react/issues/19562/comments | https://api.github.com/repos/facebook/react/issues/19562/events | https://github.com/facebook/react/issues/19562 | 675,502,089 | MDU6SXNzdWU2NzU1MDIwODk= | 19,562 | Bug: mouseEnter fires twice in react@next | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"hei, I'd like to give a shot on this but, stupid question, it's my first time and I don't know which branch points to the next version. I didn't find any useful tip on the contribution guide about how to navigate across versions in cloned repo ",
"When I tested on this issue with react next https://codesandbox.i... | 2020-08-08 10:25:23 | 2020-08-10 14:08:23 | 2020-08-10 14:08:23 | COLLABORATOR | null | null | null | React version: 0.0.0-f77c7b9d7
Browser: Chrome Version 84.0.4147.105 (Official Build) (64-bit)
OS: Ubuntu 18.04.4 LTS
## Steps To Reproduce
1. move mouse over button
Link to code example:
https://codesandbox.io/s/mouseenter-in-reactnext-ibld3?file=/src/Demo.js
## The current behavior
`onMouseEnter` ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19562/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19562/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19561 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19561/labels{/name} | https://api.github.com/repos/facebook/react/issues/19561/comments | https://api.github.com/repos/facebook/react/issues/19561/events | https://github.com/facebook/react/pull/19561 | 675,483,227 | MDExOlB1bGxSZXF1ZXN0NDY1MDAxNjEy | 19,561 | fix: onFocus/onBlur/onBeforeInput have a matching event type | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19561/builds/45202) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-08 07:56:19 | 2020-08-10 11:59:04 | 2020-08-10 11:54:11 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19561', 'html_url': 'https://github.com/facebook/react/pull/19561', 'diff_url': 'https://github.com/facebook/react/pull/19561.diff', 'patch_url': 'https://github.com/facebook/react/pull/19561.patch', 'merged_at': datetime.datetime(2020, 8, 10, 11, 54, 11)} | ## Summary
So far `event.type` always matched the listener name in React even though the underlying native event might be a different type (e.g. `onMouseEnter`). The recent changes to focus events made `onFocus` and `onBlur` the only two events whose `event.type` did not match (`onFocus` -> `focusin`, `onBlur` -> `f... | {'url': 'https://api.github.com/repos/facebook/react/issues/19561/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19561/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19560 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19560/labels{/name} | https://api.github.com/repos/facebook/react/issues/19560/comments | https://api.github.com/repos/facebook/react/issues/19560/events | https://github.com/facebook/react/issues/19560 | 675,320,516 | MDU6SXNzdWU2NzUzMjA1MTY= | 19,560 | Bug: event.type no longer matches the listener name for onFocus and onBlur | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"If you'd like to send a fix we'll take it! Otherwise I'll look on Monday."
] | 2020-08-07 22:30:51 | 2020-08-10 11:54:11 | 2020-08-10 11:54:11 | COLLABORATOR | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 0.0.0-f77c7b9d7
## Steps To Reproduce
1. listen to `onFocus... | {'url': 'https://api.github.com/repos/facebook/react/issues/19560/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19560/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19559 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19559/labels{/name} | https://api.github.com/repos/facebook/react/issues/19559/comments | https://api.github.com/repos/facebook/react/issues/19559/events | https://github.com/facebook/react/pull/19559 | 675,318,394 | MDExOlB1bGxSZXF1ZXN0NDY0ODU2MjE2 | 19,559 | provide profiling bundle for react-reconciler | {'login': 'misterdjules', 'id': 811047, 'node_id': 'MDQ6VXNlcjgxMTA0Nw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/811047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/misterdjules', 'html_url': 'https://github.com/misterdjules', 'followers_url': 'https://api.github.com/users/misterdjules... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @misterdjules! \n\nThank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing o... | 2020-08-07 22:23:42 | 2020-08-19 13:11:32 | 2020-08-19 13:11:28 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19559', 'html_url': 'https://github.com/facebook/react/pull/19559', 'diff_url': 'https://github.com/facebook/react/pull/19559.diff', 'patch_url': 'https://github.com/facebook/react/pull/19559.patch', 'merged_at': datetime.datetime(2020, 8, 19, 13, 11, 28)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19559/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19559/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19558 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19558/labels{/name} | https://api.github.com/repos/facebook/react/issues/19558/comments | https://api.github.com/repos/facebook/react/issues/19558/events | https://github.com/facebook/react/issues/19558 | 675,300,803 | MDU6SXNzdWU2NzUzMDA4MDM= | 19,558 | Bug: In react@next ShadowRoot as rootElement in ReactDOM.render crashes | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Fixed in `17.0.0-rc.1`."
] | 2020-08-07 21:30:44 | 2020-08-28 11:40:57 | 2020-08-17 14:47:50 | COLLABORATOR | null | null | null | React version: 0.0.0-f77c7b9d7
## Steps To Reproduce
1. Mount a component with even listeners in a `ShadowRoot`
Link to code example:
- [codesandbox with `react@next`](https://codesandbox.io/s/next-shadowroot-as-root-element-pkktc) (crashes)
- [codesandbox with `react@16.13.1`](https://codesandbox.io/s/16-... | {'url': 'https://api.github.com/repos/facebook/react/issues/19558/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19558/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19557 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19557/labels{/name} | https://api.github.com/repos/facebook/react/issues/19557/comments | https://api.github.com/repos/facebook/react/issues/19557/events | https://github.com/facebook/react/pull/19557 | 675,296,020 | MDExOlB1bGxSZXF1ZXN0NDY0ODM4MTM0 | 19,557 | Seperate beforeBlur/afterBlur | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19557/builds/44835) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-08-07 21:18:16 | 2022-10-20 20:41:26 | 2022-10-20 20:41:26 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19557', 'html_url': 'https://github.com/facebook/react/pull/19557', 'diff_url': 'https://github.com/facebook/react/pull/19557.diff', 'patch_url': 'https://github.com/facebook/react/pull/19557.patch', 'merged_at': None} | This PR does two things:
- Moves the logic for handling `beforeblur`/`afterblur` to a seperate flag internally. Previously, they used the `enableCreateEventHandleAPI` flag, but really the feature of adding functionality for handling focus before and after an active element is removed/hidden has nothing to do with `c... | {'url': 'https://api.github.com/repos/facebook/react/issues/19557/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19557/timeline | null | null | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.