url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/19355 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19355/labels{/name} | https://api.github.com/repos/facebook/react/issues/19355/comments | https://api.github.com/repos/facebook/react/issues/19355/events | https://github.com/facebook/react/pull/19355 | 656,948,730 | MDExOlB1bGxSZXF1ZXN0NDQ5MTU1MjIw | 19,355 | Add engines to package.json | {'login': 'MichaelDeBoey', 'id': 6643991, 'node_id': 'MDQ6VXNlcjY2NDM5OTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6643991?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MichaelDeBoey', 'html_url': 'https://github.com/MichaelDeBoey', 'followers_url': 'https://api.github.com/users/Michael... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19355/builds/39617) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-14 23:03:17 | 2021-09-04 17:13:30 | 2021-09-04 17:13:29 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19355', 'html_url': 'https://github.com/facebook/react/pull/19355', 'diff_url': 'https://github.com/facebook/react/pull/19355.diff', 'patch_url': 'https://github.com/facebook/react/pull/19355.patch', 'merged_at': None} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/19355/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19355/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19354 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19354/labels{/name} | https://api.github.com/repos/facebook/react/issues/19354/comments | https://api.github.com/repos/facebook/react/issues/19354/events | https://github.com/facebook/react/pull/19354 | 656,770,985 | MDExOlB1bGxSZXF1ZXN0NDQ5MDA4ODc1 | 19,354 | Revert #19348 | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19354/builds/39698) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-14 17:16:26 | 2020-07-15 11:27:35 | 2020-07-15 11:27:23 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19354', 'html_url': 'https://github.com/facebook/react/pull/19354', 'diff_url': 'https://github.com/facebook/react/pull/19354.diff', 'patch_url': 'https://github.com/facebook/react/pull/19354.patch', 'merged_at': datetime.datetime(2020, 7, 15, 11, 27, 23)} | This reverts https://github.com/facebook/react/pull/19348, so we can investigate if this is the PRs causing the issue with the internal www sync. | {'url': 'https://api.github.com/repos/facebook/react/issues/19354/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19354/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19353 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19353/labels{/name} | https://api.github.com/repos/facebook/react/issues/19353/comments | https://api.github.com/repos/facebook/react/issues/19353/events | https://github.com/facebook/react/issues/19353 | 656,746,548 | MDU6SXNzdWU2NTY3NDY1NDg= | 19,353 | [DEFECT] React Dev Tools search for components | {'login': 'BrittaniePham', 'id': 39067245, 'node_id': 'MDQ6VXNlcjM5MDY3MjQ1', 'avatar_url': 'https://avatars.githubusercontent.com/u/39067245?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/BrittaniePham', 'html_url': 'https://github.com/BrittaniePham', 'followers_url': 'https://api.github.com/users/Britt... | [] | closed | false | null | [] | null | [
"closed because someone else has opened this issue prior.",
"Thanks for following up @BrittaniePham!"
] | 2020-07-14 16:34:13 | 2020-07-15 03:32:32 | 2020-07-14 16:37:18 | NONE | null | null | null | The Dev tools have lost the ability to search for components recently.
| {'url': 'https://api.github.com/repos/facebook/react/issues/19353/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19353/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19352 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19352/labels{/name} | https://api.github.com/repos/facebook/react/issues/19352/comments | https://api.github.com/repos/facebook/react/issues/19352/events | https://github.com/facebook/react/pull/19352 | 656,685,220 | MDExOlB1bGxSZXF1ZXN0NDQ4OTQwMDU4 | 19,352 | Tidy up React Scope API | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19352/builds/40063) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-14 15:06:08 | 2020-07-16 15:21:25 | 2020-07-16 15:21:21 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19352', 'html_url': 'https://github.com/facebook/react/pull/19352', 'diff_url': 'https://github.com/facebook/react/pull/19352.diff', 'patch_url': 'https://github.com/facebook/react/pull/19352.patch', 'merged_at': datetime.datetime(2020, 7, 16, 15, 21, 21)} | This PR changes the React Scopes (experimental) API, so it's simpler. Previously, you used Scopes like this:
```jsx
const MyScope = React.unstable_createScope()
function MyComponent() {
return <MyScope>...</MyScope>
}
```
With this PR:
```jsx
const Scope = React.unstable_Scope;
function MyComponen... | {'url': 'https://api.github.com/repos/facebook/react/issues/19352/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19352/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19351 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19351/labels{/name} | https://api.github.com/repos/facebook/react/issues/19351/comments | https://api.github.com/repos/facebook/react/issues/19351/events | https://github.com/facebook/react/issues/19351 | 656,658,808 | MDU6SXNzdWU2NTY2NTg4MDg= | 19,351 | Error: "Commit tree does not contain fiber 11930. This is a bug in React DevTools." | {'login': 'giladaya', 'id': 1459487, 'node_id': 'MDQ6VXNlcjE0NTk0ODc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1459487?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/giladaya', 'html_url': 'https://github.com/giladaya', 'followers_url': 'https://api.github.com/users/giladaya/followers', '... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"Please search issues before opening a new one to see if it's already been reported 😄\r\n\r\nThis issue has already been reported via #18831. Please add any extra information you have to that issue!"
] | 2020-07-14 14:30:28 | 2020-07-14 14:41:03 | 2020-07-14 14:40:56 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. Recorded an activity in the profiler
2. Clicked the largest bar in the commits sequence
3. Got this error
4. Reproducible also when I use the arrows to get to that commit and also with other recorded actions
5. Restarting Chrome seems to have solved the issue
... | {'url': 'https://api.github.com/repos/facebook/react/issues/19351/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19351/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19350 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19350/labels{/name} | https://api.github.com/repos/facebook/react/issues/19350/comments | https://api.github.com/repos/facebook/react/issues/19350/events | https://github.com/facebook/react/issues/19350 | 656,590,846 | MDU6SXNzdWU2NTY1OTA4NDY= | 19,350 | Error: "Commit tree does not contain fiber 7. This is a bug in React DevTools." | {'login': 'ahmadnwira', 'id': 23643923, 'node_id': 'MDQ6VXNlcjIzNjQzOTIz', 'avatar_url': 'https://avatars.githubusercontent.com/u/23643923?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ahmadnwira', 'html_url': 'https://github.com/ahmadnwira', 'followers_url': 'https://api.github.com/users/ahmadnwira/fol... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"Please search issues before opening a new one to see if it's already been reported :smile:\r\n\r\nThis issue has already been reported via #18831. Please add any extra information you have to that issue!"
] | 2020-07-14 12:55:57 | 2020-07-14 13:25:06 | 2020-07-14 13:24:34 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. I was profiling the APP as usual and it just crashed and I have no idea why
DevTools version: 4.8.1-d4eadea6c
Call stack: at N (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:167176)
at T (chrome-extension://fmkadmapgofadopljbjfka... | {'url': 'https://api.github.com/repos/facebook/react/issues/19350/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19350/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19349 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19349/labels{/name} | https://api.github.com/repos/facebook/react/issues/19349/comments | https://api.github.com/repos/facebook/react/issues/19349/events | https://github.com/facebook/react/pull/19349 | 656,551,730 | MDExOlB1bGxSZXF1ZXN0NDQ4ODMwNjUz | 19,349 | fix(reset): set value tracker to default values after form reset | {'login': 'marcosvega91', 'id': 5365582, 'node_id': 'MDQ6VXNlcjUzNjU1ODI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5365582?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/marcosvega91', 'html_url': 'https://github.com/marcosvega91', 'followers_url': 'https://api.github.com/users/marcosvega... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19349/builds/39493) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-14 11:48:39 | 2020-12-25 13:07:16 | 2020-12-25 13:07:16 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19349', 'html_url': 'https://github.com/facebook/react/pull/19349', 'diff_url': 'https://github.com/facebook/react/pull/19349.diff', 'patch_url': 'https://github.com/facebook/react/pull/19349.patch', 'merged_at': None} | ## Summary
I have fixed the bug #19078. The problem was that when a button or an input of type reset was clicked, all inputs inside the same form did not reset to default values.
This was an issue with `ValueTracker` because after a reset it continued to keep values before reset.
## Test Plan
I have added s... | {'url': 'https://api.github.com/repos/facebook/react/issues/19349/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19349/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19348 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19348/labels{/name} | https://api.github.com/repos/facebook/react/issues/19348/comments | https://api.github.com/repos/facebook/react/issues/19348/events | https://github.com/facebook/react/pull/19348 | 656,526,924 | MDExOlB1bGxSZXF1ZXN0NDQ4ODA5OTYw | 19,348 | Fix createEventHandle bug with comment containers | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19348/builds/39479) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-14 11:04:09 | 2020-07-14 12:09:43 | 2020-07-14 12:09:39 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19348', 'html_url': 'https://github.com/facebook/react/pull/19348', 'diff_url': 'https://github.com/facebook/react/pull/19348.diff', 'patch_url': 'https://github.com/facebook/react/pull/19348.patch', 'merged_at': datetime.datetime(2020, 7, 14, 12, 9, 39)} | This PR fixes an issue where `createEventHandle` would incorrectly handle containers/roots that were comment nodes. We should use the `parentNode` of the container in the these cases. | {'url': 'https://api.github.com/repos/facebook/react/issues/19348/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19348/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19347 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19347/labels{/name} | https://api.github.com/repos/facebook/react/issues/19347/comments | https://api.github.com/repos/facebook/react/issues/19347/events | https://github.com/facebook/react/issues/19347 | 656,522,412 | MDU6SXNzdWU2NTY1MjI0MTI= | 19,347 | Error: "Commit tree does not contain fiber 9. This is a bug in React DevTools." | {'login': 'pgorka1', 'id': 34720404, 'node_id': 'MDQ6VXNlcjM0NzIwNDA0', 'avatar_url': 'https://avatars.githubusercontent.com/u/34720404?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pgorka1', 'html_url': 'https://github.com/pgorka1', 'followers_url': 'https://api.github.com/users/pgorka1/followers', 'fo... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"Please search issues before opening a new one to see if it's already been reported :smile:\r\n\r\nThis issue has already been reported via #18831. Please add any extra information you have to that issue!"
] | 2020-07-14 10:56:04 | 2020-07-14 13:25:04 | 2020-07-14 13:24:39 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1.
2.
3.
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.8.1-d4eadea6c
Call stack: at N (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/... | {'url': 'https://api.github.com/repos/facebook/react/issues/19347/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19347/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19346 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19346/labels{/name} | https://api.github.com/repos/facebook/react/issues/19346/comments | https://api.github.com/repos/facebook/react/issues/19346/events | https://github.com/facebook/react/issues/19346 | 656,498,592 | MDU6SXNzdWU2NTY0OTg1OTI= | 19,346 | Provide syntactic sugar for suspense fallback | {'login': 'voliva', 'id': 5365487, 'node_id': 'MDQ6VXNlcjUzNjU0ODc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5365487?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/voliva', 'html_url': 'https://github.com/voliva', 'followers_url': 'https://api.github.com/users/voliva/followers', 'followin... | [] | closed | false | null | [] | null | [
"This a text book case for a HOC:\r\n\r\n```javascript\r\nconst SuspenseProfileTimeline = withSuspense(ProfileTimeline, (props) => <div>Loading posts...</div>)\r\n```\r\n\r\nThat said, it shouldn't be commonly needed, since it almost entirely defeats the purpose of `Suspense`",
"I actually have it solved with HOC... | 2020-07-14 10:15:55 | 2020-07-14 13:29:50 | 2020-07-14 13:29:50 | NONE | null | null | null | When using Suspense for data fetching, I've been using a pattern which I think it's pretty common, which is to wrap the suspended component into another that represents the data is being loaded (with either a message, a spinner, skeleton, etc). As an example:
```js
function ProfileTimeline(props) {
// Try to rea... | {'url': 'https://api.github.com/repos/facebook/react/issues/19346/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19346/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19345 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19345/labels{/name} | https://api.github.com/repos/facebook/react/issues/19345/comments | https://api.github.com/repos/facebook/react/issues/19345/events | https://github.com/facebook/react/pull/19345 | 656,465,369 | MDExOlB1bGxSZXF1ZXN0NDQ4NzYwMDUw | 19,345 | Support iframe for React-Devtools browser extension. | {'login': 'Reflex-Gravity', 'id': 19655674, 'node_id': 'MDQ6VXNlcjE5NjU1Njc0', 'avatar_url': 'https://avatars.githubusercontent.com/u/19655674?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Reflex-Gravity', 'html_url': 'https://github.com/Reflex-Gravity', 'followers_url': 'https://api.github.com/users/Re... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | {'login': 'Reflex-Gravity', 'id': 19655674.0, 'node_id': 'MDQ6VXNlcjE5NjU1Njc0', 'avatar_url': 'https://avatars.githubusercontent.com/u/19655674?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Reflex-Gravity', 'html_url': 'https://github.com/Reflex-Gravity', 'followers_url': 'https://api.github.com/users/... | [{'login': 'Reflex-Gravity', 'id': 19655674, 'node_id': 'MDQ6VXNlcjE5NjU1Njc0', 'avatar_url': 'https://avatars.githubusercontent.com/u/19655674?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Reflex-Gravity', 'html_url': 'https://github.com/Reflex-Gravity', 'followers_url': 'https://api.github.com/users/R... | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19345/builds/39465) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-14 09:22:02 | 2024-04-10 17:03:37 | 2024-04-10 17:03:36 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19345', 'html_url': 'https://github.com/facebook/react/pull/19345', 'diff_url': 'https://github.com/facebook/react/pull/19345.diff', 'patch_url': 'https://github.com/facebook/react/pull/19345.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19345/reactions', 'total_count': 4, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 4} | https://api.github.com/repos/facebook/react/issues/19345/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19344 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19344/labels{/name} | https://api.github.com/repos/facebook/react/issues/19344/comments | https://api.github.com/repos/facebook/react/issues/19344/events | https://github.com/facebook/react/issues/19344 | 656,457,190 | MDU6SXNzdWU2NTY0NTcxOTA= | 19,344 | Error: "Cannot read property 'concat' of undefined" | {'login': 'slavikhard', 'id': 17024771, 'node_id': 'MDQ6VXNlcjE3MDI0Nzcx', 'avatar_url': 'https://avatars.githubusercontent.com/u/17024771?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/slavikhard', 'html_url': 'https://github.com/slavikhard', 'followers_url': 'https://api.github.com/users/slavikhard/fol... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"Please search existing issues to see if something has already been reported before opening a new one :smile:\r\n\r\nThis issue has already been reported as #18256. Please add any extra helpful info you may have to that issue."
] | 2020-07-14 09:09:42 | 2020-07-14 13:26:32 | 2020-07-14 13:26:26 | NONE | null | null | null | DevTools version: 4.8.1-d4eadea6c
Call stack: at N (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:166989)
at T (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:165979)
at e.getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:168938... | {'url': 'https://api.github.com/repos/facebook/react/issues/19344/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19344/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19343 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19343/labels{/name} | https://api.github.com/repos/facebook/react/issues/19343/comments | https://api.github.com/repos/facebook/react/issues/19343/events | https://github.com/facebook/react/issues/19343 | 656,327,143 | MDU6SXNzdWU2NTYzMjcxNDM= | 19,343 | Error: "Commit tree does not contain fiber 20379. This is a bug in React DevTools." | {'login': 'theBstar', 'id': 38653376, 'node_id': 'MDQ6VXNlcjM4NjUzMzc2', 'avatar_url': 'https://avatars.githubusercontent.com/u/38653376?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/theBstar', 'html_url': 'https://github.com/theBstar', 'followers_url': 'https://api.github.com/users/theBstar/followers',... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"Please search issues before opening a new one to see if it's already been reported :smile:\r\n\r\nThis issue has already been reported via #18831. Please add any extra information you have to that issue!"
] | 2020-07-14 05:04:04 | 2020-07-14 13:25:02 | 2020-07-14 13:24:46 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. I have a couple of material UI expansion panel in my code. Each expansion panel contains some cards inside, mounted on expansion open.
2. The one I was profiling the page while opening the panel
3. I saw this error twice.
-------------------------------------... | {'url': 'https://api.github.com/repos/facebook/react/issues/19343/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19343/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19342 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19342/labels{/name} | https://api.github.com/repos/facebook/react/issues/19342/comments | https://api.github.com/repos/facebook/react/issues/19342/events | https://github.com/facebook/react/pull/19342 | 656,262,313 | MDExOlB1bGxSZXF1ZXN0NDQ4NTkzOTg3 | 19,342 | Set current update lane priority for user blocking events | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19342/builds/40365) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-14 01:48:40 | 2020-07-17 17:52:44 | 2020-07-17 16:58:45 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19342', 'html_url': 'https://github.com/facebook/react/pull/19342', 'diff_url': 'https://github.com/facebook/react/pull/19342.diff', 'patch_url': 'https://github.com/facebook/react/pull/19342.patch', 'merged_at': datetime.datetime(2020, 7, 17, 16, 58, 44)} | ## Summary
We missed these callsites in https://github.com/facebook/react/pull/19121 and one is the most common mismatch right now.
| {'url': 'https://api.github.com/repos/facebook/react/issues/19342/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19342/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19341 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19341/labels{/name} | https://api.github.com/repos/facebook/react/issues/19341/comments | https://api.github.com/repos/facebook/react/issues/19341/events | https://github.com/facebook/react/issues/19341 | 656,247,912 | MDU6SXNzdWU2NTYyNDc5MTI= | 19,341 | Feature Request: Map JSX elements to props other then props.children | {'login': 'cnshenj', 'id': 8441956, 'node_id': 'MDQ6VXNlcjg0NDE5NTY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8441956?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cnshenj', 'html_url': 'https://github.com/cnshenj', 'followers_url': 'https://api.github.com/users/cnshenj/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This looks like a substantial change being proposed. :smile: Changes like this should go through our RFC process:\r\nhttps://github.com/reactjs/rfcs#react-rfcs\r\n\r\nThe RFC process is a great opportunity to get more eyeballs on your proposal before it becomes a part of a released version of React. Quite often, e... | 2020-07-14 01:02:39 | 2020-07-14 02:13:17 | 2020-07-14 02:13:17 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
Note: I considered RFC, but this is only a JSX syntax improvement that doesn't b... | {'url': 'https://api.github.com/repos/facebook/react/issues/19341/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19341/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19340 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19340/labels{/name} | https://api.github.com/repos/facebook/react/issues/19340/comments | https://api.github.com/repos/facebook/react/issues/19340/events | https://github.com/facebook/react/issues/19340 | 656,228,952 | MDU6SXNzdWU2NTYyMjg5NTI= | 19,340 | Error: "Commit tree does not contain fiber 12613. This is a bug in React DevTools." | {'login': 'bloycey', 'id': 20733264, 'node_id': 'MDQ6VXNlcjIwNzMzMjY0', 'avatar_url': 'https://avatars.githubusercontent.com/u/20733264?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bloycey', 'html_url': 'https://github.com/bloycey', 'followers_url': 'https://api.github.com/users/bloycey/followers', 'fo... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"Duplicate of #18831"
] | 2020-07-14 00:02:16 | 2020-07-14 02:12:36 | 2020-07-14 02:12:28 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. Recorded activity using profiler tool.
2. Navigated to ranked tab.
3. Error message displayed.
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.8... | {'url': 'https://api.github.com/repos/facebook/react/issues/19340/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19340/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19339 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19339/labels{/name} | https://api.github.com/repos/facebook/react/issues/19339/comments | https://api.github.com/repos/facebook/react/issues/19339/events | https://github.com/facebook/react/pull/19339 | 656,129,647 | MDExOlB1bGxSZXF1ZXN0NDQ4NDgyMTUw | 19,339 | Fix devtools uninitialized options for SSL | {'login': 'digicide', 'id': 38621, 'node_id': 'MDQ6VXNlcjM4NjIx', 'avatar_url': 'https://avatars.githubusercontent.com/u/38621?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/digicide', 'html_url': 'https://github.com/digicide', 'followers_url': 'https://api.github.com/users/digicide/followers', 'followin... | [] | closed | false | null | [] | null | [
"Hi @digicide! \n\nThank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on be... | 2020-07-13 20:49:22 | 2020-07-13 20:57:14 | 2020-07-13 20:50:56 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19339', 'html_url': 'https://github.com/facebook/react/pull/19339', 'diff_url': 'https://github.com/facebook/react/pull/19339.diff', 'patch_url': 'https://github.com/facebook/react/pull/19339.patch', 'merged_at': None} | ## Summary
Fix bug described in #19338. | {'url': 'https://api.github.com/repos/facebook/react/issues/19339/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19339/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19338 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19338/labels{/name} | https://api.github.com/repos/facebook/react/issues/19338/comments | https://api.github.com/repos/facebook/react/issues/19338/events | https://github.com/facebook/react/issues/19338 | 656,123,290 | MDU6SXNzdWU2NTYxMjMyOTA= | 19,338 | Bug: react-devtools error when KEY and CERT are provided, SSL not usable | {'login': 'digicide', 'id': 38621, 'node_id': 'MDQ6VXNlcjM4NjIx', 'avatar_url': 'https://avatars.githubusercontent.com/u/38621?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/digicide', 'html_url': 'https://github.com/digicide', 'followers_url': 'https://api.github.com/users/digicide/followers', 'followin... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"I was able to fix this by changing line 149 in my local copy to:\r\nlet options = {};",
"cc @ittaibaratz Interested in picking this one up?\r\n\r\nOR @digicide, want to submit a fix? :)",
"@digicide's fix sounds good to me - I'll submit a PR shortly.",
"Looks like a PR already got submitted #19336",
"> cc ... | 2020-07-13 20:37:50 | 2020-07-15 17:10:39 | 2020-07-13 20:50:25 | NONE | null | null | null | SSL is not usable because key and cert options are added to an uninitialized options object.
Line 149 of react-devtools/app.html reads 'let options;'
Line 154 and 155 begin with 'options.cert = …'
In every case, this throws an error and enters the catch block.
React version: 16.5.2
react-devtools version: 4.... | {'url': 'https://api.github.com/repos/facebook/react/issues/19338/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19338/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19337 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19337/labels{/name} | https://api.github.com/repos/facebook/react/issues/19337/comments | https://api.github.com/repos/facebook/react/issues/19337/events | https://github.com/facebook/react/pull/19337 | 656,077,035 | MDExOlB1bGxSZXF1ZXN0NDQ4NDM4OTc4 | 19,337 | Fix DevTools handling of empty Suspense tag for legacy renderer versions | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19337/builds/39331) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-13 19:14:08 | 2020-07-13 20:22:00 | 2020-07-13 20:21:57 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19337', 'html_url': 'https://github.com/facebook/react/pull/19337', 'diff_url': 'https://github.com/facebook/react/pull/19337.diff', 'patch_url': 'https://github.com/facebook/react/pull/19337.patch', 'merged_at': datetime.datetime(2020, 7, 13, 20, 21, 57)} | Fixes #19320
This test should fail the new CI task (to run latest DevTools against all recent minor OSS releases) but that does not yet exist. I will set that up with a follow up PR. | {'url': 'https://api.github.com/repos/facebook/react/issues/19337/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19337/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19336 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19336/labels{/name} | https://api.github.com/repos/facebook/react/issues/19336/comments | https://api.github.com/repos/facebook/react/issues/19336/events | https://github.com/facebook/react/pull/19336 | 656,042,594 | MDExOlB1bGxSZXF1ZXN0NDQ4NDEwODM1 | 19,336 | fix mistake in React devtools | {'login': 'b-ponomarenko', 'id': 9141542, 'node_id': 'MDQ6VXNlcjkxNDE1NDI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9141542?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/b-ponomarenko', 'html_url': 'https://github.com/b-ponomarenko', 'followers_url': 'https://api.github.com/users/b-ponom... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19336/builds/39320) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-13 18:10:49 | 2020-07-13 20:49:54 | 2020-07-13 20:49:53 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19336', 'html_url': 'https://github.com/facebook/react/pull/19336', 'diff_url': 'https://github.com/facebook/react/pull/19336.diff', 'patch_url': 'https://github.com/facebook/react/pull/19336.patch', 'merged_at': datetime.datetime(2020, 7, 13, 20, 49, 53)} | ## Summary
Fixed problem when someone is trying to connect to React devtools via SSL
| {'url': 'https://api.github.com/repos/facebook/react/issues/19336/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19336/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19335 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19335/labels{/name} | https://api.github.com/repos/facebook/react/issues/19335/comments | https://api.github.com/repos/facebook/react/issues/19335/events | https://github.com/facebook/react/pull/19335 | 656,017,590 | MDExOlB1bGxSZXF1ZXN0NDQ4MzkwNzgz | 19,335 | Use RetryLanes instead of event time (follow up) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19335/builds/39307) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-13 17:26:44 | 2020-07-13 17:37:34 | 2020-07-13 17:37:34 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19335', 'html_url': 'https://github.com/facebook/react/pull/19335', 'diff_url': 'https://github.com/facebook/react/pull/19335.diff', 'patch_url': 'https://github.com/facebook/react/pull/19335.patch', 'merged_at': datetime.datetime(2020, 7, 13, 17, 37, 34)} | Same logic as #19307. Uses RetryLanes instead of event time to determine if a render includes new updates. | {'url': 'https://api.github.com/repos/facebook/react/issues/19335/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19335/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19334 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19334/labels{/name} | https://api.github.com/repos/facebook/react/issues/19334/comments | https://api.github.com/repos/facebook/react/issues/19334/events | https://github.com/facebook/react/pull/19334 | 656,016,017 | MDExOlB1bGxSZXF1ZXN0NDQ4Mzg5NDQ3 | 19,334 | Scheduling profiler updates | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19334/builds/39353) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-13 17:24:06 | 2023-05-31 16:22:58 | 2020-07-14 02:20:54 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19334', 'html_url': 'https://github.com/facebook/react/pull/19334', 'diff_url': 'https://github.com/facebook/react/pull/19334.diff', 'patch_url': 'https://github.com/facebook/react/pull/19334.patch', 'merged_at': datetime.datetime(2020, 7, 14, 2, 20, 54)} | * Enable `enableSchedulingProfiler` statically for experimental+profiling builds and www+profiling builds.
* Synced debug tracing and scheduling profiler code from old -> new fork.
* Update test `@gate` conditions.
To verify my manual syncing over of these features, I used diff:
### ReactFiberClassComponent
``... | {'url': 'https://api.github.com/repos/facebook/react/issues/19334/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19334/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19333 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19333/labels{/name} | https://api.github.com/repos/facebook/react/issues/19333/comments | https://api.github.com/repos/facebook/react/issues/19333/events | https://github.com/facebook/react/pull/19333 | 655,970,528 | MDExOlB1bGxSZXF1ZXN0NDQ4MzUyNTAw | 19,333 | Bubble onSubmit/onReset behind a feature flag | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19333/builds/39288) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-13 16:09:34 | 2020-07-13 16:18:08 | 2020-07-13 16:17:29 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19333', 'html_url': 'https://github.com/facebook/react/pull/19333', 'diff_url': 'https://github.com/facebook/react/pull/19333.diff', 'patch_url': 'https://github.com/facebook/react/pull/19333.patch', 'merged_at': datetime.datetime(2020, 7, 13, 16, 17, 29)} | Same as https://github.com/facebook/react/pull/19285, but behind a feature flag so it's less of a risk. The flag is off by default, but is adjustable in WWW.
Essentially this is a comeback of https://github.com/facebook/react/pull/13358. When we tried it last time, it broke a few things internally, and we had to rol... | {'url': 'https://api.github.com/repos/facebook/react/issues/19333/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19333/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19332 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19332/labels{/name} | https://api.github.com/repos/facebook/react/issues/19332/comments | https://api.github.com/repos/facebook/react/issues/19332/events | https://github.com/facebook/react/issues/19332 | 655,905,689 | MDU6SXNzdWU2NTU5MDU2ODk= | 19,332 | Bug: Cannot read property 'isCollapsed' of undefined/Some Components Missing in DevTools/Blank tab | {'login': 'AveryTheDev', 'id': 23192489, 'node_id': 'MDQ6VXNlcjIzMTkyNDg5', 'avatar_url': 'https://avatars.githubusercontent.com/u/23192489?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AveryTheDev', 'html_url': 'https://github.com/AveryTheDev', 'followers_url': 'https://api.github.com/users/AveryTheDev... | [{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Needs%20More%20Information', 'name': 'Resolution: Needs More Information', 'color': 'fffde7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU='... | closed | false | {'login': 'AveryTheDev', 'id': 23192489.0, 'node_id': 'MDQ6VXNlcjIzMTkyNDg5', 'avatar_url': 'https://avatars.githubusercontent.com/u/23192489?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AveryTheDev', 'html_url': 'https://github.com/AveryTheDev', 'followers_url': 'https://api.github.com/users/AveryTheD... | [{'login': 'AveryTheDev', 'id': 23192489, 'node_id': 'MDQ6VXNlcjIzMTkyNDg5', 'avatar_url': 'https://avatars.githubusercontent.com/u/23192489?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AveryTheDev', 'html_url': 'https://github.com/AveryTheDev', 'followers_url': 'https://api.github.com/users/AveryTheDe... | null | [
"Can you share a repro (e.g. the project you're trying to use that causes React DevTools to error)? I haven't seen this behavior before, or heard reports of it.",
"I can't share the repo as its my work repo. There was an error like this in the past but it was archived because the poster did not provide steps to r... | 2020-07-13 14:40:57 | 2020-07-15 17:13:22 | 2020-07-15 16:26:21 | NONE | null | null | null | I cannot view all of my components in the Components tab. Sometimes none. It has been occurring all morning and I do not know how to rectify this.
I cannot search for the components by name either. It is not there.
When I was attempting to highlight a component to see its props value, I got the below message afte... | {'url': 'https://api.github.com/repos/facebook/react/issues/19332/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19332/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19331 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19331/labels{/name} | https://api.github.com/repos/facebook/react/issues/19331/comments | https://api.github.com/repos/facebook/react/issues/19331/events | https://github.com/facebook/react/issues/19331 | 655,893,176 | MDU6SXNzdWU2NTU4OTMxNzY= | 19,331 | Bug: Potential Published Debugger in react_devtools_backend.js | {'login': 'JoshBowdenConcepts', 'id': 31220082, 'node_id': 'MDQ6VXNlcjMxMjIwMDgy', 'avatar_url': 'https://avatars.githubusercontent.com/u/31220082?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JoshBowdenConcepts', 'html_url': 'https://github.com/JoshBowdenConcepts', 'followers_url': 'https://api.github.... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is expected. See https://github.com/facebook/react/issues/19308 for more information.",
"TY",
"To clarify, you need to update DevTools to fix this.",
"This still exists in Edge (Chromium) as the extension hasn't been published since 2020/07/09",
"We're waiting for Edge to review the update.",
"We ca... | 2020-07-13 14:23:38 | 2020-07-14 18:09:58 | 2020-07-13 15:05:20 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
There seems to be a published debugger on the react_devtools_backend.js file on th... | {'url': 'https://api.github.com/repos/facebook/react/issues/19331/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19331/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19330 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19330/labels{/name} | https://api.github.com/repos/facebook/react/issues/19330/comments | https://api.github.com/repos/facebook/react/issues/19330/events | https://github.com/facebook/react/issues/19330 | 655,829,946 | MDU6SXNzdWU2NTU4Mjk5NDY= | 19,330 | Feature proposal(eslint-react-hooks): Allow custom known stable values for exhaustive deps | {'login': 'thien-do', 'id': 5953369, 'node_id': 'MDQ6VXNlcjU5NTMzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5953369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/thien-do', 'html_url': 'https://github.com/thien-do', 'followers_url': 'https://api.github.com/users/thien-do/followers', '... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 1249821345, 'node_id': 'MDU6TGFiZWwxMjQ5ODIxMzQ1', 'url': 'https://api.github.c... | closed | false | null | [] | null | [
"Looks like you're asking for the same thing as #19217 so let's move this discussion onto that issue :smile:"
] | 2020-07-13 12:57:19 | 2020-07-13 15:07:07 | 2020-07-13 15:07:00 | NONE | null | null | null | As far as I know the list of known stable values for exhaustive-deps to exclude when checking dependencies are defined in the code of the lint: https://github.com/facebook/react/blob/61dd00db24bec6305bd72908d3617b9f2a5183da/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js#L296-L307
It would be great if this ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19330/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19330/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19329 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19329/labels{/name} | https://api.github.com/repos/facebook/react/issues/19329/comments | https://api.github.com/repos/facebook/react/issues/19329/events | https://github.com/facebook/react/issues/19329 | 655,822,211 | MDU6SXNzdWU2NTU4MjIyMTE= | 19,329 | Error: "Cannot read property 'concat' of undefined" | {'login': 'jedzej', 'id': 57070, 'node_id': 'MDQ6VXNlcjU3MDcw', 'avatar_url': 'https://avatars.githubusercontent.com/u/57070?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jedzej', 'html_url': 'https://github.com/jedzej', 'followers_url': 'https://api.github.com/users/jedzej/followers', 'following_url': ... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"I'm sorry you experienced this bug! 🙇 \r\n\r\nLooks like this problem was already reported though (#18256) so I'm going to mark this issue as a duplicate and close it. If you have additional context that might help us repro this problem, please leave a comment on the other issue!\r\n\r\nThank you~"
] | 2020-07-13 12:45:49 | 2020-07-13 15:03:40 | 2020-07-13 15:03:33 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. I opened react profiler
2. I clicked "start profiling"
3. I performed some actions in my react application
4. I clicked "stop profiling"
5. Stacktrace appeared in devtools window instead of profiler charts.
---------------------------------------------
Ple... | {'url': 'https://api.github.com/repos/facebook/react/issues/19329/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19329/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19328 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19328/labels{/name} | https://api.github.com/repos/facebook/react/issues/19328/comments | https://api.github.com/repos/facebook/react/issues/19328/events | https://github.com/facebook/react/issues/19328 | 655,595,794 | MDU6SXNzdWU2NTU1OTU3OTQ= | 19,328 | Error: "Commit tree does not contain fiber 778. This is a bug in React DevTools." | {'login': 'gurmeetsinghmalhotra', 'id': 10655796, 'node_id': 'MDQ6VXNlcjEwNjU1Nzk2', 'avatar_url': 'https://avatars.githubusercontent.com/u/10655796?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gurmeetsinghmalhotra', 'html_url': 'https://github.com/gurmeetsinghmalhotra', 'followers_url': 'https://api.g... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"I'm sorry you experienced this bug! 🙇 \r\n\r\nLooks like this problem was already reported though (#18831) so I'm going to mark this issue as a duplicate and close it. If you have additional context that might help us repro this problem, please leave a comment on the other issue!\r\n\r\nThank you~"
] | 2020-07-13 05:39:32 | 2020-07-13 15:04:12 | 2020-07-13 15:04:05 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1.
2.
3.
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.7.0-23309eb38
Call stack: at N (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/... | {'url': 'https://api.github.com/repos/facebook/react/issues/19328/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19328/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19327 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19327/labels{/name} | https://api.github.com/repos/facebook/react/issues/19327/comments | https://api.github.com/repos/facebook/react/issues/19327/events | https://github.com/facebook/react/issues/19327 | 655,500,419 | MDU6SXNzdWU2NTU1MDA0MTk= | 19,327 | Bug: react-hooks/exhaustive-deps reports a TypeScript type via typeof as a dependency | {'login': 'RebeccaStevens', 'id': 7224206, 'node_id': 'MDQ6VXNlcjcyMjQyMDY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7224206?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/RebeccaStevens', 'html_url': 'https://github.com/RebeccaStevens', 'followers_url': 'https://api.github.com/users/Rebe... | [{'id': 717031390, 'node_id': 'MDU6TGFiZWw3MTcwMzEzOTA=', 'url': 'https://api.github.com/repos/facebook/react/labels/good%20first%20issue', 'name': 'good first issue', 'color': '6ce26a', 'default': True, 'description': None}
{'id': 1109410193, 'node_id': 'MDU6TGFiZWwxMTA5NDEwMTkz', 'url': 'https://api.github.com/repos... | closed | false | null | [] | null | [
"Oh nice find @RebeccaStevens, confirmed. Any interest in working on a PR?",
"Actually this may be a dupe of https://github.com/facebook/react/issues/18828.\r\n\r\nAnd the related PR https://github.com/facebook/react/pull/19316 may fix it already, will check with the PR author.",
"Looks, like it is. Sorry for t... | 2020-07-12 23:48:23 | 2020-07-13 17:03:05 | 2020-07-13 17:03:05 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
react-hooks/exhaustive-deps reports a missing dependency when a variable is used... | {'url': 'https://api.github.com/repos/facebook/react/issues/19327/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19327/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19326 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19326/labels{/name} | https://api.github.com/repos/facebook/react/issues/19326/comments | https://api.github.com/repos/facebook/react/issues/19326/events | https://github.com/facebook/react/issues/19326 | 655,405,899 | MDU6SXNzdWU2NTU0MDU4OTk= | 19,326 | Bug: Field value does not change | {'login': 'ximik753', 'id': 34097384, 'node_id': 'MDQ6VXNlcjM0MDk3Mzg0', 'avatar_url': 'https://avatars.githubusercontent.com/u/34097384?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ximik753', 'html_url': 'https://github.com/ximik753', 'followers_url': 'https://api.github.com/users/ximik753/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The solution to this problem is to define a function in onClick, not a function call.\r\n\r\nInstead of \r\n```javascript\r\nonclick={onClickHandler},\r\n```\r\nUse \r\n```javascript\r\nonclick={()=>onClickHandler()}\r\n```\r\nor if you don't use arrow funciton\r\nUse \r\n```javascript\r\nonclick={function(){onCli... | 2020-07-12 13:59:00 | 2020-07-12 16:17:39 | 2020-07-12 16:17:39 | NONE | null | null | null |
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19326/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19326/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19325 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19325/labels{/name} | https://api.github.com/repos/facebook/react/issues/19325/comments | https://api.github.com/repos/facebook/react/issues/19325/events | https://github.com/facebook/react/issues/19325 | 655,354,996 | MDU6SXNzdWU2NTUzNTQ5OTY= | 19,325 | Bug: | {'login': '255421', 'id': 64156924, 'node_id': 'MDQ6VXNlcjY0MTU2OTI0', 'avatar_url': 'https://avatars.githubusercontent.com/u/64156924?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/255421', 'html_url': 'https://github.com/255421', 'followers_url': 'https://api.github.com/users/255421/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2020-07-12 08:19:28 | 2020-07-12 15:28:38 | 2020-07-12 15:28:38 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/19325/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19325/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19324 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19324/labels{/name} | https://api.github.com/repos/facebook/react/issues/19324/comments | https://api.github.com/repos/facebook/react/issues/19324/events | https://github.com/facebook/react/issues/19324 | 655,264,754 | MDU6SXNzdWU2NTUyNjQ3NTQ= | 19,324 | Error: "Commit tree does not contain fiber 2756. This is a bug in React DevTools." | {'login': 'wojtekmaj', 'id': 5426427, 'node_id': 'MDQ6VXNlcjU0MjY0Mjc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5426427?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/wojtekmaj', 'html_url': 'https://github.com/wojtekmaj', 'followers_url': 'https://api.github.com/users/wojtekmaj/followers... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"I'm sorry you experienced this bug! 🙇 \r\n\r\nLooks like this problem was already reported though (#18831) so I'm going to mark this issue as a duplicate and close it. If you have additional context that might help us repro this problem, please leave a comment on the other issue!\r\n\r\nThank you~"
] | 2020-07-11 19:22:37 | 2020-07-12 16:14:42 | 2020-07-12 16:14:34 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. Recorded navigating between two pages using Profiler
2. After recording, tried to see the next frame in the profiler
The only thing that may be unusual about the app is that both pages were based on Recoil.
---------------------------------------------
Ple... | {'url': 'https://api.github.com/repos/facebook/react/issues/19324/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19324/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19323 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19323/labels{/name} | https://api.github.com/repos/facebook/react/issues/19323/comments | https://api.github.com/repos/facebook/react/issues/19323/events | https://github.com/facebook/react/issues/19323 | 655,236,419 | MDU6SXNzdWU2NTUyMzY0MTk= | 19,323 | Bug: Controlled input warning for component with onInput handler | {'login': 'fearsd', 'id': 46864568, 'node_id': 'MDQ6VXNlcjQ2ODY0NTY4', 'avatar_url': 'https://avatars.githubusercontent.com/u/46864568?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fearsd', 'html_url': 'https://github.com/fearsd', 'followers_url': 'https://api.github.com/users/fearsd/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"you have to write onChange instead of onInput",
"But, what problem in using onInput instead?",
"Hey @fearsd, thanks for filing.\r\n\r\nThis was fixed in https://github.com/facebook/react/pull/18189. See https://github.com/facebook/react/issues/9567 for historical context and https://github.com/facebook/react/i... | 2020-07-11 16:17:22 | 2020-07-14 03:07:54 | 2020-07-14 03:07:06 | NONE | null | null | null | React causes warnings in browser console about immutable input when I can change value of it.
React version: 16.3.1
## Steps To Reproduce
1. Create App component which extends React.Component.
2. In constructor create new state named input which contains '12' (or another number which is wrapped by quotes).
3... | {'url': 'https://api.github.com/repos/facebook/react/issues/19323/reactions', 'total_count': 2, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 1, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19323/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19322 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19322/labels{/name} | https://api.github.com/repos/facebook/react/issues/19322/comments | https://api.github.com/repos/facebook/react/issues/19322/events | https://github.com/facebook/react/pull/19322 | 655,232,535 | MDExOlB1bGxSZXF1ZXN0NDQ3Nzg0NDU4 | 19,322 | Effects list refactor continued: did-bailout flag | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19322/builds/40020) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-11 15:53:55 | 2020-07-16 13:10:08 | 2020-07-16 13:10:01 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19322', 'html_url': 'https://github.com/facebook/react/pull/19322', 'diff_url': 'https://github.com/facebook/react/pull/19322.diff', 'patch_url': 'https://github.com/facebook/react/pull/19322.patch', 'merged_at': datetime.datetime(2020, 7, 16, 13, 10)} | Builds on top of #19261
* Adds an explicit "did bailout" flag rather than checking whether or not children were cloned.
* Updates `subtreeTag` to use its own meta values rather than copying `effectTag` values.
[**View only the delta.**](https://github.com/bvaughn/react/compare/effects_list_refactor...effects_lis... | {'url': 'https://api.github.com/repos/facebook/react/issues/19322/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19322/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19321 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19321/labels{/name} | https://api.github.com/repos/facebook/react/issues/19321/comments | https://api.github.com/repos/facebook/react/issues/19321/events | https://github.com/facebook/react/pull/19321 | 655,216,337 | MDExOlB1bGxSZXF1ZXN0NDQ3NzczMzIw | 19,321 | chore: Build react-dom/test-utils in codesandbox deploy | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19321/builds/38933) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-11 14:14:10 | 2020-07-13 15:19:00 | 2020-07-13 15:15:38 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19321', 'html_url': 'https://github.com/facebook/react/pull/19321', 'diff_url': 'https://github.com/facebook/react/pull/19321.diff', 'patch_url': 'https://github.com/facebook/react/pull/19321.patch', 'merged_at': datetime.datetime(2020, 7, 13, 15, 15, 38)} | ## Summary
Build `react-dom/test-utils` in codesandbox deploy which is useful to verify fixes for issues related to `react-dom/test-utils` (e.g. #19318).
## Test Plan
- [x] Verify that the codesandbox linked in #19318 is runnable with this build. Edit: works: https://codesandbox.io/s/missing-act-on-every-effe... | {'url': 'https://api.github.com/repos/facebook/react/issues/19321/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19321/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19320 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19320/labels{/name} | https://api.github.com/repos/facebook/react/issues/19320/comments | https://api.github.com/repos/facebook/react/issues/19320/events | https://github.com/facebook/react/issues/19320 | 655,212,307 | MDU6SXNzdWU2NTUyMTIzMDc= | 19,320 | Bug: DevTools extension component tree view crashes on empty Suspense element | {'login': 'Wedvich', 'id': 1078076, 'node_id': 'MDQ6VXNlcjEwNzgwNzY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1078076?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Wedvich', 'html_url': 'https://github.com/Wedvich', 'followers_url': 'https://api.github.com/users/Wedvich/followers', 'foll... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Some additional notes:\r\n- I downgraded to 4.7.0 and the error did not occur, so this appears to be a regression in 4.8.x.\r\n- Even when it doesn't crash, 4.8.x truncates the tree under some `Suspense` nodes. In 4.7.0 the full tree is rendered as expected. I don't have a simple repro for this behavior though.",
... | 2020-07-11 13:49:29 | 2020-07-14 13:18:48 | 2020-07-13 20:21:57 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.13.1 (also tested with versions down to 16.9.0)
DevTools exte... | {'url': 'https://api.github.com/repos/facebook/react/issues/19320/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19320/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19319 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19319/labels{/name} | https://api.github.com/repos/facebook/react/issues/19319/comments | https://api.github.com/repos/facebook/react/issues/19319/events | https://github.com/facebook/react/pull/19319 | 655,209,374 | MDExOlB1bGxSZXF1ZXN0NDQ3NzY4NTY0 | 19,319 | fix(act): Don't warn if an effect was not queued | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19319/builds/66787) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-11 13:31:10 | 2021-08-11 12:45:56 | 2021-08-11 12:45:41 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19319', 'html_url': 'https://github.com/facebook/react/pull/19319', 'diff_url': 'https://github.com/facebook/react/pull/19319.diff', 'patch_url': 'https://github.com/facebook/react/pull/19319.patch', 'merged_at': None} | ## Summary
Closes #19318
## Test Plan
- [x] build green
- [x] codesandbox in #19318 passes: https://codesandbox.io/s/missing-act-on-every-effect-forked-1iwp2?file=/src/index.test.js
- [x] use codesandbox build for an existing codebase where act warnings were enabled by setting `globalThis.jest = null`
| {'url': 'https://api.github.com/repos/facebook/react/issues/19319/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19319/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19318 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19318/labels{/name} | https://api.github.com/repos/facebook/react/issues/19318/comments | https://api.github.com/repos/facebook/react/issues/19318/events | https://github.com/facebook/react/issues/19318 | 655,203,184 | MDU6SXNzdWU2NTUyMDMxODQ= | 19,318 | Bug: act warning misleading if an effect wasn't run | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 739761016, 'node_id': 'MDU6TGFiZWw3Mzk3NjEwMTY=', 'url': 'https://api.github.com/repos/f... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-07-11 12:51:11 | 2021-08-11 12:45:52 | 2021-08-11 12:45:52 | COLLABORATOR | null | null | null |
React version: 16.13.1 and `next`
## Steps To Reproduce
1. Re-render a component where an effect wasn't run because dependencies didn't change
2. Receive missing act warning
Link to code example: https://codesandbox.io/s/missing-act-on-every-effect-ldy3b?file=/src/index.test.js
## The current behavior
... | {'url': 'https://api.github.com/repos/facebook/react/issues/19318/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19318/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19317 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19317/labels{/name} | https://api.github.com/repos/facebook/react/issues/19317/comments | https://api.github.com/repos/facebook/react/issues/19317/events | https://github.com/facebook/react/pull/19317 | 655,157,949 | MDExOlB1bGxSZXF1ZXN0NDQ3NzM1Mzk0 | 19,317 | Fixed some minor Typos | {'login': 'Ashikpaul', 'id': 17526871, 'node_id': 'MDQ6VXNlcjE3NTI2ODcx', 'avatar_url': 'https://avatars.githubusercontent.com/u/17526871?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Ashikpaul', 'html_url': 'https://github.com/Ashikpaul', 'followers_url': 'https://api.github.com/users/Ashikpaul/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Hi @Ashikpaul! \n\nThank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on b... | 2020-07-11 07:43:59 | 2021-11-15 15:55:46 | 2021-11-15 15:55:46 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19317', 'html_url': 'https://github.com/facebook/react/pull/19317', 'diff_url': 'https://github.com/facebook/react/pull/19317.diff', 'patch_url': 'https://github.com/facebook/react/pull/19317.patch', 'merged_at': None} | ## Summary
Found some typos in the error codes
## Test Plan
This PR doesn't require a test plan
Thank you
| {'url': 'https://api.github.com/repos/facebook/react/issues/19317/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19317/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19316 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19316/labels{/name} | https://api.github.com/repos/facebook/react/issues/19316/comments | https://api.github.com/repos/facebook/react/issues/19316/events | https://github.com/facebook/react/pull/19316 | 655,016,268 | MDExOlB1bGxSZXF1ZXN0NDQ3NjI4MjM3 | 19,316 | reference not add to dependencies if only its type is used as typeof arg | {'login': 'delca85', 'id': 4076043, 'node_id': 'MDQ6VXNlcjQwNzYwNDM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4076043?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/delca85', 'html_url': 'https://github.com/delca85', 'followers_url': 'https://api.github.com/users/delca85/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e85dcbed8cc8c3e55075b17... | 2020-07-10 20:23:03 | 2020-07-13 16:57:01 | 2020-07-13 16:57:01 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19316', 'html_url': 'https://github.com/facebook/react/pull/19316', 'diff_url': 'https://github.com/facebook/react/pull/19316.diff', 'patch_url': 'https://github.com/facebook/react/pull/19316.patch', 'merged_at': datetime.datetime(2020, 7, 13, 16, 57, 1)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19316/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19316/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19315 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19315/labels{/name} | https://api.github.com/repos/facebook/react/issues/19315/comments | https://api.github.com/repos/facebook/react/issues/19315/events | https://github.com/facebook/react/pull/19315 | 655,010,895 | MDExOlB1bGxSZXF1ZXN0NDQ3NjIzOTUx | 19,315 | Extract some of the tidy up changes from 19278 | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: a2b4db05bc8ac1ff92ed914008260875e4c11284...2d8d1fd2aa24530e2b93489e2e78fa481b70881d</p>\n\n\n \n## react-dom\nFile | Filesize... | 2020-07-10 20:11:25 | 2020-07-10 21:33:47 | 2020-07-10 21:33:43 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19315', 'html_url': 'https://github.com/facebook/react/pull/19315', 'diff_url': 'https://github.com/facebook/react/pull/19315.diff', 'patch_url': 'https://github.com/facebook/react/pull/19315.patch', 'merged_at': datetime.datetime(2020, 7, 10, 21, 33, 43)} | In order to make https://github.com/facebook/react/pull/19278 a bit smaller in terms of changes, this extracts some of the tidy up changes from that PR. https://github.com/facebook/react/pull/19278 should now only refer to the changes reflecting to moving away from capture phase events. | {'url': 'https://api.github.com/repos/facebook/react/issues/19315/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19315/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19314 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19314/labels{/name} | https://api.github.com/repos/facebook/react/issues/19314/comments | https://api.github.com/repos/facebook/react/issues/19314/events | https://github.com/facebook/react/pull/19314 | 654,948,995 | MDExOlB1bGxSZXF1ZXN0NDQ3NTczOTI1 | 19,314 | Removed debugger | {'login': 'prayas26', 'id': 16463310, 'node_id': 'MDQ6VXNlcjE2NDYzMzEw', 'avatar_url': 'https://avatars.githubusercontent.com/u/16463310?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/prayas26', 'html_url': 'https://github.com/prayas26', 'followers_url': 'https://api.github.com/users/prayas26/followers',... | [] | closed | false | null | [] | null | [
"Hi @prayas26! \n\nThank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on be... | 2020-07-10 18:09:44 | 2020-07-12 01:53:46 | 2020-07-10 18:13:39 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19314', 'html_url': 'https://github.com/facebook/react/pull/19314', 'diff_url': 'https://github.com/facebook/react/pull/19314.diff', 'patch_url': 'https://github.com/facebook/react/pull/19314.patch', 'merged_at': None} | Solves the issue that forces a debugger when installed extension in chrome
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before su... | {'url': 'https://api.github.com/repos/facebook/react/issues/19314/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19314/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19313 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19313/labels{/name} | https://api.github.com/repos/facebook/react/issues/19313/comments | https://api.github.com/repos/facebook/react/issues/19313/events | https://github.com/facebook/react/pull/19313 | 654,939,447 | MDExOlB1bGxSZXF1ZXN0NDQ3NTY2Mzg1 | 19,313 | [ESLint] Fix a bug causing a too coarse dependency suggestion | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19313/builds/38762) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-10 17:51:21 | 2020-08-06 14:27:31 | 2020-07-10 18:02:09 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19313', 'html_url': 'https://github.com/facebook/react/pull/19313', 'diff_url': 'https://github.com/facebook/react/pull/19313.diff', 'patch_url': 'https://github.com/facebook/react/pull/19313.patch', 'merged_at': datetime.datetime(2020, 7, 10, 18, 2, 8)} | Fixes https://github.com/facebook/react/issues/19312.
If we use `props.something` and declare `props.something` in deps, this should not violate.
However, the existing logic for AssignmentExpressions caused it to be violating. This is because we forgot to check whether an expression is on the left or the right si... | {'url': 'https://api.github.com/repos/facebook/react/issues/19313/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19313/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19312 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19312/labels{/name} | https://api.github.com/repos/facebook/react/issues/19312/comments | https://api.github.com/repos/facebook/react/issues/19312/events | https://github.com/facebook/react/issues/19312 | 654,934,648 | MDU6SXNzdWU2NTQ5MzQ2NDg= | 19,312 | Bug: Exhaustive deps lint rule mistakingly flags an assignment | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 1249821345, 'node_id': 'MDU6TGFiZWwxMjQ5ODIxMzQ1', 'url': 'https://api.github.com/repos/facebook/react/... | closed | false | null | [] | null | [] | 2020-07-10 17:41:51 | 2020-07-10 18:02:09 | 2020-07-10 18:02:09 | COLLABORATOR | null | null | null | Example:
```js
function Example(props) {
useEffect(() => {
let topHeight = 0;
topHeight = props.upperViewHeight;
}, [props.upperViewHeight]);
}
```
This is **not** supposed to violate because `props.upperViewHeight` is in the deps. | {'url': 'https://api.github.com/repos/facebook/react/issues/19312/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19312/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19311 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19311/labels{/name} | https://api.github.com/repos/facebook/react/issues/19311/comments | https://api.github.com/repos/facebook/react/issues/19311/events | https://github.com/facebook/react/issues/19311 | 654,903,534 | MDU6SXNzdWU2NTQ5MDM1MzQ= | 19,311 | debugger added in the javascript code causing breakpoint | {'login': 'tychong82', 'id': 1592393, 'node_id': 'MDQ6VXNlcjE1OTIzOTM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1592393?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tychong82', 'html_url': 'https://github.com/tychong82', 'followers_url': 'https://api.github.com/users/tychong82/followers... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"I'm sorry you experienced this bug! 🙇 \r\n\r\nLooks like this problem was already reported though (#19308) so I'm going to mark this issue as a duplicate and close it.\r\n\r\nPlease take a moment to check for duplicate issues before reporting 😄 "
] | 2020-07-10 16:41:25 | 2020-07-10 16:42:27 | 2020-07-10 16:42:16 | NONE | null | null | null | Looks like debugger was left in "react-devtools-backend.js" causing breakpoints.
<img width="1314" alt="debugger-problem" src="https://user-images.githubusercontent.com/1592393/87178051-752ab100-c291-11ea-8131-479b216e5a4b.png">
| {'url': 'https://api.github.com/repos/facebook/react/issues/19311/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19311/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19310 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19310/labels{/name} | https://api.github.com/repos/facebook/react/issues/19310/comments | https://api.github.com/repos/facebook/react/issues/19310/events | https://github.com/facebook/react/pull/19310 | 654,887,501 | MDExOlB1bGxSZXF1ZXN0NDQ3NTI1Mzk2 | 19,310 | Revise useFocus/useFocusWithin | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19310/builds/38731) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-10 16:12:58 | 2020-07-10 16:23:04 | 2020-07-10 16:23:01 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19310', 'html_url': 'https://github.com/facebook/react/pull/19310', 'diff_url': 'https://github.com/facebook/react/pull/19310.diff', 'patch_url': 'https://github.com/facebook/react/pull/19310.patch', 'merged_at': datetime.datetime(2020, 7, 10, 16, 23, 1)} | This updates the `useFocus` and `useFocusWithin` custom hooks that use event handles to better reflect the bug fixes made to the internal version. | {'url': 'https://api.github.com/repos/facebook/react/issues/19310/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19310/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19309 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19309/labels{/name} | https://api.github.com/repos/facebook/react/issues/19309/comments | https://api.github.com/repos/facebook/react/issues/19309/events | https://github.com/facebook/react/pull/19309 | 654,735,844 | MDExOlB1bGxSZXF1ZXN0NDQ3NDAzNTI3 | 19,309 | DevTools: Make break-on-warn off by default | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against c903d4c625b80534c4f9fe7... | 2020-07-10 12:09:21 | 2020-07-10 13:43:03 | 2020-07-10 13:11:33 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19309', 'html_url': 'https://github.com/facebook/react/pull/19309', 'diff_url': 'https://github.com/facebook/react/pull/19309.diff', 'patch_url': 'https://github.com/facebook/react/pull/19309.patch', 'merged_at': datetime.datetime(2020, 7, 10, 13, 11, 33)} | Fixes https://github.com/facebook/react/issues/19308.
Changelog said https://github.com/facebook/react/pull/19048 should be off by default but it's on by default. | {'url': 'https://api.github.com/repos/facebook/react/issues/19309/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19309/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19308 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19308/labels{/name} | https://api.github.com/repos/facebook/react/issues/19308/comments | https://api.github.com/repos/facebook/react/issues/19308/events | https://github.com/facebook/react/issues/19308 | 654,694,110 | MDU6SXNzdWU2NTQ2OTQxMTA= | 19,308 | Bug: Unexpected debugger statement in DevTools (solved) | {'login': 'eiamei', 'id': 20472264, 'node_id': 'MDQ6VXNlcjIwNDcyMjY0', 'avatar_url': 'https://avatars.githubusercontent.com/u/20472264?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eiamei', 'html_url': 'https://github.com/eiamei', 'followers_url': 'https://api.github.com/users/eiamei/followers', 'follow... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | true | null | [] | null | [
"Same here, I've had to disable the extension because of this... :smile: ",
"Same for me.",
"Looks bad.",
"Same here",
"https://github.com/facebook/react/blob/14084be286d09df49d5410c751bc28f0180a54b2/packages/react-devtools-shared/src/backend/console.js#L173\r\n\r\nThat's the guy you're looking for :D",
"... | 2020-07-10 10:49:41 | 2020-07-11 15:50:49 | 2020-07-11 15:50:49 | NONE | resolved | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
Looks like you forgot about the debugger inside the react_devtools_backend.js.
... | {'url': 'https://api.github.com/repos/facebook/react/issues/19308/reactions', 'total_count': 84, '+1': 56, '-1': 0, 'laugh': 23, 'hooray': 0, 'confused': 5, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19308/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19307 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19307/labels{/name} | https://api.github.com/repos/facebook/react/issues/19307/comments | https://api.github.com/repos/facebook/react/issues/19307/events | https://github.com/facebook/react/pull/19307 | 654,543,771 | MDExOlB1bGxSZXF1ZXN0NDQ3MjUxODc3 | 19,307 | Use Lanes to check if a render is a Suspense retry | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19307/builds/38583) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-10 06:26:30 | 2020-07-10 13:58:06 | 2020-07-10 13:58:06 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19307', 'html_url': 'https://github.com/facebook/react/pull/19307', 'diff_url': 'https://github.com/facebook/react/pull/19307.diff', 'patch_url': 'https://github.com/facebook/react/pull/19307.patch', 'merged_at': datetime.datetime(2020, 7, 10, 13, 58, 6)} | Now that Suspense retries have their own dedicated set of lanes (#19287), we can determine if a render includes only retries by checking if its lanes are a subset of the retry lanes.
Previously we inferred this by checking `workInProgressRootLatestProcessedEventTime`. If it's not set, that implies that no updates we... | {'url': 'https://api.github.com/repos/facebook/react/issues/19307/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19307/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19306 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19306/labels{/name} | https://api.github.com/repos/facebook/react/issues/19306/comments | https://api.github.com/repos/facebook/react/issues/19306/events | https://github.com/facebook/react/issues/19306 | 654,496,980 | MDU6SXNzdWU2NTQ0OTY5ODA= | 19,306 | API can only be initiated by a user gesture. | {'login': 'aiyudeleng', 'id': 31436484, 'node_id': 'MDQ6VXNlcjMxNDM2NDg0', 'avatar_url': 'https://avatars.githubusercontent.com/u/31436484?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aiyudeleng', 'html_url': 'https://github.com/aiyudeleng', 'followers_url': 'https://api.github.com/users/aiyudeleng/fol... | [] | closed | false | null | [] | null | [
"Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:\r\n\r\n##### Coding Questions\r\n\r\nIf you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great pla... | 2020-07-10 04:15:42 | 2020-07-10 15:33:34 | 2020-07-10 15:33:34 | NONE | null | null | null | 想实现按下键盘时页面全屏。有时候能全屏，有时候会报错，代码如下
`onKeyDown = (e) =>{
switch(e.keyCode){
case 13://回车事件
this.requestFullScreen();
break;
case 27://esc事件
this.exitFullscreen();
console.dir("SAFE返回键按下");
console.dir("e");
break;
default:
break;
}
}
requestFullScreen(){
conso... | {'url': 'https://api.github.com/repos/facebook/react/issues/19306/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19306/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19305 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19305/labels{/name} | https://api.github.com/repos/facebook/react/issues/19305/comments | https://api.github.com/repos/facebook/react/issues/19305/events | https://github.com/facebook/react/issues/19305 | 654,449,109 | MDU6SXNzdWU2NTQ0NDkxMDk= | 19,305 | Bug: Functional component rerender when same state | {'login': 'heecheolman', 'id': 35059687, 'node_id': 'MDQ6VXNlcjM1MDU5Njg3', 'avatar_url': 'https://avatars.githubusercontent.com/u/35059687?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/heecheolman', 'html_url': 'https://github.com/heecheolman', 'followers_url': 'https://api.github.com/users/heecheolman... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"By design, calling the update function of the useState hook automatically triggers a re-render. As per the useState docs:\r\n\r\n> The setState function is used to update the state. It accepts a new state value and enqueues a re-render of the component.\r\n\r\nSince this is by design, it should not be considered a... | 2020-07-10 01:41:56 | 2020-07-11 18:23:23 | 2020-07-10 11:52:10 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.13.1
## Steps To Reproduce
1.
2.
<!--
Your bug wi... | {'url': 'https://api.github.com/repos/facebook/react/issues/19305/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19305/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19304 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19304/labels{/name} | https://api.github.com/repos/facebook/react/issues/19304/comments | https://api.github.com/repos/facebook/react/issues/19304/events | https://github.com/facebook/react/issues/19304 | 654,448,628 | MDU6SXNzdWU2NTQ0NDg2Mjg= | 19,304 | Bug: componentDidMount not called when components are swapped | {'login': 'paulmand3l', 'id': 382427, 'node_id': 'MDQ6VXNlcjM4MjQyNw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/382427?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/paulmand3l', 'html_url': 'https://github.com/paulmand3l', 'followers_url': 'https://api.github.com/users/paulmand3l/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | {'login': 'paulmand3l', 'id': 382427.0, 'node_id': 'MDQ6VXNlcjM4MjQyNw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/382427?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/paulmand3l', 'html_url': 'https://github.com/paulmand3l', 'followers_url': 'https://api.github.com/users/paulmand3l/follo... | [{'login': 'paulmand3l', 'id': 382427, 'node_id': 'MDQ6VXNlcjM4MjQyNw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/382427?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/paulmand3l', 'html_url': 'https://github.com/paulmand3l', 'followers_url': 'https://api.github.com/users/paulmand3l/follow... | null | [
"The repro link doesn't run because of warnings that stop the build process. Did you test it? (Did you forget to save?)",
"This looks like a misunderstanding.\r\n\r\nReact sees the two `Image` components as the same component because in both cases the `Swapper` component renders a single child, `Image`. So all Re... | 2020-07-10 01:40:34 | 2020-07-10 15:42:06 | 2020-07-10 15:42:05 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: ^16.12.0
## Steps To Reproduce
1. Initialize app with npx c... | {'url': 'https://api.github.com/repos/facebook/react/issues/19304/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19304/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19303 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19303/labels{/name} | https://api.github.com/repos/facebook/react/issues/19303/comments | https://api.github.com/repos/facebook/react/issues/19303/events | https://github.com/facebook/react/issues/19303 | 654,411,768 | MDU6SXNzdWU2NTQ0MTE3Njg= | 19,303 | Bug: debugger getting triggered on warnings (but setting not enabled) | {'login': 'mrcoles', 'id': 136651, 'node_id': 'MDQ6VXNlcjEzNjY1MQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/136651?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mrcoles', 'html_url': 'https://github.com/mrcoles', 'followers_url': 'https://api.github.com/users/mrcoles/followers', 'follow... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"Happening to me as well on FF 79.0b5 (Dev Edition) with React DevTools 4.8.0-a5b449295.\r\n\r\nI'm guessing the following is the reason? Shouldn't this be `return false` at the end for the default return value?\r\nhttps://github.com/facebook/react/blob/14084be286d09df49d5410c751bc28f0180a54b2/packages/react-devtoo... | 2020-07-09 23:38:18 | 2020-07-10 20:55:23 | 2020-07-10 13:33:00 | NONE | null | null | null | React version: 16.9.5
## Steps To Reproduce
1. Open the dev console in Firefox (78.0.1) that is running React Developer Tools (from revision a5b449295 on 7/9/2020)
2. Don’t change any settings from the defaults
3. Do something that triggers a warning, like running stripe.js in test mode on http
4. The debugger... | {'url': 'https://api.github.com/repos/facebook/react/issues/19303/reactions', 'total_count': 12, '+1': 12, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19303/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19302 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19302/labels{/name} | https://api.github.com/repos/facebook/react/issues/19302/comments | https://api.github.com/repos/facebook/react/issues/19302/events | https://github.com/facebook/react/pull/19302 | 654,385,312 | MDExOlB1bGxSZXF1ZXN0NDQ3MTI0NDIy | 19,302 | Refactor algorithm for determining the next Lanes to work on | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 08b8e6e1dc41fec1ce315c9e5fe4b340af96cd66...15fda4b112a35fd0b399396a67c471e68255e820</p>\n\n\n \n## react-dom\nFile | Filesize... | 2020-07-09 22:26:24 | 2020-08-12 10:02:08 | 2020-07-09 23:53:55 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19302', 'html_url': 'https://github.com/facebook/react/pull/19302', 'diff_url': 'https://github.com/facebook/react/pull/19302.diff', 'patch_url': 'https://github.com/facebook/react/pull/19302.patch', 'merged_at': datetime.datetime(2020, 7, 9, 23, 53, 55)} | Some clean up to make the Lanes type easier to maintain.
I removed the "start" and "end" range markers; they don't provide any information that isn't already encoded in the bitmask for each range, and there's no computation saved compared to the `pickArbitraryLane` function.
The overall algorithm is largely the s... | {'url': 'https://api.github.com/repos/facebook/react/issues/19302/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19302/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19301 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19301/labels{/name} | https://api.github.com/repos/facebook/react/issues/19301/comments | https://api.github.com/repos/facebook/react/issues/19301/events | https://github.com/facebook/react/issues/19301 | 654,366,722 | MDU6SXNzdWU2NTQzNjY3MjI= | 19,301 | Bug: No exhaustive-deps warning | {'login': 'stoplion', 'id': 231343, 'node_id': 'MDQ6VXNlcjIzMTM0Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/231343?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/stoplion', 'html_url': 'https://github.com/stoplion', 'followers_url': 'https://api.github.com/users/stoplion/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1249821345, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Where is `variableOutside` defined? If it's not defined, this is not a mistake, since it's assumed to be global.",
"Yes it was. But looks like it might be a VSCode issue, I've switched versions and it works "
] | 2020-07-09 21:44:24 | 2020-07-17 01:02:18 | 2020-07-17 01:02:17 | NONE | null | null | null | ```
"extends": ["airbnb", "plugin:react-hooks/recommended", "react-app"],
"root": true,
"parser": "babel-eslint",
"env": {
"browser": true
},
"plugins": [
"react-hooks",
"@babel/plugin-proposal-optional-chaining",
"react"
],
```
```
"rules": {
"react-hooks/rules-of-hooks... | {'url': 'https://api.github.com/repos/facebook/react/issues/19301/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19301/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19300 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19300/labels{/name} | https://api.github.com/repos/facebook/react/issues/19300/comments | https://api.github.com/repos/facebook/react/issues/19300/events | https://github.com/facebook/react/pull/19300 | 654,287,795 | MDExOlB1bGxSZXF1ZXN0NDQ3MDQ0MzQ3 | 19,300 | Alter event replaying strategy for target only events | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19300/builds/38468) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-09 19:13:02 | 2020-07-13 20:58:29 | 2020-07-13 20:58:29 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19300', 'html_url': 'https://github.com/facebook/react/pull/19300', 'diff_url': 'https://github.com/facebook/react/pull/19300.diff', 'patch_url': 'https://github.com/facebook/react/pull/19300.patch', 'merged_at': None} | This PR removes four events from being included in event replaying. These events are:
- `submit`
- `reset`
- `close`
- `cancel`
`submit` and `reset` are both form events, and they also natively bubble on the browser. However, in React, we instead attach these to target element. We could change this in https://... | {'url': 'https://api.github.com/repos/facebook/react/issues/19300/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19300/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19299 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19299/labels{/name} | https://api.github.com/repos/facebook/react/issues/19299/comments | https://api.github.com/repos/facebook/react/issues/19299/events | https://github.com/facebook/react/issues/19299 | 654,174,454 | MDU6SXNzdWU2NTQxNzQ0NTQ= | 19,299 | Bug: | {'login': 'zoedsoupe', 'id': 44469426, 'node_id': 'MDQ6VXNlcjQ0NDY5NDI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/44469426?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zoedsoupe', 'html_url': 'https://github.com/zoedsoupe', 'followers_url': 'https://api.github.com/users/zoedsoupe/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is almost certainly a problem with your project config production build step.\r\n\r\nYou might not have much luck finding someone on this repo to dig into that configuration. Might do better on a site like Stack Overflow.",
"I can't reproduce the error using the project you linked. Both the DEV and producti... | 2020-07-09 15:59:34 | 2020-07-12 21:54:03 | 2020-07-09 16:29:11 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.13.1
## Steps To Reproduce
1. Create a React app which a... | {'url': 'https://api.github.com/repos/facebook/react/issues/19299/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19299/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19298 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19298/labels{/name} | https://api.github.com/repos/facebook/react/issues/19298/comments | https://api.github.com/repos/facebook/react/issues/19298/events | https://github.com/facebook/react/issues/19298 | 654,166,435 | MDU6SXNzdWU2NTQxNjY0MzU= | 19,298 | Which approach is better for getting data from state ? | {'login': 'NeerajNegi', 'id': 17411633, 'node_id': 'MDQ6VXNlcjE3NDExNjMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/17411633?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/NeerajNegi', 'html_url': 'https://github.com/NeerajNegi', 'followers_url': 'https://api.github.com/users/NeerajNegi/fol... | [{'id': 40929155, 'node_id': 'MDU6TGFiZWw0MDkyOTE1NQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Question', 'name': 'Type: Question', 'color': 'cc317c', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Neither approach shown above is recommended, because both are mutations- and React data (props/state) [should not be mutated](https://reactjs.org/docs/react-component.html#state).\r\n\r\nI suppose the second example is \"better\", in that you're shallowing cloning the user object, but it's still dangerous because:... | 2020-07-09 15:48:17 | 2020-07-09 16:23:48 | 2020-07-09 16:23:14 | NONE | null | null | null |
Let's say our state is as follows:
```
state: {
user: {
name: 'Dave',
email: 'Dave@gmail.com'
}
}
```
so while getting the user property from the state which one of the following should I do?
**Case 1:**
```
const user = this.state.user
this way following is valid
user ==... | {'url': 'https://api.github.com/repos/facebook/react/issues/19298/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19298/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19297 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19297/labels{/name} | https://api.github.com/repos/facebook/react/issues/19297/comments | https://api.github.com/repos/facebook/react/issues/19297/events | https://github.com/facebook/react/pull/19297 | 654,118,550 | MDExOlB1bGxSZXF1ZXN0NDQ2OTA3NTky | 19,297 | DevTools 4.7.0 -> 4.8.0 | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19297/builds/38389) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-09 14:45:05 | 2020-07-09 14:53:33 | 2020-07-09 14:49:45 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19297', 'html_url': 'https://github.com/facebook/react/pull/19297', 'diff_url': 'https://github.com/facebook/react/pull/19297.diff', 'patch_url': 'https://github.com/facebook/react/pull/19297.patch', 'merged_at': datetime.datetime(2020, 7, 9, 14, 49, 45)} | * Updates CHANGELOG
* Updates version numbers
* Upgrades the `web-ext` package to fix https://github.com/mozilla/web-ext/issues/1884 | {'url': 'https://api.github.com/repos/facebook/react/issues/19297/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19297/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19296 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19296/labels{/name} | https://api.github.com/repos/facebook/react/issues/19296/comments | https://api.github.com/repos/facebook/react/issues/19296/events | https://github.com/facebook/react/issues/19296 | 654,113,975 | MDU6SXNzdWU2NTQxMTM5NzU= | 19,296 | Bug: checked attribute doesn't change in DOM even though React handles it's state correctly | {'login': 'jdolearydl', 'id': 43141484, 'node_id': 'MDQ6VXNlcjQzMTQxNDg0', 'avatar_url': 'https://avatars.githubusercontent.com/u/43141484?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jdolearydl', 'html_url': 'https://github.com/jdolearydl', 'followers_url': 'https://api.github.com/users/jdolearydl/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The question is: why does that matter to you?",
"It doesn't pose a problem to me directly; but I figure it might cause a real issue to something currently unforeseen - maybe assistive technologies, for example. The point is, I'm sure it's not the intended behavior.",
"The HTML attribute **checked** marks cert... | 2020-07-09 14:39:06 | 2020-08-20 12:24:55 | 2020-08-20 12:24:55 | NONE | null | null | null | **For inputs of type 'checkbox', the checked attribute doesn't change in the actual DOM to match the react state.**
When the input is checked, the attribute is `checked=""`, as expected
![When checked, 'checked=""'](https://user-images.githubusercontent.com/43141484/87051612-cc674d80-c1cd-11ea-905d-a14da9ef9692.png... | {'url': 'https://api.github.com/repos/facebook/react/issues/19296/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19296/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19295 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19295/labels{/name} | https://api.github.com/repos/facebook/react/issues/19295/comments | https://api.github.com/repos/facebook/react/issues/19295/events | https://github.com/facebook/react/pull/19295 | 654,113,790 | MDExOlB1bGxSZXF1ZXN0NDQ2OTAzNzE4 | 19,295 | Fixed test script for DevTools build config | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19295/builds/38380) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-09 14:38:51 | 2020-07-09 14:49:37 | 2020-07-09 14:49:34 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19295', 'html_url': 'https://github.com/facebook/react/pull/19295', 'diff_url': 'https://github.com/facebook/react/pull/19295.diff', 'patch_url': 'https://github.com/facebook/react/pull/19295.patch', 'merged_at': datetime.datetime(2020, 7, 9, 14, 49, 33)} | Fixes #19293 | {'url': 'https://api.github.com/repos/facebook/react/issues/19295/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19295/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19294 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19294/labels{/name} | https://api.github.com/repos/facebook/react/issues/19294/comments | https://api.github.com/repos/facebook/react/issues/19294/events | https://github.com/facebook/react/pull/19294 | 654,110,511 | MDExOlB1bGxSZXF1ZXN0NDQ2OTAxMDQ1 | 19,294 | Fixed test script for DevTools config | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19294/builds/38377) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-09 14:34:39 | 2020-07-09 14:45:07 | 2020-07-09 14:37:49 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19294', 'html_url': 'https://github.com/facebook/react/pull/19294', 'diff_url': 'https://github.com/facebook/react/pull/19294.diff', 'patch_url': 'https://github.com/facebook/react/pull/19294.patch', 'merged_at': None} | Fixes #19293 | {'url': 'https://api.github.com/repos/facebook/react/issues/19294/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19294/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19293 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19293/labels{/name} | https://api.github.com/repos/facebook/react/issues/19293/comments | https://api.github.com/repos/facebook/react/issues/19293/events | https://github.com/facebook/react/issues/19293 | 654,106,811 | MDU6SXNzdWU2NTQxMDY4MTE= | 19,293 | DevTools test script runs the wrong tests | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 71502270, 'node_id': 'MDU6TGFiZWw3MTUwMjI3MA==', 'url': 'https://api.github.com/repos/facebook/react/la... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"It's because of this:\r\n```js\r\n const args = ['./scripts/jest/jest.js', '--config'];\r\n if (argv.build) {\r\n args.push(buildConfig);\r\n } else if (argv.persistent) {\r\n args.push(persistentConfig);\r\n } else if (argv.project === 'devtools') {\r\n args.push(devToolsConfig);\r\n } else if (isWW... | 2020-07-09 14:29:56 | 2020-07-09 14:49:33 | 2020-07-09 14:49:33 | CONTRIBUTOR | null | null | null | ```sh
yarn test --build --project devtools
```
This doesn't actually run any DevTools tests. It runs the main React tests.
Console output shows that it's choosing the wrong config:
```sh
$ yarn test --build --project devtools
$ node ./scripts/jest/jest-cli.js --build --project devtools
$ NODE_ENV=developmen... | {'url': 'https://api.github.com/repos/facebook/react/issues/19293/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19293/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19292 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19292/labels{/name} | https://api.github.com/repos/facebook/react/issues/19292/comments | https://api.github.com/repos/facebook/react/issues/19292/events | https://github.com/facebook/react/issues/19292 | 654,046,694 | MDU6SXNzdWU2NTQwNDY2OTQ= | 19,292 | Error: "getCommitTree(): Unable to reconstruct tree for root "1" and commit 36" | {'login': 'agustinpardolp', 'id': 44348917, 'node_id': 'MDQ6VXNlcjQ0MzQ4OTE3', 'avatar_url': 'https://avatars.githubusercontent.com/u/44348917?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/agustinpardolp', 'html_url': 'https://github.com/agustinpardolp', 'followers_url': 'https://api.github.com/users/ag... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"I'm sorry you experienced this bug! 🙇 \r\n\r\nLooks like this problem was already reported though (#18987) so I'm going to mark this issue as a duplicate and close it. If you have additional context that might help us repro this problem, please leave a comment on the other issue!\r\n\r\nThank you~",
"Hi Brian, ... | 2020-07-09 13:07:50 | 2020-07-09 13:59:42 | 2020-07-09 13:41:02 | NONE | null | null | null | Describe what you were doing when the bug occurred:
Hi I was using the profile functionallity from react dev tools,
and suddenly this error happened.
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.7... | {'url': 'https://api.github.com/repos/facebook/react/issues/19292/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19292/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19291 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19291/labels{/name} | https://api.github.com/repos/facebook/react/issues/19291/comments | https://api.github.com/repos/facebook/react/issues/19291/events | https://github.com/facebook/react/pull/19291 | 654,007,517 | MDExOlB1bGxSZXF1ZXN0NDQ2ODE2OTE3 | 19,291 | Grammar and Formatting | {'login': 'Tyorden', 'id': 19657134, 'node_id': 'MDQ6VXNlcjE5NjU3MTM0', 'avatar_url': 'https://avatars.githubusercontent.com/u/19657134?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Tyorden', 'html_url': 'https://github.com/Tyorden', 'followers_url': 'https://api.github.com/users/Tyorden/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Hi @Tyorden! \n\nThank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on beh... | 2020-07-09 12:05:17 | 2020-12-25 13:07:17 | 2020-12-25 13:07:17 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19291', 'html_url': 'https://github.com/facebook/react/pull/19291', 'diff_url': 'https://github.com/facebook/react/pull/19291.diff', 'patch_url': 'https://github.com/facebook/react/pull/19291.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19291/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19291/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19290 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19290/labels{/name} | https://api.github.com/repos/facebook/react/issues/19290/comments | https://api.github.com/repos/facebook/react/issues/19290/events | https://github.com/facebook/react/issues/19290 | 653,989,304 | MDU6SXNzdWU2NTM5ODkzMDQ= | 19,290 | Bug: Unrelated state update in onKeyDown blocks onChange and breaks controlled component | {'login': 'GRAMMAC1', 'id': 19931582, 'node_id': 'MDQ6VXNlcjE5OTMxNTgy', 'avatar_url': 'https://avatars.githubusercontent.com/u/19931582?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/GRAMMAC1', 'html_url': 'https://github.com/GRAMMAC1', 'followers_url': 'https://api.github.com/users/GRAMMAC1/followers',... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"It looks like the state update in the `onKeyDown` handler interrupts the event and prevents the `onChange` handler from being called. Because controlled components show only what you tell them to (the `value` state in your example) this results in the space character never appearing.\r\n\r\nThis looks like a bug t... | 2020-07-09 11:33:11 | 2021-02-10 23:34:46 | 2021-02-10 23:34:46 | NONE | null | null | null | Hi, I use Input controlled mode and subscribe to `onKeyDown` and `onChange` event. It will trigger an effect when user enter space. However, the space don't display on screen. Is this a bug on React or is there something wrong with the way I'm using it. But subscribe to `onKeyUp` is normal. This is confused.
React ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19290/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19290/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19289 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19289/labels{/name} | https://api.github.com/repos/facebook/react/issues/19289/comments | https://api.github.com/repos/facebook/react/issues/19289/events | https://github.com/facebook/react/pull/19289 | 653,743,961 | MDExOlB1bGxSZXF1ZXN0NDQ2NjAyMDk2 | 19,289 | Fix typo in Overview doc for react-devtools | {'login': 'rimildeyjsr', 'id': 10229595, 'node_id': 'MDQ6VXNlcjEwMjI5NTk1', 'avatar_url': 'https://avatars.githubusercontent.com/u/10229595?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rimildeyjsr', 'html_url': 'https://github.com/rimildeyjsr', 'followers_url': 'https://api.github.com/users/rimildeyjsr... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19289/builds/38229) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-09 03:59:24 | 2020-07-09 13:13:16 | 2020-07-09 13:13:16 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19289', 'html_url': 'https://github.com/facebook/react/pull/19289', 'diff_url': 'https://github.com/facebook/react/pull/19289.diff', 'patch_url': 'https://github.com/facebook/react/pull/19289.patch', 'merged_at': datetime.datetime(2020, 7, 9, 13, 13, 16)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19289/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19289/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19288 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19288/labels{/name} | https://api.github.com/repos/facebook/react/issues/19288/comments | https://api.github.com/repos/facebook/react/issues/19288/events | https://github.com/facebook/react/pull/19288 | 653,634,491 | MDExOlB1bGxSZXF1ZXN0NDQ2NTE1OTYy | 19,288 | Use jest-environment-jsdom-sixteen | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19288/builds/38767) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-08 22:24:31 | 2020-07-16 14:17:36 | 2020-07-16 14:17:32 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19288', 'html_url': 'https://github.com/facebook/react/pull/19288', 'diff_url': 'https://github.com/facebook/react/pull/19288.diff', 'patch_url': 'https://github.com/facebook/react/pull/19288.patch', 'merged_at': datetime.datetime(2020, 7, 16, 14, 17, 32)} | ## Summary
**Do not merge until JSDOM publishes a new version**
This PR replaces the [jsdom resolution override](https://github.com/facebook/react/pull/19284) with using `jest-environment-jsdom-sixteen` as the test runner until we update to [Jest 26](https://github.com/facebook/react/pull/18816)
## Test Plan
... | {'url': 'https://api.github.com/repos/facebook/react/issues/19288/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19288/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19287 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19287/labels{/name} | https://api.github.com/repos/facebook/react/issues/19287/comments | https://api.github.com/repos/facebook/react/issues/19287/events | https://github.com/facebook/react/pull/19287 | 653,622,146 | MDExOlB1bGxSZXF1ZXN0NDQ2NTA2MDAx | 19,287 | Add dedicated LanePriority for Suspense retries | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19287/builds/38228) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-08 21:57:07 | 2020-07-10 15:10:13 | 2020-07-09 04:09:23 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19287', 'html_url': 'https://github.com/facebook/react/pull/19287', 'diff_url': 'https://github.com/facebook/react/pull/19287.diff', 'patch_url': 'https://github.com/facebook/react/pull/19287.patch', 'merged_at': datetime.datetime(2020, 7, 9, 4, 9, 23)} | A "retry" is a special type of update that attempts to flip a Suspense boundary from its placeholder state back to its primary/resolved state.
Currently, retries are given default priority, using the same algorithm as normal updates and occupying range of lanes.
This adds a new range of lanes dedicated specifical... | {'url': 'https://api.github.com/repos/facebook/react/issues/19287/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19287/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19286 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19286/labels{/name} | https://api.github.com/repos/facebook/react/issues/19286/comments | https://api.github.com/repos/facebook/react/issues/19286/events | https://github.com/facebook/react/pull/19286 | 653,614,912 | MDExOlB1bGxSZXF1ZXN0NDQ2NDk5OTgz | 19,286 | Add missing unitless CSS properties | {'login': 'kripod', 'id': 14854048, 'node_id': 'MDQ6VXNlcjE0ODU0MDQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/14854048?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kripod', 'html_url': 'https://github.com/kripod', 'followers_url': 'https://api.github.com/users/kripod/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | {'login': 'kripod', 'id': 14854048.0, 'node_id': 'MDQ6VXNlcjE0ODU0MDQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/14854048?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kripod', 'html_url': 'https://github.com/kripod', 'followers_url': 'https://api.github.com/users/kripod/followers', 'foll... | [{'login': 'kripod', 'id': 14854048, 'node_id': 'MDQ6VXNlcjE0ODU0MDQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/14854048?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kripod', 'html_url': 'https://github.com/kripod', 'followers_url': 'https://api.github.com/users/kripod/followers', 'follo... | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19286/builds/38182) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-08 21:41:20 | 2020-07-12 09:45:21 | 2020-07-12 09:45:21 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19286', 'html_url': 'https://github.com/facebook/react/pull/19286', 'diff_url': 'https://github.com/facebook/react/pull/19286.diff', 'patch_url': 'https://github.com/facebook/react/pull/19286.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19286/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19286/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19285 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19285/labels{/name} | https://api.github.com/repos/facebook/react/issues/19285/comments | https://api.github.com/repos/facebook/react/issues/19285/events | https://github.com/facebook/react/pull/19285 | 653,601,053 | MDExOlB1bGxSZXF1ZXN0NDQ2NDg4NDg0 | 19,285 | Make form events bubble again | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19285/builds/38174) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-08 21:13:21 | 2020-07-13 20:58:14 | 2020-07-13 20:58:14 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19285', 'html_url': 'https://github.com/facebook/react/pull/19285', 'diff_url': 'https://github.com/facebook/react/pull/19285.diff', 'patch_url': 'https://github.com/facebook/react/pull/19285.patch', 'merged_at': None} | This PR changes form events, specifically `submit` and `reset` so that behave as native bubbling events. Today, with the modern event system, that means making them not use the capture phase.
There are a few issues though. We want to move towards removing the notion of have a special capture phase for certain events... | {'url': 'https://api.github.com/repos/facebook/react/issues/19285/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19285/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19284 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19284/labels{/name} | https://api.github.com/repos/facebook/react/issues/19284/comments | https://api.github.com/repos/facebook/react/issues/19284/events | https://github.com/facebook/react/pull/19284 | 653,569,757 | MDExOlB1bGxSZXF1ZXN0NDQ2NDYyOTUx | 19,284 | Use a custom jsdom fork | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19284/builds/38156) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-08 20:18:27 | 2020-07-08 20:26:55 | 2020-07-08 20:26:55 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19284', 'html_url': 'https://github.com/facebook/react/pull/19284', 'diff_url': 'https://github.com/facebook/react/pull/19284.diff', 'patch_url': 'https://github.com/facebook/react/pull/19284.patch', 'merged_at': datetime.datetime(2020, 7, 8, 20, 26, 55)} | This temporarily uses a jsdom fork, which is the version we use + https://github.com/jsdom/jsdom/commit/a52b77bf6af8a693b26be586b766f9303498214a cherry-picked. This should unblock https://github.com/facebook/react/pull/19186.
<s>This assumes that we actually need this change to unblock. I'm not confident yet because... | {'url': 'https://api.github.com/repos/facebook/react/issues/19284/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19284/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19283 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19283/labels{/name} | https://api.github.com/repos/facebook/react/issues/19283/comments | https://api.github.com/repos/facebook/react/issues/19283/events | https://github.com/facebook/react/pull/19283 | 653,560,910 | MDExOlB1bGxSZXF1ZXN0NDQ2NDU2MDM4 | 19,283 | [DevTools] Show HOC names in profiler | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19283/builds/38711) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-08 20:03:50 | 2020-07-10 15:21:20 | 2020-07-10 15:21:20 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19283', 'html_url': 'https://github.com/facebook/react/pull/19283', 'diff_url': 'https://github.com/facebook/react/pull/19283.diff', 'patch_url': 'https://github.com/facebook/react/pull/19283.patch', 'merged_at': datetime.datetime(2020, 7, 10, 15, 21, 20)} | close #19259
related #18802
| {'url': 'https://api.github.com/repos/facebook/react/issues/19283/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19283/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19282 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19282/labels{/name} | https://api.github.com/repos/facebook/react/issues/19282/comments | https://api.github.com/repos/facebook/react/issues/19282/events | https://github.com/facebook/react/pull/19282 | 653,530,374 | MDExOlB1bGxSZXF1ZXN0NDQ2NDMxNDQz | 19,282 | Add regression test for #19269 | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 9dae847b237... | 2020-07-08 19:09:32 | 2020-07-08 19:48:43 | 2020-07-08 19:48:43 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19282', 'html_url': 'https://github.com/facebook/react/pull/19282', 'diff_url': 'https://github.com/facebook/react/pull/19282.diff', 'patch_url': 'https://github.com/facebook/react/pull/19282.patch', 'merged_at': datetime.datetime(2020, 7, 8, 19, 48, 43)} | Verified it breaks if #19269 is reverted. | {'url': 'https://api.github.com/repos/facebook/react/issues/19282/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19282/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19281 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19281/labels{/name} | https://api.github.com/repos/facebook/react/issues/19281/comments | https://api.github.com/repos/facebook/react/issues/19281/events | https://github.com/facebook/react/pull/19281 | 653,487,410 | MDExOlB1bGxSZXF1ZXN0NDQ2Mzk2NTE3 | 19,281 | feat(devtools): add HOC name in Profiler chart | {'login': 'jyash97', 'id': 22376783, 'node_id': 'MDQ6VXNlcjIyMzc2Nzgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/22376783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jyash97', 'html_url': 'https://github.com/jyash97', 'followers_url': 'https://api.github.com/users/jyash97/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19281/builds/38114) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-08 17:54:21 | 2020-07-10 16:02:31 | 2020-07-10 15:02:58 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19281', 'html_url': 'https://github.com/facebook/react/pull/19281', 'diff_url': 'https://github.com/facebook/react/pull/19281.diff', 'patch_url': 'https://github.com/facebook/react/pull/19281.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19281/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19281/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19280 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19280/labels{/name} | https://api.github.com/repos/facebook/react/issues/19280/comments | https://api.github.com/repos/facebook/react/issues/19280/events | https://github.com/facebook/react/pull/19280 | 653,418,401 | MDExOlB1bGxSZXF1ZXN0NDQ2MzQxNzM0 | 19,280 | Updates Electron version for react-devtools | {'login': 'gsimone', 'id': 1862172, 'node_id': 'MDQ6VXNlcjE4NjIxNzI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1862172?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gsimone', 'html_url': 'https://github.com/gsimone', 'followers_url': 'https://api.github.com/users/gsimone/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Hi @gsimone! \n\nThank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on beh... | 2020-07-08 16:05:29 | 2020-07-09 14:13:28 | 2020-07-09 14:13:27 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19280', 'html_url': 'https://github.com/facebook/react/pull/19280', 'diff_url': 'https://github.com/facebook/react/pull/19280.diff', 'patch_url': 'https://github.com/facebook/react/pull/19280.patch', 'merged_at': datetime.datetime(2020, 7, 9, 14, 13, 27)} | ## Summary
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
Closes #19279
Updates electron to latest ( 9.1 ) to pull in security fixes, as detailed in #19279
## Test Plan
Tested the devtools on MacOS 10.14.6, debugging a web app running Reac... | {'url': 'https://api.github.com/repos/facebook/react/issues/19280/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19280/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19279 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19279/labels{/name} | https://api.github.com/repos/facebook/react/issues/19279/comments | https://api.github.com/repos/facebook/react/issues/19279/events | https://github.com/facebook/react/issues/19279 | 653,266,162 | MDU6SXNzdWU2NTMyNjYxNjI= | 19,279 | Security: 4 Electron (react-devtools dep) security advisories | {'login': 'dobrite', 'id': 1541631, 'node_id': 'MDQ6VXNlcjE1NDE2MzE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1541631?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dobrite', 'html_url': 'https://github.com/dobrite', 'followers_url': 'https://api.github.com/users/dobrite/followers', 'foll... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}
{'id': 725156255, 'node_id': 'MDU6TGFiZWw3MjUxNTYyNTU=', 'url': 'https://... | closed | false | null | [] | null | [
"Interested in contributing the ugprade?",
"I'm interested but unfortunately I do not have time to dedicate to moving this through. Hopefully someone else will jump in and tackle this.",
"Looks like someone else jumped on it already :smile: I'll review the PR in the morning.",
"Fix published as v4.8\r\n\r\nht... | 2020-07-08 12:42:47 | 2020-07-09 14:51:31 | 2020-07-09 14:13:27 | NONE | null | null | null | React version: `16.8.6`
There were 4 security issues filed against `electron`, which `react-devtools` has as a dep. The lowest version that fixes all 4 is `7.2.4` but the version requirement of `electron` for `react-devtools` is `^5.0.0`.
I freely admit that a good solution is to install `react-devtools` as a dev... | {'url': 'https://api.github.com/repos/facebook/react/issues/19279/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19279/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19278 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19278/labels{/name} | https://api.github.com/repos/facebook/react/issues/19278/comments | https://api.github.com/repos/facebook/react/issues/19278/events | https://github.com/facebook/react/pull/19278 | 653,206,564 | MDExOlB1bGxSZXF1ZXN0NDQ2MTY4NjM4 | 19,278 | Remove capturePhaseEvents and separate events by bubbling | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19278/builds/41138) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-08 11:12:30 | 2020-07-21 21:40:56 | 2020-07-21 21:40:51 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19278', 'html_url': 'https://github.com/facebook/react/pull/19278', 'diff_url': 'https://github.com/facebook/react/pull/19278.diff', 'patch_url': 'https://github.com/facebook/react/pull/19278.patch', 'merged_at': datetime.datetime(2020, 7, 21, 21, 40, 51)} | This PR does two things. Primarily it removes `capturePhaseEvents` entirely and now we properly attach events to the phase specified by the user in all case. For events like `onSubmit`, media events, etc, where we previously used the capture phase – we move these back to being attached to their target. This means we do... | {'url': 'https://api.github.com/repos/facebook/react/issues/19278/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19278/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19277 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19277/labels{/name} | https://api.github.com/repos/facebook/react/issues/19277/comments | https://api.github.com/repos/facebook/react/issues/19277/events | https://github.com/facebook/react/issues/19277 | 653,076,941 | MDU6SXNzdWU2NTMwNzY5NDE= | 19,277 | [Micro React Apps] - Need to render another React App into existing React App | {'login': 'vidhyeshpatil', 'id': 35132370, 'node_id': 'MDQ6VXNlcjM1MTMyMzcw', 'avatar_url': 'https://avatars.githubusercontent.com/u/35132370?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vidhyeshpatil', 'html_url': 'https://github.com/vidhyeshpatil', 'followers_url': 'https://api.github.com/users/vidhy... | [{'id': 40929155, 'node_id': 'MDU6TGFiZWw0MDkyOTE1NQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Question', 'name': 'Type: Question', 'color': 'cc317c', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:\r\n\r\n##### Coding Questions\r\n\r\nIf you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great pla... | 2020-07-08 07:55:22 | 2020-07-08 13:55:10 | 2020-07-08 13:55:03 | NONE | null | null | null | Hi,
I need to render another React App (i.e. App2) into existing React App (i.e. App1) on run time. I have hosted my "App2" on a remote server. I read "asset-manifest.json" file from it and on runtime I append those .js chunks in our head tag, this overall code I call from my "App1" to load my "App2" on runtime.
... | {'url': 'https://api.github.com/repos/facebook/react/issues/19277/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19277/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19276 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19276/labels{/name} | https://api.github.com/repos/facebook/react/issues/19276/comments | https://api.github.com/repos/facebook/react/issues/19276/events | https://github.com/facebook/react/pull/19276 | 652,841,910 | MDExOlB1bGxSZXF1ZXN0NDQ1ODU2ODc0 | 19,276 | Remove event constants | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19276/builds/43120) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-08 02:17:19 | 2020-07-30 20:52:42 | 2020-07-30 20:52:38 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19276', 'html_url': 'https://github.com/facebook/react/pull/19276', 'diff_url': 'https://github.com/facebook/react/pull/19276.diff', 'patch_url': 'https://github.com/facebook/react/pull/19276.patch', 'merged_at': datetime.datetime(2020, 7, 30, 20, 52, 38)} | I changed these to a string enum and tightened the types where needed to make them checked.
Also renamed a few things.
This shouldn't affect the output because GCC was always smart enough. | {'url': 'https://api.github.com/repos/facebook/react/issues/19276/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19276/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19275 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19275/labels{/name} | https://api.github.com/repos/facebook/react/issues/19275/comments | https://api.github.com/repos/facebook/react/issues/19275/events | https://github.com/facebook/react/pull/19275 | 652,573,617 | MDExOlB1bGxSZXF1ZXN0NDQ1NjE3ODY0 | 19,275 | [ESLint] Handle optional member chains | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19275/builds/37827) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-07 19:31:32 | 2020-07-07 20:44:45 | 2020-07-07 20:34:16 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19275', 'html_url': 'https://github.com/facebook/react/pull/19275', 'diff_url': 'https://github.com/facebook/react/pull/19275.diff', 'patch_url': 'https://github.com/facebook/react/pull/19275.patch', 'merged_at': datetime.datetime(2020, 7, 7, 20, 34, 16)} | Follow-up to https://github.com/facebook/react/pull/19273.
Our algorithm treats `a.b.c.d` as unique paths in a many places and those parts should work the same way regardless of whether these are optional or required members. So in https://github.com/facebook/react/pull/19273, I removed `?.` from the internal repres... | {'url': 'https://api.github.com/repos/facebook/react/issues/19275/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19275/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19274 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19274/labels{/name} | https://api.github.com/repos/facebook/react/issues/19274/comments | https://api.github.com/repos/facebook/react/issues/19274/events | https://github.com/facebook/react/issues/19274 | 652,532,644 | MDU6SXNzdWU2NTI1MzI2NDQ= | 19,274 | Error: "Commit tree already contains fiber 1. This is a bug in React DevTools." | {'login': 'justinbc820', 'id': 8052526, 'node_id': 'MDQ6VXNlcjgwNTI1MjY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8052526?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/justinbc820', 'html_url': 'https://github.com/justinbc820', 'followers_url': 'https://api.github.com/users/justinbc820/f... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"Hey @justinbc820. Sorry you saw this error.\r\n\r\nIt looks like a duplicate of #18859 though so I'm going to close this issue. If you have any additional repro steps that might help us track it down, please add a comment to that issue!",
"@justinbc820 This error remains the highest reported DevTools bug but we... | 2020-07-07 18:33:52 | 2021-04-29 16:55:20 | 2020-07-07 19:45:59 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. Went to the profiler
2. Did reload and record
3. Stopped Recording
4. Went to Flamegraph
5. Started paging through commits.
6. At around the 5th commit, this error was thrown.
---------------------------------------------
Please do not remove the text bel... | {'url': 'https://api.github.com/repos/facebook/react/issues/19274/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19274/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19273 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19273/labels{/name} | https://api.github.com/repos/facebook/react/issues/19273/comments | https://api.github.com/repos/facebook/react/issues/19273/events | https://github.com/facebook/react/pull/19273 | 652,431,712 | MDExOlB1bGxSZXF1ZXN0NDQ1NTAwODY2 | 19,273 | [ESLint] Consistently treat optional chaining as regular chaining | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19273/builds/37785) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-07 15:48:45 | 2020-07-07 21:41:41 | 2020-07-07 16:38:45 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19273', 'html_url': 'https://github.com/facebook/react/pull/19273', 'diff_url': 'https://github.com/facebook/react/pull/19273.diff', 'patch_url': 'https://github.com/facebook/react/pull/19273.patch', 'merged_at': datetime.datetime(2020, 7, 7, 16, 38, 45)} | We've merged a bunch of PRs which added support for optional chaining to the ESLint rule about dependencies (https://github.com/facebook/react/pull/18820, https://github.com/facebook/react/pull/19008, https://github.com/facebook/react/pull/19062, https://github.com/facebook/react/pull/19260). However there was no singl... | {'url': 'https://api.github.com/repos/facebook/react/issues/19273/reactions', 'total_count': 2, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19273/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19272 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19272/labels{/name} | https://api.github.com/repos/facebook/react/issues/19272/comments | https://api.github.com/repos/facebook/react/issues/19272/events | https://github.com/facebook/react/pull/19272 | 652,418,595 | MDExOlB1bGxSZXF1ZXN0NDQ1NDg5OTkw | 19,272 | Allow decoupleUpdatePriorityFromScheduler to be set | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19272/builds/37759) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-07 15:30:48 | 2020-07-07 19:11:03 | 2020-07-07 16:58:11 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19272', 'html_url': 'https://github.com/facebook/react/pull/19272', 'diff_url': 'https://github.com/facebook/react/pull/19272.diff', 'patch_url': 'https://github.com/facebook/react/pull/19272.patch', 'merged_at': datetime.datetime(2020, 7, 7, 16, 58, 11)} | ## Summary
Need to be able to change this to enable it.
| {'url': 'https://api.github.com/repos/facebook/react/issues/19272/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19272/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19271 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19271/labels{/name} | https://api.github.com/repos/facebook/react/issues/19271/comments | https://api.github.com/repos/facebook/react/issues/19271/events | https://github.com/facebook/react/pull/19271 | 652,284,592 | MDExOlB1bGxSZXF1ZXN0NDQ1MzgyMTYx | 19,271 | Update useEvent implementation | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19271/builds/37726) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-07 12:32:23 | 2020-07-07 13:45:00 | 2020-07-07 13:44:56 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19271', 'html_url': 'https://github.com/facebook/react/pull/19271', 'diff_url': 'https://github.com/facebook/react/pull/19271.diff', 'patch_url': 'https://github.com/facebook/react/pull/19271.patch', 'merged_at': datetime.datetime(2020, 7, 7, 13, 44, 56)} | This updates the `useEvent` implementation within this repo to match that of our internal version, for consistency. | {'url': 'https://api.github.com/repos/facebook/react/issues/19271/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19271/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19270 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19270/labels{/name} | https://api.github.com/repos/facebook/react/issues/19270/comments | https://api.github.com/repos/facebook/react/issues/19270/events | https://github.com/facebook/react/issues/19270 | 652,096,958 | MDU6SXNzdWU2NTIwOTY5NTg= | 19,270 | When waiting for an async action to end, and in the meantime the state changes, there is no way to know about the change | {'login': 'shaibam', 'id': 1324331, 'node_id': 'MDQ6VXNlcjEzMjQzMzE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1324331?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shaibam', 'html_url': 'https://github.com/shaibam', 'followers_url': 'https://api.github.com/users/shaibam/followers', 'foll... | [{'id': 40929155, 'node_id': 'MDU6TGFiZWw0MDkyOTE1NQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Question', 'name': 'Type: Question', 'color': 'cc317c', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Instead of using `setCounter(counter + 1);` use functional update of setCounter like this: `setCounter(prevCounter => prevCounter + 1);`. In this case `prevCounter` will contain the latest value. [Look here](https://reactjs.org/docs/hooks-reference.html#functional-updates)",
"@dmytro-lymarenko suggested what I w... | 2020-07-07 08:00:30 | 2020-07-07 17:50:17 | 2020-07-07 17:50:07 | NONE | null | null | null | <!--
In a functional component, when waiting for an async action to complete and meanwhile changing any state - at the end of the async action the component stays in the previous lifecycle, thus doesn't know about the state change.
-->
React version:
16.13
## Steps To Reproduce
1. create a functional compon... | {'url': 'https://api.github.com/repos/facebook/react/issues/19270/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19270/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19269 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19269/labels{/name} | https://api.github.com/repos/facebook/react/issues/19269/comments | https://api.github.com/repos/facebook/react/issues/19269/events | https://github.com/facebook/react/pull/19269 | 651,913,256 | MDExOlB1bGxSZXF1ZXN0NDQ1MDgwMDQ5 | 19,269 | Fix event replaying logic | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19269/builds/37604) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-07 01:09:41 | 2020-07-07 01:29:02 | 2020-07-07 01:28:56 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19269', 'html_url': 'https://github.com/facebook/react/pull/19269', 'diff_url': 'https://github.com/facebook/react/pull/19269.diff', 'patch_url': 'https://github.com/facebook/react/pull/19269.patch', 'merged_at': datetime.datetime(2020, 7, 7, 1, 28, 56)} | We need to ensure the logic for event replaying matches the expectations for how we register events normally, so events that are capture phase only, should have their properties passed through respectfully. | {'url': 'https://api.github.com/repos/facebook/react/issues/19269/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19269/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19268 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19268/labels{/name} | https://api.github.com/repos/facebook/react/issues/19268/comments | https://api.github.com/repos/facebook/react/issues/19268/events | https://github.com/facebook/react/pull/19268 | 651,848,051 | MDExOlB1bGxSZXF1ZXN0NDQ1MDI2MjM0 | 19,268 | Revert "Fix ExhaustiveDeps ESLint rule throwing with optional chaining" | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19268/builds/37575) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-06 22:07:00 | 2022-11-29 22:22:10 | 2020-07-07 15:41:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19268', 'html_url': 'https://github.com/facebook/react/pull/19268', 'diff_url': 'https://github.com/facebook/react/pull/19268.diff', 'patch_url': 'https://github.com/facebook/react/pull/19268.patch', 'merged_at': None} | Reverts facebook/react#19260
We don't have to merge this revert right now. But we shouldn't lose track of it because that PR only addressed a symptom rather than the cause. I think we'll get more confusing bugs later on if we don't fix the actual root problem. | {'url': 'https://api.github.com/repos/facebook/react/issues/19268/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19268/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19267 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19267/labels{/name} | https://api.github.com/repos/facebook/react/issues/19267/comments | https://api.github.com/repos/facebook/react/issues/19267/events | https://github.com/facebook/react/pull/19267 | 651,826,056 | MDExOlB1bGxSZXF1ZXN0NDQ1MDA4MDAx | 19,267 | Fix master tests | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19267/builds/37559) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-06 21:20:13 | 2020-07-06 21:36:20 | 2020-07-06 21:36:20 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19267', 'html_url': 'https://github.com/facebook/react/pull/19267', 'diff_url': 'https://github.com/facebook/react/pull/19267.diff', 'patch_url': 'https://github.com/facebook/react/pull/19267.patch', 'merged_at': datetime.datetime(2020, 7, 6, 21, 36, 20)} | This fixes master where some event related tests were referencing `ReactDOM.createRoot` rather than `ReactDOM.unstable_createRoot` when running tests on the builds. | {'url': 'https://api.github.com/repos/facebook/react/issues/19267/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19267/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19266 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19266/labels{/name} | https://api.github.com/repos/facebook/react/issues/19266/comments | https://api.github.com/repos/facebook/react/issues/19266/events | https://github.com/facebook/react/pull/19266 | 651,810,682 | MDExOlB1bGxSZXF1ZXN0NDQ0OTk1MjEy | 19,266 | Fix test suite in CI | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19266/builds/37553) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-06 20:51:23 | 2020-07-06 20:59:20 | 2020-07-06 20:59:16 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19266', 'html_url': 'https://github.com/facebook/react/pull/19266', 'diff_url': 'https://github.com/facebook/react/pull/19266.diff', 'patch_url': 'https://github.com/facebook/react/pull/19266.patch', 'merged_at': None} |
## Summary
Forward the child process exit code so that failures show up in Circle.
## Test Plan
Pushed a bad commit, Circle should fail and we'll revert that commit before landing. | {'url': 'https://api.github.com/repos/facebook/react/issues/19266/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19266/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19265 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19265/labels{/name} | https://api.github.com/repos/facebook/react/issues/19265/comments | https://api.github.com/repos/facebook/react/issues/19265/events | https://github.com/facebook/react/pull/19265 | 651,809,543 | MDExOlB1bGxSZXF1ZXN0NDQ0OTk0MjYy | 19,265 | Handle test-cli failure case for CI | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19265/builds/37557) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-06 20:49:10 | 2020-07-08 14:54:03 | 2020-07-06 21:05:52 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19265', 'html_url': 'https://github.com/facebook/react/pull/19265', 'diff_url': 'https://github.com/facebook/react/pull/19265.diff', 'patch_url': 'https://github.com/facebook/react/pull/19265.patch', 'merged_at': datetime.datetime(2020, 7, 6, 21, 5, 52)} | We should handle the failure case for the test CLI for when a process exits with a code that is `1`. | {'url': 'https://api.github.com/repos/facebook/react/issues/19265/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19265/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19264 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19264/labels{/name} | https://api.github.com/repos/facebook/react/issues/19264/comments | https://api.github.com/repos/facebook/react/issues/19264/events | https://github.com/facebook/react/pull/19264 | 651,781,765 | MDExOlB1bGxSZXF1ZXN0NDQ0OTcxMjUw | 19,264 | Move Scope API ref resolution to mutation phase | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19264/builds/38181) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-06 19:53:53 | 2020-07-08 22:41:40 | 2020-07-08 22:41:40 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19264', 'html_url': 'https://github.com/facebook/react/pull/19264', 'diff_url': 'https://github.com/facebook/react/pull/19264.diff', 'patch_url': 'https://github.com/facebook/react/pull/19264.patch', 'merged_at': datetime.datetime(2020, 7, 8, 22, 41, 40)} | To unblock internal progression on replacing React Flare, let's instead move resolution of Scope API refs to the mutation phase, so we can attach event listeners to scopes before the layout phase begins. | {'url': 'https://api.github.com/repos/facebook/react/issues/19264/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19264/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19263 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19263/labels{/name} | https://api.github.com/repos/facebook/react/issues/19263/comments | https://api.github.com/repos/facebook/react/issues/19263/events | https://github.com/facebook/react/pull/19263 | 651,759,004 | MDExOlB1bGxSZXF1ZXN0NDQ0OTUyNTcz | 19,263 | Fork ReactFiberLane (new and old) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19263/builds/37528) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-06 19:10:10 | 2020-07-06 19:21:03 | 2020-07-06 19:21:02 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19263', 'html_url': 'https://github.com/facebook/react/pull/19263', 'diff_url': 'https://github.com/facebook/react/pull/19263.diff', 'patch_url': 'https://github.com/facebook/react/pull/19263.patch', 'merged_at': None} | This wasn't previously forked because it used to only exist in the new one. | {'url': 'https://api.github.com/repos/facebook/react/issues/19263/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19263/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19262 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19262/labels{/name} | https://api.github.com/repos/facebook/react/issues/19262/comments | https://api.github.com/repos/facebook/react/issues/19262/events | https://github.com/facebook/react/pull/19262 | 651,757,684 | MDExOlB1bGxSZXF1ZXN0NDQ0OTUxNDkw | 19,262 | Enable createEventHandle API for wWW test builds | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19262/builds/37524) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-06 19:07:30 | 2020-07-06 19:20:10 | 2020-07-06 19:19:51 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19262', 'html_url': 'https://github.com/facebook/react/pull/19262', 'diff_url': 'https://github.com/facebook/react/pull/19262.diff', 'patch_url': 'https://github.com/facebook/react/pull/19262.patch', 'merged_at': datetime.datetime(2020, 7, 6, 19, 19, 51)} | Without this, Scott is unable to test the new test selector API because code that uses `useEvent` will cause null runtime errors (since `createEventHandle` returns `null` unless this flag is enabled). | {'url': 'https://api.github.com/repos/facebook/react/issues/19262/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19262/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19261 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19261/labels{/name} | https://api.github.com/repos/facebook/react/issues/19261/comments | https://api.github.com/repos/facebook/react/issues/19261/events | https://github.com/facebook/react/pull/19261 | 651,706,361 | MDExOlB1bGxSZXF1ZXN0NDQ0OTEwMzk5 | 19,261 | Effects list refactor | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19261/builds/38959) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-06 17:28:52 | 2020-07-16 13:10:27 | 2020-07-16 13:10:21 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19261', 'html_url': 'https://github.com/facebook/react/pull/19261', 'diff_url': 'https://github.com/facebook/react/pull/19261.diff', 'patch_url': 'https://github.com/facebook/react/pull/19261.patch', 'merged_at': None} | This branch is phase one of a planned effects list refactor. It includes the following changes:
* Replace effects list usage with traversing the Fiber tree for before-mutation, mutation, and layout effects phases.
* Track pending deletions in a new `deletions` Fiber field.
* Track which effects exist below a Fiber u... | {'url': 'https://api.github.com/repos/facebook/react/issues/19261/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19261/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19260 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19260/labels{/name} | https://api.github.com/repos/facebook/react/issues/19260/comments | https://api.github.com/repos/facebook/react/issues/19260/events | https://github.com/facebook/react/pull/19260 | 651,602,333 | MDExOlB1bGxSZXF1ZXN0NDQ0ODI2MTEy | 19,260 | Fix ExhaustiveDeps ESLint rule throwing with optional chaining | {'login': 'lencioni', 'id': 195534, 'node_id': 'MDQ6VXNlcjE5NTUzNA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/195534?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lencioni', 'html_url': 'https://github.com/lencioni', 'followers_url': 'https://api.github.com/users/lencioni/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19260/builds/37463) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-06 14:51:26 | 2020-07-07 15:49:50 | 2020-07-06 19:52:16 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19260', 'html_url': 'https://github.com/facebook/react/pull/19260', 'diff_url': 'https://github.com/facebook/react/pull/19260.diff', 'patch_url': 'https://github.com/facebook/react/pull/19260.patch', 'merged_at': datetime.datetime(2020, 7, 6, 19, 52, 15)} |
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. F... | {'url': 'https://api.github.com/repos/facebook/react/issues/19260/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19260/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19259 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19259/labels{/name} | https://api.github.com/repos/facebook/react/issues/19259/comments | https://api.github.com/repos/facebook/react/issues/19259/events | https://github.com/facebook/react/issues/19259 | 651,421,945 | MDU6SXNzdWU2NTE0MjE5NDU= | 19,259 | Suggestion: show HOC names in profiler | {'login': 'OliverJAsh', 'id': 921609, 'node_id': 'MDQ6VXNlcjkyMTYwOQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/921609?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/OliverJAsh', 'html_url': 'https://github.com/OliverJAsh', 'followers_url': 'https://api.github.com/users/OliverJAsh/followe... | [{'id': 121709921, 'node_id': 'MDU6TGFiZWwxMjE3MDk5MjE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Feature%20Request', 'name': 'Type: Feature Request', 'color': 'c7def8', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github... | closed | false | null | [] | null | [
"Can I take this up?",
"Can I try this?"
] | 2020-07-06 10:17:15 | 2020-07-10 15:21:20 | 2020-07-10 15:21:20 | NONE | null | null | null | (Deleted template as this is a suggestion, not a bug.)
The dev tools helpfully extracts HOC names and shows them in the components tree. [Example](https://react-devtools-tutorial.now.sh/higher-order-components):
![image](https://user-images.githubusercontent.com/921609/86582724-03ddbc00-bf7a-11ea-83fb-f9d0a3902e5... | {'url': 'https://api.github.com/repos/facebook/react/issues/19259/reactions', 'total_count': 5, '+1': 5, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19259/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19258 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19258/labels{/name} | https://api.github.com/repos/facebook/react/issues/19258/comments | https://api.github.com/repos/facebook/react/issues/19258/events | https://github.com/facebook/react/issues/19258 | 651,421,171 | MDU6SXNzdWU2NTE0MjExNzE= | 19,258 | help | {'login': 'waluyasam', 'id': 60738841, 'node_id': 'MDQ6VXNlcjYwNzM4ODQx', 'avatar_url': 'https://avatars.githubusercontent.com/u/60738841?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/waluyasam', 'html_url': 'https://github.com/waluyasam', 'followers_url': 'https://api.github.com/users/waluyasam/followe... | [] | closed | false | null | [] | null | [
"You might be reporting the same Chrome bug covered in #19002.\r\n\r\nIf not, there is not enough info here for anyone to help diagnose the problem.\r\n\r\nFirst, make sure you're on a website using React.\r\n\r\nThe panel might be hidden by default if your browser is not wide enough, in which case you'll need to s... | 2020-07-06 10:16:00 | 2020-07-06 12:53:39 | 2020-07-06 12:53:38 | NONE | null | null | null | ive installed the react developer tools in my chrome but i cant find it when i click to inspect elements | {'url': 'https://api.github.com/repos/facebook/react/issues/19258/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19258/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/19257 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19257/labels{/name} | https://api.github.com/repos/facebook/react/issues/19257/comments | https://api.github.com/repos/facebook/react/issues/19257/events | https://github.com/facebook/react/pull/19257 | 651,013,168 | MDExOlB1bGxSZXF1ZXN0NDQ0MzY3MTcx | 19,257 | Improved performance of forceFrameRate | {'login': 'nanyang24', 'id': 17287124, 'node_id': 'MDQ6VXNlcjE3Mjg3MTI0', 'avatar_url': 'https://avatars.githubusercontent.com/u/17287124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nanyang24', 'html_url': 'https://github.com/nanyang24', 'followers_url': 'https://api.github.com/users/nanyang24/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/19257/builds/37205) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-07-05 06:43:55 | 2020-07-08 16:03:54 | 2020-07-08 15:57:07 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/19257', 'html_url': 'https://github.com/facebook/react/pull/19257', 'diff_url': 'https://github.com/facebook/react/pull/19257.diff', 'patch_url': 'https://github.com/facebook/react/pull/19257.patch', 'merged_at': None} |
Improved performance of `forceFrameRate` as using [zero-fill right shift](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_Operators#Unsigned_right_shift) instead of `Math.floor`
[Diff performance](https://perf.link/#eyJpZCI6ImRpb2hydHdsd2VyIiwidGl0bGUiOiJGaW5kIEhvb2sgTmFtZSIsImJ... | {'url': 'https://api.github.com/repos/facebook/react/issues/19257/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19257/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/19256 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/19256/labels{/name} | https://api.github.com/repos/facebook/react/issues/19256/comments | https://api.github.com/repos/facebook/react/issues/19256/events | https://github.com/facebook/react/issues/19256 | 650,899,420 | MDU6SXNzdWU2NTA4OTk0MjA= | 19,256 | Feature proposal: Hook equivalent to createSlice from Redux Toolkit? | {'login': 'pdcribeiro', 'id': 46378748, 'node_id': 'MDQ6VXNlcjQ2Mzc4NzQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/46378748?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pdcribeiro', 'html_url': 'https://github.com/pdcribeiro', 'followers_url': 'https://api.github.com/users/pdcribeiro/fol... | [{'id': 121709921, 'node_id': 'MDU6TGFiZWwxMjE3MDk5MjE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Feature%20Request', 'name': 'Type: Feature Request', 'color': 'c7def8', 'default': False, 'description': None}
{'id': 1109410193, 'node_id': 'MDU6TGFiZWwxMTA5NDEwMTkz', 'url': 'https://api.githu... | closed | false | null | [] | null | [
"Hey @pdcribeiro thanks for the idea!\r\n\r\nIs there a reason you think this should be in core instead of a separate package?",
"Hey @rickhanlonii thanks for the reply :)\r\n\r\nI'm a beginner so this is an uninformed suggestion but it would reduce the amount of boilerplate code needed in comparison with using u... | 2020-07-04 14:22:02 | 2020-07-07 15:08:27 | 2020-07-06 15:42:01 | NONE | null | null | null | Would this be useful?
> A function that accepts an initial state, an object full of reducer functions, and a "slice name", and automatically generates action creators and action types that correspond to the reducers and state.
From [createSlice](https://redux-toolkit.js.org/api/createSlice). | {'url': 'https://api.github.com/repos/facebook/react/issues/19256/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/19256/timeline | null | completed | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.