url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/18435 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18435/labels{/name} | https://api.github.com/repos/facebook/react/issues/18435/comments | https://api.github.com/repos/facebook/react/issues/18435/events | https://github.com/facebook/react/pull/18435 | 590,505,033 | MDExOlB1bGxSZXF1ZXN0Mzk1ODI2NTIx | 18,435 | [ESLint] Check deps when callback body is outside the Hook call, too | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18435/builds/17167) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-30 18:37:18 | 2020-03-31 01:09:33 | 2020-03-31 01:09:33 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18435', 'html_url': 'https://github.com/facebook/react/pull/18435', 'diff_url': 'https://github.com/facebook/react/pull/18435.diff', 'patch_url': 'https://github.com/facebook/react/pull/18435.patch', 'merged_at': datetime.datetime(2020, 3, 31, 1, 9, 33)} | Fixes https://github.com/facebook/react/issues/16573.
We didn't use to check calls like `useEffect(effectBody, [])` at all. That was dangerous. Now we do.
The first commit is a refactor so that we scan any arbitrary function for deps, rather than a direct child of a Hook call. The second commit uses it to check c... | {'url': 'https://api.github.com/repos/facebook/react/issues/18435/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 2, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18435/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18434 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18434/labels{/name} | https://api.github.com/repos/facebook/react/issues/18434/comments | https://api.github.com/repos/facebook/react/issues/18434/events | https://github.com/facebook/react/issues/18434 | 590,193,182 | MDU6SXNzdWU1OTAxOTMxODI= | 18,434 | Bug: SuspenseList revealOrder="backwards" is not consistent without tail props | {'login': 'velusgautam', 'id': 8556085, 'node_id': 'MDQ6VXNlcjg1NTYwODU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8556085?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/velusgautam', 'html_url': 'https://github.com/velusgautam', 'followers_url': 'https://api.github.com/users/velusgautam/f... | [{'id': 710722093, 'node_id': 'MDU6TGFiZWw3MTA3MjIwOTM=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Needs%20Investigation', 'name': 'Type: Needs Investigation', 'color': '65AA9C', 'default': False, 'description': ''}
{'id': 1109407645, 'node_id': 'MDU6TGFiZWwxMTA5NDA3NjQ1', 'url': 'https://api... | open | false | null | [] | null | [
"Can you turn this into a failing test in the test suite?",
"@gaearon I tried to make a test case that fails but the same scenario test cases are passing when I Flush and yield is called. \r\n\r\nBut in the codesandbox\r\nhttps://codesandbox.io/s/bug-suspenselist-revealordertogether-and-error-boundaries-18429-1ok... | 2020-03-30 10:53:39 | 2020-04-06 17:51:36 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 0.0.0-experimental-aae83a4b9
## Steps To Reproduce
1. If `<... | {'url': 'https://api.github.com/repos/facebook/react/issues/18434/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18434/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/18433 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18433/labels{/name} | https://api.github.com/repos/facebook/react/issues/18433/comments | https://api.github.com/repos/facebook/react/issues/18433/events | https://github.com/facebook/react/issues/18433 | 590,133,578 | MDU6SXNzdWU1OTAxMzM1Nzg= | 18,433 | Bug: shouldComponentUpdate() doesn't being called while using this.context | {'login': 'BiosBoy', 'id': 30953392, 'node_id': 'MDQ6VXNlcjMwOTUzMzky', 'avatar_url': 'https://avatars.githubusercontent.com/u/30953392?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/BiosBoy', 'html_url': 'https://github.com/BiosBoy', 'followers_url': 'https://api.github.com/users/BiosBoy/followers', 'fo... | [{'id': 1983406161, 'node_id': 'MDU6TGFiZWwxOTgzNDA2MTYx', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Expected%20Behavior', 'name': 'Resolution: Expected Behavior', 'color': '8c98d8', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"Hey @BiosBoy! It's exepcted that `shouldComponentUpdate` isn't called when context is updated. This is [noted in the context docs](https://reactjs.org/docs/context.html#contextprovider):\r\n\r\n> The propagation from Provider to its descendant consumers (including .contextType and useContext) is not subject to the... | 2020-03-30 09:26:06 | 2020-04-18 15:54:09 | 2020-04-13 19:01:26 | NONE | null | null | null | Well, guys, I've read this post by @gaearon https://github.com/facebook/react/issues/2517 and still didn't figure out - does new context API is compatible with `shouldComponentUpdate()` since React v.16?
As far as I tested today `shouldComponentUpdate` is not callable at all while using `this.context` on the child ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18433/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18433/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18432 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18432/labels{/name} | https://api.github.com/repos/facebook/react/issues/18432/comments | https://api.github.com/repos/facebook/react/issues/18432/events | https://github.com/facebook/react/pull/18432 | 589,848,948 | MDExOlB1bGxSZXF1ZXN0Mzk1MjkzNTA0 | 18,432 | fix: Prevent crash when resuming class component inside SuspenseList | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18432/builds/17316) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-29 18:07:09 | 2020-03-31 21:57:32 | 2020-03-31 20:43:13 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18432', 'html_url': 'https://github.com/facebook/react/pull/18432', 'diff_url': 'https://github.com/facebook/react/pull/18432.diff', 'patch_url': 'https://github.com/facebook/react/pull/18432.patch', 'merged_at': None} | ## Summary
Test for #18429 (includes a fix but it's unclear if the semantics are correct)
## Test Plan
~Might be interesting add matchers for the case where one of the error boundaries is actually triggered.~ No longer concerned with error boundaries. They caused the crash originally but the bug could be redu... | {'url': 'https://api.github.com/repos/facebook/react/issues/18432/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18432/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18431 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18431/labels{/name} | https://api.github.com/repos/facebook/react/issues/18431/comments | https://api.github.com/repos/facebook/react/issues/18431/events | https://github.com/facebook/react/issues/18431 | 589,842,237 | MDU6SXNzdWU1ODk4NDIyMzc= | 18,431 | Bug: Legacy context warning is misreporting the parent element | {'login': 'mikecousins', 'id': 725614, 'node_id': 'MDQ6VXNlcjcyNTYxNA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/725614?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mikecousins', 'html_url': 'https://github.com/mikecousins', 'followers_url': 'https://api.github.com/users/mikecousins/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I dug into this a bit more and found the probable cause of it:\r\n\r\nhttps://github.com/stripe/react-stripe-elements/blob/master/src/index.js#L2\r\n\r\nInside the react-stripe-elements the file is called Provider and is being renamed to StripeProvider. Sooo, it's mostly just a naming coincidence.\r\n\r\nI don't k... | 2020-03-29 17:32:10 | 2020-03-29 20:53:35 | 2020-03-29 20:53:34 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.13.1
## Steps To Reproduce
1. Put react-stripe-elements ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18431/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18431/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18430 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18430/labels{/name} | https://api.github.com/repos/facebook/react/issues/18430/comments | https://api.github.com/repos/facebook/react/issues/18430/events | https://github.com/facebook/react/pull/18430 | 589,823,325 | MDExOlB1bGxSZXF1ZXN0Mzk1Mjc0Nzg0 | 18,430 | feat(StrictMode): Double-invoke render for every component | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18430/builds/16902) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-29 15:57:26 | 2020-03-29 22:22:50 | 2020-03-29 22:13:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18430', 'html_url': 'https://github.com/facebook/react/pull/18430', 'diff_url': 'https://github.com/facebook/react/pull/18430.diff', 'patch_url': 'https://github.com/facebook/react/pull/18430.patch', 'merged_at': datetime.datetime(2020, 3, 29, 22, 13, 47)} | ## Summary
Closes #18426.
Essentially #14639 rebased with `master` where concerns were voiced about existing tests.
## Test Plan
ReactHooks-internal is responsible for this test. This also affects any test counting renders. | {'url': 'https://api.github.com/repos/facebook/react/issues/18430/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18430/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18429 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18429/labels{/name} | https://api.github.com/repos/facebook/react/issues/18429/comments | https://api.github.com/repos/facebook/react/issues/18429/events | https://github.com/facebook/react/issues/18429 | 589,776,528 | MDU6SXNzdWU1ODk3NzY1Mjg= | 18,429 | Bug: SuspenseList revealOrder="together" and error boundaries | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 1109407645, 'node_id': 'MDU6TGFiZWwxMTA5NDA3NjQ1', 'url': 'https://api.github.com/repos/facebook/react/... | closed | false | null | [] | null | [
"Sounds like a bug. ",
"Would you mind sending this as a PR with a failing test? You can see existing SuspenseList tests as an inspiration.",
"Added test in https://github.com/facebook/react/pull/18432\r\n\r\nThis is reproducible with a basic class component which means the assumption in \r\nhttps://github.com/... | 2020-03-29 12:03:27 | 2020-04-01 05:26:57 | 2020-04-01 05:26:57 | COLLABORATOR | null | null | null |
React version: 0.0.0-experimental-aae83a4b9
## Steps To Reproduce
1. Wrap and error boundary around a suspense boundary inside a `<SuspenseList revealOrder="together" />`
2. Crash with `Cannot read property 'shared' of null`
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18429/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18429/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18428 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18428/labels{/name} | https://api.github.com/repos/facebook/react/issues/18428/comments | https://api.github.com/repos/facebook/react/issues/18428/events | https://github.com/facebook/react/pull/18428 | 589,758,208 | MDExOlB1bGxSZXF1ZXN0Mzk1MjI2ODA3 | 18,428 | chore: npm link more directly | {'login': 'AshoneA', 'id': 22393991, 'node_id': 'MDQ6VXNlcjIyMzkzOTkx', 'avatar_url': 'https://avatars.githubusercontent.com/u/22393991?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AshoneA', 'html_url': 'https://github.com/AshoneA', 'followers_url': 'https://api.github.com/users/AshoneA/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @AshoneA! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on beha... | 2020-03-29 10:03:45 | 2020-03-29 14:20:20 | 2020-03-29 14:18:16 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18428', 'html_url': 'https://github.com/facebook/react/pull/18428', 'diff_url': 'https://github.com/facebook/react/pull/18428.diff', 'patch_url': 'https://github.com/facebook/react/pull/18428.patch', 'merged_at': datetime.datetime(2020, 3, 29, 14, 18, 16)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18428/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18428/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18427 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18427/labels{/name} | https://api.github.com/repos/facebook/react/issues/18427/comments | https://api.github.com/repos/facebook/react/issues/18427/events | https://github.com/facebook/react/issues/18427 | 589,752,863 | MDU6SXNzdWU1ODk3NTI4NjM= | 18,427 | Bug: React function component unmounts on state change. | {'login': 'YashGadle', 'id': 10195795, 'node_id': 'MDQ6VXNlcjEwMTk1Nzk1', 'avatar_url': 'https://avatars.githubusercontent.com/u/10195795?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/YashGadle', 'html_url': 'https://github.com/YashGadle', 'followers_url': 'https://api.github.com/users/YashGadle/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You should pass an empty array in useEffect hook in Description component like this:\r\n```js\r\nReact.useEffect(() => {\r\n return () => {\r\n console.log(\"UNMOUNTED\");\r\n };\r\n }, []);\r\n```",
"Yes that works, but can you explain 2 things that I can't figure out:-\r\n1. When it was unmounting ... | 2020-03-29 09:25:48 | 2020-07-22 18:04:20 | 2020-03-29 10:34:53 | NONE | null | null | null | When rendering a function component, the state change causes the component to unmount and then remount. The same component using class based implementation won't unmount.
React version: 16.13.1
## Steps To Reproduce
Reproduce here in the sandbox...
Link to code example: https://codesandbox.io/s/youthful-shaw-fn... | {'url': 'https://api.github.com/repos/facebook/react/issues/18427/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18427/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18426 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18426/labels{/name} | https://api.github.com/repos/facebook/react/issues/18426/comments | https://api.github.com/repos/facebook/react/issues/18426/events | https://github.com/facebook/react/issues/18426 | 589,749,122 | MDU6SXNzdWU1ODk3NDkxMjI= | 18,426 | Call all functions twice in StrictMode | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Yeah I think it would be reasonable to flip it for all functions. Happy to take a PR doing that. ",
">since this has been ignored I'm not sure this helps\r\n\r\nWould you like to volunteer maintaining the docs? Tbh we're a bit swamped by all the other work right now and this would be helpful.",
"I think this p... | 2020-03-29 08:59:55 | 2020-04-27 06:17:35 | 2020-03-29 22:13:47 | COLLABORATOR | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.3-16.13
## Steps To Reproduce
1. Render function compone... | {'url': 'https://api.github.com/repos/facebook/react/issues/18426/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18426/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18425 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18425/labels{/name} | https://api.github.com/repos/facebook/react/issues/18425/comments | https://api.github.com/repos/facebook/react/issues/18425/events | https://github.com/facebook/react/issues/18425 | 589,740,110 | MDU6SXNzdWU1ODk3NDAxMTA= | 18,425 | Issue | {'login': 'nhuhung19', 'id': 56119213, 'node_id': 'MDQ6VXNlcjU2MTE5MjEz', 'avatar_url': 'https://avatars.githubusercontent.com/u/56119213?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nhuhung19', 'html_url': 'https://github.com/nhuhung19', 'followers_url': 'https://api.github.com/users/nhuhung19/followe... | [] | closed | false | null | [] | null | [] | 2020-03-29 07:50:59 | 2020-03-29 07:52:24 | 2020-03-29 07:52:24 | NONE | null | null | null | I have issue again | {'url': 'https://api.github.com/repos/facebook/react/issues/18425/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18425/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18424 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18424/labels{/name} | https://api.github.com/repos/facebook/react/issues/18424/comments | https://api.github.com/repos/facebook/react/issues/18424/events | https://github.com/facebook/react/issues/18424 | 589,722,655 | MDU6SXNzdWU1ODk3MjI2NTU= | 18,424 | Bug: It works in class component but in the hooks the val function calling infinity times can any one have solution for this........... | {'login': 'seelasudheer', 'id': 30329091, 'node_id': 'MDQ6VXNlcjMwMzI5MDkx', 'avatar_url': 'https://avatars.githubusercontent.com/u/30329091?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/seelasudheer', 'html_url': 'https://github.com/seelasudheer', 'followers_url': 'https://api.github.com/users/seelasud... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"1. If you want to set `records` initially to `props.records`, don’t call `setRecords` during render. Instead, when you declare your state variable, pass `props.records` as an argument to `useState`.\r\n\r\n2. In general, copying props to state is a bad idea. Instead you should try to lift state up to the parent co... | 2020-03-29 05:32:59 | 2020-03-29 14:01:37 | 2020-03-29 14:01:37 | NONE | null | null | null | import React, { useState } from 'react'
function Inhook(props) {
const initialState = 0;
const [records, setRecords] = useState([]);
const [count, setCount] = useState(initialState);
const [show, setShow] = useState(false);
const [store, setStore] = useState(initialState);
const [store1... | {'url': 'https://api.github.com/repos/facebook/react/issues/18424/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18424/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18423 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18423/labels{/name} | https://api.github.com/repos/facebook/react/issues/18423/comments | https://api.github.com/repos/facebook/react/issues/18423/events | https://github.com/facebook/react/issues/18423 | 589,722,363 | MDU6SXNzdWU1ODk3MjIzNjM= | 18,423 | Bug: | {'login': 'seelasudheer', 'id': 30329091, 'node_id': 'MDQ6VXNlcjMwMzI5MDkx', 'avatar_url': 'https://avatars.githubusercontent.com/u/30329091?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/seelasudheer', 'html_url': 'https://github.com/seelasudheer', 'followers_url': 'https://api.github.com/users/seelasud... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I already replied to you in https://github.com/facebook/react/issues/18424#issuecomment-605640709. Please stop creating duplicate issues, this is not okay. "
] | 2020-03-29 05:30:27 | 2020-03-30 10:49:17 | 2020-03-30 10:49:17 | NONE | null | null | null | It works in class component but in the hooks the val function calling infinity times
can any one have solution for this...........
import React, { useState } from 'react'
function Inhook(props) {
const initialState = 0;
const [records, setRecords] = useState([]);
const [count, setCount] = useState(i... | {'url': 'https://api.github.com/repos/facebook/react/issues/18423/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18423/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18422 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18422/labels{/name} | https://api.github.com/repos/facebook/react/issues/18422/comments | https://api.github.com/repos/facebook/react/issues/18422/events | https://github.com/facebook/react/issues/18422 | 589,669,998 | MDU6SXNzdWU1ODk2Njk5OTg= | 18,422 | Bug: When we use useState, component 2 time render. why? | {'login': 'behnammodi', 'id': 1549069, 'node_id': 'MDQ6VXNlcjE1NDkwNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1549069?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/behnammodi', 'html_url': 'https://github.com/behnammodi', 'followers_url': 'https://api.github.com/users/behnammodi/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"That’s what Strict Mode does. It calls render phase code twice in development so that you can notice if it performs unexpected side effects. In production, there would be only one call.\r\n\r\nhttps://reactjs.org/docs/strict-mode.html"
] | 2020-03-28 22:13:35 | 2020-03-30 11:33:21 | 2020-03-28 23:22:58 | CONTRIBUTOR | null | null | null | When we use `useState` with `<StrictMode />`, component 2 time render. why?
React version: 16.3.1
Link to code example:
https://codesandbox.io/s/rerender-bug-3ydyu
Open console
## Sample Code:
```jsx
import React, { useState } from "react";
import ReactDOM from "react-dom";
export default function App(... | {'url': 'https://api.github.com/repos/facebook/react/issues/18422/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18422/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18421 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18421/labels{/name} | https://api.github.com/repos/facebook/react/issues/18421/comments | https://api.github.com/repos/facebook/react/issues/18421/events | https://github.com/facebook/react/pull/18421 | 589,665,966 | MDExOlB1bGxSZXF1ZXN0Mzk1MTU5NjEy | 18,421 | https link to editorconfig.org | {'login': 'rodrigograca31', 'id': 1134310, 'node_id': 'MDQ6VXNlcjExMzQzMTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1134310?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rodrigograca31', 'html_url': 'https://github.com/rodrigograca31', 'followers_url': 'https://api.github.com/users/rodr... | [] | closed | false | null | [] | null | [
"Hi @rodrigograca31! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing ... | 2020-03-28 21:46:25 | 2020-03-29 14:18:53 | 2020-03-29 14:18:53 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18421', 'html_url': 'https://github.com/facebook/react/pull/18421', 'diff_url': 'https://github.com/facebook/react/pull/18421.diff', 'patch_url': 'https://github.com/facebook/react/pull/18421.patch', 'merged_at': datetime.datetime(2020, 3, 29, 14, 18, 53)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18421/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18421/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18420 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18420/labels{/name} | https://api.github.com/repos/facebook/react/issues/18420/comments | https://api.github.com/repos/facebook/react/issues/18420/events | https://github.com/facebook/react/pull/18420 | 589,659,302 | MDExOlB1bGxSZXF1ZXN0Mzk1MTU0NzQ2 | 18,420 | [Not for merge] Suspense fixes combined | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18420/builds/16794) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-28 21:03:13 | 2020-03-31 01:24:13 | 2020-03-31 01:24:13 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/18420', 'html_url': 'https://github.com/facebook/react/pull/18420', 'diff_url': 'https://github.com/facebook/react/pull/18420.diff', 'patch_url': 'https://github.com/facebook/react/pull/18420.patch', 'merged_at': None} | Want to kick off a WWW full test run for these fixes early. | {'url': 'https://api.github.com/repos/facebook/react/issues/18420/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18420/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18419 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18419/labels{/name} | https://api.github.com/repos/facebook/react/issues/18419/comments | https://api.github.com/repos/facebook/react/issues/18419/events | https://github.com/facebook/react/pull/18419 | 589,632,494 | MDExOlB1bGxSZXF1ZXN0Mzk1MTM1MDgy | 18,419 | Make interaction tracing on by default in all WWW builds | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18419/builds/16782) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-28 18:29:02 | 2020-03-30 15:07:59 | 2020-03-30 15:07:59 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18419', 'html_url': 'https://github.com/facebook/react/pull/18419', 'diff_url': 'https://github.com/facebook/react/pull/18419.diff', 'patch_url': 'https://github.com/facebook/react/pull/18419.patch', 'merged_at': datetime.datetime(2020, 3, 30, 15, 7, 59)} | As discussed [here](https://fb.workplace.com/groups/225341071639862/permalink/610880869752545/) internally, we are shipping a Profiling build to all FB5 users (as well as all Ads, and some other places). However, on FB5 we only *use* `<Profiler>` for a subset of users. So why do we ship this build to everyone on FB5? B... | {'url': 'https://api.github.com/repos/facebook/react/issues/18419/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18419/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18418 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18418/labels{/name} | https://api.github.com/repos/facebook/react/issues/18418/comments | https://api.github.com/repos/facebook/react/issues/18418/events | https://github.com/facebook/react/issues/18418 | 589,627,818 | MDU6SXNzdWU1ODk2Mjc4MTg= | 18,418 | Bug: useState only (no setState) triggers rerender | {'login': 'frfancha', 'id': 9610263, 'node_id': 'MDQ6VXNlcjk2MTAyNjM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9610263?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/frfancha', 'html_url': 'https://github.com/frfancha', 'followers_url': 'https://api.github.com/users/frfancha/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Your app is running in Strict Mode (check `index.js`). Double rendering any components with Hooks is intentional so you can more easily find issues caused by impure render functions. This only happens in development — you'll get one render in production.",
"That is explicitely stated in the documentation but I h... | 2020-03-28 18:02:48 | 2020-03-28 18:07:45 | 2020-03-28 18:04:27 | NONE | null | null | null | React version: 16.13.1
## Steps To Reproduce
1. create-react-app
2. change App.js to
const App = () => {
console.log("render app");
const [state, setState] = useState();
return <div></div>;
};
## The current behavior
render App happens twice
## The expected behavior
render App happens once, li... | {'url': 'https://api.github.com/repos/facebook/react/issues/18418/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18418/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18417 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18417/labels{/name} | https://api.github.com/repos/facebook/react/issues/18417/comments | https://api.github.com/repos/facebook/react/issues/18417/events | https://github.com/facebook/react/pull/18417 | 589,620,221 | MDExOlB1bGxSZXF1ZXN0Mzk1MTI2MTY5 | 18,417 | Remove Calls to User Timing API | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18417/builds/16770) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-28 17:22:21 | 2022-10-20 15:26:19 | 2020-03-30 23:29:54 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18417', 'html_url': 'https://github.com/facebook/react/pull/18417', 'diff_url': 'https://github.com/facebook/react/pull/18417.diff', 'patch_url': 'https://github.com/facebook/react/pull/18417.patch', 'merged_at': datetime.datetime(2020, 3, 30, 23, 29, 54)} | This removes calls to the User Timing API in development.
There are several reasons why we want to do this.
- **Inaccurate timings.** When we originally added it, we didn't have any profiling tools with React-specific knowledge. So we used what we could. Unfortunately, User Timings API was originally designed for... | {'url': 'https://api.github.com/repos/facebook/react/issues/18417/reactions', 'total_count': 21, '+1': 5, '-1': 3, 'laugh': 0, 'hooray': 0, 'confused': 12, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18417/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18416 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18416/labels{/name} | https://api.github.com/repos/facebook/react/issues/18416/comments | https://api.github.com/repos/facebook/react/issues/18416/events | https://github.com/facebook/react/issues/18416 | 589,609,189 | MDU6SXNzdWU1ODk2MDkxODk= | 18,416 | Bug: dragenter on text node contains parent node in event.target in Firefox | {'login': 'avandecreme', 'id': 465389, 'node_id': 'MDQ6VXNlcjQ2NTM4OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/465389?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/avandecreme', 'html_url': 'https://github.com/avandecreme', 'followers_url': 'https://api.github.com/users/avandecreme/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-03-28 16:21:05 | 2020-12-25 14:07:22 | 2020-12-25 14:07:22 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.13.1
## Steps To Reproduce
Drag a file over text in Fire... | {'url': 'https://api.github.com/repos/facebook/react/issues/18416/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18416/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18415 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18415/labels{/name} | https://api.github.com/repos/facebook/react/issues/18415/comments | https://api.github.com/repos/facebook/react/issues/18415/events | https://github.com/facebook/react/issues/18415 | 589,596,218 | MDU6SXNzdWU1ODk1OTYyMTg= | 18,415 | Issue | {'login': 'nhuhung19', 'id': 56119213, 'node_id': 'MDQ6VXNlcjU2MTE5MjEz', 'avatar_url': 'https://avatars.githubusercontent.com/u/56119213?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nhuhung19', 'html_url': 'https://github.com/nhuhung19', 'followers_url': 'https://api.github.com/users/nhuhung19/followe... | [] | closed | false | null | [] | null | [
"This isn't very descriptive."
] | 2020-03-28 15:17:45 | 2020-03-28 17:36:41 | 2020-03-28 17:36:41 | NONE | null | null | null | I have issue | {'url': 'https://api.github.com/repos/facebook/react/issues/18415/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18415/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18414 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18414/labels{/name} | https://api.github.com/repos/facebook/react/issues/18414/comments | https://api.github.com/repos/facebook/react/issues/18414/events | https://github.com/facebook/react/issues/18414 | 589,576,878 | MDU6SXNzdWU1ODk1NzY4Nzg= | 18,414 | BrowserRouter and HashRouter works for three Routes only | {'login': 'ashutosh1919', 'id': 20843596, 'node_id': 'MDQ6VXNlcjIwODQzNTk2', 'avatar_url': 'https://avatars.githubusercontent.com/u/20843596?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ashutosh1919', 'html_url': 'https://github.com/ashutosh1919', 'followers_url': 'https://api.github.com/users/ashutosh... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"React Router has no relation to React. It is a third party project. Please check out Community resources on our website for good places to ask for help. We try to keep this tracker focused on bugs in React itself. "
] | 2020-03-28 13:24:25 | 2020-03-28 13:37:54 | 2020-03-28 13:37:54 | NONE | null | null | null | ## Steps To Reproduce
You can visit [this github project](https://github.com/ashutosh1919/masterPortfolio). On the top of it, you can also see link of the currently deployed version.
Now, in the NavBar, you can see 7 options.
Home, Education, Experience, Projects, Opensource, Blogs, Contact Me.
Among which I ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18414/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18414/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18413 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18413/labels{/name} | https://api.github.com/repos/facebook/react/issues/18413/comments | https://api.github.com/repos/facebook/react/issues/18413/events | https://github.com/facebook/react/issues/18413 | 589,559,997 | MDU6SXNzdWU1ODk1NTk5OTc= | 18,413 | Devtools: Allow editing context | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 121709921, 'node_id': 'MDU6TGFiZWwxMjE3MDk5MjE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Feature%20Request', 'name': 'Type: Feature Request', 'color': 'c7def8', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github... | open | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-03-28 11:37:38 | 2022-03-05 12:21:35 | null | COLLABORATOR | null | null | null | React version: 16.13 and `0.0.0-experimental-aae83a4b9
## Steps To Reproduce
1. Goto https://codesandbox.io/s/xenodochial-field-rfdjz
2. Try editing value of `MessageListContext.Provider`
Link to code example: https://codesandbox.io/s/xenodochial-field-rfdjz
## The current behavior
Context from `createC... | {'url': 'https://api.github.com/repos/facebook/react/issues/18413/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18413/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/18412 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18412/labels{/name} | https://api.github.com/repos/facebook/react/issues/18412/comments | https://api.github.com/repos/facebook/react/issues/18412/events | https://github.com/facebook/react/pull/18412 | 589,521,716 | MDExOlB1bGxSZXF1ZXN0Mzk1MDU2NDEw | 18,412 | Reset lastEffect when resuming SuspenseList | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18412/builds/16733) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-28 06:49:06 | 2020-03-29 20:55:31 | 2020-03-29 17:13:18 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18412', 'html_url': 'https://github.com/facebook/react/pull/18412', 'diff_url': 'https://github.com/facebook/react/pull/18412.diff', 'patch_url': 'https://github.com/facebook/react/pull/18412.patch', 'merged_at': datetime.datetime(2020, 3, 29, 17, 13, 18)} | We store an effect pointer so we can backtrack in the effect list in some cases. This is a stateful variable. If we interrupt a render we need to reset it.
This field was added after the optimization was added and I didn't remember to reset it here.
Otherwise we end up not resetting the firstEffect so it points t... | {'url': 'https://api.github.com/repos/facebook/react/issues/18412/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18412/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18411 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18411/labels{/name} | https://api.github.com/repos/facebook/react/issues/18411/comments | https://api.github.com/repos/facebook/react/issues/18411/events | https://github.com/facebook/react/pull/18411 | 589,449,894 | MDExOlB1bGxSZXF1ZXN0Mzk1MDAwMTMw | 18,411 | Bugfix: Do not unhide a suspended tree without finishing the suspended update | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18411/builds/17098) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-27 22:49:11 | 2020-03-30 18:25:05 | 2020-03-30 18:25:05 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18411', 'html_url': 'https://github.com/facebook/react/pull/18411', 'diff_url': 'https://github.com/facebook/react/pull/18411.diff', 'patch_url': 'https://github.com/facebook/react/pull/18411.patch', 'merged_at': datetime.datetime(2020, 3, 30, 18, 25, 5)} | Fixes https://github.com/facebook/react/issues/18357
When we commit a fallback, we cannot unhide the content without including the level that originally suspended. That's because the work at level outside the boundary (i.e. everything that wasn't hidden during that render) already committed. | {'url': 'https://api.github.com/repos/facebook/react/issues/18411/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18411/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18410 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18410/labels{/name} | https://api.github.com/repos/facebook/react/issues/18410/comments | https://api.github.com/repos/facebook/react/issues/18410/events | https://github.com/facebook/react/issues/18410 | 589,437,517 | MDU6SXNzdWU1ODk0Mzc1MTc= | 18,410 | Bug: ncu(node-check-updates) shows many dependencies needing update, some major | {'login': 'abnud1', 'id': 12657077, 'node_id': 'MDQ6VXNlcjEyNjU3MDc3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12657077?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/abnud1', 'html_url': 'https://github.com/abnud1', 'followers_url': 'https://api.github.com/users/abnud1/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Sure, happy to take PRs. I’ll close the issue because this isn’t a problem and will always keep happening in cycles. "
] | 2020-03-27 22:10:04 | 2020-03-28 13:38:49 | 2020-03-28 13:38:49 | NONE | null | null | null | this is ncu output in package.json currently in react master:
>
> @babel/cli ^7.8.0 → ^7.8.4
> @babel/code-frame ^7.8.0 → ^7.8.3
> @babel/core ^7.8.0 → ^7.9.0... | {'url': 'https://api.github.com/repos/facebook/react/issues/18410/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18410/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18409 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18409/labels{/name} | https://api.github.com/repos/facebook/react/issues/18409/comments | https://api.github.com/repos/facebook/react/issues/18409/events | https://github.com/facebook/react/pull/18409 | 589,405,091 | MDExOlB1bGxSZXF1ZXN0Mzk0OTYzMTMw | 18,409 | Don't show destroy function state update warning when updating ancestors | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18409/builds/16769) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-27 20:47:59 | 2020-03-28 17:18:17 | 2020-03-28 17:18:14 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18409', 'html_url': 'https://github.com/facebook/react/pull/18409', 'diff_url': 'https://github.com/facebook/react/pull/18409.diff', 'patch_url': 'https://github.com/facebook/react/pull/18409.patch', 'merged_at': datetime.datetime(2020, 3, 28, 17, 18, 14)} | React can't directly detect a memory leak, but there are some clues that warn about one. One of these clues is when an unmounted React component tries to update its state. For example, if a component forgets to remove an event listener when unmounting, that listener may be called later and try to update state, at which... | {'url': 'https://api.github.com/repos/facebook/react/issues/18409/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18409/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18408 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18408/labels{/name} | https://api.github.com/repos/facebook/react/issues/18408/comments | https://api.github.com/repos/facebook/react/issues/18408/events | https://github.com/facebook/react/issues/18408 | 589,390,602 | MDU6SXNzdWU1ODkzOTA2MDI= | 18,408 | Bug: useEffect does not fired when an action dispatched. | {'login': 'slim-hmidi', 'id': 31925861, 'node_id': 'MDQ6VXNlcjMxOTI1ODYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/31925861?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/slim-hmidi', 'html_url': 'https://github.com/slim-hmidi', 'followers_url': 'https://api.github.com/users/slim-hmidi/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is a lot of code. If you think it's a bug in React, please create a minimal reproducing case we can try when filing a bug. You'll also need to exclude libraries like Redux from your example."
] | 2020-03-27 20:16:04 | 2020-03-30 15:23:25 | 2020-03-30 15:23:24 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
I have 2 table components in in the same page: Resolved Cases ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18408/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18408/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18407 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18407/labels{/name} | https://api.github.com/repos/facebook/react/issues/18407/comments | https://api.github.com/repos/facebook/react/issues/18407/events | https://github.com/facebook/react/pull/18407 | 589,335,746 | MDExOlB1bGxSZXF1ZXN0Mzk0OTE3NTYz | 18,407 | Move accumulateEventTargetListeners to its own module/function | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18407/builds/17441) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-27 18:50:22 | 2020-04-01 13:19:25 | 2020-04-01 13:19:22 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18407', 'html_url': 'https://github.com/facebook/react/pull/18407', 'diff_url': 'https://github.com/facebook/react/pull/18407.diff', 'patch_url': 'https://github.com/facebook/react/pull/18407.patch', 'merged_at': datetime.datetime(2020, 4, 1, 13, 19, 22)} | The logic for `accumulateEventTargetListeners` should really be in its own function/module and not coupled up in the `accumulateTwoPhaseListeners` logic – making it all much easier to follow. | {'url': 'https://api.github.com/repos/facebook/react/issues/18407/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18407/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18406 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18406/labels{/name} | https://api.github.com/repos/facebook/react/issues/18406/comments | https://api.github.com/repos/facebook/react/issues/18406/events | https://github.com/facebook/react/issues/18406 | 589,320,750 | MDU6SXNzdWU1ODkzMjA3NTA= | 18,406 | Bug: App crashed a message to report a bug prompted | {'login': 'arualana', 'id': 46368248, 'node_id': 'MDQ6VXNlcjQ2MzY4MjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/46368248?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/arualana', 'html_url': 'https://github.com/arualana', 'followers_url': 'https://api.github.com/users/arualana/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is not related to React."
] | 2020-03-27 18:21:44 | 2020-03-30 15:19:28 | 2020-03-30 15:19:27 | NONE | null | null | null | I copy and paste here the report.json autogenerated
```json
{
"header": {
"reportVersion": 1,
"event": "Allocation failed - JavaScript heap out of memory",
"trigger": "FatalError",
"filename": "report.20200310.170750.11804.0.001.json",
"dumpEventTime": "2020-03-10T17:07:50Z",
"dumpE... | {'url': 'https://api.github.com/repos/facebook/react/issues/18406/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18406/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18405 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18405/labels{/name} | https://api.github.com/repos/facebook/react/issues/18405/comments | https://api.github.com/repos/facebook/react/issues/18405/events | https://github.com/facebook/react/pull/18405 | 589,278,817 | MDExOlB1bGxSZXF1ZXN0Mzk0ODczMjQ3 | 18,405 | Refactor Enter/Leave listener accumulation | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18405/builds/17447) or the icon next to each commit SHA.",
"\n<!--\n 0 failure: \n 1 warning: Could not... | 2020-03-27 17:09:50 | 2020-04-02 10:07:24 | 2020-04-02 10:07:21 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18405', 'html_url': 'https://github.com/facebook/react/pull/18405', 'diff_url': 'https://github.com/facebook/react/pull/18405.diff', 'patch_url': 'https://github.com/facebook/react/pull/18405.patch', 'merged_at': datetime.datetime(2020, 4, 2, 10, 7, 21)} | We already cleaned up and refactored two phase event accumulation in a previous PR, this PR cleans up and refactors the Enter/Leave logic so it's easier to follow and adapt for future work where we can refactor how events are accumulated and ties to synthetic events. This should also have a slight runtime performance w... | {'url': 'https://api.github.com/repos/facebook/react/issues/18405/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18405/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18404 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18404/labels{/name} | https://api.github.com/repos/facebook/react/issues/18404/comments | https://api.github.com/repos/facebook/react/issues/18404/events | https://github.com/facebook/react/issues/18404 | 589,094,148 | MDU6SXNzdWU1ODkwOTQxNDg= | 18,404 | Bug: cursor jumps to end of controlled <input> tag when value is modified | {'login': 'iain-merrick-fanduel', 'id': 41625936, 'node_id': 'MDQ6VXNlcjQxNjI1OTM2', 'avatar_url': 'https://avatars.githubusercontent.com/u/41625936?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/iain-merrick-fanduel', 'html_url': 'https://github.com/iain-merrick-fanduel', 'followers_url': 'https://api.g... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is very similar to https://github.com/facebook/react/issues/14904, but doesn't look quite the same:\r\n- I'm updating the value locally, in the same component\r\n- I'm modifying the value\r\n\r\nIn case this is browser-specific, I'm using Chrome 80 on OS X 10.14.6.",
"As far as I know, this is the intended ... | 2020-03-27 12:17:28 | 2024-01-10 13:15:27 | 2020-04-01 23:29:13 | NONE | null | null | null | React version: 16.13.1
## Steps To Reproduce
1. Make an `<input>` tag controlled, by setting its `value` in response to `onChange`
2. Apply a transformation to the value (for example, replace spaces with underscores)
3. Move cursor to the middle of the text and edit it
Link to code example:
https://gist.g... | {'url': 'https://api.github.com/repos/facebook/react/issues/18404/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18404/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18403 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18403/labels{/name} | https://api.github.com/repos/facebook/react/issues/18403/comments | https://api.github.com/repos/facebook/react/issues/18403/events | https://github.com/facebook/react/issues/18403 | 589,079,413 | MDU6SXNzdWU1ODkwNzk0MTM= | 18,403 | Is it a sufficient way to find lowest common ancestor? | {'login': 'squarezw', 'id': 239963, 'node_id': 'MDQ6VXNlcjIzOTk2Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/239963?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/squarezw', 'html_url': 'https://github.com/squarezw', 'followers_url': 'https://api.github.com/users/squarezw/followers', 'fo... | [] | closed | false | null | [] | null | [] | 2020-03-27 11:50:14 | 2020-03-27 12:00:36 | 2020-03-27 12:00:36 | NONE | null | null | null | https://github.com/facebook/react/blob/b779dd51e87b92e13001b5deac4887bb4984ecf2/packages/react-reconciler/src/ReactTreeTraversal.js#L29
```
let depthA = 0;
for (let tempA = instA; tempA; tempA = getParent(tempA)) {
depthA++;
}
let depthB = 0;
for (let tempB = instB; tempB; tempB = getParent(tempB))... | {'url': 'https://api.github.com/repos/facebook/react/issues/18403/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18403/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18402 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18402/labels{/name} | https://api.github.com/repos/facebook/react/issues/18402/comments | https://api.github.com/repos/facebook/react/issues/18402/events | https://github.com/facebook/react/issues/18402 | 589,059,162 | MDU6SXNzdWU1ODkwNTkxNjI= | 18,402 | Batching makes it difficult to perform imperative actions like focus | {'login': 'astoilkov', 'id': 884810, 'node_id': 'MDQ6VXNlcjg4NDgxMA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/884810?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/astoilkov', 'html_url': 'https://github.com/astoilkov', 'followers_url': 'https://api.github.com/users/astoilkov/followers',... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}] | open | false | null | [] | null | [
"I started wondering if [RFCs for changes to React](https://github.com/reactjs/rfcs) isn't a better place to write this issue. Let me know if you agree and I will close this one and write one there.",
"If anything, we are going to _batch more_ by default, not batch less. Batching is important for multiple reasons... | 2020-03-27 11:12:19 | 2022-04-27 09:06:58 | null | NONE | null | null | null | React version: 16.9.5
## Steps To Reproduce
1. Overwrite batched updates with the following code: `ReactDOM.unstable_batchedUpdates = callback => callback()`
2. Batched updates aren't actually overwritten.
## Reasoning
I recognize that this may not be classified as bug because it isn't a documented feature... | {'url': 'https://api.github.com/repos/facebook/react/issues/18402/reactions', 'total_count': 8, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 3} | https://api.github.com/repos/facebook/react/issues/18402/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/18401 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18401/labels{/name} | https://api.github.com/repos/facebook/react/issues/18401/comments | https://api.github.com/repos/facebook/react/issues/18401/events | https://github.com/facebook/react/pull/18401 | 589,005,260 | MDExOlB1bGxSZXF1ZXN0Mzk0NjQ3MTYy | 18,401 | Rules of hooks ignore list | {'login': 'OlafMerkert', 'id': 537218, 'node_id': 'MDQ6VXNlcjUzNzIxOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/537218?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/OlafMerkert', 'html_url': 'https://github.com/OlafMerkert', 'followers_url': 'https://api.github.com/users/OlafMerkert/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18401/builds/16557) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-27 09:36:46 | 2020-03-30 13:37:36 | 2020-03-28 14:54:54 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18401', 'html_url': 'https://github.com/facebook/react/pull/18401', 'diff_url': 'https://github.com/facebook/react/pull/18401.diff', 'patch_url': 'https://github.com/facebook/react/pull/18401.patch', 'merged_at': None} | ## Summary
For historic reasons, our project contains a couple of very widely used functions with names that the heuristics of the `rules-of-hooks` linter rule falsely consider to be hooks.
- Renaming these functions could be an alternative option, but would incur the cost of a major breaking change in our projec... | {'url': 'https://api.github.com/repos/facebook/react/issues/18401/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18401/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18400 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18400/labels{/name} | https://api.github.com/repos/facebook/react/issues/18400/comments | https://api.github.com/repos/facebook/react/issues/18400/events | https://github.com/facebook/react/issues/18400 | 588,689,194 | MDU6SXNzdWU1ODg2ODkxOTQ= | 18,400 | Bug: no-unused-vars warning thrown for createRef import despite use | {'login': 'PixelPotts', 'id': 2292554, 'node_id': 'MDQ6VXNlcjIyOTI1NTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2292554?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/PixelPotts', 'html_url': 'https://github.com/PixelPotts', 'followers_url': 'https://api.github.com/users/PixelPotts/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Are you sure you’re looking at the right file? Regardless, this doesn’t have anything to do with react, and should probably be filed at eslint/issues",
"The CodeSandbox link doesn't point to an example of this.",
"If you get this with Create React App, please file an issue here: https://github.com/facebook/cre... | 2020-03-26 19:57:49 | 2020-03-26 21:36:03 | 2020-03-26 21:36:03 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
 => {
switch (action.type) {
case 'INPUT_CHANGE':
let formIsValid = true;
for (const inputId in state.inputs) {
if (inputId === action.inputId) {
formIsValid = formIsValid && action.isValid;
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18399/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18399/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18398 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18398/labels{/name} | https://api.github.com/repos/facebook/react/issues/18398/comments | https://api.github.com/repos/facebook/react/issues/18398/events | https://github.com/facebook/react/issues/18398 | 588,608,261 | MDU6SXNzdWU1ODg2MDgyNjE= | 18,398 | Error: "Could not find commit data for root "220" and commit 65" | {'login': 'georeith', 'id': 3090066, 'node_id': 'MDQ6VXNlcjMwOTAwNjY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3090066?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/georeith', 'html_url': 'https://github.com/georeith', 'followers_url': 'https://api.github.com/users/georeith/followers', '... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/la... | closed | false | null | [] | null | [
"Thanks for the report, but this issue is already been tracked as #18010 :smile:"
] | 2020-03-26 17:48:11 | 2020-03-27 16:59:17 | 2020-03-27 16:59:07 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. Changing root of Flamegraph from a React one to https://github.com/michalochman/react-pixi-fiber

---------------------------------------------
Pl... | {'url': 'https://api.github.com/repos/facebook/react/issues/18398/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18398/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18397 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18397/labels{/name} | https://api.github.com/repos/facebook/react/issues/18397/comments | https://api.github.com/repos/facebook/react/issues/18397/events | https://github.com/facebook/react/pull/18397 | 588,546,412 | MDExOlB1bGxSZXF1ZXN0Mzk0MjcyNzkx | 18,397 | Remove "es6-symbol" package from DevTools | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against c8bd782d7c39b3639b32790... | 2020-03-26 16:19:28 | 2020-03-26 20:21:41 | 2020-03-26 16:31:36 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18397', 'html_url': 'https://github.com/facebook/react/pull/18397', 'diff_url': 'https://github.com/facebook/react/pull/18397.diff', 'patch_url': 'https://github.com/facebook/react/pull/18397.patch', 'merged_at': datetime.datetime(2020, 3, 26, 16, 31, 36)} | This polyfill was copied over from DevTools v3 but given the [current browser compatibility for `Symbol`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol#Browser_compatibility), I think it's safe to remove.
This will also reduce the size on disk for `react-devtools-inline`- si... | {'url': 'https://api.github.com/repos/facebook/react/issues/18397/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18397/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18396 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18396/labels{/name} | https://api.github.com/repos/facebook/react/issues/18396/comments | https://api.github.com/repos/facebook/react/issues/18396/events | https://github.com/facebook/react/issues/18396 | 588,518,898 | MDU6SXNzdWU1ODg1MTg4OTg= | 18,396 | [eslint-plugin-react-hooks] Exhaustive deps requires a dispatch function from useReducer to be included in dependencies | {'login': 'maxijonson', 'id': 23557893, 'node_id': 'MDQ6VXNlcjIzNTU3ODkz', 'avatar_url': 'https://avatars.githubusercontent.com/u/23557893?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/maxijonson', 'html_url': 'https://github.com/maxijonson', 'followers_url': 'https://api.github.com/users/maxijonson/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is intentional because a linter can only verify so much statically.\r\n\r\nThere's no harm to passing this function if it's truly stable."
] | 2020-03-26 15:42:03 | 2020-03-30 15:18:08 | 2020-03-30 15:18:08 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
The eslint-plugin-react-hooks does not seem to recognize the dispatch function f... | {'url': 'https://api.github.com/repos/facebook/react/issues/18396/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18396/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18395 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18395/labels{/name} | https://api.github.com/repos/facebook/react/issues/18395/comments | https://api.github.com/repos/facebook/react/issues/18395/events | https://github.com/facebook/react/pull/18395 | 588,371,344 | MDExOlB1bGxSZXF1ZXN0Mzk0MTI5Nzc1 | 18,395 | ReactDOM.useEvent: enable on internal www and add inspection test | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: a16b34974508cd23ce0844ad09a0e37a879d5591...178b05798d6bc3edf4bed4d85d9f4e7bca567dec</p>\n\n\n \n## react-dom\nFile | Fi... | 2020-03-26 12:07:08 | 2020-03-26 17:13:10 | 2020-03-26 17:13:06 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18395', 'html_url': 'https://github.com/facebook/react/pull/18395', 'diff_url': 'https://github.com/facebook/react/pull/18395.diff', 'patch_url': 'https://github.com/facebook/react/pull/18395.patch', 'merged_at': datetime.datetime(2020, 3, 26, 17, 13, 6)} | This PR adds an inspection Jest test and also enables the `enableUseEventAPI` for internal FB www usage. This also fixes a small compatibility issue with `beforeblur` and React Flare, that meant we were previously incorrectly listening for a native `beforeblur` event to fire on the DOM. We shouldn't be listening for a ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18395/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18395/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18394 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18394/labels{/name} | https://api.github.com/repos/facebook/react/issues/18394/comments | https://api.github.com/repos/facebook/react/issues/18394/events | https://github.com/facebook/react/issues/18394 | 588,209,232 | MDU6SXNzdWU1ODgyMDkyMzI= | 18,394 | Bug: unnecessary scrollbars in React Developer Tools. | {'login': 'infinnie', 'id': 8168391, 'node_id': 'MDQ6VXNlcjgxNjgzOTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8168391?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/infinnie', 'html_url': 'https://github.com/infinnie', 'followers_url': 'https://api.github.com/users/infinnie/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Hi Infinnie, [version 4.6.0 was released last week](https://github.com/facebook/react/blob/master/packages/react-devtools/CHANGELOG.md#460-march-26-2020), could you try updating and see if this fixes the issue you're seeing?\r\n\r\nWith the new version I can't reproduce the issue:\r\n\r\n} | I wasn't sure we needed this but looks like it'll be necessary.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18393/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18393/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18392 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18392/labels{/name} | https://api.github.com/repos/facebook/react/issues/18392/comments | https://api.github.com/repos/facebook/react/issues/18392/events | https://github.com/facebook/react/pull/18392 | 588,089,622 | MDExOlB1bGxSZXF1ZXN0MzkzOTA2NTcx | 18,392 | [Flight] Add server-runtime to create Server Blocks | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 64ed221c3dd44601d043236479150ac6ccf2a858...89e8c3d2f4e1db23f9b64a1b1404da5d1242d30f</p>\n\n\n \n## react-flight-dom-relay\nFi... | 2020-03-26 01:26:19 | 2020-03-26 02:03:32 | 2020-03-26 02:03:32 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18392', 'html_url': 'https://github.com/facebook/react/pull/18392', 'diff_url': 'https://github.com/facebook/react/pull/18392.diff', 'patch_url': 'https://github.com/facebook/react/pull/18392.patch', 'merged_at': datetime.datetime(2020, 3, 26, 2, 3, 32)} | This is equivalent to the jsx-runtime in that this is what the compiled output on the server is supposed to target.
It's really just the same code for all the different Flights, but they have different types in their arguments so each one gets their own entry point. We might use this to add runtime warnings per entr... | {'url': 'https://api.github.com/repos/facebook/react/issues/18392/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18392/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18391 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18391/labels{/name} | https://api.github.com/repos/facebook/react/issues/18391/comments | https://api.github.com/repos/facebook/react/issues/18391/events | https://github.com/facebook/react/pull/18391 | 588,026,564 | MDExOlB1bGxSZXF1ZXN0MzkzODU3MDUx | 18,391 | Formalize the Wakeable and Thenable types | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: a6924d77b10dcf4108f5ffdfd37078b0864c57d5...a910e621a1a4c17ea39146f9647b27ab86fa143e</p>\n\n\n \n## react-flight-dom-webpack\n... | 2020-03-25 22:22:23 | 2020-03-25 23:52:08 | 2020-03-25 23:49:38 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18391', 'html_url': 'https://github.com/facebook/react/pull/18391', 'diff_url': 'https://github.com/facebook/react/pull/18391.diff', 'patch_url': 'https://github.com/facebook/react/pull/18391.patch', 'merged_at': datetime.datetime(2020, 3, 25, 23, 49, 38)} | We use two subsets of Promises throughout React APIs. This introduces the smallest subset - Wakeable. It's the thing that you can throw to suspend. It's something that can ping.
I also use a shared type for Thenable in the cases where we expect a value so we can be a bit more rigid with our us of them.
I also mad... | {'url': 'https://api.github.com/repos/facebook/react/issues/18391/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18391/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18390 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18390/labels{/name} | https://api.github.com/repos/facebook/react/issues/18390/comments | https://api.github.com/repos/facebook/react/issues/18390/events | https://github.com/facebook/react/issues/18390 | 588,020,866 | MDU6SXNzdWU1ODgwMjA4NjY= | 18,390 | Bug: Event handlers on custom elements work on the client but not on the server | {'login': 'esprehn', 'id': 415779, 'node_id': 'MDQ6VXNlcjQxNTc3OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/415779?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/esprehn', 'html_url': 'https://github.com/esprehn', 'followers_url': 'https://api.github.com/users/esprehn/followers', 'follow... | [{'id': 710332294, 'node_id': 'MDU6TGFiZWw3MTAzMzIyOTQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Server%20Rendering', 'name': 'Component: Server Rendering', 'color': 'd4c5f9', 'default': False, 'description': None}
{'id': 710722093, 'node_id': 'MDU6TGFiZWw3MTA3MjIwOTM=', 'url': 'https:... | open | false | null | [] | null | [
"Specifically on SSR renderToString produces:\r\n\r\n```\r\n<div-x onClick=\"() => console.log('clicked')\" data-reactroot=\"\">Click me</div-x>\r\n```\r\n\r\nbut onClick works fine in a client render.\r\n\r\nThis seems to be the result of this check:\r\nhttps://github.com/facebook/react/blob/e0ab1a429... | 2020-03-25 22:09:40 | 2022-05-12 15:43:13 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.13.1
## Steps To Reproduce
```js
ReactDOMServer.renderT... | {'url': 'https://api.github.com/repos/facebook/react/issues/18390/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18390/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/18389 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18389/labels{/name} | https://api.github.com/repos/facebook/react/issues/18389/comments | https://api.github.com/repos/facebook/react/issues/18389/events | https://github.com/facebook/react/issues/18389 | 588,012,315 | MDU6SXNzdWU1ODgwMTIzMTU= | 18,389 | Bug: NotFoundError: Node was not found | {'login': 'krishnaTORQUE', 'id': 4960568, 'node_id': 'MDQ6VXNlcjQ5NjA1Njg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4960568?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/krishnaTORQUE', 'html_url': 'https://github.com/krishnaTORQUE', 'followers_url': 'https://api.github.com/users/krishna... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"It's not clear without a small reproduction on either codesandbox, or as a git repo, what the issue actually is. Please share a reproducible example. \r\n\r\nPlease also test by disabling browser extensions, as React doesn't behave well with extensions that change the dom invasively. ",
"Too little information"... | 2020-03-25 21:50:07 | 2020-07-13 22:31:50 | 2020-03-30 15:19:48 | NONE | null | null | null | React version: 16.13.1
After update react getting crash on production everytime. in local development its crashing but not all time.
Error getting in development :
NotFoundError: Node was not found
Error getting in production:
Uncaught (in promise) DOMException: Failed to execute 'removeChild' on 'Node': The... | {'url': 'https://api.github.com/repos/facebook/react/issues/18389/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18389/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18388 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18388/labels{/name} | https://api.github.com/repos/facebook/react/issues/18388/comments | https://api.github.com/repos/facebook/react/issues/18388/events | https://github.com/facebook/react/pull/18388 | 587,871,278 | MDExOlB1bGxSZXF1ZXN0MzkzNzI5NjUy | 18,388 | Add getInspectorDataForViewAtPoint (take two) | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 2ba43edc2675380a0f2222f351475bf9d750c6a9...f52c6e1fa5b80130660a3ad287c5a4ef3e6ea6f2</p>\n\n\n \n## react-native-rendere... | 2020-03-25 17:38:13 | 2020-03-30 19:42:48 | 2020-03-30 19:42:42 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18388', 'html_url': 'https://github.com/facebook/react/pull/18388', 'diff_url': 'https://github.com/facebook/react/pull/18388.diff', 'patch_url': 'https://github.com/facebook/react/pull/18388.patch', 'merged_at': datetime.datetime(2020, 3, 30, 19, 42, 42)} | ## Summary
**This PR relands https://github.com/facebook/react/pull/18233 with feedback applied.**
- Adds `rendererConfig` to the DevTool config for renderer-specific dev functions.
- Moves `getInspectorDataForViewTag` to `rendererConfig` for React Native only.
- Add `getInspectorDataForViewAtPoint` to the Reac... | {'url': 'https://api.github.com/repos/facebook/react/issues/18388/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18388/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18387 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18387/labels{/name} | https://api.github.com/repos/facebook/react/issues/18387/comments | https://api.github.com/repos/facebook/react/issues/18387/events | https://github.com/facebook/react/pull/18387 | 587,556,117 | MDExOlB1bGxSZXF1ZXN0MzkzNDc0NDgx | 18,387 | [Not for Merge] Revert "Rename internal fields" | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against cbae955d80d... | 2020-03-25 09:23:12 | 2022-11-29 22:20:59 | 2020-03-25 11:34:11 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/18387', 'html_url': 'https://github.com/facebook/react/pull/18387', 'diff_url': 'https://github.com/facebook/react/pull/18387.diff', 'patch_url': 'https://github.com/facebook/react/pull/18387.patch', 'merged_at': None} | Reverts facebook/react#18377
This is to separate it from a sync | {'url': 'https://api.github.com/repos/facebook/react/issues/18387/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18387/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18386 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18386/labels{/name} | https://api.github.com/repos/facebook/react/issues/18386/comments | https://api.github.com/repos/facebook/react/issues/18386/events | https://github.com/facebook/react/pull/18386 | 587,544,536 | MDExOlB1bGxSZXF1ZXN0MzkzNDY1Mjg5 | 18,386 | feat(createContext): Include displayName in warning | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b2f5d374e9c... | 2020-03-25 09:02:21 | 2020-04-01 19:04:10 | 2020-04-01 18:42:39 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18386', 'html_url': 'https://github.com/facebook/react/pull/18386', 'diff_url': 'https://github.com/facebook/react/pull/18386.diff', 'patch_url': 'https://github.com/facebook/react/pull/18386.patch', 'merged_at': datetime.datetime(2020, 4, 1, 18, 42, 39)} | ## Summary
[Seems like this is not only used internally at facebook](https://twitter.com/kentcdodds/status/1242678976645959681). I included the `displayName` that should be set when warning to make it more obvious where the warning is coming from.
This also explicitly documents the strategy by which this warning ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18386/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18386/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18385 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18385/labels{/name} | https://api.github.com/repos/facebook/react/issues/18385/comments | https://api.github.com/repos/facebook/react/issues/18385/events | https://github.com/facebook/react/issues/18385 | 587,473,969 | MDU6SXNzdWU1ODc0NzM5Njk= | 18,385 | devtools | {'login': 'aswom', 'id': 25630159, 'node_id': 'MDQ6VXNlcjI1NjMwMTU5', 'avatar_url': 'https://avatars.githubusercontent.com/u/25630159?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aswom', 'html_url': 'https://github.com/aswom', 'followers_url': 'https://api.github.com/users/aswom/followers', 'following_... | [] | closed | false | null | [] | null | [] | 2020-03-25 06:32:35 | 2020-03-25 09:27:05 | 2020-03-25 09:27:05 | NONE | null | null | null | 👉 Please follow one of these issue templates:
- https://github.com/facebook/react/issues/new/choose
Note: to keep the backlog clean and actionable, issues may be immediately closed if they do not follow one of the above issue templates.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18385/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18385/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18384 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18384/labels{/name} | https://api.github.com/repos/facebook/react/issues/18384/comments | https://api.github.com/repos/facebook/react/issues/18384/events | https://github.com/facebook/react/pull/18384 | 587,462,231 | MDExOlB1bGxSZXF1ZXN0MzkzMzk5OTc5 | 18,384 | [Bugfix] Dropped updates inside a suspended tree | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: e0ab1a429d178d86e13f073f8451d24033bc1838...ae27d3a61336027e24c862596614a332804ec0b3</p>\n\n\n \n## react-test-renderer\... | 2020-03-25 05:59:15 | 2020-03-26 18:31:42 | 2020-03-26 18:31:41 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18384', 'html_url': 'https://github.com/facebook/react/pull/18384', 'diff_url': 'https://github.com/facebook/react/pull/18384.diff', 'patch_url': 'https://github.com/facebook/react/pull/18384.patch', 'merged_at': datetime.datetime(2020, 3, 26, 18, 31, 41)} | Fixes #18353.
When there are multiple updates at different priority levels inside a suspended subtree, all but the highest priority one is dropped after the highest one suspends.
We do have tests that cover this for updates that originate outside of the Suspense boundary, but not for updates that originate inside... | {'url': 'https://api.github.com/repos/facebook/react/issues/18384/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18384/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18383 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18383/labels{/name} | https://api.github.com/repos/facebook/react/issues/18383/comments | https://api.github.com/repos/facebook/react/issues/18383/events | https://github.com/facebook/react/issues/18383 | 587,407,038 | MDU6SXNzdWU1ODc0MDcwMzg= | 18,383 | Bug: React Lazy Suspense with Errorboundary fails on older devices. | {'login': 'apoorvmote', 'id': 9799239, 'node_id': 'MDQ6VXNlcjk3OTkyMzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9799239?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/apoorvmote', 'html_url': 'https://github.com/apoorvmote', 'followers_url': 'https://api.github.com/users/apoorvmote/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"It doesn't look like this bug report has enough info for one of us to reproduce it.\r\n\r\nPlease provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. Screenshots or videos can also be helpful if they help provide con... | 2020-03-25 02:59:08 | 2020-08-08 09:12:28 | 2020-03-30 15:24:26 | NONE | null | null | null | It is standard React Lazy wrapped with suspense that is wrapped with error boundary.
I tested it on Windows 10 Chrome. It works.
I tested it on iPad Chrome it works.
I tested it on Samsung Galaxy m 30s Chrome it works.
I tested on iPhone SE Chrome it **fails**.
I tested on iPhone 5s Chrome it **fails**.
Al... | {'url': 'https://api.github.com/repos/facebook/react/issues/18383/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18383/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18382 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18382/labels{/name} | https://api.github.com/repos/facebook/react/issues/18382/comments | https://api.github.com/repos/facebook/react/issues/18382/events | https://github.com/facebook/react/pull/18382 | 587,405,455 | MDExOlB1bGxSZXF1ZXN0MzkzMzU1MzIy | 18,382 | [Flight] Change .model getter to .readRoot method | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18382/builds/16489) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-25 02:53:48 | 2020-03-25 18:47:56 | 2020-03-25 18:47:56 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18382', 'html_url': 'https://github.com/facebook/react/pull/18382', 'diff_url': 'https://github.com/facebook/react/pull/18382.diff', 'patch_url': 'https://github.com/facebook/react/pull/18382.patch', 'merged_at': datetime.datetime(2020, 3, 25, 18, 47, 56)} | Originally the idea was to hide all suspending behind getters or proxies. However, this has some issues with perf on hot code like React elements.
It also makes it too easy to accidentally access it the first time in an effect or callback where things aren't allowed to suspend. Making it an explicit method call avoi... | {'url': 'https://api.github.com/repos/facebook/react/issues/18382/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18382/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18381 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18381/labels{/name} | https://api.github.com/repos/facebook/react/issues/18381/comments | https://api.github.com/repos/facebook/react/issues/18381/events | https://github.com/facebook/react/pull/18381 | 587,273,024 | MDExOlB1bGxSZXF1ZXN0MzkzMjUwNjgy | 18,381 | [Not for merge] WWW sync | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18381/builds/16461) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-24 20:54:45 | 2020-03-28 15:11:24 | 2020-03-28 15:11:24 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18381', 'html_url': 'https://github.com/facebook/react/pull/18381', 'diff_url': 'https://github.com/facebook/react/pull/18381.diff', 'patch_url': 'https://github.com/facebook/react/pull/18381.patch', 'merged_at': None} | This includes https://github.com/facebook/react/pull/18380 but doesn't include https://github.com/facebook/react/pull/18377 so that I could still layer it on top. | {'url': 'https://api.github.com/repos/facebook/react/issues/18381/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18381/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18380 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18380/labels{/name} | https://api.github.com/repos/facebook/react/issues/18380/comments | https://api.github.com/repos/facebook/react/issues/18380/events | https://github.com/facebook/react/pull/18380 | 587,268,760 | MDExOlB1bGxSZXF1ZXN0MzkzMjQ3MjQy | 18,380 | Fix a mistake in ReactChildren refactor | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18380/builds/16460) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-24 20:46:29 | 2020-03-25 09:20:51 | 2020-03-25 09:20:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18380', 'html_url': 'https://github.com/facebook/react/pull/18380', 'diff_url': 'https://github.com/facebook/react/pull/18380.diff', 'patch_url': 'https://github.com/facebook/react/pull/18380.patch', 'merged_at': datetime.datetime(2020, 3, 25, 9, 20, 47)} | Of course I broke something in https://github.com/facebook/react/pull/18332. Luckily internal tests caught it.
>"there's probably at least not many bugs." — @sebmarkbage
I changed signature of one of the internal functions, but forgot to adjust the callsite. So there was a missing argument. **The fix for that is ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18380/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18380/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18379 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18379/labels{/name} | https://api.github.com/repos/facebook/react/issues/18379/comments | https://api.github.com/repos/facebook/react/issues/18379/events | https://github.com/facebook/react/pull/18379 | 587,236,215 | MDExOlB1bGxSZXF1ZXN0MzkzMjIwNzkw | 18,379 | Fix email cursor jump | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18379/builds/16450) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-24 19:44:58 | 2020-04-01 21:45:39 | 2020-04-01 18:30:27 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18379', 'html_url': 'https://github.com/facebook/react/pull/18379', 'diff_url': 'https://github.com/facebook/react/pull/18379.diff', 'patch_url': 'https://github.com/facebook/react/pull/18379.patch', 'merged_at': datetime.datetime(2020, 4, 1, 18, 30, 27)} | fix #15418, #14551
Version of React: 16.13.1
Browser: Chrome 80
**Previous behavior:**
After deleting of second email separated by space cursor jumps to the beginning.
When typing a space in an empty email input and then literal, the space is deleted and cursor jumps to the beginning.
.\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18378/builds/16429) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-24 18:19:21 | 2020-03-25 17:26:44 | 2020-03-25 17:26:41 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18378', 'html_url': 'https://github.com/facebook/react/pull/18378', 'diff_url': 'https://github.com/facebook/react/pull/18378.diff', 'patch_url': 'https://github.com/facebook/react/pull/18378.patch', 'merged_at': datetime.datetime(2020, 3, 25, 17, 26, 41)} | DevTools previously used the NPM [`events` package](https://www.npmjs.com/package/events) for dispatching events. This package has an unfortunate flaw though- if a listener throws during event dispatch, no subsequent listeners are called. I've replaced that event dispatcher with my own implementation that ensures all l... | {'url': 'https://api.github.com/repos/facebook/react/issues/18378/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18378/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18377 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18377/labels{/name} | https://api.github.com/repos/facebook/react/issues/18377/comments | https://api.github.com/repos/facebook/react/issues/18377/events | https://github.com/facebook/react/pull/18377 | 587,140,345 | MDExOlB1bGxSZXF1ZXN0MzkzMTQwOTU4 | 18,377 | Rename internal fields | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18377/builds/16413) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-24 17:24:03 | 2020-03-25 09:22:49 | 2020-03-24 18:19:21 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18377', 'html_url': 'https://github.com/facebook/react/pull/18377', 'diff_url': 'https://github.com/facebook/react/pull/18377.diff', 'patch_url': 'https://github.com/facebook/react/pull/18377.patch', 'merged_at': datetime.datetime(2020, 3, 24, 18, 19, 21)} | Resubmit of https://github.com/facebook/react/pull/17798. | {'url': 'https://api.github.com/repos/facebook/react/issues/18377/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18377/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18376 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18376/labels{/name} | https://api.github.com/repos/facebook/react/issues/18376/comments | https://api.github.com/repos/facebook/react/issues/18376/events | https://github.com/facebook/react/pull/18376 | 587,125,829 | MDExOlB1bGxSZXF1ZXN0MzkzMTI4Njkw | 18,376 | Downgrade Jest to 24 | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Not sure it's going to be that easy due to jsdom changes. The upgrade was rather involved: https://github.com/facebook/react/pull/17896.",
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesa... | 2020-03-24 17:05:57 | 2020-04-03 07:52:07 | 2020-03-24 17:51:49 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18376', 'html_url': 'https://github.com/facebook/react/pull/18376', 'diff_url': 'https://github.com/facebook/react/pull/18376.diff', 'patch_url': 'https://github.com/facebook/react/pull/18376.patch', 'merged_at': datetime.datetime(2020, 3, 24, 17, 51, 49)} | There's a bug where `toEqual` throws when comparing readonly properties, which affects our JSX matchers.
https://github.com/facebook/jest/pull/9575
The bug is fixed in master, but not yet released.
Until then, downgrading to 24. | {'url': 'https://api.github.com/repos/facebook/react/issues/18376/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18376/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18375 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18375/labels{/name} | https://api.github.com/repos/facebook/react/issues/18375/comments | https://api.github.com/repos/facebook/react/issues/18375/events | https://github.com/facebook/react/pull/18375 | 586,920,686 | MDExOlB1bGxSZXF1ZXN0MzkyOTU4Nzc5 | 18,375 | ReactDOM.useEvent: Add support for experimental scopes API | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18375/builds/16392) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-24 12:22:50 | 2020-03-31 14:20:36 | 2020-03-26 13:29:55 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18375', 'html_url': 'https://github.com/facebook/react/pull/18375', 'diff_url': 'https://github.com/facebook/react/pull/18375.diff', 'patch_url': 'https://github.com/facebook/react/pull/18375.patch', 'merged_at': datetime.datetime(2020, 3, 26, 13, 29, 55)} | This is the last big piece of the `useEvent` API puzzle. It ports the existing behavior in React Flare, where you can attach listeners to the experimental Scopes API. This means that with `useEvent` you can attach events to a "scope" rather than a physical `EventTarget`, making way for us to be able to port the interna... | {'url': 'https://api.github.com/repos/facebook/react/issues/18375/reactions', 'total_count': 12, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 5, 'confused': 0, 'heart': 2, 'rocket': 3, 'eyes': 2} | https://api.github.com/repos/facebook/react/issues/18375/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18374 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18374/labels{/name} | https://api.github.com/repos/facebook/react/issues/18374/comments | https://api.github.com/repos/facebook/react/issues/18374/events | https://github.com/facebook/react/pull/18374 | 586,647,249 | MDExOlB1bGxSZXF1ZXN0MzkyNzQyMTI2 | 18,374 | Flip the arguments of Blocks and make the query optional | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18374/builds/16281) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-24 02:35:20 | 2020-03-24 17:58:24 | 2020-03-24 17:58:23 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18374', 'html_url': 'https://github.com/facebook/react/pull/18374', 'diff_url': 'https://github.com/facebook/react/pull/18374.diff', 'patch_url': 'https://github.com/facebook/react/pull/18374.patch', 'merged_at': datetime.datetime(2020, 3, 24, 17, 58, 23)} | The Query is an optional overload so I'll put that at the end instead. It also lines up with where the "data" argument goes into the render.
Originally I had some thought around how it would be better for types to infer the result of the first argument flowing into the second. Maybe as you're typing it out. But the ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18374/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18374/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18373 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18373/labels{/name} | https://api.github.com/repos/facebook/react/issues/18373/comments | https://api.github.com/repos/facebook/react/issues/18373/events | https://github.com/facebook/react/issues/18373 | 586,556,930 | MDU6SXNzdWU1ODY1NTY5MzA= | 18,373 | Bug: Returning div or span from map on Indexed Collections like Int32Array and Float32Array returns 0s and NaNs | {'login': 'saravanabalagi', 'id': 8567893, 'node_id': 'MDQ6VXNlcjg1Njc4OTM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8567893?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/saravanabalagi', 'html_url': 'https://github.com/saravanabalagi', 'followers_url': 'https://api.github.com/users/sara... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is not a React bug :smile: You can produce the same behavior in the browser console by running the following:\r\n```js\r\nnew Int32Array([1, 2, 3]).map(i => i); // [1,2,3]\r\nnew Int32Array([1, 2, 3]).map(i => {i}); // [0,0,0]\r\n```\r\n\r\nThe `map()` function you're calling is [this one](https://developer.m... | 2020-03-23 22:26:06 | 2020-03-24 00:34:29 | 2020-03-24 00:30:09 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.13.1
## Steps To Reproduce
1. Create a simple react app
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18373/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18373/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18372 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18372/labels{/name} | https://api.github.com/repos/facebook/react/issues/18372/comments | https://api.github.com/repos/facebook/react/issues/18372/events | https://github.com/facebook/react/issues/18372 | 586,516,488 | MDU6SXNzdWU1ODY1MTY0ODg= | 18,372 | Bug: Combination of standard hooks causes "Cannot read property 'length' of undefined" in areHookInputsEqual | {'login': 'willyrk1', 'id': 15706442, 'node_id': 'MDQ6VXNlcjE1NzA2NDQy', 'avatar_url': 'https://avatars.githubusercontent.com/u/15706442?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/willyrk1', 'html_url': 'https://github.com/willyrk1', 'followers_url': 'https://api.github.com/users/willyrk1/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is a misunderstanding.\r\n\r\nThe `useState` hook lets you update state in two ways:\r\n* Passing a value directly (e.g. `setState(123)`)\r\n* Passing an [\"updater function\"](https://reactjs.org/docs/hooks-reference.html#functional-updates) that receives the previous state and returns a new state.\r\n\r\nTh... | 2020-03-23 21:02:30 | 2021-06-29 16:44:22 | 2020-03-23 21:30:43 | NONE | null | null | null | Found a combination of fairly trivial hooks that causes "Cannot read property 'length' of undefined" in areHookInputsEqual" error.
React version: 16.12
## Steps To Reproduce
1. Open sandbox at https://codesandbox.io/s/hooks-combo-npe-6tyck
2. Click TRY ME button.
3. Yellow screen
Link to code example:
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18372/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18372/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18371 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18371/labels{/name} | https://api.github.com/repos/facebook/react/issues/18371/comments | https://api.github.com/repos/facebook/react/issues/18371/events | https://github.com/facebook/react/pull/18371 | 586,442,615 | MDExOlB1bGxSZXF1ZXN0MzkyNTc2Mjkz | 18,371 | [Flight] Integrate Blocks into Flight | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18371/builds/16277) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-23 18:59:02 | 2020-03-24 00:53:46 | 2020-03-24 00:53:46 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18371', 'html_url': 'https://github.com/facebook/react/pull/18371', 'diff_url': 'https://github.com/facebook/react/pull/18371.diff', 'patch_url': 'https://github.com/facebook/react/pull/18371.patch', 'merged_at': datetime.datetime(2020, 3, 24, 0, 53, 46)} | The previous model was centered around JSX rendering random models. This moves to a Block centric approach. To do this, we need a way to pass modules to the client so this wires up the previous infra to resolve modules into meta data.
The server is expected to replace a Block with a compiler to instead return a "Ser... | {'url': 'https://api.github.com/repos/facebook/react/issues/18371/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18371/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18370 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18370/labels{/name} | https://api.github.com/repos/facebook/react/issues/18370/comments | https://api.github.com/repos/facebook/react/issues/18370/events | https://github.com/facebook/react/pull/18370 | 586,315,385 | MDExOlB1bGxSZXF1ZXN0MzkyNDcxODM5 | 18,370 | ReactDOM.useEvent: add support for beforeblur/afterblur | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 6a87f876eb8... | 2020-03-23 15:54:13 | 2020-03-24 16:14:59 | 2020-03-24 16:14:57 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18370', 'html_url': 'https://github.com/facebook/react/pull/18370', 'diff_url': 'https://github.com/facebook/react/pull/18370.diff', 'patch_url': 'https://github.com/facebook/react/pull/18370.patch', 'merged_at': datetime.datetime(2020, 3, 24, 16, 14, 56)} | This ports the existing Flare logic for handling `beforeblur` and `blur` over to the ReactDOM.useEvent system. The only real differences are:
- We don't invoke events directly into the modern event system, like we do with the Flare events (we invoke the Flare event system directly). Instead, we trigger a native DOM ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18370/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18370/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18369 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18369/labels{/name} | https://api.github.com/repos/facebook/react/issues/18369/comments | https://api.github.com/repos/facebook/react/issues/18369/events | https://github.com/facebook/react/issues/18369 | 585,756,971 | MDU6SXNzdWU1ODU3NTY5NzE= | 18,369 | Bug: Custom Hooks cannot be Shared in Webpack Bundles | {'login': 'pmwmedia', 'id': 2338728, 'node_id': 'MDQ6VXNlcjIzMzg3Mjg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2338728?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pmwmedia', 'html_url': 'https://github.com/pmwmedia', 'followers_url': 'https://api.github.com/users/pmwmedia/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"React has no knowledge of webpack. Therefore, it can’t possibly refuse sharing Hooks via webpack specifically. If you see this error it *does* mean you have two copies of React (or an equivalent problem). Possibly due to bad webpack configuration. Have you examined the output of your bundles? ",
"You are right, ... | 2020-03-22 16:27:07 | 2020-03-23 08:04:08 | 2020-03-23 08:04:07 | NONE | null | null | null | A custom hook in a webpack bundle cannot be reused in another Webpack bundle, because React throws an error on runtime:
```
Uncaught Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versi... | {'url': 'https://api.github.com/repos/facebook/react/issues/18369/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18369/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18368 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18368/labels{/name} | https://api.github.com/repos/facebook/react/issues/18368/comments | https://api.github.com/repos/facebook/react/issues/18368/events | https://github.com/facebook/react/issues/18368 | 585,647,472 | MDU6SXNzdWU1ODU2NDc0NzI= | 18,368 | May be bug: onChange events don't fire in controlled forms in portals rendered in external window | {'login': 'ZYinMD', 'id': 32368482, 'node_id': 'MDQ6VXNlcjMyMzY4NDgy', 'avatar_url': 'https://avatars.githubusercontent.com/u/32368482?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ZYinMD', 'html_url': 'https://github.com/ZYinMD', 'followers_url': 'https://api.github.com/users/ZYinMD/followers', 'follow... | [{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20DOM', 'name': 'Component: DOM', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 710722093, 'node_id': 'MDU6TGFiZWw3MTA3MjIwOTM=', 'url': 'https://api.github.com/repos/faceb... | closed | false | null | [] | null | [
"Can you try this in earlier versions of React to check if this ever worked?",
"I tested several versions, as early as v16.2.0, seems it never worked.\r\n\r\n[Sandbox on React 16.2.0](https://codesandbox.io/s/portal-on-react-1620-kechz)",
"I have a guess: in the synthetic event, the keyword `document` is used s... | 2020-03-22 05:13:07 | 2022-03-30 00:31:33 | 2022-03-30 00:31:33 | NONE | null | null | null | React version: 16.13.1
I may be using Portal in a way that's not intended, which is why I had this bug, but at least it's not mentioned in the doc.
## Steps To Reproduce
Demo: [CodeSandbox](https://codesandbox.io/s/kind-morning-t3q9c)
Inspired by [this blogpost](https://medium.com/hackernoon/using-a-react-1... | {'url': 'https://api.github.com/repos/facebook/react/issues/18368/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18368/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18367 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18367/labels{/name} | https://api.github.com/repos/facebook/react/issues/18367/comments | https://api.github.com/repos/facebook/react/issues/18367/events | https://github.com/facebook/react/pull/18367 | 585,613,737 | MDExOlB1bGxSZXF1ZXN0MzkxOTM1ODQy | 18,367 | [Flight] Move bundler configs to use Suspense instead of returning thenable | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18367/builds/15967) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-22 00:21:06 | 2020-03-22 05:28:37 | 2020-03-22 05:28:37 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18367', 'html_url': 'https://github.com/facebook/react/pull/18367', 'diff_url': 'https://github.com/facebook/react/pull/18367.diff', 'patch_url': 'https://github.com/facebook/react/pull/18367.patch', 'merged_at': datetime.datetime(2020, 3, 22, 5, 28, 37)} | Follow up to the bundler configs after https://github.com/facebook/react/pull/18362
Instead of returning a thenable and let React deal with Suspense we can now simplify things a lot by just throwing a Promise or Error if we're not ready yet. | {'url': 'https://api.github.com/repos/facebook/react/issues/18367/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18367/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18366 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18366/labels{/name} | https://api.github.com/repos/facebook/react/issues/18366/comments | https://api.github.com/repos/facebook/react/issues/18366/events | https://github.com/facebook/react/pull/18366 | 585,595,293 | MDExOlB1bGxSZXF1ZXN0MzkxOTIzMjg4 | 18,366 | Stop syncing ReactTypes to RN | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18366/builds/15919) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-21 22:11:04 | 2020-03-21 22:22:41 | 2020-03-21 22:22:41 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18366', 'html_url': 'https://github.com/facebook/react/pull/18366', 'diff_url': 'https://github.com/facebook/react/pull/18366.diff', 'patch_url': 'https://github.com/facebook/react/pull/18366.patch', 'merged_at': datetime.datetime(2020, 3, 21, 22, 22, 41)} | This is a really old one and all callers have since been codemodded away anyway because of problems.
This file is not really as rigorously maintained as the official Flow types but has a few more specifics. However, the inconsistency causes problems when you try to pass files typed using the built-in Flow typing for... | {'url': 'https://api.github.com/repos/facebook/react/issues/18366/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18366/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18365 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18365/labels{/name} | https://api.github.com/repos/facebook/react/issues/18365/comments | https://api.github.com/repos/facebook/react/issues/18365/events | https://github.com/facebook/react/issues/18365 | 585,591,291 | MDU6SXNzdWU1ODU1OTEyOTE= | 18,365 | Bug: Fast refresh doesn't work when react is a dev. dependency | {'login': 'dicearr', 'id': 10713226, 'node_id': 'MDQ6VXNlcjEwNzEzMjI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/10713226?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dicearr', 'html_url': 'https://github.com/dicearr', 'followers_url': 'https://api.github.com/users/dicearr/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Please file this with Parcel. The underlying mechanism in React has no way to know how it’s declared in package.json so it couldn’t be the cause. npm also doesn’t care. That leaves us with Parcel heuristics as the place where it breaks down. ",
"I will do so. I opened it here in the first place because I see the... | 2020-03-21 21:45:18 | 2020-03-21 23:44:18 | 2020-03-21 22:21:52 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
I might be missing something obvious but I always thought that I could install `... | {'url': 'https://api.github.com/repos/facebook/react/issues/18365/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18365/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18364 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18364/labels{/name} | https://api.github.com/repos/facebook/react/issues/18364/comments | https://api.github.com/repos/facebook/react/issues/18364/events | https://github.com/facebook/react/pull/18364 | 585,580,627 | MDExOlB1bGxSZXF1ZXN0MzkxOTEzNDAx | 18,364 | Rename CI jobs after the command line equivalent | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against daa5cd442005bb9ff903ea1... | 2020-03-21 20:43:17 | 2020-03-21 23:02:02 | 2020-03-21 23:02:02 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18364', 'html_url': 'https://github.com/facebook/react/pull/18364', 'diff_url': 'https://github.com/facebook/react/pull/18364.diff', 'patch_url': 'https://github.com/facebook/react/pull/18364.patch', 'merged_at': datetime.datetime(2020, 3, 21, 23, 2, 2)} | This makes it easier to know what to write on your command line to replicate a failure locally.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18364/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18364/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18363 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18363/labels{/name} | https://api.github.com/repos/facebook/react/issues/18363/comments | https://api.github.com/repos/facebook/react/issues/18363/events | https://github.com/facebook/react/pull/18363 | 585,567,713 | MDExOlB1bGxSZXF1ZXN0MzkxOTAzMjM4 | 18,363 | Move some files out of /shared and rename to upper case | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18363/builds/15889) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-21 19:49:16 | 2020-03-21 22:22:02 | 2020-03-21 22:22:02 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18363', 'html_url': 'https://github.com/facebook/react/pull/18363', 'diff_url': 'https://github.com/facebook/react/pull/18363.diff', 'patch_url': 'https://github.com/facebook/react/pull/18363.patch', 'merged_at': datetime.datetime(2020, 3, 21, 22, 22, 2)} | This moves some stuff out of shared and into their respective packages.
I changed the isomorphic "creator" types to use the same convention (upper case) with named exports. It was inconsistent before.
Things that are Fiber specific can live in the reconciler because any individual renderer is allowed to deep link... | {'url': 'https://api.github.com/repos/facebook/react/issues/18363/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18363/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18362 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18362/labels{/name} | https://api.github.com/repos/facebook/react/issues/18362/comments | https://api.github.com/repos/facebook/react/issues/18362/events | https://github.com/facebook/react/pull/18362 | 585,549,797 | MDExOlB1bGxSZXF1ZXN0MzkxODkxODU2 | 18,362 | Refactor Lazy Components to use teh Suspense (and wrap Blocks in Lazy) | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18362/builds/16110) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-21 18:08:03 | 2020-11-30 22:48:20 | 2020-03-23 04:53:06 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18362', 'html_url': 'https://github.com/facebook/react/pull/18362', 'diff_url': 'https://github.com/facebook/react/pull/18362.diff', 'patch_url': 'https://github.com/facebook/react/pull/18362.patch', 'merged_at': datetime.datetime(2020, 3, 23, 4, 53, 6)} | I wasn't happy with my approach in https://github.com/facebook/react/pull/18220
Exposing the status stuff leaks a lot of complexity downstream. It avoids taking on a virtual dispatch but also means that other code (like Flight and Blocks) can't take advantage of what Lazy already does.
Using the suspense protocol... | {'url': 'https://api.github.com/repos/facebook/react/issues/18362/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18362/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18361 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18361/labels{/name} | https://api.github.com/repos/facebook/react/issues/18361/comments | https://api.github.com/repos/facebook/react/issues/18361/events | https://github.com/facebook/react/issues/18361 | 585,418,834 | MDU6SXNzdWU1ODU0MTg4MzQ= | 18,361 | Bug: Best practice - React.createElement children argument to be always array. | {'login': 'imvetri', 'id': 6542274, 'node_id': 'MDQ6VXNlcjY1NDIyNzQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6542274?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/imvetri', 'html_url': 'https://github.com/imvetri', 'followers_url': 'https://api.github.com/users/imvetri/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Why does this matter? It’s not meant to be manipulated/introspected by an app developer anyway, and if they do need to, there are React.Children helpers to do so. \r\n\r\nThis isn’t a bug. ",
"It's not a bug from app developer's view but helps a maintainer from keeping track of the types and get rid of condition... | 2020-03-21 03:17:38 | 2020-03-21 16:56:07 | 2020-03-21 13:39:42 | NONE | null | null | null | ## Maintain consistency
When a parent component contains children, sometimes it is passed as an object and sometimes it is passed as an array.
Example:
`<Parent>
<Child></Child>
</Parent>`
In the above example, typeof Parent.children will be object whereas
`<Parent>
<Child></Child>
<Child><... | {'url': 'https://api.github.com/repos/facebook/react/issues/18361/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18361/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18360 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18360/labels{/name} | https://api.github.com/repos/facebook/react/issues/18360/comments | https://api.github.com/repos/facebook/react/issues/18360/events | https://github.com/facebook/react/pull/18360 | 585,404,519 | MDExOlB1bGxSZXF1ZXN0MzkxNzk4NTI3 | 18,360 | Execute hooks in separate namespaces for concurrent server renderers | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18360/builds/22807) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-21 01:34:48 | 2020-08-03 01:06:57 | 2020-08-03 01:06:57 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18360', 'html_url': 'https://github.com/facebook/react/pull/18360', 'diff_url': 'https://github.com/facebook/react/pull/18360.diff', 'patch_url': 'https://github.com/facebook/react/pull/18360.patch', 'merged_at': None} | fix #16416 | {'url': 'https://api.github.com/repos/facebook/react/issues/18360/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18360/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18359 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18359/labels{/name} | https://api.github.com/repos/facebook/react/issues/18359/comments | https://api.github.com/repos/facebook/react/issues/18359/events | https://github.com/facebook/react/issues/18359 | 585,275,566 | MDU6SXNzdWU1ODUyNzU1NjY= | 18,359 | Add relevant stacktrace to act warnings | {'login': 'kentcdodds', 'id': 1500684, 'node_id': 'MDQ6VXNlcjE1MDA2ODQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1500684?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kentcdodds', 'html_url': 'https://github.com/kentcdodds', 'followers_url': 'https://api.github.com/users/kentcdodds/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Oh, and here's a reproduction: https://github.com/kentcdodds/act-stack-example",
"Isn’t this something Jest should do? The browser does it. ",
"Also the repo is empty. :-)",
"Oh, sorry about that. It was basically this: https://codesandbox.io/s/angry-curran-0mv31\r\n\r\nExcept codesandbox doesn't always work... | 2020-03-20 19:11:58 | 2020-03-20 23:51:54 | 2020-03-20 23:23:20 | CONTRIBUTOR | null | null | null | React version: ^16.8.0
## Steps To Reproduce
1. set state without wrapping in act
2. observe the act warning
Link to code example:
## The current behavior
Right now the act warning gives a component stack trace which is nice, but in the age of reusable hooks, it's not enough to help people really ident... | {'url': 'https://api.github.com/repos/facebook/react/issues/18359/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18359/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18358 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18358/labels{/name} | https://api.github.com/repos/facebook/react/issues/18358/comments | https://api.github.com/repos/facebook/react/issues/18358/events | https://github.com/facebook/react/pull/18358 | 585,260,677 | MDExOlB1bGxSZXF1ZXN0MzkxNjg2OTAz | 18,358 | Add warnings when the target instance is null to attemptToDispatchEvent method | {'login': 'suthagar23', 'id': 17599049, 'node_id': 'MDQ6VXNlcjE3NTk5MDQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/17599049?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/suthagar23', 'html_url': 'https://github.com/suthagar23', 'followers_url': 'https://api.github.com/users/suthagar23/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18358/builds/15811) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-20 18:42:07 | 2020-06-28 00:55:50 | 2020-06-28 00:55:50 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18358', 'html_url': 'https://github.com/facebook/react/pull/18358', 'diff_url': 'https://github.com/facebook/react/pull/18358.diff', 'patch_url': 'https://github.com/facebook/react/pull/18358.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18358/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18358/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18357 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18357/labels{/name} | https://api.github.com/repos/facebook/react/issues/18357/comments | https://api.github.com/repos/facebook/react/issues/18357/events | https://github.com/facebook/react/issues/18357 | 585,242,862 | MDU6SXNzdWU1ODUyNDI4NjI= | 18,357 | Bug: High-pri setState causes primary tree to get unhidden | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}] | closed | false | {'login': 'sebmarkbage', 'id': 63648.0, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followe... | [{'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/follower... | null | [
"Repro with two sibling components: https://codesandbox.io/s/vigilant-nightingale-deb0u. During the high pri render, we don't go into ProfilePage at all."
] | 2020-03-20 18:08:47 | 2020-03-30 18:25:05 | 2020-03-30 18:25:05 | COLLABORATOR | null | null | null | Repro: https://codesandbox.io/s/fast-water-4i4jb
Notice the flash. I'd expect `suspended` to be `true` during the high pri render. | {'url': 'https://api.github.com/repos/facebook/react/issues/18357/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18357/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18356 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18356/labels{/name} | https://api.github.com/repos/facebook/react/issues/18356/comments | https://api.github.com/repos/facebook/react/issues/18356/events | https://github.com/facebook/react/pull/18356 | 585,201,999 | MDExOlB1bGxSZXF1ZXN0MzkxNjM5MzEx | 18,356 | Fix to prevent from leaking error messages in prod environment (ReactFlightServer) | {'login': 'suthagar23', 'id': 17599049, 'node_id': 'MDQ6VXNlcjE3NTk5MDQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/17599049?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/suthagar23', 'html_url': 'https://github.com/suthagar23', 'followers_url': 'https://api.github.com/users/suthagar23/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18356/builds/15746) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-20 16:53:52 | 2020-06-28 00:55:49 | 2020-06-28 00:55:49 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18356', 'html_url': 'https://github.com/facebook/react/pull/18356', 'diff_url': 'https://github.com/facebook/react/pull/18356.diff', 'patch_url': 'https://github.com/facebook/react/pull/18356.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18356/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18356/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18355 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18355/labels{/name} | https://api.github.com/repos/facebook/react/issues/18355/comments | https://api.github.com/repos/facebook/react/issues/18355/events | https://github.com/facebook/react/pull/18355 | 585,128,152 | MDExOlB1bGxSZXF1ZXN0MzkxNTc5NTQ0 | 18,355 | ReactDOM.useEvent: add `EventTarget` support | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This seems to include changes from the last PR. Rebase please?",
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18355/builds/15714) or the icon next to ... | 2020-03-20 15:01:29 | 2020-03-27 02:12:31 | 2020-03-20 18:31:48 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18355', 'html_url': 'https://github.com/facebook/react/pull/18355', 'diff_url': 'https://github.com/facebook/react/pull/18355.diff', 'patch_url': 'https://github.com/facebook/react/pull/18355.patch', 'merged_at': datetime.datetime(2020, 3, 20, 18, 31, 48)} | This PR adds support to `useEvent` so that `setListener` can take objects that are valid `EventTarget`s. For example, you can use `window` or `document` with `useEvent` as of this PR:
```jsx
function Component() {
const clickHandle = ReactDOM.unstable_useEvent('click')
useEffect(() => {
clickHandle.set... | {'url': 'https://api.github.com/repos/facebook/react/issues/18355/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18355/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18354 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18354/labels{/name} | https://api.github.com/repos/facebook/react/issues/18354/comments | https://api.github.com/repos/facebook/react/issues/18354/events | https://github.com/facebook/react/pull/18354 | 584,821,349 | MDExOlB1bGxSZXF1ZXN0MzkxMzM0MDMz | 18,354 | fix string ref cannot be auto converted warning for React.jsxDEV | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18354/builds/15637) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-20 03:34:38 | 2020-03-20 06:47:54 | 2020-03-20 06:47:54 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18354', 'html_url': 'https://github.com/facebook/react/pull/18354', 'diff_url': 'https://github.com/facebook/react/pull/18354.diff', 'patch_url': 'https://github.com/facebook/react/pull/18354.patch', 'merged_at': datetime.datetime(2020, 3, 20, 6, 47, 54)} | The string ref cannot be auto converted warning was using the wrong `_self`. This diff fixes this so it is now using the correct `__self` | {'url': 'https://api.github.com/repos/facebook/react/issues/18354/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18354/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18353 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18353/labels{/name} | https://api.github.com/repos/facebook/react/issues/18353/comments | https://api.github.com/repos/facebook/react/issues/18353/events | https://github.com/facebook/react/issues/18353 | 584,793,879 | MDU6SXNzdWU1ODQ3OTM4Nzk= | 18,353 | Bug: Updates in the primary tree only unsuspend once | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 1109407645, 'node_id': 'MDU6TGFiZWwxMTA5NDA3NjQ1', 'url': 'https://api.github.com/repos/facebook/react/... | closed | false | {'login': 'acdlite', 'id': 3624098.0, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'fo... | [{'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'fol... | null | [
"Here's a variation that doesn't seem to \"wake up\" at all, not even the first time: https://codesandbox.io/s/sleepy-moore-4e3o9.",
"Confirmed that this is fixed by https://github.com/facebook/react/pull/18384"
] | 2020-03-20 01:41:21 | 2020-03-26 18:31:41 | 2020-03-26 18:31:41 | COLLABORATOR | null | null | null | https://codesandbox.io/s/upbeat-frost-3tt25
1. Press Suspend, see "Loading..."
2. Wait five seconds, you'll see "Happy birthday" at some point
3. You won't see it again no matter how long you wait
Expected: you'll see it every five seconds. | {'url': 'https://api.github.com/repos/facebook/react/issues/18353/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18353/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18352 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18352/labels{/name} | https://api.github.com/repos/facebook/react/issues/18352/comments | https://api.github.com/repos/facebook/react/issues/18352/events | https://github.com/facebook/react/pull/18352 | 584,773,836 | MDExOlB1bGxSZXF1ZXN0MzkxMjk3MzUw | 18,352 | [Flight] Follow ups to bundler configs | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18352/builds/15623) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-20 00:22:23 | 2020-03-20 00:49:41 | 2020-03-20 00:49:41 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18352', 'html_url': 'https://github.com/facebook/react/pull/18352', 'diff_url': 'https://github.com/facebook/react/pull/18352.diff', 'patch_url': 'https://github.com/facebook/react/pull/18352.patch', 'merged_at': datetime.datetime(2020, 3, 20, 0, 49, 41)} | Follow ups from https://github.com/facebook/react/pull/18334
I also introduced the concept of a module reference on the client too. We don't need this for webpack so that gets compiled out but we need it for www. Similarly I also need a difference between preload and load.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18352/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18352/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18351 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18351/labels{/name} | https://api.github.com/repos/facebook/react/issues/18351/comments | https://api.github.com/repos/facebook/react/issues/18351/events | https://github.com/facebook/react/pull/18351 | 584,693,112 | MDExOlB1bGxSZXF1ZXN0MzkxMjMxNzk4 | 18,351 | ReactDOM.useEvent: support custom types | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18351/builds/15711) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-19 20:52:19 | 2020-03-20 14:45:37 | 2020-03-20 14:45:34 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18351', 'html_url': 'https://github.com/facebook/react/pull/18351', 'diff_url': 'https://github.com/facebook/react/pull/18351.diff', 'patch_url': 'https://github.com/facebook/react/pull/18351.patch', 'merged_at': datetime.datetime(2020, 3, 20, 14, 45, 34)} | This PR adds support for custom user events to the `useEvent` system. I've also added tests demonstrating them working as expected. I also added an unnecessary `phasedRegistrationNames == null` check in `accumulateTwoPhaseListeners` that never occurs at runtime. This essentially allows this:
```jsx
function Compone... | {'url': 'https://api.github.com/repos/facebook/react/issues/18351/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18351/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18350 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18350/labels{/name} | https://api.github.com/repos/facebook/react/issues/18350/comments | https://api.github.com/repos/facebook/react/issues/18350/events | https://github.com/facebook/react/pull/18350 | 584,675,677 | MDExOlB1bGxSZXF1ZXN0MzkxMjE3OTk4 | 18,350 | Remove error code step from publish script | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against df54ba1d48e... | 2020-03-19 20:20:36 | 2020-03-19 21:45:08 | 2020-03-19 21:45:07 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18350', 'html_url': 'https://github.com/facebook/react/pull/18350', 'diff_url': 'https://github.com/facebook/react/pull/18350.diff', 'patch_url': 'https://github.com/facebook/react/pull/18350.patch', 'merged_at': datetime.datetime(2020, 3, 19, 21, 45, 7)} | Error codes don't need to be pulled from CI anymore because the ones in source are already expected to match the build output.
I noticed this when running the 16.13.1 release. Patch releases are cut with the commit used to build the previous release as a base. So the publish script accidentally reverted the changes ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18350/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18350/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18349 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18349/labels{/name} | https://api.github.com/repos/facebook/react/issues/18349/comments | https://api.github.com/repos/facebook/react/issues/18349/events | https://github.com/facebook/react/pull/18349 | 584,671,913 | MDExOlB1bGxSZXF1ZXN0MzkxMjE0OTQw | 18,349 | ModernEventSystem: refine Flow types | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18349/builds/15595) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-19 20:14:13 | 2020-03-19 20:25:57 | 2020-03-19 20:25:53 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18349', 'html_url': 'https://github.com/facebook/react/pull/18349', 'diff_url': 'https://github.com/facebook/react/pull/18349.diff', 'patch_url': 'https://github.com/facebook/react/pull/18349.patch', 'merged_at': datetime.datetime(2020, 3, 19, 20, 25, 53)} | This PR cleans up some Flow typing any casts. | {'url': 'https://api.github.com/repos/facebook/react/issues/18349/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18349/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18348 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18348/labels{/name} | https://api.github.com/repos/facebook/react/issues/18348/comments | https://api.github.com/repos/facebook/react/issues/18348/events | https://github.com/facebook/react/pull/18348 | 584,669,592 | MDExOlB1bGxSZXF1ZXN0MzkxMjEyOTk2 | 18,348 | Revert accidental changes to package.json | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 1 warning: Base commit is br...\n \n 1 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n<table>\n <thead>\n <tr>\n <th width=\"50\"></th>\n <th width=\"100%\" data-danger-table=\"true\">Warnings</th>\n </tr>\n </thead>\n <tbody><tr>\n <td>:warning:... | 2020-03-19 20:10:03 | 2020-03-19 20:16:42 | 2020-03-19 20:16:38 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18348', 'html_url': 'https://github.com/facebook/react/pull/18348', 'diff_url': 'https://github.com/facebook/react/pull/18348.diff', 'patch_url': 'https://github.com/facebook/react/pull/18348.patch', 'merged_at': datetime.datetime(2020, 3, 19, 20, 16, 37)} | The publish script was written before we switched to running patch releases out-of-band, so when updating the local package.json version numbers, it accidentally reverted other changes that have landed to master since 16.13 was released.
Comparison to before the automated changes. Only differences are to the changel... | {'url': 'https://api.github.com/repos/facebook/react/issues/18348/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18348/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18347 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18347/labels{/name} | https://api.github.com/repos/facebook/react/issues/18347/comments | https://api.github.com/repos/facebook/react/issues/18347/events | https://github.com/facebook/react/pull/18347 | 584,651,838 | MDExOlB1bGxSZXF1ZXN0MzkxMTk4NjA0 | 18,347 | Changelog for 16.13.1 | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18347/builds/15592) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-19 19:37:17 | 2020-03-19 20:06:08 | 2020-03-19 19:58:48 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18347', 'html_url': 'https://github.com/facebook/react/pull/18347', 'diff_url': 'https://github.com/facebook/react/pull/18347.diff', 'patch_url': 'https://github.com/facebook/react/pull/18347.patch', 'merged_at': datetime.datetime(2020, 3, 19, 19, 58, 48)} | Will merge once release is out | {'url': 'https://api.github.com/repos/facebook/react/issues/18347/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18347/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18346 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18346/labels{/name} | https://api.github.com/repos/facebook/react/issues/18346/comments | https://api.github.com/repos/facebook/react/issues/18346/events | https://github.com/facebook/react/pull/18346 | 584,651,790 | MDExOlB1bGxSZXF1ZXN0MzkxMTk4NTYz | 18,346 | ModernEventSystem: fix event replaying | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18346/builds/15606) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-19 19:37:11 | 2020-03-19 20:44:48 | 2020-03-19 20:44:39 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18346', 'html_url': 'https://github.com/facebook/react/pull/18346', 'diff_url': 'https://github.com/facebook/react/pull/18346.diff', 'patch_url': 'https://github.com/facebook/react/pull/18346.patch', 'merged_at': datetime.datetime(2020, 3, 19, 20, 44, 39)} | If you run all the tests with modern event system flag:
```
export const enableModernEventSystem = true;
```
This PR, thanks to Seb now should fix those use-cases with the modern event system and the event replaying mechanics. | {'url': 'https://api.github.com/repos/facebook/react/issues/18346/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18346/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18345 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18345/labels{/name} | https://api.github.com/repos/facebook/react/issues/18345/comments | https://api.github.com/repos/facebook/react/issues/18345/events | https://github.com/facebook/react/pull/18345 | 584,615,129 | MDExOlB1bGxSZXF1ZXN0MzkxMTY4OTkx | 18,345 | fix(devtools): check if data for commit index exists | {'login': 'jyash97', 'id': 22376783, 'node_id': 'MDQ6VXNlcjIyMzc2Nzgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/22376783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jyash97', 'html_url': 'https://github.com/jyash97', 'followers_url': 'https://api.github.com/users/jyash97/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18345/builds/15582) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-19 18:31:13 | 2020-03-25 05:52:59 | 2020-03-24 18:20:44 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18345', 'html_url': 'https://github.com/facebook/react/pull/18345', 'diff_url': 'https://github.com/facebook/react/pull/18345.diff', 'patch_url': 'https://github.com/facebook/react/pull/18345.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18345/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18345/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18344 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18344/labels{/name} | https://api.github.com/repos/facebook/react/issues/18344/comments | https://api.github.com/repos/facebook/react/issues/18344/events | https://github.com/facebook/react/pull/18344 | 584,596,994 | MDExOlB1bGxSZXF1ZXN0MzkxMTU0MjI1 | 18,344 | 16.13 patch | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18344/builds/15584) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-19 18:00:01 | 2020-03-28 15:11:39 | 2020-03-28 15:11:39 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/18344', 'html_url': 'https://github.com/facebook/react/pull/18344', 'diff_url': 'https://github.com/facebook/react/pull/18344.diff', 'patch_url': 'https://github.com/facebook/react/pull/18344.patch', 'merged_at': None} | Patch release branch for 16.3.
Based on d28bd2994, the commit used to [build 16.13.0](https://unpkg.com/browse/react-dom@16.13.0/build-info.json).
Release candidate: `0.0.0-da834083c`
## Test Plan
- [x] Open https://codesandbox.io/s/react-sortable-tree-hooked-22z8m. Should not warn about render phase updates.... | {'url': 'https://api.github.com/repos/facebook/react/issues/18344/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18344/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18343 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18343/labels{/name} | https://api.github.com/repos/facebook/react/issues/18343/comments | https://api.github.com/repos/facebook/react/issues/18343/events | https://github.com/facebook/react/issues/18343 | 584,496,902 | MDU6SXNzdWU1ODQ0OTY5MDI= | 18,343 | Bug: useEffect , useCallBack and useState, the problem of interdependence | {'login': 'world56', 'id': 37354312, 'node_id': 'MDQ6VXNlcjM3MzU0MzEy', 'avatar_url': 'https://avatars.githubusercontent.com/u/37354312?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/world56', 'html_url': 'https://github.com/world56', 'followers_url': 'https://api.github.com/users/world56/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2020-03-19 15:30:48 | 2020-03-20 05:00:05 | 2020-03-20 05:00:05 | NONE | null | null | null | ### React version:16.12.0
const { window } = props; // boolean
const [state, setState] = useState<CourseData[]>([]);
const [search, setSearch] = useState<getThemeList>({
theme: '',
themeType: '',
total: 0,
pageIndex: 1,
pageSize: 15
});
const ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18343/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18343/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18342 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18342/labels{/name} | https://api.github.com/repos/facebook/react/issues/18342/comments | https://api.github.com/repos/facebook/react/issues/18342/events | https://github.com/facebook/react/issues/18342 | 584,088,074 | MDU6SXNzdWU1ODQwODgwNzQ= | 18,342 | Bug: Updating a checkbox's indeterminate and checked states in the same tick causes a display issue in Chrome | {'login': 'lucaschen', 'id': 2109121, 'node_id': 'MDQ6VXNlcjIxMDkxMjE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2109121?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lucaschen', 'html_url': 'https://github.com/lucaschen', 'followers_url': 'https://api.github.com/users/lucaschen/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"I'm fairly certain this is how your code updates the `indeterminate` property:\r\n\r\n```js\r\nuseEffect(() => {\r\n checkboxRef.current.indeterminate = indeterminate;\r\n}, [indeterminate]);\r\n```\r\n\r\nThis means that react will commit a version of your UI with a new `indeterminate` and after that commit it w... | 2020-03-19 00:49:06 | 2022-11-16 09:54:50 | 2020-06-28 00:55:56 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.12.0
## Steps To Reproduce
Please see this CodeSandbox: ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18342/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18342/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18341 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18341/labels{/name} | https://api.github.com/repos/facebook/react/issues/18341/comments | https://api.github.com/repos/facebook/react/issues/18341/events | https://github.com/facebook/react/pull/18341 | 583,931,577 | MDExOlB1bGxSZXF1ZXN0MzkwNjA0Nzgx | 18,341 | [eslint-plugin-react-hooks] Disallow hooks in class components | {'login': 'ianobermiller', 'id': 897931, 'node_id': 'MDQ6VXNlcjg5NzkzMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/897931?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ianobermiller', 'html_url': 'https://github.com/ianobermiller', 'followers_url': 'https://api.github.com/users/ianobermi... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18341/builds/15428) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-18 18:43:41 | 2021-01-18 19:39:08 | 2020-03-18 19:55:14 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18341', 'html_url': 'https://github.com/facebook/react/pull/18341', 'diff_url': 'https://github.com/facebook/react/pull/18341.diff', 'patch_url': 'https://github.com/facebook/react/pull/18341.patch', 'merged_at': datetime.datetime(2020, 3, 18, 19, 55, 14)} | ## Summary
Per discussion at Facebook, we think hooks have reached a tipping point where it is more valuable to lint against potential hooks in classes than to worry about false positives.
## Test Plan
```
# run from repo root
yarn test --watch RuleOfHooks
```
| {'url': 'https://api.github.com/repos/facebook/react/issues/18341/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18341/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18340 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18340/labels{/name} | https://api.github.com/repos/facebook/react/issues/18340/comments | https://api.github.com/repos/facebook/react/issues/18340/events | https://github.com/facebook/react/issues/18340 | 583,902,607 | MDU6SXNzdWU1ODM5MDI2MDc= | 18,340 | React | {'login': 'bailitugesu', 'id': 20237304, 'node_id': 'MDQ6VXNlcjIwMjM3MzA0', 'avatar_url': 'https://avatars.githubusercontent.com/u/20237304?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bailitugesu', 'html_url': 'https://github.com/bailitugesu', 'followers_url': 'https://api.github.com/users/bailitugesu... | [] | closed | false | null | [] | null | [] | 2020-03-18 17:49:58 | 2020-03-18 17:50:11 | 2020-03-18 17:50:11 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/18340/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18340/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18339 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18339/labels{/name} | https://api.github.com/repos/facebook/react/issues/18339/comments | https://api.github.com/repos/facebook/react/issues/18339/events | https://github.com/facebook/react/pull/18339 | 583,876,217 | MDExOlB1bGxSZXF1ZXN0MzkwNTU4NzQ0 | 18,339 | Fixed inconcistency with regards to punctuation | {'login': 'ItsByteMe', 'id': 39222138, 'node_id': 'MDQ6VXNlcjM5MjIyMTM4', 'avatar_url': 'https://avatars.githubusercontent.com/u/39222138?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ItsByteMe', 'html_url': 'https://github.com/ItsByteMe', 'followers_url': 'https://api.github.com/users/ItsByteMe/followe... | [] | closed | false | null | [] | null | [
"Hi @ItsByteMe! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on be... | 2020-03-18 17:06:11 | 2020-03-18 17:13:38 | 2020-03-18 17:10:33 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18339', 'html_url': 'https://github.com/facebook/react/pull/18339', 'diff_url': 'https://github.com/facebook/react/pull/18339.diff', 'patch_url': 'https://github.com/facebook/react/pull/18339.patch', 'merged_at': datetime.datetime(2020, 3, 18, 17, 10, 33)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18339/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18339/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18338 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18338/labels{/name} | https://api.github.com/repos/facebook/react/issues/18338/comments | https://api.github.com/repos/facebook/react/issues/18338/events | https://github.com/facebook/react/pull/18338 | 583,803,194 | MDExOlB1bGxSZXF1ZXN0MzkwNDk3ODQ1 | 18,338 | Stop exposing ReactDOMComponentTree from FB builds | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18338/builds/15408) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-03-18 15:17:06 | 2020-03-18 20:35:59 | 2020-03-18 20:35:59 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18338', 'html_url': 'https://github.com/facebook/react/pull/18338', 'diff_url': 'https://github.com/facebook/react/pull/18338.diff', 'patch_url': 'https://github.com/facebook/react/pull/18338.patch', 'merged_at': datetime.datetime(2020, 3, 18, 20, 35, 59)} | I'm changing the only usage in D20512780 to read the internals directly. Let's get rid of this. | {'url': 'https://api.github.com/repos/facebook/react/issues/18338/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18338/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18337 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18337/labels{/name} | https://api.github.com/repos/facebook/react/issues/18337/comments | https://api.github.com/repos/facebook/react/issues/18337/events | https://github.com/facebook/react/issues/18337 | 583,776,915 | MDU6SXNzdWU1ODM3NzY5MTU= | 18,337 | Error when running the react-native run-android command | {'login': 'Yuri-Tiofilo', 'id': 49408968, 'node_id': 'MDQ6VXNlcjQ5NDA4OTY4', 'avatar_url': 'https://avatars.githubusercontent.com/u/49408968?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Yuri-Tiofilo', 'html_url': 'https://github.com/Yuri-Tiofilo', 'followers_url': 'https://api.github.com/users/Yuri-Tio... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hi @Yuri-Tiofilo.\r\n\r\nIssues for React Native should be filed in the React Native repository: https://github.com/facebook/react-native\r\n\r\nBefore filing an issue there though, please be sure to provide a minimal code example that reproduces the problem. (The description of this issue is not detailed enough f... | 2020-03-18 14:40:09 | 2020-03-18 17:02:41 | 2020-03-18 17:02:41 | NONE | null | null | null | {
"name": "testeFlatListInput",
"version": "0.0.1",
"private": true,
"scripts": {
"android": "react-native run-android",
"ios": "react-native run-ios",
"start": "react-native start",
"test": "jest",
"lint": "eslint ."
},
"dependencies": {
"@react-native-community/async-st... | {'url': 'https://api.github.com/repos/facebook/react/issues/18337/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18337/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18336 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18336/labels{/name} | https://api.github.com/repos/facebook/react/issues/18336/comments | https://api.github.com/repos/facebook/react/issues/18336/events | https://github.com/facebook/react/pull/18336 | 583,716,094 | MDExOlB1bGxSZXF1ZXN0MzkwNDI1NzQz | 18,336 | Modern Event System: refactor legacy FB support logic | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 7cc9fcae055130a8cb7bffa... | 2020-03-18 13:09:05 | 2020-03-19 13:22:40 | 2020-03-19 13:22:37 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18336', 'html_url': 'https://github.com/facebook/react/pull/18336', 'diff_url': 'https://github.com/facebook/react/pull/18336.diff', 'patch_url': 'https://github.com/facebook/react/pull/18336.patch', 'merged_at': datetime.datetime(2020, 3, 19, 13, 22, 37)} | This is a pretty big refactor of the FB event support logic in the modern event system. Previously, the logic worked for only Primer, but on more internal cases occuring, it seems we should probably delegated all "click" events to after the internal tooling runs, which fixes all the known issues with the legacy FB even... | {'url': 'https://api.github.com/repos/facebook/react/issues/18336/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18336/timeline | null | null | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.