instance_id
stringlengths
21
53
repo
stringclasses
188 values
language
stringclasses
1 value
pull_number
int64
20
148k
title
stringlengths
6
144
body
stringlengths
0
83.4k
created_at
stringdate
2015-09-25 03:17:17
2025-07-10 16:50:35
problem_statement
stringlengths
188
240k
hints_text
stringlengths
0
145k
resolved_issues
listlengths
1
6
base_commit
stringlengths
40
40
commit_to_review
dict
reference_review_comments
listlengths
1
62
merged_commit
stringlengths
40
40
merged_patch
stringlengths
297
9.87M
metadata
dict
scikit-learn__scikit-learn-13278@0fa4eca
scikit-learn/scikit-learn
Python
13,278
DOC : fixing missing solvers in logreg doc
#### Reference Issues/PRs Fixes #13274 #### What does this implement/fix? Explain your changes. Added liblinear and saga in the docstring following @GaelVaroquaux issue and @btel test
2019-02-26T13:21:38Z
max_iter documentation seems wrong in LogisticRegression It seems that the documentation for max_iter is wrong in the docstring of LogisticRegression: the documentation claims that the parameter is not passed to saga and liblinear. max_iter is clearly passed to saga. From a cursory look at the code, it seems that ...
The `max_iter` parameter seems to be propagated all the way down to liblinear solver. I didn't check whether it's used internally by the solver, but I have no reason to believe that it's not the case. The same applies to saga solver. The docs mention: > max_iter : int, optional (default=100) Useful onl...
[ { "body": "It seems that the documentation for max_iter is wrong in the docstring of LogisticRegression: the documentation claims that the parameter is not passed to saga and liblinear.\r\n\r\nmax_iter is clearly passed to saga. \r\nFrom a cursory look at the code, it seems that it is also passed to liblinear.\...
350cd4aefa449badc67440315fdcc069c29ea667
{ "head_commit": "0fa4eca198cda56e4a686da4db08328594f0e680", "head_commit_message": "fixing missing solvers in logreg doc", "patch_to_review": "diff --git a/sklearn/linear_model/logistic.py b/sklearn/linear_model/logistic.py\nindex d593ffbff0eab..5f8b0eda860b8 100644\n--- a/sklearn/linear_model/logistic.py\n+++ b...
[ { "diff_hunk": "@@ -1315,7 +1315,7 @@ class LogisticRegression(BaseEstimator, LinearClassifierMixin,\n Default will change from 'liblinear' to 'lbfgs' in 0.22.\n \n max_iter : int, optional (default=100)\n- Useful only for the newton-cg, sag and lbfgs solvers.\n+ Useful only for th...
d3d61f81a4cdf1542c90b03cfbf5ac9ae12ca2c1
diff --git a/sklearn/linear_model/logistic.py b/sklearn/linear_model/logistic.py index d593ffbff0eab..ed2a7d231b6fd 100644 --- a/sklearn/linear_model/logistic.py +++ b/sklearn/linear_model/logistic.py @@ -1315,7 +1315,6 @@ class LogisticRegression(BaseEstimator, LinearClassifierMixin, Default will change f...
{ "difficulty": "low", "estimated_review_effort": 1, "problem_domain": "Documentation Updates" }
scikit-learn__scikit-learn-13095@619729f
scikit-learn/scikit-learn
Python
13,095
DOC Refer to ONNX
Arguably fixes #11041
2019-02-05T19:57:56Z
Best practices for deploying scikit-learn models? What are the best practices for deploying scikit-learn models on the cloud? I have trained a Random Forest Classifier. Models size is approx 2gb and gunicorn server is crashing on production. How to use huge ML models in Flask App with gunicorn server
I think this is a good question for us to document answers to, for example in the FAQ. one option: train and pickle within a docker and provide a web service frontend for prediction (perhaps there are existing implementations). Another: export a pmml representation and use pmml infrastructure. But these are not answers...
[ { "body": "What are the best practices for deploying scikit-learn models on the cloud? I have trained a Random Forest Classifier. Models size is approx 2gb and gunicorn server is crashing on production. How to use huge ML models in Flask App with gunicorn server", "number": 11041, "title": "Best practic...
18bac2edc2a18a96ae0bdbfb9241efd2d70b67ee
{ "head_commit": "619729fecb6321b96d3ea394ee8a35cc13597a10", "head_commit_message": "DOC Refer to ONNX", "patch_to_review": "diff --git a/doc/faq.rst b/doc/faq.rst\nindex c49f3df86027e..58c76b2eefa20 100644\n--- a/doc/faq.rst\n+++ b/doc/faq.rst\n@@ -66,6 +66,11 @@ might be found.\n **Please do not email any autho...
[ { "diff_hunk": "@@ -90,6 +90,10 @@ enhance the functionality of scikit-learn's estimators.\n \n **Model export for production**\n \n+- `onnxmltools <https://github.com/onnx/onnxmltools>`_ Serializes many\n+ Scikit-learn pipelines to `ONNX <https://onnx.ai/>`_ for interchange and\n+ prediction.\n+\n - `sklearn...
aa654167665685d43ffa381594b92c83c671acdd
diff --git a/doc/faq.rst b/doc/faq.rst index c49f3df86027e..58c76b2eefa20 100644 --- a/doc/faq.rst +++ b/doc/faq.rst @@ -66,6 +66,11 @@ might be found. **Please do not email any authors directly to ask for assistance, report bugs, or for any other issue related to scikit-learn.** +How should I save, export or deplo...
{ "difficulty": "low", "estimated_review_effort": 1, "problem_domain": "Performance Optimizations" }
ray-project__ray-54156@34a632b
ray-project/ray
Python
54,156
Remove `botocore` dependency in Ray Serve LLM
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-06-26T21:14:35Z
[Serve, LLM] missing botocore dependency! ### What happened + What you expected to happen There seems to be a missing (or unhandled import of) botocore dependency when importing ray.serve.llm stuff. `ModuleNotFoundError: No module named 'botocore'` ### Versions / Dependencies ``` underwent 19s  uv pip list Package...
[ { "body": "### What happened + What you expected to happen\n\nThere seems to be a missing (or unhandled import of) botocore dependency when importing ray.serve.llm stuff. `ModuleNotFoundError: No module named 'botocore'`\n\n\n### Versions / Dependencies\n\n```\nunderwent 19s  uv pip list\nPackage ...
b796d300d76b69c45bf5fc30033d7be28ca15a16
{ "head_commit": "34a632b0de88c50080d983b09e591b7191f49624", "head_commit_message": "CloudFileSystem.list_subfolders already swallows all Exceptions\n\nSigned-off-by: Seiji Eicher <seiji@anyscale.com>", "patch_to_review": "diff --git a/python/ray/llm/_internal/serve/observability/usage_telemetry/usage.py b/python...
[ { "diff_hunk": "@@ -361,6 +361,19 @@ def test_list_subfolders(self, mock_gcsfs):\n folders = CloudFileSystem.list_subfolders(\"gs://bucket/parent\")\n assert sorted(folders) == [\"dir1\", \"dir2\"]\n \n+ @patch(\"ray.llm._internal.common.utils.cloud_utils.CloudFileSystem.get_fs_and_path\")\n+...
1c7dde9ec60bbfd8927af51157ae4f8ec2ea32d9
diff --git a/python/ray/llm/_internal/serve/observability/usage_telemetry/usage.py b/python/ray/llm/_internal/serve/observability/usage_telemetry/usage.py index 36ccc928848e..ed9439bfc2af 100644 --- a/python/ray/llm/_internal/serve/observability/usage_telemetry/usage.py +++ b/python/ray/llm/_internal/serve/observabilit...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Dependency Updates & Env Compatibility" }
scikit-learn__scikit-learn-13046@eb4765c
scikit-learn/scikit-learn
Python
13,046
[MRG] BUG: add support for non numeric values in MissingIndicator
#### Reference Issues/PRs closes #13035 #### What does this implement/fix? Explain your changes. Add support to non-numeric values in MissingIndicator. I flag this PR as BUG since SimpleImputer is already supporting non-numeric data and that we cannot use the MissingIndicator with the SimpleImputer in 0.20. I...
2019-01-26T21:29:52Z
MissingIndicator failed with non-numeric inputs #### Description ```sklearn.Imputer.MissingIndicator``` fails with string and object type numpy arrays #### String Types ##### Steps/Code to Reproduce ```python import numpy as np from sklearn.impute import MissingIndicator a = np.array([[c] for c in 'ab...
This may be a problem for #11886 given that SimpleImputer now handles non-numerics The issue is that `check_array` convert to `float64` object array. We need to turn `dtype=None` in case of `string` or `object` dtype to avoid the conversion. > This may be a problem for #11886 given that SimpleImputer now handles non-n...
[ { "body": "\r\n#### Description\r\n\r\n```sklearn.Imputer.MissingIndicator``` fails with string and object type numpy arrays\r\n\r\n#### String Types\r\n\r\n##### Steps/Code to Reproduce \r\n```python\r\nimport numpy as np\r\nfrom sklearn.impute import MissingIndicator\r\n\r\na = np.array([[c] for c in 'abcdea'...
fcec951bc9f0003d157604bb9f7003c2c397074a
{ "head_commit": "eb4765c20916b031a4fc63ab0c8740337a5cd3ff", "head_commit_message": "TST: fix the error message match", "patch_to_review": "diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst\nindex e9a1f831a7c32..21a466e433b64 100644\n--- a/doc/whats_new/v0.20.rst\n+++ b/doc/whats_new/v0.20.rst\n@@ -3...
[ { "diff_hunk": "@@ -36,6 +36,15 @@ Changelog\n threaded when `n_jobs > 1` or `n_jobs = -1`.\n :issue:`13005` by :user:`Prabakaran Kumaresshan <nixphix>`.\n \n+:mod:`sklearn.impute`\n+.....................\n+\n+- |Fix| add support for non-numeric data in\n+ :class:`sklearn.impute.MissingIndicator` which was...
0b5a96da5e836601d96a4b02220050bcc5f257f2
diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst index acf2087d4f611..3483b173dcb16 100644 --- a/doc/whats_new/v0.20.rst +++ b/doc/whats_new/v0.20.rst @@ -36,6 +36,15 @@ Changelog threaded when `n_jobs > 1` or `n_jobs = -1`. :issue:`13005` by :user:`Prabakaran Kumaresshan <nixphix>`. +:mod:`sklear...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12950@06f807d
scikit-learn/scikit-learn
Python
12,950
[MRG] DOC Mention StandardScaler ddof
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs Fixes #7757 <!-- Example: Fixes #1234. See also #3456. Please use key...
2019-01-10T16:25:16Z
StandardScaler that supports option to use unbiased estimator of variance #### Description It would be nice to provide StandardScaler with an option to chose unbiased estimator of variance, It it sometimes convenient to use unbiased estimator of variance: numpy.var(X, ddof=1) instead of default: numpy.var(X, ddof=0) ...
Does it really matter? It seems to me that it's one of those things that people (academics in particular) love to argue, but has no impact on something like predictive accuracy in realistic settings. PS: don't read me wrong, I am an academic. I love to argue. But I try to do that in papers, not software. No problem. ...
[ { "body": "#### Description\n\nIt would be nice to provide StandardScaler with an option to chose unbiased estimator of variance,\n\nIt it sometimes convenient to use unbiased estimator of variance: numpy.var(X, ddof=1)\ninstead of default: numpy.var(X, ddof=0)\n\nSo far StandardScaler does not allow to set ddo...
0eda10a598b3ae988f7d8c116089045474248d62
{ "head_commit": "06f807df4f2168fa4f77d25f9ee630c135c5fc87", "head_commit_message": "Add message explaning it's unlikely that the choice of estimator would affect model performance.", "patch_to_review": "diff --git a/sklearn/preprocessing/data.py b/sklearn/preprocessing/data.py\nindex b78f1c11fab96..529a2c76ebbff...
[ { "diff_hunk": "@@ -478,7 +478,10 @@ class StandardScaler(BaseEstimator, TransformerMixin):\n \n where `u` is the mean of the training samples or zero if `with_mean=False`,\n and `s` is the standard deviation of the training samples or one if\n- `with_std=False`.\n+ `with_std=False`. Note that `s`...
b62c70d8ceaea6871fe9910c88df071144b00414
diff --git a/sklearn/preprocessing/data.py b/sklearn/preprocessing/data.py index b78f1c11fab96..9cf2dec48f139 100644 --- a/sklearn/preprocessing/data.py +++ b/sklearn/preprocessing/data.py @@ -123,6 +123,10 @@ def scale(X, axis=0, with_mean=True, with_std=True, copy=True): NaNs are treated as missing values: disre...
{ "difficulty": "low", "estimated_review_effort": 1, "problem_domain": "New Feature Additions" }
ray-project__ray-53902@1a1623a
ray-project/ray
Python
53,902
[core][gpu-objects] Support `ray.get` on the driver process for GPU objects
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-06-17T23:01:14Z
[core][gpu-objects] Driver tries to get the data from in-actor store ### Description The driver is not allowed to be in an NCCL group in Ray GPU objects. Hence, if the driver wants to retrieve data from the in-actor store, we can move the data from the in-actor store to the object store so that the driver can access i...
[ { "body": "### Description\n\nThe driver is not allowed to be in an NCCL group in Ray GPU objects. Hence, if the driver wants to retrieve data from the in-actor store, we can move the data from the in-actor store to the object store so that the driver can access it.\n\n### Use case\n\n_No response_", "numbe...
b4727db209e8663d6c14962af5df9011481a057b
{ "head_commit": "1a1623a5260069c24e544d8768980bc738df5e4e", "head_commit_message": "update\n\nSigned-off-by: kaihsun <kaihsun@anyscale.com>", "patch_to_review": "diff --git a/python/ray/_private/gpu_object_manager.py b/python/ray/_private/gpu_object_manager.py\nindex f1c3857767b2..0761f55fe3fd 100644\n--- a/pyth...
[ { "diff_hunk": "@@ -79,6 +83,19 @@ def __ray_get_tensor_meta__(self, obj_id: str):\n \n return src_actor.__ray_call__.remote(__ray_get_tensor_meta__, obj_id)\n \n+ def is_driver(self, obj_id: str) -> bool:", "line": null, "original_line": 86, "original_start_line": null, "path": "pyth...
c923971814d52ebc7fb11d30642ab70b4f517598
diff --git a/python/ray/_private/gpu_object_manager.py b/python/ray/_private/gpu_object_manager.py index f1c3857767b2..4c17cf1bd13b 100644 --- a/python/ray/_private/gpu_object_manager.py +++ b/python/ray/_private/gpu_object_manager.py @@ -1,5 +1,6 @@ from typing import TYPE_CHECKING, Any, Dict, List, NamedTuple, Optio...
{ "difficulty": "medium", "estimated_review_effort": 4, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12874@d4a04fd
scikit-learn/scikit-learn
Python
12,874
[MRG] Added tips for reading the code base
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fi...
2018-12-27T15:43:31Z
Creation of a 'Reading scikit-learn code' section in the docs? Would you welcome a new subsection in (e.g.) the contributing guide, giving pointers on how to actually read and digest the existing code base? This could be a mix between general and sklearn-specific tips. Lots of things may seem obvious for experienced...
I personally like these kinda docs. Makes people less scared of reading code. We could put it under https://scikit-learn.org/stable/developers/tips.html > Any suggestion welcome. "Use `git grep` to see where a particular function / estimator is used in a code base" +1, we can make use of the glossary. > We cou...
[ { "body": "Would you welcome a new subsection in (e.g.) the contributing guide, giving pointers on how to actually read and digest the existing code base? This could be a mix between general and sklearn-specific tips.\r\n\r\nLots of things may seem obvious for experienced programmers and contributors, but less ...
7455078880c1f7f890ae0ae6b20efbc780cf964a
{ "head_commit": "d4a04fd3fcb9f847ca3b03e4c0a1179542c31efa", "head_commit_message": "Added bullet point about inheritance", "patch_to_review": "diff --git a/doc/developers/contributing.rst b/doc/developers/contributing.rst\nindex a1a6068d53623..d4ab9c66deb0f 100644\n--- a/doc/developers/contributing.rst\n+++ b/do...
[ { "diff_hunk": "@@ -1395,3 +1395,62 @@ that implement common linear model patterns.\n \n The :mod:`sklearn.utils.multiclass` module contains useful functions\n for working with multiclass and multilabel problems.\n+\n+Reading the existing code base\n+==============================\n+\n+Reading and digesting an ...
3a97f5696e98179e188e1b5af1697f08000c81a1
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 32ca91f49f6aa..bca3508478ba5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,6 +34,7 @@ Quick links to: * [Submitting a bug report or feature request](http://scikit-learn.org/dev/developers/contributing.html#submitting-a-bug-report-or-a-feature-request) *...
{ "difficulty": "low", "estimated_review_effort": 1, "problem_domain": "Documentation Updates" }
ray-project__ray-53598@d526a2c
ray-project/ray
Python
53,598
Fix python executable path for ray nsight configuration
## Why are these changes needed? Not all systems are guaranteed to have "python" be the way that the python interpreter is invoked on the command line. The proper way to find python is to use `sys.executable`. This hardcoded "python" was breaking workflows within my Ubuntu 22.04 training environment. ## Related i...
2025-06-05T22:26:29Z
Nsight GPU profiling unable to run on systems that don't have a "python" on the PATH ### What happened + What you expected to happen Ever since the end-of-life of Python 2, many Linux distributions (including Ubuntu) do not have a command by default named "python". Oftentimes python has to be invoked with "python3" si...
[ { "body": "### What happened + What you expected to happen\n\nEver since the end-of-life of Python 2, many Linux distributions (including Ubuntu) do not have a command by default named \"python\". Oftentimes python has to be invoked with \"python3\" since \"python\" is historically an alias to Python 2 on syste...
0e53e1ddc84662adbffbddcb7e3ff5d845747838
{ "head_commit": "d526a2c09af644e1e4a1f491d7adcab47547664d", "head_commit_message": "Fix python executable path for ray nsight configuration\n\nSigned-off-by: Shishir Bhat <shishirvbhat@gmail.com>", "patch_to_review": "diff --git a/python/ray/_private/runtime_env/nsight.py b/python/ray/_private/runtime_env/nsight...
[ { "diff_hunk": "@@ -71,7 +71,8 @@ async def _check_nsight_script(\n nsight_config_copy[\"o\"] = str(Path(self._nsight_dir) / \"empty\")\n nsight_cmd = parse_nsight_config(nsight_config_copy)\n try:\n- nsight_cmd = nsight_cmd + [\"python\", \"-c\", '\"\"']\n+ python_...
48b34779b08a39c3e915558e7c39521a550641d2
diff --git a/python/ray/_private/runtime_env/nsight.py b/python/ray/_private/runtime_env/nsight.py index 91b012db347b..15cdecf0b114 100644 --- a/python/ray/_private/runtime_env/nsight.py +++ b/python/ray/_private/runtime_env/nsight.py @@ -71,7 +71,7 @@ async def _check_nsight_script( nsight_config_copy["o"] = ...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Dependency Updates & Env Compatibility" }
scikit-learn__scikit-learn-12908@337bb2b
scikit-learn/scikit-learn
Python
12,908
[MRG + 2] Add Drop Option to OneHotEncoder.
#### Reference Issues/PRs Fixes #6488 and fixes #6053. This builds upon some of the code from #12884 (thanks @NicolasHug!), but also incorporates functionality which lets the user manually specify which category in each column they would like to be dropped, so this is a more general solution along the lines of what ...
2019-01-03T04:21:02Z
OneHotEncoding - Defining a reference category In order to avoid multicollinearity in modelling, the number of dummy-coded variables needed should be one less than the number of categories. Therefore, it would be very code if OneHotEncoding could accept a reference category as an input variable. OneHotEncoder - add...
not sure if that was raise somewhere already. multicollinearity is really not a problem in any model in scikit-learn. But feel free to create a pull-request. The OneHotEncoder is being restructured quite heavily right now, though. I'm interested in working on this feature! I ran into some problems using a OneHotEncode...
[ { "body": "In order to avoid multicollinearity in modelling, the number of dummy-coded variables needed should be one less than the number of categories. Therefore, it would be very code if OneHotEncoding could accept a reference category as an input variable. \n", "number": 6053, "title": "OneHotEncodi...
314686a65d543bd3b36d2af4b34ed23711991a57
{ "head_commit": "337bb2b0ea71417739abe7d6c4363c57e67d6c32", "head_commit_message": "Removed unnecessary loop on transform step", "patch_to_review": "diff --git a/doc/modules/preprocessing.rst b/doc/modules/preprocessing.rst\nindex 54210f2453cb0..3689ef6e95734 100644\n--- a/doc/modules/preprocessing.rst\n+++ b/do...
[ { "diff_hunk": "@@ -571,11 +671,23 @@ def _transform_new(self, X):\n \n X_int, X_mask = self._transform(X, handle_unknown=self.handle_unknown)\n \n+ if self.drop is not None:\n+ max_val = max(len(cats) for cats in self.categories_)\n+ to_drop = np.array([pos if pos is not No...
7149eac73e756c48817afa79fd7c50831caf73f5
diff --git a/doc/modules/preprocessing.rst b/doc/modules/preprocessing.rst index 77abe294a331b..7b7c447beb34d 100644 --- a/doc/modules/preprocessing.rst +++ b/doc/modules/preprocessing.rst @@ -489,7 +489,7 @@ Continuing the example above:: >>> enc = preprocessing.OneHotEncoder() >>> X = [['male', 'from US', 'uses...
{ "difficulty": "medium", "estimated_review_effort": 4, "problem_domain": "New Feature Additions" }
spyder-ide__spyder-24382@3b8b1e4
spyder-ide/spyder
Python
24,382
PR : Move files to the OS trash can when deleting them in Files or Projects
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-05-09T06:05:21Z
Files are not moved to the operating system trash can after deleting them in Files or Projects ## Problem Description Hi, I've reported this again in the past but the issue has not been resolved. I am running Spyder under Ubuntu and when I try to delete a file from the file explorer it triggers a permanent delete o...
Hi @cyiannaki sorry for the late response and not addressing any previous issue! This seems indeed like quite a serious bug! Could you link to this issue the previous ones please? I did a quick check on Windows but I was unable to reproduce this :thinking: Pinging @ccordoba12 (which maybe could be able to check on L...
[ { "body": "## Problem Description\r\nHi,\r\n\r\nI've reported this again in the past but the issue has not been resolved. I am running Spyder under Ubuntu and when I try to delete a file from the file explorer it triggers a permanent delete of the folder with all my work. \r\n\r\n\r\n### What steps reproduce th...
e98ea080de4c13619268fa3edd205d2394f43060
{ "head_commit": "3b8b1e45aaa7ec381d7b08bc60a0d1170ecdb8e1", "head_commit_message": "Merge branch 'master' into deleteFiles", "patch_to_review": "diff --git a/spyder/plugins/explorer/widgets/explorer.py b/spyder/plugins/explorer/widgets/explorer.py\nindex 34fb0578915..a0240489234 100644\n--- a/spyder/plugins/expl...
[ { "diff_hunk": "@@ -26,7 +27,7 @@ def __remove_pyc_pyo(fname):\n if osp.splitext(fname)[1] == '.py':\n for ending in ('c', 'o'):\n if osp.exists(fname + ending):\n- os.remove(fname + ending)\n+ QFile.moveToTrash(fname + ending)", "line": null, "origi...
625d9c05f16dfbae6b0e8beacb54df8945e5fe8c
diff --git a/spyder/plugins/explorer/widgets/explorer.py b/spyder/plugins/explorer/widgets/explorer.py index b1cc496a5b4..fe978a619a3 100644 --- a/spyder/plugins/explorer/widgets/explorer.py +++ b/spyder/plugins/explorer/widgets/explorer.py @@ -23,6 +23,7 @@ from qtpy.compat import getexistingdirectory, getsavefilenam...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12834@74cb798
scikit-learn/scikit-learn
Python
12,834
Fix predict method for multiclass multioutput ensemble models
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs Fixes #12831. <!-- Example: Fixes #1234. See also #3456. Please use key...
2018-12-19T22:36:36Z
`predict` fails for multioutput ensemble models with non-numeric DVs #### Description <!-- Example: Joblib Error thrown when calling fit on LatentDirichletAllocation with evaluate_every > 0--> Multioutput forest models assume that the dependent variables are numeric. Passing string DVs returns the following error: ...
Is numeric-only an intentional limitation in this case? There are lines that explicitly cast to double (https://github.com/scikit-learn/scikit-learn/blob/e73acef80de4159722b11e3cd6c20920382b9728/sklearn/ensemble/forest.py#L279). It's not an issue for single-output models, though. Sorry what do you mean by "DV"? You're ...
[ { "body": "#### Description\r\n<!-- Example: Joblib Error thrown when calling fit on LatentDirichletAllocation with evaluate_every > 0-->\r\nMultioutput forest models assume that the dependent variables are numeric. Passing string DVs returns the following error:\r\n\r\n`ValueError: could not convert string to ...
55a98ab7e3b10966f6d00c3562f3a99896797964
{ "head_commit": "74cb798532fd9753a765a879f118f18442510ef6", "head_commit_message": "BUG fix predict method for multiclass multioutput ensemble models", "patch_to_review": "diff --git a/sklearn/ensemble/forest.py b/sklearn/ensemble/forest.py\nindex 33d166d00969e..579d3f3d7b94f 100644\n--- a/sklearn/ensemble/fores...
[ { "diff_hunk": "@@ -548,6 +548,37 @@ def test_multioutput(name):\n check_multioutput(name)\n \n \n+@pytest.mark.filterwarnings('ignore:The default value of n_estimators')\n+@pytest.mark.parametrize('name', FOREST_CLASSIFIERS)\n+def test_multioutput_string(name):\n+ # Check estimators on multi-output prob...
87af94745ee8abaa341b5baa0e983dbf539b1666
diff --git a/doc/whats_new/v0.21.rst b/doc/whats_new/v0.21.rst index bcd06966e72d9..493de1d23892c 100644 --- a/doc/whats_new/v0.21.rst +++ b/doc/whats_new/v0.21.rst @@ -77,6 +77,10 @@ Support for Python 3.4 and below has been officially dropped. the gradients would be incorrectly computed in multiclass classificatio...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-24485@f64a525
spyder-ide/spyder
Python
24,485
PR: Add action and shortcut to Variable explorer editors to easily close them
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-05-27T05:56:49Z
Variable explorer : multiple windows open and impossible to close them with shortcuts ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> In the variable explorer pane multiple windows open when clicking on a variable (say a list) but they do not update whenever we ru...
Hey @JulietteCx, thanks for reporting. You said: > In the variable explorer pane multiple windows open when clicking on a variable (say a list) but they do not update whenever we run the code again This will change in Spyder 6 because we added a refresh button to our viewers. So users will be able to update them ...
[ { "body": "## Description\r\n\r\n### What steps will reproduce the problem?\r\n\r\n<!--- You can use Markdown here --->\r\n\r\nIn the variable explorer pane multiple windows open when clicking on a variable (say a list) but they do not update whenever we run the code again, nor get closed automatically. This re...
6923d7bf489da54c425c7ee85d69a1e1addedc74
{ "head_commit": "f64a525f5ad795ac280ffdf018fcc18857025d4b", "head_commit_message": "add shortcuts to menu", "patch_to_review": "diff --git a/spyder/api/widgets/mixins.py b/spyder/api/widgets/mixins.py\nindex 691c13f604b..b4e276311d6 100644\n--- a/spyder/api/widgets/mixins.py\n+++ b/spyder/api/widgets/mixins.py\n...
[ { "diff_hunk": "@@ -182,7 +188,11 @@ def set_value(self, obj):\n \n # Add menu item for toggling columns to the Options menu\n for action in self.obj_tree.toggle_column_actions_group.actions():\n- self.add_item_to_menu(action, self.show_cols_submenu)\n+ self.add_item_to_men...
15982c9940daef5313b911f27b400f1d6ca14c97
diff --git a/spyder/api/widgets/mixins.py b/spyder/api/widgets/mixins.py index 691c13f604b..cb1e7c9b372 100644 --- a/spyder/api/widgets/mixins.py +++ b/spyder/api/widgets/mixins.py @@ -257,14 +257,19 @@ class SpyderMenuMixin: """ def add_item_to_menu(self, action_or_menu, menu, section=None, - ...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-13000@3ebd308
scikit-learn/scikit-learn
Python
13,000
[MRG] Fixes cross-reference and no reference issues in sphinx
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fi...
2019-01-17T04:19:44Z
Fix 'any' doc build warnings Changing the default role to ``any`` in sphinx created loads of warnings, which makes it hard to see actual warnings from sphinx. We should see if we can fix this. One way would be to use single backticks only if there is actually something to reference, the other is to somehow silence th...
+1 for working out how to silence the warnings. A warnings.filterwarnings in conf.py matching the message might suffice?? Or does shpinx log its warnings by some other mechanism?
[ { "body": "Changing the default role to ``any`` in sphinx created loads of warnings, which makes it hard to see actual warnings from sphinx.\r\nWe should see if we can fix this.\r\nOne way would be to use single backticks only if there is actually something to reference, the other is to somehow silence the warn...
49570484db668ffa1f6d8ea16c4c62c8ef096a06
{ "head_commit": "3ebd30898af1a2dad79db0c0854f9a1cb1a123e8", "head_commit_message": "RFC: Adds early exit", "patch_to_review": "diff --git a/doc/conf.py b/doc/conf.py\nindex a8a2a58089dce..7b84d72c75c1a 100644\n--- a/doc/conf.py\n+++ b/doc/conf.py\n@@ -38,6 +38,7 @@\n 'sphinx.ext.imgconverter',\n 'sphinx_...
[ { "diff_hunk": "@@ -0,0 +1,83 @@\n+\"\"\"Adapted from\n+sphinx.transforms.post_transforms.ReferencesResolver.resolve_anyref\n+\n+If 'py' is one of the domains and `py:class` is defined,\n+the Python domain will be processed before the 'std' domain.\n+\"\"\"\n+from contextlib import suppress\n+\n+from docutils i...
b94b598c8525ed68c5d14078796f4bd06b7d3f54
diff --git a/doc/conf.py b/doc/conf.py index 62577466a0f02..7b8a7d19414fc 100644 --- a/doc/conf.py +++ b/doc/conf.py @@ -37,6 +37,7 @@ 'sphinx.ext.imgconverter', 'sphinx_gallery.gen_gallery', 'sphinx_issues', + 'custom_references_resolver' ] # this is needed for some reason... @@ -102,6 +103,10 @@...
{ "difficulty": "medium", "estimated_review_effort": 4, "problem_domain": "Documentation Updates" }
spyder-ide__spyder-24338@24947e0
spyder-ide/spyder
Python
24,338
PR: Make Editor annotations work in lower case
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-05-02T14:16:23Z
Make Editor annotations work in lower case <!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! ---> ## Problem Description editor code annotations (available via preferences > editor...
Hi @kr-g thank you for the feedback! I think `@todo` should trigger a marker too, kind of like a workaround but is that an option for you? Or maybe in general you would like for all the annotations that trigger a mark to be case insentive? So instead of the mark being triggered by only `TODO`, `FIXME`, `XXX`, `HINT`, `...
[ { "body": "<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->\r\n\r\n\r\n## Problem Description\r\n\r\neditor code annotations (available via preferences > editor > advanced se...
5de52e8ceeed3c620ad37f1671a4e520cbc069ff
{ "head_commit": "24947e0eb150ac21dbf5f1ffe2df8e149c8c7039", "head_commit_message": "Make Editor annotations work in lower case", "patch_to_review": "diff --git a/spyder/plugins/editor/utils/findtasks.py b/spyder/plugins/editor/utils/findtasks.py\nindex 1e7ce44716c..8928bfabe39 100644\n--- a/spyder/plugins/editor...
[ { "diff_hunk": "@@ -18,8 +18,9 @@\n # =============================================================================\n # Find tasks - TODOs\n # =============================================================================\n-TASKS_PATTERN = r\"(^|#)[ ]*(TODO|FIXME|XXX|HINT|TIP|@todo|\" \\\n- r\"HAC...
489c2758ae83df4fda6daf59237d299c76c4bd18
diff --git a/spyder/plugins/editor/utils/findtasks.py b/spyder/plugins/editor/utils/findtasks.py index 1e7ce44716c..b1f9b0b67c6 100644 --- a/spyder/plugins/editor/utils/findtasks.py +++ b/spyder/plugins/editor/utils/findtasks.py @@ -18,8 +18,10 @@ # =====================================================================...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12803@00202fe
scikit-learn/scikit-learn
Python
12,803
[MRG+1] Adds multilabels permutation tests to metrics/test_common
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs Fixes #12309 for multilabel and multioutput #### What does this imple...
2018-12-17T19:20:17Z
add multiclass and multilabel metric tests for label permutations Multiclass and multilabel metrics should be invariant to labeling the columns. That should be tested in ``metrics/test_common.py``. I haven't checked if there's a test for standard multiclass, but there's none for thresholded metrics.
[ { "body": "Multiclass and multilabel metrics should be invariant to labeling the columns.\r\nThat should be tested in ``metrics/test_common.py``.\r\nI haven't checked if there's a test for standard multiclass, but there's none for thresholded metrics.", "number": 12309, "title": "add multiclass and mult...
cd8fe168fbc2c5cfe1cb11a1cfbd7a1b7aec0acc
{ "head_commit": "00202fe7fb1642e38d16d8c50a3246d10b396b4c", "head_commit_message": "RFC: Removes unneeded code", "patch_to_review": "diff --git a/sklearn/metrics/tests/test_common.py b/sklearn/metrics/tests/test_common.py\nindex 7c393f81ce10f..6111c785bb5c5 100644\n--- a/sklearn/metrics/tests/test_common.py\n+++...
[ { "diff_hunk": "@@ -1201,3 +1203,53 @@ def test_no_averaging_labels():\n score_labels = metric(y_true, y_pred, labels=labels, average=None)\n score = metric(y_true, y_pred, average=None)\n assert_array_equal(score_labels, score[inverse_labels])\n+\n+\n+@pytest.mark.parametriz...
35d2651c73b821be97d1a1906f8a11ce23f7bd47
diff --git a/sklearn/metrics/tests/test_common.py b/sklearn/metrics/tests/test_common.py index 7c393f81ce10f..de304feb47847 100644 --- a/sklearn/metrics/tests/test_common.py +++ b/sklearn/metrics/tests/test_common.py @@ -3,6 +3,7 @@ from functools import partial from itertools import product from itertools import ch...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Test Suite / CI Enhancements" }
ray-project__ray-52631@e810a65
ray-project/ray
Python
52,631
[data.llm] Deserialize arrays for sampling_params
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? This solves the issue described in https://github.com/ray-project/ray/issues/52630 Some vllm sampling params ...
2025-04-26T18:55:09Z
[`build_llm_processor` throws deserialization error for `stop_token_ids`: LLM>] ### What happened + What you expected to happen Thanks for the awesome LLM abstractions. I found a bug in it that needs a simple fix. Some vllm sampling params such as `stop_token_ids` are lists and hence get converted to np.arrays. We ne...
[ { "body": "### What happened + What you expected to happen\n\nThanks for the awesome LLM abstractions. I found a bug in it that needs a simple fix.\nSome vllm sampling params such as `stop_token_ids` are lists and hence get converted to np.arrays. We need to call the `self._maybe_convert_ndarray_to_list` on the...
8374f38cecd0cb789e783c16a56a97a8fcdbec7b
{ "head_commit": "e810a65d8e3912ecbebb79ee422f7ce0d1b039c3", "head_commit_message": "fix: deserialize arrays in vllm sampling_params\n\nSigned-off-by: Arthur <atte.book@gmail.com>", "patch_to_review": "diff --git a/python/ray/llm/_internal/batch/stages/vllm_engine_stage.py b/python/ray/llm/_internal/batch/stages/...
[ { "diff_hunk": "@@ -301,7 +301,7 @@ async def _prepare_llm_request(self, row: Dict[str, Any]) -> vLLMEngineRequest:\n else:\n guided_decoding = None\n params = vllm.SamplingParams(\n- **sampling_params,\n+ **self._maybe_convert_ndarray_to_lis...
509d7ffe9555ee8d81ff466d82ea81b7b87c483d
diff --git a/python/ray/llm/_internal/batch/stages/common.py b/python/ray/llm/_internal/batch/stages/common.py new file mode 100644 index 000000000000..fb0869642991 --- /dev/null +++ b/python/ray/llm/_internal/batch/stages/common.py @@ -0,0 +1,29 @@ +""" +Shared utilities for stages. +""" + +from typing import Any, Dic...
{ "difficulty": "medium", "estimated_review_effort": 2, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-24074@b688e4f
spyder-ide/spyder
Python
24,074
PR: Improve message when trying to view object with an attribute that references a generator
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-03-28T03:40:55Z
Variable Explorer error when class has attribute that references a generator ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> I hit the 'reload' button in the corner of the variable explorer. It was open to the class I was looking at. It crashed as soon as I hit it. #...
I've continued to look at the code I wrote. This seems to happen when I have a method inside of another method. I pulled the inner method out and made it a staticmethod. As soon as I did that, the variable explorer was able to see the class again. I don't know if that is helpful for others or not, but I know this i...
[ { "body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nI hit the 'reload' button in the corner of the variable explorer. It was open to the class I was looking at. It crashed as soon as I hit it.\n\n### Traceback\n```python-traceback\nTraceback (most...
5b30b090f05e36c8c4bc4ca9d2f831250126d263
{ "head_commit": "b688e4f18f519bdcfa1f47ee58c882f2ff5b62f1", "head_commit_message": "Merge branch 'master' into generatorsPickle", "patch_to_review": "diff --git a/spyder/plugins/ipythonconsole/widgets/namespacebrowser.py b/spyder/plugins/ipythonconsole/widgets/namespacebrowser.py\nindex 6458371693a..5a7eaaef406 ...
[ { "diff_hunk": "@@ -42,7 +42,7 @@ def get_value(self, name):\n reason_big = _(\"The variable is too big to be retrieved\")\n reason_not_picklable = _(\n \"It was not possible to create a copy of the variable in the \"\n- \"kernel to pass it to Spyder.\"\n+ \"ker...
ae3be1bb621b51ea35378540d9755aa01fceb4d4
diff --git a/spyder/plugins/ipythonconsole/widgets/namespacebrowser.py b/spyder/plugins/ipythonconsole/widgets/namespacebrowser.py index 6458371693a..935e7e612d4 100644 --- a/spyder/plugins/ipythonconsole/widgets/namespacebrowser.py +++ b/spyder/plugins/ipythonconsole/widgets/namespacebrowser.py @@ -42,7 +42,10 @@ def ...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-24176@4674726
spyder-ide/spyder
Python
24,176
PR: Add Matplotlib font cache message to benign errors (IPython console)
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-04-08T02:46:11Z
Error in console with message `Matplotlib is building the font cache; this may take a moment.` ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> Hello, I recently updated Spyder using Anaconda and insde the iPython console I keep getting the following error: "An error occ...
Hey @audreyc38, thanks for reporting. You said: > The console has not been available to me since I updated Spyder several days ago (I have given it many "moments" to build the font cache) and I'm not sure how to resolve. Does this happen to you for any console you open or only for the first one? In any case, we'll f...
[ { "body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nHello, I recently updated Spyder using Anaconda and insde the iPython console I keep getting the following error:\n\"An error occured while starting the kernel\nMatplotlib is building the font cach...
f3f0b4b6a2c3bacc37e71e62f4a72f791aa915de
{ "head_commit": "467472694b5b882031784d5274fec6e8f16a87b6", "head_commit_message": "add matplotlib error to benign messages", "patch_to_review": "diff --git a/spyder/plugins/ipythonconsole/widgets/client.py b/spyder/plugins/ipythonconsole/widgets/client.py\nindex 55b71f92f1f..529b15e0d98 100644\n--- a/spyder/plu...
[ { "diff_hunk": "@@ -557,6 +557,8 @@ def is_benign_error(self, error):\n \"The system cannot find the path specified\",\n # UNC paths, see spyder-ide/spyder#23726\n \" UNC \",\n+ # Matplotlib error, see spyder-ide/spyder#23726", "line": null, "original_line"...
c1af3abae7ade5bfad9a291c873249899f8e6d64
diff --git a/spyder/plugins/ipythonconsole/widgets/client.py b/spyder/plugins/ipythonconsole/widgets/client.py index 55b71f92f1f..4d49c317576 100644 --- a/spyder/plugins/ipythonconsole/widgets/client.py +++ b/spyder/plugins/ipythonconsole/widgets/client.py @@ -557,6 +557,8 @@ def is_benign_error(self, error): ...
{ "difficulty": "low", "estimated_review_effort": 1, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-24105@0ed56ae
spyder-ide/spyder
Python
24,105
PR: Respect case sensitivity of working directory when running code (IPython console)
## Description of Changes - We were setting the current working directory to be in lowercase on Windows after running/debugging a file, which didn't allow to make proper path comparisons in code. - Depends on https://github.com/spyder-ide/spyder-kernels/pull/536 ### Issue(s) Resolved <!--- List the issue(s) b...
2025-04-01T03:36:50Z
Initial runfile changes cwd to lowercase version which fails all code needing case sensitive paths I am using the latest version of Spyder through Anaconda, but this problem started with the first version of spyder 6+. On launch, my path is correctly reflected in the working directory field if I import os in the consol...
Hey @DeltaMod, thanks for reporting. We were not aware of this problem, so thanks for bringing it up to our attention. We'll try to fix it in 6.0.6, to be released in a couple of months. @dalthviz, are you able to reproduce this one? I think I was able to reproduce this: ![Image](https://github.com/user-attachments/a...
[ { "body": "I am using the latest version of Spyder through Anaconda, but this problem started with the first version of spyder 6+.\nOn launch, my path is correctly reflected in the working directory field\nif I import os in the console, and use os.getcwd() it outputs a correctly formatted uppercase cwd (C://Use...
5b30b090f05e36c8c4bc4ca9d2f831250126d263
{ "head_commit": "0ed56ae1064bad8bd3389177ebb96239b5b4da79", "head_commit_message": "add test", "patch_to_review": "diff --git a/external-deps/spyder-kernels/.gitrepo b/external-deps/spyder-kernels/.gitrepo\nindex ddc441685ab..dcce1ff92e1 100644\n--- a/external-deps/spyder-kernels/.gitrepo\n+++ b/external-deps/sp...
[ { "diff_hunk": "@@ -2516,5 +2516,37 @@ def test_filter_frames_in_tracebacks(ipyconsole, qtbot, tmp_path):\n assert \"BdbQuit\" not in control.toPlainText()\n \n \n+def test_lowercase_wdir(ipyconsole, qtbot, tmp_path):\n+\n+ shell = ipyconsole.get_current_shellwidget()\n+ control = shell._control\n+ ...
98f87f43701ab577277dc6cbd1d351469c71c2a0
diff --git a/external-deps/spyder-kernels/.gitrepo b/external-deps/spyder-kernels/.gitrepo index ddc441685ab..bb08a4c4c23 100644 --- a/external-deps/spyder-kernels/.gitrepo +++ b/external-deps/spyder-kernels/.gitrepo @@ -6,7 +6,7 @@ [subrepo] remote = https://github.com/spyder-ide/spyder-kernels.git branch = maste...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12822@c451532
scikit-learn/scikit-learn
Python
12,822
[MRG] improve tfidfvectorizer documentation
#### Referencing PR / Issue This closes #12204 This also closes #6766 and closes #9369 This also closes #12811 (which is including the wrong file in my PR). #### Note This adds more information in the TfidfVectorizer documentation. It now includes comments about CountVectorizer and TfidfTransformer. cc: @blo...
2018-12-18T22:52:58Z
TfidfVectorizer documentation doesn't track TfidfTransformer There are important details of the tf-idf transformation in the TfidfTransformer that are not reflected in the TfidfVectorizer's docstring. I think they should be added there. Also, I think the formula that is used should be added to the narrative.
Actually, I'm not entirely happy with the documentation of TfidfTransformer. Finding out what the actual formula is it uses by default is non-trivial. also see #4391, #2998 and neither documents the default value of "norm". slightly unrelated: the `_document_frequency` function is badly misnamed. It computes documen...
[ { "body": "There are important details of the tf-idf transformation in the TfidfTransformer that are not reflected in the TfidfVectorizer's docstring. I think they should be added there.\nAlso, I think the formula that is used should be added to the narrative.\n", "number": 6766, "title": "TfidfVectoriz...
39db9c4eca8d782932040e997d4e87ed9f450169
{ "head_commit": "c451532bf834d8aa910ffe87b1645b1bfec58f70", "head_commit_message": "for TfidfTransformer, added parameter type", "patch_to_review": "diff --git a/sklearn/feature_extraction/text.py b/sklearn/feature_extraction/text.py\nindex abe63f3650f8f..2807ed5adfaba 100644\n--- a/sklearn/feature_extraction/te...
[ { "diff_hunk": "@@ -1440,6 +1440,28 @@ class TfidfVectorizer(CountVectorizer):\n sublinear_tf : boolean, default=False\n Apply sublinear tf scaling, i.e. replace tf with 1 + log(tf).\n \n+ CountVectorizer : sparse matrix, (n_samples, n_features)", "line": null, "original_line": 1443, ...
32c1eea3d0a7a2b26ee6279f23119beacc30b13d
diff --git a/sklearn/feature_extraction/text.py b/sklearn/feature_extraction/text.py index b20fadf9a86b1..675842e1bea93 100644 --- a/sklearn/feature_extraction/text.py +++ b/sklearn/feature_extraction/text.py @@ -169,7 +169,7 @@ def _word_ngrams(self, tokens, stop_words=None): space_join = " ".join ...
{ "difficulty": "low", "estimated_review_effort": 1, "problem_domain": "Documentation Updates" }
scikit-learn__scikit-learn-12656@734a345
scikit-learn/scikit-learn
Python
12,656
Handling parameter labels removal from hamming_loss
#### Referencing PR / Issue This fixes #10580, fixes #10582, closes #12210 #### Note Sorry to open another PR. I tried to `fetch` the open one, but ended up with 50+ `flake8` errors, so I began from scratch. cc: @SandraMNE #wimlds
2018-11-22T23:13:24Z
hamming_loss should not have a labels parameter hamming_loss only uses `labels` in the case where the input is multilabel. Then, it only uses the number of labels, which is identical to `y_true.shape[1]`. So it's completely unnecessary. I think we should either: * deprecate and remove it. (My preference) * allow i...
Can I take this? I think so Shall we remove `classes` parameter at the same time? Since it is deprecated since 0.18 and will be removed in 0.20. I think there is already a PR to do so... Don't worry about it here. I am working on this
[ { "body": "hamming_loss only uses `labels` in the case where the input is multilabel. Then, it only uses the number of labels, which is identical to `y_true.shape[1]`. So it's completely unnecessary.\r\n\r\nI think we should either:\r\n* deprecate and remove it. (My preference)\r\n* allow it to specify a subset...
52e9cc5add6ffe6398fed529f5f110f0961ad28a
{ "head_commit": "734a345bfff48cb14a45de9aa642372775d7ad80", "head_commit_message": "added space before |API|", "patch_to_review": "diff --git a/doc/whats_new/v0.21.rst b/doc/whats_new/v0.21.rst\nindex a9c553fa06ad6..d15bbab368e96 100644\n--- a/doc/whats_new/v0.21.rst\n+++ b/doc/whats_new/v0.21.rst\n@@ -116,6 +11...
[ { "diff_hunk": "@@ -1805,11 +1805,16 @@ def hamming_loss(y_true, y_pred, labels=None, sample_weight=None):\n y_pred : 1d array-like, or label indicator array / sparse matrix\n Predicted labels, as returned by a classifier.\n \n- labels : array, shape = [n_labels], optional (default=None)\n+ la...
51d06b8f16b8186c4c5eec03bf6c07894eb4dc63
diff --git a/doc/whats_new/v0.21.rst b/doc/whats_new/v0.21.rst index a9c553fa06ad6..98fc00932fede 100644 --- a/doc/whats_new/v0.21.rst +++ b/doc/whats_new/v0.21.rst @@ -116,6 +116,11 @@ Support for Python 3.4 and below has been officially dropped. :issue:`12334` by :user:`Emmanuel Arias <eamanu@eamanu.com>`, `Joe...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12887@c313151
scikit-learn/scikit-learn
Python
12,887
[MRG] Adds Minimal Cost-Complexity Pruning to Decision Trees
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fi...
2018-12-29T19:27:47Z
add post-pruning for decision trees I frequently get asked about post-pruning. Often using single trees is important for interpretability, and post-pruning can help both interpretability and generalization performance. [I'm surprised there is no open issue on this, but I couldn't find one]
I can give this a shot :) The title of this issue is related https://github.com/scikit-learn/scikit-learn/issues/4630 . This issue [#941](https://github.com/scikit-learn/scikit-learn/pull/941) also seems to be proposing prune method to the tree but the code has considerably changed in the meantime I suppose. On the ...
[ { "body": "I frequently get asked about post-pruning. Often using single trees is important for interpretability, and post-pruning can help both interpretability and generalization performance.\n[I'm surprised there is no open issue on this, but I couldn't find one]\n", "number": 6557, "title": "add pos...
e8f2708e05a9982e86320d994abcbcf02a1536d9
{ "head_commit": "c3131517a2d17593d74381d042cfb072f63e4471", "head_commit_message": "RFC: Less diffs", "patch_to_review": "diff --git a/doc/whats_new/v0.21.rst b/doc/whats_new/v0.21.rst\nindex 13a08b9cec4b7..deadbb5438b1d 100644\n--- a/doc/whats_new/v0.21.rst\n+++ b/doc/whats_new/v0.21.rst\n@@ -192,6 +192,11 @@ S...
[ { "diff_hunk": "@@ -510,6 +515,110 @@ def decision_path(self, X, check_input=True):\n X = self._validate_X_predict(X, check_input)\n return self.tree_.decision_path(X)\n \n+ def prune_tree(self):", "line": null, "original_line": 518, "original_start_line": null, "path": "sklea...
82f3aa14365e1732e69c458e3656c729affe4e5b
diff --git a/doc/modules/tree.rst b/doc/modules/tree.rst index 1eeabb1e3afc8..2916e4b36f306 100644 --- a/doc/modules/tree.rst +++ b/doc/modules/tree.rst @@ -534,16 +534,57 @@ Mean Absolute Error: where :math:`X_m` is the training data in node :math:`m` + +.. _minimal_cost_complexity_pruning: + +Minimal Cost-Comple...
{ "difficulty": "high", "estimated_review_effort": 4, "problem_domain": "New Feature Additions" }
spyder-ide__spyder-23978@5749393
spyder-ide/spyder
Python
23,978
PR: Fix case sensitivity and history when searching and replacing text in the Editor
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-03-18T03:54:59Z
Search and replace case sensitivity and history in editor So this is in the irritation category of "was that an intentional feature?". In (at least) Spyder 6.0.3 on Windows the history of search and replace terms in the editor is not case sensitive. This is annoying if you are trying to do a case sensitive search and r...
Hi @gb119 thank you for the report! I think I was unable to reproduce this but maybe I'm not understanding correctly the steps to reproduce 🤔 Could it be possible for you to share a GIF/Video showing the behavior described? Let us know! So this is is bit of stupid example but it demonstrates the problem... I'll leave ...
[ { "body": "So this is in the irritation category of \"was that an intentional feature?\". In (at least) Spyder 6.0.3 on Windows the history of search and replace terms in the editor is not case sensitive. This is annoying if you are trying to do a case sensitive search and replace!\n\nSteps to reproduce:\n1). D...
41ce3e1447b97505ce6e6cba9cf6eeaf748f42a1
{ "head_commit": "57493932f3e7a5c646758b3ee575a1874d94940a", "head_commit_message": "Fix case sensitivity and history", "patch_to_review": "diff --git a/spyder/widgets/comboboxes.py b/spyder/widgets/comboboxes.py\nindex 2a5b9944469..e83bb003ba4 100644\n--- a/spyder/widgets/comboboxes.py\n+++ b/spyder/widgets/comb...
[ { "diff_hunk": "@@ -70,6 +70,14 @@ def event(self, event):\n self.sig_tab_pressed.emit(True)\n return True\n return super().event(event)\n+ \n+ def focusOutEvent(self, event):\n+ \n+ if self.add_current_text_if_valid():\n+ self.selected()\n+ ...
4972079b3005a36e7a8366a2c5e4c07a71cacf27
diff --git a/spyder/widgets/comboboxes.py b/spyder/widgets/comboboxes.py index 2a5b9944469..3e0c37a8831 100644 --- a/spyder/widgets/comboboxes.py +++ b/spyder/widgets/comboboxes.py @@ -70,6 +70,18 @@ def event(self, event): self.sig_tab_pressed.emit(True) return True return super().ev...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-23920@61f0aed
spyder-ide/spyder
Python
23,920
PR: Prevent collapsing splitter widgets in the Plots plugin
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-03-11T07:33:47Z
`ValueError: math domain error` in the Plots pane ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> I keep getting a "internal problem" error. I dont know why.It says i have to report it. ### Traceback ```python-traceback Traceback (most recent call last): File "C:\U...
Hi @b19hanru thank you for the report! I think I was able to replicate this! Seems like this error happens when you completely decrease the size of the place where the selected plot is shown and try to selected another plot while having the `Fit plot to the pane size` option active: ![Image](https://github.com/user-at...
[ { "body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nI keep getting a \"internal problem\" error. I dont know why.It says i have to report it. \n\n### Traceback\n```python-traceback\n\nTraceback (most recent call last):\n File \"C:\\Users\\hanna\\an...
661edf1dec6165a3c93038cc6832d734ab4e9bc6
{ "head_commit": "61f0aedf8e8a4da6ec555929e21ce590fd2f2518", "head_commit_message": "fix resize plots", "patch_to_review": "diff --git a/spyder/plugins/plots/widgets/figurebrowser.py b/spyder/plugins/plots/widgets/figurebrowser.py\nindex ece97f0b937..2cb2d4cac01 100644\n--- a/spyder/plugins/plots/widgets/figurebr...
[ { "diff_hunk": "@@ -212,6 +215,15 @@ def __init__(self, parent=None, background_color=None):\n self.stack_layout.setSpacing(0)\n self.setContentsMargins(0, 0, 0, 0)\n \n+ def on_splitter_moved(self):\n+ total_width = self.splitter.width()\n+\n+ min_width_percentage = 0.5\n+\n+ ...
9212865e62ce961a27bdd25b5585b334fc967869
diff --git a/spyder/plugins/plots/widgets/figurebrowser.py b/spyder/plugins/plots/widgets/figurebrowser.py index ece97f0b937..db305a4240c 100644 --- a/spyder/plugins/plots/widgets/figurebrowser.py +++ b/spyder/plugins/plots/widgets/figurebrowser.py @@ -203,6 +203,8 @@ def __init__(self, parent=None, background_color=No...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-23898@7413e36
spyder-ide/spyder
Python
23,898
PR: Catch error when trying to connect to a non-existing connection file (IPython console)
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-03-07T04:21:31Z
`TypeError: 'in <string>' requires string as left operand, not NoneType` when connecting to an existing kernel ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> Consoles/Connect to kernel python 3.13 :An error occurred while starting the kernel It was not possible to conn...
Hi @hgeorgescu thank you for the report! I think I was able to reproduce this. We will give it a check in a future release :+1: For reference, a preview of the error: ![Image](https://github.com/user-attachments/assets/66b112ad-c405-4ce4-9c8e-a57842f34129) Probably we need to add some logic to prevent the dialog `OK...
[ { "body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nConsoles/Connect to kernel python 3.13 :An error occurred while starting the kernel\nIt was not possible to connect to the kernel associated to this console. If you are trying to connect to an exis...
41ce3e1447b97505ce6e6cba9cf6eeaf748f42a1
{ "head_commit": "7413e36fbecca3d9bc28ede351650b991a8ecfef", "head_commit_message": "Update spyder/plugins/ipythonconsole/widgets/kernelconnect.py\n\nCo-authored-by: Carlos Cordoba <ccordoba12@gmail.com>", "patch_to_review": "diff --git a/spyder/plugins/ipythonconsole/widgets/kernelconnect.py b/spyder/plugins/ipy...
[ { "diff_hunk": "@@ -205,6 +217,32 @@ def load_connection_settings(self):\n except Exception:\n pass\n \n+ def _validate_connection_file(self):\n+ cf_path = osp.dirname(self.cf.text())\n+ cf_filename = osp.basename(self.cf.text())\n+ try:\n+ if not cf_filena...
901c2e0139a077431d7efb34644dbe83eee71a13
diff --git a/spyder/plugins/ipythonconsole/widgets/kernelconnect.py b/spyder/plugins/ipythonconsole/widgets/kernelconnect.py index db90a1659bd..d12c71f5701 100644 --- a/spyder/plugins/ipythonconsole/widgets/kernelconnect.py +++ b/spyder/plugins/ipythonconsole/widgets/kernelconnect.py @@ -12,13 +12,14 @@ import os.path...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
ray-project__ray-53514@25af3c8
ray-project/ray
Python
53,514
[RLlib] MetricsLogger: Fix `get/set_state` to handle tensors in `self.values`.
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> MetricsLogger: Fix `get/set_state` to handle tensors in `self.values`. * Stats.get_state should never return tensors (converts to numpy now). * Stats keeps track ...
2025-06-03T11:13:23Z
[RLlib] Headnode without GPU triggers torch/CUDA de-serialization error ### What happened + What you expected to happen Running the following will result in an error if we use a CPU-node as a headnode. I didn't test for other algorithms or versions but assume that the issue exists there, too. The issue is that the Met...
When attempting the following fix (for an APPOAlgorithm object), I rant into #53468 I therefore provide the following workaround for PPO, which may also work for other algorithms. ``` # Third Party from ray.rllib.utils.numpy import convert_to_numpy from ray.rllib.algorithms import ppo from ray.rllib.algorithms.ppo.to...
[ { "body": "### What happened + What you expected to happen\n\nRunning the following will result in an error if we use a CPU-node as a headnode.\nI didn't test for other algorithms or versions but assume that the issue exists there, too.\nThe issue is that the MetricsLogger sometimes returns torch tensors that a...
eed7e024dca51a4cee5a13e8bcfe1aa392233bc1
{ "head_commit": "25af3c80b93c3a759d04878fbc906350476bf76c", "head_commit_message": "wip\n\nSigned-off-by: sven1977 <svenmika1977@gmail.com>", "patch_to_review": "diff --git a/rllib/utils/metrics/stats.py b/rllib/utils/metrics/stats.py\nindex 0b03123ca0725..2a72d357240a2 100644\n--- a/rllib/utils/metrics/stats.py...
[ { "diff_hunk": "@@ -183,29 +184,33 @@ def __init__(\n self.values: Union[List, deque.Deque] = None\n self._set_values(force_list(init_values))\n \n+ self._could_be_tensor = False", "line": null, "original_line": 187, "original_start_line": null, "path": "rllib/utils/metric...
cf2322562ce478536c489c91b681e724e71a4bfa
diff --git a/rllib/BUILD b/rllib/BUILD index d432fdafd06c..1e8ce51783b6 100644 --- a/rllib/BUILD +++ b/rllib/BUILD @@ -4209,7 +4209,7 @@ py_test( "--num-agents=2", "--as-test", "--evaluation-parallel-to-training", - "--stop-reward=900.0", + "--stop-reward=800.0", "--num...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
searxng__searxng-3378@adb9c19
searxng/searxng
Python
3,378
[feat] plugins: new unit converter plugin
## What does this PR do? - implement a new unit converter plugin ## Why is this change important? - to not rely on 3rd party search engines for basic unit conversion, see #3015 ## How to test this PR locally? - make run - 5m to cm - 5kg to g ## Author's checklist <!-- additional notes for reviewers -->...
2024-04-07T15:41:44Z
Add unit conversion like google. <!-- PLEASE FILL THESE FIELDS, IT REALLY HELPS THE MAINTAINERS OF SearXNG --> **Is your feature request related to a problem? Please describe.** no **Describe the solution you'd like** Unit conversion like google when performing searched like "10 miles in km" **Describe alter...
Looks like ddg_definitions does handle unit conversion, but SearXNG engine crashes when it tries to parse the result. Search query: `!ddg_definitions km to miles` Error produced: ``` Error * Error: httpx.ConnectTimeout * Percentage: 0 * Parameters: `(None, None, 'api.duckduckgo.com')` * File name: ...
[ { "body": "<!-- PLEASE FILL THESE FIELDS, IT REALLY HELPS THE MAINTAINERS OF SearXNG -->\r\n\r\n**Is your feature request related to a problem? Please describe.**\r\nno\r\n\r\n**Describe the solution you'd like**\r\nUnit conversion like google when performing searched like \"10 miles in km\"\r\n\r\n**Describe a...
644ae5141711a2b3086d38ab1b61db8d5b68a1c3
{ "head_commit": "adb9c1931f1fb1c25d3e4326c5c1de1dd3855647", "head_commit_message": "[data] wikidata: update wikidata_units.json", "patch_to_review": "diff --git a/searx/data/wikidata_units.json b/searx/data/wikidata_units.json\nindex 7d6e5c93dbe..d46772e4721 100644\n--- a/searx/data/wikidata_units.json\n+++ b/se...
[ { "diff_hunk": "@@ -0,0 +1,76 @@\n+# SPDX-License-Identifier: AGPL-3.0-or-later\n+\"\"\"Calculate mathematical expressions using ack#eval\n+\"\"\"\n+\n+from flask_babel import gettext\n+\n+from searx.data import WIKIDATA_UNITS\n+\n+name = \"Unit converter plugin\"\n+description = gettext(\"Convert between units...
4c1fef72c832a0ecc9afb0e39a92a53cbdc769b5
diff --git a/searx/data/wikidata_units.json b/searx/data/wikidata_units.json index 7d6e5c93dbe..d46772e4721 100644 --- a/searx/data/wikidata_units.json +++ b/searx/data/wikidata_units.json @@ -1,1256 +1,6277 @@ { - "Q100036106": "int nmi", - "Q100149279": "°We", - "Q100995": "lb", - "Q101194838": "GHz/V", ...
{ "difficulty": "medium", "estimated_review_effort": 4, "problem_domain": "New Feature Additions" }
spyder-ide__spyder-23845@285be9a
spyder-ide/spyder
Python
23,845
PR: Make `infowidget` a `property` to prevent errors when it's garbage collected (IPython console)
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-02-28T14:25:58Z
RuntimeError when restarting a kernel ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> i downloaded anocanda and used the anocanda cmd to install the seaborn packechs or created an enviroment ### Traceback ```python-traceback Traceback (most recent call last): File "C...
Hey @rosenblood99, thanks for reporting. We'll fix this problem in our next version (5.5.5), to be released shortly. I'm going to leave this error for Spyder 6 because it turned out to be harder than I thought. Please ignore it in the meantime. Hey @fishter, thanks for reporting. We'll take a look at this issue in our ...
[ { "body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\ni downloaded anocanda and used the anocanda cmd to install the seaborn packechs or created an enviroment\n\n### Traceback\n```python-traceback\nTraceback (most recent call last):\n File \"C:\\Prog...
2bf4d7fa18776f1a18af665251a702522e4f3a17
{ "head_commit": "285be9a78ee9e3ab5c379dc9b64c99f6658f00f5", "head_commit_message": "infowidget property", "patch_to_review": "diff --git a/spyder/plugins/ipythonconsole/widgets/client.py b/spyder/plugins/ipythonconsole/widgets/client.py\nindex 6aac57e8470..7c9a19a8601 100644\n--- a/spyder/plugins/ipythonconsole/...
[ { "diff_hunk": "@@ -154,7 +154,7 @@ def __init__(\n special_kernel=special_kernel,\n server_id=server_id,\n )\n- self.infowidget = self.container.infowidget\n+ self._infowidget = self.container.infowidget", "line": null, "original_line": 157, "original_s...
fa736f605915299fddfd47cacde27a5f363538c2
diff --git a/spyder/plugins/ipythonconsole/widgets/main_widget.py b/spyder/plugins/ipythonconsole/widgets/main_widget.py index b994343b9e0..02d57658350 100644 --- a/spyder/plugins/ipythonconsole/widgets/main_widget.py +++ b/spyder/plugins/ipythonconsole/widgets/main_widget.py @@ -327,18 +327,10 @@ def __init__(self, na...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
ray-project__ray-52405@dffde67
ray-project/ray
Python
52,405
[core] Fix `JobID` check for detached actor tasks
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-04-17T17:14:49Z
Check failed: worker->GetAssignedJobId().IsNil() || worker->GetAssignedJobId() == task_spec.JobId() ### What happened + What you expected to happen I submit a Job to RayCluster through API, which mainly processes data through Ray Data. At this point, Raylet crashes and Node restarts. This issue only appeared when I up...
The following reliably reproduces the same check failure. The root cause is this permissive check: https://github.com/ray-project/ray/blob/69c03e0ad9d8730000a429ac2d856c7708ee2b92/src/ray/raylet/worker_pool.cc#L1296 We allow all tasks submitted from detached actors to skip the job ID check. ## 1) Start local ray clus...
[ { "body": "### What happened + What you expected to happen\n\nI submit a Job to RayCluster through API, which mainly processes data through Ray Data. At this point, Raylet crashes and Node restarts. This issue only appeared when I upgraded the Ray version to 2.38.0 or even higher, and below this version, this p...
6ca0da17300e6087ae6bc9cb9faaa7e9a071b33e
{ "head_commit": "dffde67d731588022cf6c4486da900d6d9f4bd3c", "head_commit_message": "fmt\n\nSigned-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>", "patch_to_review": "diff --git a/src/ray/raylet/worker_pool.cc b/src/ray/raylet/worker_pool.cc\nindex 75017735d5cf8..115b4533568d2 100644\n--- a/src/ray/raylet/worker_...
[ { "diff_hunk": "@@ -926,6 +926,197 @@ TEST_F(WorkerPoolDriverRegisteredTest, PopWorkerMultiTenancy) {\n }\n }\n \n+// Tests the worker assignment logic for task specs that have a root detached actor ID.\n+// These tasks:\n+// - Must be matched to workers that have a matching job ID (or no job ID).\n+// - ...
809d1af4d14549955c42b86b348ca19dfa4819ad
diff --git a/src/ray/raylet/worker_pool.cc b/src/ray/raylet/worker_pool.cc index 75017735d5cf..115b4533568d 100644 --- a/src/ray/raylet/worker_pool.cc +++ b/src/ray/raylet/worker_pool.cc @@ -47,7 +47,6 @@ DEFINE_stats(worker_register_time_ms, namespace { -// A helper function to get a worker from a list. std::sha...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-23812@35a68d3
spyder-ide/spyder
Python
23,812
PR: Handle `TypeError` when loading a `.spydata` file (Variable Explorer)
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-02-25T18:23:55Z
Impossible to load .spydata file ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> Impossible to load a .spydata file Exception in comms call load_data: File "/Users/Fred/miniconda3/envs/py39/lib/python3.9/site-packages/spyder_kernels/comms/commbase.py", line 359, in ...
Hi @blancfrederic thank you for the report! I think this can happen if you try to load variables while your current setup has a different version of the packages used to create such variables :thinking: Some similar issues: https://github.com/spyder-ide/spyder/issues?q=is%3Aissue+TypeError%3A+a+number+is+required+is...
[ { "body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nImpossible to load a .spydata file\n\nException in comms call load_data:\n\n File \"/Users/Fred/miniconda3/envs/py39/lib/python3.9/site-packages/spyder_kernels/comms/commbase.py\", line 359, in _h...
1b3fe16f7d6cab321d861a5612cef1c1ac57a584
{ "head_commit": "35a68d3f24ee9cc5d8f75be46b6921c7584c9413", "head_commit_message": "Variable Explorer: Catch TypeError when loading a .spydata file", "patch_to_review": "diff --git a/spyder/plugins/variableexplorer/widgets/namespacebrowser.py b/spyder/plugins/variableexplorer/widgets/namespacebrowser.py\nindex 1...
[ { "diff_hunk": "@@ -381,6 +381,14 @@ def load_data(self, filename, ext):\n \"<br><br><tt>{extensions}</tt>\").format(\n extensions=', '.join(IMPORT_EXT))\n return msg\n+ except TypeError:\n+ msg = _(\"Spyder is unable to open the file \"\...
462ada40112ca762127b7be7a1e1a653127ab573
diff --git a/spyder/plugins/variableexplorer/widgets/namespacebrowser.py b/spyder/plugins/variableexplorer/widgets/namespacebrowser.py index 18e60bacaf8..b7505b9e33e 100644 --- a/spyder/plugins/variableexplorer/widgets/namespacebrowser.py +++ b/spyder/plugins/variableexplorer/widgets/namespacebrowser.py @@ -381,6 +381,...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12682@fd87128
scikit-learn/scikit-learn
Python
12,682
[MRG+1] add a `transform_max_iter` to `SparseCoder`, `DictionaryLearning`, and `MiniBatchDictionaryLearning`
Fixes #12650 SparseCoder now passes `max_iter` to the underlying LassoLarse when `algorithm='lasso_lars'`
2018-11-27T08:30:51Z
`SparseCoder` doesn't expose `max_iter` for `Lasso` `SparseCoder` uses `Lasso` if the algorithm is set to `lasso_cd`. It sets some of the `Lasso`'s parameters, but not `max_iter`, and that by default is 1000. This results in a warning in `examples/decomposition/plot_sparse_coding.py` complaining that the estimator has ...
Are you thinking a lasso_kwargs parameter? yeah, more like `algorithm_kwargs` I suppose, to cover `Lasso`, `LassoLars`, and `Lars` But I was looking at the code to figure how many parameters are not covered by what's already given to `SparseCoder`, and there's not many. In fact, `max_iter` is a parameter to `SparseC...
[ { "body": "`SparseCoder` uses `Lasso` if the algorithm is set to `lasso_cd`. It sets some of the `Lasso`'s parameters, but not `max_iter`, and that by default is 1000. This results in a warning in `examples/decomposition/plot_sparse_coding.py` complaining that the estimator has not converged.\r\n\r\nI guess the...
d360ffa7c5896a91ae498b3fb9cf464464ce8f34
{ "head_commit": "fd871281f8ad285d0da57021b1ce6d58678d7bdc", "head_commit_message": "Merge remote-tracking branch 'upstream/master' into bug/sparsecoder/max_iter", "patch_to_review": "diff --git a/doc/whats_new/v0.21.rst b/doc/whats_new/v0.21.rst\nindex 2f359ca87463f..cb621cb1214bc 100644\n--- a/doc/whats_new/v0....
[ { "diff_hunk": "@@ -52,12 +59,30 @@ Support for Python 3.4 and below has been officially dropped.\n :user:`Adrin Jalali <adrinjalali>`, and :user:`Erich Schubert <kno10>`.\n \n :mod:`sklearn.datasets`\n- ......................\n+.......................\n \n - |Fix| Added support for 64-bit group IDs and po...
2bb0ea8a60848afbbaaf8207ff3464f8e294f114
diff --git a/doc/whats_new/v0.22.rst b/doc/whats_new/v0.22.rst index 1089284a9f6a9..390ad6b40cfc6 100644 --- a/doc/whats_new/v0.22.rst +++ b/doc/whats_new/v0.22.rst @@ -17,6 +17,10 @@ parameters, may produce different models from the previous version. This often occurs due to changes in the modelling logic (bug fixes ...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
ray-project__ray-52278@704c731
ray-project/ray
Python
52,278
[core][autoscaler] make cluster constraints clear in the autoscaler status report
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-04-12T18:28:00Z
[core][autoscaler] Better observability for request resources ### What happened + What you expected to happen Cluster constraint from requests resources should not be shown together with other delta demands (e.g. pending placement groups, pending tasks/acotrs) ### Versions / Dependencies master ### Reproduction s...
Feel free to assign this issue to me @kevin85421 Adding some more context in the original issue. I think this is more of a nit in letting users what's the current cluster resource constrain through `autoscaler_sdk.request_resources()`. For example in the `ray status [-v]` output, we should probably explicitly show...
[ { "body": "### What happened + What you expected to happen\n\nCluster constraint from requests resources should not be shown together with other delta demands (e.g. pending placement groups, pending tasks/acotrs) \n\n### Versions / Dependencies\n\nmaster\n\n### Reproduction script\n\nNA\n\n### Issue Severity\n\...
be91ed688adaab1702aca65d2c27af6b4e3a3b82
{ "head_commit": "704c731b3508f44a57fddd015f218f78f6e2dcff", "head_commit_message": "[core][autoscaler] make cluster constraints in the autoscaler status report clear\n\nSigned-off-by: Rueian <rueiancsie@gmail.com>", "patch_to_review": "diff --git a/python/ray/autoscaler/_private/util.py b/python/ray/autoscaler/_...
[ { "diff_hunk": "@@ -724,6 +724,18 @@ def filter_placement_group_from_bundle(bundle: ResourceBundle):\n return demand_lines\n \n \n+def get_constraints_report(lm_summary: LoadMetricsSummary):\n+ constraint_lines = []\n+ for bundle, count in lm_summary.request_demand:\n+ line = f\" {bundle}: {cou...
b7a814c67fe88e7e773b6efc1acf7db89828cde9
diff --git a/python/ray/autoscaler/_private/util.py b/python/ray/autoscaler/_private/util.py index fde2e2cd7fac..d90c3fa6f21e 100644 --- a/python/ray/autoscaler/_private/util.py +++ b/python/ray/autoscaler/_private/util.py @@ -724,6 +724,36 @@ def filter_placement_group_from_bundle(bundle: ResourceBundle): return ...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "New Feature Additions" }
searxng__searxng-3231@909df72
searxng/searxng
Python
3,231
[feat] images: show resolution in overview
## What does this PR do? - the previous `img_format` will now be used for the real format of the image (e.g. jpg, png, webp, ...) - there now is a new field called `resolution` that should be used with the format `width x height` - I've also changed the documentation accordingly ## Why is this change important? ...
2024-02-20T09:57:19Z
Image search: show resolution beneath title or url **Is your feature request related to a problem? Please describe.** When searching for images it is quite annoying to click at all the images just to notice their resolution doesn't fit my need. Probably not all engines provide a resolution but for those who do, it wou...
[ { "body": "**Is your feature request related to a problem? Please describe.**\r\nWhen searching for images it is quite annoying to click at all the images just to notice their resolution doesn't fit my need. Probably not all engines provide a resolution but for those who do, it would be great to show it beneath...
b683aa63fb3e1689c28bd4b762b4ad962e8e232c
{ "head_commit": "909df72a87b9cb41fc476fc8436390d1138af846", "head_commit_message": "[refactor] images: add resolution, image format and filesize fields\n\nCo-authored-by: Markus Heiser <markus.heiser@darmarit.de>", "patch_to_review": "diff --git a/docs/dev/engines/engine_overview.rst b/docs/dev/engines/engine_ov...
[ { "diff_hunk": "@@ -67,7 +67,9 @@ article.result-images .detail {\n p {\n color: var(--color-result-detail-label-font);\n font-size: 0.9rem;\n- line-height: 0.9rem;\n+ white-space: nowrap;\n+ text-overflow: ellipsis;\n+ overflow: hidden;", "line": null, "original_line...
9af4d5457a67ec7741511a06e7b4b61733213566
diff --git a/docs/dev/engines/engine_overview.rst b/docs/dev/engines/engine_overview.rst index 9c1ea04277e..091d217c06b 100644 --- a/docs/dev/engines/engine_overview.rst +++ b/docs/dev/engines/engine_overview.rst @@ -271,22 +271,54 @@ type. ``images`` ---------- -.. table:: Parameter of the **images** media type: ...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "New Feature Additions" }
ray-project__ray-52575@e63ba54
ray-project/ray
Python
52,575
[core] Implement a thread pool and call the CPython API on all threads within the same concurrency group
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-04-24T07:11:40Z
[core] Only one of the threads in a thread pool will be initialized as a long-running Python thread ### What happened + What you expected to happen Currently, only one of the threads in a thread pool will be initialized as a long-running Python thread. I should also investigate whether it's possible to call `PyGILStat...
[ { "body": "### What happened + What you expected to happen\n\nCurrently, only one of the threads in a thread pool will be initialized as a long-running Python thread. I should also investigate whether it's possible to call `PyGILState_Release` on a different thread other than the one calls `PyGILState_Ensure` i...
9c988ee61460b3205081e5d6b6d903e3bf4f826e
{ "head_commit": "e63ba54785d009dabed0bb5972a3c734bdac5d38", "head_commit_message": "add test\n\nSigned-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>", "patch_to_review": "diff --git a/python/ray/tests/test_concurrency_group.py b/python/ray/tests/test_concurrency_group.py\nindex 6bec0424f396d..568aeccd25873 100644...
[ { "diff_hunk": "@@ -14,21 +14,55 @@\n \n #include \"ray/core_worker/transport/thread_pool.h\"\n \n+#include <boost/asio/post.hpp>\n+#include <future>\n #include <memory>\n \n namespace ray {\n namespace core {\n \n-BoundedExecutor::BoundedExecutor(int max_concurrency) {\n+BoundedExecutor::BoundedExecutor(\n+ ...
77879b71dff48d39eaabdb793b0de0a737a6b38e
diff --git a/python/ray/tests/test_concurrency_group.py b/python/ray/tests/test_concurrency_group.py index 6bec0424f396..12872a026b91 100644 --- a/python/ray/tests/test_concurrency_group.py +++ b/python/ray/tests/test_concurrency_group.py @@ -9,7 +9,7 @@ import ray from ray._common.utils import get_or_create_event_...
{ "difficulty": "high", "estimated_review_effort": 4, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12498@452a96d
scikit-learn/scikit-learn
Python
12,498
Impose shared memory when fitting a SGDClassifier
Fixes #12518 Previously, fitting a `SGDClassifier` instance in a multi-class setting involved modifying in-place its `coef_` attribute in the workers created by a `joblib.Parallel` call. However, this `Parallel` call was not requiring shared memory. For this reason, calling `SGDClassifier.fit` from a context manage...
2018-10-31T15:53:58Z
BUG SGDClassifier.fit segfaulting under loky and multiprocessing backend Fitting a `SGDClassifier` instance in a multi-class setting involves modifying in-place its`coef_` attribute in the workers created by a `joblib.Parallel` call. However, this Parallel call is not requiring shared memory. For this reason, calling `...
[ { "body": "Fitting a `SGDClassifier` instance in a multi-class setting involves modifying in-place its`coef_` attribute in the workers created by a `joblib.Parallel` call. However, this Parallel call is not requiring shared memory. For this reason, calling `SGDClassifier.fit` from a context manager with a `loky...
9f842e3496ab59ad593b46553fadff7b2490ef1a
{ "head_commit": "452a96def9a1a568012b378111f67fa254a53e4f", "head_commit_message": "TST skip test if no scipy.sparse.random", "patch_to_review": "diff --git a/sklearn/linear_model/stochastic_gradient.py b/sklearn/linear_model/stochastic_gradient.py\nindex 146d9623f22e7..843f9252f3426 100644\n--- a/sklearn/linear...
[ { "diff_hunk": "@@ -1516,3 +1516,48 @@ def test_multi_core_gridsearch_and_early_stopping():\n random_state=0)\n search.fit(iris.data, iris.target)\n assert search.best_score_ > 0.8\n+\n+\n+@pytest.mark.skipif(\n+ not hasattr(sp, 'random'),\n+ reason=\"this t...
a6b6688d44ebb758b6c98c5c49be22da7fcac77d
diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst index 69c4d89ddc552..8b62847149bca 100644 --- a/doc/whats_new/v0.20.rst +++ b/doc/whats_new/v0.20.rst @@ -94,6 +94,14 @@ Changelog those estimators as part of parallel parameter search or cross-validation. :issue:`12122` by :user:`Olivier Grisel <ogri...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
ray-project__ray-52276@5109220
ray-project/ray
Python
52,276
[serve] Add request timeout sec for grpc
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-04-12T14:09:58Z
[Ray Serve] request timeout sec for grpc ### Description We don't have request_timeout_s for gRPC like we do for HTTP. Currently, gRPC relies on an environment variable for request timeouts. We should deprecate the environment variable and introduce a new attribute in the gRPC options schema to configure request timeo...
Hey, @abrarsheikh ! I want to work on this, could you assign to me? > Hey, [@abrarsheikh](https://github.com/abrarsheikh) ! I want to work on this, could you assign to me? @Ziy1-Tan appreciate it. Feel free to open a PR when you find time.
[ { "body": "### Description\n\nWe don't have request_timeout_s for gRPC like we do for HTTP. Currently, gRPC relies on an environment variable for request timeouts. We should deprecate the environment variable and introduce a new attribute in the gRPC options schema to configure request timeouts explicitly.\n\n#...
0a8063f40c0befdb1d5d1f3e007165e920409009
{ "head_commit": "51092207476e13d764e41f926ee18dc7259ad509", "head_commit_message": "[Ray Serve] Add request timeout sec for grpc\n\nSigned-off-by: Ziy1-Tan <ajb459684460@gmail.com>", "patch_to_review": "diff --git a/doc/source/serve/api/index.md b/doc/source/serve/api/index.md\nindex bbc13d79def6a..8996ddb427fbf...
[ { "diff_hunk": "@@ -1198,13 +1198,27 @@ def __init__(\n proxy_router=self.proxy_router,\n request_timeout_s=self._http_options.request_timeout_s,\n )\n+\n+ if (\n+ RAY_SERVE_REQUEST_PROCESSING_TIMEOUT_S is not None\n+ and self._grpc_options.request_ti...
08d67d4d59972b500628f73da25c4af36766932a
diff --git a/doc/source/serve/api/index.md b/doc/source/serve/api/index.md index bbc13d79def6..8996ddb427fb 100644 --- a/doc/source/serve/api/index.md +++ b/doc/source/serve/api/index.md @@ -212,7 +212,8 @@ Content-Type: application/json }, "grpc_options": { "port": 9000, - "grpc_servicer_func...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "New Feature Additions" }
spyder-ide__spyder-23524@3b3d13f
spyder-ide/spyder
Python
23,524
PR : Add validation for theme color changes (Preferences)
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-01-21T19:41:23Z
Custom syntax highlighting theme has been removed / Spyder crashes when a custom syntax highlighting theme has as color an invalid hex value Hi I noticed that my personal (dark) theme was recently removed (maybe after an update) ; twice, i tried to re-create my theme: 1. new values don't change anything 2. when ...
Hey @paul18frr, thanks for reporting. You said: > I noticed that my personal (dark) theme was recently removed (maybe after an update) That probably happened when you updated from Spyder 5 to 6 because we had to reset several default theme colors. > twice, i tried to re-create my theme: > > 1. new values don...
[ { "body": "Hi\r\n\r\nI noticed that my personal (dark) theme was recently removed (maybe after an update) ; twice, i tried to re-create my theme:\r\n\r\n1. new values don't change anything\r\n2. when spyder is closed and reopened, the window immediatly closes when it appears\r\n3. when using the anaconda prompt...
f11e20c43a5fc3bbfafb8d04e1d1cda3e5a0d475
{ "head_commit": "3b3d13f762b83dc544b0230f55e28b67715a72ac", "head_commit_message": "fix message", "patch_to_review": "diff --git a/spyder/plugins/appearance/widgets.py b/spyder/plugins/appearance/widgets.py\nindex f4828f35ec4..64d205d4164 100644\n--- a/spyder/plugins/appearance/widgets.py\n+++ b/spyder/plugins/a...
[ { "diff_hunk": "@@ -60,6 +62,41 @@ def get_scheme_name(self):\n \"\"\"\n return self.scheme_name_textbox[self.last_used_scheme].text()\n \n+ def validate_colors(self):\n+ \"\"\"\n+ Validate the current color scheme and display a message box listing \n+ any invalid colors....
b3056b8b01382d90d62a0191f4c1a541c28c4ceb
diff --git a/spyder/plugins/appearance/widgets.py b/spyder/plugins/appearance/widgets.py index f4828f35ec4..ca558b906f3 100644 --- a/spyder/plugins/appearance/widgets.py +++ b/spyder/plugins/appearance/widgets.py @@ -6,9 +6,19 @@ """Appearance entry in Preferences.""" +import re + from qtpy.QtCore import Qt -from...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12486@15a4397
scikit-learn/scikit-learn
Python
12,486
Check predict_proba shape in ThresholdScorer
#### Reference Issues/PRs Continues and resolves #12221, fixes #7598 #### What does this implement/fix? Explain your changes. #### Any other comments? this time, I ran flake8, fixed formatting cc: @AMDonati @amueller Can you point me to the GMM test? I did not see on in here: scikit-learn/sklearn/tests ...
2018-10-30T01:08:40Z
BUG: Using GridSearchCV with scoring='roc_auc' and GMM as classifier gives IndexError When performing grid search using GridSearchCV using ootb scoring method 'roc_auc' and ootb GMM classifier from sklearn.mixture.GMM I get an index error. Code to reproduce: ``` from sklearn import datasets from sklearn.grid_search im...
Updated to 0.17.1 and issue persists ( Changing GMM to GaussianMixture) The error is strange, but GMM is not a supervised model, so AUC doesn't really make sense. We might want to raise a better error, though it's hard to detect what's going on here in a sense. Do you really mean updated to 0.17.1, not 0.18? On 8 Oc...
[ { "body": "When performing grid search using GridSearchCV using ootb scoring method 'roc_auc' and ootb GMM classifier from sklearn.mixture.GMM I get an index error.\nCode to reproduce:\n\n```\nfrom sklearn import datasets\nfrom sklearn.grid_search import GridSearchCV\nfrom sklearn.mixture import GMM\nX,y = data...
02dc9ed680e7f53f1b0d410dcdd37341c7958eb1
{ "head_commit": "15a43978cc2e7495b04691d1314eec70f4502e37", "head_commit_message": "add regression test, also add fix for proba scorers", "patch_to_review": "diff --git a/sklearn/metrics/scorer.py b/sklearn/metrics/scorer.py\nindex 59ecd65386823..e500fab82a86c 100644\n--- a/sklearn/metrics/scorer.py\n+++ b/sklea...
[ { "diff_hunk": "@@ -126,7 +126,12 @@ def __call__(self, clf, X, y, sample_weight=None):\n y_type = type_of_target(y)\n y_pred = clf.predict_proba(X)\n if y_type == \"binary\":\n- y_pred = y_pred[:, 1]\n+ if y_pred.shape[1] == 2:\n+ y_pred = y_pred[:, ...
4a256f1e2bf36f63076f4c4f3b869ca76116e5fc
diff --git a/sklearn/metrics/scorer.py b/sklearn/metrics/scorer.py index 59ecd65386823..3907e2439dfeb 100644 --- a/sklearn/metrics/scorer.py +++ b/sklearn/metrics/scorer.py @@ -126,7 +126,13 @@ def __call__(self, clf, X, y, sample_weight=None): y_type = type_of_target(y) y_pred = clf.predict_proba(X) ...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-23511@21506ee
spyder-ide/spyder
Python
23,511
PR: Fix error when executing in a dedicated console and the interpreter doesn't have spyder-kernels installed or its right version
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-01-19T21:17:36Z
AttributeError when executing in a dedicated console and the interpreter was set to an environment without spyder-kernels installed/correct version installed ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> 1. Install Anaconda 2. create conda environment with spyder (cre...
Hey @s-pearce, thanks for reporting. It seems the problem has to do with two things: 1. The environment you created from a yaml file doesn't have the right version of Spyder-kernels that's required for the Spyder you have in your base env. 2. We're not guarding against that when trying to create a dedicated console t...
[ { "body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\n1. Install Anaconda\n2. create conda environment with spyder (created from yaml file)\n3. open base environment spyder\n4. configure python interpreter in preferences to use the not-base environmen...
40d75915c6a7dcb59a1854229589a761f333fea8
{ "head_commit": "21506ee7eaea2deaaabb58b783e4c0d093e98a0e", "head_commit_message": "fix error", "patch_to_review": "diff --git a/spyder/plugins/ipythonconsole/widgets/main_widget.py b/spyder/plugins/ipythonconsole/widgets/main_widget.py\nindex 974eaf454b4..7878850c16a 100644\n--- a/spyder/plugins/ipythonconsole/...
[ { "diff_hunk": "@@ -1851,9 +1851,10 @@ def create_client_for_file(self, filename, is_cython=False):\n self.master_clients -= 1\n \n # Rename client tab with filename\n- client.allow_rename = False\n- tab_text = self.disambiguate_fname(filename)\n- self.rename_client_tab(clie...
65bc3d5e497712a0180d10915c478ec781bbbcaf
diff --git a/spyder/plugins/ipythonconsole/widgets/main_widget.py b/spyder/plugins/ipythonconsole/widgets/main_widget.py index 974eaf454b4..1559ff37cf5 100644 --- a/spyder/plugins/ipythonconsole/widgets/main_widget.py +++ b/spyder/plugins/ipythonconsole/widgets/main_widget.py @@ -1851,9 +1851,10 @@ def create_client_fo...
{ "difficulty": "low", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-23444@85e55fc
spyder-ide/spyder
Python
23,444
PR: Add command line option to connect to an existing kernel at startup (IPython console)
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-01-10T12:09:05Z
Add command line option to connect to an existing kernel Can I connect to an existing kernel when I start Spyder? Now, Spyder can connect to an existing kernel by clicking the menu icon of the ipython terminal, and selecting `connect to existing ipython kernel`, and inputting the JSON file name of the kernel. But...
Hi @Social-Mean sorry for the late response and thank you for the feedback! I think currently there is not a way to do that, sorry! However, I'm not sure if this is something that could be eventually achieved with the new remote development logic that has been worked on Spyder 6 🤔 Just in case, is the use case desc...
[ { "body": "Can I connect to an existing kernel when I start Spyder?\r\n\r\nNow, Spyder can connect to an existing kernel by clicking the menu icon of the ipython terminal, and selecting `connect to existing ipython kernel`, and inputting the JSON file name of the kernel.\r\n\r\nBut this needs manually operation...
0dad5d1a3c0314c41ea4a74dd17a249cdb27cc3a
{ "head_commit": "85e55fc77dcb0567ded373ec5b1d78380a935139", "head_commit_message": "code format", "patch_to_review": "diff --git a/spyder/app/cli_options.py b/spyder/app/cli_options.py\nindex 9dee61ab853..b7083387859 100644\n--- a/spyder/app/cli_options.py\n+++ b/spyder/app/cli_options.py\n@@ -157,6 +157,13 @@ d...
[ { "diff_hunk": "@@ -559,7 +559,12 @@ def on_close(self, cancelable=False):\n return self.get_widget().close_all_clients()\n \n def on_mainwindow_visible(self):\n- self.create_new_client(give_focus=False)\n+ cli_options = self.get_command_line_options()\n+ connection_file = cli_o...
fc2a4bc2f9aca242b4d7aa3581c6705e2ed6270f
diff --git a/changelogs/Spyder-6.md b/changelogs/Spyder-6.md index b244e9c8e74..e6fd6ac3efc 100644 --- a/changelogs/Spyder-6.md +++ b/changelogs/Spyder-6.md @@ -1,5 +1,12 @@ # History of changes for Spyder 6 +## Version 6.0.4 (Unreleased) + +### API changes + +* Add `give_focus` kwarg to the `create_client_for_kerne...
{ "difficulty": "medium", "estimated_review_effort": 2, "problem_domain": "New Feature Additions" }
spyder-ide__spyder-23273@f7eb373
spyder-ide/spyder
Python
23,273
PR: Don't hide control debugger buttons from main toolbar while executing
<!--- Explain what you've done and why ---> while debugging, clicking run (step in/out, etc) causes the debug actions on the toolbar to briefly hide until the current line has completed. This looks visually glitchy, and can cause mis-clicks. Instead continue to show the buttons if currently executing. ### Issue(s) ...
2024-12-13T18:40:40Z
The control debugger buttons are hidden from the main toolbar when code is executed Hello Friends! Thank you for the wonderful Spyder. I noticed a few UI or workflow changes - or flaws - with the Version 6 (and, may be, would like to start a discussion.) **Debug buttons** From the release of V.6, the debug but...
True. Debugging in Spyder 6 is completely messed up. I can add that I was not able to change debugging shortcuts in the Preferences window. Had to switch back to version 5. The buttons hiding during execution of a current line definitely seems like a bug. I generally appreciate resizable windows, but the settings cont...
[ { "body": "Hello Friends!\r\n\r\nThank you for the wonderful Spyder. I noticed a few UI or workflow changes - or flaws - with the Version 6 (and, may be, would like to start a discussion.)\r\n\r\n**Debug buttons**\r\n From the release of V.6, the debug buttons are not always visible. Debug-function is one of t...
80f6954d08d3e4bc68bee75ef4a2fd0a3da4dbc9
{ "head_commit": "f7eb373dc064389fbbe52d5463a9ca304c360c4b", "head_commit_message": "fix bug: actions shown while executing without debugging", "patch_to_review": "diff --git a/spyder/plugins/debugger/widgets/main_widget.py b/spyder/plugins/debugger/widgets/main_widget.py\nindex 6176c3bc033..3a52d2472e4 100644\n-...
[ { "diff_hunk": "@@ -438,7 +440,8 @@ def update_actions(self):\n action = self.get_action(action_name)\n action.setEnabled(pdb_prompt)\n \n- self._set_visible_control_debugger_buttons(pdb_prompt)\n+ self._set_visible_control_debugger_buttons(pdb_prompt or\n+ ...
ea50ce0f3f07e2be23e5443009a4b9f603f3260c
diff --git a/spyder/plugins/debugger/widgets/main_widget.py b/spyder/plugins/debugger/widgets/main_widget.py index 6176c3bc033..738b3bc65d5 100644 --- a/spyder/plugins/debugger/widgets/main_widget.py +++ b/spyder/plugins/debugger/widgets/main_widget.py @@ -416,6 +416,7 @@ def update_actions(self): post...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
ray-project__ray-52200@62c9a66
ray-project/ray
Python
52,200
[core][autoscaler] let AWS node provider retry instance retrieval to handle eventual consistency
## Why are these changes needed? Fixes https://github.com/ray-project/ray/issues/51861. The issue fails on the assertion: https://github.com/ray-project/ray/blob/574cf65b3996513d476ba40c48b899d8de0a27a0/python/ray/autoscaler/_private/aws/node_provider.py#L597-L598 The assertion can only fail on `len(matches) == ...
2025-04-10T04:25:40Z
[core] EC2 Autoscaler race condition ### What happened + What you expected to happen Ray Ec2 autoscaler can get into a state where it 'looses' track of an instance, but that instance is present in AWS, and it causes an exception, which leads to the autoscaler to get stuck: Here's the exception: ``` 2025-03-31 11:50:5...
@rueian can you take a look at this issue? cc @kevin85421 The assertion failure comes from here https://github.com/ray-project/ray/blob/574cf65b3996513d476ba40c48b899d8de0a27a0/python/ray/autoscaler/_private/aws/node_provider.py#L597-L598 The `ec2.instances.filter(InstanceIds=[node_id])` uses the https://docs.aws.ama...
[ { "body": "### What happened + What you expected to happen\n\nRay Ec2 autoscaler can get into a state where it 'looses' track of an instance, but that instance is present in AWS, and it causes an exception, which leads to the autoscaler to get stuck:\n\nHere's the exception:\n```\n2025-03-31 11:50:57.575\nAsser...
0c35fcd309156c416b09ca23a1dfa34b57efd929
{ "head_commit": "62c9a660cd08960b2d0138f93ef8ab197e0dc1bf", "head_commit_message": "[core][autoscaler] let AWS node provider retry instance retrieval to handle eventual consistency\n\nSigned-off-by: Rueian <rueiancsie@gmail.com>", "patch_to_review": "diff --git a/python/ray/autoscaler/_private/aws/node_provider....
[ { "diff_hunk": "@@ -38,6 +38,7 @@\n logger = logging.getLogger(__name__)\n \n TAG_BATCH_DELAY = 1\n+LIST_RETRY_DELAY = 1", "line": null, "original_line": 41, "original_start_line": null, "path": "python/ray/autoscaler/_private/aws/node_provider.py", "start_line": null, "text": "@user1:\n...
9cc1814c6c5185d469b7a0f656e8459fc628c97d
diff --git a/python/ray/autoscaler/_private/aws/node_provider.py b/python/ray/autoscaler/_private/aws/node_provider.py index a4f34de70f2b..f11e8a6dbcdb 100644 --- a/python/ray/autoscaler/_private/aws/node_provider.py +++ b/python/ray/autoscaler/_private/aws/node_provider.py @@ -38,6 +38,7 @@ logger = logging.getLogger...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12424@3cc9f44
scikit-learn/scikit-learn
Python
12,424
[MRG+2] improved documentation of MissingIndicator
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fi...
2018-10-19T16:15:55Z
MissingIndicator Documentation & Interface Today I discovered a huge mistake in my experimental pipeline, mostly due to me making too many and in particular the wrong assumptions. In order to prevent other people from making the same assumptions, I think the `MissingIndicator` documentation can be slightly improved. In...
If you want to transform all features, FeatureUnion is more appropriate than ColumnTransformer. But yes, pr welcome. I think an example in the narrative docs would be appropriate more than in the example gallery Yeah PR welcome, and I agree, should to to the narrative and some additions to the docstring are good, too....
[ { "body": "Today I discovered a huge mistake in my experimental pipeline, mostly due to me making too many and in particular the wrong assumptions. In order to prevent other people from making the same assumptions, I think the `MissingIndicator` documentation can be slightly improved. In particular, it was uncl...
5bcd84be205ebfba6bb625615d3d1de6390a42cb
{ "head_commit": "3cc9f44e656fb61c9f5de5666f427750bcb36cde", "head_commit_message": "removes empty line", "patch_to_review": "diff --git a/doc/modules/impute.rst b/doc/modules/impute.rst\nindex 0fd119857177b..30a9ee2435320 100644\n--- a/doc/modules/impute.rst\n+++ b/doc/modules/impute.rst\n@@ -120,3 +120,51 @@ wh...
[ { "diff_hunk": "@@ -410,13 +410,18 @@ def transform(self, X):\n \n \n class MissingIndicator(BaseEstimator, TransformerMixin):\n- \"\"\"Binary indicators for missing values.\n+ \"\"\"Binary indicators for missing values. Note that this component typically", "line": null, "original_line": 413, ...
eefa876151f4fcf7d0ab81cabdda30b00db789d2
diff --git a/doc/modules/impute.rst b/doc/modules/impute.rst index 0fd119857177b..933685f8bfa6f 100644 --- a/doc/modules/impute.rst +++ b/doc/modules/impute.rst @@ -120,3 +120,44 @@ whether or not they contain missing values:: [False, True, False, False]]) >>> indicator.features_ array([0, 1, 2, 3]) + ...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Documentation Updates" }
spyder-ide__spyder-23420@5806b43
spyder-ide/spyder
Python
23,420
PR: Catch error when checking for updates (Update Manager)
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2025-01-06T04:51:28Z
Error when checking for updates ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> I'm just pulling in my libraries when this happens ### Traceback ```python-traceback Traceback (most recent call last): File "C:\Users\beatwoo\AppData\Roaming\Python\Python312...
Hey @elwoodataine, thanks for reporting. It seems Spyder is unable to check if an update is available because some security certificates are not available in your system. There's nothing we can do on our side about it other than catching the error to not show it to users, which we'll do in a later version. To preven...
[ { "body": " ## Description\r\n\r\n### What steps will reproduce the problem?\r\n\r\n<!--- You can use Markdown here --->\r\n\r\nI'm just pulling in my libraries when this happens\r\n\r\n### Traceback\r\n```python-traceback\r\nTraceback (most recent call last):\r\n File \"C:\\Users\\beatwoo\\AppData\\Roaming\\P...
c943b1664b2063b47a0b2ff3e919f7837ea42f70
{ "head_commit": "5806b430932f85f8a0b9d3dae104377ea8cc064e", "head_commit_message": "add comment", "patch_to_review": "diff --git a/spyder/plugins/updatemanager/widgets/update.py b/spyder/plugins/updatemanager/widgets/update.py\nindex 3cc7b7f7020..36b6f04975e 100644\n--- a/spyder/plugins/updatemanager/widgets/upd...
[ { "diff_hunk": "@@ -51,6 +51,11 @@\n '<br><br>Please contact your network administrator for assistance.'\n )\n \n+OS_ERROR_MSG = _(\n+ 'An error occurred while checking for Spyder updates, possibly related to'\n+ ' system configuration or file access. <br><br>Please verify your system '\n+ 'setting...
d7ef309aba1fe468fa62beae190de345d2af1ee8
diff --git a/spyder/plugins/updatemanager/widgets/update.py b/spyder/plugins/updatemanager/widgets/update.py index 3cc7b7f7020..5322b3028c5 100644 --- a/spyder/plugins/updatemanager/widgets/update.py +++ b/spyder/plugins/updatemanager/widgets/update.py @@ -228,6 +228,7 @@ def _process_check_update(self): # Get...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12379@c4e0911
scikit-learn/scikit-learn
Python
12,379
[MRG] Fix IncrementalPCA when final batch is smaller than dimensions required for SVD.
#### Reference Issues/PRs This Pull Request intends to fix #12234 caused by smaller final batch during training of Incremental PCA. #### Any other comments? considering central limit theorem, sampling statistics (first and second central moments looking from the implementation) from batch to batch should already c...
2018-10-14T16:03:20Z
IncrementalPCA fails if data size % batch size < n_components #### Description `IncrementalPCA` throws`n_components=%r must be less or equal to the batch number of samples %d` The error occurs because the last batch generated by `utils.gen_batch` may be smaller than `batch_size`. #### Steps/Code to Reproduce ...
Looks like this was introduced in #9303 so @wallygauze should probably take a look too. I haven't checked in-depth how incremental pca does partial fits, but does it really need `n_components` to be <= to the `batch_size` (`n_samples` in partial_fit) - especially does it need this to hold for _every_ batch? Or should ...
[ { "body": "#### Description\r\n\r\n`IncrementalPCA` throws`n_components=%r must be less or equal to the batch number of samples %d`\r\n\r\nThe error occurs because the last batch generated by `utils.gen_batch` may be smaller than `batch_size`.\r\n\r\n#### Steps/Code to Reproduce\r\n\r\n```python\r\nfrom sklearn...
ebe77d6936c352bc7688e8ae83f80752da8453d8
{ "head_commit": "c4e0911c2c09d02cee2e7966baadc8a109c06a9c", "head_commit_message": "update test", "patch_to_review": "diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst\nindex ca6589bd895d3..5af66b9629bd5 100644\n--- a/doc/whats_new/v0.20.rst\n+++ b/doc/whats_new/v0.20.rst\n@@ -51,6 +51,12 @@ Changel...
[ { "diff_hunk": "@@ -150,7 +156,7 @@ occurs due to changes in the modelling logic (bug fixes or enhancements), or in\n random sampling procedures.\n \n - :class:`cluster.MeanShift` (bug fix)\n-- :class:`decomposition.IncrementalPCA` in Python 2 (bug fix)\n+- :class:`decomposition.IncrementalPCA` in Python 2 and ...
4cc94376a4d8bd9e0add21f23ffcda9ecbc088ef
diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst index 934adb89afc2d..0968bb81d7f23 100644 --- a/doc/whats_new/v0.20.rst +++ b/doc/whats_new/v0.20.rst @@ -12,6 +12,16 @@ Version 0.20.1 This is a bug-fix release with some minor documentation improvements and enhancements to features released in 0.20.0. ...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
ray-project__ray-51794@3279668
ray-project/ray
Python
51,794
[Data][Fix] Adding a column to pandas dataset
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-03-28T19:42:13Z
[Data] Found Bug `add_column` ### What happened + What you expected to happen See reproduction which broke when updating from 2.40.0 to 2.44.0. It seems `ray.data.Dataset.add_column` is not setting for all elements properly. ### Versions / Dependencies Ray 2.44.0 ### Reproduction script ```python import unittest i...
I can reproduce on my side ``` ====================================================================== FAIL: test_add_column (__main__.MyTest.test_add_column) -------...
[ { "body": "### What happened + What you expected to happen\n\nSee reproduction which broke when updating from 2.40.0 to 2.44.0. It seems `ray.data.Dataset.add_column` is not setting for all elements properly.\n\n### Versions / Dependencies\n\nRay 2.44.0\n\n### Reproduction script\n\n```python\nimport unittest\n...
8539a9740ac6173f43332508c3847226848b5ce7
{ "head_commit": "3279668ad5b0902ef30e13277dee90a90f269441", "head_commit_message": "fix add column to pandas\n\nSigned-off-by: zhaoch23 <c233zhao@uwaterloo.ca>", "patch_to_review": "diff --git a/python/ray/data/dataset.py b/python/ray/data/dataset.py\nindex d82f112c65d7..b3658135c220 100644\n--- a/python/ray/dat...
[ { "diff_hunk": "@@ -215,6 +215,17 @@ def test_read_pandas_data_array_column(ray_start_regular_shared):\n assert all(row[\"array\"] == [1, 1, 1])\n \n \n+def test_add_column_to_pandas(ray_start_regular_shared):\n+ # Refer to issue https://github.com/ray-project/ray/issues/51758\n+ ds = ray.data.from_pa...
cd7cc17c774c1d8e52018d9b0e8d5906f30c7cb9
diff --git a/python/ray/data/dataset.py b/python/ray/data/dataset.py index 360d31b4a192..29dd34d65e06 100644 --- a/python/ray/data/dataset.py +++ b/python/ray/data/dataset.py @@ -790,6 +790,16 @@ def add_column( def add_column(batch: DataBatch) -> DataBatch: column = fn(batch) if batc...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12357@dd95eba
scikit-learn/scikit-learn
Python
12,357
[MRG+1] Fix OPTICS processing order
#### Reference Issues/PRs Fixes #12090: a subtle bug that only the neighbors of the current point - not earlier neighbors - were considered for expanding clusters in OPTICS. Fixes #12134: test case is included and passes #### What does this implement/fix? Explain your changes. With these changes, the result is ...
2018-10-11T16:44:08Z
OPTICS test_reach_dists inappropriate I begin to suspect the correctness of the test. Seems that our implementation and the referenced implementation are not the same. In our implementation, when there're multiple points with the same reachability-distance, we choose the point which is closest to current point. In the ...
Interesting. Our policy seems appropriate, although more computationally complex. Should the test still be valid in the min_samples=2 case? > Should the test still be valid in the min_samples=2 case? I guess it will be valid when min_samples=2 (not sure though), because when min_samples=2, reachability-distance me...
[ { "body": "I begin to suspect the correctness of the test. Seems that our implementation and the referenced implementation are not the same. In our implementation, when there're multiple points with the same reachability-distance, we choose the point which is closest to current point. In the referenced implemen...
c13ba26c4780d6088c40db3cc0f8367df4e27f1f
{ "head_commit": "dd95eba13c39dc618596238264bd90b4054d8bf4", "head_commit_message": "Add a test case for OPTICS bug (closes #12134)", "patch_to_review": "diff --git a/sklearn/cluster/tests/test_optics.py b/sklearn/cluster/tests/test_optics.py\nindex 5163504ab0401..3b01dec7ef35b 100755\n--- a/sklearn/cluster/tests...
[ { "diff_hunk": "@@ -217,236 +216,168 @@ def test_cluster_sigmin_pruning(reach, n_child, members):\n \n \n def test_reach_dists():\n- # Tests against known extraction array\n+ # Expected values, computed with ELKI using:\n+ # java -jar elki.jar cli -dbc.in csv -dbc.filter FixedDBIDsFilter\n+ # -alg...
43a877054f93589f8aa08c351932bca1781b4ea2
diff --git a/doc/whats_new/v0.21.rst b/doc/whats_new/v0.21.rst index a3e8608e3f690..4dbded1b287b1 100644 --- a/doc/whats_new/v0.21.rst +++ b/doc/whats_new/v0.21.rst @@ -45,8 +45,8 @@ Support for Python 3.4 and below has been officially dropped. - |MajorFeature| A new clustering algorithm: :class:`cluster.OPTICS`: an...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12180@11d3a85
scikit-learn/scikit-learn
Python
12,180
[MRG] More informative error message in OneHotEncoder(categories=None) with negative integer values
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs Fixes #12179 - Update the error message when negative inputs are provided ...
2018-09-27T05:33:51Z
OneHotEncoder "only non-negative integers" message should suggest using categories='auto' before version 0.20, `OneHotEncoder` did not support negative integers in input. Now it supports that case if the "new behaviour" is requested by instantiating it with `categories='auto'`. The legacy behaviour currently raises `V...
Can I take this issue? Sure, thanks!
[ { "body": "before version 0.20, `OneHotEncoder` did not support negative integers in input. Now it supports that case if the \"new behaviour\" is requested by instantiating it with `categories='auto'`. The legacy behaviour currently raises `ValueError(\"X needs to contain only non-negative integers.\")`. This ...
dbfd872be4d68a6d824bd81ace09420383bf2d7b
{ "head_commit": "11d3a85a13ce0236087ac0e68de07c3b190489ab", "head_commit_message": "Fix Issue #12179\n\n OneHotEncoder \"only non-negative integers\" message should suggest using\n categories='auto'", "patch_to_review": "diff --git a/sklearn/preprocessing/_encoders.py b/sklearn/preprocessing/_encoders.py\n...
[ { "diff_hunk": "@@ -421,7 +421,10 @@ def _legacy_fit_transform(self, X):\n dtype = getattr(X, 'dtype', None)\n X = check_array(X, dtype=np.int)\n if np.any(X < 0):\n- raise ValueError(\"X needs to contain only non-negative integers.\")\n+ raise ValueError(\"X needs ...
7f0be2c2d96f4f89545cb230fd319c912fcdd3c5
diff --git a/sklearn/preprocessing/_encoders.py b/sklearn/preprocessing/_encoders.py index b2dee7d926e06..c44607d10e6d0 100644 --- a/sklearn/preprocessing/_encoders.py +++ b/sklearn/preprocessing/_encoders.py @@ -421,7 +421,11 @@ def _legacy_fit_transform(self, X): dtype = getattr(X, 'dtype', None) X ...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-22850@191bcde
spyder-ide/spyder
Python
22,850
PR: Fix `UnboundLocalError` when removing and adding paths to Pythonpath Manager
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2024-11-05T04:47:50Z
Attempt to add path in `Anaconda3/pkgs` to Pythonpath manager leads to an error ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> An attempt to overcome the problem: run zsni -in testosterone.smi Traceback (most recent call last): File D:\ICDD_PDF\TOOLS_2020\LexiChemTK...
Hey @Rg111Ga31, thanks for reporting. You said: > An attempt to overcome the problem: run zsni -in testosterone.smi Traceback (most recent call last): > >File D:\ICDD_PDF\TOOLS_2020\LexiChemTK\Struct_Name\SmiNamImg\zsni.py:17 from openeye import oechem > > ModuleNotFoundError: No module named 'openeye' The...
[ { "body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nAn attempt to overcome the problem:\nrun zsni -in testosterone.smi\nTraceback (most recent call last):\n\n File D:\\ICDD_PDF\\TOOLS_2020\\LexiChemTK\\Struct_Name\\SmiNamImg\\zsni.py:17\n from o...
aeb35a08eb65ac9808d91372109962d8bf81ed96
{ "head_commit": "191bcdeac90c3713569d20f23ac81f46a3f1c168", "head_commit_message": "Update tests", "patch_to_review": "diff --git a/spyder/plugins/pythonpath/tests/test_utils.py b/spyder/plugins/pythonpath/tests/test_utils.py\nindex 2a6c63b133a..f4c1bdecc82 100644\n--- a/spyder/plugins/pythonpath/tests/test_util...
[ { "diff_hunk": "@@ -17,14 +17,20 @@\n \n def check_path(path):\n \"\"\"Check that `path` is not a [site|dist]-packages folder.\"\"\"\n+ pattern_string = r'(ana|Ana|mini|micro)(conda|mamba|forge)\\d*(/base)*/pkgs'", "line": null, "original_line": 20, "original_start_line": null, "path": "s...
770d655c373c8b98358f2ec2407fc360bd3c918f
diff --git a/spyder/plugins/pythonpath/tests/test_utils.py b/spyder/plugins/pythonpath/tests/test_utils.py index 2a6c63b133a..f4c1bdecc82 100644 --- a/spyder/plugins/pythonpath/tests/test_utils.py +++ b/spyder/plugins/pythonpath/tests/test_utils.py @@ -27,6 +27,7 @@ def test_check_path(tmp_path): assert not ch...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-22628@0fee65d
spyder-ide/spyder
Python
22,628
PR: Handle case when kernel fault file doesn't exist and show error with info explaining that no connection was possible (IPython Console)
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2024-10-03T00:05:43Z
TypeError on connecting to spyder-notebook kernel ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> * Open a notebook with the Notebook plugin * Consoles -> Connect to existing kernel * Select the `spynbserver-*.json` kernel file ### Traceback ```python-traceb...
Leaving this for 6.0.2 given that 6.0.1 is basically closed.
[ { "body": "## Description\r\n\r\n### What steps will reproduce the problem?\r\n\r\n<!--- You can use Markdown here --->\r\n\r\n* Open a notebook with the Notebook plugin\r\n* Consoles -> Connect to existing kernel\r\n* Select the `spynbserver-*.json` kernel file\r\n\r\n### Traceback\r\n```python-traceback\r\nTr...
f9dfab7ac825489a86103cfce8c8d80788daa413
{ "head_commit": "0fee65dd991e1bd186675e4a51e37875cb641df7", "head_commit_message": "IPython Console: Handle case when kernel fault file doesn't exist and show error with info explainig no connection was possible", "patch_to_review": "diff --git a/spyder/plugins/ipythonconsole/widgets/shell.py b/spyder/plugins/ip...
[ { "diff_hunk": "@@ -1395,10 +1395,19 @@ def _kernel_restarted_message(self, died=True):\n and not self.is_remote()\n ):\n # The kernel might never restart, show position of fault file\n- msg += (\n- \"\\n\" + _(\"Its crash file is located at:\") + \" \"\...
27326cecccd27ee56714dc95f476aae5fa5be9ea
diff --git a/spyder/plugins/ipythonconsole/widgets/shell.py b/spyder/plugins/ipythonconsole/widgets/shell.py index 21f805adde4..2a8ee8d7475 100644 --- a/spyder/plugins/ipythonconsole/widgets/shell.py +++ b/spyder/plugins/ipythonconsole/widgets/shell.py @@ -1395,10 +1395,21 @@ def _kernel_restarted_message(self, died=Tr...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12246@7e11079
scikit-learn/scikit-learn
Python
12,246
[MRG + 2] Fix cache of OpenML fetcher
Supposed to fix #12227
2018-10-02T13:31:10Z
fetch_openml() does not use the local cache #### Description `fetch_openml()` does not use the local data cached in `~/scikit_learn_data`. #### Steps/Code to Reproduce Run the following code twice. The first time, with a working Internet connexion, the second time without an Internet connexion. ```python from sk...
https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/datasets/openml.py The first thing the function `fetch_openml` does is establish whether the data is cached or not: ``` data_home = get_data_home(data_home=data_home) data_home = join(data_home, 'openml') if cache is False: # no ca...
[ { "body": "#### Description\r\n`fetch_openml()` does not use the local data cached in `~/scikit_learn_data`.\r\n\r\n#### Steps/Code to Reproduce\r\nRun the following code twice. The first time, with a working Internet connexion, the second time without an Internet connexion.\r\n```python\r\nfrom sklearn.dataset...
877e3f3235dc5caa86838ef87df75a31e08649c4
{ "head_commit": "7e1107967503d56eee3d3e8a927d6f0f7f67e68f", "head_commit_message": "fixes openml fetcher", "patch_to_review": "diff --git a/sklearn/datasets/openml.py b/sklearn/datasets/openml.py\nindex d667cb3699b28..7f2538f622757 100644\n--- a/sklearn/datasets/openml.py\n+++ b/sklearn/datasets/openml.py\n@@ -3...
[ { "diff_hunk": "@@ -459,17 +459,39 @@ def test_open_openml_url_cache(monkeypatch, gzip_response):\n _monkey_patch_webbased_functions(\n monkeypatch, data_id, gzip_response)\n openml_path = sklearn.datasets.openml._DATA_FILE.format(data_id)\n- test_directory = os.path.join(os.path.expanduser('...
301857abe7428ae3b75bd76ab27bc27269860673
diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst index 2c4ef814a0a31..d53983419533e 100644 --- a/doc/whats_new/v0.20.rst +++ b/doc/whats_new/v0.20.rst @@ -37,6 +37,9 @@ Changelog :mod:`sklearn.datasets` ............................ +- |Fix| :func:`dataset.fetch_openml` to correctly use the local cache...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
ray-project__ray-51285@65e4864
ray-project/ray
Python
51,285
[Core][Doc] Add Description for Named Placement Group to Require a Namespace
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-03-12T00:24:53Z
[core] Named placement groups don't work ### What happened + What you expected to happen On terminal 1: ``` In [1]: import ray In [2]: from ray.util.placement_group import placement_group In [3]: pg_inference = placement_group([{"CPU": 1}] * 2, name="inference") 2025-03-06 22:02:53,086 INFO worker.py:1655 -- Connec...
Hi @MengjinYan , can you help take a look as oncall? I took a look at the issue. It is seems that it is because for named placement group, you will need to specify a namespace (https://docs.ray.io/en/latest/ray-core/namespaces.html) for the placement group. This is because the query of the named placement group is by...
[ { "body": "### What happened + What you expected to happen\n\nOn terminal 1:\n\n```\nIn [1]: import ray\n\nIn [2]: from ray.util.placement_group import placement_group\n\nIn [3]: pg_inference = placement_group([{\"CPU\": 1}] * 2, name=\"inference\")\n2025-03-06 22:02:53,086\tINFO worker.py:1655 -- Connecting to...
a804b0106d3633e701f3a881dabffdc171847958
{ "head_commit": "65e4864a27e21cffdce426db59aa237b09016ccf", "head_commit_message": "udpate link\n\nSigned-off-by: Mengjin Yan <mengjinyan3@gmail.com>", "patch_to_review": "diff --git a/doc/source/ray-core/doc_code/placement_group_example.py b/doc/source/ray-core/doc_code/placement_group_example.py\nindex c8b16d7...
[ { "diff_hunk": "@@ -585,12 +585,15 @@ child tasks and actors to the same placement group, specify ``PlacementGroupSche\n [Advanced] Named Placement Group\n --------------------------------\n \n-A placement group can be given a globally unique name.\n+You can give a unique name within a :ref:`namespace <namespac...
f30b01c975c0b93b3b505fe2cbc793d5e8d0378b
diff --git a/doc/source/ray-core/doc_code/placement_group_example.py b/doc/source/ray-core/doc_code/placement_group_example.py index c8b16d70a1a0..bad171fb1886 100644 --- a/doc/source/ray-core/doc_code/placement_group_example.py +++ b/doc/source/ray-core/doc_code/placement_group_example.py @@ -129,11 +129,13 @@ def rea...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Bug Fixes" }
ray-project__ray-51281@00d10bf
ray-project/ray
Python
51,281
[data/preprocessors] Fix StandardScaler to handle NaN stats
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-03-11T23:06:04Z
[Data] `StandardScaler.transform()` cannot handle non-`NAN` columns when `StandardScaler.stats_` is `NAN` for that column ### What happened + What you expected to happen `StandardScaler.transform()` should ideally return `NAN` for columns which have `StandardScaler.stats_` as None. But the current implementation leads...
[ { "body": "### What happened + What you expected to happen\n\n`StandardScaler.transform()` should ideally return `NAN` for columns which have `StandardScaler.stats_` as None. But the current implementation leads to -\n\n```\nTypeError: unsupported operand type(s) for -: 'float' and 'NoneType'\n```\n\n### Versio...
58e1f345466241633ae990cc59b152d148b77308
{ "head_commit": "00d10bff763639b35ef254c25bd6f52b8c0b899a", "head_commit_message": "Fix StandardScaler to handle NAN stats\n\nSigned-off-by: Praveen Gorthy <praveeng@anyscale.com>", "patch_to_review": "diff --git a/python/ray/data/preprocessors/scaler.py b/python/ray/data/preprocessors/scaler.py\nindex 1a9ba9a95...
[ { "diff_hunk": "@@ -95,6 +95,10 @@ def column_standard_scaler(s: pd.Series):\n s_mean = self.stats_[f\"mean({s.name})\"]\n s_std = self.stats_[f\"std({s.name})\"]\n \n+ if s_std is None and s_mean is None:\n+ s[:] = None", "line": null, "original_line": ...
8aa92d920e372069fd9b0a4350f6528e063554ba
diff --git a/python/ray/data/preprocessors/scaler.py b/python/ray/data/preprocessors/scaler.py index 1a9ba9a95682..3771db0e296c 100644 --- a/python/ray/data/preprocessors/scaler.py +++ b/python/ray/data/preprocessors/scaler.py @@ -95,6 +95,10 @@ def column_standard_scaler(s: pd.Series): s_mean = self.stats...
{ "difficulty": "low", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12104@b073a68
scikit-learn/scikit-learn
Python
12,104
[MRG] Convert ColumnTransformer input list to numpy array
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fi...
2018-09-18T11:50:33Z
ColumnTransformer breaks where X is a list ```py >>> from sklearn.preprocessing import StandardScaler >>> from sklearn.compose import ColumnTransformer >>> ColumnTransformer([('foobar', StandardScaler(), [0, 1, 2])]).fit([[1, 2, 3]]) Traceback (most recent call last): File "<stdin>", line 1, in <module> File ...
[ { "body": "```py\r\n>>> from sklearn.preprocessing import StandardScaler\r\n>>> from sklearn.compose import ColumnTransformer\r\n>>> ColumnTransformer([('foobar', StandardScaler(), [0, 1, 2])]).fit([[1, 2, 3]])\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"/Users/j...
0c0a9e8406987fd53ccd705c3e455514c47c49c4
{ "head_commit": "b073a680c2dd673a484e2c14a5fa77cd85d05403", "head_commit_message": "Add check_array", "patch_to_review": "diff --git a/sklearn/compose/_column_transformer.py b/sklearn/compose/_column_transformer.py\nindex e09d2d09d7e43..932e32b988983 100644\n--- a/sklearn/compose/_column_transformer.py\n+++ b/sk...
[ { "diff_hunk": "@@ -467,6 +469,8 @@ def transform(self, X):\n \"\"\"\n check_is_fitted(self, 'transformers_')\n \n+ X = check_array(X)", "line": null, "original_line": 472, "original_start_line": null, "path": "sklearn/compose/_column_transformer.py", "start_line": nul...
dc7f74d124178a741f858737c8e4f10a8c01a720
diff --git a/sklearn/compose/_column_transformer.py b/sklearn/compose/_column_transformer.py index 9014623280d2e..408c7a530395a 100644 --- a/sklearn/compose/_column_transformer.py +++ b/sklearn/compose/_column_transformer.py @@ -16,12 +16,11 @@ from ..base import clone, TransformerMixin from ..utils import Parallel, ...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12084@c98a6c1
scikit-learn/scikit-learn
Python
12,084
ColumnTransformer generalization to work on empty lists
#### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests --> Fixe...
2018-09-14T19:23:10Z
ColumnTransformer requires at least one column for each part it transforms #### Description <!-- Example: Joblib Error thrown when calling fit on LatentDirichletAllocation with evaluate_every > 0--> ColumnTransformer requires at least one column for each part it transforms. This sounds logical, but makes automatic ex...
@janvanrijn thanks for the feedback! Yes, I think this is a case that we would want to support. The question is maybe whether it are the other transformers that should support 0 features (it is the imputer that is raising the error), or whether the ColumnTransformer should be smart enough to not pass the data through ...
[ { "body": "#### Description\r\n<!-- Example: Joblib Error thrown when calling fit on LatentDirichletAllocation with evaluate_every > 0-->\r\nColumnTransformer requires at least one column for each part it transforms. This sounds logical, but makes automatic experimentation across datasets with mixed input types...
4035e60a6f0a0a2546bf0442ab603961c6a9cc4a
{ "head_commit": "c98a6c10f8a8d5a7d58df14d3af850c4eb0e7798", "head_commit_message": "incorporated comments by Roman and Joel", "patch_to_review": "diff --git a/sklearn/compose/_column_transformer.py b/sklearn/compose/_column_transformer.py\nindex e09d2d09d7e43..61f6a427a9920 100644\n--- a/sklearn/compose/_column_...
[ { "diff_hunk": "@@ -234,6 +236,8 @@ def _iter(self, X=None, fitted=False, replace_strings=False):\n check_inverse=False)\n elif trans == 'drop':\n continue\n+ elif hasattr(column, '__len__') and len(column) == 0:", "line": null, ...
7a5ccafecfec07d57f2faa1b8a4ec66014ec9806
diff --git a/sklearn/compose/_column_transformer.py b/sklearn/compose/_column_transformer.py index 9014623280d2e..b7be3c8ef1455 100644 --- a/sklearn/compose/_column_transformer.py +++ b/sklearn/compose/_column_transformer.py @@ -109,8 +109,10 @@ class ColumnTransformer(_BaseComposition, TransformerMixin): transfor...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "New Feature Additions" }
ray-project__ray-50959@3377daa
ray-project/ray
Python
50,959
[core][autoscaler][v1] fix crashes by infeasible strict spread placement groups
## Why are these changes needed? As the issue https://github.com/ray-project/ray/issues/39691 describes, the autoscaler v1 will **crash intentionally** on any infeasible strict spread placement group. This PR changes the behavior to **skipping** such groups. <!-- Please give a short summary of the change and the ...
2025-02-27T21:24:08Z
[core][autoscaler][v1] Infeasible strict spread Placement group would cause autoscaler stops ### What happened + What you expected to happen When a strict spread PG cannot be fulfilled, it currently crashed the autoscaler v1's processing loop. ``` 2023-09-15 18:46:02,079 CRITICAL autoscaler.py:377 -- StandardAuto...
1. Is it a regression? 2. When is the plan to migrate to V2? > 1. Is it a regression? > 2. When is the plan to migrate to V2? 1. Not a regression, has been around in v1. 2. Will be fixed in v2. Fixing in v2 is P0 to explicitly scope the problem here. is this fixed in v2? I will downgrade all v1 autoscaling iss...
[ { "body": "### What happened + What you expected to happen\n\nWhen a strict spread PG cannot be fulfilled, it currently crashed the autoscaler v1's processing loop. \r\n\r\n```\r\n2023-09-15 18:46:02,079 CRITICAL autoscaler.py:377 -- StandardAutoscaler: Too many errors, abort.\r\n2023-09-15 18:46:02,079 ERROR m...
52d3e506a63769513e462278ad939e9bf781780a
{ "head_commit": "3377daa90ed83564fcb6dc00741c7cf2adfa5859", "head_commit_message": "Merge branch 'master' into fix-crash-unfulfilled-strict-spread", "patch_to_review": "diff --git a/python/ray/autoscaler/_private/resource_demand_scheduler.py b/python/ray/autoscaler/_private/resource_demand_scheduler.py\nindex 1d...
[ { "diff_hunk": "@@ -592,8 +590,12 @@ def reserve_and_allocate_spread(\n unfulfilled, including_reserved = get_bin_pack_residual(\n new_node_resources, unfulfilled, strict_spread=True\n )\n- assert not unfulfilled\n- node_resources += including_reserv...
7d38b468e9f8d2291c4622da893e180ed413e9e0
diff --git a/python/ray/autoscaler/_private/resource_demand_scheduler.py b/python/ray/autoscaler/_private/resource_demand_scheduler.py index 1db20be69c62..3f08f6dd10c9 100644 --- a/python/ray/autoscaler/_private/resource_demand_scheduler.py +++ b/python/ray/autoscaler/_private/resource_demand_scheduler.py @@ -568,7 +56...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
ray-project__ray-51006@50c82bf
ray-project/ray
Python
51,006
make latency buckets configurable
## Why are these changes needed? The choice of bucket boundaries in Prometheus is an application-level decision. Well-defined boundaries lead to more accurate quantile calculations, while poor choices can result in less precise estimates. This PR exposes bucket boundary configuration to users via two environment...
2025-02-28T23:14:57Z
[serve] Make latency buckets configurable ### Description The latency buckets used for the latency histogram heavily affect how we calculate P50, P90 etc latency on Grafana. We should make this configurable so users who know roughly how long their requests will take can modify the buckets to match that. ### Use case ...
## Prometheus Histogram Boundaries The Prometheus histogram boundaries are fetched from `DEFAULT_LATENCY_BUCKET_MS` in `constants.py`. ### Current Usage of `Histogram` Metrics The `Histogram` metric is used in the following scenarios: 1. **Model Load/Unload Times** – Tracks the time taken to load/unload mult...
[ { "body": "### Description\n\nThe latency buckets used for the latency histogram heavily affect how we calculate P50, P90 etc latency on Grafana. We should make this configurable so users who know roughly how long their requests will take can modify the buckets to match that.\n\n### Use case\n\n_No response_", ...
678a8d75b47730d6685341a61bc8d14e924a61f8
{ "head_commit": "50c82bf36a9ad20febabe879a8e004a22fb98f96", "head_commit_message": "make latency buckets configurable\n\nSigned-off-by: Abrar Sheikh <abrar2002as@gmail.com>", "patch_to_review": "diff --git a/python/ray/serve/_private/constants.py b/python/ray/serve/_private/constants.py\nindex ff7c292a5d945..46b...
[ { "diff_hunk": "@@ -78,6 +83,39 @@\n 600000,\n ]\n \n+\n+def _parse_latency_buckets(bucket_str: str) -> list:\n+ if not bucket_str.strip():\n+ return DEFAULT_LATENCY_BUCKET_MS", "line": null, "original_line": 89, "original_start_line": 87, "path": "python/ray/serve/_private/constan...
fd64f89b673f123a276321215cbcbac98607a6ab
diff --git a/python/ray/serve/_private/constants.py b/python/ray/serve/_private/constants.py index 66fd5492748e..3f904032f404 100644 --- a/python/ray/serve/_private/constants.py +++ b/python/ray/serve/_private/constants.py @@ -53,6 +53,12 @@ # min(num_replicas * MAX_PER_REPLICA_RETRY_COUNT, MAX_DEPLOYMENT_CONSTRUCTOR_...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "New Feature Additions" }
scikit-learn__scikit-learn-12004@c600edd
scikit-learn/scikit-learn
Python
12,004
[MRG] pulling data from openml.org rather than original data source
Fixes #11858 #### What does this implement/fix? Explain your changes. This pulls data from openml.org rather than the original data source. #### Any other comments? The dataset has spent several days on openml.org but is still "in_preparation". Data can be pulled via `fetch_openml`, but gives a warning about ...
2018-09-04T19:51:58Z
Upload Mauna Loa CO2 data to OpenML.org examples/gaussian_process/plot_gpr_co2.py relies on a dataset that we used to fetch from mldata.org. Now we download it from its original source, but that server may not be reliable, etc. We also process only the monthly averages from a weekly reading. We should have this data...
Hi @jnothman, is it cool if I help on this? Since `load_mauna_loa_atmospheric_co2()` only outputs the date and co2 data (and mldata only has the two), are you thinking have just those two features on openml? Or upload the full dataset from its original source and parse as needed? We also only use monthly averages....
[ { "body": "examples/gaussian_process/plot_gpr_co2.py relies on a dataset that we used to fetch from mldata.org. Now we download it from its original source, but that server may not be reliable, etc. We also process only the monthly averages from a weekly reading.\r\n\r\nWe should have this data on openml. I don...
ddf37c75c7b912104df56e1325363cd94a4fdd5f
{ "head_commit": "c600edd13c126c70487ca853cf0b82131901fd76", "head_commit_message": "fixing pep8 issues", "patch_to_review": "diff --git a/examples/gaussian_process/plot_gpr_co2.py b/examples/gaussian_process/plot_gpr_co2.py\nindex 8170de01898dc..5c25d71d45fcf 100644\n--- a/examples/gaussian_process/plot_gpr_co2....
[ { "diff_hunk": "@@ -80,28 +80,24 @@\n \n \n def load_mauna_loa_atmospheric_c02():\n- url = ('http://cdiac.ess-dive.lbl.gov/'\n- 'ftp/trends/co2/sio-keel-flask/maunaloa_c.dat')\n+ ml_data = fetch_openml(data_id=41187)\n months = []\n ppmv_sums = []\n counts = []\n- for line in urlo...
4b92cd79020c64ca36e63bb76109bb014d9ad63e
diff --git a/examples/gaussian_process/plot_gpr_co2.py b/examples/gaussian_process/plot_gpr_co2.py index 8170de01898dc..4c438ce821284 100644 --- a/examples/gaussian_process/plot_gpr_co2.py +++ b/examples/gaussian_process/plot_gpr_co2.py @@ -66,7 +66,7 @@ import numpy as np from matplotlib import pyplot as plt - +fr...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "New Feature Additions" }
ray-project__ray-50986@96ed393
ray-project/ray
Python
50,986
[Docs][Data] Ordering of rows
## Why are these changes needed? Adds a section about impact of operators on ordering of rows to docs. ## Related issue number Closes #50890 ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in th...
2025-02-28T11:26:18Z
[Data] Ordering of blocks after map and map_batches ### What happened + What you expected to happen I have a dataset in files, rows are sorted within files and files are sorted by name in the same folder. After applying `map` or `map_batches`, the order of blocks is different than before applying `map` or `map_batches...
Interestingly, it works as expected if I sort the dataset first: ``` dataset = dataset.sort("time_to_sleep", descending=True) ``` But it doesn't solve the issue because sorting key might not be present in the data. You can try setting preserve_order to get what you're looking for -- https://docs.ray.io/en/latest/data/...
[ { "body": "### What happened + What you expected to happen\n\nI have a dataset in files, rows are sorted within files and files are sorted by name in the same folder. After applying `map` or `map_batches`, the order of blocks is different than before applying `map` or `map_batches`.\n\nExpected behavior: `map`...
b53dc04d0d2fbf66b890bf42cd5f9af7003408ca
{ "head_commit": "96ed393240717b66e9079bb2a2457e79f8f3110d", "head_commit_message": "fix\n\nSigned-off-by: Richard Liaw <rliaw@berkeley.edu>", "patch_to_review": "diff --git a/doc/source/data/transforming-data.rst b/doc/source/data/transforming-data.rst\nindex 9120575485f0..a78fb3843c93 100644\n--- a/doc/source/d...
[ { "diff_hunk": "@@ -218,6 +219,22 @@ NumPy functions and model inference. However, if your batch size is too large, y\n program might run out of memory. If you encounter an out-of-memory error, decrease your\n ``batch_size``.\n \n+.. _ordering_of_rows:\n+\n+Ordering of rows\n+================\n+\n+When transfor...
a87b47665ea51bb6ba7b3d2b0eb5ebb0d8547219
diff --git a/doc/source/data/transforming-data.rst b/doc/source/data/transforming-data.rst index 9120575485f0..6cacf4c18a2c 100644 --- a/doc/source/data/transforming-data.rst +++ b/doc/source/data/transforming-data.rst @@ -14,6 +14,7 @@ This guide shows you how to: * :ref:`Transform rows <transforming_rows>` * :ref...
{ "difficulty": "low", "estimated_review_effort": 1, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12218@7cf2dbe
scikit-learn/scikit-learn
Python
12,218
[MRG+1] Added estimator checks for pandas object
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fi...
2018-09-29T19:46:44Z
Add dataframe test to common tests. We should test that estimators play nice with DataFrames. Currently there is a test for NotAnArray. We should also explicitly test pandas, I think, with a lazy import. We now have pandas on one of the CI builds.
I am taking this up. @amueller Could you tell me the files associated with the issue? utils/estimator_checks.py testing/test_common.py Sorry for the delay, it is an AFK, kinda week. I will try my best to patch it up ASAP. Should I create a NotADataframe class in the estimate_check file, then a check_transformer for...
[ { "body": "We should test that estimators play nice with DataFrames.\nCurrently there is a test for NotAnArray. We should also explicitly test pandas, I think, with a lazy import.\nWe now have pandas on one of the CI builds.\n", "number": 7528, "title": "Add dataframe test to common tests." } ]
00841fab693de82432ef153724a2667d328cc3a1
{ "head_commit": "7cf2dbe545df16309555c699cf660caf45bcd998", "head_commit_message": "Revert \"used pytest.importorskip\"\n\nThis reverts commit 4526d5b07dce43010c31854ab1b62c3b4290c023.", "patch_to_review": "diff --git a/sklearn/utils/estimator_checks.py b/sklearn/utils/estimator_checks.py\nindex 6b411fca2a2a4..4...
[ { "diff_hunk": "@@ -117,8 +117,8 @@ def _yield_checks(name, estimator):\n def _yield_classifier_checks(name, classifier):\n tags = _safe_tags(classifier)\n \n- # test classifiers can handle non-array data\n- yield check_classifier_data_not_an_array\n+ # test classifiers can handle non-array data an...
b38c53625f29cf4536cf5cf05aba6e2ea68ec172
diff --git a/sklearn/utils/estimator_checks.py b/sklearn/utils/estimator_checks.py index b8471daf5deab..12d3ec4e26b76 100644 --- a/sklearn/utils/estimator_checks.py +++ b/sklearn/utils/estimator_checks.py @@ -117,7 +117,7 @@ def _yield_checks(name, estimator): def _yield_classifier_checks(name, classifier): tags ...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "New Feature Additions" }
spyder-ide__spyder-22075@06edaf5
spyder-ide/spyder
Python
22,075
PR: Fix setting user environment variables on Windows
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2024-05-13T21:21:40Z
Adding "User environment variables in Windows registry" ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> 1. Clicked top menu Tools->Currentuserenvironment variables... 2. Open context menu by right click in free space below environment variables list in windo "User envi...
Using Operating System Version: Windows 11 Home, not Windows 10 as mentioned in the issue report. Best regards, Florian Von: Florian Bethe ***@***.***> Gesendet: Mittwoch, 7. Februar 2024 11:05 An: spyder-ide/spyder ***@***.***> Cc: Florian Bethe ***@***.***>; Your activity ***@***.***> Betreff:...
[ { "body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\n1. Clicked top menu Tools->Currentuserenvironment variables...\n\n2. Open context menu by right click in free space below environment variables list in windo \"User environment variables in Windows...
eeb9c783438ff9cb82cfc61b60a79181349a9bc5
{ "head_commit": "06edaf5e709706d63b65b7ff3de32974113cce8b", "head_commit_message": "Fix issue: \"ValueError: Could not convert the data to the specified type.\"\n\nWhen inserting new variable in user environment variables on Windows, the value may not be a string and results in the error above.", "patch_to_revie...
[ { "diff_hunk": "@@ -1590,6 +1590,7 @@ def set_filter(self, dictfilter=None):\n \n class CollectionsEditorWidget(QWidget, SpyderWidgetMixin):\n \"\"\"Dictionary Editor Widget\"\"\"\n+ CONF_SECTION = 'main'", "line": null, "original_line": 1593, "original_start_line": null, "path": "spyder/...
8ffa400fd9a6a355318868c07d1a4656da86c368
diff --git a/spyder/utils/environ.py b/spyder/utils/environ.py index 899e241ee3c..fc95d78f749 100644 --- a/spyder/utils/environ.py +++ b/spyder/utils/environ.py @@ -131,7 +131,7 @@ def set_user_env(env, parent=None): Set user environment variables via HKCU (Windows) or shell startup file (Unix). """ - ...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-12077@0b8e161
scikit-learn/scikit-learn
Python
12,077
[MRG+2] OPTICS: add extract_xi method
Related: #12036, #12053, #11677 Fixes #12376 Adding the Xi extraction method to OPTICS. @espg, I'll need the `predecessor_` to add that final touch to it. I'm still testing the implementation, but it'll be nice if I could get some feedback. (done) Differences with the [paper](http://citeseerx.ist.psu.edu/view...
2018-09-14T15:58:14Z
OPTICS Return all the clusters found by the extraction algorithm In OPTICS, the automatic extraction algorithm actually returns all possible clusters, but currently we only provide users with the clusters on the leaves. I guess we can provide users with an option to get all these clusters. (R provides clusters_xi attri...
Both `extract_sqlnk` and `extract_xi` provide a hierarchy of clusters. I've already put `return_clusters` as a parameter to `extract_xi` in #12077. We can also extract the cluster hierarchy from the tree constructed by sqlnk. I'd say we can add `store_cluster_hierarchy` (or something) to the `OPTICS`'s init, and sto...
[ { "body": "In OPTICS, the automatic extraction algorithm actually returns all possible clusters, but currently we only provide users with the clusters on the leaves. I guess we can provide users with an option to get all these clusters. (R provides clusters_xi attribute).\r\nping @espg @adrinjalali (I think it'...
badaa153e67ffa56fb1a413b3b7b5b8507024291
{ "head_commit": "0b8e161b3c63386afb7041bb7dfae4dac3eb0306", "head_commit_message": "fix min_cluster_size as 1", "patch_to_review": "diff --git a/doc/modules/classes.rst b/doc/modules/classes.rst\nindex 7464729a52e0d..aa4fa44e5bb12 100644\n--- a/doc/modules/classes.rst\n+++ b/doc/modules/classes.rst\n@@ -114,6 +1...
[ { "diff_hunk": "@@ -527,3 +568,382 @@ def cluster_optics_dbscan(reachability, core_distances, ordering, eps=0.5):\n labels[ordering] = np.cumsum(far_reach[ordering] & near_core[ordering]) - 1\n labels[far_reach & ~near_core] = -1\n return labels\n+\n+\n+def cluster_optics_xi(reachability, predecesso...
c1e5cde546f60a9c40747d20abba38c3d6d28988
diff --git a/doc/modules/classes.rst b/doc/modules/classes.rst index e06e5139ea8f3..fe3fe7e5bbe86 100644 --- a/doc/modules/classes.rst +++ b/doc/modules/classes.rst @@ -114,6 +114,7 @@ Functions cluster.affinity_propagation cluster.cluster_optics_dbscan + cluster.cluster_optics_xi cluster.compute_optics...
{ "difficulty": "high", "estimated_review_effort": 4, "problem_domain": "New Feature Additions" }
ray-project__ray-50590@3dad0b2
ray-project/ray
Python
50,590
[data] add iceberg write support through pyiceberg
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-02-14T03:42:17Z
[data] Extend Ray Data with IcebergDataSink for Distributed Writes to Iceberg Tables ### Description Currently, Ray supports distributed reads from Iceberg tables but lacks support for distributed writes. To enhance the functionality of Ray in handling Iceberg tables, it is proposed to extend the datasink module withi...
This proposal makes sense; would you be interested in contributing? A couple of questions about the proposal: - The current proposal suggests that we will only support append operations, not delete operations (whether quality deletes or positional deletes). Or does pyiceberg support merge-on-read, and we can take care...
[ { "body": "### Description\n\nCurrently, Ray supports distributed reads from Iceberg tables but lacks support for distributed writes. To enhance the functionality of Ray in handling Iceberg tables, it is proposed to extend the datasink module within Ray Data by introducing an IcebergDataSink. This would allow u...
e18a59ab6513f8332ce2abf1ed765c48ff2dce8a
{ "head_commit": "3dad0b2859dfda5b6de113b13b7a63cf2a90e00b", "head_commit_message": "fix write iceberg table\n\nSigned-off-by: Jimmy Xie <rxie@figma.com>", "patch_to_review": "diff --git a/doc/source/data/api/input_output.rst b/doc/source/data/api/input_output.rst\nindex 6487f06a968b..781d4e038471 100644\n--- a/d...
[ { "diff_hunk": "@@ -0,0 +1,153 @@\n+\"\"\"\n+Module to write a Ray Dataset into an iceberg table, by using the Ray Datasink API.\n+\"\"\"\n+import logging\n+\n+from typing import TYPE_CHECKING, Any, Dict, Iterable, List, Optional\n+\n+from ray.data.datasource.datasink import Datasink\n+from ray.util.annotations...
dd6b3b8183c9ed8b24dd02816b5db005334ff688
diff --git a/doc/source/data/api/input_output.rst b/doc/source/data/api/input_output.rst index 6487f06a968b..781d4e038471 100644 --- a/doc/source/data/api/input_output.rst +++ b/doc/source/data/api/input_output.rst @@ -212,6 +212,7 @@ Iceberg :toctree: doc/ read_iceberg + Dataset.write_iceberg Lance ---...
{ "difficulty": "high", "estimated_review_effort": 4, "problem_domain": "New Feature Additions" }
scikit-learn__scikit-learn-11957@16f5493
scikit-learn/scikit-learn
Python
11,957
[MRG] Allow scoring of dummies without testsamples
As DummyClassifier and DummyRegressor operate solely on the targets, they can now be used without passing test samples, instead passing None. Also includes some minor renaming in the corresponding tests for more consistency. <!-- Thanks for contributing a pull request! Please ensure you have taken a look at the...
2018-08-31T13:45:19Z
Scoring for dummy classifier does not work without test samples When using the `Dummy classifier`, it is possible to fit the classifier without providing any examples, which makes sense as the classifier only operates on the targets. However, it is not possible to score the classifier without providing examples. Using ...
I suppose this would be consistent. PR welcome
[ { "body": "When using the `Dummy classifier`, it is possible to fit the classifier without providing any examples, which makes sense as the classifier only operates on the targets. However, it is not possible to score the classifier without providing examples. Using `DummyClassifier` without examples is helpful...
ddf37c75c7b912104df56e1325363cd94a4fdd5f
{ "head_commit": "16f5493f9c814bfd9f2ac3e983196c0888117807", "head_commit_message": "Add newline at end of file", "patch_to_review": "diff --git a/sklearn/dummy.py b/sklearn/dummy.py\nindex f2c866413183b..0e5371ac42239 100644\n--- a/sklearn/dummy.py\n+++ b/sklearn/dummy.py\n@@ -318,6 +318,36 @@ def predict_log_pr...
[ { "diff_hunk": "@@ -478,3 +508,46 @@ def predict(self, X, return_std=False):\n y_std = np.ravel(y_std)\n \n return (y, y_std) if return_std else y\n+\n+ def score(self, X, y, sample_weight=None):\n+ \"\"\"Returns the coefficient of determination R^2 of the prediction.\n+\n+ ...
ebedf42202c15c01d0dad9d32f20e544d1256756
diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst index 2ed336b782174..3866f5c611499 100644 --- a/doc/whats_new/v0.20.rst +++ b/doc/whats_new/v0.20.rst @@ -291,6 +291,10 @@ Support for Python 3.3 has been officially dropped. only require X to be an object with finite length or shape. :issue:`9832` by ...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
ray-project__ray-50517@dd9ccf4
ray-project/ray
Python
50,517
[Core] Fix check failure due to negative available resource
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-02-13T06:23:27Z
[Core] Crash in raylet (ray::RayLog::~RayLog) ### What happened + What you expected to happen I am experiencing raylet crashes like this: ``` (raylet) [2025-02-11 18:42:15,859 C 30797 30797] resource_instance_set.cc:374: Check failed: RAY_PREDICT_TRUE(_left_ >= _right_) 0 vs 10000 (raylet) *** StackTrace Informatio...
[ { "body": "### What happened + What you expected to happen\n\nI am experiencing raylet crashes like this:\n\n```\n(raylet) [2025-02-11 18:42:15,859 C 30797 30797] resource_instance_set.cc:374: Check failed: RAY_PREDICT_TRUE(_left_ >= _right_) 0 vs 10000\n(raylet) *** StackTrace Information ***\n(raylet) /usr/...
2e0d379c0aa034b4deac512b41f63d1a424563b4
{ "head_commit": "dd9ccf498a2e2c2e7d760623588c3d6a53e94a73", "head_commit_message": "up\n\nSigned-off-by: Jiajun Yao <jeromeyjj@gmail.com>", "patch_to_review": "diff --git a/src/ray/common/bundle_spec.cc b/src/ray/common/bundle_spec.cc\nindex 833ec7c5a82ec..7624919f273e5 100644\n--- a/src/ray/common/bundle_spec.c...
[ { "diff_hunk": "@@ -371,7 +371,12 @@ void NodeResourceInstanceSet::AllocateWithReference(\n RAY_CHECK_EQ(available.size(), ref_allocation.size());\n \n for (size_t i = 0; i < ref_allocation.size(); i++) {\n- RAY_CHECK_GE(available[i], ref_allocation[i]);\n+ if (available[i] < ref_allocation[i]) {\n+ ...
8724237eaa8b32f0dacc998596a1dbf431f9f921
diff --git a/src/ray/common/BUILD b/src/ray/common/BUILD index 040c02e0a918..b971641a497a 100644 --- a/src/ray/common/BUILD +++ b/src/ray/common/BUILD @@ -182,6 +182,7 @@ ray_cc_library( ":runtime_env", "//:node_manager_fbs", "//src/ray/util", + "//src/ray/util:container_util", ...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
ray-project__ray-50886@91c6637
ray-project/ray
Python
50,886
[Core] Logic Added to Cancel Infeasible Tasks in GCS Based on Autoscaler State
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-02-25T06:16:54Z
Make infeasible tasks error much more obvious Many times I see users run into common error scenarios that end up hanging the entire workload. 1. Scheduling something on the head node when head node `num_cpus=0` 2. Scheduling a task that requests more cpus or gpus then is available in the cluster. (And autoscaling is d...
adding for consideration in next sprint can we consider this for next sprint? This comes up in ray data as well. @jjyao what would be the tshirt size for this? not done yet
[ { "body": "Many times I see users run into common error scenarios that end up hanging the entire workload.\n\n1. Scheduling something on the head node when head node `num_cpus=0`\n2. Scheduling a task that requests more cpus or gpus then is available in the cluster. (And autoscaling is disabled)\n\nAlthough we ...
4d110f39010995524f317bb627fde46b0230a78f
{ "head_commit": "91c6637b5a72b375aaca20000a1200d1ffa98b88", "head_commit_message": "remove unused include\n\nSigned-off-by: Mengjin Yan <mengjinyan3@gmail.com>", "patch_to_review": "diff --git a/python/ray/tests/test_autoscaler_e2e.py b/python/ray/tests/test_autoscaler_e2e.py\nindex 45fb8e6f6eb97..559bc693c770f ...
[ { "diff_hunk": "@@ -266,6 +266,105 @@ def test_node_launch_exception_serialization(shutdown_only):\n assert after_serialization.src_exc_info is None\n \n \n+def test_infeasible_task_early_cancellation_normal_tasks(shutdown_only):\n+ cluster = AutoscalingCluster(\n+ head_resources={\"CPU\": 0},\n+ ...
f0f3d1cc7ce66539853e80ba0d322ef69ad54a2e
diff --git a/python/ray/tests/conftest.py b/python/ray/tests/conftest.py index 2a9a7fc7428c..afa8a4c80a6b 100644 --- a/python/ray/tests/conftest.py +++ b/python/ray/tests/conftest.py @@ -18,6 +18,7 @@ from unittest import mock import psutil import pytest +import copy import ray import ray._private.ray_constants ...
{ "difficulty": "high", "estimated_review_effort": 4, "problem_domain": "Bug Fixes" }
ray-project__ray-50434@cbf1dfd
ray-project/ray
Python
50,434
[core][cgraph] Fix compiled graph buffer release issues
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-02-11T19:19:47Z
[core][compiled graphs] Ray 2.42 got RayCgraphCapacityExceeded in vLLM ### What happened + What you expected to happen ``` INFO 02-10 16:54:48 async_llm_engine.py:211] Added request cmpl-409c81096d49467f9d71b9c645820aa1-0. ERROR 02-10 16:54:48 async_llm_engine.py:68] Engine background task failed ERROR 02-10 16:54:48 ...
[ { "body": "### What happened + What you expected to happen\n\n```\nINFO 02-10 16:54:48 async_llm_engine.py:211] Added request cmpl-409c81096d49467f9d71b9c645820aa1-0.\nERROR 02-10 16:54:48 async_llm_engine.py:68] Engine background task failed\nERROR 02-10 16:54:48 async_llm_engine.py:68] Traceback (most recent ...
95fd73efc15522e6fcd90fc671dec3c3c5491349
{ "head_commit": "cbf1dfddcc3e3cfc19db890b09e559884a044c85", "head_commit_message": "up\n\nSigned-off-by: Rui Qiao <ruisearch42@gmail.com>", "patch_to_review": "diff --git a/python/ray/dag/compiled_dag_node.py b/python/ray/dag/compiled_dag_node.py\nindex 28709285d9ae..573f3d5025a4 100644\n--- a/python/ray/dag/com...
[ { "diff_hunk": "@@ -2247,50 +2247,169 @@ def _get_execution_results(\n ]\n else:\n result = [self._result_buffer[execution_index].pop(channel_index)]\n- if len(self._result_buffer[execution_index]) == 0:\n- del self._result_buffer[execution_index]\n+\n+ ...
e2afaf6da5377c9898f10a1317c914863dd4b214
diff --git a/python/ray/_private/worker.py b/python/ray/_private/worker.py index 97e97aa48bec..c9a33b78f0c2 100644 --- a/python/ray/_private/worker.py +++ b/python/ray/_private/worker.py @@ -871,7 +871,7 @@ def get_objects( returned list. If False, then the first found exception will be ...
{ "difficulty": "high", "estimated_review_effort": 4, "problem_domain": "Performance Optimizations" }
scikit-learn__scikit-learn-12155@aeaed79
scikit-learn/scikit-learn
Python
12,155
[MRG] BUG: check equality instead of identity in check_cv
closes #12154 Check for equality instead of identity which does not hold when n_jobs=-1 due to some copy.
2018-09-25T08:50:08Z
BUG: check_cv check for cv is 'warn' instead of cv == 'warn' which is raising an exception with n_jobs=-1 In `_split.py`, `cv is 'warn'` will not work as intended since cv will be copied if `n_jobs=-1`. ```python from sklearn.datasets import load_iris from sklearn.mod...
[ { "body": "In `_split.py`, `cv is 'warn'` will not work as intended since cv will be copied if `n_jobs=-1`.\r\n\r\n```python\r\nfrom sklearn.datasets import load_iris \r\nfrom sklearn.model_selection import GridSearchCV \r\nfrom s...
fc7d6e698668b983cee2867b1bf3c65f1384e4cf
{ "head_commit": "aeaed79e0d23908612fab5cce91d4633de3c9d4b", "head_commit_message": "BUG: check equality instead of identity in check_cv", "patch_to_review": "diff --git a/sklearn/model_selection/_split.py b/sklearn/model_selection/_split.py\nindex 75c8e5d239d08..0aefbeb7f04e2 100644\n--- a/sklearn/model_selectio...
[ { "diff_hunk": "@@ -281,6 +281,17 @@ def test_cross_val_score():\n error_score='raise')\n \n \n+@pytest.mark.filterwarnings('ignore:You should specify a value for') # 0.22\n+def test_cross_validate_many_jobs():\n+ # regression test for #12154: cv='warn' with n_jobs=-1 trigger a copy of\n+ ...
16290cdb8f00162e97fe2416be75643b19cd243e
diff --git a/sklearn/model_selection/_split.py b/sklearn/model_selection/_split.py index 75c8e5d239d08..954a6c2bd443e 100644 --- a/sklearn/model_selection/_split.py +++ b/sklearn/model_selection/_split.py @@ -422,7 +422,7 @@ class KFold(_BaseKFold): def __init__(self, n_splits='warn', shuffle=False, ...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Bug Fixes" }
ray-project__ray-51122@96233f9
ray-project/ray
Python
51,122
[core][autoscaler][v1] do not removing nodes for upcoming placement groups
## Why are these changes needed? As described in the issue https://github.com/ray-project/ray/issues/50783, the autoscaler may remove existing nodes that is going to satisfy a placement group due to being idle while new nodes are coming up. This can cause a placement group to be never scheduled if the time for setti...
2025-03-06T08:23:38Z
[Autoscaler] Autoscaler gets into infinite cycle of removing and adding nodes, never satisfies placement group ### What happened + What you expected to happen Autoscaler often removes existing nodes while it is adding nodes to meet the demands of a placement group. This can cause it to get into an endless cycle of rem...
Hi @jjyao, @kevin85421 I'd like to help with this issue! Could you assign me on this? @rueian can you check whether the issue is related to https://github.com/ray-project/ray/pull/48924? In addition, would you mind reviewing #48924? > [@rueian](https://github.com/rueian) can you check whether the issue is related to [#...
[ { "body": "### What happened + What you expected to happen\n\nAutoscaler often removes existing nodes while it is adding nodes to meet the demands of a placement group. This can cause it to get into an endless cycle of removing and adding nodes, never satisfying the placement group demand.\n\nI have noticed tha...
761b41843a401f0a122a997ae428b61a8675b044
{ "head_commit": "96233f9f2084c3a3786373f48015f68bbbbc7efb", "head_commit_message": "[core][autoscaler] add start_node_delay_s config to FakeMultiNodeProvider for testing edge cases of idle_timeout_minutes\n\nSigned-off-by: Rueian <rueiancsie@gmail.com>", "patch_to_review": "diff --git a/python/ray/autoscaler/_pr...
[ { "diff_hunk": "@@ -893,6 +892,20 @@ def _get_nodes_needed_for_request_resources(\n assert self.provider\n \n nodes_not_allowed_to_terminate: Set[NodeID] = set()\n+\n+ (\n+ placement_group_demand_vector,", "line": null, "original_line": 897, "original_start_line": n...
76cae121b4ed92dd47e0535af939341141db4dc2
diff --git a/python/ray/autoscaler/_private/autoscaler.py b/python/ray/autoscaler/_private/autoscaler.py index 6874d90376b6..f6d66dc4eed2 100644 --- a/python/ray/autoscaler/_private/autoscaler.py +++ b/python/ray/autoscaler/_private/autoscaler.py @@ -47,6 +47,7 @@ ResourceDemandScheduler, ResourceDict, g...
{ "difficulty": "high", "estimated_review_effort": 4, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-11596@19605c3
scikit-learn/scikit-learn
Python
11,596
[MRG+2] Add sklearn show_versions() method
PR that adds a `show_versions()` method convenient for debugging. #### Reference Issues/PRs Fixes #11522 #### What does this implement/fix? Explain your changes. Fork of the `pandas.show_versions()`. It displays optionally the system BLAS information.
2018-07-17T15:42:55Z
Add sklearn.show_versions() similar to pandas.show_versions (with numpy blas binding info) Some numeric issues are related to the specific blas that numpy is using. I'm wondering if it makes sense to add the relevant ``system_info`` invocations to the template to make it easier for people to report.
I don't see why not! @lesteve suggested we could add something like `pandas.show_versions()` that would print all the relevant information for debugging. For instance, on my laptop, I get, <details> ``` >>> pd.show_versions() INSTALLED VERSIONS ------------------ commit: None python: 3.6.5.final.0 python-b...
[ { "body": "Some numeric issues are related to the specific blas that numpy is using. I'm wondering if it makes sense to add the relevant ``system_info`` invocations to the template to make it easier for people to report.", "number": 11522, "title": "Add sklearn.show_versions() similar to pandas.show_ver...
51407623e4f491f00e3b465626dd5c4b55860bd0
{ "head_commit": "19605c30f8957bc77be87125864d2b6181ea7b12", "head_commit_message": "added to the function list in classes.rst", "patch_to_review": "diff --git a/doc/developers/contributing.rst b/doc/developers/contributing.rst\nindex 1b43400f4a7a0..4b218e542c115 100644\n--- a/doc/developers/contributing.rst\n+++...
[ { "diff_hunk": "@@ -0,0 +1,117 @@\n+\"\"\"\n+Utility methods to print system info for debugging\n+\n+adapted from :func:`pandas.show_versions`\n+\"\"\"\n+# License: BSD 3 clause\n+\n+import platform\n+import sys\n+import importlib\n+\n+\n+def _get_sys_info():\n+ \"\"\"System information\n+\n+ Return\n+ ...
5f0fb51fbc3218a7d97436eba1f84cc21828c1fa
diff --git a/doc/developers/contributing.rst b/doc/developers/contributing.rst index 1b43400f4a7a0..dd17515aaf23d 100644 --- a/doc/developers/contributing.rst +++ b/doc/developers/contributing.rst @@ -140,6 +140,14 @@ feedback: your **Python, scikit-learn, numpy, and scipy versions**. This information can be foun...
{ "difficulty": "low", "estimated_review_effort": 3, "problem_domain": "New Feature Additions" }
ray-project__ray-49918@04cf1ee
ray-project/ray
Python
49,918
[Fix][Core] Execute user requested actor exit in C++ side
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-01-17T14:08:29Z
[Core] ray.actor.exit_actor() does not seem to work from within an async background thread ### What happened + What you expected to happen In actor initialization, I want to spawn an async background routine that has the ability to call `ray.actor.exit_actor()`; however, that API doesn't seem to actually work - ``` ...
@shomilj Is this bug only occurring occasionally, or can it always be reproduced using your reproduction script? I tried your script but couldn't reproduce it. Update: I can reproduce it now. @MortalHappiness I think we can fix this by unifying the asyncio exit path with the `check_signals` codepath: https://github....
[ { "body": "### What happened + What you expected to happen\n\nIn actor initialization, I want to spawn an async background routine that has the ability to call `ray.actor.exit_actor()`; however, that API doesn't seem to actually work - \r\n```\r\n>>> AsyncActor.remote()\r\n2024-12-26 14:20:31,392 INFO worker.py...
ff59b415bc0b76a16481767d3bf6a88238be8d25
{ "head_commit": "04cf1ee2c57e821accc3be5604f95e9ef218ed1d", "head_commit_message": "Change wrong test function name\n\nCloses: ray-project/ray#49451\nSigned-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>", "patch_to_review": "diff --git a/python/ray/_raylet.pyx b/python/ray/_raylet.pyx\nindex a5294c8290e4.....
[ { "diff_hunk": "@@ -394,6 +395,17 @@ bool WorkerContext::CurrentActorIsAsync() const {\n return current_actor_is_asyncio_;\n }\n \n+void WorkerContext::SetCurrentActorShouldExit() {\n+ absl::WriterMutexLock lock(&mutex_);\n+ RAY_CHECK(!current_actor_id_.IsNil());", "line": null, "original_line": 400...
e5969297dd876ad3294b42a166cf9f5a891d783e
diff --git a/python/ray/_raylet.pyx b/python/ray/_raylet.pyx index a5294c8290e4..b7bb98276191 100644 --- a/python/ray/_raylet.pyx +++ b/python/ray/_raylet.pyx @@ -1886,6 +1886,7 @@ cdef void execute_task( # Execute the task. with core_worker.profile_event(b"task:execute"): tas...
{ "difficulty": "medium", "estimated_review_effort": 4, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-11542@76c8092
scikit-learn/scikit-learn
Python
11,542
[MRG] EHN: Change default n_estimators to 100 for random forest
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fi...
2018-07-15T22:29:04Z
Change default n_estimators in RandomForest (to 100?) Analysis of code on github shows that people use default parameters when they shouldn't. We can make that a little bit less bad by providing reasonable defaults. The default for n_estimators is not great imho and I think we should change it. I suggest 100. We could...
I would like to give it a shot. Is the default value 100 final? @ArihantJain456 I didn't tag this one as "help wanted" because I wanted to wait for other core devs to chime in before we do anything. I agree. Bad defaults should be deprecated. The warning doesn't hurt.​ I'm also +1 for n_estimators=100 by default Both...
[ { "body": "Analysis of code on github shows that people use default parameters when they shouldn't. We can make that a little bit less bad by providing reasonable defaults. The default for n_estimators is not great imho and I think we should change it. I suggest 100.\r\nWe could probably run benchmarks with ope...
cd7d9d985e1bbe2dbbbae17da0e9fbbba7e8c8c6
{ "head_commit": "76c80928261b057f353f392559d1941b38d6e70e", "head_commit_message": "Removed blank line", "patch_to_review": "diff --git a/sklearn/ensemble/forest.py b/sklearn/ensemble/forest.py\nindex b7a349d4b5a89..92552cef6b563 100644\n--- a/sklearn/ensemble/forest.py\n+++ b/sklearn/ensemble/forest.py\n@@ -135...
[ { "diff_hunk": "@@ -758,6 +763,10 @@ class RandomForestClassifier(ForestClassifier):\n n_estimators : integer, optional (default=10)\n The number of trees in the forest.\n \n+ .. deprecated:: 0.20", "line": null, "original_line": 766, "original_start_line": null, "path": "skle...
bb1d78628a8723c75f9043dde504ea5ddd382e9a
diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst index 0df0635d57c75..5743b099fd5e1 100644 --- a/doc/whats_new/v0.20.rst +++ b/doc/whats_new/v0.20.rst @@ -17,7 +17,6 @@ Highlights We have tried to improve our support for common data-science use-cases including missing values, categorical variables, hete...
{ "difficulty": "medium", "estimated_review_effort": 2, "problem_domain": "New Feature Additions" }
scikit-learn__scikit-learn-11557@bdc063f
scikit-learn/scikit-learn
Python
11,557
[MRG+1] Change CV defaults to 5
#### Reference Issues/PRs Fixes #11129 and takes over stalled PR #11139 #### What does this implement/fix? Explain your changes. Add warning for models that do not specify an explicit value for`cv` or `n_splits` to prepare for a future deprecation of the default to 3 and an update of the default value to 5.
2018-07-16T15:02:18Z
Change cv default to 5 I think it's commonly accepted that kfold cross-validation should be done with k=5 or k=10. We do 3 fold by default. Actually in a recent talk Max Kuhn said "never do threefold" and I think he was not even aware that this could have been a jibe. Again, not sure if we should tag this 1.0 and ma...
It would be a good thing. What do you propose in terms of deprecation path, to avoid surprising users? Standard deprecation warning, two versions. I don't like deprecation warnings but if they get a warning they've been doing it wrong. (I didn't tag as "help wanted" before there is consensus) Yes, let's deprecate, wi...
[ { "body": "I think it's commonly accepted that kfold cross-validation should be done with k=5 or k=10. We do 3 fold by default. Actually in a recent talk Max Kuhn said \"never do threefold\" and I think he was not even aware that this could have been a jibe.\r\n\r\nAgain, not sure if we should tag this 1.0 and ...
51407623e4f491f00e3b465626dd5c4b55860bd0
{ "head_commit": "bdc063f6055e87a4b62a4326c47a5f51e0c7e1f7", "head_commit_message": "fix doctests", "patch_to_review": "diff --git a/doc/glossary.rst b/doc/glossary.rst\nindex 6a3780ba0c054..533a8eac63d04 100644\n--- a/doc/glossary.rst\n+++ b/doc/glossary.rst\n@@ -1414,7 +1414,8 @@ functions or non-estimator cons...
[ { "diff_hunk": "@@ -214,9 +216,9 @@ estimator during the construction and exposes an estimator API::\n >>> from sklearn.model_selection import GridSearchCV, cross_val_score\n >>> Cs = np.logspace(-6, -1, 10)\n >>> clf = GridSearchCV(estimator=svc, param_grid=dict(C=Cs),\n- ... ...
3d055f28ec59a0b3496270fb541be59bd2f8d630
diff --git a/doc/glossary.rst b/doc/glossary.rst index 6a3780ba0c054..533a8eac63d04 100644 --- a/doc/glossary.rst +++ b/doc/glossary.rst @@ -1414,7 +1414,8 @@ functions or non-estimator constructors. - An iterable yielding train/test splits. With some exceptions (especially where not using cross val...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Code Refactoring / Architectural Improvement" }
scikit-learn__scikit-learn-11646@ea1fbc1
scikit-learn/scikit-learn
Python
11,646
[MRG] Add elastic net penalty to LogisticRegression
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fi...
2018-07-20T23:28:32Z
linear classifier with elasticnet penalty I think it's weird that we don't have a linear classifier with an elasticnet penalty (apart from SGDClassifier which is kinda hard to use). Maybe we should add that to the lbfgs solver in logistic regression? glmnet does that afaik. I'm not sure if I opened this issue befor...
Are you suggesting doing the trick of splitting the weights into a positive and negative part and using the bounding box constraints? Otherwise l-bfgs is not an usual choice for sparse penalties. On a related note, there are 4 orthogonal attributes of a classifier that are very difficult to find supported together: ...
[ { "body": "I think it's weird that we don't have a linear classifier with an elasticnet penalty (apart from SGDClassifier which is kinda hard to use). Maybe we should add that to the lbfgs solver in logistic regression?\r\nglmnet does that afaik.\r\n\r\nI'm not sure if I opened this issue before... I got a slig...
a816af7d1d89a9a62f523b81be24d5058928ddd8
{ "head_commit": "ea1fbc1fb3c0362a86a51ccaf3875df3d7ed2d54", "head_commit_message": "Fixed test", "patch_to_review": "diff --git a/doc/modules/linear_model.rst b/doc/modules/linear_model.rst\nindex ab6b2994835f9..c8ff40a6ee1ae 100644\n--- a/doc/modules/linear_model.rst\n+++ b/doc/modules/linear_model.rst\n@@ -730...
[ { "diff_hunk": "@@ -1379,6 +1392,220 @@ def test_warm_start_converge_LR():\n assert_allclose(lr_no_ws_loss, lr_ws_loss, rtol=1e-5)\n \n \n+def test_elastic_net_coeffs():\n+ # make sure elastic-net penalty gives different coefficients from l1 and l2\n+ # with saga solver (l1_ratio different from 0 or 1...
59094d6fb860015f02cfa0097e18c7860de37dfe
diff --git a/doc/modules/linear_model.rst b/doc/modules/linear_model.rst index 63f9adb153bbd..8f2bffed1478c 100644 --- a/doc/modules/linear_model.rst +++ b/doc/modules/linear_model.rst @@ -338,7 +338,7 @@ the algorithm to fit the coefficients. .. _elastic_net: -Elastic Net +Elastic-Net =========== :class:`Elasti...
{ "difficulty": "high", "estimated_review_effort": 4, "problem_domain": "New Feature Additions" }
scikit-learn__scikit-learn-11535@7daf8d5
scikit-learn/scikit-learn
Python
11,535
Logistic lgbf verbosity
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs Fixes #11519 <!-- Example: Fixes #1234. See also #3456. Please use...
2018-07-15T20:56:54Z
LogisticRegression verbosity broken for l-bfgs (and newton-cg?) Setting verbose=100 in LogisticRegression results in nothing being printed. There is some conversion between verbose and iprint, and somewhere things in there are going wrong. FYI this prints to stdout, so if you're using Jupyter, look at your console,...
I'm happy to work on this. The issue is `iprint=(verbose > 0) - 1`, which causes the only option to be iprint of -1 or 0. What is the desired behavior? Setting it `iprint=verbose -1` makes sense, but then setting verbose=100 would mean printing every 99th iteration. Is that what is wanted? higher verbose should me...
[ { "body": "Setting verbose=100 in LogisticRegression results in nothing being printed.\r\nThere is some conversion between verbose and iprint, and somewhere things in there are going wrong.\r\n\r\nFYI this prints to stdout, so if you're using Jupyter, look at your console, not the Jupyter output.", "number"...
7ec71e7446164f604b81ded39f31ce2b98f54257
{ "head_commit": "7daf8d55ea4891d6e22e775a165bb76518fc6aef", "head_commit_message": "Removed accidental test file", "patch_to_review": "diff --git a/sklearn/linear_model/logistic.py b/sklearn/linear_model/logistic.py\nindex e4ea696ce7146..a2c8fddb0a653 100644\n--- a/sklearn/linear_model/logistic.py\n+++ b/sklearn...
[ { "diff_hunk": "@@ -711,10 +711,20 @@ def logistic_regression_path(X, y, pos_class=None, Cs=10, fit_intercept=True,\n n_iter = np.zeros(len(Cs), dtype=np.int32)\n for i, C in enumerate(Cs):\n if solver == 'lbfgs':\n+ if 0 < verbose <= 1:\n+ iprint = 50\n+ el...
d09baadcb0f6ccf6aa7a03c95f293780aa07b575
diff --git a/sklearn/linear_model/logistic.py b/sklearn/linear_model/logistic.py index e4ea696ce7146..95f66f1725992 100644 --- a/sklearn/linear_model/logistic.py +++ b/sklearn/linear_model/logistic.py @@ -684,7 +684,6 @@ def logistic_regression_path(X, y, pos_class=None, Cs=10, fit_intercept=True, else: ...
{ "difficulty": "low", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
searxng__searxng-54@cce029b
searxng/searxng
Python
54
[mod] option to enable or disable "proxy" button next to each result
## What does this PR do? Add option to enable or disable "proxy" button next to each result. ## Why is this change important? The ability to disable the "proxy" button next to each result. ## Related issues Closes: https://github.com/searxng/searxng/issues/51
2021-05-03T16:03:31Z
Add ability to remove "proxy" button <!-- PLEASE FILL THESE FIELDS, IT REALLY HELPS THE MAINTAINERS OF SEARX --> **Is your feature request related to a problem? Please describe.** I don't want people to use the proxy ability to browse on the web using my IPs, but I still want to proxy the resources like the images....
[ { "body": "<!-- PLEASE FILL THESE FIELDS, IT REALLY HELPS THE MAINTAINERS OF SEARX -->\r\n\r\n**Is your feature request related to a problem? Please describe.**\r\nI don't want people to use the proxy ability to browse on the web using my IPs, but I still want to proxy the resources like the images.\r\n\r\n**De...
b646050f6e47eed52a2b1564427ae199a0c92341
{ "head_commit": "cce029b6afff9365a98fac3485d9ec7428445d08", "head_commit_message": "[mod] option to enable or disable \"proxy\" button next to each result\n\nCloses: https://github.com/searxng/searxng/issues/51\nSigned-off-by: Markus Heiser <markus.heiser@darmarit.de>", "patch_to_review": "diff --git a/searx/set...
[ { "diff_hunk": "@@ -65,6 +65,7 @@ ui:\n #result_proxy:\n # url : http://127.0.0.1:3000/\n # key : !!binary \"your_morty_proxy_key\"\n+# button : True # [True|False] enable the \"proxy\" button next to each result", "line": null, "original_line": 68, "original_start_line": null, "path":...
cf9518b1a0bef31b0184e25d3b8b115e70031ce9
diff --git a/searx/settings.yml b/searx/settings.yml index 13504867361..435a638e8e0 100644 --- a/searx/settings.yml +++ b/searx/settings.yml @@ -65,6 +65,7 @@ ui: #result_proxy: # url : http://127.0.0.1:3000/ # key : !!binary "your_morty_proxy_key" +# proxify_results : True # [True|False] enable the "proxy...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "New Feature Additions" }
ray-project__ray-49711@d776f6d
ray-project/ray
Python
49,711
[core][compiled-graphs] Read input channels in a round-robin manner with a short timeout, and fail fast if a RayTaskError is found
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-01-08T08:19:27Z
[core][experimental] ray.get of accelerated DAG result may not throw exception for MultiOutputNode ### What happened + What you expected to happen When calling `ray.get()` on the outputs of an accelerated DAG with a MultiOutputNode, we currently block on the results one at a time. This means that if one of the actor t...
Marking as p0 because it's important for vLLM use case. But it's okay to release developer preview without it. @ruisearch42 are you tracking this? Thanks @anyscalesam . Yes I will work on this. I have a reproduction script here: https://gist.github.com/kevin85421/a7f14ea38d64420b105fbd79fd31fb8a ```python with Inp...
[ { "body": "### What happened + What you expected to happen\n\nWhen calling `ray.get()` on the outputs of an accelerated DAG with a MultiOutputNode, we currently block on the results one at a time. This means that if one of the actor tasks threw an exception, we do not throw it until after we get the results for...
ec330bd0277faa633878542a01138762c9bd7ad2
{ "head_commit": "d776f6dbc6c380a0a81abb37340e07adcb4a871e", "head_commit_message": "address comments\n\nSigned-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>", "patch_to_review": "diff --git a/python/ray/dag/context.py b/python/ray/dag/context.py\nindex 25fbd8bd173b0..1b8f23f5dfa65 100644\n--- a/python/ray/dag/con...
[ { "diff_hunk": "@@ -333,13 +355,63 @@ def start(self):\n pass\n \n def _read_list(self, timeout: Optional[float] = None) -> List[Any]:\n- results = []\n- for c in self._input_channels:\n- start_time = time.monotonic()\n- results.append(c.read(timeout))\n- ...
efeb583d5160876dd41a3ca4b7b3018ad65af762
diff --git a/python/ray/dag/context.py b/python/ray/dag/context.py index 25fbd8bd173b..1b8f23f5dfa6 100644 --- a/python/ray/dag/context.py +++ b/python/ray/dag/context.py @@ -11,6 +11,9 @@ DEFAULT_SUBMIT_TIMEOUT_S = int(os.environ.get("RAY_CGRAPH_submit_timeout", 10)) DEFAULT_GET_TIMEOUT_S = int(os.environ.get("RAY_C...
{ "difficulty": "medium", "estimated_review_effort": 4, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-11496@5a66c06
scikit-learn/scikit-learn
Python
11,496
[MRG+2] Fix sparse simple imputer
Fixes #11495 Changed the fit in `SimpleImputer` to properly handle sparse input with explicit zeros. I made it a little more clean also (I guess) Since the SimpleImputer hasn't been released yet, do I still have do add an entry in the what's new for this bug fix ?
2018-07-12T17:05:58Z
BUG: SimpleImputer gives wrong result on sparse matrix with explicit zeros The current implementation of the `SimpleImputer` can't deal with zeros stored explicitly in sparse matrix. Even when stored explicitly, we'd expect that all zeros are treating equally, right ? See for example the code below: ```python impor...
[ { "body": "The current implementation of the `SimpleImputer` can't deal with zeros stored explicitly in sparse matrix.\r\nEven when stored explicitly, we'd expect that all zeros are treating equally, right ?\r\nSee for example the code below:\r\n```python\r\nimport numpy as np\r\nfrom scipy import sparse\r\nfro...
cb0140017740d985960911c4f34820beea915846
{ "head_commit": "5a66c06c00c09f8ba14d737a05033b13d28f0253", "head_commit_message": "add regression test", "patch_to_review": "diff --git a/sklearn/impute.py b/sklearn/impute.py\nindex 836bfb0167add..bc76c7f53af7e 100644\n--- a/sklearn/impute.py\n+++ b/sklearn/impute.py\n@@ -241,80 +241,51 @@ def fit(self, X, y=N...
[ { "diff_hunk": "@@ -705,3 +705,22 @@ def test_chained_imputer_additive_matrix():\n random_state=rng).fit(X_train)\n X_test_est = imputer.transform(X_test)\n assert_allclose(X_test_filled, X_test_est, atol=0.01)\n+\n+\n+def regression_test_sparse_zeros():\n+ # regression t...
4025fdafda8de70f100ccf22ddb9837a9a8e7f72
diff --git a/doc/modules/impute.rst b/doc/modules/impute.rst index 0f9089c981782..2d92a604382ad 100644 --- a/doc/modules/impute.rst +++ b/doc/modules/impute.rst @@ -56,19 +56,19 @@ that contain the missing values:: The :class:`SimpleImputer` class also supports sparse matrices:: >>> import scipy.sparse as sp - ...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-11473@1f5bbb3
scikit-learn/scikit-learn
Python
11,473
[MRG] Make imputers picklable
#### Reference Issues/PRs Fixes #11462 #### What does this implement/fix? Explain your changes. Changes the problematic line (identified in the issue) to properly identify `np.nan`s after pickling. Test added to `util.estimator_checks` to check that all estimators that allow `np.nan`s properly pickle mode...
2018-07-10T17:32:05Z
np.nan is not np.nan after serialization causing SimpleImputer to fail transforming properly #### Description When I load fitted ChaninedImputer instance from `joblib` or `pickle`, it drops columns with nans instead of imputing them when I call `.fit_transform` or `.transform`. #### To reproduce: ```python In [...
interesting.... ping @sergeyf I can reproduce and the issue is related to `SimpleImputer` actually. It comes from the following [line](https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/impute.py#L45) `np.nan` should be cached but the pickling/unpickling should create a new instance which make the `i...
[ { "body": "#### Description\r\nWhen I load fitted ChaninedImputer instance from `joblib` or `pickle`, it drops columns with nans instead of imputing them when I call `.fit_transform` or `.transform`. \r\n\r\n#### To reproduce:\r\n```python\r\nIn [1]: import joblib\r\nIn [2]: import numpy as np\r\nIn [3]: from ...
3e19d7f6d78f3e28f2dd1fef08ad7d410e5ecd72
{ "head_commit": "1f5bbb3584e48a936d5d9adb07be6b1238a34553", "head_commit_message": "add test to check that estimators that allow nans properly pickle and unpickle when fitted with input data with nans", "patch_to_review": "diff --git a/sklearn/impute.py b/sklearn/impute.py\nindex 836bfb0167add..2f093dd24fae9 100...
[ { "diff_hunk": "@@ -1190,6 +1190,30 @@ def check_estimators_pickle(name, estimator_orig):\n unpickled_result = getattr(unpickled_estimator, method)(X)\n assert_allclose_dense_sparse(result[method], unpickled_result)\n \n+ # check if input with nans pickles properly\n+ if name in ALLOW_NAN:...
e238fa886777b6e6b47b825c68f654d664626325
diff --git a/sklearn/impute.py b/sklearn/impute.py index 836bfb0167add..8462d9944ccf2 100644 --- a/sklearn/impute.py +++ b/sklearn/impute.py @@ -42,7 +42,7 @@ def _get_mask(X, value_to_mask): """Compute the boolean mask X == missing_values.""" - if value_to_mask is np.nan: + if is_scalar_nan(value_to_mask...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-11464@aa073d5
scikit-learn/scikit-learn
Python
11,464
[MRG+2] Tree MAE fix to ensure sample_weights are used during impurity calculation
Tree MAE is not considering sample_weights when calculating impurity! In the proposed fix, you will see I have multiplied by the sample weight after applying the absolute to the difference (not before). This is in line with the consensus / discussion found here, where negative sample weights are considered: #3774 (a...
2018-07-10T04:29:52Z
Tree MAE is not considering sample_weights when calculating impurity! This is clearly visible by looking at the code in _criterion.pyx -> class MAE -> children_impurity and node_impurity. I will shortly provide a pull request link with a fix for the above... I have created this issue so that impacts of negative samp...
In the proposed fix, you will see I have multiplied by the sample weight *after* applying the absolute to the difference (not before). This is in line with the consensus / discussion found here, where negative sample weights are considered: https://github.com/scikit-learn/scikit-learn/issues/3774 (and also because dur...
[ { "body": "This is clearly visible by looking at the code in _criterion.pyx -> class MAE -> children_impurity and node_impurity.\r\n\r\nI will shortly provide a pull request link with a fix for the above... I have created this issue so that impacts of negative sample weights can be discussed (if necessary)?", ...
19bc7e8af6ec3468b6c7f4718a31cd5f508528cd
{ "head_commit": "aa073d51e60771451c1a16fe50864882b60f3978", "head_commit_message": "Removed unnecessary explicits", "patch_to_review": "diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst\nindex 27c9641dec3de..0f248c810e4fd 100644\n--- a/doc/whats_new/v0.20.rst\n+++ b/doc/whats_new/v0.20.rst\n@@ -513,...
[ { "diff_hunk": "@@ -513,6 +513,12 @@ Classifiers and regressors\n per-tree basis. The previous behavior over-weighted the Gini importance of\n features that appear in later stages. This issue only affected feature\n importances. :issue:`11176` by :user:`Gil Forsyth <gforsyth>`.\n+ \n+- Fixed a bug in :cl...
ef6fe3b7be257c3d40be9749276cfaa4e561ad22
diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst index 27c9641dec3de..e6c2ca1408f10 100644 --- a/doc/whats_new/v0.20.rst +++ b/doc/whats_new/v0.20.rst @@ -513,6 +513,12 @@ Classifiers and regressors per-tree basis. The previous behavior over-weighted the Gini importance of features that appear in la...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-11458@b11265a
scikit-learn/scikit-learn
Python
11,458
[MRG] Fixes tree and forest classification for non-numeric multi-target
Fixes #11451. This fixes the issue that trees and forests cannot classify (but they can fit) non-numeric targets, when there are multiple targets.
2018-07-08T05:32:15Z
An error is thrown when using Random forest classifier multi-target non-numeric classes #### Description Random forest classifier can be fit on multiple target columns where columns have string labels and are not numeric, but when trying to predict, an error is thrown. #### Steps/Code to Reproduce ```python i...
It seems the following code fixes the problem: ```python if self.n_outputs_ == 1: return self.classes_.take(np.argmax(proba, axis=1), axis=0) else: n_samples = proba[0].shape[0] predictions = [] for k in range(self.n_outputs_): ...
[ { "body": "#### Description\r\n\r\nRandom forest classifier can be fit on multiple target columns where columns have string labels and are not numeric, but when trying to predict, an error is thrown.\r\n\r\n#### Steps/Code to Reproduce\r\n\r\n```python\r\nimport numpy as np\r\nfrom sklearn.datasets import make_...
b8d1226d69bc4930d73c83394d2fee22dfe7ce2c
{ "head_commit": "b11265a9a1a4d00f8200db766beb1b1e0ef65cbb", "head_commit_message": "Adding ignore warning to test_forest.py.", "patch_to_review": "diff --git a/sklearn/ensemble/tests/test_forest.py b/sklearn/ensemble/tests/test_forest.py\nindex e4eb282923a29..ef809cc3eadb4 100644\n--- a/sklearn/ensemble/tests/te...
[ { "diff_hunk": "@@ -1337,3 +1337,23 @@ def test_backend_respected():\n clf.predict_proba(X)\n \n assert ba.count == 0\n+\n+\n+@pytest.mark.filterwarnings('ignore:The default value of n_estimators')\n+@pytest.mark.parametrize('name', FOREST_CLASSIFIERS)\n+@pytest.mark.parametrize('oob_score', (True, ...
79f768a7277044b19b09bd51591d0ec96e007fd9
diff --git a/sklearn/ensemble/tests/test_forest.py b/sklearn/ensemble/tests/test_forest.py index e4eb282923a29..aa02f46db68f3 100644 --- a/sklearn/ensemble/tests/test_forest.py +++ b/sklearn/ensemble/tests/test_forest.py @@ -1337,3 +1337,25 @@ def test_backend_respected(): clf.predict_proba(X) assert ba...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-11391@34fb9a3
scikit-learn/scikit-learn
Python
11,391
[MRG] FIX: raise error with inconsistent dtype X and missing_values
closes #11390 Implement an additional check to avoid raising `NotImplemented` from `np.equal` when the dtype of `X` and `missing_values` are inconsistent for a comparison.
2018-06-29T13:52:07Z
Cryptic error in imputers due to missing checking in _get_mask By working on the `MissingIndicator` it seems that there is a missing checking between `X` and `missing_values` dtype: ```python import numpy as np X = np.array([[1.6464405 , 2.145568 , 1.80829 , 1.6346495 , 1.2709644 ], [1.3127615 , ...
[ { "body": "By working on the `MissingIndicator` it seems that there is a missing checking between `X` and `missing_values` dtype:\r\n\r\n```python\r\nimport numpy as np\r\nX = np.array([[1.6464405 , 2.145568 , 1.80829 , 1.6346495 , 1.2709644 ],\r\n [1.3127615 , 2.675319 , 2.8906 , 2.1489816 , 0...
526aede6a762ac6646211057d00a13304fb115b6
{ "head_commit": "34fb9a3de5495dd56068605ed28f72e5fdf1aaea", "head_commit_message": "address jeremy comments", "patch_to_review": "diff --git a/sklearn/impute.py b/sklearn/impute.py\nindex 836bfb0167add..999689805b65d 100644\n--- a/sklearn/impute.py\n+++ b/sklearn/impute.py\n@@ -40,6 +40,17 @@\n ]\n \n \n+def _ch...
[ { "diff_hunk": "@@ -705,3 +705,23 @@ def test_chained_imputer_additive_matrix():\n random_state=rng).fit(X_train)\n X_test_est = imputer.transform(X_test)\n assert_allclose(X_test_filled, X_test_est, atol=0.01)\n+\n+\n+@pytest.mark.parametrize(\"imputer_constructor\",\n+ ...
d266909eb2da180630d2adaa16ef9caeffd803f2
diff --git a/sklearn/impute.py b/sklearn/impute.py index 836bfb0167add..3879e923d3313 100644 --- a/sklearn/impute.py +++ b/sklearn/impute.py @@ -40,6 +40,15 @@ ] +def _check_inputs_dtype(X, missing_values): + if (X.dtype.kind in ("f", "i", "u") and + not isinstance(missing_values, numbers.Real)): + ...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
ray-project__ray-49565@5c19746
ray-project/ray
Python
49,565
[core][cgraph] Collapse other params into max_inflight_executions and adjust execution_index counting
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P...
2025-01-03T20:11:53Z
[core][compiled graphs] Cleanup for DAG context parameters ### Description There are some confusing names for various DAG context parameters: - execution_timeout - actually refers to submission timeout - several different parameters related to number of buffered results We should clean these up before beta releas...
The timeout API part is related to this issue: https://github.com/ray-project/ray/issues/46935#issue-2445418552 @dayshah should be able help with some of the tasks.
[ { "body": "### Description\n\nThere are some confusing names for various DAG context parameters:\r\n- execution_timeout - actually refers to submission timeout\r\n- several different parameters related to number of buffered results\r\n\r\nWe should clean these up before beta release.\n\n### Use case\n\n_No resp...
4986146234e2f4506a95e8b9782eaf1b9c68f5c0
{ "head_commit": "5c1974676a053540bd56c743604d73fc4aee7f19", "head_commit_message": "address comments\n\nSigned-off-by: dayshah <dhyey2019@gmail.com>", "patch_to_review": "diff --git a/python/ray/dag/compiled_dag_node.py b/python/ray/dag/compiled_dag_node.py\nindex 94124761c6ac..c2db509b93f9 100644\n--- a/python/...
[ { "diff_hunk": "@@ -1933,14 +1905,13 @@ def run(self):\n def raise_if_too_many_inflight_requests(self):\n num_in_flight_requests = (\n self._execution_index - self._max_finished_execution_index\n- )\n- if num_in_flight_requests > self._max_inflight_executions:\n+ ) +...
a08cafd90b64f3c96ad4a87271d73a2483bb134a
diff --git a/python/ray/dag/compiled_dag_node.py b/python/ray/dag/compiled_dag_node.py index 4d1f884c7cc4..48a2d12c9f57 100644 --- a/python/ray/dag/compiled_dag_node.py +++ b/python/ray/dag/compiled_dag_node.py @@ -740,8 +740,6 @@ def __init__( submit_timeout: Optional[float] = None, buffer_size_bytes...
{ "difficulty": "medium", "estimated_review_effort": 4, "problem_domain": "Code Refactoring / Architectural Improvement" }
scikit-learn__scikit-learn-11281@afcbcaa
scikit-learn/scikit-learn
Python
11,281
[MRG + 1] #10336 adding fit_predict to mixture models
#### Reference Issues Fixes #10336 #### What does this implement/fix? Explain your changes. Added `fit_predict` method to all Gaussian mixture models and added tests to Bayesian Gaussian Mixture and Gaussian Mixture. #### Any other comments? `fit` is changed to call `fit-predict`, which really does the ...
2018-06-15T17:15:25Z
Should mixture models have a clusterer-compatible interface Mixture models are currently a bit different. They are basically clusterers, except they are probabilistic, and are applied to inductive problems unlike many clusterers. But they are unlike clusterers in API: * they have an `n_components` parameter, with iden...
In my opinion, yes. I wanted to compare K-Means, GMM and HDBSCAN and was very disappointed that GMM does not have a `fit_predict` method. The HDBSCAN examples use `fit_predict`, so I was expecting GMM to have the same interface. I think we should add ``fit_predict`` at least. I wouldn't rename ``n_components``. I wo...
[ { "body": "Mixture models are currently a bit different. They are basically clusterers, except they are probabilistic, and are applied to inductive problems unlike many clusterers. But they are unlike clusterers in API:\r\n* they have an `n_components` parameter, with identical purpose to `n_clusters`\r\n* they...
4143356c3c51831300789e4fdf795d83716dbab6
{ "head_commit": "afcbcaad824d4d2bdc4882921d6a3d518b47a9a3", "head_commit_message": "fixed flake8 issues", "patch_to_review": "diff --git a/sklearn/mixture/base.py b/sklearn/mixture/base.py\nindex a9f66740f2b88..2fd9f873b9d33 100644\n--- a/sklearn/mixture/base.py\n+++ b/sklearn/mixture/base.py\n@@ -172,7 +172,7 @...
[ { "diff_hunk": "@@ -419,3 +423,48 @@ def test_invariant_translation():\n assert_almost_equal(bgmm1.means_, bgmm2.means_ - 100)\n assert_almost_equal(bgmm1.weights_, bgmm2.weights_)\n assert_almost_equal(bgmm1.covariances_, bgmm2.covariances_)\n+\n+\n+def test_bayesian_mixture...
e73b965dbd036057663d8b93f200196a4aa276bf
diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst index 87569d8649d86..14a694b1f3e82 100644 --- a/doc/whats_new/v0.20.rst +++ b/doc/whats_new/v0.20.rst @@ -581,6 +581,11 @@ Decomposition, manifold learning and clustering pairwise distances or squared distances. :issue:`9775` by :user:`William de Vaze...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "New Feature Additions" }
scikit-learn__scikit-learn-11276@c6b7908
scikit-learn/scikit-learn
Python
11,276
FIX #11215 : Changing return in docstring to yields for generator functions
#### Reference Issues/PRs Fixes #11215. #### What does this implement/fix? Explain your changes. I changed all the docstrings for generator functions to say `Yields` instead `Returns`. #### Any other comments? First OSS contribution :) 🥇
2018-06-15T15:13:33Z
GroupShuffelSplit `return` doc is incorrect #### Description In the documentation, the `return` part of the split method on `sklearn.model_selection.GroupShuffleSplit` is incorrect Doc says the split method returns: ``` train : ndarray The training set indices for that split. test : ndarray The te...
This is a problem throughout the module. We now use a version of numpydoc that supports a Yields section. A PR is welcome (and would have been welcome without first opening an issue). Thanks! Great, thanks @jnothman , I'll submit a PR
[ { "body": "#### Description\r\nIn the documentation, the `return` part of the split method on `sklearn.model_selection.GroupShuffleSplit` is incorrect\r\n\r\nDoc says the split method returns:\r\n```\r\ntrain : ndarray\r\n The training set indices for that split.\r\n\r\ntest : ndarray\r\n The testing s...
4143356c3c51831300789e4fdf795d83716dbab6
{ "head_commit": "c6b7908914c917b337010c6e133b12a4b7fd1bce", "head_commit_message": "Changing return in docstring to yields for generator functions", "patch_to_review": "diff --git a/sklearn/model_selection/_split.py b/sklearn/model_selection/_split.py\nindex 866cb4cc53aa8..583be341b80f8 100644\n--- a/sklearn/mod...
[ { "diff_hunk": "@@ -76,7 +76,7 @@ def split(self, X, y=None, groups=None):\n Group labels for the samples used while splitting the dataset into\n train/test set.\n \n- Returns\n+ Yields\n -------", "line": null, "original_line": 80, "original_start_line"...
054b46e8bf03d98e96c4d73e8770b8ac4e75b678
diff --git a/sklearn/model_selection/_split.py b/sklearn/model_selection/_split.py index 866cb4cc53aa8..399f8df3a0ee2 100644 --- a/sklearn/model_selection/_split.py +++ b/sklearn/model_selection/_split.py @@ -76,8 +76,8 @@ def split(self, X, y=None, groups=None): Group labels for the samples used while spl...
{ "difficulty": "low", "estimated_review_effort": 1, "problem_domain": "Documentation Updates" }
spyder-ide__spyder-21235@0872cc3
spyder-ide/spyder
Python
21,235
PR: Display plots from collections editor in the Plots pane
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2023-08-09T09:38:09Z
Plots from collection editor don't appear in Plots pane ## Problem Description Plots from the namespace editor open in the Plots pane, but plots from the collection editor don't. ### What steps reproduce the problem? 1. Run the code `var = [1,2,3,4]` in the Console 2. In the variable editor, right click on t...
Here is a proof of concept: ![collection-plot](https://github.com/spyder-ide/spyder/assets/7941918/e4516be6-1fba-49c7-8ffa-5bca2b8de4cd) One problem is that the user does not get any feedback after clicking on "Plot". They have to go to the Plots pane to find the result. Compare this with when you plot from the V...
[ { "body": "## Problem Description\r\n\r\nPlots from the namespace editor open in the Plots pane, but plots from the collection editor don't.\r\n\r\n### What steps reproduce the problem?\r\n\r\n1. Run the code `var = [1,2,3,4]` in the Console \r\n2. In the variable editor, right click on the variable `var` and c...
b8b129662ff8a13876924ed009f20f52c59ff76b
{ "head_commit": "0872cc307b98267b0daad6e761ed5b0a33e03f4a", "head_commit_message": "Set plots_plugin_enabled in namespace browser from plugin\n\nCalling a function from the Variable Explorer plugin in the namespace browser\nto determine whether the Plots plugin is enabled, causes tight coupling.\nInstead, this com...
[ { "diff_hunk": "@@ -534,6 +534,10 @@ def get_current_shellwidget(self):\n \"\"\"Return the shellwidget of the current client\"\"\"\n return self.get_widget().get_current_shellwidget()\n \n+ def set_current_shellwidget(self, shellwidget):\n+ \"\"\"Activate client associated to given she...
c4ca141fbb1a7104afce2630167e422d03ea51e8
diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py index c3bc44e982f..b42a65a9ff2 100644 --- a/spyder/app/tests/test_mainwindow.py +++ b/spyder/app/tests/test_mainwindow.py @@ -2388,6 +2388,50 @@ def test_tight_layout_option_for_inline_plot(main_window, qtbot, tmpdir): assert co...
{ "difficulty": "medium", "estimated_review_effort": 4, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-11264@cd69c1a
scikit-learn/scikit-learn
Python
11,264
[MRG] Add sparse efficiency warning to randomized_svd (fixes randomized_svd is slow for dok_matrix and lil_matrix #11262)
#### Reference Issues/PRs Fixes #11262 #### What does this implement/fix? Explain your changes. Adds a `scipy.sparse.SparseEfficiencyWarning` when `randomized_svd` is run on `lil_matrix` or `dok_matrix`. #### Any other comments? `coo_matrix` is about 1.5x slower than `csr_matrix`. Maybe it is worth also wa...
2018-06-14T18:10:41Z
randomized_svd is slow for dok_matrix and lil_matrix #### Description `sklearn.utils.extmath.randomized_svd` (and its object-oriented interface, `sklearn.decomposition.TruncatedSVD`) is extremely slow for certain types of sparse matrix. #### Steps/Code to Reproduce ``` >>> import numpy as np >>> import scipy...
[ { "body": "#### Description\r\n\r\n`sklearn.utils.extmath.randomized_svd` (and its object-oriented interface, `sklearn.decomposition.TruncatedSVD`) is extremely slow for certain types of sparse matrix.\r\n\r\n#### Steps/Code to Reproduce\r\n\r\n```\r\n>>> import numpy as np\r\n>>> import scipy.sparse as sp\r\n>...
a4f8e3d2a266fe4a253b449214806562ab83dda5
{ "head_commit": "cd69c1aa66f34290fea1f267f6ec03bb8b733159", "head_commit_message": "Add sparse efficiency warning to randomized_svd\n\nlil_matrix is 4x slower than csr_matrix, dok_matrix is ~50x slower.", "patch_to_review": "diff --git a/sklearn/utils/extmath.py b/sklearn/utils/extmath.py\nindex a619065f26878..a...
[ { "diff_hunk": "@@ -322,6 +321,15 @@ def randomized_svd(M, n_components, n_oversamples=10, n_iter='auto',\n # this implementation is a bit faster with smaller shape[1]\n M = M.T\n \n+ if isinstance(M, sparse.lil_matrix):", "line": null, "original_line": 324, "original_start_line":...
2442b6f21fa8f73c077670606a3c16ef82be639a
diff --git a/sklearn/utils/extmath.py b/sklearn/utils/extmath.py index a619065f26878..2004b24f05c41 100644 --- a/sklearn/utils/extmath.py +++ b/sklearn/utils/extmath.py @@ -15,8 +15,7 @@ import warnings import numpy as np -from scipy import linalg -from scipy.sparse import issparse, csr_matrix +from scipy import li...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Performance Optimizations" }
scikit-learn__scikit-learn-11192@0f8facc
scikit-learn/scikit-learn
Python
11,192
[MRG + 1] BUG: Uses self.scoring for score function
#### Reference Issues/PRs Fixes https://github.com/scikit-learn/scikit-learn/issues/10998. #### What does this implement/fix? Explain your changes. Adds a `score` function to `LogisticRegressionCV` that uses `self.scoring`.
2018-06-03T02:32:45Z
LogisticRegressionCV.score doesn't respect scoring, inconsistent with GridSearchCV From what I can see, LogisticRegressionCV.score always computes accuracy, not the metric given by ``scoring``. That's inconsistent with the behavior of ``GridSearchCV``. How do other ``CV`` estimators do that? I assume the same? That's ...
I feel this is a duplicate but can't find any other issues. #2709 is somewhat related. Also related to #4668 though I think the issue here is more clear as the user provided a metric. Looks like I complained about that in GridSearchCV in 2013 #1831 Just looked at the code for ```LogisticRegressionCV.score```. Can y...
[ { "body": "From what I can see, LogisticRegressionCV.score always computes accuracy, not the metric given by ``scoring``. That's inconsistent with the behavior of ``GridSearchCV``. How do other ``CV`` estimators do that? I assume the same?\r\nThat's pretty unfortunate and I think we should change it. We did the...
4d8ee4388ad0233e47bfe9eaa69959b50b857921
{ "head_commit": "0f8facca7f68644d904733720a4f844d5129f8a7", "head_commit_message": "DOC: Updates whats_new", "patch_to_review": "diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst\nindex 0e206878862ae..55b4d0b59a63c 100644\n--- a/doc/whats_new/v0.20.rst\n+++ b/doc/whats_new/v0.20.rst\n@@ -326,6 +326,...
[ { "diff_hunk": "@@ -1789,3 +1790,37 @@ def fit(self, X, y, sample_weight=None):\n \n self.C_ = np.asarray(self.C_)\n return self\n+\n+ def score(self, X, y, sample_weight=None):\n+ \"\"\"Returns the score using the `scoring` option on the given\n+ test data and labels.\n+\n+ ...
d690a1cb3c3a48e48ed9c931a8b0737dab4516ef
diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst index 0e206878862ae..55b4d0b59a63c 100644 --- a/doc/whats_new/v0.20.rst +++ b/doc/whats_new/v0.20.rst @@ -326,6 +326,11 @@ Classifiers and regressors returning incorrect probabilities in the case of binary outcomes. :issue:`9939` by :user:`Roger Westo...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-20633@f658b5f
spyder-ide/spyder
Python
20,633
PR: Create magics for run|debug file|cell (IPython console)
## Description of Changes - Depends on https://github.com/spyder-ide/spyder-kernels/pull/447 ### Issue(s) Resolved <!--- List the issue(s) below, in the form "Fixes #1234"; one per line ---> Fixes #20630 ### Affirmation By submitting this Pull Request or typing my (user)name below, I affirm the [De...
2023-03-04T20:37:59Z
Proposition: Turn runfile / runcell to IPython magics The functions: - `runfile` - `runcell` - `debugfile` - `debugcell` Are now added to the builtins. This is a bit strange because you wouldn't want to be able to call them from deep inside a library. I suggest replacing them with magic instead. The callin...
Also this greatly simplifies the handling of the namespace and removes the differences between debugcell / debug selection with the debug magic Do you think we _really_ need this? It's a huge change on the way Spyder has been working since probably it was created (i.e. more than 10 years ago) and I'm sure it would impa...
[ { "body": "The functions:\r\n - `runfile`\r\n - `runcell`\r\n - `debugfile`\r\n - `debugcell`\r\n \r\nAre now added to the builtins. This is a bit strange because you wouldn't want to be able to call them from deep inside a library.\r\nI suggest replacing them with magic instead. The calling convention would be...
7d15ec265a65927f608190ce29c758c570ccb893
{ "head_commit": "f658b5fb4c570a26a0a2f4ae6b6b949be3591631", "head_commit_message": "git subrepo clone --branch=magics_runfile --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels\n\nsubrepo:\n subdir: \"external-deps/spyder-kernels\"\n merged: \"8208bcdbb\"\nupstream:\n origin...
[ { "diff_hunk": "@@ -1899,22 +1904,21 @@ def run_script(self, filename, wdir, args, post_mortem, current_client,\n method = \"runfile\"\n # If spyder-kernels, use runfile\n if client.shellwidget.is_spyder_kernel:\n- line = method + \"('%s'\" % (norm(filename...
d5954e3db9ab91af62b153c8db509c32718e3d3b
diff --git a/external-deps/spyder-kernels/.gitrepo b/external-deps/spyder-kernels/.gitrepo index c53adcbee4c..28eb111ded1 100644 --- a/external-deps/spyder-kernels/.gitrepo +++ b/external-deps/spyder-kernels/.gitrepo @@ -6,7 +6,7 @@ [subrepo] remote = https://github.com/spyder-ide/spyder-kernels.git branch = maste...
{ "difficulty": "medium", "estimated_review_effort": 4, "problem_domain": "New Feature Additions" }
scikit-learn__scikit-learn-11232@0ef7f74
scikit-learn/scikit-learn
Python
11,232
[MRG] implements log-uniform random variable
#### Reference Issues/PRs Fixes #9919, "implement/benchmark loguniform random variable for randomized search" #### What does this implement/fix? Explain your changes. This PR * implements a log-uniform random variable * provides tests * implements an example * is meant to be used with `ParameterSampler...
2018-06-11T04:20:02Z
implement / benchmark loguniform distribution for randomized search Most of our standard grid searches use logarithmic scales. For the randomized search we approximate that using the exponential distribution. It might be quite a bit better to use an actual log uniform distribution. It would be great if someone could be...
Log uniform should look like: ```py def lognuniform(low=0, high=1, size=None, base=np.exp(1)): return np.power(base, np.random.uniform(low, high, size)) ``` (though it needs a slightly different API for use in RandomizedSearchCV) I'd like to handle this issue! I spent some time digging into this and couldn’t f...
[ { "body": "Most of our standard grid searches use logarithmic scales. For the randomized search we approximate that using the exponential distribution. It might be quite a bit better to use an actual log uniform distribution. It would be great if someone could benchmark that and possibly add the log uniform dis...
4e9f97dba582bade957a6b3a0503125698978fc0
{ "head_commit": "0ef7f74f6982cbfe4e4ad5750a12509601e1df2d", "head_commit_message": "Add scipy link in grid search", "patch_to_review": "diff --git a/doc/modules/classes.rst b/doc/modules/classes.rst\nindex 22e12e837478c..d87de0456455a 100644\n--- a/doc/modules/classes.rst\n+++ b/doc/modules/classes.rst\n@@ -1504...
[ { "diff_hunk": "@@ -139,6 +140,22 @@ For continuous parameters, such as ``C`` above, it is important to specify\n a continuous distribution to take full advantage of the randomization. This way,\n increasing ``n_iter`` will always lead to a finer search.\n \n+There is also a log-uniform random variable with\n+:...
80cc4d88f821b1daf657218f4128354aa57da4b2
diff --git a/doc/modules/grid_search.rst b/doc/modules/grid_search.rst index 751637441c6bd..b550fa7782f14 100644 --- a/doc/modules/grid_search.rst +++ b/doc/modules/grid_search.rst @@ -121,6 +121,7 @@ discrete choices (which will be sampled uniformly) can be specified:: This example uses the ``scipy.stats`` module, wh...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "New Feature Additions" }
spyder-ide__spyder-20475@602f666
spyder-ide/spyder
Python
20,475
PR: Stop automatic scrolling when a plot is selected (Plots)
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2023-02-04T09:15:03Z
Generating new plots always overrides currently selected plot Consider the following code: ``` import matplotlib.pyplot as plt, time for i in range(100): plt.figure() plt.plot([0, 1, i]) plt.show() time.sleep(0.1) ``` Every time a new plot is generated, it is selected in the plots panel. If...
Checked locally and that makes sense to me :+1: What do you think @spyder-ide/core-developers ? Generally makes sense to me in that particular case, but my concern is that if a user had a fair number of plots and had some older plot selected from well before they executed their code, they might expect Spyder to still o...
[ { "body": "Consider the following code:\r\n\r\n```\r\nimport matplotlib.pyplot as plt, time\r\nfor i in range(100):\r\n plt.figure()\r\n plt.plot([0, 1, i])\r\n plt.show()\r\n time.sleep(0.1)\r\n```\r\n\r\nEvery time a new plot is generated, it is selected in the plots panel. If you want to look at ...
450e50d08e12c96183769875ff164a515491fbad
{ "head_commit": "602f666ba19b893534610d9cd2b220a12cd17fdb", "head_commit_message": "Merge remote-tracking branch 'upstream/master' into stick_to_end_plots", "patch_to_review": "diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py\nindex 38cd066069c..ef4f811c6eb 100644\n--- a/spy...
[ { "diff_hunk": "@@ -2102,7 +2103,7 @@ def test_plots_scroll(main_window, qtbot):\n \" plt.plot([1, 2, 3, 4], '.')\\n\"\n \" plt.show()\\n\"\n \" time.sleep(.1)\")\n- qtbot.wait(500)\n+ qtbot.waitUntil(lambda: sb._first_thumbnail_shown, timeout=SHELL_TIM...
d5f9af76c1aecc3d7024571c0593aeca83f4b75b
diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py index 38cd066069c..715fb9572d4 100644 --- a/spyder/app/tests/test_mainwindow.py +++ b/spyder/app/tests/test_mainwindow.py @@ -2049,6 +2049,81 @@ def test_plots_plugin(main_window, qtbot, tmpdir, mocker): assert compare_images(ip...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-11151@0b41dfa
scikit-learn/scikit-learn
Python
11,151
[MRG+2] catch more expected warnings in common tests
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fi...
2018-05-27T20:13:49Z
catch more warnings in common tests Right now the output of travis is too large to render, partially because a lot of deprecation warnings and partially because of warnings from the common tests. The common tests should catch all the deprecation warnings and probably also convergence warnings or numerical warnings (we ...
Do you mean deprecation warnings like the one below? If you can guide me a little, I am happy to work on this issue. ![image](https://user-images.githubusercontent.com/5948157/40274153-453622a6-5c02-11e8-8e50-29d341612e02.png) I meant deprecation warnings raised in scikit-learn, not in Numpy. That one you mention i...
[ { "body": "Right now the output of travis is too large to render, partially because a lot of deprecation warnings and partially because of warnings from the common tests. The common tests should catch all the deprecation warnings and probably also convergence warnings or numerical warnings (we decrease the numb...
1c61b8ac1b66254208ba6a51c1eed6ad66dc0330
{ "head_commit": "0b41dfa12345b5d02810476cfa03c459b40e672f", "head_commit_message": "remove reset warning in assert_warns", "patch_to_review": "diff --git a/sklearn/tests/test_common.py b/sklearn/tests/test_common.py\nindex 62a3bee5fc12d..1ec855fe67a37 100644\n--- a/sklearn/tests/test_common.py\n+++ b/sklearn/tes...
[ { "diff_hunk": "@@ -211,26 +211,20 @@ def context_manager_no_user_multiple_warning():\n assert_warns(DeprecationWarning, context_manager_no_user_multiple_warning)\n \n \n-# This class is inspired from numpy 1.7 with an alteration to check\n-# the reset warning filters after calls to assert_warns.\n-# This a...
493f966f274973fa9fd58ce678f31f6a38965354
diff --git a/sklearn/gaussian_process/tests/test_gaussian_process.py b/sklearn/gaussian_process/tests/test_gaussian_process.py index 6d6fa3ab81193..2cacd217cc986 100644 --- a/sklearn/gaussian_process/tests/test_gaussian_process.py +++ b/sklearn/gaussian_process/tests/test_gaussian_process.py @@ -15,6 +15,7 @@ from skl...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Test Suite / CI Enhancements" }
spyder-ide__spyder-18686@c49763c
spyder-ide/spyder
Python
18,686
PR: Prevent segfault when modifying the editor content
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2022-07-15T18:35:48Z
Segmentation fault crash from the Editor ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> Head of C stack: ``` Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x7ff80434300e __pthread_kill + 10 1 libsystem_...
@impact27, any ideas on how to reproduce this? I managed to (kinda) reproduce it: 1. open a file and add ~100 lines with breakpoints, errors, warnings, todo, and other things that would create scrollflags 2. Open the same file with another program and delete all the lines 3. go back to spyder Doing that it cras...
[ { "body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nHead of C stack:\n\n```\nThread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread\n0 libsystem_kernel.dylib \t 0x7ff80434300e __pthread_kill + 10\n1 libsystem_pthread.dy...
d6dc36cf0119ef5ead37b759052511c2afbc2f0f
{ "head_commit": "c49763ceda615a7b31e7aead20e917c261ab1471", "head_commit_message": "pep8", "patch_to_review": "diff --git a/spyder/plugins/editor/panels/scrollflag.py b/spyder/plugins/editor/panels/scrollflag.py\nindex 5a761f24935..2310b576859 100644\n--- a/spyder/plugins/editor/panels/scrollflag.py\n+++ b/spyde...
[ { "diff_hunk": "@@ -51,6 +51,23 @@ def drift_color(base_color, factor=110):\n return base_color.lighter(factor + 10)\n \n \n+def block_safe(block):\n+ \"\"\"\n+ Check if the block is safe to work with.\n+\n+ A BlockUserData must have been set on the block while it was known safe.\n+\n+ I...
d59aed3a37585a2c471346a26ba0da6b48f2a206
diff --git a/spyder/plugins/editor/panels/scrollflag.py b/spyder/plugins/editor/panels/scrollflag.py index 5a761f24935..1ae496f039d 100644 --- a/spyder/plugins/editor/panels/scrollflag.py +++ b/spyder/plugins/editor/panels/scrollflag.py @@ -20,6 +20,7 @@ # Local imports from spyder.api.panel import Panel from spyder...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-17526@6641707
spyder-ide/spyder
Python
17,526
PR: Prompt user to reset Spyder config files in case `CONF` instance initialization fails
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2022-03-22T19:50:27Z
Error when loading configuration file I can't open Spyder via Anaconda, if i want to start spyder, the loading bar will apear but after that nothing happen. Also if i want to update it to a newer version like 5.0.5, it will load until infinity. If i want to open spyder via the terminal, this will appear: (base) C...
Hey @Programmfailer, thanks for reporting. Please run the following command in the Anaconda Prompt: spyder --reset and after that, start Spyder again. That should solve your problem. Let us know if it works for you. Note: we should catch and load our default config with this kind of errors because there's...
[ { "body": "I can't open Spyder via Anaconda, if i want to start spyder, the loading bar will apear but after that nothing happen. Also if i want to update it to a newer version like 5.0.5, it will load until infinity.\r\n\r\nIf i want to open spyder via the terminal, this will appear:\r\n\r\n(base) C:\\Users\\f...
2d2fb2f731f348923df923e93d06c18517dfde1f
{ "head_commit": "6641707490a628e28135982cc1e81511e9807330", "head_commit_message": "Config: Create QApplication to show config files reset messages", "patch_to_review": "diff --git a/spyder/config/manager.py b/spyder/config/manager.py\nindex 30179eb1740..3bf8ceea80b 100644\n--- a/spyder/config/manager.py\n+++ b/...
[ { "diff_hunk": "@@ -637,4 +641,21 @@ def reset_shortcuts(self):\n plugin_config.reset_to_defaults(section='shortcuts')\r\n \r\n \r\n-CONF = ConfigurationManager()\r\n+try:\r\n+ CONF = ConfigurationManager()\r\n+except Exception:\r\n+ from spyder.app.utils import create_application\r\n+ app ...
09a10f5a5c0f584cd53a44973144fa0dad8bc099
diff --git a/spyder/config/manager.py b/spyder/config/manager.py index 30179eb1740..c0d52c4fa44 100644 --- a/spyder/config/manager.py +++ b/spyder/config/manager.py @@ -17,7 +17,8 @@ # Local imports from spyder.api.utils import PrefixedTuple -from spyder.config.base import _, get_conf_paths, get_conf_path, get_h...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-17205@c77e8d4
spyder-ide/spyder
Python
17,205
PR: Catch leaks in the test suite
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2022-01-17T09:28:10Z
Crash on bad IPython config ## Description Crash when closing a console which shows an error. The restarter is not properly stopped. ### What steps will reproduce the problem? 1- Create a console with an error at launch ```python import os.path as osp from IPython.core.application import get_ipython_dir ipy...
[ { "body": "## Description\r\nCrash when closing a console which shows an error. The restarter is not properly stopped.\r\n\r\n### What steps will reproduce the problem?\r\n\r\n 1- Create a console with an error at launch\r\n```python\r\nimport os.path as osp\r\nfrom IPython.core.application import get_ipython_d...
cd3a8e376cd9bbcd60d0493baf9c96edd661c9f3
{ "head_commit": "c77e8d437edb3291234e7b982621c84f1f1165df", "head_commit_message": "fix test", "patch_to_review": "diff --git a/spyder/app/mainwindow.py b/spyder/app/mainwindow.py\nindex 938ea1e68bb..4f8908093fb 100644\n--- a/spyder/app/mainwindow.py\n+++ b/spyder/app/mainwindow.py\n@@ -1553,7 +1553,8 @@ def clo...
[ { "diff_hunk": "@@ -352,6 +354,87 @@ def main_window(request, tmpdir):\n print(client.info_page)\n window.close()\n del main_window.window\n+ else:\n+ # Close everything we can think of\n+ window.editor.close_file()\n+ window.projec...
cb23c45be440b84b4199b9bc61b994c571c8d43e
diff --git a/spyder/app/mainwindow.py b/spyder/app/mainwindow.py index 938ea1e68bb..4f8908093fb 100644 --- a/spyder/app/mainwindow.py +++ b/spyder/app/mainwindow.py @@ -1553,7 +1553,8 @@ def closing(self, cancelable=False, close_immediately=False): # to show them in their previous locations in the next session...
{ "difficulty": "medium", "estimated_review_effort": 4, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-10677@0a57d9c
scikit-learn/scikit-learn
Python
10,677
[MRG+1] Change default error_score to raise_deprecating
#### Reference Issues/PRs Fixes #10309. #### What does this implement/fix? Explain your changes. Changes default parameter of error_score to raise-deprecating #### Any other comments? Should be method _fit_and_score(cross_validation.py) be updated in the same way?
2018-02-22T23:18:39Z
Change the default of *SearchCV's error_score to np.nan It can be pretty unpleasant when your grid search fails. That's why the `error_score` parameter was introduced. The default `error_score='raise'` helps make absolutely clear that there was a failure by terminating the program, but it might be kind to just set the ...
What happens for the refit? Do we just exclude the failed ones and warn about it? Well, I suppose we'd better be careful when sorting scores to watch out for NaNs (I doubt we check this case atm)... and to raise an error if the `best_estimator_` has a NaN score. We could use `-np.inf` instead so that we get sorting for...
[ { "body": "It can be pretty unpleasant when your grid search fails. That's why the `error_score` parameter was introduced. The default `error_score='raise'` helps make absolutely clear that there was a failure by terminating the program, but it might be kind to just set the score to NaN and raise a warning. We ...
02ddc70ee67c927365c66a186d0c9e2dadd88572
{ "head_commit": "0a57d9cfc42f8927d43d0475b2c758d64823b378", "head_commit_message": "Add description of default value of error_score.", "patch_to_review": "diff --git a/sklearn/model_selection/_search.py b/sklearn/model_selection/_search.py\nindex 8a4c13c640bc4..9f02b7d95437c 100644\n--- a/sklearn/model_selection...
[ { "diff_hunk": "@@ -484,6 +484,14 @@ def _fit_and_score(estimator, X, y, scorer, train, test, verbose,\n score_time = 0.0\n if error_score == 'raise':\n raise\n+ elif error_score == 'raise-deprecating':\n+ warnings.warn(\"Estimator failed to fit for these parameters...
28718baf8b1a4d984d56e3ee2da9a8a0e3d34578
diff --git a/sklearn/model_selection/_search.py b/sklearn/model_selection/_search.py index 8a4c13c640bc4..4af8a03c3e194 100644 --- a/sklearn/model_selection/_search.py +++ b/sklearn/model_selection/_search.py @@ -273,7 +273,7 @@ def __len__(self): def fit_grid_point(X, y, estimator, parameters, train, test, scorer...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "New Feature Additions" }
spyder-ide__spyder-16337@3108c10
spyder-ide/spyder
Python
16,337
PR: debugpy is not zip compatible (macOS app)
## Description of Changes Ensured that `debugpy` is bundled outside zip folder in macOS application. ### Issue(s) Resolved <!--- List the issue(s) below, in the form "Fixes #1234"; one per line ---> Fixes #16336 ### Affirmation By submitting this Pull Request or typing my (user)name below, I affirm...
2021-09-02T14:12:50Z
5.1.2 Mac installer broken? ### What steps will reproduce the problem? <!--- You can use Markdown here ---> I installed the update (my first update after installing and working with Spyder for the last 2 days). In the update, the kernel will not load (macOS Catalina): NotADirectoryError: [Errno 20] Not a directory: ...
Hey @gctwnl, thanks for reporting. That's a problem with the Mac installer only. @mrclary, could you take a look at this one? installs fine but fails 'cannot load kernel'.
[ { "body": "### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nI installed the update (my first update after installing and working with Spyder for the last 2 days). In the update, the kernel will not load (macOS Catalina):\n\nNotADirectoryError: [Errno 20] Not a directory: '/A...
f9cd22f2b0133133f205fe6f6f1363cfb093439e
{ "head_commit": "3108c10714a6a5abba1cafe46d12475a32d157a2", "head_commit_message": "* debugpy is not zip compatible. \"NotADirectoryError: [Errno 20] Not a directory: '.../Spyder.app/Contents/Resources/lib/python39.zip/debugpy/_vendored'\"", "patch_to_review": "diff --git a/installers/macOS/setup.py b/installers...
[ { "diff_hunk": "@@ -150,6 +153,7 @@ def make_app_bundle(dist_dir, make_lite=False):\n 'pylsp', 'pylsp_black', 'pyls_spyder', 'qtawesome',\n 'setuptools', 'sphinx', 'spyder', 'spyder_kernels',\n 'textdistance',\n+ 'debugpy',", "line": null, "...
75b25d341dd613af8854458d0894ef73d8c95915
diff --git a/installers/macOS/setup.py b/installers/macOS/setup.py index bb06b1b293f..53ace20b607 100644 --- a/installers/macOS/setup.py +++ b/installers/macOS/setup.py @@ -68,6 +68,9 @@ def make_app_bundle(dist_dir, make_lite=False): File "<frozen zipimport>", line 177, in get_data KeyError: 'blib2to...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
scikit-learn__scikit-learn-10536@2b86e40
scikit-learn/scikit-learn
Python
10,536
[MRG+1] change threshold computation in trees
#### Reference Issues/PRs Fixes #10267 #### What does this implement/fix? Explain your changes. Change threshold computation in trees. The modification should not change anything in most cases, as the computation should be equal to the previous. It should avoid cases where the previous computation could give infin...
2018-01-26T00:35:52Z
GradientBoostingRegressor with huber loss sometimes fails with an `IndexError: cannot do a non-empty take from an empty axes.` If I use the first 63726 lines of my dataset for training everything works, but if I add one line more to the training set, then I get the error. My dataset contains no NaNs. The 63727th line h...
From that error message I can deduce that `_update_terminal_region` is being called with `terminal_regions` not containing `leaf`. I'm not familiar enough with this technique to know whether this is a state that should never happen, or whether this is a case that is unhandled but should be. (@pprett?) Either way, thank...
[ { "body": "If I use the first 63726 lines of my dataset for training everything works, but if I add one line more to the training set, then I get the error. My dataset contains no NaNs. The 63727th line has no obvious differences from the others, furthermore if I use lines 63000:64000 for training then I don't ...
79053af9769765e04d51018a7a167dfe2c2ef2ff
{ "head_commit": "2b86e406b4301235844329e2337001e257b1d38e", "head_commit_message": "add line in whats new", "patch_to_review": "diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst\nindex 7e7d39dbf1759..72294bb51bdc7 100644\n--- a/doc/whats_new/v0.20.rst\n+++ b/doc/whats_new/v0.20.rst\n@@ -215,6 +215,1...
[ { "diff_hunk": "@@ -215,6 +215,11 @@ Classifiers and regressors\n unexpected TypeError given dense inputs.\n :issue:`10412` by :user:`Jiongyan Zhang <qmick>`.\n \n+- Fixed a bug in :class:`tree._splitter.BestSplitter` and", "line": null, "original_line": 218, "original_start_line": null, "pa...
ed9eccfd9309c4216a88e6efb06c635aa0efd87d
diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst index 7e7d39dbf1759..29a5b4b63fec2 100644 --- a/doc/whats_new/v0.20.rst +++ b/doc/whats_new/v0.20.rst @@ -215,6 +215,10 @@ Classifiers and regressors unexpected TypeError given dense inputs. :issue:`10412` by :user:`Jiongyan Zhang <qmick>`. +- Fixed...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "Bug Fixes" }
spyder-ide__spyder-16509@928c118
spyder-ide/spyder
Python
16,509
PR: Add functionality run to and from current line to editor
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2021-09-29T14:00:45Z
Feature request: "Run to line" and "Run from line" ## Description This is a suggestion to add the ability to "run to line" and "run from line" to the run menu. VS Code has this ability for example. "Run to line" would execute all the lines in the file up until the current cursor line (excluding the selected line) ...
[ { "body": "## Description\r\nThis is a suggestion to add the ability to \"run to line\" and \"run from line\" to the run menu. VS Code has this ability for example.\r\n\r\n\"Run to line\" would execute all the lines in the file up until the current cursor line (excluding the selected line)\r\n\"Run from line\" ...
80ad2b6d5c9b85fd2e3ca266467ceffa895b80d0
{ "head_commit": "928c1184428dcaa43374a2ba701ff345f16523b7", "head_commit_message": "rename menu items run to current line", "patch_to_review": "diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py\nindex f35b35fbb46..8619bf0d585 100644\n--- a/spyder/app/tests/test_mainwindow.py\...
[ { "diff_hunk": "@@ -4344,7 +4346,14 @@ def setup_context_menu(self):\n icon=ima.icon('run_selection'),\r\n shortcut=CONF.get_shortcut('editor', 'run selection'),\r\n triggered=self.sig_run_selection.emit)\r\n-\r\n+ self.run_to_line_action = create_action(\r\n+ ...
93823a37a1be93f79401be14ee38a311ba00cfde
diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py index f35b35fbb46..20946ce3638 100644 --- a/spyder/app/tests/test_mainwindow.py +++ b/spyder/app/tests/test_mainwindow.py @@ -1336,13 +1336,19 @@ def test_run_code(main_window, qtbot, tmpdir): main_window.editor.load(filepath) ...
{ "difficulty": "medium", "estimated_review_effort": 3, "problem_domain": "New Feature Additions" }
spyder-ide__spyder-15447@41df6df
spyder-ide/spyder
Python
15,447
PR: Fix args/kwargs handling in the call_all_editorstacks signature to update completion related options for the Editor
<!--- Make sure to read the Contributing Guidelines: ---> <!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md ---> <!--- and follow PEP 8, PEP 257 and Spyder's code style: ---> <!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style ---> ## Descrip...
2021-04-27T17:29:42Z
TypeError when using kite_tutorial ## Description ### What steps will reproduce the problem? <!--- You can use Markdown here ---> follow instructions in kite_tutorial.py just type a in line 84 to try autocompletion fwhen importing matplotlib boom ### Traceback ```python-traceback Traceback (most recent call las...
Hey @castorfou. thanks for reporting. We'll take a look at this problem. @dalthviz, could you take a look at this? Thanks! @ccordoba12 @castorfou I was able to replicate this but first I had to change the preferences to enable autocompletion results after just 1 character (the default is 3 I think): ![auto](https...
[ { "body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nfollow instructions in kite_tutorial.py\n\njust type a in line 84 to try autocompletion fwhen importing matplotlib\n\nboom\n\n\n### Traceback\n```python-traceback\nTraceback (most recent call last...
7747c10287225e6deedb48f8f635bd1286d2f1e1
{ "head_commit": "41df6df0749260f41e4112c19b61d9d1fef9d070", "head_commit_message": "Completion: Change signal emit to not put changed values as a tuple", "patch_to_review": "diff --git a/spyder/plugins/completion/plugin.py b/spyder/plugins/completion/plugin.py\nindex 6b52921f314..d32a96dcf3f 100644\n--- a/spyder...
[ { "diff_hunk": "@@ -367,7 +367,7 @@ def after_configuration_update(self, options: List[Union[tuple, str]]):\n if opt in options:\n opt_value = self.get_conf(opt, section=sec)\n self.sig_editor_rpc.emit('call_all_editorstacks',\n- ...
4b4ffe70bbb96fc10198cfe6d2e37784d4fc7188
diff --git a/spyder/plugins/completion/plugin.py b/spyder/plugins/completion/plugin.py index 6b52921f314..5c4fdd8920b 100644 --- a/spyder/plugins/completion/plugin.py +++ b/spyder/plugins/completion/plugin.py @@ -367,7 +367,7 @@ def after_configuration_update(self, options: List[Union[tuple, str]]): if opt...
{ "difficulty": "low", "estimated_review_effort": 2, "problem_domain": "Bug Fixes" }