instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
spyder-ide__spyder-14628@e6aadbc | spyder-ide/spyder | Python | 14,628 | PR: Add button to show and hide replace widget from find widget | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2021-01-21T01:00:52Z | Remove all secondary toolbars and relocate the actions that are needed
1. Remove the source toolbar completely
- [x] Remove toolbar menu item in the toolbars menu
- [ ] Embed content of warnings in code analysis and have some options to decide which linter to use. (Pylint (Non Real time) VS Real time) -> Spyder 6
... | [
{
"body": "1. Remove the source toolbar completely \r\n- [x] Remove toolbar menu item in the toolbars menu\r\n- [ ] Embed content of warnings in code analysis and have some options to decide which linter to use. (Pylint (Non Real time) VS Real time) -> Spyder 6\r\n- [ ] Deactivate run analysis button when real... | 357939073b86df8292568b949332446146c52839 | {
"head_commit": "e6aadbc0a5cbb20f29334b85977a59a2fa2cdabf",
"head_commit_message": "Add button to show and hide replace widget from find widget",
"patch_to_review": "diff --git a/spyder/widgets/findreplace.py b/spyder/widgets/findreplace.py\nindex fed446cabd8..1b3f24304b5 100644\n--- a/spyder/widgets/findreplace... | [
{
"diff_hunk": "@@ -89,6 +89,12 @@ def __init__(self, parent, enable_replace=False):\n self.text_has_been_edited)\r\n \r\n self.number_matches_text = QLabel(self)\r\n+ self.replace_on = False\r\n+ self.replace_text_button = create_toolbu... | 545fbe460e9b9abd196e28f8ac592864fb8dea0b | diff --git a/spyder/widgets/findreplace.py b/spyder/widgets/findreplace.py
index fed446cabd8..fe1a29eb3b4 100644
--- a/spyder/widgets/findreplace.py
+++ b/spyder/widgets/findreplace.py
@@ -89,6 +89,13 @@ def __init__(self, parent, enable_replace=False):
self.text_ha... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
spyder-ide__spyder-17181@0ed982f | spyder-ide/spyder | Python | 17,181 | PR: Create new file with %edit magic (IPython console) | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2022-01-12T17:40:45Z | %edit magic can't create a new file
## Description of your problem
From an ipython prompt in Spyder, editing a non-existent file gives an error. It would be great if this just created a new, blank file. If there's a way to do this, or different command, I couldn't find it.
**What steps will reproduce the problem?**... | Thanks for the suggestion. We'll see what we can do about it :-)
OK, thanks! It's not a big deal, just an annoying bump in workflow. | [
{
"body": "## Description of your problem\n\nFrom an ipython prompt in Spyder, editing a non-existent file gives an error. It would be great if this just created a new, blank file. If there's a way to do this, or different command, I couldn't find it.\n\n**What steps will reproduce the problem?**\n1. Open ipy... | b0c3685d2538e0ef7448ef7b05fb78c660011d61 | {
"head_commit": "0ed982f4165300dc2f8cd0674e909908dc9c3358",
"head_commit_message": "Merge remote-tracking branch 'upstream/5.x' into edit_new_file",
"patch_to_review": "diff --git a/spyder/plugins/ipythonconsole/widgets/main_widget.py b/spyder/plugins/ipythonconsole/widgets/main_widget.py\nindex 369eb9fbcb9..36d... | [
{
"diff_hunk": "@@ -1314,6 +1314,10 @@ def tab_name_editor(self):\n @Slot(object, object)\n def edit_file(self, filename, line):\n \"\"\"Handle %edit magic petitions.\"\"\"\n+ if not osp.isfile(filename):\n+ # Create new file\n+ with open(filename, \"w\") as f:\n+ ... | 53ffcbe3dcacb2a4fc044be06a4d1fd1f03d4544 | diff --git a/spyder/plugins/ipythonconsole/plugin.py b/spyder/plugins/ipythonconsole/plugin.py
index 80297f4ba25..b95c4d70d80 100644
--- a/spyder/plugins/ipythonconsole/plugin.py
+++ b/spyder/plugins/ipythonconsole/plugin.py
@@ -98,6 +98,16 @@ class IPythonConsole(SpyderDockablePlugin):
requested file.
"... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
ray-project__ray-50290@a5feb62 | ray-project/ray | Python | 50,290 | [Data] Implement accurate memory accounting for all-to-all operations | <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. -->
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your P... | 2025-02-06T18:40:28Z | [Data] Ray Data runs out of disk while writing Parquet files
### What happened + What you expected to happen
See repro.
I'm trying to load Parquet files that contain image URIs, load those images, and write the loaded images to Parquet files. To ensure that Ray Data fully utilizes the cluster, I repartitioned the i... | @bveeramani why is back-pressure not kicking in here?
> Calling repartition causes Ray Data to fall back to the old scheduling behavior
@alexeykudinkin Because of this
@bveeramani can you help me understand why we're falling back to old behavior then? Is it b/c of `override_num_blocks` being used?
No, `override_num... | [
{
"body": "### What happened + What you expected to happen\n\nSee repro.\r\n\r\nI'm trying to load Parquet files that contain image URIs, load those images, and write the loaded images to Parquet files. To ensure that Ray Data fully utilizes the cluster, I repartitioned the input data, but then I ran into a new... | 0ea06bd91657016d7b3eb4010d3a729078570618 | {
"head_commit": "a5feb6227f493b5aadd420e9077ac8415050685e",
"head_commit_message": "Remove old method\n\nSigned-off-by: Balaji Veeramani <bveeramani@berkeley.edu>",
"patch_to_review": "diff --git a/python/ray/data/_internal/execution/operators/base_physical_operator.py b/python/ray/data/_internal/execution/opera... | [
{
"diff_hunk": "@@ -94,23 +94,34 @@ def _add_input_inner(self, refs: RefBundle, input_index: int) -> None:\n assert not self.completed()\n assert input_index == 0, input_index\n self._input_buffer.append(refs)\n+ self._metrics.on_input_queued(refs)\n \n def all_inputs_done(sel... | 6287ebd134d0949e71d5fa0d6dfd8ced1cad56c5 | diff --git a/python/ray/data/_internal/execution/operators/base_physical_operator.py b/python/ray/data/_internal/execution/operators/base_physical_operator.py
index 1ad9b069e87b..2fc10da991be 100644
--- a/python/ray/data/_internal/execution/operators/base_physical_operator.py
+++ b/python/ray/data/_internal/execution/o... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-10508@52a306d | scikit-learn/scikit-learn | Python | 10,508 | [MRG+1] Fixes #10458: Make LabelEncoder work with empty list/array | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist
-->
#### Reference Issues/PRs
Fixes #10458
<!--
Example: Fixes #1234. See also #3456.
Please use key... | 2018-01-19T18:00:29Z | LabelEncoder transform fails for empty lists (for certain inputs)
Python 3.6.3, scikit_learn 0.19.1
Depending on which datatypes were used to fit the LabelEncoder, transforming empty lists works or not. Expected behavior would be that empty arrays are returned in both cases.
```python
>>> from sklearn.preprocess... | `le.transform([])` will trigger an numpy array of `dtype=np.float64` and you fit something which was some string.
```python
from sklearn.preprocessing import LabelEncoder
import numpy as np
... | [
{
"body": "Python 3.6.3, scikit_learn 0.19.1\r\n\r\nDepending on which datatypes were used to fit the LabelEncoder, transforming empty lists works or not. Expected behavior would be that empty arrays are returned in both cases.\r\n\r\n```python\r\n>>> from sklearn.preprocessing import LabelEncoder\r\n>>> le = L... | c753b77ac49e72ebc0fe5e3c2369fe628f975017 | {
"head_commit": "52a306dc9e0c1024a7cf6aaf103b52154a6160d8",
"head_commit_message": "Revert previously deleted test",
"patch_to_review": "diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst\nindex 5b15eddbf514a..71568755d3e90 100644\n--- a/doc/whats_new/v0.20.rst\n+++ b/doc/whats_new/v0.20.rst\n@@ -276... | [
{
"diff_hunk": "@@ -125,6 +125,8 @@ def transform(self, y):\n y : array-like of shape [n_samples]\n \"\"\"\n check_is_fitted(self, 'classes_')\n+ if _num_samples(y) == 0:\n+ return np.array([])",
"line": null,
"original_line": 129,
"original_start_line": nul... | 54ae8797bc2255eb5199c4cc64ed27a6fbb7b2ed | diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst
index 5b15eddbf514a..1c1832a1fca06 100644
--- a/doc/whats_new/v0.20.rst
+++ b/doc/whats_new/v0.20.rst
@@ -276,6 +276,12 @@ Feature Extraction
(words or n-grams). :issue:`9147` by :user:`Claes-Fredrik Mannby <mannby>`
and `Roman Yurchak`_.
+Preproces... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-10471@0f6e25f | scikit-learn/scikit-learn | Python | 10,471 | [MRG + 1] KMeans optimisation for array C/F contiguity |
<!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist
-->
#### Reference Issues/PRs
<!--
Example: Fixes #1234. See also #3456.
Please use keywords (e.g.... | 2018-01-14T11:20:46Z | KMeans optimisation for array C/F contiguity (was: Make sure that the output of PCA.fit_transform is C contiguous)
otherwise, I would rather use:
``` Python
pca.fit(X)
X_new = pca.transform(X)
```
Because of FORTRAN data for inner product is very slow. (for example, in the KMeans) | Can you give an example?
Maybe we should then rather change the behavior in KMeans.
I wouldn't change the output format, since we don't know what the user wants to do next.
They should be the same that the output and input format of PCA.fit_transform, isn't it?
Because PCA.transform is such.
In _k_means._assign_label... | [
{
"body": "otherwise, I would rather use:\n\n``` Python\npca.fit(X)\nX_new = pca.transform(X)\n```\n\nBecause of FORTRAN data for inner product is very slow. (for example, in the KMeans)\n",
"number": 4582,
"title": "KMeans optimisation for array C/F contiguity (was: Make sure that the output of PCA.fit... | 52aaf8269235d4965022b8ec970243bdcb59c9a7 | {
"head_commit": "0f6e25f35a0f960e471b1973936386f0b33fd882",
"head_commit_message": "KMeans optimisation for array C/F contiguity\n\nFixes #4582",
"patch_to_review": "diff --git a/sklearn/cluster/k_means_.py b/sklearn/cluster/k_means_.py\nindex 07e390701eaac..207affa84b618 100644\n--- a/sklearn/cluster/k_means_.p... | [
{
"diff_hunk": "@@ -393,7 +396,7 @@ def _kmeans_single_elkan(X, n_clusters, max_iter=300, init='k-means++',\n precompute_distances=True):\n if sp.issparse(X):\n raise ValueError(\"algorithm='elkan' not supported for sparse input X\")\n- X = check_array(X, order=\"C\")\n+ ... | ff9507c56e55bb81c8942a2c3b21de970e6c59f3 | diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst
index a7ae9f7415243..b4a8046d02956 100644
--- a/doc/whats_new/v0.20.rst
+++ b/doc/whats_new/v0.20.rst
@@ -125,6 +125,13 @@ Classifiers and regressors
only require X to be an object with finite length or shape.
:issue:`9832` by :user:`Vrishank Bhardwaj... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
scikit-learn__scikit-learn-10483@f914ab0 | scikit-learn/scikit-learn | Python | 10,483 | [MRG+2] Moves Imputation out of Preprocessing | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist
-->
#### Reference Issues/PRs
<!--
Example: Fixes #1234. See also #3456.
Please use keywords (e.g., Fi... | 2018-01-16T20:27:35Z | Move imputation out of preprocessing
While we're considering additional imputers, I've wondered whether preprocessing is the right place for it. Yes, it is a preprocessing step before other learning, but it often makes use of other supervised and unsupervised learners and hence is a learning task of its own. And prepro... | > modules on the basis of how they work rather than function
I don't like this (even though we've done that in the past - inconsistently. Why is LDA and LinearSVC not in linear models?)
I'm +.5 for ``sklearn.impute``, possibly moving when when we add the next class (KNNImputer I guess?).
Actually, given that MICE... | [
{
"body": "While we're considering additional imputers, I've wondered whether preprocessing is the right place for it. Yes, it is a preprocessing step before other learning, but it often makes use of other supervised and unsupervised learners and hence is a learning task of its own. And preprocessing is getting... | 98eb09e9206cb714da85c5a0616deff3cc85a1d5 | {
"head_commit": "f914ab00deb42011dfaec3920997bd5a420e9c20",
"head_commit_message": "all references to preprocessing.impute changed to impute",
"patch_to_review": "diff --git a/doc/glossary.rst b/doc/glossary.rst\nindex bea57117f7cbf..55355f0d5d44c 100644\n--- a/doc/glossary.rst\n+++ b/doc/glossary.rst\n@@ -480,7... | [
{
"diff_hunk": "@@ -60,6 +61,8 @@ def _most_frequent(array, extra_value, n_repeat):\n return extra_value\n \n \n+@deprecated(\"Imputer was deprecated in version 0.20 and will be \"\n+ \"removed in 0.22. Import Imputer from sklearn instead.\")",
"line": null,
"original_line": 65,
... | 2210504d819cc16eaea2372514e911d0a2b14e36 | diff --git a/doc/glossary.rst b/doc/glossary.rst
index c9b55bd5f17f7..0c883a0291c4e 100644
--- a/doc/glossary.rst
+++ b/doc/glossary.rst
@@ -480,7 +480,7 @@ General Concepts
missing values
Most Scikit-learn estimators do not work with missing values. When they
- do (e.g. in :class:`preprocessing.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
scikit-learn__scikit-learn-10382@f56bd83 | scikit-learn/scikit-learn | Python | 10,382 | [MRG+1] Fixes #10310 Cross Validation FitFailedWarning message and exception | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist
-->
#### Reference Issues/PRs
fixes #10310
<!--
Example: Fixes #1234. See also #3456.
Please use k... | 2017-12-28T07:05:13Z | FitFailedWarning raised by cross validation could do with better message
Current message says "Classifier fit failed" but the estimator is not necessarily a classifier. (Perhaps that's too pedantic of me...)
`%r` is not technically the best way to display an error message. We could either use `traceback.format_exc` ... | I've attempted to fix it, please check. | [
{
"body": "Current message says \"Classifier fit failed\" but the estimator is not necessarily a classifier. (Perhaps that's too pedantic of me...)\r\n\r\n`%r` is not technically the best way to display an error message. We could either use `traceback.format_exc` and include the whole traceback; or we can use `... | 1e1417cab24e5602d2d4db85e218d5277f13aeda | {
"head_commit": "f56bd83d7947e337e82a967380180e5d56b2374f",
"head_commit_message": "Fixes #10310: Cross Validation FitFailedWarning message and exception formatting",
"patch_to_review": "diff --git a/sklearn/model_selection/_validation.py b/sklearn/model_selection/_validation.py\nindex 24362620c809f..d6d4c0924b3... | [
{
"diff_hunk": "@@ -1421,3 +1421,31 @@ def test_permutation_test_score_pandas():\n check_series = lambda x: isinstance(x, TargetType)\n clf = CheckingClassifier(check_X=check_df, check_y=check_series)\n permutation_test_score(clf, X_df, y_ser)\n+\n+\n+def test_fit_and_score():\n+ from... | 8734e053f8754731ad8b9ca4e95eadcad96a42bf | diff --git a/sklearn/exceptions.py b/sklearn/exceptions.py
index 4bfcd0ae1ae85..e58f42760663c 100644
--- a/sklearn/exceptions.py
+++ b/sklearn/exceptions.py
@@ -119,9 +119,9 @@ class FitFailedWarning(RuntimeWarning):
... pass
... print(repr(w[-1].message))
... # doctest: +NORMALIZE_WHITESPACE... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-13884@4eb793a | spyder-ide/spyder | Python | 13,884 | PR: Display an error message when Kite sends a non-dict response | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2020-09-29T23:46:55Z | TypeError: KiteClient.sig_response_ready in Kite's client
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
I the procedures on the uninstall of kite through the terminal. Then I found the kite folders on my macbook and i send them to trash, but now my spider give me this... | @xavierricci, thanks for reporting. We're not really sure what to do about your problem.
@dalthviz, is there anything we could to prevent this?
I will need to check @ccordoba12.
Maybe for now @xavierricci , as a workaround, you could try to disable Kite from the preferences of Spyder? (if Spyder doesn't start che... | [
{
"body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nI the procedures on the uninstall of kite through the terminal. Then I found the kite folders on my macbook and i send them to trash, but now my spider give me this issue report constantly. \n\ni t... | 4ec0413a1627ed8c897569e8ab06e67195cb8fdd | {
"head_commit": "4eb793abe8bdc5965e7ab7ef9f78c5f59e004b28",
"head_commit_message": "Improve message layout",
"patch_to_review": "diff --git a/spyder/plugins/completion/kite/client.py b/spyder/plugins/completion/kite/client.py\nindex ac99d7c0bdd..39ee7f4b624 100644\n--- a/spyder/plugins/completion/kite/client.py\... | [
{
"diff_hunk": "@@ -170,4 +172,16 @@ def perform_request(self, req_id, method, params):\n converter = getattr(self, converter_name)\n if response is not None:\n response = converter(response)\n- self.sig_response_ready.emit(req_id, response or {})\n+ ... | 41d235829557e0cf4707cc1edc7c54e673b51349 | diff --git a/spyder/plugins/completion/kite/client.py b/spyder/plugins/completion/kite/client.py
index ac99d7c0bdd..01d40508364 100644
--- a/spyder/plugins/completion/kite/client.py
+++ b/spyder/plugins/completion/kite/client.py
@@ -15,10 +15,12 @@
# Third party imports
from qtpy.QtCore import QObject, QThread, Sig... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-13783@a2c0282 | spyder-ide/spyder | Python | 13,783 | PR: Improve folding updates and line displacement on the editor | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2020-09-14T17:25:13Z | Code Folding Occasionally Breaks
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
The problem is that, occasionally, the arrow for code folding collapse and expansion disappears. This renders the code there inaccessible from the editor. The editor still grays out the fun... | Could you please provide a video/animation of this with Licecap?
I will try to do this. I won’t be able to demonstrate the process of it breaking, but I can demonstrate it’s broken state once it happens again.
Sent from my iPhone
> On Jan 20, 2020, at 2:21 PM, Gonzalo Peña-Castellanos <notifications@github.com> wrote... | [
{
"body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nThe problem is that, occasionally, the arrow for code folding collapse and expansion disappears. This renders the code there inaccessible from the editor. The editor still grays out the function na... | 3e7af35baa31975015735544b5f32673c37db841 | {
"head_commit": "a2c02822fc0257615137081e9b1dbf0593689f96",
"head_commit_message": "Fix issues with backspace",
"patch_to_review": "diff --git a/binder/environment.yml b/binder/environment.yml\nindex f86c4f4792a..4862cbfe9e5 100644\n--- a/binder/environment.yml\n+++ b/binder/environment.yml\n@@ -43,6 +43,7 @@ de... | [
{
"diff_hunk": "@@ -36,6 +39,197 @@\n import spyder.utils.icon_manager as ima\n \n \n+class FoldingRegion:\n+ \"\"\"Internal representation of a code folding region.\"\"\"\n+\n+ def __init__(self, text, fold_range):\n+ self.text = text\n+ self.fold_range = fold_range\n+ self.id = str(... | 7adae77f681c5d0f1c8b3479e8da0e33bc1b8d51 | diff --git a/binder/environment.yml b/binder/environment.yml
index d7c84db8496..7d990fd3ea0 100644
--- a/binder/environment.yml
+++ b/binder/environment.yml
@@ -43,6 +43,7 @@ dependencies:
# NOTE: There's no need to set constraints for spyder-kernels here
# because Spyder uses the subrepo for it when started in Binde... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-13359@f38d7c5 | spyder-ide/spyder | Python | 13,359 | PR: Add a "Show in external file browser" shortcut (Editor) | I finally spent the time to (somewhat) figure out how to use git... (a certain john smith accurately [sums up](https://stackoverflow.com/questions/25101983/can-i-revert-commits-directly-on-github#comment73500278_25102008) my feelings on using git as a full time engineer, and occasional programmer)
I also realized I ... | 2020-07-22T20:33:49Z | Feature request: keyboard shortcut for "Show in external file explorer"
**Feature request: keyboard shortcut for "Show in external file explorer"**
I use this feature quite often, and as a fan of keyboard shortcuts it would be very useful. I am using the "win + E" to open explorer all the time on windows, and I beli... | Hi @athompson6735 thanks for the suggestion and trying to implement it! Indeed it could be nice to have a shortcut for that action. Maybe if you want to contribute we could guide you into how that could be done :) what do you guys think @spyder-ide/core-developers ?
I agree that it'd be really nice to have. Thanks @a... | [
{
"body": "**Feature request: keyboard shortcut for \"Show in external file explorer\"**\r\n\r\nI use this feature quite often, and as a fan of keyboard shortcuts it would be very useful. I am using the \"win + E\" to open explorer all the time on windows, and I believe using something like \"Ctrl + E\" makes s... | b12e8a3bc15e83022ea196886454987f417df337 | {
"head_commit": "f38d7c57597d5667c84f51c5a866c9bc63a178f6",
"head_commit_message": "follow pep8 for changes made",
"patch_to_review": "diff --git a/spyder/config/main.py b/spyder/config/main.py\nindex a36456a4205..100d9c294ad 100644\n--- a/spyder/config/main.py\n+++ b/spyder/config/main.py\n@@ -446,6 +446,7 @@\n... | [
{
"diff_hunk": "@@ -515,8 +515,19 @@ def __init__(self, parent, actions):\n text=_(\"Show in Finder\")\r\n else:\r\n text= _(\"Show in external file explorer\")\r\n- external_fileexp_action = create_action(self, text,\r\n- triggered=self.show_i... | 85baf725fdf890c1083dc6a06fe51991a34a44c7 | diff --git a/spyder/config/main.py b/spyder/config/main.py
index a36456a4205..100d9c294ad 100644
--- a/spyder/config/main.py
+++ b/spyder/config/main.py
@@ -446,6 +446,7 @@
'editor/split horizontally': "Ctrl+_",
'editor/close split panel': "Alt+Shift+W",
'editor/docstring'... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
scikit-learn__scikit-learn-10248@5dad472 | scikit-learn/scikit-learn | Python | 10,248 | Deprecate lar positive | #### Reference Issues/PRs
Closes #9837
#### What does this implement/fix? Explain your changes.
Deprecate option posistive=True for Lars model.
#### Any other comments?
it was reported as broken and I could not find an easy bug fix.
I propose to deprecate and suggest to use Lasso model for which it wor... | 2017-12-04T14:27:25Z | Non-negative coefficients with lars
I am running this piece of code
```py
import numpy as np
from sklearn.linear_model import Lars
import sklearn
flag = True
print sklearn.__version__
while flag:
X = np.random.randn(10,5)
Y = np.random.randn(10)
l=Lars(fit_intercept=False, positive=True)
... | thanks for the report. please make this do np.random.seed(i) for iteration
i, and report which i it breaks on so that the issue is easily replicated.
Code snippet
```py
import numpy as np
from sklearn.linear_model import Lars
import sklearn
flag = True
print sklearn.__version__
s = 100
while flag:
np.ra... | [
{
"body": "I am running this piece of code\r\n\r\n```py\r\nimport numpy as np\r\nfrom sklearn.linear_model import Lars\r\nimport sklearn\r\n\r\nflag = True\r\nprint sklearn.__version__\r\nwhile flag:\r\n X = np.random.randn(10,5)\r\n Y = np.random.randn(10)\r\n l=Lars(fit_intercept=False, positive=True... | 7182a43a6fdc19d469b76f43baf413de5b3f0b10 | {
"head_commit": "5dad472245a8de1e2faaf17d3ed6f818fb5156ef",
"head_commit_message": "more docstring updates",
"patch_to_review": "diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst\nindex afd3ed299585b..6cdfcb9196c3e 100644\n--- a/doc/whats_new/v0.20.rst\n+++ b/doc/whats_new/v0.20.rst\n@@ -242,6 +242,... | [
{
"diff_hunk": "@@ -1033,6 +1039,7 @@ class LarsCV(Lars):\n Restrict coefficients to be >= 0. Be aware that you might want to\n remove fit_intercept which is set True by default.\n \n+ The option is deprecated and will be removed in v0.21.",
"line": null,
"original_line": 1042,
... | ab352e8b3e5735271ca98029585ac6d48a97429e | diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst
index afd3ed299585b..6cdfcb9196c3e 100644
--- a/doc/whats_new/v0.20.rst
+++ b/doc/whats_new/v0.20.rst
@@ -242,6 +242,10 @@ Linear, kernelized and related models
underlying implementation is not random.
:issue:`9497` by :user:`Albert Thomas <albertctho... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-13052@7c99b1f | spyder-ide/spyder | Python | 13,052 | PR: Improve error message for loading spydata with missing dependencies | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2020-06-18T04:38:14Z | Improve error message when loading spydata files
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
When trying to load previously saved data, this issue occurs.
### Traceback
```python-traceback
File "/Users/jacob/anaconda/envs/py3/lib/python3.7/site-packages/spyder/p... | It seems you don't have the `geopandas` module installed in your `py3` env. Can you confirm?
Yes.
I had to shift environments between projects. I did that and the issue was
resolved.
On Tue, May 19, 2020 at 2:35 PM Carlos Cordoba <notifications@github.com>
wrote:
> It seems you don't have the geopandas module instal... | [
{
"body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nWhen trying to load previously saved data, this issue occurs. \n\n### Traceback\n```python-traceback\n File \"/Users/jacob/anaconda/envs/py3/lib/python3.7/site-packages/spyder/plugins/variableexpl... | e3a8594ed5804e808d3f528329fee15758125201 | {
"head_commit": "7c99b1f04f39c455922922e9c465223bf95006a8",
"head_commit_message": "Improve error message for loading spydata with missing dependencies",
"patch_to_review": "diff --git a/spyder/plugins/ipythonconsole/widgets/namespacebrowser.py b/spyder/plugins/ipythonconsole/widgets/namespacebrowser.py\nindex 8... | [
{
"diff_hunk": "@@ -137,6 +137,14 @@ def load_data(self, filename, ext):\n blocking=True,\n timeout=CALL_KERNEL_TIMEOUT).load_data(\n filename, ext, overwrite=overwrite)\n+ except ImportError as msg:\n+ module = str(msg).split(\"'\")[1]\n+ ... | b2589ebdf9734c149524b503229766cb0e0a37ec | diff --git a/spyder/plugins/ipythonconsole/widgets/namespacebrowser.py b/spyder/plugins/ipythonconsole/widgets/namespacebrowser.py
index 8637d782f90..0d1e0d2c214 100644
--- a/spyder/plugins/ipythonconsole/widgets/namespacebrowser.py
+++ b/spyder/plugins/ipythonconsole/widgets/namespacebrowser.py
@@ -137,6 +137,14 @@ de... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-13047@55d31da | spyder-ide/spyder | Python | 13,047 | PR: Clear old set shortcuts if they are now empty (Shortcuts) | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2020-06-17T19:08:38Z | Shift+return not working for run selection - no solutions work
## Problem Description
Updated to most recent Spyder version (4.1.3). Wanted to change the "run selection" back to what I was used to in previous version, shift+return. So: preferences > "run selection" > pressed Shift+Return in new shortcut. Apply, Ok.
... | Hi @EvaNewzoo I was able to reproduce this! It seems like changes in shortcuts that are detected as conflicts are not being set correctly if the old shortcut is not set to something else too or you restart Spyder:
. Wanted to change the \"run selection\" back to what I was used to in previous version, shift+return. So: preferences > \"run selection\" > pressed Shift+Return in new shortcut. Apply, Ok. \r\nTried to run a selection with Shift+... | 8be02167e11739fd284b1664eb7c7de9f39df7df | {
"head_commit": "55d31da7d03c8a7a8c56444c2cea9e0a9a75274d",
"head_commit_message": "Shortcuts: Skip empty shortcut test on MacOS",
"patch_to_review": "diff --git a/spyder/app/mainwindow.py b/spyder/app/mainwindow.py\nindex fa7f232ae31..10a7e790582 100644\n--- a/spyder/app/mainwindow.py\n+++ b/spyder/app/mainwind... | [
{
"diff_hunk": "@@ -2421,6 +2421,60 @@ def test_preferences_change_font_regression(main_window, qtbot):\n timeout=5000)\n \n \n+@pytest.mark.slow\n+@pytest.mark.skipif(\n+ sys.platform == 'darwin',\n+ reason=\"Changes of Shitf+Return shortcut cause an ambiguos shortcut\")\n+def test_pr... | f92d72051023bc38bcaa55daa42ced820cf5cce2 | diff --git a/spyder/app/mainwindow.py b/spyder/app/mainwindow.py
index fa7f232ae31..10a7e790582 100644
--- a/spyder/app/mainwindow.py
+++ b/spyder/app/mainwindow.py
@@ -3258,23 +3258,27 @@ def apply_shortcuts(self):
if shortcut_sequence:
keyseq = QKeySequence(shortcut_sequence)
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-10443@f610de4 | scikit-learn/scikit-learn | Python | 10,443 | [MRG] FIX TFIDFVectorizer follow parameter dtype and TFIDFTransformer preserve dtype | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist
-->
#### Reference Issues/PRs
Fixes #10411 #8044
<!--
Example: Fixes #1234. See also #3456.
Please us... | 2018-01-10T04:02:32Z | TfidfVectorizer dtype argument ignored
#### Description
TfidfVectorizer's fit/fit_transform output is always np.float64 instead of the specified dtype
#### Steps/Code to Reproduce
```py
from sklearn.feature_extraction.text import TfidfVectorizer
test = TfidfVectorizer(dtype=np.float32)
print(test.fit_transform(... | Hi, I found the same problem as yours. The cause looks like that TfidfVectorizer uses TfidfTransformer underhood (as _tfidf instance attribute). And when TfidfTransformer tries to fit the training data, it basically does nothing to adhere to what dtype argument specified. It just uses the system default dtype when con... | [
{
"body": "#### Description\r\nTfidfVectorizer's fit/fit_transform output is always np.float64 instead of the specified dtype\r\n\r\n#### Steps/Code to Reproduce\r\n```py\r\nfrom sklearn.feature_extraction.text import TfidfVectorizer\r\ntest = TfidfVectorizer(dtype=np.float32)\r\nprint(test.fit_transform([\"Hel... | 48f3303bfc0be26136b98e9aa95dc3b3f916daff | {
"head_commit": "f610de4e856ddf159ab906b8109e4329ee956b4e",
"head_commit_message": "Added separate test for vectorizer and transformer",
"patch_to_review": "diff --git a/sklearn/feature_extraction/tests/test_text.py b/sklearn/feature_extraction/tests/test_text.py\nindex ff13cd6e00179..a42fe2bdd5b8b 100644\n--- a... | [
{
"diff_hunk": "@@ -995,3 +998,34 @@ def test_vectorizer_string_object_as_input():\n ValueError, message, vec.fit, \"hello world!\")\n assert_raise_message(\n ValueError, message, vec.transform, \"hello world!\")\n+\n+\n+@pytest.mark.parametrize(\"dtype\", [\n+ np.float32,\n+ ... | 428442f2db22b34663671afa16098ab66dcd76d9 | diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst
index 13de05ada8369..eb2eb22a5651f 100644
--- a/doc/whats_new/v0.20.rst
+++ b/doc/whats_new/v0.20.rst
@@ -448,6 +448,13 @@ Feature Extraction
(words or n-grams). :issue:`9147` by :user:`Claes-Fredrik Mannby <mannby>`
and `Roman Yurchak`_.
+- Fixed b... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-10331@c6a9325 | scikit-learn/scikit-learn | Python | 10,331 | [MRG+2] default gamma='auto' in SVC | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist
-->
#### Reference Issues/PRs
Fixes #8361
Fixes #8535
<!--
Example: Fixes #1234. See also #3456.
... | 2017-12-16T09:30:22Z | gamma="auto" in SVC
It's a bit unfortunate that we just changed the parametrization of ``SVC``'s ``gamma`` (from 0 to ``"auto"``), but I just realized that using ``1 / (n_features * X.std())`` would be a much much better default than the current ``1 / n_features``.
Not sure there's a good way to change it though.
... | Agreed on every sentence of this issue (including the last one :( ).
'auto-scale'
On 16 February 2017 at 02:18, Gael Varoquaux <notifications@github.com>
wrote:
> Agreed on every sentence of this issue (including the last one :( ).
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to ... | [
{
"body": "It's a bit unfortunate that we just changed the parametrization of ``SVC``'s ``gamma`` (from 0 to ``\"auto\"``), but I just realized that using ``1 / (n_features * X.std())`` would be a much much better default than the current ``1 / n_features``.\r\n\r\nNot sure there's a good way to change it thoug... | 61e6f502956d6e49bfab342d7a5b8d8eab45a2ad | {
"head_commit": "c6a9325872630be357f6a497ca70587e110ed12d",
"head_commit_message": "fix pycodestyle errors",
"patch_to_review": "diff --git a/doc/modules/cross_validation.rst b/doc/modules/cross_validation.rst\nindex c68bb7ef275b0..c6bc42f6e3783 100644\n--- a/doc/modules/cross_validation.rst\n+++ b/doc/modules/c... | [
{
"diff_hunk": "@@ -975,3 +980,22 @@ def test_ovr_decision_function():\n # Test if the first point has lower decision value on every quadrant\n # compared to the second point\n assert_true(np.all(pred_class_deci_val[:, 0] < pred_class_deci_val[:, 1]))\n+\n+\n+def test_gamma_auto():\n+ X, y = [[0.... | e4a9a37b0a056dcd7ce1cd7808b66592b35332d7 | diff --git a/doc/modules/ensemble.rst b/doc/modules/ensemble.rst
index ef46d5a3fe5f1..32f49dd77d3bf 100644
--- a/doc/modules/ensemble.rst
+++ b/doc/modules/ensemble.rst
@@ -1029,7 +1029,7 @@ Vector Machine, a Decision Tree, and a K-nearest neighbor classifier::
>>> # Training classifiers
>>> clf1 = DecisionTree... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
spyder-ide__spyder-13040@39f8603 | spyder-ide/spyder | Python | 13,040 | PR: Fix ValueError when an untitled file is open in the editor | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2020-06-16T16:54:37Z | Open new file causes an error
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
Press the new file icon causes an error Causes an error?
### Traceback
```python-traceback
File "C:\Users\pchri\Anaconda3\envs\ztdl7\lib\site-packages\spyder\plugins\editor\plugin.py", line... | Hi @pchristian4481, thanks for reporting this issue. It seems that would happen if your filename contains `untitled` somewhere in its name, is it the case?
@steff456, it may be possible that filenames that contain `untitled` and not a number at the end, may be wrongly parsed by this instruction, could you please take a... | [
{
"body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nPress the new file icon causes an error Causes an error?\n\n### Traceback\n```python-traceback\n File \"C:\\Users\\pchri\\Anaconda3\\envs\\ztdl7\\lib\\site-packages\\spyder\\plugins\\editor\\plugi... | 4eb1389ee11b55f3b4a6c6c948cf33aad6c1437f | {
"head_commit": "39f8603cc8b2375c2ae67dd19770641e9ab32262",
"head_commit_message": "catch value error in the untitled number definition",
"patch_to_review": "diff --git a/spyder/plugins/editor/plugin.py b/spyder/plugins/editor/plugin.py\nindex bde35cb6ef4..f1ebf819e67 100644\n--- a/spyder/plugins/editor/plugin.p... | [
{
"diff_hunk": "@@ -1796,9 +1796,15 @@ def new(self, fname=None, editorstack=None, text=None):\n # to this number if there's other untitled file in\r\n # spyder. Please see spyder-ide/spyder#7831\r\n fname_data = osp.splitext(current_filena... | d381860ef9a49a290045ca4f3b7a8d6073c40cae | diff --git a/spyder/plugins/editor/plugin.py b/spyder/plugins/editor/plugin.py
index bde35cb6ef4..5396277668d 100644
--- a/spyder/plugins/editor/plugin.py
+++ b/spyder/plugins/editor/plugin.py
@@ -1796,9 +1796,16 @@ def new(self, fname=None, editorstack=None, text=None):
# to this number if the... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-12985@919bd45 | spyder-ide/spyder | Python | 12,985 | PR: Add message when the debug mode is on and the file cannot be closed | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2020-06-09T20:27:05Z | Can't close any editor tab when in debug mode
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
Tabs can't be closed when code is run in debug mode.
## Versions
* Spyder version: 4.1.3
* Python version: 3.7.7
* Qt version: 5.9.6
* PyQt5 version: 5.9.2
* Operating Sys... | @ma-sadeghi thanks for your report.
Could you please post an animations using https://www.cockos.com/licecap/ or similar to better understand the current issue.
Thanks!
@goanpeca There you go:

This is done by design in order to prevent that a console goes out of sync with ... | [
{
"body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nTabs can't be closed when code is run in debug mode.\n\n\n\n## Versions\n\n* Spyder version: 4.1.3 \n* Python version: 3.7.7\n* Qt version: 5.9.6\n* PyQt5 version: 5.9.2\n* Operating System: Linux ... | e91532cfa227b73943b39acb067ad8388f2b8c3d | {
"head_commit": "919bd452e5dc2bde27e8fa64e1756d9b19cc96b1",
"head_commit_message": "add message when the debug mode is on and the file cannot be closed",
"patch_to_review": "diff --git a/spyder/plugins/editor/plugin.py b/spyder/plugins/editor/plugin.py\nindex 08cad25483f..a11fba4b119 100644\n--- a/spyder/plugins... | [
{
"diff_hunk": "@@ -85,6 +85,7 @@ class Editor(SpyderPluginWidget):\n breakpoints_saved = Signal()\r\n run_in_current_extconsole = Signal(str, str, str, bool, bool)\r\n open_file_update = Signal(str)\r\n+ debugging_file_msg = Signal()\r",
"line": null,
"original_line": 88,
"original_s... | fb86245d98d93bd68a3beb3fa2c97c176f2beff7 | diff --git a/spyder/plugins/editor/plugin.py b/spyder/plugins/editor/plugin.py
index 08cad25483f..4313aeaf3c6 100644
--- a/spyder/plugins/editor/plugin.py
+++ b/spyder/plugins/editor/plugin.py
@@ -85,6 +85,7 @@ class Editor(SpyderPluginWidget):
breakpoints_saved = Signal()
run_in_current_extconsole = Signal(... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-12937@b4300c7 | spyder-ide/spyder | Python | 12,937 | PR: Enable/disable folding guides when cursor enters/exits the left panel | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2020-06-02T19:48:06Z | Restore code folding for large files
In order to do that we need to do the following:
* Only draw and update the folding panel when the user moves the cursor over it.
* Only draw the visible region in the editor (although that's probably not so necessary if we draw the panel on demand).
@andfoy, please take a lo... | [
{
"body": "In order to do that we need to do the following:\r\n\r\n* Only draw and update the folding panel when the user moves the cursor over it.\r\n* Only draw the visible region in the editor (although that's probably not so necessary if we draw the panel on demand).\r\n\r\n@andfoy, please take a look at th... | e91532cfa227b73943b39acb067ad8388f2b8c3d | {
"head_commit": "b4300c77f7bc3bf4b5ff91b82d7146ec8ab3f753",
"head_commit_message": "Fix style issues",
"patch_to_review": "diff --git a/spyder/plugins/editor/panels/codefolding.py b/spyder/plugins/editor/panels/codefolding.py\nindex 58ffb823442..ef252387cd3 100644\n--- a/spyder/plugins/editor/panels/codefolding.... | [
{
"diff_hunk": "@@ -248,6 +250,28 @@ def paintEvent(self, event):\n # on the folding panel.\n super(FoldingPanel, self).paintEvent(event)\n painter = QPainter(self)\n+ if not self._display_folding and not self._key_pressed:\n+ if any(self.folding_status.values()):\n+ ... | bc4965cddd6fd558bd737792d20fc5bdfc4a2a37 | diff --git a/spyder/plugins/editor/panels/codefolding.py b/spyder/plugins/editor/panels/codefolding.py
index 58ffb823442..96aac537deb 100644
--- a/spyder/plugins/editor/panels/codefolding.py
+++ b/spyder/plugins/editor/panels/codefolding.py
@@ -168,6 +168,8 @@ def __init__(self, highlight_caret_scope=False):
s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
scikit-learn__scikit-learn-10110@9182671 | scikit-learn/scikit-learn | Python | 10,110 | [MRG+1] Error raised when presort in gradient_boosting.py and tree.py is not a boolean | Fixes #10107
What does this change do?
When "presort" , a parameter in GradientboostingClassifier and GradientboostingRegressor is not a boolean, ValueError is now raised. Which wasn't the case before
Which fixes the above issue. | 2017-11-11T11:32:28Z | Add a test for invalid presort in GradientBoosting{Classifier,Regressor}
This should raise a ValueError and does not:
```py
from sklearn.ensemble import GradientBoostingClassifier
GradientBoostingClassifier(presort='invalid').fit([[1., 2.], [1., 1.]], [0, 1])
```
This should be enough to add the presort argument... | Can I work on this if anyone else has not already started working on it?
Go for it I recommend reading
our [contribution guidelines](https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md). https://opensource.guide/how-to-contribute/ is a great resource on contributing to open-source in general.
Th... | [
{
"body": "This should raise a ValueError and does not:\r\n```py\r\nfrom sklearn.ensemble import GradientBoostingClassifier\r\nGradientBoostingClassifier(presort='invalid').fit([[1., 2.], [1., 1.]], [0, 1])\r\n```\r\n\r\nThis should be enough to add the presort argument checking in BaseGradientBoosting._check_p... | 0885d22a250bc49a5553518d69b47cbe0720a95d | {
"head_commit": "918267118be1fa0ebe9ba9279df8f91fa288ccb7",
"head_commit_message": "pep8 fix 3",
"patch_to_review": "diff --git a/sklearn/ensemble/gradient_boosting.py b/sklearn/ensemble/gradient_boosting.py\nindex 2c155f11c6282..1bdd72b95a955 100644\n--- a/sklearn/ensemble/gradient_boosting.py\n+++ b/sklearn/en... | [
{
"diff_hunk": "@@ -158,6 +164,14 @@ def test_regressor_parameter_checks():\n \" or an integer. 'invalid' was passed\",\n GradientBoostingRegressor(n_iter_no_change='invalid')\n .fit, X, y)\n+ assert_raise_message(ValueError, \"Presor... | adcf5ffae9a6ca024ffe32215b5695ac9a4f20df | diff --git a/sklearn/ensemble/gradient_boosting.py b/sklearn/ensemble/gradient_boosting.py
index 2c155f11c6282..2da210348ca92 100644
--- a/sklearn/ensemble/gradient_boosting.py
+++ b/sklearn/ensemble/gradient_boosting.py
@@ -887,6 +887,11 @@ def _check_params(self):
"integer. %r was passed... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} |
scikit-learn__scikit-learn-10099@33f7ffa | scikit-learn/scikit-learn | Python | 10,099 | [MRG+1] Warning in KMeans if too few clusters were found | #### Reference Issues/PRs
Fixes #10059
#### What does this implement/fix? Explain your changes.
Gives a warning if the number of distinct cluster centers found is smaller than the number of expected clusters (given by ```n_clusters```).
Added a test, where exactly this behaviour can be seen and check whether ... | 2017-11-09T20:26:50Z | Duplicated input points silently create duplicated clusters in KMeans
#### Description
When there are duplicated input points to Kmeans resulting to number of unique points < number of requested clusters, there is no error thrown. Instead, clustering continues to (seemingly) produce the number of clusters requested, b... | Is this what you should expect for such a small dataset? Are there standard
ways to avoid duplicate centroids in KMeans?
Though not nice, this is actually, what MacQueen wrote in his paper and thus it _could_ be considered _expected_ behaviour.
(MacQueen, 1967, Some Methods for Classification and Analysis of Multiv... | [
{
"body": "#### Description\r\nWhen there are duplicated input points to Kmeans resulting to number of unique points < number of requested clusters, there is no error thrown. Instead, clustering continues to (seemingly) produce the number of clusters requested, but some of them are exactly the same, so the clus... | effd75dda5f4afa61f988035ff8fe4b3a447464e | {
"head_commit": "33f7ffaf5af4975f6a3d7de8de0c06944d06eff9",
"head_commit_message": "unnecessary comment",
"patch_to_review": "diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst\nindex 5af76499bcb39..73cf84a56de9a 100644\n--- a/doc/whats_new/v0.20.rst\n+++ b/doc/whats_new/v0.20.rst\n@@ -134,6 +134,11 ... | [
{
"diff_hunk": "@@ -374,6 +374,10 @@ def k_means(X, n_clusters, init='k-means++', precompute_distances='auto',\n X += X_mean\n best_centers += X_mean\n \n+ if len(set(best_labels)) < n_clusters:\n+ warnings.warn(\"number of distinct clusters found smaller than n_clusters. \"",
... | 507cc4d6e90fe51e5ad9f3a81ac56a64f4cc3ac1 | diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst
index 5af76499bcb39..de047f79a1924 100644
--- a/doc/whats_new/v0.20.rst
+++ b/doc/whats_new/v0.20.rst
@@ -134,6 +134,11 @@ Decomposition, manifold learning and clustering
- Fixed a bug when setting parameters on meta-estimator, involving both a
wrapped ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-10102@d32584d | scikit-learn/scikit-learn | Python | 10,102 | [MRG+1] FIX convert to CSR in decision_function | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist
-->
#### Reference Issues/PRs
<!--
Example: Fixes #1234. See also #3456.
Please use keywords (e.g., Fi... | 2017-11-09T23:04:06Z | GradientBoostingClassifier: sparse data and warmstarting do not work together
#### Description
Using warmstarting and sparse data for gradient boosting do not work together.
#### Steps/Code to Reproduce
```
import numpy as np
import scipy.sparse
import sklearn.datasets
import sklearn.ensemble
def get_data... | What's the difference between your expected and actual results?
My bad, there was none in the snippet I pasted here. I fixed the snippet. That's what the script results in:
```
<class 'numpy.ndarray'>
Fitted dense data
<class 'scipy.sparse.csc.csc_matrix'>
```
vs what I expect:
```
<class 'numpy.ndarray'>
Fitt... | [
{
"body": "#### Description\r\nUsing warmstarting and sparse data for gradient boosting do not work together.\r\n\r\n#### Steps/Code to Reproduce\r\n```\r\nimport numpy as np\r\nimport scipy.sparse\r\nimport sklearn.datasets\r\nimport sklearn.ensemble\r\n\r\n\r\ndef get_dataset(dataset='iris', make_sparse=False... | 9808810028f5358c53c474c223545a0b7ae82b71 | {
"head_commit": "d32584d0b8748224019dd5c353d85e04664d4dda",
"head_commit_message": "address joels comments",
"patch_to_review": "diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst\nindex 9f3e755573ce6..20990f68add51 100644\n--- a/doc/whats_new/v0.20.rst\n+++ b/doc/whats_new/v0.20.rst\n@@ -185,6 +185,... | [
{
"diff_hunk": "@@ -203,6 +203,7 @@ def predict_stages(np.ndarray[object, ndim=2] estimators,\n cdef Tree tree\n \n if issparse(X):\n+ assert X.format == 'csr'",
"line": null,
"original_line": 206,
"original_start_line": null,
"path": "sklearn/ensemble/_gradient_boosting.pyx",
... | d168ebbb40a06e79d15049b7175f7efc7042aeb6 | diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst
index 9f3e755573ce6..74c601a9df115 100644
--- a/doc/whats_new/v0.20.rst
+++ b/doc/whats_new/v0.20.rst
@@ -146,6 +146,13 @@ Classifiers and regressors
updated estimates for the standard deviation and the coefficients.
:issue:`10153` by :user:`Jörg Döpf... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-12710@f0e55aa | spyder-ide/spyder | Python | 12,710 | PR: Fix showing/hiding completions when backspace is pressed | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2020-05-13T05:24:45Z | Deleting space before a word trigger meaningless completion
Hi spyder devs,
I've find a new way of improving the completion:
## Problem Description
Deleting space before a word trigger meaningless completion.
### What steps reproduce the problem?
1. In a new document type `None`;
2. add a space before it;
... | The same problem, when real-time code completion is available
Hi @ElieGouzien and @leavor,
We are going to fix this for spyder 4.1.4 release. Thanks for reporting! | [
{
"body": "Hi spyder devs,\r\nI've find a new way of improving the completion:\r\n\r\n## Problem Description\r\nDeleting space before a word trigger meaningless completion.\r\n\r\n### What steps reproduce the problem?\r\n\r\n1. In a new document type `None`;\r\n2. add a space before it;\r\n3. remove this space.... | c615ae325ce5afdb8f4d14ad7db28af47fee37f1 | {
"head_commit": "f0e55aa3c8688bd058e7b39b7208b814ad3fbd64",
"head_commit_message": "add counter to backspace and check if the text is not empty before showing completions",
"patch_to_review": "diff --git a/spyder/plugins/editor/widgets/codeeditor.py b/spyder/plugins/editor/widgets/codeeditor.py\nindex 91f8dcde59... | [
{
"diff_hunk": "@@ -4067,8 +4074,10 @@ def _handle_completions(self):\n \r\n self.document_did_change(text)\r\n \r\n+ is_backspace = (\r\n+ self._count_backspace >= self.automatic_completions_after_chars)\r",
"line": null,
"original_line": 4078,
"original_start_line": null,... | c53787d4e9006073742c2a625ce68e4aa37a848a | diff --git a/spyder/plugins/editor/widgets/codeeditor.py b/spyder/plugins/editor/widgets/codeeditor.py
index 2096a0128f3..efbb3a2dc0f 100644
--- a/spyder/plugins/editor/widgets/codeeditor.py
+++ b/spyder/plugins/editor/widgets/codeeditor.py
@@ -4072,6 +4072,16 @@ def _handle_completions(self):
self._la... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-10045@9ce24e4 | scikit-learn/scikit-learn | Python | 10,045 | [MRG+2] make_circles() now works with odd number of samples, test added | #### Reference Issues/PRs
Fixes #10037 and adds corresponding tests
#### What does this implement/fix? Explain your changes.
Fixes he faulty behaviour of ```make_circles``` when ```n_samples``` is an odd number.
Adds test ```test_make_circles``` to ```datasets/tests/test_samples_generator.py```.
#### Any other... | 2017-10-31T10:00:44Z | make_circles always generates an even number of samples
#### Description
<!-- Example: Joblib Error thrown when calling fit on LatentDirichletAllocation with evaluate_every > 0-->
```sklearn.datasets.make_circles``` always generates an even number of samples, even when specifically asked for an uneven number.
####... | Thanks for opening the issue. I can confirm this. Also `make_circles` doesn't seem to have any specific unit tests. It is always called with an even `n_samples` in the existing scikit-learn code base.
A pull request to fix this issue (and add some unit tests) would be welcome..
My bad!
@rth Where would I place the ... | [
{
"body": "#### Description\r\n<!-- Example: Joblib Error thrown when calling fit on LatentDirichletAllocation with evaluate_every > 0-->\r\n```sklearn.datasets.make_circles``` always generates an even number of samples, even when specifically asked for an uneven number.\r\n\r\n#### Steps/Code to Reproduce\r\nE... | 9172a5905d4046cfab3dcc693d1093855c8d79fe | {
"head_commit": "9ce24e47fdc528cd650fbe017ecbc5fc4658d8ca",
"head_commit_message": "added entry under \"Decomposition, ...\" as another datasets-related bug was already mentioned in there.",
"patch_to_review": "diff --git a/doc/whats_new/_contributors.rst b/doc/whats_new/_contributors.rst\nindex dfbc319da88f4..3... | [
{
"diff_hunk": "@@ -141,3 +141,5 @@\n .. _Neeraj Gangwar: http://neerajgangwar.in\n \n .. _Arthur Mensch: https://amensch.fr\n+\n+.. _Christian Braune: https://github.com/christianbraune79",
"line": null,
"original_line": 145,
"original_start_line": null,
"path": "doc/whats_new/_contributors.rst... | e19cecc2f994081e6c9e5b9521e53ad125eee6db | diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst
index 5af76499bcb39..a8eca8190bdf6 100644
--- a/doc/whats_new/v0.20.rst
+++ b/doc/whats_new/v0.20.rst
@@ -135,6 +135,10 @@ Decomposition, manifold learning and clustering
wrapped estimator and its parameter. :issue:`9999` by :user:`Marcus Voss
<marcus... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-14314@8215490 | spyder-ide/spyder | Python | 14,314 | PR: Migrate completion plugin to the new API | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2020-11-25T20:28:56Z | Move Completion plugin to use new API
- [ ] Refactor plugins to use the standard plugin API
- [ ] Add a extension manager for extensions
- [ ] Make sure tests pass
- [ ] Move to new API | [
{
"body": "- [ ] Refactor plugins to use the standard plugin API\r\n- [ ] Add a extension manager for extensions\r\n- [ ] Make sure tests pass\r\n- [ ] Move to new API",
"number": 12192,
"title": "Move Completion plugin to use new API"
}
] | 670613c985f9791a6492ba6f9c71338705655229 | {
"head_commit": "82154901e3d4b22b7448247c4acaf2388adae81a",
"head_commit_message": "Add status bar",
"patch_to_review": "diff --git a/bootstrap.py b/bootstrap.py\nindex 2a3af4a2169..24d92895b57 100755\n--- a/bootstrap.py\n+++ b/bootstrap.py\n@@ -24,6 +24,7 @@\n import argparse\n import os\n import os.path as osp... | [
{
"diff_hunk": "@@ -120,3 +150,16 @@ def setup_page(self):\n self.setLayout(layout)\n \"\"\"\n raise NotImplementedError\n+\n+ def apply_settings(self) -> OptionSet:\n+ \"\"\"\n+ Hook called to manually apply settings that cannot be automatically\n+ applied manual... | ced74e2c5a7ff2e388b73d4aee158083713d13c4 | diff --git a/.github/workflows/test-linux.yml b/.github/workflows/test-linux.yml
index 41cbe0829ea..7672ae27413 100644
--- a/.github/workflows/test-linux.yml
+++ b/.github/workflows/test-linux.yml
@@ -117,3 +117,7 @@ jobs:
if: env.RUN_BUILD == 'true'
shell: bash -l {0}
run: codecov
+ # E... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
scikit-learn__scikit-learn-9945@3497f8c | scikit-learn/scikit-learn | Python | 9,945 | [MRG+1] fix _BaseComposition._set_params with nested parameters | Fixes #9944.
This seemed the simplest fix.
This kind of means that the protection in ``_BaseComposition._set_params`` is not enough.
We could make that method work by grouping the things in ``BaseEstimator.set_params`` according to their prefixes and call ``set_params`` only once per prefix. That seems like a sl... | 2017-10-17T21:12:50Z | Pipeline in Pipeline seems to not work well with setting of parameters using `.set_params`
#### Description
Using Pipeline in Pipeline in GridSearchCV fails sometimes at random. Use a snippet of code below to reproduce (fails ~50% of the time).
#### Steps/Code to Reproduce
```python
from sklearn.datasets import ... | Lol I was trying to reproduce and couldn't, and I think I know why. I'm using Python3.6 where all dicts are ordered.
I think we need to make the iteration ordered in BaseEstimator.set_params, that should fix it.
Yup can confirm, works fine with python3.6 :)
also: good catch! Btw, do you want a job?
As the author of `... | [
{
"body": "#### Description\r\nUsing Pipeline in Pipeline in GridSearchCV fails sometimes at random. Use a snippet of code below to reproduce (fails ~50% of the time). \r\n\r\n#### Steps/Code to Reproduce\r\n```python\r\nfrom sklearn.datasets import load_diabetes\r\nfrom sklearn.model_selection import train_tes... | 766ba9320878ecc854edfa37988aa09096ad4adb | {
"head_commit": "3497f8cbd4dd081d0ebbf8c0943628e5b4c114fa",
"head_commit_message": "Unify error messages\n\nYou can't determine even local parameters with only class name",
"patch_to_review": "diff --git a/sklearn/base.py b/sklearn/base.py\nindex d97fe92ccdd47..b653b7149c373 100644\n--- a/sklearn/base.py\n+++ b/... | [
{
"diff_hunk": "@@ -863,6 +864,20 @@ def test_step_name_validation():\n [[1]], [1])\n \n \n+def test_set_conditional_params():\n+ estimator = Pipeline([\n+ ('a', Pipeline([\n+ ('b', DummyRegressor())\n+ ]))\n+ ])\n+ params = {",
"line": null... | 5c308d59ed18d24bf06443ec6a7e42d2331475aa | diff --git a/sklearn/base.py b/sklearn/base.py
index d97fe92ccdd47..b653b7149c373 100644
--- a/sklearn/base.py
+++ b/sklearn/base.py
@@ -5,6 +5,7 @@
import copy
import warnings
+from collections import defaultdict
import numpy as np
from scipy import sparse
@@ -248,26 +249,24 @@ def set_params(self, **params):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-11815@e198745 | spyder-ide/spyder | Python | 11,815 | PR: Update Breakpoints plugin to Python 3 | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2020-03-16T22:21:46Z | Move breakpoints plugin to python3 only
Take into account the following:
- [ ] Update `super()` use
- [ ] Remove the `py3compat` module
- [ ] Update any code (and remove if necessary) that uses `if PY2` etc...
- [ ] Check division operator
- [ ] Remove future imports
- [ ] Check tests
- [ ] Check for Py2 of Py... | https://github.com/spyder-ide/spyder/blob/master/spyder/plugins/breakpoints/widgets/breakpointsgui.py#L53
`QAbstractTableModel.__init__(self, parent)` ->
`super().__init__(parent)` | [
{
"body": "Take into account the following:\r\n\r\n- [ ] Update `super()` use\r\n- [ ] Remove the `py3compat` module\r\n- [ ] Update any code (and remove if necessary) that uses `if PY2` etc...\r\n- [ ] Check division operator\r\n- [ ] Remove future imports\r\n- [ ] Check tests\r\n- [ ] Check for Py2 of Py3 cod... | a072dd12b86ff17daa20a43547e553114fc324ed | {
"head_commit": "e1987453c60f32ce99993e1aa86efa4fe3d88c05",
"head_commit_message": "remove pyside code and fix style issues",
"patch_to_review": "diff --git a/spyder/plugins/breakpoints/plugin.py b/spyder/plugins/breakpoints/plugin.py\nindex 57fa80d2a1c..e9a42230156 100644\n--- a/spyder/plugins/breakpoints/plugi... | [
{
"diff_hunk": "@@ -74,7 +74,7 @@ def on_first_registration(self):\n def register_plugin(self):\r\n \"\"\"Register plugin in Spyder's main window\"\"\"\r\n self.breakpoints.edit_goto.connect(self.main.editor.load)\r\n- #self.redirect_stdio.connect(self.main.redirect_internalshell_stdi... | cb17afccca6b89607d962dbbdf6431bdb4f06bc0 | diff --git a/spyder/plugins/breakpoints/plugin.py b/spyder/plugins/breakpoints/plugin.py
index 57fa80d2a1c..47a97b77440 100644
--- a/spyder/plugins/breakpoints/plugin.py
+++ b/spyder/plugins/breakpoints/plugin.py
@@ -37,7 +37,7 @@ class Breakpoints(SpyderPluginWidget):
def __init__(self, parent=None):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
spyder-ide__spyder-11472@578aa4e | spyder-ide/spyder | Python | 11,472 | PR: Avoid Python destroying Qt window and causing segfault | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2020-02-04T16:27:19Z | Segmentation fault when closing an undocked plugin
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
The crash happened while trying to close an undocked plugin (Outline explorer)
### Traceback
C traceback
```
Thread 0 Crashed:: ZMQbg/5 Dispatch queue: com.ap... | @goanpeca, are you able to reproduce this one in macOS?
No, closing the outline explorer closes the window and redocks it
<img width="715" alt="Screen Shot 2019-11-25 at 14 27 50" src="https://user-images.githubusercontent.com/3627835/69578711-0c5f2480-0f9f-11ea-9d33-cba5de42e1fb.png">
I could reproduce on two dif... | [
{
"body": "## Description\r\n\r\n### What steps will reproduce the problem?\r\n\r\n<!--- You can use Markdown here --->\r\n\r\nThe crash happened while trying to close an undocked plugin (Outline explorer)\r\n\r\n### Traceback\r\nC traceback\r\n```\r\nThread 0 Crashed:: ZMQbg/5 Dispatch queue: com.apple.main-t... | a3d7207225e5f5d218eb8f130ac8009995414741 | {
"head_commit": "578aa4e8c9419b12a8e379c91fef0d2c384b230c",
"head_commit_message": "Avoid python destroying qt object",
"patch_to_review": "diff --git a/spyder/plugins/base.py b/spyder/plugins/base.py\nindex cf1e5bf37f4..599cbcf729a 100644\n--- a/spyder/plugins/base.py\n+++ b/spyder/plugins/base.py\n@@ -136,6 +1... | [
{
"diff_hunk": "@@ -136,6 +136,10 @@ def closeEvent(self, event):\n self.plugin.dockwidget.setVisible(True)\n self.plugin.switch_to_plugin()\n QMainWindow.closeEvent(self, event)\n+ # Qt might want to do something with this soon,\n+ # So it should not be deleted by python y... | 73d1a7b10b233b39ffac2da712a41b5f62e5c238 | diff --git a/spyder/plugins/base.py b/spyder/plugins/base.py
index cf1e5bf37f4..2dddcf8d241 100644
--- a/spyder/plugins/base.py
+++ b/spyder/plugins/base.py
@@ -136,6 +136,10 @@ def closeEvent(self, event):
self.plugin.dockwidget.setVisible(True)
self.plugin.switch_to_plugin()
QMainWindow.clo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-11708@0ab0410 | spyder-ide/spyder | Python | 11,708 | PR: Make pylint plugin find most local .pylintrc to given file and set cwd correctly | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2020-03-03T11:42:35Z | Static Code Analysis Not Reading .pylintrc file
I have a .pylintrc file in the Spyder project directory and in the file directory (it is located in a subdirectory). It has the following line in the [MASTER] block:
extension-pkg-whitelist=numpy
It also has the following lines in the [TYPECHECK] block:
ignored-mod... | Sorry, at the moment we don't read the contents `.pylintrc` when running Pylint inside Spyder.
You're welcome to send us a pull request to provide this functionality.
I've been able to do this just fine on a per-user basis on Windows by just editing the .pylintrc file in my user folder (`/Users/username/,pylintrc`).... | [
{
"body": "I have a .pylintrc file in the Spyder project directory and in the file directory (it is located in a subdirectory). It has the following line in the [MASTER] block:\r\n\r\nextension-pkg-whitelist=numpy\r\n\r\nIt also has the following lines in the [TYPECHECK] block:\r\nignored-modules=numpy\r\nignor... | e7b29d9c87febda78dbd60ec78a069c22f272650 | {
"head_commit": "0ab041033dd22bf1a1b26167c515c0f8859c8839",
"head_commit_message": "Skip new pylint test on PY2 and other tweaks for reliable CIs",
"patch_to_review": "diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py\nindex ffabecd7f5f..9e7618395f8 100644\n--- a/spyder/app/t... | [
{
"diff_hunk": "@@ -44,6 +46,31 @@\n import gettext\r\n _ = gettext.gettext\r\n \r\n+\r\n+def _find_pylintrc_path(path):\r",
"line": null,
"original_line": 50,
"original_start_line": null,
"path": "spyder/plugins/pylint/widgets/pylintgui.py",
"start_line": null,
"text": "@user2:\... | 8aee458b6fdd38ff9a6fa8237bebefa53054bd71 | diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py
index ffabecd7f5f..9e7618395f8 100644
--- a/spyder/app/tests/test_mainwindow.py
+++ b/spyder/app/tests/test_mainwindow.py
@@ -2996,8 +2996,9 @@ def test_runcell_after_restart(main_window, qtbot):
# Make sure no errors are shown
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Style, Linting, Formatting Fixes"
} |
scikit-learn__scikit-learn-9802@5c7da54 | scikit-learn/scikit-learn | Python | 9,802 | [MRG+1]: avoid FutureWarning in BaseSGD.set_params | #### Reference Issue
Fixes #9752
#### What does this implement/fix? Explain your changes.
Adds a set_future_warning flag in BaseSGD to help avoid FutureWarnings
in uses of __init__ or set_params. | 2017-09-19T18:22:44Z | BaseSGD should not warn quite so often
Because of some strange legacy validation in __init__ (and set_params) as well as in fit and partial_fit (probably excessive in any case), the FutureWarning in BaseSGD is repeated when warn='always' is used. The FutureWarning should only be issued in uses of `fit` and `partial_fit... | Would removing self._validate_params() from __init__ and set_params solve this issue?
well it would, but with side effects that would result in tests failing
On 13 Sep 2017 10:35 pm, "Vrishank Bhardwaj" <notifications@github.com>
wrote:
> Would removing self._validate_params() from *init* and set_params solve
> this ... | [
{
"body": "Because of some strange legacy validation in __init__ (and set_params) as well as in fit and partial_fit (probably excessive in any case), the FutureWarning in BaseSGD is repeated when warn='always' is used. The FutureWarning should only be issued in uses of `fit` and `partial_fit`, and not during `_... | 3cfd1faf610e61f3572597992d4b03b3d98a3ad2 | {
"head_commit": "5c7da543c047666c3674f453834d39e7a6670149",
"head_commit_message": "Update stochastic_gradient.py",
"patch_to_review": "diff --git a/sklearn/linear_model/stochastic_gradient.py b/sklearn/linear_model/stochastic_gradient.py\nindex 4a6e6831edf44..18021a7a1ed84 100644\n--- a/sklearn/linear_model/sto... | [
{
"diff_hunk": "@@ -50,7 +50,7 @@ def __init__(self, loss, penalty='l2', alpha=0.0001, C=1.0,\n l1_ratio=0.15, fit_intercept=True, max_iter=None, tol=None,\n shuffle=True, verbose=0, epsilon=0.1, random_state=None,\n learning_rate=\"optimal\", eta0=0.0, power_t... | e5fc0f8173268967f78359bbe23c3e3778701941 | diff --git a/sklearn/linear_model/stochastic_gradient.py b/sklearn/linear_model/stochastic_gradient.py
index 4a6e6831edf44..2641e3b58a1a4 100644
--- a/sklearn/linear_model/stochastic_gradient.py
+++ b/sklearn/linear_model/stochastic_gradient.py
@@ -75,7 +75,7 @@ def __init__(self, loss, penalty='l2', alpha=0.0001, C=1.... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-10755@3f9b525 | spyder-ide/spyder | Python | 10,755 | PR: Fix link handling and pydoc numpy related import for Online Help | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-11-19T02:29:37Z | Online help index contains invalid links
## Description
**What steps will reproduce the problem?**
1. Select Online Help
2. From the "pinky" index page select any topic or link
3. "Unable to load page" is displayed and "lank" is inserted in Module or Package text box
**What is the expected output? What do yo... | Sorry, this is not a Spyder issue. The only thing we do is to render what the `pydoc` module provides.
@ccordoba12 I'm seeing this as well; the issue isn't necessarily "invalid internal links" but that clicking any link, on any page, doesn't work and produces the text ``lank`` in the search bar while entering the name ... | [
{
"body": "## Description\r\n\r\n**What steps will reproduce the problem?**\r\n\r\n1. Select Online Help\r\n2. From the \"pinky\" index page select any topic or link\r\n3. \"Unable to load page\" is displayed and \"lank\" is inserted in Module or Package text box\r\n\r\n**What is the expected output? What do yo... | 06af61cbeb03e0be718ebf3750989e2d29c3c8ae | {
"head_commit": "3f9b525b0c5910ceaab1b12f3f5025e3c744730d",
"head_commit_message": "Online Help: Skip test on MacOS-PY3. Add numpy.core to direct import mods",
"patch_to_review": "diff --git a/spyder/plugins/onlinehelp/tests/test_pydocgui.py b/spyder/plugins/onlinehelp/tests/test_pydocgui.py\nindex 23b3b795d78..... | [
{
"diff_hunk": "@@ -22,6 +23,189 @@\n from spyder.widgets.browser import WebBrowser\r\n \r\n \r\n+# =============================================================================\r\n+# Pydoc adjustments\r\n+# =============================================================================\r\n+# This is needed to pr... | d06587aae54f854a7e0e8cee3789722d436b9e11 | diff --git a/spyder/plugins/onlinehelp/pydoc_patch.py b/spyder/plugins/onlinehelp/pydoc_patch.py
new file mode 100644
index 00000000000..fbd973e696f
--- /dev/null
+++ b/spyder/plugins/onlinehelp/pydoc_patch.py
@@ -0,0 +1,120 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright © Spyder Project Contributors
+# Licensed under the... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Documentation Updates"
} |
spyder-ide__spyder-10847@40d7095 | spyder-ide/spyder | Python | 10,847 | PR: Make sure processEvents is not called by Pdb | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-11-26T13:10:52Z | Keyboard events leak from console to editor while debugging
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
create a file `tmp.py`:
```
def a():
1/0
```
And a file `tmp2.py`:
```
from tmp import a
a()
```
1. Run tmp2.py
2. type in the console `%de... | [
{
"body": "## Description\r\n\r\n### What steps will reproduce the problem?\r\n\r\n<!--- You can use Markdown here --->\r\n\r\ncreate a file `tmp.py`:\r\n```\r\ndef a():\r\n 1/0\r\n```\r\nAnd a file `tmp2.py`:\r\n```\r\nfrom tmp import a\r\na()\r\n```\r\n 1. Run tmp2.py\r\n 2. type in the console `%debug`\r\... | 2bcc7005f13583793880896791465466429b7b3c | {
"head_commit": "40d70958eca7e915e7dbe4322b0fef85e6380dbe",
"head_commit_message": "fix test",
"patch_to_review": "diff --git a/continuous_integration/azure/install.bat b/continuous_integration/azure/install.bat\nindex 9da77f1e17d..034542f1152 100644\n--- a/continuous_integration/azure/install.bat\n+++ b/continu... | [
{
"diff_hunk": "@@ -38,7 +38,7 @@ conda create -n jedi-test-env -q -y python=3.6 loghub spyder-kernels -c spyder-i\n if errorlevel 1 exit 1\n \n :: Install spyder-kernels from master\n-pip install -q --no-deps git+https://github.com/spyder-ide/spyder-kernels\n+pip install -q --no-deps git+https://github.com/spy... | 04f1a2dbc844fb5859cc3aeb7de0306bf7504a6a | diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py
index 50a7947df0b..ea47878d3e5 100644
--- a/spyder/app/tests/test_mainwindow.py
+++ b/spyder/app/tests/test_mainwindow.py
@@ -2756,5 +2756,71 @@ def test_path_manager_updates_clients(qtbot, main_window, tmpdir):
assert count >= ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
spyder-ide__spyder-10730@941e303 | spyder-ide/spyder | Python | 10,730 | PR: Fix underscore completions | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-11-15T21:33:54Z | Completions are not working for underscore variables
If a method or variable starts with `_`, completions are not working:
```python
def _test1():
pass
_test2 = 2
__test3 = 1
_*
```
Press `<tab>` on the cursor (*) and none of `_test1`, `_test2` `__test3` appear. | It was working on v4.0.0b4
<img width="370" alt="Screen Shot 2019-10-29 at 07 10 29" src="https://user-images.githubusercontent.com/3627835/67765917-47f7e480-fa1b-11e9-8ae5-02c74187e743.png">
Please take a look at this @goanpeca. Most probably the sorting algorithm for completion entries is now dropping underscore... | [
{
"body": "If a method or variable starts with `_`, completions are not working:\r\n\r\n```python\r\ndef _test1():\r\n pass\r\n\r\n\r\n_test2 = 2\r\n__test3 = 1\r\n\r\n_*\r\n```\r\n\r\nPress `<tab>` on the cursor (*) and none of `_test1`, `_test2` `__test3` appear.\r\n\r\n\r\n",
"number": 10528,
"tit... | c88697d5abbd9f46dcf4164447953fe1797b1cbc | {
"head_commit": "941e303c580c27a92b8aabcd1e07735651e20a1f",
"head_commit_message": "Check code and add test for underscore completions",
"patch_to_review": "diff --git a/spyder/plugins/editor/widgets/completion.py b/spyder/plugins/editor/widgets/completion.py\nindex 40969ba3fbc..63304b64610 100644\n--- a/spyder/... | [
{
"diff_hunk": "@@ -347,14 +349,25 @@ def is_up_to_date(self, item=None):\n filter_text = completion\n return self.check_can_complete(filter_text, current_word)\n \n- def check_can_complete(self, filter_text, current_word):\n+ def check_can_complete(self, filter_text, current_word, par... | 8d75489bfca1a04effb5823327933438facbea30 | diff --git a/spyder/plugins/editor/widgets/completion.py b/spyder/plugins/editor/widgets/completion.py
index 40969ba3fbc..a25c906c4f0 100644
--- a/spyder/plugins/editor/widgets/completion.py
+++ b/spyder/plugins/editor/widgets/completion.py
@@ -30,25 +30,26 @@
class CompletionWidget(QListWidget):
"""Completion ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-10607@13c9a42 | spyder-ide/spyder | Python | 10,607 | PR: Fix 'run file' project explorer action and add test for it | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-11-04T18:58:11Z | Crash when trying to run a Python file in a project
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
- right click on a python file in the left pane
- choose "run" from the context menu
> issue reporter pops up
### Traceback
```python-traceback
File "/home/sum/.pyenv... | @dalthviz, please take a look at this one and add a test for it. | [
{
"body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\n- right click on a python file in the left pane\n- choose \"run\" from the context menu\n\n> issue reporter pops up\n\n### Traceback\n```python-traceback\n File \"/home/sum/.pyenv/versions/3.8-dev... | f92cd3fe4a4fcfabf806a93cf42a83af0bcc04fe | {
"head_commit": "13c9a42bb18386a2bf14fa604af52a8528c2b91d",
"head_commit_message": "Projects: Fix run file action and add test for it",
"patch_to_review": "diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py\nindex 631ac9b53ce..f67730aad0c 100644\n--- a/spyder/app/tests/test_ma... | [
{
"diff_hunk": "@@ -931,6 +931,62 @@ def test_open_notebooks_from_project_explorer(main_window, qtbot, tmpdir):\n projects.close_project()\n \n \n+@pytest.mark.slow\n+@flaky(max_runs=3)\n+def test_runfile_from_project_explorer(main_window, qtbot, tmpdir):\n+ \"\"\"Test that file are run from the Project ... | 0fc34ed8ddcd3b08cd9810c3db8e0513029acc85 | diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py
index 631ac9b53ce..fcccd81dc45 100644
--- a/spyder/app/tests/test_mainwindow.py
+++ b/spyder/app/tests/test_mainwindow.py
@@ -931,6 +931,57 @@ def test_open_notebooks_from_project_explorer(main_window, qtbot, tmpdir):
projects.c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-9551@843230f | scikit-learn/scikit-learn | Python | 9,551 | [MRG] Raise exception on providing complex data to estimators | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
Fixes #9528
#### What does this implement/fix? Explain your changes.
A... | 2017-08-14T18:20:25Z | Estimators run with complex data and give wrong results
As discussed on the mailing list, estimators run on complex data without error but might produce wrong results.
We should either raise explicit error messages or ensure correctness in each case.
I think as a first step we should error everywhere, and then enab... | I'm not entirely convinced supporting complex data anywhere is worth the maintenance burden, thinking about it.... but I don't feel very strongly right now? It seems @GaelVaroquaux agrees with this sentiment from the mailing list (though I think he feels more strongly).
I'm quite happy to not deal with this anywhere... | [
{
"body": "As discussed on the mailing list, estimators run on complex data without error but might produce wrong results.\r\nWe should either raise explicit error messages or ensure correctness in each case.\r\n\r\nI think as a first step we should error everywhere, and then enable on an estimator basis.\r\n\r... | d9fdd8b0d1053cb47af8e3823b7a05279dd72054 | {
"head_commit": "843230f5dbdac2685ca40a8b73c894627aa592df",
"head_commit_message": "adding documentation for complex data handling",
"patch_to_review": "diff --git a/sklearn/utils/estimator_checks.py b/sklearn/utils/estimator_checks.py\nindex c3b066e5e31be..fa8e24c588555 100644\n--- a/sklearn/utils/estimator_che... | [
{
"diff_hunk": "@@ -433,6 +433,44 @@ def test_check_array_min_samples_and_features_messages():\n assert_array_equal(y, y_checked)\n \n \n+def test_check_array_complex_data_error():\n+ X = np.array([[1 + 2j, 3 + 4j, 5 + 7j], [2 + 3j, 4 + 5j, 6 + 7j]])",
"line": null,
"original_line": 437,
"ori... | 51d7f47f286d270d4b28aca9d7d2e58d87badf4e | diff --git a/sklearn/utils/estimator_checks.py b/sklearn/utils/estimator_checks.py
index c3b066e5e31be..fa8e24c588555 100644
--- a/sklearn/utils/estimator_checks.py
+++ b/sklearn/utils/estimator_checks.py
@@ -76,6 +76,7 @@ def _yield_non_meta_checks(name, estimator):
yield check_sample_weights_pandas_series
y... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-10565@d8ade41 | spyder-ide/spyder | Python | 10,565 | PR: Improve cell name detection and run cells with the right namespace while debugging | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-11-01T09:00:09Z | runcell is buggy
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
Create a file with this content (Exactly 3 lines):
```
if True:
a = 1
#%%
```
The first cells fails with `RuntimeError: Cell 'if True:' not found.` and the next one creates the traceback be... | [
{
"body": "## Description\r\n\r\n### What steps will reproduce the problem?\r\n\r\n<!--- You can use Markdown here --->\r\n\r\nCreate a file with this content (Exactly 3 lines):\r\n```\r\nif True:\r\n a = 1\r\n#%%\r\n```\r\nThe first cells fails with `RuntimeError: Cell 'if True:' not found.` and the next on... | 3433a2d26990ae531095b6192591725aec077d1d | {
"head_commit": "d8ade41376447adf3e71f52a8776ccc86f188010",
"head_commit_message": "fix Py2 tests",
"patch_to_review": "diff --git a/continuous_integration/azure/install.bat b/continuous_integration/azure/install.bat\nindex 35ec304b212..61954a7c91c 100644\n--- a/continuous_integration/azure/install.bat\n+++ b/co... | [
{
"diff_hunk": "@@ -262,3 +228,72 @@ def get_block_number(self):\n # Avoid calling blockNumber if not a valid block\n return None\n return self.block.blockNumber()\n+\n+\n+def document_cells(block, forward=True):",
"line": null,
"original_line": 233,
"original_start_l... | e8a75b02731e020050acd67af23f6383a4969a3b | diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py
index 111c5aec817..2ecf19e1863 100644
--- a/spyder/app/tests/test_mainwindow.py
+++ b/spyder/app/tests/test_mainwindow.py
@@ -2406,5 +2406,87 @@ def test_varexp_refresh(main_window, qtbot):
assert 0 < int(nsb.editor.source_model... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
spyder-ide__spyder-10850@99df9fb | spyder-ide/spyder | Python | 10,850 | PR: Only go to line in editor when Pdb changes line | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-11-26T15:57:04Z | Pdb switch code editor tabs without reason
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
1. create a file with `print(0)`
2. Debug this file and step into `print`. This brings you to `iostream.py`
3. Click on the original file tab in the editor
4. type in the... | [
{
"body": "## Description\r\n\r\n### What steps will reproduce the problem?\r\n\r\n<!--- You can use Markdown here --->\r\n\r\n1. create a file with `print(0)`\r\n2. Debug this file and step into `print`. This brings you to `iostream.py`\r\n3. Click on the original file tab in the editor\r\n4. type in the debug... | 19625d9ed9f0461f4cfef18fa8d0f66936b4102f | {
"head_commit": "99df9fb70763e014b658d9d90c2367ca993922cd",
"head_commit_message": "Revert \"Use PR 185\"\n\nThis reverts commit 0dae67cb31914b1e7899e1a7efe1b25c4add9d4f.",
"patch_to_review": "diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py\nindex 50a7947df0b..34e4fa3213e 1... | [
{
"diff_hunk": "@@ -2756,5 +2756,75 @@ def test_path_manager_updates_clients(qtbot, main_window, tmpdir):\n assert count >= 1\n \n \n+@pytest.mark.slow\n+@flaky(max_runs=3)\n+@pytest.mark.skipif(sys.platform == 'darwin', reason=\"It times out on macOS\")\n+def test_pbd_step(main_window, qtbot, tmpdir):\n+ ... | 58c64d0858a744b8bd7002d91394c1cc8d8673a7 | diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py
index ea47878d3e5..bacc88f09ba 100644
--- a/spyder/app/tests/test_mainwindow.py
+++ b/spyder/app/tests/test_mainwindow.py
@@ -2817,10 +2817,79 @@ def processEvents():
# Make sure the events are not processed.
asse... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
spyder-ide__spyder-10546@c0bf99d | spyder-ide/spyder | Python | 10,546 | PR: Improvements to the Object Explorer (font, resize, and actions over row) | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-10-30T15:55:26Z | Object Explorer improvements
<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->
## TODO:
- [x] Make columns resizable
- [x] Set same font used in the Variable Explorer
- [x] Do... | [
{
"body": "<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->\r\n\r\n## TODO:\r\n\r\n- [x] Make columns resizable\r\n- [x] Set same font used in the Variable Explorer\r\n- [x] ... | a435d3b48507a01599b7fdb234d2628f84cf9bee | {
"head_commit": "c0bf99ddd4c098d01c3a8a6e4cd9beacb3383525",
"head_commit_message": "Object Explorer: Prevent font size changes",
"patch_to_review": "diff --git a/spyder/plugins/variableexplorer/widgets/collectionsdelegate.py b/spyder/plugins/variableexplorer/widgets/collectionsdelegate.py\nindex cc9e393a704..29c... | [
{
"diff_hunk": "@@ -425,6 +423,8 @@ def createEditor(self, parent, option, index):\n self.old_obj = value.copy()\n except AttributeError:\n self.old_obj = copy.deepcopy(value)\n+ except Exception:\n+ value = None",
"line": null,
"orig... | 58820e6cb3939a569287ba953b04868d762a25b7 | diff --git a/spyder/plugins/variableexplorer/widgets/collectionsdelegate.py b/spyder/plugins/variableexplorer/widgets/collectionsdelegate.py
index cc9e393a704..6c5b4c88d47 100644
--- a/spyder/plugins/variableexplorer/widgets/collectionsdelegate.py
+++ b/spyder/plugins/variableexplorer/widgets/collectionsdelegate.py
@@ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
spyder-ide__spyder-10510@7882cce | spyder-ide/spyder | Python | 10,510 | PR: Fix on the fly completions inside braces | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-10-25T04:23:26Z | Autocompletions not working inside function calls
<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->
## Problem Description
Autocompletions for variables don't work inside functi... | Working on this! | [
{
"body": "<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->\r\n\r\n\r\n## Problem Description\r\nAutocompletions for variables don't work inside function calls.\r\n\r\n\r\n##... | 7ca1ca083dc5cabf13d291a3b6c26a3388342042 | {
"head_commit": "7882ccedb760d8f1a8655503b90dd33e2aed2cdb",
"head_commit_message": "Fix test comments",
"patch_to_review": "diff --git a/spyder/plugins/editor/widgets/codeeditor.py b/spyder/plugins/editor/widgets/codeeditor.py\nindex a5ca85fa026..07971a346c0 100644\n--- a/spyder/plugins/editor/widgets/codeeditor... | [
{
"diff_hunk": "@@ -3624,16 +3624,25 @@ def insert_text(event):\n def _handle_completions(self):\r\n \"\"\"Handle on the fly completions with a delay.\"\"\"\r\n cursor = self.textCursor()\r\n+ pos = cursor.position()\r\n cursor.select(QTextCursor.WordUnderCursor)\r\n t... | 8f8a806d1ef32289a2ae5884038c4bd355eace13 | diff --git a/spyder/plugins/editor/widgets/codeeditor.py b/spyder/plugins/editor/widgets/codeeditor.py
index a5ca85fa026..fa2ffd865a4 100644
--- a/spyder/plugins/editor/widgets/codeeditor.py
+++ b/spyder/plugins/editor/widgets/codeeditor.py
@@ -3624,16 +3624,25 @@ def insert_text(event):
def _handle_completions(se... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-9655@191b4f7 | scikit-learn/scikit-learn | Python | 9,655 | [MRG+1] Return nan in RadiusNeighborsRegressor for empty neighbor set | #### Reference Issue
Fixes #9654
#### What does this implement/fix? Explain your changes.
RadiusNeighborsRegressor is behaving differently when there are no neighbors for a sample between when weights are or aren't used. This PR fixes this inconsistency. This PR also fixes raised error when no available data ... | 2017-08-30T20:44:31Z | RadiusNeighborRegression error
#### Description
RadiusNeighborRegression has inconsistent output depending whether using weights that are uniform or by distance.
- When using uniform weights then if no observations are available within the specified radius of an observation point then no it returns `np.nan`,
-... | [
{
"body": "#### Description\r\nRadiusNeighborRegression has inconsistent output depending whether using weights that are uniform or by distance. \r\n\r\n- When using uniform weights then if no observations are available within the specified radius of an observation point then no it returns `np.nan`, \r\n\r\n- W... | bbdcd70fcaa875e78a009d89f755bba602a861be | {
"head_commit": "191b4f7078060a875689189e8651095f5cd31c04",
"head_commit_message": "Fix to issue 9654\n\nFixes problem with raise error when no available data points for RadiusNeighborRegression using non-uniform weights.",
"patch_to_review": "diff --git a/sklearn/neighbors/regression.py b/sklearn/neighbors/regr... | [
{
"diff_hunk": "@@ -291,9 +291,28 @@ def predict(self, X):\n y_pred = np.array([np.mean(_y[ind, :], axis=0)\n for ind in neigh_ind])\n else:\n- y_pred = np.array([(np.average(_y[ind, :], axis=0,\n- weights=we... | b47f5bff4a8a888a11417054647da97ffbcaf49c | diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst
index 170da358facb0..c5143c6e46c85 100644
--- a/doc/whats_new/v0.20.rst
+++ b/doc/whats_new/v0.20.rst
@@ -116,7 +116,7 @@ Classifiers and regressors
:class:`neural_network.MLPClassifier` with new ``n_iter_no_change``
parameter now at 10 from previousl... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
scikit-learn__scikit-learn-9420@65a617f | scikit-learn/scikit-learn | Python | 9,420 | [MRG + 1] Fix Sphinx errors | #### Reference Issue
Fixes #9417
#### What does this implement/fix? Explain your changes.
Fix warnings seen in doc build logs.
| 2017-07-20T04:32:23Z | Fix remaining sphinx errors
Since we're now using upstream numpydoc, it should be fairly easy to fix the remaining errors in building the docs:
```
/home/ubuntu/scikit-learn/doc/modules/cross_validation.rst:287: WARNING: undefined label: time_series_cv (if the link has no caption the label must precede a section he... | ```
/home/ubuntu/scikit-learn/doc/auto_examples/calibration/plot_compare_calibration.rst:51: WARNING: Footnote [1] is not referenced.
/home/ubuntu/scikit-learn/doc/auto_examples/covariance/plot_robust_vs_empirical_covariance.rst:51: WARNING: Footnote [2] is not referenced.
/home/ubuntu/scikit-learn/doc/auto_examples... | [
{
"body": "Since we're now using upstream numpydoc, it should be fairly easy to fix the remaining errors in building the docs:\r\n\r\n```\r\n/home/ubuntu/scikit-learn/doc/modules/cross_validation.rst:287: WARNING: undefined label: time_series_cv (if the link has no caption the label must precede a section heade... | 09b4cfdfb28e95bd589a0dabfb95816c36286e7f | {
"head_commit": "65a617f1ec863d6b9fb5bbf3bb7fda6e07036a1a",
"head_commit_message": "Fix link ref in covariance.rst",
"patch_to_review": "diff --git a/doc/modules/calibration.rst b/doc/modules/calibration.rst\nindex 0c0af594398a0..34e9a9cda92ad 100644\n--- a/doc/modules/calibration.rst\n+++ b/doc/modules/calibrat... | [
{
"diff_hunk": "@@ -659,6 +659,13 @@ def correct_covariance(self, data):\n The data set must be the one which was used to compute\n the raw estimates.\n \n+ References\n+ ----------\n+\n+ .. [Rouseeuw1999] `A Fast Algorithm for the Minimum Covariance",
"line": nu... | 460810da601ab705fccca1bbc94a7fb866770428 | diff --git a/doc/modules/calibration.rst b/doc/modules/calibration.rst
index 0c0af594398a0..9762414ac8cc0 100644
--- a/doc/modules/calibration.rst
+++ b/doc/modules/calibration.rst
@@ -44,7 +44,7 @@ with different biases per method:
* :class:`RandomForestClassifier` shows the opposite behavior: the histograms
sho... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
spyder-ide__spyder-10419@82fb3a5 | spyder-ide/spyder | Python | 10,419 | PR: Handle paths for recent files on a different mount than the project root path | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-10-15T19:50:46Z | ValueError when closing project on USB stick
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
1. Open project from USB stick with Spyder 3
2. Update to Spyder 4 beta
3. Try closing project. Results in an error.
### Traceback
```python-traceback
File "C:\Users\jmgro\An... | @goanpeca, please take a look at this one. I think this is caused because we're now using relative paths in our projects instead of absolute ones.
>I think this is caused because we're now using relative paths in our projects instead of absolute ones.
Yes, that is correct, will try to add a test for this then
I upda... | [
{
"body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\n1. Open project from USB stick with Spyder 3\n2. Update to Spyder 4 beta\n3. Try closing project. Results in an error.\n\n### Traceback\n```python-traceback\n File \"C:\\Users\\jmgro\\Anaconda3\\l... | 4208e6f6cf50c3c9ee695489047039fc18642790 | {
"head_commit": "82fb3a578b2901cd0e24e276257aea2f57210612",
"head_commit_message": "Projects: Remove file validation for test",
"patch_to_review": "diff --git a/spyder/plugins/projects/projecttypes/__init__.py b/spyder/plugins/projects/projecttypes/__init__.py\nindex a2864c01054..70a8fee66ca 100644\n--- a/spyder... | [
{
"diff_hunk": "@@ -75,11 +78,6 @@ def get_recent_files(self):\n recent_files = [recent_file if os.path.isabs(recent_file)\n else os.path.join(self.root_path, recent_file)\n for recent_file in recent_files]\n-\n- for recent_file in recent_files[:]:\... | 6ee6c5ac021a55eb91e3f83b5dd828d7a97d0c16 | diff --git a/spyder/plugins/projects/projecttypes/__init__.py b/spyder/plugins/projects/projecttypes/__init__.py
index a2864c01054..6834bad6eaa 100644
--- a/spyder/plugins/projects/projecttypes/__init__.py
+++ b/spyder/plugins/projects/projecttypes/__init__.py
@@ -61,12 +61,16 @@ def set_option(self, section, option, v... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-10480@b1f182d | spyder-ide/spyder | Python | 10,480 | PR: Handle inotify error on Linux | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-10-21T18:09:05Z | "OSError: inotify watch limit reached" with many files in a project
spyder4b7 gives this error if there are a lot of files in the project (150000). I use it for machine learning and it is not unusual to have a subdirectory with that number of files in a project.
`sudo sysctl fs.inotify.max_user_watches=500000 `
... | @dalthviz, please take a look at this one.
The idea is to catch this specific error and explain users how to increase the inotify limit on Linux in a QMessageBox (VSCode does the same, by the way). | [
{
"body": "spyder4b7 gives this error if there are a lot of files in the project (150000). I use it for machine learning and it is not unusual to have a subdirectory with that number of files in a project. \r\n\r\n`sudo sysctl fs.inotify.max_user_watches=500000 `\r\n\r\nmakes it work on ubuntu 18.04, but this i... | d84908e66747585d951b6749c73d2e54d6c96c07 | {
"head_commit": "b1f182d19d72ffb462e4decc40b1754dce744b1b",
"head_commit_message": "Projects: Add handling for inotify watch limit reached",
"patch_to_review": "diff --git a/spyder/plugins/projects/utils/watcher.py b/spyder/plugins/projects/utils/watcher.py\nindex 33e2e2aabd0..d8a17fd67d6 100644\n--- a/spyder/pl... | [
{
"diff_hunk": "@@ -87,10 +91,28 @@ def connect_signals(self, project):\n self.event_handler.sig_file_modified.connect(project.file_modified)\n \n def start(self, workspace_folder):\n- self.observer = Observer()\n- self.observer.schedule(\n- self.event_handler, workspace_fol... | 657a7ae47585a918a86472c7806d084138593bf1 | diff --git a/spyder/plugins/projects/utils/watcher.py b/spyder/plugins/projects/utils/watcher.py
index 33e2e2aabd0..7701f13c43b 100644
--- a/spyder/plugins/projects/utils/watcher.py
+++ b/spyder/plugins/projects/utils/watcher.py
@@ -11,10 +11,14 @@
# Third-party imports
from qtpy.QtCore import QObject, Signal
+from... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-9484@4670278 | scikit-learn/scikit-learn | Python | 9,484 | fixed a bug in isotonic regression | #### Reference Issue
Fixes #9432
#### What does this implement/fix? Explain your changes.
There was an apparent bug in the preprocessing steps for isotonic regression (_make_unique), in that the weights for duplicate points were averaged, rather that summed, effectively down-weighting duplicate points in the actu... | 2017-08-02T22:59:49Z | Incorrect predictions from isotonic regression in the presence of repeated X values
#### Description
Isotonic regression returns an incorrect solution in the presence of repeated X values.
The problem seems to be that fit() begins by taking the weighted average of points with the same x value. However, rather than... | [
{
"body": "#### Description\r\nIsotonic regression returns an incorrect solution in the presence of repeated X values. \r\n\r\nThe problem seems to be that fit() begins by taking the weighted average of points with the same x value. However, rather than associating the resulting average point with the sum of th... | 21b0bb437fa69401dafa3675a40c8d0a581b71ca | {
"head_commit": "467027838f815b6f107ff01ca331138e5a7ee7de",
"head_commit_message": "added non-regression test",
"patch_to_review": "diff --git a/sklearn/_isotonic.pyx b/sklearn/_isotonic.pyx\nindex 1cec075fc6fc7..55f3bea7ac6d5 100644\n--- a/sklearn/_isotonic.pyx\n+++ b/sklearn/_isotonic.pyx\n@@ -70,7 +70,8 @@ de... | [
{
"diff_hunk": "@@ -70,14 +70,19 @@ def _inplace_contiguous_isotonic_regression(DOUBLE[::1] y, DOUBLE[::1] w):\n @cython.cdivision(True)\n def _make_unique(np.ndarray[dtype=np.float64_t] X,\n np.ndarray[dtype=np.float64_t] y,\n- np.ndarray[dtype=np.float64_t] sample_weights):\n+... | 924a7cd701ecad85f5661f9a5cd590df27f58d68 | diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst
index 4f5e13e7860a5..f5a4ebc3477af 100644
--- a/doc/whats_new/v0.20.rst
+++ b/doc/whats_new/v0.20.rst
@@ -16,6 +16,7 @@ occurs due to changes in the modelling logic (bug fixes or enhancements), or in
random sampling procedures.
- :class:`decomposition.I... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
spyder-ide__spyder-10236@7888b54 | spyder-ide/spyder | Python | 10,236 | PR: Fix OSError when saving files on Linux |
<!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descr... | 2019-09-17T21:38:33Z | OSError when saving files on Linux
## Problem Description
Attempting to save a .py script in spyder4 beta5 leads to error.
Save Error
Unable to save file 'test_save.py'
Error message:
[Errno 22] Invalid argument
Apologies if simple issue.
### What steps reproduce the problem?
1. Open spyder4 in term... | This happens because some filesystems don't support the option to sync directories (e.g. network file systems), as described in issue https://github.com/untitaker/python-atomicwrites/issues/17
@andfoy, please take care of this one. We basically need to catch the error thrown by `atomicwrites` and perform a regular w... | [
{
"body": "## Problem Description\r\n\r\nAttempting to save a .py script in spyder4 beta5 leads to error. \r\n\r\nSave Error\r\nUnable to save file 'test_save.py'\r\nError message:\r\n[Errno 22] Invalid argument\r\n\r\nApologies if simple issue.\r\n\r\n### What steps reproduce the problem?\r\n\r\n1. Open spyde... | 3aba3212db9978cd1e86b6b860e93b48dccf0d96 | {
"head_commit": "7888b543d7f1a68598a6e81ca48b77e72c28dfc7",
"head_commit_message": "add support for python 2",
"patch_to_review": "diff --git a/spyder/plugins/editor/widgets/editor.py b/spyder/plugins/editor/widgets/editor.py\nindex 03641e5499f..1f9c36e4a07 100644\n--- a/spyder/plugins/editor/widgets/editor.py\n... | [
{
"diff_hunk": "@@ -1774,7 +1776,19 @@ def _write_to_file(self, fileinfo, filename):\n correct encoding without doing any error handling.\r\n \"\"\"\r\n txt = fileinfo.editor.get_text_with_eol()\r\n- fileinfo.encoding = encoding.write(txt, filename, fileinfo.encoding)\r\n+ ... | c1eed13b9645cf9347ce90c58c68cf13619396c9 | diff --git a/spyder/plugins/editor/widgets/editor.py b/spyder/plugins/editor/widgets/editor.py
index 03641e5499f..6544e756727 100644
--- a/spyder/plugins/editor/widgets/editor.py
+++ b/spyder/plugins/editor/widgets/editor.py
@@ -35,7 +35,8 @@
from spyder.config.gui import config_shortcut, is_dark_interface, get_shortc... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ray-project__ray-50308@b681cbb | ray-project/ray | Python | 50,308 | fix: WandbLogger crashing silently on a FileNotFoundError | Fixes: #50307
- #50307 | 2025-02-07T10:58:09Z | [Air] WandB logger / _WandbLoggingActor crashes silently when logging a video with relative path or if it cannot find the given file.
### What happened + What you expected to happen
I want to log a video to wandb that is stored as a file, what I did was roughly.
```
python
from wandb import Video
result["video"] = V... | [
{
"body": "### What happened + What you expected to happen\n\nI want to log a video to wandb that is stored as a file, what I did was roughly.\n\n```\npython\nfrom wandb import Video\n\nresult[\"video\"] = Video(\"a_file\", format=\"mp4\")\ntrain.report(result)\n```\n\nI just did this in a custom `WandbLoggerCa... | ca4878135e3628ea14bfa5c6bf37227198c298ee | {
"head_commit": "b681cbb6651920d2e29a04fd776c09a9f3168c36",
"head_commit_message": "Clarify effect of WandB error\n\nSigned-off-by: Daraan <github.blurry@9ox.net>",
"patch_to_review": "diff --git a/python/ray/air/integrations/wandb.py b/python/ray/air/integrations/wandb.py\nindex dceeca29f46b2..2a4f177263c92 100... | [
{
"diff_hunk": "@@ -420,6 +420,12 @@ def run(self):\n # Ignore HTTPError. Missing a few data points is not a\n # big issue, as long as things eventually recover.\n logger.warning(\"Failed to log result to w&b: {}\".format(str(e)))\n+ except FileNotFound... | 16f88391cbc03d940a902f2a8de4901142f06af8 | diff --git a/python/ray/air/integrations/wandb.py b/python/ray/air/integrations/wandb.py
index 89a4d376278c..c1cf4479cf12 100644
--- a/python/ray/air/integrations/wandb.py
+++ b/python/ray/air/integrations/wandb.py
@@ -423,6 +423,13 @@ def run(self):
# Ignore HTTPError. Missing a few data points is not... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
spyder-ide__spyder-10114@b1263cd | spyder-ide/spyder | Python | 10,114 | PR: Handle Sympy foreground color setting following a color scheme change | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-08-30T16:40:59Z | Invert colors for "Pretty-Printing" symbolic math in IPython's dark background
The pretty printed symbolic math is unreadable when the the IPython console background is set to dark.
To reproduce:
1. Set preferences -> IPython console->Display->Background color to dark
2. Set preferences -> IPython console->Advance... | Thanks for reporting. We'll try to fix this in Spyder 3.1
I noticed this as well years ago, remember being puzzled that there was seemingly nothing printed until the lightbulb moment that it makes perfect sense that you don't see anything useful when using black text on black background.
Anyways, at that time I did ... | [
{
"body": "The pretty printed symbolic math is unreadable when the the IPython console background is set to dark.\r\n\r\nTo reproduce:\r\n1. Set preferences -> IPython console->Display->Background color to dark\r\n2. Set preferences -> IPython console->Advanced->Use symbolic math\r\n3. Restart ipython console\r... | 33114afdb83f012e12537a1d697354d90776afe7 | {
"head_commit": "b1263cdc3882fc9329472b906ed52ddd680be939",
"head_commit_message": "IPython Console: Add comment to explain config of tracebacks colors",
"patch_to_review": "diff --git a/spyder/plugins/ipythonconsole/widgets/shell.py b/spyder/plugins/ipythonconsole/widgets/shell.py\nindex a60716977d7..d35bcf2105... | [
{
"diff_hunk": "@@ -185,9 +185,16 @@ def set_color_scheme(self, color_scheme, reset=True):\n if reset:\n self.reset(clear=True)\n if not dark_color:\n+ # Needed to change the colors of the tracebacks",
"line": null,
"original_line": 188,
"original_start_line": ... | f309d812766f6db5d4c84062f9779bbb8dca07ff | diff --git a/spyder/plugins/ipythonconsole/widgets/shell.py b/spyder/plugins/ipythonconsole/widgets/shell.py
index a60716977d7..0f165ae337a 100644
--- a/spyder/plugins/ipythonconsole/widgets/shell.py
+++ b/spyder/plugins/ipythonconsole/widgets/shell.py
@@ -185,9 +185,16 @@ def set_color_scheme(self, color_scheme, reset... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-9251@435d217 | scikit-learn/scikit-learn | Python | 9,251 | [MRG] Matplotlib tree plotting | Fixes #8508
This PR does three things:
- Refactors the graphviz export into a class for easier code reuse (public interface stays the same)
- adds a matplotlib based plotting frontend
- adds the Reingold-Tilford tree layouting algorithm
For now this lives in the tree submodule to avoid conflicting with work on... | 2017-06-29T22:38:43Z | Add matplotlib based plotting of decision trees
I really want to be able to plot trees without graphviz. Plotting trees is important. Even with conda (good luck without) this keeps creating issues on windows.
I think we should add a function that directly plots a tree without going through the graphviz file format. ... | also see #7116
also see #6522
Should the function be added to the scikit-plot side project?
I would rather have it in ``sklearn.plot`` (which exists in some PRs but not in master). | [
{
"body": "I really want to be able to plot trees without graphviz. Plotting trees is important. Even with conda (good luck without) this keeps creating issues on windows.\r\n\r\nI think we should add a function that directly plots a tree without going through the graphviz file format. Plotting trees is much ea... | 00c2f411cf87c83abdf6ad59fa522ad16a2a18cb | {
"head_commit": "435d217358508f5c3edbf5a377653ed7d6070fd3",
"head_commit_message": "added license header from pymag-trees repo",
"patch_to_review": "diff --git a/doc/Makefile b/doc/Makefile\nindex fcb547d14e2b0..6629518fc556a 100644\n--- a/doc/Makefile\n+++ b/doc/Makefile\n@@ -13,7 +13,7 @@ endif\n # Internal va... | [
{
"diff_hunk": "@@ -0,0 +1,54 @@\n+import numpy as np\n+import pytest\n+from sklearn.tree._reingold_tilford import buchheim, Tree\n+\n+simple_tree = Tree(\"\", 0,\n+ Tree(\"\", 1),\n+ Tree(\"\", 2))\n+\n+bigger_tree = Tree(\"\", 0,\n+ Tree(\"\", 1,\n+ ... | 98e8d5ab51e83ac466d67714313b984c2e85f51b | diff --git a/doc/Makefile b/doc/Makefile
index fcb547d14e2b0..6629518fc556a 100644
--- a/doc/Makefile
+++ b/doc/Makefile
@@ -13,7 +13,7 @@ endif
# Internal variables.
PAPEROPT_a4 = -D latex_paper_size=a4
PAPEROPT_letter = -D latex_paper_size=letter
-ALLSPHINXOPTS = -d $(BUILDDIR)/doctrees $(PAPEROPT_$(PAPER)) ... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
spyder-ide__spyder-10076@1149bcd | spyder-ide/spyder | Python | 10,076 | PR: Check if responses are not None in Kite plugin handlers | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-08-25T13:57:36Z | TypeError in Kite client
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
When I open up Spyder, after a while (a few seconds), the Issue reporter window pops up. It seems that there's something wrong with kite autocompletion
### Traceback
```python-traceback
... | @ma-sadeghi, thanks for reporting. Do you have Kite installed in your system?
@andfoy, please take a look at this one.
@ccordoba12 yes, I have Kite installed.
We're not preventing None responses to not be attended. I'll fix this
Thanks @metalogical for the report! | [
{
"body": "## Description\r\n\r\n### What steps will reproduce the problem?\r\n\r\n<!--- You can use Markdown here --->\r\n\r\nWhen I open up Spyder, after a while (a few seconds), the Issue reporter window pops up. It seems that there's something wrong with kite autocompletion\r\n\r\n### Traceback\r\n```python... | 0a83f097eed8b1e8ac77c7eaff289a07a69f0078 | {
"head_commit": "1149bcda6e4dca670c94eac8acc0f8f98a836b3c",
"head_commit_message": "Check response is not None",
"patch_to_review": "diff --git a/spyder/plugins/completion/kite/providers/document.py b/spyder/plugins/completion/kite/providers/document.py\nindex 8bec7243e24..82311c3fa6e 100644\n--- a/spyder/plugin... | [
{
"diff_hunk": "@@ -116,10 +116,14 @@ def request_hover(self, params):\n @handles(LSPRequestTypes.DOCUMENT_HOVER)\n def process_hover(self, response):\n # logger.debug(response)",
"line": null,
"original_line": 118,
"original_start_line": null,
"path": "spyder/plugins/completion/... | b28c9c70a77fd047bac8ba8ca7177a6b1d541962 | diff --git a/spyder/plugins/completion/kite/client.py b/spyder/plugins/completion/kite/client.py
index 29e5240ebdf..434de1b6951 100644
--- a/spyder/plugins/completion/kite/client.py
+++ b/spyder/plugins/completion/kite/client.py
@@ -9,16 +9,15 @@
# Standard library imports
import logging
-# Qt imports
+# Third part... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-9966@994813d | spyder-ide/spyder | Python | 9,966 | PR: Save files when calling runfile directly in the console | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-08-05T18:57:26Z | File not saved when calling runfile from console
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
When pressing the green "Run file" arrow, the file is automatically saved. It would be cool if the same appened when I type `runfile('file.py')` in the console.
## ... | We really need to add Comms to qtconsole to expand the things we can do between the Spyder interface and the kernel.
Trying to do something else is brittle and hacky. | [
{
"body": "## Description\r\n\r\n### What steps will reproduce the problem?\r\n\r\n<!--- You can use Markdown here --->\r\n\r\nWhen pressing the green \"Run file\" arrow, the file is automatically saved. It would be cool if the same appened when I type `runfile('file.py')` in the console.\r\n\r\n## Versions\r\n... | fb8b67a50b77fe365e9845c5a20369cfb0bc86e6 | {
"head_commit": "994813dabe291d07b559fc6110840288713dd231",
"head_commit_message": "Use PR 136",
"patch_to_review": "diff --git a/continuous_integration/azure/install.bat b/continuous_integration/azure/install.bat\nindex 82c305af19d..42e78cb714e 100644\n--- a/continuous_integration/azure/install.bat\n+++ b/conti... | [
{
"diff_hunk": "@@ -452,6 +453,26 @@ def change_mpl_backend(self, command):\n if not 'inline' in command:\n self.silent_execute(command)\n \n+ # ---- Spyder-kernels methods -------------------------------------------\n+ def get_editor(self, filename=None):\n+ \"\"\"Get e... | b053864b44db1828f9ec1db75349b0d7b0ee5942 | diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py
index 7f2088124a1..cf7d69f8d45 100644
--- a/spyder/app/tests/test_mainwindow.py
+++ b/spyder/app/tests/test_mainwindow.py
@@ -54,6 +54,7 @@
from spyder.py3compat import PY2, to_text_string
from spyder.utils.programs import is_modul... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
scrapy__scrapy-6897@e7099f3 | scrapy/scrapy | Python | 6,897 | Fix FileFeedStorage handling of Windows paths without file:// scheme | ## Description
This PR addresses an issue in the `FileFeedStorage` class where passing a Windows-style path without the `file://` URI scheme causes incorrect path resolution. Specifically, using a path like `C:/foo` was incorrectly processed by `w3lib.url.file_uri_to_path()`, which expects a proper URI. This led to ... | 2025-06-21T01:07:01Z | `FileFeedStorage` ignores the drive letter on Windows
```
>>> from scrapy.extensions.feedexport import FileFeedStorage
>>> s = FileFeedStorage("C:/foo")
>>> s.path
'\\foo'
>>> s = FileFeedStorage("D:/foo")
>>> s.path
'\\foo'
```
This, I believe, causes the files to be written to the drive from the spider work director... | A real-world symptom: running `scrapy runspider foo.py -o c:\foo.json` from a directory on D: creates d:\foo.json. It also prints "Stored json feed (1 items) in: c:\foo.json".
Hi @wRAR , may I work on this issue? | [
{
"body": "```\n>>> from scrapy.extensions.feedexport import FileFeedStorage\n>>> s = FileFeedStorage(\"C:/foo\")\n>>> s.path\n'\\\\foo'\n>>> s = FileFeedStorage(\"D:/foo\")\n>>> s.path\n'\\\\foo'\n```\n\nThis, I believe, causes the files to be written to the drive from the spider work directory instead of the ... | 91b186cf1868038569ef05a334650eae2a74b5b1 | {
"head_commit": "e7099f34f1508a81ba3cc1d4b37a678a7af7c38b",
"head_commit_message": "Fix FileFeedStorage handling of Windows paths without file:// scheme (#6894)",
"patch_to_review": "diff --git a/scrapy/extensions/feedexport.py b/scrapy/extensions/feedexport.py\nindex d9e9ea775cf..763dd326be9 100644\n--- a/scrap... | [
{
"diff_hunk": "@@ -155,6 +155,12 @@ def _assert_stores(\n finally:\n path.unlink()\n \n+ def test_preserves_windows_path_without_file_scheme(self, tmp_path):",
"line": null,
"original_line": 158,
"original_start_line": null,
"path": "tests/test_feedexport.py",
"start_... | 3eea6898cef7bd7e791243db534ad041c10a7a26 | diff --git a/scrapy/extensions/feedexport.py b/scrapy/extensions/feedexport.py
index d9e9ea775cf..f7bf50a5cf9 100644
--- a/scrapy/extensions/feedexport.py
+++ b/scrapy/extensions/feedexport.py
@@ -185,7 +185,7 @@ def store(self, file: IO[bytes]) -> Deferred[None] | None:
@implementer(IFeedStorage)
class FileFeedStora... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-9975@0528153 | spyder-ide/spyder | Python | 9,975 | PR: Centralize dependencies and declare the missing ones | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-08-07T05:05:41Z | Centralize all dependencies in one place and declare all the ones present in setup.py
@juanis2112, the idea is to move all calls of the form
```python
QDARKSTYLE_REQVER = '>=2.6.4'
dependencies.add("qdarkstyle", _("Dark style for the entire interface"),
required_version=QDARKSTYLE_REQVER)
```
... | [
{
"body": "@juanis2112, the idea is to move all calls of the form\r\n\r\n```python\r\nQDARKSTYLE_REQVER = '>=2.6.4'\r\ndependencies.add(\"qdarkstyle\", _(\"Dark style for the entire interface\"),\r\n required_version=QDARKSTYLE_REQVER)\r\n```\r\n\r\nto `spyder/dependencies.py`, inside a function... | 1ac763c4313812656131168c451ddb934a56e363 | {
"head_commit": "0528153e9b2ccd717bbe85a76d6b874668082436",
"head_commit_message": "Fixing required version for QTCONSOLE_REQVER",
"patch_to_review": "diff --git a/spyder/app/mainwindow.py b/spyder/app/mainwindow.py\nindex 9bddd61faad..24f6e8a0464 100644\n--- a/spyder/app/mainwindow.py\n+++ b/spyder/app/mainwind... | [
{
"diff_hunk": "@@ -274,10 +274,7 @@ def qt_message_handler(msg_type, msg_log_context, msg_string):\n # =============================================================================\r\n # Dependencies\r\n # =============================================================================\r\n-QDARKSTYLE_REQVER = '>=... | 33c4751bf5b72211358e25d552740068b4a1d0d5 | diff --git a/README.md b/README.md
index bf6d3fa83f9..1b1ee0e29c7 100644
--- a/README.md
+++ b/README.md
@@ -223,42 +223,13 @@ a Python version equal or greater than 3.5 or 2.7.
### Runtime dependencies
+The basic dependencies to run Spyder are:
+
* **Python** 3.5+ or 2.7: The core language Spyder is written in a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
spyder-ide__spyder-15922@a06bc54 | spyder-ide/spyder | Python | 15,922 | PR: Add a way to create plugins like Plots and the Variable explorer to the API | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2021-06-23T10:25:23Z | Consoles connected to external ipykernels break Plots and the Variable Explorer
## Problem Description
When switching to an external ipykernel, the plugins do not update correctly.
For example, the variable explorer would show the namespace of the previous console instead of the current one
I know that the varia... | [
{
"body": "## Problem Description\r\nWhen switching to an external ipykernel, the plugins do not update correctly.\r\n\r\nFor example, the variable explorer would show the namespace of the previous console instead of the current one\r\n\r\nI know that the variable explorer is not expected to work for ipykernel... | 8efff37940397f2c2c946505d1ccf8fc43bc197c | {
"head_commit": "a06bc54dd05b5040c9b4a41da4a051652f2860e1",
"head_commit_message": "Revert changed names",
"patch_to_review": "diff --git a/spyder/plugins/help/plugin.py b/spyder/plugins/help/plugin.py\nindex 612a3f66280..b3d734c3574 100644\n--- a/spyder/plugins/help/plugin.py\n+++ b/spyder/plugins/help/plugin.p... | [
{
"diff_hunk": "@@ -0,0 +1,195 @@\n+# -*- coding: utf-8 -*-\n+#\n+# Copyright © Spyder Project Contributors\n+# Licensed under the terms of the MIT License\n+# (see spyder/__init__.py for details)\n+\n+\"\"\"\n+classes to connect to a shellwidget.\n+\"\"\"\n+\n+# Third party imports\n+from qtpy.QtWidgets import... | 16606753117285647613d11583104bca5d275049 | diff --git a/spyder/api/shellconnect/__init__.py b/spyder/api/shellconnect/__init__.py
new file mode 100644
index 00000000000..031acf39d5b
--- /dev/null
+++ b/spyder/api/shellconnect/__init__.py
@@ -0,0 +1,9 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright © Spyder Project Contributors
+# Licensed under the terms of the MIT... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
spyder-ide__spyder-9925@c907a60 | spyder-ide/spyder | Python | 9,925 | PR: Fix wrapping calltip text for elements without signature in the IPython console | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-07-30T23:54:03Z | IPython console crashes when using netCDF4
## Problem Description
Spyder 4.0.0b3 crashes when loading and using netCDF4 package within the iPython Console. Does not happen with the editor.
### What steps reproduce the problem?
1. import netcdf4
2. Only in the iPython console -> when typing "netcdf4.Dataset( " t... | Thanks for reporting. How did you install Spyder and netcdf4?
Thanks for the quick reply!
I installed Spyder as such;
conda update qt pyqt
conda install -c spyder-ide spyder=4.0.0b3
(as instructed here - https://github.com/spyder-ide/spyder/releases/tag/v4.0.0b3)
and as for the netCDF4
conda install netcdf4... | [
{
"body": "## Problem Description\r\nSpyder 4.0.0b3 crashes when loading and using netCDF4 package within the iPython Console. Does not happen with the editor.\r\n\r\n\r\n### What steps reproduce the problem?\r\n1. import netcdf4\r\n2. Only in the iPython console -> when typing \"netcdf4.Dataset( \" the exact s... | 258c1fe571e699bde8cfad5d959b3fd5f4a199cb | {
"head_commit": "c907a60691d95d8352cfe28043c7514b35a43b03",
"head_commit_message": "Mixins - Ipython Console: Fix calltip handling of paragraphs. Fix tests",
"patch_to_review": "diff --git a/spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py b/spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py\ni... | [
{
"diff_hunk": "@@ -205,19 +205,32 @@ def _format_text(self, title=None, signature=None, text=None,\n text = text.strip()\r\n \r\n if not with_html_format:\r\n- paragraphs = text.splitlines()\r\n+ # All the replacement are need to properly divide the\r",
"line": nul... | d673853bd89f49f0c57b83b0e2658a58d8eece81 | diff --git a/spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py b/spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py
index b7d3fbc66b3..7a88b69353b 100644
--- a/spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py
+++ b/spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py
@@ -169,19 +169,19 ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-9921@d655ce2 | spyder-ide/spyder | Python | 9,921 | PR: Improve shortcuts entry in Preferences | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-07-30T16:17:26Z | Improve shortcuts table UI
Right now there's very hard for people to know that they can customize our keyboard shortcuts in our Preferences. That's because there's no message mentioning that and no UI element signaling the possibility.
To fix this I think that we could do the following:
1. Add this message on top... | Hi @ccordoba12. I think the message should suffice :-), but i see no harm in adding the hand as well
Great! @steff456, please work on implementing my suggestions then. | [
{
"body": "Right now there's very hard for people to know that they can customize our keyboard shortcuts in our Preferences. That's because there's no message mentioning that and no UI element signaling the possibility.\r\n\r\nTo fix this I think that we could do the following:\r\n\r\n1. Add this message on top... | c188748789c8b069b5fc383061219f875fe36959 | {
"head_commit": "d655ce27b64c1e966ffc760b9b68218fd10672f6",
"head_commit_message": "changes to placeholder and text label",
"patch_to_review": "diff --git a/spyder/preferences/shortcuts.py b/spyder/preferences/shortcuts.py\nindex ff1565d92b4..84a6ae063c2 100644\n--- a/spyder/preferences/shortcuts.py\n+++ b/spyde... | [
{
"diff_hunk": "@@ -14,7 +14,7 @@\n from qtpy import PYQT5\r\n from qtpy.compat import from_qvariant, to_qvariant\r\n from qtpy.QtCore import QAbstractTableModel, QModelIndex, Qt, Slot, QEvent\r\n-from qtpy.QtGui import QKeySequence, QIcon\r\n+from qtpy.QtGui import QKeySequence, QIcon, QCursor, QMouseEvent\r",... | 93e29923635eb6f4d0e1b31ba6961164453660b5 | diff --git a/spyder/preferences/shortcuts.py b/spyder/preferences/shortcuts.py
index ff1565d92b4..b2b6ec42f1d 100644
--- a/spyder/preferences/shortcuts.py
+++ b/spyder/preferences/shortcuts.py
@@ -796,6 +796,7 @@ def keyPressEvent(self, event):
def mouseDoubleClickEvent(self, event):
"""Qt Override."""
... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
spyder-ide__spyder-9857@a2a3c67 | spyder-ide/spyder | Python | 9,857 | PR: Fix control-click URL in tutorial ValueError | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-07-18T15:39:09Z | Control-click URL in tutorial causes ValueError
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
In the Spyder tutorial, the 'Recommended first steps for Python beginners' section, control-left click on the 'IPython interpreter' link.
I did this because I though... | Thanks for reporting. We'll fix this in Spyder 4.
@steff456, simply catch this error in a try/except and `pass` if it appears. | [
{
"body": "## Description\r\n\r\n### What steps will reproduce the problem?\r\n\r\n<!--- You can use Markdown here --->\r\n\r\nIn the Spyder tutorial, the 'Recommended first steps for Python beginners' section, control-left click on the 'IPython interpreter' link.\r\n\r\nI did this because I thought it might op... | 27a2c67e7342e371c5bdeef522bc6cd51131c136 | {
"head_commit": "a2a3c67185b39a679c45f554043f8cd3ceb81931",
"head_commit_message": "add parent to widget",
"patch_to_review": "diff --git a/spyder/widgets/browser.py b/spyder/widgets/browser.py\nindex 5a177460182..023f4af225e 100644\n--- a/spyder/widgets/browser.py\n+++ b/spyder/widgets/browser.py\n@@ -168,7 +16... | [
{
"diff_hunk": "@@ -168,7 +168,10 @@ def zoom_in(self):\n #------ QWebEngineView API -------------------------------------------------------\r\n def createWindow(self, webwindowtype):\r\n import webbrowser\r\n- webbrowser.open(to_text_string(self.url().toString()))\r\n+ try:\r",
... | f32abee1e8bf9cb9dd40ced6f0013686c678a49d | diff --git a/spyder/widgets/browser.py b/spyder/widgets/browser.py
index 5a177460182..97a9df1c7f5 100644
--- a/spyder/widgets/browser.py
+++ b/spyder/widgets/browser.py
@@ -168,7 +168,11 @@ def zoom_in(self):
#------ QWebEngineView API -------------------------------------------------------
def createWindow(... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-9044@7142ab3 | scikit-learn/scikit-learn | Python | 9,044 | [MRG+1] fix StratifiedShuffleSplit with 2d y | #### Fixes #9037
#### What does this implement/fix?
StratifiedShuffleSplit gives unexpected results if given a 2d y, such as a multi-label or multi-task indicator matrix: basically the current behaviour implicitly flattens y, which makes the indices meaningless.
This fix computes the split indices by replaci... | 2017-06-07T17:09:37Z | StratifiedShuffleSplit generates overlapping train and test indices for multilabel data
#### Description
StratifiedShuffleSplit generates train and test indices which overlap when based on multilabel data.
#### Steps/Code to Reproduce
```python
from sklearn.model_selection import StratifiedShuffleSplit
from skle... | Looks like a bug. For reference, the returned split here is `train_idx=[3, 1]; test_idx=[3, 2]`.
Supporting multi-label sounds tricky to me: what would your desired behaviour be other than simply non-overlapping? Strive for a similar ratio of all unique label sets?
Unless there is some established approach that I... | [
{
"body": "#### Description\r\nStratifiedShuffleSplit generates train and test indices which overlap when based on multilabel data.\r\n\r\n#### Steps/Code to Reproduce\r\n```python\r\nfrom sklearn.model_selection import StratifiedShuffleSplit\r\nfrom sklearn.utils.testing import assert_equal\r\n\r\nX = [['A', '... | 65792205887c37316dd7da348179652d13e79b78 | {
"head_commit": "7142ab36f816edd601b7fe9d2ff1fae728d364f0",
"head_commit_message": "regression test and fix for 2d stratified shuffle split",
"patch_to_review": "diff --git a/sklearn/model_selection/_split.py b/sklearn/model_selection/_split.py\nindex d51487cd1cb4e..d00855eef4a73 100644\n--- a/sklearn/model_sele... | [
{
"diff_hunk": "@@ -667,6 +667,15 @@ def test_stratified_shuffle_split_overlap_train_test_bug():\n assert_array_equal(np.intersect1d(train, test), [])\n \n \n+def test_stratified_shuffle_split_multilabel():\n+ # issue 9037\n+ for y in [np.array([[0, 1], [1, 0], [1, 0], [0, 1]]),",
"line": null,
... | b6ad68a4a43bd828ddf6e433d95f3b8880b89a66 | diff --git a/sklearn/model_selection/_split.py b/sklearn/model_selection/_split.py
index d51487cd1cb4e..1798269cc5926 100644
--- a/sklearn/model_selection/_split.py
+++ b/sklearn/model_selection/_split.py
@@ -1472,6 +1472,11 @@ def _iter_indices(self, X, y, groups=None):
y = check_array(y, ensure_2d=False, dty... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-9820@e540193 | spyder-ide/spyder | Python | 9,820 | PR: Update and modernize config system to support multiple types of configurations | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-07-12T13:08:45Z | Add a configuration manager to handle global user preferences and projects preferences
This configuration manager is a class that will be a direct replacement of the usual CONF. But this manager will handle which configuration to use depending if it is a global or a project situation.
Add capability of splitting th... | > The tricky part is ensuring backward compatibility.
I agree. We can't break backwards compatibility at this point. | [
{
"body": "This configuration manager is a class that will be a direct replacement of the usual CONF. But this manager will handle which configuration to use depending if it is a global or a project situation.\r\n ",
"number": 9801,
"title": "Add a configuration manager to handle global user preferences... | 3057e210f53f21e92dac7a594e15c67581d3d6d2 | {
"head_commit": "e54019379c7b4e1f7db5e3d3bdc8b670ad12f9d3",
"head_commit_message": "Refactor tests",
"patch_to_review": "diff --git a/spyder/app/mainwindow.py b/spyder/app/mainwindow.py\nindex 09298a0cd0b..c64409fdc7b 100644\n--- a/spyder/app/mainwindow.py\n+++ b/spyder/app/mainwindow.py\n@@ -95,7 +95,7 @@\n # P... | [
{
"diff_hunk": "@@ -1,23 +1,23 @@\n # -*- coding: utf-8 -*-\r\n #\r\n-# Copyright © Spyder Project Contributors\r\n+# # Copyright © Spyder Project Contributors\r",
"line": null,
"original_line": 3,
"original_start_line": null,
"path": "spyder/config/main.py",
"start_line": null,
"text": ... | 7d29396f623e6c85b56d256de5235abc61a3f526 | diff --git a/spyder/app/mainwindow.py b/spyder/app/mainwindow.py
index ad08856351d..4488ff974a0 100644
--- a/spyder/app/mainwindow.py
+++ b/spyder/app/mainwindow.py
@@ -95,7 +95,7 @@
# Proper high DPI scaling is available in Qt >= 5.6.0. This attibute must
# be set before creating the application.
#===============... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
scikit-learn__scikit-learn-8936@2cecb8d | scikit-learn/scikit-learn | Python | 8,936 | [MRG+1] fixed OOB_Score bug for bagging classifiers. | Fixes #8933
<!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
<!-- Example: Fixes #1234 -->
#### What does this impleme... | 2017-05-25T19:12:36Z | BUG: BaggingClassifier.oob_score_ should not change with class label
Let us compute the oob score of a bagged classifier.
```python
import numpy as np
import pandas as pd
from sklearn.ensemble import BaggingClassifier
from sklearn.neighbors import KNeighborsClassifier
N = 50
randState = 5
label = 'Label'
f... | I don't think BaggingClassifier uses bincount over the labels. I've not yet
grokked your issue here entirely, though
On 25 May 2017 at 01:03, JohnNapier <notifications@github.com> wrote:
> Let us compute the oob score of a bagged classifier.
>
> import numpy as npimport pandas as pdfrom sklearn.ensemble import Baggin... | [
{
"body": "Let us compute the oob score of a bagged classifier.\r\n\r\n```python\r\nimport numpy as np\r\nimport pandas as pd\r\nfrom sklearn.ensemble import BaggingClassifier\r\nfrom sklearn.neighbors import KNeighborsClassifier\r\n\r\nN = 50\r\nrandState = 5\r\nlabel = 'Label'\r\nfeatures = ['A','B','C']\r\n\... | 9131f89e6c165fb27dadd37d3168c1ee5ea84f5a | {
"head_commit": "2cecb8de8f67e124785088ea336e252f9b52d1fd",
"head_commit_message": "white space",
"patch_to_review": "diff --git a/sklearn/ensemble/bagging.py b/sklearn/ensemble/bagging.py\nindex 711d089d057d9..be55ec03206c9 100644\n--- a/sklearn/ensemble/bagging.py\n+++ b/sklearn/ensemble/bagging.py\n@@ -609,8 ... | [
{
"diff_hunk": "@@ -723,3 +723,37 @@ def test_max_samples_consistency():\n max_features=0.5, random_state=1)\n bagging.fit(X, y)\n assert_equal(bagging._max_samples, max_samples)\n+\n+\n+def test_set_oob_score():\n+ # Make sure the oob_score doesn't change when the lab... | 4fb3042a1988f357b4529b40f5159cb33bc8029a | diff --git a/sklearn/ensemble/bagging.py b/sklearn/ensemble/bagging.py
index 711d089d057d9..be55ec03206c9 100644
--- a/sklearn/ensemble/bagging.py
+++ b/sklearn/ensemble/bagging.py
@@ -609,8 +609,7 @@ def _set_oob_score(self, X, y):
oob_decision_function = (predictions /
pre... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-9792@a494b9b | spyder-ide/spyder | Python | 9,792 | PR: Preserve selected working directory in Preferences after a restart | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-07-08T23:37:51Z | Selected working directory in Preferences is not preserved after a restart
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
under preferance i chose a working directory as a start up directrory when starting spyder again reverts back to c:\users\user directory
## Vers... | @dalthviz, could you verify if this is happening to you on Windows or not?
yes windows 10
@ccordoba12 yes, testing it, it happens to me too. In the preferences, the selected woking directory shows the change but the working directory toolbar shows the home directory (after restarting Spyder manually this is what I see)... | [
{
"body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nunder preferance i chose a working directory as a start up directrory when starting spyder again reverts back to c:\\users\\user directory\n\n\n\n## Versions\n\n* Spyder version: 4.0.0b2 \n* Python... | bf027b443d228b1cd169aaa2873fcf7b6d67d746 | {
"head_commit": "a494b9b6186b89ec782df54dbdbb4549981394d8",
"head_commit_message": "fix pep8 issues",
"patch_to_review": "diff --git a/spyder/config/main.py b/spyder/config/main.py\nindex fa7231020fe..4cad80a1f28 100755\n--- a/spyder/config/main.py\n+++ b/spyder/config/main.py\n@@ -307,6 +307,9 @@\n ... | [
{
"diff_hunk": "@@ -307,6 +307,9 @@\n 'console/use_project_or_home_directory': False,\r\n 'console/use_cwd': True,\r\n 'console/use_fixed_directory': False,\r\n+ 'console/fixed_directory': '',\r\n+ 'startup/fixed_directory': '',\r",
"line":... | e512de66e3527ddf1e737e64e375f840778bf7e6 | diff --git a/pytest.ini b/pytest.ini
index 3dc01bd6caf..dfaa62c026d 100644
--- a/pytest.ini
+++ b/pytest.ini
@@ -22,3 +22,4 @@ markers =
sympy_client
cython_client
change_directory
+ use_startup_wdir: Test startup workingdir CONF
diff --git a/spyder/config/main.py b/spyder/config/main.py
index fa72310... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scrapy__scrapy-6519@decf8f4 | scrapy/scrapy | Python | 6,519 | Deprecate unused scrapy utils | Fixes #6517
This PR deprecates following unused functions and classes in `scrapy.utils`:
- `flatten`
- `iflatten`
- `equal_attributes`
- `request_authenticate`
- `ScrapyJSONDecoder`
- `assert_samelines`
I have also changed some other warnings for a grammatical uniformity
pls review this PR | 2024-10-30T21:14:53Z | Deprecate unused scrapy.utils code
As far as I can see the following functions and classes from `scrapy.utils` are not used anywhere (usually because the code using them is gone):
* `scrapy.utils.python.flatten()`
* `scrapy.utils.python.iflatten()`
* `scrapy.utils.python.equal_attributes()`
* `scrapy.utils.reques... | I'd be happy to work on this issue. I understand that the goal is to identify and remove the unused functions and classes listed above
I'll check for any remaining references across the repository to confirm that these are indeed unused and proceed with removing them.
Also, could you please let me know which spec... | [
{
"body": "As far as I can see the following functions and classes from `scrapy.utils` are not used anywhere (usually because the code using them is gone):\r\n\r\n* `scrapy.utils.python.flatten()`\r\n* `scrapy.utils.python.iflatten()`\r\n* `scrapy.utils.python.equal_attributes()`\r\n* `scrapy.utils.request.requ... | d2bdbad8c8cc5e5b4b9d3a79c94e2411a44e94be | {
"head_commit": "decf8f4e234be08b34c27fac4228316d0484089b",
"head_commit_message": "Added ignore statements for deprecation warning in tests",
"patch_to_review": "diff --git a/scrapy/utils/misc.py b/scrapy/utils/misc.py\nindex 51621834730..12c09839f0f 100644\n--- a/scrapy/utils/misc.py\n+++ b/scrapy/utils/misc.p... | [
{
"diff_hunk": "@@ -40,7 +40,7 @@ def default(self, o: Any) -> Any:\n class ScrapyJSONDecoder(json.JSONDecoder):\n def __init__(self, *args, **kwargs):\n warnings.warn(\n- \"'ScrapyJSONDecoder' is a deprecated setting.\\nIt will be removed in a future version of Scrapy.\",\n+ \... | 433bebc03ede6abf235a529e4b916446ae5c1101 | diff --git a/scrapy/utils/misc.py b/scrapy/utils/misc.py
index 51621834730..12c09839f0f 100644
--- a/scrapy/utils/misc.py
+++ b/scrapy/utils/misc.py
@@ -111,7 +111,7 @@ def md5sum(file: IO[bytes]) -> str:
"""
warnings.warn(
(
- "The scrapy.utils.misc.md5sum function is deprecated, and will... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
scikit-learn__scikit-learn-8835@4bef1da | scikit-learn/scikit-learn | Python | 8,835 | [MRG+2] LogisticRegression convert to float64 (newton-cg) | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
Fixes #8769
#### What does this implement/fix? Explain your changes.
Avoi... | 2017-05-05T17:29:53Z | LogisticRegression convert to float64
Looking at the code of LogisticRegression, I have just noticed that it converts automatically the data to float64. I would expect at least the SAG, SAGA, newton-cg and lbfgs solvers to be able to work with float32.
Also, in a similar line of thoughts, the code converts to C-orde... | I can work on this
Great! Handling float32 is not that hard: We need fused type : you can have
a look at cd_fast.pyx. Handling F ordered arrays is possible but requires
to change the way we access some arrays in place of the code where we use
explicit pointers.
On Thu, Apr 20, 2017, 5:19 PM Joan Massich <notifications... | [
{
"body": "Looking at the code of LogisticRegression, I have just noticed that it converts automatically the data to float64. I would expect at least the SAG, SAGA, newton-cg and lbfgs solvers to be able to work with float32.\r\n\r\nAlso, in a similar line of thoughts, the code converts to C-ordered data. How u... | 4397e7ec6a15ee20160be8f1aea824a6168a888a | {
"head_commit": "4bef1da728e712f405a1ee712420ca026ae5c500",
"head_commit_message": "Add a test where X.dtype is different of y.dtype",
"patch_to_review": "diff --git a/sklearn/linear_model/logistic.py b/sklearn/linear_model/logistic.py\nindex fa7bc7f32e4be..53cc391156d6b 100644\n--- a/sklearn/linear_model/logist... | [
{
"diff_hunk": "@@ -1136,3 +1136,38 @@ def test_saga_vs_liblinear():\n liblinear.fit(X, y)\n # Convergence for alpha=1e-3 is very slow\n assert_array_almost_equal(saga.coef_, liblinear.coef_, 3)\n+\n+\n+def test_dtype_match():\n+ # Test that np.float32 input da... | b80cd39b2ae6d780476091841ae4d431af6a173c | diff --git a/sklearn/linear_model/logistic.py b/sklearn/linear_model/logistic.py
index fa7bc7f32e4be..5f747ce154e5f 100644
--- a/sklearn/linear_model/logistic.py
+++ b/sklearn/linear_model/logistic.py
@@ -337,7 +337,8 @@ def _multinomial_loss_grad(w, X, Y, alpha, sample_weight):
n_classes = Y.shape[1]
n_featu... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
spyder-ide__spyder-9673@ace932a | spyder-ide/spyder | Python | 9,673 | PR: Add support to run files in external system terminal for macOS | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-06-25T06:07:11Z | Run in external system terminal doesn't work in macOS
## Description
**What steps will reproduce the problem?**
1. open python file
2. "run"->"configuration per file.."
3. set "execute in an external system terminal"
4. "run"
5. nothing happens
**What is the expected output? What do you see instead?**
I... | We don't have support for running files in system terminals in macOS, but we'll work to add it in a future release.
Thank you!
@juanis2112 I'm about to push a PR with some fixes and improvements to this feature and its tests on Windows and Linux. After that, might you perhaps be able to implement and test a code snippe... | [
{
"body": "## Description\r\n\r\n**What steps will reproduce the problem?**\r\n\r\n1. open python file\r\n2. \"run\"->\"configuration per file..\"\r\n3. set \"execute in an external system terminal\"\r\n4. \"run\"\r\n5. nothing happens\r\n\r\n**What is the expected output? What do you see instead?**\r\n\r\nI ex... | bcf1e3514a374196d7060ca992d30f8c8d6eb5e9 | {
"head_commit": "ace932ad842f0e3b14247dd42b85f21fb4e84372",
"head_commit_message": "add appscript to setup.py",
"patch_to_review": "diff --git a/continuous_integration/azure/install.sh b/continuous_integration/azure/install.sh\nindex 23bb58e76ee..efbf1651dea 100755\n--- a/continuous_integration/azure/install.sh\... | [
{
"diff_hunk": "@@ -340,7 +340,13 @@ def run_python_script_in_terminal(fname, wdir, args, interact,\n else:\r\n run_program(program['cmd'], arglist)\r\n return\r\n- # TODO: Add a fallback to OSX\r\n+ elif sys.platform == 'darwin':\r\n+ import ... | fc6171d541a7f33950ea4ecdb28f3d983d2b956d | diff --git a/spyder/utils/programs.py b/spyder/utils/programs.py
index d4c464aeecd..9b28d9c342f 100644
--- a/spyder/utils/programs.py
+++ b/spyder/utils/programs.py
@@ -22,6 +22,8 @@
import subprocess
import sys
import tempfile
+import threading
+import time
# Local imports
from spyder.config.base import ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-8802@186de45 | scikit-learn/scikit-learn | Python | 8,802 | [MRG] Fixes #8736 add get_n_splits for RepeatedKFold and RepeatedStratifiedKFold |
<!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
Fixes #8736
#### What does this implement/fix? Explain your changes.... | 2017-04-26T19:04:45Z | Bug in RepeatedKFold and RepeatedStratifiedKFold: get_n_splits missing
```python
from sklearn import svm, datasets
from sklearn.model_selection import GridSearchCV, RepeatedKFold
iris = datasets.load_iris()
parameters = {'kernel':('linear', 'rbf'), 'C':[1, 10]}
svr = svm.SVC()
clf = GridSearchCV(svr, parameters, ... | I would like to work on this. This'll be my first contribution and seems like a good bug to start with.
@akshat-harit go for it!
is this issue still open? I would like to also try to work on it... also my first contribution. ty -L
--also do you have a slack channel for first-time or new contributors?
@akshat-harit @L... | [
{
"body": "```python\r\nfrom sklearn import svm, datasets\r\nfrom sklearn.model_selection import GridSearchCV, RepeatedKFold\r\niris = datasets.load_iris()\r\nparameters = {'kernel':('linear', 'rbf'), 'C':[1, 10]}\r\nsvr = svm.SVC()\r\nclf = GridSearchCV(svr, parameters, cv=RepeatedKFold())\r\nclf.fit(iris.data... | 28a0d5605902da76cad1533ca9e7a7f4adbf6478 | {
"head_commit": "186de45bf84bc00d1652df67b5f6ea2e52c01fef",
"head_commit_message": "add get_n_splits for RepeatedKFold and RepeatedStratifiedKFold in _RepeatedSplits",
"patch_to_review": "diff --git a/sklearn/model_selection/_split.py b/sklearn/model_selection/_split.py\nindex 0eb51be93f5bb..2dc8cda3c03f9 100644... | [
{
"diff_hunk": "@@ -997,6 +997,16 @@ def split(self, X, y=None, groups=None):\n for train_index, test_index in cv.split(X, y, groups):\n yield train_index, test_index\n \n+ def get_n_splits(self):\n+ \"\"\"Returns the number of splitting iterations in the cross-validator\n+... | 090e95ad2f3ffd01cba80df152fa4ea01107250d | diff --git a/sklearn/model_selection/_split.py b/sklearn/model_selection/_split.py
index 0eb51be93f5bb..151bbafd62220 100644
--- a/sklearn/model_selection/_split.py
+++ b/sklearn/model_selection/_split.py
@@ -997,6 +997,33 @@ def split(self, X, y=None, groups=None):
for train_index, test_index in cv.split(... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-9633@61685dc | spyder-ide/spyder | Python | 9,633 | PR: Fix project workspace startup | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-06-21T04:23:17Z | Python LSP codeeditor configurations are being replaced each time a new LSP server is available
<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->
## Problem Description
Sometime... | [
{
"body": "<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->\r\n\r\n## Problem Description\r\n\r\nSometimes when two or more LSP servers are launched after restoring the previ... | 40eca93733b3c5626db11170b10db658810d5c77 | {
"head_commit": "61685dcbdb56947687be57d028bc9cb5eaf4b033",
"head_commit_message": "Remove logging messages",
"patch_to_review": "diff --git a/spyder/plugins/editor/plugin.py b/spyder/plugins/editor/plugin.py\nindex 4fd1086c4d4..384acc5c71f 100644\n--- a/spyder/plugins/editor/plugin.py\n+++ b/spyder/plugins/edit... | [
{
"diff_hunk": "@@ -287,27 +287,29 @@ def restore_scrollbar_position(self):\n def report_open_file(self, options):\r\n \"\"\"Request to start a LSP server to attend a language.\"\"\"\r\n filename = options['filename']\r\n- logger.debug('Call LSP for %s' % filename)\r\n languag... | 2e531562efbee2ddb14afe3e68afe33fe0b1cdee | diff --git a/spyder/plugins/editor/plugin.py b/spyder/plugins/editor/plugin.py
index 4fd1086c4d4..be6f9ffd6a7 100644
--- a/spyder/plugins/editor/plugin.py
+++ b/spyder/plugins/editor/plugin.py
@@ -287,27 +287,29 @@ def restore_scrollbar_position(self):
def report_open_file(self, options):
"""Request to s... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
scikit-learn__scikit-learn-9151@70d8165 | scikit-learn/scikit-learn | Python | 9,151 | [MRG + 1] ENH: new CategoricalEncoder class | This is currently simply a rebase of PR https://github.com/scikit-learn/scikit-learn/pull/6559 by @vighneshbirodkar .
Some context: this PR https://github.com/scikit-learn/scikit-learn/pull/6559 was the first of a series of PRs related to this. This PR added a CategoricalEncoder. Then it was decided, instead of add... | 2017-06-18T20:05:47Z | Pipeline doesn't work with Label Encoder
I've found that I cannot use pipelines if I wish to use the label encoder. In the following I wish to build a pipeline that first encodes the label and then constructs a one-hot encoding from that labelling.
```
from sklearn.preprocessing import OneHotEncoder, LabelEncoder
fr... | Do you mean to use `LabelBinarizer` instead? This has been a subject of complaint previously, and we should probably document this more clearly. The label "transformers" should probably not have the same interface as data transformers.
It is a bit odd that we don't have these for data, though. We have the `DictVectori... | [
{
"body": "I've found that I cannot use pipelines if I wish to use the label encoder. In the following I wish to build a pipeline that first encodes the label and then constructs a one-hot encoding from that labelling. \n\n```\nfrom sklearn.preprocessing import OneHotEncoder, LabelEncoder\nfrom sklearn.pipelin... | abb43c1aef10a3348216006f6be5e34dcd6ac157 | {
"head_commit": "70d8165fae6c9d94ec8b08a01c5129052126475b",
"head_commit_message": "Added CategoricalEncoder class - deprecating OneHotEncoder",
"patch_to_review": "diff --git a/doc/modules/classes.rst b/doc/modules/classes.rst\nindex 950a9320dd1af..601d41b682791 100644\n--- a/doc/modules/classes.rst\n+++ b/doc/... | [
{
"diff_hunk": "@@ -1197,7 +1197,7 @@ See the :ref:`metrics` section of the user guide for further details.\n preprocessing.MaxAbsScaler\n preprocessing.MinMaxScaler\n preprocessing.Normalizer\n- preprocessing.OneHotEncoder",
"line": null,
"original_line": 1200,
"original_start_line": nul... | c39aa0c289a632cd22d733195a672f3b93265c61 | diff --git a/doc/modules/classes.rst b/doc/modules/classes.rst
index 5e53e99dcc176..f1a2e973d187f 100644
--- a/doc/modules/classes.rst
+++ b/doc/modules/classes.rst
@@ -1198,6 +1198,7 @@ Model validation
preprocessing.MinMaxScaler
preprocessing.Normalizer
preprocessing.OneHotEncoder
+ preprocessing.Catego... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-8776@b2d723d | scikit-learn/scikit-learn | Python | 8,776 | [MRG] Improve the error message of export_graphviz if a not-fitted decision tree is provided | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
<!-- Example: Fixes #1234 -->
Fixes #8775
#### What does this implement/... | 2017-04-22T03:23:58Z | export_graphviz should fail with a better error message if a not-fitted decision tree is provided.
#### Description
export_graphviz should fail with a better error message if a not-fitted decision tree is provided.
#### Steps/Code to Reproduce
```python
from sklearn.tree import DecisionTreeClassifier
dtc = Dec... | I am new to your codebase but happy to try if mentoring/support is available.
Is this a matter of changing the wording, or adding a string to the standard error message for this case?
Hi @morrme, a good place to start is by looking at the code for `export_graphviz()` [here](https://github.com/scikit-learn/scik... | [
{
"body": "#### Description\r\nexport_graphviz should fail with a better error message if a not-fitted decision tree is provided.\r\n\r\n#### Steps/Code to Reproduce\r\n\r\n```python\r\nfrom sklearn.tree import DecisionTreeClassifier\r\ndtc = DecisionTreeClassifier()\r\nexport_graphviz(dtc)\r\nAttributeError: '... | 24653e8721794d47173554ec723a358a26f7300c | {
"head_commit": "b2d723d3cb8c16792560b114599684f1493f499d",
"head_commit_message": "Update export.py",
"patch_to_review": "diff --git a/sklearn/tree/export.py b/sklearn/tree/export.py\nindex 43e8aa11b9611..5462cca0676b2 100644\n--- a/sklearn/tree/export.py\n+++ b/sklearn/tree/export.py\n@@ -14,6 +14,7 @@\n impor... | [
{
"diff_hunk": "@@ -380,6 +381,12 @@ def recurse(tree, node_id, criterion, parent=None, depth=0):\n own_file = False\n return_string = False\n try:\n+ if decision_tree.tree_ is None:",
"line": null,
"original_line": 384,
"original_start_line": null,
"path": "sklearn/tree/expor... | 9008816545030f9556f92382b8f66d6ef76fa708 | diff --git a/sklearn/tree/export.py b/sklearn/tree/export.py
index 43e8aa11b9611..db89ae25d9721 100644
--- a/sklearn/tree/export.py
+++ b/sklearn/tree/export.py
@@ -14,6 +14,7 @@
import warnings
from ..externals import six
+from ..utils.validation import check_is_fitted
from . import _criterion
from . import _t... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
scrapy__scrapy-6368@60743d0 | scrapy/scrapy | Python | 6,368 | Closes #6365. Fix overridable methods in MediaPipeline | Closes #6365 | 2024-05-18T19:20:40Z | Fix overridable methods in MediaPipeline
`MediaPipeline` defines several empty or almost empty "overridable" methods, which return things inconsistent with their overrides. I propose making all of them raise `NotImplementedError`. Alternatively `MediaPipeline` should just be made an abstract class and all those methods... | A tentative proposal:
* Replace all bodies with `raise NotImplementedError()`.
* Remove all tests that test calling these methods, they are not useful for anything even now.
* Make sure nothing else broke.
* Make the methods abstract, make sure nothing broke.
* Ideally get some 3rd-party pipelines and check that... | [
{
"body": "`MediaPipeline` defines several empty or almost empty \"overridable\" methods, which return things inconsistent with their overrides. I propose making all of them raise `NotImplementedError`. Alternatively `MediaPipeline` should just be made an abstract class and all those methods made abstract metho... | 631fc65fadb874629787ae5f7fdd876b9ec96a29 | {
"head_commit": "60743d00034384ce6ec410e00f6fc7f0ad6ea8e0",
"head_commit_message": "Merge branch 'master' of https://github.com/kumar-sanchay/scrapy",
"patch_to_review": ""
} | [
{
"diff_hunk": "@@ -35,8 +31,26 @@ def _mocked_download_func(request, info):\n return response() if callable(response) else response\n \n \n+class UserDefinedPipeline(MediaPipeline):",
"line": 36,
"original_line": 36,
"original_start_line": null,
"path": "tests/test_pipeline_media.py",
"... | 40cae19c725a29aae01d7248c853fad5ed5c61b7 | diff --git a/scrapy/pipelines/media.py b/scrapy/pipelines/media.py
index fd5e70cb903..5b03731a42f 100644
--- a/scrapy/pipelines/media.py
+++ b/scrapy/pipelines/media.py
@@ -2,6 +2,7 @@
import functools
import logging
+from abc import ABC, abstractmethod
from collections import defaultdict
from typing import TYPE_... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
scrapy__scrapy-6417@32edd9c | scrapy/scrapy | Python | 6,417 | start_requests can return items | resolve https://github.com/scrapy/scrapy/issues/5289
based on code sample from https://github.com/scrapy/scrapy/issues/5289#issuecomment-1522396870
I used this сode sample to test this locally.
<details><summary>script.py</summary>
```python
import scrapy
from scrapy.crawler import CrawlerProcess
class Quo... | 2024-06-26T20:09:32Z | Better error (or support?) when yielding items from start requests
We have seen more than once users trying to yield items from the `start_requests` method.
We should consider providing a better error message in this scenario, the current one is not very helpful.
We could also consider supporting this use case in... | Example of the current situation:
<details>
<summary>
A minimal sample spider code.
</summary>
```python
#coding: utf8
import scrapy
class Test(scrapy.Spider):
name = "test"
def start_requests(self):
yield {}
```
</details>
<details>
<summary>
The full error output using Sc... | [
{
"body": "We have seen more than once users trying to yield items from the `start_requests` method.\r\n\r\nWe should consider providing a better error message in this scenario, the current one is not very helpful.\r\n\r\nWe could also consider supporting this use case instead.",
"number": 5289,
"title"... | 5794071f9679c89ef4ee75e8a627274b2464b65b | {
"head_commit": "32edd9c29d92b4288ab14473076973fb51281720",
"head_commit_message": "start_requests: test_crawl updated",
"patch_to_review": "diff --git a/scrapy/core/engine.py b/scrapy/core/engine.py\nindex 5318cbd64e7..ef1fd57baaa 100644\n--- a/scrapy/core/engine.py\n+++ b/scrapy/core/engine.py\n@@ -24,6 +24,7 ... | [
{
"diff_hunk": "@@ -328,12 +328,13 @@ def process_start_requests(self, start_requests, spider):\n class ProcessStartRequestsSimple(BaseAsyncSpiderMiddlewareTestCase):\n \"\"\"process_start_requests tests for simple start_requests\"\"\"\n \n- ITEM_TYPE = Request\n+ ITEM_TYPE = Union[Request, dict]",
... | 74be2c3905a44e0d8429d27762eedb235ad7d44b | diff --git a/docs/topics/signals.rst b/docs/topics/signals.rst
index 13e636055d8..b45b12540ff 100644
--- a/docs/topics/signals.rst
+++ b/docs/topics/signals.rst
@@ -159,8 +159,9 @@ item_scraped
:param spider: the spider which scraped the item
:type spider: :class:`~scrapy.Spider` object
- :param response... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-8527@20f9794 | scikit-learn/scikit-learn | Python | 8,527 | [MRG+2] referred reliability diagrams and added citations | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
<!-- Example: Fixes #1234 -->
Fixes #8423
#### What does this implement/... | 2017-03-04T19:56:01Z | mention "reliability diagram" in calibration docs
From the paper "Predicting Good Probabilities With Supervised Learning" it seems "reliability diagram" is a common name for the calibration curve, but it's not mentioned in the text. Googling for "reliability diagram python" looks like it doesn't exist. That's not great... | [
{
"body": "From the paper \"Predicting Good Probabilities With Supervised Learning\" it seems \"reliability diagram\" is a common name for the calibration curve, but it's not mentioned in the text. Googling for \"reliability diagram python\" looks like it doesn't exist. That's not great.\r\n\r\nAlso, we might w... | d64103f3c50a5dc5c48645d222833bfc34dea7a5 | {
"head_commit": "20f979419aa1f7470f3772f83505b374204cfb97",
"head_commit_message": "referred reliability diagrams and added citations",
"patch_to_review": "diff --git a/doc/modules/calibration.rst b/doc/modules/calibration.rst\nindex cd74f414fe3d2..44644dd169640 100644\n--- a/doc/modules/calibration.rst\n+++ b/d... | [
{
"diff_hunk": "@@ -511,7 +511,8 @@ def predict(self, T):\n \n \n def calibration_curve(y_true, y_prob, normalize=False, n_bins=5):\n- \"\"\"Compute true and predicted probabilities for a calibration curve.\n+ \"\"\"Compute true and predicted probabilities for a calibration curve also",
"line": null,
... | ab18ceaf7cd1157780611d776791e6424c09d265 | diff --git a/doc/modules/calibration.rst b/doc/modules/calibration.rst
index cd74f414fe3d2..0c0af594398a0 100644
--- a/doc/modules/calibration.rst
+++ b/doc/modules/calibration.rst
@@ -57,9 +57,9 @@ with different biases per method:
ensemble away from 0. We observe this effect most strongly with random
forests ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
spyder-ide__spyder-9582@d39101f | spyder-ide/spyder | Python | 9,582 | PR: Add validation for empty signature while getting calltip in the IPython Console | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-06-15T01:41:23Z | Error for calltip with empty signature
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
import os
os.getcwd( -> triggers calltip but an error raises
### Traceback
```python-traceback
File "C:\Users\Daniel\Anaconda3\envs\spyder4\lib\site-packages\qtconsole\base_front... | Thanks for reporting @dalthviz will fix it now
Hi @dalthviz sorry, I thought this was related to the code editor. I think you have more xp with the ipython console :-p. Could you fix it?
---
Also if I try doing on the ipython console
```python
import subprocess
subprocess.Popen(
```
I am getting
```pyth... | [
{
"body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nimport os\n\nos.getcwd( -> triggers calltip but an error raises\n\n\n### Traceback\n```python-traceback\n File \"C:\\Users\\Daniel\\Anaconda3\\envs\\spyder4\\lib\\site-packages\\qtconsole\\base_fr... | 7cd9819b766e1aafa593ac254ec11c70597c684c | {
"head_commit": "d39101fd5df2788d1a942d86f121da5612a77856",
"head_commit_message": "IPython Console: Add validation for empty signature while getting doc",
"patch_to_review": "diff --git a/spyder/plugins/ipythonconsole/widgets/help.py b/spyder/plugins/ipythonconsole/widgets/help.py\nindex 039b5f97ebb..a85586eba3... | [
{
"diff_hunk": "@@ -43,9 +43,10 @@ def get_documentation(self, content):\n text = data.get('text/plain', '')\n signature = self.get_signature(content).split('(')[-1]\n if text:\n- documentation = text.split(signature)\n- if len(documentation) > 1:\n- ... | b7c58f67a2ca701ee17552a28b84502ef8a39b59 | diff --git a/spyder/plugins/ipythonconsole/plugin.py b/spyder/plugins/ipythonconsole/plugin.py
index 60b2d8a9667..559d8f40a89 100644
--- a/spyder/plugins/ipythonconsole/plugin.py
+++ b/spyder/plugins/ipythonconsole/plugin.py
@@ -66,7 +66,7 @@
dependencies.add("cython", _("Run Cython files in the IPython Console"),
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-8437@40b304d | scikit-learn/scikit-learn | Python | 8,437 | [MRG+1] Add note about the size of a random forest model #6276 | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
Fixes #6276
#### What does this implement/fix? Explain your changes.
Add... | 2017-02-22T18:36:08Z | Need a condensed representation for storing random forest classifiers
scikit-learn version: 0.16.1
python: 3.4.4 (anaconda 2.3.0)
machine: Linux RH 6, more memory than you can shake a stick at
There should be an option to store random forest classifiers that can be used for predictions, in a condensed representation, ... | I have tried all kinds of variants, using gzip and pickle, e.g.:
def saveModel(self, fileName):
assert self.classifier is not None
try:
with gzip.open(fileName, "wb", 3) as gz:
pickle.dump(self.classifier, gz, protocol=pickle.HIGHEST_PROTOCOL)
return True
... | [
{
"body": "scikit-learn version: 0.16.1\npython: 3.4.4 (anaconda 2.3.0)\nmachine: Linux RH 6, more memory than you can shake a stick at\n\nThere should be an option to store random forest classifiers that can be used for predictions, in a condensed representation, e.g. with each decision point having the descri... | 6f771d51866972e1c8989ec33e02e984ca7b1ebb | {
"head_commit": "40b304d01b74d88724486c7341699f6be8f5ccc7",
"head_commit_message": "DOC: Add note about the size of a random forest model (See #6276)",
"patch_to_review": "diff --git a/doc/modules/ensemble.rst b/doc/modules/ensemble.rst\nindex 52f1f0bc0ff62..bc5326be8d453 100644\n--- a/doc/modules/ensemble.rst\n... | [
{
"diff_hunk": "@@ -213,6 +213,13 @@ When using bootstrap sampling the generalization accuracy can be estimated\n on the left out or out-of-bag samples. This can be enabled by\n setting ``oob_score=True``.\n \n+.. note::\n+\n+ The size of the model with the default parameters is :math:`O( M * N * log (N) )`,... | 7aee307be06602473c0f1ca05b2b037afbcdbdc2 | diff --git a/doc/modules/ensemble.rst b/doc/modules/ensemble.rst
index 52f1f0bc0ff62..12a0ff6a74ba0 100644
--- a/doc/modules/ensemble.rst
+++ b/doc/modules/ensemble.rst
@@ -213,6 +213,13 @@ When using bootstrap sampling the generalization accuracy can be estimated
on the left out or out-of-bag samples. This can be ena... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} |
scikit-learn__scikit-learn-8418@d37c248 | scikit-learn/scikit-learn | Python | 8,418 | [MRG+2] Fixed assumption fit attribute means object is estimator. | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
<!-- Example: Fixes #1234 -->
Fix https://github.com/scikit-learn/scikit-lea... | 2017-02-21T02:49:37Z | model_selection.KFold and GroupKFold cannot handle column labelled 'fit' in pandas dataframe
#### Description
When supplying a pandas dataframe to model_selection.KFold or GroupKFold the split function fails if the dataframe contains a column labelled 'fit'. Renaming the column to something other than 'fit' fixes t... | Problem seems to come from assuming that if the object has an attribute labelled 'fit' then it is an estimator, see:
https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/utils/validation.py#L95
```
def _num_samples(x):
"""Return number of samples in array-like x."""
if hasattr(x, 'fit'):
... | [
{
"body": "\r\n#### Description\r\nWhen supplying a pandas dataframe to model_selection.KFold or GroupKFold the split function fails if the dataframe contains a column labelled 'fit'. Renaming the column to something other than 'fit' fixes the issue. This is especially problematic for users of CountVectorizer... | 4493d37058938c85f78b40562e2741812b983291 | {
"head_commit": "d37c2480a7241f8b290cb7868527ab70ba187318",
"head_commit_message": "Added non-regression test for #8418",
"patch_to_review": "diff --git a/sklearn/utils/tests/test_validation.py b/sklearn/utils/tests/test_validation.py\nindex 37469f165da15..9a899add7734a 100644\n--- a/sklearn/utils/tests/test_val... | [
{
"diff_hunk": "@@ -92,7 +92,7 @@ def _is_arraylike(x):\n \n def _num_samples(x):\n \"\"\"Return number of samples in array-like x.\"\"\"\n- if hasattr(x, 'fit'):\n+ if hasattr(x, 'fit') and hasattr(x.fit, '__call__'):",
"line": null,
"original_line": null,
"original_start_line": null,
... | 6041763c192c4df9d1d88e4624389e87d7710776 | diff --git a/sklearn/utils/tests/test_validation.py b/sklearn/utils/tests/test_validation.py
index 37469f165da15..49d867a1b0bee 100644
--- a/sklearn/utils/tests/test_validation.py
+++ b/sklearn/utils/tests/test_validation.py
@@ -15,6 +15,7 @@
from sklearn.utils.testing import assert_warns_message
from sklearn.utils.t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-9571@d65a928 | spyder-ide/spyder | Python | 9,571 | PR: Fix error when launching Preferences in Chinese | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-06-14T04:26:33Z | Error when launching Preferences in Chinese
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
1. Download Spyder 4.0.0b2 from conda
2. Start Spyder
3. Launch the preference window and then an error report window shows. However, the preference window seems working ... | Please run in a terminal (cmd.exe)
spyder --reset
and try again.
>
>
> Please run in a terminal (cmd.exe)
>
> ```
> spyder --reset
> ```
>
> and try again.
All things are still the same.
Are you using Spyder in Chinese?
>
>
> Are you using Spyder in Chinese?
Yes
Ok, I guessed that. Thank... | [
{
"body": "## Description\r\n\r\n### What steps will reproduce the problem?\r\n\r\n<!--- You can use Markdown here --->\r\n\r\n1. Download Spyder 4.0.0b2 from conda\r\n2. Start Spyder\r\n3. Launch the preference window and then an error report window shows. However, the preference window seems working correctly... | eb70e6b6d8a343e950e9d8a2bfef3be0c72e4066 | {
"head_commit": "d65a928bc2470c068ee8e0ccd2390fb509557070",
"head_commit_message": "fix chinese preferences",
"patch_to_review": "diff --git a/spyder/locale/zh_CN/LC_MESSAGES/spyder.po b/spyder/locale/zh_CN/LC_MESSAGES/spyder.po\nindex 662a8d39dcf..ea7cb2d5bd2 100644\n--- a/spyder/locale/zh_CN/LC_MESSAGES/spyder... | [
{
"diff_hunk": "@@ -2422,8 +2422,8 @@ msgid \"\"\n \"please select <b>%s</b> to put graphics inside the console or <b>%s</b> to \"\n \"interact with them (through zooming and panning) in a separate window.\"\n msgstr \"\"\n-\"确定如何在控制台中显示图形。 如果不确定,请选择<b>%s</b>将图形放入控制台或<b>\"\n-\"%s</b>以在单独的窗口中与它们进行交互(如缩放和平移)。\"\n... | 741b3a93698c6b7c414b5996a31ea747057d0488 | diff --git a/spyder/locale/zh_CN/LC_MESSAGES/spyder.mo b/spyder/locale/zh_CN/LC_MESSAGES/spyder.mo
index e28a25357fd..eaca3c93a5d 100644
Binary files a/spyder/locale/zh_CN/LC_MESSAGES/spyder.mo and b/spyder/locale/zh_CN/LC_MESSAGES/spyder.mo differ
diff --git a/spyder/locale/zh_CN/LC_MESSAGES/spyder.po b/spyder/locale/... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-8328@f4039bd | scikit-learn/scikit-learn | Python | 8,328 | [MRG+1] Fixes issue #3367 -> MCD fails on data with singular covariance matrix | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
<!-- Example: Fixes #1234 -->
Fixes #3367
See Issue #4635 (my previous... | 2017-02-09T19:10:42Z | Robust covaraince (fast_mcd) does not handle singular covariance matrices
When the c_step of fast_mcd encounters a covariance matrix with a 0 determinant, it raises an error. According to the paper (Rousseeuw & Van Driessen 1999), it shouldn't be the case. Technically, 0-determinant covariance is the optimal solution. ... | Sorry for the long silence. If you are still interested a fix would be very welcome.
Hey, sorry for the long wait, I haven't taken the time to commit to this issue since I have been busy with final projects / exams. I submitted a PR which I believe fixes this issue (PR #4635), but does manage to produce some warnings ... | [
{
"body": "When the c_step of fast_mcd encounters a covariance matrix with a 0 determinant, it raises an error. According to the paper (Rousseeuw & Van Driessen 1999), it shouldn't be the case. Technically, 0-determinant covariance is the optimal solution. A singular case requires a special treatment. (Section ... | 29958d867b12048d5fa8a030a0d6259c3e676594 | {
"head_commit": "f4039bd68be2f8610bf6fbedd373501820b17875",
"head_commit_message": "Style corrections to pass flake runner\n\nImplements the style corrections as mentioned in pull request #8328",
"patch_to_review": "diff --git a/sklearn/covariance/robust_covariance.py b/sklearn/covariance/robust_covariance.py\ni... | [
{
"diff_hunk": "@@ -114,11 +115,13 @@ def _c_step(X, n_support, random_state, remaining_iterations=30,\n X_support = X[support]\n location = X_support.mean(0)\n covariance = cov_computation_method(X_support)\n+ precision = pinvh(covariance)",
"line": null,
"original_line": null,
"orig... | 270e780b448876c2d980913fb0a65f6437c165b4 | diff --git a/doc/whats_new.rst b/doc/whats_new.rst
index 32663b199833f..2122373628ea5 100644
--- a/doc/whats_new.rst
+++ b/doc/whats_new.rst
@@ -187,6 +187,12 @@ Enhancements
Bug fixes
.........
+
+ - Fixed a bug in :class:`sklearn.covariance.MinCovDet` where inputting data
+ that produced a singular covarian... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-9550@a541226 | spyder-ide/spyder | Python | 9,550 | PR: Preserve file permissions when saving in the editor | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-06-11T04:59:50Z | Overwritten file permissions on save
## Description
If one saves a file it a) cannot follow my symlink and b) removes my file permissions such that it's not executable anymore. In other words I think on each save the original file is deleted and replaced by a new one
### What steps will reproduce the problem?
Clic... | > In other words I think on each save the original file is deleted and replaced by a new one
That's correct. This is the behavior since beta2 to ensure that we write atomically on disk. The only thing we can fix is preserving file permissions but not working with symlinks.
@dalthviz, please take a look at this on... | [
{
"body": "## Description\r\nIf one saves a file it a) cannot follow my symlink and b) removes my file permissions such that it's not executable anymore. In other words I think on each save the original file is deleted and replaced by a new one\r\n\r\n### What steps will reproduce the problem?\r\nClick save\r\n... | f0e625450c6fb74347eb474989f2cab1c4099977 | {
"head_commit": "a541226574d7f3e609eb4e4ef9e32e17f4efface",
"head_commit_message": "Editor: Add support for Python 2 error handling",
"patch_to_review": "diff --git a/spyder/utils/encoding.py b/spyder/utils/encoding.py\nindex e75660f0e75..55df5cf9bc0 100644\n--- a/spyder/utils/encoding.py\n+++ b/spyder/utils/enc... | [
{
"diff_hunk": "@@ -235,10 +235,25 @@ def write(text, filename, encoding='utf-8', mode='wb'):\n with open(filename, mode) as textfile:\r\n textfile.write(text)\r\n else:\r\n+ # Based in the solution at untitaker/python-atomicwrites#42\r\n+ # Needed to fix file permissions o... | 2e1967ee9efe14eb2727b48d68133ca029860e73 | diff --git a/spyder/utils/encoding.py b/spyder/utils/encoding.py
index e75660f0e75..d719bfbb599 100644
--- a/spyder/utils/encoding.py
+++ b/spyder/utils/encoding.py
@@ -235,10 +235,21 @@ def write(text, filename, encoding='utf-8', mode='wb'):
with open(filename, mode) as textfile:
textfile.write(... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-8621@a91cf67 | scikit-learn/scikit-learn | Python | 8,621 | [MRG+1] Calculate confidence intervall only if we have enough samples |
#### Reference Issue
Fixes #8620
#### What does this implement/fix? Explain your changes.
To calculate frequentist standard errors we need at least 4 data points.
I checked for this requirement and did not enter the buggy calculation.
| 2017-03-21T11:27:36Z | sklearn.isotonic.check_increasing(x,y) crashes if len(x) < 4
The following code (scikit-learn==0.17.1):
`import numpy as np`
`from sklearn.isotonic import check_increasing`
`n = 2`
`check_increasing(np.arange(n), np.ones(n))`
crashes with the following error message:
` File "bug.py", line 4, in <module... | Indeed it is still in master. PR more than welcome. I am not sure what the right fix is to be honest.
I have done a bug fix and i am happy to push it and create a pull request | [
{
"body": "The following code (scikit-learn==0.17.1):\r\n\r\n\r\n`import numpy as np`\r\n`from sklearn.isotonic import check_increasing`\r\n`n = 2`\r\n`check_increasing(np.arange(n), np.ones(n))`\r\n\r\ncrashes with the following error message:\r\n\r\n\r\n` File \"bug.py\", line 4, in <module>`\r\n` check_i... | 05feb7e4806c71b2ae8d80ff83a8a43246592814 | {
"head_commit": "a91cf67d048e230ff18f178fd7971cdca0ee210d",
"head_commit_message": "pep8",
"patch_to_review": "diff --git a/sklearn/isotonic.py b/sklearn/isotonic.py\nindex f3e86b9813429..8930cce559189 100644\n--- a/sklearn/isotonic.py\n+++ b/sklearn/isotonic.py\n@@ -57,7 +57,7 @@ def check_increasing(x, y):\n ... | [
{
"diff_hunk": "@@ -57,7 +57,7 @@ def check_increasing(x, y):\n increasing_bool = rho >= 0\n \n # Run Fisher transform to get the rho CI, but handle rho=+/-1\n- if rho not in [-1.0, 1.0]:\n+ if (rho not in [-1.0, 1.0]) and (len(x) > 3):",
"line": null,
"original_line": 60,
"original_st... | 51f6431d2f1b85223cb88aec92074ae35e1da2b7 | diff --git a/sklearn/isotonic.py b/sklearn/isotonic.py
index f3e86b9813429..910c23508592a 100644
--- a/sklearn/isotonic.py
+++ b/sklearn/isotonic.py
@@ -57,7 +57,7 @@ def check_increasing(x, y):
increasing_bool = rho >= 0
# Run Fisher transform to get the rho CI, but handle rho=+/-1
- if rho not in [-1.0... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-8658@8b4551a | scikit-learn/scikit-learn | Python | 8,658 | [MRG] DOC: improve docstring form 'normalize' | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
<!-- Example: Fixes #1234 -->
Fixes: [#4480](https://github.com/scikit-learn... | 2017-03-28T00:07:16Z | Documentation for 'normalize' in Ridge regression somewhat unclear
For linear models with regularization, the input variables should be standardized because the solution is not scale invariant. I noticed that in the ridge regression source code, the input variables are centered by mean subtraction but normalization by ... | 1) I think our models are not consistent in this, but normalization should never hurt.
2) It affects the model. The data will not be expected to be normalized, the model will take care of this
3) I don't see why it should be possible to restrict alpha to [0, 1]. Why do you want that? alpha>1 is pretty rare, but I don't... | [
{
"body": "For linear models with regularization, the input variables should be standardized because the solution is not scale invariant. I noticed that in the ridge regression source code, the input variables are centered by mean subtraction but normalization by std deviation is a flag.\n\nMy questions are:\n1... | 5147fd09c6a063188efde444f47bd006fa5f95f0 | {
"head_commit": "8b4551a63f8fd74c563e52a9ab010da3e0b26989",
"head_commit_message": "add missing path reference",
"patch_to_review": "diff --git a/sklearn/linear_model/base.py b/sklearn/linear_model/base.py\nindex 7ac614a1cd7fe..546aaaa544919 100644\n--- a/sklearn/linear_model/base.py\n+++ b/sklearn/linear_model/... | [
{
"diff_hunk": "@@ -410,12 +410,10 @@ class LinearRegression(LinearModel, RegressorMixin):\n (e.g. data is expected to be already centered).\n \n normalize : boolean, optional, default False\n- If True, the regressors X will be normalized before regression.\n This parameter is ignored... | ce634bb558c799d92ebb7a63ee718bd206513797 | diff --git a/sklearn/linear_model/base.py b/sklearn/linear_model/base.py
index 7ac614a1cd7fe..e3f06ccce5ed0 100644
--- a/sklearn/linear_model/base.py
+++ b/sklearn/linear_model/base.py
@@ -410,14 +410,12 @@ class LinearRegression(LinearModel, RegressorMixin):
(e.g. data is expected to be already centered).
... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
spyder-ide__spyder-9526@45d74a6 | spyder-ide/spyder | Python | 9,526 | PR: Correct indentation folding cases | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-06-07T03:31:26Z | Code folding does not fold correctly when there are blank lines
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
copy this dict in the editor:
```python
responses = {
100: ('Continue', 'Request received, please continue'),
101: ('Switching Protocols',... | Thanks for reporting. We'll take a look at it in beta3.
@steff456, please take a look at this one. | [
{
"body": "## Description\r\n\r\n### What steps will reproduce the problem?\r\n\r\n<!--- You can use Markdown here --->\r\n\r\ncopy this dict in the editor:\r\n\r\n```python\r\nresponses = {\r\n 100: ('Continue', 'Request received, please continue'),\r\n 101: ('Switching Protocols','Switching to new proto... | 0675df25370f99d1b7ab544964810fd75e21f108 | {
"head_commit": "45d74a6e3942d0f6d9d809b3a9db8fd59055247b",
"head_commit_message": "remove print_tree_triggers",
"patch_to_review": "diff --git a/spyder/plugins/editor/api/folding.py b/spyder/plugins/editor/api/folding.py\nindex f6b7d6d6aa9..ff7cf62a7d4 100644\n--- a/spyder/plugins/editor/api/folding.py\n+++ b/s... | [
{
"diff_hunk": "@@ -9,49 +9,69 @@\n \"\"\"\n \n # Third party imports\n-from qtpy.QtGui import QTextCursor\n import pytest\n \n # Local imports\n-from spyder.utils.qthelpers import qapplication\n from spyder.plugins.editor.widgets.codeeditor import CodeEditor\n from spyder.plugins.editor.api.folding import prin... | 181e84d9523c0e8d63771a668f29c4f6183ffaff | diff --git a/spyder/plugins/editor/api/folding.py b/spyder/plugins/editor/api/folding.py
index f6b7d6d6aa9..ff7cf62a7d4 100644
--- a/spyder/plugins/editor/api/folding.py
+++ b/spyder/plugins/editor/api/folding.py
@@ -39,29 +39,20 @@ def print_tree(editor, file=sys.stdout, print_blocks=False, return_list=False):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-8072@ac115df | scikit-learn/scikit-learn | Python | 8,072 | [MRG + 1] Reformat the version info and cite us labels in the user-guide docs. | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
<!-- Example: Fixes #1234 -->
Fixes #7021. Closes #7036.
#### What does t... | 2016-12-18T02:20:25Z | Reformat version info and cite-us boxes in user guide
They are pretty text heavy. Maybe have a bold "cite us" at the beginning and a bold version thing. The font is very small and it doesn't really pop out. Also the line is broken in both the version and the cite us link. | Ill fix this! Probably will take me 24 hours or so!
@amueller @jnothman Is it safe to assume that the PR for this issue is abandoned? If that's the case, I would like to open a new PR since the one above has it's code in the master branch.
Yes, I think it is abandoned. | [
{
"body": "They are pretty text heavy. Maybe have a bold \"cite us\" at the beginning and a bold version thing. The font is very small and it doesn't really pop out. Also the line is broken in both the version and the cite us link.\n",
"number": 7021,
"title": "Reformat version info and cite-us boxes in... | 726c8d999a0485a3319cb32aecd0cac25dd3cc53 | {
"head_commit": "ac115dfce91c8d711edb2a62cc8f2c07891c405f",
"head_commit_message": "Reformat the version info and cite us labels in the user-guide docs.\n\n* Fix the line break in the version number.\n* Refactor the cite us sentence to have cite us in the beginning of\n the line.",
"patch_to_review": "diff --gi... | [
{
"diff_hunk": "@@ -272,9 +272,9 @@\n {% endif %}\n \n {%- if pagename != \"install\" %}\n- <p class=\"doc-version\">This documentation is for {{project}} <strong>version {{ release|e }}</strong> — <a href=\"http://scikit-learn.org/stable/support.html#documentation-resources\">Other versions<... | ba32c556dedad5d382ce44d4c893613f81794051 | diff --git a/doc/themes/scikit-learn/layout.html b/doc/themes/scikit-learn/layout.html
index b2c053f6eaf45..89c09d3180480 100644
--- a/doc/themes/scikit-learn/layout.html
+++ b/doc/themes/scikit-learn/layout.html
@@ -272,9 +272,9 @@ <h2>Machine Learning in Python</h2>
{% endif %}
{%- if pagename != "install... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
scikit-learn__scikit-learn-8586@6e44b91 | scikit-learn/scikit-learn | Python | 8,586 | [MRG+1] Change named_steps to Bunch object | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
<!-- Example: Fixes #1234 -->
Fix #8481
#### What does this implement/fi... | 2017-03-14T21:54:15Z | API for autocompletable attributes on pipeline
Many people use jupyter for data analysis. I like us to be as responsive and interactive in this environment as possible. I also like API to be discoverable by pressing <tab>.
Unfortunately it's not possible to access attributes on pipelines without writing out full nam... | I would like to work on this issue
Ipython should provide dict key completion for named_steps assist. also
note that there is a setting in ipython that generically enables completion
across complicated expressions. My Pipeline.pop proposal also makes it
easier to access last estimator attributes, and if that's our focu... | [
{
"body": "Many people use jupyter for data analysis. I like us to be as responsive and interactive in this environment as possible. I also like API to be discoverable by pressing <tab>.\r\n\r\nUnfortunately it's not possible to access attributes on pipelines without writing out full names.\r\nafaik there's two... | 134c9b732f7ac093fa97e2a7ca1bb368abea94e0 | {
"head_commit": "6e44b917d2057fa1c3d4966515b719078a997e1a",
"head_commit_message": "Add comment for named_steps usage",
"patch_to_review": "diff --git a/sklearn/pipeline.py b/sklearn/pipeline.py\nindex 61d7b12b7564d..31aa78cc9054a 100644\n--- a/sklearn/pipeline.py\n+++ b/sklearn/pipeline.py\n@@ -20,6 +20,7 @@\n ... | [
{
"diff_hunk": "@@ -20,6 +20,7 @@\n from .externals import six\n from .utils import tosequence\n from .utils.metaestimators import if_delegate_has_method\n+from .datasets.base import Bunch",
"line": null,
"original_line": 23,
"original_start_line": null,
"path": "sklearn/pipeline.py",
"start... | 3a38c19c30fb5f1799c10307c0be0350b27e2d15 | diff --git a/doc/modules/pipeline.rst b/doc/modules/pipeline.rst
index a48164b09470e..c90f35753fb00 100644
--- a/doc/modules/pipeline.rst
+++ b/doc/modules/pipeline.rst
@@ -79,6 +79,11 @@ Parameters of the estimators in the pipeline can be accessed using the
steps=[('reduce_dim', PCA(copy=True, iterated_p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
spyder-ide__spyder-9301@4addcd7 | spyder-ide/spyder | Python | 9,301 | PR: Fix hover/calltip for Python objects without signature | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-05-08T21:17:35Z | Error when getting hover of "dict"
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
I got the following error after writing
```python
dict()
```
in the editor and placing the mouse on top of it.
### Traceback
```python-traceback
at_point=self._last_point)
sign... | @goanpeca, please take a look at this one.
I'm also getting the following error when getting the signature of `dict`:
```python-traceback
parameter=parameter,
parameter=parameter,
parameter=parameter,
IndexError: tuple index out of range
Traceback (most recent call last):
msg = self.format(re... | [
{
"body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nI got the following error after writing\n\n```python\ndict()\n```\n\nin the editor and placing the mouse on top of it.\n\n### Traceback\n```python-traceback\n at_point=self._last_point)\n sig... | 7bdf210953512ec4b4bc536b1fb8e8f39f3d7292 | {
"head_commit": "4addcd7c8a490b57932a9d531d214b7b6d0eb701",
"head_commit_message": "Split and handle multiple signatures",
"patch_to_review": "diff --git a/spyder/plugins/editor/widgets/codeeditor.py b/spyder/plugins/editor/widgets/codeeditor.py\nindex 04a0620d6a3..a3884b9f746 100644\n--- a/spyder/plugins/editor... | [
{
"diff_hunk": "@@ -275,11 +275,11 @@ class CodeEditor(TextEditBaseWidget):\n lsp_response_signal = Signal(str, dict)\r\n \r\n #: Signal to display object information on the Help plugin\r\n- sig_display_object_info = Signal(str)\r\n+ sig_display_object_info = Signal(object)\r\n \r\n #: Signal ... | 6599c8e55d074c1c676d79f93c5c2afc65f9bb9f | diff --git a/spyder/plugins/editor/widgets/codeeditor.py b/spyder/plugins/editor/widgets/codeeditor.py
index 04a0620d6a3..b3d3fb6b2f8 100644
--- a/spyder/plugins/editor/widgets/codeeditor.py
+++ b/spyder/plugins/editor/widgets/codeeditor.py
@@ -279,7 +279,7 @@ class CodeEditor(TextEditBaseWidget):
#: Signal onl... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-8035@fe6d4df | scikit-learn/scikit-learn | Python | 8,035 | [MRG+1] Catch cases for different class size in MLPClassifier with warm start (#7976) | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
<!-- Example: Fixes #1234 -->
Fixes #7976
#### What does this implement/... | 2016-12-11T08:18:59Z | MLPClasiffier produce error when trying to re-fit
Hi,
I am training a MLPClasiffier model twice, each time on a different data-set.
On the second iteration the fit method produce an error. Every time a different error.
I did the processes on various models, this is the only one that produce an error.
this are ... | Could you please provide a code snippet that produces this error?
On 5 December 2016 at 01:30, yairbr <notifications@github.com> wrote:
> Hi,
>
> I am training a MLPClasiffier model twice, each time on a different
> data-set.
> On the second iteration the fit method produce an error. Every time a
> different error.
>... | [
{
"body": "Hi,\r\n\r\nI am training a MLPClasiffier model twice, each time on a different data-set.\r\nOn the second iteration the fit method produce an error. Every time a different error.\r\nI did the processes on various models, this is the only one that produce an error. \r\n\r\nthis are the errors i get (e... | 40a1b7a0b10fea2995c7aaa46c90a9633e6d99f6 | {
"head_commit": "fe6d4dff4aae743c4ae271ce287ce35ba22dee66",
"head_commit_message": "fixed pep8 violation",
"patch_to_review": "diff --git a/sklearn/neural_network/multilayer_perceptron.py b/sklearn/neural_network/multilayer_perceptron.py\nindex b3b657e09c956..c6aff72d29bc3 100644\n--- a/sklearn/neural_network/mu... | [
{
"diff_hunk": "@@ -939,6 +946,28 @@ def predict(self, X):\n \n return self._label_binarizer.inverse_transform(y_pred)\n \n+ def fit(self, X, y):\n+ \"\"\"Fit the model to data matrix X and target(s) y.\n+\n+ Parameters\n+ ----------\n+ X : array-like or sparse matrix, sha... | 7dd880967a69dba7ba45c73aa7c444ff3cb73977 | diff --git a/sklearn/neural_network/multilayer_perceptron.py b/sklearn/neural_network/multilayer_perceptron.py
index b3b657e09c956..720a3fef21d84 100644
--- a/sklearn/neural_network/multilayer_perceptron.py
+++ b/sklearn/neural_network/multilayer_perceptron.py
@@ -908,6 +908,13 @@ def _validate_input(self, X, y, increm... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-9069@8ea9afa | scikit-learn/scikit-learn | Python | 9,069 | Added distance_threshold parameter to hierarchical clustering | #### Reference Issue
Fixes #3796
#### What does this implement/fix? Explain your changes.
Hierarchical clustering now has a `distance_threshold` parameter which can be set instead of `n_clusters` and this is used to determine the number of clusters to cut the tree at.
*Note: that this works only when comput... | 2017-06-08T16:02:19Z | Hierarchical clustering: distance threshold
So, the output of hierarchichal clustering results can be determined either by number of clusters, or by the a distance thereshold to cut the tree at that threshold. However, scikit learn only supports one way!
class sklearn.cluster.AgglomerativeClustering(n_clusters=2, ...... | sure it is possible !
code is open and we always welcome good contributions...
actually there are more options for the stopping/threshold criteria:
https://docs.scipy.org/doc/scipy-0.15.1/reference/generated/scipy.cluster.hierarchy.fcluster.html#scipy.cluster.hierarchy.fcluster
http://www.mathworks.com/help/stats/clu... | [
{
"body": "So, the output of hierarchichal clustering results can be determined either by number of clusters, or by the a distance thereshold to cut the tree at that threshold. However, scikit learn only supports one way! \n\nclass sklearn.cluster.AgglomerativeClustering(n_clusters=2, ...\n\nAs a suggestion, is... | f8af325f035b662567b20dc2aaa41a20ebafb35c | {
"head_commit": "8ea9afa58586694099dbfc1731a3b1ffa97d2038",
"head_commit_message": "Changes based on review\n\n* Doc string updates for clear information\n\n* Removed redundant attribute n_clusters_\n\n* Fixed tests\n\n* Changes to FeatureAgglomeration to include distance threshold",
"patch_to_review": "diff --g... | [
{
"diff_hunk": "@@ -527,11 +529,44 @@ def test_agg_n_clusters():\n \n rng = np.random.RandomState(0)\n X = rng.rand(20, 10)\n- for n_clus in [-1, 0]:\n- agc = AgglomerativeClustering(n_clusters=n_clus)\n- msg = (\"n_clusters should be an integer greater than 0.\"\n- \" %s ... | 8060020fa4640670f863c3f01736ae8dc5589d9d | diff --git a/doc/modules/clustering.rst b/doc/modules/clustering.rst
index 0043ce5c4e36c..60ced6cea7bac 100644
--- a/doc/modules/clustering.rst
+++ b/doc/modules/clustering.rst
@@ -73,13 +73,13 @@ Overview of clustering methods
- Graph distance (e.g. nearest-neighbor graph)
* - :ref:`Ward hierarchical clust... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
spyder-ide__spyder-9384@1400dcd | spyder-ide/spyder | Python | 9,384 | PR: Add fuzzy search to the Variable Explorer | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-05-21T17:54:16Z | Add fuzzy search functionality to the Variable Explorer
It is hard to explain so let me present a scenario:
You are researching and have many dataframes with various names in your current session. you want to look at some dataframe you just created. printing it is rarely helpful.
Right now, I search for my dataframe ... | Cool suggestion!! We'll try to work on it for Spyder 4 :-)
Or you could give it a try for Spyder 3. We already have a fuzzy search library, so it'd be a matter of using that library with the variable explorer.
@goanpeca, what do you think? Should we try to add this in Spyder 3.2?
@ccordoba12 yep sounds like a good i... | [
{
"body": "It is hard to explain so let me present a scenario:\r\nYou are researching and have many dataframes with various names in your current session. you want to look at some dataframe you just created. printing it is rarely helpful.\r\nRight now, I search for my dataframe in the variable explorer and open... | 729948910994ba7e48a58b50a6bf77c611cb91b3 | {
"head_commit": "1400dcd5a3bc359fd5f5ac0500a785ca0d10dc21",
"head_commit_message": "Variable Explorer: Fix code style issues",
"patch_to_review": "diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py\nindex cdf2f585a05..3c55407f91a 100644\n--- a/spyder/app/tests/test_mainwindow.... | [
{
"diff_hunk": "@@ -322,11 +332,30 @@ def get_bgcolor(self, index):\n color.setAlphaF(.3)\r\n return color\r\n \r\n+ def update_search_letters(self, text):\r\n+ \"\"\"Update search letters with text input in search box.\"\"\"\r\n+ self.letters = text\r\n+ names = self... | e2f75469c3371b6816688b18589930b9f61f2d75 | diff --git a/spyder/app/tests/test_mainwindow.py b/spyder/app/tests/test_mainwindow.py
index bda9c7ad38f..75891895bac 100644
--- a/spyder/app/tests/test_mainwindow.py
+++ b/spyder/app/tests/test_mainwindow.py
@@ -108,7 +108,7 @@ def reset_run_code(qtbot, shell, code_editor, nsb):
"""Reset state after a run code te... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
scrapy__scrapy-5971@1466e42 | scrapy/scrapy | Python | 5,971 | fix: -O/-o option does not work with absolute paths on Windows | fix #5969 | 2023-07-11T03:49:56Z | crawl -o and -O options does not work with absolute paths on Windows
Absolute paths on Windows has `:` as a part of disk names which leads to unexpected behaviour.
# Steps to Reproduce
Case 1: run command `scrapy crawl spider_name -O "C:\path\to\output.json"`
Case 2: run command `scrapy crawl spider_name -O "C... | [
{
"body": "Absolute paths on Windows has `:` as a part of disk names which leads to unexpected behaviour.\r\n\r\n# Steps to Reproduce\r\n\r\nCase 1: run command `scrapy crawl spider_name -O \"C:\\path\\to\\output.json\"`\r\n\r\nCase 2: run command `scrapy crawl spider_name -O \"C:\\path\\to\\output.json:json\"`... | 8055a948dc2544c4d8ebe7aa1c6227e19b1583ac | {
"head_commit": "1466e42da64366d1f88e12cfeb23607f60ced69c",
"head_commit_message": "fix: -O/-o option does not work with absolute paths on Windows",
"patch_to_review": "diff --git a/scrapy/extensions/feedexport.py b/scrapy/extensions/feedexport.py\nindex 1cdc78f5915..d30b45682a9 100644\n--- a/scrapy/extensions/f... | [
{
"diff_hunk": "@@ -617,7 +617,7 @@ def _get_storage(self, uri, feed_options):\n It supports not passing the *feed_options* parameters to classes that\n do not support it, and issuing a deprecation warning instead.\n \"\"\"\n- feedcls = self.storages[urlparse(uri).scheme]\n+ ... | 4bd3060851a95145e3a13b6dc7244540dedebab8 | diff --git a/scrapy/extensions/feedexport.py b/scrapy/extensions/feedexport.py
index 1cdc78f5915..3bf64dc1289 100644
--- a/scrapy/extensions/feedexport.py
+++ b/scrapy/extensions/feedexport.py
@@ -9,7 +9,7 @@
import sys
import warnings
from datetime import datetime
-from pathlib import Path
+from pathlib import Path... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
spyder-ide__spyder-9203@d9c9f73 | spyder-ide/spyder | Python | 9,203 | PR: Add option to connect to external PyLS servers | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-04-25T04:53:35Z | Cannot connect to an external PyLS server
<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->
## Problem Description
The new menu does not allow to connect to an external PyLS serve... | @dalthviz, I was wrong when I instructed you to assume that external servers can only live in external machines. As @steff456 pointed out, external servers are simply servers started outside Spyder.
So to fix this we need to add a new checkbox in `Completion and linting > Advanced Setttings` (below the current optio... | [
{
"body": "<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->\r\n## Problem Description\r\n\r\nThe new menu does not allow to connect to an external PyLS server. \r\n\r\n### Wh... | be98b086f95968fccc4e8dbe3f1140154c94a412 | {
"head_commit": "d9c9f73245269b6ef33eaacde12b14ba802bbcc9",
"head_commit_message": "LSP: Fix lsp-client restart after changing options for python",
"patch_to_review": "diff --git a/spyder/config/main.py b/spyder/config/main.py\nindex 0948fd1cbe2..52659a26dcf 100755\n--- a/spyder/config/main.py\n+++ b/spyder/conf... | [
{
"diff_hunk": "@@ -82,7 +82,7 @@ def get_language_config(self, language):\n \"\"\"Get language configuration options from our config system.\"\"\"\n if language == 'python':\n self.update_python_config()\n- return self.python_config\n+ return self.python_config... | deffd340256c7339aa7c29e4a251796c2a0cf979 | diff --git a/spyder/config/main.py b/spyder/config/main.py
index 0948fd1cbe2..52659a26dcf 100755
--- a/spyder/config/main.py
+++ b/spyder/config/main.py
@@ -698,6 +698,7 @@
'advanced/command_launch': 'pyls',
'advanced/host': '127.0.0.1',
'advanced/port': 2087,
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scrapy__scrapy-5929@034ff77 | scrapy/scrapy | Python | 5,929 | Configurable exception list retry middleware 2701 | Resolves https://github.com/scrapy/scrapy/issues/2701, closes https://github.com/scrapy/scrapy/pull/2984, closes https://github.com/scrapy/scrapy/pull/3334. | 2023-05-09T15:17:38Z | Make Exceptions Handled by Retry Middleware Configurable
I was having troubles finding which exceptions are handled by Retry Middleware, so I asked on freenode scrapy irc channel (should obviously check the source code). Paul from scrapinhub helped me there and pointed me to the source code.
Beside that he also ask... | Hi,
Since this is tagged as an as 'help-wanted' and 'enhancement', I think the help wanted here is to make the exceptions handled configurable. I'd like to work on this.
I think the way the exceptions should be made configurable is to allow the user to exclude certain exceptions rather than add exceptions, since w... | [
{
"body": "I was having troubles finding which exceptions are handled by Retry Middleware, so I asked on freenode scrapy irc channel (should obviously check the source code). Paul from scrapinhub helped me there and pointed me to the source code. \r\n\r\nBeside that he also asked me to open an issue here.\r\nHe... | 52c072640aa61884de05214cb1bdda07c2a87bef | {
"head_commit": "034ff77a9594276738e1d990705beb41c8b8fbd8",
"head_commit_message": "Fix #5929",
"patch_to_review": "diff --git a/docs/topics/downloader-middleware.rst b/docs/topics/downloader-middleware.rst\nindex 7665a901a7e..4b53838548a 100644\n--- a/docs/topics/downloader-middleware.rst\n+++ b/docs/topics/dow... | [
{
"diff_hunk": "@@ -110,7 +112,34 @@ def test_twistederrors(self):\n == 2\n )\n \n- def _test_retry_exception(self, req, exception):\n+ def test_exception_to_retry_added(self):\n+ exc = ValueError\n+ self.mw.exceptions_to_retry = self.mw.exceptions_to_retry + (exc,)\n+ ... | 9aaa0ebbfb3c83fc77f323f29d11a4f9a425fd9f | diff --git a/docs/topics/downloader-middleware.rst b/docs/topics/downloader-middleware.rst
index 7665a901a7e..a8e5b23bf92 100644
--- a/docs/topics/downloader-middleware.rst
+++ b/docs/topics/downloader-middleware.rst
@@ -915,6 +915,7 @@ settings (see the settings documentation for more info):
* :setting:`RETRY_ENABLED... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
scrapy__scrapy-5851@3e59b08 | scrapy/scrapy | Python | 5,851 | #5109 extend contributing.rst | Closes #5109. May need some formatting on links or rewrite. | 2023-03-16T13:05:26Z | Starting contributing
Hello everybody. I am a Brazilian student at UTFPR. I would like to contribute with Scrapy and I would like to ask someone to refer me to an issue to start, most of the issues I saw are already in progress or have been finalized. Thanks | This is a common problem in Scrapy. Whenever we tag an issue as a “good first issue”, someone new often starts working on it no longer after.
Some of those listed in https://github.com/scrapy/scrapy/contribute do not have pull requests targeting them, but they are all about improving the documentation.
Anything t... | [
{
"body": "Hello everybody. I am a Brazilian student at UTFPR. I would like to contribute with Scrapy and I would like to ask someone to refer me to an issue to start, most of the issues I saw are already in progress or have been finalized. Thanks",
"number": 5109,
"title": "Starting contributing "
}
... | d60b4edd11436e61284615ec7ce89f8ac7e46d9a | {
"head_commit": "3e59b0805e8f7a9bd89179203a1307f5cb7fc02a",
"head_commit_message": "#5109 extend contributing.rst",
"patch_to_review": "diff --git a/docs/contributing.rst b/docs/contributing.rst\nindex 6b1a4133984..cbfcc375194 100644\n--- a/docs/contributing.rst\n+++ b/docs/contributing.rst\n@@ -11,6 +11,19 @@ C... | [
{
"diff_hunk": "@@ -11,6 +11,19 @@ Contributing to Scrapy\n \n There are many ways to contribute to Scrapy. Here are some of them:\n \n+* Contribute to Scrapy by fixing currently available issues in the repository.\n+ Scrapy has a list of `good first issues`_ and `help wanted issues`_ that you\n+ can work on.... | af730df83c74296ec2e831417278b21952b098f7 | diff --git a/docs/contributing.rst b/docs/contributing.rst
index 6b1a4133984..eef92e14881 100644
--- a/docs/contributing.rst
+++ b/docs/contributing.rst
@@ -11,10 +11,6 @@ Contributing to Scrapy
There are many ways to contribute to Scrapy. Here are some of them:
-* Blog about Scrapy. Tell the world how you're usin... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} |
scikit-learn__scikit-learn-7889@69f9207 | scikit-learn/scikit-learn | Python | 7,889 | [MRG + 1] Fix the cross_val_predict function for method='predict_proba' | #### Reference Issue
Fixes #7863
#### What does this implement/fix? Explain your changes.
cross_val_predict() did not specify the order of the classes when method='predict_proba' was passed as the argument. So firstly, the change mentions in the documentation that the columns returned would be sorted. Secondly, f... | 2016-11-16T13:08:55Z | order of returned probabilites unclear for cross_val_predict with method=predict_proba
Cross_val_predict has a new method parameter which is typically set to "predict_proba" to return probabilities for each class.
However the order of the classes returned is unclear. Either self.classes_ needs to be set; or the resu... | Yes, I suppose this (and disagreements in the set of classes between splits) was overlooked.
(For internal models, I'm fairly sure that `classes_` is always alphabetically ordered.)
Can I start working on this?
After running a few tests on the iris dataset using LogisticRegression as the estimator, it became clear t... | [
{
"body": "Cross_val_predict has a new method parameter which is typically set to \"predict_proba\" to return probabilities for each class.\r\n\r\nHowever the order of the classes returned is unclear. Either self.classes_ needs to be set; or the results need to be returned in a predictable order. Otherwise we h... | 9dfe0189fae6edfe7be8e64296d4454547a7c1c4 | {
"head_commit": "69f9207bf68341e5db081109eca3018025996808",
"head_commit_message": "FIX: fixed _fit_and_predict and added tests",
"patch_to_review": "diff --git a/sklearn/model_selection/_validation.py b/sklearn/model_selection/_validation.py\nindex 23db2a9cebc77..329f7308988a3 100644\n--- a/sklearn/model_select... | [
{
"diff_hunk": "@@ -474,6 +476,18 @@ def _fit_and_predict(estimator, X, y, train, test, verbose, fit_params,\n estimator.fit(X_train, y_train, **fit_params)\n func = getattr(estimator, method)\n predictions = func(X_test)\n+ if method in ['decision_function', 'predict_proba', 'predict_log_pro... | 933ef9bf6e3fb27b560bf0ed748415f7c59baf2e | diff --git a/doc/whats_new.rst b/doc/whats_new.rst
index cd6789bb1f805..367220a15d29b 100644
--- a/doc/whats_new.rst
+++ b/doc/whats_new.rst
@@ -73,6 +73,10 @@ Enhancements
Bug fixes
.........
+ - :func:`model_selection.cross_val_predict` now returns output of the
+ correct shape for all values of the argumen... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
scikit-learn__scikit-learn-8120@373e5a5 | scikit-learn/scikit-learn | Python | 8,120 | [MRG+1] Repeated K-Fold and Repeated Stratified K-Fold | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
Fixes #7948
#### What does this implement/fix? Explain your changes.
I... | 2016-12-27T07:33:32Z | repeated k-fold
We should add repeated k-fold cross-validation. It's something a lot of people use, and it's tricky to implement in scikit-learn. In particular with the recent changes to cross-validation,
```python
cv = KFold(shuffle=True)
results = []
for i in range(10):
results.append(cross_val_score(est, ... | Do you want to be repeating the *same* splits? In all of 0.17, 0.18.0,
0.18.1 and master this will produce different splits in each call to
cross_val_score, but not if random_state is an int. The difference in
0.18.0 is that in GridSearchCV each parameter would use different splits. I
think #7935 would change this to p... | [
{
"body": "We should add repeated k-fold cross-validation. It's something a lot of people use, and it's tricky to implement in scikit-learn. In particular with the recent changes to cross-validation,\r\n\r\n```python\r\ncv = KFold(shuffle=True)\r\nresults = []\r\nfor i in range(10):\r\n results.append(cross_... | 75c892c41318f82252d00da890206f592ce605e4 | {
"head_commit": "373e5a5c51b6c6d13a02cb3984ab2e3dfdb25053",
"head_commit_message": "Remove blank line, put testcases for deterministic split in loop and add StopIteration check in testcase",
"patch_to_review": "diff --git a/doc/modules/classes.rst b/doc/modules/classes.rst\nindex 3aee8f258b9d1..3101488fd6661 100... | [
{
"diff_hunk": "@@ -913,6 +920,165 @@ def get_n_splits(self, X, y, groups):\n return int(comb(len(np.unique(groups)), self.n_groups, exact=True))\n \n \n+class _RepeatedSplits(with_metaclass(ABCMeta)):\n+ \"\"\"Repeated splits for an arbitrary randomized CV splitter.\n+\n+ Repeats splits for cross... | 338997eaba8bbf42ba4c54f7ff61f8f7bcacca91 | diff --git a/doc/modules/classes.rst b/doc/modules/classes.rst
index 3aee8f258b9d1..3101488fd6661 100644
--- a/doc/modules/classes.rst
+++ b/doc/modules/classes.rst
@@ -170,6 +170,8 @@ Splitter Classes
model_selection.LeavePGroupsOut
model_selection.LeaveOneOut
model_selection.LeavePOut
+ model_selection.... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
scikit-learn__scikit-learn-7685@e3acdbf | scikit-learn/scikit-learn | Python | 7,685 | [MRG+1] Made PCA expose the singular values | <!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests
-->
#### Reference Issue
<!-- Example: Fixes #1234 -->
Fixes #6955.
#### What does this implement/fix? Ex... | 2016-10-17T13:23:18Z | Store singular values in PCA instances
Is there a particular reason why classes such as PCA, TruncatedPCA do not store the singular values as instance variables after they have been computed? It would seem useful to store them since they are already computed so that they can be later accessed if need be. One use case w... | From a quick look at it, it looks like you can compute them from the `explained_variance_` attribute.
``` py
n_samples = X.shape[0]
self.explained_variance_ = (S ** 2) / n_samples
```
`S` being the diagonal matrix with the singular values.
True, but a few comments:
- It should be possible to access the singular valu... | [
{
"body": "Is there a particular reason why classes such as PCA, TruncatedPCA do not store the singular values as instance variables after they have been computed? It would seem useful to store them since they are already computed so that they can be later accessed if need be. One use case would be to scale the... | 10323f5a377f378f3b4d79ec9cd36d27d79bbb31 | {
"head_commit": "e3acdbf91b5298ada17e7b9c16e650dc25f5293c",
"head_commit_message": "ENH: Added the singular values to PCA by a singular_values_ instance variable as per Issue #6955.",
"patch_to_review": "diff --git a/sklearn/decomposition/incremental_pca.py b/sklearn/decomposition/incremental_pca.py\nindex d95c4... | [
{
"diff_hunk": "@@ -663,6 +686,7 @@ def _fit(self, X):\n self.explained_variance_ = exp_var = (S ** 2) / n_samples\n full_var = np.var(X, axis=0).sum()\n self.explained_variance_ratio_ = exp_var / full_var\n+ self.singular_values_ = S.copy() # Store the singular values.",
"li... | b5a6356593e01602bb747528c9ce09caff712a05 | diff --git a/doc/whats_new.rst b/doc/whats_new.rst
index 73d7a9e5471b4..3804f5c01c26c 100644
--- a/doc/whats_new.rst
+++ b/doc/whats_new.rst
@@ -22,6 +22,11 @@ New features
Enhancements
............
+ - :class:`decomposition.PCA`, :class:`decomposition.IncrementalPCA` and
+ :class:`decomposition.TruncatedSVD`... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
spyder-ide__spyder-8222@46fca0b | spyder-ide/spyder | Python | 8,222 | PR: Save last accepted kernel settings in config | <!--- Before submitting your pull request, --->
<!--- please complete as much as practicable of the following checklist: --->
### Pull Request Checklist
* [x] Read and followed this repo's [Contributing Guidelines](https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md)
* [x] Based this PR on the late... | 2018-11-10T22:57:32Z | How to remember the configurations of connecting to remote kernel?
Hello,
I can update that remote kernel josn manually,but how to remember the configurations(remote kernel json file location,host,ssh key file location,password) of connectiong to remote kernel?Then I don't need to configure it manually every ti... | There's no option to do that right now, but it's an interesting suggestion. We'll work on it for a future Spyder version :-)
Second that; it's a hassle typing everything again each time since I am connecting through SSH. Maybe add a "save password" option, too. | [
{
"body": "Hello,\r\n I can update that remote kernel josn manually,but how to remember the configurations(remote kernel json file location,host,ssh key file location,password) of connectiong to remote kernel?Then I don't need to configure it manually every time.",
"number": 3689,
"title": "How to... | bbcbf6db0479f83ffd14249921e90d4b61067970 | {
"head_commit": "46fca0bdc945c31898aebedde48cc3ac740c9fc4",
"head_commit_message": "Connected save_connection_settings to accept button\n\nAdded test cases for remembering password, and not remembering settings if checkbox is unchecked\nAdded proper teardown\nClick ok button in test cases instead of calling save_c... | [
{
"diff_hunk": "@@ -0,0 +1,298 @@\n+# -*- coding: utf-8 -*-\n+# -----------------------------------------------------------------------------\n+# Copyright © Spyder Project Contributors\n+#\n+# Licensed under the terms of the MIT License\n+# (see spyder/__init__.py for details)\n+# -----------------------------... | 02055cf43351ad37df2b158a32ab8db85c8570f3 | diff --git a/spyder/plugins/ipythonconsole/widgets/kernelconnect.py b/spyder/plugins/ipythonconsole/widgets/kernelconnect.py
index c035925e0cc..d4f73eed895 100644
--- a/spyder/plugins/ipythonconsole/widgets/kernelconnect.py
+++ b/spyder/plugins/ipythonconsole/widgets/kernelconnect.py
@@ -15,12 +15,14 @@
from jupyter_c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
scrapy__scrapy-5782@cb485ee | scrapy/scrapy | Python | 5,782 | test_install_asyncio_reactor: restore the original reactor when done | Fixes https://github.com/scrapy/scrapy/issues/5765 | 2023-01-02T14:18:55Z | AsyncioTest failures
There are two new failing tests (`AsyncioTest.test_install_asyncio_reactor` and `AsyncioTest.test_is_asyncio_reactor_installed`) on 3.10 and 3.11, and it looks like they started failing after updating to 3.10.9 and 3.11.1 (it may be a coincidence though). I see an asyncio-related change in those ve... | Disabling `test_install_asyncio_reactor` makes `test_is_asyncio_reactor_installed` pass; I suspect that the former now installs the reactor when previously it didn't (initially this test had a comment "does nothing" but I don't remember why did this call do nothing), this needs future investigation. It may actually jus... | [
{
"body": "There are two new failing tests (`AsyncioTest.test_install_asyncio_reactor` and `AsyncioTest.test_is_asyncio_reactor_installed`) on 3.10 and 3.11, and it looks like they started failing after updating to 3.10.9 and 3.11.1 (it may be a coincidence though). I see an asyncio-related change in those vers... | deaf1fb6cf513db8119acfe70fd3e08f761f7ede | {
"head_commit": "cb485ee85f5af5e415586b23617390a8b45c816d",
"head_commit_message": "Sturdier fix for asyncio warning",
"patch_to_review": "diff --git a/scrapy/utils/reactor.py b/scrapy/utils/reactor.py\nindex e6b8de292ef..853c85b2749 100644\n--- a/scrapy/utils/reactor.py\n+++ b/scrapy/utils/reactor.py\n@@ -90,11... | [
{
"diff_hunk": "@@ -90,11 +90,16 @@ def set_asyncio_event_loop(event_loop_path):\n asyncio.set_event_loop(event_loop)\n else:\n try:\n+ asyncio.get_running_loop()\n event_loop = policy.get_event_loop()\n except RuntimeError:\n- # `get_event_loop` is ... | 66417d85d02e5ff4ae95a98d9c283dfd70f956a9 | diff --git a/scrapy/utils/defer.py b/scrapy/utils/defer.py
index ddacfaa49a9..0da2e363898 100644
--- a/scrapy/utils/defer.py
+++ b/scrapy/utils/defer.py
@@ -26,7 +26,7 @@
from twisted.python.failure import Failure
from scrapy.exceptions import IgnoreRequest
-from scrapy.utils.reactor import is_asyncio_reactor_insta... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
spyder-ide__spyder-7107@278db3f | spyder-ide/spyder | Python | 7,107 | PR: Show group cells in Outline Explorer | ### Pull Request Checklist
* [x] Read and followed this repo's [Contributing Guidelines](https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md)
* [x] Based your PR on the latest version of the correct branch (master or 3.x)
* [x] Followed [PEP8](https://www.python.org/dev/peps/pep-0008/) for code style
... | 2018-05-11T16:52:51Z | Grouping cells in Outline without code indentation
## Problem Description
Spyders Outline works well most of the time with cells and grouping by indentation to represent the code. Sometimes, manual setting would be advantageous (e.g. group functions desfined at top). See example..
### What steps reproduce the p... | So you want to define cells with indented code? Sorry, but I don't follow exactly what you mean.
@ccordoba12 I believe what the OP is suggesting is a way to get functions (etc.) grouped into collapsible sections by cell, like Cell 2 in the screenshot, without having to manually indent the code. Perhaps an option to tha... | [
{
"body": "## Problem Description\r\n\r\nSpyders Outline works well most of the time with cells and grouping by indentation to represent the code. Sometimes, manual setting would be advantageous (e.g. group functions desfined at top). See example..\r\n\r\n\r\n### What steps reproduce the problem?\r\n\r\nAdd the... | 5a9f81a1000cf5b7800fcc001e7ffe81b3ad32be | {
"head_commit": "278db3fe8280f8fdfc22464280ca7db0525d7be0",
"head_commit_message": "Group fuctions in cells and make sub cell",
"patch_to_review": "diff --git a/spyder/utils/syntaxhighlighters.py b/spyder/utils/syntaxhighlighters.py\nindex 14849892e04..ec317b39daf 100644\n--- a/spyder/utils/syntaxhighlighters.py... | [
{
"diff_hunk": "@@ -478,7 +479,12 @@ def highlight_block(self, text):\n self.found_cell_separators = True\r\n oedata = OutlineExplorerData()\r\n oedata.text = to_text_string(text).strip()\r\n- ... | 635d48a97d807089191246a1c27290b881f451cf | diff --git a/spyder/utils/syntaxhighlighters.py b/spyder/utils/syntaxhighlighters.py
index 14849892e04..7f1570b132d 100644
--- a/spyder/utils/syntaxhighlighters.py
+++ b/spyder/utils/syntaxhighlighters.py
@@ -478,6 +478,14 @@ def highlight_block(self, text):
self.found_cell_separators =... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
spyder-ide__spyder-8598@dc394ea | spyder-ide/spyder | Python | 8,598 | PR: Enclose contents of load_more_data method in try/except NameError Block | <!--- Make sure to read the Contributing Guidelines: --->
<!--- https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md --->
<!--- and follow PEP 8, PEP 257 and Spyder's code style: --->
<!--- https://github.com/spyder-ide/spyder/wiki/Dev:-Coding-Style --->
## Descrip... | 2019-01-19T21:55:29Z | Error when closing dataframe while data is being fetched
## Description
### What steps will reproduce the problem?
<!--- You can use Markdown here --->
I was using the data viewer to open a pandas DataFrame with shape = (1788, 3), after I closed the data viewer, this error appeared.
### Traceback
```python-tracebac... | Thanks for reporting. We'll take a look at this in a future release.
Note: This happens when users are scrolling a big dataframe and closing it before it gets all the data that's being fetched.
@juanis2112, this is an easy one for you. Please enclose the entire contents of the `load_more_data` method, placed here:
h... | [
{
"body": "## Description\n\n### What steps will reproduce the problem?\n\n<!--- You can use Markdown here --->\n\nI was using the data viewer to open a pandas DataFrame with shape = (1788, 3), after I closed the data viewer, this error appeared.\n\n### Traceback\n```python-traceback\n File \"C:\\ProgramData\\... | 4db4465f09c8d48cc26dc7feed539db532ea4677 | {
"head_commit": "dc394eae37d8519e406583de5910222b30a3f4f7",
"head_commit_message": "Enclose contents of load_more_data method in try/except NameError Block",
"patch_to_review": "diff --git a/spyder/plugins/variableexplorer/widgets/arrayeditor.py b/spyder/plugins/variableexplorer/widgets/arrayeditor.py\nindex 261... | [
{
"diff_hunk": "@@ -511,12 +511,16 @@ def __init__(self, parent, model, header, hscroll, vscroll):\n \r\n def load_more_data(self, value, rows=False, columns=False):\r\n \"\"\"Load more rows and columns to display.\"\"\"\r\n- if rows and value == self.verticalScrollBar().maximum():\r\n- ... | d83030d446d0e7dab8a5f39ca65eb28fdcc6419e | diff --git a/spyder/plugins/variableexplorer/widgets/arrayeditor.py b/spyder/plugins/variableexplorer/widgets/arrayeditor.py
index 261bd081384..3f9ea1d3603 100644
--- a/spyder/plugins/variableexplorer/widgets/arrayeditor.py
+++ b/spyder/plugins/variableexplorer/widgets/arrayeditor.py
@@ -418,39 +418,48 @@ def __init__(... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-5497@fd3d9fe | spyder-ide/spyder | Python | 5,497 | PR: Add option to toggle code style checks from Source menu | Fixes #5488
A pull request that fixes issue #5488
| 2017-10-18T05:05:55Z | Code style (pep8) toggle in source menu
## Issue
I often find myself switching the code style warnings on as off as I switch between files and I think it's about 6 clicks through the preferences to get at it.
I often write scripts for figures or data crunching that are one offs and the pep8 is just noise.
For ... | > Add a Code Style Warnings (PEP8) toggle in the source menu.
I like this idea, thanks for the suggestion.
> I just found the # analysis:ignore comment. A # analysis:ignore_all might be handy too.
That's provided by `pyflakes` (I think) so you should google a bit to see if there's a `# analysis:ignore_all` kin... | [
{
"body": "## Issue\r\n\r\nI often find myself switching the code style warnings on as off as I switch between files and I think it's about 6 clicks through the preferences to get at it.\r\n\r\nI often write scripts for figures or data crunching that are one offs and the pep8 is just noise.\r\n\r\nFor code that... | 5ef708a5ef5ac1e9951f10bfdaa3f0f505abb4e0 | {
"head_commit": "fd3d9fe9aa76fd567eb7513756f93dd597b378da",
"head_commit_message": "Add option to toggle code style checks from source menu",
"patch_to_review": "diff --git a/spyder/plugins/editor.py b/spyder/plugins/editor.py\nindex 7d152c0db5c..fb26d08f07d 100644\n--- a/spyder/plugins/editor.py\n+++ b/spyder/p... | [
{
"diff_hunk": "@@ -1020,11 +1020,16 @@ def get_plugin_actions(self):\n _(\"Show selector for classes and functions.\"),\r\n 'show_class_func_dropdown', 'set_classfunc_dropdown_visible')\r\n \r\n+ showcode_analysis_pep8_action = self._create_checkable_action(\r\n+ ... | a9276067d93d900056077b21e0b2cf5a4f41ac11 | diff --git a/spyder/plugins/editor.py b/spyder/plugins/editor.py
index 7d152c0db5c..bd36aa0c58d 100644
--- a/spyder/plugins/editor.py
+++ b/spyder/plugins/editor.py
@@ -1020,11 +1020,16 @@ def get_plugin_actions(self):
_("Show selector for classes and functions."),
'show_class_func_dr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Style, Linting, Formatting Fixes"
} |
scrapy__scrapy-5689@71406dd | scrapy/scrapy | Python | 5,689 | Get eventloop from event_loop_policy to avoid deprecation warning. | Fixes #5685
Use `policy.get_event_loop()` instead of `asyncio.get_event_loop()`.
If there is no event loop running, policy will create new_event_loop.
| 2022-10-24T16:54:02Z | DeprecationWarning: There is no current event loop
```
/home/runner/work/scrapy/scrapy/scrapy/utils/reactor.py:70: DeprecationWarning: There is no current event loop
event_loop = asyncio.get_event_loop()
tests/test_downloadermiddleware.py: 2 warnings
tests/test_utils_asyncgen.py: 2 warnings
tests/test_utils_defe... | > asyncio.get_event_loop() now emits a deprecation warning if there is no running event loop. In the future it will be an alias of get_running_loop(). asyncio functions which implicitly create Future or Task objects now emit a deprecation warning if there is no running event loop and no explicit loop argument is passed... | [
{
"body": "```\r\n/home/runner/work/scrapy/scrapy/scrapy/utils/reactor.py:70: DeprecationWarning: There is no current event loop\r\n event_loop = asyncio.get_event_loop()\r\ntests/test_downloadermiddleware.py: 2 warnings\r\ntests/test_utils_asyncgen.py: 2 warnings\r\ntests/test_utils_defer.py: 4 warnings\r\nte... | 92be5ba2572ec14e2580abe12d276e8aa24247b6 | {
"head_commit": "71406dd92a21872188e3f65d9ea0608c5293c7ab",
"head_commit_message": "Get eventloop from event_loop_policy to avoid deprecation warning.\n\nCloses #5685",
"patch_to_review": "diff --git a/scrapy/utils/reactor.py b/scrapy/utils/reactor.py\nindex 652733ce8b3..e0f9295392f 100644\n--- a/scrapy/utils/re... | [
{
"diff_hunk": "@@ -58,16 +58,19 @@ def install_reactor(reactor_path, event_loop_path=None):\n reactor_class = load_object(reactor_path)\n if reactor_class is asyncioreactor.AsyncioSelectorReactor:\n with suppress(error.ReactorAlreadyInstalledError):\n+ policy = asyncio.get_event_loop... | 78523a3ee64904213e08bf302eb434a91cea0d0c | diff --git a/scrapy/utils/defer.py b/scrapy/utils/defer.py
index 8fcf31cab54..38aefd6d02a 100644
--- a/scrapy/utils/defer.py
+++ b/scrapy/utils/defer.py
@@ -26,7 +26,7 @@
from twisted.python.failure import Failure
from scrapy.exceptions import IgnoreRequest
-from scrapy.utils.reactor import is_asyncio_reactor_insta... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
spyder-ide__spyder-6430@ea91314 | spyder-ide/spyder | Python | 6,430 | PR: Add a Plots plugin to browse figures generated by the IPython console | Fixes #2550


| 2018-02-10T17:45:42Z | Dock matplotlib figures
I don't use inline plotting, because you lose the zoom functions, which are really useful for me. But it'd be nice to have matplotlib windows docked into the spyder UI, so that I don't need to switch back and forth between the two windows. | Sorry, but I think this is not so easy to do :-)
This feature would be a great idea! Hopefully it is not as difficult as imagined...
I depends a lot on how matplotlib is used, which backend... I think it's not even in the same process as the main interface ?
What we could provide is a module specific for spyder, so ... | [
{
"body": "I don't use inline plotting, because you lose the zoom functions, which are really useful for me. But it'd be nice to have matplotlib windows docked into the spyder UI, so that I don't need to switch back and forth between the two windows.\n",
"number": 2550,
"title": "Dock matplotlib figures... | 900e0e65c2f81ddb39a676f59094ca3dc09ce8a0 | {
"head_commit": "ea91314db09571d4b0773bc350fc94dd0e70ed71",
"head_commit_message": "fix pep8",
"patch_to_review": "diff --git a/spyder/app/mainwindow.py b/spyder/app/mainwindow.py\nindex cbe6e8d3775..1f81a5df519 100644\n--- a/spyder/app/mainwindow.py\n+++ b/spyder/app/mainwindow.py\n@@ -332,6 +332,7 @@ def signa... | [
{
"diff_hunk": "@@ -0,0 +1,843 @@\n+# -*- coding: utf-8 -*-\n+#\n+# Copyright © Spyder Project Contributors\n+# Licensed under the terms of the MIT License\n+# (see spyder/__init__.py for details)\n+\n+\"\"\"\n+Figure browser widget\n+\n+This is the main widget used in the Plots plugin\n+\"\"\"\n+\n+\n+# ---- S... | 88081238d5996cace7985594f419647929c8b3ff | diff --git a/spyder/app/mainwindow.py b/spyder/app/mainwindow.py
index cbe6e8d3775..1f81a5df519 100644
--- a/spyder/app/mainwindow.py
+++ b/spyder/app/mainwindow.py
@@ -332,6 +332,7 @@ def signal_handler(signum, frame=None):
self.historylog = None
self.ipyconsole = None
self.variableexplore... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
spyder-ide__spyder-8257@b0b4c04 | spyder-ide/spyder | Python | 8,257 | PR: LSP fixes, debugging, and minor code cleanup | <!--- Before submitting your pull request, --->
<!--- please complete as much as practicable of the following checklist: --->
### Pull Request Checklist
* [x] Read and followed this repo's [Contributing Guidelines](https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md)
* [x] Based this PR on the late... | 2018-11-16T17:04:22Z | Warnings and errors from PyLS don't go away after fixing them, even when saving file
<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->
## Problem Description
PyLS errors and war... | I added the following line to `spyder.plugins.editor.widgets.editor.save` inside the try block, around line 1670: `finfo.editor.document_did_change()`
That fixed it for me.
There is also call to `notify_save()` above that, but that call effectively does nothing because `will_save_notify` defaults to False in the `C... | [
{
"body": "<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->\r\n\r\n## Problem Description\r\n\r\nPyLS errors and warnings (e.g. from pycodestyle, pyflakes, etc) don't go away... | 43ef69d0e984dd98620ac7b768540121a74af313 | {
"head_commit": "b0b4c046afcc62a1e6946cce7efbdf8f015b8f96",
"head_commit_message": "forgot to include lspmanager in commit",
"patch_to_review": "diff --git a/spyder/config/utils.py b/spyder/config/utils.py\nindex 308b570bef0..3a5402e2831 100644\n--- a/spyder/config/utils.py\n+++ b/spyder/config/utils.py\n@@ -27,... | [
{
"diff_hunk": "@@ -202,6 +205,12 @@ def on_msg_received(self):\n except KeyError:\n pass\n \n+ if 'error' in resp:\n+ logger.debug(\n+ '{} response error: {}'.format(self.language,",
"line": null,
"original_lin... | 90033dbdfa4449d1b7db4268f5707432a102309e | diff --git a/.gitignore b/.gitignore
index c4694ba5ccb..f16a4a8e683 100644
--- a/.gitignore
+++ b/.gitignore
@@ -31,4 +31,5 @@ spyder_crash.log
*.log
# Rope project folders
-.ropeproject/
\ No newline at end of file
+.ropeproject/
+.vscode/
\ No newline at end of file
diff --git a/spyder/config/utils.py b/spyder/co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
spyder-ide__spyder-5011@3f5f084 | spyder-ide/spyder | Python | 5,011 | PR: Add all possible string prefixes for syntax highlighting | Fixes #4884
----
As suggested in #4884 the string prefixes should be highlighted with the same color as the string itself. The list of all possible prefixes is given [here](https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals) for Python 3 and [here](https://docs.python.org/2/refer... | 2017-08-19T22:46:22Z | prefix 'b' of bytes is not highlighting in the editor window
## Description
**What steps will reproduce the problem?**
when inputting the bytes-type string in the editor window, the prefix 'b' is not highlighting with the same color of string.
**What is the expected output? What do you see instead?**
**Pl... | @fanstvn could you add a screenshot?
I don't think we're going to address this, but pull requests are welcome.
@ccordoba12 I think it should be fairly simple? also we should add f strings, no?
https://github.com/spyder-ide/spyder/blob/master/spyder/utils/syntaxhighlighters.py#L345
Adding `f` and `b` in there? | [
{
"body": "## Description\r\n\r\n**What steps will reproduce the problem?**\r\n\r\nwhen inputting the bytes-type string in the editor window, the prefix 'b' is not highlighting with the same color of string.\r\n\r\n**What is the expected output? What do you see instead?**\r\n\r\n\r\n**Please provide any additio... | 719e642508a7930843e477f1490518acf5a1c235 | {
"head_commit": "3f5f0847d05bab2418e14e317ed397f8f759d23d",
"head_commit_message": "added test for some string prefixes",
"patch_to_review": "diff --git a/spyder/utils/syntaxhighlighters.py b/spyder/utils/syntaxhighlighters.py\nindex 13eaf7ddce7..4703072663d 100644\n--- a/spyder/utils/syntaxhighlighters.py\n+++ ... | [
{
"diff_hunk": "@@ -340,14 +341,20 @@ def make_python_patterns(additional_keywords=[], additional_builtins=[]):\n r\"\\b[+-]?0[oO][0-7]+[lL]?\\b\",\r\n r\"\\b[+-]?0[bB][01]+[lL]?\\b\",\r\n r\"\\b[+-]?[0-9]+(?:\\.[0-9]+)?(?:[eE][+-]?[0-9]+)?[jJ]?\\b\"])\r\n- ... | 8b4980092570c70a72d237caeecc1714547fb0e3 | diff --git a/spyder/utils/syntaxhighlighters.py b/spyder/utils/syntaxhighlighters.py
index 13eaf7ddce7..9598626cae8 100644
--- a/spyder/utils/syntaxhighlighters.py
+++ b/spyder/utils/syntaxhighlighters.py
@@ -26,7 +26,7 @@
from spyder import dependencies
from spyder.config.base import _
from spyder.config.main imp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.