Add the Greptile and ReviewBench benchmark data
#45
by jfbrown95 - opened
- greptile/README.md +23 -0
- greptile/known.json +565 -0
- greptile/manifest.json +1367 -0
- greptile/results/jev.jsonl.gz +3 -0
- greptile/results/jev048.jsonl.gz +3 -0
- greptile/results/oai.jsonl.gz +3 -0
- greptile/results/oai2q.jsonl.gz +3 -0
- greptile/results/oai407.jsonl.gz +3 -0
- greptile/summary.json +302 -0
- greptile/truth/cal.com.json +428 -0
- greptile/truth/discourse.json +390 -0
- greptile/truth/grafana.json +261 -0
- greptile/truth/keycloak.json +297 -0
- greptile/truth/sentry.json +349 -0
- reviewbench/README.md +26 -0
- reviewbench/coverage.jsonl +0 -0
- reviewbench/judgments.jsonl +0 -0
- reviewbench/manifest.json +59 -0
- reviewbench/requests.jsonl.gz +3 -0
- reviewbench/rerun-jev-summary.json +236 -0
- reviewbench/rerun-summary.json +236 -0
- reviewbench/results/jev.jsonl.gz +3 -0
- reviewbench/results/luna.jsonl.gz +3 -0
- reviewbench/results/rerun-jev.jsonl.gz +3 -0
- reviewbench/results/rerun-luna.jsonl.gz +3 -0
- reviewbench/summary.json +28 -0
- reviewbench/targets.jsonl +0 -0
greptile/README.md
ADDED
|
@@ -0,0 +1,23 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Greptile benchmark
|
| 2 |
+
|
| 3 |
+
Perch's runs on [Greptile's benchmark](https://www.greptile.com/benchmarks): 50 pull requests, each carrying one known bug, with the golden comments from [Martian's code review benchmark](https://github.com/withmartian/code-review-benchmark). The scripts that score these files are in [`.benchmarks/greptile`](https://github.com/lakeday-org/perch/tree/main/.benchmarks/greptile) in lakeday-org/perch. Its README describes the runs and how they are scored.
|
| 4 |
+
|
| 5 |
+
These files are scored by lakeday-org/perch at commit `6b33c162a778f56e27ae043f57f4d52cf30b9456`, from [lakeday-org/perch#421](https://github.com/lakeday-org/perch/pull/421). Download them into a perch checkout, where the scripts read them:
|
| 6 |
+
|
| 7 |
+
```sh
|
| 8 |
+
hf download perchscan/benchmark-results --repo-type dataset --include 'greptile/*' --local-dir .benchmarks/hf
|
| 9 |
+
```
|
| 10 |
+
|
| 11 |
+
| File | Contents |
|
| 12 |
+
|---|---|
|
| 13 |
+
| `manifest.json` | Each pull request in its [ai-code-review-evaluation](https://github.com/ai-code-review-evaluation) fork, with its base and head commits and Martian's golden comments |
|
| 14 |
+
| `known.json` | Each pull request's known bug, in Greptile's words, and the functions that hold it |
|
| 15 |
+
| `truth/<repo>.json` | The functions each golden comment is about, for Cal.com, Discourse, Grafana, Keycloak and Sentry |
|
| 16 |
+
| `results/oai2q.jsonl.gz` | perch#418 on OpenAI Decisions, one line a pull request |
|
| 17 |
+
| `results/oai407.jsonl.gz` | perch#407 on OpenAI Decisions |
|
| 18 |
+
| `results/jev048.jsonl.gz` | The released perch 0.4.8 on Jev (`jev-latest`) |
|
| 19 |
+
| `results/jev.jsonl.gz` | perch 0.4.7 on Jev |
|
| 20 |
+
| `results/oai.jsonl.gz` | perch 0.4.7 on OpenAI Decisions |
|
| 21 |
+
| `summary.json` | Each run's scores at the 60%, 70% and 80% cutoffs, from `score.mjs` |
|
| 22 |
+
|
| 23 |
+
Martian's golden comments are [MIT-licensed](https://github.com/withmartian/code-review-benchmark). Source code is licensed according to its repository.
|
greptile/known.json
ADDED
|
@@ -0,0 +1,565 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
[
|
| 2 |
+
{
|
| 3 |
+
"repo": "sentry",
|
| 4 |
+
"pr": 1,
|
| 5 |
+
"bug": "Pagination for audit logs imports a nonexistent OptimizedCursorPaginator / negative slice offsets",
|
| 6 |
+
"methods": [
|
| 7 |
+
"src/sentry/api/paginator.py::OptimizedCursorPaginator.get_result"
|
| 8 |
+
],
|
| 9 |
+
"file": "src/sentry/api/paginator.py",
|
| 10 |
+
"line": 880,
|
| 11 |
+
"why": "Matches golden 0/3: the negative-offset branch assigns start_offset = cursor.offset and slices the queryset with it (line 882); the import named in the description is real at head."
|
| 12 |
+
},
|
| 13 |
+
{
|
| 14 |
+
"repo": "sentry",
|
| 15 |
+
"pr": 2,
|
| 16 |
+
"bug": "Negative offset cursor bypasses pagination bounds during span buffer insert",
|
| 17 |
+
"methods": [
|
| 18 |
+
"src/sentry/api/paginator.py::OptimizedCursorPaginator.get_result"
|
| 19 |
+
],
|
| 20 |
+
"file": "src/sentry/api/paginator.py",
|
| 21 |
+
"line": 880,
|
| 22 |
+
"why": "The described negative-offset bypass is the paginator change, not the span buffer insert: the span-buffer files (add-buffer.lua, buffer.py, factory.py) have no cursor or offset logic; the defect is start_offset = cursor.offset fed to queryset slicing."
|
| 23 |
+
},
|
| 24 |
+
{
|
| 25 |
+
"repo": "sentry",
|
| 26 |
+
"pr": 3,
|
| 27 |
+
"bug": "Upsampled error count skips sample_rate of 0.0 because it is treated as falsy",
|
| 28 |
+
"methods": [
|
| 29 |
+
"src/sentry/testutils/factories.py::_set_sample_rate_from_error_sampling"
|
| 30 |
+
],
|
| 31 |
+
"file": "src/sentry/testutils/factories.py",
|
| 32 |
+
"line": 353,
|
| 33 |
+
"why": "Same as golden 0: the truthiness check `if client_sample_rate:` drops a 0.0 sample rate."
|
| 34 |
+
},
|
| 35 |
+
{
|
| 36 |
+
"repo": "sentry",
|
| 37 |
+
"pr": 4,
|
| 38 |
+
"bug": "Null reference when github_authenticated_user state is missing (OAuth change)",
|
| 39 |
+
"methods": [
|
| 40 |
+
"src/sentry/integrations/github/integration.py::GitHubInstallation.dispatch"
|
| 41 |
+
],
|
| 42 |
+
"file": "src/sentry/integrations/github/integration.py",
|
| 43 |
+
"line": 502,
|
| 44 |
+
"why": "Same as golden 0: the github_authenticated_user state is fetched and compared with no presence check."
|
| 45 |
+
},
|
| 46 |
+
{
|
| 47 |
+
"repo": "sentry",
|
| 48 |
+
"pr": 5,
|
| 49 |
+
"bug": "Replays bulk delete changes the error response format, breaking clients",
|
| 50 |
+
"methods": [
|
| 51 |
+
"src/sentry/issues/endpoints/browser_reporting_collector.py::BrowserReportingCollectorEndpoint.post"
|
| 52 |
+
],
|
| 53 |
+
"file": "src/sentry/issues/endpoints/browser_reporting_collector.py",
|
| 54 |
+
"line": 115,
|
| 55 |
+
"why": "The description does not match the replays bulk-delete code (replays/usecases/delete.py only adds a None max_segment_id guard); the error response change in this PR is the browser reporting collector, which now answers an invalid report with a 422 JSON body {'error', 'details'} where the base code raised a TypeError (500) from BrowserReport(**report)."
|
| 56 |
+
},
|
| 57 |
+
{
|
| 58 |
+
"repo": "sentry",
|
| 59 |
+
"pr": 6,
|
| 60 |
+
"bug": "Inconsistent metric tag names ('shard' vs 'shards') in span buffer monitoring",
|
| 61 |
+
"methods": [
|
| 62 |
+
"src/sentry/spans/consumers/process/flusher.py::SpanFlusher.main"
|
| 63 |
+
],
|
| 64 |
+
"file": "src/sentry/spans/consumers/process/flusher.py",
|
| 65 |
+
"line": 199,
|
| 66 |
+
"why": "Same as golden 0: 'shards' tag on wait_produce versus 'shard' on the other flusher metrics."
|
| 67 |
+
},
|
| 68 |
+
{
|
| 69 |
+
"repo": "sentry",
|
| 70 |
+
"pr": 7,
|
| 71 |
+
"bug": "Dataclass uses a shared mutable default for a timestamp",
|
| 72 |
+
"methods": [
|
| 73 |
+
"src/sentry/integrations/services/assignment_source.py::<top-level>"
|
| 74 |
+
],
|
| 75 |
+
"file": "src/sentry/integrations/services/assignment_source.py",
|
| 76 |
+
"line": 18,
|
| 77 |
+
"why": "Same as golden 0: the dataclass default timezone.now() is evaluated once at class definition and shared by all instances."
|
| 78 |
+
},
|
| 79 |
+
{
|
| 80 |
+
"repo": "sentry",
|
| 81 |
+
"pr": 8,
|
| 82 |
+
"bug": "Incident creation reads a stale config variable instead of the updated one",
|
| 83 |
+
"methods": [
|
| 84 |
+
"src/sentry/monitors/logic/incident_occurrence.py::get_monitor_environment_context"
|
| 85 |
+
],
|
| 86 |
+
"file": "src/sentry/monitors/logic/incident_occurrence.py",
|
| 87 |
+
"line": 168,
|
| 88 |
+
"why": "Same as golden 0: the context returns the original monitor.config instead of the updated config copy."
|
| 89 |
+
},
|
| 90 |
+
{
|
| 91 |
+
"repo": "sentry",
|
| 92 |
+
"pr": 9,
|
| 93 |
+
"bug": "Queue-based parallelism mishandles the queue.ShutDown exception",
|
| 94 |
+
"methods": [
|
| 95 |
+
"src/sentry/remote_subscriptions/consumers/queue_consumer.py::OrderedQueueWorker.run"
|
| 96 |
+
],
|
| 97 |
+
"file": "src/sentry/remote_subscriptions/consumers/queue_consumer.py",
|
| 98 |
+
"line": 142,
|
| 99 |
+
"why": "The second except queue.ShutDown wraps result_processor, which never raises it, so it is dead code; ShutDown only comes from work_queue.get() (line 132), and FixedQueuePool.shutdown sets worker.shutdown = True before q.shutdown(immediate=False), so workers leave the loop without draining queued items. It is unclear which part the description means; line 142 is the misplaced handler."
|
| 100 |
+
},
|
| 101 |
+
{
|
| 102 |
+
"repo": "sentry",
|
| 103 |
+
"pr": 10,
|
| 104 |
+
"bug": "Occurrence hook in stateful detector is an incomplete stub (only pass)",
|
| 105 |
+
"methods": [
|
| 106 |
+
"src/sentry/incidents/grouptype.py::<top-level>"
|
| 107 |
+
],
|
| 108 |
+
"file": "src/sentry/incidents/grouptype.py",
|
| 109 |
+
"line": 11,
|
| 110 |
+
"why": "Same as golden 0: MetricAlertDetectorHandler is a stub containing only `pass`."
|
| 111 |
+
},
|
| 112 |
+
{
|
| 113 |
+
"repo": "grafana",
|
| 114 |
+
"pr": 1,
|
| 115 |
+
"bug": "Race condition in device creation/update (anonymous device limit), CreateOrUpdateDevice",
|
| 116 |
+
"methods": [
|
| 117 |
+
"pkg/services/anonymous/anonimpl/anonstore/database.go::AnonDBStore.CreateOrUpdateDevice"
|
| 118 |
+
],
|
| 119 |
+
"file": "pkg/services/anonymous/anonimpl/anonstore/database.go",
|
| 120 |
+
"line": 110,
|
| 121 |
+
"why": "Check-then-insert race: the device count and the upsert are separate, unsynchronized DB operations."
|
| 122 |
+
},
|
| 123 |
+
{
|
| 124 |
+
"repo": "grafana",
|
| 125 |
+
"pr": 2,
|
| 126 |
+
"bug": "Authz cache entries lack expiration, causing permanent permission denials",
|
| 127 |
+
"methods": [
|
| 128 |
+
"pkg/services/authz/rbac/service.go::Service.Check",
|
| 129 |
+
"pkg/services/authz/rbac/service.go::NewService"
|
| 130 |
+
],
|
| 131 |
+
"file": "pkg/services/authz/rbac/service.go",
|
| 132 |
+
"line": 117,
|
| 133 |
+
"why": "Denials written to permDenialCache (line 154) short-circuit Check at line 117 and are never invalidated when permissions change; note the cache does get shortCacheTTL (30s) in NewService line 85, so 'no expiration' is overstated and the defensible defect is the stale-denial short-circuit in Check."
|
| 134 |
+
},
|
| 135 |
+
{
|
| 136 |
+
"repo": "grafana",
|
| 137 |
+
"pr": 3,
|
| 138 |
+
"bug": "Undefined endpoint constants after middleware rename cause compile errors",
|
| 139 |
+
"methods": [
|
| 140 |
+
"pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.go::ContextualLoggerMiddleware.QueryData",
|
| 141 |
+
"pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.go::ContextualLoggerMiddleware.CallResource",
|
| 142 |
+
"pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.go::ContextualLoggerMiddleware.CheckHealth",
|
| 143 |
+
"pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.go::ContextualLoggerMiddleware.CollectMetrics"
|
| 144 |
+
],
|
| 145 |
+
"file": "pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.go",
|
| 146 |
+
"line": 40,
|
| 147 |
+
"why": "Unsure: the endpoint constants used by the new middleware (lines 40, 45, 50, 55) are in fact defined in clientmiddleware/utils.go at head, so no compile error is visible; these uses are the closest match to the described defect."
|
| 148 |
+
},
|
| 149 |
+
{
|
| 150 |
+
"repo": "grafana",
|
| 151 |
+
"pr": 4,
|
| 152 |
+
"bug": "Double interpolation risk in query processing",
|
| 153 |
+
"methods": [
|
| 154 |
+
"public/app/plugins/datasource/loki/querySplitting.ts::runSplitQuery",
|
| 155 |
+
"public/app/plugins/datasource/loki/shardQuerySplitting.ts::runShardSplitQuery"
|
| 156 |
+
],
|
| 157 |
+
"file": "public/app/plugins/datasource/loki/querySplitting.ts",
|
| 158 |
+
"line": 299,
|
| 159 |
+
"why": "Queries are interpolated with applyTemplateVariables before splitting, then interpolated again when datasource.runQuery calls super.query (DataSourceWithBackend applies template variables); same pattern in shardQuerySplitting.ts line 52."
|
| 160 |
+
},
|
| 161 |
+
{
|
| 162 |
+
"repo": "grafana",
|
| 163 |
+
"pr": 5,
|
| 164 |
+
"bug": "Missing key prop causes React rendering issues in notification rules",
|
| 165 |
+
"methods": [
|
| 166 |
+
"public/app/features/alerting/unified/rule-list/FilterView.tsx::FilterViewResults"
|
| 167 |
+
],
|
| 168 |
+
"file": "public/app/features/alerting/unified/rule-list/FilterView.tsx",
|
| 169 |
+
"line": 157,
|
| 170 |
+
"why": "GrafanaRuleListItem in the mapped list is missing its key prop."
|
| 171 |
+
},
|
| 172 |
+
{
|
| 173 |
+
"repo": "grafana",
|
| 174 |
+
"pr": 6,
|
| 175 |
+
"bug": "Wrong metrics recording methods produce misleading performance data",
|
| 176 |
+
"methods": [
|
| 177 |
+
"pkg/apiserver/rest/dualwriter_mode3.go::DualWriterMode3.Create",
|
| 178 |
+
"pkg/apiserver/rest/dualwriter_mode3.go::DualWriterMode3.Update",
|
| 179 |
+
"pkg/apiserver/rest/dualwriter_mode3.go::DualWriterMode3.DeleteCollection"
|
| 180 |
+
],
|
| 181 |
+
"file": "pkg/apiserver/rest/dualwriter_mode3.go",
|
| 182 |
+
"line": 45,
|
| 183 |
+
"why": "Wrong recorder used: storage failures recorded via recordLegacyDuration in Create (45) and Update (129), and legacy DeleteCollection recorded via recordStorageDuration (166)."
|
| 184 |
+
},
|
| 185 |
+
{
|
| 186 |
+
"repo": "grafana",
|
| 187 |
+
"pr": 7,
|
| 188 |
+
"bug": "Incorrect error log level in database optimizations",
|
| 189 |
+
"methods": [
|
| 190 |
+
"pkg/services/annotations/annotationsimpl/xorm_store.go::xormRepositoryImpl.CleanAnnotations",
|
| 191 |
+
"pkg/services/annotations/annotationsimpl/xorm_store.go::xormRepositoryImpl.CleanOrphanedAnnotationTags"
|
| 192 |
+
],
|
| 193 |
+
"file": "pkg/services/annotations/annotationsimpl/xorm_store.go",
|
| 194 |
+
"line": 534,
|
| 195 |
+
"why": "Error log level used for routine debug information in the annotation cleanup batches."
|
| 196 |
+
},
|
| 197 |
+
{
|
| 198 |
+
"repo": "grafana",
|
| 199 |
+
"pr": 8,
|
| 200 |
+
"bug": "Possible deadlock during concurrent annotation deletion",
|
| 201 |
+
"methods": [],
|
| 202 |
+
"file": null,
|
| 203 |
+
"line": null,
|
| 204 |
+
"why": "Unsure: this PR only changes GetWebAssets locking (no annotation deletion code, and the RLock/Lock sequence cannot deadlock); the description matches PR 7's annotation cleanup, so there is no location in this PR."
|
| 205 |
+
},
|
| 206 |
+
{
|
| 207 |
+
"repo": "grafana",
|
| 208 |
+
"pr": 9,
|
| 209 |
+
"bug": "enableSqlExpressions always returns false, disabling SQL functionality",
|
| 210 |
+
"methods": [
|
| 211 |
+
"pkg/expr/reader.go::enableSqlExpressions"
|
| 212 |
+
],
|
| 213 |
+
"file": "pkg/expr/reader.go",
|
| 214 |
+
"line": 195,
|
| 215 |
+
"why": "enableSqlExpressions returns false whether or not the feature flag is enabled."
|
| 216 |
+
},
|
| 217 |
+
{
|
| 218 |
+
"repo": "grafana",
|
| 219 |
+
"pr": 10,
|
| 220 |
+
"bug": "Race condition in cache locking (unified storage)",
|
| 221 |
+
"methods": [
|
| 222 |
+
"pkg/storage/unified/search/bleve.go::bleveBackend.BuildIndex"
|
| 223 |
+
],
|
| 224 |
+
"file": "pkg/storage/unified/search/bleve.go",
|
| 225 |
+
"line": 137,
|
| 226 |
+
"why": "Narrowing the cacheMu lock in BuildIndex to the cache write leaves index construction unsynchronized."
|
| 227 |
+
},
|
| 228 |
+
{
|
| 229 |
+
"repo": "cal.com",
|
| 230 |
+
"pr": 2,
|
| 231 |
+
"bug": "Async callbacks in forEach cause unhandled promise rejections (appStore import)",
|
| 232 |
+
"methods": [
|
| 233 |
+
"packages/app-store/vital/lib/reschedule.ts::Reschedule",
|
| 234 |
+
"packages/app-store/wipemycalother/lib/reschedule.ts::Reschedule",
|
| 235 |
+
"packages/trpc/server/routers/viewer/bookings.tsx::requestReschedule",
|
| 236 |
+
"packages/features/bookings/lib/handleCancelBooking.ts::handler"
|
| 237 |
+
],
|
| 238 |
+
"file": "packages/app-store/vital/lib/reschedule.ts",
|
| 239 |
+
"line": 125,
|
| 240 |
+
"why": "forEach(async (bookingRef) => { await getCalendar(...) }) leaves the promises unawaited, causing unhandled rejections (same as golden 1; also wipemycalother reschedule.ts:125, bookings.tsx:553, handleCancelBooking.ts:460)."
|
| 241 |
+
},
|
| 242 |
+
{
|
| 243 |
+
"repo": "cal.com",
|
| 244 |
+
"pr": 3,
|
| 245 |
+
"bug": "2FA backup codes are not invalidated after use",
|
| 246 |
+
"methods": [
|
| 247 |
+
"packages/features/auth/lib/next-auth-options.ts::authorize"
|
| 248 |
+
],
|
| 249 |
+
"file": "packages/features/auth/lib/next-auth-options.ts",
|
| 250 |
+
"line": 148,
|
| 251 |
+
"why": "A used backup code is invalidated only by a non-atomic read-modify-write of the encrypted list, so it is not reliably invalidated after use (concurrent reuse, as in golden 3); the disable endpoint clears all codes, so login is the only place this applies."
|
| 252 |
+
},
|
| 253 |
+
{
|
| 254 |
+
"repo": "cal.com",
|
| 255 |
+
"pr": 4,
|
| 256 |
+
"bug": "Null reference when destinationCalendar host array is empty",
|
| 257 |
+
"methods": [
|
| 258 |
+
"packages/core/EventManager.ts::EventManager.create",
|
| 259 |
+
"packages/app-store/googlecalendar/lib/CalendarService.ts::GoogleCalendarService.createEvent",
|
| 260 |
+
"packages/app-store/googlecalendar/lib/CalendarService.ts::GoogleCalendarService.updateEvent"
|
| 261 |
+
],
|
| 262 |
+
"file": "packages/core/EventManager.ts",
|
| 263 |
+
"line": 119,
|
| 264 |
+
"why": "const [mainHostDestinationCalendar] = evt.destinationCalendar ?? [] is undefined for an empty array, and mainHostDestinationCalendar.integration is then read without a guard; the Google createEvent/updateEvent destructuring named in golden 0 is listed too."
|
| 265 |
+
},
|
| 266 |
+
{
|
| 267 |
+
"repo": "cal.com",
|
| 268 |
+
"pr": 5,
|
| 269 |
+
"bug": "SQL injection risk in raw Prisma.sql query construction (InsightsBookingService)",
|
| 270 |
+
"methods": [
|
| 271 |
+
"packages/lib/server/service/insightsBooking.ts::InsightsBookingService.buildFilterConditions",
|
| 272 |
+
"packages/lib/server/service/insightsBooking.ts::InsightsBookingService.buildAuthorizationConditions",
|
| 273 |
+
"packages/lib/server/service/insightsBooking.ts::InsightsBookingService.buildOrgAuthorizationCondition",
|
| 274 |
+
"packages/lib/server/service/insightsBooking.ts::InsightsBookingService.buildTeamAuthorizationCondition"
|
| 275 |
+
],
|
| 276 |
+
"file": "packages/lib/server/service/insightsBooking.ts",
|
| 277 |
+
"line": 106,
|
| 278 |
+
"why": "WHERE fragments are now built as raw Prisma.sql strings from filter and option values (first at line 106); Prisma.sql binds the interpolated values as parameters, so the injection risk is nominal, and the location is ambiguous across all four build* methods."
|
| 279 |
+
},
|
| 280 |
+
{
|
| 281 |
+
"repo": "cal.com",
|
| 282 |
+
"pr": 6,
|
| 283 |
+
"bug": "Workflow reminders not cleaned up from DB when immediateDelete is true",
|
| 284 |
+
"methods": [
|
| 285 |
+
"packages/features/ee/workflows/lib/reminders/emailReminderManager.ts::deleteScheduledEmailReminder"
|
| 286 |
+
],
|
| 287 |
+
"file": "packages/features/ee/workflows/lib/reminders/emailReminderManager.ts",
|
| 288 |
+
"line": 213,
|
| 289 |
+
"why": "With immediateDelete true, the function returns after the SendGrid cancel and never removes the WorkflowReminder from the DB."
|
| 290 |
+
},
|
| 291 |
+
{
|
| 292 |
+
"repo": "cal.com",
|
| 293 |
+
"pr": 7,
|
| 294 |
+
"bug": "End time computed from slotStartTime instead of slotEndTime",
|
| 295 |
+
"methods": [
|
| 296 |
+
"packages/trpc/server/routers/viewer/slots.ts::checkIfIsAvailable"
|
| 297 |
+
],
|
| 298 |
+
"file": "packages/trpc/server/routers/viewer/slots.ts",
|
| 299 |
+
"line": 142,
|
| 300 |
+
"why": "const end = slotStartTime.hour() * 60 + slotStartTime.minute() uses the slot start time where the slot end time is needed."
|
| 301 |
+
},
|
| 302 |
+
{
|
| 303 |
+
"repo": "cal.com",
|
| 304 |
+
"pr": 8,
|
| 305 |
+
"bug": "Timing attack from direct string comparison in OAuth credential sync",
|
| 306 |
+
"methods": [
|
| 307 |
+
"apps/web/pages/api/webhook/app-credential.ts::handler"
|
| 308 |
+
],
|
| 309 |
+
"file": "apps/web/pages/api/webhook/app-credential.ts",
|
| 310 |
+
"line": 25,
|
| 311 |
+
"why": "The webhook secret header is compared to CALCOM_WEBHOOK_SECRET with !==, a non-constant-time comparison open to timing attacks."
|
| 312 |
+
},
|
| 313 |
+
{
|
| 314 |
+
"repo": "cal.com",
|
| 315 |
+
"pr": 9,
|
| 316 |
+
"bug": "OR condition in SMS reminder logic deletes all workflow reminders",
|
| 317 |
+
"methods": [
|
| 318 |
+
"packages/features/ee/workflows/api/scheduleSMSReminders.ts::handler"
|
| 319 |
+
],
|
| 320 |
+
"file": "packages/features/ee/workflows/api/scheduleSMSReminders.ts",
|
| 321 |
+
"line": 38,
|
| 322 |
+
"why": "The retryCount OR condition in deleteMany is not limited to SMS reminders, so it deletes workflow reminders of every method."
|
| 323 |
+
},
|
| 324 |
+
{
|
| 325 |
+
"repo": "cal.com",
|
| 326 |
+
"pr": 10,
|
| 327 |
+
"bug": "Email blacklist is case-sensitive, allowing bypass (guest management)",
|
| 328 |
+
"methods": [
|
| 329 |
+
"packages/trpc/server/routers/viewer/bookings/addGuests.handler.ts::addGuestsHandler"
|
| 330 |
+
],
|
| 331 |
+
"file": "packages/trpc/server/routers/viewer/bookings/addGuests.handler.ts",
|
| 332 |
+
"line": 77,
|
| 333 |
+
"why": "The guest email is compared case-sensitively against the lowercased blacklist, allowing a bypass."
|
| 334 |
+
},
|
| 335 |
+
{
|
| 336 |
+
"repo": "cal.com",
|
| 337 |
+
"pr": 11,
|
| 338 |
+
"bug": "Unreliable updatedAt field produces inaccurate calendar cache status",
|
| 339 |
+
"methods": [
|
| 340 |
+
"packages/app-store/googlecalendar/lib/CalendarService.ts::GoogleCalendarService.fetchAvailabilityAndSetCache",
|
| 341 |
+
"packages/lib/server/repository/selectedCalendar.ts::SelectedCalendarRepository.updateManyByCredentialId"
|
| 342 |
+
],
|
| 343 |
+
"file": "packages/app-store/googlecalendar/lib/CalendarService.ts",
|
| 344 |
+
"line": 1024,
|
| 345 |
+
"why": "The updatedAt refresh relies on an updateMany with empty data, so the timestamp shown as cache status is unreliable (same as golden 0)."
|
| 346 |
+
},
|
| 347 |
+
{
|
| 348 |
+
"repo": "keycloak",
|
| 349 |
+
"pr": 1,
|
| 350 |
+
"bug": "Passkey re-auth calls ConditionalPasskeysEnabled() without UserModel",
|
| 351 |
+
"methods": [
|
| 352 |
+
"services/src/main/java/org/keycloak/authentication/authenticators/browser/UsernameForm.java::UsernameForm.authenticate"
|
| 353 |
+
],
|
| 354 |
+
"file": "services/src/main/java/org/keycloak/authentication/authenticators/browser/UsernameForm.java",
|
| 355 |
+
"line": 47,
|
| 356 |
+
"why": "Re-authentication check calls isConditionalPasskeysEnabled() without the UserModel parameter it requires (should pass context.getUser())."
|
| 357 |
+
},
|
| 358 |
+
{
|
| 359 |
+
"repo": "keycloak",
|
| 360 |
+
"pr": 2,
|
| 361 |
+
"bug": "Recursive caching call uses session instead of delegate (getForLogin)",
|
| 362 |
+
"methods": [
|
| 363 |
+
"model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/idp/InfinispanIdentityProviderStorageProvider.java::InfinispanIdentityProviderStorageProvider.getForLogin"
|
| 364 |
+
],
|
| 365 |
+
"file": "model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/idp/InfinispanIdentityProviderStorageProvider.java",
|
| 366 |
+
"line": 246,
|
| 367 |
+
"why": "getForLogin loads each cached IdP via session.identityProviders().getById (the caching layer itself) rather than idpDelegate.getById."
|
| 368 |
+
},
|
| 369 |
+
{
|
| 370 |
+
"repo": "keycloak",
|
| 371 |
+
"pr": 3,
|
| 372 |
+
"bug": "Returns default keystore provider instead of BouncyCastle (AuthzClientCryptoProvider)",
|
| 373 |
+
"methods": [
|
| 374 |
+
"authz/client/src/main/java/org/keycloak/authorization/client/util/crypto/AuthzClientCryptoProvider.java::AuthzClientCryptoProvider.getBouncyCastleProvider"
|
| 375 |
+
],
|
| 376 |
+
"file": "authz/client/src/main/java/org/keycloak/authorization/client/util/crypto/AuthzClientCryptoProvider.java",
|
| 377 |
+
"line": 63,
|
| 378 |
+
"why": "Returns KeyStore.getInstance(KeyStore.getDefaultType()).getProvider() (default keystore provider) instead of a BouncyCastle provider."
|
| 379 |
+
},
|
| 380 |
+
{
|
| 381 |
+
"repo": "keycloak",
|
| 382 |
+
"pr": 4,
|
| 383 |
+
"bug": "Incorrect method call for exit codes in rolling-updates framework",
|
| 384 |
+
"methods": [
|
| 385 |
+
"quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/cli/command/UpdateCompatibilityCheck.java::UpdateCompatibilityCheck.run",
|
| 386 |
+
"quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/cli/command/UpdateCompatibilityMetadata.java::UpdateCompatibilityMetadata.run"
|
| 387 |
+
],
|
| 388 |
+
"file": "quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/cli/command/UpdateCompatibilityCheck.java",
|
| 389 |
+
"line": 48,
|
| 390 |
+
"why": "Exit code for the disabled rolling-updates feature is returned with picocli.exit(...), which hard-exits via System.exit; same call duplicated in UpdateCompatibilityMetadata.run."
|
| 391 |
+
},
|
| 392 |
+
{
|
| 393 |
+
"repo": "keycloak",
|
| 394 |
+
"pr": 5,
|
| 395 |
+
"bug": "Inconsistent feature flag causes orphaned permissions (Client scopes)",
|
| 396 |
+
"methods": [
|
| 397 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/AdminPermissions.java::AdminPermissions.registerListener.onEvent",
|
| 398 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/AdminPermissions.java::AdminPermissions.registerListener"
|
| 399 |
+
],
|
| 400 |
+
"file": "services/src/main/java/org/keycloak/services/resources/admin/permissions/AdminPermissions.java",
|
| 401 |
+
"line": 77,
|
| 402 |
+
"why": "Permission cleanup listener checks the V1 ADMIN_FINE_GRAINED_AUTHZ flag while the rest of the code uses V2, leaving orphaned permissions when only V2 is on."
|
| 403 |
+
},
|
| 404 |
+
{
|
| 405 |
+
"repo": "keycloak",
|
| 406 |
+
"pr": 6,
|
| 407 |
+
"bug": "Incorrect permission check in canManage() (Groups scopes)",
|
| 408 |
+
"methods": [
|
| 409 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/GroupPermissionsV2.java::GroupPermissionsV2.canManage"
|
| 410 |
+
],
|
| 411 |
+
"file": "services/src/main/java/org/keycloak/services/resources/admin/permissions/GroupPermissionsV2.java",
|
| 412 |
+
"line": 70,
|
| 413 |
+
"why": "canManage() accepts the VIEW scope as well as MANAGE when falling back to the all-groups permission."
|
| 414 |
+
},
|
| 415 |
+
{
|
| 416 |
+
"repo": "keycloak",
|
| 417 |
+
"pr": 7,
|
| 418 |
+
"bug": "Lithuanian translation files contain Italian text",
|
| 419 |
+
"methods": [],
|
| 420 |
+
"file": "themes/src/main/resources-community/theme/base/account/messages/messages_lt.properties",
|
| 421 |
+
"line": 101,
|
| 422 |
+
"why": "Translation file (no method): Lithuanian totpStep1 set to Italian text; also login/messages/messages_lt.properties line 71."
|
| 423 |
+
},
|
| 424 |
+
{
|
| 425 |
+
"repo": "keycloak",
|
| 426 |
+
"pr": 8,
|
| 427 |
+
"bug": "Wrong parameter in null check (grantType vs. rawTokenId)",
|
| 428 |
+
"methods": [
|
| 429 |
+
"services/src/main/java/org/keycloak/protocol/oidc/encode/AccessTokenContext.java::AccessTokenContext.AccessTokenContext"
|
| 430 |
+
],
|
| 431 |
+
"file": "services/src/main/java/org/keycloak/protocol/oidc/encode/AccessTokenContext.java",
|
| 432 |
+
"line": 73,
|
| 433 |
+
"why": "Null check passes grantType where rawTokenId was intended, so a null rawTokenId is accepted."
|
| 434 |
+
},
|
| 435 |
+
{
|
| 436 |
+
"repo": "keycloak",
|
| 437 |
+
"pr": 9,
|
| 438 |
+
"bug": "Unsafe raw List deserialization in recovery key support",
|
| 439 |
+
"methods": [
|
| 440 |
+
"testsuite/integration-arquillian/servers/auth-server/services/testsuite-providers/src/main/java/org/keycloak/testsuite/federation/BackwardsCompatibilityUserStorage.java::BackwardsCompatibilityUserStorage.getCredentials",
|
| 441 |
+
"testsuite/integration-arquillian/servers/auth-server/services/testsuite-providers/src/main/java/org/keycloak/testsuite/federation/BackwardsCompatibilityUserStorage.java::BackwardsCompatibilityUserStorage.isValid"
|
| 442 |
+
],
|
| 443 |
+
"file": "testsuite/integration-arquillian/servers/auth-server/services/testsuite-providers/src/main/java/org/keycloak/testsuite/federation/BackwardsCompatibilityUserStorage.java",
|
| 444 |
+
"line": 238,
|
| 445 |
+
"why": "JsonSerialization.readValue(..., List.class) yields a raw List passed unchecked to createFromValues(List<String>...); isValid repeats it with a raw `List generatedKeys` at line 332-334."
|
| 446 |
+
},
|
| 447 |
+
{
|
| 448 |
+
"repo": "keycloak",
|
| 449 |
+
"pr": 10,
|
| 450 |
+
"bug": "Missing null check causes NullPointerException in concurrent group access",
|
| 451 |
+
"methods": [
|
| 452 |
+
"model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/GroupAdapter.java::GroupAdapter.getSubGroupsCount"
|
| 453 |
+
],
|
| 454 |
+
"file": "model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/GroupAdapter.java",
|
| 455 |
+
"line": 275,
|
| 456 |
+
"why": "Concurrent-deletion path in getSubGroupsCount; this PR's head equals upstream commit 332c9b6e so nothing was injected, and the closest match is this null return (sibling getSubGroupsStream overloads at 256/262/268 still call modelSupplier.get() unchecked)."
|
| 457 |
+
},
|
| 458 |
+
{
|
| 459 |
+
"repo": "discourse",
|
| 460 |
+
"pr": 1,
|
| 461 |
+
"bug": "Method overwriting causes parameter mismatch (image downsizing)",
|
| 462 |
+
"methods": [
|
| 463 |
+
"app/models/optimized_image.rb::OptimizedImage.downsize#2",
|
| 464 |
+
"app/models/optimized_image.rb::OptimizedImage.downsize"
|
| 465 |
+
],
|
| 466 |
+
"file": "app/models/optimized_image.rb",
|
| 467 |
+
"line": 149,
|
| 468 |
+
"why": "Same defect as golden 0: the second downsize definition overwrites the max_width/max_height one, so the parameter lists no longer match the callers."
|
| 469 |
+
},
|
| 470 |
+
{
|
| 471 |
+
"repo": "discourse",
|
| 472 |
+
"pr": 2,
|
| 473 |
+
"bug": "Nil reference to a nonexistent TopicUser (per-topic unsubscribe)",
|
| 474 |
+
"methods": [
|
| 475 |
+
"app/controllers/topics_controller.rb::TopicsController.unsubscribe"
|
| 476 |
+
],
|
| 477 |
+
"file": "app/controllers/topics_controller.rb",
|
| 478 |
+
"line": 107,
|
| 479 |
+
"why": "Same as golden 0: unsubscribe dereferences tu without checking that the TopicUser record exists."
|
| 480 |
+
},
|
| 481 |
+
{
|
| 482 |
+
"repo": "discourse",
|
| 483 |
+
"pr": 3,
|
| 484 |
+
"bug": "BlockedEmail.should_block? writes to the DB during a read",
|
| 485 |
+
"methods": [
|
| 486 |
+
"app/models/blocked_email.rb::BlockedEmail.should_block?"
|
| 487 |
+
],
|
| 488 |
+
"file": "app/models/blocked_email.rb",
|
| 489 |
+
"line": 14,
|
| 490 |
+
"why": "Same as golden 0: should_block? saves match statistics during what callers use as a read-only check."
|
| 491 |
+
},
|
| 492 |
+
{
|
| 493 |
+
"repo": "discourse",
|
| 494 |
+
"pr": 4,
|
| 495 |
+
"bug": "SSRF via open(url) without validation (embed URLs)",
|
| 496 |
+
"methods": [
|
| 497 |
+
"app/jobs/scheduled/poll_feed.rb::Jobs.PollFeed.poll_feed"
|
| 498 |
+
],
|
| 499 |
+
"file": "app/jobs/scheduled/poll_feed.rb",
|
| 500 |
+
"line": 29,
|
| 501 |
+
"why": "Matches golden 0: open(SiteSetting.feed_polling_url) with no validation. TopicEmbed.import_remote also calls open(url) on the embed URL (topic_embed.rb line 48), but TopicRetriever.invalid_host? checks that host first."
|
| 502 |
+
},
|
| 503 |
+
{
|
| 504 |
+
"repo": "discourse",
|
| 505 |
+
"pr": 5,
|
| 506 |
+
"bug": "float: left mixed with flexbox causes header layout issues",
|
| 507 |
+
"methods": [],
|
| 508 |
+
"file": "app/assets/stylesheets/common/base/topic.scss",
|
| 509 |
+
"line": 34,
|
| 510 |
+
"why": "Same as golden 0: float: left kept inside the new flexbox header layout (.extra-info-wrapper .badge-wrapper); SCSS, no methods."
|
| 511 |
+
},
|
| 512 |
+
{
|
| 513 |
+
"repo": "discourse",
|
| 514 |
+
"pr": 6,
|
| 515 |
+
"bug": "String mutation via the << operator in URL display",
|
| 516 |
+
"methods": [
|
| 517 |
+
"app/serializers/user_serializer.rb::UserSerializer.website_name"
|
| 518 |
+
],
|
| 519 |
+
"file": "app/serializers/user_serializer.rb",
|
| 520 |
+
"line": 149,
|
| 521 |
+
"why": "website_name uses \".\" << website_host, which mutates the string literal in place instead of concatenating with + or interpolation."
|
| 522 |
+
},
|
| 523 |
+
{
|
| 524 |
+
"repo": "discourse",
|
| 525 |
+
"pr": 7,
|
| 526 |
+
"bug": "scale-color $lightness should use $secondary for dark themes",
|
| 527 |
+
"methods": [],
|
| 528 |
+
"file": "app/assets/stylesheets/desktop/topic-post.scss",
|
| 529 |
+
"line": 291,
|
| 530 |
+
"why": "The greptile line restates the PR title rather than a defect; the most defensible bug is the light-theme value inverted to 70% at .topic-meta-data h5 a (golden 0/3). SCSS, no methods."
|
| 531 |
+
},
|
| 532 |
+
{
|
| 533 |
+
"repo": "discourse",
|
| 534 |
+
"pr": 8,
|
| 535 |
+
"bug": "Race conditions in async group member loading",
|
| 536 |
+
"methods": [
|
| 537 |
+
"app/assets/javascripts/admin/routes/admin_group_route.js::setupController"
|
| 538 |
+
],
|
| 539 |
+
"file": "app/assets/javascripts/admin/routes/admin_group_route.js",
|
| 540 |
+
"line": 13,
|
| 541 |
+
"why": "Same as golden 0: findMembers is fired asynchronously from setupController with no promise handling."
|
| 542 |
+
},
|
| 543 |
+
{
|
| 544 |
+
"repo": "discourse",
|
| 545 |
+
"pr": 9,
|
| 546 |
+
"bug": "Thread-safety issue with lazy @loaded_locales",
|
| 547 |
+
"methods": [
|
| 548 |
+
"lib/freedom_patches/translate_accelerator.rb::I18n.ensure_loaded!"
|
| 549 |
+
],
|
| 550 |
+
"file": "lib/freedom_patches/translate_accelerator.rb",
|
| 551 |
+
"line": 63,
|
| 552 |
+
"why": "Same as golden 0: @loaded_locales ||= [] in ensure_loaded! is not thread-safe."
|
| 553 |
+
},
|
| 554 |
+
{
|
| 555 |
+
"repo": "discourse",
|
| 556 |
+
"pr": 10,
|
| 557 |
+
"bug": "NoMethodError in before_validation of EmbeddableHost",
|
| 558 |
+
"methods": [
|
| 559 |
+
"app/models/embeddable_host.rb::<top-level>"
|
| 560 |
+
],
|
| 561 |
+
"file": "app/models/embeddable_host.rb",
|
| 562 |
+
"line": 6,
|
| 563 |
+
"why": "Same as golden 0: host.sub! in before_validation raises NoMethodError when host is nil."
|
| 564 |
+
}
|
| 565 |
+
]
|
greptile/manifest.json
ADDED
|
@@ -0,0 +1,1367 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
[
|
| 2 |
+
{
|
| 3 |
+
"repo": "sentry",
|
| 4 |
+
"pr": 1,
|
| 5 |
+
"title": "Enhanced Pagination Performance for High-Volume Audit Logs",
|
| 6 |
+
"base": "a5d290951def84afdcc4c88d2f1f20023fc36e2a",
|
| 7 |
+
"head": "8ab88145113dd23a930e23b9cbbcf8b30e4c0b17",
|
| 8 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/sentry-greptile/pull/1",
|
| 9 |
+
"comments": [
|
| 10 |
+
{
|
| 11 |
+
"comment": "The OptimizedCursorPaginator in organization_auditlogs.py attempts to use negative slice offsets on Django querysets, but Django querysets do not support negative slicing and will raise an AssertionError.",
|
| 12 |
+
"severity": "High",
|
| 13 |
+
"category": "bug"
|
| 14 |
+
},
|
| 15 |
+
{
|
| 16 |
+
"comment": "When requests are authenticated with API keys or org auth tokens (which have user_id=None), organization_context.member is None. Line 71 attempts to access organization_context.member.has_global_access without checking if member is None, causing an AttributeError crash when optimized_pagination=true is used, even though the request passed all permission checks with valid org:write scope.",
|
| 17 |
+
"severity": "High",
|
| 18 |
+
"category": "bug"
|
| 19 |
+
},
|
| 20 |
+
{
|
| 21 |
+
"comment": "get_item_key assumes a numeric key, but the paginator is used with order_by=-datetime in the audit logs endpoint; calling math.floor/ceil on a datetime will raise a TypeError.",
|
| 22 |
+
"severity": "High",
|
| 23 |
+
"category": "bug"
|
| 24 |
+
},
|
| 25 |
+
{
|
| 26 |
+
"comment": "Importing non-existent OptimizedCursorPaginator",
|
| 27 |
+
"severity": "Low",
|
| 28 |
+
"category": "bug"
|
| 29 |
+
}
|
| 30 |
+
]
|
| 31 |
+
},
|
| 32 |
+
{
|
| 33 |
+
"repo": "sentry",
|
| 34 |
+
"pr": 2,
|
| 35 |
+
"title": "Optimize spans buffer insertion with eviction during insert",
|
| 36 |
+
"base": "28e3db2520d4ea28c57b08da57b83917ba7b2e15",
|
| 37 |
+
"head": "8ab88145113dd23a930e23b9cbbcf8b30e4c0b17",
|
| 38 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/sentry-greptile/pull/2",
|
| 39 |
+
"comments": [
|
| 40 |
+
{
|
| 41 |
+
"comment": "OptimizedCursorPaginator's negative-offset branch in get_result() passes cursor.offset directly as start_offset to queryset slicing when enable_advanced_features is True and cursor.offset < 0.",
|
| 42 |
+
"severity": "Critical",
|
| 43 |
+
"category": "bug"
|
| 44 |
+
},
|
| 45 |
+
{
|
| 46 |
+
"comment": "In BasePaginator.get_result(), when cursor.is_prev is True, it sets start_offset = offset without clamping, allowing negative offset values to be passed to queryset slicing.",
|
| 47 |
+
"severity": "High",
|
| 48 |
+
"category": "bug"
|
| 49 |
+
},
|
| 50 |
+
{
|
| 51 |
+
"comment": "OptimizedCursorPaginator.get_item_key uses floor/ceil on a datetime key (order_by='-datetime'), causing TypeError.",
|
| 52 |
+
"severity": "High",
|
| 53 |
+
"category": "bug"
|
| 54 |
+
},
|
| 55 |
+
{
|
| 56 |
+
"comment": "Accessing .has_global_access on organization_context.member can raise an AttributeError when organization_context is None, particularly for non-superuser non-member users.",
|
| 57 |
+
"severity": "High",
|
| 58 |
+
"category": "bug"
|
| 59 |
+
}
|
| 60 |
+
]
|
| 61 |
+
},
|
| 62 |
+
{
|
| 63 |
+
"repo": "sentry",
|
| 64 |
+
"pr": 3,
|
| 65 |
+
"title": "feat(upsampling) - Support upsampled error count with performance optimizations",
|
| 66 |
+
"base": "a5d290951def84afdcc4c88d2f1f20023fc36e2a",
|
| 67 |
+
"head": "6ad6fe3899f630ccf922ce7ac681147dc7987435",
|
| 68 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/sentry-greptile/pull/3",
|
| 69 |
+
"comments": [
|
| 70 |
+
{
|
| 71 |
+
"comment": "In _set_sample_rate_from_error_sampling(), the check `if client_sample_rate:` treats 0.0 as falsy, so a sample_rate of 0.0 is silently skipped and never set on normalized_data.",
|
| 72 |
+
"severity": "Low",
|
| 73 |
+
"category": "bug"
|
| 74 |
+
},
|
| 75 |
+
{
|
| 76 |
+
"comment": "Using Python’s built-in hash() to build cache keys is non-deterministic across processes (hash randomization), so keys won’t match across workers and invalidate_upsampling_cache may fail to delete them. Use a deterministic serialization of project_ids for the cache key.",
|
| 77 |
+
"severity": "Low",
|
| 78 |
+
"category": "data"
|
| 79 |
+
},
|
| 80 |
+
{
|
| 81 |
+
"comment": "The upsampling eligibility check passes the outer dataset instead of the actual dataset used by scoped_dataset. In paths where the query ultimately runs against discover (e.g., dashboard split) while the original dataset is metrics, upsampling may be skipped even when all projects are allowlisted.",
|
| 82 |
+
"severity": "Medium",
|
| 83 |
+
"category": "bug"
|
| 84 |
+
}
|
| 85 |
+
]
|
| 86 |
+
},
|
| 87 |
+
{
|
| 88 |
+
"repo": "sentry",
|
| 89 |
+
"pr": 4,
|
| 90 |
+
"title": "GitHub OAuth Security Enhancement",
|
| 91 |
+
"base": "ccd14e450fcefa5b286c06221775f50a49059f6d",
|
| 92 |
+
"head": "843d7c71926b03f0c5847a0740ac3f7fb3c5fbad",
|
| 93 |
+
"golden_url": "https://github.com/getsentry/sentry/pull/67876",
|
| 94 |
+
"comments": [
|
| 95 |
+
{
|
| 96 |
+
"comment": "Null reference if github_authenticated_user state is missing",
|
| 97 |
+
"severity": "Medium",
|
| 98 |
+
"category": "bug"
|
| 99 |
+
},
|
| 100 |
+
{
|
| 101 |
+
"comment": "OAuth state uses pipeline.signature (static) instead of a per-request random value",
|
| 102 |
+
"severity": "Medium",
|
| 103 |
+
"category": "security"
|
| 104 |
+
},
|
| 105 |
+
{
|
| 106 |
+
"comment": "The code attempts to access integration.metadata[sender][login] without checking for the existence of the sender key. This causes a KeyError for integrations where the sender metadata was not set during creation",
|
| 107 |
+
"severity": "High",
|
| 108 |
+
"category": "bug"
|
| 109 |
+
}
|
| 110 |
+
]
|
| 111 |
+
},
|
| 112 |
+
{
|
| 113 |
+
"repo": "sentry",
|
| 114 |
+
"pr": 5,
|
| 115 |
+
"title": "Replays Self-Serve Bulk Delete System",
|
| 116 |
+
"base": "49a275847631e231672d01b5dcd66558c069d25b",
|
| 117 |
+
"head": "ea188e2d736fd6ed27c1dba8aae63b7268e2a7a9",
|
| 118 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/sentry-greptile/pull/5",
|
| 119 |
+
"comments": [
|
| 120 |
+
{
|
| 121 |
+
"comment": "The BrowserReportingCollectorEndpoint returns HttpResponse objects but the endpoint inherits from Endpoint which expects rest_framework.response.Response objects.",
|
| 122 |
+
"severity": "Medium",
|
| 123 |
+
"category": "api"
|
| 124 |
+
},
|
| 125 |
+
{
|
| 126 |
+
"comment": "In BaseDetectorTypeValidator.update(), the validator incorrectly updates instance.type using validated_data.get('detector_type') instead of validated_data.get('type').",
|
| 127 |
+
"severity": "Medium",
|
| 128 |
+
"category": "bug"
|
| 129 |
+
},
|
| 130 |
+
{
|
| 131 |
+
"comment": "Using zip(error_ids, events.values()) assumes the get_multi result preserves the input order; dict value order is not guaranteed to match error_ids, so event data can be paired with the wrong ID (missing nodes also shift alignment).",
|
| 132 |
+
"severity": "Low",
|
| 133 |
+
"category": "bug"
|
| 134 |
+
},
|
| 135 |
+
{
|
| 136 |
+
"comment": "Hardcoded empty data passed to TableWidgetVisualization causes it to always render an empty table instead of displaying actual results when the feature flag is enabled.",
|
| 137 |
+
"severity": "Medium",
|
| 138 |
+
"category": "bug"
|
| 139 |
+
},
|
| 140 |
+
{
|
| 141 |
+
"comment": "Validation logic incorrectly uses .get('timestamp'), which treats a timestamp of 0 as absent. It should directly check 'timestamp' in self.initial_data to ensure proper field presence detection, preventing both 'age=0' and 'timestamp' from passing mutual-exclusion validation.",
|
| 142 |
+
"severity": "High",
|
| 143 |
+
"category": "bug"
|
| 144 |
+
},
|
| 145 |
+
{
|
| 146 |
+
"comment": "Analytics events are recorded before the feature flag check, resulting in analytics being logged for all requests, including those that return 404 due to the feature being disabled. This can lead to misleading analytics data.",
|
| 147 |
+
"severity": "Medium",
|
| 148 |
+
"category": "bug"
|
| 149 |
+
}
|
| 150 |
+
]
|
| 151 |
+
},
|
| 152 |
+
{
|
| 153 |
+
"repo": "sentry",
|
| 154 |
+
"pr": 6,
|
| 155 |
+
"title": "Span Buffer Multiprocess Enhancement with Health Monitoring",
|
| 156 |
+
"base": "c2c41b0db17dafbcf901412623e874b48ae37a6e",
|
| 157 |
+
"head": "9bf83b05423beff6dcc542f93e903c562e97469b",
|
| 158 |
+
"golden_url": "https://github.com/getsentry/sentry/pull/93824",
|
| 159 |
+
"comments": [
|
| 160 |
+
{
|
| 161 |
+
"comment": "In the SpanFlusher flush loop, metric tags inconsistently use 'shard' (e.g., in spans.buffer.flusher.produce and spans.buffer.segment_size_bytes) and 'shards' (in spans.buffer.flusher.wait_produce) for the same shard identifier value. This prevents correct metric aggregation across flush stages — dashboards and alerts filtering by tag 'shard' will miss data tagged as 'shards' and vice versa.",
|
| 162 |
+
"severity": "Medium",
|
| 163 |
+
"category": "bug"
|
| 164 |
+
},
|
| 165 |
+
{
|
| 166 |
+
"comment": "The test_basic function in test_consumer.py uses a monkeypatched time.sleep that returns immediately, but then calls time.sleep(0.1) expecting it to actually wait.",
|
| 167 |
+
"severity": "Low",
|
| 168 |
+
"category": "test_gap"
|
| 169 |
+
},
|
| 170 |
+
{
|
| 171 |
+
"comment": "Because flusher processes are created via multiprocessing.get_context('spawn').Process, they are instances of multiprocessing.context.SpawnProcess, which on POSIX is not a subclass of multiprocessing.Process, so this isinstance check will always be false and hung processes won't be killed here.",
|
| 172 |
+
"severity": "High",
|
| 173 |
+
"category": "bug"
|
| 174 |
+
},
|
| 175 |
+
{
|
| 176 |
+
"comment": "Sleep in test_consumer.py won’t actually wait because time.sleep was monkeypatched above; consider restoring sleep or using a different sync to ensure the flusher has time to process.",
|
| 177 |
+
"severity": "Medium",
|
| 178 |
+
"category": "test_gap"
|
| 179 |
+
},
|
| 180 |
+
{
|
| 181 |
+
"comment": "Breaking out of the loop when the deadline has elapsed can skip terminating remaining flusher processes, potentially leaving them running after shutdown; consider ensuring termination is attempted even if the deadline is exceeded.",
|
| 182 |
+
"severity": "Medium",
|
| 183 |
+
"category": "concurrency"
|
| 184 |
+
}
|
| 185 |
+
]
|
| 186 |
+
},
|
| 187 |
+
{
|
| 188 |
+
"repo": "sentry",
|
| 189 |
+
"pr": 7,
|
| 190 |
+
"title": "feat(ecosystem): Implement cross-system issue synchronization",
|
| 191 |
+
"base": "19c92a4345beecc750245775de2b3ab9f4f59473",
|
| 192 |
+
"head": "f9919d789416dd32549d7bb9e238d5df55d5265a",
|
| 193 |
+
"golden_url": "https://github.com/getsentry/sentry/pull/77754",
|
| 194 |
+
"comments": [
|
| 195 |
+
{
|
| 196 |
+
"comment": "The AssignmentSource dataclass uses queued: datetime = timezone.now() as a default field value, which evaluates timezone.now() once at class definition time and shares that single datetime instance across all objects.",
|
| 197 |
+
"severity": "Medium",
|
| 198 |
+
"category": "concurrency"
|
| 199 |
+
},
|
| 200 |
+
{
|
| 201 |
+
"comment": "The method name has a typo: test_from_dict_inalid_data should be test_from_dict_invalid_data.",
|
| 202 |
+
"severity": "Low",
|
| 203 |
+
"category": "style"
|
| 204 |
+
},
|
| 205 |
+
{
|
| 206 |
+
"comment": "Method name says 'empty_array' but tests empty dict - consider renaming to 'test_from_dict_empty_dict' for clarity.",
|
| 207 |
+
"severity": "Low",
|
| 208 |
+
"category": "style"
|
| 209 |
+
},
|
| 210 |
+
{
|
| 211 |
+
"comment": "to_dict() returns a datetime for queued; if this dict is passed in task kwargs (e.g., via apply_async), JSON serialization may fail depending on the serializer, which can cause enqueue errors.",
|
| 212 |
+
"severity": "Medium",
|
| 213 |
+
"category": "bug"
|
| 214 |
+
}
|
| 215 |
+
]
|
| 216 |
+
},
|
| 217 |
+
{
|
| 218 |
+
"repo": "sentry",
|
| 219 |
+
"pr": 8,
|
| 220 |
+
"title": "ref(crons): Reorganize incident creation / issue occurrence logic",
|
| 221 |
+
"base": "5fc9f67c1bd6a50d6c6eb3270b1e6fb7938c5865",
|
| 222 |
+
"head": "c3b32a7babfcf62b91553388bcd9e9fbfd30a690",
|
| 223 |
+
"golden_url": "https://github.com/getsentry/sentry/pull/80528",
|
| 224 |
+
"comments": [
|
| 225 |
+
{
|
| 226 |
+
"comment": "The function modifies the config variable to include display values but then returns the original monitor.config instead of the modified version.",
|
| 227 |
+
"severity": "High",
|
| 228 |
+
"category": "bug"
|
| 229 |
+
},
|
| 230 |
+
{
|
| 231 |
+
"comment": "The code fetches MonitorCheckIn objects by ID when the required data already exists in previous_checkins. This creates an unnecessary database query.",
|
| 232 |
+
"severity": "Low",
|
| 233 |
+
"category": "perf"
|
| 234 |
+
}
|
| 235 |
+
]
|
| 236 |
+
},
|
| 237 |
+
{
|
| 238 |
+
"repo": "sentry",
|
| 239 |
+
"pr": 9,
|
| 240 |
+
"title": "feat(uptime): Add ability to use queues to manage parallelism",
|
| 241 |
+
"base": "5c94383dd49b567fb086ad594b40af066f426858",
|
| 242 |
+
"head": "33f4fddf64465f75308957c4431e56fd0443eca3",
|
| 243 |
+
"golden_url": "https://github.com/getsentry/sentry/pull/95633",
|
| 244 |
+
"comments": [
|
| 245 |
+
{
|
| 246 |
+
"comment": "The magic number 50 for max_wait is used repeatedly throughout the tests. Consider extracting this as a named constant to improve maintainability.",
|
| 247 |
+
"severity": "Low",
|
| 248 |
+
"category": "style"
|
| 249 |
+
},
|
| 250 |
+
{
|
| 251 |
+
"comment": "The test test_thread_queue_parallel_error_handling has a docstring that doesn't match the test implementation.",
|
| 252 |
+
"severity": "Low",
|
| 253 |
+
"category": "doc_defect"
|
| 254 |
+
}
|
| 255 |
+
]
|
| 256 |
+
},
|
| 257 |
+
{
|
| 258 |
+
"repo": "sentry",
|
| 259 |
+
"pr": 10,
|
| 260 |
+
"title": "feat(workflow_engine): Add in hook for producing occurrences from the stateful detector",
|
| 261 |
+
"base": "7249010ca8fea2bbc9ae58e7352861c2d17c2ef2",
|
| 262 |
+
"head": "de60b7fb01a1df4ecca82cc842a8b5fb16d92794",
|
| 263 |
+
"golden_url": "https://github.com/getsentry/sentry/pull/80168",
|
| 264 |
+
"comments": [
|
| 265 |
+
{
|
| 266 |
+
"comment": "MetricAlertDetectorHandler inherits from StatefulDetectorHandler but only contains pass, failing to implement its required abstract methods: counter_names (property), get_dedupe_value(), get_group_key_values(), and build_occurrence_and_event_data(). This will cause a TypeError at runtime when the class is instantiated.",
|
| 267 |
+
"severity": "High",
|
| 268 |
+
"category": "api"
|
| 269 |
+
},
|
| 270 |
+
{
|
| 271 |
+
"comment": "Docstring says this returns a list of DetectorEvaluationResult, but the method now returns a dict keyed by DetectorGroupKey. Consider updating the docstring to match the new return type.",
|
| 272 |
+
"severity": "Low",
|
| 273 |
+
"category": "doc_defect"
|
| 274 |
+
},
|
| 275 |
+
{
|
| 276 |
+
"comment": "Wrong value `6` passed for `group_2` occurrence — the data packet specifies `\"group_2\": 10`. Should be `10` to accurately reflect the test scenario, which will ensure the test produces the correct occurrence data.",
|
| 277 |
+
"severity": "Medium",
|
| 278 |
+
"category": "test_gap"
|
| 279 |
+
}
|
| 280 |
+
]
|
| 281 |
+
},
|
| 282 |
+
{
|
| 283 |
+
"repo": "grafana",
|
| 284 |
+
"pr": 1,
|
| 285 |
+
"title": "Anonymous: Add configurable device limit",
|
| 286 |
+
"base": "ed865831071a0c0a63c75ad0cfa6661107dabcaf",
|
| 287 |
+
"head": "3647ba7360b8d157e4a294a650a365b6aca070d8",
|
| 288 |
+
"golden_url": "https://github.com/grafana/grafana/pull/79265",
|
| 289 |
+
"comments": [
|
| 290 |
+
{
|
| 291 |
+
"comment": "Race condition: Multiple concurrent requests could pass the device count check simultaneously and create devices beyond the limit. Consider using a database transaction or lock.",
|
| 292 |
+
"severity": "High",
|
| 293 |
+
"category": "concurrency"
|
| 294 |
+
},
|
| 295 |
+
{
|
| 296 |
+
"comment": "Anonymous authentication now fails entirely if anonDeviceService.TagDevice returns ErrDeviceLimitReached. Previously, device tagging was asynchronous and non-blocking. This change prevents anonymous users from authenticating when the device limit is reached.",
|
| 297 |
+
"severity": "Medium",
|
| 298 |
+
"category": "bug"
|
| 299 |
+
},
|
| 300 |
+
{
|
| 301 |
+
"comment": "The updateDevice function returns ErrDeviceLimitReached when rowsAffected == 0, but zero affected rows means the device doesn't exist or falls outside the time window, not that a limit was reached.",
|
| 302 |
+
"severity": "Low",
|
| 303 |
+
"category": "doc_defect"
|
| 304 |
+
},
|
| 305 |
+
{
|
| 306 |
+
"comment": "Time window calculation inconsistency: Using device.UpdatedAt.UTC().Add(-anonymousDeviceExpiration) as the lower bound but device.UpdatedAt as the current time may not match the intended logic. Consider using time.Now().UTC() consistently.",
|
| 307 |
+
"severity": "Low",
|
| 308 |
+
"category": "bug"
|
| 309 |
+
},
|
| 310 |
+
{
|
| 311 |
+
"comment": "The `tagDeviceUI` function populates the local cache with the device ID before the `CreateOrUpdateDevice` call. If `ErrDeviceLimitReached` is returned, the cache entry remains set, allowing subsequent requests to bypass the device limit until the cache expires after 29 minutes.",
|
| 312 |
+
"severity": "High",
|
| 313 |
+
"category": "bug"
|
| 314 |
+
}
|
| 315 |
+
]
|
| 316 |
+
},
|
| 317 |
+
{
|
| 318 |
+
"repo": "grafana",
|
| 319 |
+
"pr": 2,
|
| 320 |
+
"title": "AuthZService: improve authz caching",
|
| 321 |
+
"base": "e650fa7b2041c91fbb98ef3432b3969e13bbdac9",
|
| 322 |
+
"head": "d9dc93c4a6c88ef850dbe526cb3226ae99cafa20",
|
| 323 |
+
"golden_url": "https://github.com/grafana/grafana/pull/103633",
|
| 324 |
+
"comments": [
|
| 325 |
+
{
|
| 326 |
+
"comment": "The Check operation exhibits asymmetric cache trust logic: cached permission grants are trusted and returned immediately, but cached denials from the same permission cache are ignored, leading to a fresh database lookup. This allows stale cached grants to provide access to revoked resources, posing a security risk. ",
|
| 327 |
+
"severity": "High",
|
| 328 |
+
"category": "security"
|
| 329 |
+
},
|
| 330 |
+
{
|
| 331 |
+
"comment": "The test comment says the cached permissions 'allow access', but the map stores false for dashboards:uid:dash1, so checkPermission will still treat this scope as not allowed.",
|
| 332 |
+
"severity": "Low",
|
| 333 |
+
"category": "doc_defect"
|
| 334 |
+
},
|
| 335 |
+
{
|
| 336 |
+
"comment": "The cache key construction in `userPermDenialCacheKey` uses simple string concatenation with underscores, which can lead to ambiguous keys and collision risks when any component contains underscores or is empty. This could result in incorrect denial cache hits, affecting user permissions.",
|
| 337 |
+
"severity": "Medium",
|
| 338 |
+
"category": "data"
|
| 339 |
+
}
|
| 340 |
+
]
|
| 341 |
+
},
|
| 342 |
+
{
|
| 343 |
+
"repo": "grafana",
|
| 344 |
+
"pr": 3,
|
| 345 |
+
"title": "Plugins: Chore: Renamed instrumentation middleware to metrics middleware",
|
| 346 |
+
"base": "5dac6731cbb99f3374898cf6a1558edb222d323b",
|
| 347 |
+
"head": "00393c2ac9103072bc2194118e455f9248a37816",
|
| 348 |
+
"golden_url": "https://github.com/grafana/grafana/pull/76186",
|
| 349 |
+
"comments": [
|
| 350 |
+
{
|
| 351 |
+
"comment": "The ContextualLoggerMiddleware methods (QueryData, CallResource, CheckHealth, CollectMetrics) panic when a nil request is received. This occurs because they directly access req.PluginContext (via the instrumentContext function) without first checking if req is nil. This is a regression, as previous middleware layers gracefully handled nil requests.",
|
| 352 |
+
"severity": "High",
|
| 353 |
+
"category": "bug"
|
| 354 |
+
},
|
| 355 |
+
{
|
| 356 |
+
"comment": "The traceID is no longer logged for plugin requests. During a refactoring, the tracing import and the logic to extract and add traceID from the context to log parameters were removed from the LoggerMiddleware. The newly introduced ContextualLoggerMiddleware does not add this information, resulting in missing traceID in plugin request logs and impacting debugging and request tracing capabilities.",
|
| 357 |
+
"severity": "Low",
|
| 358 |
+
"category": "bug"
|
| 359 |
+
},
|
| 360 |
+
{
|
| 361 |
+
"comment": "The `TestLogger.FromContext` method returns a new `TestLogger` instance via `NewTestLogger()` instead of returning the receiver (f). This causes logs to be recorded on an un-referenced instance, leading to broken test assertions that expect logs to be recorded on the original logger.",
|
| 362 |
+
"severity": "High",
|
| 363 |
+
"category": "bug"
|
| 364 |
+
}
|
| 365 |
+
]
|
| 366 |
+
},
|
| 367 |
+
{
|
| 368 |
+
"repo": "grafana",
|
| 369 |
+
"pr": 4,
|
| 370 |
+
"title": "Advanced Query Processing Architecture",
|
| 371 |
+
"base": "dcb853d3099c08b74370fcc965342f035dd6d6cc",
|
| 372 |
+
"head": "3ba2457a7090b2b76f4b368c8a9db835d0bec66c",
|
| 373 |
+
"golden_url": "https://github.com/grafana/grafana/pull/107534",
|
| 374 |
+
"comments": [
|
| 375 |
+
{
|
| 376 |
+
"comment": "The applyTemplateVariables method is called with request.filters as the third parameter, but this parameter is not used in the corresponding test setup.",
|
| 377 |
+
"severity": "Low",
|
| 378 |
+
"category": "test_gap"
|
| 379 |
+
}
|
| 380 |
+
]
|
| 381 |
+
},
|
| 382 |
+
{
|
| 383 |
+
"repo": "grafana",
|
| 384 |
+
"pr": 5,
|
| 385 |
+
"title": "Notification Rule Processing Engine",
|
| 386 |
+
"base": "acdb0e151c9a2abd6e691353de6cc515d316ee76",
|
| 387 |
+
"head": "3e6d620d2c1d1f6c10611fba8b0ee062d6fb2a68",
|
| 388 |
+
"golden_url": "https://github.com/grafana/grafana/pull/106778",
|
| 389 |
+
"comments": [
|
| 390 |
+
{
|
| 391 |
+
"comment": "The rendered GrafanaRuleListItem is missing the required key prop for React list items. This can cause rendering issues when the list order changes.",
|
| 392 |
+
"severity": "Medium",
|
| 393 |
+
"category": "bug"
|
| 394 |
+
},
|
| 395 |
+
{
|
| 396 |
+
"comment": "RuleActionsButtons is invoked with only promRule, but SilenceGrafanaRuleDrawer inside RuleActionsButtons still depends on a Grafana Ruler rule being present, so for Grafana rules coming from list views the 'Silence notifications' menu entry (now driven by Grafana Prom abilities) will toggle showSilenceDrawer without ever rendering the drawer. This means clicking 'Silence notifications' for these rules has no visible effect, even when abilities indicate silencing is allowed.",
|
| 397 |
+
"severity": "High",
|
| 398 |
+
"category": "bug"
|
| 399 |
+
}
|
| 400 |
+
]
|
| 401 |
+
},
|
| 402 |
+
{
|
| 403 |
+
"repo": "grafana",
|
| 404 |
+
"pr": 6,
|
| 405 |
+
"title": "Dual Storage Architecture",
|
| 406 |
+
"base": "5e3a5b355ef7478d7be86923749e25aebef5226a",
|
| 407 |
+
"head": "67b74e1e8a7d26d24617b7313b90fa4649138318",
|
| 408 |
+
"golden_url": "https://github.com/grafana/grafana/pull/90045",
|
| 409 |
+
"comments": [
|
| 410 |
+
{
|
| 411 |
+
"comment": "The context is being created with d.Log instead of the log variable that was initialized with additional context values (name, kind, method). This means those values won't be propagated to the logging context.",
|
| 412 |
+
"severity": "Medium",
|
| 413 |
+
"category": "bug"
|
| 414 |
+
},
|
| 415 |
+
{
|
| 416 |
+
"comment": "In DualWriterMode3's DeleteCollection method, when a storage operation fails, recordStorageDuration is incorrectly called with recordLegacyDuration instead.",
|
| 417 |
+
"severity": "High",
|
| 418 |
+
"category": "bug"
|
| 419 |
+
},
|
| 420 |
+
{
|
| 421 |
+
"comment": "Inconsistency: using name instead of options.Kind for metrics recording differs from other methods.",
|
| 422 |
+
"severity": "Medium",
|
| 423 |
+
"category": "api"
|
| 424 |
+
}
|
| 425 |
+
]
|
| 426 |
+
},
|
| 427 |
+
{
|
| 428 |
+
"repo": "grafana",
|
| 429 |
+
"pr": 7,
|
| 430 |
+
"title": "Database Performance Optimizations",
|
| 431 |
+
"base": "f84c8f685310cc41b52831c130e700a01b225b58",
|
| 432 |
+
"head": "81c45bfe449584dc7ff50e4fabd5d0c6568999b5",
|
| 433 |
+
"golden_url": "https://github.com/grafana/grafana/pull/80329",
|
| 434 |
+
"comments": [
|
| 435 |
+
{
|
| 436 |
+
"comment": "The code uses Error log level for what appears to be debugging information. This will pollute error logs in production. Consider using Debug or Info level instead.",
|
| 437 |
+
"severity": "Low",
|
| 438 |
+
"category": "perf"
|
| 439 |
+
},
|
| 440 |
+
{
|
| 441 |
+
"comment": "The cleanup job ticker was changed from 10 minutes to 1 minute, which can lead to increased database load and contention due to more frequent execution of cleanup tasks. This change should be reviewed to ensure it aligns with performance expectations.",
|
| 442 |
+
"severity": "Low",
|
| 443 |
+
"category": "perf"
|
| 444 |
+
}
|
| 445 |
+
]
|
| 446 |
+
},
|
| 447 |
+
{
|
| 448 |
+
"repo": "grafana",
|
| 449 |
+
"pr": 8,
|
| 450 |
+
"title": "Frontend Asset Optimization",
|
| 451 |
+
"base": "0a870e6a8855cee9c8ae391767da40dbb1c16cc6",
|
| 452 |
+
"head": "95000f9fc8049d47f837b6e8603c230c2a073ae5",
|
| 453 |
+
"golden_url": "https://github.com/grafana/grafana/pull/90939",
|
| 454 |
+
"comments": [
|
| 455 |
+
{
|
| 456 |
+
"comment": "The GetWebAssets function implements an incomplete double-checked locking pattern for caching web assets. The function first checks if the cache is populated using a read lock (RLock), and if the cache is empty, it acquires a write lock to populate it. However, it fails to re-check whether the cache was populated by another goroutine while waiting to acquire the write lock.",
|
| 457 |
+
"severity": "Medium",
|
| 458 |
+
"category": "concurrency"
|
| 459 |
+
},
|
| 460 |
+
{
|
| 461 |
+
"comment": "In addition to the missing double-check, the function has a critical flaw in its error handling: it unconditionally assigns the fetch result to the cache (line 69: entryPointAssetsCache = result) regardless of whether the fetch succeeded or failed. When an error occurs during asset fetching, result is nil, and this nil value overwrites any previously valid cache entry.",
|
| 462 |
+
"severity": "High",
|
| 463 |
+
"category": "bug"
|
| 464 |
+
}
|
| 465 |
+
]
|
| 466 |
+
},
|
| 467 |
+
{
|
| 468 |
+
"repo": "grafana",
|
| 469 |
+
"pr": 9,
|
| 470 |
+
"title": "Advanced SQL Analytics Framework",
|
| 471 |
+
"base": "cbe1e7d63f098e306058c0fbcab2f5c30602fa7d",
|
| 472 |
+
"head": "ea71201ddc66f06a3f16387e85a09c53514aaadd",
|
| 473 |
+
"golden_url": "https://github.com/grafana/grafana/pull/94942",
|
| 474 |
+
"comments": [
|
| 475 |
+
{
|
| 476 |
+
"comment": "The enableSqlExpressions function has flawed logic that always returns false, effectively disabling SQL expressions unconditionally:",
|
| 477 |
+
"severity": "Critical",
|
| 478 |
+
"category": "bug"
|
| 479 |
+
},
|
| 480 |
+
{
|
| 481 |
+
"comment": "The DB methods NewInMemoryDB().RunCommands, DB.QueryFramesInto, and DB.TablesList in pkg/expr/sql/db.go return hardcoded 'not implemented' errors after removing the go-duck dependency.",
|
| 482 |
+
"severity": "High",
|
| 483 |
+
"category": "api"
|
| 484 |
+
}
|
| 485 |
+
]
|
| 486 |
+
},
|
| 487 |
+
{
|
| 488 |
+
"repo": "grafana",
|
| 489 |
+
"pr": 10,
|
| 490 |
+
"title": "Unified Storage Performance Optimizations",
|
| 491 |
+
"base": "871af07203177ce59a24e742107119409274f48a",
|
| 492 |
+
"head": "d762a9643618a6ba7c43da27374bd9ffc80889ce",
|
| 493 |
+
"golden_url": "https://github.com/grafana/grafana/pull/97529",
|
| 494 |
+
"comments": [
|
| 495 |
+
{
|
| 496 |
+
"comment": "A race condition in BuildIndex allows multiple goroutines to concurrently build the same expensive index for the same key. This is caused by moving the b.cacheMu lock from protecting the entire function to only protecting the final cache assignment. ",
|
| 497 |
+
"severity": "High",
|
| 498 |
+
"category": "concurrency"
|
| 499 |
+
},
|
| 500 |
+
{
|
| 501 |
+
"comment": "Calling s.search.TotalDocs() here may race with concurrent index creation: TotalDocs iterates b.cache without synchronization, and the event watcher goroutine started just above could trigger BuildIndex writes concurrently, potentially causing a concurrent map read/write panic.",
|
| 502 |
+
"severity": "High",
|
| 503 |
+
"category": "concurrency"
|
| 504 |
+
}
|
| 505 |
+
]
|
| 506 |
+
},
|
| 507 |
+
{
|
| 508 |
+
"repo": "cal.com",
|
| 509 |
+
"pr": 2,
|
| 510 |
+
"title": "Async import of the appStore packages",
|
| 511 |
+
"base": "bff28e5d6fef42b4e7c036c688f0bad4410b42a2",
|
| 512 |
+
"head": "e043a5efd872362a3fc146ed0d9ce4393e316c1e",
|
| 513 |
+
"golden_url": "https://github.com/calcom/cal.com/pull/8087",
|
| 514 |
+
"comments": [
|
| 515 |
+
{
|
| 516 |
+
"comment": "Consider adding try-catch around the await to handle import failures gracefully",
|
| 517 |
+
"severity": "Low",
|
| 518 |
+
"category": "speculative"
|
| 519 |
+
},
|
| 520 |
+
{
|
| 521 |
+
"comment": "The code uses forEach with async callbacks, which causes asynchronous operations (e.g., calendar/video event deletions, payment refunds) to run concurrently without being awaited. This 'fire-and-forget' behavior leads to unhandled promise rejections, race conditions, and incomplete cleanup, as surrounding try-catch blocks cannot properly handle errors from these unawaited promises. Replace forEach with for...of loops or Promise.all() with map() to ensure proper sequential execution and error handling.",
|
| 522 |
+
"severity": "Critical",
|
| 523 |
+
"category": "concurrency"
|
| 524 |
+
}
|
| 525 |
+
]
|
| 526 |
+
},
|
| 527 |
+
{
|
| 528 |
+
"repo": "cal.com",
|
| 529 |
+
"pr": 3,
|
| 530 |
+
"title": "feat: 2fa backup codes",
|
| 531 |
+
"base": "efa6d464a38e60ceeeb88f40668c1c4ac4bfaf54",
|
| 532 |
+
"head": "a308075bc39b77ed7059b0cae9d443d669a7bf98",
|
| 533 |
+
"golden_url": "https://github.com/calcom/cal.com/pull/10600",
|
| 534 |
+
"comments": [
|
| 535 |
+
{
|
| 536 |
+
"comment": "The exported function TwoFactor handles backup codes and is in BackupCode.tsx. Inconsistent naming.",
|
| 537 |
+
"severity": "Low",
|
| 538 |
+
"category": "style"
|
| 539 |
+
},
|
| 540 |
+
{
|
| 541 |
+
"comment": "Error message mentions 'backup code login' but this is a disable endpoint, not login",
|
| 542 |
+
"severity": "Low",
|
| 543 |
+
"category": "doc_defect"
|
| 544 |
+
},
|
| 545 |
+
{
|
| 546 |
+
"comment": "Backup code validation is case-sensitive due to the use of indexOf(). This causes validation to fail if a user enters uppercase hex characters, as backup codes should be case-insensitive for a better user experience.",
|
| 547 |
+
"severity": "Medium",
|
| 548 |
+
"category": "bug"
|
| 549 |
+
},
|
| 550 |
+
{
|
| 551 |
+
"comment": "Because backupCodes are decrypted and mutated in memory before being written back, two concurrent login requests using the same backupCode could both pass this check and update, so a single backup code may effectively be accepted more than once if used concurrently, weakening the intended one-time-use semantics.",
|
| 552 |
+
"severity": "High",
|
| 553 |
+
"category": "concurrency"
|
| 554 |
+
},
|
| 555 |
+
{
|
| 556 |
+
"comment": "Object URL for backup codes is not revoked on component unmount, leading to a potential memory leak. This can cause increased memory usage over time, especially if the component is mounted and unmounted frequently.",
|
| 557 |
+
"severity": "Low",
|
| 558 |
+
"category": "perf"
|
| 559 |
+
}
|
| 560 |
+
]
|
| 561 |
+
},
|
| 562 |
+
{
|
| 563 |
+
"repo": "cal.com",
|
| 564 |
+
"pr": 4,
|
| 565 |
+
"title": "fix: handle collective multiple host on destinationCalendar",
|
| 566 |
+
"base": "500bfb4d82c53c42e7f53250c6715f5fb474dc2b",
|
| 567 |
+
"head": "bd797c1ea00a61425735f2b9fd7ce212ebf8c8ab",
|
| 568 |
+
"golden_url": "https://github.com/calcom/cal.com/pull/10967",
|
| 569 |
+
"comments": [
|
| 570 |
+
{
|
| 571 |
+
"comment": "A null reference occurs in GoogleCalendarService.createEvent() and updateEvent() when mainHostDestinationCalendar is destructured from evt.destinationCalendar but evt.destinationCalendar is null or an empty array, causing mainHostDestinationCalendar to be undefined.",
|
| 572 |
+
"severity": "High",
|
| 573 |
+
"category": "bug"
|
| 574 |
+
},
|
| 575 |
+
{
|
| 576 |
+
"comment": "The optional chaining on mainHostDestinationCalendar?.integration is redundant since you already check mainHostDestinationCalendar in the ternary condition.",
|
| 577 |
+
"severity": "Low",
|
| 578 |
+
"category": "style"
|
| 579 |
+
},
|
| 580 |
+
{
|
| 581 |
+
"comment": "Logic error: when externalCalendarId is provided, you're searching for a calendar where externalId === externalCalendarId, but this will always fail since you're looking for a calendar that matches itself. Should likely find by credentialId or use different logic.",
|
| 582 |
+
"severity": "High",
|
| 583 |
+
"category": "bug"
|
| 584 |
+
},
|
| 585 |
+
{
|
| 586 |
+
"comment": "Logic inversion in organization creation: The slug property is now conditionally set when IS_TEAM_BILLING_ENABLED is true, instead of when it's false as originally intended. This change, combined with requestedSlug still being set when IS_TEAM_BILLING_ENABLED is true, results in both properties being set when billing is enabled, and neither when disabled",
|
| 587 |
+
"severity": "Medium",
|
| 588 |
+
"category": "bug"
|
| 589 |
+
},
|
| 590 |
+
{
|
| 591 |
+
"comment": "The Calendar interface now requires createEvent(event, credentialId), but some implementations (e.g., Lark/Office365) still declare createEvent(event) only—this breaks the interface contract (also applies to other locations in the PR).",
|
| 592 |
+
"severity": "Low",
|
| 593 |
+
"category": "api"
|
| 594 |
+
},
|
| 595 |
+
{
|
| 596 |
+
"comment": "The `credential` may be undefined when passed to `updateEvent` if `reference.credentialId` is set but the credential is not found. This can lead to a runtime error when `updateEvent` is called with an undefined credential, which should be handled to prevent crashes.",
|
| 597 |
+
"severity": "High",
|
| 598 |
+
"category": "bug"
|
| 599 |
+
}
|
| 600 |
+
]
|
| 601 |
+
},
|
| 602 |
+
{
|
| 603 |
+
"repo": "cal.com",
|
| 604 |
+
"pr": 5,
|
| 605 |
+
"title": "feat: convert InsightsBookingService to use Prisma.sql raw queries",
|
| 606 |
+
"base": "202d248ae45f8f2f01324b0d8eb5914e9154112f",
|
| 607 |
+
"head": "56ff75f07b92ba8ef499ff28a2f98c25f339fdae",
|
| 608 |
+
"golden_url": "https://github.com/calcom/cal.com/pull/22345",
|
| 609 |
+
"comments": [
|
| 610 |
+
{
|
| 611 |
+
"comment": "In getBaseConditions(), the else if (filterConditions) and final else branches are unreachable. This is because getAuthorizationConditions() always returns a non-null Prisma.Sql object, making authConditions always truthy, which means only the first two if/else if conditions are ever evaluated.",
|
| 612 |
+
"severity": "Low",
|
| 613 |
+
"category": "bug"
|
| 614 |
+
},
|
| 615 |
+
{
|
| 616 |
+
"comment": "Fetching userIdsFromOrg only when teamsFromOrg.length > 0 can exclude org-level members for orgs without child teams; consider deriving from teamIds (which includes orgId) or removing the guard so org-only orgs still include member user bookings.",
|
| 617 |
+
"severity": "Medium",
|
| 618 |
+
"category": "speculative"
|
| 619 |
+
}
|
| 620 |
+
]
|
| 621 |
+
},
|
| 622 |
+
{
|
| 623 |
+
"repo": "cal.com",
|
| 624 |
+
"pr": 6,
|
| 625 |
+
"title": "Comprehensive workflow reminder management for booking lifecycle events",
|
| 626 |
+
"base": "235ec0e906a189ceb0843cfa7af585b1d46f699f",
|
| 627 |
+
"head": "2ebfcf448c7e4136ac1b8b9ef9b526a4424fd155",
|
| 628 |
+
"golden_url": "https://github.com/calcom/cal.com/pull/7232",
|
| 629 |
+
"comments": [
|
| 630 |
+
{
|
| 631 |
+
"comment": "Asynchronous functions deleteScheduledEmailReminder and deleteScheduledSMSReminder are called without await inside forEach loops. This occurs during booking rescheduling/cancellation, and workflow/workflow step deletion/updates. Consequently, scheduled workflow reminders may not be reliably cancelled, potentially leaving them active.",
|
| 632 |
+
"severity": "Medium",
|
| 633 |
+
"category": "concurrency"
|
| 634 |
+
},
|
| 635 |
+
{
|
| 636 |
+
"comment": "When immediateDelete is true, the deleteScheduledEmailReminder function cancels the SendGrid email but fails to delete the corresponding WorkflowReminder record from the database. This creates orphaned database entries and is inconsistent with the immediateDelete: false path, which marks the record as cancelled. The SendGrid DELETE API call is also omitted in this path.",
|
| 637 |
+
"severity": "High",
|
| 638 |
+
"category": "data"
|
| 639 |
+
},
|
| 640 |
+
{
|
| 641 |
+
"comment": "The 'cancelled' field is nullable, which can lead to existing records having null values instead of a default of false. This can cause incorrect behavior in the application when checking the cancellation status of reminders.",
|
| 642 |
+
"severity": "Medium",
|
| 643 |
+
"category": "data"
|
| 644 |
+
}
|
| 645 |
+
]
|
| 646 |
+
},
|
| 647 |
+
{
|
| 648 |
+
"repo": "cal.com",
|
| 649 |
+
"pr": 7,
|
| 650 |
+
"title": "Advanced date override handling and timezone compatibility improvements",
|
| 651 |
+
"base": "c4fe69d8265ba632c10f3a90ea05e4a74ff14c85",
|
| 652 |
+
"head": "3ef328421f60cd096b7676ef7ee7c32b71593049",
|
| 653 |
+
"golden_url": "https://github.com/calcom/cal.com/pull/8330",
|
| 654 |
+
"comments": [
|
| 655 |
+
{
|
| 656 |
+
"comment": "Incorrect end time calculation using slotStartTime instead of slotEndTime",
|
| 657 |
+
"severity": "Medium",
|
| 658 |
+
"category": "bug"
|
| 659 |
+
},
|
| 660 |
+
{
|
| 661 |
+
"comment": "Using === for dayjs object comparison will always return false as it compares object references, not values. Use .isSame() method instead: dayjs(date.start).add(utcOffset, 'minutes').isSame(dayjs(date.end).add(utcOffset, minutes))",
|
| 662 |
+
"severity": "Medium",
|
| 663 |
+
"category": "bug"
|
| 664 |
+
}
|
| 665 |
+
]
|
| 666 |
+
},
|
| 667 |
+
{
|
| 668 |
+
"repo": "cal.com",
|
| 669 |
+
"pr": 8,
|
| 670 |
+
"title": "OAuth credential sync and app integration enhancements",
|
| 671 |
+
"base": "bc89fe00ea84d20bedcec782f0701b9711dc8201",
|
| 672 |
+
"head": "824145b0e245661875240ed5c8745decd2293d1a",
|
| 673 |
+
"golden_url": "https://github.com/calcom/cal.com/pull/11059",
|
| 674 |
+
"comments": [
|
| 675 |
+
{
|
| 676 |
+
"comment": "The parseRefreshTokenResponse function incorrectly sets refresh_token to the hardcoded string 'refresh_token' when it's missing from the OAuth refresh token response. This invalidates the token, breaking subsequent token refreshes and causing authentication failures.",
|
| 677 |
+
"severity": "High",
|
| 678 |
+
"category": "bug"
|
| 679 |
+
},
|
| 680 |
+
{
|
| 681 |
+
"comment": "The Zod schema in parseRefreshTokenResponse uses computed property keys [z.string().toString()] and [z.string().optional().toString()] in minimumTokenResponseSchema, which is invalid Zod syntax and will throw a runtime error.",
|
| 682 |
+
"severity": "High",
|
| 683 |
+
"category": "bug"
|
| 684 |
+
},
|
| 685 |
+
{
|
| 686 |
+
"comment": "parseRefreshTokenResponse returns a Zod safeParse result ({ success, data, error }), not the credential key object. Persisting that as key stores the wrapper instead of the token payload; we should store the parsed data or use schema parse.",
|
| 687 |
+
"severity": "High",
|
| 688 |
+
"category": "data"
|
| 689 |
+
},
|
| 690 |
+
{
|
| 691 |
+
"comment": "When APP_CREDENTIAL_SHARING_ENABLED and CALCOM_CREDENTIAL_SYNC_ENDPOINT are set, the refreshFunction helper returns the fetch Response, but several callers (for example GoogleCalendarService.refreshAccessToken expecting res.data, and HubspotCalendarService.refreshAccessToken expecting a HubspotToken) assume it returns the integration-specific token object. That mismatch will cause runtime errors in the sync-enabled path unless the return type or those call sites are adjusted.",
|
| 692 |
+
"severity": "High",
|
| 693 |
+
"category": "api"
|
| 694 |
+
},
|
| 695 |
+
{
|
| 696 |
+
"comment": "When the sync endpoint path is used, res is a fetch Response and has no .data; res?.data will be undefined and token.access_token will throw at runtime. This relies on a consistent return shape from refreshOAuthTokens, which isn’t guaranteed currently.",
|
| 697 |
+
"severity": "High",
|
| 698 |
+
"category": "bug"
|
| 699 |
+
},
|
| 700 |
+
{
|
| 701 |
+
"comment": "The `refreshOAuthTokens` function is passed `credentialId` instead of `userId`, which breaks the credential sync functionality by causing incorrect user lookups. This issue can lead to failures in syncing user credentials, impacting user experience.",
|
| 702 |
+
"severity": "High",
|
| 703 |
+
"category": "bug"
|
| 704 |
+
},
|
| 705 |
+
{
|
| 706 |
+
"comment": "The Salesforce integration checks `response.statusText` instead of `response.ok` when handling OAuth token refresh responses. This can lead to unreliable behavior, as a successful response may not be correctly identified, resulting in the use of stale credentials and potential authentication failures.",
|
| 707 |
+
"severity": "High",
|
| 708 |
+
"category": "bug"
|
| 709 |
+
},
|
| 710 |
+
{
|
| 711 |
+
"comment": "The `jsforce.Connection` is created using stale `credentialKey.access_token` and `credentialKey.instance_url` after a token refresh, which can lead to authentication failures and incorrect data access. Ensure that the connection is established using the refreshed token values instead.",
|
| 712 |
+
"severity": "High",
|
| 713 |
+
"category": "bug"
|
| 714 |
+
},
|
| 715 |
+
{
|
| 716 |
+
"comment": "The `appCredentialWebhookRequestBodySchema.parse` function can throw on invalid payloads, resulting in 500 Internal Server Errors instead of the expected 400 Bad Request responses. This can lead to confusion for clients and hinder proper error handling.",
|
| 717 |
+
"severity": "Medium",
|
| 718 |
+
"category": "api"
|
| 719 |
+
}
|
| 720 |
+
]
|
| 721 |
+
},
|
| 722 |
+
{
|
| 723 |
+
"repo": "cal.com",
|
| 724 |
+
"pr": 9,
|
| 725 |
+
"title": "SMS workflow reminder retry count tracking",
|
| 726 |
+
"base": "917c7b0764f4c6bfdca95db2c5f73dbfdbe11757",
|
| 727 |
+
"head": "2dae0bfb8c72b51aa49260dc1f7f215a6290f3a6",
|
| 728 |
+
"golden_url": "https://github.com/calcom/cal.com/pull/14943",
|
| 729 |
+
"comments": [
|
| 730 |
+
{
|
| 731 |
+
"comment": "Using retryCount: reminder.retryCount + 1 reads a possibly stale value and can lose increments under concurrency; consider an atomic increment via Prisma (increment: 1) to avoid race conditions (also applies to the similar update in the catch block).",
|
| 732 |
+
"severity": "High",
|
| 733 |
+
"category": "concurrency"
|
| 734 |
+
},
|
| 735 |
+
{
|
| 736 |
+
"comment": "The deletion logic in scheduleSMSReminders.ts incorrectly deletes non-SMS workflow reminders (e.g., Email, WhatsApp) that have retryCount > 1. This occurs because the retryCount condition within the OR clause for deletion lacks a method: WorkflowMethods.SMS filter, causing it to apply to all reminder types instead of only SMS reminders, which is the intended scope of this function.",
|
| 737 |
+
"severity": "High",
|
| 738 |
+
"category": "bug"
|
| 739 |
+
}
|
| 740 |
+
]
|
| 741 |
+
},
|
| 742 |
+
{
|
| 743 |
+
"repo": "cal.com",
|
| 744 |
+
"pr": 10,
|
| 745 |
+
"title": "Add guest management functionality to existing bookings",
|
| 746 |
+
"base": "b004587262e8221083bafbe9a0c515e7becaa7b3",
|
| 747 |
+
"head": "baa9045af7711ea0b86390cb0bf0fdce5430228c",
|
| 748 |
+
"golden_url": "https://github.com/calcom/cal.com/pull/14740",
|
| 749 |
+
"comments": [
|
| 750 |
+
{
|
| 751 |
+
"comment": "The addGuests.handler.ts blacklist check uses blacklistedGuestEmails.includes(guest) after lowercasing the blacklist but not the input guest emails, allowing attackers to bypass BLACKLISTED_GUEST_EMAILS restrictions by submitting emails with uppercase characters.",
|
| 752 |
+
"severity": "High",
|
| 753 |
+
"category": "security"
|
| 754 |
+
},
|
| 755 |
+
{
|
| 756 |
+
"comment": "The logic for checking team admin/owner permissions is incorrect. This condition uses AND (&&) which requires both isTeamAdmin AND isTeamOwner to be true, but it should use OR (||) since a user needs to be either an admin OR an owner to have permission.",
|
| 757 |
+
"severity": "Critical",
|
| 758 |
+
"category": "bug"
|
| 759 |
+
},
|
| 760 |
+
{
|
| 761 |
+
"comment": "The sendAddGuestsEmails function in email-manager.ts passes the full calendarEvent.attendees array when determining which attendees receive AttendeeScheduledEmail vs AttendeeAddGuestsEmail, but checks if newGuests.includes(attendee.email) where newGuests is the input guests array.",
|
| 762 |
+
"severity": "Medium",
|
| 763 |
+
"category": "bug"
|
| 764 |
+
},
|
| 765 |
+
{
|
| 766 |
+
"comment": "uniqueGuests filters out existing attendees and blacklisted emails but does not deduplicate duplicates within the input; createMany can insert duplicate attendee rows if the client submits repeated emails.",
|
| 767 |
+
"severity": "Medium",
|
| 768 |
+
"category": "bug"
|
| 769 |
+
},
|
| 770 |
+
{
|
| 771 |
+
"comment": "Starting with an array containing an empty string may cause validation issues. Consider starting with an empty array [] and handling the empty state in the MultiEmail component instead.",
|
| 772 |
+
"severity": "Low",
|
| 773 |
+
"category": "bug"
|
| 774 |
+
},
|
| 775 |
+
{
|
| 776 |
+
"comment": "The `sendAddGuestsEmails` function does not check the `disableStandardEmails` flags in the `EventType` metadata, which may result in sending emails to hosts/attendees even when standard emails are disabled for the event type.",
|
| 777 |
+
"severity": "Medium",
|
| 778 |
+
"category": "bug"
|
| 779 |
+
}
|
| 780 |
+
]
|
| 781 |
+
},
|
| 782 |
+
{
|
| 783 |
+
"repo": "cal.com",
|
| 784 |
+
"pr": 11,
|
| 785 |
+
"title": "feat: add calendar cache status and actions (#22532)",
|
| 786 |
+
"base": "3784421f025afc3a595fbb4e222916785cc6de0c",
|
| 787 |
+
"head": "cb7869234729f908648af6796ab4082b569daf39",
|
| 788 |
+
"golden_url": "https://github.com/calcom/cal.com/pull/22532",
|
| 789 |
+
"comments": [
|
| 790 |
+
{
|
| 791 |
+
"comment": "The updateManyByCredentialId call uses an empty data object, which prevents Prisma's @updatedAt decorator from updating the updatedAt timestamp. This results in inaccurate cache status tracking, as the timestamp isn't updated when the cache is refreshed. To fix this, explicitly set the updatedAt field.",
|
| 792 |
+
"severity": "Medium",
|
| 793 |
+
"category": "bug"
|
| 794 |
+
},
|
| 795 |
+
{
|
| 796 |
+
"comment": "logic: macOS-specific sed syntax with empty string after -i flag will fail on Linux systems",
|
| 797 |
+
"severity": "Low",
|
| 798 |
+
"category": "bug"
|
| 799 |
+
},
|
| 800 |
+
{
|
| 801 |
+
"comment": "Throwing a generic Error for authentication failures results in a 500 response in tRPC. Instead, it should return a structured TRPCError with an appropriate code, such as FORBIDDEN, to accurately reflect the error type.",
|
| 802 |
+
"severity": "High",
|
| 803 |
+
"category": "api"
|
| 804 |
+
},
|
| 805 |
+
{
|
| 806 |
+
"comment": "Date is formatted with hardcoded 'en-US' locale instead of using the user's locale from useLocale, which can lead to incorrect date representation for users in different locales.",
|
| 807 |
+
"severity": "Medium",
|
| 808 |
+
"category": "bug"
|
| 809 |
+
}
|
| 810 |
+
]
|
| 811 |
+
},
|
| 812 |
+
{
|
| 813 |
+
"repo": "keycloak",
|
| 814 |
+
"pr": 1,
|
| 815 |
+
"title": "Fixing Re-authentication with passkeys",
|
| 816 |
+
"base": "30f804af450dec523909a52f2a4b97302d27f5cc",
|
| 817 |
+
"head": "3214b188de808fdb0fff335556b686f1b0a63218",
|
| 818 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/keycloak-greptile/pull/1",
|
| 819 |
+
"comments": [
|
| 820 |
+
{
|
| 821 |
+
"comment": "In UsernameForm.authenticate(), isConditionalPasskeysEnabled() is called without passing the required UserModel parameter.",
|
| 822 |
+
"severity": "Medium",
|
| 823 |
+
"category": "api"
|
| 824 |
+
},
|
| 825 |
+
{
|
| 826 |
+
"comment": "With isConditionalPasskeysEnabled(UserModel user) requiring user != null, authenticate(...) will not call webauthnAuth.fillContextForm(context) on the initial login page where context.getUser() is still null, so conditional passkey UI will not be set up for first-time passkey login. Consider whether this should also be enabled when no user has been selected yet so ID-less passkey authentication on the initial login form continues to work.",
|
| 827 |
+
"severity": "Medium",
|
| 828 |
+
"category": "speculative"
|
| 829 |
+
}
|
| 830 |
+
]
|
| 831 |
+
},
|
| 832 |
+
{
|
| 833 |
+
"repo": "keycloak",
|
| 834 |
+
"pr": 2,
|
| 835 |
+
"title": "Add caching support for IdentityProviderStorageProvider.getForLogin operations",
|
| 836 |
+
"base": "5ff9e9147dc08432b3ec7753906467c390b1e6ee",
|
| 837 |
+
"head": "3e597722a9164d145bc46aa1de5bd714fb6ba357",
|
| 838 |
+
"golden_url": "https://github.com/keycloak/keycloak/pull/32918",
|
| 839 |
+
"comments": [
|
| 840 |
+
{
|
| 841 |
+
"comment": "InfinispanIdentityProviderStorageProvider.getForLogin() recursively calls session.identityProviders().getById() instead of idpDelegate.getById(), causing the cache lookup to re-enter the same caching layer.",
|
| 842 |
+
"severity": "Critical",
|
| 843 |
+
"category": "bug"
|
| 844 |
+
},
|
| 845 |
+
{
|
| 846 |
+
"comment": "Cleanup reference uses incorrect alias - should be 'idp-alias-' + i instead of 'alias'.",
|
| 847 |
+
"severity": "Medium",
|
| 848 |
+
"category": "bug"
|
| 849 |
+
}
|
| 850 |
+
]
|
| 851 |
+
},
|
| 852 |
+
{
|
| 853 |
+
"repo": "keycloak",
|
| 854 |
+
"pr": 3,
|
| 855 |
+
"title": "Add AuthzClientCryptoProvider for authorization client cryptographic operations",
|
| 856 |
+
"base": "10aca5552314d6e5c9226f3c6d0107861c38c693",
|
| 857 |
+
"head": "b95d12a968e8374a93ddcd56f47ab12eb4136ff4",
|
| 858 |
+
"golden_url": "https://github.com/keycloak/keycloak/pull/33832",
|
| 859 |
+
"comments": [
|
| 860 |
+
{
|
| 861 |
+
"comment": "Returns wrong provider (default keystore instead of BouncyCastle)",
|
| 862 |
+
"severity": "High",
|
| 863 |
+
"category": "bug"
|
| 864 |
+
},
|
| 865 |
+
{
|
| 866 |
+
"comment": "Dead code exists where ASN1Encoder instances are created and written to, but their results are immediately discarded. The actual encoding is performed by new ASN1Encoder instances created in the subsequent return statement, rendering the earlier operations useless.",
|
| 867 |
+
"severity": "Low",
|
| 868 |
+
"category": "perf"
|
| 869 |
+
},
|
| 870 |
+
{
|
| 871 |
+
"comment": "When length starts at -1 from indefinite-length encoding, the arithmetic 'length = length - bytes.length' will behave unexpectedly, potentially leading to incorrect processing of encoded data.",
|
| 872 |
+
"severity": "Medium",
|
| 873 |
+
"category": "bug"
|
| 874 |
+
},
|
| 875 |
+
{
|
| 876 |
+
"comment": "Abstract order() method on CryptoProvider may break backward compatibility with existing implementations",
|
| 877 |
+
"severity": "Low",
|
| 878 |
+
"category": "speculative"
|
| 879 |
+
}
|
| 880 |
+
]
|
| 881 |
+
},
|
| 882 |
+
{
|
| 883 |
+
"repo": "keycloak",
|
| 884 |
+
"pr": 4,
|
| 885 |
+
"title": "Add rolling-updates feature flag and compatibility framework",
|
| 886 |
+
"base": "690b0e4bef15654ea9037b0a26b3337e548c6b48",
|
| 887 |
+
"head": "0f91e67b9025d978059b21b5c41283e5000a509c",
|
| 888 |
+
"golden_url": "https://github.com/keycloak/keycloak/pull/36882",
|
| 889 |
+
"comments": [
|
| 890 |
+
{
|
| 891 |
+
"comment": "Incorrect method call for exit codes. The picocli.exit() method calls System.exit() directly, which is problematic:",
|
| 892 |
+
"severity": "Medium",
|
| 893 |
+
"category": "bug"
|
| 894 |
+
},
|
| 895 |
+
{
|
| 896 |
+
"comment": "Need to add changelog/release notes documenting the exit code change and migration guidance",
|
| 897 |
+
"severity": "Low",
|
| 898 |
+
"category": "doc_defect"
|
| 899 |
+
}
|
| 900 |
+
]
|
| 901 |
+
},
|
| 902 |
+
{
|
| 903 |
+
"repo": "keycloak",
|
| 904 |
+
"pr": 5,
|
| 905 |
+
"title": "Add Client resource type and scopes to authorization schema",
|
| 906 |
+
"base": "baa6ebbeb8791017c01ce9fa63965f8dc584ddfe",
|
| 907 |
+
"head": "7e5540896bbbafc02234b6ea2b15215dc24cb972",
|
| 908 |
+
"golden_url": "https://github.com/keycloak/keycloak/pull/36880",
|
| 909 |
+
"comments": [
|
| 910 |
+
{
|
| 911 |
+
"comment": "Inconsistent feature flag bug causing orphaned permissions. The AdminPermissions event listener, responsible for cleaning up permissions upon role, client, or group removal, is incorrectly guarded by the ADMIN_FINE_GRAINED_AUTHZ (V1) feature flag. This is inconsistent with other methods in the class that use ADMIN_FINE_GRAINED_AUTHZ_V2. Consequently, if ADMIN_FINE_GRAINED_AUTHZ_V2 is enabled but V1 is not, the permission cleanup logic will not execute, leading to orphaned permission data. Cleanup should occur regardless of which fine-grained authorization version is enabled.",
|
| 912 |
+
"severity": "High",
|
| 913 |
+
"category": "bug"
|
| 914 |
+
},
|
| 915 |
+
{
|
| 916 |
+
"comment": "In hasPermission(ClientModel client, String scope), the resource lookup uses findByName(server, client.getId(), server.getId()), but AdminPermissionsSchema.getOrCreateResource creates per-client resources with the owner set to resourceServer.getClientId(), so this lookup will never find those resources and will always fall back to the 'all-clients' resource, effectively ignoring client-specific permissions.",
|
| 917 |
+
"severity": "High",
|
| 918 |
+
"category": "bug"
|
| 919 |
+
},
|
| 920 |
+
{
|
| 921 |
+
"comment": "In getClientsWithPermission(String scope), iterating resourceStore.findByType(server, AdminPermissionsSchema.CLIENTS_RESOURCE_TYPE) and returning resource.getName() will only ever consider the type-level 'Clients' resource (per-client resources have no type) and return its name, while AvailableRoleMappingResource#getRoleIdsWithPermissions expects actual client IDs to pass to realm.getClientById, which can lead to incorrect behavior or a null client and subsequent failures.",
|
| 922 |
+
"severity": "High",
|
| 923 |
+
"category": "bug"
|
| 924 |
+
},
|
| 925 |
+
{
|
| 926 |
+
"comment": "In ClientPermissionsV2.hasPermission, the method getResourceTypeResource could return null, leading to a NullPointerException in findByResource. Defensive null checks are needed to prevent this issue.",
|
| 927 |
+
"severity": "High",
|
| 928 |
+
"category": "bug"
|
| 929 |
+
},
|
| 930 |
+
{
|
| 931 |
+
"comment": "Remove unused getEvaluationContext private method in ClientPermissionsV2 - it is defined but never called",
|
| 932 |
+
"severity": "Low",
|
| 933 |
+
"category": "style"
|
| 934 |
+
}
|
| 935 |
+
]
|
| 936 |
+
},
|
| 937 |
+
{
|
| 938 |
+
"repo": "keycloak",
|
| 939 |
+
"pr": 6,
|
| 940 |
+
"title": "Add Groups resource type and scopes to authorization schema",
|
| 941 |
+
"base": "7a8d18122aea42278332120093d5cefce9748356",
|
| 942 |
+
"head": "679f44692dbc288bedc8f1535071c8467dbaf70c",
|
| 943 |
+
"golden_url": "https://github.com/keycloak/keycloak/pull/37038",
|
| 944 |
+
"comments": [
|
| 945 |
+
{
|
| 946 |
+
"comment": "In GroupPermissionsV2.canManage(), the permission fallback checks for both VIEW and MANAGE scopes (hasPermission(null, AdminPermissionsSchema.VIEW, AdminPermissionsSchema.MANAGE)), but canManage() should only grant access for MANAGE scope, not VIEW. This means users with only VIEW permission on groups can pass the canManage() check, granting them write access they should not have. The canView() method correctly checks both VIEW and MANAGE, but canManage() should only check MANAGE.",
|
| 947 |
+
"severity": "High",
|
| 948 |
+
"category": "bug"
|
| 949 |
+
},
|
| 950 |
+
{
|
| 951 |
+
"comment": "In getGroupIdsWithViewPermission, hasPermission is called with groupResource.getId() and the same groupResource.getId() is added to granted, but hasPermission resolves resources by name (treating the argument as a group id) and the GroupPermissionEvaluator contract says this method returns group IDs that are later used as UserModel.GROUPS and in getUsersCount group filters. This mismatch means per-group VIEW_MEMBERS/MANAGE_MEMBERS permissions may not yield the expected group IDs for filtering and counts, and evaluation may effectively only look at the type-level 'all-groups' resource; consider revisiting whether this should operate on the underlying group ids (resource names) instead so it aligns with the JPA queries and the interface contract.",
|
| 952 |
+
"severity": "High",
|
| 953 |
+
"category": "api"
|
| 954 |
+
}
|
| 955 |
+
]
|
| 956 |
+
},
|
| 957 |
+
{
|
| 958 |
+
"repo": "keycloak",
|
| 959 |
+
"pr": 7,
|
| 960 |
+
"title": "Add HTML sanitizer for translated message resources",
|
| 961 |
+
"base": "21d53112849fe55f328f3de2f071989b8763de61",
|
| 962 |
+
"head": "5d77e7ea7d431aa0a6b65904457b7471bd050e81",
|
| 963 |
+
"golden_url": "https://github.com/keycloak/keycloak/pull/37429",
|
| 964 |
+
"comments": [
|
| 965 |
+
{
|
| 966 |
+
"comment": "The translation is in Italian instead of Lithuanian. This should be translated to Lithuanian to match the file's locale (messages_lt.properties).",
|
| 967 |
+
"severity": "Medium",
|
| 968 |
+
"category": "doc_defect"
|
| 969 |
+
},
|
| 970 |
+
{
|
| 971 |
+
"comment": "The totpStep1 value uses Traditional Chinese terms in the Simplified Chinese file (zh_CN), which is likely incorrect for this locale. Please verify the locale‑appropriate translation.",
|
| 972 |
+
"severity": "Medium",
|
| 973 |
+
"category": "doc_defect"
|
| 974 |
+
},
|
| 975 |
+
{
|
| 976 |
+
"comment": "The anchor sanitization logic has a potential issue where it consumes English matcher groups without proper validation. If the translated text has more anchor tags than the English text, this could lead to incorrect validation results.",
|
| 977 |
+
"severity": "Low",
|
| 978 |
+
"category": "security"
|
| 979 |
+
},
|
| 980 |
+
{
|
| 981 |
+
"comment": "The method name 'santizeAnchors' should be 'sanitizeAnchors' (missing 'i').",
|
| 982 |
+
"severity": "Low",
|
| 983 |
+
"category": "style"
|
| 984 |
+
},
|
| 985 |
+
{
|
| 986 |
+
"comment": "Field HTML_TAGS should be declared as 'private static final' following Java naming conventions for constants",
|
| 987 |
+
"severity": "Low",
|
| 988 |
+
"category": "style"
|
| 989 |
+
}
|
| 990 |
+
]
|
| 991 |
+
},
|
| 992 |
+
{
|
| 993 |
+
"repo": "keycloak",
|
| 994 |
+
"pr": 8,
|
| 995 |
+
"title": "Implement access token context encoding framework",
|
| 996 |
+
"base": "b545339e2c924263a498653f348610de0c09059c",
|
| 997 |
+
"head": "c8738721df2cd2d16fe16adec571b4192354a771",
|
| 998 |
+
"golden_url": "https://github.com/keycloak/keycloak/pull/37634",
|
| 999 |
+
"comments": [
|
| 1000 |
+
{
|
| 1001 |
+
"comment": "In AccessTokenContext constructor, the fourth Objects.requireNonNull validates grantType twice instead of validating rawTokenId, allowing null rawTokenId values to pass validation.",
|
| 1002 |
+
"severity": "Critical",
|
| 1003 |
+
"category": "bug"
|
| 1004 |
+
},
|
| 1005 |
+
{
|
| 1006 |
+
"comment": "In isAccessTokenId, the substring for the grant shortcut and the equality check look inverted: the grant shortcut occupies indices 4–5 (substring(4,6)), and a match should return true (combined with UUID check), not false.",
|
| 1007 |
+
"severity": "High",
|
| 1008 |
+
"category": "bug"
|
| 1009 |
+
},
|
| 1010 |
+
{
|
| 1011 |
+
"comment": "Javadoc mentions \"usually like 3-letters shortcut\" but some implementations use 2-letter shortcuts (\"ac\", \"cc\", \"rt\", \"te\", \"pc\", \"ci\", \"ro\"). Consider updating documentation to reflect actual usage pattern.",
|
| 1012 |
+
"severity": "Low",
|
| 1013 |
+
"category": "doc_defect"
|
| 1014 |
+
},
|
| 1015 |
+
{
|
| 1016 |
+
"comment": " Catching generic RuntimeException is too broad. The implementation throws IllegalArgumentException specifically - catch that instead for more precise testing.",
|
| 1017 |
+
"severity": "Low",
|
| 1018 |
+
"category": "bug"
|
| 1019 |
+
}
|
| 1020 |
+
]
|
| 1021 |
+
},
|
| 1022 |
+
{
|
| 1023 |
+
"repo": "keycloak",
|
| 1024 |
+
"pr": 9,
|
| 1025 |
+
"title": "Implement recovery key support for user storage providers",
|
| 1026 |
+
"base": "a0852eaa2ed19408ecf8ad02652802d00529a085",
|
| 1027 |
+
"head": "134437a5a7e31472763ffa2ac3cc91030e7ee389",
|
| 1028 |
+
"golden_url": "https://github.com/keycloak/keycloak/pull/38446",
|
| 1029 |
+
"comments": [
|
| 1030 |
+
{
|
| 1031 |
+
"comment": "Unsafe raw List deserialization without type safety. Calling Optional.get() directly on the Optional returned by RecoveryAuthnCodesUtils.getCredential(user) without checking isPresent() can lead to a NoSuchElementException if the Optional is empty.",
|
| 1032 |
+
"severity": "Medium",
|
| 1033 |
+
"category": "bug"
|
| 1034 |
+
},
|
| 1035 |
+
{
|
| 1036 |
+
"comment": "After creating the RecoveryAuthnCodesCredentialModel, consider setting its id from the stored credential (e.g., myUser.recoveryCodes.getId()); otherwise getId() will be null and downstream removal by id (e.g., removeStoredCredentialById in the authenticator flow) may not work.",
|
| 1037 |
+
"severity": "Low",
|
| 1038 |
+
"category": "bug"
|
| 1039 |
+
}
|
| 1040 |
+
]
|
| 1041 |
+
},
|
| 1042 |
+
{
|
| 1043 |
+
"repo": "keycloak",
|
| 1044 |
+
"pr": 10,
|
| 1045 |
+
"title": "Fix concurrent group access to prevent NullPointerException",
|
| 1046 |
+
"base": "e92b825a14800e42f42d5f22ee314e94cf7c4e27",
|
| 1047 |
+
"head": "332c9b6e4a1288705f173a9b797742859384d1e0",
|
| 1048 |
+
"golden_url": "https://github.com/keycloak/keycloak/pull/40940",
|
| 1049 |
+
"comments": [
|
| 1050 |
+
{
|
| 1051 |
+
"comment": "Returning null from getSubGroupsCount() violates the GroupModel contract (Javadoc says it never returns null) and may lead to NPEs in callers that expect a non-null count.",
|
| 1052 |
+
"severity": "Critical",
|
| 1053 |
+
"category": "api"
|
| 1054 |
+
},
|
| 1055 |
+
{
|
| 1056 |
+
"comment": "The reader thread isn’t waited for; flipping deletedAll to true and asserting immediately can race and miss exceptions added just after the flag change, making this test flaky.",
|
| 1057 |
+
"severity": "Medium",
|
| 1058 |
+
"category": "concurrency"
|
| 1059 |
+
}
|
| 1060 |
+
]
|
| 1061 |
+
},
|
| 1062 |
+
{
|
| 1063 |
+
"repo": "discourse",
|
| 1064 |
+
"pr": 1,
|
| 1065 |
+
"title": "FEATURE: automatically downsize large images",
|
| 1066 |
+
"base": "3f71fa15c93bb0b751bb92abae1b5dc9a21bd4ca",
|
| 1067 |
+
"head": "ffbaf8c54269df2ce510de91245760fddce09896",
|
| 1068 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/discourse-graphite/pull/1",
|
| 1069 |
+
"comments": [
|
| 1070 |
+
{
|
| 1071 |
+
"comment": "The downsize method is defined twice. The second definition, which expects a single dimensions string parameter, overrides the first, which expected separate max_width and max_height parameters. This makes the original method unreachable and breaks existing code that calls it with separate width and height arguments.",
|
| 1072 |
+
"severity": "Medium",
|
| 1073 |
+
"category": "bug"
|
| 1074 |
+
},
|
| 1075 |
+
{
|
| 1076 |
+
"comment": "Hardcoding maxSizeKB = 10 * 1024 ignores Discourse.SiteSettings['max_' + type + '_size_kb'], so the client-side limit can diverge from server-side and per-type settings (also applies to the 413 handler below).",
|
| 1077 |
+
"severity": "Low",
|
| 1078 |
+
"category": "bug"
|
| 1079 |
+
},
|
| 1080 |
+
{
|
| 1081 |
+
"comment": "Passing 80% as the dimensions can fail for animated GIFs when allow_animated_thumbnails is true, since the animated path uses gifsicle --resize-fit which expects WxH geometry, not a percentage; downsizing would then silently fail.",
|
| 1082 |
+
"severity": "Medium",
|
| 1083 |
+
"category": "data"
|
| 1084 |
+
},
|
| 1085 |
+
{
|
| 1086 |
+
"comment": "The loop checking `tempfile.size` may never terminate correctly due to stale cached size, leading to potential infinite loops or incorrect file handling after modifications.",
|
| 1087 |
+
"severity": "Medium",
|
| 1088 |
+
"category": "bug"
|
| 1089 |
+
}
|
| 1090 |
+
]
|
| 1091 |
+
},
|
| 1092 |
+
{
|
| 1093 |
+
"repo": "discourse",
|
| 1094 |
+
"pr": 2,
|
| 1095 |
+
"title": "FEATURE: per-topic unsubscribe option in emails",
|
| 1096 |
+
"base": "56abd247e1829cb6de82dfcc8ce04deb5f0d1e91",
|
| 1097 |
+
"head": "6669a2d94d76eea3b99b8c476d12b1eb66726b07",
|
| 1098 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/discourse-graphite/pull/2",
|
| 1099 |
+
"comments": [
|
| 1100 |
+
{
|
| 1101 |
+
"comment": "logic: Potential nil pointer exception - if no TopicUser record exists, tu will be nil and calling methods on it will crash",
|
| 1102 |
+
"severity": "High",
|
| 1103 |
+
"category": "bug"
|
| 1104 |
+
},
|
| 1105 |
+
{
|
| 1106 |
+
"comment": "Typo in property name: 'stopNotificiationsText' should be 'stopNotificationsText' (missing 'n' in 'Notifications')",
|
| 1107 |
+
"severity": "Low",
|
| 1108 |
+
"category": "style"
|
| 1109 |
+
}
|
| 1110 |
+
]
|
| 1111 |
+
},
|
| 1112 |
+
{
|
| 1113 |
+
"repo": "discourse",
|
| 1114 |
+
"pr": 3,
|
| 1115 |
+
"title": "Add comprehensive email validation for blocked users",
|
| 1116 |
+
"base": "e25638dab0d4b98f99c8fe8976ccaae8f4fb9db3",
|
| 1117 |
+
"head": "5f8a130277dbddc95d133cd2832be639baf89213",
|
| 1118 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/discourse-graphite/pull/3",
|
| 1119 |
+
"comments": [
|
| 1120 |
+
{
|
| 1121 |
+
"comment": "BlockedEmail.should_block_email? method has side effects during a read operation - it updates statistics even when just checking if an email should be blocked. This could cause race conditions in concurrent environments and makes the method name misleading.",
|
| 1122 |
+
"severity": "Medium",
|
| 1123 |
+
"category": "concurrency"
|
| 1124 |
+
},
|
| 1125 |
+
{
|
| 1126 |
+
"comment": "The regex pattern @(#{domains}) in email_in_restriction_setting? method only matches domain suffixes, not full domains with proper boundary anchoring. An attacker can register evil.example.com to bypass a whitelist entry for example.com.",
|
| 1127 |
+
"severity": "Medium",
|
| 1128 |
+
"category": "bug"
|
| 1129 |
+
},
|
| 1130 |
+
{
|
| 1131 |
+
"comment": "The case-sensitive email lookup in `BlockedEmail.should_block?` creates a bypass risk, allowing 'User@Example.com' to bypass a block on 'user@example.com'. This can lead to unauthorized access to blocked users.",
|
| 1132 |
+
"severity": "Critical",
|
| 1133 |
+
"category": "security"
|
| 1134 |
+
}
|
| 1135 |
+
]
|
| 1136 |
+
},
|
| 1137 |
+
{
|
| 1138 |
+
"repo": "discourse",
|
| 1139 |
+
"pr": 4,
|
| 1140 |
+
"title": "Enhance embed URL handling and validation system",
|
| 1141 |
+
"base": "62db063e1e1abe691313ab42682a68f796d63769",
|
| 1142 |
+
"head": "4f8aed295a29954023b2849c060ef4fb299d1b5d",
|
| 1143 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/discourse-graphite/pull/4",
|
| 1144 |
+
"comments": [
|
| 1145 |
+
{
|
| 1146 |
+
"comment": "The PollFeed job calls open(SiteSetting.feed_polling_url) without validating the URL, allowing an attacker who controls the feed_polling_url site setting to make the server fetch arbitrary internal or external URLs.",
|
| 1147 |
+
"severity": "Critical",
|
| 1148 |
+
"category": "security"
|
| 1149 |
+
},
|
| 1150 |
+
{
|
| 1151 |
+
"comment": "The current origin validation using indexOf is insufficient and can be bypassed. An attacker could use a malicious domain like evil-discourseUrl.com to pass this check.",
|
| 1152 |
+
"severity": "Medium",
|
| 1153 |
+
"category": "security"
|
| 1154 |
+
},
|
| 1155 |
+
{
|
| 1156 |
+
"comment": "postMessage targetOrigin should be the origin (scheme+host+port), not the full referrer URL; using the full URL will cause the message to be dropped and prevent resizing.",
|
| 1157 |
+
"severity": "Medium",
|
| 1158 |
+
"category": "security"
|
| 1159 |
+
},
|
| 1160 |
+
{
|
| 1161 |
+
"comment": "The code sets X-Frame-Options: ALLOWALL which completely disables clickjacking protection. The referer validation can be bypassed (referer headers are easily spoofed), and the fallback to empty string for nil referer masks validation failures.",
|
| 1162 |
+
"severity": "Medium",
|
| 1163 |
+
"category": "security"
|
| 1164 |
+
},
|
| 1165 |
+
{
|
| 1166 |
+
"comment": "The TopicEmbed.import method is susceptible to a NoMethodError if the contents parameter is nil when attempting to append a string, and an XSS vulnerability due to unescaped url interpolation in the generated HTML.",
|
| 1167 |
+
"severity": "Medium",
|
| 1168 |
+
"category": "bug"
|
| 1169 |
+
},
|
| 1170 |
+
{
|
| 1171 |
+
"comment": "The ERB block closes with end if, which is invalid Ruby/ERB and will raise at render; it should just be end to close the if block.",
|
| 1172 |
+
"severity": "Medium",
|
| 1173 |
+
"category": "bug"
|
| 1174 |
+
},
|
| 1175 |
+
{
|
| 1176 |
+
"comment": "Calling `i.content.scrub` assumes that `i.content` is always populated. However, many RSS feeds do not provide a `content` field, leading to a potential nil pointer exception when `i.content` is nil. A fallback to `description` should be implemented to prevent crashes.",
|
| 1177 |
+
"severity": "High",
|
| 1178 |
+
"category": "bug"
|
| 1179 |
+
},
|
| 1180 |
+
{
|
| 1181 |
+
"comment": "An unescaped request header (request.referer) is interpolated into JavaScript without proper escaping, which can lead to XSS vulnerabilities if the referer contains malicious content. This issue can allow attackers to execute arbitrary scripts in the context of the application.",
|
| 1182 |
+
"severity": "Critical",
|
| 1183 |
+
"category": "security"
|
| 1184 |
+
}
|
| 1185 |
+
]
|
| 1186 |
+
},
|
| 1187 |
+
{
|
| 1188 |
+
"repo": "discourse",
|
| 1189 |
+
"pr": 5,
|
| 1190 |
+
"title": "Optimize header layout performance with flexbox mixins",
|
| 1191 |
+
"base": "98fa098e6fade3097a11fe7f99a98a4e6ffb4728",
|
| 1192 |
+
"head": "5b229316ee4c661836ed1161139692a3e8527444",
|
| 1193 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/discourse-graphite/pull/5",
|
| 1194 |
+
"comments": [
|
| 1195 |
+
{
|
| 1196 |
+
"comment": "Mixing float: left with flexbox causes layout issues. Further this PR removes the float-based right alignment for .d-header .panel, which may cause the login panel in the non-Ember/noscript header (where .panel is nested inside .row and not a flex item) to stack under the title instead of remaining right-aligned.",
|
| 1197 |
+
"severity": "Low",
|
| 1198 |
+
"category": "bug"
|
| 1199 |
+
},
|
| 1200 |
+
{
|
| 1201 |
+
"comment": "-ms-align-items never existed in any version of IE/Edge; the correct legacy property is -ms-flex-align.",
|
| 1202 |
+
"severity": "Low",
|
| 1203 |
+
"category": "bug"
|
| 1204 |
+
},
|
| 1205 |
+
{
|
| 1206 |
+
"comment": "-webkit-box-ordinal-group and -moz-box-ordinal-group require values starting from 1, not 0. If $val is 0, this will cause incorrect rendering in older browsers, leading to layout issues.",
|
| 1207 |
+
"severity": "Medium",
|
| 1208 |
+
"category": "bug"
|
| 1209 |
+
}
|
| 1210 |
+
]
|
| 1211 |
+
},
|
| 1212 |
+
{
|
| 1213 |
+
"repo": "discourse",
|
| 1214 |
+
"pr": 6,
|
| 1215 |
+
"title": "UX: show complete URL path if website domain is same as instance domain",
|
| 1216 |
+
"base": "7a5fbae060bd0d3e29f3a4b5c6f2bfd8b2914dc7",
|
| 1217 |
+
"head": "267d8be1f556ed59639ced396c885bb44586da19",
|
| 1218 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/discourse-graphite/pull/6",
|
| 1219 |
+
"comments": [
|
| 1220 |
+
{
|
| 1221 |
+
"comment": "The include_website_name method is missing the required ? suffix. Rails serializers expect include_ methods to end with ? for conditional attribute inclusion, a convention followed by other methods in this serializer. Without it, the website_name attribute may not be conditionally included as intended. Additionally, the '.' << website_host string concatenation should be replaced with '.' + website_host or '.#{website_host}' to avoid mutating string literals, which can lead to issues.",
|
| 1222 |
+
"severity": "Medium",
|
| 1223 |
+
"category": "api"
|
| 1224 |
+
}
|
| 1225 |
+
]
|
| 1226 |
+
},
|
| 1227 |
+
{
|
| 1228 |
+
"repo": "discourse",
|
| 1229 |
+
"pr": 7,
|
| 1230 |
+
"title": "scale-color $lightness must use $secondary for dark themes",
|
| 1231 |
+
"base": "7554b5e3c458dc79b591d5e874e79ab10cf30c2f",
|
| 1232 |
+
"head": "d38c4d5f7443223c81529c22470293771baf9f38",
|
| 1233 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/discourse-graphite/pull/7",
|
| 1234 |
+
"comments": [
|
| 1235 |
+
{
|
| 1236 |
+
"comment": "In .topic-meta-data h5 a, the original code had color: scale-color($primary, $lightness: 30%) but was changed to dark-light-choose(scale-color($primary, $lightness: 70%), scale-color($secondary, $lightness: 30%)). The lightness for the light theme changed from 30% to 70%, which is a dramatic inversion",
|
| 1237 |
+
"severity": "Low",
|
| 1238 |
+
"category": "style"
|
| 1239 |
+
},
|
| 1240 |
+
{
|
| 1241 |
+
"comment": "This change for desktop/user.css changes $primary from 30% to 50% for the light theme; most other changes preserve the original $primary value and move the complement to $secondary for dark. Consider reviewing this (also applies to a similar .name change in the mobile variant).",
|
| 1242 |
+
"severity": "Low",
|
| 1243 |
+
"category": "speculative"
|
| 1244 |
+
},
|
| 1245 |
+
{
|
| 1246 |
+
"comment": "In topic-post.css the original code used $lightness: 70% but the replacement uses $lightness: 30% for the light theme. This makes the text significantly darker than intended.",
|
| 1247 |
+
"severity": "Low",
|
| 1248 |
+
"category": "bug"
|
| 1249 |
+
},
|
| 1250 |
+
{
|
| 1251 |
+
"comment": "The light theme color for `.topic-meta-data h5 a` was changed from `scale-color($primary, $lightness: 30%)` to `scale-color($primary, $lightness: 70%)`, which may unintentionally reduce contrast and affect readability. This change should be reviewed to ensure it aligns with design intentions.",
|
| 1252 |
+
"severity": "Medium",
|
| 1253 |
+
"category": "bug"
|
| 1254 |
+
},
|
| 1255 |
+
{
|
| 1256 |
+
"comment": "In mobile/user.scss line 497, the lightness value for dark themes should be inverted to 70% instead of being changed to 50%. This change may lead to unintended visual regressions in light themes.",
|
| 1257 |
+
"severity": "Medium",
|
| 1258 |
+
"category": "bug"
|
| 1259 |
+
}
|
| 1260 |
+
]
|
| 1261 |
+
},
|
| 1262 |
+
{
|
| 1263 |
+
"repo": "discourse",
|
| 1264 |
+
"pr": 8,
|
| 1265 |
+
"title": "FIX: proper handling of group memberships",
|
| 1266 |
+
"base": "4975fc28903a84418f546b2809370f19abf10e08",
|
| 1267 |
+
"head": "060cda77729cb1c4a827560e09e89a7b22078ba9",
|
| 1268 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/discourse-graphite/pull/8",
|
| 1269 |
+
"comments": [
|
| 1270 |
+
{
|
| 1271 |
+
"comment": " The findMembers() call is now asynchronous and unhandled. The controller may not have member data immediately available, creating a race condition.",
|
| 1272 |
+
"severity": "High",
|
| 1273 |
+
"category": "concurrency"
|
| 1274 |
+
},
|
| 1275 |
+
{
|
| 1276 |
+
"comment": "In the next action, capping the next offset at user_count can produce an empty page (e.g., total equal to limit results in offset == total, showing 2/2 with no members). This can cause confusing UX on the last page.",
|
| 1277 |
+
"severity": "Medium",
|
| 1278 |
+
"category": "bug"
|
| 1279 |
+
},
|
| 1280 |
+
{
|
| 1281 |
+
"comment": "The remove_member test uses xhr :put to call the remove_member action, but the route defines delete 'members' => 'groups#remove_member' requiring DELETE method.",
|
| 1282 |
+
"severity": "Medium",
|
| 1283 |
+
"category": "api"
|
| 1284 |
+
},
|
| 1285 |
+
{
|
| 1286 |
+
"comment": "The `totalPages` calculation using `Math.floor(user_count / limit) + 1` produces an extra page when `user_count` is an exact multiple of `limit`, leading to incorrect pagination. For example, with 100 users and a limit of 50, it reports 3 pages instead of 2, allowing navigation to an empty page.",
|
| 1287 |
+
"severity": "Medium",
|
| 1288 |
+
"category": "bug"
|
| 1289 |
+
},
|
| 1290 |
+
{
|
| 1291 |
+
"comment": "Expected to return a value at the end of function - code paths without explicit returns will return undefined",
|
| 1292 |
+
"severity": "Medium",
|
| 1293 |
+
"category": "bug"
|
| 1294 |
+
},
|
| 1295 |
+
{
|
| 1296 |
+
"comment": "The route provides the group's ID in params[:id], but the code attempts to read it from params[:group_id], causing the action to fail. This results in a broken feature when trying to access group memberships.",
|
| 1297 |
+
"severity": "High",
|
| 1298 |
+
"category": "bug"
|
| 1299 |
+
}
|
| 1300 |
+
]
|
| 1301 |
+
},
|
| 1302 |
+
{
|
| 1303 |
+
"repo": "discourse",
|
| 1304 |
+
"pr": 9,
|
| 1305 |
+
"title": "FEATURE: Localization fallbacks (server-side)",
|
| 1306 |
+
"base": "728845d008f06828630a632e5c7d67e11bf15deb",
|
| 1307 |
+
"head": "ecfa17b5a79dfdc91e7a4d50b42ae78a35d0a293",
|
| 1308 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/discourse-graphite/pull/9",
|
| 1309 |
+
"comments": [
|
| 1310 |
+
{
|
| 1311 |
+
"comment": "The @loaded_locales instance variable in translate_accelerator.rb is lazily initialized and accessed by multiple concurrent threads without synchronization.",
|
| 1312 |
+
"severity": "Low",
|
| 1313 |
+
"category": "concurrency"
|
| 1314 |
+
},
|
| 1315 |
+
{
|
| 1316 |
+
"comment": "Consider normalizing the input locale (e.g., to a symbol) when checking/loading here to avoid double-loading if the same locale is passed as a String vs Symbol (also applies to other locations in the PR).",
|
| 1317 |
+
"severity": "Low",
|
| 1318 |
+
"category": "perf"
|
| 1319 |
+
}
|
| 1320 |
+
]
|
| 1321 |
+
},
|
| 1322 |
+
{
|
| 1323 |
+
"repo": "discourse",
|
| 1324 |
+
"pr": 10,
|
| 1325 |
+
"title": "FEATURE: Can edit category/host relationships for embedding",
|
| 1326 |
+
"base": "913c3d6f636d02b3dd6c2c022ca1af2bec95d752",
|
| 1327 |
+
"head": "d1c69189f3c90ecf56013a8da904da9bff9a8e19",
|
| 1328 |
+
"golden_url": "https://github.com/ai-code-review-evaluation/discourse-graphite/pull/10",
|
| 1329 |
+
"comments": [
|
| 1330 |
+
{
|
| 1331 |
+
"comment": "The EmbeddableHost model's before_validation callback calls self.host.sub! to strip http://, https://, and path segments, but if self.host is nil, this raises NoMethodError.",
|
| 1332 |
+
"severity": "Critical",
|
| 1333 |
+
"category": "bug"
|
| 1334 |
+
},
|
| 1335 |
+
{
|
| 1336 |
+
"comment": "The update and destroy methods in Admin::EmbeddableHostsController do not validate the existence of the EmbeddableHost record retrieved by ID. If EmbeddableHost.where(id: params[:id]).first returns nil (i.e., the host does not exist), attempting to call methods on the nil object (e.g., save_host or destroy) will result in a NoMethodError.",
|
| 1337 |
+
"severity": "Medium",
|
| 1338 |
+
"category": "bug"
|
| 1339 |
+
},
|
| 1340 |
+
{
|
| 1341 |
+
"comment": "record_for_host compares lower(host) = ? but does not normalize the parameter’s case, so mixed‑case referer hosts may fail to match even though comparison intends to be case‑insensitive.",
|
| 1342 |
+
"severity": "Medium",
|
| 1343 |
+
"category": "bug"
|
| 1344 |
+
},
|
| 1345 |
+
{
|
| 1346 |
+
"comment": "Because this migration inserts embeddable_hosts rows with raw SQL, any existing embeddable_hosts values that include http:// or /https:// or path segments won’t go through the EmbeddableHost model’s normalization, so the new host lookup (which compares only the bare host) may fail for migrated data. Consider ensuring that migrated hosts are normalized to the same format as newly created EmbeddableHost records so existing embedding configurations keep working.",
|
| 1347 |
+
"severity": "High",
|
| 1348 |
+
"category": "data"
|
| 1349 |
+
},
|
| 1350 |
+
{
|
| 1351 |
+
"comment": "The contents of `category_fabricator.rb` and `embeddable_host_fabricator.rb` have been swapped, resulting in the loss of original category fabricators and potentially causing errors in fabricator usage.",
|
| 1352 |
+
"severity": "High",
|
| 1353 |
+
"category": "bug"
|
| 1354 |
+
},
|
| 1355 |
+
{
|
| 1356 |
+
"comment": "The SQL query in the `app/controllers/admin/embeddable_hosts_controller.rb` file uses string interpolation (`'#{h}'`) to insert values, which is vulnerable to SQL injection. It should use parameter binding or proper quoting to prevent this security vulnerability.",
|
| 1357 |
+
"severity": "Critical",
|
| 1358 |
+
"category": "security"
|
| 1359 |
+
},
|
| 1360 |
+
{
|
| 1361 |
+
"comment": "The migration accesses execute(...)[0]['id'] without checking if the query returned any rows, which causes a crash when no embed_category setting exists. This can lead to a broken feature when attempting to edit category/host relationships.",
|
| 1362 |
+
"severity": "High",
|
| 1363 |
+
"category": "bug"
|
| 1364 |
+
}
|
| 1365 |
+
]
|
| 1366 |
+
}
|
| 1367 |
+
]
|
greptile/results/jev.jsonl.gz
ADDED
|
@@ -0,0 +1,3 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
version https://git-lfs.github.com/spec/v1
|
| 2 |
+
oid sha256:af03c66bc1851b1625a67fb87cc16ba61888a6f32f32e5fc20457fd7ef40d39c
|
| 3 |
+
size 62958
|
greptile/results/jev048.jsonl.gz
ADDED
|
@@ -0,0 +1,3 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
version https://git-lfs.github.com/spec/v1
|
| 2 |
+
oid sha256:d4dc953851ffe50c0e6b682842162124932e5da009fc2695bfa17e53e6ab5757
|
| 3 |
+
size 26975
|
greptile/results/oai.jsonl.gz
ADDED
|
@@ -0,0 +1,3 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
version https://git-lfs.github.com/spec/v1
|
| 2 |
+
oid sha256:fbbe8bf974f3005181d730dffa6436847e1433b26e130ee43a4524141f625fab
|
| 3 |
+
size 62175
|
greptile/results/oai2q.jsonl.gz
ADDED
|
@@ -0,0 +1,3 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
version https://git-lfs.github.com/spec/v1
|
| 2 |
+
oid sha256:2c75ef09d198958e314156a542417d136226a94f934dfeba213de7298d9f040c
|
| 3 |
+
size 26134
|
greptile/results/oai407.jsonl.gz
ADDED
|
@@ -0,0 +1,3 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
version https://git-lfs.github.com/spec/v1
|
| 2 |
+
oid sha256:1b0c9c4fd3ea2f1895b0b1572367882808b22e5a8006dedf8613fce3b404e83f
|
| 3 |
+
size 67017
|
greptile/summary.json
ADDED
|
@@ -0,0 +1,302 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
[
|
| 2 |
+
{
|
| 3 |
+
"config": "oai2q",
|
| 4 |
+
"label": "perch#418, OpenAI Decisions",
|
| 5 |
+
"cutoff": 0.6,
|
| 6 |
+
"prs": 50,
|
| 7 |
+
"missing": [],
|
| 8 |
+
"known": 38,
|
| 9 |
+
"known_of": 50,
|
| 10 |
+
"known_chance": 20.2,
|
| 11 |
+
"caught": 42,
|
| 12 |
+
"of": 47,
|
| 13 |
+
"chance": 32,
|
| 14 |
+
"golden": 116,
|
| 15 |
+
"golden_of": 140,
|
| 16 |
+
"flags": 490,
|
| 17 |
+
"read": 1568,
|
| 18 |
+
"flag_rate": 0.313,
|
| 19 |
+
"median_flags": 7,
|
| 20 |
+
"cost": 0.335
|
| 21 |
+
},
|
| 22 |
+
{
|
| 23 |
+
"config": "oai2q",
|
| 24 |
+
"label": "perch#418, OpenAI Decisions",
|
| 25 |
+
"cutoff": 0.7,
|
| 26 |
+
"prs": 50,
|
| 27 |
+
"missing": [],
|
| 28 |
+
"known": 33,
|
| 29 |
+
"known_of": 50,
|
| 30 |
+
"known_chance": 16.3,
|
| 31 |
+
"caught": 39,
|
| 32 |
+
"of": 47,
|
| 33 |
+
"chance": 27.3,
|
| 34 |
+
"golden": 105,
|
| 35 |
+
"golden_of": 140,
|
| 36 |
+
"flags": 383,
|
| 37 |
+
"read": 1568,
|
| 38 |
+
"flag_rate": 0.244,
|
| 39 |
+
"median_flags": 6,
|
| 40 |
+
"cost": 0.335
|
| 41 |
+
},
|
| 42 |
+
{
|
| 43 |
+
"config": "oai2q",
|
| 44 |
+
"label": "perch#418, OpenAI Decisions",
|
| 45 |
+
"cutoff": 0.8,
|
| 46 |
+
"prs": 50,
|
| 47 |
+
"missing": [],
|
| 48 |
+
"known": 28,
|
| 49 |
+
"known_of": 50,
|
| 50 |
+
"known_chance": 11.8,
|
| 51 |
+
"caught": 39,
|
| 52 |
+
"of": 47,
|
| 53 |
+
"chance": 21.5,
|
| 54 |
+
"golden": 86,
|
| 55 |
+
"golden_of": 140,
|
| 56 |
+
"flags": 264,
|
| 57 |
+
"read": 1568,
|
| 58 |
+
"flag_rate": 0.168,
|
| 59 |
+
"median_flags": 4,
|
| 60 |
+
"cost": 0.335
|
| 61 |
+
},
|
| 62 |
+
{
|
| 63 |
+
"config": "jev048",
|
| 64 |
+
"label": "perch 0.4.8, Jev",
|
| 65 |
+
"cutoff": 0.6,
|
| 66 |
+
"prs": 50,
|
| 67 |
+
"missing": [],
|
| 68 |
+
"known": 22,
|
| 69 |
+
"known_of": 50,
|
| 70 |
+
"known_chance": 8.2,
|
| 71 |
+
"caught": 27,
|
| 72 |
+
"of": 47,
|
| 73 |
+
"chance": 15.2,
|
| 74 |
+
"golden": 65,
|
| 75 |
+
"golden_of": 140,
|
| 76 |
+
"flags": 179,
|
| 77 |
+
"read": 1568,
|
| 78 |
+
"flag_rate": 0.114,
|
| 79 |
+
"median_flags": 2,
|
| 80 |
+
"cost": 0.149
|
| 81 |
+
},
|
| 82 |
+
{
|
| 83 |
+
"config": "jev048",
|
| 84 |
+
"label": "perch 0.4.8, Jev",
|
| 85 |
+
"cutoff": 0.7,
|
| 86 |
+
"prs": 50,
|
| 87 |
+
"missing": [],
|
| 88 |
+
"known": 12,
|
| 89 |
+
"known_of": 50,
|
| 90 |
+
"known_chance": 4,
|
| 91 |
+
"caught": 19,
|
| 92 |
+
"of": 47,
|
| 93 |
+
"chance": 8.8,
|
| 94 |
+
"golden": 37,
|
| 95 |
+
"golden_of": 140,
|
| 96 |
+
"flags": 75,
|
| 97 |
+
"read": 1568,
|
| 98 |
+
"flag_rate": 0.048,
|
| 99 |
+
"median_flags": 0,
|
| 100 |
+
"cost": 0.149
|
| 101 |
+
},
|
| 102 |
+
{
|
| 103 |
+
"config": "jev048",
|
| 104 |
+
"label": "perch 0.4.8, Jev",
|
| 105 |
+
"cutoff": 0.8,
|
| 106 |
+
"prs": 50,
|
| 107 |
+
"missing": [],
|
| 108 |
+
"known": 6,
|
| 109 |
+
"known_of": 50,
|
| 110 |
+
"known_chance": 0.7,
|
| 111 |
+
"caught": 8,
|
| 112 |
+
"of": 47,
|
| 113 |
+
"chance": 2.2,
|
| 114 |
+
"golden": 13,
|
| 115 |
+
"golden_of": 140,
|
| 116 |
+
"flags": 18,
|
| 117 |
+
"read": 1568,
|
| 118 |
+
"flag_rate": 0.011,
|
| 119 |
+
"median_flags": 0,
|
| 120 |
+
"cost": 0.149
|
| 121 |
+
},
|
| 122 |
+
{
|
| 123 |
+
"config": "oai407",
|
| 124 |
+
"label": "perch#407, OpenAI Decisions",
|
| 125 |
+
"cutoff": 0.6,
|
| 126 |
+
"prs": 50,
|
| 127 |
+
"missing": [],
|
| 128 |
+
"known": 39,
|
| 129 |
+
"known_of": 50,
|
| 130 |
+
"known_chance": 16.8,
|
| 131 |
+
"caught": 44,
|
| 132 |
+
"of": 47,
|
| 133 |
+
"chance": 28.3,
|
| 134 |
+
"golden": 122,
|
| 135 |
+
"golden_of": 140,
|
| 136 |
+
"flags": 918,
|
| 137 |
+
"read": 4205,
|
| 138 |
+
"flag_rate": 0.218,
|
| 139 |
+
"median_flags": 14,
|
| 140 |
+
"cost": 0.64
|
| 141 |
+
},
|
| 142 |
+
{
|
| 143 |
+
"config": "oai407",
|
| 144 |
+
"label": "perch#407, OpenAI Decisions",
|
| 145 |
+
"cutoff": 0.7,
|
| 146 |
+
"prs": 50,
|
| 147 |
+
"missing": [],
|
| 148 |
+
"known": 36,
|
| 149 |
+
"known_of": 50,
|
| 150 |
+
"known_chance": 13.1,
|
| 151 |
+
"caught": 42,
|
| 152 |
+
"of": 47,
|
| 153 |
+
"chance": 23.8,
|
| 154 |
+
"golden": 110,
|
| 155 |
+
"golden_of": 140,
|
| 156 |
+
"flags": 684,
|
| 157 |
+
"read": 4205,
|
| 158 |
+
"flag_rate": 0.163,
|
| 159 |
+
"median_flags": 10,
|
| 160 |
+
"cost": 0.64
|
| 161 |
+
},
|
| 162 |
+
{
|
| 163 |
+
"config": "oai407",
|
| 164 |
+
"label": "perch#407, OpenAI Decisions",
|
| 165 |
+
"cutoff": 0.8,
|
| 166 |
+
"prs": 50,
|
| 167 |
+
"missing": [],
|
| 168 |
+
"known": 33,
|
| 169 |
+
"known_of": 50,
|
| 170 |
+
"known_chance": 9.4,
|
| 171 |
+
"caught": 40,
|
| 172 |
+
"of": 47,
|
| 173 |
+
"chance": 18.3,
|
| 174 |
+
"golden": 98,
|
| 175 |
+
"golden_of": 140,
|
| 176 |
+
"flags": 472,
|
| 177 |
+
"read": 4205,
|
| 178 |
+
"flag_rate": 0.112,
|
| 179 |
+
"median_flags": 6,
|
| 180 |
+
"cost": 0.64
|
| 181 |
+
},
|
| 182 |
+
{
|
| 183 |
+
"config": "jev",
|
| 184 |
+
"label": "perch 0.4.7, Jev",
|
| 185 |
+
"cutoff": 0.6,
|
| 186 |
+
"prs": 50,
|
| 187 |
+
"missing": [],
|
| 188 |
+
"known": 18,
|
| 189 |
+
"known_of": 50,
|
| 190 |
+
"known_chance": 6.1,
|
| 191 |
+
"caught": 27,
|
| 192 |
+
"of": 47,
|
| 193 |
+
"chance": 12.8,
|
| 194 |
+
"golden": 61,
|
| 195 |
+
"golden_of": 140,
|
| 196 |
+
"flags": 418,
|
| 197 |
+
"read": 4617,
|
| 198 |
+
"flag_rate": 0.091,
|
| 199 |
+
"median_flags": 4,
|
| 200 |
+
"cost": 0.76
|
| 201 |
+
},
|
| 202 |
+
{
|
| 203 |
+
"config": "jev",
|
| 204 |
+
"label": "perch 0.4.7, Jev",
|
| 205 |
+
"cutoff": 0.7,
|
| 206 |
+
"prs": 50,
|
| 207 |
+
"missing": [],
|
| 208 |
+
"known": 10,
|
| 209 |
+
"known_of": 50,
|
| 210 |
+
"known_chance": 3.2,
|
| 211 |
+
"caught": 17,
|
| 212 |
+
"of": 47,
|
| 213 |
+
"chance": 6.9,
|
| 214 |
+
"golden": 40,
|
| 215 |
+
"golden_of": 140,
|
| 216 |
+
"flags": 176,
|
| 217 |
+
"read": 4617,
|
| 218 |
+
"flag_rate": 0.038,
|
| 219 |
+
"median_flags": 1,
|
| 220 |
+
"cost": 0.76
|
| 221 |
+
},
|
| 222 |
+
{
|
| 223 |
+
"config": "jev",
|
| 224 |
+
"label": "perch 0.4.7, Jev",
|
| 225 |
+
"cutoff": 0.8,
|
| 226 |
+
"prs": 50,
|
| 227 |
+
"missing": [],
|
| 228 |
+
"known": 4,
|
| 229 |
+
"known_of": 50,
|
| 230 |
+
"known_chance": 1,
|
| 231 |
+
"caught": 7,
|
| 232 |
+
"of": 47,
|
| 233 |
+
"chance": 2.7,
|
| 234 |
+
"golden": 13,
|
| 235 |
+
"golden_of": 140,
|
| 236 |
+
"flags": 50,
|
| 237 |
+
"read": 4617,
|
| 238 |
+
"flag_rate": 0.011,
|
| 239 |
+
"median_flags": 0,
|
| 240 |
+
"cost": 0.76
|
| 241 |
+
},
|
| 242 |
+
{
|
| 243 |
+
"config": "oai",
|
| 244 |
+
"label": "perch 0.4.7, OpenAI Decisions",
|
| 245 |
+
"cutoff": 0.6,
|
| 246 |
+
"prs": 50,
|
| 247 |
+
"missing": [],
|
| 248 |
+
"known": 28,
|
| 249 |
+
"known_of": 50,
|
| 250 |
+
"known_chance": 11.6,
|
| 251 |
+
"caught": 37,
|
| 252 |
+
"of": 47,
|
| 253 |
+
"chance": 22.6,
|
| 254 |
+
"golden": 92,
|
| 255 |
+
"golden_of": 140,
|
| 256 |
+
"flags": 914,
|
| 257 |
+
"read": 4617,
|
| 258 |
+
"flag_rate": 0.198,
|
| 259 |
+
"median_flags": 10,
|
| 260 |
+
"cost": 1.555
|
| 261 |
+
},
|
| 262 |
+
{
|
| 263 |
+
"config": "oai",
|
| 264 |
+
"label": "perch 0.4.7, OpenAI Decisions",
|
| 265 |
+
"cutoff": 0.7,
|
| 266 |
+
"prs": 50,
|
| 267 |
+
"missing": [],
|
| 268 |
+
"known": 24,
|
| 269 |
+
"known_of": 50,
|
| 270 |
+
"known_chance": 10,
|
| 271 |
+
"caught": 33,
|
| 272 |
+
"of": 47,
|
| 273 |
+
"chance": 19.8,
|
| 274 |
+
"golden": 81,
|
| 275 |
+
"golden_of": 140,
|
| 276 |
+
"flags": 760,
|
| 277 |
+
"read": 4617,
|
| 278 |
+
"flag_rate": 0.165,
|
| 279 |
+
"median_flags": 8,
|
| 280 |
+
"cost": 1.555
|
| 281 |
+
},
|
| 282 |
+
{
|
| 283 |
+
"config": "oai",
|
| 284 |
+
"label": "perch 0.4.7, OpenAI Decisions",
|
| 285 |
+
"cutoff": 0.8,
|
| 286 |
+
"prs": 50,
|
| 287 |
+
"missing": [],
|
| 288 |
+
"known": 20,
|
| 289 |
+
"known_of": 50,
|
| 290 |
+
"known_chance": 8,
|
| 291 |
+
"caught": 31,
|
| 292 |
+
"of": 47,
|
| 293 |
+
"chance": 16.6,
|
| 294 |
+
"golden": 68,
|
| 295 |
+
"golden_of": 140,
|
| 296 |
+
"flags": 596,
|
| 297 |
+
"read": 4617,
|
| 298 |
+
"flag_rate": 0.129,
|
| 299 |
+
"median_flags": 7,
|
| 300 |
+
"cost": 1.555
|
| 301 |
+
}
|
| 302 |
+
]
|
greptile/truth/cal.com.json
ADDED
|
@@ -0,0 +1,428 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
[
|
| 2 |
+
{
|
| 3 |
+
"pr": 2,
|
| 4 |
+
"index": 0,
|
| 5 |
+
"methods": [
|
| 6 |
+
"packages/app-store/_utils/getCalendar.ts::getCalendar"
|
| 7 |
+
],
|
| 8 |
+
"file": "packages/app-store/_utils/getCalendar.ts",
|
| 9 |
+
"line": 15,
|
| 10 |
+
"why": "The new await on the dynamic appStore import has no try/catch, so a failed import rejects instead of returning null; ambiguous because the same unguarded await of appStore[...] also appears in getVideoAdapters, handlePayment, deletePayment and confirm, and getCalendar is the most central one."
|
| 11 |
+
},
|
| 12 |
+
{
|
| 13 |
+
"pr": 2,
|
| 14 |
+
"index": 1,
|
| 15 |
+
"methods": [
|
| 16 |
+
"packages/app-store/vital/lib/reschedule.ts::Reschedule",
|
| 17 |
+
"packages/app-store/wipemycalother/lib/reschedule.ts::Reschedule",
|
| 18 |
+
"packages/trpc/server/routers/viewer/bookings.tsx::requestReschedule",
|
| 19 |
+
"packages/features/bookings/lib/handleCancelBooking.ts::handler"
|
| 20 |
+
],
|
| 21 |
+
"file": "packages/app-store/vital/lib/reschedule.ts",
|
| 22 |
+
"line": 125,
|
| 23 |
+
"why": "bookingRefsFiltered.forEach(async ...) now awaits getCalendar inside an unawaited async callback, so calendar/video deletions run fire-and-forget and the surrounding try/catch cannot see their rejections; the same pattern is in wipemycalother/lib/reschedule.ts:125, bookings.tsx:553 and handleCancelBooking.ts:460."
|
| 24 |
+
},
|
| 25 |
+
{
|
| 26 |
+
"pr": 3,
|
| 27 |
+
"index": 0,
|
| 28 |
+
"methods": [
|
| 29 |
+
"apps/web/components/auth/BackupCode.tsx::TwoFactor"
|
| 30 |
+
],
|
| 31 |
+
"file": "apps/web/components/auth/BackupCode.tsx",
|
| 32 |
+
"line": 7,
|
| 33 |
+
"why": "The backup-code component in BackupCode.tsx is exported as a function named TwoFactor, duplicating the TwoFactor component's name."
|
| 34 |
+
},
|
| 35 |
+
{
|
| 36 |
+
"pr": 3,
|
| 37 |
+
"index": 1,
|
| 38 |
+
"methods": [
|
| 39 |
+
"apps/web/pages/api/auth/two-factor/totp/disable.ts::handler"
|
| 40 |
+
],
|
| 41 |
+
"file": "apps/web/pages/api/auth/two-factor/totp/disable.ts",
|
| 42 |
+
"line": 50,
|
| 43 |
+
"why": "The disable endpoint logs 'cannot proceed with backup code login', copied from the login path."
|
| 44 |
+
},
|
| 45 |
+
{
|
| 46 |
+
"pr": 3,
|
| 47 |
+
"index": 2,
|
| 48 |
+
"methods": [
|
| 49 |
+
"packages/features/auth/lib/next-auth-options.ts::authorize",
|
| 50 |
+
"apps/web/pages/api/auth/two-factor/totp/disable.ts::handler"
|
| 51 |
+
],
|
| 52 |
+
"file": "packages/features/auth/lib/next-auth-options.ts",
|
| 53 |
+
"line": 144,
|
| 54 |
+
"why": "backupCodes.indexOf(credentials.backupCode.replaceAll('-', '')) is an exact, case-sensitive match against lowercase hex codes; the disable endpoint repeats it at disable.ts:61."
|
| 55 |
+
},
|
| 56 |
+
{
|
| 57 |
+
"pr": 3,
|
| 58 |
+
"index": 3,
|
| 59 |
+
"methods": [
|
| 60 |
+
"packages/features/auth/lib/next-auth-options.ts::authorize"
|
| 61 |
+
],
|
| 62 |
+
"file": "packages/features/auth/lib/next-auth-options.ts",
|
| 63 |
+
"line": 148,
|
| 64 |
+
"why": "The code is checked against a decrypted in-memory copy, nulled and written back with a plain update, so two concurrent logins with the same backup code can both succeed."
|
| 65 |
+
},
|
| 66 |
+
{
|
| 67 |
+
"pr": 3,
|
| 68 |
+
"index": 4,
|
| 69 |
+
"methods": [
|
| 70 |
+
"apps/web/components/settings/EnableTwoFactorModal.tsx::EnableTwoFactorModal.handleSetup",
|
| 71 |
+
"apps/web/components/settings/EnableTwoFactorModal.tsx::EnableTwoFactorModal"
|
| 72 |
+
],
|
| 73 |
+
"file": "apps/web/components/settings/EnableTwoFactorModal.tsx",
|
| 74 |
+
"line": 99,
|
| 75 |
+
"why": "URL.createObjectURL for the backup-codes download is only revoked on the next setup call; the component has no unmount cleanup that revokes backupCodesUrl."
|
| 76 |
+
},
|
| 77 |
+
{
|
| 78 |
+
"pr": 4,
|
| 79 |
+
"index": 0,
|
| 80 |
+
"methods": [
|
| 81 |
+
"packages/app-store/googlecalendar/lib/CalendarService.ts::GoogleCalendarService.createEvent",
|
| 82 |
+
"packages/app-store/googlecalendar/lib/CalendarService.ts::GoogleCalendarService.updateEvent",
|
| 83 |
+
"packages/core/EventManager.ts::EventManager.create"
|
| 84 |
+
],
|
| 85 |
+
"file": "packages/app-store/googlecalendar/lib/CalendarService.ts",
|
| 86 |
+
"line": 100,
|
| 87 |
+
"why": "mainHostDestinationCalendar is destructured from an empty/absent destinationCalendar array and is undefined (Google createEvent:100, updateEvent:198, as the comment says); there its uses are optional-chained, and the actual unguarded dereference is EventManager.create at EventManager.ts:119 (mainHostDestinationCalendar.integration)."
|
| 88 |
+
},
|
| 89 |
+
{
|
| 90 |
+
"pr": 4,
|
| 91 |
+
"index": 1,
|
| 92 |
+
"methods": [
|
| 93 |
+
"packages/emails/src/templates/BrokenIntegrationEmail.tsx::BrokenIntegrationEmail"
|
| 94 |
+
],
|
| 95 |
+
"file": "packages/emails/src/templates/BrokenIntegrationEmail.tsx",
|
| 96 |
+
"line": 90,
|
| 97 |
+
"why": "mainHostDestinationCalendar?.integration uses optional chaining inside the branch of a ternary that already checked mainHostDestinationCalendar."
|
| 98 |
+
},
|
| 99 |
+
{
|
| 100 |
+
"pr": 4,
|
| 101 |
+
"index": 2,
|
| 102 |
+
"methods": [
|
| 103 |
+
"packages/app-store/googlecalendar/lib/CalendarService.ts::GoogleCalendarService.updateEvent",
|
| 104 |
+
"packages/app-store/googlecalendar/lib/CalendarService.ts::GoogleCalendarService.deleteEvent"
|
| 105 |
+
],
|
| 106 |
+
"file": "packages/app-store/googlecalendar/lib/CalendarService.ts",
|
| 107 |
+
"line": 256,
|
| 108 |
+
"why": "In the branch where externalCalendarId is falsy, it searches destinationCalendar for externalId === externalCalendarId, which can never match; deleteEvent repeats this at line 317."
|
| 109 |
+
},
|
| 110 |
+
{
|
| 111 |
+
"pr": 4,
|
| 112 |
+
"index": 3,
|
| 113 |
+
"methods": [
|
| 114 |
+
"packages/trpc/server/routers/viewer/organizations/create.handler.ts::createHandler"
|
| 115 |
+
],
|
| 116 |
+
"file": "packages/trpc/server/routers/viewer/organizations/create.handler.ts",
|
| 117 |
+
"line": 151,
|
| 118 |
+
"why": "The slug spread changed from !IS_TEAM_BILLING_ENABLED to IS_TEAM_BILLING_ENABLED, so with billing enabled both slug and requestedSlug are set and with billing disabled neither is."
|
| 119 |
+
},
|
| 120 |
+
{
|
| 121 |
+
"pr": 4,
|
| 122 |
+
"index": 4,
|
| 123 |
+
"methods": [
|
| 124 |
+
"packages/app-store/larkcalendar/lib/CalendarService.ts::LarkCalendarService.createEvent",
|
| 125 |
+
"packages/app-store/office365calendar/lib/CalendarService.ts::Office365CalendarService.createEvent"
|
| 126 |
+
],
|
| 127 |
+
"file": "packages/app-store/larkcalendar/lib/CalendarService.ts",
|
| 128 |
+
"line": 125,
|
| 129 |
+
"why": "The Calendar interface (packages/types/Calendar.d.ts:221, a type declaration) now declares createEvent(event, credentialId), but the Lark (line 125) and Office365 (line 72) implementations still declare createEvent(event)."
|
| 130 |
+
},
|
| 131 |
+
{
|
| 132 |
+
"pr": 4,
|
| 133 |
+
"index": 5,
|
| 134 |
+
"methods": [
|
| 135 |
+
"packages/core/EventManager.ts::EventManager.updateAllCalendarEvents"
|
| 136 |
+
],
|
| 137 |
+
"file": "packages/core/EventManager.ts",
|
| 138 |
+
"line": 542,
|
| 139 |
+
"why": "When reference.credentialId is set but the credential is neither in calendarCredentials nor found in the DB, the undefined credential is still passed to updateEvent."
|
| 140 |
+
},
|
| 141 |
+
{
|
| 142 |
+
"pr": 5,
|
| 143 |
+
"index": 0,
|
| 144 |
+
"methods": [
|
| 145 |
+
"packages/lib/server/service/insightsBooking.ts::InsightsBookingService.getBaseConditions",
|
| 146 |
+
"packages/lib/server/service/insightsBooking.ts::InsightsBookingService.getAuthorizationConditions"
|
| 147 |
+
],
|
| 148 |
+
"file": "packages/lib/server/service/insightsBooking.ts",
|
| 149 |
+
"line": 76,
|
| 150 |
+
"why": "getAuthorizationConditions always returns a Prisma.Sql (NOTHING_CONDITION at worst), so authConditions is always truthy and the filter-only and NOTHING_CONDITION branches of getBaseConditions are unreachable."
|
| 151 |
+
},
|
| 152 |
+
{
|
| 153 |
+
"pr": 5,
|
| 154 |
+
"index": 1,
|
| 155 |
+
"methods": [
|
| 156 |
+
"packages/lib/server/service/insightsBooking.ts::InsightsBookingService.buildOrgAuthorizationCondition"
|
| 157 |
+
],
|
| 158 |
+
"file": "packages/lib/server/service/insightsBooking.ts",
|
| 159 |
+
"line": 158,
|
| 160 |
+
"why": "Org member user IDs are only fetched when teamsFromOrg.length > 0, so an org with no child teams loses its members' personal bookings even though teamIds includes orgId."
|
| 161 |
+
},
|
| 162 |
+
{
|
| 163 |
+
"pr": 6,
|
| 164 |
+
"index": 0,
|
| 165 |
+
"methods": [
|
| 166 |
+
"packages/features/bookings/lib/handleCancelBooking.ts::handler",
|
| 167 |
+
"packages/features/bookings/lib/handleNewBooking.ts::handler",
|
| 168 |
+
"packages/trpc/server/routers/viewer/bookings.tsx::requestReschedule",
|
| 169 |
+
"packages/trpc/server/routers/viewer/workflows.tsx::delete",
|
| 170 |
+
"packages/trpc/server/routers/viewer/workflows.tsx::update"
|
| 171 |
+
],
|
| 172 |
+
"file": "packages/features/bookings/lib/handleCancelBooking.ts",
|
| 173 |
+
"line": 488,
|
| 174 |
+
"why": "deleteScheduledEmailReminder/deleteScheduledSMSReminder are called without await inside forEach (handleCancelBooking:488, handleNewBooking:966, bookings.tsx:489, workflows.tsx:213/377/520/575), so cancellations may not complete."
|
| 175 |
+
},
|
| 176 |
+
{
|
| 177 |
+
"pr": 6,
|
| 178 |
+
"index": 1,
|
| 179 |
+
"methods": [
|
| 180 |
+
"packages/features/ee/workflows/lib/reminders/emailReminderManager.ts::deleteScheduledEmailReminder"
|
| 181 |
+
],
|
| 182 |
+
"file": "packages/features/ee/workflows/lib/reminders/emailReminderManager.ts",
|
| 183 |
+
"line": 213,
|
| 184 |
+
"why": "The immediateDelete branch cancels the SendGrid batch and returns without deleting the WorkflowReminder row or calling the scheduled_sends DELETE."
|
| 185 |
+
},
|
| 186 |
+
{
|
| 187 |
+
"pr": 6,
|
| 188 |
+
"index": 2,
|
| 189 |
+
"methods": [],
|
| 190 |
+
"file": "packages/prisma/schema.prisma",
|
| 191 |
+
"line": 644,
|
| 192 |
+
"why": "WorkflowReminder.cancelled is added as Boolean? with no default (migration adds a nullable BOOLEAN), so existing rows are null instead of false; schema/migration, not a method."
|
| 193 |
+
},
|
| 194 |
+
{
|
| 195 |
+
"pr": 7,
|
| 196 |
+
"index": 0,
|
| 197 |
+
"methods": [
|
| 198 |
+
"packages/trpc/server/routers/viewer/slots.ts::checkIfIsAvailable"
|
| 199 |
+
],
|
| 200 |
+
"file": "packages/trpc/server/routers/viewer/slots.ts",
|
| 201 |
+
"line": 142,
|
| 202 |
+
"why": "The working-hours check computes end from slotStartTime instead of slotEndTime, so slots that run past the end of working hours pass."
|
| 203 |
+
},
|
| 204 |
+
{
|
| 205 |
+
"pr": 7,
|
| 206 |
+
"index": 1,
|
| 207 |
+
"methods": [
|
| 208 |
+
"packages/trpc/server/routers/viewer/slots.ts::checkIfIsAvailable"
|
| 209 |
+
],
|
| 210 |
+
"file": "packages/trpc/server/routers/viewer/slots.ts",
|
| 211 |
+
"line": 114,
|
| 212 |
+
"why": "Two dayjs objects are compared with ===, which compares references and is always false; it should use isSame."
|
| 213 |
+
},
|
| 214 |
+
{
|
| 215 |
+
"pr": 8,
|
| 216 |
+
"index": 0,
|
| 217 |
+
"methods": [
|
| 218 |
+
"packages/app-store/_utils/oauth/parseRefreshTokenResponse.ts::parseRefreshTokenResponse"
|
| 219 |
+
],
|
| 220 |
+
"file": "packages/app-store/_utils/oauth/parseRefreshTokenResponse.ts",
|
| 221 |
+
"line": 26,
|
| 222 |
+
"why": "A missing refresh_token is replaced with the literal string 'refresh_token', which is then persisted and breaks later refreshes."
|
| 223 |
+
},
|
| 224 |
+
{
|
| 225 |
+
"pr": 8,
|
| 226 |
+
"index": 1,
|
| 227 |
+
"methods": [
|
| 228 |
+
"packages/app-store/_utils/oauth/parseRefreshTokenResponse.ts::<top-level>"
|
| 229 |
+
],
|
| 230 |
+
"file": "packages/app-store/_utils/oauth/parseRefreshTokenResponse.ts",
|
| 231 |
+
"line": 8,
|
| 232 |
+
"why": "minimumTokenResponseSchema uses computed keys [z.string().toString()] and [z.string().optional().toString()], which become literal '[object Object]'-style keys, not wildcards; module-level const (used by parseRefreshTokenResponse at line 16), not inside a listed method. (mapped to the file's <top-level> unit, which perch reads)"
|
| 233 |
+
},
|
| 234 |
+
{
|
| 235 |
+
"pr": 8,
|
| 236 |
+
"index": 2,
|
| 237 |
+
"methods": [
|
| 238 |
+
"packages/app-store/googlecalendar/lib/CalendarService.ts::GoogleCalendarService.<anonymous>.refreshAccessToken",
|
| 239 |
+
"packages/app-store/_utils/oauth/parseRefreshTokenResponse.ts::parseRefreshTokenResponse"
|
| 240 |
+
],
|
| 241 |
+
"file": "packages/app-store/googlecalendar/lib/CalendarService.ts",
|
| 242 |
+
"line": 97,
|
| 243 |
+
"why": "key = parseRefreshTokenResponse(...) is the safeParse wrapper ({success, data}) and is persisted as the credential key instead of .data."
|
| 244 |
+
},
|
| 245 |
+
{
|
| 246 |
+
"pr": 8,
|
| 247 |
+
"index": 3,
|
| 248 |
+
"methods": [
|
| 249 |
+
"packages/app-store/_utils/oauth/refreshOAuthTokens.ts::refreshOAuthTokens",
|
| 250 |
+
"packages/app-store/googlecalendar/lib/CalendarService.ts::GoogleCalendarService.<anonymous>.refreshAccessToken",
|
| 251 |
+
"packages/app-store/hubspot/lib/CalendarService.ts::HubspotCalendarService.<anonymous>.refreshAccessToken"
|
| 252 |
+
],
|
| 253 |
+
"file": "packages/app-store/_utils/oauth/refreshOAuthTokens.ts",
|
| 254 |
+
"line": 15,
|
| 255 |
+
"why": "In the sync-endpoint branch refreshOAuthTokens returns the raw fetch Response, while callers such as Google (res.data) and Hubspot (HubspotToken) expect the integration's token object."
|
| 256 |
+
},
|
| 257 |
+
{
|
| 258 |
+
"pr": 8,
|
| 259 |
+
"index": 4,
|
| 260 |
+
"methods": [
|
| 261 |
+
"packages/app-store/googlecalendar/lib/CalendarService.ts::GoogleCalendarService.<anonymous>.refreshAccessToken",
|
| 262 |
+
"packages/app-store/_utils/oauth/refreshOAuthTokens.ts::refreshOAuthTokens"
|
| 263 |
+
],
|
| 264 |
+
"file": "packages/app-store/googlecalendar/lib/CalendarService.ts",
|
| 265 |
+
"line": 94,
|
| 266 |
+
"why": "On the sync path res is a fetch Response, so res?.data is undefined and token.access_token on line 95 throws."
|
| 267 |
+
},
|
| 268 |
+
{
|
| 269 |
+
"pr": 8,
|
| 270 |
+
"index": 5,
|
| 271 |
+
"methods": [
|
| 272 |
+
"packages/app-store/zoho-bigin/lib/CalendarService.ts::BiginCalendarService.refreshAccessToken"
|
| 273 |
+
],
|
| 274 |
+
"file": "packages/app-store/zoho-bigin/lib/CalendarService.ts",
|
| 275 |
+
"line": 93,
|
| 276 |
+
"why": "refreshOAuthTokens is passed credentialId where it expects the userId, so the sync endpoint receives the wrong calcomUserId."
|
| 277 |
+
},
|
| 278 |
+
{
|
| 279 |
+
"pr": 8,
|
| 280 |
+
"index": 6,
|
| 281 |
+
"methods": [
|
| 282 |
+
"packages/app-store/salesforce/lib/CalendarService.ts::<top-level>"
|
| 283 |
+
],
|
| 284 |
+
"file": "packages/app-store/salesforce/lib/CalendarService.ts",
|
| 285 |
+
"line": 86,
|
| 286 |
+
"why": "The Salesforce token refresh checks response.statusText !== 'OK' instead of response.ok; this is in the getClient class-property arrow function, which methods_read does not list. (mapped to the file's <top-level> unit, which perch reads)"
|
| 287 |
+
},
|
| 288 |
+
{
|
| 289 |
+
"pr": 8,
|
| 290 |
+
"index": 7,
|
| 291 |
+
"methods": [
|
| 292 |
+
"packages/app-store/salesforce/lib/CalendarService.ts::<top-level>"
|
| 293 |
+
],
|
| 294 |
+
"file": "packages/app-store/salesforce/lib/CalendarService.ts",
|
| 295 |
+
"line": 106,
|
| 296 |
+
"why": "After refreshing and saving new tokens, jsforce.Connection is still built from the stale credentialKey.access_token/instance_url (lines 105-106); this is in getClient, which methods_read does not list. (mapped to the file's <top-level> unit, which perch reads)"
|
| 297 |
+
},
|
| 298 |
+
{
|
| 299 |
+
"pr": 8,
|
| 300 |
+
"index": 8,
|
| 301 |
+
"methods": [
|
| 302 |
+
"apps/web/pages/api/webhook/app-credential.ts::handler"
|
| 303 |
+
],
|
| 304 |
+
"file": "apps/web/pages/api/webhook/app-credential.ts",
|
| 305 |
+
"line": 31,
|
| 306 |
+
"why": "appCredentialWebhookRequestBodySchema.parse throws on an invalid body, producing a 500 instead of a 400."
|
| 307 |
+
},
|
| 308 |
+
{
|
| 309 |
+
"pr": 9,
|
| 310 |
+
"index": 0,
|
| 311 |
+
"methods": [
|
| 312 |
+
"packages/features/ee/workflows/api/scheduleSMSReminders.ts::handler"
|
| 313 |
+
],
|
| 314 |
+
"file": "packages/features/ee/workflows/api/scheduleSMSReminders.ts",
|
| 315 |
+
"line": 184,
|
| 316 |
+
"why": "retryCount: reminder.retryCount + 1 writes a value read earlier instead of an atomic increment; the catch block repeats it at line 195."
|
| 317 |
+
},
|
| 318 |
+
{
|
| 319 |
+
"pr": 9,
|
| 320 |
+
"index": 1,
|
| 321 |
+
"methods": [
|
| 322 |
+
"packages/features/ee/workflows/api/scheduleSMSReminders.ts::handler"
|
| 323 |
+
],
|
| 324 |
+
"file": "packages/features/ee/workflows/api/scheduleSMSReminders.ts",
|
| 325 |
+
"line": 38,
|
| 326 |
+
"why": "The OR branch { retryCount: { gt: 1 } } has no method: SMS filter, so deleteMany removes email/WhatsApp reminders with retryCount > 1."
|
| 327 |
+
},
|
| 328 |
+
{
|
| 329 |
+
"pr": 10,
|
| 330 |
+
"index": 0,
|
| 331 |
+
"methods": [
|
| 332 |
+
"packages/trpc/server/routers/viewer/bookings/addGuests.handler.ts::addGuestsHandler"
|
| 333 |
+
],
|
| 334 |
+
"file": "packages/trpc/server/routers/viewer/bookings/addGuests.handler.ts",
|
| 335 |
+
"line": 77,
|
| 336 |
+
"why": "The blacklist is lowercased but guest emails are not, so blacklistedGuestEmails.includes(guest) is bypassed by uppercase input."
|
| 337 |
+
},
|
| 338 |
+
{
|
| 339 |
+
"pr": 10,
|
| 340 |
+
"index": 1,
|
| 341 |
+
"methods": [
|
| 342 |
+
"packages/trpc/server/routers/viewer/bookings/addGuests.handler.ts::addGuestsHandler"
|
| 343 |
+
],
|
| 344 |
+
"file": "packages/trpc/server/routers/viewer/bookings/addGuests.handler.ts",
|
| 345 |
+
"line": 47,
|
| 346 |
+
"why": "isTeamAdminOrOwner requires isTeamAdmin && isTeamOwner; it should be ||."
|
| 347 |
+
},
|
| 348 |
+
{
|
| 349 |
+
"pr": 10,
|
| 350 |
+
"index": 2,
|
| 351 |
+
"methods": [
|
| 352 |
+
"packages/emails/email-manager.ts::sendAddGuestsEmails",
|
| 353 |
+
"packages/trpc/server/routers/viewer/bookings/addGuests.handler.ts::addGuestsHandler"
|
| 354 |
+
],
|
| 355 |
+
"file": "packages/emails/email-manager.ts",
|
| 356 |
+
"line": 541,
|
| 357 |
+
"why": "sendAddGuestsEmails decides which attendees are new with newGuests.includes(attendee.email), but the handler passes the raw input guests (addGuests.handler.ts:168), not the filtered uniqueGuests."
|
| 358 |
+
},
|
| 359 |
+
{
|
| 360 |
+
"pr": 10,
|
| 361 |
+
"index": 3,
|
| 362 |
+
"methods": [
|
| 363 |
+
"packages/trpc/server/routers/viewer/bookings/addGuests.handler.ts::addGuestsHandler"
|
| 364 |
+
],
|
| 365 |
+
"file": "packages/trpc/server/routers/viewer/bookings/addGuests.handler.ts",
|
| 366 |
+
"line": 74,
|
| 367 |
+
"why": "uniqueGuests removes existing attendees and blacklisted emails but not duplicates within the input, so createMany can insert duplicate attendees."
|
| 368 |
+
},
|
| 369 |
+
{
|
| 370 |
+
"pr": 10,
|
| 371 |
+
"index": 4,
|
| 372 |
+
"methods": [
|
| 373 |
+
"apps/web/components/dialog/AddGuestsDialog.tsx::AddGuestsDialog"
|
| 374 |
+
],
|
| 375 |
+
"file": "apps/web/components/dialog/AddGuestsDialog.tsx",
|
| 376 |
+
"line": 32,
|
| 377 |
+
"why": "multiEmailValue starts as [\"\"] (and is reset to it), so an empty string is submitted and fails email validation."
|
| 378 |
+
},
|
| 379 |
+
{
|
| 380 |
+
"pr": 10,
|
| 381 |
+
"index": 5,
|
| 382 |
+
"methods": [
|
| 383 |
+
"packages/emails/email-manager.ts::sendAddGuestsEmails"
|
| 384 |
+
],
|
| 385 |
+
"file": "packages/emails/email-manager.ts",
|
| 386 |
+
"line": 529,
|
| 387 |
+
"why": "sendAddGuestsEmails sends organizer, team and attendee emails without checking the event type's disableStandardEmails metadata."
|
| 388 |
+
},
|
| 389 |
+
{
|
| 390 |
+
"pr": 11,
|
| 391 |
+
"index": 0,
|
| 392 |
+
"methods": [
|
| 393 |
+
"packages/app-store/googlecalendar/lib/CalendarService.ts::GoogleCalendarService.fetchAvailabilityAndSetCache",
|
| 394 |
+
"packages/lib/server/repository/selectedCalendar.ts::SelectedCalendarRepository.updateManyByCredentialId"
|
| 395 |
+
],
|
| 396 |
+
"file": "packages/app-store/googlecalendar/lib/CalendarService.ts",
|
| 397 |
+
"line": 1024,
|
| 398 |
+
"why": "updateManyByCredentialId(this.credential.id, {}) passes empty data, so updatedAt is not reliably bumped and the cache status timestamp is stale."
|
| 399 |
+
},
|
| 400 |
+
{
|
| 401 |
+
"pr": 11,
|
| 402 |
+
"index": 1,
|
| 403 |
+
"methods": [],
|
| 404 |
+
"file": "scripts/test-gcal-webhooks.sh",
|
| 405 |
+
"line": 68,
|
| 406 |
+
"why": "sed -i '' is BSD/macOS syntax and fails with GNU sed on Linux; shell script, not a method."
|
| 407 |
+
},
|
| 408 |
+
{
|
| 409 |
+
"pr": 11,
|
| 410 |
+
"index": 2,
|
| 411 |
+
"methods": [
|
| 412 |
+
"packages/trpc/server/routers/viewer/calendars/deleteCache.handler.ts::deleteCacheHandler"
|
| 413 |
+
],
|
| 414 |
+
"file": "packages/trpc/server/routers/viewer/calendars/deleteCache.handler.ts",
|
| 415 |
+
"line": 25,
|
| 416 |
+
"why": "A plain Error is thrown for a missing or unauthorized credential, which tRPC returns as a 500 instead of a TRPCError FORBIDDEN/NOT_FOUND."
|
| 417 |
+
},
|
| 418 |
+
{
|
| 419 |
+
"pr": 11,
|
| 420 |
+
"index": 3,
|
| 421 |
+
"methods": [
|
| 422 |
+
"packages/features/apps/components/CredentialActionsDropdown.tsx::CredentialActionsDropdown"
|
| 423 |
+
],
|
| 424 |
+
"file": "packages/features/apps/components/CredentialActionsDropdown.tsx",
|
| 425 |
+
"line": 89,
|
| 426 |
+
"why": "The cache timestamp is formatted with a hardcoded 'en-US' Intl.DateTimeFormat instead of the user's locale."
|
| 427 |
+
}
|
| 428 |
+
]
|
greptile/truth/discourse.json
ADDED
|
@@ -0,0 +1,390 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
[
|
| 2 |
+
{
|
| 3 |
+
"pr": 1,
|
| 4 |
+
"index": 0,
|
| 5 |
+
"methods": [
|
| 6 |
+
"app/models/optimized_image.rb::OptimizedImage.downsize#2",
|
| 7 |
+
"app/models/optimized_image.rb::OptimizedImage.downsize"
|
| 8 |
+
],
|
| 9 |
+
"file": "app/models/optimized_image.rb",
|
| 10 |
+
"line": 149,
|
| 11 |
+
"why": "A second self.downsize(from, to, dimensions, opts) is defined right after the four-argument one at line 145, so Ruby keeps only the three-argument version and any caller passing max_width and max_height separately gets the wrong arguments."
|
| 12 |
+
},
|
| 13 |
+
{
|
| 14 |
+
"pr": 1,
|
| 15 |
+
"index": 1,
|
| 16 |
+
"methods": [
|
| 17 |
+
"app/assets/javascripts/discourse/lib/utilities.js::Discourse.Utilities.validateUploadedFile",
|
| 18 |
+
"app/assets/javascripts/discourse/lib/utilities.js::Discourse.Utilities.displayErrorForUpload"
|
| 19 |
+
],
|
| 20 |
+
"file": "app/assets/javascripts/discourse/lib/utilities.js",
|
| 21 |
+
"line": 182,
|
| 22 |
+
"why": "validateUploadedFile hardcodes maxSizeKB = 10 * 1024 instead of reading Discourse.SiteSettings['max_' + type + '_size_kb']; the 413 branch of displayErrorForUpload (line 246) does the same."
|
| 23 |
+
},
|
| 24 |
+
{
|
| 25 |
+
"pr": 1,
|
| 26 |
+
"index": 2,
|
| 27 |
+
"methods": [
|
| 28 |
+
"app/controllers/uploads_controller.rb::UploadsController.create_upload",
|
| 29 |
+
"app/models/optimized_image.rb::OptimizedImage.resize_instructions_animated"
|
| 30 |
+
],
|
| 31 |
+
"file": "app/controllers/uploads_controller.rb",
|
| 32 |
+
"line": 67,
|
| 33 |
+
"why": "create_upload passes \"80%\" as the dimensions with allow_animation set; for GIFs downsize_instructions_animated delegates to resize_instructions_animated, whose gifsicle --resize-fit (line 120) expects WxH, so the downsize fails silently."
|
| 34 |
+
},
|
| 35 |
+
{
|
| 36 |
+
"pr": 1,
|
| 37 |
+
"index": 3,
|
| 38 |
+
"methods": [
|
| 39 |
+
"app/controllers/uploads_controller.rb::UploadsController.create_upload"
|
| 40 |
+
],
|
| 41 |
+
"file": "app/controllers/uploads_controller.rb",
|
| 42 |
+
"line": 66,
|
| 43 |
+
"why": "The while loop tests tempfile.size after convert has rewritten the file at tempfile.path, so the size read through the open Tempfile can be stale and the loop does not reliably see the shrink."
|
| 44 |
+
},
|
| 45 |
+
{
|
| 46 |
+
"pr": 2,
|
| 47 |
+
"index": 0,
|
| 48 |
+
"methods": [
|
| 49 |
+
"app/controllers/topics_controller.rb::TopicsController.unsubscribe"
|
| 50 |
+
],
|
| 51 |
+
"file": "app/controllers/topics_controller.rb",
|
| 52 |
+
"line": 107,
|
| 53 |
+
"why": "TopicUser.find_by on line 105 returns nil when the user has no TopicUser row for the topic, and line 107 calls tu.notification_level on it."
|
| 54 |
+
},
|
| 55 |
+
{
|
| 56 |
+
"pr": 2,
|
| 57 |
+
"index": 1,
|
| 58 |
+
"methods": [],
|
| 59 |
+
"file": "app/assets/javascripts/discourse/controllers/topic-unsubscribe.js.es6",
|
| 60 |
+
"line": 5,
|
| 61 |
+
"why": "The computed property is spelled stopNotificiationsText (also used that way in templates/topic/unsubscribe.hbs line 3); it is in an ES6 controller that methods_read does not list, and the misspelling is consistent so it is cosmetic."
|
| 62 |
+
},
|
| 63 |
+
{
|
| 64 |
+
"pr": 3,
|
| 65 |
+
"index": 0,
|
| 66 |
+
"methods": [
|
| 67 |
+
"app/models/blocked_email.rb::BlockedEmail.should_block?"
|
| 68 |
+
],
|
| 69 |
+
"file": "app/models/blocked_email.rb",
|
| 70 |
+
"line": 14,
|
| 71 |
+
"why": "should_block? increments match_count, sets last_match_at and saves the record (lines 14-16) every time it is asked, so a validation check writes to the database with a non-atomic read-modify-write."
|
| 72 |
+
},
|
| 73 |
+
{
|
| 74 |
+
"pr": 3,
|
| 75 |
+
"index": 1,
|
| 76 |
+
"methods": [
|
| 77 |
+
"lib/validators/email_validator.rb::EmailValidator.email_in_restriction_setting?"
|
| 78 |
+
],
|
| 79 |
+
"file": "lib/validators/email_validator.rb",
|
| 80 |
+
"line": 20,
|
| 81 |
+
"why": "Regexp.new(\"@(#{domains})\", true) has no end anchor or boundary, so the whitelist/blacklist match accepts addresses whose domain only contains the listed domain rather than equalling it."
|
| 82 |
+
},
|
| 83 |
+
{
|
| 84 |
+
"pr": 3,
|
| 85 |
+
"index": 2,
|
| 86 |
+
"methods": [
|
| 87 |
+
"app/models/blocked_email.rb::BlockedEmail.should_block?"
|
| 88 |
+
],
|
| 89 |
+
"file": "app/models/blocked_email.rb",
|
| 90 |
+
"line": 12,
|
| 91 |
+
"why": "BlockedEmail.where(email: email) compares case-sensitively, so a differently-cased address bypasses a block."
|
| 92 |
+
},
|
| 93 |
+
{
|
| 94 |
+
"pr": 4,
|
| 95 |
+
"index": 0,
|
| 96 |
+
"methods": [
|
| 97 |
+
"app/jobs/scheduled/poll_feed.rb::Jobs.PollFeed.poll_feed"
|
| 98 |
+
],
|
| 99 |
+
"file": "app/jobs/scheduled/poll_feed.rb",
|
| 100 |
+
"line": 29,
|
| 101 |
+
"why": "poll_feed calls Kernel#open on SiteSetting.feed_polling_url with no scheme or host validation, so the server fetches (or open-uri pipes) whatever URL the setting holds."
|
| 102 |
+
},
|
| 103 |
+
{
|
| 104 |
+
"pr": 4,
|
| 105 |
+
"index": 1,
|
| 106 |
+
"methods": [
|
| 107 |
+
"app/assets/javascripts/embed.js::<anonymous>.postMessageReceived"
|
| 108 |
+
],
|
| 109 |
+
"file": "app/assets/javascripts/embed.js",
|
| 110 |
+
"line": 17,
|
| 111 |
+
"why": "discourseUrl.indexOf(e.origin) is a substring test, not an exact origin comparison, so other origins that appear inside discourseUrl pass the check."
|
| 112 |
+
},
|
| 113 |
+
{
|
| 114 |
+
"pr": 4,
|
| 115 |
+
"index": 2,
|
| 116 |
+
"methods": [],
|
| 117 |
+
"file": "app/views/layouts/embed.html.erb",
|
| 118 |
+
"line": 11,
|
| 119 |
+
"why": "In the layout template (no method), postMessage uses the full request.referer URL as targetOrigin instead of the referer's scheme+host+port."
|
| 120 |
+
},
|
| 121 |
+
{
|
| 122 |
+
"pr": 4,
|
| 123 |
+
"index": 3,
|
| 124 |
+
"methods": [
|
| 125 |
+
"app/controllers/embed_controller.rb::EmbedController.ensure_embeddable"
|
| 126 |
+
],
|
| 127 |
+
"file": "app/controllers/embed_controller.rb",
|
| 128 |
+
"line": 28,
|
| 129 |
+
"why": "ensure_embeddable sets X-Frame-Options to ALLOWALL after only a Referer host check (line 26), which also maps a missing referer to ''."
|
| 130 |
+
},
|
| 131 |
+
{
|
| 132 |
+
"pr": 4,
|
| 133 |
+
"index": 4,
|
| 134 |
+
"methods": [
|
| 135 |
+
"app/models/topic_embed.rb::TopicEmbed.import"
|
| 136 |
+
],
|
| 137 |
+
"file": "app/models/topic_embed.rb",
|
| 138 |
+
"line": 13,
|
| 139 |
+
"why": "import appends to contents with << (NoMethodError when contents is nil, and it mutates the caller's string) and interpolates url unescaped into the <a href> HTML."
|
| 140 |
+
},
|
| 141 |
+
{
|
| 142 |
+
"pr": 4,
|
| 143 |
+
"index": 5,
|
| 144 |
+
"methods": [],
|
| 145 |
+
"file": "app/views/embed/best.html.erb",
|
| 146 |
+
"line": 6,
|
| 147 |
+
"why": "The ERB template closes the if/else with '<%- end if %>' instead of '<%- end %>'; it is in a view template, not a method."
|
| 148 |
+
},
|
| 149 |
+
{
|
| 150 |
+
"pr": 4,
|
| 151 |
+
"index": 6,
|
| 152 |
+
"methods": [
|
| 153 |
+
"app/jobs/scheduled/poll_feed.rb::Jobs.PollFeed.poll_feed"
|
| 154 |
+
],
|
| 155 |
+
"file": "app/jobs/scheduled/poll_feed.rb",
|
| 156 |
+
"line": 35,
|
| 157 |
+
"why": "i.content.scrub raises NoMethodError for feed items that have no content element; there is no fallback to i.description."
|
| 158 |
+
},
|
| 159 |
+
{
|
| 160 |
+
"pr": 4,
|
| 161 |
+
"index": 7,
|
| 162 |
+
"methods": [],
|
| 163 |
+
"file": "app/views/layouts/embed.html.erb",
|
| 164 |
+
"line": 11,
|
| 165 |
+
"why": "In the layout template (no method), request.referer is interpolated into a JavaScript string literal with only HTML escaping, not JavaScript escaping."
|
| 166 |
+
},
|
| 167 |
+
{
|
| 168 |
+
"pr": 5,
|
| 169 |
+
"index": 0,
|
| 170 |
+
"methods": [],
|
| 171 |
+
"file": "app/assets/stylesheets/common/base/topic.scss",
|
| 172 |
+
"line": 34,
|
| 173 |
+
"why": "SCSS, no methods: .extra-info-wrapper becomes a flex item (order(2)) but its .badge-wrapper keeps float: left; the PR also drops float: right from .d-header .panel (header.scss lines 35-39), relying on margin-left: auto, which only works when .panel is a flex item."
|
| 174 |
+
},
|
| 175 |
+
{
|
| 176 |
+
"pr": 5,
|
| 177 |
+
"index": 1,
|
| 178 |
+
"methods": [],
|
| 179 |
+
"file": "app/assets/stylesheets/common/foundation/mixins.scss",
|
| 180 |
+
"line": 121,
|
| 181 |
+
"why": "SCSS, no methods: the align-items mixin emits -ms-align-items, which is not a real property; -ms-flex-align (line 120) is the IE one."
|
| 182 |
+
},
|
| 183 |
+
{
|
| 184 |
+
"pr": 5,
|
| 185 |
+
"index": 2,
|
| 186 |
+
"methods": [],
|
| 187 |
+
"file": "app/assets/stylesheets/common/foundation/mixins.scss",
|
| 188 |
+
"line": 126,
|
| 189 |
+
"why": "SCSS, no methods: the order mixin passes $val straight to -webkit-box-ordinal-group and -moz-box-ordinal-group (lines 126-127), which start at 1, so they do not get the same ordering as order: $val."
|
| 190 |
+
},
|
| 191 |
+
{
|
| 192 |
+
"pr": 6,
|
| 193 |
+
"index": 0,
|
| 194 |
+
"methods": [
|
| 195 |
+
"app/serializers/user_serializer.rb::UserSerializer.include_website_name",
|
| 196 |
+
"app/serializers/user_serializer.rb::UserSerializer.website_name"
|
| 197 |
+
],
|
| 198 |
+
"file": "app/serializers/user_serializer.rb",
|
| 199 |
+
"line": 153,
|
| 200 |
+
"why": "The conditional is named include_website_name without the trailing ?, so ActiveModel::Serializers never treats it as the include check; website_name also builds \".\" << website_host (line 149), mutating a string literal."
|
| 201 |
+
},
|
| 202 |
+
{
|
| 203 |
+
"pr": 7,
|
| 204 |
+
"index": 0,
|
| 205 |
+
"methods": [],
|
| 206 |
+
"file": "app/assets/stylesheets/desktop/topic-post.scss",
|
| 207 |
+
"line": 291,
|
| 208 |
+
"why": "SCSS, no methods: .topic-meta-data h5 a went from scale-color($primary, 30%) to dark-light-choose(scale-color($primary, 70%), ...), so the light-theme value is inverted rather than kept."
|
| 209 |
+
},
|
| 210 |
+
{
|
| 211 |
+
"pr": 7,
|
| 212 |
+
"index": 1,
|
| 213 |
+
"methods": [],
|
| 214 |
+
"file": "app/assets/stylesheets/desktop/user.scss",
|
| 215 |
+
"line": 522,
|
| 216 |
+
"why": "SCSS, no methods: .group-member-info .name changes the light-theme $primary lightness from 30% to 50% instead of keeping 30% (same change in mobile/user.scss line 497)."
|
| 217 |
+
},
|
| 218 |
+
{
|
| 219 |
+
"pr": 7,
|
| 220 |
+
"index": 2,
|
| 221 |
+
"methods": [],
|
| 222 |
+
"file": "app/assets/stylesheets/desktop/topic-post.scss",
|
| 223 |
+
"line": 291,
|
| 224 |
+
"why": "SCSS, no methods. Ambiguous: no topic-post file has a light-theme 70% -> 30% change; the only topic-post line where a 30/70 pair was swapped is desktop/topic-post.scss 291 (30% -> 70%). The only literal 70% -> 30% change is mobile/modal.scss line 102 (.custom-message-length)."
|
| 225 |
+
},
|
| 226 |
+
{
|
| 227 |
+
"pr": 7,
|
| 228 |
+
"index": 3,
|
| 229 |
+
"methods": [],
|
| 230 |
+
"file": "app/assets/stylesheets/desktop/topic-post.scss",
|
| 231 |
+
"line": 291,
|
| 232 |
+
"why": "SCSS, no methods: same line as golden 0; the light-theme lightness for .topic-meta-data h5 a moved from 30% to 70%, which lowers contrast."
|
| 233 |
+
},
|
| 234 |
+
{
|
| 235 |
+
"pr": 7,
|
| 236 |
+
"index": 4,
|
| 237 |
+
"methods": [],
|
| 238 |
+
"file": "app/assets/stylesheets/mobile/user.scss",
|
| 239 |
+
"line": 497,
|
| 240 |
+
"why": "SCSS, no methods: .group-member-info .name became dark-light-choose(50%, 50%) instead of keeping $primary 30% with the $secondary 70% complement."
|
| 241 |
+
},
|
| 242 |
+
{
|
| 243 |
+
"pr": 8,
|
| 244 |
+
"index": 0,
|
| 245 |
+
"methods": [
|
| 246 |
+
"app/assets/javascripts/admin/routes/admin_group_route.js::setupController"
|
| 247 |
+
],
|
| 248 |
+
"file": "app/assets/javascripts/admin/routes/admin_group_route.js",
|
| 249 |
+
"line": 13,
|
| 250 |
+
"why": "afterModel was removed and setupController now calls model.findMembers() without returning or waiting for its promise, so the page renders before members load (same in routes/group-members.js.es6 line 11, which methods_read does not list)."
|
| 251 |
+
},
|
| 252 |
+
{
|
| 253 |
+
"pr": 8,
|
| 254 |
+
"index": 1,
|
| 255 |
+
"methods": [],
|
| 256 |
+
"file": "app/assets/javascripts/admin/controllers/admin-group.js.es6",
|
| 257 |
+
"line": 33,
|
| 258 |
+
"why": "The next action caps offset at user_count with Math.min, so offset can equal the total and the page fetched is empty; it is in the ES6 admin-group controller, which methods_read does not list."
|
| 259 |
+
},
|
| 260 |
+
{
|
| 261 |
+
"pr": 8,
|
| 262 |
+
"index": 2,
|
| 263 |
+
"methods": [],
|
| 264 |
+
"file": "spec/controllers/admin/groups_controller_spec.rb",
|
| 265 |
+
"line": 115,
|
| 266 |
+
"why": "The spec calls xhr :put, :remove_member although the route is delete \"members\"; spec code, not in methods_read."
|
| 267 |
+
},
|
| 268 |
+
{
|
| 269 |
+
"pr": 8,
|
| 270 |
+
"index": 3,
|
| 271 |
+
"methods": [],
|
| 272 |
+
"file": "app/assets/javascripts/admin/controllers/admin-group.js.es6",
|
| 273 |
+
"line": 13,
|
| 274 |
+
"why": "totalPages is Math.floor(user_count / limit) + 1, which adds a page when user_count is an exact multiple of limit; it is in the ES6 admin-group controller, which methods_read does not list."
|
| 275 |
+
},
|
| 276 |
+
{
|
| 277 |
+
"pr": 8,
|
| 278 |
+
"index": 4,
|
| 279 |
+
"methods": [
|
| 280 |
+
"app/assets/javascripts/discourse/models/group.js::<top-level>"
|
| 281 |
+
],
|
| 282 |
+
"file": "app/assets/javascripts/discourse/models/group.js",
|
| 283 |
+
"line": 17,
|
| 284 |
+
"why": "userCountDisplay (in the Discourse.Group extend body that the <top-level> entry covers) returns c only when c > 0 and falls off the end otherwise. Ambiguous: findMembers line 21 now does a bare 'return ;' where it used to return a resolved promise."
|
| 285 |
+
},
|
| 286 |
+
{
|
| 287 |
+
"pr": 8,
|
| 288 |
+
"index": 5,
|
| 289 |
+
"methods": [
|
| 290 |
+
"app/controllers/admin/groups_controller.rb::Admin::GroupsController.add_members",
|
| 291 |
+
"app/controllers/admin/groups_controller.rb::Admin::GroupsController.remove_member"
|
| 292 |
+
],
|
| 293 |
+
"file": "app/controllers/admin/groups_controller.rb",
|
| 294 |
+
"line": 66,
|
| 295 |
+
"why": "add_members (line 66) and remove_member (line 85) read params.require(:group_id); the comment says the route supplies :id. Rails routes declared inside a resources block normally pass :group_id, so the claim is doubtful, but these are the lines it refers to."
|
| 296 |
+
},
|
| 297 |
+
{
|
| 298 |
+
"pr": 9,
|
| 299 |
+
"index": 0,
|
| 300 |
+
"methods": [
|
| 301 |
+
"lib/freedom_patches/translate_accelerator.rb::I18n.ensure_loaded!"
|
| 302 |
+
],
|
| 303 |
+
"file": "lib/freedom_patches/translate_accelerator.rb",
|
| 304 |
+
"line": 63,
|
| 305 |
+
"why": "ensure_loaded! lazily initializes @loaded_locales with ||= and reads it outside LOAD_MUTEX, with no synchronization between threads."
|
| 306 |
+
},
|
| 307 |
+
{
|
| 308 |
+
"pr": 9,
|
| 309 |
+
"index": 1,
|
| 310 |
+
"methods": [
|
| 311 |
+
"lib/freedom_patches/translate_accelerator.rb::I18n.ensure_loaded!",
|
| 312 |
+
"config/initializers/i18n.rb::FallbackLocaleList.[]"
|
| 313 |
+
],
|
| 314 |
+
"file": "lib/freedom_patches/translate_accelerator.rb",
|
| 315 |
+
"line": 64,
|
| 316 |
+
"why": "ensure_loaded! checks @loaded_locales.include?(locale) without normalizing to a symbol, so 'en' and :en load twice; FallbackLocaleList#[] (i18n.rb line 17) mixes the raw locale with symbols, so uniq does not dedupe them."
|
| 317 |
+
},
|
| 318 |
+
{
|
| 319 |
+
"pr": 10,
|
| 320 |
+
"index": 0,
|
| 321 |
+
"methods": [
|
| 322 |
+
"app/models/embeddable_host.rb::<top-level>"
|
| 323 |
+
],
|
| 324 |
+
"file": "app/models/embeddable_host.rb",
|
| 325 |
+
"line": 6,
|
| 326 |
+
"why": "The class-level before_validation block calls self.host.sub! without a nil guard, so NoMethodError is raised when host is nil."
|
| 327 |
+
},
|
| 328 |
+
{
|
| 329 |
+
"pr": 10,
|
| 330 |
+
"index": 1,
|
| 331 |
+
"methods": [
|
| 332 |
+
"app/controllers/admin/embeddable_hosts_controller.rb::Admin::EmbeddableHostsController.update",
|
| 333 |
+
"app/controllers/admin/embeddable_hosts_controller.rb::Admin::EmbeddableHostsController.destroy"
|
| 334 |
+
],
|
| 335 |
+
"file": "app/controllers/admin/embeddable_hosts_controller.rb",
|
| 336 |
+
"line": 10,
|
| 337 |
+
"why": "update (line 10) and destroy (line 15) use EmbeddableHost.where(id:).first and then call save_host or host.destroy on a possibly nil record."
|
| 338 |
+
},
|
| 339 |
+
{
|
| 340 |
+
"pr": 10,
|
| 341 |
+
"index": 2,
|
| 342 |
+
"methods": [
|
| 343 |
+
"app/models/embeddable_host.rb::EmbeddableHost.record_for_host"
|
| 344 |
+
],
|
| 345 |
+
"file": "app/models/embeddable_host.rb",
|
| 346 |
+
"line": 17,
|
| 347 |
+
"why": "record_for_host compares lower(host) = ? with uri.host as given, without downcasing, so mixed-case referer hosts do not match."
|
| 348 |
+
},
|
| 349 |
+
{
|
| 350 |
+
"pr": 10,
|
| 351 |
+
"index": 3,
|
| 352 |
+
"methods": [
|
| 353 |
+
"db/migrate/20150818190757_create_embeddable_hosts.rb::CreateEmbeddableHosts.change"
|
| 354 |
+
],
|
| 355 |
+
"file": "db/migrate/20150818190757_create_embeddable_hosts.rb",
|
| 356 |
+
"line": 25,
|
| 357 |
+
"why": "The migration inserts each old embeddable_hosts value with raw SQL, skipping the model's scheme/path stripping, so migrated hosts with http:// or a path never match record_for_host."
|
| 358 |
+
},
|
| 359 |
+
{
|
| 360 |
+
"pr": 10,
|
| 361 |
+
"index": 4,
|
| 362 |
+
"methods": [
|
| 363 |
+
"spec/fabricators/category_fabricator.rb::<top-level>",
|
| 364 |
+
"spec/fabricators/embeddable_host_fabricator.rb::<top-level>"
|
| 365 |
+
],
|
| 366 |
+
"file": "spec/fabricators/category_fabricator.rb",
|
| 367 |
+
"line": 1,
|
| 368 |
+
"why": "category_fabricator.rb now holds the :embeddable_host fabricator and embeddable_host_fabricator.rb holds the category fabricators; the contents are swapped between the two files."
|
| 369 |
+
},
|
| 370 |
+
{
|
| 371 |
+
"pr": 10,
|
| 372 |
+
"index": 5,
|
| 373 |
+
"methods": [
|
| 374 |
+
"db/migrate/20150818190757_create_embeddable_hosts.rb::CreateEmbeddableHosts.change"
|
| 375 |
+
],
|
| 376 |
+
"file": "db/migrate/20150818190757_create_embeddable_hosts.rb",
|
| 377 |
+
"line": 25,
|
| 378 |
+
"why": "The '#{h}' interpolation is in the migration's INSERT, not in the controller the comment names; host values are put into SQL unquoted."
|
| 379 |
+
},
|
| 380 |
+
{
|
| 381 |
+
"pr": 10,
|
| 382 |
+
"index": 6,
|
| 383 |
+
"methods": [
|
| 384 |
+
"db/migrate/20150818190757_create_embeddable_hosts.rb::CreateEmbeddableHosts.change"
|
| 385 |
+
],
|
| 386 |
+
"file": "db/migrate/20150818190757_create_embeddable_hosts.rb",
|
| 387 |
+
"line": 11,
|
| 388 |
+
"why": "execute(...)[0]['id'] (statement starting line 9) indexes the first row with no check, which raises when no embed_category setting row exists; line 15 does the same for uncategorized_category_id."
|
| 389 |
+
}
|
| 390 |
+
]
|
greptile/truth/grafana.json
ADDED
|
@@ -0,0 +1,261 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
[
|
| 2 |
+
{
|
| 3 |
+
"pr": 1,
|
| 4 |
+
"index": 0,
|
| 5 |
+
"methods": [
|
| 6 |
+
"pkg/services/anonymous/anonimpl/anonstore/database.go::AnonDBStore.CreateOrUpdateDevice"
|
| 7 |
+
],
|
| 8 |
+
"file": "pkg/services/anonymous/anonimpl/anonstore/database.go",
|
| 9 |
+
"line": 110,
|
| 10 |
+
"why": "CountDevices is read and the insert happens afterwards with no transaction or lock, so concurrent requests can all pass the count >= deviceLimit check and exceed the limit."
|
| 11 |
+
},
|
| 12 |
+
{
|
| 13 |
+
"pr": 1,
|
| 14 |
+
"index": 1,
|
| 15 |
+
"methods": [
|
| 16 |
+
"pkg/services/anonymous/anonimpl/client.go::Anonymous.Authenticate",
|
| 17 |
+
"pkg/services/anonymous/anonimpl/impl.go::AnonDeviceService.TagDevice"
|
| 18 |
+
],
|
| 19 |
+
"file": "pkg/services/anonymous/anonimpl/client.go",
|
| 20 |
+
"line": 44,
|
| 21 |
+
"why": "Authenticate now calls TagDevice synchronously and returns ErrDeviceLimitReached as an auth failure (lines 44-47); TagDevice was changed to propagate the tagging error (impl.go line 147)."
|
| 22 |
+
},
|
| 23 |
+
{
|
| 24 |
+
"pr": 1,
|
| 25 |
+
"index": 2,
|
| 26 |
+
"methods": [
|
| 27 |
+
"pkg/services/anonymous/anonimpl/anonstore/database.go::AnonDBStore.updateDevice"
|
| 28 |
+
],
|
| 29 |
+
"file": "pkg/services/anonymous/anonimpl/anonstore/database.go",
|
| 30 |
+
"line": 95,
|
| 31 |
+
"why": "rowsAffected == 0 is mapped to ErrDeviceLimitReached, although it only means no existing device matched the id/time window."
|
| 32 |
+
},
|
| 33 |
+
{
|
| 34 |
+
"pr": 1,
|
| 35 |
+
"index": 3,
|
| 36 |
+
"methods": [
|
| 37 |
+
"pkg/services/anonymous/anonimpl/anonstore/database.go::AnonDBStore.updateDevice"
|
| 38 |
+
],
|
| 39 |
+
"file": "pkg/services/anonymous/anonimpl/anonstore/database.go",
|
| 40 |
+
"line": 81,
|
| 41 |
+
"why": "The BETWEEN bounds are computed from device.UpdatedAt rather than time.Now(), unlike the CountDevices window in CreateOrUpdateDevice."
|
| 42 |
+
},
|
| 43 |
+
{
|
| 44 |
+
"pr": 1,
|
| 45 |
+
"index": 4,
|
| 46 |
+
"methods": [
|
| 47 |
+
"pkg/services/anonymous/anonimpl/impl.go::AnonDeviceService.tagDeviceUI"
|
| 48 |
+
],
|
| 49 |
+
"file": "pkg/services/anonymous/anonimpl/impl.go",
|
| 50 |
+
"line": 87,
|
| 51 |
+
"why": "localCache.SetDefault runs before CreateOrUpdateDevice, so a device rejected with ErrDeviceLimitReached stays cached and skips the limit check for 29 minutes."
|
| 52 |
+
},
|
| 53 |
+
{
|
| 54 |
+
"pr": 2,
|
| 55 |
+
"index": 0,
|
| 56 |
+
"methods": [
|
| 57 |
+
"pkg/services/authz/rbac/service.go::Service.Check"
|
| 58 |
+
],
|
| 59 |
+
"file": "pkg/services/authz/rbac/service.go",
|
| 60 |
+
"line": 131,
|
| 61 |
+
"why": "Cached permissions are trusted only when they allow (lines 123-136); a cached deny falls through to a fresh DB lookup, so a stale cached grant still allows access after revocation."
|
| 62 |
+
},
|
| 63 |
+
{
|
| 64 |
+
"pr": 2,
|
| 65 |
+
"index": 1,
|
| 66 |
+
"methods": [],
|
| 67 |
+
"file": "pkg/services/authz/rbac/service_test.go",
|
| 68 |
+
"line": 981,
|
| 69 |
+
"why": "Test file (not in methods_read): the comment says the cached permissions allow access but the map stores false for dashboards:uid:dash1."
|
| 70 |
+
},
|
| 71 |
+
{
|
| 72 |
+
"pr": 2,
|
| 73 |
+
"index": 2,
|
| 74 |
+
"methods": [
|
| 75 |
+
"pkg/services/authz/rbac/cache.go::userPermDenialCacheKey"
|
| 76 |
+
],
|
| 77 |
+
"file": "pkg/services/authz/rbac/cache.go",
|
| 78 |
+
"line": 31,
|
| 79 |
+
"why": "The denial key joins namespace, user, action, name and parent with underscores, so values containing underscores or empty parts can collide."
|
| 80 |
+
},
|
| 81 |
+
{
|
| 82 |
+
"pr": 3,
|
| 83 |
+
"index": 0,
|
| 84 |
+
"methods": [
|
| 85 |
+
"pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.go::ContextualLoggerMiddleware.QueryData",
|
| 86 |
+
"pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.go::ContextualLoggerMiddleware.CallResource",
|
| 87 |
+
"pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.go::ContextualLoggerMiddleware.CheckHealth",
|
| 88 |
+
"pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.go::ContextualLoggerMiddleware.CollectMetrics"
|
| 89 |
+
],
|
| 90 |
+
"file": "pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.go",
|
| 91 |
+
"line": 40,
|
| 92 |
+
"why": "Each method dereferences req.PluginContext (lines 40, 45, 50, 55) with no req == nil guard, unlike LoggerMiddleware, so a nil request panics."
|
| 93 |
+
},
|
| 94 |
+
{
|
| 95 |
+
"pr": 3,
|
| 96 |
+
"index": 1,
|
| 97 |
+
"methods": [
|
| 98 |
+
"pkg/services/pluginsintegration/clientmiddleware/logger_middleware.go::LoggerMiddleware.logRequest",
|
| 99 |
+
"pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.go::instrumentContext"
|
| 100 |
+
],
|
| 101 |
+
"file": "pkg/services/pluginsintegration/clientmiddleware/logger_middleware.go",
|
| 102 |
+
"line": 49,
|
| 103 |
+
"why": "logRequest no longer adds traceID to logParams, and the new instrumentContext does not add it either, so plugin request logs lose the trace ID."
|
| 104 |
+
},
|
| 105 |
+
{
|
| 106 |
+
"pr": 3,
|
| 107 |
+
"index": 2,
|
| 108 |
+
"methods": [
|
| 109 |
+
"pkg/plugins/log/fake.go::TestLogger.FromContext"
|
| 110 |
+
],
|
| 111 |
+
"file": "pkg/plugins/log/fake.go",
|
| 112 |
+
"line": 47,
|
| 113 |
+
"why": "FromContext returns NewTestLogger() instead of the receiver, so logs written through it are lost to test assertions."
|
| 114 |
+
},
|
| 115 |
+
{
|
| 116 |
+
"pr": 4,
|
| 117 |
+
"index": 0,
|
| 118 |
+
"methods": [
|
| 119 |
+
"public/app/plugins/datasource/loki/shardQuerySplitting.ts::runShardSplitQuery",
|
| 120 |
+
"public/app/plugins/datasource/loki/querySplitting.ts::runSplitQuery"
|
| 121 |
+
],
|
| 122 |
+
"file": "public/app/plugins/datasource/loki/shardQuerySplitting.ts",
|
| 123 |
+
"line": 52,
|
| 124 |
+
"why": "applyTemplateVariables is called with request.filters, but the shardQuerySplitting tests mock it as a one-argument function, so the filters path is untested; the same call is in runSplitQuery line 299 (file choice is ambiguous)."
|
| 125 |
+
},
|
| 126 |
+
{
|
| 127 |
+
"pr": 5,
|
| 128 |
+
"index": 0,
|
| 129 |
+
"methods": [
|
| 130 |
+
"public/app/features/alerting/unified/rule-list/FilterView.tsx::FilterViewResults"
|
| 131 |
+
],
|
| 132 |
+
"file": "public/app/features/alerting/unified/rule-list/FilterView.tsx",
|
| 133 |
+
"line": 157,
|
| 134 |
+
"why": "The grafana case renders GrafanaRuleListItem inside rules.map without key={key} (the other cases keep it)."
|
| 135 |
+
},
|
| 136 |
+
{
|
| 137 |
+
"pr": 5,
|
| 138 |
+
"index": 1,
|
| 139 |
+
"methods": [
|
| 140 |
+
"public/app/features/alerting/unified/rule-list/components/RuleActionsButtons.V2.tsx::RuleActionsButtons",
|
| 141 |
+
"public/app/features/alerting/unified/rule-list/GrafanaRuleListItem.tsx::GrafanaRuleListItem"
|
| 142 |
+
],
|
| 143 |
+
"file": "public/app/features/alerting/unified/rule-list/components/RuleActionsButtons.V2.tsx",
|
| 144 |
+
"line": 104,
|
| 145 |
+
"why": "SilenceGrafanaRuleDrawer renders only when rulerRuleType.grafana.alertingRule(rule), but GrafanaRuleListItem (line 47) now passes only promRule, so 'Silence notifications' sets state and shows nothing."
|
| 146 |
+
},
|
| 147 |
+
{
|
| 148 |
+
"pr": 6,
|
| 149 |
+
"index": 0,
|
| 150 |
+
"methods": [
|
| 151 |
+
"pkg/apiserver/rest/dualwriter_mode3.go::DualWriterMode3.Delete"
|
| 152 |
+
],
|
| 153 |
+
"file": "pkg/apiserver/rest/dualwriter_mode3.go",
|
| 154 |
+
"line": 97,
|
| 155 |
+
"why": "klog.NewContext(ctx, d.Log) uses the base logger instead of the enriched log with name/kind/method."
|
| 156 |
+
},
|
| 157 |
+
{
|
| 158 |
+
"pr": 6,
|
| 159 |
+
"index": 1,
|
| 160 |
+
"methods": [
|
| 161 |
+
"pkg/apiserver/rest/dualwriter_mode3.go::DualWriterMode3.DeleteCollection"
|
| 162 |
+
],
|
| 163 |
+
"file": "pkg/apiserver/rest/dualwriter_mode3.go",
|
| 164 |
+
"line": 166,
|
| 165 |
+
"why": "In DeleteCollection the legacy DeleteCollection duration is recorded with recordStorageDuration instead of recordLegacyDuration; the comment's wording is garbled, and Create (line 45) and Update (line 129) have the inverse mix-up."
|
| 166 |
+
},
|
| 167 |
+
{
|
| 168 |
+
"pr": 6,
|
| 169 |
+
"index": 2,
|
| 170 |
+
"methods": [
|
| 171 |
+
"pkg/apiserver/rest/dualwriter_mode3.go::DualWriterMode3.Delete"
|
| 172 |
+
],
|
| 173 |
+
"file": "pkg/apiserver/rest/dualwriter_mode3.go",
|
| 174 |
+
"line": 106,
|
| 175 |
+
"why": "recordStorageDuration is passed name instead of options.Kind as the kind label."
|
| 176 |
+
},
|
| 177 |
+
{
|
| 178 |
+
"pr": 7,
|
| 179 |
+
"index": 0,
|
| 180 |
+
"methods": [
|
| 181 |
+
"pkg/services/annotations/annotationsimpl/xorm_store.go::xormRepositoryImpl.CleanAnnotations",
|
| 182 |
+
"pkg/services/annotations/annotationsimpl/xorm_store.go::xormRepositoryImpl.CleanOrphanedAnnotationTags"
|
| 183 |
+
],
|
| 184 |
+
"file": "pkg/services/annotations/annotationsimpl/xorm_store.go",
|
| 185 |
+
"line": 534,
|
| 186 |
+
"why": "Debug output (ids, counts, cond) is logged with r.log.Error on every batch (lines 534, 537, 554, 557 and 576, 579)."
|
| 187 |
+
},
|
| 188 |
+
{
|
| 189 |
+
"pr": 7,
|
| 190 |
+
"index": 1,
|
| 191 |
+
"methods": [
|
| 192 |
+
"pkg/services/cleanup/cleanup.go::CleanUpService.Run"
|
| 193 |
+
],
|
| 194 |
+
"file": "pkg/services/cleanup/cleanup.go",
|
| 195 |
+
"line": 77,
|
| 196 |
+
"why": "The cleanup ticker changed from 10 minutes to 1 minute, running every cleanup job ten times as often."
|
| 197 |
+
},
|
| 198 |
+
{
|
| 199 |
+
"pr": 8,
|
| 200 |
+
"index": 0,
|
| 201 |
+
"methods": [
|
| 202 |
+
"pkg/api/webassets/webassets.go::GetWebAssets"
|
| 203 |
+
],
|
| 204 |
+
"file": "pkg/api/webassets/webassets.go",
|
| 205 |
+
"line": 48,
|
| 206 |
+
"why": "After acquiring the write lock it does not re-check entryPointAssetsCache, so goroutines that queued on the lock all re-read the assets."
|
| 207 |
+
},
|
| 208 |
+
{
|
| 209 |
+
"pr": 8,
|
| 210 |
+
"index": 1,
|
| 211 |
+
"methods": [
|
| 212 |
+
"pkg/api/webassets/webassets.go::GetWebAssets"
|
| 213 |
+
],
|
| 214 |
+
"file": "pkg/api/webassets/webassets.go",
|
| 215 |
+
"line": 69,
|
| 216 |
+
"why": "entryPointAssetsCache = result runs even when the read failed, overwriting a valid cache with nil."
|
| 217 |
+
},
|
| 218 |
+
{
|
| 219 |
+
"pr": 9,
|
| 220 |
+
"index": 0,
|
| 221 |
+
"methods": [
|
| 222 |
+
"pkg/expr/reader.go::enableSqlExpressions"
|
| 223 |
+
],
|
| 224 |
+
"file": "pkg/expr/reader.go",
|
| 225 |
+
"line": 195,
|
| 226 |
+
"why": "Both branches return false (lines 195-199), so ReadQuery always rejects SQL expressions."
|
| 227 |
+
},
|
| 228 |
+
{
|
| 229 |
+
"pr": 9,
|
| 230 |
+
"index": 1,
|
| 231 |
+
"methods": [
|
| 232 |
+
"pkg/expr/sql/db.go::DB.RunCommands",
|
| 233 |
+
"pkg/expr/sql/db.go::DB.QueryFramesInto",
|
| 234 |
+
"pkg/expr/sql/db.go::DB.TablesList"
|
| 235 |
+
],
|
| 236 |
+
"file": "pkg/expr/sql/db.go",
|
| 237 |
+
"line": 17,
|
| 238 |
+
"why": "The replacement for go-duck is stubs that return 'not implemented' (lines 13, 17, 21), so TablesList and SQLCommand.Execute always fail."
|
| 239 |
+
},
|
| 240 |
+
{
|
| 241 |
+
"pr": 10,
|
| 242 |
+
"index": 0,
|
| 243 |
+
"methods": [
|
| 244 |
+
"pkg/storage/unified/search/bleve.go::bleveBackend.BuildIndex"
|
| 245 |
+
],
|
| 246 |
+
"file": "pkg/storage/unified/search/bleve.go",
|
| 247 |
+
"line": 137,
|
| 248 |
+
"why": "cacheMu now guards only the final b.cache[key] assignment, so concurrent BuildIndex calls for the same key both build the index."
|
| 249 |
+
},
|
| 250 |
+
{
|
| 251 |
+
"pr": 10,
|
| 252 |
+
"index": 1,
|
| 253 |
+
"methods": [
|
| 254 |
+
"pkg/storage/unified/resource/search.go::searchSupport.init",
|
| 255 |
+
"pkg/storage/unified/search/bleve.go::bleveBackend.TotalDocs"
|
| 256 |
+
],
|
| 257 |
+
"file": "pkg/storage/unified/resource/search.go",
|
| 258 |
+
"line": 216,
|
| 259 |
+
"why": "init calls s.search.TotalDocs() after starting the event watcher goroutine; TotalDocs (bleve.go line 146) ranges over b.cache without cacheMu while BuildIndex can write it."
|
| 260 |
+
}
|
| 261 |
+
]
|
greptile/truth/keycloak.json
ADDED
|
@@ -0,0 +1,297 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
[
|
| 2 |
+
{
|
| 3 |
+
"pr": 1,
|
| 4 |
+
"index": 0,
|
| 5 |
+
"methods": [
|
| 6 |
+
"services/src/main/java/org/keycloak/authentication/authenticators/browser/UsernameForm.java::UsernameForm.authenticate"
|
| 7 |
+
],
|
| 8 |
+
"file": "services/src/main/java/org/keycloak/authentication/authenticators/browser/UsernameForm.java",
|
| 9 |
+
"line": 47,
|
| 10 |
+
"why": "Calls isConditionalPasskeysEnabled() with no argument, but the only definition (UsernamePasswordForm) takes a UserModel, so this does not compile."
|
| 11 |
+
},
|
| 12 |
+
{
|
| 13 |
+
"pr": 1,
|
| 14 |
+
"index": 1,
|
| 15 |
+
"methods": [
|
| 16 |
+
"services/src/main/java/org/keycloak/authentication/authenticators/browser/UsernamePasswordForm.java::UsernamePasswordForm.isConditionalPasskeysEnabled",
|
| 17 |
+
"services/src/main/java/org/keycloak/authentication/authenticators/browser/UsernamePasswordForm.java::UsernamePasswordForm.authenticate"
|
| 18 |
+
],
|
| 19 |
+
"file": "services/src/main/java/org/keycloak/authentication/authenticators/browser/UsernamePasswordForm.java",
|
| 20 |
+
"line": 161,
|
| 21 |
+
"why": "The added `&& user != null` makes the check false on the first login page (no user yet), so authenticate() at line 115 never calls webauthnAuth.fillContextForm and conditional passkey UI is lost for ID-less login."
|
| 22 |
+
},
|
| 23 |
+
{
|
| 24 |
+
"pr": 2,
|
| 25 |
+
"index": 0,
|
| 26 |
+
"methods": [
|
| 27 |
+
"model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/idp/InfinispanIdentityProviderStorageProvider.java::InfinispanIdentityProviderStorageProvider.getForLogin"
|
| 28 |
+
],
|
| 29 |
+
"file": "model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/idp/InfinispanIdentityProviderStorageProvider.java",
|
| 30 |
+
"line": 246,
|
| 31 |
+
"why": "Cached-id resolution calls session.identityProviders().getById(id), re-entering the caching provider, instead of idpDelegate.getById(id)."
|
| 32 |
+
},
|
| 33 |
+
{
|
| 34 |
+
"pr": 2,
|
| 35 |
+
"index": 1,
|
| 36 |
+
"methods": [],
|
| 37 |
+
"file": "testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/organization/cache/OrganizationCacheTest.java",
|
| 38 |
+
"line": 381,
|
| 39 |
+
"why": "Test testCacheIDPForLogin (not in methods_read) registers cleanup for identityProviders().get(\"alias\") instead of \"idp-alias-\" + i, so the created IdPs are not removed (same mistake again at line 425 for idp-alias-20)."
|
| 40 |
+
},
|
| 41 |
+
{
|
| 42 |
+
"pr": 3,
|
| 43 |
+
"index": 0,
|
| 44 |
+
"methods": [
|
| 45 |
+
"authz/client/src/main/java/org/keycloak/authorization/client/util/crypto/AuthzClientCryptoProvider.java::AuthzClientCryptoProvider.getBouncyCastleProvider"
|
| 46 |
+
],
|
| 47 |
+
"file": "authz/client/src/main/java/org/keycloak/authorization/client/util/crypto/AuthzClientCryptoProvider.java",
|
| 48 |
+
"line": 63,
|
| 49 |
+
"why": "getBouncyCastleProvider returns the provider of the default KeyStore type rather than a BouncyCastle provider."
|
| 50 |
+
},
|
| 51 |
+
{
|
| 52 |
+
"pr": 3,
|
| 53 |
+
"index": 1,
|
| 54 |
+
"methods": [
|
| 55 |
+
"authz/client/src/main/java/org/keycloak/authorization/client/util/crypto/AuthzClientCryptoProvider.java::AuthzClientCryptoProvider.getEcdsaCryptoProvider.concatenatedRSToASN1DER",
|
| 56 |
+
"authz/client/src/main/java/org/keycloak/authorization/client/util/crypto/AuthzClientCryptoProvider.java::AuthzClientCryptoProvider.getEcdsaCryptoProvider"
|
| 57 |
+
],
|
| 58 |
+
"file": "authz/client/src/main/java/org/keycloak/authorization/client/util/crypto/AuthzClientCryptoProvider.java",
|
| 59 |
+
"line": 114,
|
| 60 |
+
"why": "Lines 114-115 create ASN1Encoder instances and write r and s, then discard them; the return statement re-encodes with fresh encoders (dead code inside the anonymous ECDSACryptoProvider)."
|
| 61 |
+
},
|
| 62 |
+
{
|
| 63 |
+
"pr": 3,
|
| 64 |
+
"index": 2,
|
| 65 |
+
"methods": [
|
| 66 |
+
"authz/client/src/main/java/org/keycloak/authorization/client/util/crypto/ASN1Decoder.java::ASN1Decoder.readSequence",
|
| 67 |
+
"authz/client/src/main/java/org/keycloak/authorization/client/util/crypto/ASN1Decoder.java::ASN1Decoder.readLength"
|
| 68 |
+
],
|
| 69 |
+
"file": "authz/client/src/main/java/org/keycloak/authorization/client/util/crypto/ASN1Decoder.java",
|
| 70 |
+
"line": 60,
|
| 71 |
+
"why": "readSequence does `length = length - bytes.length` on the value from readLength, which returns -1 for indefinite-length encoding (line 134); the -1 is never handled, so such sequences are silently read as empty."
|
| 72 |
+
},
|
| 73 |
+
{
|
| 74 |
+
"pr": 3,
|
| 75 |
+
"index": 3,
|
| 76 |
+
"methods": [
|
| 77 |
+
"common/src/main/java/org/keycloak/common/crypto/CryptoProvider.java::CryptoProvider.order"
|
| 78 |
+
],
|
| 79 |
+
"file": "common/src/main/java/org/keycloak/common/crypto/CryptoProvider.java",
|
| 80 |
+
"line": 44,
|
| 81 |
+
"why": "New abstract `int order()` on the public CryptoProvider interface (no default) breaks every existing third-party implementation."
|
| 82 |
+
},
|
| 83 |
+
{
|
| 84 |
+
"pr": 4,
|
| 85 |
+
"index": 0,
|
| 86 |
+
"methods": [
|
| 87 |
+
"quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/cli/command/UpdateCompatibilityCheck.java::UpdateCompatibilityCheck.run",
|
| 88 |
+
"quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/cli/command/UpdateCompatibilityMetadata.java::UpdateCompatibilityMetadata.run"
|
| 89 |
+
],
|
| 90 |
+
"file": "quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/cli/command/UpdateCompatibilityCheck.java",
|
| 91 |
+
"line": 48,
|
| 92 |
+
"why": "Feature-disabled branch calls picocli.exit(CompatibilityResult.FEATURE_DISABLED), which calls System.exit directly; the identical new call is in UpdateCompatibilityMetadata.run line 48 (ambiguous which file the comment meant)."
|
| 93 |
+
},
|
| 94 |
+
{
|
| 95 |
+
"pr": 4,
|
| 96 |
+
"index": 1,
|
| 97 |
+
"methods": [],
|
| 98 |
+
"file": "quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/compatibility/CompatibilityResult.java",
|
| 99 |
+
"line": 34,
|
| 100 |
+
"why": "Constant declaration (not a method; covered only by the CompatibilityResult.java::<top-level> entry): RECREATE_UPGRADE_EXIT_CODE changes 4 to 3 and 4 becomes FEATURE_DISABLED with no release note or migration guidance; this is a missing-docs comment, so the location is the changed constant."
|
| 101 |
+
},
|
| 102 |
+
{
|
| 103 |
+
"pr": 5,
|
| 104 |
+
"index": 0,
|
| 105 |
+
"methods": [
|
| 106 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/AdminPermissions.java::AdminPermissions.registerListener.onEvent",
|
| 107 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/AdminPermissions.java::AdminPermissions.registerListener"
|
| 108 |
+
],
|
| 109 |
+
"file": "services/src/main/java/org/keycloak/services/resources/admin/permissions/AdminPermissions.java",
|
| 110 |
+
"line": 77,
|
| 111 |
+
"why": "Removal-event cleanup is gated on Profile.Feature.ADMIN_FINE_GRAINED_AUTHZ (V1) instead of ADMIN_FINE_GRAINED_AUTHZ_V2, so with only V2 enabled permissions are orphaned."
|
| 112 |
+
},
|
| 113 |
+
{
|
| 114 |
+
"pr": 5,
|
| 115 |
+
"index": 1,
|
| 116 |
+
"methods": [
|
| 117 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java::ClientPermissionsV2.hasPermission",
|
| 118 |
+
"server-spi-private/src/main/java/org/keycloak/authorization/AdminPermissionsSchema.java::AdminPermissionsSchema.getOrCreateResource"
|
| 119 |
+
],
|
| 120 |
+
"file": "services/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java",
|
| 121 |
+
"line": 214,
|
| 122 |
+
"why": "findByName(server, client.getId(), server.getId()) uses the server id as owner, but getOrCreateResource creates per-client resources with owner resourceServer.getClientId() (line 104), so per-client resources are never found."
|
| 123 |
+
},
|
| 124 |
+
{
|
| 125 |
+
"pr": 5,
|
| 126 |
+
"index": 2,
|
| 127 |
+
"methods": [
|
| 128 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java::ClientPermissionsV2.getClientsWithPermission"
|
| 129 |
+
],
|
| 130 |
+
"file": "services/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java",
|
| 131 |
+
"line": 138,
|
| 132 |
+
"why": "findByType(CLIENTS_RESOURCE_TYPE) only yields the type-level 'Clients' resource (per-client resources have no type), and line 140 returns its name rather than client ids, which callers pass to realm.getClientById."
|
| 133 |
+
},
|
| 134 |
+
{
|
| 135 |
+
"pr": 5,
|
| 136 |
+
"index": 3,
|
| 137 |
+
"methods": [
|
| 138 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java::ClientPermissionsV2.hasPermission"
|
| 139 |
+
],
|
| 140 |
+
"file": "services/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java",
|
| 141 |
+
"line": 219,
|
| 142 |
+
"why": "getResourceTypeResource (line 217) can return null and the result is passed to findByResource and later resource.getScopes() without a null check."
|
| 143 |
+
},
|
| 144 |
+
{
|
| 145 |
+
"pr": 5,
|
| 146 |
+
"index": 4,
|
| 147 |
+
"methods": [
|
| 148 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java::ClientPermissionsV2.getEvaluationContext",
|
| 149 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java::ClientPermissionsV2.getEvaluationContext.getBaseAttributes"
|
| 150 |
+
],
|
| 151 |
+
"file": "services/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java",
|
| 152 |
+
"line": 262,
|
| 153 |
+
"why": "Private getEvaluationContext (with its anonymous getBaseAttributes override) is never called."
|
| 154 |
+
},
|
| 155 |
+
{
|
| 156 |
+
"pr": 6,
|
| 157 |
+
"index": 0,
|
| 158 |
+
"methods": [
|
| 159 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/GroupPermissionsV2.java::GroupPermissionsV2.canManage"
|
| 160 |
+
],
|
| 161 |
+
"file": "services/src/main/java/org/keycloak/services/resources/admin/permissions/GroupPermissionsV2.java",
|
| 162 |
+
"line": 70,
|
| 163 |
+
"why": "canManage() falls back to hasPermission(null, VIEW, MANAGE), so a VIEW-only grant passes the manage check; it should check MANAGE only."
|
| 164 |
+
},
|
| 165 |
+
{
|
| 166 |
+
"pr": 6,
|
| 167 |
+
"index": 1,
|
| 168 |
+
"methods": [
|
| 169 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/GroupPermissionsV2.java::GroupPermissionsV2.getGroupIdsWithViewPermission",
|
| 170 |
+
"services/src/main/java/org/keycloak/services/resources/admin/permissions/GroupPermissionsV2.java::GroupPermissionsV2.hasPermission"
|
| 171 |
+
],
|
| 172 |
+
"file": "services/src/main/java/org/keycloak/services/resources/admin/permissions/GroupPermissionsV2.java",
|
| 173 |
+
"line": 122,
|
| 174 |
+
"why": "Passes and collects groupResource.getId() (resource id) although hasPermission resolves resources by name (the group id) and callers expect group ids, so per-group grants do not yield the right ids."
|
| 175 |
+
},
|
| 176 |
+
{
|
| 177 |
+
"pr": 7,
|
| 178 |
+
"index": 0,
|
| 179 |
+
"methods": [],
|
| 180 |
+
"file": "themes/src/main/resources-community/theme/base/account/messages/messages_lt.properties",
|
| 181 |
+
"line": 101,
|
| 182 |
+
"why": "Translation file (no method): totpStep1 in the Lithuanian file is replaced with Italian text; the same Italian line is in login/messages/messages_lt.properties line 71 (loginTotpStep1), so the comment could mean either."
|
| 183 |
+
},
|
| 184 |
+
{
|
| 185 |
+
"pr": 7,
|
| 186 |
+
"index": 1,
|
| 187 |
+
"methods": [],
|
| 188 |
+
"file": "themes/src/main/resources-community/theme/base/account/messages/messages_zh_CN.properties",
|
| 189 |
+
"line": 112,
|
| 190 |
+
"why": "Translation file (no method): totpStep1 in the Simplified Chinese file uses Traditional Chinese characters."
|
| 191 |
+
},
|
| 192 |
+
{
|
| 193 |
+
"pr": 7,
|
| 194 |
+
"index": 2,
|
| 195 |
+
"methods": [
|
| 196 |
+
"misc/theme-verifier/src/main/java/org/keycloak/themeverifier/VerifyMessageProperties.java::VerifyMessageProperties.santizeAnchors"
|
| 197 |
+
],
|
| 198 |
+
"file": "misc/theme-verifier/src/main/java/org/keycloak/themeverifier/VerifyMessageProperties.java",
|
| 199 |
+
"line": 154,
|
| 200 |
+
"why": "Each translated anchor consumes the next English anchor via englishMatcher.find() and compares in order, so extra, missing, or reordered anchors give wrong validation results."
|
| 201 |
+
},
|
| 202 |
+
{
|
| 203 |
+
"pr": 7,
|
| 204 |
+
"index": 3,
|
| 205 |
+
"methods": [
|
| 206 |
+
"misc/theme-verifier/src/main/java/org/keycloak/themeverifier/VerifyMessageProperties.java::VerifyMessageProperties.santizeAnchors"
|
| 207 |
+
],
|
| 208 |
+
"file": "misc/theme-verifier/src/main/java/org/keycloak/themeverifier/VerifyMessageProperties.java",
|
| 209 |
+
"line": 150,
|
| 210 |
+
"why": "Method name is misspelled santizeAnchors (should be sanitizeAnchors)."
|
| 211 |
+
},
|
| 212 |
+
{
|
| 213 |
+
"pr": 7,
|
| 214 |
+
"index": 4,
|
| 215 |
+
"methods": [],
|
| 216 |
+
"file": "misc/theme-verifier/src/main/java/org/keycloak/themeverifier/VerifyMessageProperties.java",
|
| 217 |
+
"line": 139,
|
| 218 |
+
"why": "Field declaration (not a method; covered only by the VerifyMessageProperties.java::<top-level> entry): `Pattern HTML_TAGS` is package-private and non-final instead of private static final."
|
| 219 |
+
},
|
| 220 |
+
{
|
| 221 |
+
"pr": 8,
|
| 222 |
+
"index": 0,
|
| 223 |
+
"methods": [
|
| 224 |
+
"services/src/main/java/org/keycloak/protocol/oidc/encode/AccessTokenContext.java::AccessTokenContext.AccessTokenContext"
|
| 225 |
+
],
|
| 226 |
+
"file": "services/src/main/java/org/keycloak/protocol/oidc/encode/AccessTokenContext.java",
|
| 227 |
+
"line": 73,
|
| 228 |
+
"why": "Fourth Objects.requireNonNull checks grantType again (with the rawTokenId message) instead of rawTokenId."
|
| 229 |
+
},
|
| 230 |
+
{
|
| 231 |
+
"pr": 8,
|
| 232 |
+
"index": 1,
|
| 233 |
+
"methods": [
|
| 234 |
+
"testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/AssertEvents.java::AssertEvents.isAccessTokenId.matchesSafely",
|
| 235 |
+
"testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/AssertEvents.java::AssertEvents.isAccessTokenId"
|
| 236 |
+
],
|
| 237 |
+
"file": "testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/AssertEvents.java",
|
| 238 |
+
"line": 483,
|
| 239 |
+
"why": "Uses substring(3,5) instead of substring(4,6) for the grant shortcut and returns false on a match, inverting the check."
|
| 240 |
+
},
|
| 241 |
+
{
|
| 242 |
+
"pr": 8,
|
| 243 |
+
"index": 2,
|
| 244 |
+
"methods": [
|
| 245 |
+
"server-spi-private/src/main/java/org/keycloak/protocol/oidc/grants/OAuth2GrantTypeFactory.java::OAuth2GrantTypeFactory.getShortcut"
|
| 246 |
+
],
|
| 247 |
+
"file": "server-spi-private/src/main/java/org/keycloak/protocol/oidc/grants/OAuth2GrantTypeFactory.java",
|
| 248 |
+
"line": 30,
|
| 249 |
+
"why": "Javadoc on getShortcut() says 'usually like 3-letters shortcut' while the shortcuts and the 6-char encoding use 2 letters (comment sits just above the one-line method range 33)."
|
| 250 |
+
},
|
| 251 |
+
{
|
| 252 |
+
"pr": 8,
|
| 253 |
+
"index": 3,
|
| 254 |
+
"methods": [],
|
| 255 |
+
"file": "services/src/test/java/org/keycloak/protocol/oidc/encode/DefaultTokenContextEncoderProviderTest.java",
|
| 256 |
+
"line": 82,
|
| 257 |
+
"why": "Test method testIncorrectGrantType (not in methods_read) catches generic RuntimeException where the provider throws IllegalArgumentException."
|
| 258 |
+
},
|
| 259 |
+
{
|
| 260 |
+
"pr": 9,
|
| 261 |
+
"index": 0,
|
| 262 |
+
"methods": [
|
| 263 |
+
"services/src/main/java/org/keycloak/forms/login/freemarker/model/RecoveryAuthnCodeInputLoginBean.java::RecoveryAuthnCodeInputLoginBean.RecoveryAuthnCodeInputLoginBean"
|
| 264 |
+
],
|
| 265 |
+
"file": "services/src/main/java/org/keycloak/forms/login/freemarker/model/RecoveryAuthnCodeInputLoginBean.java",
|
| 266 |
+
"line": 19,
|
| 267 |
+
"why": "Calls credentialModelOpt.get() on RecoveryAuthnCodesUtils.getCredential(user) without isPresent(), risking NoSuchElementException; the comment's raw-List title matches the greptile entry below instead (ambiguous comment, located by its body)."
|
| 268 |
+
},
|
| 269 |
+
{
|
| 270 |
+
"pr": 9,
|
| 271 |
+
"index": 1,
|
| 272 |
+
"methods": [
|
| 273 |
+
"testsuite/integration-arquillian/servers/auth-server/services/testsuite-providers/src/main/java/org/keycloak/testsuite/federation/BackwardsCompatibilityUserStorage.java::BackwardsCompatibilityUserStorage.getCredentials"
|
| 274 |
+
],
|
| 275 |
+
"file": "testsuite/integration-arquillian/servers/auth-server/services/testsuite-providers/src/main/java/org/keycloak/testsuite/federation/BackwardsCompatibilityUserStorage.java",
|
| 276 |
+
"line": 237,
|
| 277 |
+
"why": "RecoveryAuthnCodesCredentialModel built via createFromValues never gets the stored credential's id (myUser.recoveryCodes.getId()), so getId() is null and removal by id fails."
|
| 278 |
+
},
|
| 279 |
+
{
|
| 280 |
+
"pr": 10,
|
| 281 |
+
"index": 0,
|
| 282 |
+
"methods": [
|
| 283 |
+
"model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/GroupAdapter.java::GroupAdapter.getSubGroupsCount"
|
| 284 |
+
],
|
| 285 |
+
"file": "model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/GroupAdapter.java",
|
| 286 |
+
"line": 275,
|
| 287 |
+
"why": "Returns null when the group model is gone, violating GroupModel's documented never-null contract for getSubGroupsCount."
|
| 288 |
+
},
|
| 289 |
+
{
|
| 290 |
+
"pr": 10,
|
| 291 |
+
"index": 1,
|
| 292 |
+
"methods": [],
|
| 293 |
+
"file": "tests/base/src/test/java/org/keycloak/tests/admin/group/GroupTest.java",
|
| 294 |
+
"line": 155,
|
| 295 |
+
"why": "Test createMultiDeleteMultiReadMulti (not in methods_read) sets deletedAll and asserts at line 157 without joining the reader thread started at line 139, so late exceptions can be missed."
|
| 296 |
+
}
|
| 297 |
+
]
|
greptile/truth/sentry.json
ADDED
|
@@ -0,0 +1,349 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
[
|
| 2 |
+
{
|
| 3 |
+
"pr": 1,
|
| 4 |
+
"index": 0,
|
| 5 |
+
"methods": [
|
| 6 |
+
"src/sentry/api/paginator.py::OptimizedCursorPaginator.get_result"
|
| 7 |
+
],
|
| 8 |
+
"file": "src/sentry/api/paginator.py",
|
| 9 |
+
"line": 882,
|
| 10 |
+
"why": "When enable_advanced_features is set and cursor.offset < 0, start_offset is the raw negative offset (line 880) and queryset[start_offset:stop] slices a Django QuerySet with a negative index, which Django rejects."
|
| 11 |
+
},
|
| 12 |
+
{
|
| 13 |
+
"pr": 1,
|
| 14 |
+
"index": 1,
|
| 15 |
+
"methods": [
|
| 16 |
+
"src/sentry/api/endpoints/organization_auditlogs.py::OrganizationAuditLogsEndpoint.get"
|
| 17 |
+
],
|
| 18 |
+
"file": "src/sentry/api/endpoints/organization_auditlogs.py",
|
| 19 |
+
"line": 71,
|
| 20 |
+
"why": "enable_advanced reads organization_context.member.has_global_access with no None check; member is None for API-key/org-token requests, so the attribute access raises AttributeError (it is evaluated even when optimized_pagination is not requested, because it runs unconditionally for non-superusers)."
|
| 21 |
+
},
|
| 22 |
+
{
|
| 23 |
+
"pr": 1,
|
| 24 |
+
"index": 2,
|
| 25 |
+
"methods": [
|
| 26 |
+
"src/sentry/api/paginator.py::OptimizedCursorPaginator.get_item_key"
|
| 27 |
+
],
|
| 28 |
+
"file": "src/sentry/api/paginator.py",
|
| 29 |
+
"line": 840,
|
| 30 |
+
"why": "get_item_key applies math.floor/math.ceil to getattr(item, self.key), but the audit log endpoint uses it with order_by='-datetime', so the key is a datetime and floor/ceil raise TypeError (DateTimePaginator converts to a timestamp first)."
|
| 31 |
+
},
|
| 32 |
+
{
|
| 33 |
+
"pr": 1,
|
| 34 |
+
"index": 3,
|
| 35 |
+
"methods": [],
|
| 36 |
+
"file": "src/sentry/api/endpoints/organization_auditlogs.py",
|
| 37 |
+
"line": 11,
|
| 38 |
+
"why": "Module-level import of OptimizedCursorPaginator (outside the organization_auditlogs.py <top-level> range 17-40, which excludes the import block); at the head commit the class does exist in paginator.py (line 821, added by this PR), so the 'non-existent' claim does not hold here."
|
| 39 |
+
},
|
| 40 |
+
{
|
| 41 |
+
"pr": 2,
|
| 42 |
+
"index": 0,
|
| 43 |
+
"methods": [
|
| 44 |
+
"src/sentry/api/paginator.py::OptimizedCursorPaginator.get_result"
|
| 45 |
+
],
|
| 46 |
+
"file": "src/sentry/api/paginator.py",
|
| 47 |
+
"line": 880,
|
| 48 |
+
"why": "In the enable_advanced_features and cursor.offset < 0 branch, cursor.offset is used directly as start_offset and passed to queryset[start_offset:stop] (line 882) with no clamping."
|
| 49 |
+
},
|
| 50 |
+
{
|
| 51 |
+
"pr": 2,
|
| 52 |
+
"index": 1,
|
| 53 |
+
"methods": [
|
| 54 |
+
"src/sentry/api/paginator.py::BasePaginator.get_result"
|
| 55 |
+
],
|
| 56 |
+
"file": "src/sentry/api/paginator.py",
|
| 57 |
+
"line": 182,
|
| 58 |
+
"why": "start_offset = max(0, offset) if not cursor.is_prev else offset leaves prev-cursor offsets unclamped, so a negative offset from a crafted cursor reaches queryset slicing on line 184."
|
| 59 |
+
},
|
| 60 |
+
{
|
| 61 |
+
"pr": 2,
|
| 62 |
+
"index": 2,
|
| 63 |
+
"methods": [
|
| 64 |
+
"src/sentry/api/paginator.py::OptimizedCursorPaginator.get_item_key"
|
| 65 |
+
],
|
| 66 |
+
"file": "src/sentry/api/paginator.py",
|
| 67 |
+
"line": 840,
|
| 68 |
+
"why": "math.floor/math.ceil are applied to the raw datetime key (order_by='-datetime'), which raises TypeError."
|
| 69 |
+
},
|
| 70 |
+
{
|
| 71 |
+
"pr": 2,
|
| 72 |
+
"index": 3,
|
| 73 |
+
"methods": [
|
| 74 |
+
"src/sentry/api/endpoints/organization_auditlogs.py::OrganizationAuditLogsEndpoint.get"
|
| 75 |
+
],
|
| 76 |
+
"file": "src/sentry/api/endpoints/organization_auditlogs.py",
|
| 77 |
+
"line": 71,
|
| 78 |
+
"why": "organization_context.member.has_global_access is read without checking that member is not None, which raises AttributeError for non-member / token-authenticated callers that are not superusers."
|
| 79 |
+
},
|
| 80 |
+
{
|
| 81 |
+
"pr": 3,
|
| 82 |
+
"index": 0,
|
| 83 |
+
"methods": [
|
| 84 |
+
"src/sentry/testutils/factories.py::_set_sample_rate_from_error_sampling"
|
| 85 |
+
],
|
| 86 |
+
"file": "src/sentry/testutils/factories.py",
|
| 87 |
+
"line": 353,
|
| 88 |
+
"why": "`if client_sample_rate:` is falsy for 0.0, so a client_sample_rate of 0.0 never sets normalized_data['sample_rate']; it should test `is not None`."
|
| 89 |
+
},
|
| 90 |
+
{
|
| 91 |
+
"pr": 3,
|
| 92 |
+
"index": 1,
|
| 93 |
+
"methods": [
|
| 94 |
+
"src/sentry/api/helpers/error_upsampling.py::is_errors_query_for_error_upsampled_projects",
|
| 95 |
+
"src/sentry/api/helpers/error_upsampling.py::invalidate_upsampling_cache"
|
| 96 |
+
],
|
| 97 |
+
"file": "src/sentry/api/helpers/error_upsampling.py",
|
| 98 |
+
"line": 27,
|
| 99 |
+
"why": "The cache key embeds hash(tuple(sorted(project_ids))) and invalidate_upsampling_cache rebuilds it the same way (line 73); hash() is not a stable serialization for a shared cache key. Note that CPython only randomizes str/bytes hashes, so for int project ids the keys do match across workers today; the location is right but the stated failure is overstated."
|
| 100 |
+
},
|
| 101 |
+
{
|
| 102 |
+
"pr": 3,
|
| 103 |
+
"index": 2,
|
| 104 |
+
"methods": [
|
| 105 |
+
"src/sentry/api/endpoints/organization_events_stats.py::OrganizationEventsStatsEndpoint.get._get_event_stats"
|
| 106 |
+
],
|
| 107 |
+
"file": "src/sentry/api/endpoints/organization_events_stats.py",
|
| 108 |
+
"line": 221,
|
| 109 |
+
"why": "is_errors_query_for_error_upsampled_projects is passed the enclosing `dataset` instead of the `scoped_dataset` parameter, so when the dashboard split path calls _get_event_stats with discover (or errors) while the request dataset is metrics, the eligibility check uses the wrong dataset."
|
| 110 |
+
},
|
| 111 |
+
{
|
| 112 |
+
"pr": 4,
|
| 113 |
+
"index": 0,
|
| 114 |
+
"methods": [
|
| 115 |
+
"src/sentry/integrations/github/integration.py::GitHubInstallation.dispatch"
|
| 116 |
+
],
|
| 117 |
+
"file": "src/sentry/integrations/github/integration.py",
|
| 118 |
+
"line": 502,
|
| 119 |
+
"why": "pipeline.fetch_state('github_authenticated_user') is used without checking it was set (e.g. when the OAuth step was skipped); at head a missing value compares None against the sender login and fails closed with the generic error rather than crashing, so this is the most defensible location."
|
| 120 |
+
},
|
| 121 |
+
{
|
| 122 |
+
"pr": 4,
|
| 123 |
+
"index": 1,
|
| 124 |
+
"methods": [
|
| 125 |
+
"src/sentry/integrations/github/integration.py::OAuthLoginView.dispatch"
|
| 126 |
+
],
|
| 127 |
+
"file": "src/sentry/integrations/github/integration.py",
|
| 128 |
+
"line": 402,
|
| 129 |
+
"why": "The OAuth state parameter is pipeline.signature, a deterministic md5 of the pipeline ids, rather than a per-request random nonce; it is compared against the same value on line 412."
|
| 130 |
+
},
|
| 131 |
+
{
|
| 132 |
+
"pr": 4,
|
| 133 |
+
"index": 2,
|
| 134 |
+
"methods": [
|
| 135 |
+
"src/sentry/integrations/github/integration.py::GitHubInstallation.dispatch"
|
| 136 |
+
],
|
| 137 |
+
"file": "src/sentry/integrations/github/integration.py",
|
| 138 |
+
"line": 503,
|
| 139 |
+
"why": "integration.metadata['sender']['login'] is indexed directly, raising KeyError for existing integrations whose metadata has no 'sender' entry."
|
| 140 |
+
},
|
| 141 |
+
{
|
| 142 |
+
"pr": 5,
|
| 143 |
+
"index": 0,
|
| 144 |
+
"methods": [
|
| 145 |
+
"src/sentry/issues/endpoints/browser_reporting_collector.py::BrowserReportingCollectorEndpoint.post"
|
| 146 |
+
],
|
| 147 |
+
"file": "src/sentry/issues/endpoints/browser_reporting_collector.py",
|
| 148 |
+
"line": 91,
|
| 149 |
+
"why": "The comment describes the base code: this PR replaced the HttpResponse returns with rest_framework Response (lines 91, 104, 115, 130), so at head post already returns DRF Responses; the location is still this method."
|
| 150 |
+
},
|
| 151 |
+
{
|
| 152 |
+
"pr": 5,
|
| 153 |
+
"index": 1,
|
| 154 |
+
"methods": [
|
| 155 |
+
"src/sentry/workflow_engine/endpoints/validators/base/detector.py::BaseDetectorTypeValidator.update"
|
| 156 |
+
],
|
| 157 |
+
"file": "src/sentry/workflow_engine/endpoints/validators/base/detector.py",
|
| 158 |
+
"line": 64,
|
| 159 |
+
"why": "instance.type is taken from validated_data.get('detector_type', ...), but the serializer field is named 'type', so a type change in an update is ignored and the existing group_type slug is kept."
|
| 160 |
+
},
|
| 161 |
+
{
|
| 162 |
+
"pr": 5,
|
| 163 |
+
"index": 2,
|
| 164 |
+
"methods": [
|
| 165 |
+
"src/sentry/replays/endpoints/project_replay_summarize_breadcrumbs.py::fetch_error_details"
|
| 166 |
+
],
|
| 167 |
+
"file": "src/sentry/replays/endpoints/project_replay_summarize_breadcrumbs.py",
|
| 168 |
+
"line": 118,
|
| 169 |
+
"why": "zip(error_ids, events.values()) pairs ids with nodestore get_multi results by position, so a missing node or a different dict order attaches event data to the wrong error id; it should look up events[node_id] per id."
|
| 170 |
+
},
|
| 171 |
+
{
|
| 172 |
+
"pr": 5,
|
| 173 |
+
"index": 3,
|
| 174 |
+
"methods": [
|
| 175 |
+
"static/app/views/dashboards/widgetCard/chart.tsx::WidgetCardChart.tableResultComponent"
|
| 176 |
+
],
|
| 177 |
+
"file": "static/app/views/dashboards/widgetCard/chart.tsx",
|
| 178 |
+
"line": 168,
|
| 179 |
+
"why": "When the use-table-widget-visualization flag is on, TableWidgetVisualization is rendered with columns={[]} and tableData data: [] and empty meta (lines 165-174) instead of result.data/result.meta, so the table is always empty."
|
| 180 |
+
},
|
| 181 |
+
{
|
| 182 |
+
"pr": 5,
|
| 183 |
+
"index": 4,
|
| 184 |
+
"methods": [
|
| 185 |
+
"src/sentry/issues/endpoints/browser_reporting_collector.py::BrowserReportSerializer.validate_age",
|
| 186 |
+
"src/sentry/issues/endpoints/browser_reporting_collector.py::BrowserReportSerializer.validate_timestamp"
|
| 187 |
+
],
|
| 188 |
+
"file": "src/sentry/issues/endpoints/browser_reporting_collector.py",
|
| 189 |
+
"line": 58,
|
| 190 |
+
"why": "validate_age checks self.initial_data.get('timestamp'), which is falsy for timestamp=0 (allowed by min_value=0), so age and timestamp=0 pass together; validate_timestamp has the same truthiness check on 'age' (line 52). Both should use `in self.initial_data`."
|
| 191 |
+
},
|
| 192 |
+
{
|
| 193 |
+
"pr": 5,
|
| 194 |
+
"index": 5,
|
| 195 |
+
"methods": [
|
| 196 |
+
"src/sentry/preprod/api/endpoints/organization_preprod_artifact_assemble.py::ProjectPreprodArtifactAssembleEndpoint.post"
|
| 197 |
+
],
|
| 198 |
+
"file": "src/sentry/preprod/api/endpoints/organization_preprod_artifact_assemble.py",
|
| 199 |
+
"line": 81,
|
| 200 |
+
"why": "analytics.record('preprod_artifact.api.assemble', ...) runs before the organizations:preprod-artifact-assemble feature check on line 88, so requests that get the 404 are still recorded."
|
| 201 |
+
},
|
| 202 |
+
{
|
| 203 |
+
"pr": 6,
|
| 204 |
+
"index": 0,
|
| 205 |
+
"methods": [
|
| 206 |
+
"src/sentry/spans/consumers/process/flusher.py::SpanFlusher.main"
|
| 207 |
+
],
|
| 208 |
+
"file": "src/sentry/spans/consumers/process/flusher.py",
|
| 209 |
+
"line": 199,
|
| 210 |
+
"why": "spans.buffer.flusher.wait_produce is tagged {'shards': shard_tag} while flusher.produce (line 185) and segment_size_bytes (line 195) use {'shard': shard_tag}."
|
| 211 |
+
},
|
| 212 |
+
{
|
| 213 |
+
"pr": 6,
|
| 214 |
+
"index": 1,
|
| 215 |
+
"methods": [],
|
| 216 |
+
"file": "tests/sentry/spans/consumers/process/test_consumer.py",
|
| 217 |
+
"line": 62,
|
| 218 |
+
"why": "In test_basic (test file not listed in methods_read), time.sleep is monkeypatched to a no-op on line 15, so time.sleep(0.1) on line 62 does not wait for the flusher."
|
| 219 |
+
},
|
| 220 |
+
{
|
| 221 |
+
"pr": 6,
|
| 222 |
+
"index": 2,
|
| 223 |
+
"methods": [
|
| 224 |
+
"src/sentry/spans/consumers/process/flusher.py::SpanFlusher._ensure_processes_alive"
|
| 225 |
+
],
|
| 226 |
+
"file": "src/sentry/spans/consumers/process/flusher.py",
|
| 227 |
+
"line": 254,
|
| 228 |
+
"why": "Processes come from mp_context = multiprocessing.get_context('spawn').Process, i.e. SpawnProcess, which is not a subclass of multiprocessing.Process, so isinstance(process, multiprocessing.Process) is False and hung processes are never killed before a new one is created."
|
| 229 |
+
},
|
| 230 |
+
{
|
| 231 |
+
"pr": 6,
|
| 232 |
+
"index": 3,
|
| 233 |
+
"methods": [],
|
| 234 |
+
"file": "tests/sentry/spans/consumers/process/test_consumer.py",
|
| 235 |
+
"line": 62,
|
| 236 |
+
"why": "Same as golden 1: test_basic's time.sleep(0.1) is a no-op because of the monkeypatch on line 15 (test file not listed in methods_read)."
|
| 237 |
+
},
|
| 238 |
+
{
|
| 239 |
+
"pr": 6,
|
| 240 |
+
"index": 4,
|
| 241 |
+
"methods": [
|
| 242 |
+
"src/sentry/spans/consumers/process/flusher.py::SpanFlusher.join"
|
| 243 |
+
],
|
| 244 |
+
"file": "src/sentry/spans/consumers/process/flusher.py",
|
| 245 |
+
"line": 341,
|
| 246 |
+
"why": "Once the deadline has passed, `break` exits the loop before the terminate() call on line 347, so the remaining flusher processes are never terminated."
|
| 247 |
+
},
|
| 248 |
+
{
|
| 249 |
+
"pr": 7,
|
| 250 |
+
"index": 0,
|
| 251 |
+
"methods": [
|
| 252 |
+
"src/sentry/integrations/services/assignment_source.py::<top-level>"
|
| 253 |
+
],
|
| 254 |
+
"file": "src/sentry/integrations/services/assignment_source.py",
|
| 255 |
+
"line": 18,
|
| 256 |
+
"why": "In the AssignmentSource class body, `queued: datetime = timezone.now()` is evaluated once at import, so every instance shares the module-load timestamp; it needs field(default_factory=timezone.now)."
|
| 257 |
+
},
|
| 258 |
+
{
|
| 259 |
+
"pr": 7,
|
| 260 |
+
"index": 1,
|
| 261 |
+
"methods": [],
|
| 262 |
+
"file": "tests/sentry/integrations/services/test_assignment_source.py",
|
| 263 |
+
"line": 13,
|
| 264 |
+
"why": "Test method name test_from_dict_inalid_data is misspelled (test file not listed in methods_read)."
|
| 265 |
+
},
|
| 266 |
+
{
|
| 267 |
+
"pr": 7,
|
| 268 |
+
"index": 2,
|
| 269 |
+
"methods": [],
|
| 270 |
+
"file": "tests/sentry/integrations/services/test_assignment_source.py",
|
| 271 |
+
"line": 8,
|
| 272 |
+
"why": "test_from_dict_empty_array passes an empty dict, so the name is misleading (test file not listed in methods_read)."
|
| 273 |
+
},
|
| 274 |
+
{
|
| 275 |
+
"pr": 7,
|
| 276 |
+
"index": 3,
|
| 277 |
+
"methods": [
|
| 278 |
+
"src/sentry/integrations/services/assignment_source.py::AssignmentSource.to_dict",
|
| 279 |
+
"src/sentry/integrations/utils/sync.py::sync_group_assignee_outbound"
|
| 280 |
+
],
|
| 281 |
+
"file": "src/sentry/integrations/services/assignment_source.py",
|
| 282 |
+
"line": 28,
|
| 283 |
+
"why": "to_dict returns asdict(self), which keeps queued as a datetime; sync_group_assignee_outbound puts that dict in apply_async kwargs (sync.py line 141), where a JSON task serializer cannot encode it."
|
| 284 |
+
},
|
| 285 |
+
{
|
| 286 |
+
"pr": 8,
|
| 287 |
+
"index": 0,
|
| 288 |
+
"methods": [
|
| 289 |
+
"src/sentry/monitors/logic/incident_occurrence.py::get_monitor_environment_context"
|
| 290 |
+
],
|
| 291 |
+
"file": "src/sentry/monitors/logic/incident_occurrence.py",
|
| 292 |
+
"line": 168,
|
| 293 |
+
"why": "config is copied and schedule_type replaced with its display value (lines 160-162), but the returned dict uses monitor_environment.monitor.config, discarding the modified copy."
|
| 294 |
+
},
|
| 295 |
+
{
|
| 296 |
+
"pr": 8,
|
| 297 |
+
"index": 1,
|
| 298 |
+
"methods": [
|
| 299 |
+
"src/sentry/monitors/logic/incidents.py::try_incident_threshold"
|
| 300 |
+
],
|
| 301 |
+
"file": "src/sentry/monitors/logic/incidents.py",
|
| 302 |
+
"line": 93,
|
| 303 |
+
"why": "MonitorCheckIn.objects.filter(id__in=[c['id'] for c in previous_checkins]) re-queries check-ins whose data is already in previous_checkins."
|
| 304 |
+
},
|
| 305 |
+
{
|
| 306 |
+
"pr": 9,
|
| 307 |
+
"index": 0,
|
| 308 |
+
"methods": [],
|
| 309 |
+
"file": "tests/sentry/uptime/consumers/test_results_consumer.py",
|
| 310 |
+
"line": 1718,
|
| 311 |
+
"why": "max_wait = 50 is a repeated literal in three thread-queue tests (lines 1718, 1765, 1812; other tests use 20); a style comment, located at the first occurrence."
|
| 312 |
+
},
|
| 313 |
+
{
|
| 314 |
+
"pr": 9,
|
| 315 |
+
"index": 1,
|
| 316 |
+
"methods": [],
|
| 317 |
+
"file": "tests/sentry/uptime/consumers/test_results_consumer.py",
|
| 318 |
+
"line": 1876,
|
| 319 |
+
"why": "The docstring says errors do not block offset commits for other messages, but the test asserts that nothing was committed for the partition (line 1922)."
|
| 320 |
+
},
|
| 321 |
+
{
|
| 322 |
+
"pr": 10,
|
| 323 |
+
"index": 0,
|
| 324 |
+
"methods": [
|
| 325 |
+
"src/sentry/incidents/grouptype.py::<top-level>"
|
| 326 |
+
],
|
| 327 |
+
"file": "src/sentry/incidents/grouptype.py",
|
| 328 |
+
"line": 11,
|
| 329 |
+
"why": "MetricAlertDetectorHandler subclasses StatefulDetectorHandler with only `pass`, leaving counter_names, get_dedupe_value, get_group_key_values and build_occurrence_and_event_data abstract, so instantiating it raises TypeError; class-body code, so the file's <top-level>."
|
| 330 |
+
},
|
| 331 |
+
{
|
| 332 |
+
"pr": 10,
|
| 333 |
+
"index": 1,
|
| 334 |
+
"methods": [
|
| 335 |
+
"src/sentry/workflow_engine/processors/detector.py::StatefulDetectorHandler.evaluate"
|
| 336 |
+
],
|
| 337 |
+
"file": "src/sentry/workflow_engine/processors/detector.py",
|
| 338 |
+
"line": 230,
|
| 339 |
+
"why": "The docstring still says evaluate returns a list of DetectorEvaluationResult, but it now returns a dict keyed by DetectorGroupKey."
|
| 340 |
+
},
|
| 341 |
+
{
|
| 342 |
+
"pr": 10,
|
| 343 |
+
"index": 2,
|
| 344 |
+
"methods": [],
|
| 345 |
+
"file": "tests/sentry/workflow_engine/processors/test_detector.py",
|
| 346 |
+
"line": 191,
|
| 347 |
+
"why": "The expected occurrence for group_2 is built with value 6, but the data packet on line 177 gives group_2 the value 10."
|
| 348 |
+
}
|
| 349 |
+
]
|
reviewbench/README.md
ADDED
|
@@ -0,0 +1,26 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# ReviewBench
|
| 2 |
+
|
| 3 |
+
Perch's runs on [ReviewBench](https://github.com/review-bench/ReviewBench), GitHub's benchmark for AI code review. The scripts that score these files are in [`.benchmarks/reviewbench`](https://github.com/lakeday-org/perch/tree/main/.benchmarks/reviewbench) in lakeday-org/perch. Its README describes both runs and how they are scored.
|
| 4 |
+
|
| 5 |
+
These files are scored by lakeday-org/perch at commit `6b33c162a778f56e27ae043f57f4d52cf30b9456`, from [lakeday-org/perch#421](https://github.com/lakeday-org/perch/pull/421). Download them into a perch checkout, where the scripts read them:
|
| 6 |
+
|
| 7 |
+
```sh
|
| 8 |
+
hf download perchscan/benchmark-results --repo-type dataset --include 'reviewbench/*' --local-dir .benchmarks/hf
|
| 9 |
+
```
|
| 10 |
+
|
| 11 |
+
| File | Contents |
|
| 12 |
+
|---|---|
|
| 13 |
+
| `targets.jsonl` | The 16,168 methods scored, each with its repository, commits, file, lines, split and labels |
|
| 14 |
+
| `requests.jsonl.gz` | The frozen run's requests, two readings of each method |
|
| 15 |
+
| `results/jev.jsonl.gz` | The frozen run's answers from Jev 1.14 |
|
| 16 |
+
| `results/luna.jsonl.gz` | The frozen run's answers from GPT-6 Luna Decisions |
|
| 17 |
+
| `judgments.jsonl` | Judgments of the alerts ReviewBench did not label, with quoted source |
|
| 18 |
+
| `coverage.jsonl` | How many methods were extracted from each file of all 219 pull requests |
|
| 19 |
+
| `manifest.json` | The ReviewBench and perch revisions used, and each file's SHA-256 hash |
|
| 20 |
+
| `summary.json` | The frozen run's scores, from `score.mjs` |
|
| 21 |
+
| `results/rerun-luna.jsonl.gz` | The rerun's answers, one line a pull request, from `perch scan --since` on GPT-6 Luna Decisions |
|
| 22 |
+
| `rerun-summary.json` | The rerun's scores, from `rerun-score.mjs` |
|
| 23 |
+
| `results/rerun-jev.jsonl.gz` | The same rerun on Jev (`jev-latest`), from the released perch 0.4.8 |
|
| 24 |
+
| `rerun-jev-summary.json` | The Jev rerun's scores, from `rerun-score.mjs --results` |
|
| 25 |
+
|
| 26 |
+
Source code quoted in these files is licensed according to its repository. ReviewBench is [MIT-licensed](https://github.com/review-bench/ReviewBench/blob/main/LICENSE).
|
reviewbench/coverage.jsonl
ADDED
|
The diff for this file is too large to render.
See raw diff
|
|
|
reviewbench/judgments.jsonl
ADDED
|
The diff for this file is too large to render.
See raw diff
|
|
|
reviewbench/manifest.json
ADDED
|
@@ -0,0 +1,59 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
{
|
| 2 |
+
"schema_version": 1,
|
| 3 |
+
"benchmark": "ReviewBench",
|
| 4 |
+
"upstream": "https://github.com/review-bench/ReviewBench",
|
| 5 |
+
"upstream_revision": "c17b05be9c90b85a1fc012ce39e455e2d09a7255",
|
| 6 |
+
"perch_revision": "67575f846d2b0c1d912fea8e0f0e9ba8941c4a24",
|
| 7 |
+
"selected_prs": 219,
|
| 8 |
+
"prs_with_targets": 177,
|
| 9 |
+
"targets": 16168,
|
| 10 |
+
"positive_targets": 1506,
|
| 11 |
+
"failure_policy": "A failed target is a miss if positive and a false alert if clean. Missing requests are incomplete coverage, never scored as clean.",
|
| 12 |
+
"thresholds": {
|
| 13 |
+
"functional": "strictly greater than 0.60",
|
| 14 |
+
"security": "strictly greater than 0.70"
|
| 15 |
+
},
|
| 16 |
+
"models": {
|
| 17 |
+
"jev": "jev-1.14.0",
|
| 18 |
+
"luna": "gpt-6-luna"
|
| 19 |
+
},
|
| 20 |
+
"input_prices_per_million": {
|
| 21 |
+
"jev": 0.042,
|
| 22 |
+
"luna": 0.1
|
| 23 |
+
},
|
| 24 |
+
"sha256": {
|
| 25 |
+
"targets.jsonl": "476f46f98e1ca72e8e17e8b65e1867d7a45b94140b72b1d7489c348634164adf",
|
| 26 |
+
"requests.jsonl.gz": "bb38d8ec68c16004e04a46ff489d072bc5bb036cfc795d53ae5271c34328a05e",
|
| 27 |
+
"judgments.jsonl": "09add93765a34161597e981da463d30c8998f0e7497a697e38ecd8f8a11be5db",
|
| 28 |
+
"coverage.jsonl": "a8a33d5fc42d6b5cd4805bcad8091b06153e7ac8d6101e667a472bec3bf530b0",
|
| 29 |
+
"results/jev.jsonl.gz": "f946f88bdf850f165b0541ca9247c3d3f1a856bcf8666bd20de455709d0d66d7",
|
| 30 |
+
"results/luna.jsonl.gz": "219d746feaaa2b58ac8a7750913542f9f017123dcaf97e19463ed18252a2bcd7"
|
| 31 |
+
},
|
| 32 |
+
"protocol": {
|
| 33 |
+
"readings": [
|
| 34 |
+
"change_current",
|
| 35 |
+
"relation"
|
| 36 |
+
],
|
| 37 |
+
"selection": "The same fixed two-reading protocol for both providers."
|
| 38 |
+
},
|
| 39 |
+
"readings_per_model": 30936,
|
| 40 |
+
"planned_api_calls_per_model": 30945,
|
| 41 |
+
"completed_at": "2026-10-15T21:03:15.289Z",
|
| 42 |
+
"graph_revision": "eaf1cc93313cc3329b06e551f0b42922fc7a5f65",
|
| 43 |
+
"runs": {
|
| 44 |
+
"jev": {
|
| 45 |
+
"readings": 30936,
|
| 46 |
+
"api_calls_attempted": 30945,
|
| 47 |
+
"failed_readings": 0,
|
| 48 |
+
"failed_targets": 0
|
| 49 |
+
},
|
| 50 |
+
"luna": {
|
| 51 |
+
"readings": 30936,
|
| 52 |
+
"api_calls_attempted": 30945,
|
| 53 |
+
"failed_readings": 1,
|
| 54 |
+
"failed_targets": 1
|
| 55 |
+
}
|
| 56 |
+
},
|
| 57 |
+
"target_scope": "method",
|
| 58 |
+
"prs_without_methods": 42
|
| 59 |
+
}
|
reviewbench/requests.jsonl.gz
ADDED
|
@@ -0,0 +1,3 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
version https://git-lfs.github.com/spec/v1
|
| 2 |
+
oid sha256:bb38d8ec68c16004e04a46ff489d072bc5bb036cfc795d53ae5271c34328a05e
|
| 3 |
+
size 12270547
|
reviewbench/rerun-jev-summary.json
ADDED
|
@@ -0,0 +1,236 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
{
|
| 2 |
+
"targets": 16168,
|
| 3 |
+
"buggy": 1506,
|
| 4 |
+
"buggy_reference": 861,
|
| 5 |
+
"prs": 177,
|
| 6 |
+
"scanned_prs": 171,
|
| 7 |
+
"failed": [
|
| 8 |
+
{
|
| 9 |
+
"pr": "hughdidit_DAISy-Agency_274-1c88a238",
|
| 10 |
+
"code": "checkout",
|
| 11 |
+
"error": "Command failed: git clone -q --filter=blob:none --no-checkout https://github.com/hughdidit/DAISy-Agency.git /Users/jfbrown/code/perch-research/.claude/worktrees/greptile-bench/reviewbench/repos/hughdidit__DAISy-Agency"
|
| 12 |
+
},
|
| 13 |
+
{
|
| 14 |
+
"pr": "Nixbug_entebus-android-operator_67-21b50bbb",
|
| 15 |
+
"code": "checkout",
|
| 16 |
+
"error": "Command failed: git clone -q --filter=blob:none --no-checkout https://github.com/Nixbug/entebus-android-operator.git /Users/jfbrown/code/perch-research/.claude/worktrees/greptile-bench/reviewbench/repos/Nixbug__entebus-android-operator"
|
| 17 |
+
},
|
| 18 |
+
{
|
| 19 |
+
"pr": "hughdidit_DAISy-Agency_309-ac6e2196",
|
| 20 |
+
"code": "checkout",
|
| 21 |
+
"error": "Command failed: git clone -q --filter=blob:none --no-checkout https://github.com/hughdidit/DAISy-Agency.git /Users/jfbrown/code/perch-research/.claude/worktrees/greptile-bench/reviewbench/repos/hughdidit__DAISy-Agency"
|
| 22 |
+
},
|
| 23 |
+
{
|
| 24 |
+
"pr": "RobertAgterhuis_myAgentic-IT-Project-team-V2_331-980b84fa",
|
| 25 |
+
"code": "checkout",
|
| 26 |
+
"error": "Command failed: git clone -q --filter=blob:none --no-checkout https://github.com/RobertAgterhuis/myAgentic-IT-Project-team-V2.git /Users/jfbrown/code/perch-research/.claude/worktrees/greptile-bench/reviewbench/repos/RobertAgterhuis__myAgentic-IT-Project-team-V2"
|
| 27 |
+
},
|
| 28 |
+
{
|
| 29 |
+
"pr": "anokye-labs_kbexplorer_38-cf24fe27",
|
| 30 |
+
"code": "checkout",
|
| 31 |
+
"error": "base 84bf940b71ac021cbe2afa4b1f445959774c4d63 not fetchable"
|
| 32 |
+
},
|
| 33 |
+
{
|
| 34 |
+
"pr": "whispr-messenger_mobile-app_64-9e7742e5",
|
| 35 |
+
"code": "checkout",
|
| 36 |
+
"error": "Command failed: git clone -q --filter=blob:none --no-checkout https://github.com/whispr-messenger/mobile-app.git /Users/jfbrown/code/perch-research/.claude/worktrees/greptile-bench/reviewbench/repos/whispr-messenger__mobile-app"
|
| 37 |
+
}
|
| 38 |
+
],
|
| 39 |
+
"readings": 17250,
|
| 40 |
+
"targets_read": 12955,
|
| 41 |
+
"unread_buggy": {
|
| 42 |
+
"in_failed_prs": 80,
|
| 43 |
+
"in_unparsed_files": 1,
|
| 44 |
+
"in_unread_functions": 292
|
| 45 |
+
},
|
| 46 |
+
"usage": {
|
| 47 |
+
"jev-1.14.0": {
|
| 48 |
+
"requests": 17369,
|
| 49 |
+
"input": 42814227,
|
| 50 |
+
"output": 2555058,
|
| 51 |
+
"cost": 1.798197534
|
| 52 |
+
}
|
| 53 |
+
},
|
| 54 |
+
"cost_usd": 1.798197534,
|
| 55 |
+
"cutoffs": [
|
| 56 |
+
{
|
| 57 |
+
"cutoff": 0.6,
|
| 58 |
+
"total": {
|
| 59 |
+
"targets": 16168,
|
| 60 |
+
"buggy": 1506,
|
| 61 |
+
"flagged": 260,
|
| 62 |
+
"flag_rate": 0.016081147946561108,
|
| 63 |
+
"precision": 0.4576923076923077,
|
| 64 |
+
"recall": 0.07901726427622842,
|
| 65 |
+
"f1": 0.1347678369195923,
|
| 66 |
+
"correct": 119,
|
| 67 |
+
"false": 141,
|
| 68 |
+
"missed": 1387
|
| 69 |
+
},
|
| 70 |
+
"development": {
|
| 71 |
+
"targets": 10326,
|
| 72 |
+
"buggy": 944,
|
| 73 |
+
"flagged": 207,
|
| 74 |
+
"flag_rate": 0.020046484601975594,
|
| 75 |
+
"precision": 0.47342995169082125,
|
| 76 |
+
"recall": 0.1038135593220339,
|
| 77 |
+
"f1": 0.17028670721112077,
|
| 78 |
+
"correct": 98,
|
| 79 |
+
"false": 109,
|
| 80 |
+
"missed": 846
|
| 81 |
+
},
|
| 82 |
+
"validation": {
|
| 83 |
+
"targets": 5842,
|
| 84 |
+
"buggy": 562,
|
| 85 |
+
"flagged": 53,
|
| 86 |
+
"flag_rate": 0.00907223553577542,
|
| 87 |
+
"precision": 0.39622641509433965,
|
| 88 |
+
"recall": 0.037366548042704624,
|
| 89 |
+
"f1": 0.06829268292682927,
|
| 90 |
+
"correct": 21,
|
| 91 |
+
"false": 32,
|
| 92 |
+
"missed": 541
|
| 93 |
+
},
|
| 94 |
+
"reference_only": {
|
| 95 |
+
"targets": 16168,
|
| 96 |
+
"buggy": 861,
|
| 97 |
+
"flagged": 260,
|
| 98 |
+
"flag_rate": 0.016081147946561108,
|
| 99 |
+
"precision": 0.3038461538461538,
|
| 100 |
+
"recall": 0.09175377468060394,
|
| 101 |
+
"f1": 0.1409455842997324,
|
| 102 |
+
"correct": 79,
|
| 103 |
+
"false": 181,
|
| 104 |
+
"missed": 782
|
| 105 |
+
}
|
| 106 |
+
},
|
| 107 |
+
{
|
| 108 |
+
"cutoff": 0.7,
|
| 109 |
+
"total": {
|
| 110 |
+
"targets": 16168,
|
| 111 |
+
"buggy": 1506,
|
| 112 |
+
"flagged": 81,
|
| 113 |
+
"flag_rate": 0.0050098960910440376,
|
| 114 |
+
"precision": 0.5061728395061729,
|
| 115 |
+
"recall": 0.027224435590969456,
|
| 116 |
+
"f1": 0.0516698172652804,
|
| 117 |
+
"correct": 41,
|
| 118 |
+
"false": 40,
|
| 119 |
+
"missed": 1465
|
| 120 |
+
},
|
| 121 |
+
"development": {
|
| 122 |
+
"targets": 10326,
|
| 123 |
+
"buggy": 944,
|
| 124 |
+
"flagged": 68,
|
| 125 |
+
"flag_rate": 0.0065853186132093745,
|
| 126 |
+
"precision": 0.5441176470588235,
|
| 127 |
+
"recall": 0.03919491525423729,
|
| 128 |
+
"f1": 0.07312252964426877,
|
| 129 |
+
"correct": 37,
|
| 130 |
+
"false": 31,
|
| 131 |
+
"missed": 907
|
| 132 |
+
},
|
| 133 |
+
"validation": {
|
| 134 |
+
"targets": 5842,
|
| 135 |
+
"buggy": 562,
|
| 136 |
+
"flagged": 13,
|
| 137 |
+
"flag_rate": 0.0022252653200958575,
|
| 138 |
+
"precision": 0.3076923076923077,
|
| 139 |
+
"recall": 0.0071174377224199285,
|
| 140 |
+
"f1": 0.01391304347826087,
|
| 141 |
+
"correct": 4,
|
| 142 |
+
"false": 9,
|
| 143 |
+
"missed": 558
|
| 144 |
+
},
|
| 145 |
+
"reference_only": {
|
| 146 |
+
"targets": 16168,
|
| 147 |
+
"buggy": 861,
|
| 148 |
+
"flagged": 81,
|
| 149 |
+
"flag_rate": 0.0050098960910440376,
|
| 150 |
+
"precision": 0.3333333333333333,
|
| 151 |
+
"recall": 0.0313588850174216,
|
| 152 |
+
"f1": 0.05732484076433121,
|
| 153 |
+
"correct": 27,
|
| 154 |
+
"false": 54,
|
| 155 |
+
"missed": 834
|
| 156 |
+
}
|
| 157 |
+
},
|
| 158 |
+
{
|
| 159 |
+
"cutoff": 0.8,
|
| 160 |
+
"total": {
|
| 161 |
+
"targets": 16168,
|
| 162 |
+
"buggy": 1506,
|
| 163 |
+
"flagged": 7,
|
| 164 |
+
"flag_rate": 0.0004329539831766452,
|
| 165 |
+
"precision": 0.8571428571428571,
|
| 166 |
+
"recall": 0.00398406374501992,
|
| 167 |
+
"f1": 0.007931262392597489,
|
| 168 |
+
"correct": 6,
|
| 169 |
+
"false": 1,
|
| 170 |
+
"missed": 1500
|
| 171 |
+
},
|
| 172 |
+
"development": {
|
| 173 |
+
"targets": 10326,
|
| 174 |
+
"buggy": 944,
|
| 175 |
+
"flagged": 5,
|
| 176 |
+
"flag_rate": 0.000484214603912454,
|
| 177 |
+
"precision": 1,
|
| 178 |
+
"recall": 0.005296610169491525,
|
| 179 |
+
"f1": 0.01053740779768177,
|
| 180 |
+
"correct": 5,
|
| 181 |
+
"false": 0,
|
| 182 |
+
"missed": 939
|
| 183 |
+
},
|
| 184 |
+
"validation": {
|
| 185 |
+
"targets": 5842,
|
| 186 |
+
"buggy": 562,
|
| 187 |
+
"flagged": 2,
|
| 188 |
+
"flag_rate": 0.00034234851078397807,
|
| 189 |
+
"precision": 0.5,
|
| 190 |
+
"recall": 0.0017793594306049821,
|
| 191 |
+
"f1": 0.0035460992907801418,
|
| 192 |
+
"correct": 1,
|
| 193 |
+
"false": 1,
|
| 194 |
+
"missed": 561
|
| 195 |
+
},
|
| 196 |
+
"reference_only": {
|
| 197 |
+
"targets": 16168,
|
| 198 |
+
"buggy": 861,
|
| 199 |
+
"flagged": 7,
|
| 200 |
+
"flag_rate": 0.0004329539831766452,
|
| 201 |
+
"precision": 0.5714285714285714,
|
| 202 |
+
"recall": 0.004645760743321719,
|
| 203 |
+
"f1": 0.009216589861751152,
|
| 204 |
+
"correct": 4,
|
| 205 |
+
"false": 3,
|
| 206 |
+
"missed": 857
|
| 207 |
+
}
|
| 208 |
+
}
|
| 209 |
+
],
|
| 210 |
+
"frozen_reference_only": {
|
| 211 |
+
"jev": {
|
| 212 |
+
"targets": 16168,
|
| 213 |
+
"buggy": 861,
|
| 214 |
+
"flagged": 876,
|
| 215 |
+
"flag_rate": 0.05418109846610589,
|
| 216 |
+
"precision": 0.1780821917808219,
|
| 217 |
+
"recall": 0.18118466898954705,
|
| 218 |
+
"f1": 0.17962003454231434,
|
| 219 |
+
"correct": 156,
|
| 220 |
+
"false": 720,
|
| 221 |
+
"missed": 705
|
| 222 |
+
},
|
| 223 |
+
"luna": {
|
| 224 |
+
"targets": 16168,
|
| 225 |
+
"buggy": 861,
|
| 226 |
+
"flagged": 5635,
|
| 227 |
+
"flag_rate": 0.3485279564571994,
|
| 228 |
+
"precision": 0.10629991126885537,
|
| 229 |
+
"recall": 0.6957026713124274,
|
| 230 |
+
"f1": 0.18442118226600984,
|
| 231 |
+
"correct": 599,
|
| 232 |
+
"false": 5036,
|
| 233 |
+
"missed": 262
|
| 234 |
+
}
|
| 235 |
+
}
|
| 236 |
+
}
|
reviewbench/rerun-summary.json
ADDED
|
@@ -0,0 +1,236 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
{
|
| 2 |
+
"targets": 16168,
|
| 3 |
+
"buggy": 1506,
|
| 4 |
+
"buggy_reference": 861,
|
| 5 |
+
"prs": 177,
|
| 6 |
+
"scanned_prs": 171,
|
| 7 |
+
"failed": [
|
| 8 |
+
{
|
| 9 |
+
"pr": "hughdidit_DAISy-Agency_274-1c88a238",
|
| 10 |
+
"code": "checkout",
|
| 11 |
+
"error": "clone of https://github.com/hughdidit/DAISy-Agency failed"
|
| 12 |
+
},
|
| 13 |
+
{
|
| 14 |
+
"pr": "Nixbug_entebus-android-operator_67-21b50bbb",
|
| 15 |
+
"code": "checkout",
|
| 16 |
+
"error": "clone of https://github.com/Nixbug/entebus-android-operator failed"
|
| 17 |
+
},
|
| 18 |
+
{
|
| 19 |
+
"pr": "hughdidit_DAISy-Agency_309-ac6e2196",
|
| 20 |
+
"code": "checkout",
|
| 21 |
+
"error": "clone of https://github.com/hughdidit/DAISy-Agency failed"
|
| 22 |
+
},
|
| 23 |
+
{
|
| 24 |
+
"pr": "RobertAgterhuis_myAgentic-IT-Project-team-V2_331-980b84fa",
|
| 25 |
+
"code": "checkout",
|
| 26 |
+
"error": "clone of https://github.com/RobertAgterhuis/myAgentic-IT-Project-team-V2 failed"
|
| 27 |
+
},
|
| 28 |
+
{
|
| 29 |
+
"pr": "anokye-labs_kbexplorer_38-cf24fe27",
|
| 30 |
+
"code": "checkout",
|
| 31 |
+
"error": "base 84bf940b71ac021cbe2afa4b1f445959774c4d63 not fetchable"
|
| 32 |
+
},
|
| 33 |
+
{
|
| 34 |
+
"pr": "whispr-messenger_mobile-app_64-9e7742e5",
|
| 35 |
+
"code": "checkout",
|
| 36 |
+
"error": "clone of https://github.com/whispr-messenger/mobile-app failed"
|
| 37 |
+
}
|
| 38 |
+
],
|
| 39 |
+
"readings": 17250,
|
| 40 |
+
"targets_read": 12955,
|
| 41 |
+
"unread_buggy": {
|
| 42 |
+
"in_failed_prs": 80,
|
| 43 |
+
"in_unparsed_files": 1,
|
| 44 |
+
"in_unread_functions": 292
|
| 45 |
+
},
|
| 46 |
+
"usage": {
|
| 47 |
+
"gpt-6-luna": {
|
| 48 |
+
"requests": 17369,
|
| 49 |
+
"input": 41569033,
|
| 50 |
+
"output": 0,
|
| 51 |
+
"cost": 4.1569033
|
| 52 |
+
}
|
| 53 |
+
},
|
| 54 |
+
"cost_usd": 4.1569033,
|
| 55 |
+
"cutoffs": [
|
| 56 |
+
{
|
| 57 |
+
"cutoff": 0.6,
|
| 58 |
+
"total": {
|
| 59 |
+
"targets": 16168,
|
| 60 |
+
"buggy": 1506,
|
| 61 |
+
"flagged": 2094,
|
| 62 |
+
"flag_rate": 0.12951509153884216,
|
| 63 |
+
"precision": 0.28796561604584525,
|
| 64 |
+
"recall": 0.40039840637450197,
|
| 65 |
+
"f1": 0.335,
|
| 66 |
+
"correct": 603,
|
| 67 |
+
"false": 1491,
|
| 68 |
+
"missed": 903
|
| 69 |
+
},
|
| 70 |
+
"development": {
|
| 71 |
+
"targets": 10326,
|
| 72 |
+
"buggy": 944,
|
| 73 |
+
"flagged": 1558,
|
| 74 |
+
"flag_rate": 0.15088127057912068,
|
| 75 |
+
"precision": 0.2920410783055199,
|
| 76 |
+
"recall": 0.4819915254237288,
|
| 77 |
+
"f1": 0.36370903277378097,
|
| 78 |
+
"correct": 455,
|
| 79 |
+
"false": 1103,
|
| 80 |
+
"missed": 489
|
| 81 |
+
},
|
| 82 |
+
"validation": {
|
| 83 |
+
"targets": 5842,
|
| 84 |
+
"buggy": 562,
|
| 85 |
+
"flagged": 536,
|
| 86 |
+
"flag_rate": 0.09174940089010612,
|
| 87 |
+
"precision": 0.27611940298507465,
|
| 88 |
+
"recall": 0.26334519572953735,
|
| 89 |
+
"f1": 0.26958105646630237,
|
| 90 |
+
"correct": 148,
|
| 91 |
+
"false": 388,
|
| 92 |
+
"missed": 414
|
| 93 |
+
},
|
| 94 |
+
"reference_only": {
|
| 95 |
+
"targets": 16168,
|
| 96 |
+
"buggy": 861,
|
| 97 |
+
"flagged": 2094,
|
| 98 |
+
"flag_rate": 0.12951509153884216,
|
| 99 |
+
"precision": 0.20152817574021012,
|
| 100 |
+
"recall": 0.4901277584204414,
|
| 101 |
+
"f1": 0.2856175972927242,
|
| 102 |
+
"correct": 422,
|
| 103 |
+
"false": 1672,
|
| 104 |
+
"missed": 439
|
| 105 |
+
}
|
| 106 |
+
},
|
| 107 |
+
{
|
| 108 |
+
"cutoff": 0.7,
|
| 109 |
+
"total": {
|
| 110 |
+
"targets": 16168,
|
| 111 |
+
"buggy": 1506,
|
| 112 |
+
"flagged": 1364,
|
| 113 |
+
"flag_rate": 0.08436417615042058,
|
| 114 |
+
"precision": 0.3519061583577713,
|
| 115 |
+
"recall": 0.3187250996015936,
|
| 116 |
+
"f1": 0.3344947735191638,
|
| 117 |
+
"correct": 480,
|
| 118 |
+
"false": 884,
|
| 119 |
+
"missed": 1026
|
| 120 |
+
},
|
| 121 |
+
"development": {
|
| 122 |
+
"targets": 10326,
|
| 123 |
+
"buggy": 944,
|
| 124 |
+
"flagged": 1007,
|
| 125 |
+
"flag_rate": 0.09752082122796824,
|
| 126 |
+
"precision": 0.3624627606752731,
|
| 127 |
+
"recall": 0.3866525423728814,
|
| 128 |
+
"f1": 0.3741670937980523,
|
| 129 |
+
"correct": 365,
|
| 130 |
+
"false": 642,
|
| 131 |
+
"missed": 579
|
| 132 |
+
},
|
| 133 |
+
"validation": {
|
| 134 |
+
"targets": 5842,
|
| 135 |
+
"buggy": 562,
|
| 136 |
+
"flagged": 357,
|
| 137 |
+
"flag_rate": 0.06110920917494009,
|
| 138 |
+
"precision": 0.32212885154061627,
|
| 139 |
+
"recall": 0.20462633451957296,
|
| 140 |
+
"f1": 0.250272034820457,
|
| 141 |
+
"correct": 115,
|
| 142 |
+
"false": 242,
|
| 143 |
+
"missed": 447
|
| 144 |
+
},
|
| 145 |
+
"reference_only": {
|
| 146 |
+
"targets": 16168,
|
| 147 |
+
"buggy": 861,
|
| 148 |
+
"flagged": 1364,
|
| 149 |
+
"flag_rate": 0.08436417615042058,
|
| 150 |
+
"precision": 0.25,
|
| 151 |
+
"recall": 0.39605110336817656,
|
| 152 |
+
"f1": 0.30651685393258427,
|
| 153 |
+
"correct": 341,
|
| 154 |
+
"false": 1023,
|
| 155 |
+
"missed": 520
|
| 156 |
+
}
|
| 157 |
+
},
|
| 158 |
+
{
|
| 159 |
+
"cutoff": 0.8,
|
| 160 |
+
"total": {
|
| 161 |
+
"targets": 16168,
|
| 162 |
+
"buggy": 1506,
|
| 163 |
+
"flagged": 836,
|
| 164 |
+
"flag_rate": 0.051707075705096486,
|
| 165 |
+
"precision": 0.41746411483253587,
|
| 166 |
+
"recall": 0.23173970783532535,
|
| 167 |
+
"f1": 0.29803586678052946,
|
| 168 |
+
"correct": 349,
|
| 169 |
+
"false": 487,
|
| 170 |
+
"missed": 1157
|
| 171 |
+
},
|
| 172 |
+
"development": {
|
| 173 |
+
"targets": 10326,
|
| 174 |
+
"buggy": 944,
|
| 175 |
+
"flagged": 611,
|
| 176 |
+
"flag_rate": 0.059171024598101876,
|
| 177 |
+
"precision": 0.4402618657937807,
|
| 178 |
+
"recall": 0.2849576271186441,
|
| 179 |
+
"f1": 0.3459807073954984,
|
| 180 |
+
"correct": 269,
|
| 181 |
+
"false": 342,
|
| 182 |
+
"missed": 675
|
| 183 |
+
},
|
| 184 |
+
"validation": {
|
| 185 |
+
"targets": 5842,
|
| 186 |
+
"buggy": 562,
|
| 187 |
+
"flagged": 225,
|
| 188 |
+
"flag_rate": 0.03851420746319754,
|
| 189 |
+
"precision": 0.35555555555555557,
|
| 190 |
+
"recall": 0.1423487544483986,
|
| 191 |
+
"f1": 0.20330368487928843,
|
| 192 |
+
"correct": 80,
|
| 193 |
+
"false": 145,
|
| 194 |
+
"missed": 482
|
| 195 |
+
},
|
| 196 |
+
"reference_only": {
|
| 197 |
+
"targets": 16168,
|
| 198 |
+
"buggy": 861,
|
| 199 |
+
"flagged": 836,
|
| 200 |
+
"flag_rate": 0.051707075705096486,
|
| 201 |
+
"precision": 0.30023923444976075,
|
| 202 |
+
"recall": 0.29152148664343785,
|
| 203 |
+
"f1": 0.2958161461402475,
|
| 204 |
+
"correct": 251,
|
| 205 |
+
"false": 585,
|
| 206 |
+
"missed": 610
|
| 207 |
+
}
|
| 208 |
+
}
|
| 209 |
+
],
|
| 210 |
+
"frozen_reference_only": {
|
| 211 |
+
"jev": {
|
| 212 |
+
"targets": 16168,
|
| 213 |
+
"buggy": 861,
|
| 214 |
+
"flagged": 876,
|
| 215 |
+
"flag_rate": 0.05418109846610589,
|
| 216 |
+
"precision": 0.1780821917808219,
|
| 217 |
+
"recall": 0.18118466898954705,
|
| 218 |
+
"f1": 0.17962003454231434,
|
| 219 |
+
"correct": 156,
|
| 220 |
+
"false": 720,
|
| 221 |
+
"missed": 705
|
| 222 |
+
},
|
| 223 |
+
"luna": {
|
| 224 |
+
"targets": 16168,
|
| 225 |
+
"buggy": 861,
|
| 226 |
+
"flagged": 5635,
|
| 227 |
+
"flag_rate": 0.3485279564571994,
|
| 228 |
+
"precision": 0.10629991126885537,
|
| 229 |
+
"recall": 0.6957026713124274,
|
| 230 |
+
"f1": 0.18442118226600984,
|
| 231 |
+
"correct": 599,
|
| 232 |
+
"false": 5036,
|
| 233 |
+
"missed": 262
|
| 234 |
+
}
|
| 235 |
+
}
|
| 236 |
+
}
|
reviewbench/results/jev.jsonl.gz
ADDED
|
@@ -0,0 +1,3 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
version https://git-lfs.github.com/spec/v1
|
| 2 |
+
oid sha256:f946f88bdf850f165b0541ca9247c3d3f1a856bcf8666bd20de455709d0d66d7
|
| 3 |
+
size 997667
|
reviewbench/results/luna.jsonl.gz
ADDED
|
@@ -0,0 +1,3 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
version https://git-lfs.github.com/spec/v1
|
| 2 |
+
oid sha256:219d746feaaa2b58ac8a7750913542f9f017123dcaf97e19463ed18252a2bcd7
|
| 3 |
+
size 927113
|
reviewbench/results/rerun-jev.jsonl.gz
ADDED
|
@@ -0,0 +1,3 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
version https://git-lfs.github.com/spec/v1
|
| 2 |
+
oid sha256:781ed9caee71fef17f0b97bc1df2ec2837aeb1789fb6da9f1f457bbf7d4919ae
|
| 3 |
+
size 553573
|
reviewbench/results/rerun-luna.jsonl.gz
ADDED
|
@@ -0,0 +1,3 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
version https://git-lfs.github.com/spec/v1
|
| 2 |
+
oid sha256:95f88bdd28969acfdd13f9a33333025a5c351877955fa0e8f1251d0ea76eb92a
|
| 3 |
+
size 543282
|
reviewbench/summary.json
ADDED
|
@@ -0,0 +1,28 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
[
|
| 2 |
+
{
|
| 3 |
+
"provider": "jev",
|
| 4 |
+
"targets": 16168,
|
| 5 |
+
"tp": 304,
|
| 6 |
+
"fp": 572,
|
| 7 |
+
"fn": 1202,
|
| 8 |
+
"tn": 14090,
|
| 9 |
+
"precision": 0.3470319634703196,
|
| 10 |
+
"recall": 0.20185922974767595,
|
| 11 |
+
"f1": 0.25524769101595296,
|
| 12 |
+
"failed_targets": 0,
|
| 13 |
+
"cost_usd": 2.928322194000014
|
| 14 |
+
},
|
| 15 |
+
{
|
| 16 |
+
"provider": "luna",
|
| 17 |
+
"targets": 16168,
|
| 18 |
+
"tp": 1221,
|
| 19 |
+
"fp": 4414,
|
| 20 |
+
"fn": 285,
|
| 21 |
+
"tn": 10248,
|
| 22 |
+
"precision": 0.21668145519077195,
|
| 23 |
+
"recall": 0.8107569721115537,
|
| 24 |
+
"f1": 0.34196891191709844,
|
| 25 |
+
"failed_targets": 1,
|
| 26 |
+
"cost_usd": 5.636321799999951
|
| 27 |
+
}
|
| 28 |
+
]
|
reviewbench/targets.jsonl
ADDED
|
The diff for this file is too large to render.
See raw diff
|
|
|