diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/signup/product_helper.rb b/lib/signup/product_helper.rb index abc1234..def5678 100644 --- a/lib/signup/product_helper.rb +++ b/lib/signup/product_helper.rb @@ -1,4 +1,13 @@ module ProductHelper + + def products + [ + :supporter, + :member, + :sponsor, + :partner + ] + end ...
Add product list to helper
diff --git a/lib/signup/product_helper.rb b/lib/signup/product_helper.rb index abc1234..def5678 100644 --- a/lib/signup/product_helper.rb +++ b/lib/signup/product_helper.rb @@ -1,4 +1,13 @@ module ProductHelper + + def products + [ + :supporter, + :member, + :sponsor, + :partner + ] + end ...
Add product list to helper
diff --git a/lib/active_null.rb b/lib/active_null.rb index abc1234..def5678 100644 --- a/lib/active_null.rb +++ b/lib/active_null.rb @@ -17,6 +17,7 @@ def null_model(method_name=nil, &block) @null_model_overrides = if block_given? Module.new.tap { |m| m.module_eval(&block) } + end if method_name...
Fix missing end from @iachettifederico
diff --git a/lib/lita/common.rb b/lib/lita/common.rb index abc1234..def5678 100644 --- a/lib/lita/common.rb +++ b/lib/lita/common.rb @@ -10,5 +10,5 @@ end end -I18n.load_path << Dir[File.join(Lita.template_root, "locales", "*.yml")] +I18n.load_path += Dir[File.join(Lita.template_root, "locales", "*.yml")] I18n.en...
Concatenate I18n.load_path instead of shoveling.
diff --git a/Casks/cyberduck.rb b/Casks/cyberduck.rb index abc1234..def5678 100644 --- a/Casks/cyberduck.rb +++ b/Casks/cyberduck.rb @@ -0,0 +1,5 @@+class Cyberduck < Cask + url 'http://cyberduck.ch/Cyberduck-4.2.1.zip' + homepage 'http://cyberduck.ch' + version '4.2.1' +end
Add Cyberduck - Libre FTP, SFTP, WebDAV & cloud storage browser for Mac & Windows.
diff --git a/Casks/launchbar.rb b/Casks/launchbar.rb index abc1234..def5678 100644 --- a/Casks/launchbar.rb +++ b/Casks/launchbar.rb @@ -5,8 +5,8 @@ sha256 '22a1ec0c10de940e5efbcccd18b8b048d95fb7c63213a01c7976a76d6be69a4d' url "http://www.obdev.at/downloads/launchbar/legacy/LaunchBar-#{version}.dmg" else - ...
Update Launchbar to version 6.4 This commit updates the version stanza and the SHA
diff --git a/lib/random_yiff.rb b/lib/random_yiff.rb index abc1234..def5678 100644 --- a/lib/random_yiff.rb +++ b/lib/random_yiff.rb @@ -31,5 +31,4 @@ def method_missing(m) post["#{m}"] || super end - end
Remove empty line at end of RandomYiff
diff --git a/business_time.gemspec b/business_time.gemspec index abc1234..def5678 100644 --- a/business_time.gemspec +++ b/business_time.gemspec @@ -13,7 +13,7 @@ s.files = `git ls-files -- {lib,rails_generators,LICENSE,README.rdoc}`.split("\n") - s.add_dependency('activesupport','~> 3.0.11') + s.add_dependen...
Add more precise activesupport version
diff --git a/test/lib/generators/slim/mailer_generator_test.rb b/test/lib/generators/slim/mailer_generator_test.rb index abc1234..def5678 100644 --- a/test/lib/generators/slim/mailer_generator_test.rb +++ b/test/lib/generators/slim/mailer_generator_test.rb @@ -11,14 +11,37 @@ test "should invoke template engine" do...
Add assertions for rails4.2 in MailerGeneratorTest I am basically copying tests from `indirect/haml-rails`, and changing to slim where necessary.
diff --git a/core/app/controllers/application_controller.rb b/core/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/core/app/controllers/application_controller.rb +++ b/core/app/controllers/application_controller.rb @@ -15,12 +15,7 @@ end def after_sign_in_path_for(resource) - - i...
Return path is not used anymore
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -13,6 +13,7 @@ module ContentTagger class Application < Rails::Application config.active_record.raise_in_transactional_callbacks = true + config.autoload_paths +...
Add lib to autoload paths
diff --git a/config/environment.rb b/config/environment.rb index abc1234..def5678 100644 --- a/config/environment.rb +++ b/config/environment.rb @@ -9,6 +9,7 @@ config.action_controller.session = { :key => "_mockr_session", :secret => "my cat is yellow" } + config.action_controller.asset_host = "http://#{ENV...
Move config declaration to the appropriate place
diff --git a/lib/active_encode/engine_adapters/ffmpeg_adapter.rb b/lib/active_encode/engine_adapters/ffmpeg_adapter.rb index abc1234..def5678 100644 --- a/lib/active_encode/engine_adapters/ffmpeg_adapter.rb +++ b/lib/active_encode/engine_adapters/ffmpeg_adapter.rb @@ -1,17 +1,41 @@+require 'fileutils' + module ActiveE...
Make a few tests green
diff --git a/db/data/20150311194246_associate_provers_with_ontology_versions.rb b/db/data/20150311194246_associate_provers_with_ontology_versions.rb index abc1234..def5678 100644 --- a/db/data/20150311194246_associate_provers_with_ontology_versions.rb +++ b/db/data/20150311194246_associate_provers_with_ontology_version...
Print error messages on stderr.
diff --git a/jekyll-github-metadata.gemspec b/jekyll-github-metadata.gemspec index abc1234..def5678 100644 --- a/jekyll-github-metadata.gemspec +++ b/jekyll-github-metadata.gemspec @@ -19,6 +19,7 @@ spec.add_development_dependency "bundler", "~> 1.5" spec.add_development_dependency "rake" + spec.add_development...
Add netrc as dev dep and use any version of Jekyll over 2.
diff --git a/lib/octoshark/active_record_extensions.rb b/lib/octoshark/active_record_extensions.rb index abc1234..def5678 100644 --- a/lib/octoshark/active_record_extensions.rb +++ b/lib/octoshark/active_record_extensions.rb @@ -1,8 +1,8 @@ module Octoshark module ConnectionHandler def establish_connection(*arg...
Fix undefined method `connection' when using Passenger server
diff --git a/spec/lib/user_agent_spec.rb b/spec/lib/user_agent_spec.rb index abc1234..def5678 100644 --- a/spec/lib/user_agent_spec.rb +++ b/spec/lib/user_agent_spec.rb @@ -0,0 +1,20 @@+require "spec_helper" + +class UserAgentTest + attr_accessor :user_agent + include UserAgent + + def initialize(user_agent) + @u...
Add a basic test for UserAgent
diff --git a/spec/reindeer/types_spec.rb b/spec/reindeer/types_spec.rb index abc1234..def5678 100644 --- a/spec/reindeer/types_spec.rb +++ b/spec/reindeer/types_spec.rb @@ -6,7 +6,7 @@ with Reindeer::Role::TypeConstraint def verify(val) - val =~ /^[a-z]+$/ + val.downcase == val end ...
Test for meaningful type error messages.
diff --git a/spec/rspec_matchers_spec.rb b/spec/rspec_matchers_spec.rb index abc1234..def5678 100644 --- a/spec/rspec_matchers_spec.rb +++ b/spec/rspec_matchers_spec.rb @@ -0,0 +1,9 @@+require 'models' +require 'rspec/acts_as_matchers' + +RSpec.describe "Custom RSpec matchers" do + it { expect(Product).to be_actable }...
Create specs for RSpec custom matchers
diff --git a/app/controllers/clubs_controller.rb b/app/controllers/clubs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/clubs_controller.rb +++ b/app/controllers/clubs_controller.rb @@ -7,6 +7,6 @@ def show @club = Club.find(params[:id]) - @meetings = @club.meetings.order(created_at: :asc...
Order meetings in list by date descending
diff --git a/lib/generators/authentication/templates/identities_controller.rb b/lib/generators/authentication/templates/identities_controller.rb index abc1234..def5678 100644 --- a/lib/generators/authentication/templates/identities_controller.rb +++ b/lib/generators/authentication/templates/identities_controller.rb @@ ...
Set model id in session after create
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -10,7 +10,7 @@ def create @user = User.new(user_params) if @user.save - # Handle successful save + ...
Create redirects to the new user page
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,4 +1,9 @@ class UsersController < ApplicationController + + # May try to make custom 404 page later + # def inde...
Delete print statements from users controller
diff --git a/app/controllers/votes_controller.rb b/app/controllers/votes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/votes_controller.rb +++ b/app/controllers/votes_controller.rb @@ -1,14 +1,25 @@-<<<<<<< HEAD -class VotesController < UserActionsController -======= class VotesController < Applica...
Update logic in votes controller
diff --git a/lib/anego/client.rb b/lib/anego/client.rb index abc1234..def5678 100644 --- a/lib/anego/client.rb +++ b/lib/anego/client.rb @@ -14,8 +14,8 @@ request :get, "/accounts/#{account_id}/products" end - def product_ratings(product) - request :get, "/apps/#{product.market}/app/#{product.produ...
Improve params of product ratings api
diff --git a/lib/arena/client.rb b/lib/arena/client.rb index abc1234..def5678 100644 --- a/lib/arena/client.rb +++ b/lib/arena/client.rb @@ -35,6 +35,9 @@ rescue JSON::ParserError nil + rescue TypeError + nil + rescue Exception => exception puts exception.inspect puts exception.b...
Return nil for TypeError (from attempting to parse nil)
diff --git a/app/grids/signups_grid.rb b/app/grids/signups_grid.rb index abc1234..def5678 100644 --- a/app/grids/signups_grid.rb +++ b/app/grids/signups_grid.rb @@ -6,20 +6,27 @@ end column(:id, header: "Seq") - column(:status) do |signup| - if signup.bucket - "Confirmed" - else - "Waitlisted" -...
Update the signups list for recent schema changes Things have gotten both simpler (in one place) and more complicated (in others) in the signups table in this branch. The signups list needs to be updated to account for the new logic in there.
diff --git a/lib/nehm/command.rb b/lib/nehm/command.rb index abc1234..def5678 100644 --- a/lib/nehm/command.rb +++ b/lib/nehm/command.rb @@ -1,51 +1,88 @@ module Nehm + # Base class for all Nehm commands. When creating a new nehm command, define + # #initialize, #execute, #arguments, #description, #program_name, #sum...
Add some functionality and comment Command class Inspired by rubygems
diff --git a/lib/pcap/handler.rb b/lib/pcap/handler.rb index abc1234..def5678 100644 --- a/lib/pcap/handler.rb +++ b/lib/pcap/handler.rb @@ -38,7 +38,7 @@ PCap.pcap_setdirection(@pcap,dir) end - def loop(data,&block) + def loop(data=nil,&block) callback(&block) if block PC...
Make the data argument optional for loop and dispatch.
diff --git a/LeetCode/remote/remove_duplicates_from_sorted_array_II.rb b/LeetCode/remote/remove_duplicates_from_sorted_array_II.rb index abc1234..def5678 100644 --- a/LeetCode/remote/remove_duplicates_from_sorted_array_II.rb +++ b/LeetCode/remote/remove_duplicates_from_sorted_array_II.rb @@ -0,0 +1,29 @@+# https://le...
Remove duplicates from sorted array II
diff --git a/lib/active_record_like_interface.rb b/lib/active_record_like_interface.rb index abc1234..def5678 100644 --- a/lib/active_record_like_interface.rb +++ b/lib/active_record_like_interface.rb @@ -60,6 +60,10 @@ id && id.to_s end + def model_name + self.class.model_name + end + def self.include...
Fix ActiveRecordLikeInterface to expose a model_name instance method
diff --git a/tests/setup_master.rb b/tests/setup_master.rb index abc1234..def5678 100644 --- a/tests/setup_master.rb +++ b/tests/setup_master.rb @@ -11,6 +11,7 @@ require 'wakame' require 'wakame/initializer' +require 'wakame/util' require 'ext/eventmachine'
Add a require for util classes.
diff --git a/lib/app_frame/controller_methods.rb b/lib/app_frame/controller_methods.rb index abc1234..def5678 100644 --- a/lib/app_frame/controller_methods.rb +++ b/lib/app_frame/controller_methods.rb @@ -18,7 +18,7 @@ module PaginationSupport # paginate collection def collection - get_collecti...
Use kaminari syntax for pagination
diff --git a/railties/lib/rails/generators/rails/app/templates/config/boot.rb b/railties/lib/rails/generators/rails/app/templates/config/boot.rb index abc1234..def5678 100644 --- a/railties/lib/rails/generators/rails/app/templates/config/boot.rb +++ b/railties/lib/rails/generators/rails/app/templates/config/boot.rb @@ ...
Allow a Rails application to be initialized from any directory and not just from inside it (ht: Andre Arko).
diff --git a/lib/facebook_share_widget/engine.rb b/lib/facebook_share_widget/engine.rb index abc1234..def5678 100644 --- a/lib/facebook_share_widget/engine.rb +++ b/lib/facebook_share_widget/engine.rb @@ -7,10 +7,5 @@ module FacebookShareWidget class Engine < ::Rails::Engine isolate_namespace FacebookShareWidge...
Revert "turn off compression to help with debugging in production." This reverts commit d3bc0d0eb5b44688b50a02475ae629f1a6eaa04c.
diff --git a/features/support/ui/sections/child_category.rb b/features/support/ui/sections/child_category.rb index abc1234..def5678 100644 --- a/features/support/ui/sections/child_category.rb +++ b/features/support/ui/sections/child_category.rb @@ -3,7 +3,7 @@ module UI::Sections class ChildCategory < UI::Section ...
Fix cucumber error due to link being removed
diff --git a/app/services/submission_rejector.rb b/app/services/submission_rejector.rb index abc1234..def5678 100644 --- a/app/services/submission_rejector.rb +++ b/app/services/submission_rejector.rb @@ -1,8 +1,7 @@ class SubmissionRejector RULES = [ Rules::EnglishRule.new, - Rules::FirstTimeRule.new, - ...
[155] Remove adult rule from SubmissionRejector
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index abc1234..def5678 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -1,5 +1,11 @@ require 'rails_helper' RSpec.describe User, type: :model do - pending "add some examples to (or delete) #{__FILE__}" + + it {should have_many...
Add passing tests on user relations: tutor_connections, learner_connections, tutors, learners
diff --git a/spec/sample_file_spec.rb b/spec/sample_file_spec.rb index abc1234..def5678 100644 --- a/spec/sample_file_spec.rb +++ b/spec/sample_file_spec.rb @@ -1,31 +1,24 @@ require 'spec_helper' describe SampleFile do - describe :image do - it "should call #file on an instance of Image" do - described_cla...
Remove duplication from SampleFile spec
diff --git a/simple_mvc.gemspec b/simple_mvc.gemspec index abc1234..def5678 100644 --- a/simple_mvc.gemspec +++ b/simple_mvc.gemspec @@ -23,4 +23,5 @@ spec.add_runtime_dependency "rack" spec.add_runtime_dependency "tilt" + spec.add_runtime_dependency "haml" end
Add haml gem to gemspec
diff --git a/lib/rack/canonical_host/redirect.rb b/lib/rack/canonical_host/redirect.rb index abc1234..def5678 100644 --- a/lib/rack/canonical_host/redirect.rb +++ b/lib/rack/canonical_host/redirect.rb @@ -19,34 +19,30 @@ end def known_host? - request_host == @host || ignored_host? + request...
Use URI to simplify host detection and generation.
diff --git a/test/lib/shopify_app/login_protection_test.rb b/test/lib/shopify_app/login_protection_test.rb index abc1234..def5678 100644 --- a/test/lib/shopify_app/login_protection_test.rb +++ b/test/lib/shopify_app/login_protection_test.rb @@ -0,0 +1,56 @@+require 'test_helper' +require 'action_controller' + +class He...
Add controller tests for LoginProtection module
diff --git a/spec/support/matchers.rb b/spec/support/matchers.rb index abc1234..def5678 100644 --- a/spec/support/matchers.rb +++ b/spec/support/matchers.rb @@ -1,7 +1,7 @@ # Define matchers for the docker LWRPs # Need chef-docker to define its own LWRP matchers eventually -module DockerLWRPs +module DockerLWRPMatch...
Add sudo LWRP matcher and rename docker matcher module
diff --git a/db/migrate/1_create_seo_data.rb b/db/migrate/1_create_seo_data.rb index abc1234..def5678 100644 --- a/db/migrate/1_create_seo_data.rb +++ b/db/migrate/1_create_seo_data.rb @@ -5,6 +5,8 @@ t.string :meta_keywords t.string :meta_title t.text :meta_description + + t.timestamps ...
Include timestamps to SeoDatum table
diff --git a/ember-cli-rails-assets.gemspec b/ember-cli-rails-assets.gemspec index abc1234..def5678 100644 --- a/ember-cli-rails-assets.gemspec +++ b/ember-cli-rails-assets.gemspec @@ -15,4 +15,6 @@ s.license = "MIT" s.files = Dir["{app,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"] + + s.add_dependenc...
Add nokogiri as a dependency
diff --git a/recipes/_repo.rb b/recipes/_repo.rb index abc1234..def5678 100644 --- a/recipes/_repo.rb +++ b/recipes/_repo.rb @@ -4,8 +4,8 @@ when 'nginx-stable' include_recipe 'yum-nginx::default' when 'nginx-mainline' - node.default['yum-nginx']['repos']['nginx-stable']['manages'] = false - node.default['yum-ngi...
Fix attirbute names that allow choosing the nginx-mainline repo
diff --git a/bureaucrat.gemspec b/bureaucrat.gemspec index abc1234..def5678 100644 --- a/bureaucrat.gemspec +++ b/bureaucrat.gemspec @@ -9,7 +9,7 @@ s.specification_version = 2 if s.respond_to? :specification_version= - s.files = ["lib/bureaucrat/fields.rb", "lib/bureaucrat/forms.rb", "lib/bureaucrat/formsets....
Fix gemspec for this branch
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -17,7 +17,7 @@ # limitations under the License. # prime the search to avoid 2 masters -node.save +node.save # ~FC075 unless node['drbd']['custom_repo'] include_recipe 'yum-elr...
Disable FC075 where we actually need it Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/db/migrate/20141219034321_add_permalink_to_enterprises.rb b/db/migrate/20141219034321_add_permalink_to_enterprises.rb index abc1234..def5678 100644 --- a/db/migrate/20141219034321_add_permalink_to_enterprises.rb +++ b/db/migrate/20141219034321_add_permalink_to_enterprises.rb @@ -13,7 +13,7 @@ count...
Switch to update_column, which will not run geocoding callback of Enterprise
diff --git a/db/migrate/20190206235119_change_category_id_to_bigint.rb b/db/migrate/20190206235119_change_category_id_to_bigint.rb index abc1234..def5678 100644 --- a/db/migrate/20190206235119_change_category_id_to_bigint.rb +++ b/db/migrate/20190206235119_change_category_id_to_bigint.rb @@ -0,0 +1,15 @@+class ChangeCa...
Update category_id primary and foreign keys to bigint
diff --git a/UIScrollSlidingPages.podspec b/UIScrollSlidingPages.podspec index abc1234..def5678 100644 --- a/UIScrollSlidingPages.podspec +++ b/UIScrollSlidingPages.podspec @@ -16,6 +16,5 @@ "UIScrollViewSlidingPages/Source/**/*.{h,m}" ] s.requires_arc = true - s.resources = "UIScrollViewSlidingPages/Source/...
Remove unused resources from podfile
diff --git a/lib/ap/core_ext/action_view.rb b/lib/ap/core_ext/action_view.rb index abc1234..def5678 100644 --- a/lib/ap/core_ext/action_view.rb +++ b/lib/ap/core_ext/action_view.rb @@ -1,4 +1,17 @@ module AwesomePrintActionView + + def self.included(base) + unless base.const_defined?(:AP_ANSI_TO_HTML) + hash =...
Build ansi => html conversion hash once when the module gets included
diff --git a/mixlib-shellout-x86-mingw32.gemspec b/mixlib-shellout-x86-mingw32.gemspec index abc1234..def5678 100644 --- a/mixlib-shellout-x86-mingw32.gemspec +++ b/mixlib-shellout-x86-mingw32.gemspec @@ -3,6 +3,6 @@ gemspec.platform = "x86-mingw32" -gemspec.add_dependency "win32-process", "~> 0.6.5" +gemspec.add_d...
Update to use win32-process ~> 0.7.0
diff --git a/app/controllers/root_controller.rb b/app/controllers/root_controller.rb index abc1234..def5678 100644 --- a/app/controllers/root_controller.rb +++ b/app/controllers/root_controller.rb @@ -16,6 +16,7 @@ NON_LAYOUT_TEMPLATES = %w( barclays_epdq beta_notice + beta_label campaign print...
Mark the beta_label template as a non-layout template Include "beta_label" as part of the NON_LAYOUT_TEMPLATES list, so that we don't show the GOV.UK wrapper around it when we include it in other pages.
diff --git a/app/helpers/notification_helper.rb b/app/helpers/notification_helper.rb index abc1234..def5678 100644 --- a/app/helpers/notification_helper.rb +++ b/app/helpers/notification_helper.rb @@ -4,19 +4,20 @@ include ActionView::Helpers::TagHelper def banner_notification - banner = NotificationFileLooku...
Refactor duplicate method bodies into shared private method
diff --git a/app/models/mails/initiated_mail.rb b/app/models/mails/initiated_mail.rb index abc1234..def5678 100644 --- a/app/models/mails/initiated_mail.rb +++ b/app/models/mails/initiated_mail.rb @@ -5,7 +5,7 @@ SLUG = "initiated_mail" TEMPLATE_NAME = "mails/initiated_mail" DISPLAYED_NAME = 'Accusé de ré...
Fix the wording of the initiated email’s subject
diff --git a/lib/tasks/tmp_update_hmrc_manual_sections.rake b/lib/tasks/tmp_update_hmrc_manual_sections.rake index abc1234..def5678 100644 --- a/lib/tasks/tmp_update_hmrc_manual_sections.rake +++ b/lib/tasks/tmp_update_hmrc_manual_sections.rake @@ -0,0 +1,42 @@+# Following decommissioning of manuals-frontend we are imp...
Add temporary rake task to update titles on hmrc_manual_Section items. To simplify front-end rendering, we need to add the parent manual title to hmrc manual section items. This commit adds a task to update the values on existing records (can be removed once this job is complete and all existing and new hmrc_manual_s...
diff --git a/lib/rails_ops/profiler/node.rb b/lib/rails_ops/profiler/node.rb index abc1234..def5678 100644 --- a/lib/rails_ops/profiler/node.rb +++ b/lib/rails_ops/profiler/node.rb @@ -4,7 +4,7 @@ @object_id = object_id @description = description @parent = parent - parent&.add_child(self) + ...
Remove usage of Safe Navigation Operator '&.' The Safe Navigation Operator was introduced in ruby 2.3. However, it would be nice to have compatibility with ruby versions below that. This commit has been tested with ruby 2.2.4.
diff --git a/lib/reek/source/source_code.rb b/lib/reek/source/source_code.rb index abc1234..def5678 100644 --- a/lib/reek/source/source_code.rb +++ b/lib/reek/source/source_code.rb @@ -1,4 +1,8 @@-require 'ruby_parser' +if RUBY_VERSION < "1.9.3" + require 'ruby_parser' +else + require 'ripper_ruby_parser' +end requi...
Replace ruby_parser with ripper_ruby_parser for Ruby 1.9.
diff --git a/mongo_rates.gemspec b/mongo_rates.gemspec index abc1234..def5678 100644 --- a/mongo_rates.gemspec +++ b/mongo_rates.gemspec @@ -8,7 +8,7 @@ spec.version = MongoRates::VERSION spec.authors = ["Justin Ridgewell"] spec.email = ["justin@ridgewell.name"] - spec.description = %q{Ra...
Use gem.summary instead of gem.description Noob mistake
diff --git a/lib/skimlinks/configuration.rb b/lib/skimlinks/configuration.rb index abc1234..def5678 100644 --- a/lib/skimlinks/configuration.rb +++ b/lib/skimlinks/configuration.rb @@ -20,7 +20,7 @@ def reset VALID_CONFIG_KEYS.each do |key| - self.send "#{key}=", self.class.const_get("DEFAULT_#{key....
Revert "Explicitely call to_s on symbol before calling upcase" This reverts commit f57cafe5d8d13f9d3a557950bb8d4ea7243ee475.
diff --git a/lib/tasks/metadata_tagger.rake b/lib/tasks/metadata_tagger.rake index abc1234..def5678 100644 --- a/lib/tasks/metadata_tagger.rake +++ b/lib/tasks/metadata_tagger.rake @@ -0,0 +1,7 @@+require 'rummager' + +desc "Apply metadata from the json file" +task :tag_json_metadata do + file_path = File.join(setting...
Add rake task to apply metadata
diff --git a/XDKAirMenu.podspec b/XDKAirMenu.podspec index abc1234..def5678 100644 --- a/XDKAirMenu.podspec +++ b/XDKAirMenu.podspec @@ -1,10 +1,10 @@ Pod::Spec.new do |s| s.name = "XDKAirMenu" - s.version = "1.1.11" - s.summary = "A short description of XDKAirMenu." + s.version ...
Change podspec to be valid
diff --git a/test/factories/users_factory.rb b/test/factories/users_factory.rb index abc1234..def5678 100644 --- a/test/factories/users_factory.rb +++ b/test/factories/users_factory.rb @@ -2,10 +2,10 @@ FactoryGirl.define do factory :user do - username { Faker::Internet.user_name } - email { Faker::...
FIX: Create unique username and password
diff --git a/test/support/config_helpers.rb b/test/support/config_helpers.rb index abc1234..def5678 100644 --- a/test/support/config_helpers.rb +++ b/test/support/config_helpers.rb @@ -9,34 +9,12 @@ # ... # end def use_config(options, &example) - original_config = {} - - options.each do |key, val| -...
Refactor config helpers to share logic that swaps config values It's the same logic, just working on a different config instance object, so we can have a shared method used by both.
diff --git a/lib/gpgme/misc.rb b/lib/gpgme/misc.rb index abc1234..def5678 100644 --- a/lib/gpgme/misc.rb +++ b/lib/gpgme/misc.rb @@ -12,10 +12,17 @@ attr_reader :signatures end + class Recipient + private_class_method :new + + attr_reader :pubkey_algo, :keyid, :status + end + class DecryptResult ...
Define readers of DecryptResult and Recipient instance variables
diff --git a/lib/heroku_san.rb b/lib/heroku_san.rb index abc1234..def5678 100644 --- a/lib/heroku_san.rb +++ b/lib/heroku_san.rb @@ -1,4 +1,4 @@-require 'railtie' if defined?(Rails) && Rails::VERSION::MAJOR >= 3 +require File.join(File.dirname(__FILE__), 'railtie.rb') if defined?(Rails) && Rails::VERSION::MAJOR >= 3 r...
Use full path to require railtie
diff --git a/serverspec.gemspec b/serverspec.gemspec index abc1234..def5678 100644 --- a/serverspec.gemspec +++ b/serverspec.gemspec @@ -21,7 +21,6 @@ spec.add_runtime_dependency "rspec", "~> 3.0" spec.add_runtime_dependency "rspec-its" spec.add_runtime_dependency "specinfra", "~> 2.1" - spec.add_runtime_depen...
Remove dependency on test-unit because test-unit/power_assert support is experimental currently
diff --git a/webpack-rails.gemspec b/webpack-rails.gemspec index abc1234..def5678 100644 --- a/webpack-rails.gemspec +++ b/webpack-rails.gemspec @@ -18,5 +18,6 @@ s.test_files = Dir["test/**/*"] s.add_dependency "railties", ">= 3.2.0" + s.add_development_dependency "rails", ">= 3.2.0" s.required_ruby_version...
Add rails back as a dev dependency
diff --git a/lib/atlas/initializer_input.rb b/lib/atlas/initializer_input.rb index abc1234..def5678 100644 --- a/lib/atlas/initializer_input.rb +++ b/lib/atlas/initializer_input.rb @@ -8,6 +8,7 @@ attribute :share_group, Symbol attribute :priority, Integer, default: 0 attribute :unit, ...
Add 'update type' property to initializer input class
diff --git a/lib/capybara/server/checker.rb b/lib/capybara/server/checker.rb index abc1234..def5678 100644 --- a/lib/capybara/server/checker.rb +++ b/lib/capybara/server/checker.rb @@ -3,6 +3,8 @@ module Capybara class Server class Checker + TRY_HTTPS_ERRORS = [EOFError, Net::ReadTimeout, Errno::ECONNRESET...
Add Errno::ECONNRESET to the errors that trigger https attempt
diff --git a/lib/tasks/db.rake b/lib/tasks/db.rake index abc1234..def5678 100644 --- a/lib/tasks/db.rake +++ b/lib/tasks/db.rake @@ -0,0 +1,11 @@+namespace :db do + desc "drops, creates, migrates, and seeds database" + task :nuke_pave => :environment do + unless Rails.env == "Production" + Rake::Task["db:drop...
Add nuke_pave task for resetting development database
diff --git a/lib/emeril/metadata_chopper.rb b/lib/emeril/metadata_chopper.rb index abc1234..def5678 100644 --- a/lib/emeril/metadata_chopper.rb +++ b/lib/emeril/metadata_chopper.rb @@ -24,10 +24,10 @@ def initialize(metadata_file) eval(IO.read(metadata_file), nil, metadata_file) %w{name version}.map(&...
Use a next to skip iteration in each block (style).
diff --git a/lib/facter/package_provider.rb b/lib/facter/package_provider.rb index abc1234..def5678 100644 --- a/lib/facter/package_provider.rb +++ b/lib/facter/package_provider.rb @@ -12,7 +12,7 @@ Facter.add(:package_provider) do setcode do - if Gem::Version.new(Facter.value(:puppetversion).split(' ')[0]) >= ...
Add check if Gem is defined On e.g. Ubuntu 12.04 LTS Gem is not there by default so i added a check to not fail in that fact if this is the case.
diff --git a/lib/hiraoyogi/database/base.rb b/lib/hiraoyogi/database/base.rb index abc1234..def5678 100644 --- a/lib/hiraoyogi/database/base.rb +++ b/lib/hiraoyogi/database/base.rb @@ -1,3 +1,5 @@+require "nkf" + module Hiraoyogi module Database class Base @@ -17,7 +19,7 @@ protected def body_te...
Convert page text to UTF-8
diff --git a/datadog.gemspec b/datadog.gemspec index abc1234..def5678 100644 --- a/datadog.gemspec +++ b/datadog.gemspec @@ -20,5 +20,5 @@ spec.add_development_dependency 'bundler', '~> 1.3' spec.add_development_dependency 'rake' - spec.add_development_dependency 'rubocop', '~> 0.23.0' + spec.add_development_d...
Update rubocop version for security See CVE-2017-8418 Signed-off-by: Mike Fiedler <af44b651315133051dded0e55830cbf76e9bfef9@gmail.com>
diff --git a/lib/restulicious/connection.rb b/lib/restulicious/connection.rb index abc1234..def5678 100644 --- a/lib/restulicious/connection.rb +++ b/lib/restulicious/connection.rb @@ -4,7 +4,7 @@ def get(url, params) request = ::Typhoeus::Request.new(url, method: :get, - headers: ...
Change accept header to application/json
diff --git a/spec/jsonapi_app/config/initializers/jsonapi_resources.rb b/spec/jsonapi_app/config/initializers/jsonapi_resources.rb index abc1234..def5678 100644 --- a/spec/jsonapi_app/config/initializers/jsonapi_resources.rb +++ b/spec/jsonapi_app/config/initializers/jsonapi_resources.rb @@ -0,0 +1,7 @@+JSONAPI.configu...
Set up pagination in testing app
diff --git a/lib/active_record/connection_adapters/sqlserver/core_ext/calculations.rb b/lib/active_record/connection_adapters/sqlserver/core_ext/calculations.rb index abc1234..def5678 100644 --- a/lib/active_record/connection_adapters/sqlserver/core_ext/calculations.rb +++ b/lib/active_record/connection_adapters/sqlser...
Remove order from count subquery
diff --git a/lib/traceview/api/layerinit.rb b/lib/traceview/api/layerinit.rb index abc1234..def5678 100644 --- a/lib/traceview/api/layerinit.rb +++ b/lib/traceview/api/layerinit.rb @@ -11,11 +11,13 @@ # layer. # def report_init(layer = 'rack') - # Don't send __Init in development or test - ...
Consolidate __Init checks inside report_init method
diff --git a/try/14_auth_methods_tryouts.rb b/try/14_auth_methods_tryouts.rb index abc1234..def5678 100644 --- a/try/14_auth_methods_tryouts.rb +++ b/try/14_auth_methods_tryouts.rb @@ -1,8 +1,6 @@ require "rye" -# May need to update this in the future with a -# different free SSH provider -@hostname = "shellmix.com" ...
Change SSH server in auth methods test
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -23,7 +23,7 @@ remote_directory node['chef_handler']['handler_path'] do source 'handlers' unless platform?('windows') - owner 'root' + owner node['root_user'] mode '07...
Use root_user attribute in recipe
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -22,6 +22,7 @@ when 'rhel', 'fedora' node['platform_version'].to_f >= 6.0 ? 'cronie' : 'vixie-cron' end + action :upgrade end serv...
Install tmpwatch (tmpreaper on Ubuntu).
diff --git a/spec/helpers/collection_spec.rb b/spec/helpers/collection_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/collection_spec.rb +++ b/spec/helpers/collection_spec.rb @@ -24,7 +24,9 @@ Fog.wait_for { !subject.all.map(&:identity).include? instance_one.identity } Fog.wait_for { !subject.all.m...
[shindo-minitest] Split up CollectionSpec tests into smaller bits
diff --git a/spec/release/deployment_spec.rb b/spec/release/deployment_spec.rb index abc1234..def5678 100644 --- a/spec/release/deployment_spec.rb +++ b/spec/release/deployment_spec.rb @@ -26,7 +26,7 @@ uri = URI("http://localhost:9200/#{index}/_search?q=#{log.data}") output = gateway.execute_on(deployment.mas...
Fix bug in test when accessing @message field [#116514499] Signed-off-by: Derik Evangelista <70505a31063ee00d819d9d243caf579a659cbb4f@pivotal.io>
diff --git a/spec/feels_spec.rb b/spec/feels_spec.rb index abc1234..def5678 100644 --- a/spec/feels_spec.rb +++ b/spec/feels_spec.rb @@ -1,6 +1,6 @@ ENV['RACK_ENV'] = 'test' -require_relative '../app/feels' # <-- your sinatra app +require_relative '../app/feels' require 'rspec' require 'rack/test' @@ -16,48 +16,...
Make the specs shorter by listing routes in word array.
diff --git a/spec/stack_spec.rb b/spec/stack_spec.rb index abc1234..def5678 100644 --- a/spec/stack_spec.rb +++ b/spec/stack_spec.rb @@ -20,6 +20,10 @@ expect(@stack.top).to eq(nil) end + it "allows you to pop from an empty stack" do + expect(@stack.pop).to eq(nil) + end + describe "empty?" do it ...
Add test for popping from an empty Stack
diff --git a/test/adapters/mongo_test.rb b/test/adapters/mongo_test.rb index abc1234..def5678 100644 --- a/test/adapters/mongo_test.rb +++ b/test/adapters/mongo_test.rb @@ -7,7 +7,8 @@ def setup host = '127.0.0.1' port = '27017' - collection = Mongo::Client.new(["#{host}:#{port}"], server_selection_timeo...
Send mongo logging to dev null
diff --git a/lib/openxml/docx/elements/abstract_number.rb b/lib/openxml/docx/elements/abstract_number.rb index abc1234..def5678 100644 --- a/lib/openxml/docx/elements/abstract_number.rb +++ b/lib/openxml/docx/elements/abstract_number.rb @@ -21,6 +21,13 @@ # value_property :name # value_property :style_...
Make properties appear on the root level of the element
diff --git a/test/jenkins_sample_test.rb b/test/jenkins_sample_test.rb index abc1234..def5678 100644 --- a/test/jenkins_sample_test.rb +++ b/test/jenkins_sample_test.rb @@ -6,10 +6,15 @@ class JenkinsSampleTest < MiniTest::Unit::TestCase def setup - @webpage = Net::HTTP.get(URI("http://#{ENV['TEST_IP_ADDRESS']}...
Change default test port to 80 The test port can be configured with the env variable TEST_PORT.
diff --git a/lib/woocommerce_api/concerns/associations.rb b/lib/woocommerce_api/concerns/associations.rb index abc1234..def5678 100644 --- a/lib/woocommerce_api/concerns/associations.rb +++ b/lib/woocommerce_api/concerns/associations.rb @@ -19,7 +19,7 @@ define_method association_name do associatio...
Fix error since we moved to 'collection_name'
diff --git a/config/initializers/carrierwave.rb b/config/initializers/carrierwave.rb index abc1234..def5678 100644 --- a/config/initializers/carrierwave.rb +++ b/config/initializers/carrierwave.rb @@ -34,10 +34,6 @@ region: 'eu-west-1' } - if s3['vhost'] - credentials.merge!(host: s3['vhost']) - end - ...
Remove host from s3 fog credentials
diff --git a/spec/swagger_docs_generator/configuration/configuration_default_spec.rb b/spec/swagger_docs_generator/configuration/configuration_default_spec.rb index abc1234..def5678 100644 --- a/spec/swagger_docs_generator/configuration/configuration_default_spec.rb +++ b/spec/swagger_docs_generator/configuration/confi...
Test doc_class and doc_folder attribute
diff --git a/composer/recipes/install.rb b/composer/recipes/install.rb index abc1234..def5678 100644 --- a/composer/recipes/install.rb +++ b/composer/recipes/install.rb @@ -8,5 +8,8 @@ php composer.phar install --no-dev --no-interaction --prefer-dist EOH only_if { ::File.exist?("#{deploy[:deploy_to]}/curr...
Add laravel project at deploy Add laravel project at deploy
diff --git a/modules/php5/spec/extension/newrelic/spec.rb b/modules/php5/spec/extension/newrelic/spec.rb index abc1234..def5678 100644 --- a/modules/php5/spec/extension/newrelic/spec.rb +++ b/modules/php5/spec/extension/newrelic/spec.rb @@ -14,3 +14,7 @@ its(:stdout) { should match /daemon\.logfile => \/var\/log\/new...
Duplicate extension - Change test object
diff --git a/config/initializers/i18n.rb b/config/initializers/i18n.rb index abc1234..def5678 100644 --- a/config/initializers/i18n.rb +++ b/config/initializers/i18n.rb @@ -9,7 +9,7 @@ # set up fallbacks require "i18n/backend/fallbacks" I18n::Backend::Simple.send(:include, I18n::Backend::Fallbacks) -Rails.application...
Use he (current Hebrew locale) as the fallback locale for iw (old Hebrew locale)
diff --git a/db/migrate/20120101170000_remove_unique_constraint_from_titles_on_mock_lists.rb b/db/migrate/20120101170000_remove_unique_constraint_from_titles_on_mock_lists.rb index abc1234..def5678 100644 --- a/db/migrate/20120101170000_remove_unique_constraint_from_titles_on_mock_lists.rb +++ b/db/migrate/201201011700...
Remove unique constraint on mock titles
diff --git a/config/schedule.rb b/config/schedule.rb index abc1234..def5678 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -1,4 +1,4 @@-env 'PATH', '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin' +env 'PATH', '/opt/ruby/bin:/usr/sbin:/usr/bin:/sbin:/bin' every :day, at: '12:00am' do ru...
Change the path to where ruby will be
diff --git a/config/schedule.rb b/config/schedule.rb index abc1234..def5678 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -1,3 +1,5 @@+job_type :rake, "cd :path && RACK_ENV=:environment bundle exec rake :task --silent :output" + set :output, '/home/stillmaintained/shared/log/cron.log' every 6.hours...
Fix whenever environment variables from RAILS_ENV to RACK_ENV
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -5,3 +5,5 @@ # # movies = Movie.create([{ name: 'Star Wars' }, { name: 'Lord of the Rings' }]) # Character.create(name: 'Luke', movie: movies.first) + +badge = Badge.create(name: 'Chemical Spill', descripti...
Create first badge to seed database