diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/test/exclude_log_messages.rb b/test/exclude_log_messages.rb index abc1234..def5678 100644 --- a/test/exclude_log_messages.rb +++ b/test/exclude_log_messages.rb @@ -0,0 +1,48 @@+require_relative 'test_init' + +class ExcludeLogMessages + attr_accessor :logger + + def self.build + instance = new + Tel...
Write tests for excluding log messages based on an environment variable.
diff --git a/lib/guided_randomness.rb b/lib/guided_randomness.rb index abc1234..def5678 100644 --- a/lib/guided_randomness.rb +++ b/lib/guided_randomness.rb @@ -1,22 +1,13 @@ class Array - - def get_rand(arr) - raise "Wrong number of arguments" unless arr.size == self.size - # raise "Currently working only for ...
Rewrite get_rand method - less LOC, better alhorithm, names. Complexity is now O(N), where N is number of array elements.
diff --git a/lib/hets/hets_options.rb b/lib/hets/hets_options.rb index abc1234..def5678 100644 --- a/lib/hets/hets_options.rb +++ b/lib/hets/hets_options.rb @@ -4,6 +4,10 @@ def self.from_hash(hash) new(hash['options']) + end + + def self.from_json(json) + from_hash(JSON.parse(json)) end ...
Add json converting methods to HetsOptions Those are needed for async calls with sidekiq, because it can only pass basic data types to asynchronously called methods.
diff --git a/exceltocsv.gemspec b/exceltocsv.gemspec index abc1234..def5678 100644 --- a/exceltocsv.gemspec +++ b/exceltocsv.gemspec @@ -4,7 +4,7 @@ require 'exceltocsv/version' Gem::Specification.new do |spec| - spec.name = "xmlutils" + spec.name = "exceltocsv" spec.version = ExcelToCsv...
Correct gem name in gemspec modified: exceltocsv.gemspec
diff --git a/app/validators/picture_image_validator.rb b/app/validators/picture_image_validator.rb index abc1234..def5678 100644 --- a/app/validators/picture_image_validator.rb +++ b/app/validators/picture_image_validator.rb @@ -12,14 +12,16 @@ return end - new_checksum = record.image_file.blob.checksum...
Validate uniqueness of image upload only for new records
diff --git a/lib/lysergide.rb b/lib/lysergide.rb index abc1234..def5678 100644 --- a/lib/lysergide.rb +++ b/lib/lysergide.rb @@ -9,10 +9,10 @@ require 'lysergide/jobs' Lysergide::Jobs.start require 'lysergide/application' - lsd = Lysergide::Application - lsd.set :port, port - lsd.set :bind, '0.0....
Rename 'lsd' to 'lys' internally
diff --git a/app/workers/completeness_metric_worker.rb b/app/workers/completeness_metric_worker.rb index abc1234..def5678 100644 --- a/app/workers/completeness_metric_worker.rb +++ b/app/workers/completeness_metric_worker.rb @@ -3,9 +3,9 @@ def perform(repository_name) repository = Repository.find repository_nam...
Add missing argument for completeness worker There was a missing argument, as well as as a missing call to self.class for symbolize_keys which prevented the completeness metric from working. This commit fixes that. Signed-off-by: Konrad Reiche <4ff0213f56e2082fcd8c882d04c546881c579ce4@gmail.com>
diff --git a/lib/osrm/route.rb b/lib/osrm/route.rb index abc1234..def5678 100644 --- a/lib/osrm/route.rb +++ b/lib/osrm/route.rb @@ -19,7 +19,7 @@ # HACK: Should fix encoded_polyline gem instead def fix_float_precision(float) - decimals = float.to_s.sub(/\A\d+\./, '') + decimals = float.to_f.to_s[/...
Allow precision algorithm to process integers
diff --git a/test/unit/edition/role_appointments_test.rb b/test/unit/edition/role_appointments_test.rb index abc1234..def5678 100644 --- a/test/unit/edition/role_appointments_test.rb +++ b/test/unit/edition/role_appointments_test.rb @@ -9,4 +9,11 @@ published = create(:published_news_article, role_appointments: app...
Add additional test coverage for edition role appointments This adds some missing coverage around exposing the role appointments in search data when present.
diff --git a/app/models/admin.rb b/app/models/admin.rb index abc1234..def5678 100644 --- a/app/models/admin.rb +++ b/app/models/admin.rb @@ -30,4 +30,10 @@ def lead_or_assigned?(*) true end + + private + + def min_password_score + 3 + end end
Set minimum password score for Admin model to 3 This is the score for zxcvbn
diff --git a/app/models/audit.rb b/app/models/audit.rb index abc1234..def5678 100644 --- a/app/models/audit.rb +++ b/app/models/audit.rb @@ -7,7 +7,7 @@ end), dataset: (proc do klass = auditable_type.constantize - ...
Fix issue with loading polymorphic association from Audit
diff --git a/lib/next_step.rb b/lib/next_step.rb index abc1234..def5678 100644 --- a/lib/next_step.rb +++ b/lib/next_step.rb @@ -2,7 +2,7 @@ module NextStep - StepResult = Struct.new(:continue, :message, :exception, :payload, :step) + StepResult = Struct.new(:continue, :message, :exception, :payload, :step, :bag)...
Add a data bag to result objects
diff --git a/lib/open_hash.rb b/lib/open_hash.rb index abc1234..def5678 100644 --- a/lib/open_hash.rb +++ b/lib/open_hash.rb @@ -4,18 +4,18 @@ new(hash) end end - + def initialize(hash = {}) super self.default = hash.default end - + def dup self.class.new(self) end protec...
Fix crash when runing Rails4 - wrong number of arguments (given 2, expected 1)
diff --git a/db/migrate/20130919010513_ensure_shipping_methods_have_distributors.rb b/db/migrate/20130919010513_ensure_shipping_methods_have_distributors.rb index abc1234..def5678 100644 --- a/db/migrate/20130919010513_ensure_shipping_methods_have_distributors.rb +++ b/db/migrate/20130919010513_ensure_shipping_methods_...
Fix migration for envs without distributors
diff --git a/OAuthSwift.podspec b/OAuthSwift.podspec index abc1234..def5678 100644 --- a/OAuthSwift.podspec +++ b/OAuthSwift.podspec @@ -11,6 +11,7 @@ } s.source = { git: 'https://github.com/OAuthSwift/OAuthSwift.git', tag: s.version } s.source_files = 'Sources/*.swift' + s.swift_version = '4.1' s.ios.deplo...
Add Swift version into podspec
diff --git a/lib/trackler/problems.rb b/lib/trackler/problems.rb index abc1234..def5678 100644 --- a/lib/trackler/problems.rb +++ b/lib/trackler/problems.rb @@ -2,8 +2,6 @@ # Problems is the collection of problems that we have metadata for. class Problems include Enumerable - - SLUG_PATTERN = Regexp.new("....
Use File.basename instead of regex to determine slugs
diff --git a/build/dist/bin/generate_build_metadata.rb b/build/dist/bin/generate_build_metadata.rb index abc1234..def5678 100644 --- a/build/dist/bin/generate_build_metadata.rb +++ b/build/dist/bin/generate_build_metadata.rb @@ -3,8 +3,9 @@ require 'rubygems' require 'json' require File.join( File.dirname( __FILE__ )...
Fix build info script to use the correct BuildInfo class.
diff --git a/lib/rorr/init.rb b/lib/rorr/init.rb index abc1234..def5678 100644 --- a/lib/rorr/init.rb +++ b/lib/rorr/init.rb @@ -16,7 +16,7 @@ options.banner = 'Usage: rorr [options]' options.on('-t', '--time SECONDS', 'Delay each turn by seconds (default: 0.6)') { |seconds| Config.delay = seconds.to_f } ...
Fix config all questions arg is 0
diff --git a/lib/rubysh/fd.rb b/lib/rubysh/fd.rb index abc1234..def5678 100644 --- a/lib/rubysh/fd.rb +++ b/lib/rubysh/fd.rb @@ -31,6 +31,10 @@ Rubysh.<<(self) end + def inspect + to_s + end + def to_s "FD: #{@fileno}" end
Add an inspect method to FD
diff --git a/lib/ec2_helper.rb b/lib/ec2_helper.rb index abc1234..def5678 100644 --- a/lib/ec2_helper.rb +++ b/lib/ec2_helper.rb @@ -0,0 +1,70 @@+require 'open-uri' +require 'json' +require 'fog' + +# Support IAM instance profiles +class EC2Helper + + # Need access_key_id, secret_access_key + def initialize(aki, sak)...
Create a helper class that constructs Fog::Compute connection strings and gathers AWS IAM credentials from instance metadata.
diff --git a/app/models/github_user.rb b/app/models/github_user.rb index abc1234..def5678 100644 --- a/app/models/github_user.rb +++ b/app/models/github_user.rb @@ -36,4 +36,12 @@ rescue Octokit::RepositoryUnavailable, Octokit::NotFound, Octokit::Forbidden, Octokit::InternalServerError, Octokit::BadGateway => e ...
Add a method to download a users public orgs
diff --git a/app/models/user_mailer.rb b/app/models/user_mailer.rb index abc1234..def5678 100644 --- a/app/models/user_mailer.rb +++ b/app/models/user_mailer.rb @@ -1,4 +1,5 @@ class UserMailer < Devise::Mailer + default :from => "Admin <#{APP_CONFIG[:help_email]}>" def confirmation_instructions(record, opts={}...
Add default from address to Usermailer class - Add default from address to Usermailer class
diff --git a/SnapKit.podspec b/SnapKit.podspec index abc1234..def5678 100644 --- a/SnapKit.podspec +++ b/SnapKit.podspec @@ -6,7 +6,7 @@ s.homepage = 'https://github.com/SnapKit/SnapKit' s.authors = { 'Robert Payne' => 'robertpayne@me.com' } s.social_media_url = 'http://twitter.com/robertjpayne' - s.source = {...
Add swift version to podspec
diff --git a/app/tasks/import_needs.rb b/app/tasks/import_needs.rb index abc1234..def5678 100644 --- a/app/tasks/import_needs.rb +++ b/app/tasks/import_needs.rb @@ -1,13 +1,7 @@-require 'gds_api/need_api' - class ImportNeeds class << self - def api - @api ||= GdsApi::NeedApi.new( Plek.current.find('need-api...
Simplify code to reuse ContentPlanner.needs_api
diff --git a/populate_organisation_types.rb b/populate_organisation_types.rb index abc1234..def5678 100644 --- a/populate_organisation_types.rb +++ b/populate_organisation_types.rb @@ -0,0 +1,14 @@+[ + "Ministerial department", + "Non-ministerial department", + "Executive agency", + "Executive non-departmental publ...
Add script to populate org types. We'll run this on the server, then remove it.
diff --git a/test/membership_validators_test.rb b/test/membership_validators_test.rb index abc1234..def5678 100644 --- a/test/membership_validators_test.rb +++ b/test/membership_validators_test.rb @@ -0,0 +1,54 @@+require_relative 'test_helper' + +module GitHubLdapMembershipValidatorsTestCases + def make_validator(gro...
Add rudimentary tests for MembershipValidators
diff --git a/rspec_lister.gemspec b/rspec_lister.gemspec index abc1234..def5678 100644 --- a/rspec_lister.gemspec +++ b/rspec_lister.gemspec @@ -22,6 +22,4 @@ spec.add_development_dependency "rake" spec.add_development_dependency "rspec" spec.add_development_dependency "aruba" - - spec.add_dependency 'rspec' ...
Remove RSpec gem install dependency.
diff --git a/lib/build-cloud/s3bucket.rb b/lib/build-cloud/s3bucket.rb index abc1234..def5678 100644 --- a/lib/build-cloud/s3bucket.rb +++ b/lib/build-cloud/s3bucket.rb @@ -18,14 +18,19 @@ def create - return if exists? + policy = @options.delete(:policy) + + unless exists? ...
Add policy lifecycle to s3 buckets
diff --git a/lib/epub/publication/package.rb b/lib/epub/publication/package.rb index abc1234..def5678 100644 --- a/lib/epub/publication/package.rb +++ b/lib/epub/publication/package.rb @@ -5,7 +5,7 @@ class Package attr_accessor :book, :version, :unique_identifier_id, :prefix, :xml_lang,...
Remove unique_identifier from attr_reader; it implemented implicitly
diff --git a/test/server/run_timed_out_test.rb b/test/server/run_timed_out_test.rb index abc1234..def5678 100644 --- a/test/server/run_timed_out_test.rb +++ b/test/server/run_timed_out_test.rb @@ -44,7 +44,7 @@ @stubs[@n].call end def join(_seconds) - nil + self end end
Use better stubbed return value for Thread.join()
diff --git a/lib/tasks/ui.rake b/lib/tasks/ui.rake index abc1234..def5678 100644 --- a/lib/tasks/ui.rake +++ b/lib/tasks/ui.rake @@ -0,0 +1,43 @@+# frozen_string_literal: true + +namespace :ui do + def log_info(message) + puts message + end + + def setup_token(project_anchor) + unless project_anchor.token + ...
Allow to setup hesabu token in dhis2 datastore
diff --git a/lib/ebx/aws_s3.rb b/lib/ebx/aws_s3.rb index abc1234..def5678 100644 --- a/lib/ebx/aws_s3.rb +++ b/lib/ebx/aws_s3.rb @@ -9,8 +9,12 @@ app_bucket.objects[Settings.get(:s3_key)].tap do |o| unless o.exists? puts 'Bundling and pushing project' - zip = `git ls-tree -r --name-on...
Switch zip generation options to make .config files work Not sure exactly what the issue is here, but calling `zip - -@` was resulting in a differently constructed zip file than `zip name.zip -@` and therefore eb config files were not getting run. Strangely everything else seemed to work and the archive created in bot...
diff --git a/spec/app.rb b/spec/app.rb index abc1234..def5678 100644 --- a/spec/app.rb +++ b/spec/app.rb @@ -1,19 +1,5 @@-require 'sinatra/asset_pipeline' - module Example class App < Sinatra::Base - configure do - # Asset configuration and settings - set root: File.expand_path('../../', __FILE__) - ...
Remove references to asset pipeline
diff --git a/config/initializers/delayed_job_config.rb b/config/initializers/delayed_job_config.rb index abc1234..def5678 100644 --- a/config/initializers/delayed_job_config.rb +++ b/config/initializers/delayed_job_config.rb @@ -6,7 +6,7 @@ Delayed::Worker.destroy_failed_jobs = false Delayed::Worker.sleep_delay = 2 D...
Increase delayed jobs max run time
diff --git a/lib/phpcop/cli.rb b/lib/phpcop/cli.rb index abc1234..def5678 100644 --- a/lib/phpcop/cli.rb +++ b/lib/phpcop/cli.rb @@ -2,6 +2,8 @@ # The CLI is a class responsible of handling all the command line interface # logic class CLI + EXT = %w('.php').freeze + attr_reader :options, :config_store ...
Add test file ins php type
diff --git a/lib/travis/hub/exception.rb b/lib/travis/hub/exception.rb index abc1234..def5678 100644 --- a/lib/travis/hub/exception.rb +++ b/lib/travis/hub/exception.rb @@ -1,6 +1,6 @@ module Travis class Hub - class Exception + class Exception < StandardError attr_reader :event, :payload, :exception ...
Revert "Revert "Hub::Exception should inherit from StandardError"" This reverts commit a1e6d4ccc8fb60c7b812c821b61efaab07ee80fc.
diff --git a/lib/tasks/s3.rake b/lib/tasks/s3.rake index abc1234..def5678 100644 --- a/lib/tasks/s3.rake +++ b/lib/tasks/s3.rake @@ -0,0 +1,15 @@+namespace :s3 do + desc "Upload clean assets to S3 (percentage: fraction of assets to upload; default: 0)" + task :upload_all_clean_assets, [:percentage] => [:environment] ...
Add rake task to upload assets to S3 This iterates through the assets and enqueues a job to upload those that have a file on the NFS mount (this should be most of them). The jobs are enqueued with a "lower" priority (10) than the default (0) [1] with the idea that they should not interfere with publishing apps uploadi...
diff --git a/make-sponsors.rb b/make-sponsors.rb index abc1234..def5678 100644 --- a/make-sponsors.rb +++ b/make-sponsors.rb @@ -0,0 +1,19 @@+require "yaml" +print "Enter the event in YYYY-city format: " +cityname = gets.chomp +config = YAML.load_file("data/events/#{cityname}.yml") +sponsors = config['sponsors'] +spons...
Create script for generating sponsor files This ruby script basically reads in a city config file and creates the sponsor file associated with it. It will NOT create the images, naturally, but this will make it somewhat easier.
diff --git a/lib/docker_test.rb b/lib/docker_test.rb index abc1234..def5678 100644 --- a/lib/docker_test.rb +++ b/lib/docker_test.rb @@ -5,10 +5,7 @@ require 'securerandom' require 'set' -TIMEOUT = 1000 - -Excon.defaults[:write_timeout] = TIMEOUT -Excon.defaults[:read_timeout] = TIMEOUT +Docker.options = { read_time...
Use a different timeout style
diff --git a/lib/kosmos/packages/cacteye.rb b/lib/kosmos/packages/cacteye.rb index abc1234..def5678 100644 --- a/lib/kosmos/packages/cacteye.rb +++ b/lib/kosmos/packages/cacteye.rb @@ -2,6 +2,7 @@ title 'CactEye Telescope' aliases 'cacteye' url 'https://app.box.com/s/89skim2e3simjwmuof4c' + postrequisite 'cact...
Add CactEye bugfix as postrequisite.
diff --git a/lib/middleware/health_check.rb b/lib/middleware/health_check.rb index abc1234..def5678 100644 --- a/lib/middleware/health_check.rb +++ b/lib/middleware/health_check.rb @@ -7,9 +7,9 @@ return @app.call(env) unless env["PATH_INFO"] == "/health_check" if database_up? - response(200, {status: "...
Fix style issues in health check
diff --git a/lib/pagelet_rails/encryptor.rb b/lib/pagelet_rails/encryptor.rb index abc1234..def5678 100644 --- a/lib/pagelet_rails/encryptor.rb +++ b/lib/pagelet_rails/encryptor.rb @@ -41,7 +41,7 @@ def encryptor @encryptor ||= begin key = self.class.get_key secret, salt - + key = key[0..31] A...
Fix error : key must be 32 bytes
diff --git a/lib/podio/models/item_field.rb b/lib/podio/models/item_field.rb index abc1234..def5678 100644 --- a/lib/podio/models/item_field.rb +++ b/lib/podio/models/item_field.rb @@ -12,8 +12,10 @@ class << self # https://developers.podio.com/doc/items/update-item-field-values-22367 def update(item_id, fi...
Handle silent updates of item field values
diff --git a/lib/lodo/string.rb b/lib/lodo/string.rb index abc1234..def5678 100644 --- a/lib/lodo/string.rb +++ b/lib/lodo/string.rb @@ -3,23 +3,22 @@ LED_COUNT = 100 def initialize - @core = Core - @device = @core.open_device - @buffer = @core::Buffer.new + @device = Core.open_device + ...
Change back to old Core scheme in String
diff --git a/lib/on_the_spot.rb b/lib/on_the_spot.rb index abc1234..def5678 100644 --- a/lib/on_the_spot.rb +++ b/lib/on_the_spot.rb @@ -5,7 +5,9 @@ class Engine < ::Rails::Engine config.before_initialize do - config.action_view.javascript_expansions[:on_the_spot] = %w(jquery.jeditable.mini.js on_the_spot...
Make sure javascript_expansions config option exists
diff --git a/lib/tasks/relocate_manual.rake b/lib/tasks/relocate_manual.rake index abc1234..def5678 100644 --- a/lib/tasks/relocate_manual.rake +++ b/lib/tasks/relocate_manual.rake @@ -0,0 +1,10 @@+require "manual_relocator" +require "logger" + +desc <<-EndDesc +Relocate manual from <from-slug> to <to-slug> +Both <from...
Add Rake task to relocate manuals I don't fully understand the use case for this script but we've agreed to wrap it in a Rake task to prevent us from removing it in future. We tried to remove it in PR #878 but @h-lame pointed out that it might still be useful for certain support requests that come in. Note that commi...
diff --git a/lib/update_repo/git_control.rb b/lib/update_repo/git_control.rb index abc1234..def5678 100644 --- a/lib/update_repo/git_control.rb +++ b/lib/update_repo/git_control.rb @@ -0,0 +1,70 @@+require 'update_repo/version' +require 'update_repo/helpers' +require 'open3' + +module UpdateRepo + # Class : GitControl...
Move all the git update logic into a new class Signed-off-by: Grant Ramsay <4ab1b2fdb7784a8f9b55e81e3261617f44fd0585@gmail.com>
diff --git a/lib/upstream/tracker/helper.rb b/lib/upstream/tracker/helper.rb index abc1234..def5678 100644 --- a/lib/upstream/tracker/helper.rb +++ b/lib/upstream/tracker/helper.rb @@ -29,6 +29,10 @@ File.join(get_config_dir, COMPONENT_FILE) end + def load_component + YAML.load_file(get_com...
Add method to load components from YAML
diff --git a/example/config.ru b/example/config.ru index abc1234..def5678 100644 --- a/example/config.ru +++ b/example/config.ru @@ -4,7 +4,7 @@ require 'pact_broker' # Create a real database, and set the credentials for it here -DATABASE_CREDENTIALS = {database: "pact_broker_database.sqlite3", adapter: "sqlite"} +D...
Set default encoding to utf-8 in example app. This is required for the sha foreign key to work between the pact table and the pact_version_content table.
diff --git a/lib/tic_tac_toe.rb b/lib/tic_tac_toe.rb index abc1234..def5678 100644 --- a/lib/tic_tac_toe.rb +++ b/lib/tic_tac_toe.rb @@ -8,6 +8,6 @@ def TicTacToe.run game = TicTacToe::Game.new(TicTacToe::Board.new) shell = TicTacToe::ConsoleShell.new(IO::console, game) - shell.game_loop + shell.main_...
Make the game use the main loop instead of game loop
diff --git a/markdown-style.rb b/markdown-style.rb index abc1234..def5678 100644 --- a/markdown-style.rb +++ b/markdown-style.rb @@ -3,4 +3,5 @@ exclude_rule 'line-length' exclude_rule 'no-duplicate-header' +rule 'no-trailing-punctuation', :punctuation => '.,;:!' rule 'ul-indent', :indent => 4
Allow headers to end with a question mark By default, Markdown lint warns about various header-trailing punctuation characters, including question marks: <https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md#md007---unordered-list-indentation>. Allowing question marks makes sense here, since the affe...
diff --git a/qa/qa/runtime/api/client.rb b/qa/qa/runtime/api/client.rb index abc1234..def5678 100644 --- a/qa/qa/runtime/api/client.rb +++ b/qa/qa/runtime/api/client.rb @@ -25,15 +25,12 @@ private def create_personal_access_token - if @is_new_session - Runtime::Browser.visit(@addr...
Allow login validation before block Removes a block so that the login page is validated before the block, while the login page is still present, instead of after it when the login page is long gone
diff --git a/queue_classic_admin.gemspec b/queue_classic_admin.gemspec index abc1234..def5678 100644 --- a/queue_classic_admin.gemspec +++ b/queue_classic_admin.gemspec @@ -17,7 +17,7 @@ s.files = Dir["{app,config,db,lib,vendor}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.md"] s.test_files = Dir["test/**/*"] - ...
Add support for Rails 6.0
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-messaging' - s.version = '0.18.0.0' + s.version = '0.18.1.0' s.summary = 'Common primitives for ...
Package version is increased from 0.18.0.0 to 0.18.1.0
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-messaging' - s.version = '0.29.0.0' + s.version = '0.29.0.1' s.summary = 'Common primitives for ...
Package version is increased from 0.29.0.0 to 0.29.0.1
diff --git a/db/migrate/20121008001854_add_purchases_count_to_tags.rb b/db/migrate/20121008001854_add_purchases_count_to_tags.rb index abc1234..def5678 100644 --- a/db/migrate/20121008001854_add_purchases_count_to_tags.rb +++ b/db/migrate/20121008001854_add_purchases_count_to_tags.rb @@ -1,9 +1,5 @@ class AddPurchasesC...
Fix migration to add purchases counter cache column
diff --git a/spec/system/supervisors/editing_incidents_spec.rb b/spec/system/supervisors/editing_incidents_spec.rb index abc1234..def5678 100644 --- a/spec/system/supervisors/editing_incidents_spec.rb +++ b/spec/system/supervisors/editing_incidents_spec.rb @@ -3,33 +3,38 @@ require 'spec_helper' describe 'editing in...
Update editing incidents supervisor system tests
diff --git a/rundeck/rundeck_get_projects.rb b/rundeck/rundeck_get_projects.rb index abc1234..def5678 100644 --- a/rundeck/rundeck_get_projects.rb +++ b/rundeck/rundeck_get_projects.rb @@ -0,0 +1,58 @@+#!/usr/bin/env ruby + +#@author:: 'weezhard' +#@usage:: 'Delete projects rundeck' +#@licence:: 'GPL' +#@version:...
Add script get projects rundeck
diff --git a/recipes/vmware_fusion.rb b/recipes/vmware_fusion.rb index abc1234..def5678 100644 --- a/recipes/vmware_fusion.rb +++ b/recipes/vmware_fusion.rb @@ -1,6 +1,2 @@-dmg_package "VMWare Fusion" do - source "http://download2us.softpedia.com/dl/a5bdb8f0e2faf4dcea62bf272213d56c/513376a7/400024122/mac/System-Utilit...
Update VMWare Fusion to follow brew-cask VMWare Fusion was recently added to homebrew-cask.
diff --git a/app/models/application_draft.rb b/app/models/application_draft.rb index abc1234..def5678 100644 --- a/app/models/application_draft.rb +++ b/app/models/application_draft.rb @@ -15,6 +15,14 @@ define_method "as_#{role}?" do # def as_student? team.send(role.pluralize).include?...
Add proxy methods for students' attributes
diff --git a/app/models/budget_statistics.rb b/app/models/budget_statistics.rb index abc1234..def5678 100644 --- a/app/models/budget_statistics.rb +++ b/app/models/budget_statistics.rb @@ -9,4 +9,36 @@ @budget.categories.map {|category| {:value => category.used_this_month.to_i, :color => category.color} } end ...
Add monthly trend to budget statistics
diff --git a/app/models/transaction_split.rb b/app/models/transaction_split.rb index abc1234..def5678 100644 --- a/app/models/transaction_split.rb +++ b/app/models/transaction_split.rb @@ -1,3 +1,5 @@ class TransactionSplit < ActiveRecord::Base belongs_to :transaction_record + has_many :pie_piece_transaction_splits...
Add TxSplit has_many PiePieces association
diff --git a/app/models/manageiq/providers/amazon/cloud_manager/refresher.rb b/app/models/manageiq/providers/amazon/cloud_manager/refresher.rb index abc1234..def5678 100644 --- a/app/models/manageiq/providers/amazon/cloud_manager/refresher.rb +++ b/app/models/manageiq/providers/amazon/cloud_manager/refresher.rb @@ -1,1...
Change AWS Cloud Refresher to the new format Change AWS Cloud Refresher to the new format separating collection from parsing. We use Inventory abstraction for the inventory collection and parsing.
diff --git a/app/controllers/admin/features_controller.rb b/app/controllers/admin/features_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/features_controller.rb +++ b/app/controllers/admin/features_controller.rb @@ -10,7 +10,7 @@ def create @features_fields = Feature.non_common_fields....
Fix a bug with ruby 1.8.7 when inserting/updating features
diff --git a/spec/keywhiz_spec.rb b/spec/keywhiz_spec.rb index abc1234..def5678 100644 --- a/spec/keywhiz_spec.rb +++ b/spec/keywhiz_spec.rb @@ -23,21 +23,13 @@ its(:args) { should match(/keywhiz-server-shaded\.jar/) } end - # Check if TCP port 4444 is listening - describe command('nc -z 127....
Testing: Disable port checking on CircleCI
diff --git a/spec/nomnoml_spec.rb b/spec/nomnoml_spec.rb index abc1234..def5678 100644 --- a/spec/nomnoml_spec.rb +++ b/spec/nomnoml_spec.rb @@ -27,6 +27,6 @@ include_examples "block_macro", :nomnoml, code, [:svg] end -describe Asciidoctor::Diagram::NomnomlBlockProcessor, :broken_on_windows do +describe Asciidocto...
Enable nomnoml tests on Windows
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index abc1234..def5678 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -2,8 +2,8 @@ require File.expand_path('../../config/environment', __FILE__) abort("The Rails environment is running in production mode!") if Rails.env.production? +require '...
Change order in requires to fix tests
diff --git a/spec/weibull_spec.rb b/spec/weibull_spec.rb index abc1234..def5678 100644 --- a/spec/weibull_spec.rb +++ b/spec/weibull_spec.rb @@ -0,0 +1,120 @@+require 'spec_helper' +require 'statistical/rng/weibull' +require 'statistical/distribution/weibull' + +describe Statistical::Rng::Weibull do + it 'passes the G...
Add pending specs for weibull distribution
diff --git a/lib/autobots/page_objects.rb b/lib/autobots/page_objects.rb index abc1234..def5678 100644 --- a/lib/autobots/page_objects.rb +++ b/lib/autobots/page_objects.rb @@ -31,7 +31,7 @@ require_relative 'page_objects/property_details' require_relative 'page_objects/my_rent' require_relative 'page_objects/mbs' -r...
[PH][00000000] Restructure search tests: Change SearchBy page object to GenericSearch; move a generic search test to new GenericSearch test case
diff --git a/app/models/metrics.rb b/app/models/metrics.rb index abc1234..def5678 100644 --- a/app/models/metrics.rb +++ b/app/models/metrics.rb @@ -1,5 +1,5 @@ class Metrics < Sequel::Model(:metrics) plugin :timestamps - one_to_one :pod + many_to_one :pod end
[Metrics] Fix model, use many_to_one, even if it is conceptually one_to_one.
diff --git a/Casks/firefox-nightly-ja.rb b/Casks/firefox-nightly-ja.rb index abc1234..def5678 100644 --- a/Casks/firefox-nightly-ja.rb +++ b/Casks/firefox-nightly-ja.rb @@ -0,0 +1,9 @@+class FirefoxNightlyJa < Cask + version '35.0a1' + sha256 '9cde18aabb838684c41e124b50b67006e842f29b12d4f9fa9ab3c5fa964aa12f' + + url...
Upgrade Firefox Nightly Ja to v35.0a1
diff --git a/lib/style/style.rb b/lib/style/style.rb index abc1234..def5678 100644 --- a/lib/style/style.rb +++ b/lib/style/style.rb @@ -19,6 +19,7 @@ if bg_color && !bg_color.empty? formatting << "," if formatting_changed formatting << "bg="+bg_color + formatting_changed = true end f...
Return formatting even if only the background has changed
diff --git a/lib/tapjoy/ldap.rb b/lib/tapjoy/ldap.rb index abc1234..def5678 100644 --- a/lib/tapjoy/ldap.rb +++ b/lib/tapjoy/ldap.rb @@ -2,7 +2,6 @@ require 'yaml' require 'optimist' require 'memoist' -require 'pry' require_relative 'ldap/cli' require_relative 'ldap/base' require_relative 'ldap/key'
Remove runtime requirement on pry gem.
diff --git a/lib/user_agents.rb b/lib/user_agents.rb index abc1234..def5678 100644 --- a/lib/user_agents.rb +++ b/lib/user_agents.rb @@ -0,0 +1,10 @@+module XP + USER_AGENTS = { + ipad: 'Mozilla/5.0 (iPad; CPU OS 5_1 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9B176 Safari/7534.48.3', +...
Add user agents in separate file
diff --git a/lib/tasks/test_security.rake b/lib/tasks/test_security.rake index abc1234..def5678 100644 --- a/lib/tasks/test_security.rake +++ b/lib/tasks/test_security.rake @@ -2,30 +2,58 @@ namespace :security do task :setup # NOOP - Stub for consistent CI testing - desc "Run Brakeman" - task :brakeman ...
Add JSON output format to security scans Additionally, this commit allows plugins to be able to run the security scans from the plugin itself.
diff --git a/lib/time_tap/editor/xcode.rb b/lib/time_tap/editor/xcode.rb index abc1234..def5678 100644 --- a/lib/time_tap/editor/xcode.rb +++ b/lib/time_tap/editor/xcode.rb @@ -0,0 +1,24 @@+require 'appscript' + +class TimeTap::Editor::Xcode + include Appscript + + def initialize options = {} + end + + def is_run...
Add (experimental and untested) XCode support
diff --git a/sidekiq-unique-jobs.gemspec b/sidekiq-unique-jobs.gemspec index abc1234..def5678 100644 --- a/sidekiq-unique-jobs.gemspec +++ b/sidekiq-unique-jobs.gemspec @@ -17,6 +17,7 @@ gem.add_dependency 'sidekiq', '~> 2.6' gem.add_dependency 'mock_redis' gem.add_development_...
Put back accidentally committed rake removal
diff --git a/apps/redirects/app.rb b/apps/redirects/app.rb index abc1234..def5678 100644 --- a/apps/redirects/app.rb +++ b/apps/redirects/app.rb @@ -5,7 +5,8 @@ def initialize(app) super do # redirect ruby api to rubydoc.info - r301 %r{/api/cucumber/ruby/yardoc(.*)}, "http://www.rubydoc.info/...
Change redirects to cucumber-ruby instead of cucumber on rubydoc
diff --git a/spec/models/assessment_spec.rb b/spec/models/assessment_spec.rb index abc1234..def5678 100644 --- a/spec/models/assessment_spec.rb +++ b/spec/models/assessment_spec.rb @@ -21,19 +21,4 @@ end end - context 'STAR' do - context 'valid subject' do - let(:assessment) { FactoryBot.build(:assess...
Remove STAR from assessment spec
diff --git a/spec/peeek/hook/linker_spec.rb b/spec/peeek/hook/linker_spec.rb index abc1234..def5678 100644 --- a/spec/peeek/hook/linker_spec.rb +++ b/spec/peeek/hook/linker_spec.rb @@ -1,8 +1,15 @@ require 'peeek/hook/linker' describe Peeek::Hook::Linker, '.classes' do + before do + @class = Class.new(described_...
Delete class from Peeek::Hook::Linker.classes after test
diff --git a/core/app/models/concerns/spree/adjustment_source.rb b/core/app/models/concerns/spree/adjustment_source.rb index abc1234..def5678 100644 --- a/core/app/models/concerns/spree/adjustment_source.rb +++ b/core/app/models/concerns/spree/adjustment_source.rb @@ -4,20 +4,19 @@ included do def deals_wi...
Move all calculations to DB in AdjustmentSource Closes #364
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -9,7 +9,7 @@ install_puppet end hosts.each do |host| - on hosts, "mkdir -p #{host['distmoduledir']}" + on host, "mkdir -...
Fix the mkdir for moduledir
diff --git a/app/controllers/api/v1/countries_controller.rb b/app/controllers/api/v1/countries_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/countries_controller.rb +++ b/app/controllers/api/v1/countries_controller.rb @@ -1,7 +1,7 @@ class API::V1::CountriesController < API::APIController ...
Sort countries by name before output in API
diff --git a/app/models/nav_item.rb b/app/models/nav_item.rb index abc1234..def5678 100644 --- a/app/models/nav_item.rb +++ b/app/models/nav_item.rb @@ -2,6 +2,7 @@ belongs_to :url_page, class_name: "Page" + validates :title, presence: true validates :url_type, numericality: { only_integer: true } valid...
Add presence true validation for title in nav items model file
diff --git a/spec/web/controllers/authentication_jwt_strategy_spec.rb b/spec/web/controllers/authentication_jwt_strategy_spec.rb index abc1234..def5678 100644 --- a/spec/web/controllers/authentication_jwt_strategy_spec.rb +++ b/spec/web/controllers/authentication_jwt_strategy_spec.rb @@ -0,0 +1,70 @@+require 'spec_help...
Add specs for authentication jwt strategy
diff --git a/spec/commands/pipelined_spec.rb b/spec/commands/pipelined_spec.rb index abc1234..def5678 100644 --- a/spec/commands/pipelined_spec.rb +++ b/spec/commands/pipelined_spec.rb @@ -26,7 +26,7 @@ redis.get key2 end - results.should == [ value1, value2 ] + results.should == [value1, val...
Remove spaces around array contents
diff --git a/spec/plugin/run_handler_spec.rb b/spec/plugin/run_handler_spec.rb index abc1234..def5678 100644 --- a/spec/plugin/run_handler_spec.rb +++ b/spec/plugin/run_handler_spec.rb @@ -0,0 +1,53 @@+require File.expand_path("spec_helper", File.dirname(File.dirname(__FILE__))) + +describe "run_handler plugin" do + ...
Add spec for run_handler plugin, missed in previous commit
diff --git a/spec/requests/error_404_spec.rb b/spec/requests/error_404_spec.rb index abc1234..def5678 100644 --- a/spec/requests/error_404_spec.rb +++ b/spec/requests/error_404_spec.rb @@ -3,7 +3,7 @@ describe "404 Page Not Found" do - let(:station) { Station.make! } + let(:station) { create(:station) } cont...
Move 404 requests spec to factory_girl.
diff --git a/core/db/migrate/20130802022321_migrate_tax_categories_to_line_items.rb b/core/db/migrate/20130802022321_migrate_tax_categories_to_line_items.rb index abc1234..def5678 100644 --- a/core/db/migrate/20130802022321_migrate_tax_categories_to_line_items.rb +++ b/core/db/migrate/20130802022321_migrate_tax_categor...
Add exceptions for blank records in tax categories migration Fixes #4204
diff --git a/campfire/polling_bot/plugins/tweet_plugin.rb b/campfire/polling_bot/plugins/tweet_plugin.rb index abc1234..def5678 100644 --- a/campfire/polling_bot/plugins/tweet_plugin.rb +++ b/campfire/polling_bot/plugins/tweet_plugin.rb @@ -31,7 +31,7 @@ # strip links from CF messages def strip_links(msg) - ...
Fix link parsing in TweetPlugin
diff --git a/lib/allowance/permissions.rb b/lib/allowance/permissions.rb index abc1234..def5678 100644 --- a/lib/allowance/permissions.rb +++ b/lib/allowance/permissions.rb @@ -34,7 +34,7 @@ if p.is_a?(Hash) model.where(p) elsif p.is_a?(Proc) - (p.arity == 0 ? model.instance_exec(&p...
Simplify scope block code for now (fixes problems with 1.8.7)
diff --git a/lib/badge_overflow_config.rb b/lib/badge_overflow_config.rb index abc1234..def5678 100644 --- a/lib/badge_overflow_config.rb +++ b/lib/badge_overflow_config.rb @@ -0,0 +1,32 @@+require 'yaml' + +class BadgeOverflowConfig + attr_reader :config_file + + def self.instance + @@instance ||= new('config/use...
Add BadgeOverflowConfig class to configure user id
diff --git a/lib/bourgeois/view_helper.rb b/lib/bourgeois/view_helper.rb index abc1234..def5678 100644 --- a/lib/bourgeois/view_helper.rb +++ b/lib/bourgeois/view_helper.rb @@ -10,7 +10,6 @@ def present(object, klass = nil, &blk) return object.map { |o| present(o, klass, &blk) } if object.respond_to?(:to_a) ...
Remove useless presenter = nil
diff --git a/lib/git_release_notes/cli.rb b/lib/git_release_notes/cli.rb index abc1234..def5678 100644 --- a/lib/git_release_notes/cli.rb +++ b/lib/git_release_notes/cli.rb @@ -34,7 +34,7 @@ options[:from], options[:to], options[:git_web_url], - options[:exclude_submodules_without_changes], + ...
Fix regression in passing in negation of exclude_submodules option
diff --git a/lib/hatokura/fairy_garden.rb b/lib/hatokura/fairy_garden.rb index abc1234..def5678 100644 --- a/lib/hatokura/fairy_garden.rb +++ b/lib/hatokura/fairy_garden.rb @@ -1,5 +1,9 @@ module Hatokura module FairyGarden + def self.const_missing(identifier) + Hatokura.const_missing(identifier) + end + ...
Enable autoloading also in FairyGarden
diff --git a/lib/opal/hike_path_finder.rb b/lib/opal/hike_path_finder.rb index abc1234..def5678 100644 --- a/lib/opal/hike_path_finder.rb +++ b/lib/opal/hike_path_finder.rb @@ -6,7 +6,7 @@ def initialize(paths = Opal.paths) super() append_paths *paths - append_extensions '.js', '.js.rb', '.rb' + ...
Add opalerb to admitted path finder extensions
diff --git a/lib/rack_iframe_transport.rb b/lib/rack_iframe_transport.rb index abc1234..def5678 100644 --- a/lib/rack_iframe_transport.rb +++ b/lib/rack_iframe_transport.rb @@ -1,7 +1,8 @@ module Rack class IframeTransport - def initialize(app) + def initialize(app, tag = 'textarea') @app = app + @...
Allow to use different tag Sometimes is better to use pre instead of textarea because it have some issues with html inside of json object.
diff --git a/src/test/controllers/dashboard_controller_test.rb b/src/test/controllers/dashboard_controller_test.rb index abc1234..def5678 100644 --- a/src/test/controllers/dashboard_controller_test.rb +++ b/src/test/controllers/dashboard_controller_test.rb @@ -5,7 +5,12 @@ @user = users(:one) end - test "sh...
Test case without sign_in in addition
diff --git a/lib/bundler/feature_flag.rb b/lib/bundler/feature_flag.rb index abc1234..def5678 100644 --- a/lib/bundler/feature_flag.rb +++ b/lib/bundler/feature_flag.rb @@ -1,11 +1,15 @@ # frozen_string_literal: true module Bundler class FeatureFlag - def self.settings_flag(flag) + def self.settings_flag(flag...
[FeatureFlag] Add a default value block for settings flags
diff --git a/pakyow-test/lib/pakyow-test.rb b/pakyow-test/lib/pakyow-test.rb index abc1234..def5678 100644 --- a/pakyow-test/lib/pakyow-test.rb +++ b/pakyow-test/lib/pakyow-test.rb @@ -19,7 +19,7 @@ module Pakyow module TestHelp def self.setup - Pakyow::App.stage :test + Pakyow::App.stage(ENV['TEST_EN...
Use TEST_ENV when running tests