diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/features/consumer/account/settings_spec.rb b/spec/features/consumer/account/settings_spec.rb index abc1234..def5678 100644 --- a/spec/features/consumer/account/settings_spec.rb +++ b/spec/features/consumer/account/settings_spec.rb @@ -18,7 +18,12 @@ expect(page).to have_content I18n.t('spree.use...
Update account setting spec for updating email address
diff --git a/spec/features/save_parameters_in_localstorage_spec.rb b/spec/features/save_parameters_in_localstorage_spec.rb index abc1234..def5678 100644 --- a/spec/features/save_parameters_in_localstorage_spec.rb +++ b/spec/features/save_parameters_in_localstorage_spec.rb @@ -1,14 +1,20 @@-feature 'Save server URL in l...
Add test for all form parameters save in localStorage
diff --git a/spec/lib/core/entity/search_result_collection_spec.rb b/spec/lib/core/entity/search_result_collection_spec.rb index abc1234..def5678 100644 --- a/spec/lib/core/entity/search_result_collection_spec.rb +++ b/spec/lib/core/entity/search_result_collection_spec.rb @@ -13,6 +13,8 @@ it { is_expected.to respo...
Add test for `items` attribute
diff --git a/app/models/edition.rb b/app/models/edition.rb index abc1234..def5678 100644 --- a/app/models/edition.rb +++ b/app/models/edition.rb @@ -26,7 +26,7 @@ end def new_action(user,type,comment) - self.actions << Action.new(:requester=>self._id,:request_type=>type,:comment=>comment) + self.actions ...
Use requester_id for actions rather than requester
diff --git a/spec/controllers/dashboard_controller_spec.rb b/spec/controllers/dashboard_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/dashboard_controller_spec.rb +++ b/spec/controllers/dashboard_controller_spec.rb @@ -2,6 +2,14 @@ describe DashboardController do describe 'GET #show' do +...
Add sign in redirection in dashboard controller spec
diff --git a/app/models/asset.rb b/app/models/asset.rb index abc1234..def5678 100644 --- a/app/models/asset.rb +++ b/app/models/asset.rb @@ -18,7 +18,7 @@ def set_metadata if url =~ /\ |\[/ - self.url = URI.encode(url) + self.url = URI.encode(url,/\[\]/) end real_url = Link.resolve_uri(url)...
Deal with brackets in urls
diff --git a/app/models/email.rb b/app/models/email.rb index abc1234..def5678 100644 --- a/app/models/email.rb +++ b/app/models/email.rb @@ -4,7 +4,8 @@ def check_account account = Account.where(slug: self.to.split('@')[0]).first if account && !account.empty? - + self.account_id = account.id + sel...
Save the PLANT THE FLAG
diff --git a/htmlentities.gemspec b/htmlentities.gemspec index abc1234..def5678 100644 --- a/htmlentities.gemspec +++ b/htmlentities.gemspec @@ -14,5 +14,7 @@ s.test_files = Dir["test/*_test.rb"] s.has_rdoc = true s.extra_rdoc_files = %w[History.txt COPYING.txt] - s.homepage = "http://htm...
Add development dependencies to gemspec.
diff --git a/spec/support/matchers/method_type_matchers.rb b/spec/support/matchers/method_type_matchers.rb index abc1234..def5678 100644 --- a/spec/support/matchers/method_type_matchers.rb +++ b/spec/support/matchers/method_type_matchers.rb @@ -1,9 +1,11 @@-RSpec::Matchers.define :have_return_type do |type| +# @example...
Improve documentation for `have_return_type` rspec matcher
diff --git a/spec/unit/alf-support/test_to_ruby_literal.rb b/spec/unit/alf-support/test_to_ruby_literal.rb index abc1234..def5678 100644 --- a/spec/unit/alf-support/test_to_ruby_literal.rb +++ b/spec/unit/alf-support/test_to_ruby_literal.rb @@ -7,16 +7,14 @@ end it 'works on DateTime' do - dt = DateTime...
Fix to_ruby_literal test on DateTime/Time
diff --git a/Cartography.podspec b/Cartography.podspec index abc1234..def5678 100644 --- a/Cartography.podspec +++ b/Cartography.podspec @@ -11,7 +11,9 @@ s.homepage = "https://github.com/robb/Cartography" s.license = { :type => "MIT", :file => "LICENSE" } s.author = { "Robert Böhnke" => "robb@ro...
Set OS X deployment target
diff --git a/Casks/opera-beta.rb b/Casks/opera-beta.rb index abc1234..def5678 100644 --- a/Casks/opera-beta.rb +++ b/Casks/opera-beta.rb @@ -1,6 +1,6 @@ cask :v1 => 'opera-beta' do - version '29.0.1795.41' - sha256 'e7f013637993189ee96409fd647bbc00fa94bde544e2604c36cde230ad717063' + version '30.0.1835.18' + sha256 ...
Upgrade Opera Beta.app to v30.0.1835.18
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -12,7 +12,7 @@ end 100.times do - Student.create!(first_name: Faker::Name.first_name, last_name: Faker::Name.last_name, grade: 1, gpa: 1.5, detentions: 1, gender: 'M', teacher_id: rand(1..30)) + Student.create...
Change seed.rb to add snack food, shirt size
diff --git a/tests/spec/features/compilation_targets_spec.rb b/tests/spec/features/compilation_targets_spec.rb index abc1234..def5678 100644 --- a/tests/spec/features/compilation_targets_spec.rb +++ b/tests/spec/features/compilation_targets_spec.rb @@ -1,7 +1,10 @@ require 'spec_helper' require 'support/editor' +requi...
Add feature spec for MIR output
diff --git a/config/sitemap.rb b/config/sitemap.rb index abc1234..def5678 100644 --- a/config/sitemap.rb +++ b/config/sitemap.rb @@ -13,12 +13,17 @@ # Defaults: :priority => 0.5, :changefreq => 'weekly', # :lastmod => Time.now, :host => default_host - add events_path, priority: 0.8 - add '/kata'...
Add each podcast episode to Sitemap
diff --git a/config.rb b/config.rb index abc1234..def5678 100644 --- a/config.rb +++ b/config.rb @@ -51,3 +51,4 @@ deploy.user = 'nblock0330' deploy.password = "#{ENV['PASSWORD']}" end +
Fix my mistake and the corresponding merge conflict
diff --git a/howdoi.rb b/howdoi.rb index abc1234..def5678 100644 --- a/howdoi.rb +++ b/howdoi.rb @@ -3,7 +3,7 @@ class Howdoi < Formula homepage 'https://github.com/gleitz/howdoi/' url 'https://pypi.python.org/packages/23/2d/9790707eed08c802daee32183e7c98ec2e9797564dad229738b7f178e18e/howdoi-1.1.9.tar.gz' - sha1...
Add sha256 hash for Homebrew Fixes #151
diff --git a/spec/controllers/comments_controller_spec.rb b/spec/controllers/comments_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/comments_controller_spec.rb +++ b/spec/controllers/comments_controller_spec.rb @@ -9,13 +9,6 @@ @user.confirm! sign_in @user - end - - describe "GET ...
Remove Comments controller 'index' spec The 'index' action no longer exists, so the spec in the Comments controller should be removed.
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -23,12 +23,26 @@ end def edit + @user = User.find(params[:id]) end def update + @user = User.find(param...
Add destroy route to users controller
diff --git a/app/jobs/start_service_job.rb b/app/jobs/start_service_job.rb index abc1234..def5678 100644 --- a/app/jobs/start_service_job.rb +++ b/app/jobs/start_service_job.rb @@ -3,13 +3,16 @@ return if service.container_id fail 'Cannot be performed on an external service' unless service.hosted? - Rails...
Disable this for now as it's just hanging
diff --git a/app/models/in_app_purchase.rb b/app/models/in_app_purchase.rb index abc1234..def5678 100644 --- a/app/models/in_app_purchase.rb +++ b/app/models/in_app_purchase.rb @@ -27,6 +27,7 @@ new_expires_at = base_date + product[:time] user.plan = Plan.find_by_stripe_id("timed") user.expires_at = new_e...
Make sure user gets unsuspended.
diff --git a/app/models/page_attachment.rb b/app/models/page_attachment.rb index abc1234..def5678 100644 --- a/app/models/page_attachment.rb +++ b/app/models/page_attachment.rb @@ -12,6 +12,8 @@ :class_name => 'User', :foreign_key => 'updated_by' belongs_to :page + + attr_accessible :ti...
Fix title/description update (previously unable to update those information on available attachments). Make :title and :description attributes accessible
diff --git a/app/models/physical_server.rb b/app/models/physical_server.rb index abc1234..def5678 100644 --- a/app/models/physical_server.rb +++ b/app/models/physical_server.rb @@ -30,6 +30,6 @@ end def label_for_vendor - VENDOR_TYPES[vendor] + VENDOR_TYPES[vendor.downcase] end end
Fix vendor key in physical server Vendor key should be always downcase.
diff --git a/app/models/single_use_link.rb b/app/models/single_use_link.rb index abc1234..def5678 100644 --- a/app/models/single_use_link.rb +++ b/app/models/single_use_link.rb @@ -6,6 +6,28 @@ alias_attribute :itemId, :item_id after_initialize :set_defaults + + # rubocop:disable Naming/MethodName + def downlo...
Add deprecations for downloadKey and itemId
diff --git a/strong_routes.gemspec b/strong_routes.gemspec index abc1234..def5678 100644 --- a/strong_routes.gemspec +++ b/strong_routes.gemspec @@ -19,11 +19,11 @@ spec.require_paths = ["lib"] spec.add_dependency "rack" - spec.add_dependency "actionpack", ">= 3.2.0" + spec.add_development_dependency "action...
Make actionpack a dev dependency only
diff --git a/knife-vrealize.gemspec b/knife-vrealize.gemspec index abc1234..def5678 100644 --- a/knife-vrealize.gemspec +++ b/knife-vrealize.gemspec @@ -21,7 +21,7 @@ spec.required_ruby_version = ">= 2.5" - spec.add_dependency "knife-cloud", ">= 1.2.0", "< 4.0" + spec.add_dependency "knife-cloud", ">= 1.2.0",...
Update knife-cloud requirement from >= 1.2.0, < 4.0 to >= 1.2.0, < 5.0 Updates the requirements on [knife-cloud](https://github.com/chef/knife-cloud) to permit the latest version. - [Release notes](https://github.com/chef/knife-cloud/releases) - [Changelog](https://github.com/chef/knife-cloud/blob/master/CHANGELOG.md)...
diff --git a/lib/future-resource.rb b/lib/future-resource.rb index abc1234..def5678 100644 --- a/lib/future-resource.rb +++ b/lib/future-resource.rb @@ -11,9 +11,9 @@ !!@resource_lock.synchronize { defined? @resource } end - def resource + def resource(timeout = nil) @resource_lock.synchronize do - ...
Allow setting a timeout on waiting for a resource
diff --git a/lib/kamerling/value.rb b/lib/kamerling/value.rb index abc1234..def5678 100644 --- a/lib/kamerling/value.rb +++ b/lib/kamerling/value.rb @@ -2,17 +2,19 @@ module Kamerling class Value - include Virtus.value_object + class << self + def defaults(hash = {}) + hash.each do |name, default...
Switch Value to class << self
diff --git a/lib/lunar/stopwords.rb b/lib/lunar/stopwords.rb index abc1234..def5678 100644 --- a/lib/lunar/stopwords.rb +++ b/lib/lunar/stopwords.rb @@ -5,13 +5,13 @@ def include?(word) stopwords.include?(word.downcase) end + module_function :include? private def stopwords %w(an and ...
Make module_function declaration in stop words more explicit.
diff --git a/lib/simplemvc/utils.rb b/lib/simplemvc/utils.rb index abc1234..def5678 100644 --- a/lib/simplemvc/utils.rb +++ b/lib/simplemvc/utils.rb @@ -0,0 +1,14 @@+class String + def to_snake_case + gsub("::", "/"). + gsub(/([A-Z]+)([A-Z][a-z])/, "\1_\2"). + gsub(/([a-z]\d)([A-Z])/). + tr("-", "_")...
Allow for conversion to camel case and snake case for strings
diff --git a/lib/sub_diff/differ.rb b/lib/sub_diff/differ.rb index abc1234..def5678 100644 --- a/lib/sub_diff/differ.rb +++ b/lib/sub_diff/differ.rb @@ -3,6 +3,8 @@ module SubDiff class Differ + attr_reader :diffable, :collection + def initialize(diffable) @diffable = diffable @collection = D...
Make readers public to avoid weird ruby warnings See https://github.com/thoughtbot/guides/pull/190 See https://twitter.com/tomstuart/status/486143792140271616
diff --git a/config/initializers/reset_db.rb b/config/initializers/reset_db.rb index abc1234..def5678 100644 --- a/config/initializers/reset_db.rb +++ b/config/initializers/reset_db.rb @@ -1,3 +1,5 @@+require 'fileutils' + BASESPEC = {adapter: "sqlite3", database: "db/production.sqlite3", poo...
Change the logging to the app dir as well
diff --git a/brew/cask/awsaml.rb b/brew/cask/awsaml.rb index abc1234..def5678 100644 --- a/brew/cask/awsaml.rb +++ b/brew/cask/awsaml.rb @@ -1,6 +1,6 @@ cask 'awsaml' do - sha256 '8840a68b2e1c2ce1fa46a3bb830dd1d2d997e1e7cd49fdc7bcfec40351df97e4' version '2.0.0' + sha256 'cea42994cb52a71b8f811c38b25281604360b821688...
Update the SHA256 checksum for the v2.0.0 binary.
diff --git a/core/enumerator/produce_spec.rb b/core/enumerator/produce_spec.rb index abc1234..def5678 100644 --- a/core/enumerator/produce_spec.rb +++ b/core/enumerator/produce_spec.rb @@ -0,0 +1,36 @@+require_relative '../../spec_helper' + +ruby_version_is "2.7" do + describe "Enumerator.produce" do + it "creates ...
Add new specs. Added Enumerator.produce to generate an Enumerator from any custom data transformation
diff --git a/cg_service_client.gemspec b/cg_service_client.gemspec index abc1234..def5678 100644 --- a/cg_service_client.gemspec +++ b/cg_service_client.gemspec @@ -1,6 +1,4 @@-# -*- encoding: utf-8 -*-i -lib = File.expand_path('../lib/', __FILE__) -$:.unshift lib unless $:.include?(lib) +require 'gem/dependency_manage...
Use gem-dependency_management in gemspec. See CP-2346. git-svn-id: c3135c47f3c29d4ec17dc77fe0dea76971532c8f@9567 bc291798-7d79-44a5-a816-fbf4f7d05ffa
diff --git a/app/models/manageiq/providers/openstack/infra_manager/host/operations.rb b/app/models/manageiq/providers/openstack/infra_manager/host/operations.rb index abc1234..def5678 100644 --- a/app/models/manageiq/providers/openstack/infra_manager/host/operations.rb +++ b/app/models/manageiq/providers/openstack/infr...
Use task queue for set/unset node maintenance Uses task queue instead of making direct provider API calls from the UI. This PR contains the necessary model changes.
diff --git a/test/test_retryable_typhoeus.rb b/test/test_retryable_typhoeus.rb index abc1234..def5678 100644 --- a/test/test_retryable_typhoeus.rb +++ b/test/test_retryable_typhoeus.rb @@ -0,0 +1,33 @@+require_relative '../lib/retryable_typhoeus' + +module Unipept + class BatchIteratorTestCase < Unipept::TestCase + ...
Add tests for the retryable_typhoeus request patches
diff --git a/spec/uploaders/attachment_uploader_spec.rb b/spec/uploaders/attachment_uploader_spec.rb index abc1234..def5678 100644 --- a/spec/uploaders/attachment_uploader_spec.rb +++ b/spec/uploaders/attachment_uploader_spec.rb @@ -8,16 +8,16 @@ let(:uploader) { AttachmentUploader.new(comment, :attachment) } be...
Comment uploader spec until we can revisit
diff --git a/tty-which.gemspec b/tty-which.gemspec index abc1234..def5678 100644 --- a/tty-which.gemspec +++ b/tty-which.gemspec @@ -19,5 +19,6 @@ spec.require_paths = ["lib"] spec.add_development_dependency 'bundler', '>= 1.5.0', '< 2.0' + spec.add_development_dependency 'rspec', '~> 3.1' spec.add_developme...
Add rspec as dev dependency
diff --git a/tools/fetch_ago_mappings.rb b/tools/fetch_ago_mappings.rb index abc1234..def5678 100644 --- a/tools/fetch_ago_mappings.rb +++ b/tools/fetch_ago_mappings.rb @@ -1,74 +1,8 @@ #!/usr/bin/env ruby -w -require 'csv' -require 'uri' -require 'net/http' -require 'pathname' -class FetchAgoMappings - - def fetch ...
Use generic mapping fetcher for AGO mappings
diff --git a/db/migrate/20181020103501_revoke_variant_overrideswithout_permissions.rb b/db/migrate/20181020103501_revoke_variant_overrideswithout_permissions.rb index abc1234..def5678 100644 --- a/db/migrate/20181020103501_revoke_variant_overrideswithout_permissions.rb +++ b/db/migrate/20181020103501_revoke_variant_ove...
Speed up database queries and make them scale This commit makes use of three ActiveRecord features: 1. Using `select` instead of `all.map` enables ActiveRecord to nest one select into the other, resulting in one more efficient query instead of two. 2. Using `find_each` saves memory by loading records in batches. htt...
diff --git a/spec/controllers/application_controller_spec.rb b/spec/controllers/application_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/application_controller_spec.rb +++ b/spec/controllers/application_controller_spec.rb @@ -6,10 +6,9 @@ before { expect(error).to receive(:message).and_...
Add test for application controller.
diff --git a/recipes/delete_validation.rb b/recipes/delete_validation.rb index abc1234..def5678 100644 --- a/recipes/delete_validation.rb +++ b/recipes/delete_validation.rb @@ -17,7 +17,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -unless node[:recipes]....
FC001: Use strings in preference to symbols.
diff --git a/backend/spree_backend.gemspec b/backend/spree_backend.gemspec index abc1234..def5678 100644 --- a/backend/spree_backend.gemspec +++ b/backend/spree_backend.gemspec @@ -22,7 +22,7 @@ s.add_dependency 'spree_api', s.version s.add_dependency 'spree_core', s.version - s.add_dependency 'bootstrap', ...
Update bootstrap requirement from ~> 4.3.1 to >= 4.3.1, < 4.6.0 Updates the requirements on [bootstrap](https://github.com/twbs/bootstrap-rubygem) to permit the latest version. - [Release notes](https://github.com/twbs/bootstrap-rubygem/releases) - [Changelog](https://github.com/twbs/bootstrap-rubygem/blob/master/CHAN...
diff --git a/delayed_job/spec/spec_helper.rb b/delayed_job/spec/spec_helper.rb index abc1234..def5678 100644 --- a/delayed_job/spec/spec_helper.rb +++ b/delayed_job/spec/spec_helper.rb @@ -7,7 +7,7 @@ RAILS_ROOT = File.dirname(__FILE__) + '/rails' FileUtils.rm_rf RAILS_ROOT + '/db/test.sqlite3' -ActiveRecord::Base.e...
Use the same database path as the tests
diff --git a/lib/bummr/updater.rb b/lib/bummr/updater.rb index abc1234..def5678 100644 --- a/lib/bummr/updater.rb +++ b/lib/bummr/updater.rb @@ -36,7 +36,11 @@ end def updated_version_for(gem) - `bundle list | grep " #{gem[:name]} "`.split('(')[1].split(')')[0] + if (gem[:name].include?("(") && gem...
Handle absence of updated version
diff --git a/closed_struct.gemspec b/closed_struct.gemspec index abc1234..def5678 100644 --- a/closed_struct.gemspec +++ b/closed_struct.gemspec @@ -10,7 +10,7 @@ spec.email = ["pawel.obrok@gmail.com"] spec.summary = %q{An immutable, strict version of OpenStruct} spec.description = %q{ClosedStru...
Add homepage link to rubygems page Simplifies finding the source code repo when visiting the rubygems page.
diff --git a/lib/junit_adapter.rb b/lib/junit_adapter.rb index abc1234..def5678 100644 --- a/lib/junit_adapter.rb +++ b/lib/junit_adapter.rb @@ -4,7 +4,7 @@ COUNT_REGEXP = /Tests run: (\d+)/.freeze FAILURES_REGEXP = /Failures: (\d+)/.freeze SUCCESS_REGEXP = /OK \((\d+) tests?\)\s*(?:\x1B\]0;|exit)?\s*\z/.freeze...
Fix JUnit 4 for ArrayComparisonFailure
diff --git a/lib/kmc/refresher.rb b/lib/kmc/refresher.rb index abc1234..def5678 100644 --- a/lib/kmc/refresher.rb +++ b/lib/kmc/refresher.rb @@ -8,6 +8,7 @@ kmc_packages_path = Kmc::Configuration.packages_path output_path = File.join(kmc_packages_path, '..') + FileUtils::mkdir_p output_path ...
Create package folder if don't exists
diff --git a/lib/app/nitpick.rb b/lib/app/nitpick.rb index abc1234..def5678 100644 --- a/lib/app/nitpick.rb +++ b/lib/app/nitpick.rb @@ -2,6 +2,14 @@ post '/preview' do md(params[:comment]) + end + + get '/dashboard/:language/?' do |language| + redirect "/nitpick/#{language}/no-nits" + end + + get '/das...
Add redirects from the old dashboard
diff --git a/app/controllers/api/subscriptions_controller.rb b/app/controllers/api/subscriptions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/subscriptions_controller.rb +++ b/app/controllers/api/subscriptions_controller.rb @@ -4,6 +4,7 @@ def show if @account.subscription(api_subscrip...
Add more logging to PuSH callback
diff --git a/lib/yard/server/rack_adapter.rb b/lib/yard/server/rack_adapter.rb index abc1234..def5678 100644 --- a/lib/yard/server/rack_adapter.rb +++ b/lib/yard/server/rack_adapter.rb @@ -38,10 +38,9 @@ end def call(env) - @command ||= @command_class.new(@options) request = Rack::R...
Reset command on each request in Rack adapter
diff --git a/config/unicorn/staging.rb b/config/unicorn/staging.rb index abc1234..def5678 100644 --- a/config/unicorn/staging.rb +++ b/config/unicorn/staging.rb @@ -24,5 +24,4 @@ ActiveRecord::Base.establish_connection end -listen Integer(ENV['PORT'] || 3000) - +listen "/tmp/unicorn.manageiq.sock"
Use socket for nginx front-end
diff --git a/lib/ionic_notification/concerns/ionic_notificable.rb b/lib/ionic_notification/concerns/ionic_notificable.rb index abc1234..def5678 100644 --- a/lib/ionic_notification/concerns/ionic_notificable.rb +++ b/lib/ionic_notification/concerns/ionic_notificable.rb @@ -6,8 +6,9 @@ included do serializ...
Send notifications from within the model
diff --git a/config/initializers/assets.rb b/config/initializers/assets.rb index abc1234..def5678 100644 --- a/config/initializers/assets.rb +++ b/config/initializers/assets.rb @@ -9,3 +9,17 @@ # Precompile additional assets. # application.js, application.css, and all non-JS/CSS in app/assets folder are already added....
Add the themes to the search path.
diff --git a/lib/kaminari/mongo_mapper/plucky_criteria_methods.rb b/lib/kaminari/mongo_mapper/plucky_criteria_methods.rb index abc1234..def5678 100644 --- a/lib/kaminari/mongo_mapper/plucky_criteria_methods.rb +++ b/lib/kaminari/mongo_mapper/plucky_criteria_methods.rb @@ -6,8 +6,8 @@ delegate :default_per_page,...
Use I18n to pluralize entries see: https://github.com/amatsuda/kaminari/commit/7f6e9a877d646263dc0504a5ad96ef4d5f2dd684
diff --git a/core/db/migrate/20140205120320_create_spree_payment_capture_events.rb b/core/db/migrate/20140205120320_create_spree_payment_capture_events.rb index abc1234..def5678 100644 --- a/core/db/migrate/20140205120320_create_spree_payment_capture_events.rb +++ b/core/db/migrate/20140205120320_create_spree_payment_c...
Use decimal field for capture_events, just like payment table
diff --git a/features/support/screenshots.rb b/features/support/screenshots.rb index abc1234..def5678 100644 --- a/features/support/screenshots.rb +++ b/features/support/screenshots.rb @@ -8,7 +8,7 @@ AfterStep do |scenario| cdir = ENV['CAPTURE_DIR'] now = Time.now.to_f - fn = Shellwords.escape("#{cdir}/...
Move timestamp for easier sorting.
diff --git a/app/controllers/puddy/transactions_controller.rb b/app/controllers/puddy/transactions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/puddy/transactions_controller.rb +++ b/app/controllers/puddy/transactions_controller.rb @@ -3,6 +3,12 @@ @transaction_state = 'All' @transactions ...
Add show method for transactions
diff --git a/app/presenters/medical_safety_alert_presenter.rb b/app/presenters/medical_safety_alert_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/medical_safety_alert_presenter.rb +++ b/app/presenters/medical_safety_alert_presenter.rb @@ -2,6 +2,7 @@ delegate( :alert_type, :medical_special...
Add issued date to medical safety alerts Add the issued date attribute to the medical safety alaert date metadata in the presenter so that it can be shown in the frontend. This corresponds to this commit in specialist publisher: https://github.com/alphagov/specialist-publisher/pull/281 The trello ticket can be found...
diff --git a/WDAlertView.podspec b/WDAlertView.podspec index abc1234..def5678 100644 --- a/WDAlertView.podspec +++ b/WDAlertView.podspec @@ -1,12 +1,13 @@ Pod::Spec.new do |spec| spec.name = 'WDAlertView' + spec.platform = :ios spec.version = '1.0.0' spec.license = { :type => 'MI...
Change pod spec source reference
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -1,6 +1,23 @@ require File.expand_path('../boot', __FILE__) -require 'rails/all' +#require 'rails/all' + +# Include each railties manually, excluding `active_storage/engi...
Disable ActiveStorage to avoid heroku warn when deploy
diff --git a/spec/build/job/test/php_spec.rb b/spec/build/job/test/php_spec.rb index abc1234..def5678 100644 --- a/spec/build/job/test/php_spec.rb +++ b/spec/build/job/test/php_spec.rb @@ -3,8 +3,8 @@ describe Travis::Build::Job::Test::Php do let(:shell) { stub('shell') } - let(:config) { Travis::Build::Job::Tes...
Revert "Fix php builder spec." This reverts commit ecb8adbc7f9db773978c8a8c8606c76e9667158b. I am reverting all attempts to fix php builder. There are people who supposed to maintain it.
diff --git a/spec/factories/interventions.rb b/spec/factories/interventions.rb index abc1234..def5678 100644 --- a/spec/factories/interventions.rb +++ b/spec/factories/interventions.rb @@ -23,7 +23,7 @@ end trait :non_atp_intervention do - intervention_type { InterventionType.find_by_name('Extra Dance')...
Change factory intervention name to match InterventionTypes
diff --git a/lib/dizby/utility/timed_state.rb b/lib/dizby/utility/timed_state.rb index abc1234..def5678 100644 --- a/lib/dizby/utility/timed_state.rb +++ b/lib/dizby/utility/timed_state.rb @@ -33,7 +33,7 @@ private def progress - @time = 0 + @time -= @timeout @state = case @state ...
Reduce the time of a TimedState object rather than setting it to zero This allows for long periods of time between updates to not result in even longer living times for objects.
diff --git a/lib/epub/searcher/publication.rb b/lib/epub/searcher/publication.rb index abc1234..def5678 100644 --- a/lib/epub/searcher/publication.rb +++ b/lib/epub/searcher/publication.rb @@ -4,7 +4,6 @@ module Searcher class Publication class << self - # @todo Use named argument in the future ...
Remove todo comment that was done
diff --git a/db/migrate/20140721152149_add_created_at_to_supporters_action_jobs.rb b/db/migrate/20140721152149_add_created_at_to_supporters_action_jobs.rb index abc1234..def5678 100644 --- a/db/migrate/20140721152149_add_created_at_to_supporters_action_jobs.rb +++ b/db/migrate/20140721152149_add_created_at_to_supporter...
Fix typo in table name
diff --git a/lib/liberic/sdk/configuration.rb b/lib/liberic/sdk/configuration.rb index abc1234..def5678 100644 --- a/lib/liberic/sdk/configuration.rb +++ b/lib/liberic/sdk/configuration.rb @@ -1,7 +1,7 @@ module Liberic module SDK module Configuration - LIBERICAPI_VERSION = %w(23.2.12.0 23.3.8.0) + LI...
Include 23.2.6.0 as supported libcapi versions Apparently the package filename is 23.3.8.0 while the contained libs return 23.3.6.0 as versions.
diff --git a/lib/partitioned.rb b/lib/partitioned.rb index abc1234..def5678 100644 --- a/lib/partitioned.rb +++ b/lib/partitioned.rb @@ -16,6 +16,7 @@ require 'partitioned/by_yearly_time_field' require 'partitioned/by_monthly_time_field' require 'partitioned/by_weekly_time_field' +require 'partitioned/by_daily_time_f...
Add a require of by_daily_time_field
diff --git a/lib/manage_engine/app_manager.rb b/lib/manage_engine/app_manager.rb index abc1234..def5678 100644 --- a/lib/manage_engine/app_manager.rb +++ b/lib/manage_engine/app_manager.rb @@ -1,5 +1,6 @@-require File.expand_path(File.dirname(__FILE__) + '/app_manager/version') -require File.expand_path(File.dirname(__...
Update AppManager new Method Documentation Update the comments within the AppManager module to more specifically denote what parameters are required for the new method.
diff --git a/lib/propr/maybe.rb b/lib/propr/maybe.rb index abc1234..def5678 100644 --- a/lib/propr/maybe.rb +++ b/lib/propr/maybe.rb @@ -1,6 +1,24 @@ module Propr class Maybe + end + + class << Maybe + def run(computation) + computation + end + + def unit(value) + Some.new(value) + end + + ...
Implement monad instance for Maybe
diff --git a/lib/rusty_blank.rb b/lib/rusty_blank.rb index abc1234..def5678 100644 --- a/lib/rusty_blank.rb +++ b/lib/rusty_blank.rb @@ -1,9 +1,10 @@ require 'fiddle' require 'rbconfig' +require 'thermite/config' -ext = RbConfig::CONFIG['DLEXT'] == 'bundle' ? 'dylib' : RbConfig::CONFIG['DLEXT'] -basename = "librusty...
Use Thermite::Config to load the library via Fiddle in a cross-platform way
diff --git a/figaro.gemspec b/figaro.gemspec index abc1234..def5678 100644 --- a/figaro.gemspec +++ b/figaro.gemspec @@ -6,8 +6,8 @@ gem.authors = ["Steve Richert"] gem.email = ["steve.richert@gmail.com"] - gem.description = %q{TODO: Write a gem description} - gem.summary = %q{TODO: Write a gem s...
Write the gem summary and description
diff --git a/lib/sequel/extensions/db_opts.rb b/lib/sequel/extensions/db_opts.rb index abc1234..def5678 100644 --- a/lib/sequel/extensions/db_opts.rb +++ b/lib/sequel/extensions/db_opts.rb @@ -18,10 +18,21 @@ end def apply(c) - execute_meth = c.respond_to?(:log_connection_execute) ? :log_connectio...
Fix bug where SET commands never finish Turns out that we're calling Impala::Connection#execute and that opens up a cursor, but never closes it. As a hacky, quick fix, Sequelizer will check for a cursor and close it if it can.
diff --git a/lib/super_resources/resources.rb b/lib/super_resources/resources.rb index abc1234..def5678 100644 --- a/lib/super_resources/resources.rb +++ b/lib/super_resources/resources.rb @@ -30,7 +30,7 @@ end def memoize_collection(&block) - @collection ||= block.call + @_collection ||= block.cal...
Make resource and collection ivars "private"
diff --git a/lib/tty/prompt/reader/win_api.rb b/lib/tty/prompt/reader/win_api.rb index abc1234..def5678 100644 --- a/lib/tty/prompt/reader/win_api.rb +++ b/lib/tty/prompt/reader/win_api.rb @@ -12,12 +12,24 @@ CRT_HANDLE = Handle.new("msvcrt") rescue Handle.new("crtdll") + # Get a character from the c...
Change to document windows api calls
diff --git a/lib/metric_fu/metrics/rails_best_practices/rails_best_practices_bluff_grapher.rb b/lib/metric_fu/metrics/rails_best_practices/rails_best_practices_bluff_grapher.rb index abc1234..def5678 100644 --- a/lib/metric_fu/metrics/rails_best_practices/rails_best_practices_bluff_grapher.rb +++ b/lib/metric_fu/metric...
Fix problem with missing rails best practice count.
diff --git a/future_wrapper.rb b/future_wrapper.rb index abc1234..def5678 100644 --- a/future_wrapper.rb +++ b/future_wrapper.rb @@ -11,23 +11,23 @@ class FutureWrapper # Take a key and hash where the matcher can eventually be fetched, and # optionally take a rename value and a Proc to extend the result. - ...
Change name of instance variable so it makes more sense for a subclass
diff --git a/Casks/little-snitch.rb b/Casks/little-snitch.rb index abc1234..def5678 100644 --- a/Casks/little-snitch.rb +++ b/Casks/little-snitch.rb @@ -1,6 +1,6 @@ cask :v1 => 'little-snitch' do - version '3.5.3' - sha256 'cfe44ba45c669e1bf9a04910b2dd8675a26d7e6c00954b74adeffd12f90b8197' + version '3.6' + sha256 '...
Upgrade Little Snitch to v3.6
diff --git a/sidekiq-redis-logger.gemspec b/sidekiq-redis-logger.gemspec index abc1234..def5678 100644 --- a/sidekiq-redis-logger.gemspec +++ b/sidekiq-redis-logger.gemspec @@ -1,11 +1,11 @@ # -*- encoding: utf-8 -*- -lib = File.expand_path('../lib', __FILE__) +lib = File.expand_path("../lib", __FILE__) $LOAD_PATH.uns...
Fix the gemspec for the version
diff --git a/lib/bitex_bot/models/open_buy.rb b/lib/bitex_bot/models/open_buy.rb index abc1234..def5678 100644 --- a/lib/bitex_bot/models/open_buy.rb +++ b/lib/bitex_bot/models/open_buy.rb @@ -2,9 +2,11 @@ # OpenBuys are open buy positions that are closed by one or several CloseBuys. # TODO: document attributes. # -c...
Use nested module/class definitions instead of compact style.
diff --git a/lib/debot/recipes/fast_assets.rb b/lib/debot/recipes/fast_assets.rb index abc1234..def5678 100644 --- a/lib/debot/recipes/fast_assets.rb +++ b/lib/debot/recipes/fast_assets.rb @@ -0,0 +1,27 @@+set :assets_dependencies, %w(public app/assets lib/assets vendor/assets Gemfile.lock config/routes.rb) + +namespac...
Add debot assets precompile for public assets mainly
diff --git a/workers/worker_base.rb b/workers/worker_base.rb index abc1234..def5678 100644 --- a/workers/worker_base.rb +++ b/workers/worker_base.rb @@ -4,7 +4,12 @@ Thread.new do loop do sleep(self.timeout) - self.work + begin + self.work + rescue => ex +...
Add basic exception handling for workers
diff --git a/fixed_array.rb b/fixed_array.rb index abc1234..def5678 100644 --- a/fixed_array.rb +++ b/fixed_array.rb @@ -19,7 +19,7 @@ private def name(index) raise IndexError unless (0...size).include?(index) - "@index#{index}" + :"@index#{index}" end end
Change string to symbol for stylistic reasons
diff --git a/lib/ar_doc_store/attribute_types/datetime_attribute.rb b/lib/ar_doc_store/attribute_types/datetime_attribute.rb index abc1234..def5678 100644 --- a/lib/ar_doc_store/attribute_types/datetime_attribute.rb +++ b/lib/ar_doc_store/attribute_types/datetime_attribute.rb @@ -1,42 +1,15 @@ module ArDocStore modu...
Remove now-unnecessary implementation details in DateTimeAttribute
diff --git a/lib/generators/spree_address_book/install_generator.rb b/lib/generators/spree_address_book/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/spree_address_book/install_generator.rb +++ b/lib/generators/spree_address_book/install_generator.rb @@ -1,21 +1,23 @@ module SpreeAddressBook ...
Add possibility to run migration automatically
diff --git a/spec/generators/heat_spec.rb b/spec/generators/heat_spec.rb index abc1234..def5678 100644 --- a/spec/generators/heat_spec.rb +++ b/spec/generators/heat_spec.rb @@ -10,6 +10,7 @@ :description => 'sample template', :parameters => [], :resources => [], + :files => [], } te...
Test Heat generates the required properties Signed-off-by: Tomas Sedovic <2bc6038c3dfca09b2da23c8b6da8ba884dc2dcc2@sedovic.cz>
diff --git a/spec/java-properties_spec.rb b/spec/java-properties_spec.rb index abc1234..def5678 100644 --- a/spec/java-properties_spec.rb +++ b/spec/java-properties_spec.rb @@ -1,3 +1,4 @@+# coding: utf-8 require 'helper' describe JavaProperties do @@ -21,7 +22,7 @@ end it "writes to file" do - with_temp_...
Add source encoding hint for ruby 1.9.3 Otherwise the tests fail on 1.9.3
diff --git a/spec/models/question_spec.rb b/spec/models/question_spec.rb index abc1234..def5678 100644 --- a/spec/models/question_spec.rb +++ b/spec/models/question_spec.rb @@ -20,6 +20,7 @@ expect(@vote.voteable).to be_instance_of(Question) end end + end describe Question do
Add missing end of input
diff --git a/filterrific.gemspec b/filterrific.gemspec index abc1234..def5678 100644 --- a/filterrific.gemspec +++ b/filterrific.gemspec @@ -11,6 +11,7 @@ gem.authors = ['Jo Hund'] gem.email = 'jhund@clearcove.ca' gem.homepage = 'http://filterrific.clearcove.ca' + gem.license = 'MIT' gem.licenses = ['MIT']...
Add the single license attribute Some verifiers don't appear to correctly parse the licenses attribute, so adding the single license version.
diff --git a/measurable.gemspec b/measurable.gemspec index abc1234..def5678 100644 --- a/measurable.gemspec +++ b/measurable.gemspec @@ -24,7 +24,7 @@ gem.required_ruby_version = '>= 1.9.3' gem.add_development_dependency 'bundler' - gem.add_development_dependency 'rake', '~> 10.1' - gem.add_development_depende...
Update rake & rdoc versions Older rake versions had a security hole that was patched in 12.3.3.
diff --git a/lib/motion-sqlite3/result_set.rb b/lib/motion-sqlite3/result_set.rb index abc1234..def5678 100644 --- a/lib/motion-sqlite3/result_set.rb +++ b/lib/motion-sqlite3/result_set.rb @@ -15,41 +15,29 @@ private - def columns - columns = {} + def current_row + row = {} - count = sqli...
Remove unnecessary object churn in ResultSet
diff --git a/app/models/kennedy/post.rb b/app/models/kennedy/post.rb index abc1234..def5678 100644 --- a/app/models/kennedy/post.rb +++ b/app/models/kennedy/post.rb @@ -4,5 +4,16 @@ attr_accessible :category_ids has_and_belongs_to_many :categories + searchable do + string :month, stored: true + ...
Add month & categories to index
diff --git a/app/models/single_value.rb b/app/models/single_value.rb index abc1234..def5678 100644 --- a/app/models/single_value.rb +++ b/app/models/single_value.rb @@ -2,10 +2,10 @@ @@mutex = Mutex.new def self.update(value) - sublcass_name = self.name + subclass_name = self.name single_value = nil ...
Fix SingleValue.get: only get values for the SingleValue Subclass
diff --git a/memoizable.gemspec b/memoizable.gemspec index abc1234..def5678 100644 --- a/memoizable.gemspec +++ b/memoizable.gemspec @@ -1,22 +1,23 @@-lib = File.expand_path('../lib', __FILE__) -$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) -require 'memoizable/version' +require File.expand_path('../lib/memoi...
Change gemspec to match other gems
diff --git a/db/migrate/20160505130158_fix_gss_codes_for_some_councils_in_existing_support_schemes.rb b/db/migrate/20160505130158_fix_gss_codes_for_some_councils_in_existing_support_schemes.rb index abc1234..def5678 100644 --- a/db/migrate/20160505130158_fix_gss_codes_for_some_councils_in_existing_support_schemes.rb ++...
Fix GSS codes for some councils in existing Business Support editions - Following on from frontend PR 948, we had to edit existing Business Support Editions so that they would refer to the correct GSS codes from the new data in MapIt, not the old ones that no longer worked. This migration does just that, replaci...
diff --git a/puppet-lint-duplicate_class_parameters-check.gemspec b/puppet-lint-duplicate_class_parameters-check.gemspec index abc1234..def5678 100644 --- a/puppet-lint-duplicate_class_parameters-check.gemspec +++ b/puppet-lint-duplicate_class_parameters-check.gemspec @@ -22,7 +22,7 @@ spec.add_development_dependency...
Update rubocop requirement from ~> 0.81.0 to ~> 0.82.0 Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](h...
diff --git a/test/integration/idle_loop_test.rb b/test/integration/idle_loop_test.rb index abc1234..def5678 100644 --- a/test/integration/idle_loop_test.rb +++ b/test/integration/idle_loop_test.rb @@ -1,8 +1,29 @@ require 'gir_ffi_test_helper' + +class Foo + def initialize + @handler = proc { self.idle_handler; fal...
Add simple idle loop implementation
diff --git a/mock_redis.gemspec b/mock_redis.gemspec index abc1234..def5678 100644 --- a/mock_redis.gemspec +++ b/mock_redis.gemspec @@ -20,5 +20,4 @@ s.add_development_dependency "redis", "~> 2.2.1" s.add_development_dependency "rspec", "~> 2.6.0" - s.add_development_dependency "ZenTest" end
Drop ZenTest as a development dependency ZenTest wants to force the evil that is RubyGems 1.8 on us, but accepting that would mean journeying into a world of spammy deprecation notices. Change-Id: I0badd3f46edb73d25b56c9723630215c15455d9e Reviewed-on: https://gerrit.causes.com/1524 Tested-by: Greg Hurrell <79e2475f81...
diff --git a/model_base.gemspec b/model_base.gemspec index abc1234..def5678 100644 --- a/model_base.gemspec +++ b/model_base.gemspec @@ -27,5 +27,6 @@ spec.add_development_dependency "rake", "~> 10.0" spec.add_development_dependency "rspec", "~> 3.0" spec.add_development_dependency "rspec-its" + spec.add_devel...
Add dependency to rspec-rails to load generators in it