diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/roles/bytemark.rb b/roles/bytemark.rb index abc1234..def5678 100644 --- a/roles/bytemark.rb +++ b/roles/bytemark.rb @@ -3,7 +3,7 @@ default_attributes( :networking => { - :nameservers => [ "[2001:41c8:2::2]", "[2001:41c8:2::1]", "80.68.80.25", "80.68.80.24" ], + :nameservers => [ "8.8.8.8", "8.8...
BM: Switch to Google Public DNS until long replies reliable
diff --git a/app/models/guest_device.rb b/app/models/guest_device.rb index abc1234..def5678 100644 --- a/app/models/guest_device.rb +++ b/app/models/guest_device.rb @@ -20,4 +20,8 @@ def self.with_ethernet_type where(:device_type => "ethernet") end + + def self.with_storage_type + where(:device_type => "s...
Implement the with_storage_type named_scope for physical server
diff --git a/rails/pluralization/hu.rb b/rails/pluralization/hu.rb index abc1234..def5678 100644 --- a/rails/pluralization/hu.rb +++ b/rails/pluralization/hu.rb @@ -1,3 +1,3 @@-require 'rails_i18n/common_pluralizations/other' +require 'rails_i18n/common_pluralizations/one_other' ::RailsI18n::Pluralization::OneOther....
Fix incorrect `require` added in 7838ad5. This didn't break tests, I imagine that's because the test suite was already importing `one_other` via some other file?
diff --git a/files/gitlab-cookbooks/gitlab/recipes/users.rb b/files/gitlab-cookbooks/gitlab/recipes/users.rb index abc1234..def5678 100644 --- a/files/gitlab-cookbooks/gitlab/recipes/users.rb +++ b/files/gitlab-cookbooks/gitlab/recipes/users.rb @@ -27,6 +27,7 @@ account "GitLab user and group" do username gitlab_use...
Set correct gid for gitlab user.
diff --git a/Casks/appcode-eap.rb b/Casks/appcode-eap.rb index abc1234..def5678 100644 --- a/Casks/appcode-eap.rb +++ b/Casks/appcode-eap.rb @@ -1,6 +1,6 @@ cask :v1 => 'appcode-eap' do - version '141.2000.4' - sha256 '964a077f89c3317116aeb566d398c96754f3eb06474f3c7039974f38197123ac' + version '141.2263.29' + sha25...
Update AppCode EAP to build 141.2263.29 This commit updates the version and sha256 stanzas
diff --git a/Casks/appcode-eap.rb b/Casks/appcode-eap.rb index abc1234..def5678 100644 --- a/Casks/appcode-eap.rb +++ b/Casks/appcode-eap.rb @@ -1,8 +1,8 @@ cask :v1 => 'appcode-eap' do version '3.2.0' - sha256 '2dd8a0a9246067ae6e092b9934cbadac6730a74fe400c8929b09792a0c0cda83' + sha256 'fa78dc8e2a7430e7173cecec7b6...
Update AppCode EAP to latest build This commit updates the sha256 and url stanzas. The version of the app itself has not changed.
diff --git a/Casks/jira-client.rb b/Casks/jira-client.rb index abc1234..def5678 100644 --- a/Casks/jira-client.rb +++ b/Casks/jira-client.rb @@ -1,6 +1,6 @@ cask :v1 => 'jira-client' do - version '3.6.2' - sha256 '6add59e92511f6017fc8cc5d74e14ec78c31e3f8e29df7dc0b63acb5e1261fe6' + version '3.7.0' + sha256 'c4a4b45b...
Upgrade JIRA Client to 3.7.0
diff --git a/app/decorators/user_decorator.rb b/app/decorators/user_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/user_decorator.rb +++ b/app/decorators/user_decorator.rb @@ -8,7 +8,7 @@ def admin_link_with_popover(chapter=nil) common_opts = { data: { toggle: "popover", content: h.html_escape_o...
Fix typo that stopped admin info popovers working on chapter/event pages in the eadmin interface.
diff --git a/Casks/iphone-configuration-utility.rb b/Casks/iphone-configuration-utility.rb index abc1234..def5678 100644 --- a/Casks/iphone-configuration-utility.rb +++ b/Casks/iphone-configuration-utility.rb @@ -4,4 +4,5 @@ version '3.5' sha256 '822204947ae5f7739bcb1e9694814f8e3ef65cd184952b76104f525d97a28163' ...
Add uninstall stanza for iPhone Configuration Utility
diff --git a/spec/graph_spec.rb b/spec/graph_spec.rb index abc1234..def5678 100644 --- a/spec/graph_spec.rb +++ b/spec/graph_spec.rb @@ -10,6 +10,18 @@ graph1 = Graph::Graph.new('graph1') graph1.name.should eq('graph1') graph1.nodes.empty?.should eq(true) + end + + end + + describe ...
Add a spec for an add method as part of the Graph class.
diff --git a/spec/features/clubs/list_spec.rb b/spec/features/clubs/list_spec.rb index abc1234..def5678 100644 --- a/spec/features/clubs/list_spec.rb +++ b/spec/features/clubs/list_spec.rb @@ -0,0 +1,15 @@+require 'spec_helper.rb' + +feature "Viewing a list of Clubs", js: true do + let(:club_list){FactoryGirl::create_...
Add list feature spec for clubs
diff --git a/spec/pdfs/statements_pdf_spec.rb b/spec/pdfs/statements_pdf_spec.rb index abc1234..def5678 100644 --- a/spec/pdfs/statements_pdf_spec.rb +++ b/spec/pdfs/statements_pdf_spec.rb @@ -0,0 +1,21 @@+require "spec_helper" + +describe StatementsPdf do + + describe "#render" do + context "with one statement for...
Add basic spec to verify minimal statement pdf renders something This is just a sanity check to make sure something hasn't fundamentally broken in the rendering of a statement. It does not ensure that the pdf was correctly rendered, just that *something* was rendered.
diff --git a/spec/rspec/git_specifier_spec.rb b/spec/rspec/git_specifier_spec.rb index abc1234..def5678 100644 --- a/spec/rspec/git_specifier_spec.rb +++ b/spec/rspec/git_specifier_spec.rb @@ -21,9 +21,25 @@ it { is_expected.to all(match(/\A.*(?:\n\Z|\n\n)/)) } # force second line to be blank it { is_exp...
Add examples for testing commit message length
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -5,7 +5,7 @@ ENV['RAILS_ENV'] = 'test' # require File.expand_path("../dummy/config/environment.rb", __FILE__) -require File.expand_path('../rails421/config/environment.rb', __F...
Use the installed Rails 6.1 application for tests
diff --git a/spec/support/an_active_object.rb b/spec/support/an_active_object.rb index abc1234..def5678 100644 --- a/spec/support/an_active_object.rb +++ b/spec/support/an_active_object.rb @@ -4,6 +4,7 @@ let(:child_class) { Class.new(described_class) } subject { child_class.new } + before { child_class.send(:...
Make some protected methods available in testing
diff --git a/db/migrate/20151029212113_add_indices_and_uniqueness.rb b/db/migrate/20151029212113_add_indices_and_uniqueness.rb index abc1234..def5678 100644 --- a/db/migrate/20151029212113_add_indices_and_uniqueness.rb +++ b/db/migrate/20151029212113_add_indices_and_uniqueness.rb @@ -1,6 +1,5 @@ class AddIndicesAndUniq...
Remove index from user table
diff --git a/spec/optioneer_spec.rb b/spec/optioneer_spec.rb index abc1234..def5678 100644 --- a/spec/optioneer_spec.rb +++ b/spec/optioneer_spec.rb @@ -6,7 +6,6 @@ end it 'should create an instance of the class with no errors' do - settings = Optioneer.new - expect(settings).to be_a Optioneer + expect(...
Use rspec 'subject' instead of explicitly creating instance. Signed-off-by: Seapagan <4ab1b2fdb7784a8f9b55e81e3261617f44fd0585@gmail.com>
diff --git a/spec/colorls_spec.rb b/spec/colorls_spec.rb index abc1234..def5678 100644 --- a/spec/colorls_spec.rb +++ b/spec/colorls_spec.rb @@ -1,11 +1,29 @@ require 'spec_helper' RSpec.describe ColorLS do + FIXTURES = 'spec/fixtures'.freeze + it 'has a version number' do expect(ColorLS::VERSION).not_to be...
Add specs for --all & --report flags
diff --git a/app/uploaders/avatar_uploader.rb b/app/uploaders/avatar_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/avatar_uploader.rb +++ b/app/uploaders/avatar_uploader.rb @@ -19,6 +19,10 @@ process resize_to_fill: [270, 260] end + version :v1_large do + process resize_to_fill: [370, 290] ...
Add large avatar version for speaker
diff --git a/app/controllers/steps_controller.rb b/app/controllers/steps_controller.rb index abc1234..def5678 100644 --- a/app/controllers/steps_controller.rb +++ b/app/controllers/steps_controller.rb @@ -19,8 +19,6 @@ render :visitors elsif slots_step_needed? render :slots - elsif confirm_step_nee...
Remove unexercised branch for now We'll add it when we test it.
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -39,12 +39,16 @@ def update @user = User.find_by(id: params[:id]) - if @user.update_attributes(username:...
Add auth to POST '/users'
diff --git a/app/models/concerns/globalizable.rb b/app/models/concerns/globalizable.rb index abc1234..def5678 100644 --- a/app/models/concerns/globalizable.rb +++ b/app/models/concerns/globalizable.rb @@ -16,6 +16,10 @@ def description self.read_attribute(:description).try :html_safe end + + if self....
Add paranoid behavior to translations of paranoid models We want to be able to fetch soft deleted translations without using with_deleted scope.
diff --git a/LAPickerView.podspec b/LAPickerView.podspec index abc1234..def5678 100644 --- a/LAPickerView.podspec +++ b/LAPickerView.podspec @@ -10,7 +10,7 @@ # s.screenshots = "www.example.com/screenshots_1", "www.example.com/screenshots_2" s.license = 'MIT' s.author = { "Luis Laugga" => "luis@laug...
Add https for git repository url.
diff --git a/lib/openc_bot/helpers/pseudo_machine_parser.rb b/lib/openc_bot/helpers/pseudo_machine_parser.rb index abc1234..def5678 100644 --- a/lib/openc_bot/helpers/pseudo_machine_parser.rb +++ b/lib/openc_bot/helpers/pseudo_machine_parser.rb @@ -14,21 +14,34 @@ def parse(fetched_datum) # implement i...
Allow external bots persisting parsed data record-by-record by yielding a block
diff --git a/lib/rails_soft_deletable/rails/associations.rb b/lib/rails_soft_deletable/rails/associations.rb index abc1234..def5678 100644 --- a/lib/rails_soft_deletable/rails/associations.rb +++ b/lib/rails_soft_deletable/rails/associations.rb @@ -9,7 +9,7 @@ return if options[:polymorphic] && klass.nil? ...
Use with_deleted instead of unscoped
diff --git a/K9LogPatternFormatter.podspec b/K9LogPatternFormatter.podspec index abc1234..def5678 100644 --- a/K9LogPatternFormatter.podspec +++ b/K9LogPatternFormatter.podspec @@ -19,6 +19,7 @@ spec.subspec 'Lumberjack' do |lumberjack| lumberjack.source_files = 'Classes/Lumberjack/**/*.{h,m}' + lumberjack....
Add common dependency in subspec
diff --git a/db/migrate/20190206235733_change_drug_id_to_bigint.rb b/db/migrate/20190206235733_change_drug_id_to_bigint.rb index abc1234..def5678 100644 --- a/db/migrate/20190206235733_change_drug_id_to_bigint.rb +++ b/db/migrate/20190206235733_change_drug_id_to_bigint.rb @@ -0,0 +1,9 @@+class ChangeDrugIdToBigint < Ac...
Update drug_id primary key to bigint
diff --git a/fastlane-plugin-trainer/lib/fastlane/plugin/trainer/actions/trainer_action.rb b/fastlane-plugin-trainer/lib/fastlane/plugin/trainer/actions/trainer_action.rb index abc1234..def5678 100644 --- a/fastlane-plugin-trainer/lib/fastlane/plugin/trainer/actions/trainer_action.rb +++ b/fastlane-plugin-trainer/lib/f...
Use scan’s derived data by default
diff --git a/spec/cfer_spec.rb b/spec/cfer_spec.rb index abc1234..def5678 100644 --- a/spec/cfer_spec.rb +++ b/spec/cfer_spec.rb @@ -5,6 +5,11 @@ class B < Cfer::Resource def c(e) d e + end + + def post_block + super + i "j" end end end @@ -42,8 +47,12 @@ e...
Test for post_block k/v pairs
diff --git a/spec/memo_spec.rb b/spec/memo_spec.rb index abc1234..def5678 100644 --- a/spec/memo_spec.rb +++ b/spec/memo_spec.rb @@ -2,14 +2,22 @@ describe 'memoized rules' do specify 'memoized symbol prefix' do - direction = Calyx::Grammar.new(123) do + grammar = Calyx::Grammar.new do rule :start, "E...
Add additional tests of memoized symbols in template strings
diff --git a/spec/path_spec.rb b/spec/path_spec.rb index abc1234..def5678 100644 --- a/spec/path_spec.rb +++ b/spec/path_spec.rb @@ -0,0 +1,67 @@+require 'spec_helper' + +RSpec.describe Path do + describe '.new' do + it 'constructs a cleansed path' do + path = described_class.new("./hoopty/doopty/doo\n") + ...
Add test coverage for the Path class Why you made the change: I did this so that we would have some safety when evolving and refactoring this code base.
diff --git a/lib/thinking_sphinx/active_record/collection_proxy.rb b/lib/thinking_sphinx/active_record/collection_proxy.rb index abc1234..def5678 100644 --- a/lib/thinking_sphinx/active_record/collection_proxy.rb +++ b/lib/thinking_sphinx/active_record/collection_proxy.rb @@ -13,8 +13,11 @@ private def a...
Handle through associations in model.association.search calls
diff --git a/sentry-ruby/sentry-ruby.gemspec b/sentry-ruby/sentry-ruby.gemspec index abc1234..def5678 100644 --- a/sentry-ruby/sentry-ruby.gemspec +++ b/sentry-ruby/sentry-ruby.gemspec @@ -23,5 +23,5 @@ spec.require_paths = ["lib"] spec.add_dependency "faraday", ">= 1.0" - spec.add_dependency "concurrent-ruby" ...
Add clearer requirement on concurrent-ruby
diff --git a/spec/controllers/statistics_controller_spec.rb b/spec/controllers/statistics_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/statistics_controller_spec.rb +++ b/spec/controllers/statistics_controller_spec.rb @@ -0,0 +1,34 @@+require 'rails_helper' + +describe StatisticsController do...
Add tests for statistics controller routes
diff --git a/lib/generators/public_activity/migration/templates/migration.rb b/lib/generators/public_activity/migration/templates/migration.rb index abc1234..def5678 100644 --- a/lib/generators/public_activity/migration/templates/migration.rb +++ b/lib/generators/public_activity/migration/templates/migration.rb @@ -9,7...
Remove deprecation warning during migrate about timestamps This warning occurs when you tried to rake:db migrate in a rails 4.2 application. It's a deprecation warning for upcoming rails 5, a null option need to be given : DEPRECATION WARNING: `#timestamp` was called without specifying an option for `null`. In Rails ...
diff --git a/ruby/open-location-code.gemspec b/ruby/open-location-code.gemspec index abc1234..def5678 100644 --- a/ruby/open-location-code.gemspec +++ b/ruby/open-location-code.gemspec @@ -5,7 +5,7 @@ Gem::Specification.new do |s| s.name = "open-location-code" - s.version = "1.0.2" + s.version ...
Bump Ruby version to 1.0.3.
diff --git a/rails_event_store/lib/rails_event_store/repositories/event_repository.rb b/rails_event_store/lib/rails_event_store/repositories/event_repository.rb index abc1234..def5678 100644 --- a/rails_event_store/lib/rails_event_store/repositories/event_repository.rb +++ b/rails_event_store/lib/rails_event_store/repo...
Use supported Rails methods for finding all events
diff --git a/spec/features/home_page_spec.rb b/spec/features/home_page_spec.rb index abc1234..def5678 100644 --- a/spec/features/home_page_spec.rb +++ b/spec/features/home_page_spec.rb @@ -1,3 +1,5 @@+require 'rails_helper' + RSpec.feature 'Home page' do scenario 'visit the home page' do visit root_path
Include 'rails_helper' in home page spec
diff --git a/schema.gemspec b/schema.gemspec index abc1234..def5678 100644 --- a/schema.gemspec +++ b/schema.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'evt-schema' s.summary = "Primitives for schema and data structure" - s.version = '2.3.1.2' + s.version = '2.3.1.1' s.description = ' ' ...
Package version is increased from 2.3.1.2 to 2.3.1.1
diff --git a/smappy.gemspec b/smappy.gemspec index abc1234..def5678 100644 --- a/smappy.gemspec +++ b/smappy.gemspec @@ -11,7 +11,7 @@ s.email = "tomeric@eet.nu" s.homepage = "http://github.com/eet-nu/smappy" - s.files = Dir["{lib}/**/*"] + ["LICENSE", "Rakefile", "Gemfile", "README.md"] + s.f...
Add markers/ and spec/ files to gemspec
diff --git a/activerecord/lib/active_record/encryption/extended_deterministic_uniqueness_validator.rb b/activerecord/lib/active_record/encryption/extended_deterministic_uniqueness_validator.rb index abc1234..def5678 100644 --- a/activerecord/lib/active_record/encryption/extended_deterministic_uniqueness_validator.rb ++...
Remove N+1 validation for encrypted attributes
diff --git a/spec/unit/data_mapper/mapper/class_methods/from_spec.rb b/spec/unit/data_mapper/mapper/class_methods/from_spec.rb index abc1234..def5678 100644 --- a/spec/unit/data_mapper/mapper/class_methods/from_spec.rb +++ b/spec/unit/data_mapper/mapper/class_methods/from_spec.rb @@ -4,17 +4,15 @@ subject { described...
Clean up spec for Mapper.from
diff --git a/plugins/graphite/graphite.rb b/plugins/graphite/graphite.rb index abc1234..def5678 100644 --- a/plugins/graphite/graphite.rb +++ b/plugins/graphite/graphite.rb @@ -3,9 +3,9 @@ hostname = `hostname -s`.chomp! -host = config[:host] || 'localhost' -port = config[:port] || '2003' -path = config[:path] || h...
Rename path variable to prefix.
diff --git a/UIViewAppearanceSwift.podspec b/UIViewAppearanceSwift.podspec index abc1234..def5678 100644 --- a/UIViewAppearanceSwift.podspec +++ b/UIViewAppearanceSwift.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.module_name = 'UIViewAppearanceSwift' - s.name = 'UICommon' + s.name = 'UIViewAppearanceSwift' s...
Update date name of spec
diff --git a/lib/active_touch/touch_job.rb b/lib/active_touch/touch_job.rb index abc1234..def5678 100644 --- a/lib/active_touch/touch_job.rb +++ b/lib/active_touch/touch_job.rb @@ -13,10 +13,8 @@ associated.send(after_touch) unless after_touch.blank? elsif !associated.nil? - associated.each do |...
Revert the individual touches for grouped associations.
diff --git a/lib/cortex/snippets/client.rb b/lib/cortex/snippets/client.rb index abc1234..def5678 100644 --- a/lib/cortex/snippets/client.rb +++ b/lib/cortex/snippets/client.rb @@ -23,7 +23,7 @@ if defined?(Rails) url = sanitized_webpage_url(request.original_url) Rails.cache.fetch("webpage...
Fix reference to Webpage class
diff --git a/lib/graphql/interface_type.rb b/lib/graphql/interface_type.rb index abc1234..def5678 100644 --- a/lib/graphql/interface_type.rb +++ b/lib/graphql/interface_type.rb @@ -23,7 +23,7 @@ # class InterfaceType < GraphQL::BaseType include GraphQL::BaseType::HasPossibleTypes - accepts_definitions :res...
Allow Interface.define to accept fields
diff --git a/lib/rohbau/it_behaves_like.rb b/lib/rohbau/it_behaves_like.rb index abc1234..def5678 100644 --- a/lib/rohbau/it_behaves_like.rb +++ b/lib/rohbau/it_behaves_like.rb @@ -1,4 +1,4 @@-require 'minitest' +require 'minitest/spec' module Rohbau module ItBehavesLike
Change minitest require into minitest/spec
diff --git a/lib/saasable/saas_document.rb b/lib/saasable/saas_document.rb index abc1234..def5678 100644 --- a/lib/saasable/saas_document.rb +++ b/lib/saasable/saas_document.rb @@ -2,8 +2,8 @@ @saas_document = nil def self.included klass - if @saas_document and @saas_document != klass - raise Saasable:...
Fix the bug with the Saasable::SaasDocument reloading with a different address.
diff --git a/lib/tasks/populate_image.rake b/lib/tasks/populate_image.rake index abc1234..def5678 100644 --- a/lib/tasks/populate_image.rake +++ b/lib/tasks/populate_image.rake @@ -0,0 +1,47 @@+$image_types = ['ccam_images', 'fcam_images', 'rcam_images', 'ncam_images', 'mastcam_left_images', 'mastcam_right_images', 'ma...
Use rake task to fetch images instead of db seed script
diff --git a/guard-annotate.gemspec b/guard-annotate.gemspec index abc1234..def5678 100644 --- a/guard-annotate.gemspec +++ b/guard-annotate.gemspec @@ -13,6 +13,11 @@ s.description = %q{Guard::Annotate automatically runs the annotate gem when needed} s.license = "MIT" + s.post_install_message = %Q(** guard...
Add post install message to gemspec
diff --git a/spec/integration/snmpjr_spec.rb b/spec/integration/snmpjr_spec.rb index abc1234..def5678 100644 --- a/spec/integration/snmpjr_spec.rb +++ b/spec/integration/snmpjr_spec.rb @@ -0,0 +1,9 @@+describe "snmpjr" do + + describe 'GET' do + it "can perform a simple synchronous get request on an snmp agent" do ...
Add simple get integration spec
diff --git a/app/controllers/answers_controller.rb b/app/controllers/answers_controller.rb index abc1234..def5678 100644 --- a/app/controllers/answers_controller.rb +++ b/app/controllers/answers_controller.rb @@ -1,23 +1,29 @@ class AnswersController < ApplicationController def create + question = Question.find...
Add create action for answers
diff --git a/app/models/salary_booking_template.rb b/app/models/salary_booking_template.rb index abc1234..def5678 100644 --- a/app/models/salary_booking_template.rb +++ b/app/models/salary_booking_template.rb @@ -1,6 +1,4 @@ class SalaryBookingTemplate < BookingTemplate - default_scope order(:code) - # Obligation f...
Move default order to BookingTemplate.
diff --git a/spec/models/event_spec.rb b/spec/models/event_spec.rb index abc1234..def5678 100644 --- a/spec/models/event_spec.rb +++ b/spec/models/event_spec.rb @@ -1,5 +1,14 @@ require 'rails_helper' RSpec.describe Event, type: :model do - pending "add some examples to (or delete) #{__FILE__}" + + it { is_expecte...
Add validation and enum specs for event objects
diff --git a/spec/mumukit/user_spec.rb b/spec/mumukit/user_spec.rb index abc1234..def5678 100644 --- a/spec/mumukit/user_spec.rb +++ b/spec/mumukit/user_spec.rb @@ -0,0 +1,15 @@+require 'spec_helper' + +describe Mumukit::Auth::User do + describe 'build_metadata' do + let(:user) { { bibliotheca: 'foo/bar', classroom...
Add tests for user logic
diff --git a/rubiniusvm/compiler/compiler.rb b/rubiniusvm/compiler/compiler.rb index abc1234..def5678 100644 --- a/rubiniusvm/compiler/compiler.rb +++ b/rubiniusvm/compiler/compiler.rb @@ -15,7 +15,10 @@ end parser.input file, line + parser.print + printer = compiler.packager.print + pri...
Print generated bytecode, useful for compaing what we produce and what actually generates rbx
diff --git a/fassets-presentations.gemspec b/fassets-presentations.gemspec index abc1234..def5678 100644 --- a/fassets-presentations.gemspec +++ b/fassets-presentations.gemspec @@ -7,8 +7,8 @@ Gem::Specification.new do |s| s.name = "fassets-presentations" s.version = FassetsPresentations::VERSION - s....
Add our names and email adresses to the gemspec-file.
diff --git a/lib/cli/modular_options.rb b/lib/cli/modular_options.rb index abc1234..def5678 100644 --- a/lib/cli/modular_options.rb +++ b/lib/cli/modular_options.rb @@ -1,8 +1,10 @@ require 'optparse' + module CLI module WithOptions def cli_options( &block ) + raise ArgumentError, 'Block required but ...
Verify block is given when adding hook
diff --git a/lib/feed2email/core_ext.rb b/lib/feed2email/core_ext.rb index abc1234..def5678 100644 --- a/lib/feed2email/core_ext.rb +++ b/lib/feed2email/core_ext.rb @@ -24,7 +24,7 @@ end def numeric? - !!(self =~ /\A\d+\z/) + !(self =~ /\A\d+\z/).nil? end def pluralize(count, plural = self + 's')
Replace !! with explicit check for nil
diff --git a/lib/gitlab/git/rev_list.rb b/lib/gitlab/git/rev_list.rb index abc1234..def5678 100644 --- a/lib/gitlab/git/rev_list.rb +++ b/lib/gitlab/git/rev_list.rb @@ -31,7 +31,7 @@ output, status = popen(args, nil, Gitlab::Git::Env.all.stringify_keys) unless status.zero? - raise "Got a non...
Include RevList error messages in exceptions
diff --git a/lib/srtshifter/subtitle.rb b/lib/srtshifter/subtitle.rb index abc1234..def5678 100644 --- a/lib/srtshifter/subtitle.rb +++ b/lib/srtshifter/subtitle.rb @@ -8,6 +8,8 @@ end def shift + + start_time = Time.now output_file = File.open(@opts[:output], 'w') @@ -28,7 +30,10 @@ end end ...
Change success message. Add 'elapsed time' stdout
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,27 +1,37 @@ class User < ActiveRecord::Base - - before_save { self.email = email.downcase } before_create :create_remember_token attr_accessor :twitter_id, :facebook, :linkedi...
Make Users use friendly url params
diff --git a/fixture_dependencies.gemspec b/fixture_dependencies.gemspec index abc1234..def5678 100644 --- a/fixture_dependencies.gemspec +++ b/fixture_dependencies.gemspec @@ -1,11 +1,11 @@ Gem::Specification.new do |s| s.name = "fixture_dependencies" - s.version = "1.7.0" + s.version = "1.7.1" s.author = "Je...
Add the minitest support files to the gemspec The gem does not include the two files added for 1.7.0 with minitest_spec support. This change remedies that. % diff -u \ <(gem contents fixture_dependencies -v 1.7.0 --no-prefix) \ <(gem contents fixture_dependencies -v 1.7.1 --no-prefix) ```diff --- /dev/fd/11 201...
diff --git a/spec/support/redirect_server.rb b/spec/support/redirect_server.rb index abc1234..def5678 100644 --- a/spec/support/redirect_server.rb +++ b/spec/support/redirect_server.rb @@ -9,13 +9,13 @@ end def self.address - 'http://127.0.0.1:8201/' + 'http://127.0.0.1:8202/' end def s...
Change redirect port to avoid Vault's cluster default.
diff --git a/money-historical-bank.gemspec b/money-historical-bank.gemspec index abc1234..def5678 100644 --- a/money-historical-bank.gemspec +++ b/money-historical-bank.gemspec @@ -7,13 +7,14 @@ s.email = ["wam@atwam.com", "jon.allured@gmail.com"] s.description = "A gem that provides rates for the money gem. Able ...
Fix gemspec, adding license and semantic dependencies
diff --git a/app/models/domain.rb b/app/models/domain.rb index abc1234..def5678 100644 --- a/app/models/domain.rb +++ b/app/models/domain.rb @@ -2,4 +2,8 @@ has_many :domain_admin_roles has_many :admins, :through => :domain_admin_roles, :source => :user has_many :org_units + + def imported? + imported_at.pr...
Add convenience method for :imported?
diff --git a/app/models/lesson.rb b/app/models/lesson.rb index abc1234..def5678 100644 --- a/app/models/lesson.rb +++ b/app/models/lesson.rb @@ -1,5 +1,5 @@ class Lesson < ActiveRecord::Base - attr_accessible :background, :free, :title + attr_accessible :background, :free, :title, :video validates :title, :...
Add video as attr_accessible for Lesson Update the Lesson model to make the video attribute as attr_accessible.
diff --git a/app/views/lotteries/_results.csv.ruby b/app/views/lotteries/_results.csv.ruby index abc1234..def5678 100644 --- a/app/views/lotteries/_results.csv.ruby +++ b/app/views/lotteries/_results.csv.ruby @@ -4,7 +4,7 @@ ::CSV.generate do |csv| csv << ["Results for #{lottery.name}"] - lottery.divisions....
Order divisions by name for lottery results export
diff --git a/test/unit/jekyll_payload_test.rb b/test/unit/jekyll_payload_test.rb index abc1234..def5678 100644 --- a/test/unit/jekyll_payload_test.rb +++ b/test/unit/jekyll_payload_test.rb @@ -0,0 +1,63 @@+require 'support/test_case' +require 'support/fixture_config' +require 'jekyll/minibundle/development_file_collect...
Test our files can be sorted with Jekyll's static files
diff --git a/aws-sdk-core/lib/aws-sdk-core/json.rb b/aws-sdk-core/lib/aws-sdk-core/json.rb index abc1234..def5678 100644 --- a/aws-sdk-core/lib/aws-sdk-core/json.rb +++ b/aws-sdk-core/lib/aws-sdk-core/json.rb @@ -33,20 +33,20 @@ end def dump(value) - ENGINE.dump(value, ENGINE_DUMP_OPTIONS) + ...
Fix for broken JSON.dump call.
diff --git a/benchmark/event.rb b/benchmark/event.rb index abc1234..def5678 100644 --- a/benchmark/event.rb +++ b/benchmark/event.rb @@ -0,0 +1,36 @@+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib')) +require 'benchmark' +require 'analytics' +require 'thwait' + +raise "No Analytics Key Provided" unless...
Add trivial benchmarks to gauge cost of logging
diff --git a/spec/nymphia/dsl/context/host_context_methods_spec.rb b/spec/nymphia/dsl/context/host_context_methods_spec.rb index abc1234..def5678 100644 --- a/spec/nymphia/dsl/context/host_context_methods_spec.rb +++ b/spec/nymphia/dsl/context/host_context_methods_spec.rb @@ -0,0 +1,35 @@+require 'spec_helper' + +descr...
Add a spec for HostContextMethods module
diff --git a/resque-job_logger.gemspec b/resque-job_logger.gemspec index abc1234..def5678 100644 --- a/resque-job_logger.gemspec +++ b/resque-job_logger.gemspec @@ -12,7 +12,7 @@ gem.summary = %q{A resque plugin which logs the time it takes a job's perform method to run.} gem.homepage = "https://github....
Update and loosen resque version requirements.
diff --git a/Casks/imageoptim.rb b/Casks/imageoptim.rb index abc1234..def5678 100644 --- a/Casks/imageoptim.rb +++ b/Casks/imageoptim.rb @@ -1,7 +1,7 @@ class Imageoptim < Cask - url 'http://imageoptim.com/ImageOptim.tbz2' + url 'http://imageoptim.com/ImageOptim1.4.1.2.tar.bz2' homepage 'http://imageoptim.com/' - ...
Update cask to latest version. See https://twitter.com/pornelski/status/336639773382950913
diff --git a/Casks/vagrant127.rb b/Casks/vagrant127.rb index abc1234..def5678 100644 --- a/Casks/vagrant127.rb +++ b/Casks/vagrant127.rb @@ -3,8 +3,9 @@ sha256 '75c720eda0cbe6b2a2b19e38757ba4c34fbc57095ab4cc1459609bd242418129' url "http://files.vagrantup.com/packages/7ec0ee1d00a916f80b109a298bab08e391945243/Vagr...
Vagrant127: Add name, update license and homepage
diff --git a/lib/recurring.rb b/lib/recurring.rb index abc1234..def5678 100644 --- a/lib/recurring.rb +++ b/lib/recurring.rb @@ -11,7 +11,7 @@ #websites = DailyRank.select(:domain).distinct domains = Domain.includes(:ranks) domains.each do |domain| - url = website.try(:domain) + url = ...
Fix bug - undefined variable 'website'
diff --git a/lib/remindice.rb b/lib/remindice.rb index abc1234..def5678 100644 --- a/lib/remindice.rb +++ b/lib/remindice.rb @@ -17,7 +17,11 @@ end end class Commands < Thor - @@tasks = if File.exists?(Remindice::TASK_FILENAME); File.readlines(Remindice::TASK_FILENAME) else [] end + if File.exists?(Remi...
Split a class variable declaration It was too long
diff --git a/app/mailers/contact_mailer.rb b/app/mailers/contact_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/contact_mailer.rb +++ b/app/mailers/contact_mailer.rb @@ -1,5 +1,5 @@ class ContactMailer < ActionMailer::Base - default from: "contact@mail.cgbc-nc.com" + default from: "CGBC-Web <contact@mail.c...
Clean up display name when sending emails
diff --git a/app/mailers/teacher_mailer.rb b/app/mailers/teacher_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/teacher_mailer.rb +++ b/app/mailers/teacher_mailer.rb @@ -2,11 +2,13 @@ default from: "leap@southdevon.ac.uk" def email_teacher(teacher, learner, register_event, slot) - @teacher = teache...
Check for presence of teacher before sending email
diff --git a/rails/spec/requests/home_controller_spec.rb b/rails/spec/requests/home_controller_spec.rb index abc1234..def5678 100644 --- a/rails/spec/requests/home_controller_spec.rb +++ b/rails/spec/requests/home_controller_spec.rb @@ -16,7 +16,12 @@ it "#search" do compare("/search.php") + # Goes direct t...
Add some varied postcode tests Broken postcode test commented out because #134
diff --git a/spec/ruby-progressbar/components/title_spec.rb b/spec/ruby-progressbar/components/title_spec.rb index abc1234..def5678 100644 --- a/spec/ruby-progressbar/components/title_spec.rb +++ b/spec/ruby-progressbar/components/title_spec.rb @@ -0,0 +1,12 @@+require 'rspectacular' +require 'ruby-progressbar/componen...
Tests: Add tests for the 'Title' component -------------------------------------------------------------------------------- Branch: refactor/massive-update Signed-off-by: Jeff Felchner <8a84c204e2d4c387d61d20f7892a2bbbf0bc8ae8@thekompanee.com>
diff --git a/core/db/migrate/20130414000512_update_name_fields_on_spree_credit_cards.rb b/core/db/migrate/20130414000512_update_name_fields_on_spree_credit_cards.rb index abc1234..def5678 100644 --- a/core/db/migrate/20130414000512_update_name_fields_on_spree_credit_cards.rb +++ b/core/db/migrate/20130414000512_update_...
Correct use of CONCAT() in very old migration In MySQL, CONCAT() will return NULL if any of the passed in arguments are NULL. There are scenarios in which a user might have a first or last name but not both. In this case, this migration could be losing data. Instead, we can use CONCAT_WS() which will simply skip NULL...
diff --git a/test/mash_test.rb b/test/mash_test.rb index abc1234..def5678 100644 --- a/test/mash_test.rb +++ b/test/mash_test.rb @@ -1,7 +1,7 @@ require 'test_helper' # Tests -class HashieMashTest < MiniTest::Unit::TestCase +class HashieMashTest < MiniTest::Test def setup @mash = Hashie::Mash.new end
Test class changed due to warning
diff --git a/test/unix_test.rb b/test/unix_test.rb index abc1234..def5678 100644 --- a/test/unix_test.rb +++ b/test/unix_test.rb @@ -0,0 +1,26 @@+require File.expand_path("../lib/redic", File.dirname(__FILE__)) + +setup do + Redic.new(url: "unix:///tmp/redis.sock") +end + +test "normal commands" do |c| + c.call("SET"...
Add basic unix test to make sure unix sockets work.
diff --git a/spec/centos/dirtycow_spec.rb b/spec/centos/dirtycow_spec.rb index abc1234..def5678 100644 --- a/spec/centos/dirtycow_spec.rb +++ b/spec/centos/dirtycow_spec.rb @@ -0,0 +1,9 @@+require 'spec_helper' + +# Test to ensure image is not vulnerable to CVE-2016-5195 +# Via: https://access.redhat.com/security/vulne...
Add test for dirty cow CVE-2016-5195
diff --git a/spec/henson/settings_spec.rb b/spec/henson/settings_spec.rb index abc1234..def5678 100644 --- a/spec/henson/settings_spec.rb +++ b/spec/henson/settings_spec.rb @@ -19,6 +19,10 @@ shared = "#{Dir.pwd}/shared" expect(Henson::Settings.new[:path]).to eq(shared) end + + it "accepts a hash t...
Add tests for the new hash arg to Henson::Settings.new
diff --git a/spec/money_converter_spec.rb b/spec/money_converter_spec.rb index abc1234..def5678 100644 --- a/spec/money_converter_spec.rb +++ b/spec/money_converter_spec.rb @@ -13,15 +13,15 @@ context "configured with currencies" do let(:conversion_rates) do { - EUR: { - DKK: 7.4...
Use strings instead of symbols to match the given interface and updated EUR -> USD rate.
diff --git a/test/lib/gemfile_parser_test.rb b/test/lib/gemfile_parser_test.rb index abc1234..def5678 100644 --- a/test/lib/gemfile_parser_test.rb +++ b/test/lib/gemfile_parser_test.rb @@ -1,4 +1,5 @@ require "test_helper" +require_relative "../../lib/gemfile_parser" class GemfileParserTest < ActiveSupport::TestCase...
Fix uninitialized constant error in test
diff --git a/spec/features/spotchecks/spotcheck_page_displays_letter_to_be_sent_spec.rb b/spec/features/spotchecks/spotcheck_page_displays_letter_to_be_sent_spec.rb index abc1234..def5678 100644 --- a/spec/features/spotchecks/spotcheck_page_displays_letter_to_be_sent_spec.rb +++ b/spec/features/spotchecks/spotcheck_pag...
Add feature test for the spotcheck page letter
diff --git a/lib/app/helpers/esi_helper.rb b/lib/app/helpers/esi_helper.rb index abc1234..def5678 100644 --- a/lib/app/helpers/esi_helper.rb +++ b/lib/app/helpers/esi_helper.rb @@ -11,7 +11,7 @@ env = ENV['RAILS_ENV'] # If we were passed a url... - if URI.extract(resource).any? + if resource =~...
Fix failing test for rendering internal resources.
diff --git a/app/controllers/admin/relationships_controller.rb b/app/controllers/admin/relationships_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/relationships_controller.rb +++ b/app/controllers/admin/relationships_controller.rb @@ -1,6 +1,6 @@ class Admin::RelationshipsController < Admin::B...
Change order of relationships index so pending relationships are at the top
diff --git a/lib/better_logging/railtie.rb b/lib/better_logging/railtie.rb index abc1234..def5678 100644 --- a/lib/better_logging/railtie.rb +++ b/lib/better_logging/railtie.rb @@ -6,6 +6,7 @@ class Railtie < Rails::Railtie config.better_logging = ActiveSupport::OrderedOptions.new config.better_logging.enab...
Allow passing controllers to ignore
diff --git a/config/initializers/_splunk_logger.rb b/config/initializers/_splunk_logger.rb index abc1234..def5678 100644 --- a/config/initializers/_splunk_logger.rb +++ b/config/initializers/_splunk_logger.rb @@ -1,5 +1,5 @@ if AppConfig[:enable_splunk_logging] require File.expand_path('../../../lib/log_overrider', ...
Move the include of splunklogging into the appconfig check
diff --git a/app/models/qernel/plugins/merit/import_adapter.rb b/app/models/qernel/plugins/merit/import_adapter.rb index abc1234..def5678 100644 --- a/app/models/qernel/plugins/merit/import_adapter.rb +++ b/app/models/qernel/plugins/merit/import_adapter.rb @@ -14,14 +14,16 @@ elec_link.dataset_set(:calculated...
Fix imported electricity cost_per_mj with zero production
diff --git a/app/overrides/add_return_requests_to_admin_tab.rb b/app/overrides/add_return_requests_to_admin_tab.rb index abc1234..def5678 100644 --- a/app/overrides/add_return_requests_to_admin_tab.rb +++ b/app/overrides/add_return_requests_to_admin_tab.rb @@ -0,0 +1,11 @@+Deface::Override.new( + virtual_path: 'spree/...
Add Return Requests to admin tab
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -7,5 +7,6 @@ def setup url = File.join(File.dirname(__FILE__), 'fixtures', 'pegelstaende_neu.xml') Wasserstand.waterway_provider = PegelOnline::WaterwayProvider.new(url) + Wasserstand.l...
Use local file for level test, too
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -9,7 +9,7 @@ end require 'minitest/autorun' require 'minitest/pride' -require 'mocha/setup' +require 'mocha/minitest' $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib')) $LOAD_PAT...
Replace 'mocha/setup' require with 'mocha/minitest'.
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -16,8 +16,8 @@ )) end -def read_api_file(path) - path = File.join(test_site.output_paths[:site], 'api', path) +def read_api_file(path = nil) + path = File.join(test_site.output_paths[:site], 'a...
Update read_api_file to assume the index.json part of the path.
diff --git a/lib/duty_calculator/dootie.rb b/lib/duty_calculator/dootie.rb index abc1234..def5678 100644 --- a/lib/duty_calculator/dootie.rb +++ b/lib/duty_calculator/dootie.rb @@ -1,5 +1,5 @@+# encoding: utf-8 module DutyCalculator - class Dootie < StandardError def initialize(data=nil) @data = data
Fix invalid double byte character error