diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/github/ldap/user_search/active_directory.rb b/lib/github/ldap/user_search/active_directory.rb index abc1234..def5678 100644 --- a/lib/github/ldap/user_search/active_directory.rb +++ b/lib/github/ldap/user_search/active_directory.rb @@ -2,14 +2,6 @@ class Ldap module UserSearch class Activ...
Make global connection interface private
diff --git a/lib/tasks/2018_06_05_send_new_attestations.rake b/lib/tasks/2018_06_05_send_new_attestations.rake index abc1234..def5678 100644 --- a/lib/tasks/2018_06_05_send_new_attestations.rake +++ b/lib/tasks/2018_06_05_send_new_attestations.rake @@ -43,7 +43,7 @@ dossier.attestation = dossier.build_attestation...
Fix a bug in a task
diff --git a/lib/tasks/deployment/20201123115503_update_head_teacher_school_summary_to_management_summary.rake b/lib/tasks/deployment/20201123115503_update_head_teacher_school_summary_to_management_summary.rake index abc1234..def5678 100644 --- a/lib/tasks/deployment/20201123115503_update_head_teacher_school_summary_to...
Change HeadTeachersSchoolSummaryTable to ManagementSummaryTable in alert_types
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,6 +1,6 @@ class User < ActiveRecord::Base devise :two_factor_authenticatable, - otp_secret_encryption_key: ENV['TWO_FACTOR_ENCRYPTION_KEY'], + otp_secret_encrypti...
Make tests less dependent on config. For the test environment it's okay if no TWO_FACTOR_ENCRYPTION_KEY is set up, we can use any old key. This will make it easier to run tests from a fresh install.
diff --git a/google-cloud/lib/google-cloud.rb b/google-cloud/lib/google-cloud.rb index abc1234..def5678 100644 --- a/google-cloud/lib/google-cloud.rb +++ b/google-cloud/lib/google-cloud.rb @@ -13,9 +13,7 @@ # limitations under the License. ## -# This file is here to be autorequired by bundler, so that the .bigquery ...
Update comment for Google Cloud Correct the methods listed in the autorequire comment.
diff --git a/test/integration/connection_test.rb b/test/integration/connection_test.rb index abc1234..def5678 100644 --- a/test/integration/connection_test.rb +++ b/test/integration/connection_test.rb @@ -2,10 +2,18 @@ module Tropoli class ConnectionTest < IntegrationTest + test :"nick and user commands sent to...
Add integration test for NICK and USER on connection establishment
diff --git a/spec/views/assets/_support_facility_fta.html.haml_spec.rb b/spec/views/assets/_support_facility_fta.html.haml_spec.rb index abc1234..def5678 100644 --- a/spec/views/assets/_support_facility_fta.html.haml_spec.rb +++ b/spec/views/assets/_support_facility_fta.html.haml_spec.rb @@ -3,7 +3,7 @@ describe "asset...
Fix support_facility_fta error on finding facilitytype
diff --git a/git_bumper.gemspec b/git_bumper.gemspec index abc1234..def5678 100644 --- a/git_bumper.gemspec +++ b/git_bumper.gemspec @@ -14,7 +14,7 @@ spec.homepage = 'https://github.com/lenon/git_bumper' spec.license = 'MIT' - spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(...
Add only required files on .gem pkg
diff --git a/app/models/reviewit_config.rb b/app/models/reviewit_config.rb index abc1234..def5678 100644 --- a/app/models/reviewit_config.rb +++ b/app/models/reviewit_config.rb @@ -12,7 +12,7 @@ def load_data data = read_yaml data.merge!(data[Rails.env]) if data.key?(Rails.env) - data.symbolize_k...
Fix reviewit config for mail configuration.
diff --git a/app/refineries/cloud_refinery.rb b/app/refineries/cloud_refinery.rb index abc1234..def5678 100644 --- a/app/refineries/cloud_refinery.rb +++ b/app/refineries/cloud_refinery.rb @@ -1,10 +1,11 @@ class CloudRefinery < ApplicationRefinery def create - [:name, :short_name, :description] + [:name, :s...
Add more allowed attributes to clouds refinery.
diff --git a/app/sweepers/location_sweeper.rb b/app/sweepers/location_sweeper.rb index abc1234..def5678 100644 --- a/app/sweepers/location_sweeper.rb +++ b/app/sweepers/location_sweeper.rb @@ -1,34 +1,37 @@ class LocationSweeper < ActionController::Caching::Sweeper - + include ApplicationHelper - + private ...
Remove cached location maps with the variant suffix too.
diff --git a/app/workers/feed_eater_worker.rb b/app/workers/feed_eater_worker.rb index abc1234..def5678 100644 --- a/app/workers/feed_eater_worker.rb +++ b/app/workers/feed_eater_worker.rb @@ -26,5 +26,6 @@ # logger.info '5. Creating FeedEater Reports' # logger.info '6. Uploading to S3' + # aws s3 sync . ...
Comment describing s3 upload command
diff --git a/examples/ranking_csv.rb b/examples/ranking_csv.rb index abc1234..def5678 100644 --- a/examples/ranking_csv.rb +++ b/examples/ranking_csv.rb @@ -0,0 +1,54 @@+# coding: utf-8 +# 楽天ランキングAPIを利用し、ランキングデータをCSVとして保存するサンプル +# config.item_ranking_module = 'MyCSV' の使い方を説明したかっただけ + +require 'rakuten_api' +require 'fa...
Add rakuten ranking save as csv sample
diff --git a/spec/build/dependencygrapher/print_dependencies_spec.rb b/spec/build/dependencygrapher/print_dependencies_spec.rb index abc1234..def5678 100644 --- a/spec/build/dependencygrapher/print_dependencies_spec.rb +++ b/spec/build/dependencygrapher/print_dependencies_spec.rb @@ -7,6 +7,10 @@ @grapher = Depen...
Make sure $stdout is reassigned in :after action.
diff --git a/spec/generators/rspec/feature/feature_generator_spec.rb b/spec/generators/rspec/feature/feature_generator_spec.rb index abc1234..def5678 100644 --- a/spec/generators/rspec/feature/feature_generator_spec.rb +++ b/spec/generators/rspec/feature/feature_generator_spec.rb @@ -15,10 +15,16 @@ run_generat...
Change feature generator spec to use expect syntax
diff --git a/vendor/plugins/themes/rails/init.rb b/vendor/plugins/themes/rails/init.rb index abc1234..def5678 100644 --- a/vendor/plugins/themes/rails/init.rb +++ b/vendor/plugins/themes/rails/init.rb @@ -1,29 +1,32 @@-# Set up middleware to serve theme files -config.middleware.use "ThemeServer" +# Before the applicati...
Fix themes breaking rake db:setup because RefinerySetting.table_exists? is false.
diff --git a/features/support/app.rb b/features/support/app.rb index abc1234..def5678 100644 --- a/features/support/app.rb +++ b/features/support/app.rb @@ -3,6 +3,24 @@ class DillApp < Sinatra::Base; end +module WebApp + def define_page_body(html, path = "/test") + define_page <<-HTML, path + <html> + ...
[tests] Allow defining the html we're working with.
diff --git a/formula/ruby-1.9.3-p327-falcon.rb b/formula/ruby-1.9.3-p327-falcon.rb index abc1234..def5678 100644 --- a/formula/ruby-1.9.3-p327-falcon.rb +++ b/formula/ruby-1.9.3-p327-falcon.rb @@ -6,6 +6,6 @@ def install run "autoconf" - autoconf(["--disable-install-doc"]) + autoconf(["--disable-install-...
Add some more options to ruby
diff --git a/capistrano-nginx-unicorn.gemspec b/capistrano-nginx-unicorn.gemspec index abc1234..def5678 100644 --- a/capistrano-nginx-unicorn.gemspec +++ b/capistrano-nginx-unicorn.gemspec @@ -6,11 +6,11 @@ Gem::Specification.new do |gem| gem.name = "capistrano-nginx-unicorn" gem.version = Capistra...
Update authors, email, website of gem
diff --git a/NBJMergeLayout-ObjC.podspec b/NBJMergeLayout-ObjC.podspec index abc1234..def5678 100644 --- a/NBJMergeLayout-ObjC.podspec +++ b/NBJMergeLayout-ObjC.podspec @@ -12,6 +12,6 @@ s.osx.deployment_target = "10.7" s.source = { :git => "https://github.com/BrentleyJones/NBJMergeLayout-ObjC.git", :tag => ...
Fix requires_arc value in podspec
diff --git a/short_straw/straws.rb b/short_straw/straws.rb index abc1234..def5678 100644 --- a/short_straw/straws.rb +++ b/short_straw/straws.rb @@ -18,6 +18,29 @@ # When only one player remains, the game will end and display the winner. #========================================================================== +# ...
Create game, player, and straw classes, add main game loop
diff --git a/db/migrate/20141020094819_create_featured_links.rb b/db/migrate/20141020094819_create_featured_links.rb index abc1234..def5678 100644 --- a/db/migrate/20141020094819_create_featured_links.rb +++ b/db/migrate/20141020094819_create_featured_links.rb @@ -0,0 +1,32 @@+class CreateFeaturedLinks < ActiveRecord::...
Create new featured link table
diff --git a/spec/unit/queueing_rabbit/configuration_spec.rb b/spec/unit/queueing_rabbit/configuration_spec.rb index abc1234..def5678 100644 --- a/spec/unit/queueing_rabbit/configuration_spec.rb +++ b/spec/unit/queueing_rabbit/configuration_spec.rb @@ -0,0 +1,11 @@+require 'spec_helper' + +describe QueueingRabbit::Conf...
Add a spec for QueueingRabbit::Configuration module.
diff --git a/db/migrate/20180420010616_cleanup_build_stage_migration.rb b/db/migrate/20180420010616_cleanup_build_stage_migration.rb index abc1234..def5678 100644 --- a/db/migrate/20180420010616_cleanup_build_stage_migration.rb +++ b/db/migrate/20180420010616_cleanup_build_stage_migration.rb @@ -2,6 +2,7 @@ include G...
Add tmp index to ci_builds to optimize stages migration
diff --git a/spec/client_spec.rb b/spec/client_spec.rb index abc1234..def5678 100644 --- a/spec/client_spec.rb +++ b/spec/client_spec.rb @@ -10,14 +10,14 @@ end describe 'query_interval' do - before { MusicBrainz.config.query_interval = 0.5 } + before { MusicBrainz.config.query_interval = 0.2 } after ...
Reduce query interval in specs
diff --git a/spec/client_spec.rb b/spec/client_spec.rb index abc1234..def5678 100644 --- a/spec/client_spec.rb +++ b/spec/client_spec.rb @@ -0,0 +1,17 @@+require 'spec_helper' + +describe EventGirl::Client do + it 'creates instances with two arguments' do + expect(described_class.instance_method(:initialize).arity)...
Test instance creation and argument assignment
diff --git a/spec/geezeo_spec.rb b/spec/geezeo_spec.rb index abc1234..def5678 100644 --- a/spec/geezeo_spec.rb +++ b/spec/geezeo_spec.rb @@ -0,0 +1,13 @@+require "spec_helper" + +describe Geezeo::Client do + before(:each) do + @client = Geezeo::Client.new(credentials) + end + + it "gets a list of accounts" do + ...
Add first test. Let the TDD commence
diff --git a/lib/jcr.rb b/lib/jcr.rb index abc1234..def5678 100644 --- a/lib/jcr.rb +++ b/lib/jcr.rb @@ -39,4 +39,8 @@ hostname + "/crx/server" end end + + def self.dev_login + login(:hostname => "http://localhost:4502", :username => "admin", :password => "admin") + end end
Add convenience method to login to dev JCR
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -38,6 +38,6 @@ Jekyll::Site.new(config) end -def make_context(registers = {}) - Liquid::Context.new({}, {}, { site: site, page: page }.merge(registers)) +def make_context(reg...
Allow passing custom environments when making Liquid contexts for testing. Backwards-compatible with previous implementation.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -25,5 +25,6 @@ added_constants = Object.constants - @constants added_constants.each { |name| Object.send(:remove_const, name) } ROM::Relation.instance_variable_set('@...
Support :prefix option and build Mapper descendants on Finalize
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,6 +1,11 @@ if ENV['COVERAGE'] == 'yes' require 'coveralls' - Coveralls.wear! + require 'simplecov' + + SimpleCov.formatter = Coveralls::SimpleCov::Formatter + SimpleCov.s...
Exclude /spec/ from coverage reports
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,6 +1,8 @@ require "hearthstone_api" require "rspec" require "vcr" +require "byebug" +require "dotenv" VCR.configure do |c| c.cassette_library_dir = "spec/support/vcr_cas...
Add dotenv to spec helper
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -22,4 +22,9 @@ password: "test123", return_response: true } +RSpec.configure do |config| + config.before(:each) do + EmailEvents.adapter = :sendgrid + end +end
Reset test suite default to sendgrid.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -23,3 +23,10 @@ Eventify::Database.instance_variable_set(:@sqlite, nil) end end + +# monkey-patch StubSocket for backwards compatibility so that specs would pass +# on newe...
Add monkey-patch for StubSocket so that specs would pass
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -32,6 +32,10 @@ return true if value == :auth && !Support::MongoHQ.auth_node_configured? end + config.before :each do + Moped::Connection::Manager.instance_variable_se...
Reset global connection pool on tests
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -6,8 +6,19 @@ $LOAD_PATH.unshift(File.expand_path(File.join(__FILE__, "..", "..", "lib"))) require 'duckweed' +module SpecHelpers + def open_page_in_browser + path = "/tmp/d...
Add spec helpers to open page in web browser for debugging Obvious caveat: this will only work if you are running the tests on your local machine, and particularly, it depends on Mac OS X (for the "open" command).
diff --git a/buildr_plus.gemspec b/buildr_plus.gemspec index abc1234..def5678 100644 --- a/buildr_plus.gemspec +++ b/buildr_plus.gemspec @@ -25,5 +25,5 @@ s.rdoc_options = %w(--line-numbers --inline-source --title buildr_plus) s.add_dependency 'reality-core', '>= 1.4.0' - s.add_dependency 'reality-naming'...
Update the version of reality-naming in use
diff --git a/spec/winnow_spec.rb b/spec/winnow_spec.rb index abc1234..def5678 100644 --- a/spec/winnow_spec.rb +++ b/spec/winnow_spec.rb @@ -0,0 +1,16 @@+require 'spec_helper' + +describe Winnow::Fingerprinter do + describe '#fingerprints' do + it 'hashes strings to get keys' do + # if t = k = 1, then each cha...
Add a test for simple-case fingerprinting.
diff --git a/spec/markwiki_spec.rb b/spec/markwiki_spec.rb index abc1234..def5678 100644 --- a/spec/markwiki_spec.rb +++ b/spec/markwiki_spec.rb @@ -1,11 +1,34 @@ require 'spec_helper' describe Markwiki do + before :all do + @name = "markwiki" + end + it 'has a version number' do expect(Markwiki::VERSIO...
Update tests for Coveralls coverage
diff --git a/spec/nif_generator.rb b/spec/nif_generator.rb index abc1234..def5678 100644 --- a/spec/nif_generator.rb +++ b/spec/nif_generator.rb @@ -1,11 +1,27 @@ require 'lib/nif_generator' describe "NifGenerator" do - it "should validade a valid Nif" do + it "should validate a valid nif" do valid_nif = '502...
Refactor and add rspec tests
diff --git a/examples/rails/app/controllers/snoop_controller.rb b/examples/rails/app/controllers/snoop_controller.rb index abc1234..def5678 100644 --- a/examples/rails/app/controllers/snoop_controller.rb +++ b/examples/rails/app/controllers/snoop_controller.rb @@ -11,6 +11,7 @@ @snoop[:session_options] = request....
Add system properties to snoop
diff --git a/recipes/sevenscale_deploy/web.rb b/recipes/sevenscale_deploy/web.rb index abc1234..def5678 100644 --- a/recipes/sevenscale_deploy/web.rb +++ b/recipes/sevenscale_deploy/web.rb @@ -12,10 +12,11 @@ reason = ENV['REASON'] deadline = ENV['UNTIL'] - template = File.read(File.join(File.dirname(__FI...
Add the ability to specify where the maintenance file comes from.
diff --git a/helpers/meta_helpers.rb b/helpers/meta_helpers.rb index abc1234..def5678 100644 --- a/helpers/meta_helpers.rb +++ b/helpers/meta_helpers.rb @@ -5,7 +5,7 @@ def canonical_url host = site_host + '/' - path = current_page.path.gsub('index.html', '') + path = current_page.url.gsub('index.html', ...
Use current_page.url instead of current_page.path for og:url
diff --git a/lib/omniauth/strategies/local.rb b/lib/omniauth/strategies/local.rb index abc1234..def5678 100644 --- a/lib/omniauth/strategies/local.rb +++ b/lib/omniauth/strategies/local.rb @@ -28,14 +28,13 @@ end def user_key + return nil unless request[:identity] return nil unless reques...
Fix when form empty submit.
diff --git a/apis/comic_vine.rb b/apis/comic_vine.rb index abc1234..def5678 100644 --- a/apis/comic_vine.rb +++ b/apis/comic_vine.rb @@ -13,7 +13,9 @@ "query" => query } - puts params + params = { + :params => params + } return JSON.parse((RestClient.get request_url, params).body)
Fix parameter passing to Comic Vine API url
diff --git a/spec/acceptance/basic_gnocchi_spec.rb b/spec/acceptance/basic_gnocchi_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/basic_gnocchi_spec.rb +++ b/spec/acceptance/basic_gnocchi_spec.rb @@ -8,6 +8,7 @@ pp = <<-EOS include openstack_integration include openstack_integration::re...
Use common class to manage apache service in beaker job Depends-on: https://review.opendev.org/#/c/745246/ Change-Id: I299640aed47071381efb4dfb95f77245223b7dce
diff --git a/lib/flipper/api.rb b/lib/flipper/api.rb index abc1234..def5678 100644 --- a/lib/flipper/api.rb +++ b/lib/flipper/api.rb @@ -17,6 +17,8 @@ builder.use Flipper::Api::JsonParams builder.use Flipper::Api::Middleware builder.run app + klass = self + builder.define_singleton_method(...
Add same hack as UI to make rake routes output mo' pretty
diff --git a/config/initializers/omni_auth.rb b/config/initializers/omni_auth.rb index abc1234..def5678 100644 --- a/config/initializers/omni_auth.rb +++ b/config/initializers/omni_auth.rb @@ -1,4 +1,5 @@ OmniAuth.config.logger = Rails.logger +OmniAuth.config.allowed_request_methods = [:post, :get] Rails.application...
Allow GET request for omniauth gem Logins are failing on Chrome and it seems due to receiving `GET` requests. This is an attempt to get our logins working again.
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -33,7 +33,8 @@ name: project.name, client_id: project.client_id, work_weeks: project.work_weeks.for_user(self).map do |ww| - { project_id: ww.project...
Fix bug in the UI where work weeks wouldn't update, ID has to be set on initial page load
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -2,7 +2,6 @@ belongs_to :group has_many :made_requests, class_name: 'Request', foreign_key: 'requester_id' has_many :fulfilled_requests, class_name: 'Request', fore...
Remove has_many to reflect changes to votes table
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -8,10 +8,9 @@ validates :last_name, presence: true validates_format_of :email, :with => /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\z/i validates :email, presence: true, uniquene...
Validate password length only on create
diff --git a/mandrill-delivery-method.gemspec b/mandrill-delivery-method.gemspec index abc1234..def5678 100644 --- a/mandrill-delivery-method.gemspec +++ b/mandrill-delivery-method.gemspec @@ -7,20 +7,19 @@ s.version = MandrillDeliveryMethod::VERSION s.platform = Gem::Platform::RUBY - s.files = ...
Update gemspec with proper dependency settings
diff --git a/pdf_ravager.gemspec b/pdf_ravager.gemspec index abc1234..def5678 100644 --- a/pdf_ravager.gemspec +++ b/pdf_ravager.gemspec @@ -12,11 +12,11 @@ s.summary = %q{DSL to aid filling out AcroForms PDF and XFA documents} s.description = %q{DSL to aid filling out AcroForms PDF and XFA documents} - s.a...
Change json dependency to use add_dependency
diff --git a/db/migrate/20141229083623_remove_ghost_tables_enabled_from_users.rb b/db/migrate/20141229083623_remove_ghost_tables_enabled_from_users.rb index abc1234..def5678 100644 --- a/db/migrate/20141229083623_remove_ghost_tables_enabled_from_users.rb +++ b/db/migrate/20141229083623_remove_ghost_tables_enabled_from_...
Fix migration typo to be able to rollback if needed
diff --git a/activesupport/lib/active_support/testing/tagged_logging.rb b/activesupport/lib/active_support/testing/tagged_logging.rb index abc1234..def5678 100644 --- a/activesupport/lib/active_support/testing/tagged_logging.rb +++ b/activesupport/lib/active_support/testing/tagged_logging.rb @@ -1,10 +1,6 @@-require 'a...
Remove AS::Concern extension from Testing::TaggedLogging
diff --git a/spec/agharta/user_stream_spec.rb b/spec/agharta/user_stream_spec.rb index abc1234..def5678 100644 --- a/spec/agharta/user_stream_spec.rb +++ b/spec/agharta/user_stream_spec.rb @@ -17,6 +17,12 @@ end describe '#logger' do + before do + @logger = Logger.new($stdout) + Logger.should_receiv...
Fix MultiLogger spec to use dummy logger.
diff --git a/spec/classes/bmclib_init_spec.rb b/spec/classes/bmclib_init_spec.rb index abc1234..def5678 100644 --- a/spec/classes/bmclib_init_spec.rb +++ b/spec/classes/bmclib_init_spec.rb @@ -0,0 +1,76 @@+#!/usr/bin/env rspec + +require 'spec_helper' + +describe 'bmclib', :type => 'class' do + + context 'on a RedHat ...
Add rspec test for Class['bmclib'].
diff --git a/spec/http/request/writer_spec.rb b/spec/http/request/writer_spec.rb index abc1234..def5678 100644 --- a/spec/http/request/writer_spec.rb +++ b/spec/http/request/writer_spec.rb @@ -1,3 +1,5 @@+# coding: utf-8 + require 'spec_helper' describe HTTP::Request::Writer do @@ -30,4 +32,12 @@ expect(io.st...
Add spec for unicode request body length header Related to #129
diff --git a/spec/ruby/core/fiber/new_spec.rb b/spec/ruby/core/fiber/new_spec.rb index abc1234..def5678 100644 --- a/spec/ruby/core/fiber/new_spec.rb +++ b/spec/ruby/core/fiber/new_spec.rb @@ -5,6 +5,13 @@ it "creates a fiber from the given block" do fiber = Fiber.new {} fiber.should be_an_instance_of...
Add spec for instantiating subclasses of Fiber
diff --git a/lib/grapple/components/will_paginate_pagination.rb b/lib/grapple/components/will_paginate_pagination.rb index abc1234..def5678 100644 --- a/lib/grapple/components/will_paginate_pagination.rb +++ b/lib/grapple/components/will_paginate_pagination.rb @@ -21,7 +21,8 @@ html = h(t(no_results_message)) ...
Fix for older versions of rails without the hash compact method
diff --git a/lib/shoulda/matchers/active_model/helpers.rb b/lib/shoulda/matchers/active_model/helpers.rb index abc1234..def5678 100644 --- a/lib/shoulda/matchers/active_model/helpers.rb +++ b/lib/shoulda/matchers/active_model/helpers.rb @@ -20,12 +20,12 @@ def default_error_message(key, options = {}) ...
Make the code easier to read.
diff --git a/chamber.gemspec b/chamber.gemspec index abc1234..def5678 100644 --- a/chamber.gemspec +++ b/chamber.gemspec @@ -26,7 +26,6 @@ spec.add_runtime_dependency "hashie", "~> 2.0" - spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" spec.add_development_depende...
Remove bundler from the development dependencies. It lives outside of gemspecs
diff --git a/config/schedule.rb b/config/schedule.rb index abc1234..def5678 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -29,5 +29,9 @@ runner 'DigestBuilder.send_daily_email' end -every :minute { command "whoami" } -every :minute { command "which ruby" } +every :minute do + command "whoami" +end +...
Add crons to check env
diff --git a/app/mixins/numeric_sanitizers.rb b/app/mixins/numeric_sanitizers.rb index abc1234..def5678 100644 --- a/app/mixins/numeric_sanitizers.rb +++ b/app/mixins/numeric_sanitizers.rb @@ -9,11 +9,11 @@ # Strip extraneous non-numeric characters from an input number and return a float def sanitize_to_float(nu...
Tweak coercions in the input sanitizers
diff --git a/lib/shoes/swt/shoes_layout.rb b/lib/shoes/swt/shoes_layout.rb index abc1234..def5678 100644 --- a/lib/shoes/swt/shoes_layout.rb +++ b/lib/shoes/swt/shoes_layout.rb @@ -30,7 +30,7 @@ def handle_scroll_bar(vertical_bar, height, scrollable_height) vertical_bar.setThumb height * height / scrolla...
Change constant of vertical bar increment value
diff --git a/lib/tasks/commit_monitor.rake b/lib/tasks/commit_monitor.rake index abc1234..def5678 100644 --- a/lib/tasks/commit_monitor.rake +++ b/lib/tasks/commit_monitor.rake @@ -4,7 +4,7 @@ loop do print "." CommitMonitor.perform_async - sleep(60) + sleep(CommitMonitor.options["poll"]) ...
Move commit monitor polling time into an option.
diff --git a/app/models/pick.rb b/app/models/pick.rb index abc1234..def5678 100644 --- a/app/models/pick.rb +++ b/app/models/pick.rb @@ -7,4 +7,25 @@ group(:enclosure_id).order('count_container_id DESC').count('container_id') } + scope :feed, -> (feed) { + joins(container: :entries).where(entries: { feed_i...
Customize Pick stream scopes: Join enclosures table on `container_id`
diff --git a/lib/vagrant-ca-certificates/cap/debian/update_certificate_bundle.rb b/lib/vagrant-ca-certificates/cap/debian/update_certificate_bundle.rb index abc1234..def5678 100644 --- a/lib/vagrant-ca-certificates/cap/debian/update_certificate_bundle.rb +++ b/lib/vagrant-ca-certificates/cap/debian/update_certificate_b...
Enable uploaded certificates in ca-certificates.conf for debian
diff --git a/lib/vmdb/loggers/io_logger.rb b/lib/vmdb/loggers/io_logger.rb index abc1234..def5678 100644 --- a/lib/vmdb/loggers/io_logger.rb +++ b/lib/vmdb/loggers/io_logger.rb @@ -0,0 +1,31 @@+module Vmdb::Loggers + class IoLogger < StringIO + def initialize(logger, level = :info, prefix = nil) + @logger = lo...
Add IoLogger to be used for stdout and stderr logging
diff --git a/chef-repo/site-cookbooks/cbench-databox/recipes/default.rb b/chef-repo/site-cookbooks/cbench-databox/recipes/default.rb index abc1234..def5678 100644 --- a/chef-repo/site-cookbooks/cbench-databox/recipes/default.rb +++ b/chef-repo/site-cookbooks/cbench-databox/recipes/default.rb @@ -20,15 +20,13 @@ # Worar...
Add workaround for databox cookbook bug by implementing database choice directly
diff --git a/html_massage.gemspec b/html_massage.gemspec index abc1234..def5678 100644 --- a/html_massage.gemspec +++ b/html_massage.gemspec @@ -17,13 +17,12 @@ gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_paths = ["lib"] - gem.add_dependency "nokogiri", ">= 1.4" - gem.add_depende...
Update dependencies in gemspec; use ~> syntax
diff --git a/jfit.gemspec b/jfit.gemspec index abc1234..def5678 100644 --- a/jfit.gemspec +++ b/jfit.gemspec @@ -17,7 +17,7 @@ spec.files = `git ls-files -z`.split("\x0") spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } spec.test_files = spec.files.grep(%r{^(test|spec|features...
Add vendor to require paths
diff --git a/lib/capistrano/data_bag/helper.rb b/lib/capistrano/data_bag/helper.rb index abc1234..def5678 100644 --- a/lib/capistrano/data_bag/helper.rb +++ b/lib/capistrano/data_bag/helper.rb @@ -5,9 +5,11 @@ module Helper def create_data_bag_item(bag, item, data = {}) FileUtils.makedirs "#{data_ba...
Print data bag item file name after creation
diff --git a/lib/moltin/resource_collection.rb b/lib/moltin/resource_collection.rb index abc1234..def5678 100644 --- a/lib/moltin/resource_collection.rb +++ b/lib/moltin/resource_collection.rb @@ -8,6 +8,10 @@ end end + def each(&block) + @resources.each { |resource| yield resource } + end + ...
Allow collection resources to be iterated over
diff --git a/ext/baz/extconf.rb b/ext/baz/extconf.rb index abc1234..def5678 100644 --- a/ext/baz/extconf.rb +++ b/ext/baz/extconf.rb @@ -1,4 +1,3 @@ # ext/baz/extconf.rb require 'mkmf' -$CXXFLAGS = '--std=c++0x' create_makefile( 'baz/baz' )
Revert - worked locally, but on Travis it seems . . .
diff --git a/app/lib/deprecated_attributes.rb b/app/lib/deprecated_attributes.rb index abc1234..def5678 100644 --- a/app/lib/deprecated_attributes.rb +++ b/app/lib/deprecated_attributes.rb @@ -0,0 +1,29 @@+require 'active_support/deprecation' + +module DeprecatedAttributes + extend ActiveSupport::Concern + + class_me...
Add module for deprecating model attributes This will cause a deprecation message to be logged when any attribute related method (Model#foo, Model#foo= and Model#foo?) is used.
diff --git a/app/mailers/newsletter_mailer.rb b/app/mailers/newsletter_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/newsletter_mailer.rb +++ b/app/mailers/newsletter_mailer.rb @@ -4,7 +4,7 @@ def newsletter_email(client) clients_titles = ClientsTitles.select("title_id").where(:client_id => client.id...
Change to mail in newsletter
diff --git a/app/models/champs/carte_champ.rb b/app/models/champs/carte_champ.rb index abc1234..def5678 100644 --- a/app/models/champs/carte_champ.rb +++ b/app/models/champs/carte_champ.rb @@ -15,6 +15,14 @@ end end + def cadastres? + type_de_champ&.cadastres && type_de_champ.cadastres != '0' + end + + d...
Add type options on carte champ
diff --git a/app/models/worthwhile/generic_work.rb b/app/models/worthwhile/generic_work.rb index abc1234..def5678 100644 --- a/app/models/worthwhile/generic_work.rb +++ b/app/models/worthwhile/generic_work.rb @@ -11,7 +11,7 @@ :publisher, :date_created, :subject, ...
Use the root namespace for CurationConcern
diff --git a/haxby.rb b/haxby.rb index abc1234..def5678 100644 --- a/haxby.rb +++ b/haxby.rb @@ -2,9 +2,9 @@ class Haxby < Formula homepage 'https://github.com/tabletcorry/haxby' - url "https://github.com/tabletcorry/haxby/tarball/haxby-0.1" + url "https://github.com/tabletcorry/haxby/tarball/haxby-0.2" ...
Update formula version to v0.2
diff --git a/spec/helper.rb b/spec/helper.rb index abc1234..def5678 100644 --- a/spec/helper.rb +++ b/spec/helper.rb @@ -6,6 +6,23 @@ YAML::load( File.open(file) )["key"] end +def stub_api_endpoint + 'http://ffapi.fanfeedr.com/basic/api' +end + +def stub_leagues_url + "#{stub_api_endpoint}/leagues?api_key=#{stub...
Add stub methods for league specs
diff --git a/app/uploaders/avatar_uploader.rb b/app/uploaders/avatar_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/avatar_uploader.rb +++ b/app/uploaders/avatar_uploader.rb @@ -18,7 +18,7 @@ end def default_url - DEFAULT_AVATAR_URL + DEFAULT_AVATAR_URL + '?' + ENV['RAILS_ASSET_ID'] end ...
Improve the caching of the default avatar
diff --git a/app/validators/slug_validator.rb b/app/validators/slug_validator.rb index abc1234..def5678 100644 --- a/app/validators/slug_validator.rb +++ b/app/validators/slug_validator.rb @@ -0,0 +1,6 @@+class SlugValidator < ActiveModel::EachValidator + # implement the method called during validation + def validate...
Add custom validator to check for well-formed slugs
diff --git a/lib/async_client/clients/qless.rb b/lib/async_client/clients/qless.rb index abc1234..def5678 100644 --- a/lib/async_client/clients/qless.rb +++ b/lib/async_client/clients/qless.rb @@ -2,3 +2,20 @@ require "qless" require "async_client/clients/qless/client" require "async_client/clients/qless/client_facto...
Add factory methods to AsyncClient::Clients::Qless
diff --git a/config/initializers/dragonfly.rb b/config/initializers/dragonfly.rb index abc1234..def5678 100644 --- a/config/initializers/dragonfly.rb +++ b/config/initializers/dragonfly.rb @@ -8,17 +8,20 @@ url_format "/media/:job/:name" - if Rails.env.production? + case Rails.env + when 'development' + dat...
Set memory storage for file upload tests
diff --git a/lib/fullcontact/client/company.rb b/lib/fullcontact/client/company.rb index abc1234..def5678 100644 --- a/lib/fullcontact/client/company.rb +++ b/lib/fullcontact/client/company.rb @@ -9,7 +9,7 @@ url = "company/search" end response = get(url, options, false, faraday_options) - ...
Fix Company API XML accessing nonexistent tag
diff --git a/config/initializers/resque.rb b/config/initializers/resque.rb index abc1234..def5678 100644 --- a/config/initializers/resque.rb +++ b/config/initializers/resque.rb @@ -2,5 +2,5 @@ require 'resque-status' Resque.inline = ENV['APP_ENV'] == 'test' -Resque.redis = ENV['REDIS_HOST'] || 'localhost' +Resque.re...
Add variable to be able to seperate Redis host for Resque.
diff --git a/lib/peribot/processor_registry.rb b/lib/peribot/processor_registry.rb index abc1234..def5678 100644 --- a/lib/peribot/processor_registry.rb +++ b/lib/peribot/processor_registry.rb @@ -18,14 +18,11 @@ @processors[processor] = true end - # Obtain a list of processors that have been previously...
Remove deprecated alias from ProcessorRegistry The tasks method was originally defined for the non-service "chains" in pre-0.9 Peribot, and was kept in ProcessorRegistry for backwards compatibility with calls like `bot.preprocessor.tasks`. With 0.9, the list method became the standard way to obtain registered handlers...
diff --git a/lib/rack/insight/enable-button.rb b/lib/rack/insight/enable-button.rb index abc1234..def5678 100644 --- a/lib/rack/insight/enable-button.rb +++ b/lib/rack/insight/enable-button.rb @@ -1,45 +1,36 @@ module Rack::Insight - class EnableButton + class EnableButton < Struct.new :app, :insight include Ren...
Complete rewrite of `EnableButton` to ensure compatibility with all other Rack apps Conflicts: lib/rack/insight/enable-button.rb
diff --git a/lib/rubycritic/source_control_systems/source_control_system.rb b/lib/rubycritic/source_control_systems/source_control_system.rb index abc1234..def5678 100644 --- a/lib/rubycritic/source_control_systems/source_control_system.rb +++ b/lib/rubycritic/source_control_systems/source_control_system.rb @@ -24,6 +2...
Add missing abstract method to SourceControlSystem
diff --git a/lib/facter/puppet_settings.rb b/lib/facter/puppet_settings.rb index abc1234..def5678 100644 --- a/lib/facter/puppet_settings.rb +++ b/lib/facter/puppet_settings.rb @@ -0,0 +1,80 @@+# 'inspired/stolen' from puppetlabs-stdlib puppet_vardir fact + + +begin + require 'facter/util/puppet_settings' +rescue Load...
Add a couple of facts about the puppet installation
diff --git a/lib/gir_ffi/in_out_pointer.rb b/lib/gir_ffi/in_out_pointer.rb index abc1234..def5678 100644 --- a/lib/gir_ffi/in_out_pointer.rb +++ b/lib/gir_ffi/in_out_pointer.rb @@ -13,13 +13,12 @@ end def self.from type, value - return from_gboolean value if type == :gboolean return from_utf8 val...
Refactor so InOutPointer knows it holds a :gboolean when it does.
diff --git a/lib/janky/builder/receiver.rb b/lib/janky/builder/receiver.rb index abc1234..def5678 100644 --- a/lib/janky/builder/receiver.rb +++ b/lib/janky/builder/receiver.rb @@ -10,7 +10,7 @@ elsif payload.completed? Build.complete(payload.id, payload.green?) else - return Rack::...
Return a 400 Bad Request for invalid payloads
diff --git a/lib/gdata.rb b/lib/gdata.rb index abc1234..def5678 100644 --- a/lib/gdata.rb +++ b/lib/gdata.rb @@ -19,4 +19,3 @@ require 'gdata/auth' # This is for Unicode "support" require 'jcode' if RUBY_VERSION < '1.9' -$KCODE = 'UTF8'
Fix for newer ruby version.
diff --git a/lib/ideas.rb b/lib/ideas.rb index abc1234..def5678 100644 --- a/lib/ideas.rb +++ b/lib/ideas.rb @@ -1,13 +1 @@-require "ideas/version" - -require "ideas/models/feature" -require "ideas/models/feature_set" -require "ideas/models/idea" - -require "ideas/scopes/root_scope" -require "ideas/scopes/idea_scope" -...
Simplify requiring of all files
diff --git a/lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-openstack-cloud_manager-vm.rb b/lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-openstack-cloud_manager-vm.rb index abc1234..def5678 100644 --- a/lib/miq_automation_engine/service_models/miq_ae_service_man...
Support associating Floating Ips with Instances * Add methods to the Openstack instance model for associating and disassociating floating ips with Openstack cloud instances. * Expose Associate and Disassociate Floating IP to Automate. (transferred from ManageIQ/manageiq@6273cc744c61389bad05a152eb2bcbb46c5f74cc...
diff --git a/lib/layer.rb b/lib/layer.rb index abc1234..def5678 100644 --- a/lib/layer.rb +++ b/lib/layer.rb @@ -32,7 +32,7 @@ end def rasterize(output) - size = "#{@terminal.width}*#{@terminal.height}" + size = "#{@terminal.width}px*#{@terminal.height}px" `phantomjs #{rasterize_path} #{@url...
Create image to be same size as the terminal
diff --git a/lib/hearthstone_json.rb b/lib/hearthstone_json.rb index abc1234..def5678 100644 --- a/lib/hearthstone_json.rb +++ b/lib/hearthstone_json.rb @@ -1,2 +1,18 @@+require 'httparty' + class HearthstoneJSON + include HTTParty + + API_URL_BASE = 'https://api.hearthstonejson.com'.freeze + API_VER = 'v1'.f...
Add very basic setup for httparty
diff --git a/lib/mina/slack/tasks.rb b/lib/mina/slack/tasks.rb index abc1234..def5678 100644 --- a/lib/mina/slack/tasks.rb +++ b/lib/mina/slack/tasks.rb @@ -2,15 +2,15 @@ namespace :slack do task :post_info do if (url = fetch(:slack_url)) && (room = fetch(:slack_room)) - if set?(:user) - Net::SSH.st...
Fix domain settings without user
diff --git a/lib/rusic/theme_file.rb b/lib/rusic/theme_file.rb index abc1234..def5678 100644 --- a/lib/rusic/theme_file.rb +++ b/lib/rusic/theme_file.rb @@ -9,17 +9,19 @@ end def uploader - case dirname + case dirname.to_s when 'layouts', 'ideas', 'pages' - Uploaders::Template.new(sel...
Fix extname and base name issues