diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/rack-attack-recaptcha.gemspec b/rack-attack-recaptcha.gemspec index abc1234..def5678 100644 --- a/rack-attack-recaptcha.gemspec +++ b/rack-attack-recaptcha.gemspec @@ -6,11 +6,11 @@ Gem::Specification.new do |spec| spec.name = "rack-attack-recaptcha" spec.version = Rack::Attack::Recapt...
Add gem info and dependencies
diff --git a/db/migrate/20120919171223_add_question_comments.rb b/db/migrate/20120919171223_add_question_comments.rb index abc1234..def5678 100644 --- a/db/migrate/20120919171223_add_question_comments.rb +++ b/db/migrate/20120919171223_add_question_comments.rb @@ -4,7 +4,7 @@ t.integer :id t.integer :q...
Comment bodies should be text, not varchar
diff --git a/core/app/models/spree/promotion_item_handlers.rb b/core/app/models/spree/promotion_item_handlers.rb index abc1234..def5678 100644 --- a/core/app/models/spree/promotion_item_handlers.rb +++ b/core/app/models/spree/promotion_item_handlers.rb @@ -1,4 +1,16 @@ module Spree + # Decides which promotion should b...
Make PromotionItemHandler have pluggable behaviour
diff --git a/config/initializers/fast_get_text.rb b/config/initializers/fast_get_text.rb index abc1234..def5678 100644 --- a/config/initializers/fast_get_text.rb +++ b/config/initializers/fast_get_text.rb @@ -5,6 +5,8 @@ FastGettext::TranslationRepository::Db.require_models #load and include default models FastGettext...
Use include to make the functions available in rails apps by default
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,3 +1,4 @@ # Be sure to restart your server when you modify this file. -Rails.application.config.session_sto...
Make use of secure session cookies
diff --git a/spec/matest_specs/aliases_spec.rb b/spec/matest_specs/aliases_spec.rb index abc1234..def5678 100644 --- a/spec/matest_specs/aliases_spec.rb +++ b/spec/matest_specs/aliases_spec.rb @@ -1,65 +1,65 @@ scope do spec { true } - xspec { true } + xspec { false } example { true } - xexample { true } + ...
Make skipped specs fail if aliases are broken Previously, skip aliases would error if they were not defined. This change ensures that skipped specs will fail if, for some reason, skip aliases are overwritten but not undefined.
diff --git a/spec/metacrunch/db/reader_spec.rb b/spec/metacrunch/db/reader_spec.rb index abc1234..def5678 100644 --- a/spec/metacrunch/db/reader_spec.rb +++ b/spec/metacrunch/db/reader_spec.rb @@ -1,6 +1,7 @@ describe Metacrunch::Db::Reader do - DB_URL = "sqlite://#{File.join(asset_dir, "dummy.sqlite")}" + DB_PROTO...
Make sure to use the right connection string in case of JRuby.
diff --git a/foodr-backend/app/models/user.rb b/foodr-backend/app/models/user.rb index abc1234..def5678 100644 --- a/foodr-backend/app/models/user.rb +++ b/foodr-backend/app/models/user.rb @@ -5,9 +5,13 @@ has_many :products, through: :searches has_many :ingredients, through: :products + validates :email, :passwo...
Add validation to require password and email. Add method to return average grade as 2 decimal places
diff --git a/app/models/developer.rb b/app/models/developer.rb index abc1234..def5678 100644 --- a/app/models/developer.rb +++ b/app/models/developer.rb @@ -2,12 +2,32 @@ devise :database_authenticatable, :trackable, :validatable, :omniauthable store_accessor :data, :html_url, :avatar_url, :company, :blog, :fol...
Add callbacks to invalidate cache and set premium
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -8,8 +8,8 @@ class CustomWorld - def initialize screenFactory - @screen_factory = screenFactory + def initialize screen_factory + @screen_factory = scre...
Use ruby conventions on param name
diff --git a/db/migrate/012_sandboxes.rb b/db/migrate/012_sandboxes.rb index abc1234..def5678 100644 --- a/db/migrate/012_sandboxes.rb +++ b/db/migrate/012_sandboxes.rb @@ -0,0 +1,25 @@+require File.expand_path('../settings', __FILE__) + +Sequel.migration do + up do + create_table(:checksums) do + String(:org_...
Add checksums and sandbox_checksums tables
diff --git a/packages/yaml_cpp.rb b/packages/yaml_cpp.rb index abc1234..def5678 100644 --- a/packages/yaml_cpp.rb +++ b/packages/yaml_cpp.rb @@ -9,7 +9,7 @@ opts.all do mkdir "Build" cd "Build" do - sh "cmake -DBUILD_SHARED_LIBS=FALSE -DCMAKE_INSTALL_PREFIX=#{opts.prefix} ../" + sh "cmak...
Fix compilation to have a universal lib
diff --git a/github_lda.gemspec b/github_lda.gemspec index abc1234..def5678 100644 --- a/github_lda.gemspec +++ b/github_lda.gemspec @@ -17,6 +17,8 @@ gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_paths = ["lib"] + gem.add_development_dependency "rake", ">= 0.9.2.2" + gem.add_run...
Add dev dependency to gemspec
diff --git a/init.rb b/init.rb index abc1234..def5678 100644 --- a/init.rb +++ b/init.rb @@ -1,9 +1,11 @@-require 'factory_girl' +config.gem 'thoughtbot-factory_girl', :lib => 'factory_girl', :source => 'http://gems.github.com' -%w(test spec).each do |dir| - factories = File.join(RAILS_ROOT, dir, 'factories.rb') - ...
Use config.gem to depend on factory_girl.
diff --git a/Casks/handbrakecli-nightly.rb b/Casks/handbrakecli-nightly.rb index abc1234..def5678 100644 --- a/Casks/handbrakecli-nightly.rb +++ b/Casks/handbrakecli-nightly.rb @@ -1,10 +1,10 @@ class HandbrakecliNightly < Cask - version '6419svn' - sha256 '3fcd67ddda23ba406789f0f00c9d501fd85a6c6348385ba6da8550db0fcf...
Update HandBrakeCLI Nightly to v6430svn HandBrakeCLI Nightly Build 6430svn released 2014-10-02.
diff --git a/Casks/handbrakecli-nightly.rb b/Casks/handbrakecli-nightly.rb index abc1234..def5678 100644 --- a/Casks/handbrakecli-nightly.rb +++ b/Casks/handbrakecli-nightly.rb @@ -1,6 +1,6 @@ cask :v1 => 'handbrakecli-nightly' do - version '6859svn' - sha256 '656a716c4c75d325cdfda874db4215ba280355b672c6f19ae5dd01325...
Update HandbrakeCLI Nightly to v6897svn HandBrakeCLI Nightly v6897svn built 2015-02-13.
diff --git a/lib/collective/collectors/rabbitmq.rb b/lib/collective/collectors/rabbitmq.rb index abc1234..def5678 100644 --- a/lib/collective/collectors/rabbitmq.rb +++ b/lib/collective/collectors/rabbitmq.rb @@ -28,7 +28,7 @@ queues.each do |queue| group 'rabbitmq.queue' do |group| - instrume...
Set source as queue name.
diff --git a/lib/modules/wdpa/carto_db_importer.rb b/lib/modules/wdpa/carto_db_importer.rb index abc1234..def5678 100644 --- a/lib/modules/wdpa/carto_db_importer.rb +++ b/lib/modules/wdpa/carto_db_importer.rb @@ -28,10 +28,10 @@ end def upload + cartodb_uploader = CartoDb::Uploader.new @cartodb_username, @car...
Reduce carto db uploader instance number
diff --git a/spec/classes/homebrew_spec.rb b/spec/classes/homebrew_spec.rb index abc1234..def5678 100644 --- a/spec/classes/homebrew_spec.rb +++ b/spec/classes/homebrew_spec.rb @@ -20,11 +20,6 @@ should contain_boxen__env_script("homebrew") - ["latest", "install"].each do |cmd| - should contain_file("#{...
Remove boxen-latest and boxen-install in favour of Homebrew
diff --git a/spec/deployment/nginx_spec.rb b/spec/deployment/nginx_spec.rb index abc1234..def5678 100644 --- a/spec/deployment/nginx_spec.rb +++ b/spec/deployment/nginx_spec.rb @@ -2,6 +2,15 @@ describe 'nginx' do describe 'configuration' do + CONFIG_PATH = "/var/vcap/jobs/cf-redis-broker/config/nginx.conf" + +...
Use bosh ssh wrapper in nginx deployment test - This spec file is not included in any rake task, is it an orphan? [#145917557]
diff --git a/db/migrate/20180930205254_add_variables_to_users.rb b/db/migrate/20180930205254_add_variables_to_users.rb index abc1234..def5678 100644 --- a/db/migrate/20180930205254_add_variables_to_users.rb +++ b/db/migrate/20180930205254_add_variables_to_users.rb @@ -9,7 +9,7 @@ def up add_column :users, :var...
Refresh user's model in variables migration [SCI-2864]
diff --git a/app/models/question.rb b/app/models/question.rb index abc1234..def5678 100644 --- a/app/models/question.rb +++ b/app/models/question.rb @@ -4,4 +4,12 @@ validates_presence_of :body validates_presence_of :title + + def self.search(words) + matches = [] + words.split(' ').each do |word| + ...
Add search class method for Question.
diff --git a/spec/direction_matrix_spec.rb b/spec/direction_matrix_spec.rb index abc1234..def5678 100644 --- a/spec/direction_matrix_spec.rb +++ b/spec/direction_matrix_spec.rb @@ -3,9 +3,9 @@ describe DirectionMatrix do it 'provides a method for each direction' do - expect(described_class.north).to eq [0,1] - ...
Add extra spaces in DirectionMatrix spec
diff --git a/spec/rrj/rrj_requests_spec.rb b/spec/rrj/rrj_requests_spec.rb index abc1234..def5678 100644 --- a/spec/rrj/rrj_requests_spec.rb +++ b/spec/rrj/rrj_requests_spec.rb @@ -6,24 +6,26 @@ describe '.message_template_ask' do let(:transaction) { RRJ::RRJ.new } - let(:request_info) { transaction.message...
Fix test destroy and replace methods with aliases
diff --git a/app/models/tip.rb b/app/models/tip.rb index abc1234..def5678 100644 --- a/app/models/tip.rb +++ b/app/models/tip.rb @@ -27,7 +27,7 @@ def should_generate_new_friendly_id? if persisted? - created_at < 1.day.ago + created_at > 1.day.ago else super end
Fix another small bug in friendly_id for Tips Apparently the condition for generating new slugs was reversed.
diff --git a/scripts/generate_toc.rb b/scripts/generate_toc.rb index abc1234..def5678 100644 --- a/scripts/generate_toc.rb +++ b/scripts/generate_toc.rb @@ -0,0 +1,15 @@+#!/usr/bin/env ruby + +# Source: https://gist.github.com/albertodebortoli/9310424 +# Via: http://stackoverflow.com/a/22131019/873282 + +File.open("Cod...
Add script to generate a TOC based for markdown files
diff --git a/gemfiles/travis.rb b/gemfiles/travis.rb index abc1234..def5678 100644 --- a/gemfiles/travis.rb +++ b/gemfiles/travis.rb @@ -2,6 +2,6 @@ gem "codeclimate-test-reporter".freeze gem "json".freeze, "~> 1.8.3".freeze -gem "rake".freeze +gem "rake".freeze, "~> 10.5.0".freeze gem "rspec".freeze gem "simpleco...
Use older `rake` version for Travis tests.
diff --git a/gemologist.gemspec b/gemologist.gemspec index abc1234..def5678 100644 --- a/gemologist.gemspec +++ b/gemologist.gemspec @@ -8,10 +8,6 @@ spec.version = Gemologist::VERSION spec.authors = ["Yuji Nakayama"] spec.email = ["nkymyj@gmail.com"] - - if spec.respond_to?(:metadata) - ...
Remove allowed_push_host definition in gemspec
diff --git a/core/db/migrate/20130802022321_migrate_tax_categories_to_line_items.rb b/core/db/migrate/20130802022321_migrate_tax_categories_to_line_items.rb index abc1234..def5678 100644 --- a/core/db/migrate/20130802022321_migrate_tax_categories_to_line_items.rb +++ b/core/db/migrate/20130802022321_migrate_tax_categor...
Fix migration to run when no tax category set on product.
diff --git a/instrumental_tools.gemspec b/instrumental_tools.gemspec index abc1234..def5678 100644 --- a/instrumental_tools.gemspec +++ b/instrumental_tools.gemspec @@ -15,7 +15,7 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["lib"] s.add_runtime_depende...
Upgrade to latest version of instrumental_agent.
diff --git a/db/data_migration/20210225103359_update_pa_ur_translations_to_pa_pk.rb b/db/data_migration/20210225103359_update_pa_ur_translations_to_pa_pk.rb index abc1234..def5678 100644 --- a/db/data_migration/20210225103359_update_pa_ur_translations_to_pa_pk.rb +++ b/db/data_migration/20210225103359_update_pa_ur_tran...
Update all pa-ur locales to pa-pk, and republish
diff --git a/lib/finite_machine/threadable.rb b/lib/finite_machine/threadable.rb index abc1234..def5678 100644 --- a/lib/finite_machine/threadable.rb +++ b/lib/finite_machine/threadable.rb @@ -7,15 +7,30 @@ module InstanceMethods @@sync = Sync.new + # Exclusive lock + # + # @return [nil] + ...
Change to allow for default value, add docs.
diff --git a/lib/formalist/output_compiler.rb b/lib/formalist/output_compiler.rb index abc1234..def5678 100644 --- a/lib/formalist/output_compiler.rb +++ b/lib/formalist/output_compiler.rb @@ -23,33 +23,33 @@ end def visit_attr(data) - name, elements, _errors = data + name, predicates, errors, chil...
Update output compiler to match AST output
diff --git a/lib/nested_db/models/instance.rb b/lib/nested_db/models/instance.rb index abc1234..def5678 100644 --- a/lib/nested_db/models/instance.rb +++ b/lib/nested_db/models/instance.rb @@ -27,6 +27,7 @@ module ClassMethods def image_variation(input, variation = nil) + input = input.u...
Convert input to a string if the input was an uploader
diff --git a/spec/filtration_spec.rb b/spec/filtration_spec.rb index abc1234..def5678 100644 --- a/spec/filtration_spec.rb +++ b/spec/filtration_spec.rb @@ -27,16 +27,15 @@ end it 'raises an error if the method has no arguments' do - pending class Foo3 def foo 2 end end c...
Fix no argument error test
diff --git a/spec/lib/column_spec.rb b/spec/lib/column_spec.rb index abc1234..def5678 100644 --- a/spec/lib/column_spec.rb +++ b/spec/lib/column_spec.rb @@ -20,22 +20,17 @@ it 'returns the email from a proc correctly' do email_column.value(dummy_model, view_context).should == 'robert at example.com' end...
Remove available spec in columns. Add specs for human name.
diff --git a/lib/printer/jobs/prepare_page.rb b/lib/printer/jobs/prepare_page.rb index abc1234..def5678 100644 --- a/lib/printer/jobs/prepare_page.rb +++ b/lib/printer/jobs/prepare_page.rb @@ -3,6 +3,7 @@ require "printer/id_generator" require "printer/preview" require "timeout" +require "shellwords" class Printer...
Patch shell injection vulnerability in prepare page By escaping the URL argument, we prevent arbitrary commands from being able to be injected there. Fixes #56
diff --git a/lib/rodzilla/resource/product.rb b/lib/rodzilla/resource/product.rb index abc1234..def5678 100644 --- a/lib/rodzilla/resource/product.rb +++ b/lib/rodzilla/resource/product.rb @@ -11,7 +11,7 @@ end def get_accessible_products - prepare_request + self.class.prepare_request ...
Make prepare request a class method call
diff --git a/lib/sequel_mapper/root_mapper.rb b/lib/sequel_mapper/root_mapper.rb index abc1234..def5678 100644 --- a/lib/sequel_mapper/root_mapper.rb +++ b/lib/sequel_mapper/root_mapper.rb @@ -3,6 +3,7 @@ module SequelMapper class RootMapper include MapperMethods + include Enumerable def initialize(re...
Refactor RootMapper to fluid interface
diff --git a/lib/picolena/templates/spec/controllers/application_controller_spec.rb b/lib/picolena/templates/spec/controllers/application_controller_spec.rb index abc1234..def5678 100644 --- a/lib/picolena/templates/spec/controllers/application_controller_spec.rb +++ b/lib/picolena/templates/spec/controllers/applicatio...
Access denied specs. Preparing views specs. git-svn-id: 52e2e43ce7a15623d54ec01c4d971b259c993eed@215 354c73f7-f838-4446-8ec5-bf0d774acd2b
diff --git a/lib/specinfra/command/freebsd.rb b/lib/specinfra/command/freebsd.rb index abc1234..def5678 100644 --- a/lib/specinfra/command/freebsd.rb +++ b/lib/specinfra/command/freebsd.rb @@ -30,6 +30,10 @@ def install(package) "pkg_add -r install #{package}" end + + def get_package_version(...
Support return package version for installed packages on FreeBSD
diff --git a/lib/toy_robot_simulator/robot.rb b/lib/toy_robot_simulator/robot.rb index abc1234..def5678 100644 --- a/lib/toy_robot_simulator/robot.rb +++ b/lib/toy_robot_simulator/robot.rb @@ -3,6 +3,8 @@ module ToyRobotSimulator class Robot attr_accessor :x, :y, :facing + + DEFAULT_MOVEMENT = "FORWARD" ...
Add default movement to be FORWARD
diff --git a/init.rb b/init.rb index abc1234..def5678 100644 --- a/init.rb +++ b/init.rb @@ -1,4 +1,8 @@ require "taobao_fu" + +#Fix "couldn't parse YAML" error ruby 1.9.2/rails 3.1 +require 'yaml' +YAML::ENGINE.yamler= 'syck' config_file = File.join(Rails.root, "config", "taobao.yml") TaobaoFu.load(config_file) if...
Fix "couldn't parse YAML" error ruby 1.9.2/rails 3.1
diff --git a/lib/fake_xml_server/api.rb b/lib/fake_xml_server/api.rb index abc1234..def5678 100644 --- a/lib/fake_xml_server/api.rb +++ b/lib/fake_xml_server/api.rb @@ -24,7 +24,9 @@ sent = params[:s] respond_to do |f| - f.xml { post_file(doc, sent, request.body.read)} + f.xml do + post_file...
Add positive response to post
diff --git a/lib/feature_definitions.rb b/lib/feature_definitions.rb index abc1234..def5678 100644 --- a/lib/feature_definitions.rb +++ b/lib/feature_definitions.rb @@ -11,6 +11,8 @@ def initialize(proc) @test_proc = proc end + + @@context = nil def self.context=(context) @@context = context
Initialize @@context in super class
diff --git a/lib/graphql/scalar_type.rb b/lib/graphql/scalar_type.rb index abc1234..def5678 100644 --- a/lib/graphql/scalar_type.rb +++ b/lib/graphql/scalar_type.rb @@ -1,5 +1,14 @@ module GraphQL # The parent type for scalars, eg {GraphQL::STRING_TYPE}, {GraphQL::INT_TYPE} + # + # @example defining a type for Tim...
Add an example for a custom scalar.
diff --git a/lib/fulcrum/resource.rb b/lib/fulcrum/resource.rb index abc1234..def5678 100644 --- a/lib/fulcrum/resource.rb +++ b/lib/fulcrum/resource.rb @@ -47,7 +47,7 @@ end def all(params = default_index_params) - result = call(:get, collection, params) + result = call(:get, collection, default_i...
Make sure default params are always used.
diff --git a/lib/like/interaction.rb b/lib/like/interaction.rb index abc1234..def5678 100644 --- a/lib/like/interaction.rb +++ b/lib/like/interaction.rb @@ -13,7 +13,7 @@ def post_action if ActionPack::VERSION::STRING.to_i > 4 - controller.redirect_back fallback_location: "/"#, status: 303 + controll...
Remove accidental comment in redirect_back change.
diff --git a/lib/micro_migrations.rb b/lib/micro_migrations.rb index abc1234..def5678 100644 --- a/lib/micro_migrations.rb +++ b/lib/micro_migrations.rb @@ -1,7 +1,5 @@ require 'rails' require 'active_record/railtie' - -Bundler.require app = Class.new(Rails::Application) app.config.active_support.deprecation = :lo...
Remove Bundler.require call. Makes no sense inside a gem.
diff --git a/lib/nanite/exchanges.rb b/lib/nanite/exchanges.rb index abc1234..def5678 100644 --- a/lib/nanite/exchanges.rb +++ b/lib/nanite/exchanges.rb @@ -1,4 +1,11 @@ module Nanite + # Using these methods actors can participate in distributed processing + # with other nodes using topic exchange publishing (classic...
Document how Nanite agents can participate in distrubuted processing using topic queues and push_to_exchange/subscribe_to_exchange. Signed-off-by: ezmobius <4aca359fa1b78e51bc8226c4f161d16fdc1e21c8@engineyard.com>
diff --git a/lib/rack/methodoverride.rb b/lib/rack/methodoverride.rb index abc1234..def5678 100644 --- a/lib/rack/methodoverride.rb +++ b/lib/rack/methodoverride.rb @@ -4,6 +4,7 @@ METHOD_OVERRIDE_PARAM_KEY = "_method".freeze HTTP_METHOD_OVERRIDE_HEADER = "HTTP_X_HTTP_METHOD_OVERRIDE".freeze + ALLOWED_MET...
Move ["POST"] to a constant
diff --git a/lib/r_fast_r_furious.rb b/lib/r_fast_r_furious.rb index abc1234..def5678 100644 --- a/lib/r_fast_r_furious.rb +++ b/lib/r_fast_r_furious.rb @@ -7,7 +7,12 @@ SOURCE = "https://raw.github.com/alunny/r_fast_r_furious/master/fast.js" def check(string, url = SOURCE) uri = URI.parse(SOURCE) - conten...
Make specs pass on Ruby 1.9
diff --git a/lib/urban_dictionary.rb b/lib/urban_dictionary.rb index abc1234..def5678 100644 --- a/lib/urban_dictionary.rb +++ b/lib/urban_dictionary.rb @@ -16,9 +16,9 @@ def self.random_word url = URI.parse(RANDOM_URL) req = Net::HTTP::Get.new(url.path) - rsp = Net::HTTP.start(url.host, url.port) {|http...
Use do ... end for multiline blocks
diff --git a/flamegraph.gemspec b/flamegraph.gemspec index abc1234..def5678 100644 --- a/flamegraph.gemspec +++ b/flamegraph.gemspec @@ -10,7 +10,7 @@ spec.email = ["sam.saffron@gmail.com"] spec.description = %q{Flamegraph support for arbitrary ruby apps} spec.summary = %q{Flamegraph support for...
Add homepage link to gemspec
diff --git a/lib/capybara-screenshot/rspec/html_link_reporter.rb b/lib/capybara-screenshot/rspec/html_link_reporter.rb index abc1234..def5678 100644 --- a/lib/capybara-screenshot/rspec/html_link_reporter.rb +++ b/lib/capybara-screenshot/rspec/html_link_reporter.rb @@ -22,7 +22,7 @@ end def link_to_sc...
Fix undefined 'URI.escape' method in Ruby3.0.2 https://github.com/mattheworiordan/capybara-screenshot/issues/283
diff --git a/lib/fog/brightbox/models/compute/firewall_policy.rb b/lib/fog/brightbox/models/compute/firewall_policy.rb index abc1234..def5678 100644 --- a/lib/fog/brightbox/models/compute/firewall_policy.rb +++ b/lib/fog/brightbox/models/compute/firewall_policy.rb @@ -41,6 +41,16 @@ true end + ...
[Brightbox] Add model method for remove
diff --git a/lib/fixer_upper/engine/erb.rb b/lib/fixer_upper/engine/erb.rb index abc1234..def5678 100644 --- a/lib/fixer_upper/engine/erb.rb +++ b/lib/fixer_upper/engine/erb.rb @@ -1,10 +1,12 @@ class FixerUpper module Engine class Erb - def call(text, scope:, &block) + def call(text, scope:, _filepat...
Set filepath on ERB engine
diff --git a/lib/tasks/taxonomy/remove_non_education_taxons.rake b/lib/tasks/taxonomy/remove_non_education_taxons.rake index abc1234..def5678 100644 --- a/lib/tasks/taxonomy/remove_non_education_taxons.rake +++ b/lib/tasks/taxonomy/remove_non_education_taxons.rake @@ -0,0 +1,48 @@+namespace :taxonomy do + desc "remove...
Add rake task to remove non-education taxon
diff --git a/lib/scorebutt/host_watcher.rb b/lib/scorebutt/host_watcher.rb index abc1234..def5678 100644 --- a/lib/scorebutt/host_watcher.rb +++ b/lib/scorebutt/host_watcher.rb @@ -28,13 +28,13 @@ begin result = client.get(target) if ok_status_codes.include? result.header.status_code - ...
Remove puts in service method, Scorer can print it
diff --git a/lib/tasks/connectors_api.rake b/lib/tasks/connectors_api.rake index abc1234..def5678 100644 --- a/lib/tasks/connectors_api.rake +++ b/lib/tasks/connectors_api.rake @@ -0,0 +1,30 @@+namespace :cartodb do + namespace :connectors do + desc 'Adapt connector synchronizations to the new API' + task adapt_...
Add rake task to adapt syncs to API changes The rake taks will adapt existing connector synchronizations to work with the new API defined by #9674
diff --git a/lib/tasks/webhookr_tasks.rake b/lib/tasks/webhookr_tasks.rake index abc1234..def5678 100644 --- a/lib/tasks/webhookr_tasks.rake +++ b/lib/tasks/webhookr_tasks.rake @@ -1,4 +1,16 @@-# desc "Explaining what the task does" -# task :webhookr do -# # Task goes here -# end +namespace :webhookr do + desc "List...
Add a rake task to show the configured services paths
diff --git a/lib/travis-deploy-logs/app.rb b/lib/travis-deploy-logs/app.rb index abc1234..def5678 100644 --- a/lib/travis-deploy-logs/app.rb +++ b/lib/travis-deploy-logs/app.rb @@ -42,7 +42,7 @@ halt 404, "Unknown app" end - redirect "https://dashboard-next.heroku.com/orgs/#{heroku_org}/apps/#{her...
Change Heroku redirect URL to their new dashboard domain
diff --git a/lib/windcharger/attributes.rb b/lib/windcharger/attributes.rb index abc1234..def5678 100644 --- a/lib/windcharger/attributes.rb +++ b/lib/windcharger/attributes.rb @@ -3,13 +3,13 @@ module Windcharger module Attributes def attributes - (@__attributes || []).dup.freeze + (@__windcharger_at...
Reduce collision probability with ivars Since these are in the user’s class.
diff --git a/lib/be_gateway/checkout.rb b/lib/be_gateway/checkout.rb index abc1234..def5678 100644 --- a/lib/be_gateway/checkout.rb +++ b/lib/be_gateway/checkout.rb @@ -3,7 +3,8 @@ include Connection def get_token(params) - send_request('post', '/ctp/api/checkouts', checkout: params.merge('version' => '...
Add version acceptance with 2.1 by default
diff --git a/lib/bcu/options.rb b/lib/bcu/options.rb index abc1234..def5678 100644 --- a/lib/bcu/options.rb +++ b/lib/bcu/options.rb @@ -35,6 +35,11 @@ parser.parse!(args) + if args[0] == "help" + puts parser + exit + end + options.cask = args[0] self.options = options
Add `brew cu help` command Closes #50
diff --git a/lib/lita/builder.rb b/lib/lita/builder.rb index abc1234..def5678 100644 --- a/lib/lita/builder.rb +++ b/lib/lita/builder.rb @@ -17,7 +17,7 @@ # Constructs a {Lita::Handler} from the provided block. def build_handler handler = create_plugin(Handler) - handler.instance_exec(&@block) + ...
Use class_exec when building a handler for better semantics.
diff --git a/lib/mjml/railtie.rb b/lib/mjml/railtie.rb index abc1234..def5678 100644 --- a/lib/mjml/railtie.rb +++ b/lib/mjml/railtie.rb @@ -7,8 +7,12 @@ class Railtie < ::Rails::Railtie # Template handler for Rails class Handler + def initialize(base_handler = :erb) + @base_handler = base_handl...
Handle slim and haml templates
diff --git a/app/controllers/podcasts_controller.rb b/app/controllers/podcasts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/podcasts_controller.rb +++ b/app/controllers/podcasts_controller.rb @@ -1,6 +1,7 @@ class PodcastsController < ApplicationController def show @podcast = Podcast.find(p...
Set the default feed for the podcast
diff --git a/app/models/feeder/feedable_observer.rb b/app/models/feeder/feedable_observer.rb index abc1234..def5678 100644 --- a/app/models/feeder/feedable_observer.rb +++ b/app/models/feeder/feedable_observer.rb @@ -15,6 +15,8 @@ end def after_save(feedable) + feedable.reload + item = feedable.f...
Fix a bug that caused a NoMethodError on nil
diff --git a/app/presenters/option_set_presenter.rb b/app/presenters/option_set_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/option_set_presenter.rb +++ b/app/presenters/option_set_presenter.rb @@ -14,9 +14,7 @@ TypeCoersion::HashCoercer.new(config: option_types).coerce(options) end - # rub...
Remove unnecessary rubocop disable comments This method used to be long but now it has been extracted
diff --git a/lib/rudy/aws.rb b/lib/rudy/aws.rb index abc1234..def5678 100644 --- a/lib/rudy/aws.rb +++ b/lib/rudy/aws.rb @@ -21,7 +21,7 @@ str.to_s.tr!("[\0\n\r\032\\\\]", '').gsub!(/([\'\"])/, '\\1\\1') end - require 'rudy/aws/sdb' + #require 'rudy/aws/sdb' require 'rudy/aws/ec2' r...
ADDED: Debug mode global option -D
diff --git a/lib/salt/clt.rb b/lib/salt/clt.rb index abc1234..def5678 100644 --- a/lib/salt/clt.rb +++ b/lib/salt/clt.rb @@ -2,9 +2,9 @@ require 'salt/clt/version' require 'salt/clt/config' -require 'salt/clt/cli' require 'salt/clt/errors' require 'salt/clt/api' +require 'salt/clt/cli' module Salt module CLT...
Load CLI a bit later
diff --git a/lib/zebra/zpl/printable.rb b/lib/zebra/zpl/printable.rb index abc1234..def5678 100644 --- a/lib/zebra/zpl/printable.rb +++ b/lib/zebra/zpl/printable.rb @@ -16,6 +16,9 @@ def position=(coords) @position, @x, @y = coords, coords[0], coords[1] + if @justification + @x = 0 + ...
Set x position to zero if justification is given
diff --git a/lib/plotly/axis.rb b/lib/plotly/axis.rb index abc1234..def5678 100644 --- a/lib/plotly/axis.rb +++ b/lib/plotly/axis.rb @@ -4,9 +4,12 @@ class Axis include Castable - ATTRS = %i(title range).freeze + ATTRS = %i(title range zeroline).freeze attr_accessor(*ATTRS) + # @option opts [St...
Add an attribute to Axis
diff --git a/lib/poke/window.rb b/lib/poke/window.rb index abc1234..def5678 100644 --- a/lib/poke/window.rb +++ b/lib/poke/window.rb @@ -12,14 +12,14 @@ @paused = false - @user = User.new(self, 416, 288) + @player = User.new(self, 416, 288) @controls = Controls.new(window: self) ...
Change Window's user ivar to player
diff --git a/microsoft-live-simple.gemspec b/microsoft-live-simple.gemspec index abc1234..def5678 100644 --- a/microsoft-live-simple.gemspec +++ b/microsoft-live-simple.gemspec @@ -1,9 +1,9 @@ Gem::Specification.new do |spec| - spec.name = 'microsoft-live-rest-client' + spec.name = 'microsoft-live-simpl...
Update gemspec with correct gem name.
diff --git a/libexec/um-list.rb b/libexec/um-list.rb index abc1234..def5678 100644 --- a/libexec/um-list.rb +++ b/libexec/um-list.rb @@ -25,7 +25,7 @@ end if $stdout.isatty - exec(%{ls "#{topic_directory}" | sed 's/.txt//' | column}) + exec(%{ls "#{topic_directory}" | sed 's/\.[[:alnum:]]*$//' | column}) else - ...
Update um list extension filter regex to accomodate .md
diff --git a/lib/cxml/status.rb b/lib/cxml/status.rb index abc1234..def5678 100644 --- a/lib/cxml/status.rb +++ b/lib/cxml/status.rb @@ -2,6 +2,7 @@ class Status attr_accessor :code attr_accessor :text + attr_accessor :content attr_accessor :xml_lang # Initialize a new Status instance @@ -12,...
Add support for Status content
diff --git a/lib/lifeguard/infinite_threadpool.rb b/lib/lifeguard/infinite_threadpool.rb index abc1234..def5678 100644 --- a/lib/lifeguard/infinite_threadpool.rb +++ b/lib/lifeguard/infinite_threadpool.rb @@ -9,6 +9,7 @@ @queued_jobs = ::Queue.new @shutdown = false @super_async_mutex = ::Mutex.new +...
Use a scheduler for infinite threadpool
diff --git a/spec/dummy/app/relations/users.rb b/spec/dummy/app/relations/users.rb index abc1234..def5678 100644 --- a/spec/dummy/app/relations/users.rb +++ b/spec/dummy/app/relations/users.rb @@ -1,6 +1,4 @@ class Users < ROM::Relation[:sql] - base_name :users - def by_id(id) where(id: id) end
Update dummy app to pass on latest ROM from master
diff --git a/spec/services/next_bidder_spec.rb b/spec/services/next_bidder_spec.rb index abc1234..def5678 100644 --- a/spec/services/next_bidder_spec.rb +++ b/spec/services/next_bidder_spec.rb @@ -0,0 +1,29 @@+require 'rails_helper' + +RSpec.describe NextBidder do + describe "#call" do + subject(:service) { NextBid...
Add RSpec test for NextBidder
diff --git a/lib/mako/writer.rb b/lib/mako/writer.rb index abc1234..def5678 100644 --- a/lib/mako/writer.rb +++ b/lib/mako/writer.rb @@ -0,0 +1,16 @@+module Mako + class Writer + attr_reader :renderer, :destination + + def initialize(args) + @renderer = args.fetch(:renderer) + @destination = args.fetch...
Add Writer class to write output of renderers
diff --git a/lib/pcap/packet.rb b/lib/pcap/packet.rb index abc1234..def5678 100644 --- a/lib/pcap/packet.rb +++ b/lib/pcap/packet.rb @@ -22,7 +22,7 @@ # Returns the data payload of the packet. # def payload - self + self.size + self.to_ptr + self.size end #
Make sure to call to_ptr.
diff --git a/NSObject-SafeExpectations.podspec b/NSObject-SafeExpectations.podspec index abc1234..def5678 100644 --- a/NSObject-SafeExpectations.podspec +++ b/NSObject-SafeExpectations.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "NSObject-SafeExpectations" - s.version = "0.0.4-beta.1" + s.ve...
Update podspec, change version to 0.0.4
diff --git a/lib/rackstash/filters/clear_color.rb b/lib/rackstash/filters/clear_color.rb index abc1234..def5678 100644 --- a/lib/rackstash/filters/clear_color.rb +++ b/lib/rackstash/filters/clear_color.rb @@ -9,6 +9,12 @@ module Filters # Remove all ANSI color codes from the `"message"` field of the given event ...
Add code example how to instantiate the ClearColor filter
diff --git a/lib/devise/models/suspendable.rb b/lib/devise/models/suspendable.rb index abc1234..def5678 100644 --- a/lib/devise/models/suspendable.rb +++ b/lib/devise/models/suspendable.rb @@ -12,14 +12,14 @@ def active_for_authentication? if super - return true if !suspended? + retur...
Remove unnecessary negation from suspension logic. Use `unless` and flip ternary operators to avoid having to think through too much negation in conditionals; hopefully this makes the logic a bit clearer.
diff --git a/lib/ruxero/base_model/finders.rb b/lib/ruxero/base_model/finders.rb index abc1234..def5678 100644 --- a/lib/ruxero/base_model/finders.rb +++ b/lib/ruxero/base_model/finders.rb @@ -1,8 +1,8 @@ class Ruxero::BaseModel - def self.all(params = {}) + def self.all(params = {}, headers = {}) parts = ["/a...
Allow passing headers to Ruxero model 'all' method
diff --git a/lib/sidekiq/expected_failures.rb b/lib/sidekiq/expected_failures.rb index abc1234..def5678 100644 --- a/lib/sidekiq/expected_failures.rb +++ b/lib/sidekiq/expected_failures.rb @@ -48,3 +48,9 @@ Sidekiq::Web.register Sidekiq::ExpectedFailures::Web Sidekiq::Web.tabs["Expected Failures"] = "expected_failur...
Insert server middleware by default
diff --git a/lib/sinatra/assetpack/helpers.rb b/lib/sinatra/assetpack/helpers.rb index abc1234..def5678 100644 --- a/lib/sinatra/assetpack/helpers.rb +++ b/lib/sinatra/assetpack/helpers.rb @@ -11,7 +11,7 @@ def img(src, options={}) attrs = { :src => HtmlHelpers.get_file_uri(src, settings.assets) } - ...
Fix for ruby 1.8 compatiblity
diff --git a/octokit.gemspec b/octokit.gemspec index abc1234..def5678 100644 --- a/octokit.gemspec +++ b/octokit.gemspec @@ -4,7 +4,7 @@ require 'octokit/version' Gem::Specification.new do |spec| - spec.add_development_dependency 'bundler', '~> 1.0' + spec.add_development_dependency 'bundler', '>= 1', '< 3' spe...
Expand Bundler dependency version requirements
diff --git a/sample/db/samples/adjustments.rb b/sample/db/samples/adjustments.rb index abc1234..def5678 100644 --- a/sample/db/samples/adjustments.rb +++ b/sample/db/samples/adjustments.rb @@ -8,7 +8,7 @@ :source => first_order, :originator => Spree::TaxRate.find_by_name!("North America"), :label => "Tax", - :...
Convert db seed + sample files to Ruby This removes some confusion about what countries are in what zone members, and will prevent us from running into issues like #2547
diff --git a/tests/spec/requests/cors_spec.rb b/tests/spec/requests/cors_spec.rb index abc1234..def5678 100644 --- a/tests/spec/requests/cors_spec.rb +++ b/tests/spec/requests/cors_spec.rb @@ -0,0 +1,23 @@+require 'net/http' +require 'spec_helper' + +RSpec.feature "Cross-origin requests", type: :request do + let(:eval...
Test that CORS requests are allowed
diff --git a/build_tools/publisher/ejs_publisher.rb b/build_tools/publisher/ejs_publisher.rb index abc1234..def5678 100644 --- a/build_tools/publisher/ejs_publisher.rb +++ b/build_tools/publisher/ejs_publisher.rb @@ -5,6 +5,7 @@ module Publisher class EJSPublisher + include Helpers GIT_REPO = "github.com/a...
Add missing include statement to EJS publisher
diff --git a/jsoneur/service.rb b/jsoneur/service.rb index abc1234..def5678 100644 --- a/jsoneur/service.rb +++ b/jsoneur/service.rb @@ -1,3 +1,5 @@+require 'open-uri' + module Jsoneur class Service @@ -6,11 +8,14 @@ def initialize(name, base_url, &block) @name = name @base_url = base_url - ...
Fix problem with Faraday config
diff --git a/combo_build_api/lib/api_constraints.rb b/combo_build_api/lib/api_constraints.rb index abc1234..def5678 100644 --- a/combo_build_api/lib/api_constraints.rb +++ b/combo_build_api/lib/api_constraints.rb @@ -0,0 +1,10 @@+class ApiConstraints + def initialize(options) + @version = options[:version] + @de...
Add api constraints file under lib folder
diff --git a/mixlib-log.gemspec b/mixlib-log.gemspec index abc1234..def5678 100644 --- a/mixlib-log.gemspec +++ b/mixlib-log.gemspec @@ -11,7 +11,7 @@ gem.authors = ["Opscode, Inc."] gem.has_rdoc = true gem.extra_rdoc_files = ["README.rdoc", "LICENSE", 'NOTICE'] - gem.files = Dir['lib/**/*'] + gem.files = Dir...
CHEF-3169: Include tests in gem package for distros, test.rubygems.org, etc
diff --git a/spec/integration/adapter_spec.rb b/spec/integration/adapter_spec.rb index abc1234..def5678 100644 --- a/spec/integration/adapter_spec.rb +++ b/spec/integration/adapter_spec.rb @@ -12,7 +12,11 @@ setup.relation(:users, adapter: :yesql) end - it 'works yay!' do - expect(users.by_name(name: 'Jane...
Update example descriptions in spec
diff --git a/lib/gitnesse.rb b/lib/gitnesse.rb index abc1234..def5678 100644 --- a/lib/gitnesse.rb +++ b/lib/gitnesse.rb @@ -1,11 +1,9 @@ require 'gitnesse/version' -require 'gitnesse/commit_info_generator' require 'gitnesse/config' require 'gitnesse/config_loader' require 'gitnesse/dependency_checker' require 'git...
Remove requires for no-longer-used classes
diff --git a/spec/features/remote/github/miscellaneous/gitignore_spec.rb b/spec/features/remote/github/miscellaneous/gitignore_spec.rb index abc1234..def5678 100644 --- a/spec/features/remote/github/miscellaneous/gitignore_spec.rb +++ b/spec/features/remote/github/miscellaneous/gitignore_spec.rb @@ -0,0 +1,19 @@+requir...
Add spec for GitHub gitignore
diff --git a/lib/parsable.rb b/lib/parsable.rb index abc1234..def5678 100644 --- a/lib/parsable.rb +++ b/lib/parsable.rb @@ -15,7 +15,14 @@ crunched = original.dup parsed_parts.each do |item| - crunched.gsub!("{{#{item.original}}}", context.read(item.object, item.attribute).to_s) + # Using the bloc...
Use block form of gsub