diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -2,7 +2,7 @@ require 'dotenv' require './helpers/logs_helpers' -Cuba.use Rack::Static, urls: %w[/js /css], root: "public" +Cuba.use Rack::Static, urls: %w[/js /css /img]...
Add img folder for cuba.
diff --git a/lib/rsscache/feed.rb b/lib/rsscache/feed.rb index abc1234..def5678 100644 --- a/lib/rsscache/feed.rb +++ b/lib/rsscache/feed.rb @@ -3,6 +3,10 @@ module RSSCache # An RSS or Atom feed. class Feed + # Maximum number of seconds an update will return a + # cached response. + MAX_STALENESS = 900 ...
Add some very basic caching behavior. A `MAX_STALENESS` in number of seconds governs whether or not the update method actually does any fetching. This is pretty much a stand-in until some more thoughtful caching is implemented. The update method accepts one parameter, defaulting to false, that determines whether a ha...
diff --git a/engines/standard_tasks/spec/models/paper_admin_task_spec.rb b/engines/standard_tasks/spec/models/paper_admin_task_spec.rb index abc1234..def5678 100644 --- a/engines/standard_tasks/spec/models/paper_admin_task_spec.rb +++ b/engines/standard_tasks/spec/models/paper_admin_task_spec.rb @@ -8,15 +8,18 @@ end...
Fix paper admin task spec.
diff --git a/lib/sikuli/key_code.rb b/lib/sikuli/key_code.rb index abc1234..def5678 100644 --- a/lib/sikuli/key_code.rb +++ b/lib/sikuli/key_code.rb @@ -1,4 +1,6 @@ require 'java' +java_import 'org.sikuli.script.Key' +java_import 'org.sikuli.script.KeyModifier' # These constants represent keyboard codes for interact...
Use definitions of modifier keys defined by org.sikuli.script.KeyModifier Use definitions of keystrokes defined by org.sikuli.script.Key Add support for all arrow keys
diff --git a/lib/spree_robokassa.rb b/lib/spree_robokassa.rb index abc1234..def5678 100644 --- a/lib/spree_robokassa.rb +++ b/lib/spree_robokassa.rb @@ -8,7 +8,7 @@ def self.activate Dir.glob(File.join(File.dirname(__FILE__), "../app/**/*_decorator*.rb")) do |c| - Rails.env.production? ? require(c) ...
Change way of checking rails env.
diff --git a/rgpg.gemspec b/rgpg.gemspec index abc1234..def5678 100644 --- a/rgpg.gemspec +++ b/rgpg.gemspec @@ -13,7 +13,7 @@ s.license = 'MIT' s.authors = 'Richard Cook' s.email = 'rcook@rcook.org' - s.files = ['MIT-LICENSE.txt'] + Dir.glob('lib/**/*.rb') + s.files = ['LICENSE'] + Dir.glob('lib/**/*.rb') ...
Fix path to licence file in gemspec
diff --git a/rgpg.gemspec b/rgpg.gemspec index abc1234..def5678 100644 --- a/rgpg.gemspec +++ b/rgpg.gemspec @@ -6,7 +6,7 @@ Gem::Specification.new do |s| s.name = 'rgpg' s.version = Rgpg::GemInfo.version_string - s.date = Date.today + s.date = Date.today rescue '1970-01-01' s.executables << 'rgpg' s.summ...
Add fallback to Unix epoch if Date.today method does not exist
diff --git a/test/features/deals/show_deal_test.rb b/test/features/deals/show_deal_test.rb index abc1234..def5678 100644 --- a/test/features/deals/show_deal_test.rb +++ b/test/features/deals/show_deal_test.rb @@ -3,7 +3,7 @@ feature "Deals::ShowADeal" do scenario "anyone can view deals" do visit root_path - ...
Change billboard message in show deal test.
diff --git a/lib/concourse2tracker-resource/scripts/concourse2tracker.rb b/lib/concourse2tracker-resource/scripts/concourse2tracker.rb index abc1234..def5678 100644 --- a/lib/concourse2tracker-resource/scripts/concourse2tracker.rb +++ b/lib/concourse2tracker-resource/scripts/concourse2tracker.rb @@ -36,7 +36,7 @@ r...
Check for more encompassing HTTPSuccess instead of 200 response code
diff --git a/spec/factory_spec.rb b/spec/factory_spec.rb index abc1234..def5678 100644 --- a/spec/factory_spec.rb +++ b/spec/factory_spec.rb @@ -24,6 +24,28 @@ end describe 'meeting' do - # + context 'basic' do + let(:meeting) { FactoryGirl.create(:meeting) } + + it 'has a date' do + ex...
Add specs for meeting factory
diff --git a/lib/android_interface.rb b/lib/android_interface.rb index abc1234..def5678 100644 --- a/lib/android_interface.rb +++ b/lib/android_interface.rb @@ -26,7 +26,7 @@ def location_coordinates result = DROID.getLastKnownLocation["result"] - data = result["gps"] || result["passive"] + data = result...
Improve robustness of location tracking.
diff --git a/app/controllers/companies_controller.rb b/app/controllers/companies_controller.rb index abc1234..def5678 100644 --- a/app/controllers/companies_controller.rb +++ b/app/controllers/companies_controller.rb @@ -1,12 +1,6 @@ class CompaniesController < ApplicationController - + before_filter :check_access ...
Check admin access in compnaies controller update action.
diff --git a/app/presenters/experiments_presenter.rb b/app/presenters/experiments_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/experiments_presenter.rb +++ b/app/presenters/experiments_presenter.rb @@ -15,9 +15,9 @@ def notification { - message: 'Would you like to opt in to our research...
Update opt-in message and link
diff --git a/app/presenters/mcas_result_presenter.rb b/app/presenters/mcas_result_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/mcas_result_presenter.rb +++ b/app/presenters/mcas_result_presenter.rb @@ -1,35 +1,21 @@ class McasResultPresenter < Struct.new(:result) + delegate :math_growth_warning?, :m...
Refactor McasResultPresenter to be way DRYer * Thanks @daguar! * Less code ++++++
diff --git a/lib/ffi-ogr/http_reader.rb b/lib/ffi-ogr/http_reader.rb index abc1234..def5678 100644 --- a/lib/ffi-ogr/http_reader.rb +++ b/lib/ffi-ogr/http_reader.rb @@ -4,6 +4,14 @@ module OGR class HttpReader + + TF_MAP = { + true => 1, + false => 0, + 1 => true, + 0 => false + } + ...
Remove temp file usage in HttpReader
diff --git a/lib/expgen/randomizer.rb b/lib/expgen/randomizer.rb index abc1234..def5678 100644 --- a/lib/expgen/randomizer.rb +++ b/lib/expgen/randomizer.rb @@ -2,16 +2,22 @@ module Randomizer extend self + def range(number) + if number == "*" + [0,5] + elsif number == "+" + [1,5] + ...
Make it a bit more random
diff --git a/spec/app_spec.rb b/spec/app_spec.rb index abc1234..def5678 100644 --- a/spec/app_spec.rb +++ b/spec/app_spec.rb @@ -36,7 +36,7 @@ Example.logger.level = Logger::ERROR @app.config[:type] = :widget - @app.perform_action + @app.run log.should include("Widgets can't perform this act...
Fix private function call in spec
diff --git a/lib/better_errors/exception_hint.rb b/lib/better_errors/exception_hint.rb index abc1234..def5678 100644 --- a/lib/better_errors/exception_hint.rb +++ b/lib/better_errors/exception_hint.rb @@ -10,7 +10,7 @@ /\Aundefined method `(?<method>[^']+)' for (?<val>[^:]+):(?<klass>\w+)/.match(exception.messa...
Fix passing regex to start_with?
diff --git a/authem.gemspec b/authem.gemspec index abc1234..def5678 100644 --- a/authem.gemspec +++ b/authem.gemspec @@ -4,18 +4,20 @@ require 'authem/version' Gem::Specification.new do |spec| - spec.name = "authem" - spec.version = Authem::VERSION - spec.authors = ["Paul Elliott", "Pavel Pra...
Add Ruby version requirement to gemspec
diff --git a/lib/laziness/api/base.rb b/lib/laziness/api/base.rb index abc1234..def5678 100644 --- a/lib/laziness/api/base.rb +++ b/lib/laziness/api/base.rb @@ -3,7 +3,7 @@ class Base attr_reader :access_token - def initialize(access_token) + def initialize(access_token=nil) @access_toke...
Make access token optional since some api calls do not have one
diff --git a/lib/mars_photos/rover.rb b/lib/mars_photos/rover.rb index abc1234..def5678 100644 --- a/lib/mars_photos/rover.rb +++ b/lib/mars_photos/rover.rb @@ -10,5 +10,17 @@ response = HTTParty.get(url) response['photos'] end + + def get_by_sol(sol) + url = MarsPhotos::Calculations.build_url...
Add get_by_sol and get_by_earth_date methods
diff --git a/lib/merb_activerecord.rb b/lib/merb_activerecord.rb index abc1234..def5678 100644 --- a/lib/merb_activerecord.rb +++ b/lib/merb_activerecord.rb @@ -1,17 +1,10 @@-if defined?(Merb::Plugins) +if defined?(Merb::Plugins) dependency "activerecord" require File.join(File.dirname(__FILE__) / "merb" / "orm...
Use simple before_app_loads hook instead of bootloader subclass.
diff --git a/test/helpers/application_helper_test.rb b/test/helpers/application_helper_test.rb index abc1234..def5678 100644 --- a/test/helpers/application_helper_test.rb +++ b/test/helpers/application_helper_test.rb @@ -12,7 +12,7 @@ # == DateTime # test 'should return current year' do - assert_equal curren...
Update params order for assert test
diff --git a/test/remote/remote_add_receiver_test.rb b/test/remote/remote_add_receiver_test.rb index abc1234..def5678 100644 --- a/test/remote/remote_add_receiver_test.rb +++ b/test/remote/remote_add_receiver_test.rb @@ -25,9 +25,9 @@ end def test_add_test_receiver - receiver = @environment.add_receiver(:test...
Change hostname because for some reason the former one was failing this remote test
diff --git a/spec/requests/gpdb_spec.rb b/spec/requests/gpdb_spec.rb index abc1234..def5678 100644 --- a/spec/requests/gpdb_spec.rb +++ b/spec/requests/gpdb_spec.rb @@ -7,7 +7,7 @@ :port => 5432, :host => "chorus-gpdb42", :maintenance_db => "postgres", - :db_username => "test", + ...
Fix db username in request spec for creating instances
diff --git a/spec/str_sanitizer_spec.rb b/spec/str_sanitizer_spec.rb index abc1234..def5678 100644 --- a/spec/str_sanitizer_spec.rb +++ b/spec/str_sanitizer_spec.rb @@ -5,30 +5,13 @@ expect(StrSanitizer::VERSION).not_to be nil end - it "has a method named 'double_quote'" do + it "can invoke the methods of Qu...
Remove specs for Quotes module in StrSanitizer class, respond_to? method will suffice
diff --git a/lib/generators/install_generator.rb b/lib/generators/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/install_generator.rb +++ b/lib/generators/install_generator.rb @@ -0,0 +1,26 @@+require 'rails/generators/base' + +module ActiveForm + module Generators + class InstallGenerator ...
Add an install generator to create a forms directory into the app and test directories and include the JS file.
diff --git a/lib/rspec_api_helpers.rb b/lib/rspec_api_helpers.rb index abc1234..def5678 100644 --- a/lib/rspec_api_helpers.rb +++ b/lib/rspec_api_helpers.rb @@ -6,4 +6,12 @@ require 'active_support/core_ext/object/json' require 'active_support/core_ext/hash' +module RspecApiHelpers + def self.included(base) + co...
Include child submodules in RspecApiHelpers
diff --git a/app/mailers/general_mailer.rb b/app/mailers/general_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/general_mailer.rb +++ b/app/mailers/general_mailer.rb @@ -0,0 +1,13 @@+class GeneralMailer < ActionMailer::Base + def email(email) + from = "#{email.from_name} <#{email.from_email}>" + to = ...
Add general mailer that sends out an email from the email model.
diff --git a/lib/regexp_parser/token.rb b/lib/regexp_parser/token.rb index abc1234..def5678 100644 --- a/lib/regexp_parser/token.rb +++ b/lib/regexp_parser/token.rb @@ -12,6 +12,12 @@ ].freeze Token = Struct.new(*TOKEN_KEYS) do + def initialize(*) + super + + @previous = @next = nil + end + ...
Remove uninitialized ivar warnings for Token
diff --git a/lib/puppet/parser/functions/lpad.rb b/lib/puppet/parser/functions/lpad.rb index abc1234..def5678 100644 --- a/lib/puppet/parser/functions/lpad.rb +++ b/lib/puppet/parser/functions/lpad.rb @@ -18,7 +18,7 @@ num = num.to_i count = count.to_i - format = "%0" + count + "d" + format = "%0#{Stri...
Fix implicit conversion of Fixnum into String
diff --git a/lib/serialize/generator.rb b/lib/serialize/generator.rb index abc1234..def5678 100644 --- a/lib/serialize/generator.rb +++ b/lib/serialize/generator.rb @@ -1,15 +1,9 @@ class Serialize class Generator - instance_methods.each do |m| - undef_method m unless m =~ /^(__|object_id)/ - end - - a...
Remove more object-proxying craziness in Generator
diff --git a/lib/tasks/resources.rake b/lib/tasks/resources.rake index abc1234..def5678 100644 --- a/lib/tasks/resources.rake +++ b/lib/tasks/resources.rake @@ -41,6 +41,8 @@ desc 'Refreshes all the resources in the database' task refresh: :environment do Resource.find_each do |resource| + puts "Refreshi...
Fix typo + print info
diff --git a/lib/voodoo/peopletools/appengine.rb b/lib/voodoo/peopletools/appengine.rb index abc1234..def5678 100644 --- a/lib/voodoo/peopletools/appengine.rb +++ b/lib/voodoo/peopletools/appengine.rb @@ -15,8 +15,24 @@ append(:env_password => target.app_password) append(:r => '1') append(:ae_name =...
Make running app engines non-blocking
diff --git a/recipes/ppa.rb b/recipes/ppa.rb index abc1234..def5678 100644 --- a/recipes/ppa.rb +++ b/recipes/ppa.rb @@ -11,6 +11,7 @@ apt_repository 'ubiquiti_unifi' do uri 'http://www.ubnt.com/downloads/unifi/debian' components %w(stable ubiquiti) + distribution nil keyserver 'keyserver.ubuntu.com' key '...
Support the new version of the apt cookbook
diff --git a/shortest_path.gemspec b/shortest_path.gemspec index abc1234..def5678 100644 --- a/shortest_path.gemspec +++ b/shortest_path.gemspec @@ -21,7 +21,6 @@ s.add_development_dependency "guard-rspec" s.add_development_dependency "rake" s.add_development_dependency "rspec" - s.add_development_dependency "...
Delete rcov gem for ruby 1.9
diff --git a/examples/select_disabled_paged.rb b/examples/select_disabled_paged.rb index abc1234..def5678 100644 --- a/examples/select_disabled_paged.rb +++ b/examples/select_disabled_paged.rb @@ -0,0 +1,22 @@+# frozen_string_literal: true + +require_relative "../lib/tty-prompt" + +prompt = TTY::Prompt.new + +numbers =...
Add example of selecting from a paged menu with disabled items
diff --git a/spec/controllers/comments_controller_spec.rb b/spec/controllers/comments_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/comments_controller_spec.rb +++ b/spec/controllers/comments_controller_spec.rb @@ -1 +1,9 @@-comments_controller_spec.rb +describe CommentsController do + let!(:...
Create first test for the comments controller
diff --git a/spec/ruby/library/stringscanner/scan_spec.rb b/spec/ruby/library/stringscanner/scan_spec.rb index abc1234..def5678 100644 --- a/spec/ruby/library/stringscanner/scan_spec.rb +++ b/spec/ruby/library/stringscanner/scan_spec.rb @@ -28,6 +28,12 @@ @s.scan(/\w+/).should be_nil end + it "returns an empt...
Add spec for matching an empty string
diff --git a/scripts/convert_to_open_stack.rb b/scripts/convert_to_open_stack.rb index abc1234..def5678 100644 --- a/scripts/convert_to_open_stack.rb +++ b/scripts/convert_to_open_stack.rb @@ -0,0 +1,13 @@+#!/bin/env ruby + +require './src/helpers/loader' + +if ARGV.size != 1 + puts 'bundle exec scripts/convert_to_ope...
Add script to convert template from aws format to openstack format
diff --git a/spec/lib/license_finder/package_managers/bundler_package_spec.rb b/spec/lib/license_finder/package_managers/bundler_package_spec.rb index abc1234..def5678 100644 --- a/spec/lib/license_finder/package_managers/bundler_package_spec.rb +++ b/spec/lib/license_finder/package_managers/bundler_package_spec.rb @@ ...
Fix issue found by travis again
diff --git a/spec/models/league_request_spec.rb b/spec/models/league_request_spec.rb index abc1234..def5678 100644 --- a/spec/models/league_request_spec.rb +++ b/spec/models/league_request_spec.rb @@ -0,0 +1,57 @@+# frozen_string_literal: true + +require 'spec_helper' + +describe LeagueRequest do + let(:user) { create...
Add a spec to explain how league search requests work
diff --git a/spec/lib/grim_spec.rb b/spec/lib/grim_spec.rb index abc1234..def5678 100644 --- a/spec/lib/grim_spec.rb +++ b/spec/lib/grim_spec.rb @@ -18,7 +18,7 @@ Grim::DENSITY.should == 300 end - describe "#new" do + describe "#reap" do it "should return an instance of Grim::Pdf" do Grim.reap(fi...
Fix describe text on spec.
diff --git a/spec/ghost/cli/task/help_spec.rb b/spec/ghost/cli/task/help_spec.rb index abc1234..def5678 100644 --- a/spec/ghost/cli/task/help_spec.rb +++ b/spec/ghost/cli/task/help_spec.rb @@ -14,6 +14,7 @@ export Export all hosts in /etc/hosts format import Import hosts in /etc/hosts forma...
Add set output to help test
diff --git a/tara.gemspec b/tara.gemspec index abc1234..def5678 100644 --- a/tara.gemspec +++ b/tara.gemspec @@ -19,4 +19,5 @@ s.bindir = 'bin' s.executables = %w[tara] s.require_paths = %w[lib] + s.required_ruby_version = '>= 2.1.5' end
Set required Ruby version in gemspec
diff --git a/lib/twurl.rb b/lib/twurl.rb index abc1234..def5678 100644 --- a/lib/twurl.rb +++ b/lib/twurl.rb @@ -3,6 +3,7 @@ require 'optparse' require 'ostruct' require 'stringio' +require 'yaml' library_files = Dir[File.join(File.dirname(__FILE__), "/twurl/**/*.rb")] library_files.each do |file|
Add explicit require for yaml library.
diff --git a/config/initializers/s3_direct_upload.rb b/config/initializers/s3_direct_upload.rb index abc1234..def5678 100644 --- a/config/initializers/s3_direct_upload.rb +++ b/config/initializers/s3_direct_upload.rb @@ -1,7 +1,7 @@ S3DirectUpload.config do |c| c.access_key_id = ENV['AWS_ACCESS_KEY'] c.secret_acc...
Fix typo on S3 Direct Upload configuration An unecessary comma caused an Invalid Policy error while trying to upload files do Amazon S3.
diff --git a/bzip2-ffi.gemspec b/bzip2-ffi.gemspec index abc1234..def5678 100644 --- a/bzip2-ffi.gemspec +++ b/bzip2-ffi.gemspec @@ -18,8 +18,9 @@ Dir['test/fixtures/*'] s.platform = Gem::Platform::RUBY s.require_path = 'lib' - s.rdoc_options << '--title' << 'Bzip2::FFI' - s.extra_rdoc_files = ['LIC...
Add CHANGES.md and README.md to RDoc.
diff --git a/spec/controllers/admin/base_controller_spec.rb b/spec/controllers/admin/base_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/admin/base_controller_spec.rb +++ b/spec/controllers/admin/base_controller_spec.rb @@ -10,7 +10,7 @@ let(:account) { create :account } before do - c...
Fix RSpec deprecation by removing stub
diff --git a/spec/hg/workers/worker_spec_shared_examples.rb b/spec/hg/workers/worker_spec_shared_examples.rb index abc1234..def5678 100644 --- a/spec/hg/workers/worker_spec_shared_examples.rb +++ b/spec/hg/workers/worker_spec_shared_examples.rb @@ -1,7 +1,11 @@ RSpec.shared_examples 'a message processing worker' do + ...
Add it block to spec to separate expects
diff --git a/inch_ci-worker.gemspec b/inch_ci-worker.gemspec index abc1234..def5678 100644 --- a/inch_ci-worker.gemspec +++ b/inch_ci-worker.gemspec @@ -23,6 +23,6 @@ spec.add_development_dependency "simplecov" spec.add_development_dependency "pry" - spec.add_dependency "inch", "0.5.0.rc8" + spec.add_dependenc...
Upgrade inch and bump version
diff --git a/pages/config/routes.rb b/pages/config/routes.rb index abc1234..def5678 100644 --- a/pages/config/routes.rb +++ b/pages/config/routes.rb @@ -6,7 +6,7 @@ namespace :admin, :path => Refinery::Core.backend_route do scope :path => :pages do post 'preview', :to => 'preview#show', :as => :prev...
Use PATCH HTTP method because Rails 4 now uses that by default over PUT.
diff --git a/0_code_wars/find_duplicated_number.rb b/0_code_wars/find_duplicated_number.rb index abc1234..def5678 100644 --- a/0_code_wars/find_duplicated_number.rb +++ b/0_code_wars/find_duplicated_number.rb @@ -0,0 +1,5 @@+# http://www.codewars.com/kata/558dd9a1b3f79dc88e000001/ +# --- iteration 1 --- +def find_dup(a...
Add code wars (7) - find duplicated number
diff --git a/Methods/accessModifiers.rb b/Methods/accessModifiers.rb index abc1234..def5678 100644 --- a/Methods/accessModifiers.rb +++ b/Methods/accessModifiers.rb @@ -0,0 +1,38 @@+# Access modifiers in Ruby + +class MyClass + + private # access modifier + def priv + puts("private") + end + + protected + ...
Access modifiers - protected method is an important example in ruby
diff --git a/test/test_abi.rb b/test/test_abi.rb index abc1234..def5678 100644 --- a/test/test_abi.rb +++ b/test/test_abi.rb @@ -0,0 +1,108 @@+require 'helper' + +module RCPU + class TestABI < TestCase + def test_call + rcpu do + block :main do + call :_library, 1, 2, 3, 4, 5 + data :d...
Add tests for the calling conventions
diff --git a/spec/controllers/delay_controller_spec.rb b/spec/controllers/delay_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/delay_controller_spec.rb +++ b/spec/controllers/delay_controller_spec.rb @@ -0,0 +1,71 @@+require 'spec_helper' + +describe Slowwly::DelayController do + context 'with...
Add spec for delay controller get request; cant really test the delay atm; and need to implement some
diff --git a/spec/controllers/users_controller_spec.rb b/spec/controllers/users_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/users_controller_spec.rb +++ b/spec/controllers/users_controller_spec.rb @@ -0,0 +1,62 @@+require 'spec_helper' + +describe UsersController do + let(:user) { FactoryGi...
Add Users Controller Spec for Profile Add a Users controller spec to account for editing/viewing the Users' profile pages.
diff --git a/conoha.gemspec b/conoha.gemspec index abc1234..def5678 100644 --- a/conoha.gemspec +++ b/conoha.gemspec @@ -14,14 +14,6 @@ spec.homepage = "https://github.com/kaosf/conoha" spec.license = "MIT" - # Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or - # delete th...
Remove the code to prevent pushing to a public server
diff --git a/test/integration/sign_in_test.rb b/test/integration/sign_in_test.rb index abc1234..def5678 100644 --- a/test/integration/sign_in_test.rb +++ b/test/integration/sign_in_test.rb @@ -4,14 +4,7 @@ Warden.test_mode! class SignInTest < ActionDispatch::IntegrationTest - - def setup - @user = users(:lee) + ...
Revert "Add basic Capybara tests for log in" This reverts commit 637e272204b80850238c64bc8042a8bc66c155d2. Conflicts: test/features/sign_in_sign_out_test.rb
diff --git a/features/support/webmock.rb b/features/support/webmock.rb index abc1234..def5678 100644 --- a/features/support/webmock.rb +++ b/features/support/webmock.rb @@ -8,6 +8,4 @@ # Mock out all publisher URLs stub_request(:get, %r{^#{Regexp.escape Plek.current.find('publisher')}/}).to_return(status: 200) -...
Stop stubbing an imminence data set URL in all tests Removing the stub doesn't seem to cause a problem and it looks like this stub hasn't been needed since 2011 (see: b3e0c8aefa2cb3b6c85d67c384f31dcb746ff268).
diff --git a/test/smoke/source/source_test.rb b/test/smoke/source/source_test.rb index abc1234..def5678 100644 --- a/test/smoke/source/source_test.rb +++ b/test/smoke/source/source_test.rb @@ -1,3 +1,7 @@-describe processes('exabgp') do +describe directory('/usr/src/exabgp') do it { should exist } end + +describe f...
Change from process to file/dir check
diff --git a/db/migrate/20200323181726_add_publish_last_version_automatically_column_to_plans.rb b/db/migrate/20200323181726_add_publish_last_version_automatically_column_to_plans.rb index abc1234..def5678 100644 --- a/db/migrate/20200323181726_add_publish_last_version_automatically_column_to_plans.rb +++ b/db/migrate/...
Add publish_last_version_automatically column to plans
diff --git a/test/unit/recipes/resolv_spec.rb b/test/unit/recipes/resolv_spec.rb index abc1234..def5678 100644 --- a/test/unit/recipes/resolv_spec.rb +++ b/test/unit/recipes/resolv_spec.rb @@ -0,0 +1,62 @@+describe 'sys::resolv' do + + before do + stub_command("test -L /etc/resolv.conf").and_return(false) + end + ...
Add unit tests for resolv recipe
diff --git a/lib/atlas/scaler/graph_scaler.rb b/lib/atlas/scaler/graph_scaler.rb index abc1234..def5678 100644 --- a/lib/atlas/scaler/graph_scaler.rb +++ b/lib/atlas/scaler/graph_scaler.rb @@ -7,8 +7,10 @@ NODE_ATTRIBUTES = [ :demand, :max_demand, - :typical_input_capacity, - :electricity_ou...
Disable scaling of typical_input_capacity and electricity_output_capacity
diff --git a/omnibus-software.gemspec b/omnibus-software.gemspec index abc1234..def5678 100644 --- a/omnibus-software.gemspec +++ b/omnibus-software.gemspec @@ -1,4 +1,3 @@-# -*- encoding: utf-8 -*- $:.push File.expand_path("../lib", __FILE__) require "omnibus-software/version"
Remove the redundant encoding comment The encoding is utf-8 in Ruby 2+ Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/recipes/configure.rb b/recipes/configure.rb index abc1234..def5678 100644 --- a/recipes/configure.rb +++ b/recipes/configure.rb @@ -22,7 +22,15 @@ template '/etc/gitlab/gitlab.rb' do variables( - external_url: node['gitlab-omnibus']['external_url'] + external_url: node['gitlab-omnibus']['externa...
Add more variables to template resource for gitlab.rb.
diff --git a/config/initializers/assets.rb b/config/initializers/assets.rb index abc1234..def5678 100644 --- a/config/initializers/assets.rb +++ b/config/initializers/assets.rb @@ -15,5 +15,6 @@ publify_admin.css accounts.css bootstrap.css + user-styles.css coderay.css )
Add precompiling of user-styles.css again.
diff --git a/tests/browser_based/run_tests.rb b/tests/browser_based/run_tests.rb index abc1234..def5678 100644 --- a/tests/browser_based/run_tests.rb +++ b/tests/browser_based/run_tests.rb @@ -3,11 +3,16 @@ # make it possible to load the test cases from the local directory $:.unshift File.dirname(__FILE__) +# FIXME ...
Add in Watir tests to the test runner
diff --git a/lib/brightbox-cli/config/cache.rb b/lib/brightbox-cli/config/cache.rb index abc1234..def5678 100644 --- a/lib/brightbox-cli/config/cache.rb +++ b/lib/brightbox-cli/config/cache.rb @@ -2,21 +2,17 @@ module Config module Cache def cache_path - if @cache_path - @cache_path - ...
Fix caching attempts when directory missing Running specs in a random order could trigger a number of failures related to naughty API classes attempting to cache IDs whilst the directory used did not exist. This alters the `#cache_path` method to be read only without side effect and creates it when `#cache_id` is ca...
diff --git a/lib/clamp/subcommand/execution.rb b/lib/clamp/subcommand/execution.rb index abc1234..def5678 100644 --- a/lib/clamp/subcommand/execution.rb +++ b/lib/clamp/subcommand/execution.rb @@ -10,7 +10,7 @@ subcommand_class = find_subcommand_class(subcommand_name) subcommand = subcommand_class.new(...
Fix check for presence of explicitly set option.
diff --git a/lib/finite_machine/async_call.rb b/lib/finite_machine/async_call.rb index abc1234..def5678 100644 --- a/lib/finite_machine/async_call.rb +++ b/lib/finite_machine/async_call.rb @@ -1,14 +1,13 @@ # encoding: utf-8 module FiniteMachine - # An asynchronouse call representation + # An immutable asynchronou...
Remove async call thread syncing.
diff --git a/lib/docs/scrapers/react_native.rb b/lib/docs/scrapers/react_native.rb index abc1234..def5678 100644 --- a/lib/docs/scrapers/react_native.rb +++ b/lib/docs/scrapers/react_native.rb @@ -3,7 +3,7 @@ self.name = 'React Native' self.slug = 'react_native' self.type = 'react' - self.release = '0....
Update React Native documentation (0.41)
diff --git a/core/process/euid_spec.rb b/core/process/euid_spec.rb index abc1234..def5678 100644 --- a/core/process/euid_spec.rb +++ b/core/process/euid_spec.rb @@ -33,25 +33,12 @@ as_superuser do describe "if run by a superuser" do - with_feature :fork do - it "sets the effective user id f...
Rewrite Process.euid= spec without fork
diff --git a/lib/knapsack/allocator_builder.rb b/lib/knapsack/allocator_builder.rb index abc1234..def5678 100644 --- a/lib/knapsack/allocator_builder.rb +++ b/lib/knapsack/allocator_builder.rb @@ -8,9 +8,9 @@ def allocator Knapsack::Allocator.new({ report: Knapsack.report.open, + spec_pattern...
Change args order in allocator builder
diff --git a/CCKit.podspec b/CCKit.podspec index abc1234..def5678 100644 --- a/CCKit.podspec +++ b/CCKit.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "CCKit" - s.version = "0.0.2" + s.version = "0.0.3" s.summary = "Cliq Consulting reusable components for iOS." s.description ...
Update Podspec to version 0.0.3
diff --git a/config/unicorn.rb b/config/unicorn.rb index abc1234..def5678 100644 --- a/config/unicorn.rb +++ b/config/unicorn.rb @@ -1,5 +1,5 @@ preload_app true -worker_count 2 +worker_processes 2 timeout 30 check_client_connection true
Use correct Unicorn config method
diff --git a/lib/badbill/invoice_payment.rb b/lib/badbill/invoice_payment.rb index abc1234..def5678 100644 --- a/lib/badbill/invoice_payment.rb +++ b/lib/badbill/invoice_payment.rb @@ -5,5 +5,24 @@ # # See http://www.billomat.com/en/api/invoices/payments/ class InvoicePayment < BaseResource + # Create a new ...
Create invoice payments (to set an invoice's status to paid)
diff --git a/lib/algoliasearch/utilities.rb b/lib/algoliasearch/utilities.rb index abc1234..def5678 100644 --- a/lib/algoliasearch/utilities.rb +++ b/lib/algoliasearch/utilities.rb @@ -2,9 +2,8 @@ module Utilities class << self def get_model_classes - Rails.application.eager_load! # Ensure all mode...
Make sure get_model_classes is not ActiveRecord compliant only
diff --git a/lib/chatrix/event_processor.rb b/lib/chatrix/event_processor.rb index abc1234..def5678 100644 --- a/lib/chatrix/event_processor.rb +++ b/lib/chatrix/event_processor.rb @@ -16,15 +16,10 @@ private def parse_event(event) - case event - when String + if event.is_a? String ev...
Simplify code in event processor
diff --git a/lib/torque_box/sidekiq_service.rb b/lib/torque_box/sidekiq_service.rb index abc1234..def5678 100644 --- a/lib/torque_box/sidekiq_service.rb +++ b/lib/torque_box/sidekiq_service.rb @@ -1,6 +1,6 @@ module TorqueBox class SidekiqService - attr_accessor :config, :launcher + attr_accessor :config, :lau...
Handle errors during startup better and fixed a race condition with :stop being called before the Sidekiq launcher finishes booting.
diff --git a/lib/tasks/default_admin_set.rake b/lib/tasks/default_admin_set.rake index abc1234..def5678 100644 --- a/lib/tasks/default_admin_set.rake +++ b/lib/tasks/default_admin_set.rake @@ -2,7 +2,7 @@ namespace :default_admin_set do desc "Create the Default Admin Set" task create: :environment do - ...
Update default admin set creation call in rake job
diff --git a/scopy.gemspec b/scopy.gemspec index abc1234..def5678 100644 --- a/scopy.gemspec +++ b/scopy.gemspec @@ -24,7 +24,6 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake", "~> 10.1" - spec.add_development_dependency "minitest", "~> 4.7" spec.add_development_...
Remove explicit dependency on minitest
diff --git a/db/data_migrations/20190820181152_add_organization_role_mapping_for_super_manager.rb b/db/data_migrations/20190820181152_add_organization_role_mapping_for_super_manager.rb index abc1234..def5678 100644 --- a/db/data_migrations/20190820181152_add_organization_role_mapping_for_super_manager.rb +++ b/db/data_...
[TTPLAT-1044] Add organization role mapping for grantors to super manager role.
diff --git a/overheard.rb b/overheard.rb index abc1234..def5678 100644 --- a/overheard.rb +++ b/overheard.rb @@ -5,7 +5,7 @@ include DataMapper::Resource property :id, Serial - property :body, Text + property :body, Text, { :required => true } property :created_at, DateTime end @@ -23,5 +23,9 @@ post '...
Add validation that Overheard must have a body Here we're doing two things: 1. We're creating a validation that will prevent an overheard from being created if a body isn't provided 2. We're only redirecting if the creation was successful; otherwise we re-render the new overheard form
diff --git a/lib/filepicker/rails/policy.rb b/lib/filepicker/rails/policy.rb index abc1234..def5678 100644 --- a/lib/filepicker/rails/policy.rb +++ b/lib/filepicker/rails/policy.rb @@ -5,6 +5,12 @@ module Rails class Policy attr_accessor :expiry, :call, :handle, :maxsize, :minsize + + def initialize(...
Add initializer to Policy class
diff --git a/lib/graphql/execution_error.rb b/lib/graphql/execution_error.rb index abc1234..def5678 100644 --- a/lib/graphql/execution_error.rb +++ b/lib/graphql/execution_error.rb @@ -11,6 +11,9 @@ hash = { "message" => message, } + + hash.merge!({ 'backtrace' => backtrace }) if self.class.b...
Add ability to dump backtrace.
diff --git a/sidekiq/recipes/default.rb b/sidekiq/recipes/default.rb index abc1234..def5678 100644 --- a/sidekiq/recipes/default.rb +++ b/sidekiq/recipes/default.rb @@ -6,7 +6,7 @@ node[:deploy].each do |application, deploy| process_name = "sidekiq_#{application}" - template "/etc/monit/#{process_name}.monitrc" d...
Put monitrc files in proper folder
diff --git a/lib/generators/templates/app/initializers/link_renderer.rb b/lib/generators/templates/app/initializers/link_renderer.rb index abc1234..def5678 100644 --- a/lib/generators/templates/app/initializers/link_renderer.rb +++ b/lib/generators/templates/app/initializers/link_renderer.rb @@ -0,0 +1,51 @@+module Wil...
Patch to render willpaginate with Twitter Bootstrap
diff --git a/app/Screens/AboutScreen.rb b/app/Screens/AboutScreen.rb index abc1234..def5678 100644 --- a/app/Screens/AboutScreen.rb +++ b/app/Screens/AboutScreen.rb @@ -9,7 +9,26 @@ def will_appear @view_loaded ||= begin set_nav_bar_right_button "Done", action: :close_modal, type: UIBarButtonItemStyleDone...
Add a "made in" label to the about view.
diff --git a/db/data_migration/20150311142732_add_missing_content_id_for_organisation.rb b/db/data_migration/20150311142732_add_missing_content_id_for_organisation.rb index abc1234..def5678 100644 --- a/db/data_migration/20150311142732_add_missing_content_id_for_organisation.rb +++ b/db/data_migration/20150311142732_ad...
Set missing content ids for organisations The previous data migration skipped over any organisations that failed validation. This meant that at least one (FCO Services) was left without a content_id as it failed validation due to not having an alternative format provider email address.
diff --git a/spec/hadoop/hbase_spec.rb b/spec/hadoop/hbase_spec.rb index abc1234..def5678 100644 --- a/spec/hadoop/hbase_spec.rb +++ b/spec/hadoop/hbase_spec.rb @@ -5,7 +5,7 @@ it { should return_exit_status 0 } end -# Make sure hbase stops without error as well -describe command('stop-hbase.sh') do +# Make sure J...
Fix hbase test, makes sure to kill off java when done so test is repeatable
diff --git a/spec/locale_spec.rb b/spec/locale_spec.rb index abc1234..def5678 100644 --- a/spec/locale_spec.rb +++ b/spec/locale_spec.rb @@ -10,9 +10,9 @@ describe :model_comments do let(:result) do { + 'person' => '人', 'address' => '住所', 'email' => 'メール', - 'person' =>...
Change the order of models
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -11,14 +11,6 @@ add_group "Relation", "lib/data_mapper/relation" add_group "Relationship", "lib/data_mapper/relationship" add_group "Engine", "lib/data_mapp...
Remove duplicate OpenStruct monkey patch for specs
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -16,7 +16,8 @@ #TMP_DIR = SpecHelper::TemporaryDirectory.temporary_directory #TMP_COCOA_PODS_DIR = File.join(TMP_DIR, 'cocoa-pods') -class Bacon::Context +context_class = define...
Make the specs work with ObjectiveBacon as well.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -14,18 +14,8 @@ # class HashObject def self.new(hash) - build_class(hash.keys).new(hash) - end - - def self.build_class(attributes) - Class.new do - attr_accessor(...
Use Struct as backend for HashObject.
diff --git a/spec/topicz_spec.rb b/spec/topicz_spec.rb index abc1234..def5678 100644 --- a/spec/topicz_spec.rb +++ b/spec/topicz_spec.rb @@ -21,8 +21,14 @@ expect(Topicz.create_command(['foo'])).to be nil end - it 'returns a command when a valid command is specificied' do - expect(Topicz.create_command(['i...
Use dummy command factory in topicz spec.
diff --git a/lib/registrar/adapter/rails.rb b/lib/registrar/adapter/rails.rb index abc1234..def5678 100644 --- a/lib/registrar/adapter/rails.rb +++ b/lib/registrar/adapter/rails.rb @@ -7,6 +7,19 @@ def self.included(klass) klass.include InstanceMethods klass.before_action :try_to_store_registrar...
Add additional helper methods to Rails Adapter
diff --git a/app/models/edition_diff.rb b/app/models/edition_diff.rb index abc1234..def5678 100644 --- a/app/models/edition_diff.rb +++ b/app/models/edition_diff.rb @@ -1,5 +1,5 @@ class EditionDiff - TRACKABLE_FIELDS = [:title, :related_discussion_title, :related_discussion_href, :content_owner_title, :description, :...
Remove related discussion fields from diffs These are no longer used and are planned to be removed completely.
diff --git a/spec/valanga/music_spec.rb b/spec/valanga/music_spec.rb index abc1234..def5678 100644 --- a/spec/valanga/music_spec.rb +++ b/spec/valanga/music_spec.rb @@ -22,6 +22,12 @@ it do expect do @music.list_musics(sorttype: :music_name) + end.not_to raise_error + end + + ...
Add spec the case of valid parameter
diff --git a/lib/watir-webdriver/cookies.rb b/lib/watir-webdriver/cookies.rb index abc1234..def5678 100644 --- a/lib/watir-webdriver/cookies.rb +++ b/lib/watir-webdriver/cookies.rb @@ -32,7 +32,7 @@ if t.respond_to?(:to_time) t.to_time else - Time.local t.year, t.month, t.day, t.hour, t.min...
Fix incorrect constant reference on Ruby 1.8. Closes #132.