diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/Formula/alac.rb b/Formula/alac.rb index abc1234..def5678 100644 --- a/Formula/alac.rb +++ b/Formula/alac.rb @@ -0,0 +1,12 @@+require 'formula' + +class Alac < Formula + homepage 'http://craz.net/programs/itunes/alac.html' + url 'http://craz.net/programs/itunes/files/alac_decoder-0.2.0.tgz' + md5 'cec75c...
Add the Apple Lossless Audio Codec decoder formula. Add a formula for the alac binary from http://craz.net/programs/itunes/alac.html. Closes Homebrew/homebrew#13017. Signed-off-by: Max Howell <mxcl@me.com> Renamed alac.
diff --git a/spec/models/post_spec.rb b/spec/models/post_spec.rb index abc1234..def5678 100644 --- a/spec/models/post_spec.rb +++ b/spec/models/post_spec.rb @@ -1,4 +1,13 @@ require 'rails_helper' describe Post do + describe "creating a post" do + context "after_save" do + let(:post) { create(:post, content...
Add spec for ensuring posts have a word_count after saving.
diff --git a/clockwork.gemspec b/clockwork.gemspec index abc1234..def5678 100644 --- a/clockwork.gemspec +++ b/clockwork.gemspec @@ -17,7 +17,7 @@ s.require_paths = ["lib"] s.add_dependency(%q<tzinfo>, ["~> 0.3.35"]) - s.add_dependency(%q<activesupport>, ["~> 4.0.0"]) + s.add_dependency(%q<activesupport>) ...
Remove activesupport version specification to work with any Rails version This does not mean we ensure clockwork works correctly with any version of activesupport. Support for old version is best effort.
diff --git a/rb/lib/selenium/webdriver/firefox/bridge.rb b/rb/lib/selenium/webdriver/firefox/bridge.rb index abc1234..def5678 100644 --- a/rb/lib/selenium/webdriver/firefox/bridge.rb +++ b/rb/lib/selenium/webdriver/firefox/bridge.rb @@ -41,9 +41,9 @@ def quit super + nil + ensure ...
JariBakken: Make sure Firefox shutdown happens even if the RPC fails. git-svn-id: 4179480af2c2519a5eb5e1e9b541cbdf5cf27696@16693 07704840-8298-11de-bf8c-fd130f914ac9
diff --git a/libraries/rbac.rb b/libraries/rbac.rb index abc1234..def5678 100644 --- a/libraries/rbac.rb +++ b/libraries/rbac.rb @@ -1,3 +1,8 @@+# This module is used to retain state during the course of a chef +# run. The LWRPs in the cookbook modify a global hash in this module, +# and at the end of the chef run if u...
Add comment around top-level RBAC module
diff --git a/parsley_simple_form.gemspec b/parsley_simple_form.gemspec index abc1234..def5678 100644 --- a/parsley_simple_form.gemspec +++ b/parsley_simple_form.gemspec @@ -19,7 +19,7 @@ spec.require_paths = ["lib"] spec.add_dependency("simple_form") - # spec.add_dependency("parsley-rails") + spec.add_dependen...
Add parsley-rails from gem spec
diff --git a/lib/configuration/yaml.rb b/lib/configuration/yaml.rb index abc1234..def5678 100644 --- a/lib/configuration/yaml.rb +++ b/lib/configuration/yaml.rb @@ -19,23 +19,29 @@ segments = [] @configuration[section]['segments'].each do |segment_config| - segment_style = generate_style(segment_config[...
Move the segment generation in another method
diff --git a/luban-cli.gemspec b/luban-cli.gemspec index abc1234..def5678 100644 --- a/luban-cli.gemspec +++ b/luban-cli.gemspec @@ -13,9 +13,9 @@ spec.homepage = "https://github.com/lubanrb/cli" spec.license = "MIT" - spec.files = `git ls-files`.split($/) + spec.files = `git ls-file...
Exclude examples and spec from the gem itself
diff --git a/lib/faker/default/team.rb b/lib/faker/default/team.rb index abc1234..def5678 100644 --- a/lib/faker/default/team.rb +++ b/lib/faker/default/team.rb @@ -5,22 +5,67 @@ flexible :team class << self + ## + # Produces a team name from a state and a creature. + # + # @return [Strin...
Add YARD docs for Faker::Team
diff --git a/lib/fluent/plugin/fifo.rb b/lib/fluent/plugin/fifo.rb index abc1234..def5678 100644 --- a/lib/fluent/plugin/fifo.rb +++ b/lib/fluent/plugin/fifo.rb @@ -3,7 +3,9 @@ class Fifo include Forwardable - + + READ_TIMEOUT = 1 + class Pipe < ::File alias :orig_write :write def write(*args) @@ -...
Use class variable for timeout of IO.select
diff --git a/core/db/migrate/20161017102621_create_spree_promotion_code_batch.rb b/core/db/migrate/20161017102621_create_spree_promotion_code_batch.rb index abc1234..def5678 100644 --- a/core/db/migrate/20161017102621_create_spree_promotion_code_batch.rb +++ b/core/db/migrate/20161017102621_create_spree_promotion_code_...
Add indexes from promotion code batch
diff --git a/FootlessParser.podspec b/FootlessParser.podspec index abc1234..def5678 100644 --- a/FootlessParser.podspec +++ b/FootlessParser.podspec @@ -1,13 +1,12 @@ Pod::Spec.new do |s| - s.name = "FootlessParser" - s.version = "1.0" - s.summary = "A simple parser combinator written in Swift" - ...
Use Ruby 2.0 syntax in pod spec and replace tag with branch
diff --git a/lib/dimples/plugin.rb b/lib/dimples/plugin.rb index abc1234..def5678 100644 --- a/lib/dimples/plugin.rb +++ b/lib/dimples/plugin.rb @@ -4,8 +4,10 @@ # A Ruby class that can receive events from Dimples as a site is processed. class Plugin EVENTS = %i[ - before_site_generation - after_sit...
Add file scanning and publishing events, kill the site generation event
diff --git a/lib/ar_transaction_changes.rb b/lib/ar_transaction_changes.rb index abc1234..def5678 100644 --- a/lib/ar_transaction_changes.rb +++ b/lib/ar_transaction_changes.rb @@ -1,39 +1,16 @@ require "ar_transaction_changes/version" module ArTransactionChanges - # rails 4.0.0: renamed create/update to create_rec...
Use the more stable run_callbacks API method for forward compatiblity.
diff --git a/lib/chimpdoc/dropbox_setup.rb b/lib/chimpdoc/dropbox_setup.rb index abc1234..def5678 100644 --- a/lib/chimpdoc/dropbox_setup.rb +++ b/lib/chimpdoc/dropbox_setup.rb @@ -44,6 +44,11 @@ end end + def prompt_for_authorisation(session) + puts "Please visit #{session.get_authorize_url} and hit 'Allo...
Improve readability by moving some methods around.
diff --git a/features/step_definitions/image_steps.rb b/features/step_definitions/image_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/image_steps.rb +++ b/features/step_definitions/image_steps.rb @@ -1,7 +1,9 @@ When(/^I select an image for the (?:detailed guide|publication)$/) do within ".i...
Fix selenium error for forcing click on input type=file There is a JS event handler on the input field that needs a click event, this needs to be done synthetically as chromedriver no longer allows clicking a file input (oddly).
diff --git a/test/features/anonymous_user_cant_view_agreements_test.rb b/test/features/anonymous_user_cant_view_agreements_test.rb index abc1234..def5678 100644 --- a/test/features/anonymous_user_cant_view_agreements_test.rb +++ b/test/features/anonymous_user_cant_view_agreements_test.rb @@ -0,0 +1,58 @@+require "test_...
Add test for secure agreements to anonimous users
diff --git a/modules/auxiliary/scanner/http/wp_font_file_read.rb b/modules/auxiliary/scanner/http/wp_font_file_read.rb index abc1234..def5678 100644 --- a/modules/auxiliary/scanner/http/wp_font_file_read.rb +++ b/modules/auxiliary/scanner/http/wp_font_file_read.rb @@ -0,0 +1,94 @@+## +# This module requires Metasploit:...
Add WP Font File Read Vulnerability Module
diff --git a/Library/Formula/tor.rb b/Library/Formula/tor.rb index abc1234..def5678 100644 --- a/Library/Formula/tor.rb +++ b/Library/Formula/tor.rb @@ -8,7 +8,7 @@ depends_on 'libevent' def patches - {:p0 => 'http://gist.github.com/raw/344132/d27d1cd3042d7c58120688d79ed25a2fc959a2de/config.guess-x86_64patch....
Use https for all GitHub URLs Signed-off-by: Adam Vandenberg <34c2b6407fd5a10249a15d699d40f9ed1782e98c@gmail.com>
diff --git a/lib/github_api/browser.rb b/lib/github_api/browser.rb index abc1234..def5678 100644 --- a/lib/github_api/browser.rb +++ b/lib/github_api/browser.rb @@ -1,4 +1,3 @@-require 'singleton' module GitHub class Browser include Singleton @@ -8,10 +7,12 @@ end def self.get(uri) + puts "...
Add diagnostic messages to Browser.
diff --git a/test/vagrant-spec/configs/vagrant-spec.config.virtualbox.rb b/test/vagrant-spec/configs/vagrant-spec.config.virtualbox.rb index abc1234..def5678 100644 --- a/test/vagrant-spec/configs/vagrant-spec.config.virtualbox.rb +++ b/test/vagrant-spec/configs/vagrant-spec.config.virtualbox.rb @@ -3,7 +3,8 @@ Vagrant...
Extend assert retries to allow for slow setup
diff --git a/lib/inpost/html_helper.rb b/lib/inpost/html_helper.rb index abc1234..def5678 100644 --- a/lib/inpost/html_helper.rb +++ b/lib/inpost/html_helper.rb @@ -0,0 +1,32 @@+module Inpost + module HtmlHelper + + EDITABLE_ATTRIBUTES = %i(id class) + + class << self + def machine_select_tag(collection: []...
Add machines converter to html select tag
diff --git a/lib/fastlane/actions/slack.rb b/lib/fastlane/actions/slack.rb index abc1234..def5678 100644 --- a/lib/fastlane/actions/slack.rb +++ b/lib/fastlane/actions/slack.rb @@ -25,7 +25,8 @@ notifier = Slack::Notifier.new url notifier.username = 'fastlane' - notifier.channel = "##{options[...
Allow to send direct messages to a specific user (using @nickname)
diff --git a/lib/guard/shotgun/notifier.rb b/lib/guard/shotgun/notifier.rb index abc1234..def5678 100644 --- a/lib/guard/shotgun/notifier.rb +++ b/lib/guard/shotgun/notifier.rb @@ -1,6 +1,16 @@ module Guard - class Shotgun + class Shotgun < Plugin class Notifier + + def self.notify(result) + message ...
Fix Notifier to new ::Guard::Notifier interface
diff --git a/lib/lokka/models/field.rb b/lib/lokka/models/field.rb index abc1234..def5678 100644 --- a/lib/lokka/models/field.rb +++ b/lib/lokka/models/field.rb @@ -10,4 +10,10 @@ belongs_to :field_name belongs_to :entry -end+ + %i|to_a to_ary|.each do |name| + define_method name do + # noop + end + ...
Define to_a and to_ary to suppress meaningless query
diff --git a/lib/metamorpher/refactorer.rb b/lib/metamorpher/refactorer.rb index abc1234..def5678 100644 --- a/lib/metamorpher/refactorer.rb +++ b/lib/metamorpher/refactorer.rb @@ -10,6 +10,20 @@ literal = driver.parse(src) replacements = reduce_to_replacements(literal) Merger.new(src).merge(*replac...
Add support for refactoring code contained in files.
diff --git a/Casks/steelseries-engine.rb b/Casks/steelseries-engine.rb index abc1234..def5678 100644 --- a/Casks/steelseries-engine.rb +++ b/Casks/steelseries-engine.rb @@ -2,6 +2,7 @@ version '3.7.1' sha256 '0f50666e3a97c81f2c3b3825d1d7d8fa7ec0d458b12aee4968dd5442af648c0c' + # steelseriescdn.com was verified a...
Fix `url` stanza comment for SteelSeries Engine 3.
diff --git a/app/controllers/admin/base_controller.rb b/app/controllers/admin/base_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/base_controller.rb +++ b/app/controllers/admin/base_controller.rb @@ -3,6 +3,10 @@ layout "admin" + # Clear out any root crumbs from ApplicationController (th...
Fix unwanted root breadcrumbs in the admin.
diff --git a/app/controllers/syllabuses_controller.rb b/app/controllers/syllabuses_controller.rb index abc1234..def5678 100644 --- a/app/controllers/syllabuses_controller.rb +++ b/app/controllers/syllabuses_controller.rb @@ -18,6 +18,7 @@ # Creates syllabus handler def create @syllabus ||= @classroom.build_sy...
Add the user to syllabus upon creation.
diff --git a/app/helpers/localised_url_path_helper.rb b/app/helpers/localised_url_path_helper.rb index abc1234..def5678 100644 --- a/app/helpers/localised_url_path_helper.rb +++ b/app/helpers/localised_url_path_helper.rb @@ -1,12 +1,14 @@ module LocalisedUrlPathHelper - routes = Rails.application.routes.routes - loca...
Fix a problem with Module method inclusion Previously if the module was re-included its methods were not being re-defined. This caused strange behaviour in tests and resulted in failures in Admin::AdminGovspeakHelperTest. I’m not entirely sure why we need this.
diff --git a/app/helpers/overlapped_buttons_helper.rb b/app/helpers/overlapped_buttons_helper.rb index abc1234..def5678 100644 --- a/app/helpers/overlapped_buttons_helper.rb +++ b/app/helpers/overlapped_buttons_helper.rb @@ -3,8 +3,8 @@ overlapped_button_icon :fullscreen, :expand end - def restart_icon - o...
Fix wrong tooltip placement on guide reset icon
diff --git a/app/helpers/spree/admin/slides_helper.rb b/app/helpers/spree/admin/slides_helper.rb index abc1234..def5678 100644 --- a/app/helpers/spree/admin/slides_helper.rb +++ b/app/helpers/spree/admin/slides_helper.rb @@ -4,6 +4,8 @@ def get_column_header_by_type(type) return Spree.t(:name) if type ==...
Return string when type does not match for column header
diff --git a/app/services/entry/save_entry_service.rb b/app/services/entry/save_entry_service.rb index abc1234..def5678 100644 --- a/app/services/entry/save_entry_service.rb +++ b/app/services/entry/save_entry_service.rb @@ -14,7 +14,7 @@ entries_array.each(&:save) end - return valid_entries + ...
Update return on save antry service
diff --git a/NSData+TDTImageMIMEDetection.podspec b/NSData+TDTImageMIMEDetection.podspec index abc1234..def5678 100644 --- a/NSData+TDTImageMIMEDetection.podspec +++ b/NSData+TDTImageMIMEDetection.podspec @@ -5,7 +5,7 @@ s.homepage = "https://github.com/talk-to/NSData-ImageMIMEDetection" s.license ...
Use double quotes in podspec
diff --git a/Library/Formula/readline.rb b/Library/Formula/readline.rb index abc1234..def5678 100644 --- a/Library/Formula/readline.rb +++ b/Library/Formula/readline.rb @@ -4,6 +4,7 @@ homepage 'http://tiswww.case.edu/php/chet/readline/rltop.html' url 'ftp://ftp.cwru.edu/pub/bash/readline-6.2.tar.gz' sha256 '79...
Add explicit version number for Readline. Signed-off-by: Adam Vandenberg <34c2b6407fd5a10249a15d699d40f9ed1782e98c@gmail.com>
diff --git a/lib/gitlab/version.rb b/lib/gitlab/version.rb index abc1234..def5678 100644 --- a/lib/gitlab/version.rb +++ b/lib/gitlab/version.rb @@ -44,7 +44,7 @@ when "GITLAB_SHELL_VERSION" "git@dev.gitlab.org:gitlab/gitlab-shell.git" when "GITLAB_WORKHORSE_VERSION" - "https://gitlab.com/g...
Switch to dev for workhorse source, again.
diff --git a/lib/tachikoma/settings.rb b/lib/tachikoma/settings.rb index abc1234..def5678 100644 --- a/lib/tachikoma/settings.rb +++ b/lib/tachikoma/settings.rb @@ -27,4 +27,14 @@ def self.repos_path=(repos_path) @repos_path = Pathname.new File.expand_path(repos_path) end + + # /path/to/gem/tachikoma + def ...
Add gem data, root path
diff --git a/lib/booking.rb b/lib/booking.rb index abc1234..def5678 100644 --- a/lib/booking.rb +++ b/lib/booking.rb @@ -0,0 +1,37 @@+class Booking < ActiveRecord::Base + validates_presence_of :debit_account, :credit_account, :title, :amount, :value_date + + belongs_to :debit_account, :foreign_key => 'debit_account_i...
Add de-namespaced Booking class. Stupid copy paste, probably to be dropped again.
diff --git a/lib/meem/templates.rb b/lib/meem/templates.rb index abc1234..def5678 100644 --- a/lib/meem/templates.rb +++ b/lib/meem/templates.rb @@ -12,8 +12,9 @@ # Returns an Array of Pathname instances. def self.list PATHS.map do |path| + next unless File.exists?(path) path.children.select { |ch...
Handle when optional folders don't exist.
diff --git a/lib/stacker/region.rb b/lib/stacker/region.rb index abc1234..def5678 100644 --- a/lib/stacker/region.rb +++ b/lib/stacker/region.rb @@ -7,24 +7,24 @@ attr_reader :name, :defaults, :stacks, :templates_path def initialize(name, defaults, stacks, templates_path) - Stacker.logger.info "region na...
Put back SSL verification on for aws-sdk
diff --git a/lib/tasks/events.rake b/lib/tasks/events.rake index abc1234..def5678 100644 --- a/lib/tasks/events.rake +++ b/lib/tasks/events.rake @@ -0,0 +1,16 @@+namespace :events do + desc 'Create demo data using our factories' + task fix_wrong_track: :environment do + events = Event.all.select { |e| e.track_id &...
Add task to remove non-existent track_id from Event.
diff --git a/Formula/p0f.rb b/Formula/p0f.rb index abc1234..def5678 100644 --- a/Formula/p0f.rb +++ b/Formula/p0f.rb @@ -19,6 +19,6 @@ 'RAAAAAIAAABFAABAbvpAAEAGAAB/AAABfwAAAcv8Iyjt2/Pg' \ 'AAAAALAC///+NAAAAgQ/2AEDAwQBAQgKCyrc9wAAAAAEAgAA' (testpath / 'test.pcap').write(Base64.decode64(pcap))...
Use relative path to test file Reverted last commits use of the full path to the test file. The executable is tested from within the `testpath`, so it's unnecessary.
diff --git a/lib/planning_center/client.rb b/lib/planning_center/client.rb index abc1234..def5678 100644 --- a/lib/planning_center/client.rb +++ b/lib/planning_center/client.rb @@ -31,7 +31,10 @@ private def default_headers - { 'content-type' => 'application/json' } + { + 'content-type' => '...
Add 'application/json' Accept header to requests
diff --git a/lib/geodata.rb b/lib/geodata.rb index abc1234..def5678 100644 --- a/lib/geodata.rb +++ b/lib/geodata.rb @@ -11,7 +11,11 @@ def self.serialize_country(country) {code: country.code, name: country.name, - subregions: country.subregions.map { |subregion| [subregion.code, subregion.name] }.to_h...
Fix sorting and inclusion of subregions in Geodata class.
diff --git a/RxBluetoothKit.podspec b/RxBluetoothKit.podspec index abc1234..def5678 100644 --- a/RxBluetoothKit.podspec +++ b/RxBluetoothKit.podspec @@ -16,7 +16,6 @@ s.ios.deployment_target = '8.0' s.osx.deployment_target = '10.10' - s.platform = :ios, '8.0' s.requires_arc = true s.source_files = '...
Remove iOS platform specification from podspec
diff --git a/spec/integration/subscribing_to_repos_spec.rb b/spec/integration/subscribing_to_repos_spec.rb index abc1234..def5678 100644 --- a/spec/integration/subscribing_to_repos_spec.rb +++ b/spec/integration/subscribing_to_repos_spec.rb @@ -6,9 +6,9 @@ include JSONHelper it "given a list of repos to subscrib...
Include the repo's name in the "committers" event JSON
diff --git a/MCHTTPRequestLogger.podspec b/MCHTTPRequestLogger.podspec index abc1234..def5678 100644 --- a/MCHTTPRequestLogger.podspec +++ b/MCHTTPRequestLogger.podspec @@ -0,0 +1,15 @@+Pod::Spec.new do |s| + s.name = 'MCHTTPRequestLogger' + s.version = '0.5.0' + s.license = 'BSD 3-Clause' + s.summary = 'Out...
Add a pod specification file.
diff --git a/app/controllers/clubs_controller.rb b/app/controllers/clubs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/clubs_controller.rb +++ b/app/controllers/clubs_controller.rb @@ -1,6 +1,10 @@ class ClubsController < ApplicationController - before_filter :authenticate_user! + before_filter :a...
Add show Action to Clubs Controller Update the Clubs controller to include a show action.
diff --git a/app/controllers/lists_controller.rb b/app/controllers/lists_controller.rb index abc1234..def5678 100644 --- a/app/controllers/lists_controller.rb +++ b/app/controllers/lists_controller.rb @@ -8,6 +8,8 @@ end def create + @list = List.create(list_params) + redirect_to lists_path end def...
Set proper redirect after List creation
diff --git a/app/controllers/repos_controller.rb b/app/controllers/repos_controller.rb index abc1234..def5678 100644 --- a/app/controllers/repos_controller.rb +++ b/app/controllers/repos_controller.rb @@ -21,7 +21,7 @@ @result_type ||= commit.benchmark_runs.first.category commit.benchmark_runs.where(cate...
Add label for Commit SHA1 in graph.
diff --git a/app/controllers/stats_controller.rb b/app/controllers/stats_controller.rb index abc1234..def5678 100644 --- a/app/controllers/stats_controller.rb +++ b/app/controllers/stats_controller.rb @@ -19,7 +19,7 @@ else @subtitle = "stats overview" @version = @rubygem.versions.most_...
Sort the versions on the graph properly
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,14 +1,4 @@ class UsersController < ApplicationController - def new - end - - def create - - end - - def inde...
Add users show, eliminate empty routes in users controller
diff --git a/spec/models/attachment_spec.rb b/spec/models/attachment_spec.rb index abc1234..def5678 100644 --- a/spec/models/attachment_spec.rb +++ b/spec/models/attachment_spec.rb @@ -3,7 +3,23 @@ RSpec.describe Attachment do let(:attachment) { build(:attachment) } + it { should belong_to(:attachable) } + it { ...
Add some more tests for attachments
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -1,27 +1,8 @@ require 'beaker-rspec/spec_helper' require 'beaker-rspec/helpers/serverspec' +require 'beaker/puppet_installer_helper' ...
Add helper to install puppet/pe/puppet-agent
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -4,18 +4,17 @@ require 'beaker/module_install_helper' run_puppet_install_helper unless ENV['BEAKER_provision'] == 'no' -install_ca_ce...
Clean up acceptance spec helper
diff --git a/test/test_1_8_fallbacks.rb b/test/test_1_8_fallbacks.rb index abc1234..def5678 100644 --- a/test/test_1_8_fallbacks.rb +++ b/test/test_1_8_fallbacks.rb @@ -2,6 +2,10 @@ # Tests that verify that on 1.8 versions of ruby, simplecov simply # does not launch and does not cause errors on the way +# +# TODO: T...
Make sure adapter definitions go through on 1.8
diff --git a/Layout.podspec b/Layout.podspec index abc1234..def5678 100644 --- a/Layout.podspec +++ b/Layout.podspec @@ -0,0 +1,16 @@+Pod::Spec.new do |s| + s.name = 'Layout' + s.version = "1.0.0" + s.summary = "Elegant view layout for iOS :leaves:" + s.homepage = "https://gith...
Add .podspec for cocoapods support
diff --git a/lib/generators/rails/scaffold_controller_generator.rb b/lib/generators/rails/scaffold_controller_generator.rb index abc1234..def5678 100644 --- a/lib/generators/rails/scaffold_controller_generator.rb +++ b/lib/generators/rails/scaffold_controller_generator.rb @@ -6,7 +6,7 @@ class ScaffoldControllerGen...
Set proper type for jbuilder option to prevent a warning with Thor >= 0.19.3 See https://github.com/erikhuda/thor/pull/435, right now we got a warning >Expected string default value for '--jbuilder'; got true (boolean)
diff --git a/config/unicorn.rb b/config/unicorn.rb index abc1234..def5678 100644 --- a/config/unicorn.rb +++ b/config/unicorn.rb @@ -1,8 +1,23 @@ # config/unicorn.rb -if ENV["RAILS_ENV"] == "development" - worker_processes 1 -else - worker_processes 3 +worker_processes Integer(ENV["WEB_CONCURRENCY"] || 3) +timeout 15...
Set up Unicorn as production server
diff --git a/UIImage-Resize.podspec b/UIImage-Resize.podspec index abc1234..def5678 100644 --- a/UIImage-Resize.podspec +++ b/UIImage-Resize.podspec @@ -0,0 +1,16 @@+Pod::Spec.new do |s| + s.name = "UIImage-Resize" + s.version = "0.1.0" + s.summary = "UIImage-Resize" + s.homepage ...
Insert minimal podspec file to allow inclusion via Cocoapods
diff --git a/lib/haml/helpers/safe_erubis_template.rb b/lib/haml/helpers/safe_erubis_template.rb index abc1234..def5678 100644 --- a/lib/haml/helpers/safe_erubis_template.rb +++ b/lib/haml/helpers/safe_erubis_template.rb @@ -10,7 +10,7 @@ end def precompiled_preamble(locals) - [super, "@output_buffer = ...
Fix the :erb filter in rails. Fixes #654
diff --git a/lib/tasks/code_quality_html_reports.rake b/lib/tasks/code_quality_html_reports.rake index abc1234..def5678 100644 --- a/lib/tasks/code_quality_html_reports.rake +++ b/lib/tasks/code_quality_html_reports.rake @@ -8,8 +8,12 @@ tsk.fail_on_error = false end + task :rubycritic_html do + sh 'rubycr...
Add rake task for rubicritic rake task
diff --git a/lib/tasks/mail/if_gem_version_stale.rake b/lib/tasks/mail/if_gem_version_stale.rake index abc1234..def5678 100644 --- a/lib/tasks/mail/if_gem_version_stale.rake +++ b/lib/tasks/mail/if_gem_version_stale.rake @@ -5,14 +5,14 @@ task :if_gem_version_stale do message = "" puts "checking the install...
Fix logic bug wherein the app emailed if the gem version is the latest.
diff --git a/Tabman.podspec b/Tabman.podspec index abc1234..def5678 100644 --- a/Tabman.podspec +++ b/Tabman.podspec @@ -3,7 +3,7 @@ s.name = "Tabman" s.platform = :ios, "9.0" s.requires_arc = true - s.swift_version = "4.2" + s.swift_version = "4.0" s.version = "2.4.1" s.summary ...
Fix Swift version in podspec
diff --git a/app/controllers/tagger_controller.rb b/app/controllers/tagger_controller.rb index abc1234..def5678 100644 --- a/app/controllers/tagger_controller.rb +++ b/app/controllers/tagger_controller.rb @@ -14,7 +14,7 @@ session[:guid] ||= SecureRandom.uuid # Save tag to db - Tag.new(:session_id => ...
Update controller to accept :content from js to db
diff --git a/active_interaction.gemspec b/active_interaction.gemspec index abc1234..def5678 100644 --- a/active_interaction.gemspec +++ b/active_interaction.gemspec @@ -6,8 +6,8 @@ Gem::Specification.new do |spec| spec.name = 'active_interaction' spec.version = ActiveInteraction::VERSION - spec.au...
Add myself as an author
diff --git a/spec/blimp/sources/disk_source_spec.rb b/spec/blimp/sources/disk_source_spec.rb index abc1234..def5678 100644 --- a/spec/blimp/sources/disk_source_spec.rb +++ b/spec/blimp/sources/disk_source_spec.rb @@ -33,7 +33,7 @@ it "should not allow access to hidden directories" do expect { - sour...
Fix minor bug in spec
diff --git a/app/workers/update_head_pipeline_for_merge_request_worker.rb b/app/workers/update_head_pipeline_for_merge_request_worker.rb index abc1234..def5678 100644 --- a/app/workers/update_head_pipeline_for_merge_request_worker.rb +++ b/app/workers/update_head_pipeline_for_merge_request_worker.rb @@ -1,6 +1,8 @@ cla...
Change queue namespace of UpdateHeadPipelineForMergeRequestWorker
diff --git a/spec/models/skill_spec.rb b/spec/models/skill_spec.rb index abc1234..def5678 100644 --- a/spec/models/skill_spec.rb +++ b/spec/models/skill_spec.rb @@ -27,4 +27,31 @@ skill = create(:skill) expect { skill.destroy }.to change(Skill, :count).by(-1) end + + describe "merged" do + before(:each)...
Test cases for merging skills
diff --git a/spec/movie_filter_spec.rb b/spec/movie_filter_spec.rb index abc1234..def5678 100644 --- a/spec/movie_filter_spec.rb +++ b/spec/movie_filter_spec.rb @@ -1,17 +1,28 @@+require 'ostruct' +require 'imdb' + require_relative '../lib/movie_filter' RSpec.describe 'MovieFilter' do + let(:filtered) do + ...
Use `let` to set up filtered array Populate using OpenScruct instances with and without posters.
diff --git a/app/models/spree/option_value_decorator.rb b/app/models/spree/option_value_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/option_value_decorator.rb +++ b/app/models/spree/option_value_decorator.rb @@ -1,5 +1,7 @@ Spree::OptionValue.class_eval do - scope :for_product, lambda { |product...
Use a database join to get products' variants, reducing round trips.
diff --git a/app/presenters/money_question_presenter.rb b/app/presenters/money_question_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/money_question_presenter.rb +++ b/app/presenters/money_question_presenter.rb @@ -6,7 +6,7 @@ end def hint_text - text = [body, suffix_label].reject(&:blank?)....
Add hint text to money questions Previously all money questions had a default hint-text of `in £` https://github.com/alphagov/smart-answers/pull/4150/commits/dfa0742c44874c4abbcf363451be86f7c9a8e607 This was recently removed for content clarity https://github.com/alphagov/smart-answers/commit/cc7fb3a11b028fa0c6a125d2...
diff --git a/app/serializers/task_comment_serializer.rb b/app/serializers/task_comment_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/task_comment_serializer.rb +++ b/app/serializers/task_comment_serializer.rb @@ -1,5 +1,5 @@ class TaskCommentSerializer < ActiveModel::Serializer - attributes :id, :c...
NEW: Add recipient_id and is_new to comment serializer
diff --git a/test/fixtures/cookbooks/perl_test/metadata.rb b/test/fixtures/cookbooks/perl_test/metadata.rb index abc1234..def5678 100644 --- a/test/fixtures/cookbooks/perl_test/metadata.rb +++ b/test/fixtures/cookbooks/perl_test/metadata.rb @@ -1,3 +1,5 @@ name 'perl_test' version '0.0.1' + depends 'perl' +depends 'b...
Revert "The test recipe doesn’t need build-essential" This reverts commit 790106d85b77cdc269785e4f14b33936d7eea998.
diff --git a/raygun_client.gemspec b/raygun_client.gemspec index abc1234..def5678 100644 --- a/raygun_client.gemspec +++ b/raygun_client.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'raygun_client' - s.version = '0.1.6' + s.version = '0.1.7' s.summary = 'Client for t...
Package version increased from 0.1.6 to 0.1.7
diff --git a/app/cells/checkout_cell.rb b/app/cells/checkout_cell.rb index abc1234..def5678 100644 --- a/app/cells/checkout_cell.rb +++ b/app/cells/checkout_cell.rb @@ -3,8 +3,7 @@ MONTH_NAMES = %w(January Febuary March April May June July August September October November December).freeze MONTHS = MONTH_NAMES.eac...
Fix the selection of months on the payment view.
diff --git a/app/controllers/sms.rb b/app/controllers/sms.rb index abc1234..def5678 100644 --- a/app/controllers/sms.rb +++ b/app/controllers/sms.rb @@ -3,7 +3,7 @@ end post '/sms' do - tip = Tips.find(rand(1..(Tips.all.length))) + tip = Tip.find(rand(1..(Tips.all.length))) msg = "Envirotip:" + tip
Remove s from Tips method
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -7,7 +7,9 @@ config.path_prefix = "/shutterbug" # use heroku app for now. Uncomment to use local file server. config.uri_prefix = "http://shutterbug.herokuapp.com/" - config.resource_dir = File.expand_path('../...
Add some comments about how to run with local instance of snapshot server.
diff --git a/app/models/bookmark.rb b/app/models/bookmark.rb index abc1234..def5678 100644 --- a/app/models/bookmark.rb +++ b/app/models/bookmark.rb @@ -1,4 +1,6 @@ class Bookmark < ApplicationRecord has_many :bookmark_tags has_many :tags, through: :bookmark_tags + + enum source_type: { "Post" => 0, "Publication...
Add enum source_type in Bookmark model
diff --git a/app/models/question.rb b/app/models/question.rb index abc1234..def5678 100644 --- a/app/models/question.rb +++ b/app/models/question.rb @@ -4,6 +4,8 @@ has_many :votes, as: :votable has_many :comments, as: :commentable + validates :title, :content, :user_id, presence: true + def to_param "#...
Add validations to Question model
diff --git a/app/models/response.rb b/app/models/response.rb index abc1234..def5678 100644 --- a/app/models/response.rb +++ b/app/models/response.rb @@ -2,6 +2,7 @@ belongs_to :responder, class_name: :User belongs_to :respondable, polymorphic: true has_many :votes, as: :votable + validates :content, presence: ...
Add validation to make repsonse content mandatory
diff --git a/app/mailers/user_mailer.rb b/app/mailers/user_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/user_mailer.rb +++ b/app/mailers/user_mailer.rb @@ -2,7 +2,7 @@ def welcome_email(user, organization) with_locale(user, organization) do organization_name = organization.display_name || t(:...
Add custom from for welcome_email
diff --git a/app/models/user_session.rb b/app/models/user_session.rb index abc1234..def5678 100644 --- a/app/models/user_session.rb +++ b/app/models/user_session.rb @@ -1,6 +1,7 @@ class UserSession < Authlogic::Session::Base - consecutive_failed_logins_limit 5 + consecutive_failed_logins_limit 6 + failed_login_ba...
Increase failed login count to 6 Change-Id: I44d0b6a06e9f97b9cd3f51056af1c11c8fbcc47f
diff --git a/deathmax_parse.rb b/deathmax_parse.rb index abc1234..def5678 100644 --- a/deathmax_parse.rb +++ b/deathmax_parse.rb @@ -14,4 +14,36 @@ response["header-here"] # All headers are lowercase unit_list = JSON.parse(response.body) -puts unit_list.first + +unit_array = [] + +unit_list.each do |unit_id, unit_ha...
Use deathmax's evomats json for data instead of scraping wiki
diff --git a/test/support/integration_case.rb b/test/support/integration_case.rb index abc1234..def5678 100644 --- a/test/support/integration_case.rb +++ b/test/support/integration_case.rb @@ -9,6 +9,10 @@ private + def aggregate + Metrics::Rails.aggregate + end + def counters Metrics::Rails.co...
Add aggregate access shortcut method for integration tests.
diff --git a/APAddressBook.podspec b/APAddressBook.podspec index abc1234..def5678 100644 --- a/APAddressBook.podspec +++ b/APAddressBook.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "APAddressBook" - s.version = "0.1.12" + s.version = "0.1.11" s.summary = "Easy access to iOS addr...
Revert "update pod spec to 0.1.12" This reverts commit 5d0af5d00e711d27baefac1e5f19fd36e55a63a9.
diff --git a/haproxy_log_parser.gemspec b/haproxy_log_parser.gemspec index abc1234..def5678 100644 --- a/haproxy_log_parser.gemspec +++ b/haproxy_log_parser.gemspec @@ -12,7 +12,7 @@ s.add_development_dependency 'rspec', '~> 3.5.0' s.files = Dir.glob('lib/**/*') + [ - 'README.rdoc', + 'README.md', 'VE...
Change gemspec to contain README.md
diff --git a/app/domain/entities/week.rb b/app/domain/entities/week.rb index abc1234..def5678 100644 --- a/app/domain/entities/week.rb +++ b/app/domain/entities/week.rb @@ -8,13 +8,13 @@ def get_day_of_week case @id - when 1 then 'Domingo' - when 2 then 'Segunda' - when 3 then 'Ter...
Adjust in Week entity to implement translate
diff --git a/chef/cookbooks/ccdc/recipes/cron.rb b/chef/cookbooks/ccdc/recipes/cron.rb index abc1234..def5678 100644 --- a/chef/cookbooks/ccdc/recipes/cron.rb +++ b/chef/cookbooks/ccdc/recipes/cron.rb @@ -5,8 +5,8 @@ day options[:day] || "*" month options[:month] || "*" weekday options[:weekday] || ...
Add source .bash_profile to commands
diff --git a/ruby-amqp/new_task.rb b/ruby-amqp/new_task.rb index abc1234..def5678 100644 --- a/ruby-amqp/new_task.rb +++ b/ruby-amqp/new_task.rb @@ -8,7 +8,7 @@ queue = channel.queue("task_queue", :durable => true) message = ARGV.empty? ? "Hello World!" : ARGV.join(" ") - AMQP::Exchange.default.publish(messag...
Use the channel we open
diff --git a/app/controllers/api/papers_controller.rb b/app/controllers/api/papers_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/papers_controller.rb +++ b/app/controllers/api/papers_controller.rb @@ -17,7 +17,7 @@ format.epub do epub = EpubConverter.new @paper, current_user, pa...
Send the proper ePub as part of the download
diff --git a/app/controllers/mixins/topology_mixin.rb b/app/controllers/mixins/topology_mixin.rb index abc1234..def5678 100644 --- a/app/controllers/mixins/topology_mixin.rb +++ b/app/controllers/mixins/topology_mixin.rb @@ -0,0 +1,23 @@+module TopologyMixin + def show + # When navigated here without id, it means t...
Add common methods from topology controllers to new mixin
diff --git a/app/models/responsibilities_agreement.rb b/app/models/responsibilities_agreement.rb index abc1234..def5678 100644 --- a/app/models/responsibilities_agreement.rb +++ b/app/models/responsibilities_agreement.rb @@ -4,5 +4,4 @@ extend SingleForwardable def_single_delegator :Agreement, :reflect_on_assoc...
Fix errant line from merge
diff --git a/chef/atcclient/recipes/default.rb b/chef/atcclient/recipes/default.rb index abc1234..def5678 100644 --- a/chef/atcclient/recipes/default.rb +++ b/chef/atcclient/recipes/default.rb @@ -12,4 +12,9 @@ # Recipe:: default # include_recipe 'apt' -package "ubuntu-desktop" +package 'ubuntu-desktop' + +# Force th...
MAke sure the atc client UI is started upon bootup
diff --git a/lib/api/account_methods.rb b/lib/api/account_methods.rb index abc1234..def5678 100644 --- a/lib/api/account_methods.rb +++ b/lib/api/account_methods.rb @@ -9,12 +9,12 @@ self.call_api("/account", {:account_id => account_id}) end - def find_account(args) - self.call_api("/accoun...
Update modify account api call to require account id as an argument since WePay requires it, and allow find_account to be called without arguments.
diff --git a/config/environments/production.rb b/config/environments/production.rb index abc1234..def5678 100644 --- a/config/environments/production.rb +++ b/config/environments/production.rb @@ -17,5 +17,4 @@ config.assets.digest = true config.static_cache_control = 'public, max-age=31536000' config.host = EN...
Remove the logger level configuration
diff --git a/config/initializers/minimagick.rb b/config/initializers/minimagick.rb index abc1234..def5678 100644 --- a/config/initializers/minimagick.rb +++ b/config/initializers/minimagick.rb @@ -13,7 +13,7 @@ convert.depth(8) convert.gravity("center") convert.crop("260x300+50+0") - convert.sc...
Remove scale for better accuracy in NB
diff --git a/cookbooks/nagios/recipes/server_package.rb b/cookbooks/nagios/recipes/server_package.rb index abc1234..def5678 100644 --- a/cookbooks/nagios/recipes/server_package.rb +++ b/cookbooks/nagios/recipes/server_package.rb @@ -18,6 +18,21 @@ # limitations under the License. # +if platform_family?(debian) + + ...
Fix Nagios server installs via package using a closed out pull request
diff --git a/app/helpers/cache_helper.rb b/app/helpers/cache_helper.rb index abc1234..def5678 100644 --- a/app/helpers/cache_helper.rb +++ b/app/helpers/cache_helper.rb @@ -2,6 +2,6 @@ module CacheHelper def cache_buster(version) - "#{ Setting['advanced.cache_buster'] }#{ version }" + "#{ Setting.all.load }#...
Add settings to cache key
diff --git a/app/jobs/github_sync_job.rb b/app/jobs/github_sync_job.rb index abc1234..def5678 100644 --- a/app/jobs/github_sync_job.rb +++ b/app/jobs/github_sync_job.rb @@ -29,7 +29,7 @@ end commits << commit end - return commits, nil + return commits.reverse, nil end protected
Fix initial sync commits order...