diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/minitest-spec-rails.gemspec b/minitest-spec-rails.gemspec index abc1234..def5678 100644 --- a/minitest-spec-rails.gemspec +++ b/minitest-spec-rails.gemspec @@ -1,5 +1,3 @@-# -*- encoding: utf-8 -*- - $LOAD_PATH.push File.expand_path('../lib', __FILE__) require 'minitest-spec-rails/version'
Remove encoding comment from gemspec.
diff --git a/plugins/distribution/db/migrate/20130615023621_add_active_to_distribution_plugin_supplier.rb b/plugins/distribution/db/migrate/20130615023621_add_active_to_distribution_plugin_supplier.rb index abc1234..def5678 100644 --- a/plugins/distribution/db/migrate/20130615023621_add_active_to_distribution_plugin_su...
Add active field to supplier
diff --git a/cookbooks/lib/features/mysql_spec.rb b/cookbooks/lib/features/mysql_spec.rb index abc1234..def5678 100644 --- a/cookbooks/lib/features/mysql_spec.rb +++ b/cookbooks/lib/features/mysql_spec.rb @@ -8,7 +8,7 @@ its(:exit_status) { should eq 0 } end - describe file('/home/travis/.my.cnf') do + descr...
Exclude `~travis/.my.cnf` spec on precise
diff --git a/app/services/runner_service.rb b/app/services/runner_service.rb index abc1234..def5678 100644 --- a/app/services/runner_service.rb +++ b/app/services/runner_service.rb @@ -20,12 +20,15 @@ end def run_cyber_dojo_sh(image_name, id, files, max_seconds) - @http.get(__method__, { - image_name:ima...
Refactor runner to pass manifest
diff --git a/app/views/annotations/index.json.jbuilder b/app/views/annotations/index.json.jbuilder index abc1234..def5678 100644 --- a/app/views/annotations/index.json.jbuilder +++ b/app/views/annotations/index.json.jbuilder @@ -3,9 +3,9 @@ json.data do if annotation.entity if annotation.entity.descriptio...
Add target parent to Annotations links to avoid open links inside frames Closes #261
diff --git a/app/views/compositions/save.json.jbuilder b/app/views/compositions/save.json.jbuilder index abc1234..def5678 100644 --- a/app/views/compositions/save.json.jbuilder +++ b/app/views/compositions/save.json.jbuilder @@ -1,4 +1,5 @@ json.composition do + json.id @composition.id json.name @composition.name ...
Include composition ID in save response
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -13,13 +13,14 @@ end def client - config = { - :consumer_key => configuration...
Configure with block instead of hash
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -40,7 +40,7 @@ end def all_other_users - User.where("users.id != ?", current_user....
Fix all_other_users to be restricted to the current team
diff --git a/app/views/spree/api/products/show.v1.rabl b/app/views/spree/api/products/show.v1.rabl index abc1234..def5678 100644 --- a/app/views/spree/api/products/show.v1.rabl +++ b/app/views/spree/api/products/show.v1.rabl @@ -1,5 +1,4 @@ object @product -cache [I18n.locale, @current_user_roles.include?('admin'), cur...
Remove cache. Fucking stupid implementation of api.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -22,7 +22,7 @@ if request.env["HTTP_USER_AGENT"] and !request.env["HTTP_USER_AGE...
Add code to end campaign and redirect users who come to the site
diff --git a/ar_transaction_changes.gemspec b/ar_transaction_changes.gemspec index abc1234..def5678 100644 --- a/ar_transaction_changes.gemspec +++ b/ar_transaction_changes.gemspec @@ -17,7 +17,7 @@ gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_paths = ["lib"] - gem.add_dependency "...
Fix version on gemspec so it includes activerecord 4.
diff --git a/lib/rusic/uploaders/template.rb b/lib/rusic/uploaders/template.rb index abc1234..def5678 100644 --- a/lib/rusic/uploaders/template.rb +++ b/lib/rusic/uploaders/template.rb @@ -2,7 +2,7 @@ module Uploaders class Template < Base def perform - client["themes/#{theme}/templates/#{file.dirn...
Return only the directory name not the entire path
diff --git a/lib/yarrow/tools/output_file.rb b/lib/yarrow/tools/output_file.rb index abc1234..def5678 100644 --- a/lib/yarrow/tools/output_file.rb +++ b/lib/yarrow/tools/output_file.rb @@ -2,7 +2,7 @@ module Tools # TODO: consider renaming this to OutputDocument. class OutputFile - include ::Configurab...
Tweak output file to write to docroot by default
diff --git a/lib/cinch/plugins/clever_bot.rb b/lib/cinch/plugins/clever_bot.rb index abc1234..def5678 100644 --- a/lib/cinch/plugins/clever_bot.rb +++ b/lib/cinch/plugins/clever_bot.rb @@ -8,6 +8,11 @@ match lambda { |m| /(.*)\s?@?#{m.bot.nick}[:,]?\s*(.*)/i }, use_prefix: false + def initialize(*args) + su...
Fix initialize function that didn't make the move
diff --git a/jenkins-peace.gemspec b/jenkins-peace.gemspec index abc1234..def5678 100644 --- a/jenkins-peace.gemspec +++ b/jenkins-peace.gemspec @@ -24,5 +24,5 @@ s.add_runtime_dependency 'tty-table' s.add_development_dependency 'rspec' - s.add_development_dependency 'simplecov' + s.add_development_dependency ...
Fix simplecov version (workaround for a bug in CodeClimate reporter)
diff --git a/lib/finicity/v1/response/mfa.rb b/lib/finicity/v1/response/mfa.rb index abc1234..def5678 100644 --- a/lib/finicity/v1/response/mfa.rb +++ b/lib/finicity/v1/response/mfa.rb @@ -7,7 +7,7 @@ class Choice include ::Saxomattic - attribute :data + attribute :data, :value => true ...
Fix getting choice/imageChoice element body returned
diff --git a/cookbooks/ghg/recipes/ghg.rb b/cookbooks/ghg/recipes/ghg.rb index abc1234..def5678 100644 --- a/cookbooks/ghg/recipes/ghg.rb +++ b/cookbooks/ghg/recipes/ghg.rb @@ -4,6 +4,5 @@ ghg 'c-bata/kube-prompt' ghg 'golang/dep' ghg 'hyperhq/pi' -ghg 'kubernetes-sigs/aws-iam-authenticator' ghg 'mattn/memo' ghg 'w...
Uninstall aws-iam-authenticator to use awscli instead
diff --git a/rs_user_policy.gemspec b/rs_user_policy.gemspec index abc1234..def5678 100644 --- a/rs_user_policy.gemspec +++ b/rs_user_policy.gemspec @@ -1,7 +1,7 @@ Gem::Specification.new do |gem| gem.name = "rs_user_policy" gem.version = "0.0.1" - gem.homepage = "http://www.rightscale.com" + gem.homepage = "ht...
Set homepage to git repo
diff --git a/lib/pivotal-tracker/activity.rb b/lib/pivotal-tracker/activity.rb index abc1234..def5678 100644 --- a/lib/pivotal-tracker/activity.rb +++ b/lib/pivotal-tracker/activity.rb @@ -39,7 +39,7 @@ element :project_id, Integer element :description, String - has_many :stories, Story + has_many :sto...
Enable to fetch stories in activities
diff --git a/lib/jsound/midi/devices/monitor.rb b/lib/jsound/midi/devices/monitor.rb index abc1234..def5678 100644 --- a/lib/jsound/midi/devices/monitor.rb +++ b/lib/jsound/midi/devices/monitor.rb @@ -1,17 +1,20 @@ # A device that prints out all incoming MIDI message. module JSound::Midi::Devices - class Monitor ...
Monitor is now a proper Device and handles the <= method
diff --git a/lib/puppet/type/netapp_qtree.rb b/lib/puppet/type/netapp_qtree.rb index abc1234..def5678 100644 --- a/lib/puppet/type/netapp_qtree.rb +++ b/lib/puppet/type/netapp_qtree.rb @@ -5,19 +5,7 @@ apply_to_device - ensurable do - desc "Netapp Qtree resource state. Valid values are: present, absent." ...
Simplify ensure property of qtree type The block passed to the ensurable method is basically the default behaviour as defined in puppet/property/ensure.rb#self.defaultvalues Ommit the block and use the default
diff --git a/lib/rails_ops/log_subscriber.rb b/lib/rails_ops/log_subscriber.rb index abc1234..def5678 100644 --- a/lib/rails_ops/log_subscriber.rb +++ b/lib/rails_ops/log_subscriber.rb @@ -9,15 +9,12 @@ return if op.class.logging_skipped? + profile = ::RailsOps::Profiler.node(op.object_id) + messa...
Reword failed operation log message Close #7
diff --git a/lib/tty/table/border_options.rb b/lib/tty/table/border_options.rb index abc1234..def5678 100644 --- a/lib/tty/table/border_options.rb +++ b/lib/tty/table/border_options.rb @@ -57,10 +57,16 @@ # # @api public def separator?(line) - return true if separator == TTY::Table::Border::E...
Change to be more readable
diff --git a/spec/active_hash/relation_spec.rb b/spec/active_hash/relation_spec.rb index abc1234..def5678 100644 --- a/spec/active_hash/relation_spec.rb +++ b/spec/active_hash/relation_spec.rb @@ -1,14 +1,16 @@ require 'spec_helper' RSpec.describe ActiveHash::Relation do - class Country < ActiveHash::Base - self...
Use anonymous model class in spec
diff --git a/spec/helpers/dhis2_helper_spec.rb b/spec/helpers/dhis2_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/dhis2_helper_spec.rb +++ b/spec/helpers/dhis2_helper_spec.rb @@ -0,0 +1,30 @@+# frozen_string_literal: true + +require "rails_helper" + +RSpec.describe Dhis2Helper, type: :helper do + let...
Add spec for dhis2 links helper
diff --git a/spec/routing/static_pages_spec.rb b/spec/routing/static_pages_spec.rb index abc1234..def5678 100644 --- a/spec/routing/static_pages_spec.rb +++ b/spec/routing/static_pages_spec.rb @@ -8,20 +8,6 @@ ) end - it "routes privacy policy page" do - expect(:get => "/privacy_policy").to route_to( - ...
Remove the specs for terms of use and privacy policy routes as well.
diff --git a/spec/type_aliases/x509pem_spec.rb b/spec/type_aliases/x509pem_spec.rb index abc1234..def5678 100644 --- a/spec/type_aliases/x509pem_spec.rb +++ b/spec/type_aliases/x509pem_spec.rb @@ -1,5 +1,6 @@ require 'spec_helper' -describe 'Certmgmt::X509PEM', :type => :type_alias do - it { is_expected.to allow_val...
Use test cert for type alias rspec test
diff --git a/app/helpers/home_helper.rb b/app/helpers/home_helper.rb index abc1234..def5678 100644 --- a/app/helpers/home_helper.rb +++ b/app/helpers/home_helper.rb @@ -4,7 +4,10 @@ if !logged_in? link_to t('ui.home'), home_path else - link_to t('ui.home'), conversation_messages_path(current_user.p...
Add a tooltip to the home link when the user is loged, so the user can know the login name of the current user and the personal convo
diff --git a/app/helpers/root_helper.rb b/app/helpers/root_helper.rb index abc1234..def5678 100644 --- a/app/helpers/root_helper.rb +++ b/app/helpers/root_helper.rb @@ -3,30 +3,6 @@ module RootHelper include GeoHelper - - def has_further_information?(publication) - publication.parts.collect(&:slug).include?('f...
Remove 4 more outdated helpers These aren't used any more.
diff --git a/core/db/migrate/20210112193440_remove_contact_email_from_spree_stores.rb b/core/db/migrate/20210112193440_remove_contact_email_from_spree_stores.rb index abc1234..def5678 100644 --- a/core/db/migrate/20210112193440_remove_contact_email_from_spree_stores.rb +++ b/core/db/migrate/20210112193440_remove_contac...
Fix migration version for Rails 6.0 support
diff --git a/TvOSMoreButton.podspec b/TvOSMoreButton.podspec index abc1234..def5678 100644 --- a/TvOSMoreButton.podspec +++ b/TvOSMoreButton.podspec @@ -9,4 +9,5 @@ s.tvos.deployment_target = '9.0' s.source_files = 'Source/**/*.swift' s.resource_bundle = { 'TvOSMoreButton' => ['Resources/*.lproj'] } + s.pod_ta...
Set swift version for podspec
diff --git a/lib/msplex/resource/application.rb b/lib/msplex/resource/application.rb index abc1234..def5678 100644 --- a/lib/msplex/resource/application.rb +++ b/lib/msplex/resource/application.rb @@ -1,12 +1,12 @@ module Msplex module Resource class Application - attr_reader :name - attr_reader :main...
Add links field to Application
diff --git a/lib/patches/actioncontroller_ex.rb b/lib/patches/actioncontroller_ex.rb index abc1234..def5678 100644 --- a/lib/patches/actioncontroller_ex.rb +++ b/lib/patches/actioncontroller_ex.rb @@ -32,4 +32,19 @@ end end + alias_method :theme_support_active_layout, :active_layout + + def active_lay...
Handle layouts by pushing the theme path onto the class level view_paths instance before calling active_layout
diff --git a/app/models/subscription.rb b/app/models/subscription.rb index abc1234..def5678 100644 --- a/app/models/subscription.rb +++ b/app/models/subscription.rb @@ -11,6 +11,7 @@ enumerize :status, in: { paid: 0, pending_payment: 1, unpaid: 2, canceled: 3 } + has_many :transactions belongs_to :user b...
Add has_many transactions association to Subscription
diff --git a/Casks/couchbase-server-enterprise.rb b/Casks/couchbase-server-enterprise.rb index abc1234..def5678 100644 --- a/Casks/couchbase-server-enterprise.rb +++ b/Casks/couchbase-server-enterprise.rb @@ -1,6 +1,6 @@ cask :v1 => 'couchbase-server-enterprise' do - version '3.0.4' - sha256 '476599935a1278b71d2bee73...
Revert "Upgrade Couchbase Server.app (Enterprise) to v3.0.4"
diff --git a/spec/models/flight_spec.rb b/spec/models/flight_spec.rb index abc1234..def5678 100644 --- a/spec/models/flight_spec.rb +++ b/spec/models/flight_spec.rb @@ -13,7 +13,7 @@ end describe 'when not valid' do - it 'is not valid without a name' do + xit 'is not valid without a name' do ...
Set test to pending for flight name validation since logic changed.
diff --git a/spec/recipes/winrm_spec.rb b/spec/recipes/winrm_spec.rb index abc1234..def5678 100644 --- a/spec/recipes/winrm_spec.rb +++ b/spec/recipes/winrm_spec.rb @@ -1,11 +1,15 @@ require 'spec_helper' -require 'chef/win32/version' describe 'powershell::winrm' do let(:chef_run) do ChefSpec::SoloRunner.new...
Fix specs for winrm recipe Update winrm's specs to be able to test on linux/travis: * Remove references to `chef/winr32/version` * Mock shellout commands
diff --git a/lib/culinarian/dsl.rb b/lib/culinarian/dsl.rb index abc1234..def5678 100644 --- a/lib/culinarian/dsl.rb +++ b/lib/culinarian/dsl.rb @@ -27,9 +27,7 @@ end def step(name) - step = Step.new(name) - steps << step - step + find_or_create_step(name) end ...
Allow steps to be retrieved by name
diff --git a/lib/email_assessor.rb b/lib/email_assessor.rb index abc1234..def5678 100644 --- a/lib/email_assessor.rb +++ b/lib/email_assessor.rb @@ -10,7 +10,7 @@ end def self.configuration - @@configuration ||= Configuration.new + @configuration ||= Configuration.new end def self.configure
Replace the configuration class variable with an instance variable equivalant
diff --git a/Casks/after-dark-classic.rb b/Casks/after-dark-classic.rb index abc1234..def5678 100644 --- a/Casks/after-dark-classic.rb +++ b/Casks/after-dark-classic.rb @@ -0,0 +1,29 @@+cask 'after-dark-classic' do + version :latest + sha256 :no_check + + url 'ftp://www.infinisys.co.jp/online/online_afterdarkclassic...
Add the After Dark Classic Set v1.0 from Infinisys.
diff --git a/spec/cdm_batch_spec.rb b/spec/cdm_batch_spec.rb index abc1234..def5678 100644 --- a/spec/cdm_batch_spec.rb +++ b/spec/cdm_batch_spec.rb @@ -4,18 +4,4 @@ it 'has a version number' do expect(CdmBatch::VERSION).not_to be nil end - - it 'checks that each records associated file is present' do - ...
Remove specs now tested elsewhere
diff --git a/spec/discovery_spec.rb b/spec/discovery_spec.rb index abc1234..def5678 100644 --- a/spec/discovery_spec.rb +++ b/spec/discovery_spec.rb @@ -5,13 +5,13 @@ fixtures_path = File.join(File.dirname(__FILE__), 'fixtures') json_discovery = File.read(File.join(fixtures_path, 'discovery.json')) uri = ...
Make code valid in 1.8.
diff --git a/app/web_view_controller.rb b/app/web_view_controller.rb index abc1234..def5678 100644 --- a/app/web_view_controller.rb +++ b/app/web_view_controller.rb @@ -13,16 +13,14 @@ v.scalesPageToFit = true url = self.item[9].gsub(/\"/, "") # image image_src = NSData.dataWithContentsOfURL(NSURL.U...
Fix image size on webview
diff --git a/minimal-mistakes-jekyll.gemspec b/minimal-mistakes-jekyll.gemspec index abc1234..def5678 100644 --- a/minimal-mistakes-jekyll.gemspec +++ b/minimal-mistakes-jekyll.gemspec @@ -12,11 +12,8 @@ spec.metadata["plugin_type"] = "theme" spec.files = `git ls-files -z`.split("\x0").select d...
Update regex for spec.files and remove bindir and executables
diff --git a/Library/Homebrew/test/testing_env.rb b/Library/Homebrew/test/testing_env.rb index abc1234..def5678 100644 --- a/Library/Homebrew/test/testing_env.rb +++ b/Library/Homebrew/test/testing_env.rb @@ -0,0 +1,54 @@+# This software is in the public domain, furnished "as is", without technical +# support, and with...
Add new "testing environment" include.
diff --git a/lib/tasks/assets.rake b/lib/tasks/assets.rake index abc1234..def5678 100644 --- a/lib/tasks/assets.rake +++ b/lib/tasks/assets.rake @@ -4,8 +4,8 @@ # all! namespace :assets do - desc "Create .gz versions of static assets" - task :gzip_static => :environment do + desc "Create .gz versions of assets" +...
Rename gzip_static task to just "gzip"
diff --git a/lib/tiny_tds/error.rb b/lib/tiny_tds/error.rb index abc1234..def5678 100644 --- a/lib/tiny_tds/error.rb +++ b/lib/tiny_tds/error.rb @@ -1,22 +1,8 @@-module TinyTds +module TinyTds class Error < StandardError - - SEVERITIES = [ - {:number => 1, :severity => 'EXINFO', :explanation ...
Remove TinyTds::Error::SEVERITIES. Not used anywhere.
diff --git a/lib/warnings/mixin.rb b/lib/warnings/mixin.rb index abc1234..def5678 100644 --- a/lib/warnings/mixin.rb +++ b/lib/warnings/mixin.rb @@ -15,6 +15,8 @@ # @return [nil] # def warn(message) + super(message) if $DEBUG + $WARNINGS << Warning.new(message,caller) return nil en...
Call the original warn method if $DEBUG is enabled.
diff --git a/comable.gemspec b/comable.gemspec index abc1234..def5678 100644 --- a/comable.gemspec +++ b/comable.gemspec @@ -10,7 +10,7 @@ s.summary = 'Comable provides a simple way to add e-commerce features to your Ruby on Rails application.' s.description = 'Comable provides a simple way to add e-commerce f...
Add COMABLE_VERSION file to gem
diff --git a/Library/Formula/open-mpi.rb b/Library/Formula/open-mpi.rb index abc1234..def5678 100644 --- a/Library/Formula/open-mpi.rb +++ b/Library/Formula/open-mpi.rb @@ -1,9 +1,9 @@ require 'formula' class OpenMpi <Formula - url 'http://www.open-mpi.org/software/ompi/v1.4/downloads/openmpi-1.4.1.tar.gz' + url '...
Update Open-MPI to version 1.4.2 Some Mac-Specific issues noted in the Open-MPI changelog: http://www.open-mpi.org/community/lists/announce/2010/05/0037.php Signed-off-by: Adam Vandenberg <34c2b6407fd5a10249a15d699d40f9ed1782e98c@gmail.com>
diff --git a/db/data_migrations/20200509165855_add_serial_numberto_service_vehicles.rb b/db/data_migrations/20200509165855_add_serial_numberto_service_vehicles.rb index abc1234..def5678 100644 --- a/db/data_migrations/20200509165855_add_serial_numberto_service_vehicles.rb +++ b/db/data_migrations/20200509165855_add_ser...
Update Serial Number data migration
diff --git a/db/migrate/20151029211323_create_users.rb b/db/migrate/20151029211323_create_users.rb index abc1234..def5678 100644 --- a/db/migrate/20151029211323_create_users.rb +++ b/db/migrate/20151029211323_create_users.rb @@ -6,6 +6,7 @@ t.string :last_name, null: false t.string :email, null: false ...
Update user db to include vote_count integer
diff --git a/spec/features/triggers_spec.rb b/spec/features/triggers_spec.rb index abc1234..def5678 100644 --- a/spec/features/triggers_spec.rb +++ b/spec/features/triggers_spec.rb @@ -12,7 +12,7 @@ context 'create a trigger' do before do - click_on 'Add Trigger' + click_on 'Add trigger' expec...
Fix failing rspec test for triggers
diff --git a/app/models/campfire.rb b/app/models/campfire.rb index abc1234..def5678 100644 --- a/app/models/campfire.rb +++ b/app/models/campfire.rb @@ -2,8 +2,8 @@ KEYS = ["campfire_subdomain", "campfire_token", "campfire_room"] def self.notify_mocks_created(mocks, url) - room = find_room - if use? && roo...
Fix uploading flow for Mockr instances without Campfire configured Users without a Campfire subdomain set were seeing an error message when uploading a mock. The mock went through, but we were encountering an error in attempting to parse the URI ".campfire.now", which does not exist. We now only parse if a proper camp...
diff --git a/app/models/timeslot.rb b/app/models/timeslot.rb index abc1234..def5678 100644 --- a/app/models/timeslot.rb +++ b/app/models/timeslot.rb @@ -5,8 +5,12 @@ validates_presence_of :start, :tutor_id validates :tutor_id, uniqueness: { scope: :start, - message: "you are already available at this time"...
Add validation for student/start in Timeslot model Validation to prevent student from signin up for more than one tutoring session at a given start time.
diff --git a/lib/adiwg/mdtranslator/readers/fgdc/modules/module_spatialOrganization.rb b/lib/adiwg/mdtranslator/readers/fgdc/modules/module_spatialOrganization.rb index abc1234..def5678 100644 --- a/lib/adiwg/mdtranslator/readers/fgdc/modules/module_spatialOrganization.rb +++ b/lib/adiwg/mdtranslator/readers/fgdc/modul...
Add fgdc reader module 'spatialOrganization'
diff --git a/spec/controllers/users_controller_spec.rb b/spec/controllers/users_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/users_controller_spec.rb +++ b/spec/controllers/users_controller_spec.rb @@ -15,6 +15,14 @@ it { expect(response).to be_success } it { expect(response).t...
Add a few more specs for /signup
diff --git a/spec/controllers/users_controller_spec.rb b/spec/controllers/users_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/users_controller_spec.rb +++ b/spec/controllers/users_controller_spec.rb @@ -0,0 +1,31 @@+require 'rails_helper' +describe UsersController do + + let!(:user) { Factory...
Create tests for the users controller
diff --git a/spec/controllers/votes_controller_spec.rb b/spec/controllers/votes_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/votes_controller_spec.rb +++ b/spec/controllers/votes_controller_spec.rb @@ -42,4 +42,5 @@ expect(response).to be_redirect expect(response).to redirect_to ...
Fix syntax in Votes controller spec Spec is missing an 'end' keyword towards the end.
diff --git a/elasticsearch-client.gemspec b/elasticsearch-client.gemspec index abc1234..def5678 100644 --- a/elasticsearch-client.gemspec +++ b/elasticsearch-client.gemspec @@ -18,8 +18,8 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["lib"] - s.add_depen...
Upgrade faraday to ~> 0.9.0
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -1,6 +1,6 @@ require 'sinatra/base' require 'mongoid' -require 'pry' +require 'pry' if Sinatra::Base.development? require_relative 'models/init'
Disable pry in production due to issues with heroku
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -3,7 +3,6 @@ require "cuba" sms = Mobilyws::API.new ENV["USERNAME"], ENV["PASSWORD"], ENV["SENDER_NAME"] -message = ENV["MESSAGE"] # TODO user can send new message. @@ -22,7 +21,7 @@ on root do on param("m...
Move getting message from ENV inside every call. This is fast attempt to fix message caching name.
diff --git a/db/migrate/20181213170120_change_dataset_file_audits_id_to_bigint.rb b/db/migrate/20181213170120_change_dataset_file_audits_id_to_bigint.rb index abc1234..def5678 100644 --- a/db/migrate/20181213170120_change_dataset_file_audits_id_to_bigint.rb +++ b/db/migrate/20181213170120_change_dataset_file_audits_id_...
Update dataset_file_audit_id primary key to bigint
diff --git a/db/migrate/20200917072152_add_subscription_reference_to_orders.rb b/db/migrate/20200917072152_add_subscription_reference_to_orders.rb index abc1234..def5678 100644 --- a/db/migrate/20200917072152_add_subscription_reference_to_orders.rb +++ b/db/migrate/20200917072152_add_subscription_reference_to_orders.rb...
Use integer foreign keys for compatibility with old tables
diff --git a/app/controllers/omniauth_callbacks_controller.rb b/app/controllers/omniauth_callbacks_controller.rb index abc1234..def5678 100644 --- a/app/controllers/omniauth_callbacks_controller.rb +++ b/app/controllers/omniauth_callbacks_controller.rb @@ -11,17 +11,33 @@ protected def oauth_callback_for(oauth_p...
Use OmniauthUserSerializer instance to sign users via omniauth
diff --git a/app/decorators/models/refinery/user_decorator.rb b/app/decorators/models/refinery/user_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/models/refinery/user_decorator.rb +++ b/app/decorators/models/refinery/user_decorator.rb @@ -1,9 +1,9 @@ require 'acts_as_indexed' begin - Refinery::Use...
Fix user model with new authentication
diff --git a/app/overrides/replace_checkout_payment_button.rb b/app/overrides/replace_checkout_payment_button.rb index abc1234..def5678 100644 --- a/app/overrides/replace_checkout_payment_button.rb +++ b/app/overrides/replace_checkout_payment_button.rb @@ -2,4 +2,5 @@ :replace => "code[erb-lou...
Disable as this has now been incorporated into move_save_checkout_button
diff --git a/temando.gemspec b/temando.gemspec index abc1234..def5678 100644 --- a/temando.gemspec +++ b/temando.gemspec @@ -18,5 +18,5 @@ gem.add_dependency 'nokogiri' gem.add_dependency 'typhoeus', '~> 0.4.2' - gem.add_development_dependency 'rspec' + gem.add_development_dependency 'rspec', '~> 2.11.0' end
Set a specific minimum version of rspec
diff --git a/features/step_definitions/renalware/peritonitis_episodes_steps.rb b/features/step_definitions/renalware/peritonitis_episodes_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/renalware/peritonitis_episodes_steps.rb +++ b/features/step_definitions/renalware/peritonitis_episodes_steps.rb...
Implement recording a medication step for a peritonitis episode
diff --git a/lib/atdis/applications.rb b/lib/atdis/applications.rb index abc1234..def5678 100644 --- a/lib/atdis/applications.rb +++ b/lib/atdis/applications.rb @@ -13,11 +13,8 @@ end def all - # TODO: Use URL to do the concatenation - url = base_url + "/" + "atdis/1.0/applications.json" - r =...
Simplify concatenation of url and inline
diff --git a/spec/ailurus/client_spec.rb b/spec/ailurus/client_spec.rb index abc1234..def5678 100644 --- a/spec/ailurus/client_spec.rb +++ b/spec/ailurus/client_spec.rb @@ -4,11 +4,11 @@ describe Ailurus::Client do it "initializes properly" do - client = Ailurus::Client.new({ + client = Ailurus::Client.new( ...
Clean up test syntax a bit Part of me appreciates this, and part of me thinks there's too much magic. (The eternal struggle.)
diff --git a/spec/bin/gem-search_spec.rb b/spec/bin/gem-search_spec.rb index abc1234..def5678 100644 --- a/spec/bin/gem-search_spec.rb +++ b/spec/bin/gem-search_spec.rb @@ -30,6 +30,12 @@ it_behaves_like 'display an usage' end + # non-exisitng option: -x + context 'with -x' do + subject { `#{BIN} -x` } + ...
Add test for giving non-exisiting option
diff --git a/spec/classes/server_spec.rb b/spec/classes/server_spec.rb index abc1234..def5678 100644 --- a/spec/classes/server_spec.rb +++ b/spec/classes/server_spec.rb @@ -0,0 +1,17 @@+require 'spec_helper' + +describe 'ssh::server' do + let (:facts) { { + :osfamily => 'Debian' + }} + + context "basic tests" do + ...
Add basic test for ssh::server
diff --git a/lib/cached_write_store.rb b/lib/cached_write_store.rb index abc1234..def5678 100644 --- a/lib/cached_write_store.rb +++ b/lib/cached_write_store.rb @@ -34,6 +34,8 @@ namespace, actual_key = YAML.load(key) redis_store.set(namespace, actual_key, value) end + + @store = {} end pri...
Set store to empty after persisted, helps reduce the memory usage
diff --git a/spec/lib/hdo/mailer_spec.rb b/spec/lib/hdo/mailer_spec.rb index abc1234..def5678 100644 --- a/spec/lib/hdo/mailer_spec.rb +++ b/spec/lib/hdo/mailer_spec.rb @@ -0,0 +1,21 @@+require 'spec_helper' + +module Hdo + describe Mailer do + let(:rep) { Representative.make! :with_email } + + it "sends confirm...
Add spec for multipart devise mails
diff --git a/spec/lib/roo/excelx_spec.rb b/spec/lib/roo/excelx_spec.rb index abc1234..def5678 100644 --- a/spec/lib/roo/excelx_spec.rb +++ b/spec/lib/roo/excelx_spec.rb @@ -9,6 +9,10 @@ it 'creates an instance' do expect(subject).to be_a(Roo::Excelx) end + + it 'correctly parses files that dont have ...
Add test proving it works w/ files that don't supply spans attribute on rowns
diff --git a/spec/models/comment_spec.rb b/spec/models/comment_spec.rb index abc1234..def5678 100644 --- a/spec/models/comment_spec.rb +++ b/spec/models/comment_spec.rb @@ -0,0 +1,25 @@+require "rails_helper" + +RSpec.describe Comment, type: :model do + let(:case_worker) { create(:user, :case_worker) } + let(:admin) ...
Add tests verifying that we lookup users on creation of comments * spec/models/comment_spec.rb: Add tests for ensuring that comments can notify the appropriate other users about new comments.
diff --git a/spec/support/example_app.rb b/spec/support/example_app.rb index abc1234..def5678 100644 --- a/spec/support/example_app.rb +++ b/spec/support/example_app.rb @@ -3,6 +3,8 @@ class ExampleApp < Sinatra::Base set :views, File.dirname(__FILE__) + '/views' + set :raise_errors, true + set :show_exceptions,...
Allow errors to be propagated.
diff --git a/lib/facter/pip_version.rb b/lib/facter/pip_version.rb index abc1234..def5678 100644 --- a/lib/facter/pip_version.rb +++ b/lib/facter/pip_version.rb @@ -5,15 +5,23 @@ Facter.add("pip_version") do has_weight 100 setcode do - /^pip (\d+\.\d+\.?\d*).*$/.match(Facter::Util::Resolution.exec('pip --versi...
Add begin/rescue/end to setcode block This silences these warnings: Could not retrieve pip_version: undefined method `[]' for nil:NilClass Could not retrieve pip_version: can't convert Symbol into String
diff --git a/spec/gaddag/word/to_delimited_paths_spec.rb b/spec/gaddag/word/to_delimited_paths_spec.rb index abc1234..def5678 100644 --- a/spec/gaddag/word/to_delimited_paths_spec.rb +++ b/spec/gaddag/word/to_delimited_paths_spec.rb @@ -2,24 +2,18 @@ describe GADDAG::Word, '#to_delimited_paths' do context 'when th...
Use subject instead of let, not sure if clearer
diff --git a/lib/image-picker-rails.rb b/lib/image-picker-rails.rb index abc1234..def5678 100644 --- a/lib/image-picker-rails.rb +++ b/lib/image-picker-rails.rb @@ -1,5 +1,8 @@ require "image-picker-rails/version" module ImagePickerRails - # Your code goes here... + module Rails + class Engine < ::Rails::En...
Make gem a Rails engine
diff --git a/lib/legal_pages/engine.rb b/lib/legal_pages/engine.rb index abc1234..def5678 100644 --- a/lib/legal_pages/engine.rb +++ b/lib/legal_pages/engine.rb @@ -5,5 +5,9 @@ config.to_prepare do ApplicationController.helper(LegalPages::ApplicationHelper) end + + def self.setup(&block) + yield...
Add setup code to evaluate app's initializer
diff --git a/lib/mina/unicorn/tasks.rb b/lib/mina/unicorn/tasks.rb index abc1234..def5678 100644 --- a/lib/mina/unicorn/tasks.rb +++ b/lib/mina/unicorn/tasks.rb @@ -5,7 +5,8 @@ namespace :unicorn do include Mina::Unicorn::Utility - set_default :unicorn_env, -> { fetch(:rails_env, 'production') } + # Follow...
Change default settings for unicorn_env Follow recommendations from official unicorn documentation. see: http://unicorn.bogomips.org/unicorn_1.html#rack-environment
diff --git a/lib/rspec_java/project_initializer/spec/features/homepage_spec.rb b/lib/rspec_java/project_initializer/spec/features/homepage_spec.rb index abc1234..def5678 100644 --- a/lib/rspec_java/project_initializer/spec/features/homepage_spec.rb +++ b/lib/rspec_java/project_initializer/spec/features/homepage_spec.rb...
Use feature and scenario DSL The feature and scenario DSL correspond to describe and it, respectively. These methods are simply aliases that allow feature specs to read more as customer and acceptance tests
diff --git a/lib/rails-footnotes/notes/env_note.rb b/lib/rails-footnotes/notes/env_note.rb index abc1234..def5678 100644 --- a/lib/rails-footnotes/notes/env_note.rb +++ b/lib/rails-footnotes/notes/env_note.rb @@ -8,11 +8,18 @@ end def content - # Replace HTTP_COOKIE for a link - @env['HTTP_...
Stop the unescaped env madness!
diff --git a/lib/scss_lint/linter/declared_name.rb b/lib/scss_lint/linter/declared_name.rb index abc1234..def5678 100644 --- a/lib/scss_lint/linter/declared_name.rb +++ b/lib/scss_lint/linter/declared_name.rb @@ -3,29 +3,29 @@ include LinterRegistry def visit_function(node) - check(node) + check(no...
Make DeclaredName lints more specific Change the descriptions of lints reported by `DeclaredName` to be relevant to the particular context (e.g. whether the incorrectly named thing was a function, mixin, or variable). Change-Id: I2191c1a3bb4f512b7d28e377eaedce4c0ec0a849 Reviewed-on: https://gerrit.causes.com/28832 Te...
diff --git a/app/decorators/review_decorator.rb b/app/decorators/review_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/review_decorator.rb +++ b/app/decorators/review_decorator.rb @@ -7,8 +7,10 @@ h.link_to title, path, options end + # Do not use helper methods via Draper when the method is u...
Stop to use a helper method
diff --git a/app/policies/application_policy.rb b/app/policies/application_policy.rb index abc1234..def5678 100644 --- a/app/policies/application_policy.rb +++ b/app/policies/application_policy.rb @@ -5,50 +5,5 @@ @user = user @record = record end - - def index? - false - end - - def show? - scope....
Remove unused code from auto-generated app policy Huge test coverage increase...
diff --git a/app/serializers/game_serializer.rb b/app/serializers/game_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/game_serializer.rb +++ b/app/serializers/game_serializer.rb @@ -1,6 +1,6 @@ class GameSerializer < ActiveModel::Serializer attributes :id, :created_at - has_one :tournament, seria...
Remove dead reference to serializer
diff --git a/app/controllers/backend/navigations_controller.rb b/app/controllers/backend/navigations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/backend/navigations_controller.rb +++ b/app/controllers/backend/navigations_controller.rb @@ -2,6 +2,6 @@ before_action -> { breadcrumb.add t('b.naviga...
Fix bad reference to Navigation.
diff --git a/common/src/rb/lib/selenium/webdriver/driver_extensions/takes_screenshot.rb b/common/src/rb/lib/selenium/webdriver/driver_extensions/takes_screenshot.rb index abc1234..def5678 100644 --- a/common/src/rb/lib/selenium/webdriver/driver_extensions/takes_screenshot.rb +++ b/common/src/rb/lib/selenium/webdriver/d...
JariBakken: Use "wb" mode string when saving screenshots (needed on Windows). r9686
diff --git a/app/features/album/album.rb b/app/features/album/album.rb index abc1234..def5678 100644 --- a/app/features/album/album.rb +++ b/app/features/album/album.rb @@ -14,6 +14,17 @@ def self.new_from_slug(slug) slug = ::AlbumSlug.new(slug) new(slug: slug.to_s, title: slug.to_title) + end + + def sel...
Add methods to update first_photo_taken_at
diff --git a/app/helpers/files_helper.rb b/app/helpers/files_helper.rb index abc1234..def5678 100644 --- a/app/helpers/files_helper.rb +++ b/app/helpers/files_helper.rb @@ -1,5 +1,4 @@ module FilesHelper - private # The url to a icon representing the file based in its extension. @@ -10,14 +9,15 @@ end de...
Format code in files helper
diff --git a/app/mailers/admin_mailer.rb b/app/mailers/admin_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/admin_mailer.rb +++ b/app/mailers/admin_mailer.rb @@ -8,5 +8,9 @@ mail(to: @app_configs.admin_email, subject: "[Reservation] Notes for " + (Date.yesterday.midnight).strftime('%m/%d/%y')) end -...
Revert "removed admin mail for checkout" This reverts commit ce0eb77cabdfc3063ac1eb8aa52416f7264b9b0a.
diff --git a/app/controllers/videos_controller.rb b/app/controllers/videos_controller.rb index abc1234..def5678 100644 --- a/app/controllers/videos_controller.rb +++ b/app/controllers/videos_controller.rb @@ -6,9 +6,13 @@ def new @video = Video.new + if session[:user_id] == nil + redirect_to login_path...
Add redirecting if not logged in
diff --git a/app/mailers/spree/supplier_mailer.rb b/app/mailers/spree/supplier_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/spree/supplier_mailer.rb +++ b/app/mailers/spree/supplier_mailer.rb @@ -1,7 +1,7 @@ module Spree class SupplierMailer < Spree::BaseMailer - default from: Spree::Config[:mails_...
Replace outdated Spree::Config[:mails_from] with Spree::Store.current.mail_from_address https://github.com/spree/spree/pull/6097
diff --git a/app/models/spree/gateway/usa_epay.rb b/app/models/spree/gateway/usa_epay.rb index abc1234..def5678 100644 --- a/app/models/spree/gateway/usa_epay.rb +++ b/app/models/spree/gateway/usa_epay.rb @@ -19,7 +19,7 @@ gateway_options = if creditcard.respond_to?(:gateway_options) creditcard.gateway_o...
Call gateway_options on payment using send, given that it's a private method
diff --git a/spec/clipboard_file_spec.rb b/spec/clipboard_file_spec.rb index abc1234..def5678 100644 --- a/spec/clipboard_file_spec.rb +++ b/spec/clipboard_file_spec.rb @@ -1,6 +1,8 @@ # frozen_string_literal: true require_relative "spec_helper" + +require "fileutils" describe 'Clipboard::File' do before :all ...
Add explicit require "fileuilts" in spec file
diff --git a/spec/dummy/config/routes.rb b/spec/dummy/config/routes.rb index abc1234..def5678 100644 --- a/spec/dummy/config/routes.rb +++ b/spec/dummy/config/routes.rb @@ -3,5 +3,5 @@ devise_for :users - root 'application#welcome' + root to: redirect('/admin') end
Change root path for dummy app
diff --git a/spec/github_cli/cli_spec.rb b/spec/github_cli/cli_spec.rb index abc1234..def5678 100644 --- a/spec/github_cli/cli_spec.rb +++ b/spec/github_cli/cli_spec.rb @@ -1,5 +1,66 @@ require 'spec_helper' describe GithubCLI::CLI do + let(:object) { described_class } + let(:config) { stub(:config).as_null_object...
Add test for init and config commands.