diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/scss_lint/linter/empty_rule.rb b/lib/scss_lint/linter/empty_rule.rb index abc1234..def5678 100644 --- a/lib/scss_lint/linter/empty_rule.rb +++ b/lib/scss_lint/linter/empty_rule.rb @@ -4,12 +4,8 @@ include LinterRegistry def visit_rule(node) - add_lint(node) if node.children.empty? + ...
Remove description method from EmptyRule The `description` method is being deprecated. Change-Id: I632b48097c628b6140b330745dfef15b059174ff Reviewed-on: http://gerrit.causes.com/36722 Tested-by: jenkins <d95b56ce41a2e1ac4cecdd398defd7414407cc08@causes.com> Reviewed-by: Shane da Silva <6f6e68d1df92f30cb4b3ce35260ddf94...
diff --git a/lib/discordrb/voice/encoder.rb b/lib/discordrb/voice/encoder.rb index abc1234..def5678 100644 --- a/lib/discordrb/voice/encoder.rb +++ b/lib/discordrb/voice/encoder.rb @@ -23,13 +23,13 @@ end def encode_file(file) - command = "#{ffmpeg_command} -loglevel 0 -i \"#{file}\" -f s16le -ar 48000 ...
Fix Voice::Encoder volume option for avconv
diff --git a/lib/facebooker/models/album.rb b/lib/facebooker/models/album.rb index abc1234..def5678 100644 --- a/lib/facebooker/models/album.rb +++ b/lib/facebooker/models/album.rb @@ -5,7 +5,7 @@ class Album include Model attr_accessor :aid, :cover_pid, :owner, :name, :created, - :modified...
Add :visible attr_accessor to Facebooker:Album model
diff --git a/lib/nationbuilder/paginator.rb b/lib/nationbuilder/paginator.rb index abc1234..def5678 100644 --- a/lib/nationbuilder/paginator.rb +++ b/lib/nationbuilder/paginator.rb @@ -11,11 +11,11 @@ @body[page_type.to_s] end - define_method(:"#{page_type}") do |args = {}| + define_method(:"#{page_t...
Update the params name in pagination calls To be more in line with the raw_call being used
diff --git a/lib/restclient/net_http_ext.rb b/lib/restclient/net_http_ext.rb index abc1234..def5678 100644 --- a/lib/restclient/net_http_ext.rb +++ b/lib/restclient/net_http_ext.rb @@ -1,39 +1,5 @@ module Net class HTTP - - # Adding the patch method if it doesn't exist (rest-client issue: https://github.com/archilo...
Drop the Net::HTTP::Patch monkey patch. Now that we require Ruby >= 1.9.3, there's no need for this monkey patch.
diff --git a/LVGSwiftSystemSoundServices.podspec b/LVGSwiftSystemSoundServices.podspec index abc1234..def5678 100644 --- a/LVGSwiftSystemSoundServices.podspec +++ b/LVGSwiftSystemSoundServices.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "LVGSwiftSystemSoundServices" - s.version = "0.1...
Change podspec version to 0.1.2
diff --git a/lib/klarna_gateway/models/amount_calculators/uk/line_item_calculator.rb b/lib/klarna_gateway/models/amount_calculators/uk/line_item_calculator.rb index abc1234..def5678 100644 --- a/lib/klarna_gateway/models/amount_calculators/uk/line_item_calculator.rb +++ b/lib/klarna_gateway/models/amount_calculators/uk...
Use display_amount instead of display_total This is deprecated in Solidus 2.1.
diff --git a/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec b/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec index abc1234..def5678 100644 --- a/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec +++ b/railties/lib/rails/generators/rails/plugin_new/...
Tidy up a bit plugin new gemspec
diff --git a/lib/bane/behavior_maker.rb b/lib/bane/behavior_maker.rb index abc1234..def5678 100644 --- a/lib/bane/behavior_maker.rb +++ b/lib/bane/behavior_maker.rb @@ -30,12 +30,12 @@ class ResponderMaker def initialize(responder) - @responer = responder + @responder = responder end def ...
Correct typo in variable name
diff --git a/app/importers/data_transformers/csv_row_cleaner.rb b/app/importers/data_transformers/csv_row_cleaner.rb index abc1234..def5678 100644 --- a/app/importers/data_transformers/csv_row_cleaner.rb +++ b/app/importers/data_transformers/csv_row_cleaner.rb @@ -3,7 +3,7 @@ def transform_row if has_dates ...
Make sure we're passing in DateTimes to importers that expect datetimes
diff --git a/lib/tasks/temporary/factual_migration.rake b/lib/tasks/temporary/factual_migration.rake index abc1234..def5678 100644 --- a/lib/tasks/temporary/factual_migration.rake +++ b/lib/tasks/temporary/factual_migration.rake @@ -16,8 +16,10 @@ .where(city: nil) locations.each do |location| ...
:lipstick: Add whodunnit for the importer
diff --git a/app/controllers/admin_controller.rb b/app/controllers/admin_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin_controller.rb +++ b/app/controllers/admin_controller.rb @@ -17,7 +17,7 @@ def ensure_admin_user ensure_user_can 'access_admin' - cookies.encrypted[:current_user_id...
Fix error when there is no current_user
diff --git a/app/controllers/books_controller.rb b/app/controllers/books_controller.rb index abc1234..def5678 100644 --- a/app/controllers/books_controller.rb +++ b/app/controllers/books_controller.rb @@ -1,2 +1,10 @@ class BooksController < ApplicationController + def show + @book = Book.find(paramas[:id]) + re...
Add method show in books
diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pages_controller.rb +++ b/app/controllers/pages_controller.rb @@ -6,7 +6,7 @@ @upcoming_events = Event.upcoming end - def history + def beliefs @title = 'Beliefs' ...
Fix title on Beliefs page
diff --git a/voicearchive_client.gemspec b/voicearchive_client.gemspec index abc1234..def5678 100644 --- a/voicearchive_client.gemspec +++ b/voicearchive_client.gemspec @@ -19,7 +19,7 @@ spec.require_paths = ["lib"] spec.add_dependency "activesupport" - spec.add_development_dependency "bundler", "~> 1.3" + spe...
Use latest version of bundler
diff --git a/app/models/import/resources/base.rb b/app/models/import/resources/base.rb index abc1234..def5678 100644 --- a/app/models/import/resources/base.rb +++ b/app/models/import/resources/base.rb @@ -0,0 +1,19 @@+require 'active_resource' + +class Import::Resources::Base < ActiveResource::Base + self.site = "" + ...
Add Resource Base class for imports This is the base class for all import resources. It can be used as follows: class Import::Resources::User < Import::Resources::Base validates :name, presence: true import do ::User.create(name: name) end end The import is only triggered if the model is valid (in ...
diff --git a/app/models/spree/order_decorator.rb b/app/models/spree/order_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/order_decorator.rb +++ b/app/models/spree/order_decorator.rb @@ -7,7 +7,7 @@ def last_payment return nil if payments.blank? - return payments.last + return payments....
Order payments by created_at and pick the latest
diff --git a/app/services/user/signup_service.rb b/app/services/user/signup_service.rb index abc1234..def5678 100644 --- a/app/services/user/signup_service.rb +++ b/app/services/user/signup_service.rb @@ -5,7 +5,8 @@ end def create_account - account = @user.accounts.create() + account_name = "Conta Privada...
Update service to add name and owner to new account
diff --git a/run.rb b/run.rb index abc1234..def5678 100644 --- a/run.rb +++ b/run.rb @@ -1,22 +1,42 @@ #!/usr/bin/env ruby +require 'optparse' require_relative 'kepler_processor.rb' -# TODO: use optparse to clean this up +options = {:input_path => [], :output_path => "data/output"} -# abort the execution if no fil...
Switch to using optparse for command line option parsing
diff --git a/lib/instapusher/railtie.rb b/lib/instapusher/railtie.rb index abc1234..def5678 100644 --- a/lib/instapusher/railtie.rb +++ b/lib/instapusher/railtie.rb @@ -26,7 +26,7 @@ if response.code == '200' tmp = MultiJson.load(response.body) - puts 'The appliction will be deployed to: '...
Fix typo: 'appliction' to 'application'
diff --git a/lib/mbidle/unique_queue.rb b/lib/mbidle/unique_queue.rb index abc1234..def5678 100644 --- a/lib/mbidle/unique_queue.rb +++ b/lib/mbidle/unique_queue.rb @@ -3,9 +3,13 @@ def push(*items) EM.schedule do items.each do |item| - @items.push(item) unless @items.include?(item) + ...
Update for EM::Queue internal API change
diff --git a/app/mailers/keymail/auth_mailer.rb b/app/mailers/keymail/auth_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/keymail/auth_mailer.rb +++ b/app/mailers/keymail/auth_mailer.rb @@ -1,13 +1,13 @@ module Keymail class AuthMailer < ActionMailer::Base - default from: "from@example.com" + defaul...
Set default from email to rails.keymail
diff --git a/lib/skipper/servers/ec2.rb b/lib/skipper/servers/ec2.rb index abc1234..def5678 100644 --- a/lib/skipper/servers/ec2.rb +++ b/lib/skipper/servers/ec2.rb @@ -11,15 +11,15 @@ end def instances - find_instances + @instances ||= find_instances end def hosts - ...
Print a table of EC2 info for the 'servers' command
diff --git a/validator/absolute_file_path_validator.rb b/validator/absolute_file_path_validator.rb index abc1234..def5678 100644 --- a/validator/absolute_file_path_validator.rb +++ b/validator/absolute_file_path_validator.rb @@ -3,11 +3,11 @@ module MCollective module Validator class Absolute_file_pathValidator...
Correct variable usage in absolute_file_path validation The `absolute_file_path` validator was using missmatched variables halfway through the code. The commit realigns everything to use more ceoherent and clearer named variables.
diff --git a/db/migrate/20170507161530_require_batch_and_recorded_at_in_live_times.rb b/db/migrate/20170507161530_require_batch_and_recorded_at_in_live_times.rb index abc1234..def5678 100644 --- a/db/migrate/20170507161530_require_batch_and_recorded_at_in_live_times.rb +++ b/db/migrate/20170507161530_require_batch_and_...
Fix live_times migration requiring batch and recorded_at to make it reversible.
diff --git a/app/serializers/user_serializer.rb b/app/serializers/user_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/user_serializer.rb +++ b/app/serializers/user_serializer.rb @@ -4,7 +4,8 @@ attributes :avatar_url, :bio, :hearts_received, :last_hearted_at, :last_online, :staff, :url, :full_url, ...
Allow staff to see encrypted_password (for migrations only)
diff --git a/cookbooks/travis_build_environment/recipes/sshd.rb b/cookbooks/travis_build_environment/recipes/sshd.rb index abc1234..def5678 100644 --- a/cookbooks/travis_build_environment/recipes/sshd.rb +++ b/cookbooks/travis_build_environment/recipes/sshd.rb @@ -22,7 +22,7 @@ package 'openssh-server' -templates '...
Use existing resource name :neutral_face:
diff --git a/lib/processing_framework/shell_out_helper.rb b/lib/processing_framework/shell_out_helper.rb index abc1234..def5678 100644 --- a/lib/processing_framework/shell_out_helper.rb +++ b/lib/processing_framework/shell_out_helper.rb @@ -52,7 +52,7 @@ end def debug? - true + false end en...
Debug should be false until enabled as a cli option
diff --git a/lib/real_world_rails/inspectors/inspector.rb b/lib/real_world_rails/inspectors/inspector.rb index abc1234..def5678 100644 --- a/lib/real_world_rails/inspectors/inspector.rb +++ b/lib/real_world_rails/inspectors/inspector.rb @@ -1,9 +1,11 @@ require 'coderay' +require_relative '../printer' require_relative...
Use pretty print powers from Printer module
diff --git a/config/initializers/wrap_parameters.rb b/config/initializers/wrap_parameters.rb index abc1234..def5678 100644 --- a/config/initializers/wrap_parameters.rb +++ b/config/initializers/wrap_parameters.rb @@ -8,6 +8,6 @@ # end # To enable root element in JSON for ActiveRecord objects. -# ActiveSupport.on_loa...
Make sure root element is not being returned
diff --git a/cookbooks/burthorpe/recipes/default.rb b/cookbooks/burthorpe/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/burthorpe/recipes/default.rb +++ b/cookbooks/burthorpe/recipes/default.rb @@ -4,3 +4,10 @@ quiet false action [:install, :dump_autoload] end + +bash "migrate_db" do + user "v...
Migrate database after composer install
diff --git a/core/spec/lib/spree/core/testing_support/factories/variant_property_rule_factory_spec.rb b/core/spec/lib/spree/core/testing_support/factories/variant_property_rule_factory_spec.rb index abc1234..def5678 100644 --- a/core/spec/lib/spree/core/testing_support/factories/variant_property_rule_factory_spec.rb ++...
Test variant property rule factory
diff --git a/lib/extensions/generic_view_paths.rb b/lib/extensions/generic_view_paths.rb index abc1234..def5678 100644 --- a/lib/extensions/generic_view_paths.rb +++ b/lib/extensions/generic_view_paths.rb @@ -3,7 +3,7 @@ class PathSet attr_accessor :active_scaffold_paths - def find_template_with_active_scaf...
Fix for latest rails edge
diff --git a/passkeep2.gemspec b/passkeep2.gemspec index abc1234..def5678 100644 --- a/passkeep2.gemspec +++ b/passkeep2.gemspec @@ -20,6 +20,8 @@ gem.test_files = Dir['spec/**/*'] gem.require_paths = ['lib'] + gem.add_dependency 'trollop', '~> 2.1', '>= 2.1.2' + gem.add_development_dependency 'bundler', ...
Add trollop as a dependency
diff --git a/app/helpers/repos_helper.rb b/app/helpers/repos_helper.rb index abc1234..def5678 100644 --- a/app/helpers/repos_helper.rb +++ b/app/helpers/repos_helper.rb @@ -1,6 +1,6 @@ module ReposHelper def wanna_triage_button(repo, html_class: "") - path = user_signed_in? ? repo_subscriptions_path(repo_id: repo...
Add origin path to authorize path helper
diff --git a/lib/rembrandt/engines/web_service.rb b/lib/rembrandt/engines/web_service.rb index abc1234..def5678 100644 --- a/lib/rembrandt/engines/web_service.rb +++ b/lib/rembrandt/engines/web_service.rb @@ -1,3 +1,4 @@+require 'net/http' require 'uri' module Rembrandt
Add missing require for net/http
diff --git a/lib/services/notification_service.rb b/lib/services/notification_service.rb index abc1234..def5678 100644 --- a/lib/services/notification_service.rb +++ b/lib/services/notification_service.rb @@ -1,5 +1,5 @@ # -# Copyright (C) 2014 Instructure, Inc. +# Copyright (C) 2014-2016 Instructure, Inc. # # This f...
Fix nil value loading notification service config Closes CNVS-27564 Avoids causing a crash when configuration for the notification service is absent but feature flags are enabled. Also removes the default config options, meaning that notification_service_queue_name is now required in the config. Test plan: - Remove...
diff --git a/tasks/finalize-buildpack/run.rb b/tasks/finalize-buildpack/run.rb index abc1234..def5678 100644 --- a/tasks/finalize-buildpack/run.rb +++ b/tasks/finalize-buildpack/run.rb @@ -8,4 +8,8 @@ buildpack_repo_dir = 'buildpack' uncached_buildpack_dir = 'pivotal-buildpacks' +ENV['GOPATH']=buildpack_repo_dir +EN...
Set GOPATH, GOBIN, PATH for finalizing Signed-off-by: Sam Coward <f2d9ddb83d985bcf331a113cd487aeceb5e618e4@pivotal.io>
diff --git a/bin/testsave.rb b/bin/testsave.rb index abc1234..def5678 100644 --- a/bin/testsave.rb +++ b/bin/testsave.rb @@ -0,0 +1,64 @@+#!/usr/bin/env ruby + +require 'gst' + +Gst.init +$stderr.puts "INFO: Using #{Gst.version_string}" + +unless ARGV.length == 1 + $stderr.puts "Usage: #{__FILE__} <filename>" + exit ...
Add the older ruby test
diff --git a/db/migrate/20151103154104_add_buffers_and_add_buffers_to_load_profiles.rb b/db/migrate/20151103154104_add_buffers_and_add_buffers_to_load_profiles.rb index abc1234..def5678 100644 --- a/db/migrate/20151103154104_add_buffers_and_add_buffers_to_load_profiles.rb +++ b/db/migrate/20151103154104_add_buffers_and...
Fix buffer migration when run during a deploy Multiple migrations; a previous migration added the "composite" column, this migration needs to reload the Technology class to ensure the change is picked up.
diff --git a/nyan-cat-formatter.gemspec b/nyan-cat-formatter.gemspec index abc1234..def5678 100644 --- a/nyan-cat-formatter.gemspec +++ b/nyan-cat-formatter.gemspec @@ -6,8 +6,8 @@ s.authors = ["Matt Sears"] s.email = ["matt@mattsears.com"] s.homepage = "" - s.summary = %q{TODO: Write a gem su...
Update the name and description of the gem
diff --git a/features/step_definitions/guard_brakeman_steps.rb b/features/step_definitions/guard_brakeman_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/guard_brakeman_steps.rb +++ b/features/step_definitions/guard_brakeman_steps.rb @@ -10,7 +10,7 @@ Then /^guard should rescan the application$...
Fix tests on all builds
diff --git a/party_prawn_submarine/constants.rb b/party_prawn_submarine/constants.rb index abc1234..def5678 100644 --- a/party_prawn_submarine/constants.rb +++ b/party_prawn_submarine/constants.rb @@ -18,4 +18,7 @@ # The name of the font to use for text FONT_NAME = Gosu::default_font_name + # The text height of th...
Add constant for button text height
diff --git a/rails_stdout_logging.gemspec b/rails_stdout_logging.gemspec index abc1234..def5678 100644 --- a/rails_stdout_logging.gemspec +++ b/rails_stdout_logging.gemspec @@ -7,6 +7,7 @@ gem.description = %q{Sets Rails to log to stdout} gem.summary = %q{Overrides Rails' built in logger to send all logs t...
Add license to gemspec, is MIT per https://github.com/pivotal/LicenseFinder
diff --git a/lib/omniauth/strategies/cronofy_service_account.rb b/lib/omniauth/strategies/cronofy_service_account.rb index abc1234..def5678 100644 --- a/lib/omniauth/strategies/cronofy_service_account.rb +++ b/lib/omniauth/strategies/cronofy_service_account.rb @@ -5,7 +5,7 @@ option :client_options, { ...
Change service_account to enterprise_connect in oauth url
diff --git a/test/support/fake_udp_socket.rb b/test/support/fake_udp_socket.rb index abc1234..def5678 100644 --- a/test/support/fake_udp_socket.rb +++ b/test/support/fake_udp_socket.rb @@ -1,5 +1,8 @@ class FakeUdpSocket + attr_reader :buffer + TimingRegex = /\:\d+\|ms\Z/ + CounterRegex = /\:\d+\|c\Z/ def ini...
Break down fake udp socket methods a bit more.
diff --git a/app/controllers/api/messages_controller.rb b/app/controllers/api/messages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/messages_controller.rb +++ b/app/controllers/api/messages_controller.rb @@ -3,7 +3,7 @@ def index @account = Account.find(params.fetch(:account)) autho...
Fix bug when listing messages in api
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -10,5 +10,5 @@ supports os end -source_url 'https://github.com/chef-cookbooks/ohai' if respond_to?(:source_url) -issues_url 'https://github.com/chef-cookbooks/ohai/issues' if respond_to?(:issues_url) +source...
Remove Chef 11 combatibility check
diff --git a/creek.gemspec b/creek.gemspec index abc1234..def5678 100644 --- a/creek.gemspec +++ b/creek.gemspec @@ -25,5 +25,5 @@ spec.add_development_dependency 'rspec', '~> 2.13.0' spec.add_dependency 'nokogiri', '~> 1.6.0' - spec.add_dependency 'rubyzip', '~> 0.9.9' + spec.add_dependency 'rubyzip', '>= 1...
Change rubyzip dependency to >= 1.0
diff --git a/hero_rspec.rb b/hero_rspec.rb index abc1234..def5678 100644 --- a/hero_rspec.rb +++ b/hero_rspec.rb @@ -11,4 +11,14 @@ expect(hero.power_up).to eq 110 end + it "can power down" do + hero = Hero.new 'mike' + expect(hero.power_down).to eq 90 + end + + it "displays full hero info" do + he...
Add tests for all methods
diff --git a/pointme.gemspec b/pointme.gemspec index abc1234..def5678 100644 --- a/pointme.gemspec +++ b/pointme.gemspec @@ -1,6 +1,7 @@ # encoding: utf-8 -require "lib/pointme/version" +$:.push File.expand_path "../lib", __FILE__ +require "pointme/version" Gem::Specification.new do |s| s.name = "pointme...
Change way of requiring version file
diff --git a/pipeline/app/controllers/application_controller.rb b/pipeline/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/pipeline/app/controllers/application_controller.rb +++ b/pipeline/app/controllers/application_controller.rb @@ -1,5 +1,6 @@-class ApplicationController < ActionControl...
Change controller to API and desired responses to JSON objs
diff --git a/spec/integration/draft_js_compiler_spec.rb b/spec/integration/draft_js_compiler_spec.rb index abc1234..def5678 100644 --- a/spec/integration/draft_js_compiler_spec.rb +++ b/spec/integration/draft_js_compiler_spec.rb @@ -10,8 +10,12 @@ [block1, block2, block2, block1] } + let(:output_html) { + ...
Add expected html output to test.
diff --git a/jekyll-materialdocs.gemspec b/jekyll-materialdocs.gemspec index abc1234..def5678 100644 --- a/jekyll-materialdocs.gemspec +++ b/jekyll-materialdocs.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |spec| spec.name = "jekyll-materialdocs" - spec.version = "1.1.2" + spec.version ...
Fix gemspec and bump version
diff --git a/config/initializers/secret_token.rb b/config/initializers/secret_token.rb index abc1234..def5678 100644 --- a/config/initializers/secret_token.rb +++ b/config/initializers/secret_token.rb @@ -0,0 +1 @@+Wheelomatic9000::Application.config.secret_token = ENV['SECRET_TOKEN'] || bde8eee598129768ea1d58f28d614ae...
Set an env secret token and use default if none
diff --git a/config/initializers/secret_token.rb b/config/initializers/secret_token.rb index abc1234..def5678 100644 --- a/config/initializers/secret_token.rb +++ b/config/initializers/secret_token.rb @@ -9,4 +9,4 @@ # Make sure your secret_key_base is kept private # if you're sharing your code publicly. -Community:...
Remove SECRET_TOKEN and calculate a new one
diff --git a/lib/generators/sample_plugin/install_generator.rb b/lib/generators/sample_plugin/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/sample_plugin/install_generator.rb +++ b/lib/generators/sample_plugin/install_generator.rb @@ -27,10 +27,10 @@ def create_seed_file vendo...
Use genrate scaffold generator method
diff --git a/lib/netsuite/records/vendor_payment_apply_list.rb b/lib/netsuite/records/vendor_payment_apply_list.rb index abc1234..def5678 100644 --- a/lib/netsuite/records/vendor_payment_apply_list.rb +++ b/lib/netsuite/records/vendor_payment_apply_list.rb @@ -1,31 +1,11 @@ module NetSuite module Records - class ...
Refactor VendorPaymentApplyList to use Support::Sublist
diff --git a/growl-test.rb b/growl-test.rb index abc1234..def5678 100644 --- a/growl-test.rb +++ b/growl-test.rb @@ -1,7 +1,11 @@+require 'rubygems' +require 'bundler/setup' + require 'growl' -Growl.notify { - self.message = "<a href='http://www.google.com'>This is a test!</a>" - self.icon = :Safari - sticky! -} ...
Add url to growl test file; update code
diff --git a/webapp/plugins/raw_handler/raw_handler.rb b/webapp/plugins/raw_handler/raw_handler.rb index abc1234..def5678 100644 --- a/webapp/plugins/raw_handler/raw_handler.rb +++ b/webapp/plugins/raw_handler/raw_handler.rb @@ -10,4 +10,8 @@ app.headers({"Content-Type" => "text/plain"}) end + action :write do |p...
Add write action placeholder for raw handler
diff --git a/lib/hubdown/page_builder.rb b/lib/hubdown/page_builder.rb index abc1234..def5678 100644 --- a/lib/hubdown/page_builder.rb +++ b/lib/hubdown/page_builder.rb @@ -0,0 +1,53 @@+module Hubdown + class PageBuilder + + def initialize body + @body = body + end + + def get_page + page = "#{g...
Add object for creating page PageBuilder will have the responsibility of creating a full functioning page. This may mean offloading to ERB or scraping CSS links in the future
diff --git a/routes/general.rb b/routes/general.rb index abc1234..def5678 100644 --- a/routes/general.rb +++ b/routes/general.rb @@ -3,11 +3,6 @@ module Routing module General def self.registered(app) - app.head '/' do - status :ok - body "" - end - ...
Disable my weird, custom head request response
diff --git a/cognizant.gemspec b/cognizant.gemspec index abc1234..def5678 100644 --- a/cognizant.gemspec +++ b/cognizant.gemspec @@ -19,6 +19,11 @@ gem.add_development_dependency "redcarpet" gem.add_development_dependency "yard" + # cognizantd gem.add_dependency "eventmachine" gem.add_dependency "state_ma...
Add gli and formatador to dependencies.
diff --git a/Casks/cycling74-max.rb b/Casks/cycling74-max.rb index abc1234..def5678 100644 --- a/Casks/cycling74-max.rb +++ b/Casks/cycling74-max.rb @@ -4,7 +4,7 @@ url "http://filepivot.appspot.com/projects/maxmspjitter/files/Max#{version.sub('-','_').gsub('.','')}.dmg" name 'Max' - homepage 'http://cycling74....
Fix homepage to use SSL in Max Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/lib/tasks/factory_girl.rake b/lib/tasks/factory_girl.rake index abc1234..def5678 100644 --- a/lib/tasks/factory_girl.rake +++ b/lib/tasks/factory_girl.rake @@ -0,0 +1,18 @@+namespace :factory_girl do + desc "Verify that all FactoryGirl factories are valid" + task lint: :environment do + if Rails.env.t...
Add Rake task for Factory linting
diff --git a/lib/tasks/kaleidoscope.rake b/lib/tasks/kaleidoscope.rake index abc1234..def5678 100644 --- a/lib/tasks/kaleidoscope.rake +++ b/lib/tasks/kaleidoscope.rake @@ -0,0 +1,9 @@+module Kaleidoscope + module Task + def self.obtain_class + class_name = ENV['CLASS'] || ENV['class'] + raise "Must speci...
Add rake task to lib
diff --git a/EPSCommandCell.podspec b/EPSCommandCell.podspec index abc1234..def5678 100644 --- a/EPSCommandCell.podspec +++ b/EPSCommandCell.podspec @@ -22,4 +22,5 @@ s.source_files = 'Pod/Classes' s.public_header_files = 'Pod/Classes/**/*.h' + s.dependency 'ReactiveCocoa', '~> 2.3' end
Add RAC as a dependency.
diff --git a/redhead.gemspec b/redhead.gemspec index abc1234..def5678 100644 --- a/redhead.gemspec +++ b/redhead.gemspec @@ -9,7 +9,6 @@ s.files = Dir["{lib/**/*,test/**/*}"] + %w[redhead.gemspec .gemtest LICENSE Gemfile rakefile README.md] s.require_path = "lib" s.test_files = Dir["test/*"] - s.has_r...
Remove deprecated has_rdoc= from gemspec.
diff --git a/spec/node_spec.rb b/spec/node_spec.rb index abc1234..def5678 100644 --- a/spec/node_spec.rb +++ b/spec/node_spec.rb @@ -2,18 +2,21 @@ describe DripDrop::Node do describe "initialization" do - before do - @ddn = DripDrop::Node.new {} + before(:all) do + @ddn = DripDrop::Node.new { + ...
Speed up node reactor start/stop test.
diff --git a/scripts/chrome.rb b/scripts/chrome.rb index abc1234..def5678 100644 --- a/scripts/chrome.rb +++ b/scripts/chrome.rb @@ -1,6 +1,33 @@ require 'tmpdir' +require 'os' def run_chrome(language) + if OS.mac? + run_chrome_macos(language) + elsif OS.windows? + run_chrome_windows(language) + else + $...
Add ability to launch Chrome on Windows from scripts.
diff --git a/spec/adapters/spec_helper.rb b/spec/adapters/spec_helper.rb index abc1234..def5678 100644 --- a/spec/adapters/spec_helper.rb +++ b/spec/adapters/spec_helper.rb @@ -1,7 +1,7 @@ require 'rubygems' -require File.join(File.dirname(__FILE__), '../spec_config.rb') unless Object.const_defined?('Sequel') $:.un...
Load sequel_core before spec_config in the adapter specs
diff --git a/spec/models/safe_erb_spec.rb b/spec/models/safe_erb_spec.rb index abc1234..def5678 100644 --- a/spec/models/safe_erb_spec.rb +++ b/spec/models/safe_erb_spec.rb @@ -0,0 +1,20 @@+require File.dirname(__FILE__) + '/../spec_helper' + +# Verify that our safe_erb patches are working. +describe "An ERB template" ...
Add test cases verifying that SafeERB works If an upgrade to Rails breaks SafeERB, we'd like to find out.
diff --git a/test/integration/search_test.rb b/test/integration/search_test.rb index abc1234..def5678 100644 --- a/test/integration/search_test.rb +++ b/test/integration/search_test.rb @@ -0,0 +1,40 @@+require 'test_helper' + +class SearchTest < ActionDispatch::IntegrationTest + setup do + setup_groonga_database + ...
Add a test for only posts of the current site
diff --git a/lib/quotes.rb b/lib/quotes.rb index abc1234..def5678 100644 --- a/lib/quotes.rb +++ b/lib/quotes.rb @@ -1,13 +1,12 @@ require 'quotes/version' -# require all support files -require_relative 'quotes/support/validation_helpers' +require './lib/quotes/helpers/validation_helpers' -require_relative 'quotes/...
Use 'require' rather than require_relative
diff --git a/spec/lib/user_importer_spec.rb b/spec/lib/user_importer_spec.rb index abc1234..def5678 100644 --- a/spec/lib/user_importer_spec.rb +++ b/spec/lib/user_importer_spec.rb @@ -1,10 +1,10 @@ require 'rails_helper' describe 'UserImporter' do - + let(:filename) { File.join(Rails.root, "spec", "resources", "an...
Add filename & subject to let blocks in importer spec
diff --git a/spec/models/instrument_spec.rb b/spec/models/instrument_spec.rb index abc1234..def5678 100644 --- a/spec/models/instrument_spec.rb +++ b/spec/models/instrument_spec.rb @@ -2,4 +2,5 @@ describe Instrument do it { should respond_to(:questions) } + it { should respond_to(:surveys) } end
Add surveys to instrument spec
diff --git a/spec/url_referenceable_spec.rb b/spec/url_referenceable_spec.rb index abc1234..def5678 100644 --- a/spec/url_referenceable_spec.rb +++ b/spec/url_referenceable_spec.rb @@ -7,4 +7,9 @@ end describe MockUrlReferenceable do + describe '#url' do + end + + describe '#parent_url' do + end end
Add stubs for the expected methods.
diff --git a/lib/gitlab.rb b/lib/gitlab.rb index abc1234..def5678 100644 --- a/lib/gitlab.rb +++ b/lib/gitlab.rb @@ -0,0 +1,55 @@+require 'gitlab' +require 'httparty' +require 'retries' + +module Provider + # GitLab SSH public key provider + class GitLab + # @param [Hash] options GitLab credentials for Gitlab::Cli...
Add GitLab SSH key provider
diff --git a/lib/laadur.rb b/lib/laadur.rb index abc1234..def5678 100644 --- a/lib/laadur.rb +++ b/lib/laadur.rb @@ -1,33 +1,21 @@ require "laadur/version" require 'optparse' -require 'pp' module Laadur class CLI def initialize - puts 'test' - options = {} - - optparse = OptionParser.new do|opt...
Raise intelligent error on invalid argument
diff --git a/lib/resume.rb b/lib/resume.rb index abc1234..def5678 100644 --- a/lib/resume.rb +++ b/lib/resume.rb @@ -3,8 +3,7 @@ module Resume VERSION = '1.0' - # REMOTE_REPO = "https://raw.githubusercontent.com/paulfioravanti/resume/master" - REMOTE_REPO = "https://raw.githubusercontent.com/paulfioravanti/resum...
Change repo to point at master
diff --git a/extras/c12.rb b/extras/c12.rb index abc1234..def5678 100644 --- a/extras/c12.rb +++ b/extras/c12.rb @@ -0,0 +1,57 @@+require 'open3' +require 'tempfile' + +def to_c(input, regs) + prologue = [ + '#include <stdio.h>', + 'int main() {', + ] + regs.map { |k, v| + " int #{k} = #{v};" + } + + come...
Add day 12 C compiler
diff --git a/spec/factories.rb b/spec/factories.rb index abc1234..def5678 100644 --- a/spec/factories.rb +++ b/spec/factories.rb @@ -35,6 +35,7 @@ fork false homepage 'http://rubyonrails.org' github_organisation + stargazers_count 10_000 end factory :user do
Add stargazers_count to repo factory
diff --git a/spec/factories.rb b/spec/factories.rb index abc1234..def5678 100644 --- a/spec/factories.rb +++ b/spec/factories.rb @@ -1,11 +1,16 @@ FactoryGirl.define do + factory :hero do + name 'McCree' + role 'offense' + end + factory :map do - name "Dorado" - map_type "escort" + name 'Dorado' + ...
Add Hero factory for tests
diff --git a/spec/feed_spec.rb b/spec/feed_spec.rb index abc1234..def5678 100644 --- a/spec/feed_spec.rb +++ b/spec/feed_spec.rb @@ -33,7 +33,7 @@ expect(fetcher_object_id_1).to eq(fetcher_object_id_2) end - it 'raises RSSCache::Feed::FormatError on non-RSS and non-Atom feeds' do + it 'raises RSSCache::Feed:...
Make spec description a little less ambiguous
diff --git a/VENPromotionsManager.podspec b/VENPromotionsManager.podspec index abc1234..def5678 100644 --- a/VENPromotionsManager.podspec +++ b/VENPromotionsManager.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "VENPromotionsManager" - s.version = "0.2.0" + s.version = "0.2.1" s.summar...
Update podspec version to 0.2.1
diff --git a/lib/aws/xray/client.rb b/lib/aws/xray/client.rb index abc1234..def5678 100644 --- a/lib/aws/xray/client.rb +++ b/lib/aws/xray/client.rb @@ -22,7 +22,7 @@ sock = @sock || UDPSocket.new begin - len = sock.send(payload, 0, @host, @port) + len = sock.send(payload, Socket::M...
Set Socket::MSG_DONTWAIT not to be blocked I don't have problems without this flag, but it might be blocked in some cases (still I'm not sure).
diff --git a/lib/nanoc-nbconvert.rb b/lib/nanoc-nbconvert.rb index abc1234..def5678 100644 --- a/lib/nanoc-nbconvert.rb +++ b/lib/nanoc-nbconvert.rb @@ -0,0 +1,9 @@+require 'nanoc' + +module Nanoc + module Filters + autoload 'NBConvert', 'nanoc/filters/nbconvert' + + Nanoc::Filter.register '::Nanoc::Filters::NBC...
Add the missing file, bump the version to 0.1.1.-a
diff --git a/lib/pry-rescue/rack.rb b/lib/pry-rescue/rack.rb index abc1234..def5678 100644 --- a/lib/pry-rescue/rack.rb +++ b/lib/pry-rescue/rack.rb @@ -0,0 +1,10 @@+require 'pry-rescue' +class PryRescue + def initialize(app) + @app = app + end + + def call(env) + Pry::rescue{ @app.call(env) } + end +end
Add a Rack Middleware, thanks blaines http://news.ycombinator.com/item?id=4439989
diff --git a/lib/retention_magic.rb b/lib/retention_magic.rb index abc1234..def5678 100644 --- a/lib/retention_magic.rb +++ b/lib/retention_magic.rb @@ -6,6 +6,7 @@ end mattr_accessor :activation_counter_columns do [] + end mattr_accessor :retention_models do [] end
Fix error in RetentionMagic config
diff --git a/src/helpers/error_handler.rb b/src/helpers/error_handler.rb index abc1234..def5678 100644 --- a/src/helpers/error_handler.rb +++ b/src/helpers/error_handler.rb @@ -1,7 +1,7 @@ module ErrorHandler def self.registered(app) app.error 404 do - json message: 'Not Found' + json message: 'Not Fo...
Return original response body when response body already exists
diff --git a/fluffle.gemspec b/fluffle.gemspec index abc1234..def5678 100644 --- a/fluffle.gemspec +++ b/fluffle.gemspec @@ -14,14 +14,14 @@ s.required_ruby_version = '>= 2.1' - s.add_dependency 'bunny', '~> 2.6.1' - s.add_dependency 'concurrent-ruby', '~> 1.0.2' - s.add_dependency 'oj', ...
Update gemspec dependency versions to be more lenient
diff --git a/closed_issues.rb b/closed_issues.rb index abc1234..def5678 100644 --- a/closed_issues.rb +++ b/closed_issues.rb @@ -18,8 +18,8 @@ results.reject { |i| !i.pull_request? } puts "Milestone Statistics for: #{results.first.milestone.title}" -puts "NUMBER,AUTHOR,ASSIGNEE,LABELS" +puts "NUMBER,TITLE,AUTHOR,ASS...
Add Title of PR to output Need the Title of the PR to figure out what might be able to go in the changelog.
diff --git a/config/initializers/host.rb b/config/initializers/host.rb index abc1234..def5678 100644 --- a/config/initializers/host.rb +++ b/config/initializers/host.rb @@ -1,5 +1,25 @@-HOST = ENV['HOST'] || { - 'development' => 'http://localhost:3000', +development_host = if Rails.env.development? + port = ENV['PORT...
Allow HOST to be set by CANONICAL_HOST env var
diff --git a/config/initializers/rack-attack.rb b/config/initializers/rack-attack.rb index abc1234..def5678 100644 --- a/config/initializers/rack-attack.rb +++ b/config/initializers/rack-attack.rb @@ -11,7 +11,7 @@ headers = { 'X-RateLimit-Limit' => match_data[:limit].to_s, 'X-RateLimit-Remaining'...
Fix reset date format when rate limited
diff --git a/test/unit/helpers/locations_options_helper_test.rb b/test/unit/helpers/locations_options_helper_test.rb index abc1234..def5678 100644 --- a/test/unit/helpers/locations_options_helper_test.rb +++ b/test/unit/helpers/locations_options_helper_test.rb @@ -14,7 +14,7 @@ end option_set.css("option")[1...
Fix deprecation calling assert_equal nil Fix the deprecation: ``` DEPRECATED: Use assert_nil if expecting nil from test/unit/helpers/locations_options_helper_test.rb:17. This will fail in Minitest 6. ```
diff --git a/smoke_test/steps/prison_booking_cancelled.rb b/smoke_test/steps/prison_booking_cancelled.rb index abc1234..def5678 100644 --- a/smoke_test/steps/prison_booking_cancelled.rb +++ b/smoke_test/steps/prison_booking_cancelled.rb @@ -14,7 +14,7 @@ private def expected_email_subject - 'CANCELL...
Fix email expectation in smoke test Test was expecting subject with format 'CANCELLED: %s on %s' but email subject is 'CANCELLED: Visit for %s on %s'
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -1,4 +1,14 @@-require 'formaggio/capistrano' +require 'formaggio/capistrano/default_attributes' +require 'formaggio/capistrano/figs' +require 'formaggio/capistrano/config' +require 'formaggio/...
Remove formaggio tagging for production
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -2,7 +2,7 @@ # Put this before Devise during the transition so the old tests still work. devise_for :users, controllers: { registrations: :registrations } # The following should be whe...
Fix the route after login.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,5 +1,11 @@ Issuet::Application.routes.draw do - root 'home#index' - devise_for :users + devise_scope :user do + authenticated :user do + root 'home#index', as: :authenticated_r...
Change roots for authed and non-authed users
diff --git a/spec/authorization_spec.rb b/spec/authorization_spec.rb index abc1234..def5678 100644 --- a/spec/authorization_spec.rb +++ b/spec/authorization_spec.rb @@ -12,7 +12,7 @@ it 'returns the correct metadata', vcr: { cassette_name: 'authorization' } do expect(authorization.expires).to be_a(Time) - e...
Change from Time::mktime to Time::gm in test because .mktime uses the local timezone and the test fails if it runs on a machine configured with another timezone