diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/tests/spec/requests/malformed_json_spec.rb b/tests/spec/requests/malformed_json_spec.rb index abc1234..def5678 100644 --- a/tests/spec/requests/malformed_json_spec.rb +++ b/tests/spec/requests/malformed_json_spec.rb @@ -0,0 +1,44 @@+# coding: utf-8 + +require 'net/http' +require 'spec_helper' + +RSpec.feat...
Test for fundamental API deserialization errors
diff --git a/effective_datatables.gemspec b/effective_datatables.gemspec index abc1234..def5678 100644 --- a/effective_datatables.gemspec +++ b/effective_datatables.gemspec @@ -20,5 +20,5 @@ s.add_dependency 'coffee-rails' s.add_dependency 'effective_bootstrap' s.add_dependency 'effective_resources' - s.add_de...
Remove deprecated sass gem in favour of sassc https://github.com/sass/ruby-sass#ruby-sass-has-reached-end-of-life
diff --git a/tasks/docs.rake b/tasks/docs.rake index abc1234..def5678 100644 --- a/tasks/docs.rake +++ b/tasks/docs.rake @@ -14,7 +14,8 @@ FileUtils.cd(TMP_DIR) do sh("wget http://mirror.ctan.org/systems/texlive/tlnet/#{LATEX_TAR}") sh("tar xvzf #{LATEX_TAR}") - FileUtils.cd("install-tl-20130815"...
Determine path tar writes to, cd into that dir
diff --git a/spec_helper.rb b/spec_helper.rb index abc1234..def5678 100644 --- a/spec_helper.rb +++ b/spec_helper.rb @@ -1,8 +1,6 @@-Dir[ARGV[1] || 'algorithms/**/*.md'].each do |filename| - matcher = File.read(filename).match(/~~~\n(require 'rspec'\n.+?)\n~~~/m) - - next if matcher.nil? - - puts "Evaluating #{filen...
Simplify spec helper even further and use scan so that we can evaluate all snippets in a file.
diff --git a/Formula/d-bus.rb b/Formula/d-bus.rb index abc1234..def5678 100644 --- a/Formula/d-bus.rb +++ b/Formula/d-bus.rb @@ -16,7 +16,8 @@ # Fix the TMPDIR to one D-Bus doesn't reject due to odd symbols ENV["TMPDIR"] = "/tmp" system "./configure", "--prefix=#{prefix}", "--disable-xml-docs", - ...
Build D-Bus without X dependency.
diff --git a/app/models/offsite_link.rb b/app/models/offsite_link.rb index abc1234..def5678 100644 --- a/app/models/offsite_link.rb +++ b/app/models/offsite_link.rb @@ -1,6 +1,6 @@ class OffsiteLink < ActiveRecord::Base belongs_to :parent, polymorphic: true - validates :title, :summary, :link_type, :url, presence: ...
Validate the length of fields in Offsite Links Rather than letting the database raise an error (now that we have a MySQL version which doesn't silently truncate), let's validate it in the model and show the user a helpful validation message, not a 5xx error page.
diff --git a/atomic.gemspec b/atomic.gemspec index abc1234..def5678 100644 --- a/atomic.gemspec +++ b/atomic.gemspec @@ -7,10 +7,15 @@ s.date = Time.now.strftime('%Y-%m-%d') s.description = "An atomic reference implementation for JRuby and green or GIL-threaded impls" s.email = ["headius@headius.com", "mental@r...
Split gem into -java and normal versions, so JRuby doesn't attempt to build native ext it will never use.
diff --git a/spec/cucumber/formatter/backtrace_filter_spec.rb b/spec/cucumber/formatter/backtrace_filter_spec.rb index abc1234..def5678 100644 --- a/spec/cucumber/formatter/backtrace_filter_spec.rb +++ b/spec/cucumber/formatter/backtrace_filter_spec.rb @@ -0,0 +1,32 @@+require 'cucumber/formatter/backtrace_filter' + +m...
Add unit tests for backtrace_filter
diff --git a/test/enum_field_test.rb b/test/enum_field_test.rb index abc1234..def5678 100644 --- a/test/enum_field_test.rb +++ b/test/enum_field_test.rb @@ -27,12 +27,10 @@ model.stubs(:gender).returns("male") assert model.male? + assert !model.female? model.stubs(:gender).returns("fema...
Remove unnecessary operations from one of the tests
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -2,7 +2,7 @@ Bundler.require assets { - js :application, ['/js/generic.js', '/js/rainbow.min.js', '/js/shell.js'] + js :application, ['/js/rainbow.min.js', '/js/generic.js', '/js/shell.js'] css :application, ['/css/github.cs...
Fix order of js includes
diff --git a/lib/docs/scrapers/phpunit.rb b/lib/docs/scrapers/phpunit.rb index abc1234..def5678 100644 --- a/lib/docs/scrapers/phpunit.rb +++ b/lib/docs/scrapers/phpunit.rb @@ -24,7 +24,7 @@ HTML version '5' do - self.release = '5.5' + self.release = '5.7' self.base_url = "https://phpunit.de...
Update PHPUnit documentation (5.7, 4.8)
diff --git a/test/middleware_test.rb b/test/middleware_test.rb index abc1234..def5678 100644 --- a/test/middleware_test.rb +++ b/test/middleware_test.rb @@ -19,7 +19,7 @@ def test_middleware_processor response = build_stack("flex.css").get("/javascripts/src/test.js") - assert response.body.include?("-...
Update test as -webkit-flex is no longer prefixed
diff --git a/lib/restforce/db/registry.rb b/lib/restforce/db/registry.rb index abc1234..def5678 100644 --- a/lib/restforce/db/registry.rb +++ b/lib/restforce/db/registry.rb @@ -6,56 +6,51 @@ # established in the system. class Registry - class << self + extend Enumerable - include Enumerabl...
Use more explicit Registry self.method definitions
diff --git a/lib/usesthis/api/endpoint.rb b/lib/usesthis/api/endpoint.rb index abc1234..def5678 100644 --- a/lib/usesthis/api/endpoint.rb +++ b/lib/usesthis/api/endpoint.rb @@ -4,6 +4,10 @@ module Api # A class that models a static API endpoint. class Endpoint + def self.publish(output_path, items, typ...
Add the publish class method
diff --git a/lib/generators/clearance/install/templates/db/migrate/add_clearance_to_users.rb b/lib/generators/clearance/install/templates/db/migrate/add_clearance_to_users.rb index abc1234..def5678 100644 --- a/lib/generators/clearance/install/templates/db/migrate/add_clearance_to_users.rb +++ b/lib/generators/clearanc...
Make generated code follow the current style guide Since these migrations are generated, we want them to follow the current style guide. So when opening a PR, there will be no violations reported from [Hound]. [Hound]: https://houndci.com
diff --git a/test/test_collection.rb b/test/test_collection.rb index abc1234..def5678 100644 --- a/test/test_collection.rb +++ b/test/test_collection.rb @@ -18,7 +18,7 @@ assert_equal 10, Collection.new(10).results end - def test_collection_assigns_results + def test_collection_assigns_start assert_equa...
Fix typo in test name.
diff --git a/spec/features/order/order_order_items_spec.rb b/spec/features/order/order_order_items_spec.rb index abc1234..def5678 100644 --- a/spec/features/order/order_order_items_spec.rb +++ b/spec/features/order/order_order_items_spec.rb @@ -30,6 +30,28 @@ end + feature '注文の修正' do + scenario '注文者は自分の注文を修正で...
Add test for edit order
diff --git a/spec/omniauth/strategies/digitalocean_spec.rb b/spec/omniauth/strategies/digitalocean_spec.rb index abc1234..def5678 100644 --- a/spec/omniauth/strategies/digitalocean_spec.rb +++ b/spec/omniauth/strategies/digitalocean_spec.rb @@ -1,8 +1,8 @@ require 'spec_helper' -describe OmniAuth::Strategies::Digital...
Fix class name in spec to match existing class.
diff --git a/spec/features/show_game_pairings_spec.rb b/spec/features/show_game_pairings_spec.rb index abc1234..def5678 100644 --- a/spec/features/show_game_pairings_spec.rb +++ b/spec/features/show_game_pairings_spec.rb @@ -8,7 +8,7 @@ let!(:game_one) { create(:game_appointment, round: round) } let!(:game_...
Update show game pairings feature test
diff --git a/spec/models/events/deck_shuffled_spec.rb b/spec/models/events/deck_shuffled_spec.rb index abc1234..def5678 100644 --- a/spec/models/events/deck_shuffled_spec.rb +++ b/spec/models/events/deck_shuffled_spec.rb @@ -12,6 +12,10 @@ expect(event.state_attribute).to be nil end + it "should have no...
Add test case for bare DeckShuffled object
diff --git a/app/controllers/sitemap_controller.rb b/app/controllers/sitemap_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sitemap_controller.rb +++ b/app/controllers/sitemap_controller.rb @@ -3,6 +3,7 @@ def index @static_pages = static_pages @courses = Course.all + respond_to ...
Add a newline between the respond_to block and the instance variables
diff --git a/app/controllers/sitemap_controller.rb b/app/controllers/sitemap_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sitemap_controller.rb +++ b/app/controllers/sitemap_controller.rb @@ -1,5 +1,5 @@ class SitemapController < ApplicationController def index - @articles = ContentService.ne...
fix: Use the signleton contenful service insteado f instansiating a new one.
diff --git a/app/controllers/welcome_controller.rb b/app/controllers/welcome_controller.rb index abc1234..def5678 100644 --- a/app/controllers/welcome_controller.rb +++ b/app/controllers/welcome_controller.rb @@ -1,6 +1,6 @@ class WelcomeController < ApplicationController - caches_action :index, expires_in: 1.minute...
Remove time from caching-wasn't working
diff --git a/OmniBase.podspec b/OmniBase.podspec index abc1234..def5678 100644 --- a/OmniBase.podspec +++ b/OmniBase.podspec @@ -3,7 +3,7 @@ s.version = "0.1.0" s.summary = "The core Omni open source framework." s.homepage = "https://github.com/wjk/OmniBase" - s.license = { :...
Update license reference in podspec
diff --git a/app/models/spree/variant_decorator.rb b/app/models/spree/variant_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/variant_decorator.rb +++ b/app/models/spree/variant_decorator.rb @@ -1,9 +1,4 @@ Spree::Variant.class_eval do has_many :variant_images, -> { order(:position) }, class_name: ...
Clean up variant images association The "has_many :images" was broken since it didn't specify the class name, and I couldn't figure out why these were defined this way anyway. Consolidating "images_for_variant" and "images" into a single normal association. Will make stuff like preloading easier to work with.
diff --git a/app/representers/event_representer.rb b/app/representers/event_representer.rb index abc1234..def5678 100644 --- a/app/representers/event_representer.rb +++ b/app/representers/event_representer.rb @@ -20,7 +20,7 @@ property :room, getter: -> (args) { room.to_s } collection :teacher_ids, as: :teache...
Rename applied_schedule_exceptions link to applied_exceptions.
diff --git a/Casks/dwarf-fortress.rb b/Casks/dwarf-fortress.rb index abc1234..def5678 100644 --- a/Casks/dwarf-fortress.rb +++ b/Casks/dwarf-fortress.rb @@ -1,10 +1,9 @@ class DwarfFortress < Cask - version '0.40.01' - sha256 'c4f729f094790671b1fde995c02c5d547d652d87790785b13a6cdc9f35dec6be' + version '0.40.12' + s...
Update Dwarf Fortress to 0.40.12
diff --git a/lib/carto/db/migration_helper.rb b/lib/carto/db/migration_helper.rb index abc1234..def5678 100644 --- a/lib/carto/db/migration_helper.rb +++ b/lib/carto/db/migration_helper.rb @@ -39,6 +39,7 @@ run 'ROLLBACK TO SAVEPOINT before_migration' sleep WAIT_BETWEEN_RETRIES_S ...
Add extra error information to migration helper
diff --git a/lib/minty/objects/transaction.rb b/lib/minty/objects/transaction.rb index abc1234..def5678 100644 --- a/lib/minty/objects/transaction.rb +++ b/lib/minty/objects/transaction.rb @@ -32,8 +32,10 @@ @row["Labels"] end + DATE_FORMAT = '%m/%d/%Y' + def date - @row["Date"] + ...
Convert date string to Date object
diff --git a/lib/user_agent/browsers/gecko.rb b/lib/user_agent/browsers/gecko.rb index abc1234..def5678 100644 --- a/lib/user_agent/browsers/gecko.rb +++ b/lib/user_agent/browsers/gecko.rb @@ -24,7 +24,7 @@ def platform if comment = application.comment - if comment[0] == 'compatible' + ...
Fix a couple issues parsing Gecko user agents.
diff --git a/app/models/concerns/taggable.rb b/app/models/concerns/taggable.rb index abc1234..def5678 100644 --- a/app/models/concerns/taggable.rb +++ b/app/models/concerns/taggable.rb @@ -22,7 +22,7 @@ after_save :save_tags def tag_list - tags.map(&:name) + TagList.new tags.map(&:name) end ...
Use TagList class to tag_list method
diff --git a/application.rb b/application.rb index abc1234..def5678 100644 --- a/application.rb +++ b/application.rb @@ -14,7 +14,7 @@ haml :root end post '/' do - if redis.sismember("EMAIL", params[:username]) + if redis.sismember("EMAIL", params[:email]) haml :bad else haml :good
Change tired code to be broke not
diff --git a/spec/bundler/fetcher/compact_index_spec.rb b/spec/bundler/fetcher/compact_index_spec.rb index abc1234..def5678 100644 --- a/spec/bundler/fetcher/compact_index_spec.rb +++ b/spec/bundler/fetcher/compact_index_spec.rb @@ -4,7 +4,7 @@ describe Bundler::Fetcher::CompactIndex do let(:downloader) { double(:d...
Fix issue with older versions of Ruby and URI.
diff --git a/spec/classes/elasticsearch_package_spec.rb b/spec/classes/elasticsearch_package_spec.rb index abc1234..def5678 100644 --- a/spec/classes/elasticsearch_package_spec.rb +++ b/spec/classes/elasticsearch_package_spec.rb @@ -6,6 +6,6 @@ it do should contain_homebrew__formula("elasticsearch") - shoul...
Fix failling spec due to the elasticsearch formula update
diff --git a/spec/unit/sequel/plugins/auditable_spec.rb b/spec/unit/sequel/plugins/auditable_spec.rb index abc1234..def5678 100644 --- a/spec/unit/sequel/plugins/auditable_spec.rb +++ b/spec/unit/sequel/plugins/auditable_spec.rb @@ -0,0 +1,21 @@+require "rails_helper" + +describe "Auditable sequel plugin" do + let(:mo...
Add spec for the auditable plugin
diff --git a/lesson9/hit_the_road_jack.rb b/lesson9/hit_the_road_jack.rb index abc1234..def5678 100644 --- a/lesson9/hit_the_road_jack.rb +++ b/lesson9/hit_the_road_jack.rb @@ -0,0 +1,22 @@+# Lesson 9 - More Chords: D, E, A and B Flat +# Rhythm - Left Note/Right Chord (Hit the Road, Jack) +use_synth :piano + +play :D3 ...
Add first song from Lesson 9
diff --git a/comrad.gemspec b/comrad.gemspec index abc1234..def5678 100644 --- a/comrad.gemspec +++ b/comrad.gemspec @@ -18,8 +18,8 @@ s.add_development_dependency 'rubocop', '~> 0.30.0' s.files = `git ls-files -z`.split("\x0") - s.executables = s.files.grep(%r{^bin/}) { |f| File.basename(f) } + s.ex...
Simplify determining the executable and get the name for docs right
diff --git a/polymorphic_identity.gemspec b/polymorphic_identity.gemspec index abc1234..def5678 100644 --- a/polymorphic_identity.gemspec +++ b/polymorphic_identity.gemspec @@ -14,4 +14,7 @@ s.test_files = `git ls-files -- test/*`.split("\n") s.rdoc_options = %w(--line-numbers --inline-source --title p...
Add missing dependencies to gemspec
diff --git a/lib/pig_latin.rb b/lib/pig_latin.rb index abc1234..def5678 100644 --- a/lib/pig_latin.rb +++ b/lib/pig_latin.rb @@ -3,17 +3,17 @@ module PigLatin # Your code goes here... def self.cut_front(word) - if /\A[aeiou]/.match(word) != nil + if /\A[aeiou]/i.match(word) != nil return "w" - els...
Change code so it is case insensitive
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -24,4 +24,10 @@ render status: :unauthorized, text: "You are not authorised to access ...
Add set_flash_message(type) for automatic translation of flash messages. Based on: https://github.com/rails/rails/issues/473
diff --git a/lib/embulk/guess/jsonpath.rb b/lib/embulk/guess/jsonpath.rb index abc1234..def5678 100644 --- a/lib/embulk/guess/jsonpath.rb +++ b/lib/embulk/guess/jsonpath.rb @@ -11,8 +11,8 @@ json_path = parser_config.param("root",:string,default: "$") json = JsonPath.new(json_path).on(sample_text).firs...
Check all data in Array. Change message
diff --git a/lib/growl-transfer/gt_scp.rb b/lib/growl-transfer/gt_scp.rb index abc1234..def5678 100644 --- a/lib/growl-transfer/gt_scp.rb +++ b/lib/growl-transfer/gt_scp.rb @@ -8,7 +8,7 @@ @output.puts "Downloading #{remote}" params = remote.split(":") file = params.last.split("/").last ...
Use current UNIX user, incase your name isn't Clint
diff --git a/lib/hatokura/fairy_garden.rb b/lib/hatokura/fairy_garden.rb index abc1234..def5678 100644 --- a/lib/hatokura/fairy_garden.rb +++ b/lib/hatokura/fairy_garden.rb @@ -9,6 +9,7 @@ Cost = 1 Link = 1 MainType = :land + Rarity = :basic AuthorityPoint = -2 PlayedAbility = Pro...
Add missing rarity for each card
diff --git a/lib/mrT/git_branch_select.rb b/lib/mrT/git_branch_select.rb index abc1234..def5678 100644 --- a/lib/mrT/git_branch_select.rb +++ b/lib/mrT/git_branch_select.rb @@ -16,8 +16,8 @@ if `git status --porcelain | wc -l`.chomp.to_i == 0 Kernel.exec 'git', 'checkout', action.target else - ...
Use puts instead of system echo
diff --git a/lib/resque/heroku-signals.rb b/lib/resque/heroku-signals.rb index abc1234..def5678 100644 --- a/lib/resque/heroku-signals.rb +++ b/lib/resque/heroku-signals.rb @@ -6,16 +6,16 @@ def unregister_signal_handlers trap('TERM') do trap('TERM') do - puts "[resque-heroku] received second term ...
Use logger instead of puts
diff --git a/lib/ripl/commands/history.rb b/lib/ripl/commands/history.rb index abc1234..def5678 100644 --- a/lib/ripl/commands/history.rb +++ b/lib/ripl/commands/history.rb @@ -25,7 +25,7 @@ else '' end - file = Tempfile.new('edit_string').path + file = Tempfile.new('ripl-editor').path ...
Change tempfile name to ripl-editor.
diff --git a/test/precompile_test.rb b/test/precompile_test.rb index abc1234..def5678 100644 --- a/test/precompile_test.rb +++ b/test/precompile_test.rb @@ -28,7 +28,7 @@ contents = File.read(application_js_path) - assert_match %r{Ember\.VERSION}, contents, 'application.js should contain Ember.VERSION' + ...
Fix test to match `Ember.VERSION`
diff --git a/config/initializers/messenger.rb b/config/initializers/messenger.rb index abc1234..def5678 100644 --- a/config/initializers/messenger.rb +++ b/config/initializers/messenger.rb @@ -1,6 +1,6 @@ require 'messenger' -unless File.basename($0) == 'rake' || Rails.env.test? +unless Rails.env.test? host = Rail...
Connect Stomp client when running rake tasks
diff --git a/config/initializers/rabl_init.rb b/config/initializers/rabl_init.rb index abc1234..def5678 100644 --- a/config/initializers/rabl_init.rb +++ b/config/initializers/rabl_init.rb @@ -1,4 +1,5 @@ Rabl.configure do |config| + config.json_engine = Oj config.cache_all_output = false config.cache_sou...
Make sure Rabl is using Oj
diff --git a/16_aunt_sue.rb b/16_aunt_sue.rb index abc1234..def5678 100644 --- a/16_aunt_sue.rb +++ b/16_aunt_sue.rb @@ -0,0 +1,28 @@+DESIRES = { + children: [3, :==.to_proc], + cats: [7, :>.to_proc], + samoyeds: [2, :==.to_proc], + pomeranians: [3, :<.to_proc], + akitas: [0, :==.to_proc], + vizslas: [0, :==.to_p...
Add day 16: Aunt Sue
diff --git a/lib/tasks/courses_wikis.rake b/lib/tasks/courses_wikis.rake index abc1234..def5678 100644 --- a/lib/tasks/courses_wikis.rake +++ b/lib/tasks/courses_wikis.rake @@ -4,10 +4,12 @@ desc 'Creates CoursesWikis association for existing courses through revisions' task migrate: :environment do Rails.logg...
Update CoursesWikis data migration task to use Assignments This matches the way we previously imported revisions for courses; the wiki_ids feature was an edge case that didn't reflect the intention.
diff --git a/lib/tasks/pull_requests.rake b/lib/tasks/pull_requests.rake index abc1234..def5678 100644 --- a/lib/tasks/pull_requests.rake +++ b/lib/tasks/pull_requests.rake @@ -1,6 +1,17 @@ desc "Download new pull requests" task :download_pull_requests => :environment do + + def load_user + u = User.order('created...
Use a random users token for downloading pull requests Avoids the case of expired tokens
diff --git a/cookbooks/php/recipes/default.rb b/cookbooks/php/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/php/recipes/default.rb +++ b/cookbooks/php/recipes/default.rb @@ -17,4 +17,7 @@ # limitations under the License. # -package "php" +package %W[ + php + php#{node[:php][:version]}-fpm +]
Install php-fpm whenever we install php This stops apt (un)helpfully installing and activating mod_php for us.
diff --git a/ruby_hue.gemspec b/ruby_hue.gemspec index abc1234..def5678 100644 --- a/ruby_hue.gemspec +++ b/ruby_hue.gemspec @@ -19,6 +19,9 @@ gem.add_development_dependency "rspec", "~> 2.13.0" gem.add_development_dependency "awesome_print", "~> 1.1.0" + gem.add_development_dependency "webmock", "~> 1.11.0" + ...
Add webmock, typhoeus, and multi_json to gemspec.
diff --git a/railitics.gemspec b/railitics.gemspec index abc1234..def5678 100644 --- a/railitics.gemspec +++ b/railitics.gemspec @@ -17,9 +17,10 @@ s.test_files = Dir["test/**/*"] s.add_dependency "rails", "~> 3.2.3" + s.add_dependency 'mongoid' # s.add_dependency "jquery-rails" s.add_development_depend...
Move mongoid to normal dependancy
diff --git a/recipes/_idmap.rb b/recipes/_idmap.rb index abc1234..def5678 100644 --- a/recipes/_idmap.rb +++ b/recipes/_idmap.rb @@ -19,8 +19,6 @@ include_recipe 'nfs::_common' -package 'nfs-kernel-server' if node['platform_family'] == 'debian' - # Configure idmap template for NFSv4 client/server support template...
Remove installation of nfs-kernel-server for debian the idmap recipe on debian does not require nfs-kernel-server to be installed for functionality. see #43
diff --git a/cookbooks/wt_streamingcollection/recipes/default.rb b/cookbooks/wt_streamingcollection/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/wt_streamingcollection/recipes/default.rb +++ b/cookbooks/wt_streamingcollection/recipes/default.rb @@ -57,5 +57,6 @@ execute "delete_install_source" do ...
Fix the execute resource in streamingcollection Former-commit-id: 754a691b7d70942367421fda3f49828c95143d8c [formerly 9b59ab7efbf5713065e233c29a79bf1cc44f02ff] [formerly d41ec10e314aaa2d9434ff7678b697c9cf4a4b4b [formerly 99e096defa786188fcc445f38b2cd9dfd30a211b [formerly 0e5ed870a45f6982a2c9d137d59365909cb56cb1]]] For...
diff --git a/app/models/rule.rb b/app/models/rule.rb index abc1234..def5678 100644 --- a/app/models/rule.rb +++ b/app/models/rule.rb @@ -22,10 +22,10 @@ end def self.rule_type_values(key) - constants = [] + values = [] Rules.each do |rule| - constants << Settings.rule_types.send(rule).send(key) +...
Update array name to more accurately reflect updated purpose of storing any general value
diff --git a/app/controllers/projects/refs_controller.rb b/app/controllers/projects/refs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/projects/refs_controller.rb +++ b/app/controllers/projects/refs_controller.rb @@ -37,7 +37,7 @@ 0 end - @limit = 10 + @limit = 25 ...
Increase commit log amount for tree view from 10 to 25 Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/app/controllers/subscriptions_controller.rb b/app/controllers/subscriptions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/subscriptions_controller.rb +++ b/app/controllers/subscriptions_controller.rb @@ -1,12 +1,6 @@ class SubscriptionsController < ApplicationController - before_action...
Remove destructive and enumerative methods from the subscriptions controller, scope show to current_user
diff --git a/app/controllers/user_sessions_controller.rb b/app/controllers/user_sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/user_sessions_controller.rb +++ b/app/controllers/user_sessions_controller.rb @@ -7,8 +7,11 @@ @user = current_user if @user = login(params[:email], params...
Fix Last Vote Item Being Nil When User Not Log In
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -11,7 +11,7 @@ def find_for_github_oauth(user_hash) user_details = user_data_from_github_data(user_hash) - if user = User.find_by_github_id(user_details['uid']) + ...
Revert "a small typo => 500 error" This reverts commit 60a80d41ff88850333f29026b7310c7219a0bc5f.
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,6 +1,5 @@ class User < ActiveRecord::Base - # Include default devise modules. Others available are: - # :confirmable, :lockable, :timeoutable and :omniauthable + validates_presen...
Add validation for email and password
diff --git a/app/routes/root.rb b/app/routes/root.rb index abc1234..def5678 100644 --- a/app/routes/root.rb +++ b/app/routes/root.rb @@ -5,7 +5,7 @@ end post '/' do - link = Link.find_or_create_by(url: params[:url]) + Link.find_or_create_by(url: params[:url]) redirect to('/') end
Remove unnecessary variable from POST / action
diff --git a/config/software/chef-gem.rb b/config/software/chef-gem.rb index abc1234..def5678 100644 --- a/config/software/chef-gem.rb +++ b/config/software/chef-gem.rb @@ -17,7 +17,7 @@ name 'chef-gem' # The version here should be in agreement with /Gemfile.lock so that our rspec # testing stays consistent with the ...
Apply 1 suggestion(s) to 1 file(s)
diff --git a/app/helpers/forest_errors_helper.rb b/app/helpers/forest_errors_helper.rb index abc1234..def5678 100644 --- a/app/helpers/forest_errors_helper.rb +++ b/app/helpers/forest_errors_helper.rb @@ -1,7 +1,7 @@ module ForestErrorsHelper # Display errors that are only visible to admin users def forest_admin_...
Fix forest error logic from testing
diff --git a/app/models/spree/order_decorator.rb b/app/models/spree/order_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/order_decorator.rb +++ b/app/models/spree/order_decorator.rb @@ -8,8 +8,6 @@ ensure_valid_shipments orig_process_payments! end - - private def ensur...
Make order shipment validation a public method
diff --git a/app/models/time_based_repo_rater.rb b/app/models/time_based_repo_rater.rb index abc1234..def5678 100644 --- a/app/models/time_based_repo_rater.rb +++ b/app/models/time_based_repo_rater.rb @@ -1,4 +1,5 @@ require "date" +require_relative "repo_rater" module HazCommitz class TimeBasedRepoRater < Repo...
Add require for super class
diff --git a/app/views/funded_projects/index.xml.builder b/app/views/funded_projects/index.xml.builder index abc1234..def5678 100644 --- a/app/views/funded_projects/index.xml.builder +++ b/app/views/funded_projects/index.xml.builder @@ -7,7 +7,7 @@ entry.title "#{project.chapter.name} – #{project.title}" e...
Revert 601dfd93f230 (which removed images from atom feed if a project had no image) While technically correct, we use some external services that rely on an image enclosure to be in place, so just for consistency, we'll always include an image, even if it's the placeholder.
diff --git a/ruby/import_js.rb b/ruby/import_js.rb index abc1234..def5678 100644 --- a/ruby/import_js.rb +++ b/ruby/import_js.rb @@ -8,13 +8,3 @@ require_relative 'import_js/importer' require_relative 'import_js/vim_editor' require_relative 'import_js/configuration' - -# @deprecated we've moved to JSON configuration,...
Remove warning about deprecated .importjs This deprecation has been there long enough to serve its purpose. I'm cleaning it out to stay lean.
diff --git a/db/migrate/20140117051315_rename_payment_methods.rb b/db/migrate/20140117051315_rename_payment_methods.rb index abc1234..def5678 100644 --- a/db/migrate/20140117051315_rename_payment_methods.rb +++ b/db/migrate/20140117051315_rename_payment_methods.rb @@ -0,0 +1,13 @@+class RenamePaymentMethods < ActiveRec...
Fix an issue with old payment methods from the original paypal extension. Signed-off-by: Nathan Lowrie <nate@finelineautomation.com> Fixes #58
diff --git a/automobile.gemspec b/automobile.gemspec index abc1234..def5678 100644 --- a/automobile.gemspec +++ b/automobile.gemspec @@ -21,5 +21,5 @@ s.add_runtime_dependency 'earth', '~>1.0.0' s.add_runtime_dependency 'emitter', '~>0.12.0' - s.add_development_dependency 'sniff', '~>1.0.0' + s.add_dev...
Update sniff dependency to 1.x
diff --git a/app/controllers/wor/elfinder_controller.rb b/app/controllers/wor/elfinder_controller.rb index abc1234..def5678 100644 --- a/app/controllers/wor/elfinder_controller.rb +++ b/app/controllers/wor/elfinder_controller.rb @@ -17,14 +17,17 @@ 'application/zip' => ['unzip', '-qq', '-o'], 'applicat...
Fix elfinder error on rails5
diff --git a/scripts/config.ru b/scripts/config.ru index abc1234..def5678 100644 --- a/scripts/config.ru +++ b/scripts/config.ru @@ -1,5 +1,5 @@ # Required so that we can set path correctly for Config, which is loaded statically due to a bug in cijoe -$project_path = File.dirname(__FILE__) + '/app' +$project_path = Fil...
Expand the path so we're always in correct dir
diff --git a/config/software/ctl-man.rb b/config/software/ctl-man.rb index abc1234..def5678 100644 --- a/config/software/ctl-man.rb +++ b/config/software/ctl-man.rb @@ -16,7 +16,7 @@ # name "ctl-man" -default_version "0.1.0" +default_version "master" dependency "private-chef-ctl"
Fix version in chef-server-ctl manpage software definition
diff --git a/benchmark/instance_counter_performance.rb b/benchmark/instance_counter_performance.rb index abc1234..def5678 100644 --- a/benchmark/instance_counter_performance.rb +++ b/benchmark/instance_counter_performance.rb @@ -0,0 +1,39 @@+#!/usr/bin/env ruby + +require 'benchmark' +require 'active_record' +require '...
Add benchmark for allocating 40k objects with + without oink: user system total real 40,000 empty iterations 0.000000 0.000000 0.000000 ( 0.002370) without instance type counter - instantiating 40,000 objects 0.910000 0.020000 0.930000 ( 0.922722) with instance type cou...
diff --git a/benchmarks/output_stringio_vs_tempfile.rb b/benchmarks/output_stringio_vs_tempfile.rb index abc1234..def5678 100644 --- a/benchmarks/output_stringio_vs_tempfile.rb +++ b/benchmarks/output_stringio_vs_tempfile.rb @@ -0,0 +1,31 @@+require 'rubygems' +require 'bundler/setup' +require 'benchmark' +require 'rsp...
Add benchmarks around `to_std(out|err)_from_any_process` matchers
diff --git a/business.gemspec b/business.gemspec index abc1234..def5678 100644 --- a/business.gemspec +++ b/business.gemspec @@ -20,7 +20,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_development_dependency "gc_ruboconfig", "~> 2.33.0" + spec.add_...
Update gc_ruboconfig requirement from ~> 2.33.0 to ~> 3.0.1 Updates the requirements on [gc_ruboconfig](https://github.com/gocardless/ruboconfig) to permit the latest version. - [Release notes](https://github.com/gocardless/ruboconfig/releases) - [Changelog](https://github.com/gocardless/gc_ruboconfig/blob/master/CHAN...
diff --git a/db/migrate/20091123062515_set_poll_and_vote_types.rb b/db/migrate/20091123062515_set_poll_and_vote_types.rb index abc1234..def5678 100644 --- a/db/migrate/20091123062515_set_poll_and_vote_types.rb +++ b/db/migrate/20091123062515_set_poll_and_vote_types.rb @@ -1,39 +1,41 @@ class SetPollAndVoteTypes < Activ...
Use pure sql to migrate poll and vote types
diff --git a/week-6/gps.rb b/week-6/gps.rb index abc1234..def5678 100644 --- a/week-6/gps.rb +++ b/week-6/gps.rb @@ -0,0 +1,42 @@+# Your Names +# 1) +# 2) + +# We spent [#] hours on this challenge. + +# Bakery Serving Size portion calculator. + +def serving_size_calc(item_to_make, order_quantity) + library = {"cookie"...
Add blank file for GPS
diff --git a/app/helpers/sandbox_helper.rb b/app/helpers/sandbox_helper.rb index abc1234..def5678 100644 --- a/app/helpers/sandbox_helper.rb +++ b/app/helpers/sandbox_helper.rb @@ -3,7 +3,7 @@ content_tag(:div, nil, class: 'download-and-submit') do content_tag(:div, nil, class: 'download-report') do ...
Add download functionality to download link in errors page
diff --git a/app/mailers/contact_mailer.rb b/app/mailers/contact_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/contact_mailer.rb +++ b/app/mailers/contact_mailer.rb @@ -23,11 +23,10 @@ mail(subject: @message.subject, bcc: @emails) end - def payment_reminder(message, emails, event) + def payment_r...
Fix to be `to` instead of `bcc`
diff --git a/app/models/split_time_data.rb b/app/models/split_time_data.rb index abc1234..def5678 100644 --- a/app/models/split_time_data.rb +++ b/app/models/split_time_data.rb @@ -4,16 +4,16 @@ # The time zone parsing methods in Rails are slow and create an unacceptable delay # when working with many objects, particu...
Improve docs in SplitTimeData model
diff --git a/feeds/stock.rb b/feeds/stock.rb index abc1234..def5678 100644 --- a/feeds/stock.rb +++ b/feeds/stock.rb @@ -1,3 +1,5 @@+app.feed(:silent, desc: "don't show anything") { false } + app.feed(:hidden, desc: "include hidden") { $rec.hidden? } app.feed(:visible, desc: "exclude hidden") { !$rec.hidden? || app.o...
Add silent feed (for benchmark)
diff --git a/test/test_zip_tuples.rb b/test/test_zip_tuples.rb index abc1234..def5678 100644 --- a/test/test_zip_tuples.rb +++ b/test/test_zip_tuples.rb @@ -0,0 +1,25 @@+# -*- encoding : utf-8 -*- +require File.expand_path(File.dirname(__FILE__)) + '/helper' + +class ZipTuplesTest < Test::Unit::TestCase + include Trac...
Add a test for tuple zipper
diff --git a/Opus-ios.podspec b/Opus-ios.podspec index abc1234..def5678 100644 --- a/Opus-ios.podspec +++ b/Opus-ios.podspec @@ -1,5 +1,5 @@ Pod::Spec.new do |s| - s.name = "Opus-iOS" + s.name = "Opus-ios" s.version = "1.0" s.summary = "iOS build scripts for the Opus Codec." s.homep...
Fix spec name in podspec.
diff --git a/git-hooks/dont-commit-github-token.rb b/git-hooks/dont-commit-github-token.rb index abc1234..def5678 100644 --- a/git-hooks/dont-commit-github-token.rb +++ b/git-hooks/dont-commit-github-token.rb @@ -1,4 +1,5 @@ #!/usr/bin/ruby +# pre-commit hook gitconfig = File.expand_path("./gitconfig")
Add a note which hook is meant for the git-hook
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -13,7 +13,6 @@ map.resources :users map.resources :home, :collection => {:mock_set => :get} map.claim '/claim', :controller => :claim - map.connect '/intro', :controller => :intro ...
Remove reference to unused controller.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -9,9 +9,11 @@ namespace :api, defaults: { format: 'json' } do resources :patients, only: [] do resources :consultations, only: [:index] do - post 'previous', on: :collecti...
Use collection as a block
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -5,7 +5,7 @@ get '/logout', :to => 'auth#logout', :as => :logout get '/loginerror', :to => 'auth#unauthenticated' get '/auth/federation', :to => 'auth#federation_login' - get ...
Fix routing for /auth/development which should have been POST
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -6,10 +6,12 @@ get '/login', to: 'sessions#new', as: :login get '/logout', to: 'sessions#destroy', as: :logout - resources :timeslots, only: [:update, :show, :destroy] + resources...
Move destroy route to api timeslots controller
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,4 +1,5 @@ Rails.application.routes.draw do + root "sessions#new" resources :users, except: :index resources :videos resources :descriptions, except: :index
Set login as root page
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -47,8 +47,8 @@ # Make sure this routeset is defined last namespace :api, path: '/' do - get '/(*locale)/categories(.:format)' => 'category_contents#index' - get '/(*locale)/catego...
Remove wildcard matcher on category path
diff --git a/plugins/simple_tracker/lib/db.rb b/plugins/simple_tracker/lib/db.rb index abc1234..def5678 100644 --- a/plugins/simple_tracker/lib/db.rb +++ b/plugins/simple_tracker/lib/db.rb @@ -12,6 +12,31 @@ Jetpants.topology.tracker.spares = spares Jetpants.topology.update_tracker_data + end + + d...
Implement cleanup_spare! in the simple_tracker plugin
diff --git a/jekyll-sitemap.gemspec b/jekyll-sitemap.gemspec index abc1234..def5678 100644 --- a/jekyll-sitemap.gemspec +++ b/jekyll-sitemap.gemspec @@ -1,16 +1,21 @@-Gem::Specification.new do |s| - s.name = "jekyll-sitemap" - s.summary = "Automatically generate a sitemap.xml for your Jekyll site." s.ve...
Bring the spec into the 21st century
diff --git a/lib/bitcoin/network/peer_discovery.rb b/lib/bitcoin/network/peer_discovery.rb index abc1234..def5678 100644 --- a/lib/bitcoin/network/peer_discovery.rb +++ b/lib/bitcoin/network/peer_discovery.rb @@ -24,8 +24,9 @@ Socket.getaddrinfo(seed, Bitcoin.chain_params.default_port).map{|a|a[2]}.uniq ...
Fix a bug that contains an incorrect IP when an error occurs when searching seeds
diff --git a/lib/bodogem/slack_interface/client.rb b/lib/bodogem/slack_interface/client.rb index abc1234..def5678 100644 --- a/lib/bodogem/slack_interface/client.rb +++ b/lib/bodogem/slack_interface/client.rb @@ -8,13 +8,13 @@ def initialize(channel_name) @client = Bodogem::SlackInterface::Client.connect...
Set null to default router
diff --git a/lib/builderator/patch/thor-actions.rb b/lib/builderator/patch/thor-actions.rb index abc1234..def5678 100644 --- a/lib/builderator/patch/thor-actions.rb +++ b/lib/builderator/patch/thor-actions.rb @@ -30,7 +30,10 @@ io.write(input) ## Stream output - output.write(io.readpartial(409...
Call flush on STDOUT to make Jenkins print it correctly
diff --git a/puppet-lint-duplicate_class_parameters-check.gemspec b/puppet-lint-duplicate_class_parameters-check.gemspec index abc1234..def5678 100644 --- a/puppet-lint-duplicate_class_parameters-check.gemspec +++ b/puppet-lint-duplicate_class_parameters-check.gemspec @@ -22,7 +22,7 @@ spec.add_development_dependency...
Update rubocop requirement from ~> 0.78.0 to ~> 0.79.0 Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](h...
diff --git a/lib/computer_player.rb b/lib/computer_player.rb index abc1234..def5678 100644 --- a/lib/computer_player.rb +++ b/lib/computer_player.rb @@ -15,7 +15,7 @@ when :random then Random.new when :min_max then MinMax.new else - ...
Use interpolation rather than sprintf