diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/bollettino/renderers/payer_renderer.rb b/lib/bollettino/renderers/payer_renderer.rb index abc1234..def5678 100644 --- a/lib/bollettino/renderers/payer_renderer.rb +++ b/lib/bollettino/renderers/payer_renderer.rb @@ -11,7 +11,7 @@ write_text(image, [85, 315], payer.name[25..49]) write_text(im...
Fix overlapping in payer's name
diff --git a/lib/dry/system/plugins/monitoring/proxy.rb b/lib/dry/system/plugins/monitoring/proxy.rb index abc1234..def5678 100644 --- a/lib/dry/system/plugins/monitoring/proxy.rb +++ b/lib/dry/system/plugins/monitoring/proxy.rb @@ -23,7 +23,7 @@ attr_reader :__notifications__ - monitored...
Use variable already allocated for monitored_methods
diff --git a/lib/hstore_radio_buttons/button_options.rb b/lib/hstore_radio_buttons/button_options.rb index abc1234..def5678 100644 --- a/lib/hstore_radio_buttons/button_options.rb +++ b/lib/hstore_radio_buttons/button_options.rb @@ -2,7 +2,7 @@ class ButtonOptions attr_accessor :name, :options def initializ...
Revert "Fix attempt for an integration project" This reverts commit 2a223655705526140f9a51215ece8dabe5fc2860.
diff --git a/lib/test_kafka/zookeeper.rb b/lib/test_kafka/zookeeper.rb index abc1234..def5678 100644 --- a/lib/test_kafka/zookeeper.rb +++ b/lib/test_kafka/zookeeper.rb @@ -9,9 +9,9 @@ "org.apache.zookeeper.server.quorum.QuorumPeerMain", port, ...
Use strings for ZK java properties
diff --git a/schema-evolution-manager.gemspec b/schema-evolution-manager.gemspec index abc1234..def5678 100644 --- a/schema-evolution-manager.gemspec +++ b/schema-evolution-manager.gemspec @@ -0,0 +1,12 @@+Gem::Specification.new do |s| + s.name = 'schema-evolution-manager' + s.version = '0.0.0'...
Add gemfile as an install option Resolves #13
diff --git a/lib/shenanigans/module/private_accessor.rb b/lib/shenanigans/module/private_accessor.rb index abc1234..def5678 100644 --- a/lib/shenanigans/module/private_accessor.rb +++ b/lib/shenanigans/module/private_accessor.rb @@ -1,8 +1,9 @@ class Module private - # Works like attr_accessor but generates priva...
Update documentation and change return value
diff --git a/spec/generator/generator_spec.rb b/spec/generator/generator_spec.rb index abc1234..def5678 100644 --- a/spec/generator/generator_spec.rb +++ b/spec/generator/generator_spec.rb @@ -3,5 +3,8 @@ describe Uniqueness do context 'generate' do it { expect(Uniqueness.generate).not_to be_nil } + it { exp...
Add specs for generate custom numbers with prefix and suffix options
diff --git a/spec/helpers/url_helpers_spec.rb b/spec/helpers/url_helpers_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/url_helpers_spec.rb +++ b/spec/helpers/url_helpers_spec.rb @@ -0,0 +1,33 @@+require 'rails_helper' + +RSpec.describe "url helpers", type: :helper do + let(:headers) { helper.request.env } +...
Test that url helpers use the correct domain
diff --git a/lib/lita/handlers/greet.rb b/lib/lita/handlers/greet.rb index abc1234..def5678 100644 --- a/lib/lita/handlers/greet.rb +++ b/lib/lita/handlers/greet.rb @@ -2,7 +2,7 @@ module Handlers class Greet < Handler - route(/^(hello|hi|good morning|howdy|yo!?$|hey) .*/i, :say_hello) + route(/^(hel...
Fix improve how Hi gets found
diff --git a/plugins/distribution/controllers/myprofile/distribution_plugin_supplier_controller.rb b/plugins/distribution/controllers/myprofile/distribution_plugin_supplier_controller.rb index abc1234..def5678 100644 --- a/plugins/distribution/controllers/myprofile/distribution_plugin_supplier_controller.rb +++ b/plugi...
Change pagination to 10 on supplier
diff --git a/lib/spec/rails/matchers.rb b/lib/spec/rails/matchers.rb index abc1234..def5678 100644 --- a/lib/spec/rails/matchers.rb +++ b/lib/spec/rails/matchers.rb @@ -1,12 +1,4 @@ dir = File.dirname(__FILE__) -require 'spec/rails/matchers/ar_be_valid' -require 'spec/rails/matchers/assert_select' -require 'spec/rails/...
Move require statements to underneath the Spec::Rails module, so that the module exists before we try to use it. [#939 state:resolved milestone:'Next Release']
diff --git a/lib/template/lib/routes.rb b/lib/template/lib/routes.rb index abc1234..def5678 100644 --- a/lib/template/lib/routes.rb +++ b/lib/template/lib/routes.rb @@ -3,6 +3,7 @@ use Pliny::Middleware::CORS use Pliny::Middleware::RequestID use Pliny::Middleware::RequestStore::Seed, store: Pliny::RequestStore ...
Add Middleware::Metrics to the default stack
diff --git a/test/filters/test_pandoc.rb b/test/filters/test_pandoc.rb index abc1234..def5678 100644 --- a/test/filters/test_pandoc.rb +++ b/test/filters/test_pandoc.rb @@ -6,6 +6,10 @@ def test_filter if_have 'pandoc-ruby' do + if `which pandoc`.strip.empty? + skip "could not find pandoc" + e...
Make pandoc test case not fail when pandoc is not available
diff --git a/db/migrate/112_add_api_key_to_public_bodies.rb b/db/migrate/112_add_api_key_to_public_bodies.rb index abc1234..def5678 100644 --- a/db/migrate/112_add_api_key_to_public_bodies.rb +++ b/db/migrate/112_add_api_key_to_public_bodies.rb @@ -9,7 +9,7 @@ pb.save! end - change_column :public_...
Correct syntax for making column NOT NULL
diff --git a/db/migrate/20180719122729_create_oauth_apps.rb b/db/migrate/20180719122729_create_oauth_apps.rb index abc1234..def5678 100644 --- a/db/migrate/20180719122729_create_oauth_apps.rb +++ b/db/migrate/20180719122729_create_oauth_apps.rb @@ -13,7 +13,7 @@ # Oauth parameters String :client_id, u...
Support a single redirection uri
diff --git a/db/migrate/20140808035741_create_comments.rb b/db/migrate/20140808035741_create_comments.rb index abc1234..def5678 100644 --- a/db/migrate/20140808035741_create_comments.rb +++ b/db/migrate/20140808035741_create_comments.rb @@ -1,7 +1,7 @@ class CreateComments < ActiveRecord::Migration def change c...
Change migration field in comments migration from comment to content
diff --git a/roadie.gemspec b/roadie.gemspec index abc1234..def5678 100644 --- a/roadie.gemspec +++ b/roadie.gemspec @@ -13,6 +13,7 @@ s.homepage = 'http://github.com/Mange/roadie' s.summary = %q{Making HTML emails comfortable for the Ruby rockstars} s.description = %q{Roadie tries to make sending HTML e...
Add MIT license to gemspec
diff --git a/paperclip-optimizer.gemspec b/paperclip-optimizer.gemspec index abc1234..def5678 100644 --- a/paperclip-optimizer.gemspec +++ b/paperclip-optimizer.gemspec @@ -13,7 +13,7 @@ spec.homepage = "https://github.com/janfoeh/paperclip-optimizer" spec.license = "MIT" - spec.add_dependency "paper...
Allow all minor version upgrades of Paperclip 3.x
diff --git a/app/models/experience.rb b/app/models/experience.rb index abc1234..def5678 100644 --- a/app/models/experience.rb +++ b/app/models/experience.rb @@ -2,7 +2,7 @@ extend FriendlyId has_many :cocktails, dependent: :destroy - accepts_nested_attributes_for :cocktails, reject_if: lambda { |cocktail| cockt...
Move condition to method for improved readability.
diff --git a/app/models/permission.rb b/app/models/permission.rb index abc1234..def5678 100644 --- a/app/models/permission.rb +++ b/app/models/permission.rb @@ -6,8 +6,5 @@ valhammer - # "word" in the url-safe base64 alphabet, or single '*' - SEGMENT = /([\w-]+|\*)/ - private_constant :SEGMENT - validates :va...
Use Accession::Permission regexp for validation The code here predated what was available in accession
diff --git a/spec/features/creating_a_notebook_spec.rb b/spec/features/creating_a_notebook_spec.rb index abc1234..def5678 100644 --- a/spec/features/creating_a_notebook_spec.rb +++ b/spec/features/creating_a_notebook_spec.rb @@ -3,26 +3,42 @@ RSpec.describe "Creating a notebook" do let(:user) { create(:user) } - ...
Add test scenarios for displaying notebooks per user
diff --git a/spec/integration/arel/many_to_one_spec.rb b/spec/integration/arel/many_to_one_spec.rb index abc1234..def5678 100644 --- a/spec/integration/arel/many_to_one_spec.rb +++ b/spec/integration/arel/many_to_one_spec.rb @@ -0,0 +1,27 @@+require 'spec_helper_integration' + +describe '[Arel] Many To One with generat...
Add explicit many_to_one integration spec for arel
diff --git a/etcenv.gemspec b/etcenv.gemspec index abc1234..def5678 100644 --- a/etcenv.gemspec +++ b/etcenv.gemspec @@ -19,10 +19,7 @@ spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - if spec.respond_to?(:metadata) - spec.metadata['allowed_push_host'] =...
Update gemspec: add rspec and allow push
diff --git a/schema.gemspec b/schema.gemspec index abc1234..def5678 100644 --- a/schema.gemspec +++ b/schema.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'evt-schema' s.summary = "Primitives for schema and data structure" - s.version = '1.2.2.0' + s.version = '2.2.2.0' s.description = ' ' ...
Package version is increased from 1.2.2.0 to 2.2.2.0
diff --git a/test/gir_ffi/version_test.rb b/test/gir_ffi/version_test.rb index abc1234..def5678 100644 --- a/test/gir_ffi/version_test.rb +++ b/test/gir_ffi/version_test.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'gir_ffi_test_helper' -describe GirFFI::VERSION do +describe 'GirFFI::VERSION' do it 'i...
Fix description for GirFFI::VERSION test Unlike with classes, the bare constant does not result in the description being 'GirFFI::VERSION', but instead makes the description equal to the value of GirFFI::VERSION, which is not what we want.
diff --git a/lib/legal_markdown/legal_to_markdown/writer.rb b/lib/legal_markdown/legal_to_markdown/writer.rb index abc1234..def5678 100644 --- a/lib/legal_markdown/legal_to_markdown/writer.rb +++ b/lib/legal_markdown/legal_to_markdown/writer.rb @@ -6,7 +6,7 @@ require 'json' if writer == :jason if @output_file...
Change JSON dump to JSON pretty_print
diff --git a/ext/extconf.rb b/ext/extconf.rb index abc1234..def5678 100644 --- a/ext/extconf.rb +++ b/ext/extconf.rb @@ -17,6 +17,8 @@ case CONFIG["arch"] when /mswin32|mingw|solaris/ $CFLAGS += " -march=native" +when 'i686-linux' + $CFLAGS += " -march-i686" end try_run(<<CODE,$CFLAGS) && ($defs << '-DHAVE...
Set march appropriately on RHEL5 32bit Fix for issue 24.
diff --git a/test/new/post_mortem_test.rb b/test/new/post_mortem_test.rb index abc1234..def5678 100644 --- a/test/new/post_mortem_test.rb +++ b/test/new/post_mortem_test.rb @@ -17,4 +17,9 @@ enter 'cont', 'break 12', 'cont' debug_file("post_mortem") { Debugger.post_mortem?.must_equal false } end + + it "mu...
Add additional test example to post mortem tests
diff --git a/test/unit/finder_schema_validation_test.rb b/test/unit/finder_schema_validation_test.rb index abc1234..def5678 100644 --- a/test/unit/finder_schema_validation_test.rb +++ b/test/unit/finder_schema_validation_test.rb @@ -1,9 +1,15 @@ require 'test_helper' class FinderSchemaValidationTest < ActiveSupport:...
Test all the existing finders The Finding Things Team is working towards moving some of the index pages to finders. This commit will make it easier to continue adding new finders and be sure they are tested and valid.
diff --git a/lib/capybara/bootstrap/alert.rb b/lib/capybara/bootstrap/alert.rb index abc1234..def5678 100644 --- a/lib/capybara/bootstrap/alert.rb +++ b/lib/capybara/bootstrap/alert.rb @@ -31,7 +31,7 @@ def css_for_type(type) case type when :success, :info, :warning, :danger - "...
Drop white space in CSS class name for Alert
diff --git a/lib/rrj/models/active_record.rb b/lib/rrj/models/active_record.rb index abc1234..def5678 100644 --- a/lib/rrj/models/active_record.rb +++ b/lib/rrj/models/active_record.rb @@ -13,6 +13,15 @@ after_create { callback_create_after } after_update { callback_update_after } after_de...
Create method set for saving attributes in model
diff --git a/week-4/shortest-string/my_solution.rb b/week-4/shortest-string/my_solution.rb index abc1234..def5678 100644 --- a/week-4/shortest-string/my_solution.rb +++ b/week-4/shortest-string/my_solution.rb @@ -17,4 +17,3 @@ list_of_words.min { |x,y| x.length <=> y.length } end shortest_string(["1","3","10","25...
Include method for shortest string
diff --git a/lib/montage.rb b/lib/montage.rb index abc1234..def5678 100644 --- a/lib/montage.rb +++ b/lib/montage.rb @@ -1,7 +1,6 @@ require 'yaml' require 'pathname' -require 'fileutils' -require 'digest' +require 'digest/sha2' # Gems. require 'active_support/ordered_hash'
Remove fileutils (since isn't used explicitly).
diff --git a/config/deploy/staging.rb b/config/deploy/staging.rb index abc1234..def5678 100644 --- a/config/deploy/staging.rb +++ b/config/deploy/staging.rb @@ -1,4 +1,4 @@-raise "No staging server setup yet!" +warn "No staging server setup yet!" # server ".us-west-2.compute.amazonaws.com", :app, :db, :primary => true...
Switch to warn so cap -T works
diff --git a/app/models/dojo.rb b/app/models/dojo.rb index abc1234..def5678 100644 --- a/app/models/dojo.rb +++ b/app/models/dojo.rb @@ -14,6 +14,15 @@ validates :description, presence: true, length: { maximum: 50 } validates :logo, presence: false validates :tags, presence: true + validate :num...
Add custom validation to check number of tags
diff --git a/virtus-representable.gemspec b/virtus-representable.gemspec index abc1234..def5678 100644 --- a/virtus-representable.gemspec +++ b/virtus-representable.gemspec @@ -22,5 +22,5 @@ spec.add_development_dependency "rake" spec.add_dependency "virtus" spec.add_dependency "representable" - spec.add_depen...
Use activesupport gem, not active_support
diff --git a/ariadne_js_rails.gemspec b/ariadne_js_rails.gemspec index abc1234..def5678 100644 --- a/ariadne_js_rails.gemspec +++ b/ariadne_js_rails.gemspec @@ -17,7 +17,7 @@ s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.rdoc"] s.test_files = Dir["test/**/*"] - s.add_dependency "r...
Update dependency for rails version.
diff --git a/lib/ie/compat.rb b/lib/ie/compat.rb index abc1234..def5678 100644 --- a/lib/ie/compat.rb +++ b/lib/ie/compat.rb @@ -17,5 +17,9 @@ case when defined? Rails require 'ie/compat/railtie' +when defined? Opal + Opal.append_path IE::Compat.assets_path +when defined? Sprockets + Sprockets.append_path IE::Com...
Add alternative support for Sprockets and Opal
diff --git a/config/rackup.ru b/config/rackup.ru index abc1234..def5678 100644 --- a/config/rackup.ru +++ b/config/rackup.ru @@ -9,6 +9,7 @@ set :environment, :production set :public, app_root + '/public' +set :views, app_root + '/views' disable :run, :reload
Set the views directory explicitly.
diff --git a/app/controllers/api_controller.rb b/app/controllers/api_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api_controller.rb +++ b/app/controllers/api_controller.rb @@ -1,7 +1,5 @@ class APIController < ActionController::API include Operations::Performable - - respond_to :json rescu...
Remove respond_to instruction causing an error
diff --git a/mailman_app.rb b/mailman_app.rb index abc1234..def5678 100644 --- a/mailman_app.rb +++ b/mailman_app.rb @@ -25,5 +25,4 @@ user.responses.create(content: message) end end - end
Remove newline (demo for Moazzam)
diff --git a/db/migrate/20090924204451_add_processing_to_issues.rb b/db/migrate/20090924204451_add_processing_to_issues.rb index abc1234..def5678 100644 --- a/db/migrate/20090924204451_add_processing_to_issues.rb +++ b/db/migrate/20090924204451_add_processing_to_issues.rb @@ -0,0 +1,9 @@+class AddProcessingToIssues < A...
Add processing attribute to issues.
diff --git a/app/models/spree/order_version.rb b/app/models/spree/order_version.rb index abc1234..def5678 100644 --- a/app/models/spree/order_version.rb +++ b/app/models/spree/order_version.rb @@ -10,7 +10,7 @@ products: order.products.map{|product| product.current_version.id}, taxons: ...
Add versioning logic to orders+option_types
diff --git a/lib/loudmouth.rb b/lib/loudmouth.rb index abc1234..def5678 100644 --- a/lib/loudmouth.rb +++ b/lib/loudmouth.rb @@ -1,6 +1,7 @@ require "loudmouth" require "rails/routes" require "extensions/helper" +require "extensions/active_record" module Loudmouth class Engine < Rails::Engine @@ -25,12 +26,12 @...
Include helpers under :action_view Load ActiveRecord extensions.
diff --git a/app/services/dashboard_runlist.rb b/app/services/dashboard_runlist.rb index abc1234..def5678 100644 --- a/app/services/dashboard_runlist.rb +++ b/app/services/dashboard_runlist.rb @@ -25,6 +25,8 @@ { id: submission.id, group_id: submission.collaboration_run_id, + # Return tim...
Add date to LARA arg-block dashboard API [#112541903]
diff --git a/lib/harbor/core.rb b/lib/harbor/core.rb index abc1234..def5678 100644 --- a/lib/harbor/core.rb +++ b/lib/harbor/core.rb @@ -30,7 +30,7 @@ class Harbor def initialize - self.class::applications.each do |application| + self.class::registered_applications.each do |application| applications <...
Allow public access to registered applications
diff --git a/web.rb b/web.rb index abc1234..def5678 100644 --- a/web.rb +++ b/web.rb @@ -2,7 +2,7 @@ # External libs require 'sinatra' # Internal modules -require 'tradera.rb' +require './tradera.rb' get '/' do redirect '/index.html'
Use absolute path in include
diff --git a/minimal-mistakes-jekyll.gemspec b/minimal-mistakes-jekyll.gemspec index abc1234..def5678 100644 --- a/minimal-mistakes-jekyll.gemspec +++ b/minimal-mistakes-jekyll.gemspec @@ -22,6 +22,6 @@ spec.add_runtime_dependency "jekyll-feed", "~> 0.9.1" spec.add_runtime_dependency "jemoji", "~> 0.8" - spec.a...
Update min bundler specs for security
diff --git a/lib/lazy_object.rb b/lib/lazy_object.rb index abc1234..def5678 100644 --- a/lib/lazy_object.rb +++ b/lib/lazy_object.rb @@ -9,6 +9,7 @@ # lazy = LazyObject.new { VeryExpensiveObject.new } # At this point the VeryExpensiveObject hasn't been initialized yet. # lazy.get_expensive_results(foo, bar) # Initiali...
Include Comparable module and delegate it to the target object
diff --git a/lib/watirspec.rb b/lib/watirspec.rb index abc1234..def5678 100644 --- a/lib/watirspec.rb +++ b/lib/watirspec.rb @@ -1,6 +1,6 @@ module WatirSpec class << self - attr_accessor :browser_args, :persistent_browser, :unguarded + attr_accessor :browser_args, :persistent_browser, :unguarded, :implementat...
Add ability to set impl name manually using WatirSpec.implementation=
diff --git a/lib/octopi/blob.rb b/lib/octopi/blob.rb index abc1234..def5678 100644 --- a/lib/octopi/blob.rb +++ b/lib/octopi/blob.rb @@ -1,7 +1,7 @@ require File.join(File.dirname(__FILE__), "resource") module Octopi class Blob < Base - attr_accessor :text + attr_accessor :text, :data, :name, :sha, :size, :mo...
Add more attr_accessors to Blob - Closes GH-33
diff --git a/liquid-c.gemspec b/liquid-c.gemspec index abc1234..def5678 100644 --- a/liquid-c.gemspec +++ b/liquid-c.gemspec @@ -7,7 +7,7 @@ spec.name = "liquid-c" spec.version = Liquid::C::VERSION spec.authors = ["Justin Li", "Dylan Thacker-Smith"] - spec.email = ["jli@shopify.com...
Use gems@shopify.com email address in gemspec
diff --git a/lib/poms/errors.rb b/lib/poms/errors.rb index abc1234..def5678 100644 --- a/lib/poms/errors.rb +++ b/lib/poms/errors.rb @@ -4,24 +4,19 @@ AuthenticationError = Class.new(StandardError) # Base exception for all Poms-specific HTTP errors. - class HttpError < StandardError - end + HttpErro...
Use shorthand syntax to define custom exceptions
diff --git a/spec/services/search_orders_spec.rb b/spec/services/search_orders_spec.rb index abc1234..def5678 100644 --- a/spec/services/search_orders_spec.rb +++ b/spec/services/search_orders_spec.rb @@ -8,6 +8,8 @@ let!(:order2) { create(:order_with_line_items, distributor: distributor, line_items_count: 2) } le...
Update test to add more case with finalized order with no line items Those empty order but finalized must be returned by the API
diff --git a/spec/tasks/negative_balance_spec.rb b/spec/tasks/negative_balance_spec.rb index abc1234..def5678 100644 --- a/spec/tasks/negative_balance_spec.rb +++ b/spec/tasks/negative_balance_spec.rb @@ -17,7 +17,7 @@ warning_emails = deliveries.select { |m| m.subject[/negative balance warning/] } expect(warn...
FIx for negative balance mailer spec
diff --git a/lib/synx/tabber.rb b/lib/synx/tabber.rb index abc1234..def5678 100644 --- a/lib/synx/tabber.rb +++ b/lib/synx/tabber.rb @@ -1,39 +1,39 @@ module Synx class Tabber - @@options = {} - @@tabbing = 0 + @options = {} + @tabbing = 0 class << self def increase(n=1) - @@tabbin...
Remove class variables from Tabber @@vars are generally considered a Bad Thing in Ruby. See http://bit.ly/1kcit9V for a quick rationale.
diff --git a/keno.gemspec b/keno.gemspec index abc1234..def5678 100644 --- a/keno.gemspec +++ b/keno.gemspec @@ -8,9 +8,9 @@ spec.version = Keno::VERSION spec.authors = ["Dave Powers"] spec.email = ["djpowers89@gmail.com"] - spec.summary = %q{TODO: Write a short summary. Required.} - ...
Update gemspec file with summary, description, and homepage
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -10,8 +10,19 @@ "fixtures")) Before do + $git_fixture_dir_exists ||= false @dirs = [FIXTURES_PATH] + ["no_git", "with_git"].eac...
[Cucumber] Add creating of fixtures before scenarios Signed-off-by: Daniel Schmidt <95584f82d85fd95b525d0d56fac4758a79f7199d@adytonsystems.com>
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -5,7 +5,7 @@ ENV['RUBYLIB'] = "#{File.expand_path(File.dirname(__FILE__) + '/../../lib')}#{File::PATH_SEPARATOR}#{ENV['RUBYLIB']}" Before do - @aruba_timeout_se...
Revert "Longer timeout for travis to finish `rake bootstrap`" This reverts commit 846d47359e970bce0e898d82569687b7d601b6a0.
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -5,10 +5,11 @@ class ReekWorld def run(cmd) - out, err, status = Open3.capture3(cmd) - @last_stdout = out - @last_stderr = err - @last_exit_status ...
Work around broken Open3 on JRuby 1.7.16
diff --git a/spec/delegate_all_for/delegate_all_for_spec.rb b/spec/delegate_all_for/delegate_all_for_spec.rb index abc1234..def5678 100644 --- a/spec/delegate_all_for/delegate_all_for_spec.rb +++ b/spec/delegate_all_for/delegate_all_for_spec.rb @@ -1,20 +1,21 @@ require File.expand_path('../../spec_helper', __FILE__) +...
Rearrange Child and Parent definitions so Child is in scope when we delegate to it from Parent
diff --git a/lib/usi/session.rb b/lib/usi/session.rb index abc1234..def5678 100644 --- a/lib/usi/session.rb +++ b/lib/usi/session.rb @@ -1,9 +1,12 @@+require "open3" + module USI class Session - attr_reader :engine + attr_reader :engine, :stdin, :stdout, :stderr, :wait_thr def initialize(engine) ...
Use Open3.popen3 in execution of engine.
diff --git a/spec/govuk_seed_crawler/topic_exchange_spec.rb b/spec/govuk_seed_crawler/topic_exchange_spec.rb index abc1234..def5678 100644 --- a/spec/govuk_seed_crawler/topic_exchange_spec.rb +++ b/spec/govuk_seed_crawler/topic_exchange_spec.rb @@ -0,0 +1,32 @@+require 'spec_helper' + +describe GovukSeedCrawler::TopicE...
Add unit tests for TopicExchange class
diff --git a/spec/models/utils/util_user_db_manager_spec.rb b/spec/models/utils/util_user_db_manager_spec.rb index abc1234..def5678 100644 --- a/spec/models/utils/util_user_db_manager_spec.rb +++ b/spec/models/utils/util_user_db_manager_spec.rb @@ -13,7 +13,7 @@ # make sure user account doesn't already exist ...
Make the UserDbManager responsible for creating user accounts
diff --git a/spec/requests/api/v1/playlists_request_spec.rb b/spec/requests/api/v1/playlists_request_spec.rb index abc1234..def5678 100644 --- a/spec/requests/api/v1/playlists_request_spec.rb +++ b/spec/requests/api/v1/playlists_request_spec.rb @@ -0,0 +1,39 @@+require 'rails_helper' + +RSpec.describe "Api::V1::Playlis...
Add test for /api/v1/playlists route
diff --git a/lib/brick_ftp/http_client.rb b/lib/brick_ftp/http_client.rb index abc1234..def5678 100644 --- a/lib/brick_ftp/http_client.rb +++ b/lib/brick_ftp/http_client.rb @@ -40,6 +40,7 @@ def request(method, path, params: {}, headers: {}) req = Net::HTTP.const_get(method.to_s.capitalize).new(path, headers...
Set session cookie if logged in.
diff --git a/lib/generators/doorkeeper/views_generator.rb b/lib/generators/doorkeeper/views_generator.rb index abc1234..def5678 100644 --- a/lib/generators/doorkeeper/views_generator.rb +++ b/lib/generators/doorkeeper/views_generator.rb @@ -2,6 +2,8 @@ module Generators class ViewsGenerator < Rails::Generators::...
Add description to views generator
diff --git a/lib/genomer-plugin-view/gff_record_helper.rb b/lib/genomer-plugin-view/gff_record_helper.rb index abc1234..def5678 100644 --- a/lib/genomer-plugin-view/gff_record_helper.rb +++ b/lib/genomer-plugin-view/gff_record_helper.rb @@ -28,23 +28,6 @@ end end - def to_genbank_feature_row - out = [coord...
Remove unused gff3 helper methods
diff --git a/lib/knapsack_pro/config/ci/github_actions.rb b/lib/knapsack_pro/config/ci/github_actions.rb index abc1234..def5678 100644 --- a/lib/knapsack_pro/config/ci/github_actions.rb +++ b/lib/knapsack_pro/config/ci/github_actions.rb @@ -1,4 +1,4 @@-# https://help.github.com/en/articles/virtual-environments-for-gith...
Update link to list of Github Actions envs
diff --git a/lib/spontaneous/data_mapper/content_table.rb b/lib/spontaneous/data_mapper/content_table.rb index abc1234..def5678 100644 --- a/lib/spontaneous/data_mapper/content_table.rb +++ b/lib/spontaneous/data_mapper/content_table.rb @@ -1,6 +1,8 @@ module Spontaneous module DataMapper class ContentTable + ...
Replace revision padding magic number with a constant Also remove hard-coded table name from #revision_table? test
diff --git a/lib/asciidoctor-diagram/util/cli.rb b/lib/asciidoctor-diagram/util/cli.rb index abc1234..def5678 100644 --- a/lib/asciidoctor-diagram/util/cli.rb +++ b/lib/asciidoctor-diagram/util/cli.rb @@ -8,7 +8,7 @@ def self.run(*args) stdout, stderr, status = Open3.capture3(*args) - if status ...
Correct process exit code check
diff --git a/markdown-test.rb b/markdown-test.rb index abc1234..def5678 100644 --- a/markdown-test.rb +++ b/markdown-test.rb @@ -2,6 +2,9 @@ puts "Maruku:" puts `bin/maruku -o - --html-frag #{ARGV[0]}` + +puts "Old Maruku:" +puts `maruku -o - --html-frag #{ARGV[0]}` puts "\n\nRedcarpet:" puts `redcarpet #{ARGV[0...
Include old maruku in comparison script
diff --git a/lib/filter_factory/filter.rb b/lib/filter_factory/filter.rb index abc1234..def5678 100644 --- a/lib/filter_factory/filter.rb +++ b/lib/filter_factory/filter.rb @@ -47,7 +47,7 @@ class << self def create(&block) - new.tap { |filter| filter.instance_eval &block } + new.tap { |filte...
Add brackets around block in Filter::create.
diff --git a/lib/fassets_presentations/engine.rb b/lib/fassets_presentations/engine.rb index abc1234..def5678 100644 --- a/lib/fassets_presentations/engine.rb +++ b/lib/fassets_presentations/engine.rb @@ -2,7 +2,7 @@ class Engine < Rails::Engine isolate_namespace FassetsPresentations initializer :assets do ...
Add fancybox.css to precompile list
diff --git a/lib/mobylette/mobile_user_agents.rb b/lib/mobylette/mobile_user_agents.rb index abc1234..def5678 100644 --- a/lib/mobylette/mobile_user_agents.rb +++ b/lib/mobylette/mobile_user_agents.rb @@ -6,5 +6,5 @@ 'x320|x240|j2me|sgh|portable|sprint|docomo|kddi|softbank|android|mmp|' + 'pdxgw|netfront|xiino...
Add Silk (Kindle) to the user agent list
diff --git a/lib/xcode/builder/scheme_builder.rb b/lib/xcode/builder/scheme_builder.rb index abc1234..def5678 100644 --- a/lib/xcode/builder/scheme_builder.rb +++ b/lib/xcode/builder/scheme_builder.rb @@ -36,11 +36,11 @@ # cmd # end - def test + def test options = {:sdk => @sdk, :show_o...
Allow overriding test options for schemes
diff --git a/lib/organisation_registry.rb b/lib/organisation_registry.rb index abc1234..def5678 100644 --- a/lib/organisation_registry.rb +++ b/lib/organisation_registry.rb @@ -1,7 +1,7 @@ require "time" class OrganisationRegistry - CACHE_LIFETIME = 12 * 3600 + CACHE_LIFETIME = 12 * 3600 # 12 hours def initi...
Add a comment to be explicit about the cache time.
diff --git a/shared/complex/hash.rb b/shared/complex/hash.rb index abc1234..def5678 100644 --- a/shared/complex/hash.rb +++ b/shared/complex/hash.rb @@ -8,9 +8,9 @@ end it "is different for different instances" do - Complex(1, 2).hash.should_not == Complex(1, 1).hash + Complex(1, 2).hash.should_not == Complex...
Remove unintended tabs in spec.
diff --git a/lib/appsignal/integrations/sequel.rb b/lib/appsignal/integrations/sequel.rb index abc1234..def5678 100644 --- a/lib/appsignal/integrations/sequel.rb +++ b/lib/appsignal/integrations/sequel.rb @@ -7,7 +7,7 @@ # Add query instrumentation def log_yield(sql, args = nil) name = 's...
Use the old hash syntax to support older Rubies.
diff --git a/lib/cargo.rb b/lib/cargo.rb index abc1234..def5678 100644 --- a/lib/cargo.rb +++ b/lib/cargo.rb @@ -18,4 +18,4 @@ end end -include Cargo +extend Cargo
Use extend instead of include.
diff --git a/lib/http_streaming_client/version.rb b/lib/http_streaming_client/version.rb index abc1234..def5678 100644 --- a/lib/http_streaming_client/version.rb +++ b/lib/http_streaming_client/version.rb @@ -28,5 +28,5 @@ ########################################################################### module HttpStreami...
Fix for EOFError NoMethodError issue
diff --git a/lib/mountable_image_server/server.rb b/lib/mountable_image_server/server.rb index abc1234..def5678 100644 --- a/lib/mountable_image_server/server.rb +++ b/lib/mountable_image_server/server.rb @@ -11,6 +11,7 @@ image_processor = ImageProcessor.new(path, params) image_processor.run do |pro...
Add Cache-Control headers to response
diff --git a/lib/rspec/core/mocking/with_rspec.rb b/lib/rspec/core/mocking/with_rspec.rb index abc1234..def5678 100644 --- a/lib/rspec/core/mocking/with_rspec.rb +++ b/lib/rspec/core/mocking/with_rspec.rb @@ -4,10 +4,8 @@ module Core module MockFrameworkAdapter - include RSpec::Mocks::ExampleMethods - ...
Update rspec mock framework adapter to new API for RSpec::Mocks
diff --git a/lib/ubuntu_unused_kernels.rb b/lib/ubuntu_unused_kernels.rb index abc1234..def5678 100644 --- a/lib/ubuntu_unused_kernels.rb +++ b/lib/ubuntu_unused_kernels.rb @@ -8,17 +8,17 @@ class << self def to_remove - current, suffix = get_current - packages = get_installed(suffix) + current ...
Fix post-suffix tests for to_remove Now that we're ignoring suffixes.
diff --git a/lib/vidibus/oauth2_server.rb b/lib/vidibus/oauth2_server.rb index abc1234..def5678 100644 --- a/lib/vidibus/oauth2_server.rb +++ b/lib/vidibus/oauth2_server.rb @@ -20,6 +20,6 @@ class InvalidTokenError < Oauth2ServerError; end class ExpiredTokenError < Oauth2ServerError; end - FLOWS = %w[web_...
Allow several values as flow
diff --git a/lib/cool.io.rb b/lib/cool.io.rb index abc1234..def5678 100644 --- a/lib/cool.io.rb +++ b/lib/cool.io.rb @@ -19,7 +19,6 @@ require "cool.io/dns_resolver" require "cool.io/socket" require "cool.io/server" -require "cool.io/dsl" module Coolio def self.inspect
Remove dsl.rb from default required modules
diff --git a/lib/vagrant-ca-certificates/config/ca_certificates.rb b/lib/vagrant-ca-certificates/config/ca_certificates.rb index abc1234..def5678 100644 --- a/lib/vagrant-ca-certificates/config/ca_certificates.rb +++ b/lib/vagrant-ca-certificates/config/ca_certificates.rb @@ -20,14 +20,6 @@ @enabled = false i...
Remove URL block from config. URL support is planned and this block was accidentally included in a pull request.
diff --git a/kitcat.gemspec b/kitcat.gemspec index abc1234..def5678 100644 --- a/kitcat.gemspec +++ b/kitcat.gemspec @@ -16,9 +16,9 @@ gem.require_path = 'lib' gem.add_runtime_dependency 'ruby-progressbar', '~> 1.8' - gem.add_runtime_dependency 'activemodel', '~> 4.2' + gem.add_runtime_dependency 'activemodel...
Remove restrictive version stuff for rails 5.0
diff --git a/test/null_asset_compiler_test.rb b/test/null_asset_compiler_test.rb index abc1234..def5678 100644 --- a/test/null_asset_compiler_test.rb +++ b/test/null_asset_compiler_test.rb @@ -1,4 +1,5 @@ require_relative 'test_helper' +require 'rack-zippy/asset_compiler' module Rack module Zippy
Add require dependency so null compiler test runs with ruby directly
diff --git a/lib/pentago.rb b/lib/pentago.rb index abc1234..def5678 100644 --- a/lib/pentago.rb +++ b/lib/pentago.rb @@ -1,6 +1,5 @@ require 'observer' -require 'rubygems' require 'bundler/setup' Bundler.require @@ -18,4 +17,4 @@ require_relative 'pentago/human_player' require_relative 'pentago/negamax_player' ...
Remove unnecessary 'rubygems' require statement.
diff --git a/test/unit/recipes/resolv_spec.rb b/test/unit/recipes/resolv_spec.rb index abc1234..def5678 100644 --- a/test/unit/recipes/resolv_spec.rb +++ b/test/unit/recipes/resolv_spec.rb @@ -0,0 +1,62 @@+describe 'sys::resolv' do + + before do + stub_command("test -L /etc/resolv.conf").and_return(false) + end + ...
Add unit tests for resolv recipe
diff --git a/lib/verdict.rb b/lib/verdict.rb index abc1234..def5678 100644 --- a/lib/verdict.rb +++ b/lib/verdict.rb @@ -11,19 +11,16 @@ end def repository - if @repository.nil? - @repository = {} - discovery - end - + discovery if @repository.nil? @repository end def discovery + ...
Allow Verdict.discovery to be called multiple times without exceptions Since we're using `load` instead of `require`, it's important to clear the repository cache before searching for experiment definitions again.
diff --git a/lib/dimples.rb b/lib/dimples.rb index abc1234..def5678 100644 --- a/lib/dimples.rb +++ b/lib/dimples.rb @@ -2,6 +2,7 @@ $LOAD_PATH.unshift(__dir__) +require 'fileutils' require 'hashie' require 'tilt' require 'yaml'
Add the missing fileutils require
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -1,7 +1,7 @@ name 'mingw' maintainer 'Chef Software, Inc.' maintainer_email 'cookbooks@chef.io' -license 'apache2' +license 'Apache 2.0' description 'Installs a mingw/msys based toolchain on windows' long_des...
Use the full license name
diff --git a/spec/msgr/msgr_spec.rb b/spec/msgr/msgr_spec.rb index abc1234..def5678 100644 --- a/spec/msgr/msgr_spec.rb +++ b/spec/msgr/msgr_spec.rb @@ -23,7 +23,7 @@ end after do - client.stop + client.stop delete: true end it 'should dispatch published methods to consumer' do
Delete queues and exchange after test run
diff --git a/test/integration/detailed_guide_test.rb b/test/integration/detailed_guide_test.rb index abc1234..def5678 100644 --- a/test/integration/detailed_guide_test.rb +++ b/test/integration/detailed_guide_test.rb @@ -4,7 +4,7 @@ test "meta data tag is present" do detailed_guide = create(:published_detailed_g...
Fix detailed guide test for new paths
diff --git a/test/models/user_mailer_content_test.rb b/test/models/user_mailer_content_test.rb index abc1234..def5678 100644 --- a/test/models/user_mailer_content_test.rb +++ b/test/models/user_mailer_content_test.rb @@ -0,0 +1,38 @@+require "test_helper" +class UserMailerContentTest < ActionMailer::TestCase + #Use sp...
Add content scanning test for user mail content This commit adds a new test file with the intent of scanning content for malformed patterns that may prevent certain approaches from working as intended. First implementation of this test scans any html mail content files for malformed link_to calls, while allowing for ...
diff --git a/lib/sweep.rb b/lib/sweep.rb index abc1234..def5678 100644 --- a/lib/sweep.rb +++ b/lib/sweep.rb @@ -15,3 +15,11 @@ } end +require 'rubygems' +require 'active_record' +require 'racket' + +require 'sweep/scheduler' +require 'sweep/task' +require 'sweep/module' +
Add basic require for operations.
diff --git a/db/migrate/20160918000000_create_indices.rb b/db/migrate/20160918000000_create_indices.rb index abc1234..def5678 100644 --- a/db/migrate/20160918000000_create_indices.rb +++ b/db/migrate/20160918000000_create_indices.rb @@ -9,6 +9,8 @@ add_index :facilities, :nct_id add_index :outcomes, :nct_id ...
AACT-219: Add indexes to the StudyXmlRecords table
diff --git a/lib/csv_rails/active_model.rb b/lib/csv_rails/active_model.rb index abc1234..def5678 100644 --- a/lib/csv_rails/active_model.rb +++ b/lib/csv_rails/active_model.rb @@ -5,7 +5,12 @@ def to_csv(opts={}) fields = opts[:fields] || csv_fields header = csv_header(fields, opts.delete(:i18n...
Remove deprecation warning using rails 4.0.0.rc1.