diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/trawler/sources/json_fetcher.rb b/lib/trawler/sources/json_fetcher.rb index abc1234..def5678 100644 --- a/lib/trawler/sources/json_fetcher.rb +++ b/lib/trawler/sources/json_fetcher.rb @@ -9,11 +9,13 @@ class << self extend Memoist - def get(url) + def get(url, &error_bloc...
Add default error handler to fetch
diff --git a/lib/uniara_virtual_parser/client.rb b/lib/uniara_virtual_parser/client.rb index abc1234..def5678 100644 --- a/lib/uniara_virtual_parser/client.rb +++ b/lib/uniara_virtual_parser/client.rb @@ -9,7 +9,7 @@ class << self def get_with_token(path, token) - uri = URI("#{ENDPOINT}#{path}") + ...
Allow configure a custom endpoint
diff --git a/lib/ups/builders/shipper_builder.rb b/lib/ups/builders/shipper_builder.rb index abc1234..def5678 100644 --- a/lib/ups/builders/shipper_builder.rb +++ b/lib/ups/builders/shipper_builder.rb @@ -10,6 +10,10 @@ def initialize(opts = {}) self.name = name self.opts = opts + end + + ...
Add Shipper Name to Shipper Builder
diff --git a/lib/core/repositories/vcr.rb b/lib/core/repositories/vcr.rb index abc1234..def5678 100644 --- a/lib/core/repositories/vcr.rb +++ b/lib/core/repositories/vcr.rb @@ -0,0 +1,17 @@+require 'vcr' + +module Core::Repositories + class VCR < SimpleDelegator + def method_missing(method_name, *args, &block) + ...
Introduce a VCR repository for acceptance tests We'll use our VCR repository to wrap HTTP backed repositories at runtime to provide us with fast, deterministic repositories when we perform our acceptance tests.
diff --git a/hijri_date.gemspec b/hijri_date.gemspec index abc1234..def5678 100644 --- a/hijri_date.gemspec +++ b/hijri_date.gemspec @@ -8,8 +8,8 @@ spec.version = HijriDate::VERSION spec.authors = ["Murtaza Gulamali"] spec.email = ["mygulamali@gmail.com"] - spec.description = %q{TODO: Wr...
Complete description and summary in gemspec.
diff --git a/lib/kobol/requests/issues.rb b/lib/kobol/requests/issues.rb index abc1234..def5678 100644 --- a/lib/kobol/requests/issues.rb +++ b/lib/kobol/requests/issues.rb @@ -5,7 +5,7 @@ def search(properties, page) updated_after_date = Date.today << 3 - set_response(client.search_issues("#{search_p...
Exclude archived repositories from search Resolves #141
diff --git a/lib/cache_comment/comment_formatter.rb b/lib/cache_comment/comment_formatter.rb index abc1234..def5678 100644 --- a/lib/cache_comment/comment_formatter.rb +++ b/lib/cache_comment/comment_formatter.rb @@ -3,7 +3,7 @@ def initialize key, options @key = key - @options = options.symbolize...
Fix formatter for options that are nil
diff --git a/spec/controllers/application_controller_spec.rb b/spec/controllers/application_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/application_controller_spec.rb +++ b/spec/controllers/application_controller_spec.rb @@ -0,0 +1,14 @@+require "spec_helper" + +describe ApplicationControlle...
Add locale support to URLs
diff --git a/ios/RNSqlite2.podspec b/ios/RNSqlite2.podspec index abc1234..def5678 100644 --- a/ios/RNSqlite2.podspec +++ b/ios/RNSqlite2.podspec @@ -10,7 +10,7 @@ s.license = "Apache 2.0" s.author = { "author" => "hi@craftz.dog" } s.platform = :ios, "7.0" - s.source = { :git => "https://gi...
fix(ios): Fix source URI in podspec RNSqlite2.git doesn't exist #55
diff --git a/lib/praxis/tasks/api_docs.rb b/lib/praxis/tasks/api_docs.rb index abc1234..def5678 100644 --- a/lib/praxis/tasks/api_docs.rb +++ b/lib/praxis/tasks/api_docs.rb @@ -7,9 +7,8 @@ generator = Praxis::RestfulDocGenerator.new(Dir.pwd) end - desc "API Documenation Browser" desc "API Documentation Bro...
Add 'port' argument to doc_browser rake task. Closes #75
diff --git a/lib/ransack/configuration.rb b/lib/ransack/configuration.rb index abc1234..def5678 100644 --- a/lib/ransack/configuration.rb +++ b/lib/ransack/configuration.rb @@ -35,9 +35,9 @@ end # default search_key that, it can be overridden on sort_link level - def set_search_key_name(name) + def sea...
Change set_search_key_name Configuration method to be a true setter, renamed to search_key= Related to #81
diff --git a/lib/engineyard-cloud-client/version.rb b/lib/engineyard-cloud-client/version.rb index abc1234..def5678 100644 --- a/lib/engineyard-cloud-client/version.rb +++ b/lib/engineyard-cloud-client/version.rb @@ -1,7 +1,7 @@ # This file is maintained by a herd of rabid monkeys with Rakes. module EY class CloudC...
Add .pre for next release
diff --git a/spec/controllers/products_controller_spec.rb b/spec/controllers/products_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/products_controller_spec.rb +++ b/spec/controllers/products_controller_spec.rb @@ -14,7 +14,7 @@ it 'returns the correct content type' do subject - ...
Fix content type spec on Rails 6 Rails 6 appends the charset to the content type of the response, so we need to parse the content type properly in our test.
diff --git a/spec/fixtures/dummy_rails_app/application.rb b/spec/fixtures/dummy_rails_app/application.rb index abc1234..def5678 100644 --- a/spec/fixtures/dummy_rails_app/application.rb +++ b/spec/fixtures/dummy_rails_app/application.rb @@ -1,5 +1,5 @@ Rails = Class.new do - require "#{File.dirname(__FILE__)}/dummy_ap...
Fix test which did not work in all cases.
diff --git a/spec/views/mentorships/show.html.erb_spec.rb b/spec/views/mentorships/show.html.erb_spec.rb index abc1234..def5678 100644 --- a/spec/views/mentorships/show.html.erb_spec.rb +++ b/spec/views/mentorships/show.html.erb_spec.rb @@ -12,6 +12,8 @@ end it "renders attributes in <p>" do + pending "I don'...
Change another view spec to pending
diff --git a/files/chef-marketplace-cookbooks/chef-marketplace/recipes/enable.rb b/files/chef-marketplace-cookbooks/chef-marketplace/recipes/enable.rb index abc1234..def5678 100644 --- a/files/chef-marketplace-cookbooks/chef-marketplace/recipes/enable.rb +++ b/files/chef-marketplace-cookbooks/chef-marketplace/recipes/e...
Update MOTD at the beginning of the chef-client run
diff --git a/spec/support/custom_matchers/response_matchers.rb b/spec/support/custom_matchers/response_matchers.rb index abc1234..def5678 100644 --- a/spec/support/custom_matchers/response_matchers.rb +++ b/spec/support/custom_matchers/response_matchers.rb @@ -1,7 +1,89 @@-RSpec::Matchers.define :respond_with_redirect_...
Add custom controller matchers for status
diff --git a/app/helpers/dashboard_helper.rb b/app/helpers/dashboard_helper.rb index abc1234..def5678 100644 --- a/app/helpers/dashboard_helper.rb +++ b/app/helpers/dashboard_helper.rb @@ -9,21 +9,8 @@ end if defined?(Graphite) - def elective_block_enrollment_status(elective_mod) - if current_user.studen...
Move enrollment_info method into separate module Change-Id: I74102b677b097a105fb472c6f2c1aea35ed06ee0
diff --git a/KeenClientTD.podspec b/KeenClientTD.podspec index abc1234..def5678 100644 --- a/KeenClientTD.podspec +++ b/KeenClientTD.podspec @@ -2,7 +2,7 @@ spec.name = 'KeenClientTD' spec.version = '3.2.28' spec.license = { :type => 'MIT' } - spec.platforms = { :ios => "", :tvos => "" } +...
Set minimum iOS version on `platform` in the podspec file
diff --git a/app/models/flexibility_order.rb b/app/models/flexibility_order.rb index abc1234..def5678 100644 --- a/app/models/flexibility_order.rb +++ b/app/models/flexibility_order.rb @@ -1,7 +1,9 @@ class FlexibilityOrder def self.all %w(power_to_power + mv_batteries electric_vehicle + opa...
Update flexibility order with new flex options
diff --git a/lib/file_blobs_rails/action_controller_data_streaming_extensions.rb b/lib/file_blobs_rails/action_controller_data_streaming_extensions.rb index abc1234..def5678 100644 --- a/lib/file_blobs_rails/action_controller_data_streaming_extensions.rb +++ b/lib/file_blobs_rails/action_controller_data_streaming_exten...
Make send_file_blob protected, because send_data is also protected.
diff --git a/app/commands/v2/put_link_set.rb b/app/commands/v2/put_link_set.rb index abc1234..def5678 100644 --- a/app/commands/v2/put_link_set.rb +++ b/app/commands/v2/put_link_set.rb @@ -4,22 +4,17 @@ def call validate! - content_id = links_params.fetch(:content_id) + content_id = link_...
Allow the creation of linksets without a content item. We can only currently speculate about the exact workflows, i.e. whether links might be sent to the publishing API before the main content item. Since we don't have a confirmed need for constraining the order of the pushes, we've opted to leave the system open (an...
diff --git a/.chef/cookbook/_box/recipes/module_igbinary.rb b/.chef/cookbook/_box/recipes/module_igbinary.rb index abc1234..def5678 100644 --- a/.chef/cookbook/_box/recipes/module_igbinary.rb +++ b/.chef/cookbook/_box/recipes/module_igbinary.rb @@ -10,5 +10,9 @@ end link '/etc/php5/conf.d/20-igbinary.ini' do - to '...
Make final optimizations for the igbinary recipe
diff --git a/lib/bandicoot.rb b/lib/bandicoot.rb index abc1234..def5678 100644 --- a/lib/bandicoot.rb +++ b/lib/bandicoot.rb @@ -7,10 +7,10 @@ # Your code goes here... module Bandicoot - attr_reader :config + mattr_accessor :config def self.included(receiver) - config = Config.new + self.config = Config...
Add mattr accessor to main module
diff --git a/lib/bak-shell.rb b/lib/bak-shell.rb index abc1234..def5678 100644 --- a/lib/bak-shell.rb +++ b/lib/bak-shell.rb @@ -11,8 +11,7 @@ require "rainbow/ext/string" module BakShell - # BACKUP_DIR = File.expand_path(File.join(ENV["HOME"], "bak")) - BACKUP_DIR = File.expand_path(File.join(ENV["HOME"], "tmp", ...
Change the default backup dir
diff --git a/app/adapters/alma_adapter/marc_response.rb b/app/adapters/alma_adapter/marc_response.rb index abc1234..def5678 100644 --- a/app/adapters/alma_adapter/marc_response.rb +++ b/app/adapters/alma_adapter/marc_response.rb @@ -6,15 +6,34 @@ # @param bibs [Alma::BibSet] def initialize(bibs:) @bibs ...
Refactor MARCResponse to return objects we control. This should allow us to enrich the output in an OO way.
diff --git a/app/controllers/api/editions_controller.rb b/app/controllers/api/editions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/editions_controller.rb +++ b/app/controllers/api/editions_controller.rb @@ -1,7 +1,11 @@ class Api::EditionsController < ApplicationController - + only_allow_acce...
Add authz - only admin can download an edition
diff --git a/lib/cuba/mote.rb b/lib/cuba/mote.rb index abc1234..def5678 100644 --- a/lib/cuba/mote.rb +++ b/lib/cuba/mote.rb @@ -1,31 +1,7 @@-# borrowed from: -# https://github.com/harmoni-io/mote-render/blob/master/lib/mote/render.rb module Mout module Render - include ::Mote::Helpers - def self.setup(app)...
Set the Cuba application templating engine to Mote. That is really all the plugin should do. Nothing more.
diff --git a/lib/gothonweb.rb b/lib/gothonweb.rb index abc1234..def5678 100644 --- a/lib/gothonweb.rb +++ b/lib/gothonweb.rb @@ -1,3 +1,5 @@+gem 'sinatra', '1.3.6' + require_relative "gothonweb/version" require_relative "map" require "sinatra"
Add gem dependency at the top
diff --git a/lib/onix/name.rb b/lib/onix/name.rb index abc1234..def5678 100644 --- a/lib/onix/name.rb +++ b/lib/onix/name.rb @@ -6,19 +6,21 @@ xml_name "Name" - xml_accessor :person_name_type, :from => "PersonNameType", :as => Fixnum, :to_xml => ONIX::Formatters.two_digit - xml_accessor :person_name, ...
Correct mapping of PersonNameIdentifier under Name
diff --git a/lib/opencl/cl.rb b/lib/opencl/cl.rb index abc1234..def5678 100644 --- a/lib/opencl/cl.rb +++ b/lib/opencl/cl.rb @@ -48,8 +48,8 @@ queues.first end - def create_buffer(type, size, options = 0) - options ||= CL_MEM_READ_ONLY | CL_MEM_COPY_HOST_PTR + def create_buffer(type, size, optio...
Use the host pointer over copying by default when creating a buffer This continues to make the contents at the buffer's host pointer modifiable until a kernel actually uses it.
diff --git a/lib/active_job/queue_adapters/sidekiq_adapter.rb b/lib/active_job/queue_adapters/sidekiq_adapter.rb index abc1234..def5678 100644 --- a/lib/active_job/queue_adapters/sidekiq_adapter.rb +++ b/lib/active_job/queue_adapters/sidekiq_adapter.rb @@ -5,8 +5,11 @@ class SidekiqAdapter class << self ...
Remove all Sidekiq-specific stuff from job, enable retries by default
diff --git a/lib/log/event.rb b/lib/log/event.rb index abc1234..def5678 100644 --- a/lib/log/event.rb +++ b/lib/log/event.rb @@ -3,7 +3,7 @@ module Log class Event - def initialize(name, monitored=false, context={}) + def initialize(name, context, monitored: false) @name = name @monitored = mo...
Make monitored a keyword argument
diff --git a/app/models/link.rb b/app/models/link.rb index abc1234..def5678 100644 --- a/app/models/link.rb +++ b/app/models/link.rb @@ -4,7 +4,7 @@ field :url, :type => String - references_many :comments + references_many :comments, :dependent => :destroy referenced_in :user validates :url, :presence =...
Add deletion dependency to comments
diff --git a/lib/rom/model.rb b/lib/rom/model.rb index abc1234..def5678 100644 --- a/lib/rom/model.rb +++ b/lib/rom/model.rb @@ -1,3 +1,5 @@+require 'charlatan' + module ROM module Model class ValidationError < CommandError
Add charlatan as a dep
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -17,6 +17,29 @@ has_gravatar :size => '80', :secure => false + # Public: Determine whether this user has voted on a given object before. + # + # This method examines the colle...
Add voted_on? method and tomdoc all methods
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,9 +1,9 @@ class User < ApplicationRecord HONORIFICS = %w( - Miss Mr. + Ms. Mrs. - Ms. + Dr. ).freeze # Include default devise modules. Others availa...
Remove Miss and add Dr to honorifics
diff --git a/lib/srvrouter.rb b/lib/srvrouter.rb index abc1234..def5678 100644 --- a/lib/srvrouter.rb +++ b/lib/srvrouter.rb @@ -25,6 +25,6 @@ answers.each do |ans| ret << "#{ans.target}:#{ans.port}" end - return ret + return ret.sort end end
Sort DNS results for less config file updates
diff --git a/app/decorators/author_decorator.rb b/app/decorators/author_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/author_decorator.rb +++ b/app/decorators/author_decorator.rb @@ -20,6 +20,10 @@ source.try :image end + def link + author_path(source) + end + def large_image sou...
Add link to author decorator
diff --git a/lib/cuba/render.rb b/lib/cuba/render.rb index abc1234..def5678 100644 --- a/lib/cuba/render.rb +++ b/lib/cuba/render.rb @@ -34,7 +34,7 @@ # def render(template, locals = {}, options = {}, &block) _cache.fetch(template) { - Tilt.new(template, 1, options) + Tilt.new(template, 1,...
Add output variable for Tilt (tizoc).
diff --git a/config/initializers/themenap.rb b/config/initializers/themenap.rb index abc1234..def5678 100644 --- a/config/initializers/themenap.rb +++ b/config/initializers/themenap.rb @@ -7,7 +7,7 @@ :text => '<%= render "layouts/css_includes" %>', :mode => :append }, { :css => 'body', - :mode =...
Set ADA colour theme correctly.
diff --git a/lib/car_guard.rb b/lib/car_guard.rb index abc1234..def5678 100644 --- a/lib/car_guard.rb +++ b/lib/car_guard.rb @@ -20,7 +20,7 @@ end post "/map/:api_key" do - Location.create(JSON.parse(request.body.read)) + Location.create(JSON.parse(request.body.read).merge(api_key: params[:api_key])) ...
Save api key as well.
diff --git a/lib/dynadot/api.rb b/lib/dynadot/api.rb index abc1234..def5678 100644 --- a/lib/dynadot/api.rb +++ b/lib/dynadot/api.rb @@ -20,10 +20,14 @@ data = response.parsed_response.split("\n") data.delete_at(1) - return { - error: data[0, 2] != 'ok' ? data.shift.split(",")[1] : ni...
Raise an exception if API call returns an error
diff --git a/Library/Homebrew/compat/tap.rb b/Library/Homebrew/compat/tap.rb index abc1234..def5678 100644 --- a/Library/Homebrew/compat/tap.rb +++ b/Library/Homebrew/compat/tap.rb @@ -22,13 +22,13 @@ new_path = path new_remote = default_remote - ohai "Migrating Tap #{old_name} to #{new_name} …" + ohai...
Use `...` instead of ellipsis and only output if TTY.
diff --git a/lib/githubber.rb b/lib/githubber.rb index abc1234..def5678 100644 --- a/lib/githubber.rb +++ b/lib/githubber.rb @@ -10,7 +10,7 @@ module Githubber # Your code goes here... class App - + attr_reader :teams, :issues def initialize puts "What is your auth token?" token = gets.chomp ...
Add attr_reader for team and issues
diff --git a/lib/gui/event.rb b/lib/gui/event.rb index abc1234..def5678 100644 --- a/lib/gui/event.rb +++ b/lib/gui/event.rb @@ -0,0 +1,94 @@+# Copyright 2014 Noel Cower +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You m...
Add a basic Event class.
diff --git a/config/boot.rb b/config/boot.rb index abc1234..def5678 100644 --- a/config/boot.rb +++ b/config/boot.rb @@ -6,6 +6,11 @@ require 'rubygems' unless defined?(Gem) require 'bundler/setup' Bundler.require(:default, RACK_ENV) + +if File.exist? 'config/app-cfg-params.yml' + conf_params = YAML.load_file 'confi...
Load application configuration parameters from file.
diff --git a/font-awesome-rails.gemspec b/font-awesome-rails.gemspec index abc1234..def5678 100644 --- a/font-awesome-rails.gemspec +++ b/font-awesome-rails.gemspec @@ -15,7 +15,7 @@ gem.require_paths = ["lib"] gem.version = FontAwesome::Rails::VERSION - gem.add_dependency "railties", ">= 3.2", "< 5.0" + ...
Raise railties dependency to be compatible with Rails 5 Signed-off-by: Clemens Gruber <dda41f46a19317797d2fa2442dc67d1578f8ace9@gmail.com>
diff --git a/lib/pcap/dumper.rb b/lib/pcap/dumper.rb index abc1234..def5678 100644 --- a/lib/pcap/dumper.rb +++ b/lib/pcap/dumper.rb @@ -6,19 +6,28 @@ module PCap class Dumper < FFI::MemoryPointer - def self.open(path) + def initialize(dumper) + @dumper = dumper end def tell - ...
Make Dumper more like Handler in how it wraps around a pointer.
diff --git a/lib/skyed/git.rb b/lib/skyed/git.rb index abc1234..def5678 100644 --- a/lib/skyed/git.rb +++ b/lib/skyed/git.rb @@ -14,7 +14,7 @@ ENV['GIT_SSH'] = '/tmp/ssh-git' path = "/tmp/skyed.#{SecureRandom.hex}" r = ::Git.clone(stack[:custom_cookbooks_source][:url], path) - puts repo...
INF-941: Add check if remore is cloned
diff --git a/lib/spinach/dsl.rb b/lib/spinach/dsl.rb index abc1234..def5678 100644 --- a/lib/spinach/dsl.rb +++ b/lib/spinach/dsl.rb @@ -37,8 +37,6 @@ # @return [String] this feature's name # - def feature_name - @feature_name - end + attr_reader :feature_name end end
Refactor DSL to use attr_reader instead of defining a method
diff --git a/app/synchronizers/solidus_mailchimp_sync/product_synchronizer.rb b/app/synchronizers/solidus_mailchimp_sync/product_synchronizer.rb index abc1234..def5678 100644 --- a/app/synchronizers/solidus_mailchimp_sync/product_synchronizer.rb +++ b/app/synchronizers/solidus_mailchimp_sync/product_synchronizer.rb @@ ...
Allow patch for updating products
diff --git a/lib/tic_tac_toe.rb b/lib/tic_tac_toe.rb index abc1234..def5678 100644 --- a/lib/tic_tac_toe.rb +++ b/lib/tic_tac_toe.rb @@ -13,6 +13,14 @@ end class Board + @@win_places = [[0, 1, 2], + [3, 4, 5], + [6, 7, 8], + [0, 3, 6], + ...
Add data about winning index sets to Board
diff --git a/spec/lib/commands/edit_command_spec.rb b/spec/lib/commands/edit_command_spec.rb index abc1234..def5678 100644 --- a/spec/lib/commands/edit_command_spec.rb +++ b/spec/lib/commands/edit_command_spec.rb @@ -6,23 +6,27 @@ it 'edits the Markdo root in your preferred editor' do skip 'Shellwords not su...
Refactor: Replace data clump with class (in EditCommand)
diff --git a/spec/models/course/achievement_spec.rb b/spec/models/course/achievement_spec.rb index abc1234..def5678 100644 --- a/spec/models/course/achievement_spec.rb +++ b/spec/models/course/achievement_spec.rb @@ -2,15 +2,12 @@ RSpec.describe Course::Achievement, type: :model do it { is_expected.to have_many :c...
Use shoulda to test achievement validations and its associations.
diff --git a/spec/features/public_access_spec.rb b/spec/features/public_access_spec.rb index abc1234..def5678 100644 --- a/spec/features/public_access_spec.rb +++ b/spec/features/public_access_spec.rb @@ -0,0 +1,42 @@+require "rails_helper" + +feature "Public access to pages", type: :feature do + scenario "visitor can...
Test to check you can access pages when not signed in
diff --git a/spec/support/integration_context.rb b/spec/support/integration_context.rb index abc1234..def5678 100644 --- a/spec/support/integration_context.rb +++ b/spec/support/integration_context.rb @@ -1,9 +1,13 @@ shared_context "integration" do let :api do + ENV['API_URL'] = ENV['API_URL'] || 'https://store-...
Set default environment vars to run recorded tests without config Also fixes the 1.8.7 killing syntax that was exploding Travis CI.
diff --git a/lib/inherited_resources/dumb_responder.rb b/lib/inherited_resources/dumb_responder.rb index abc1234..def5678 100644 --- a/lib/inherited_resources/dumb_responder.rb +++ b/lib/inherited_resources/dumb_responder.rb @@ -6,7 +6,7 @@ class DumbResponder instance_methods.each do |m| - undef_method m...
Fix warning message on DumbResponder Signed-off-by: José Valim <0c2436ea76ed86e37cc05f66dea18d48ef390882@gmail.com>
diff --git a/db/migrate/20110902203823_add_allowed_children_cache_to_pages.rb b/db/migrate/20110902203823_add_allowed_children_cache_to_pages.rb index abc1234..def5678 100644 --- a/db/migrate/20110902203823_add_allowed_children_cache_to_pages.rb +++ b/db/migrate/20110902203823_add_allowed_children_cache_to_pages.rb @@ ...
Set a sensible limit to the allowed_children_cache column (esp important for DB/2). Fixes GH-309.
diff --git a/db/migrate/20210312061728_add_replica_identity_for_pseudonyms.rb b/db/migrate/20210312061728_add_replica_identity_for_pseudonyms.rb index abc1234..def5678 100644 --- a/db/migrate/20210312061728_add_replica_identity_for_pseudonyms.rb +++ b/db/migrate/20210312061728_add_replica_identity_for_pseudonyms.rb @@ ...
Set up replica identity index for Pseudonym refs FOO-1171 flag=none test plan: - migration works up and down - tests pass Change-Id: I523528da85d0e3170e7b9d32b9e0a011987ae5d8 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/260533 Tested-by: Service Cloud Jenkins <9144042a601061f88f1e1d7a1753ea3e2972119d...
diff --git a/spec/bulk_processor/row_chunker/boundary_spec.rb b/spec/bulk_processor/row_chunker/boundary_spec.rb index abc1234..def5678 100644 --- a/spec/bulk_processor/row_chunker/boundary_spec.rb +++ b/spec/bulk_processor/row_chunker/boundary_spec.rb @@ -11,13 +11,15 @@ context 'when values differ on either sid...
Clean up CSV construction in specs
diff --git a/spec/features/admin/promotion_rule_store_spec.rb b/spec/features/admin/promotion_rule_store_spec.rb index abc1234..def5678 100644 --- a/spec/features/admin/promotion_rule_store_spec.rb +++ b/spec/features/admin/promotion_rule_store_spec.rb @@ -9,7 +9,11 @@ it "Can add a store rule to a promotion" do ...
Fix for removed select2 on Solidus 2.3+
diff --git a/test/integration/woeid_test.rb b/test/integration/woeid_test.rb index abc1234..def5678 100644 --- a/test/integration/woeid_test.rb +++ b/test/integration/woeid_test.rb @@ -18,10 +18,10 @@ end end - it "returns a hard 404 error if woeid is not a valid woeid" do + it "returns a hard 404 error if w...
Remove the need for a comment by rewording test
diff --git a/mygithub.gemspec b/mygithub.gemspec index abc1234..def5678 100644 --- a/mygithub.gemspec +++ b/mygithub.gemspec @@ -16,4 +16,8 @@ gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) } gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_paths = ["lib"] + + ...
Add dependency 'thor', 'milkode', 'github_api'
diff --git a/app/models/fluentd/setting/in_forward.rb b/app/models/fluentd/setting/in_forward.rb index abc1234..def5678 100644 --- a/app/models/fluentd/setting/in_forward.rb +++ b/app/models/fluentd/setting/in_forward.rb @@ -20,6 +20,13 @@ :bind, :port ] end + + def hidden_options + ...
Drop TLS support for now Signed-off-by: Kenji Okimoto <7a4b90a0a1e6fc688adec907898b6822ce215e6c@clear-code.com>
diff --git a/i18n-hygiene.gemspec b/i18n-hygiene.gemspec index abc1234..def5678 100644 --- a/i18n-hygiene.gemspec +++ b/i18n-hygiene.gemspec @@ -9,4 +9,5 @@ s.homepage ='https://github.com/conversation/i18n-hygiene' s.add_dependency 'i18n', ['~> 0.6', '>= 0.6.9'] + s.add_development_dependency 'rspec', '~> 3.0'...
Add development dependency on rspec
diff --git a/app/controllers/application.rb b/app/controllers/application.rb index abc1234..def5678 100644 --- a/app/controllers/application.rb +++ b/app/controllers/application.rb @@ -10,6 +10,7 @@ before_filter :can_create?, :only => [:new, :create] before_filter :can_edit?, :only => [:edit, :update, :destroy]...
Load current_network in an ApplicationController before_filter
diff --git a/app/helpers/markdown_helper.rb b/app/helpers/markdown_helper.rb index abc1234..def5678 100644 --- a/app/helpers/markdown_helper.rb +++ b/app/helpers/markdown_helper.rb @@ -7,7 +7,7 @@ #TODO if local_resources # Local photo embeds - markdown.gsub!(/!\[([^\[\]]*)\] ?\...
Update other regexes to work
diff --git a/files/private-chef-cookbooks/private-chef/recipes/show_config.rb b/files/private-chef-cookbooks/private-chef/recipes/show_config.rb index abc1234..def5678 100644 --- a/files/private-chef-cookbooks/private-chef/recipes/show_config.rb +++ b/files/private-chef-cookbooks/private-chef/recipes/show_config.rb @@ ...
Change of show-config recipe to point at new chef-server.rb
diff --git a/app/models/sighting_adapter.rb b/app/models/sighting_adapter.rb index abc1234..def5678 100644 --- a/app/models/sighting_adapter.rb +++ b/app/models/sighting_adapter.rb @@ -0,0 +1,36 @@+class SightingAdapter + class << self + HOST = ENV['API_URL'] + PATH = '/biomap/sightings' + + def all + co...
Add adapter class to get data from server Parsing will be a separate class.
diff --git a/lib/rusic/cli.rb b/lib/rusic/cli.rb index abc1234..def5678 100644 --- a/lib/rusic/cli.rb +++ b/lib/rusic/cli.rb @@ -1,6 +1,8 @@ require 'thor' require 'pathname' require 'filewatcher' +require 'json' +require 'awesome_print' module Rusic class CLI < Thor @@ -36,6 +38,20 @@ end end + + ...
Add a settings action to print .rusic file
diff --git a/jekyll_prism.gemspec b/jekyll_prism.gemspec index abc1234..def5678 100644 --- a/jekyll_prism.gemspec +++ b/jekyll_prism.gemspec @@ -13,7 +13,7 @@ s.files = `git ls-files`.split s.test_files = `git ls-files spec/*`.split - s.add_dependency 'liquid', '~> 2.6.1' + s.add_dependency 'liquid', '~...
Revert "jekyll joins the future" This reverts commit 19b7d2a77a425456425f6aa04e6c3aba02e81785.
diff --git a/attributes/source.rb b/attributes/source.rb index abc1234..def5678 100644 --- a/attributes/source.rb +++ b/attributes/source.rb @@ -17,7 +17,9 @@ # limitations under the License. # -default['git']['version'] = "1.7.12" -default['git']['url'] = "https://github.com/gitster/git/tarball/v#{node['git']['vers...
Update Git to version 1.8.0
diff --git a/auth/app/controllers/users_controller.rb b/auth/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/auth/app/controllers/users_controller.rb +++ b/auth/app/controllers/users_controller.rb @@ -21,8 +21,7 @@ end update.wants.html { redirect_to account_url } - - update.flash I18n.t...
Fix flash message in users controller, it should be fetched in block, otherwise message is fetched while loading controller, before any locales are loaded.
diff --git a/boot.rb b/boot.rb index abc1234..def5678 100644 --- a/boot.rb +++ b/boot.rb @@ -1,3 +1,5 @@+ENV['RACK_ENV'] ||= 'development' + $LOAD_PATH << File.dirname(__FILE__) require 'bundler/setup'
Set rack env to dev by default
diff --git a/app/models/issue_trackers/cloudfuji_tracker.rb b/app/models/issue_trackers/cloudfuji_tracker.rb index abc1234..def5678 100644 --- a/app/models/issue_trackers/cloudfuji_tracker.rb +++ b/app/models/issue_trackers/cloudfuji_tracker.rb @@ -7,6 +7,12 @@ :placeholder => "Ido ID of project to create task ...
Validate project Ido ID, store issue_type, provide url.
diff --git a/config/software/loom-ui.rb b/config/software/loom-ui.rb index abc1234..def5678 100644 --- a/config/software/loom-ui.rb +++ b/config/software/loom-ui.rb @@ -8,7 +8,7 @@ build do command "mkdir -p #{install_dir}/ui/bin" - command "cp -fpPR bin/loom-ui.sh #{install_dir}/ui/bin" + command "sed -e 's:ui/...
Update UI build to fix path to node
diff --git a/rspec-exercise/calculator.rb b/rspec-exercise/calculator.rb index abc1234..def5678 100644 --- a/rspec-exercise/calculator.rb +++ b/rspec-exercise/calculator.rb @@ -23,7 +23,7 @@ until tokens.empty? case tokens.first when /\d+/ # Integer - value = tokens.shift.to_i # consu...
Make comments unnecessary by making Tokenizer's API more expressive
diff --git a/lib/how_is/config.rb b/lib/how_is/config.rb index abc1234..def5678 100644 --- a/lib/how_is/config.rb +++ b/lib/how_is/config.rb @@ -3,14 +3,14 @@ require "yaml" module HowIs - HOME_CONFIG = File.join(Dir.home, '.config', 'how_is', 'config.yml') + HOME_CONFIG = File.join(Dir.home, ".config", "how_is", ...
Use double quotes instead of single quotes.
diff --git a/lib/mollie/method.rb b/lib/mollie/method.rb index abc1234..def5678 100644 --- a/lib/mollie/method.rb +++ b/lib/mollie/method.rb @@ -1,20 +1,22 @@ module Mollie class Method < Base - BANCONTACT = 'bancontact'.freeze - BANKTRANSFER = 'banktransfer'.freeze - BELFIUS = 'belfius'.freeze - ...
Add klarnasliceit and klarnapaylater constants in Mollie::Methods
diff --git a/cookbooks/wt_monitoring/recipes/email_heartbeat.rb b/cookbooks/wt_monitoring/recipes/email_heartbeat.rb index abc1234..def5678 100644 --- a/cookbooks/wt_monitoring/recipes/email_heartbeat.rb +++ b/cookbooks/wt_monitoring/recipes/email_heartbeat.rb @@ -11,5 +11,5 @@ cron "email_heartbeat" do hour "*/6"...
Tweak the cron job for the nagios heartbeat
diff --git a/ci_environment/docker/recipes/default.rb b/ci_environment/docker/recipes/default.rb index abc1234..def5678 100644 --- a/ci_environment/docker/recipes/default.rb +++ b/ci_environment/docker/recipes/default.rb @@ -11,15 +11,15 @@ include_recipe 'travis_build_environment' apt_repository 'docker' do - uri ...
Switch from get.docker.io over to apt.dockerproject.org
diff --git a/ci_environment/sbt/attributes/default.rb b/ci_environment/sbt/attributes/default.rb index abc1234..def5678 100644 --- a/ci_environment/sbt/attributes/default.rb +++ b/ci_environment/sbt/attributes/default.rb @@ -1,4 +1,4 @@ # 5 minutes to install sbt's own dependencies under ~/.sbt/boot. MK. default[:sbt]...
Add two more Scala versions we pre-download People seem to be testing against them
diff --git a/lib/rspec-sidekiq.rb b/lib/rspec-sidekiq.rb index abc1234..def5678 100644 --- a/lib/rspec-sidekiq.rb +++ b/lib/rspec-sidekiq.rb @@ -3,5 +3,4 @@ require "rspec/sidekiq/configuration" require "rspec/sidekiq/matchers" require "rspec/sidekiq/sidekiq" -require "rspec/sidekiq/batch" -require "rspec/sidekiq/ver...
Revert "require version file to make spec pass" This reverts commit 72ac8df5f937803c6668a87f39a6bb4b18509072.
diff --git a/lib/tasks/specs.rake b/lib/tasks/specs.rake index abc1234..def5678 100644 --- a/lib/tasks/specs.rake +++ b/lib/tasks/specs.rake @@ -10,7 +10,7 @@ end def execute_rspec_for_engine(engine_path) - system "cd #{engine_path.expand_path} && bundle exec rspec" + system "cd #{engine_pa...
Disable Knapsack when running engine RSpec tests
diff --git a/lib/webtail/stdin.rb b/lib/webtail/stdin.rb index abc1234..def5678 100644 --- a/lib/webtail/stdin.rb +++ b/lib/webtail/stdin.rb @@ -6,6 +6,7 @@ "&lt;" => "<", "&gt;" => ">", } + ENTITY_KEYS_REGEXP = Regexp.union(ENTITY_MAP.keys) def run STDIN.each do |line| @@ -22,7 +23,7...
Improve unefficient regexp in Webtail::Stdin
diff --git a/db/migrate/20151008212543_migrate_news_to_posts.rb b/db/migrate/20151008212543_migrate_news_to_posts.rb index abc1234..def5678 100644 --- a/db/migrate/20151008212543_migrate_news_to_posts.rb +++ b/db/migrate/20151008212543_migrate_news_to_posts.rb @@ -17,13 +17,15 @@ activities = RecentActivity.whe...
Fix migrating recent activities for news, keys were not being updated refs #1046
diff --git a/db/migrate/20180416223444_update_meeting_scores.rb b/db/migrate/20180416223444_update_meeting_scores.rb index abc1234..def5678 100644 --- a/db/migrate/20180416223444_update_meeting_scores.rb +++ b/db/migrate/20180416223444_update_meeting_scores.rb @@ -0,0 +1,8 @@+class UpdateMeetingScores < ActiveRecord::M...
Migrate meeting stances to 'yes'
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -18,6 +18,8 @@ # limitations under the License. # +Chef::Log.error('The default rundeck recipe is for testing purposes only. Caveat emptor.') + rundeck node['rundeck']['node_name']...
Add an message about only using this for testing (for now).
diff --git a/spec/lib/project_statuses_trimmer_spec.rb b/spec/lib/project_statuses_trimmer_spec.rb index abc1234..def5678 100644 --- a/spec/lib/project_statuses_trimmer_spec.rb +++ b/spec/lib/project_statuses_trimmer_spec.rb @@ -14,7 +14,7 @@ end it 'reduces the number of project statuses to the newest N request...
Fix broken test for payload_log_entry trimming [#92367008]
diff --git a/lib/rrj/janus/type_data.rb b/lib/rrj/janus/type_data.rb index abc1234..def5678 100644 --- a/lib/rrj/janus/type_data.rb +++ b/lib/rrj/janus/type_data.rb @@ -0,0 +1,21 @@+# frozen_string_literal: true + +module RubyRabbitmqJanus + # Format data with type corresponding + class TypeData + def initialize(t...
Add class for casting a format to string
diff --git a/lib/seed_scatter/engine.rb b/lib/seed_scatter/engine.rb index abc1234..def5678 100644 --- a/lib/seed_scatter/engine.rb +++ b/lib/seed_scatter/engine.rb @@ -5,7 +5,12 @@ paths["db/seeds.rb"].each do |seed_file| puts seed_file load(seed_file) + if ActiveRecord::Base.connection....
Reset sequences after running creates for Postgres.
diff --git a/lib/suppliers/tib/order.rb b/lib/suppliers/tib/order.rb index abc1234..def5678 100644 --- a/lib/suppliers/tib/order.rb +++ b/lib/suppliers/tib/order.rb @@ -12,11 +12,14 @@ tib_prefix = 3 end + logger.debug "------------ Prefix = #{config.order_prefix}" + logger.debug "------------ tib_pr...
TIB: Add logger info for tib_prefix
diff --git a/lib/tasks/backend_ids.rake b/lib/tasks/backend_ids.rake index abc1234..def5678 100644 --- a/lib/tasks/backend_ids.rake +++ b/lib/tasks/backend_ids.rake @@ -1,7 +1,13 @@ namespace :backend_ids do task fix: :environment do affected_base_paths = %w( - /government/statistics/announcements/farming-...
Revert "Correct backend_id for statistics pages"
diff --git a/test/integration/search_test.rb b/test/integration/search_test.rb index abc1234..def5678 100644 --- a/test/integration/search_test.rb +++ b/test/integration/search_test.rb @@ -35,6 +35,33 @@ end end + test 'no published posts should be hide' do + create_post(site: @current_site, + ...
Add a test for not published post
diff --git a/lib/timestamp_api/utils.rb b/lib/timestamp_api/utils.rb index abc1234..def5678 100644 --- a/lib/timestamp_api/utils.rb +++ b/lib/timestamp_api/utils.rb @@ -1,7 +1,7 @@ module TimestampAPI module Utils def camelize(symbol) - symbol.to_s.split('_').each_with_index.map{ |chunk, idx| idx == 0 ? ch...
Fix a bug where camelization did not properly force first letter to be lowercase
diff --git a/test/lib/tasks/code_quality_html_reports_test.rb b/test/lib/tasks/code_quality_html_reports_test.rb index abc1234..def5678 100644 --- a/test/lib/tasks/code_quality_html_reports_test.rb +++ b/test/lib/tasks/code_quality_html_reports_test.rb @@ -0,0 +1,26 @@+# frozen_string_literal: true +require 'test_helpe...
Cover rake tasks with tests
diff --git a/test/rubygems/comparator/test_spec_comparator.rb b/test/rubygems/comparator/test_spec_comparator.rb index abc1234..def5678 100644 --- a/test/rubygems/comparator/test_spec_comparator.rb +++ b/test/rubygems/comparator/test_spec_comparator.rb @@ -19,6 +19,15 @@ end def test_licenses_comparison - ass...
Test the full license report
diff --git a/core/app/models/spree/stock/splitter/weight.rb b/core/app/models/spree/stock/splitter/weight.rb index abc1234..def5678 100644 --- a/core/app/models/spree/stock/splitter/weight.rb +++ b/core/app/models/spree/stock/splitter/weight.rb @@ -2,8 +2,6 @@ module Stock module Splitter class Weight < S...
Remove redundant attr_reader from Splitter::Weight These attributes were already declared on the superclass
diff --git a/test/the_community_farm_test.rb b/test/the_community_farm_test.rb index abc1234..def5678 100644 --- a/test/the_community_farm_test.rb +++ b/test/the_community_farm_test.rb @@ -1,11 +1,7 @@ require 'test_helper' -class TheCommunityFarmTest < Minitest::Test - def test_that_it_has_a_version_number - ref...
Switch to describe syntax in tests