diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/redmine_git_hosting/patches/user_patch.rb b/lib/redmine_git_hosting/patches/user_patch.rb index abc1234..def5678 100644 --- a/lib/redmine_git_hosting/patches/user_patch.rb +++ b/lib/redmine_git_hosting/patches/user_patch.rb @@ -7,17 +7,37 @@ base.class_eval do unloadable + ...
Update projects when locking/unlocking user
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,5 +1,7 @@-require 'bundler' -Bundler.require :development, :test +ENV['RAILS_ENV'] ||= 'test' +ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__) +require 'bu...
Allow non bundle exec `$ ruby -I"test:lib" ...` test style to work.
diff --git a/db/migrate/20220626134554_remove_ban_related_field_from_users.rb b/db/migrate/20220626134554_remove_ban_related_field_from_users.rb index abc1234..def5678 100644 --- a/db/migrate/20220626134554_remove_ban_related_field_from_users.rb +++ b/db/migrate/20220626134554_remove_ban_related_field_from_users.rb @@ ...
Remove old ban fields from user table
diff --git a/test/integration/instrumentation_test.rb b/test/integration/instrumentation_test.rb index abc1234..def5678 100644 --- a/test/integration/instrumentation_test.rb +++ b/test/integration/instrumentation_test.rb @@ -28,23 +28,23 @@ def test_does_not_log_counter_on_exception begin - ActiveSupport:...
Simplify instrumentation for exception tests
diff --git a/test/html5/test_scrub.rb b/test/html5/test_scrub.rb index abc1234..def5678 100644 --- a/test/html5/test_scrub.rb +++ b/test/html5/test_scrub.rb @@ -4,7 +4,7 @@ include Loofah def test_scrub_css - assert Loofah::HTML5::Scrub.scrub_css("background: #ABC012"), "background: #ABC012" - assert Loofa...
Fix test for style attribute scrubbing
diff --git a/test/unit/support/shared/base_context.rb b/test/unit/support/shared/base_context.rb index abc1234..def5678 100644 --- a/test/unit/support/shared/base_context.rb +++ b/test/unit/support/shared/base_context.rb @@ -25,6 +25,6 @@ f.flush end - return Pathname.new(f.path) + return Pathname.ne...
Fix issue with Tempfile in test being deleted
diff --git a/test/test_girl_friday.rb b/test/test_girl_friday.rb index abc1234..def5678 100644 --- a/test/test_girl_friday.rb +++ b/test/test_girl_friday.rb @@ -9,8 +9,8 @@ describe '.status' do before do - q1 = GirlFriday::Queue.new(:q1) do; end - q2 = GirlFriday::Queue.new(:q2) do; end + ...
Remove 'assigned but unused variable' warning Ruby 2.0.0-preview2
diff --git a/api/app/serializers/relation_info_serializer.rb b/api/app/serializers/relation_info_serializer.rb index abc1234..def5678 100644 --- a/api/app/serializers/relation_info_serializer.rb +++ b/api/app/serializers/relation_info_serializer.rb @@ -6,8 +6,8 @@ data = super data['start_date'] = object.st...
Fix for non existing relation_type
diff --git a/app/workers/fetch_developer_languages_worker.rb b/app/workers/fetch_developer_languages_worker.rb index abc1234..def5678 100644 --- a/app/workers/fetch_developer_languages_worker.rb +++ b/app/workers/fetch_developer_languages_worker.rb @@ -9,8 +9,11 @@ # Update languages in a transaction block Dev...
Add rescue block and remove unless
diff --git a/lib/generators/templates/controllers/registrations_controller.rb b/lib/generators/templates/controllers/registrations_controller.rb index abc1234..def5678 100644 --- a/lib/generators/templates/controllers/registrations_controller.rb +++ b/lib/generators/templates/controllers/registrations_controller.rb @@ ...
Use some other existing constant for verifier
diff --git a/lib/impressionist/models/mongoid/impressionist/impressionable.rb b/lib/impressionist/models/mongoid/impressionist/impressionable.rb index abc1234..def5678 100644 --- a/lib/impressionist/models/mongoid/impressionist/impressionable.rb +++ b/lib/impressionist/models/mongoid/impressionist/impressionable.rb @@ ...
Refactor override of impressionist_count for mongoid compatibility to fit the same style as the default AR version
diff --git a/test/unit/charge_and_ship_order_command_test.rb b/test/unit/charge_and_ship_order_command_test.rb index abc1234..def5678 100644 --- a/test/unit/charge_and_ship_order_command_test.rb +++ b/test/unit/charge_and_ship_order_command_test.rb @@ -0,0 +1,69 @@+#-- +# Project: google_checkout4r +# File: tes...
Add support for ChargeAndShipOrder command
diff --git a/spec/dummy/config/initializers/feedy.rb b/spec/dummy/config/initializers/feedy.rb index abc1234..def5678 100644 --- a/spec/dummy/config/initializers/feedy.rb +++ b/spec/dummy/config/initializers/feedy.rb @@ -1,3 +1,3 @@-Feedy.anonymous_feedback = false +Feedy.anonymous_feedback = true Feedy.user_class = "...
Use anonymous feedback for the dummy app
diff --git a/spec/features/campaign_articles_spec.rb b/spec/features/campaign_articles_spec.rb index abc1234..def5678 100644 --- a/spec/features/campaign_articles_spec.rb +++ b/spec/features/campaign_articles_spec.rb @@ -18,4 +18,10 @@ visit "/campaigns/#{campaign.slug}/articles" expect(page).to have_content('...
Add test for 'too many articles' handling on Campaign articles tab
diff --git a/spec/lib/attributes/association_spec.rb b/spec/lib/attributes/association_spec.rb index abc1234..def5678 100644 --- a/spec/lib/attributes/association_spec.rb +++ b/spec/lib/attributes/association_spec.rb @@ -0,0 +1,19 @@+describe Adminable::Attributes::Association do + let!(:reflection) do + User.refle...
Add specs for Attributes::Association class
diff --git a/config/initializers/nuclear_secrets.rb b/config/initializers/nuclear_secrets.rb index abc1234..def5678 100644 --- a/config/initializers/nuclear_secrets.rb +++ b/config/initializers/nuclear_secrets.rb @@ -20,7 +20,6 @@ shared_auth_secret: String, secret_key_base: String, secret_token: NilClass...
Remove deploy_env from required secrets. It is now optional as an extra secret. Nuclear secrets now allows optional extra secrets.
diff --git a/pages/app/controllers/refinery/pages/admin/preview_controller.rb b/pages/app/controllers/refinery/pages/admin/preview_controller.rb index abc1234..def5678 100644 --- a/pages/app/controllers/refinery/pages/admin/preview_controller.rb +++ b/pages/app/controllers/refinery/pages/admin/preview_controller.rb @@ ...
Use find_page as a before filter and use @page. The method find_page does not always returns the page. It returns he params hash in the case of hash assignation (preview existing pages). This break previews view view_templates as object methods are called in RenderOptions::render_options_for_template.
diff --git a/core/config/initializers/spree_user.rb b/core/config/initializers/spree_user.rb index abc1234..def5678 100644 --- a/core/config/initializers/spree_user.rb +++ b/core/config/initializers/spree_user.rb @@ -3,7 +3,7 @@ # are still doing for compatability, but with a warning. Spree::Core::Engine.config.to_p...
Fix initialization if Spree.user_class is not set For example, when running the install generator.
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -1,6 +1,5 @@ # This env var is set by the beforeTest action in our Jenkinsfile unless ENV.key?("RUNNING_IN_CI") # See app/tasks/seed_database - ImportOrganisations.new.call SeedDatabase.instance.run end
Remove import organisations from db:seed ImportOrganisations.new.call involves pulling data dynamically in from GOV.UK. This makes it an extremely complicated approach to seeding a database, and causes a bunch of misery in spinning up a production-like environment for GOV.UK (as is the case with publishing_e2e_tests [...
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -5,3 +5,21 @@ # # cities = City.create([{ name: 'Chicago' }, { name: 'Copenhagen' }]) # Mayor.create(name: 'Emanuel', city: cities.first) + +User.destroy_all +Experience.destroy_all + +u = User.create!( + ...
Add user and experience to seed file
diff --git a/spec/cc/engine/csslint_spec.rb b/spec/cc/engine/csslint_spec.rb index abc1234..def5678 100644 --- a/spec/cc/engine/csslint_spec.rb +++ b/spec/cc/engine/csslint_spec.rb @@ -0,0 +1,28 @@+require 'cc/engine/csslint' +require 'tmpdir' + +module CC + module Engine + describe CSSlint do + let(:code) { D...
Add spec for including only *.css files
diff --git a/ehjob_authentication.gemspec b/ehjob_authentication.gemspec index abc1234..def5678 100644 --- a/ehjob_authentication.gemspec +++ b/ehjob_authentication.gemspec @@ -19,7 +19,5 @@ s.add_dependency "omniauth" s.add_dependency "omniauth-facebook" s.add_dependency "omniauth-linkedin-oauth2" - s.add_dep...
Remove dependencies out of gem spec to avoid gems confliction
diff --git a/app/views/api/v1/relics/_relic.json.jbuilder b/app/views/api/v1/relics/_relic.json.jbuilder index abc1234..def5678 100644 --- a/app/views/api/v1/relics/_relic.json.jbuilder +++ b/app/views/api/v1/relics/_relic.json.jbuilder @@ -30,8 +30,11 @@ end json.photos relic.photos -json.place_id relic.place.id -j...
fix: Check if relic has a valid place
diff --git a/features/step_definitions/shared.rb b/features/step_definitions/shared.rb index abc1234..def5678 100644 --- a/features/step_definitions/shared.rb +++ b/features/step_definitions/shared.rb @@ -1,5 +1,5 @@ When(/^I visit the (.*) path$/) do |route| - visit eval(route.gsub(' ', '_') + '_path') + visit eval(...
Use tr instead of gsub
diff --git a/spec/models/tournament_spec.rb b/spec/models/tournament_spec.rb index abc1234..def5678 100644 --- a/spec/models/tournament_spec.rb +++ b/spec/models/tournament_spec.rb @@ -31,4 +31,29 @@ end end end + + describe "Creation" do + let(:creator) { + FactoryGirl::create(:user) + } + + ...
Add test for creatoin of initial admin for tournament The functionality was there, but was not tested
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -6,17 +6,17 @@ run_puppet_install_helper unless ENV['BEAKER_provision'] == 'no' RSpec.configure do |c| - install_module_on(hosts) - ...
Clean up acceptance spec helper
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -20,8 +20,8 @@ # Readable test descriptions c.formatter = :documentation c.before :suite do - puppet_module_install(:source =...
Remove puppet_module_install in favor of copy_module_to
diff --git a/spec/unit/result_queue_spec.rb b/spec/unit/result_queue_spec.rb index abc1234..def5678 100644 --- a/spec/unit/result_queue_spec.rb +++ b/spec/unit/result_queue_spec.rb @@ -10,6 +10,7 @@ describe "#push and #clear" do it "should add items and remove all items from the result queue" do ids = (1...
Fix another intermittent spec failure.
diff --git a/story.rb b/story.rb index abc1234..def5678 100644 --- a/story.rb +++ b/story.rb @@ -0,0 +1,35 @@+require 'yaml' + +information = YAML.load(File.open("data.yml")) + +# Extract from corpus and save in variables +def extract_paragraphs(hash) + array = [] + hash.keys.each do |key| + array << hash[key]["Pa...
Set up proof of concept program
diff --git a/vagrant-cucumber.gemspec b/vagrant-cucumber.gemspec index abc1234..def5678 100644 --- a/vagrant-cucumber.gemspec +++ b/vagrant-cucumber.gemspec @@ -26,6 +26,7 @@ s.add_runtime_dependency 'cucumber', '~>1.3.2' s.add_runtime_dependency 'to_regexp', '>=0.2.1' + s.add_runtime_dependency 'sahara',...
gemspec: Add sahara to runtime dependency
diff --git a/spec/default/etckeeper_spec.rb b/spec/default/etckeeper_spec.rb index abc1234..def5678 100644 --- a/spec/default/etckeeper_spec.rb +++ b/spec/default/etckeeper_spec.rb @@ -1,3 +1,20 @@ require 'spec_helper' # write up RSpec integration tests here +%w{ + git + etckeeper +}.each do |pkg| + describe pac...
Add integration tests for etckeeper
diff --git a/spec/resque-job_logger_spec.rb b/spec/resque-job_logger_spec.rb index abc1234..def5678 100644 --- a/spec/resque-job_logger_spec.rb +++ b/spec/resque-job_logger_spec.rb @@ -2,6 +2,10 @@ describe Resque::Plugins::JobLogger do include PerformJob + + it "complies with recommended practices" do + expect ...
[master] Add lint test to spec.
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -18,6 +18,7 @@ # Install module and dependencies hosts.each do |host| copy_module_to(host, source: proj_root, module_nam...
Add missing dependency for Beaker tests
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -18,6 +18,7 @@ on host, puppet('module', 'install', 'puppetlabs-stdlib'), { :acceptable_exit_codes => [0] } on host, puppet...
Add monitoring facts to acceptance tests
diff --git a/spec/yars/atomic_queue_spec.rb b/spec/yars/atomic_queue_spec.rb index abc1234..def5678 100644 --- a/spec/yars/atomic_queue_spec.rb +++ b/spec/yars/atomic_queue_spec.rb @@ -0,0 +1,28 @@+describe Yars::AtomicQueue do + let(:q) { Yars::AtomicQueue.new } + let(:data){ %w(one two three four) } + + describe '...
Add specs for sequential queue
diff --git a/db/migrate/20130611210815_increase_snippet_text_column_size.rb b/db/migrate/20130611210815_increase_snippet_text_column_size.rb index abc1234..def5678 100644 --- a/db/migrate/20130611210815_increase_snippet_text_column_size.rb +++ b/db/migrate/20130611210815_increase_snippet_text_column_size.rb @@ -0,0 +1,...
Increase snippet content column size. This will fix issue #3904
diff --git a/builder/test-integration/spec/hypriotos-image/base/kernel_spec.rb b/builder/test-integration/spec/hypriotos-image/base/kernel_spec.rb index abc1234..def5678 100644 --- a/builder/test-integration/spec/hypriotos-image/base/kernel_spec.rb +++ b/builder/test-integration/spec/hypriotos-image/base/kernel_spec.rb...
Fix integrations tests for kernel version Signed-off-by: Dieter Reuter <554783fc552b5b2a46dd3d7d7b9b2cce9a82c122@me.com>
diff --git a/promo/app/models/spree/user_decorator.rb b/promo/app/models/spree/user_decorator.rb index abc1234..def5678 100644 --- a/promo/app/models/spree/user_decorator.rb +++ b/promo/app/models/spree/user_decorator.rb @@ -1,5 +1,5 @@ if Spree.user_class Spree.user_class.class_eval do - has_and_belongs_to_many ...
[promo] Use join_table, not join_table name in user decorator
diff --git a/features/step_definitions/renalware/peritonitis_episodes_steps.rb b/features/step_definitions/renalware/peritonitis_episodes_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/renalware/peritonitis_episodes_steps.rb +++ b/features/step_definitions/renalware/peritonitis_episodes_steps.rb...
Add missing organism and medication to episode - these are required when the episode is revised
diff --git a/env_bang.gemspec b/env_bang.gemspec index abc1234..def5678 100644 --- a/env_bang.gemspec +++ b/env_bang.gemspec @@ -9,8 +9,8 @@ spec.authors = ["Jonathan Camenisch"] spec.email = ["jonathan@camenisch.net"] spec.summary = %q{Do a bang-up job managing your environment variables} -...
Add gem description & homepage
diff --git a/spec/models/vote_spec.rb b/spec/models/vote_spec.rb index abc1234..def5678 100644 --- a/spec/models/vote_spec.rb +++ b/spec/models/vote_spec.rb @@ -0,0 +1,19 @@+require 'spec_helper' + +describe Vote do + + it "is valid with a user_id and question_id" do + vote = Vote.new(user_id: 1, question_id: 1) + ...
Add validation tests for votes
diff --git a/edurange.gemspec b/edurange.gemspec index abc1234..def5678 100644 --- a/edurange.gemspec +++ b/edurange.gemspec @@ -27,4 +27,5 @@ gem.add_runtime_dependency "sqlite3" gem.add_runtime_dependency "thread" gem.add_runtime_dependency "erubis" + gem.add_runtime_dependency "unix-crypt" # For generating ...
Add unix-crypt gem to generate hashes
diff --git a/test/spec/connection/close.rb b/test/spec/connection/close.rb index abc1234..def5678 100644 --- a/test/spec/connection/close.rb +++ b/test/spec/connection/close.rb @@ -0,0 +1,16 @@+require_relative './connection_spec_init' + +context 'Connection' do + test 'Closing' do + socket = StringIO.new + io =...
Test connection closing in an SSL compliant way
diff --git a/db/migrate/20160524110518_add_columns_to_users.rb b/db/migrate/20160524110518_add_columns_to_users.rb index abc1234..def5678 100644 --- a/db/migrate/20160524110518_add_columns_to_users.rb +++ b/db/migrate/20160524110518_add_columns_to_users.rb @@ -2,7 +2,7 @@ def change add_column :users, :provider,...
Make Alert Layout, add provider, uid, first/last name to users
diff --git a/db/migrate/20160616094245_statistics_precision.rb b/db/migrate/20160616094245_statistics_precision.rb index abc1234..def5678 100644 --- a/db/migrate/20160616094245_statistics_precision.rb +++ b/db/migrate/20160616094245_statistics_precision.rb @@ -1,5 +1,6 @@ class StatisticsPrecision < ActiveRecord::Migra...
Remove and re-add values column
diff --git a/activemodel/lib/active_model/mass_assignment_security/sanitizer.rb b/activemodel/lib/active_model/mass_assignment_security/sanitizer.rb index abc1234..def5678 100644 --- a/activemodel/lib/active_model/mass_assignment_security/sanitizer.rb +++ b/activemodel/lib/active_model/mass_assignment_security/sanitize...
Speed up mass assignment by avoiding extra loops.
diff --git a/app/controllers/glome_oauth/oauth2_controller.rb b/app/controllers/glome_oauth/oauth2_controller.rb index abc1234..def5678 100644 --- a/app/controllers/glome_oauth/oauth2_controller.rb +++ b/app/controllers/glome_oauth/oauth2_controller.rb @@ -10,25 +10,34 @@ app_name = params[:client_id] redi...
Set client_secret, grant_type, create fake application
diff --git a/app/controllers/kebapress/hq/posts_controller.rb b/app/controllers/kebapress/hq/posts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/kebapress/hq/posts_controller.rb +++ b/app/controllers/kebapress/hq/posts_controller.rb @@ -30,7 +30,7 @@ @post = Kebapress::Post.find(params[:id]) ...
Fix published boolean attribute error
diff --git a/app/controllers/omniauth_callbacks_controller.rb b/app/controllers/omniauth_callbacks_controller.rb index abc1234..def5678 100644 --- a/app/controllers/omniauth_callbacks_controller.rb +++ b/app/controllers/omniauth_callbacks_controller.rb @@ -6,6 +6,7 @@ id = auth[:uid] login = auth[:info][:ni...
Store access token in login
diff --git a/app/controllers/user/registrations_controller.rb b/app/controllers/user/registrations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/user/registrations_controller.rb +++ b/app/controllers/user/registrations_controller.rb @@ -1,5 +1,6 @@ class User::RegistrationsController < Devise::Regis...
Fix redirect path after signup
diff --git a/app/models/manageiq/providers/storage_manager.rb b/app/models/manageiq/providers/storage_manager.rb index abc1234..def5678 100644 --- a/app/models/manageiq/providers/storage_manager.rb +++ b/app/models/manageiq/providers/storage_manager.rb @@ -15,5 +15,10 @@ :foreign_key => :parent_ems_id, ...
Define model_name with route keys for the StorageManager model
diff --git a/app/representers/api/musical_work_representer.rb b/app/representers/api/musical_work_representer.rb index abc1234..def5678 100644 --- a/app/representers/api/musical_work_representer.rb +++ b/app/representers/api/musical_work_representer.rb @@ -9,7 +9,7 @@ property :label property :album property :y...
Use duration rather than length for musical works Having a `length` property does not seem to play well with the front end
diff --git a/app/workers/asset_manager_update_asset_worker.rb b/app/workers/asset_manager_update_asset_worker.rb index abc1234..def5678 100644 --- a/app/workers/asset_manager_update_asset_worker.rb +++ b/app/workers/asset_manager_update_asset_worker.rb @@ -1,12 +1,12 @@ class AssetManagerUpdateAssetWorker < WorkerBase ...
Rename attributes -> new_attributes in AssetManagerUpdateAssetWorker I'm about to make some changes to this class and this will make them easier.
diff --git a/Casks/intellij-idea-ce.rb b/Casks/intellij-idea-ce.rb index abc1234..def5678 100644 --- a/Casks/intellij-idea-ce.rb +++ b/Casks/intellij-idea-ce.rb @@ -1,6 +1,6 @@ cask :v1 => 'intellij-idea-ce' do - version '15.0' - sha256 'e9d0f479e692463cda6ab81deda93d4145fb01968bb802a0d7be35e3e0eee73d' + version '15...
Upgrade IntelliJ IDEA CE to 15.0.1.
diff --git a/test/helpers/magic_test_helper.rb b/test/helpers/magic_test_helper.rb index abc1234..def5678 100644 --- a/test/helpers/magic_test_helper.rb +++ b/test/helpers/magic_test_helper.rb @@ -1,12 +1,38 @@ # frozen_string_literal: true module MagicTestHelpers - def capture_stderr - require 'stringio' - s...
Refactor the capture_stderr helper to capture child processes output Signed-off-by: Krzysztof Wilczyński <5f1c0be89013f8fde969a8dcb2fa1d522e94ee00@linux.com>
diff --git a/test/orm_ext/activerecord_test.rb b/test/orm_ext/activerecord_test.rb index abc1234..def5678 100644 --- a/test/orm_ext/activerecord_test.rb +++ b/test/orm_ext/activerecord_test.rb @@ -4,11 +4,33 @@ context "The ActiveRecord extension" do setup do - @account = ActiveRecordAccount.create + ...
Add some tests for the activerecord extension
diff --git a/test/unit/policy_team_test.rb b/test/unit/policy_team_test.rb index abc1234..def5678 100644 --- a/test/unit/policy_team_test.rb +++ b/test/unit/policy_team_test.rb @@ -6,15 +6,15 @@ refute policy_team.valid? end - test "should be invalid without an email" do + test "should be valid without an em...
Fix tests on policy team
diff --git a/TodUni/spec/support/project_attributes.rb b/TodUni/spec/support/project_attributes.rb index abc1234..def5678 100644 --- a/TodUni/spec/support/project_attributes.rb +++ b/TodUni/spec/support/project_attributes.rb @@ -0,0 +1,11 @@+def project_attributes(overrides = {}) + { + name: "Test project", + descrip...
Add projects_attributes support ruby class for testing
diff --git a/db/migrate/20160527152831_unset_local_authority_contact_details.rb b/db/migrate/20160527152831_unset_local_authority_contact_details.rb index abc1234..def5678 100644 --- a/db/migrate/20160527152831_unset_local_authority_contact_details.rb +++ b/db/migrate/20160527152831_unset_local_authority_contact_detail...
Delete existing local authority contact details We don't need these any more.
diff --git a/frontend/app/views/format/_canadian_highlander.rb b/frontend/app/views/format/_canadian_highlander.rb index abc1234..def5678 100644 --- a/frontend/app/views/format/_canadian_highlander.rb +++ b/frontend/app/views/format/_canadian_highlander.rb @@ -0,0 +1,12 @@+%p + %em Canadian Highlander + is an unoffic...
Add format page for Canadian Highlander
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,7 +1,7 @@ class ApplicationController < ActionController::Base include Slimmer::Header...
Allow robots to crawl reports AAIB, MAIB and RAIB have now transitioned. We now want the reports to appear in Google so they can be found by users.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -23,7 +23,8 @@ def default_url_options(options = {}) if I18n.locale != I18n.default_l...
Fix for passing along the locale param I broke this in an earlier commit...
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,6 +1,7 @@ class ApplicationController < ActionController::Base before_filter :prepar...
Add additional allowed parameters name and phone to devise controller (required for Rails 4 strong parameters).
diff --git a/app/extractors/bundestag_pdf_extractor.rb b/app/extractors/bundestag_pdf_extractor.rb index abc1234..def5678 100644 --- a/app/extractors/bundestag_pdf_extractor.rb +++ b/app/extractors/bundestag_pdf_extractor.rb @@ -16,12 +16,13 @@ .gsub("\n", ' ') .gsub(/\s+/, ' ') ...
Remove private use unicode characters from names
diff --git a/app/models/block_layout.rb b/app/models/block_layout.rb index abc1234..def5678 100644 --- a/app/models/block_layout.rb +++ b/app/models/block_layout.rb @@ -5,10 +5,12 @@ validates_presence_of :display_name - scope :default_layout, -> { BlockLayout.find_by_slug('default') } - def self.resource_des...
Move BlockLayout default_layout scope to class method Rails 6.1 adds a deprecation notice related to class level scopes in this instance.
diff --git a/app/models/organization.rb b/app/models/organization.rb index abc1234..def5678 100644 --- a/app/models/organization.rb +++ b/app/models/organization.rb @@ -9,7 +9,7 @@ before_save :add_county def add_county - return unless county.nil? && primary_address + return if county.present? || addresses...
Clean up return statement for readability
diff --git a/app/models/spree/credit_card_decorator.rb b/app/models/spree/credit_card_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/credit_card_decorator.rb +++ b/app/models/spree/credit_card_decorator.rb @@ -0,0 +1,10 @@+module Spree + module CreditCardDecorator + def set_last_digits + sel...
Add card decorator to unify method last_digits
diff --git a/app/services/start_game.rb b/app/services/start_game.rb index abc1234..def5678 100644 --- a/app/services/start_game.rb +++ b/app/services/start_game.rb @@ -40,14 +40,9 @@ end def give_players_cards - # each player picks up 5 cards @game.players.each do |player| @deck.pop(5).each do |c...
Refactor StartGame service to use convenience methods play/pickup
diff --git a/filmbuff.gemspec b/filmbuff.gemspec index abc1234..def5678 100644 --- a/filmbuff.gemspec +++ b/filmbuff.gemspec @@ -11,6 +11,7 @@ s.description = 'Film Buff provides a Ruby wrapper for IMDb\'s JSON API, ' << 'which is the fastest and easiest way to get information ' << ...
Add MIT license to gemspec
diff --git a/lib/tasks/database_record_validator.rb b/lib/tasks/database_record_validator.rb index abc1234..def5678 100644 --- a/lib/tasks/database_record_validator.rb +++ b/lib/tasks/database_record_validator.rb @@ -32,9 +32,9 @@ end end - # TODO - make this dynamic? def models - [L...
Make DatabaseRecordValidator dynamically read tables
diff --git a/lib/web_console/exception_extension.rb b/lib/web_console/exception_extension.rb index abc1234..def5678 100644 --- a/lib/web_console/exception_extension.rb +++ b/lib/web_console/exception_extension.rb @@ -0,0 +1,17 @@+module WebConsole + module ExceptionExtension + prepend_features Exception + + def ...
Add exception extension to retrieve the stacktrace binding
diff --git a/app/workers/repository_download_worker.rb b/app/workers/repository_download_worker.rb index abc1234..def5678 100644 --- a/app/workers/repository_download_worker.rb +++ b/app/workers/repository_download_worker.rb @@ -1,6 +1,6 @@ class RepositoryDownloadWorker include Sidekiq::Worker - sidekiq_options un...
Make repo downloads more important
diff --git a/test/unit/tracker_sparql_cursor_test.rb b/test/unit/tracker_sparql_cursor_test.rb index abc1234..def5678 100644 --- a/test/unit/tracker_sparql_cursor_test.rb +++ b/test/unit/tracker_sparql_cursor_test.rb @@ -4,18 +4,18 @@ describe "#get_string" do before do conn = Tracker::SparqlConnection.ge...
Use simpler SPARQL query that does not require Tracker to have data.
diff --git a/OAuthSwift.podspec b/OAuthSwift.podspec index abc1234..def5678 100644 --- a/OAuthSwift.podspec +++ b/OAuthSwift.podspec @@ -9,7 +9,7 @@ s.source = { :git => 'https://github.com/dongri/OAuthSwift.git', :tag => s.version } s.source_files = 'OAuthSwift/*.swift' s.ios.deployment_target = '8.0' - s.osx...
Fix error: `'parentViewController' is only available on OS X 10.10 or newer`
diff --git a/recipes/munin_sidekiq_memory.rb b/recipes/munin_sidekiq_memory.rb index abc1234..def5678 100644 --- a/recipes/munin_sidekiq_memory.rb +++ b/recipes/munin_sidekiq_memory.rb @@ -2,7 +2,6 @@ notifies :restart, "service[munin-node]" end -cookbook_file File.join(node['munin']['plugin_dir'], 'omnibus_gitlab...
Use munin_plugin to render the plugin
diff --git a/fit-commit.gemspec b/fit-commit.gemspec index abc1234..def5678 100644 --- a/fit-commit.gemspec +++ b/fit-commit.gemspec @@ -12,7 +12,6 @@ gem.description = "A Git hook to validate your commit messages based on community standards." gem.files = `git ls-files`.split("\n") gem.exec...
Remove deprecated default_executable gem attribute
diff --git a/assignments/assignment1.rb b/assignments/assignment1.rb index abc1234..def5678 100644 --- a/assignments/assignment1.rb +++ b/assignments/assignment1.rb @@ -24,13 +24,5 @@ note.play(@duration.text.to_i, @amplitude.text.to_i) end end - # require 'jsound' - # output = JSound::Midi::O...
Remove MIDI :poop: since it's not being used :rainbow:
diff --git a/plugins/distribution/test/unit/distribution_plugin_session_test.rb b/plugins/distribution/test/unit/distribution_plugin_session_test.rb index abc1234..def5678 100644 --- a/plugins/distribution/test/unit/distribution_plugin_session_test.rb +++ b/plugins/distribution/test/unit/distribution_plugin_session_tes...
Add validation test to session
diff --git a/lib/ares.rb b/lib/ares.rb index abc1234..def5678 100644 --- a/lib/ares.rb +++ b/lib/ares.rb @@ -7,9 +7,10 @@ require 'ico-validator' module Ares - cattr_accessor :timeout do - 5 - end + DEFAULT_TIMEOUT = 5 + + @@timeout = DEFAULT_TIMEOUT + mattr_accessor :timeout class << self include ...
Use mattr_accessor and make 5 seconds as constant
diff --git a/fork_break.gemspec b/fork_break.gemspec index abc1234..def5678 100644 --- a/fork_break.gemspec +++ b/fork_break.gemspec @@ -10,8 +10,8 @@ gem.homepage = 'http://github.com/forkbreak/fork_break' gem.licenses = ['MIT'] gem.files = `git ls-files`.split($OUTPUT_RECORD_SEPARATOR) - ge...
Update regex syntax in gemspec Gemspec was failing builds due to fork_break.gemspec:14:38: C: Use %r around regular expression. gem.test_files = gem.files.grep(/^(test|spec|features)\//) Updated the regular expressions
diff --git a/lib/bson.rb b/lib/bson.rb index abc1234..def5678 100644 --- a/lib/bson.rb +++ b/lib/bson.rb @@ -3,8 +3,20 @@ require "bson/types" require "bson/version" +# Determin if we are using JRuby or not. +# +# @example Are we running with JRuby? +# jruby? +# +# @return [ true, false ] If JRuby is our vm. +# +#...
Update requires with jruby example
diff --git a/jirabot.rb b/jirabot.rb index abc1234..def5678 100644 --- a/jirabot.rb +++ b/jirabot.rb @@ -1,4 +1,7 @@ require 'slack-ruby-bot' +require "net/https" +require "uri" +require "JSON" class JiraBot < SlackRubyBot::Bot match(/([a-z]+-[0-9]+)/i) do |client, data, issues| @@ -14,9 +17,29 @@ # Now grab ...
Call JIRA and fetch issue details
diff --git a/app/models/address.rb b/app/models/address.rb index abc1234..def5678 100644 --- a/app/models/address.rb +++ b/app/models/address.rb @@ -1,5 +1,8 @@ class Address < ActiveRecord::Base belongs_to :user + validates :user, presence: true + validates :title, :receiver, :street, :country, :state, + ...
Add validations for Address model
diff --git a/app/models/service.rb b/app/models/service.rb index abc1234..def5678 100644 --- a/app/models/service.rb +++ b/app/models/service.rb @@ -28,7 +28,7 @@ validates_with_method :service_type_exists? def service_type - service_type_type.to_s.constantize + service_type_type.to_s # TODO .constantize ...
Comment out use of constantize Signed-off-by: Alex Coles <60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexcolesportfolio.com>
diff --git a/gemfresh.gemspec b/gemfresh.gemspec index abc1234..def5678 100644 --- a/gemfresh.gemspec +++ b/gemfresh.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = 'gemfresh' - s.version = '1.0.2' + s.version = '1.0.3' s.platform = Gem::Platform::RUBY s.authors = ['Jon W...
Move to 1.0.3 bugfix release
diff --git a/spec/certificate_validation_spec.rb b/spec/certificate_validation_spec.rb index abc1234..def5678 100644 --- a/spec/certificate_validation_spec.rb +++ b/spec/certificate_validation_spec.rb @@ -19,7 +19,8 @@ 'Mozilla NSS' => true, 'Microsoft' => true, 'Apple' => true, - 'Java...
Add the new Google entry.
diff --git a/spec/grape/integration/rack_spec.rb b/spec/grape/integration/rack_spec.rb index abc1234..def5678 100644 --- a/spec/grape/integration/rack_spec.rb +++ b/spec/grape/integration/rack_spec.rb @@ -21,7 +21,7 @@ unless RUBY_PLATFORM == 'java' major, minor, release = Rack.release.split('.').map(&...
Check for Rack >= 1.5
diff --git a/spec/mailers/admin_notifier_spec.rb b/spec/mailers/admin_notifier_spec.rb index abc1234..def5678 100644 --- a/spec/mailers/admin_notifier_spec.rb +++ b/spec/mailers/admin_notifier_spec.rb @@ -1,5 +1,26 @@ require "rails_helper" RSpec.describe AdminNotifierMailer, type: :mailer do - #pending "add some e...
Add test for notification email
diff --git a/capistrano-fanfare.gemspec b/capistrano-fanfare.gemspec index abc1234..def5678 100644 --- a/capistrano-fanfare.gemspec +++ b/capistrano-fanfare.gemspec @@ -14,4 +14,7 @@ gem.name = "capistrano-fanfare" gem.require_paths = ["lib"] gem.version = Capistrano::Fanfare::VERSION + + gem.ad...
Add capistrano and capistrano_colors as dependencies.
diff --git a/lib/kari.rb b/lib/kari.rb index abc1234..def5678 100644 --- a/lib/kari.rb +++ b/lib/kari.rb @@ -0,0 +1,48 @@+require 'camping' + +Camping.goes :Kari + +module Kari + module Controllers + class Index < R '/' + def get + render :index + end + end + end + + module Views + def layo...
Add an initial Kari camping app to the main source tree. git-svn-id: e0fade74c25be90edb0606ce8d40d6c0447cda8b@54 7a99d2f0-d533-0410-96fe-f25cb2755c1e
diff --git a/lib/wanikani/recent_unlocks.rb b/lib/wanikani/recent_unlocks.rb index abc1234..def5678 100644 --- a/lib/wanikani/recent_unlocks.rb +++ b/lib/wanikani/recent_unlocks.rb @@ -10,31 +10,15 @@ return api_response["requested_information"] end - # Gets the recent unlocked radicals. - # - # @...
Clean up RecentUnlocks code duplication
diff --git a/data-exploration/enrich_outsourcer_csv.rb b/data-exploration/enrich_outsourcer_csv.rb index abc1234..def5678 100644 --- a/data-exploration/enrich_outsourcer_csv.rb +++ b/data-exploration/enrich_outsourcer_csv.rb @@ -1,21 +1,21 @@ # rubocop:disable all +# Use a CSV with Burden IDs to create a new CSV with...
Refactor so you don't have to define an output file
diff --git a/lib/nehm.rb b/lib/nehm.rb index abc1234..def5678 100644 --- a/lib/nehm.rb +++ b/lib/nehm.rb @@ -1,10 +1,11 @@-require 'colored' require 'highline' require 'nehm/applescript' -require 'nehm/argument_processor' +require 'nehm/argument_parser' require 'nehm/artwork' require 'nehm/cfg' +require 'nehm/com...
Add some dependencies and edit Nehm.start command
diff --git a/plugins/delivery/models/delivery_plugin/option.rb b/plugins/delivery/models/delivery_plugin/option.rb index abc1234..def5678 100644 --- a/plugins/delivery/models/delivery_plugin/option.rb +++ b/plugins/delivery/models/delivery_plugin/option.rb @@ -1,4 +1,7 @@ class DeliveryPlugin::Option < Noosfero::Plugin...
Fix weird issue on has_many association with polymorphic
diff --git a/knockout_forms-rails.gemspec b/knockout_forms-rails.gemspec index abc1234..def5678 100644 --- a/knockout_forms-rails.gemspec +++ b/knockout_forms-rails.gemspec @@ -22,5 +22,5 @@ spec.add_development_dependency "rake" spec.add_runtime_dependency "railties", [">= 3.1", "< 5"] - spec.add_runtime_depen...
Set dependency version for actionview
diff --git a/sample-apps/ruby-with-services/cloudcredo.rb b/sample-apps/ruby-with-services/cloudcredo.rb index abc1234..def5678 100644 --- a/sample-apps/ruby-with-services/cloudcredo.rb +++ b/sample-apps/ruby-with-services/cloudcredo.rb @@ -9,14 +9,14 @@ end get '/' do - 'CloudCredo help you deliver value wit...
Fix typo in Ruby default app
diff --git a/spec/factories/organizations.rb b/spec/factories/organizations.rb index abc1234..def5678 100644 --- a/spec/factories/organizations.rb +++ b/spec/factories/organizations.rb @@ -11,6 +11,7 @@ organization_type_id { 2 } sequence(:name) { |n| "Org #{n}" } short_name {name} + legal_name {name} ...
[TTPLAT-1117] Add legal name to organization factories.
diff --git a/spec/features/generator_spec.rb b/spec/features/generator_spec.rb index abc1234..def5678 100644 --- a/spec/features/generator_spec.rb +++ b/spec/features/generator_spec.rb @@ -4,6 +4,7 @@ scenario 'stylesheets assets files are added' do application_css_file = IO.read("#{dummy_app_path}/app/assets/st...
Update stylesheets assets files test to check for _settings.scss presence
diff --git a/lib/gitlab/build/get/geo/trigger.rb b/lib/gitlab/build/get/geo/trigger.rb index abc1234..def5678 100644 --- a/lib/gitlab/build/get/geo/trigger.rb +++ b/lib/gitlab/build/get/geo/trigger.rb @@ -9,7 +9,7 @@ class <<self def get_project_path - 'gitlab-org/quality/gitlab-environm...
Update to use new repository * Geo specific CI jobs were moved to a separate project
diff --git a/lib/booking_locations/api.rb b/lib/booking_locations/api.rb index abc1234..def5678 100644 --- a/lib/booking_locations/api.rb +++ b/lib/booking_locations/api.rb @@ -19,6 +19,7 @@ def headers_and_options {}.tap do |hash| hash[:read_timeout] = read_timeout + hash[:open_timeout] ...
Allow open timeout to be configurable