diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/models/review_spec.rb b/spec/models/review_spec.rb index abc1234..def5678 100644 --- a/spec/models/review_spec.rb +++ b/spec/models/review_spec.rb @@ -0,0 +1,13 @@+require 'rails_helper' + +RSpec.describe Review, type: :model do + before(:each) do + @stub_post = build_stubbed(:post) + @stub_rev...
Test if a review belongs to a user
diff --git a/spec/rspec_matcher_spec.rb b/spec/rspec_matcher_spec.rb index abc1234..def5678 100644 --- a/spec/rspec_matcher_spec.rb +++ b/spec/rspec_matcher_spec.rb @@ -7,29 +7,32 @@ @black_box = 'black.png' @ref_path = Gatling::Configuration.reference_image_path = File.join(spec_support_root, 'ref_path') ...
Add test to check rspec matcher can fail
diff --git a/spec/sara/callback_spec.rb b/spec/sara/callback_spec.rb index abc1234..def5678 100644 --- a/spec/sara/callback_spec.rb +++ b/spec/sara/callback_spec.rb @@ -8,9 +8,9 @@ describe ".on_xxx" do it "should store given block as callback" do - expect do - instance.on_xxx {} - end.to chan...
Refactor test for more redability
diff --git a/app/helpers/keywording_helper.rb b/app/helpers/keywording_helper.rb index abc1234..def5678 100644 --- a/app/helpers/keywording_helper.rb +++ b/app/helpers/keywording_helper.rb @@ -6,7 +6,7 @@ unless on_parent link += link_to_delete (fa_icon 'remove'), keywording, method: :delete end - bo...
Stop keywords from fluttering about
diff --git a/app/jobs/release_episodes_job.rb b/app/jobs/release_episodes_job.rb index abc1234..def5678 100644 --- a/app/jobs/release_episodes_job.rb +++ b/app/jobs/release_episodes_job.rb @@ -2,14 +2,16 @@ queue_as :feeder_default - def perform + def perform(reschedule = false) ActiveRecord::Base.connecti...
Add param to control rescheduling the same job
diff --git a/app/presenters/user_presenter.rb b/app/presenters/user_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/user_presenter.rb +++ b/app/presenters/user_presenter.rb @@ -1,3 +1,8 @@ class UserPresenter < Presenter attribute :id, :name, :email, :api_token, :created_at + attribute :feeds_count ...
Include feeds_count into user presenter
diff --git a/app/serializers/me_serializer.rb b/app/serializers/me_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/me_serializer.rb +++ b/app/serializers/me_serializer.rb @@ -1,6 +1,6 @@ class MeSerializer < UserSerializer - attributes :total_clouds, :read_terms, :using_default_avatar, :notificatio...
Include user email data in /me resource.
diff --git a/spec/cc/engine/analyzers/php/main_spec.rb b/spec/cc/engine/analyzers/php/main_spec.rb index abc1234..def5678 100644 --- a/spec/cc/engine/analyzers/php/main_spec.rb +++ b/spec/cc/engine/analyzers/php/main_spec.rb @@ -0,0 +1,65 @@+require 'spec_helper' +require 'cc/engine/analyzers/php/main' +require 'flay' ...
Add a spec for php analyzer
diff --git a/spec/controllers/pages_controller_spec.rb b/spec/controllers/pages_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/pages_controller_spec.rb +++ b/spec/controllers/pages_controller_spec.rb @@ -14,4 +14,11 @@ it { should respond_with(200) } it { should render_template('applicatio...
Add test for pages studio
diff --git a/spec/features/user_creates_a_post_spec.rb b/spec/features/user_creates_a_post_spec.rb index abc1234..def5678 100644 --- a/spec/features/user_creates_a_post_spec.rb +++ b/spec/features/user_creates_a_post_spec.rb @@ -22,8 +22,8 @@ feature 'Auto generate post slug' do scenario 'user types on title f...
Fix capybara waits for ajax
diff --git a/spec/request/request_create_async_spec.rb b/spec/request/request_create_async_spec.rb index abc1234..def5678 100644 --- a/spec/request/request_create_async_spec.rb +++ b/spec/request/request_create_async_spec.rb @@ -0,0 +1,20 @@+# frozen_string_literal: true + +require 'spec_helper' + +describe 'RubyRabbit...
Add test ASYNC with create
diff --git a/lib/active_touch/define_touch.rb b/lib/active_touch/define_touch.rb index abc1234..def5678 100644 --- a/lib/active_touch/define_touch.rb +++ b/lib/active_touch/define_touch.rb @@ -23,8 +23,11 @@ @klass.send :define_method, @touch_method do |*args| changed_attributes = self.previous_changes...
Add if and unless conditional procs to touch options.
diff --git a/lib/checkout/pricing_strategy.rb b/lib/checkout/pricing_strategy.rb index abc1234..def5678 100644 --- a/lib/checkout/pricing_strategy.rb +++ b/lib/checkout/pricing_strategy.rb @@ -6,16 +6,15 @@ end def calculate_price(product, quantity) - product_rules = @rules.fetch(product) do + prod...
Add a bit of readability
diff --git a/features/lib/step_definitions/profile_steps.rb b/features/lib/step_definitions/profile_steps.rb index abc1234..def5678 100644 --- a/features/lib/step_definitions/profile_steps.rb +++ b/features/lib/step_definitions/profile_steps.rb @@ -0,0 +1,15 @@+Given /^the following profiles? (?:are|is) defined:$/ do |...
Add the necessary profile steps
diff --git a/db/initialize.rb b/db/initialize.rb index abc1234..def5678 100644 --- a/db/initialize.rb +++ b/db/initialize.rb @@ -1,3 +1,8 @@+# Heroku uses DATABASE_URL environment variable to pass database path to the app +if ENV['DATABASE_URL'] + @config['database'] = ENV['DATABASE_URL'] +end + case @config['db_adap...
Add DATABASE_URL environment variable processing
diff --git a/spec/features/items/visitor_visits_items_index_spec.rb b/spec/features/items/visitor_visits_items_index_spec.rb index abc1234..def5678 100644 --- a/spec/features/items/visitor_visits_items_index_spec.rb +++ b/spec/features/items/visitor_visits_items_index_spec.rb @@ -0,0 +1,18 @@+require 'rails_helper' + +...
Add spec for items index
diff --git a/app/models/record.rb b/app/models/record.rb index abc1234..def5678 100644 --- a/app/models/record.rb +++ b/app/models/record.rb @@ -5,8 +5,7 @@ has_many :comments validate :date_from_lesser_than_date_to - validate :dates_cannot_be_in_the_past unless proc { |record| record.is_a? Worktime} - validat...
Remove emails validation for Worktimes
diff --git a/features/step_definitions/basic.rb b/features/step_definitions/basic.rb index abc1234..def5678 100644 --- a/features/step_definitions/basic.rb +++ b/features/step_definitions/basic.rb @@ -10,6 +10,9 @@ create_dir 'working-repository' cd 'working-repository' run_simple 'git init' + # Configure Git ...
Configure Git username and email on the cucumber's working repo to unclutter console output.
diff --git a/Casks/appcode-eap.rb b/Casks/appcode-eap.rb index abc1234..def5678 100644 --- a/Casks/appcode-eap.rb +++ b/Casks/appcode-eap.rb @@ -1,6 +1,6 @@ cask 'appcode-eap' do - version '145.256.45' - sha256 '2e33648bfda807f2d8e1cf8eea96a169ad420a31b36250030c5414fee5c30f05' + version '2016.1-RC2' + sha256 'dec74...
Update AppCode EAP to version 2016.1-RC2 This commit updates the version and sha256 stanzas. It also changes the app name, as the RC versions drop the EAP from the app name. Also updated the zap stanza.
diff --git a/Casks/iterm2-beta.rb b/Casks/iterm2-beta.rb index abc1234..def5678 100644 --- a/Casks/iterm2-beta.rb +++ b/Casks/iterm2-beta.rb @@ -1,8 +1,8 @@ cask 'iterm2-beta' do - version '2.9.20151111' - sha256 'fb1c566412656c4e9f5cfdc892a1ea960d0b3124479fd4c60dc65ce48ee37c2e' + version '2.9.20160102' + sha256 '2...
Upgrade iTerm2 Beta to 2.9.20160102 update version add version substitution for the url
diff --git a/lib/dizby/utility/timed_state.rb b/lib/dizby/utility/timed_state.rb index abc1234..def5678 100644 --- a/lib/dizby/utility/timed_state.rb +++ b/lib/dizby/utility/timed_state.rb @@ -8,7 +8,7 @@ def update previous = @last_update - @last_update = Time.now + @last_update = Time.now.utc ...
Fix styling error and possible error when dealing with DST.
diff --git a/lib/dry/types/builder_methods.rb b/lib/dry/types/builder_methods.rb index abc1234..def5678 100644 --- a/lib/dry/types/builder_methods.rb +++ b/lib/dry/types/builder_methods.rb @@ -1,26 +1,71 @@ module Dry module Types module BuilderMethods + # Build an array type. + # It is a shortcut for...
Add YARD for type constructores [skip ci]
diff --git a/lib/govuk_seed_crawler/seeder.rb b/lib/govuk_seed_crawler/seeder.rb index abc1234..def5678 100644 --- a/lib/govuk_seed_crawler/seeder.rb +++ b/lib/govuk_seed_crawler/seeder.rb @@ -1,18 +1,21 @@ module GovukSeedCrawler class Seeder def self.seed(options = {}) - amqp_connection_options = options...
Move extraction of AMQP config to separate method Move the logic that extracts the AMQP connection options into its own method for readability.
diff --git a/Formula/redis-php.rb b/Formula/redis-php.rb index abc1234..def5678 100644 --- a/Formula/redis-php.rb +++ b/Formula/redis-php.rb @@ -1,4 +1,8 @@ require 'formula' + +def redis_installed? + `which redis-server`.length > 0 +end class RedisPhp < Formula homepage 'https://github.com/nicolasff/phpredis' @...
Make php-redis depend upon redis
diff --git a/app/controllers/admin/settings_controller.rb b/app/controllers/admin/settings_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/settings_controller.rb +++ b/app/controllers/admin/settings_controller.rb @@ -11,7 +11,7 @@ def cache_clear Rails.cache.clear - render nothing: t...
Remove deprecated render nothing: true
diff --git a/week-6/attr/my_solution.rb b/week-6/attr/my_solution.rb index abc1234..def5678 100644 --- a/week-6/attr/my_solution.rb +++ b/week-6/attr/my_solution.rb @@ -0,0 +1,102 @@+#Attr Methods + +# I worked on this challenge by myself. + +# I spent [#] hours on this challenge. + +# NameData will initialize a ...
Add my solution for Challenge 6.4 - Accessing Attributes
diff --git a/lib/rspec/collection_matchers.rb b/lib/rspec/collection_matchers.rb index abc1234..def5678 100644 --- a/lib/rspec/collection_matchers.rb +++ b/lib/rspec/collection_matchers.rb @@ -1,4 +1,5 @@+require 'rspec/expectations' require 'rspec/collection_matchers/version' require 'rspec/collection_matchers/match...
Fix bug of uninitialized constant RSpec::Expectations
diff --git a/lib/vines/stream/server/start.rb b/lib/vines/stream/server/start.rb index abc1234..def5678 100644 --- a/lib/vines/stream/server/start.rb +++ b/lib/vines/stream/server/start.rb @@ -15,9 +15,10 @@ stream.start(node) doc = Document.new features = doc.create_element('stream:feat...
Add tls flag to stream:features if forcing encryption
diff --git a/lib/tasks/shapes/make_valid.rake b/lib/tasks/shapes/make_valid.rake index abc1234..def5678 100644 --- a/lib/tasks/shapes/make_valid.rake +++ b/lib/tasks/shapes/make_valid.rake @@ -0,0 +1,70 @@+# Tenant tasks +namespace :shapes do + desc 'Find invalid productions support shapes (resolve GEOSUnaryUnion: Top...
Add rake task for resolve support shape error
diff --git a/lib/dry/types/constructor.rb b/lib/dry/types/constructor.rb index abc1234..def5678 100644 --- a/lib/dry/types/constructor.rb +++ b/lib/dry/types/constructor.rb @@ -4,8 +4,6 @@ module Types class Constructor < Definition include Dry::Equalizer(:type) - - undef_method :primitive a...
Remove redundant call to undef_method
diff --git a/ducktrap.gemspec b/ducktrap.gemspec index abc1234..def5678 100644 --- a/ducktrap.gemspec +++ b/ducktrap.gemspec @@ -13,7 +13,7 @@ gem.files = `git ls-files`.split("\n") gem.test_files = `git ls-files -- spec`.split("\n") gem.extra_rdoc_files = %w[TODO] - gem.license = %w[...
Fix gem.license setting in the gemspec
diff --git a/lib/frizz/middleman/tasks.rb b/lib/frizz/middleman/tasks.rb index abc1234..def5678 100644 --- a/lib/frizz/middleman/tasks.rb +++ b/lib/frizz/middleman/tasks.rb @@ -25,6 +25,7 @@ relevant_environments.each do |name, env| desc "Build #{env.name}" task env.name do + ...
Remove middleman-sprocket's file cache (pre-3.3.2) before building to ensure any erb assets use correct environment's frizz.yml values
diff --git a/dynosaur.gemspec b/dynosaur.gemspec index abc1234..def5678 100644 --- a/dynosaur.gemspec +++ b/dynosaur.gemspec @@ -23,6 +23,6 @@ spec.add_development_dependency 'bundler', '~> 1.8' spec.add_development_dependency 'codeclimate-test-reporter', '~> 0.4' spec.add_development_dependency 'pry-byebug', '...
Update rake requirement from ~> 10.0 to ~> 13.0 Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version. - [Release notes](https://github.com/ruby/rake/releases) - [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc) - [Commits](https://github.com/ruby/rake/compare/r...
diff --git a/Casks/mapbox-studio.rb b/Casks/mapbox-studio.rb index abc1234..def5678 100644 --- a/Casks/mapbox-studio.rb +++ b/Casks/mapbox-studio.rb @@ -1,10 +1,10 @@ class MapboxStudio < Cask - version '0.1.0' - sha256 'c36455cfa938c957cb08acd04281a5104702ab3b6ba0c76ae38bb6a55910296d' + version '0.1.5' + sha256 '5...
Upgrade Mapbox Studio to v0.1.5 The latest version addresses bugs related to atom-shell integration. For a full list of changes, see https://github.com/mapbox/mapbox-studio/blob/mb-pages/CHANGELOG.md#changelog
diff --git a/test/airbrussh/log_file_formatter_test.rb b/test/airbrussh/log_file_formatter_test.rb index abc1234..def5678 100644 --- a/test/airbrussh/log_file_formatter_test.rb +++ b/test/airbrussh/log_file_formatter_test.rb @@ -1,5 +1,6 @@ require "minitest_helper" require "airbrussh/log_file_formatter" +require "fil...
Work around Dir.mktmpdir problems on Windows
diff --git a/lib/how_is/sources/github.rb b/lib/how_is/sources/github.rb index abc1234..def5678 100644 --- a/lib/how_is/sources/github.rb +++ b/lib/how_is/sources/github.rb @@ -11,24 +11,20 @@ class ConfigError < StandardError end - def initialize(global_config) - raise ConfigError, "Expected...
Clean up Sources::Github.new by adding a helper method.
diff --git a/test/controllers/items_controller_test.rb b/test/controllers/items_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/items_controller_test.rb +++ b/test/controllers/items_controller_test.rb @@ -4,4 +4,9 @@ # test "the truth" do # assert true # end + + test "should get new i...
Write test for clicking on a new item link
diff --git a/lib/nehm/playlist_manager.rb b/lib/nehm/playlist_manager.rb index abc1234..def5678 100644 --- a/lib/nehm/playlist_manager.rb +++ b/lib/nehm/playlist_manager.rb @@ -5,7 +5,7 @@ def self.set_playlist loop do - playlist = HighLine.new.ask('Enter name of default iTunes playlist to which you want ...
Edit message when set the iTunes playlist
diff --git a/lib/24_seven_office/services/authentication.rb b/lib/24_seven_office/services/authentication.rb index abc1234..def5678 100644 --- a/lib/24_seven_office/services/authentication.rb +++ b/lib/24_seven_office/services/authentication.rb @@ -27,7 +27,7 @@ end def self.login(username, password, app...
Add missing hash key in call to super
diff --git a/actionpack/test/controller/new_base/render_context_test.rb b/actionpack/test/controller/new_base/render_context_test.rb index abc1234..def5678 100644 --- a/actionpack/test/controller/new_base/render_context_test.rb +++ b/actionpack/test/controller/new_base/render_context_test.rb @@ -0,0 +1,54 @@+require 'a...
Add a test for rendering from the controller context.
diff --git a/lib/aaa_sfu_misc/request_throttle_whitelist.rb b/lib/aaa_sfu_misc/request_throttle_whitelist.rb index abc1234..def5678 100644 --- a/lib/aaa_sfu_misc/request_throttle_whitelist.rb +++ b/lib/aaa_sfu_misc/request_throttle_whitelist.rb @@ -1,5 +1,5 @@ class RequestThrottle - alias_method :whitelisted_original...
Fix call to changed method name.
diff --git a/spec/overcommit/hook/commit_msg/spellcheck_spec.rb b/spec/overcommit/hook/commit_msg/spellcheck_spec.rb index abc1234..def5678 100644 --- a/spec/overcommit/hook/commit_msg/spellcheck_spec.rb +++ b/spec/overcommit/hook/commit_msg/spellcheck_spec.rb @@ -0,0 +1,76 @@+# encoding: utf-8 +require 'spec_helper' +...
Add spec for Spellcheck commit-msg hook
diff --git a/lib/volunteermatch/api/search_organizations.rb b/lib/volunteermatch/api/search_organizations.rb index abc1234..def5678 100644 --- a/lib/volunteermatch/api/search_organizations.rb +++ b/lib/volunteermatch/api/search_organizations.rb @@ -4,7 +4,6 @@ def search_organizations(parameters = {}) ra...
Remove default text to display in parameters
diff --git a/app/init_sidekiq.rb b/app/init_sidekiq.rb index abc1234..def5678 100644 --- a/app/init_sidekiq.rb +++ b/app/init_sidekiq.rb @@ -1,6 +1,3 @@ require "./app/boot" require "./app/workers/dependency_file_fetcher" -require "./app/workers/dependency_file_parser" -require "./app/workers/update_checker" -require ...
Remove nonexistent requires from sidekiq_init
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -13,7 +13,7 @@ # you've limited to :test, :development, or :production. Bundler.require(*Rails.groups) -module Opencampground +module OpenCampground class Application...
Rename app from Opencampground to OpenCampground
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -23,6 +23,9 @@ raise '$ORBIT_HOME not set' unless ENV['ORBIT_HOME'] raise '$ORBIT_HOME not a dir' unless File.directory? ENV['ORBIT_HOME'] +raise '$ORBIT_KEY not set' ...
Make sure that $ORBIT_KEY is set
diff --git a/StringStylizer.podspec b/StringStylizer.podspec index abc1234..def5678 100644 --- a/StringStylizer.podspec +++ b/StringStylizer.podspec @@ -22,5 +22,5 @@ s.ios.deployment_target = '8.0' - s.source_files = 'StringStylizer/*' + s.source_files = 'StringStylizer/*.swift' end
Fix `podspec` to not include Info.plist Fixes building via CocoaPods in Xcode 10
diff --git a/db/migrate/20140617193351_add_post_id_index_on_topic_links.rb b/db/migrate/20140617193351_add_post_id_index_on_topic_links.rb index abc1234..def5678 100644 --- a/db/migrate/20140617193351_add_post_id_index_on_topic_links.rb +++ b/db/migrate/20140617193351_add_post_id_index_on_topic_links.rb @@ -0,0 +1,9 @@...
Add post_id index to topic_links
diff --git a/core/file/fixtures/file_types.rb b/core/file/fixtures/file_types.rb index abc1234..def5678 100644 --- a/core/file/fixtures/file_types.rb +++ b/core/file/fixtures/file_types.rb @@ -57,8 +57,11 @@ name = tmp("ftype_socket.socket") rm_r name socket = UNIXServer.new name - yield name - sock...
Add missing ensure in FileSpecs.socket
diff --git a/test/integration/default/serverspec/spec_helper.rb b/test/integration/default/serverspec/spec_helper.rb index abc1234..def5678 100644 --- a/test/integration/default/serverspec/spec_helper.rb +++ b/test/integration/default/serverspec/spec_helper.rb @@ -18,8 +18,7 @@ require 'serverspec' -include SpecInf...
Upgrade serverspec helper to latets notation
diff --git a/core/objectspace/_id2ref_spec.rb b/core/objectspace/_id2ref_spec.rb index abc1234..def5678 100644 --- a/core/objectspace/_id2ref_spec.rb +++ b/core/objectspace/_id2ref_spec.rb @@ -6,4 +6,21 @@ r = ObjectSpace._id2ref(s.object_id) r.should == s end + + it "retrieves a Fixnum by object_id" do + ...
Add specs for ObjectSpace._id2ref and immediates
diff --git a/week-6/die-2/my_solution.rb b/week-6/die-2/my_solution.rb index abc1234..def5678 100644 --- a/week-6/die-2/my_solution.rb +++ b/week-6/die-2/my_solution.rb @@ -1,26 +1,47 @@ # Die Class 2: Arbitrary Symbols -# I worked on this challenge [by myself, with: ]. +# I worked on this challenge by myself. # I...
Create class with methods to output the number of sides on a die and a random position in an array, corresponding to a side on the die.
diff --git a/db/migrate/20140602152302_remove_rpa_specialist_sectors.rb b/db/migrate/20140602152302_remove_rpa_specialist_sectors.rb index abc1234..def5678 100644 --- a/db/migrate/20140602152302_remove_rpa_specialist_sectors.rb +++ b/db/migrate/20140602152302_remove_rpa_specialist_sectors.rb @@ -0,0 +1,41 @@+class Remo...
Add migration to delete three RPA specialist sectors This migration deletes three specialist sector tags if they exist. These have never been populated on GOV.UK, nor are they currently linked to, so it is not necessary to add redirects for these.
diff --git a/lib/devise_jwt/jwt_failure_app.rb b/lib/devise_jwt/jwt_failure_app.rb index abc1234..def5678 100644 --- a/lib/devise_jwt/jwt_failure_app.rb +++ b/lib/devise_jwt/jwt_failure_app.rb @@ -14,12 +14,19 @@ return i18n_message unless request_format method = "to_#{request_format}" if method == ...
Redefine scope property of i18n options from devise.failure to devise_jwt.failure
diff --git a/app/api/shopt/api.rb b/app/api/shopt/api.rb index abc1234..def5678 100644 --- a/app/api/shopt/api.rb +++ b/app/api/shopt/api.rb @@ -16,6 +16,12 @@ route_param :id do get do Customer.find(params[:id]) + end + + route_param :orders do + get do + Cus...
Add endpoint for a customer's orders
diff --git a/app/jobs/notifier.rb b/app/jobs/notifier.rb index abc1234..def5678 100644 --- a/app/jobs/notifier.rb +++ b/app/jobs/notifier.rb @@ -18,7 +18,7 @@ 'Authorization' => authorization end true - rescue *(HTTP_ERRORS + [RestClient::Exception, SocketError]) => e + rescue *(HTTP_E...
Include all Errnos as failures
diff --git a/app_prototype/lib/templates/rspec/scaffold/show_spec.rb b/app_prototype/lib/templates/rspec/scaffold/show_spec.rb index abc1234..def5678 100644 --- a/app_prototype/lib/templates/rspec/scaffold/show_spec.rb +++ b/app_prototype/lib/templates/rspec/scaffold/show_spec.rb @@ -0,0 +1,15 @@+require 'spec_helper' ...
Use the expect() syntax when generating view specs for :show. Use factory_girl's build_stubbed instead of rspec's stub_model.
diff --git a/lib/rails/deprecated_sanitizer.rb b/lib/rails/deprecated_sanitizer.rb index abc1234..def5678 100644 --- a/lib/rails/deprecated_sanitizer.rb +++ b/lib/rails/deprecated_sanitizer.rb @@ -39,5 +39,5 @@ end ActiveSupport.on_load(:action_view) do - ActionView::SanitizeHelper.sanitizer_vendor = Rails::Depreca...
Set sanitizer_vendor to correct constant.
diff --git a/lib/generators/templates/plans.rb b/lib/generators/templates/plans.rb index abc1234..def5678 100644 --- a/lib/generators/templates/plans.rb +++ b/lib/generators/templates/plans.rb @@ -11,7 +11,7 @@ # # amount in cents. This is 6.99 # plan.amount = 699 # -# # interval must be either 'month' or 'year...
Update template to include 'week'.
diff --git a/lib/tasks/analyse_javascript.rake b/lib/tasks/analyse_javascript.rake index abc1234..def5678 100644 --- a/lib/tasks/analyse_javascript.rake +++ b/lib/tasks/analyse_javascript.rake @@ -1,5 +1,7 @@+require 'English' + desc 'Analyse Javascript with JSHint and Javascript Code Style checker' task :analyse_jav...
Exit with correct exit code Returns the correct exit code, rather than raising an exception.
diff --git a/db/data_migration/20181004172520_update_drafts_for_scheduled_content_to_resolve_first_published_at_issue.rb b/db/data_migration/20181004172520_update_drafts_for_scheduled_content_to_resolve_first_published_at_issue.rb index abc1234..def5678 100644 --- a/db/data_migration/20181004172520_update_drafts_for_sc...
Add data migration to fix first_published_at values Along with the first_public_at values for scheduled content which hasn't been published yet. This is necessary, as Whitehall has been sending the first_published_at values for content which hasn't been published yet... and it didn't even get them right for scheduled...
diff --git a/test/readers/fgdc/tc_fgdc_lineage.rb b/test/readers/fgdc/tc_fgdc_lineage.rb index abc1234..def5678 100644 --- a/test/readers/fgdc/tc_fgdc_lineage.rb +++ b/test/readers/fgdc/tc_fgdc_lineage.rb @@ -0,0 +1,37 @@+# MdTranslator - minitest of +# readers / fgdc / module_lineage + +# History: +# Stan Smith 2017...
Add fgdc reader module 'lineage' include minitest
diff --git a/attributes/exabgp.rb b/attributes/exabgp.rb index abc1234..def5678 100644 --- a/attributes/exabgp.rb +++ b/attributes/exabgp.rb @@ -1,5 +1,5 @@-default[:exabgp][:local_as] = 0 -default[:exabgp][:peer_as] = 0 +default[:exabgp][:local_as] = 12345 +default[:exabgp][:peer_as] = 12345 default[:exabgp][:communi...
Put something other than 0 for local and peer as This will allow it to fully start up for now.
diff --git a/app/models/sentence.rb b/app/models/sentence.rb index abc1234..def5678 100644 --- a/app/models/sentence.rb +++ b/app/models/sentence.rb @@ -8,6 +8,8 @@ default_scope where(imported: false) attr_accessible :locid + + delegate :repository, to: :ontology def self.find_with_locid(locid, _iri = nil...
Make repository available from Sentence.
diff --git a/app/plugins/weather.rb b/app/plugins/weather.rb index abc1234..def5678 100644 --- a/app/plugins/weather.rb +++ b/app/plugins/weather.rb @@ -1,6 +1,6 @@ # encoding: utf-8 class Wearther < Base - match /^[zurg].+como.+tempo.+em\s(.+)[?]$/, :use_prefix => false, :method => :weather + match /^[zurg].+como.+...
Fix regexp and remove , from the answer
diff --git a/fdic.gemspec b/fdic.gemspec index abc1234..def5678 100644 --- a/fdic.gemspec +++ b/fdic.gemspec @@ -6,7 +6,7 @@ Gem::Specification.new do |spec| spec.name = "fdic" spec.version = FDIC::VERSION - spec.authors = ["Thomas Reznick", "Dan Bernier"] + spec.authors = ["Tom Rezni...
Rename Thomas to Tom in the .gemspec. :bowtie:
diff --git a/app/models/category_topic.rb b/app/models/category_topic.rb index abc1234..def5678 100644 --- a/app/models/category_topic.rb +++ b/app/models/category_topic.rb @@ -16,6 +16,8 @@ validate :category_and_topic_must_belong_to_same_user + private + def category_and_topic_must_belong_to_same_user ...
Make custom validation method private
diff --git a/app/models/org_identifier.rb b/app/models/org_identifier.rb index abc1234..def5678 100644 --- a/app/models/org_identifier.rb +++ b/app/models/org_identifier.rb @@ -34,7 +34,8 @@ validates :identifier_scheme_id, uniqueness: { scope: :org_id, message: UNIQU...
Add uniqueness validation to OrgIdentifier
diff --git a/lib/frecon/controllers/records_controller.rb b/lib/frecon/controllers/records_controller.rb index abc1234..def5678 100644 --- a/lib/frecon/controllers/records_controller.rb +++ b/lib/frecon/controllers/records_controller.rb @@ -13,8 +13,8 @@ module FReCon class RecordsController < Controller - def sel...
Make RecordsController allow three arguments
diff --git a/spec/features/acceptance/login_as_user_spec.rb b/spec/features/acceptance/login_as_user_spec.rb index abc1234..def5678 100644 --- a/spec/features/acceptance/login_as_user_spec.rb +++ b/spec/features/acceptance/login_as_user_spec.rb @@ -14,4 +14,9 @@ end end + scenario "Change button layout after ...
Add test for changing label after applying
diff --git a/spec/lib/request_started_on_middleware_spec.rb b/spec/lib/request_started_on_middleware_spec.rb index abc1234..def5678 100644 --- a/spec/lib/request_started_on_middleware_spec.rb +++ b/spec/lib/request_started_on_middleware_spec.rb @@ -1,8 +1,7 @@-describe RequestStartedOnMiddleware do +RSpec.describe Requ...
Remove unused partial in RequestStartedOnMiddleware specs. Added RSpec to outer describe block.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -5,13 +5,9 @@ class HTMLwithPygments < Redcarpet::Render::HTML def block_code(code, language) - if Pygments::L...
Stop displaying errors for code blocks with no language.
diff --git a/test/factories/accounts.rb b/test/factories/accounts.rb index abc1234..def5678 100644 --- a/test/factories/accounts.rb +++ b/test/factories/accounts.rb @@ -5,7 +5,7 @@ nature { 'general' } sequence(:name) { |n| "Compte 801 - #{n}" } sequence(:number) { |n| (801000 + n).to_s } - number_is_v...
Change old field by new one
diff --git a/test/metrics-rails_test.rb b/test/metrics-rails_test.rb index abc1234..def5678 100644 --- a/test/metrics-rails_test.rb +++ b/test/metrics-rails_test.rb @@ -8,6 +8,11 @@ test 'client is available' do assert_kind_of Librato::Metrics::Client, Metrics::Rails.client + end + + test '#increment exi...
Add coverage for counters persisting between flushes
diff --git a/app/models/question_permission.rb b/app/models/question_permission.rb index abc1234..def5678 100644 --- a/app/models/question_permission.rb +++ b/app/models/question_permission.rb @@ -11,7 +11,7 @@ def after_initialize return unless question = Question.find(:secret => secret) - return if questi...
Allow superusers to access private questions w/ a group
diff --git a/event_store-entity_store.gemspec b/event_store-entity_store.gemspec index abc1234..def5678 100644 --- a/event_store-entity_store.gemspec +++ b/event_store-entity_store.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'event_store-entity_store' - s.version = '0.1...
Package version is increased from 0.1.1.0 to 0.2.0.0
diff --git a/claim_token.gemspec b/claim_token.gemspec index abc1234..def5678 100644 --- a/claim_token.gemspec +++ b/claim_token.gemspec @@ -6,8 +6,8 @@ Gem::Specification.new do |spec| spec.name = "claim_token" spec.version = ClaimToken::VERSION - spec.authors = ["Daniel Zollinger"] - spec...
Update authors list in gemspec
diff --git a/spec/controllers/settings/export_controller_spec.rb b/spec/controllers/settings/export_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/settings/export_controller_spec.rb +++ b/spec/controllers/settings/export_controller_spec.rb @@ -0,0 +1,20 @@+# frozen_string_literal: true + +requi...
Add test for `Settings::ExportController` index view
diff --git a/delayed_constraint.rb b/delayed_constraint.rb index abc1234..def5678 100644 --- a/delayed_constraint.rb +++ b/delayed_constraint.rb @@ -13,11 +13,11 @@ alias_method :_always, :always def always(constraint_name, bindings, context) - DelayedConstraint.send constraint_name.to_sym, bindings, context, :_...
Make DelayedConstraint class simple again
diff --git a/rspec-retry.gemspec b/rspec-retry.gemspec index abc1234..def5678 100644 --- a/rspec-retry.gemspec +++ b/rspec-retry.gemspec @@ -15,6 +15,7 @@ gem.require_paths = ["lib"] gem.version = RSpec::Retry::VERSION gem.add_runtime_dependency %{rspec-core} + gem.add_development_dependency %q{rspec} ...
Add rspec to development dependency
diff --git a/lib/dynosaur/process/heroku.rb b/lib/dynosaur/process/heroku.rb index abc1234..def5678 100644 --- a/lib/dynosaur/process/heroku.rb +++ b/lib/dynosaur/process/heroku.rb @@ -4,12 +4,14 @@ module Dynosaur class Process class Heroku < Process - # Valid dyno sizes under Heroku's new pricing model ...
Add private dyno size constants
diff --git a/lib/field_attribute_builder.rb b/lib/field_attribute_builder.rb index abc1234..def5678 100644 --- a/lib/field_attribute_builder.rb +++ b/lib/field_attribute_builder.rb @@ -28,7 +28,7 @@ end def install_methods - @model.class_eval <<-HERE + @model.class_eval <<-HERE, __FILE__, __LIN...
Add file and line numbers when class_eval'ing
diff --git a/lib/count_gen.rb b/lib/count_gen.rb index abc1234..def5678 100644 --- a/lib/count_gen.rb +++ b/lib/count_gen.rb @@ -0,0 +1,10 @@+module CountGen + + # Generates an array of numbers, counting by how many player records + # are on each HTML page. Allows other methods to paginate through the + # stat page...
Add CountGen module for mixin
diff --git a/lib/ruboty/slack_rtm/client.rb b/lib/ruboty/slack_rtm/client.rb index abc1234..def5678 100644 --- a/lib/ruboty/slack_rtm/client.rb +++ b/lib/ruboty/slack_rtm/client.rb @@ -21,11 +21,24 @@ end def main_loop + keep_connection + loop do message = @queue.deq ...
Send ping every 30 seconds
diff --git a/lib/tasks/replace_textile.rake b/lib/tasks/replace_textile.rake index abc1234..def5678 100644 --- a/lib/tasks/replace_textile.rake +++ b/lib/tasks/replace_textile.rake @@ -0,0 +1,17 @@+# frozen_string_literal: true + +namespace :publify do + desc "Convert content in Textile format to Markdown" + task tex...
Add task to convert Textile content to Markdown
diff --git a/lib/tasks/reset_sequences.rake b/lib/tasks/reset_sequences.rake index abc1234..def5678 100644 --- a/lib/tasks/reset_sequences.rake +++ b/lib/tasks/reset_sequences.rake @@ -1,17 +1,17 @@ namespace :db do desc "Reset all sequences. Run after data imports" - task :reset_sequences, [:model_class] => :envir...
Add ti reset sequesces the tables that we migrated
diff --git a/lib/turbo-sprockets/railtie.rb b/lib/turbo-sprockets/railtie.rb index abc1234..def5678 100644 --- a/lib/turbo-sprockets/railtie.rb +++ b/lib/turbo-sprockets/railtie.rb @@ -21,7 +21,8 @@ if File.exist?(manifest_path) manifest = YAML.load_file(manifest_path) - config.assets.digest_fil...
Set both digest keys for backwards compatibility
diff --git a/lib/vagrant-triggers/plugin.rb b/lib/vagrant-triggers/plugin.rb index abc1234..def5678 100644 --- a/lib/vagrant-triggers/plugin.rb +++ b/lib/vagrant-triggers/plugin.rb @@ -23,8 +23,10 @@ action_hook(:trigger, Plugin::ALL_ACTIONS) do |hook| require_relative "action" - hook.prepend(Ac...
Allow skipping triggers for a single run Triggers won't run if VAGRANT_NO_TRIGGERS environment variable is set
diff --git a/lib/veeqo/resources/company.rb b/lib/veeqo/resources/company.rb index abc1234..def5678 100644 --- a/lib/veeqo/resources/company.rb +++ b/lib/veeqo/resources/company.rb @@ -30,8 +30,8 @@ get path.build, params end - def self.check_connection - info + def self.check_connection(params ...
Change check connection to receive connection on params
diff --git a/UPCarouselFlowLayout.podspec b/UPCarouselFlowLayout.podspec index abc1234..def5678 100644 --- a/UPCarouselFlowLayout.podspec +++ b/UPCarouselFlowLayout.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "UPCarouselFlowLayout" - s.version = "1.0.0" + s.version = "1.1.0"...
Update pod version to 1.1
diff --git a/lib/webtrends.rb b/lib/webtrends.rb index abc1234..def5678 100644 --- a/lib/webtrends.rb +++ b/lib/webtrends.rb @@ -1,5 +1,6 @@ require "rest_client" require "webtrends/version" +require "webtrends/service" require "webtrends/event" require "webtrends/configuration"
Include parent class into the module
diff --git a/actionpack/test/lib/fixture_template.rb b/actionpack/test/lib/fixture_template.rb index abc1234..def5678 100644 --- a/actionpack/test/lib/fixture_template.rb +++ b/actionpack/test/lib/fixture_template.rb @@ -6,10 +6,6 @@ end private - - def or_extensions(array) - "(?:" << array.map {|e| e ...
Remove a useless method in the fixture template class
diff --git a/aloha-rails-improved.gemspec b/aloha-rails-improved.gemspec index abc1234..def5678 100644 --- a/aloha-rails-improved.gemspec +++ b/aloha-rails-improved.gemspec @@ -7,6 +7,7 @@ gem.description = 'Aloha Editor in Rails' gem.summary = 'Provides the Aloha Editor for your Rails app' gem.homepage...
Add License information to gemspec
diff --git a/table.rb b/table.rb index abc1234..def5678 100644 --- a/table.rb +++ b/table.rb @@ -15,8 +15,8 @@ self.class.mtime(@name) end - def self.exists? table_name, schema_names = ['public'] - Db.table_exists?(table_name, schema_names) + def self.exists? table_name, options={} + ...
Fix crash on bad argument to Table.exists?
diff --git a/app/controllers/publications_controller.rb b/app/controllers/publications_controller.rb index abc1234..def5678 100644 --- a/app/controllers/publications_controller.rb +++ b/app/controllers/publications_controller.rb @@ -5,10 +5,8 @@ if edition.persisted? UpdateWorker.perform_async(edition.id.to_...
Remove some redundant return statements
diff --git a/app/controllers/questions_controller.rb b/app/controllers/questions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/questions_controller.rb +++ b/app/controllers/questions_controller.rb @@ -9,7 +9,7 @@ end def show - @user = User.new + @user = @question.user end def c...
Update show method with correct user
diff --git a/app/controllers/voicemail_controller.rb b/app/controllers/voicemail_controller.rb index abc1234..def5678 100644 --- a/app/controllers/voicemail_controller.rb +++ b/app/controllers/voicemail_controller.rb @@ -1,4 +1,6 @@ class VoicemailController < ApplicationController + skip_before_action :verify_authent...
Remove cr0sskrypt proteccion for now
diff --git a/spec/controllers/spree/admin/reports_controller_spec.rb b/spec/controllers/spree/admin/reports_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/spree/admin/reports_controller_spec.rb +++ b/spec/controllers/spree/admin/reports_controller_spec.rb @@ -0,0 +1,57 @@+require 'spec_helper' ...
WIP: Test for enterprise user access in reports
diff --git a/songkick-oauth2-provider.gemspec b/songkick-oauth2-provider.gemspec index abc1234..def5678 100644 --- a/songkick-oauth2-provider.gemspec +++ b/songkick-oauth2-provider.gemspec @@ -19,6 +19,7 @@ s.add_development_dependency("appraisal", "~> 0.4.0") s.add_development_dependency("activerecord", "~> 3.2...
Add mysql dependency when running tests on MySQL.
diff --git a/spec/knapsack_pro/runners/queue/minitest_runner_spec.rb b/spec/knapsack_pro/runners/queue/minitest_runner_spec.rb index abc1234..def5678 100644 --- a/spec/knapsack_pro/runners/queue/minitest_runner_spec.rb +++ b/spec/knapsack_pro/runners/queue/minitest_runner_spec.rb @@ -0,0 +1,47 @@+describe KnapsackPro::...
Add test for .run method