diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/controllers/dashboard_controller.rb b/app/controllers/dashboard_controller.rb index abc1234..def5678 100644 --- a/app/controllers/dashboard_controller.rb +++ b/app/controllers/dashboard_controller.rb @@ -1,29 +1,72 @@ class DashboardController < ApplicationController def index @current_account ...
Update dashboard controller to load chart data
diff --git a/app/controllers/employers_controller.rb b/app/controllers/employers_controller.rb index abc1234..def5678 100644 --- a/app/controllers/employers_controller.rb +++ b/app/controllers/employers_controller.rb @@ -1,7 +1,7 @@ class EmployersController < ApplicationController before_action :authenticate_employ...
Fix permission and set employer
diff --git a/app/controllers/proposals_controller.rb b/app/controllers/proposals_controller.rb index abc1234..def5678 100644 --- a/app/controllers/proposals_controller.rb +++ b/app/controllers/proposals_controller.rb @@ -2,19 +2,20 @@ respond_to :html def index - # Fetch open proposals - @proposals = co....
Fix /proposals displaying resolution-proposals as currently-open resolutions.
diff --git a/app/controllers/sms_tests_controller.rb b/app/controllers/sms_tests_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sms_tests_controller.rb +++ b/app/controllers/sms_tests_controller.rb @@ -8,16 +8,20 @@ # handles a request for a test. this will be an AJAX call so we only return the mes...
Set adapter name on reply
diff --git a/lib/llt/diff/parser/postag_diff.rb b/lib/llt/diff/parser/postag_diff.rb index abc1234..def5678 100644 --- a/lib/llt/diff/parser/postag_diff.rb +++ b/lib/llt/diff/parser/postag_diff.rb @@ -1,5 +1,7 @@ module LLT class Diff::Parser + # This class is redundant right now, we keep it around because we + ...
Add comment in PostagDiff about its current status
diff --git a/app/models/gobierto_common/custom_field.rb b/app/models/gobierto_common/custom_field.rb index abc1234..def5678 100644 --- a/app/models/gobierto_common/custom_field.rb +++ b/app/models/gobierto_common/custom_field.rb @@ -4,6 +4,7 @@ class CustomField < ApplicationRecord belongs_to :site has_many...
Add validation to custom field name
diff --git a/app/presenters/money_question_presenter.rb b/app/presenters/money_question_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/money_question_presenter.rb +++ b/app/presenters/money_question_presenter.rb @@ -6,7 +6,7 @@ end def hint_text - text = [body, "in £", suffix_label].reject(&:...
Remove "in £" from money input As recommended by the Content Designers.
diff --git a/app/graphql/annict_schema.rb b/app/graphql/annict_schema.rb index abc1234..def5678 100644 --- a/app/graphql/annict_schema.rb +++ b/app/graphql/annict_schema.rb @@ -1,24 +1,24 @@ # frozen_string_literal: true -AnnictSchema = GraphQL::Schema.define do +class AnnictSchema < GraphQL::Schema query ObjectTy...
Change to class style schema
diff --git a/app/views/api/v1/places/index.json.rabl b/app/views/api/v1/places/index.json.rabl index abc1234..def5678 100644 --- a/app/views/api/v1/places/index.json.rabl +++ b/app/views/api/v1/places/index.json.rabl @@ -1,6 +1,5 @@ collection @places attributes :id, :name, :city, :address, :latitude, :longitude, :ac...
Remove farm attribute form places.
diff --git a/features/support/remote_command_helpers.rb b/features/support/remote_command_helpers.rb index abc1234..def5678 100644 --- a/features/support/remote_command_helpers.rb +++ b/features/support/remote_command_helpers.rb @@ -17,8 +17,8 @@ def safely_remove_file(_path) run_vagrant_command("rm #{test_fil...
Revert issue introduced by misunderstanding of rescue modifier
diff --git a/config/initializers/extensions.rb b/config/initializers/extensions.rb index abc1234..def5678 100644 --- a/config/initializers/extensions.rb +++ b/config/initializers/extensions.rb @@ -3,8 +3,8 @@ idx = path.rindex(/\//) if idx file_portion = path.slice(idx+1, path.length) - versions << file_po...
Fix issue with finding the latest version of models
diff --git a/config/initializers/udp_logger.rb b/config/initializers/udp_logger.rb index abc1234..def5678 100644 --- a/config/initializers/udp_logger.rb +++ b/config/initializers/udp_logger.rb @@ -20,8 +20,7 @@ id: id, message: name, racing_association: RacingAssociation.current.short_name, - s...
Remove _ttl from logger. Needs to be in Logstash -> Elasticsearch bit.
diff --git a/spec/integration/adapter_spec.rb b/spec/integration/adapter_spec.rb index abc1234..def5678 100644 --- a/spec/integration/adapter_spec.rb +++ b/spec/integration/adapter_spec.rb @@ -7,15 +7,9 @@ let(:path) { File.expand_path("./spec/fixtures/users.csv") } # If :csv is not passed in the repository is n...
Update spec to pass on latest rom
diff --git a/spec/integration/console_spec.rb b/spec/integration/console_spec.rb index abc1234..def5678 100644 --- a/spec/integration/console_spec.rb +++ b/spec/integration/console_spec.rb @@ -18,6 +18,6 @@ subject(:console_access) { client.console_access(vm: vm) } it "returns html for console access" do - ex...
Make console integration spec more specific
diff --git a/spec/react/refs_callback_spec.rb b/spec/react/refs_callback_spec.rb index abc1234..def5678 100644 --- a/spec/react/refs_callback_spec.rb +++ b/spec/react/refs_callback_spec.rb @@ -1,3 +1,7 @@+require 'spec_helper' + +if opal? + describe 'Refs callback' do before do stub_const 'Foo', Class.new @@ -...
Fix dynamic constant assignment error
diff --git a/app/jobs/export_async_job.rb b/app/jobs/export_async_job.rb index abc1234..def5678 100644 --- a/app/jobs/export_async_job.rb +++ b/app/jobs/export_async_job.rb @@ -12,14 +12,14 @@ params_class = "#{resource_class_name}Parameters".constantize # Get a new ActiveRecord::Relation from the sql_string...
Add record count to the filename
diff --git a/app/services/pickup_cards.rb b/app/services/pickup_cards.rb index abc1234..def5678 100644 --- a/app/services/pickup_cards.rb +++ b/app/services/pickup_cards.rb @@ -1,14 +1,6 @@-class PickupCards - attr_reader :errors - - def initialize(player, round) - @player = player - @round = round - @error...
Refactor PickupCards into a struct for simplicity
diff --git a/spec/models/organization_spec.rb b/spec/models/organization_spec.rb index abc1234..def5678 100644 --- a/spec/models/organization_spec.rb +++ b/spec/models/organization_spec.rb @@ -10,4 +10,18 @@ str_dump.should include('Kirjasto') end + it 'provides an error on duplicate key' do + h = FactoryG...
Add specs for Organization validations
diff --git a/spec/unit/view/null_part_spec.rb b/spec/unit/view/null_part_spec.rb index abc1234..def5678 100644 --- a/spec/unit/view/null_part_spec.rb +++ b/spec/unit/view/null_part_spec.rb @@ -0,0 +1,39 @@+require 'rodakase/view/null_part' + +RSpec.describe Rodakase::View::NullPart do + subject(:part) do + Rodakase...
Add some initial unit tests for null part
diff --git a/simple_form_fancy_uploads.gemspec b/simple_form_fancy_uploads.gemspec index abc1234..def5678 100644 --- a/simple_form_fancy_uploads.gemspec +++ b/simple_form_fancy_uploads.gemspec @@ -15,7 +15,7 @@ s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.md"] - s.add_dependenc...
Allow gem to work with Rails 4.1
diff --git a/activesupport/lib/active_support/message_verifier.rb b/activesupport/lib/active_support/message_verifier.rb index abc1234..def5678 100644 --- a/activesupport/lib/active_support/message_verifier.rb +++ b/activesupport/lib/active_support/message_verifier.rb @@ -25,10 +25,10 @@ def verify(signed_mes...
Fix timing attack vulnerability in ActiveSupport::MessageVerifier. Use a constant-time comparison algorithm to compare the candidate HMAC with the calculated HMAC to prevent leaking information about the calculated HMAC. Signed-off-by: Michael Koziarski <17b9e1c64588c7fa6419b4d29dc1f4426279ba01@koziarski.com>
diff --git a/aphrodite/app/views/api/v2/documents/index.json.rabl b/aphrodite/app/views/api/v2/documents/index.json.rabl index abc1234..def5678 100644 --- a/aphrodite/app/views/api/v2/documents/index.json.rabl +++ b/aphrodite/app/views/api/v2/documents/index.json.rabl @@ -1,2 +1,11 @@ collection @documents -attributes ...
[aphrodite] Add counters information to documents
diff --git a/examples/authorization/create_authorization_with_account.rb b/examples/authorization/create_authorization_with_account.rb index abc1234..def5678 100644 --- a/examples/authorization/create_authorization_with_account.rb +++ b/examples/authorization/create_authorization_with_account.rb @@ -0,0 +1,56 @@+requir...
Add example create authorization request with an account
diff --git a/app/controllers/compare_controller.rb b/app/controllers/compare_controller.rb index abc1234..def5678 100644 --- a/app/controllers/compare_controller.rb +++ b/app/controllers/compare_controller.rb @@ -18,8 +18,8 @@ query_results = {} base_selection = UserSelections.new( __safe_params: { - ...
Fix for ignored date params in compare search. Proposed fix for #118 'date picker not working in compare view'. The problem was that seeding the user selections model with the given from and to dates was using symbol keys not string keys.
diff --git a/app/controllers/exports_controller.rb b/app/controllers/exports_controller.rb index abc1234..def5678 100644 --- a/app/controllers/exports_controller.rb +++ b/app/controllers/exports_controller.rb @@ -9,7 +9,6 @@ attendances = AttendanceExportsHelper. get_attendances(params[:course_id], params[:s...
Move render to end of statement
diff --git a/app/controllers/profile_controller.rb b/app/controllers/profile_controller.rb index abc1234..def5678 100644 --- a/app/controllers/profile_controller.rb +++ b/app/controllers/profile_controller.rb @@ -1,5 +1,5 @@ class ProfileController < ArticlesController - before_action :require_sign_in + before_action...
Use Device provided `before_action :authenticate_user!` instead of `user_signed_in?` from the Authentication concern.
diff --git a/lib/bumbleworks/redis/adapter.rb b/lib/bumbleworks/redis/adapter.rb index abc1234..def5678 100644 --- a/lib/bumbleworks/redis/adapter.rb +++ b/lib/bumbleworks/redis/adapter.rb @@ -1,4 +1,5 @@ require "bumbleworks/storage_adapter" +require "rufus-json/automatic" require "ruote-redis" module Bumbleworks
Use rufus-json's automatic JSON library loading
diff --git a/spec/features/config_spec.rb b/spec/features/config_spec.rb index abc1234..def5678 100644 --- a/spec/features/config_spec.rb +++ b/spec/features/config_spec.rb @@ -40,6 +40,10 @@ expect(User.all.count).to equal 1 expect(page).to have_content "Logged in as" end + + it 'outputs t...
Add test for table header on pages list Make sure the table header is html, not escaped text. Conflicts: spec/features/config_spec.rb
diff --git a/spec/lib/pixi_client_spec.rb b/spec/lib/pixi_client_spec.rb index abc1234..def5678 100644 --- a/spec/lib/pixi_client_spec.rb +++ b/spec/lib/pixi_client_spec.rb @@ -6,6 +6,7 @@ configuration.endpoint = 'endpoint' configuration.username = 'username' configuration.password = 'random-passwo...
Test the configuration too after adding the wsdl
diff --git a/spec/models/relation_spec.rb b/spec/models/relation_spec.rb index abc1234..def5678 100644 --- a/spec/models/relation_spec.rb +++ b/spec/models/relation_spec.rb @@ -0,0 +1,26 @@+require 'rails_helper' + +describe RelatedContent do + + let(:parent_relationable) { create([:proposal, :debate, :budget_investme...
Add basic RelatedContent model spec to check multiple models can be related
diff --git a/spec/support/proc_helpers.rb b/spec/support/proc_helpers.rb index abc1234..def5678 100644 --- a/spec/support/proc_helpers.rb +++ b/spec/support/proc_helpers.rb @@ -11,6 +11,8 @@ yield [$stdout.string, $stderr.string] + rescue SystemExit => ex + fail "Unexpected SystemExit in capture_io: std...
Improve capture_io handling of unexpected exceptions We frequently use `capture_io` in specs for testing running CLI commands, many of which will indirectly end up calling `exit 1` in failure conditions. For a happy-path spec, if a regression breaks the spec, this is problematic because `exit 1` gets called & `rspec`...
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -11,7 +11,7 @@ for slice in graph res = http.head("/devices/?query=#{CGI::escape ActiveSuppor...
Use path-only URLs for chart slices.
diff --git a/app/controllers/site_controller.rb b/app/controllers/site_controller.rb index abc1234..def5678 100644 --- a/app/controllers/site_controller.rb +++ b/app/controllers/site_controller.rb @@ -7,6 +7,8 @@ @character = Character.where(id: params[:id], public: true).pluck(:name, :description).first els...
Support public battlegroup name/description on Discord links
diff --git a/app/helpers/font_awesome_helper.rb b/app/helpers/font_awesome_helper.rb index abc1234..def5678 100644 --- a/app/helpers/font_awesome_helper.rb +++ b/app/helpers/font_awesome_helper.rb @@ -10,17 +10,20 @@ def label_with_icon(label, icon, opts = {}) + fa_icon(icon, opts) + label + end + + + def fa...
Add a hlper method to render FontAwesome icons
diff --git a/app/models/prompt_delivery_hour.rb b/app/models/prompt_delivery_hour.rb index abc1234..def5678 100644 --- a/app/models/prompt_delivery_hour.rb +++ b/app/models/prompt_delivery_hour.rb @@ -5,11 +5,11 @@ end def in_time_zone - in_24_hours(hour + offset) + in_24_hours(hour + time_zone_offset) ...
Use Rails voodoo to get DST offset automatically
diff --git a/rocketjob_mission_control.gemspec b/rocketjob_mission_control.gemspec index abc1234..def5678 100644 --- a/rocketjob_mission_control.gemspec +++ b/rocketjob_mission_control.gemspec @@ -16,7 +16,7 @@ s.add_dependency "access-granted", "~> 1.3" s.add_dependency "jquery-rails" - s.add_dependency "rails...
Change rails dependency to railties
diff --git a/lib/kepler_processor/saveable.rb b/lib/kepler_processor/saveable.rb index abc1234..def5678 100644 --- a/lib/kepler_processor/saveable.rb +++ b/lib/kepler_processor/saveable.rb @@ -1,5 +1,6 @@ module KeplerProcessor module Saveable + def full_output_filename "#{@options[:output_path]}/#{outpu...
Make Saveable a little prettier
diff --git a/lib/magnum/integration/github.rb b/lib/magnum/integration/github.rb index abc1234..def5678 100644 --- a/lib/magnum/integration/github.rb +++ b/lib/magnum/integration/github.rb @@ -7,7 +7,8 @@ end def repositories - client.repositories.map { |r| format_repository(r) } + resp = client.re...
Sort repositories by push date
diff --git a/lib/rails_translation_manager.rb b/lib/rails_translation_manager.rb index abc1234..def5678 100644 --- a/lib/rails_translation_manager.rb +++ b/lib/rails_translation_manager.rb @@ -13,4 +13,12 @@ autoload :Exporter, "rails_translation_manager/exporter" autoload :Importer, "rails_translation_manager/imp...
Add plural rules to I18n load path This adds the native plural rules in rails-i18n and the bespoke list we created in `config/locales/plurals.rb`. This allows them to be located when we lookup the plural rules for all our supported languages. `concat` and `Dir` have been used instead of `<< `..pluralization/*.rb` for...
diff --git a/config/initializers/active_record_mysql_timestamp.rb b/config/initializers/active_record_mysql_timestamp.rb index abc1234..def5678 100644 --- a/config/initializers/active_record_mysql_timestamp.rb +++ b/config/initializers/active_record_mysql_timestamp.rb @@ -0,0 +1,30 @@+# Make sure that MySQL won't try t...
Make sure MySQL would not use CURRENT_TIMESTAMP for timestamp columns magically. See: https://gitlab.com/gitlab-org/gitlab-ce/issues/36405
diff --git a/config/initializers/refraction_rules.rb b/config/initializers/refraction_rules.rb index abc1234..def5678 100644 --- a/config/initializers/refraction_rules.rb +++ b/config/initializers/refraction_rules.rb @@ -8,7 +8,7 @@ Rails.logger.add(1, "\n\nREDIRECT : redirect issued for old heroku address\n\n") ...
Revert "the flush was causing an app error, why was this not caught earlier?" This reverts commit 834ebf3a026ae3de951917b231eecf70062756d9.
diff --git a/spec/bitmap_spec.rb b/spec/bitmap_spec.rb index abc1234..def5678 100644 --- a/spec/bitmap_spec.rb +++ b/spec/bitmap_spec.rb @@ -1,33 +1,36 @@ require 'bitmap' require 'color' -RSpec.describe Bitmap, "#init" do - context "With a given width and height" do - width, height = 2, 2 - it "initializes a...
Refactor tests and add todo for new test cases.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,27 +1,15 @@ require 'serverspec' -require 'net/ssh' - -include SpecInfra::Helper::DetectOS -include SpecInfra::Helper::Exec -include SpecInfra::Helper::Ssh if ENV['RAKE_ANS...
Update integration testing to work with Serverspec 2.N
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1 +1,12 @@ require 'cassandra/mapper' + +TEST_KEYSPACE = 'test_mapper' + +# create testing keyspace if needed +cassandra = Cassandra.new('system') +unless cassandra.keyspaces.incl...
Create testing keyspace if needed
diff --git a/app/views/osc_jobs/show.json.jbuilder b/app/views/osc_jobs/show.json.jbuilder index abc1234..def5678 100644 --- a/app/views/osc_jobs/show.json.jbuilder +++ b/app/views/osc_jobs/show.json.jbuilder @@ -1 +1,2 @@ json.extract! @osc_job, :name, :batch_host, :created_at, :updated_at +json.folder_contents @folde...
Include job folder contents in payload
diff --git a/config/initializers/delayed_job.rb b/config/initializers/delayed_job.rb index abc1234..def5678 100644 --- a/config/initializers/delayed_job.rb +++ b/config/initializers/delayed_job.rb @@ -12,4 +12,28 @@ ActionMailer::Base.logger = Delayed::Worker.logger + module Delayed + module Backend + mo...
Hide delayed job sql messages in production.log
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,5 +1,10 @@ require 'coveralls' Coveralls.wear! + +SimpleCov.formatter = Coveralls::SimpleCov::Formatter +SimpleCov.start do + add_filter 'spec/dummy' +end ENV["RAILS_ENV"] ...
Exclude spec/dummy from SimpleCov for Coveralls
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -21,12 +21,11 @@ config.run_all_when_everything_filtered = true config.filter_run :focus config.raise_errors_for_deprecations! - - # Run specs in random order to surface o...
Update specs helper to prevent monkey patching.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,2 +1,14 @@ $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__) require 'rubyxls' + +RSpec.configure do |config| + + config.after(:all) do + FileUtils.rm_rf("#{tmp_di...
Remove contents of tmp dir after build
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -9,3 +9,9 @@ Dir[SPEC_DIR.join("support", "**", "*.rb")].each {|f| require f} CONFIG = YAML.load_file(SPEC_DIR.join("config.yml")).with_indifferent_access + +RSpec.configure do ...
Set sandbox to true for tests
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,10 +1,10 @@-require 'bundler' -Bundler.require - require 'coveralls' Coveralls.wear! do add_filter 'spec' end + +require 'bundler' +Bundler.require require 'acfs' requ...
Move Bundler.require to get coverage back.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -17,7 +17,7 @@ add_group 'Libraries', '/lib/' end - SimpleCov.minimum_coverage(99) + SimpleCov.minimum_coverage(98) SimpleCov.start 'gem' end
Drop test coverage to 98% Tests are good but 99% is very high and we need the VPN functionality ASAP.
diff --git a/api.rb b/api.rb index abc1234..def5678 100644 --- a/api.rb +++ b/api.rb @@ -6,9 +6,7 @@ "It runs from Heroku!" end -get '/messages/next' do - return {:message => "A message!"}.to_json -end +### MOBILE CLIENT API # API sends 'message' as : # message_id @@ -16,23 +14,31 @@ # delay (of current mess...
Clarify mobile client API routes Shorten the base routes and move required paramaters. Add basic pseudocode to methods.
diff --git a/spec/acceptance/001_basic_spec.rb b/spec/acceptance/001_basic_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/001_basic_spec.rb +++ b/spec/acceptance/001_basic_spec.rb @@ -34,7 +34,7 @@ expect(apply_manifest(pp, :catch_failures => true).exit_code).to be_zero sleep 5 end -logst...
Remove extra string in stub acceptance test
diff --git a/spec/active_record_spec_helper.rb b/spec/active_record_spec_helper.rb index abc1234..def5678 100644 --- a/spec/active_record_spec_helper.rb +++ b/spec/active_record_spec_helper.rb @@ -16,7 +16,7 @@ /../config/initializers/#{name}.rb") end - connection_info = YAML.load_file...
Fix yaml erb parsing when Rails is not loaded
diff --git a/spec/controllers/conference_registration_controller_spec.rb b/spec/controllers/conference_registration_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/conference_registration_controller_spec.rb +++ b/spec/controllers/conference_registration_controller_spec.rb @@ -0,0 +1,76 @@+requir...
Add test for conference registration controller edit and update action
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -15,6 +15,7 @@ DB_DIR = APP_ROOT + 'db' DB_DIR.mkpath + DataMapper.setup(:default, ENV['DATABASE_URL'] || "sqlite://#{DB_DIR}/tdrb.db") end
Add newline in configure block for cleanliness
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -1,4 +1,6 @@ require 'sinatra' + +set :sessions, true get '/' do File.read('index.html') @@ -6,4 +8,11 @@ post '/demo' do "The username is #{params['username']} and the password is #{params['password']}" + session[:useri...
Add a little more info
diff --git a/spec/controllers/requests_controller_spec.rb b/spec/controllers/requests_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/requests_controller_spec.rb +++ b/spec/controllers/requests_controller_spec.rb @@ -28,14 +28,8 @@ context 'when request ID is not created' do it 'throw...
Remove check for private requests Not used and it was showing as a passing test.
diff --git a/lib/api_wrapper_example/mock/api_server.rb b/lib/api_wrapper_example/mock/api_server.rb index abc1234..def5678 100644 --- a/lib/api_wrapper_example/mock/api_server.rb +++ b/lib/api_wrapper_example/mock/api_server.rb @@ -8,6 +8,15 @@ get '/v1/mittens' do JSON.dump(REPO) + end + + ...
Implement mock version of GET /v1/mittens/:name
diff --git a/lib/brewery_db/middleware/error_handler.rb b/lib/brewery_db/middleware/error_handler.rb index abc1234..def5678 100644 --- a/lib/brewery_db/middleware/error_handler.rb +++ b/lib/brewery_db/middleware/error_handler.rb @@ -6,7 +6,7 @@ when 200 when 400 then raise BadRequest.new(env[:body]...
Fix failing error handler specs under Ruby 1.9.2.
diff --git a/lib/minitest/ruby_golf_metrics/reporter.rb b/lib/minitest/ruby_golf_metrics/reporter.rb index abc1234..def5678 100644 --- a/lib/minitest/ruby_golf_metrics/reporter.rb +++ b/lib/minitest/ruby_golf_metrics/reporter.rb @@ -21,7 +21,7 @@ def report io.puts "\nRuby Golf Metrics" - @ergs....
Sort metrics output by method name
diff --git a/lib/puppet-lint/plugins/check_variables.rb b/lib/puppet-lint/plugins/check_variables.rb index abc1234..def5678 100644 --- a/lib/puppet-lint/plugins/check_variables.rb +++ b/lib/puppet-lint/plugins/check_variables.rb @@ -1,23 +1,18 @@ class PuppetLint::Plugins::CheckVariables < PuppetLint::CheckPlugin + # ...
Rewrite variable_contains_dash check to use new lexer
diff --git a/lib/puppet/parser/functions/query_nodes.rb b/lib/puppet/parser/functions/query_nodes.rb index abc1234..def5678 100644 --- a/lib/puppet/parser/functions/query_nodes.rb +++ b/lib/puppet/parser/functions/query_nodes.rb @@ -11,8 +11,8 @@ EOT ) do |args| + query, filter = args require File.expand_path(Fi...
Fix query node to remove active only filter. Query node should not filter by active_only node.
diff --git a/db/migrate/20150618193748_create_skills.rb b/db/migrate/20150618193748_create_skills.rb index abc1234..def5678 100644 --- a/db/migrate/20150618193748_create_skills.rb +++ b/db/migrate/20150618193748_create_skills.rb @@ -2,8 +2,8 @@ def change create_table :skills do |t| t.string :title - ...
Add defaults to skills migration
diff --git a/db/seeds/modules/gobierto_data/seeds.rb b/db/seeds/modules/gobierto_data/seeds.rb index abc1234..def5678 100644 --- a/db/seeds/modules/gobierto_data/seeds.rb +++ b/db/seeds/modules/gobierto_data/seeds.rb @@ -0,0 +1,52 @@+# frozen_string_literal: true + +module GobiertoSeeds + class Recipe + def self.ru...
Add seed recipe of gobierto data with default custom fields
diff --git a/app/channels/run_channel.rb b/app/channels/run_channel.rb index abc1234..def5678 100644 --- a/app/channels/run_channel.rb +++ b/app/channels/run_channel.rb @@ -11,6 +11,8 @@ run, time_since_upload: ApplicationController.render(partial: 'runs/time_since_upload', locals: {run: run}) )...
Fix jobs running on dead runs
diff --git a/test/unit/document_queue_test.rb b/test/unit/document_queue_test.rb index abc1234..def5678 100644 --- a/test/unit/document_queue_test.rb +++ b/test/unit/document_queue_test.rb @@ -0,0 +1,18 @@+require "test_helper" +require "elasticsearch/document_queue" +require "elasticsearch/bulk_index_worker" + +class ...
Test the functionality of the DocumentQueue.
diff --git a/test/cookbooks/apache2_test/recipes/setup.rb b/test/cookbooks/apache2_test/recipes/setup.rb index abc1234..def5678 100644 --- a/test/cookbooks/apache2_test/recipes/setup.rb +++ b/test/cookbooks/apache2_test/recipes/setup.rb @@ -2,19 +2,9 @@ case node['platform_family'] when 'debian' - %w(libxml2 libxml...
Use multipackage installs in the test recipe Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/tasks/modules/logging/collins.rb b/tasks/modules/logging/collins.rb index abc1234..def5678 100644 --- a/tasks/modules/logging/collins.rb +++ b/tasks/modules/logging/collins.rb @@ -10,8 +10,8 @@ end def self.log message - if self.facter['asset_tag'] - collins.log! 'tumblrtag301', mess...
Use asset tag from facter when logging
diff --git a/config/deploy/production2.rb b/config/deploy/production2.rb index abc1234..def5678 100644 --- a/config/deploy/production2.rb +++ b/config/deploy/production2.rb @@ -4,7 +4,7 @@ # uncomment in case of travis, capistrano will have its own set :ssh_options, keys: ["config/deploy_id_rsa"] if File.exist?("confi...
Update token for merchant 2
diff --git a/ci_environment/postgresql/attributes/default.rb b/ci_environment/postgresql/attributes/default.rb index abc1234..def5678 100644 --- a/ci_environment/postgresql/attributes/default.rb +++ b/ci_environment/postgresql/attributes/default.rb @@ -13,6 +13,7 @@ default['postgresql']['data_on_ramfs'] = true ...
Fix RAMFS dependency problem in PostgreSQL Related to 050c194a4be0bdcc6a6dd1bcfc61c69ffe41df97 Still pending to check if this regression affects Chef 10 and 11
diff --git a/spec/system/cars_endpoint_spec.rb b/spec/system/cars_endpoint_spec.rb index abc1234..def5678 100644 --- a/spec/system/cars_endpoint_spec.rb +++ b/spec/system/cars_endpoint_spec.rb @@ -0,0 +1,39 @@+require "json" + +RSpec.describe "System tests" do + describe "/cars API endpoint" do + let!(:pipe) { open...
Add smoke tests for /cars endpoint together with import command
diff --git a/cookbooks/elasticsearch/recipes/sensu_checks.rb b/cookbooks/elasticsearch/recipes/sensu_checks.rb index abc1234..def5678 100644 --- a/cookbooks/elasticsearch/recipes/sensu_checks.rb +++ b/cookbooks/elasticsearch/recipes/sensu_checks.rb @@ -8,6 +8,9 @@ sensu_check 'check-es-cluster-status' do command ...
Set the number of occurrences to 3 for the cluster status alarm.
diff --git a/test/admin_ui/test_api_scopes.rb b/test/admin_ui/test_api_scopes.rb index abc1234..def5678 100644 --- a/test/admin_ui/test_api_scopes.rb +++ b/test/admin_ui/test_api_scopes.rb @@ -0,0 +1,54 @@+require_relative "../test_helper" + +class Test::AdminUi::TestApiScopes < Minitest::Capybara::Test + include Capy...
Add tests for api scope forms in admin UI too.
diff --git a/examples/multi_select_disabled_paged.rb b/examples/multi_select_disabled_paged.rb index abc1234..def5678 100644 --- a/examples/multi_select_disabled_paged.rb +++ b/examples/multi_select_disabled_paged.rb @@ -0,0 +1,22 @@+# frozen_string_literal: true + +require_relative "../lib/tty-prompt" + +prompt = TTY:...
Add multi_select prompt pagination of disabled items example
diff --git a/custom_counter_cache.gemspec b/custom_counter_cache.gemspec index abc1234..def5678 100644 --- a/custom_counter_cache.gemspec +++ b/custom_counter_cache.gemspec @@ -13,7 +13,7 @@ s.require_paths = ['lib'] s.files = Dir['lib/**/*.rb'] s.required_rubygems_version = '>= 1.3.6' - s.add_dependency('rail...
Fix Rails version requirement for Travis.
diff --git a/chef/site-cookbooks/sana-protocol-builder/recipes/default.rb b/chef/site-cookbooks/sana-protocol-builder/recipes/default.rb index abc1234..def5678 100644 --- a/chef/site-cookbooks/sana-protocol-builder/recipes/default.rb +++ b/chef/site-cookbooks/sana-protocol-builder/recipes/default.rb @@ -28,7 +28,7 @@ ...
Fix environment to be a hash.
diff --git a/lib/pathway/rspec/matchers/list_helpers.rb b/lib/pathway/rspec/matchers/list_helpers.rb index abc1234..def5678 100644 --- a/lib/pathway/rspec/matchers/list_helpers.rb +++ b/lib/pathway/rspec/matchers/list_helpers.rb @@ -3,8 +3,8 @@ module Pathway module Rspec module ListHelpers - def as_list(i...
Allow as_list helper for matcher to take connectors as params
diff --git a/config/deploy/interactions-staging.rb b/config/deploy/interactions-staging.rb index abc1234..def5678 100644 --- a/config/deploy/interactions-staging.rb +++ b/config/deploy/interactions-staging.rb @@ -1,5 +1,6 @@ # interactions staging branch set :user, "deploy" +set :gateway, "otto.concord.org" set :doma...
Update interactions staging deploy config
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -1,5 +1,6 @@-require 'chaindrive/api' -require 'chaindrive/web' +$:.unshift('lib').uniq! + +require 'chaindrive' use Rack::Session::Cookie run Rack::Cascade.new [Chaindrive::API, Chaindrive::Web]
Fix issue with load path and lib folder.
diff --git a/lib/docbert/parser.rb b/lib/docbert/parser.rb index abc1234..def5678 100644 --- a/lib/docbert/parser.rb +++ b/lib/docbert/parser.rb @@ -4,7 +4,6 @@ class Parser < Kramdown::Parser::Kramdown EXAMPLE_KEYWORDS = "Given|When|Then|And|But|\\|" EXAMPLE_START = /#{BLANK_LINE}?^\s*Example:/ - EXA...
Make example body regexp dynamically configurable.
diff --git a/lib/llt/review/api.rb b/lib/llt/review/api.rb index abc1234..def5678 100644 --- a/lib/llt/review/api.rb +++ b/lib/llt/review/api.rb @@ -9,11 +9,15 @@ gold = Array(params[:gold]) rev = Array(params[:reviewable]) + comp_param = params[:compare] + comparables = comp_param ? Array(comp_param)...
Add compare param to diff routes
diff --git a/lib/mill/navigator.rb b/lib/mill/navigator.rb index abc1234..def5678 100644 --- a/lib/mill/navigator.rb +++ b/lib/mill/navigator.rb @@ -14,13 +14,14 @@ end - def initialize(items: []) + def initialize(items: [], site: nil) @items = Hash[ items.map do |uri, title| it...
Save site object in Navigator class for subclassing use.
diff --git a/fourchan_kit.gemspec b/fourchan_kit.gemspec index abc1234..def5678 100644 --- a/fourchan_kit.gemspec +++ b/fourchan_kit.gemspec @@ -21,4 +21,6 @@ spec.add_development_dependency "bundler", "~> 1.6" spec.add_development_dependency "rake" spec.add_development_dependency "rspec" + spec.add_developmen...
Add two dependencies for RSpec
diff --git a/lib/mongoid_seeder.rb b/lib/mongoid_seeder.rb index abc1234..def5678 100644 --- a/lib/mongoid_seeder.rb +++ b/lib/mongoid_seeder.rb @@ -47,6 +47,6 @@ end def self.after_tests - Mongoid.session(:default).collections.select{|a| Config.condition_to_drop_collection.call(a) }.each(&:drop) + Mongoid...
Make the collections truncate instead of drop
diff --git a/contrib/connected_active_record/sample/config/application.rb b/contrib/connected_active_record/sample/config/application.rb index abc1234..def5678 100644 --- a/contrib/connected_active_record/sample/config/application.rb +++ b/contrib/connected_active_record/sample/config/application.rb @@ -28,6 +28,8 @@ ...
Add load path for BCs
diff --git a/lib/souffle/server.rb b/lib/souffle/server.rb index abc1234..def5678 100644 --- a/lib/souffle/server.rb +++ b/lib/souffle/server.rb @@ -1,5 +1,6 @@ require 'puma' require 'eventmachine' +require 'em-synchrony' require 'souffle/http' # The souffle server and management daemon. @@ -12,7 +13,7 @@ # Run...
Update event loop to use em-synchrony
diff --git a/db/migrate/20160912161354_reset_pk.rb b/db/migrate/20160912161354_reset_pk.rb index abc1234..def5678 100644 --- a/db/migrate/20160912161354_reset_pk.rb +++ b/db/migrate/20160912161354_reset_pk.rb @@ -0,0 +1,7 @@+class ResetPk < ActiveRecord::Migration[5.0] + def change + ActiveRecord::Base.connection.t...
Add migration to fix primary key issue
diff --git a/lib/kaminari/models/mongoid_criteria_methods.rb b/lib/kaminari/models/mongoid_criteria_methods.rb index abc1234..def5678 100644 --- a/lib/kaminari/models/mongoid_criteria_methods.rb +++ b/lib/kaminari/models/mongoid_criteria_methods.rb @@ -1,5 +1,9 @@ module Kaminari module MongoidCriteriaMethods + d...
Simplify page_entries_info by adding entry_name interface to each ORM
diff --git a/spec/entities/resource_spec.rb b/spec/entities/resource_spec.rb index abc1234..def5678 100644 --- a/spec/entities/resource_spec.rb +++ b/spec/entities/resource_spec.rb @@ -0,0 +1,29 @@+describe Dox::Entities::Resource do + subject { described_class } + + let(:resource_name) { 'Pokemons' } + let(:details...
Add entities specs for resource
diff --git a/spec/features/donation_spec.rb b/spec/features/donation_spec.rb index abc1234..def5678 100644 --- a/spec/features/donation_spec.rb +++ b/spec/features/donation_spec.rb @@ -11,8 +11,22 @@ Capybara.within_frame 'stripe_checkout_app' do fill_in 'Email', with: 'rspec@example.com' - fill_in 'C...
Use stupid workaround for stripe input
diff --git a/lib/parkaby/frameworks/camping.rb b/lib/parkaby/frameworks/camping.rb index abc1234..def5678 100644 --- a/lib/parkaby/frameworks/camping.rb +++ b/lib/parkaby/frameworks/camping.rb @@ -1,34 +1,58 @@ Parkaby.load('parse_tree', 'ParseTree') module Parkaby::Frameworks::Camping + class Processor < SexpProce...
Make the Camping handler smarter
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -4,20 +4,21 @@ require 'beaker/module_install_helper' run_puppet_install_helper unless ENV['BEAKER_provision'] == 'no' -install_ca_ce...
Clean up acceptance spec helper
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -3,7 +3,7 @@ hosts.each do |host| # Install Puppet - on host, install_puppet + install_package(host, 'puppet') end RSpec.conf...
Install puppet package from distro sources My acceptance tests should run against the lowest common denominator on which the module is supported. This is currently puppet 2.7 as shipped with Debian Wheezy. install_puppet installs from Puppetlabs repos, so switch to install_package instead.
diff --git a/spec/twitter/geo/point_spec.rb b/spec/twitter/geo/point_spec.rb index abc1234..def5678 100644 --- a/spec/twitter/geo/point_spec.rb +++ b/spec/twitter/geo/point_spec.rb @@ -28,7 +28,7 @@ describe "#latitude" do it "returns the latitude" do - @point.latitude.should eq -122.399983 + @point....
Fix "ambiguous first argument" warning
diff --git a/test/unit/repository_test.rb b/test/unit/repository_test.rb index abc1234..def5678 100644 --- a/test/unit/repository_test.rb +++ b/test/unit/repository_test.rb @@ -2,6 +2,10 @@ require 'citrus/repository' class RepositoryTest < UnitTestCase + def valid_repository_url + "git://github.com/pawelpacana/...
Fix repository url used in tests.
diff --git a/lib/brewery_db/collection.rb b/lib/brewery_db/collection.rb index abc1234..def5678 100644 --- a/lib/brewery_db/collection.rb +++ b/lib/brewery_db/collection.rb @@ -4,7 +4,7 @@ BATCH_SIZE = 50 - attr_reader :size, :page_count + attr_reader :size alias length size def initialize(res...
Remove page_count; it is not a concern of Collection
diff --git a/spec/requests/voice_survey_spec.rb b/spec/requests/voice_survey_spec.rb index abc1234..def5678 100644 --- a/spec/requests/voice_survey_spec.rb +++ b/spec/requests/voice_survey_spec.rb @@ -0,0 +1,20 @@+require 'spec_helper' + +describe "Voice Survey Interface" do + + def hash_from_xml(nokogiri_doc) + Ha...
Set up test for initial routing
diff --git a/spec/warden/jwt_auth/hooks_spec.rb b/spec/warden/jwt_auth/hooks_spec.rb index abc1234..def5678 100644 --- a/spec/warden/jwt_auth/hooks_spec.rb +++ b/spec/warden/jwt_auth/hooks_spec.rb @@ -17,12 +17,20 @@ end context 'when method and path match and scope is known ' do - it 'codes a token and...
Test hook provides user when generating the token