diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/auto_html/filters/instagram.rb b/lib/auto_html/filters/instagram.rb index abc1234..def5678 100644 --- a/lib/auto_html/filters/instagram.rb +++ b/lib/auto_html/filters/instagram.rb @@ -1,12 +1,10 @@ require 'uri' require 'net/http' -AutoHtml.add_filter(:instagram).with(:width => 616, :height => 714) ...
Remove height/width options as they don't make sense for this embed
diff --git a/config/initializers/engine_locale_fix.rb b/config/initializers/engine_locale_fix.rb index abc1234..def5678 100644 --- a/config/initializers/engine_locale_fix.rb +++ b/config/initializers/engine_locale_fix.rb @@ -0,0 +1,27 @@+module Rails + class Application + class RoutesReloader + + def reload_wi...
Add :locale param to routes of scoped engines This prevents an invalid "?locale=xx" from being added to the querystring on engine routes for engines mounted with a scope that has its own :locale parameter
diff --git a/lib/infinity_test/core/notifier.rb b/lib/infinity_test/core/notifier.rb index abc1234..def5678 100644 --- a/lib/infinity_test/core/notifier.rb +++ b/lib/infinity_test/core/notifier.rb @@ -15,7 +15,7 @@ end def notify - send(library).message(test_message).image(image).notify + s...
Add the Ruby version as the title of the notification
diff --git a/devise_browserid_authenticatable.gemspec b/devise_browserid_authenticatable.gemspec index abc1234..def5678 100644 --- a/devise_browserid_authenticatable.gemspec +++ b/devise_browserid_authenticatable.gemspec @@ -10,7 +10,7 @@ s.files = `git ls-files`.split("\n") s.require_paths = ["lib"] - ...
Increase the version to make the documentation go live.
diff --git a/proc_to_ast.gemspec b/proc_to_ast.gemspec index abc1234..def5678 100644 --- a/proc_to_ast.gemspec +++ b/proc_to_ast.gemspec @@ -22,7 +22,7 @@ spec.add_runtime_dependency "unparser" spec.add_runtime_dependency "coderay" - spec.add_development_dependency "bundler", "~> 1.6" + spec.add_development_de...
Fix bundler dependency for Ruby 2.0.0
diff --git a/lib/tasks/fix_system_comments.rake b/lib/tasks/fix_system_comments.rake index abc1234..def5678 100644 --- a/lib/tasks/fix_system_comments.rake +++ b/lib/tasks/fix_system_comments.rake @@ -0,0 +1,25 @@+# encoding: utf-8 +#-- +# Copyright (C) 2013 Gitorious AS +# +# This program is free software: you can...
Add task for disabling system comments
diff --git a/lib/utopia_dungeon_notifier/cli.rb b/lib/utopia_dungeon_notifier/cli.rb index abc1234..def5678 100644 --- a/lib/utopia_dungeon_notifier/cli.rb +++ b/lib/utopia_dungeon_notifier/cli.rb @@ -22,10 +22,12 @@ @secret_key = secret_key event = SummonsBoard::Event.new(uid: uid) text = "今日のユートピア...
Add weekly event and url.
diff --git a/activerecord/lib/active_record/fixture_set/render_context.rb b/activerecord/lib/active_record/fixture_set/render_context.rb index abc1234..def5678 100644 --- a/activerecord/lib/active_record/fixture_set/render_context.rb +++ b/activerecord/lib/active_record/fixture_set/render_context.rb @@ -10,7 +10,7 @@ ...
Fix for reading binary file on Windows
diff --git a/spec/controllers/members_controller_spec.rb b/spec/controllers/members_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/members_controller_spec.rb +++ b/spec/controllers/members_controller_spec.rb @@ -11,7 +11,8 @@ describe "GET 'show'" do it "returns http success" do - ...
Use factory to create test member
diff --git a/spec/controllers/workers_controller_spec.rb b/spec/controllers/workers_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/workers_controller_spec.rb +++ b/spec/controllers/workers_controller_spec.rb @@ -2,4 +2,18 @@ RSpec.describe Kuroko2::WorkersController, :type => :controller do ...
Add spec for workers controller
diff --git a/lib/endpoint_base/sinatra/base.rb b/lib/endpoint_base/sinatra/base.rb index abc1234..def5678 100644 --- a/lib/endpoint_base/sinatra/base.rb +++ b/lib/endpoint_base/sinatra/base.rb @@ -8,7 +8,7 @@ include EndpointBase::Concerns::ExceptionHandler get '/' do - "#{self.class.name} ok" + ...
Add newline at end of status check
diff --git a/spec/controllers/secrets_controller_spec.rb b/spec/controllers/secrets_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/secrets_controller_spec.rb +++ b/spec/controllers/secrets_controller_spec.rb @@ -14,7 +14,7 @@ end it "does not raise errors" do - SecretRetrieval.e...
Fix exception name in unit test
diff --git a/spec/features/user_answers_question_spec.rb b/spec/features/user_answers_question_spec.rb index abc1234..def5678 100644 --- a/spec/features/user_answers_question_spec.rb +++ b/spec/features/user_answers_question_spec.rb @@ -3,39 +3,51 @@ describe "User answers question" do fixtures :users, :questions ...
Fix user answers questions spec
diff --git a/db/migrate/20110902203823_add_allowed_children_cache_to_pages.rb b/db/migrate/20110902203823_add_allowed_children_cache_to_pages.rb index abc1234..def5678 100644 --- a/db/migrate/20110902203823_add_allowed_children_cache_to_pages.rb +++ b/db/migrate/20110902203823_add_allowed_children_cache_to_pages.rb @@ ...
Remove default because MYSQL blows up
diff --git a/spec/uploaders/cover_image_uploader_spec.rb b/spec/uploaders/cover_image_uploader_spec.rb index abc1234..def5678 100644 --- a/spec/uploaders/cover_image_uploader_spec.rb +++ b/spec/uploaders/cover_image_uploader_spec.rb @@ -9,13 +9,14 @@ let(:cover_image) { described_class.new } before do - cover...
Update cover_image_uploader spec to use rspec 3
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -1,7 +1,7 @@ class SessionsController < ApplicationController def new - render :login + rende...
Change render from login to new
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -1,10 +1,18 @@ class SessionsController < ApplicationController - def new - end def create + u...
Add logic to session controller
diff --git a/app/controllers/upgrades_controller.rb b/app/controllers/upgrades_controller.rb index abc1234..def5678 100644 --- a/app/controllers/upgrades_controller.rb +++ b/app/controllers/upgrades_controller.rb @@ -9,4 +9,8 @@ "upgrades." end helper_method :sort_column, :sort_direction, :sort_column_prefix ...
Sort upgrades by server name in upgrades/index
diff --git a/app/mailers/islay_shop/order_mailer.rb b/app/mailers/islay_shop/order_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/islay_shop/order_mailer.rb +++ b/app/mailers/islay_shop/order_mailer.rb @@ -30,8 +30,8 @@ end def cancelled(order) - return if Settings.for(:islay_shop, :disable_order_c...
Correct the lookup for the switch on order cancelled mail
diff --git a/app/representers/answer_representer.rb b/app/representers/answer_representer.rb index abc1234..def5678 100644 --- a/app/representers/answer_representer.rb +++ b/app/representers/answer_representer.rb @@ -11,4 +11,5 @@ property :respondent property :user_id property :answer_text + property :details...
Add details_text field for answers
diff --git a/app/models/etsource.rb b/app/models/etsource.rb index abc1234..def5678 100644 --- a/app/models/etsource.rb +++ b/app/models/etsource.rb @@ -9,7 +9,7 @@ # Used to check if an interface element is still required. def self.dataset_inputs @dataset_inputs ||= Atlas::SparseGraphQuery.all.flat_map do |q...
Check for any character which is not whitespace
diff --git a/tasks/native.rake b/tasks/native.rake index abc1234..def5678 100644 --- a/tasks/native.rake +++ b/tasks/native.rake @@ -27,7 +27,6 @@ else ext.cross_compile = true ext.cross_platform = ['i386-mswin32-60', 'i386-mingw32', 'x64-mingw32'] - ext.cross_config_options << "--enable-local" end e...
Stop messing with LDFLAGS when cross-compiling LDFLAGS cannot be used to link to specific versions, instead we should use extconf '--with-opt-dir'.
diff --git a/lib/sinatra_more/warden_plugin.rb b/lib/sinatra_more/warden_plugin.rb index abc1234..def5678 100644 --- a/lib/sinatra_more/warden_plugin.rb +++ b/lib/sinatra_more/warden_plugin.rb @@ -15,12 +15,20 @@ Warden::Strategies.add(:password) do def valid? - params['username'] || params['p...
Improve robustness of warden password strategy
diff --git a/config/environments/development.rb b/config/environments/development.rb index abc1234..def5678 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -11,7 +11,7 @@ # Show full error reports and disable caching config.consider_all_requests_local = true - c...
Set local caching to false.
diff --git a/lib/tasks/purge_fastly_cache.rake b/lib/tasks/purge_fastly_cache.rake index abc1234..def5678 100644 --- a/lib/tasks/purge_fastly_cache.rake +++ b/lib/tasks/purge_fastly_cache.rake @@ -0,0 +1,15 @@+# Implement full purge of Fastly CDN cache. Invoke using: +# heroku run rake fastly:purge --app NAME_OF_APP...
Add new "rake fastly:purge" command for purging Fastly cache This is useful when making changes to the code that cause sudden changes in the displayed badge level. This isn't tested yet, so there may be further changes to come. Signed-off-by: David A. Wheeler <9ae72d22d8b894b865a7a496af4fab6320e6abb2@dwheeler....
diff --git a/lib/whos_dated_who/bing_client.rb b/lib/whos_dated_who/bing_client.rb index abc1234..def5678 100644 --- a/lib/whos_dated_who/bing_client.rb +++ b/lib/whos_dated_who/bing_client.rb @@ -1,7 +1,8 @@ require 'yaml' module WhosDatedWho class BingClient - API_KEY = YAML.load_file( File.expand_path('~/.who...
Read bing api key from ENV to be Heroku friendly
diff --git a/lib/chef/handler/etcd_report.rb b/lib/chef/handler/etcd_report.rb index abc1234..def5678 100644 --- a/lib/chef/handler/etcd_report.rb +++ b/lib/chef/handler/etcd_report.rb @@ -15,7 +15,7 @@ def report if success? data = {total: all_resources.size, updated: updated_resources.size, ...
Fix a syntax error in etcd report handler.
diff --git a/spec/finders/email_alert_configuration_spec.rb b/spec/finders/email_alert_configuration_spec.rb index abc1234..def5678 100644 --- a/spec/finders/email_alert_configuration_spec.rb +++ b/spec/finders/email_alert_configuration_spec.rb @@ -0,0 +1,27 @@+require 'spec_helper' + +RSpec.describe "Email alert confi...
Test that email alerts are configured correctly We currently don't test that the "keys" to which a user can subscribe are actually valid. If one of the keys is mistyped or the original value removed, this would result in people being subscribed to subjects for which an email will never be sent.
diff --git a/lib/lanes/api/handlers/asset.rb b/lib/lanes/api/handlers/asset.rb index abc1234..def5678 100644 --- a/lib/lanes/api/handlers/asset.rb +++ b/lib/lanes/api/handlers/asset.rb @@ -27,8 +27,10 @@ end def self.getter - Lanes::API::RequestWrapper.with_authenticated_user do |user, req...
Allow anonymous access to files
diff --git a/lib/pragma/operation/destroy.rb b/lib/pragma/operation/destroy.rb index abc1234..def5678 100644 --- a/lib/pragma/operation/destroy.rb +++ b/lib/pragma/operation/destroy.rb @@ -7,20 +7,21 @@ # @author Alessandro Desantis class Destroy < Pragma::Operation::Base step Macro::Classes() - st...
Refactor Destroy operation to remove fail_fast directives
diff --git a/lib/s3_multipart_upload/file.rb b/lib/s3_multipart_upload/file.rb index abc1234..def5678 100644 --- a/lib/s3_multipart_upload/file.rb +++ b/lib/s3_multipart_upload/file.rb @@ -6,7 +6,7 @@ end def split_into_parts(part_size) - boundaries = Range.new(0, file_size).step(part_size).tap do |_| +...
Fix to work in Rails 4.x
diff --git a/lib/optical/filters/null_filter.rb b/lib/optical/filters/null_filter.rb index abc1234..def5678 100644 --- a/lib/optical/filters/null_filter.rb +++ b/lib/optical/filters/null_filter.rb @@ -15,7 +15,7 @@ end def filter_through_awk_script(script,output_bam,min_score=0) - File.delete(output_bam) + ...
Fix delete when something is not yet there
diff --git a/lib/tasks/cleanup_attachments.rake b/lib/tasks/cleanup_attachments.rake index abc1234..def5678 100644 --- a/lib/tasks/cleanup_attachments.rake +++ b/lib/tasks/cleanup_attachments.rake @@ -3,9 +3,10 @@ desc "Clean attachments older than 2 years" task :cleanup => :environment do - Invoice.where("pd...
Extend attachment cleanup to all objects
diff --git a/lib/daimon_skycrawlers/cli.rb b/lib/daimon_skycrawlers/cli.rb index abc1234..def5678 100644 --- a/lib/daimon_skycrawlers/cli.rb +++ b/lib/daimon_skycrawlers/cli.rb @@ -4,7 +4,7 @@ module DaimonSkycrawlers class CLI < Thor - register(Generator::New, "generate", "generate NAME", "Generate new project...
Change sub command name `generate` to `new` Because Rails uses `new` to create new project. I want to use `generate` to generate other files such as concrete crawlers and processors.
diff --git a/lib/e4commerce/bank_billet.rb b/lib/e4commerce/bank_billet.rb index abc1234..def5678 100644 --- a/lib/e4commerce/bank_billet.rb +++ b/lib/e4commerce/bank_billet.rb @@ -0,0 +1,20 @@+module E4commerce + + class BankBillet < E4CPayment + attr_accessor :product_list + attr_accessor :total + + def calculate_...
Create Bank Billet class inheriting from Payment class
diff --git a/lib/fooda-bot/time_helpers.rb b/lib/fooda-bot/time_helpers.rb index abc1234..def5678 100644 --- a/lib/fooda-bot/time_helpers.rb +++ b/lib/fooda-bot/time_helpers.rb @@ -8,8 +8,8 @@ def self.tomorrow?(time) now = Time.new - today_start = Time.new(now.year, now.month, now.day + 1) - today_end =...
Fix tomorrow? to account for last day of month
diff --git a/lib/gooder_data/session_id.rb b/lib/gooder_data/session_id.rb index abc1234..def5678 100644 --- a/lib/gooder_data/session_id.rb +++ b/lib/gooder_data/session_id.rb @@ -37,7 +37,7 @@ armor: true } options[:signer] = @options[:sso_signer_email] if @options[:sso_signer_email] - opti...
Change variable passphrase to password. The variable passphrase does no longer exists in GPGME.
diff --git a/app/controllers/admin_controller.rb b/app/controllers/admin_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin_controller.rb +++ b/app/controllers/admin_controller.rb @@ -0,0 +1,14 @@+class AdminController < ApplicationController + before_filter :authenticate_user! + before_filter :g...
Add Admin Controller show Action Add an Admin controller with a show action.
diff --git a/app/controllers/clubs_controller.rb b/app/controllers/clubs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/clubs_controller.rb +++ b/app/controllers/clubs_controller.rb @@ -6,7 +6,7 @@ def create @club = Club.new(params.require(:club).permit(:name, :city, :description)) @club...
Make new club action render show instead of index That seems to be a bit more natural
diff --git a/lib/modules/parse_pg_array.rb b/lib/modules/parse_pg_array.rb index abc1234..def5678 100644 --- a/lib/modules/parse_pg_array.rb +++ b/lib/modules/parse_pg_array.rb @@ -1,8 +1,9 @@ module ParsePgArray def parse_array(attribute) - # byebug attr = read_attribute(attribute) + # --- []\n is the de...
Manage case for nomenclature change output default value
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -5,7 +5,6 @@ def show @user = User.find(params[:id]) - @question = Question.find(params[:id]) end
Remove unused instance variable in user controller.
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,8 +1,16 @@ class UsersController < ApplicationController + def show + @user = User.find params[:id] + + re...
Update Users Controller for Mercury Actions Update the Users controller to handle the parameters passed by the Mercury editor.
diff --git a/app/models/devices/dimmer_device.rb b/app/models/devices/dimmer_device.rb index abc1234..def5678 100644 --- a/app/models/devices/dimmer_device.rb +++ b/app/models/devices/dimmer_device.rb @@ -24,7 +24,7 @@ '32/mixer.png' end - def update_attributes_from_registration params + def update_attribute...
feat: Remove pwm number from dimmer device
diff --git a/lib/generators/active_record/devise_userbin_generator.rb b/lib/generators/active_record/devise_userbin_generator.rb index abc1234..def5678 100644 --- a/lib/generators/active_record/devise_userbin_generator.rb +++ b/lib/generators/active_record/devise_userbin_generator.rb @@ -6,7 +6,7 @@ source_root F...
Make sure that migration file ends with .rb
diff --git a/manifests/cf-manifest/spec/manifest/certificates_spec.rb b/manifests/cf-manifest/spec/manifest/certificates_spec.rb index abc1234..def5678 100644 --- a/manifests/cf-manifest/spec/manifest/certificates_spec.rb +++ b/manifests/cf-manifest/spec/manifest/certificates_spec.rb @@ -0,0 +1,30 @@+RSpec.describe "ce...
Add a test for ca usages so ca_cert rotation works If you use ((ca.certificate)) when refering to a certificate's CA cert, then you will only get the latest CA certificate interpolated in the manifest You must instead use ((certficate.ca)) When you use ((certificate.ca)) and the latest CA has the "transitional" flag...
diff --git a/test/examples/api_client.rb b/test/examples/api_client.rb index abc1234..def5678 100644 --- a/test/examples/api_client.rb +++ b/test/examples/api_client.rb @@ -1,13 +1,13 @@ Oven.bake :ApiClient, destination: "tmp/" do format :json - get :users, "/api/v2/users" - get :user, "/api/v2/users/:id" ...
Refactor a client used in test
diff --git a/minimal_state_machine.gemspec b/minimal_state_machine.gemspec index abc1234..def5678 100644 --- a/minimal_state_machine.gemspec +++ b/minimal_state_machine.gemspec @@ -8,8 +8,8 @@ gem.version = MinimalStateMachine::VERSION gem.authors = ["Matteo Depalo"] gem.email = ["matteodepa...
Update Gemfile description and summary
diff --git a/test/features/step_definitions/search_steps.rb b/test/features/step_definitions/search_steps.rb index abc1234..def5678 100644 --- a/test/features/step_definitions/search_steps.rb +++ b/test/features/step_definitions/search_steps.rb @@ -7,13 +7,13 @@ end Then(/^vil jeg finne verket i trefflista$/) do - ...
Change variable names in test
diff --git a/test/end_to_end/basic_run_test.rb b/test/end_to_end/basic_run_test.rb index abc1234..def5678 100644 --- a/test/end_to_end/basic_run_test.rb +++ b/test/end_to_end/basic_run_test.rb @@ -14,6 +14,13 @@ status = @driver.cleanup status.exitstatus.must_equal 0 + end + + it 'can be interacted with' d...
Add simple test for finding items by role
diff --git a/test/integration/my_stuff_test.rb b/test/integration/my_stuff_test.rb index abc1234..def5678 100644 --- a/test/integration/my_stuff_test.rb +++ b/test/integration/my_stuff_test.rb @@ -0,0 +1,26 @@+require_relative '../integration_test_helper' + +class MyStuffTest < ActionDispatch::IntegrationTest + + def ...
Add an integration test for the 'my stuff' index.
diff --git a/match_api/lib/corenlp_client.rb b/match_api/lib/corenlp_client.rb index abc1234..def5678 100644 --- a/match_api/lib/corenlp_client.rb +++ b/match_api/lib/corenlp_client.rb @@ -1,7 +1,7 @@ class CoreNlpClient def initialize(host) #params = URI.encode('properties={"annotators": "lemma,parse,depparse"...
Use the same annotator set as the corenlp.run UI Motivation: -makes the results comparable -otherwise, for some reason, the results differ making the tool harder to work with Change Explanation: -pass additional annotators, don't pass parse
diff --git a/core/time/inspect_spec.rb b/core/time/inspect_spec.rb index abc1234..def5678 100644 --- a/core/time/inspect_spec.rb +++ b/core/time/inspect_spec.rb @@ -10,6 +10,11 @@ t.inspect.should == "2007-11-01 15:25:00.123456 UTC" end + it "omits trailing zeros from microseconds" do + t = Time.ut...
Test for removal of trailing zeros when inspecting a microsecond-precision time
diff --git a/toolsmith.gemspec b/toolsmith.gemspec index abc1234..def5678 100644 --- a/toolsmith.gemspec +++ b/toolsmith.gemspec @@ -23,4 +23,5 @@ s.add_development_dependency "guard-rspec", "~> 2.3.3" s.add_development_dependency "rb-fsevent", "~> 0.9.1" s.add_development_dependency "nokogiri", "~> 1.5.6" + s...
Add awesome print to gemspec.
diff --git a/middleman-core/lib/middleman-core/extensions/external_pipeline.rb b/middleman-core/lib/middleman-core/extensions/external_pipeline.rb index abc1234..def5678 100644 --- a/middleman-core/lib/middleman-core/extensions/external_pipeline.rb +++ b/middleman-core/lib/middleman-core/extensions/external_pipeline.rb...
Fix first-run issue with pipeline
diff --git a/db/migrate/008_create_playlists.rb b/db/migrate/008_create_playlists.rb index abc1234..def5678 100644 --- a/db/migrate/008_create_playlists.rb +++ b/db/migrate/008_create_playlists.rb @@ -3,6 +3,8 @@ create_table :playlists, id: :uuid, default: "uuid_generate_v4()", force: true do |t| t.string :...
Add owner_id and owner_name to playlists table
diff --git a/scheduled_tasks/management_information_v2_generation_task.rb b/scheduled_tasks/management_information_v2_generation_task.rb index abc1234..def5678 100644 --- a/scheduled_tasks/management_information_v2_generation_task.rb +++ b/scheduled_tasks/management_information_v2_generation_task.rb @@ -5,10 +5,10 @@ ...
Correct log output for scheduler Copy/paste mistake from previous work.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,8 +1,11 @@ require 'rspec-puppet' +require 'puppetlabs_spec_helper/module_spec_helper' fixture_path = File.expand_path(File.join(__FILE__, '..', 'fixtures')) RSpec.configu...
Add files to spec helper
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,13 +1,7 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib')) -require 'tempfile' require 'rspec' -require 'fakefs/spec_helpers' -require 'mocha' -require 'bi...
Remove requires from spec helper
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -3,8 +3,10 @@ require 'codeclimate-test-reporter' require 'stringio' -CodeClimate::TestReporter.start do - add_filter '/spec/' +if ENV['CODECLIMATE_REPO_TOKEN'] + CodeClimate:...
Use CodeClimate only if ENVs defined
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -5,3 +5,8 @@ add_filter '/vendor/' coverage_dir 'log/coverage/spec' end + +def production_code + spec = caller[0][/spec.+\.rb/] + './' + spec.gsub('_spec','').gsub(/spec/, ...
Add production_code helper method to spec helper
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,6 +1,38 @@+require "codeclimate-test-reporter" +CodeClimate::TestReporter.start + +require 'capybara/rspec' + require "lita-hackers-news" require "lita/rspec" # A compatibi...
Add RSpec config and apply CodeClimate coverage
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,12 +1,23 @@ require 'pathname' SPEC_ROOT = root = Pathname(__FILE__).dirname + +if RUBY_ENGINE == 'ruby' && ENV['COVERAGE'] == 'true' + require 'yaml' + rubies = YAML.load(...
Enable simplecov for rom gem specs
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -43,9 +43,12 @@ Sidekiq.logger = nil end - config.before :example do - Sidekiq::Merger::Redis.redis do |conn| - conn.flushall + config.around :example do |exampl...
Clean up redis after examples
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -5,5 +5,3 @@ config.color = true # Use color in STDOUT config.formatter = :documentation # Use the specified formatter end - -at_exit { ChefSpec::Coverage.repor...
Remove the converge report in chefspec These lead to poorly designed specs Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,5 +1,13 @@+# SimpleCov must run _first_ according to its README if ENV['COVERAGE'] require 'simplecov' + + # monkey-patch to prevent SimpleCov from reporting coverage perce...
Change SimpleCov behaviour to stop reporting Change the SimpleCov behaviour so that it no longer reports coverage when `rake` completes and acts only as a 'red light' if coverage drops significantly (by 20%) or drops below a percentage (80%). Note that to silence the 'Coverage report generated for' message that repor...
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -25,6 +25,9 @@ config.filter_run_when_matching :focus config.before(:each) { Grape::Util::InheritableSetting.reset_global! } + + # Enable flags like --only-failures and --n...
Enable support for `rspec --next-failure`.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -7,7 +7,7 @@ module Serverspec module Backend - class Ssh + class Exec def do_check(cmd) if cmd =~ /invalid/ { @@ -30,6 +30,7 @@ end RSpec....
Use Helper::Exec instead of Helper::Ssh
diff --git a/app/models/physical_server.rb b/app/models/physical_server.rb index abc1234..def5678 100644 --- a/app/models/physical_server.rb +++ b/app/models/physical_server.rb @@ -5,7 +5,6 @@ belongs_to :ext_management_system, :foreign_key => :ems_id, :class_name => "ManageIQ::Providers::PhysicalInfraManager" - ...
Remove referenced to undefined :enabled attribute
diff --git a/app/overrides/orders_index.rb b/app/overrides/orders_index.rb index abc1234..def5678 100644 --- a/app/overrides/orders_index.rb +++ b/app/overrides/orders_index.rb @@ -5,13 +5,4 @@ <li> <%= button_link_to Spree.t(:view_on_shippo), admin_shippo_orders_path, :icon => '' %> </li> - ") - -Defa...
Remove order list connect button
diff --git a/app/services/stats_service.rb b/app/services/stats_service.rb index abc1234..def5678 100644 --- a/app/services/stats_service.rb +++ b/app/services/stats_service.rb @@ -1,5 +1,5 @@ class StatsService - GRAPH_SAMPLES = 4 + GRAPH_SAMPLES = 5 attr_accessor :check_ins, :leader
Increase graph samples 4 -> 5 in check ins
diff --git a/config/initializers/actionmailer.rb b/config/initializers/actionmailer.rb index abc1234..def5678 100644 --- a/config/initializers/actionmailer.rb +++ b/config/initializers/actionmailer.rb @@ -1,6 +1,15 @@ if File.exists?("#{RAILS_ROOT}/config/mailer.yml") require "action_mailer" c = YAML::load(File.o...
Change the way config/mailer.yml is read so that it supports configurations other than smtp.
diff --git a/test/models/account_test.rb b/test/models/account_test.rb index abc1234..def5678 100644 --- a/test/models/account_test.rb +++ b/test/models/account_test.rb @@ -2,6 +2,7 @@ describe Account do before do + ENV['INCOMING_EMAIL_DOMAIN'] = 'example.com' @account = FactoryGirl.build(:account) end...
Set required ENV var in test
diff --git a/cf_spec/spec_helper.rb b/cf_spec/spec_helper.rb index abc1234..def5678 100644 --- a/cf_spec/spec_helper.rb +++ b/cf_spec/spec_helper.rb @@ -6,6 +6,9 @@ Machete.logger = Machete::Logger.new("log/integration.log") RSpec.configure do |config| + config.color = true + config.tty = true + config.filter_r...
Make RSpec emit colored output no matter what We thought concourse-filter was swallowing color codes. It was not. Instead, they were not emitted on CI. [#133046105]
diff --git a/lib/skr/concerns/code_identifier.rb b/lib/skr/concerns/code_identifier.rb index abc1234..def5678 100644 --- a/lib/skr/concerns/code_identifier.rb +++ b/lib/skr/concerns/code_identifier.rb @@ -24,7 +24,10 @@ if from before_validation(:on=>:create) do - ...
Deal with possibly nil source strings
diff --git a/app/overrides/products/index/add_welcome_text_to_home_page.rb b/app/overrides/products/index/add_welcome_text_to_home_page.rb index abc1234..def5678 100644 --- a/app/overrides/products/index/add_welcome_text_to_home_page.rb +++ b/app/overrides/products/index/add_welcome_text_to_home_page.rb @@ -1,7 +1,7 @@...
Add text with newsletter link.
diff --git a/app/controllers/backend/assets_controller.rb b/app/controllers/backend/assets_controller.rb index abc1234..def5678 100644 --- a/app/controllers/backend/assets_controller.rb +++ b/app/controllers/backend/assets_controller.rb @@ -1,5 +1,5 @@ class Backend::AssetsController < Backend::BaseController - before...
Make sure assets can be deleted.
diff --git a/Library/Contributions/cmd/brew-tap-readme.rb b/Library/Contributions/cmd/brew-tap-readme.rb index abc1234..def5678 100644 --- a/Library/Contributions/cmd/brew-tap-readme.rb +++ b/Library/Contributions/cmd/brew-tap-readme.rb @@ -0,0 +1,32 @@+name = ARGV.first + +raise "A name is required" if name.nil? + +te...
Add `brew tap-readme <name>` external command. Closes Homebrew/homebrew#17935.
diff --git a/app/controllers/event_partners_controller.rb b/app/controllers/event_partners_controller.rb index abc1234..def5678 100644 --- a/app/controllers/event_partners_controller.rb +++ b/app/controllers/event_partners_controller.rb @@ -31,5 +31,6 @@ def load_parent @event = Event.find_by_slug!(params[:eve...
Add authorization for Event Partner
diff --git a/core/spec/requests/admin/configuration/image_settings_spec.rb b/core/spec/requests/admin/configuration/image_settings_spec.rb index abc1234..def5678 100644 --- a/core/spec/requests/admin/configuration/image_settings_spec.rb +++ b/core/spec/requests/admin/configuration/image_settings_spec.rb @@ -2,6 +2,10 @...
Reset preferences after spec to properly teardown test and avoid files being saved where they are not gitignored. Fixes #2467
diff --git a/lib/rubocop/cop/metrics/method_length.rb b/lib/rubocop/cop/metrics/method_length.rb index abc1234..def5678 100644 --- a/lib/rubocop/cop/metrics/method_length.rb +++ b/lib/rubocop/cop/metrics/method_length.rb @@ -23,9 +23,7 @@ def code_length(node) lines = node.loc.expression.source.lines...
Use count instead of reject!..size
diff --git a/lib/watch_tower/editor/base_appscript.rb b/lib/watch_tower/editor/base_appscript.rb index abc1234..def5678 100644 --- a/lib/watch_tower/editor/base_appscript.rb +++ b/lib/watch_tower/editor/base_appscript.rb @@ -13,6 +13,9 @@ # Include AppScript include ::Appscript + #...
BaseAppscript: Add Documentation for the methods defined.
diff --git a/demo/models/photo.rb b/demo/models/photo.rb index abc1234..def5678 100644 --- a/demo/models/photo.rb +++ b/demo/models/photo.rb @@ -2,5 +2,5 @@ require "./uploaders/image_uploader" class Photo < Sequel::Model - include ImageUploader[:image] + include ImageUploader::Attachment.new(:image) end
Use ImageUploader::Attachment.new(:image) instead of ImageUploader[:image]
diff --git a/app/controllers/api/v1/replies_controller.rb b/app/controllers/api/v1/replies_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/replies_controller.rb +++ b/app/controllers/api/v1/replies_controller.rb @@ -18,10 +18,11 @@ access_denied and return unless post.visible_to?(current_us...
Add alias join to API replies controller
diff --git a/Casks/hostbuddy.rb b/Casks/hostbuddy.rb index abc1234..def5678 100644 --- a/Casks/hostbuddy.rb +++ b/Casks/hostbuddy.rb @@ -5,7 +5,7 @@ url 'https://clickontyler.com/hostbuddy/download/' appcast 'http://shine.clickontyler.com/appcast.php?id=22' name 'Hostbuddy' - homepage 'http://clickontyler.com/...
Fix homepage to use SSL in Hostbuddy Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/spec/end_to_end/end_to_end_spec.rb b/spec/end_to_end/end_to_end_spec.rb index abc1234..def5678 100644 --- a/spec/end_to_end/end_to_end_spec.rb +++ b/spec/end_to_end/end_to_end_spec.rb @@ -5,7 +5,8 @@ def expect_runs(source_file, expected_output) executable = File.expand_path('../../../target/debug/h...
Fix typo in end-to-end harness
diff --git a/spec/models/portal/country_spec.rb b/spec/models/portal/country_spec.rb index abc1234..def5678 100644 --- a/spec/models/portal/country_spec.rb +++ b/spec/models/portal/country_spec.rb @@ -42,10 +42,9 @@ end end - # TODO: auto-generated describe '.from_hash' do it 'from_hash' do - in_...
Update spec test for Portal::Country class
diff --git a/rspec_junit_formatter.gemspec b/rspec_junit_formatter.gemspec index abc1234..def5678 100644 --- a/rspec_junit_formatter.gemspec +++ b/rspec_junit_formatter.gemspec @@ -13,6 +13,8 @@ s.required_rubygems_version = ">= 1.3.6" s.add_dependency "rspec", "~> 2.0" + # https://github.com/rspec/rspec-core/c...
Make sure we don't get loaded with bad rspec-core
diff --git a/foodr-backend/db/migrate/20170729002122_create_ingredients.rb b/foodr-backend/db/migrate/20170729002122_create_ingredients.rb index abc1234..def5678 100644 --- a/foodr-backend/db/migrate/20170729002122_create_ingredients.rb +++ b/foodr-backend/db/migrate/20170729002122_create_ingredients.rb @@ -3,7 +3,7 @@...
Change ingredient field from type to is_natural
diff --git a/lib/font_awesome/sass/rails/helpers.rb b/lib/font_awesome/sass/rails/helpers.rb index abc1234..def5678 100644 --- a/lib/font_awesome/sass/rails/helpers.rb +++ b/lib/font_awesome/sass/rails/helpers.rb @@ -11,7 +11,7 @@ html_options[:class] = content_class html = content_tag(:i, nil, h...
Fix appending non-strings to icon Example: `icon(:copyright, Time.now.year)` Before: © ߟ After: © 2015
diff --git a/lib/mumuki/laboratory/events/events.rb b/lib/mumuki/laboratory/events/events.rb index abc1234..def5678 100644 --- a/lib/mumuki/laboratory/events/events.rb +++ b/lib/mumuki/laboratory/events/events.rb @@ -20,6 +20,10 @@ Exam.import_from_resource_h! body end + event 'UpsertExamStudents' do |body| +...
Add exam students upsert event
diff --git a/db/migrate/20121002130659_update_mainstream_categories.rb b/db/migrate/20121002130659_update_mainstream_categories.rb index abc1234..def5678 100644 --- a/db/migrate/20121002130659_update_mainstream_categories.rb +++ b/db/migrate/20121002130659_update_mainstream_categories.rb @@ -0,0 +1,51 @@+class Mainstre...
Add new detailed guidance categories
diff --git a/Casks/photo-supreme-single-user.rb b/Casks/photo-supreme-single-user.rb index abc1234..def5678 100644 --- a/Casks/photo-supreme-single-user.rb +++ b/Casks/photo-supreme-single-user.rb @@ -0,0 +1,13 @@+cask :v1 => 'photo-supreme-single-user' do + version '3' + sha256 'b2a60379e61ac6a44ac14b05e462a145ad65d...
Add Photo Supreme v3 single user Install the single-user version of IDImager's DAM package, Photo Supreme v3
diff --git a/config/initializers/gollum.rb b/config/initializers/gollum.rb index abc1234..def5678 100644 --- a/config/initializers/gollum.rb +++ b/config/initializers/gollum.rb @@ -21,8 +21,10 @@ commit = @access.commit(sha) tree_map_for(sha).inject([]) do |list, entry| next list unless @pag...
Fix offense to the LineBreakAfterGuardClauses cop Signed-off-by: Rémy Coutable <4ea0184b9df19e0786dd00b28e6daa4d26baeb3e@rymai.me>
diff --git a/features/step_definitions/filtering_steps.rb b/features/step_definitions/filtering_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/filtering_steps.rb +++ b/features/step_definitions/filtering_steps.rb @@ -5,6 +5,7 @@ Then(/^I can get a list of all merger inquiries$/) do visit find...
Refactor filtering step to look at items Check contents of one item but just asset counts for the rest.
diff --git a/spec/acceptance/class_spec.rb b/spec/acceptance/class_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/class_spec.rb +++ b/spec/acceptance/class_spec.rb @@ -6,7 +6,7 @@ pp =<<-EOS class { 'mock': } EOS - + apply_manifest(pp, :catch_failures => true) expect(a...
Add extra system tests for when ensure => absent
diff --git a/spec/core/kernel/eval_spec.rb b/spec/core/kernel/eval_spec.rb index abc1234..def5678 100644 --- a/spec/core/kernel/eval_spec.rb +++ b/spec/core/kernel/eval_spec.rb @@ -15,4 +15,9 @@ it "creates a CompiledMethod that can be cached and re-run" do KernelSpecs.run_cache(@cache).should == "Object:Object"...
Add a spec for __LINE__ in eval
diff --git a/publify_core/spec/dummy/config/routes.rb b/publify_core/spec/dummy/config/routes.rb index abc1234..def5678 100644 --- a/publify_core/spec/dummy/config/routes.rb +++ b/publify_core/spec/dummy/config/routes.rb @@ -1,56 +1,4 @@ Rails.application.routes.draw do - # The priority is based upon order of creation...
Remove route explanation from dummy app
diff --git a/lib/octostar/repositories/project_repository.rb b/lib/octostar/repositories/project_repository.rb index abc1234..def5678 100644 --- a/lib/octostar/repositories/project_repository.rb +++ b/lib/octostar/repositories/project_repository.rb @@ -1,4 +1,5 @@ class ProjectRepository < Hanami::Repository + # TODO:...
Add todo comment for testing
diff --git a/lib/miq_automation_engine/service_models/miq_ae_service_storage.rb b/lib/miq_automation_engine/service_models/miq_ae_service_storage.rb index abc1234..def5678 100644 --- a/lib/miq_automation_engine/service_models/miq_ae_service_storage.rb +++ b/lib/miq_automation_engine/service_models/miq_ae_service_storag...
Add association Storage Clusters to Automate Storage Service Model. https://bugzilla.redhat.com/show_bug.cgi?id=1335658 (transferred from ManageIQ/manageiq@57a73d0ca0d96e5c26532709d4755b83de923ff4)
diff --git a/migrate/20190603154049_add_wdpa_id_and_name_to_pame_evaluations.rb b/migrate/20190603154049_add_wdpa_id_and_name_to_pame_evaluations.rb index abc1234..def5678 100644 --- a/migrate/20190603154049_add_wdpa_id_and_name_to_pame_evaluations.rb +++ b/migrate/20190603154049_add_wdpa_id_and_name_to_pame_evaluation...
Add migration for adding wdpa id and name to pame evaluations