diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,12 +1,12 @@ class ApplicationController < ActionController::Base - - include Application...
Make the ApplicationHelper module methods private
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -9,4 +9,9 @@ 'umlaut.request_id' => request.id) end helper_method :url_for_reque...
Add new_session_path helper function to application controller
diff --git a/app/controllers/instruments_controller.rb b/app/controllers/instruments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/instruments_controller.rb +++ b/app/controllers/instruments_controller.rb @@ -40,14 +40,4 @@ @instrument.destroy redirect_to instruments_url, notice: "Successfu...
Remove un-used params for instrument controller
diff --git a/app/models/content_item_expanded_links.rb b/app/models/content_item_expanded_links.rb index abc1234..def5678 100644 --- a/app/models/content_item_expanded_links.rb +++ b/app/models/content_item_expanded_links.rb @@ -2,7 +2,31 @@ include ActiveModel::Model attr_accessor :content_id, :previous_version ...
Hide related links behind a feature toggle We're temporarily disabling this, because there is more work to do on the frontend side, but we'd like to merge this branch now so it doesn't fall behind master. The tests still run with this functionality enabled.
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,6 +1,5 @@ class UsersController < ApplicationController skip_before_filter :require_login, :only => [:new, :cr...
Add user_type to handle User STI params.
diff --git a/app/jobs/periodic_serverspec_job.rb b/app/jobs/periodic_serverspec_job.rb index abc1234..def5678 100644 --- a/app/jobs/periodic_serverspec_job.rb +++ b/app/jobs/periodic_serverspec_job.rb @@ -17,6 +17,9 @@ wait_until: schedule.next_run ).perform_later(physical_id, infra_id, user_id) - Serve...
Check if instance is running before running serverspec
diff --git a/.config.rb b/.config.rb index abc1234..def5678 100644 --- a/.config.rb +++ b/.config.rb @@ -1,5 +1,9 @@+# +# Setup QED. +# qed do + # Just to demonstrate profiles. profile :sample do puts ("*" * 78) puts @@ -10,6 +14,7 @@ end end + # Create coverage report. profile :cov do ...
Remove rdoc profile, we use simplcov now. [admin]
diff --git a/config/initializers/cookies_serializer.rb b/config/initializers/cookies_serializer.rb index abc1234..def5678 100644 --- a/config/initializers/cookies_serializer.rb +++ b/config/initializers/cookies_serializer.rb @@ -1,2 +1,2 @@ # Be sure to restart your server when you modify this file. -Rails.application....
Fix old sessions not being recognized
diff --git a/app/controllers/omnisocial/auth_controller.rb b/app/controllers/omnisocial/auth_controller.rb index abc1234..def5678 100644 --- a/app/controllers/omnisocial/auth_controller.rb +++ b/app/controllers/omnisocial/auth_controller.rb @@ -20,7 +20,7 @@ self.current_user = account.find_or_create_user ...
Send the successful login message via flash[:notice] instead of flash[:message]
diff --git a/app/decorators/meals/portion_count_builder.rb b/app/decorators/meals/portion_count_builder.rb index abc1234..def5678 100644 --- a/app/decorators/meals/portion_count_builder.rb +++ b/app/decorators/meals/portion_count_builder.rb @@ -34,7 +34,7 @@ end def formula_parts_by_category - @formula_...
72: Add eager loading in PortionCountBuilder
diff --git a/Casks/android-studio-canary.rb b/Casks/android-studio-canary.rb index abc1234..def5678 100644 --- a/Casks/android-studio-canary.rb +++ b/Casks/android-studio-canary.rb @@ -1,6 +1,6 @@ cask 'android-studio-canary' do - version '2.1.0.5,143.2759333' - sha256 '8a76eb901646d340b4edf2fb0b0475d457a2b30ef019fa4...
Update Android Studio Canary to 2.1 Beta 2
diff --git a/Casks/sbig-universal-driver.rb b/Casks/sbig-universal-driver.rb index abc1234..def5678 100644 --- a/Casks/sbig-universal-driver.rb +++ b/Casks/sbig-universal-driver.rb @@ -0,0 +1,13 @@+cask 'sbig-universal-driver' do + version :latest + sha256 :no_check + + # ftp.sbig.com was verified as official when f...
Add SBIG Universal Driver (latest version)
diff --git a/config/initializers/cookies_serializer.rb b/config/initializers/cookies_serializer.rb index abc1234..def5678 100644 --- a/config/initializers/cookies_serializer.rb +++ b/config/initializers/cookies_serializer.rb @@ -2,4 +2,4 @@ # Specify a serializer for the signed and encrypted cookie jars. # Valid opt...
Fix scoreboard for users who have previously visited the site
diff --git a/config/software/datadog-upgrade-helper.rb b/config/software/datadog-upgrade-helper.rb index abc1234..def5678 100644 --- a/config/software/datadog-upgrade-helper.rb +++ b/config/software/datadog-upgrade-helper.rb @@ -1,9 +1,15 @@ name "datadog-upgrade-helper" -default_version "master" + source github: "Dat...
Add ability to specify UPGRADE_HELPER_BRANCH in environment
diff --git a/spec/acceptance/masterless_spec.rb b/spec/acceptance/masterless_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/masterless_spec.rb +++ b/spec/acceptance/masterless_spec.rb @@ -0,0 +1,29 @@+require 'spec_helper_acceptance' + +describe 'puppet::masterless' do + let(:manifest) { <<-EOS + pac...
Add test for masterless mode
diff --git a/config/initializers/carrier_wave.rb b/config/initializers/carrier_wave.rb index abc1234..def5678 100644 --- a/config/initializers/carrier_wave.rb +++ b/config/initializers/carrier_wave.rb @@ -1,9 +1,10 @@ CarrierWave.configure do |config| config.fog_credentials = { - :provider => 'AWS',...
Set region for s3 credentials
diff --git a/config/initializers/secret_token.rb b/config/initializers/secret_token.rb index abc1234..def5678 100644 --- a/config/initializers/secret_token.rb +++ b/config/initializers/secret_token.rb @@ -4,4 +4,4 @@ # If you change this key, all old signed cookies will become invalid! # Make sure the secret is at lea...
Fix a long-forgotten security problem :)
diff --git a/config/initializers/secret_token.rb b/config/initializers/secret_token.rb index abc1234..def5678 100644 --- a/config/initializers/secret_token.rb +++ b/config/initializers/secret_token.rb @@ -3,5 +3,6 @@ # Your secret key for verifying the integrity of signed cookies. # If you change this key, all old sig...
Remove secret token from current config.
diff --git a/lib/affiliate_window/etl/config.rb b/lib/affiliate_window/etl/config.rb index abc1234..def5678 100644 --- a/lib/affiliate_window/etl/config.rb +++ b/lib/affiliate_window/etl/config.rb @@ -23,7 +23,7 @@ end def last_n_days - env.fetch("LAST_N_DAYS", 7) + env.fetch("LAST_N_DAYS",...
Fix etl startup when LAST_N_DAYS is set When the LAST_N_DAYS environment variable is set then the etl fails as environment variables are always strings... and ruby is a strongly typed language.
diff --git a/db/migrate/20150625231923_create_users.rb b/db/migrate/20150625231923_create_users.rb index abc1234..def5678 100644 --- a/db/migrate/20150625231923_create_users.rb +++ b/db/migrate/20150625231923_create_users.rb @@ -8,6 +8,8 @@ t.string :password_hash t.boolean :in_office + t.references ...
Add reference to user_group in User migration
diff --git a/lib/openstax/rescue_from/engine.rb b/lib/openstax/rescue_from/engine.rb index abc1234..def5678 100644 --- a/lib/openstax/rescue_from/engine.rb +++ b/lib/openstax/rescue_from/engine.rb @@ -3,18 +3,6 @@ module OpenStax module RescueFrom class Engine < ::Rails::Engine - ActionController::Base.sen...
Move all includes into their own realm
diff --git a/lib/tasks/fulltext_searchable.rake b/lib/tasks/fulltext_searchable.rake index abc1234..def5678 100644 --- a/lib/tasks/fulltext_searchable.rake +++ b/lib/tasks/fulltext_searchable.rake @@ -14,10 +14,17 @@ task :rebuild => :environment do puts "Rebuilding FulltextIndex..." - # read all models + ...
Rebuild task didn't play nice with autoloading
diff --git a/lib/totally_tabular/html_helper.rb b/lib/totally_tabular/html_helper.rb index abc1234..def5678 100644 --- a/lib/totally_tabular/html_helper.rb +++ b/lib/totally_tabular/html_helper.rb @@ -1,7 +1,8 @@ module TotallyTabular class HtmlHelper - EMPTY_TAG = /br|input|img/ + EMPTY_TAG = /br|hr|img|met...
Add unpaired tags from TextMate bundle
diff --git a/lib/manifestation.rb b/lib/manifestation.rb index abc1234..def5678 100644 --- a/lib/manifestation.rb +++ b/lib/manifestation.rb @@ -4,7 +4,7 @@ require 'ostruct' %w(build content parse source template version).each do |lib| - require File.join File.expand_path("./lib"), "manifestation/#{lib}" + requir...
Update require statement in base file.
diff --git a/test/unit/test_transparent_pdfs.rb b/test/unit/test_transparent_pdfs.rb index abc1234..def5678 100644 --- a/test/unit/test_transparent_pdfs.rb +++ b/test/unit/test_transparent_pdfs.rb @@ -2,7 +2,7 @@ require File.join(here, '..', 'test_helper') require 'tmpdir' -class TransparentPDFsTest < Test::Unit::T...
Update merged test to minitest
diff --git a/spec/gaffe/errors_spec.rb b/spec/gaffe/errors_spec.rb index abc1234..def5678 100644 --- a/spec/gaffe/errors_spec.rb +++ b/spec/gaffe/errors_spec.rb @@ -5,13 +5,17 @@ describe :show do let(:request) { ActionDispatch::TestRequest.new } let(:env) { request.env.merge 'action_dispatch.exceptio...
Fix tests to make them work with Rails 4.2
diff --git a/spec/models/route_spec.rb b/spec/models/route_spec.rb index abc1234..def5678 100644 --- a/spec/models/route_spec.rb +++ b/spec/models/route_spec.rb @@ -21,7 +21,8 @@ end it "should create a new instance given valid attributes" do - Route.create!(@valid_attributes) + route = Route.new(@valid_at...
Fix route spec to avoid contraint violation
diff --git a/lib/owners/search.rb b/lib/owners/search.rb index abc1234..def5678 100644 --- a/lib/owners/search.rb +++ b/lib/owners/search.rb @@ -33,7 +33,7 @@ end def subscriptions - trees.flat_map(&:owner_files).uniq.product([nil]) + trees.flat_map(&:owner_files).uniq end def trees
Remove an unnecessary call to `product([nil])`
diff --git a/spec/system/login_spec.rb b/spec/system/login_spec.rb index abc1234..def5678 100644 --- a/spec/system/login_spec.rb +++ b/spec/system/login_spec.rb @@ -0,0 +1,12 @@+require 'rails_helper' + +describe 'Logging In' do + before do + driven_by :selenium_chrome_headless + end + + it 'shows the right pag...
Make system directory and failing test
diff --git a/lib/slatan/spirit.rb b/lib/slatan/spirit.rb index abc1234..def5678 100644 --- a/lib/slatan/spirit.rb +++ b/lib/slatan/spirit.rb @@ -26,7 +26,9 @@ :log_file_path, :log_level, :use_log, - :pid_file_path + :pid...
Add ignore_bot_reply, ignore_self_message to attr_accessor
diff --git a/lib/withings/base.rb b/lib/withings/base.rb index abc1234..def5678 100644 --- a/lib/withings/base.rb +++ b/lib/withings/base.rb @@ -1,6 +1,8 @@ module Withings SCALE = 1 BLOOD_PRESSURE_MONITOR = 4 + PULSE = 16 + SLEEP_MONITOR = 32 def self.consumer_secret=(value) @consumer_secret = valu...
Add Pulse and Sleep Monitor to the devices IDs
diff --git a/Library/Homebrew/cmd/leaves.rb b/Library/Homebrew/cmd/leaves.rb index abc1234..def5678 100644 --- a/Library/Homebrew/cmd/leaves.rb +++ b/Library/Homebrew/cmd/leaves.rb @@ -13,9 +13,9 @@ f.deps.each do |dep| if dep.optional? || dep.recommended? tab = Tab.for_formula(f) - d...
Use name of formula rather than name of dependency Closes Homebrew/homebrew#27192. Signed-off-by: Jack Nagel <43386ce32af96f5c56f2a88e458cb94cebee3751@gmail.com>
diff --git a/core/app/views/users/_user.jbuilder b/core/app/views/users/_user.jbuilder index abc1234..def5678 100644 --- a/core/app/views/users/_user.jbuilder +++ b/core/app/views/users/_user.jbuilder @@ -23,4 +23,9 @@ if is_current_user json.receives_mailed_notifications user.receives_mailed_notifications json.r...
Return in currentUser whether services are connected
diff --git a/acceptance/features/support/env.rb b/acceptance/features/support/env.rb index abc1234..def5678 100644 --- a/acceptance/features/support/env.rb +++ b/acceptance/features/support/env.rb @@ -4,6 +4,9 @@ require_relative 'visitor_agent' require_relative 'app_descriptor' + +# Set longer wait time since we're...
Set longer wait time for acceptance tests since we're hitting external services
diff --git a/action_cable_notifications.gemspec b/action_cable_notifications.gemspec index abc1234..def5678 100644 --- a/action_cable_notifications.gemspec +++ b/action_cable_notifications.gemspec @@ -16,8 +16,8 @@ s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"] - s.add_dependen...
Fix gem dependencies for rails >= 5.0.0.1 and lodash
diff --git a/lib/saxlsx/rows_collection.rb b/lib/saxlsx/rows_collection.rb index abc1234..def5678 100644 --- a/lib/saxlsx/rows_collection.rb +++ b/lib/saxlsx/rows_collection.rb @@ -15,7 +15,7 @@ end def count - @count ||= @sheet.match(/<dimension ref="[^:]+:[A-Z]+(\d+)"/)[1].to_i + @count ||= @shee...
Fix count when ref is just numbers '1:255'
diff --git a/lib/simple_solr/core/index.rb b/lib/simple_solr/core/index.rb index abc1234..def5678 100644 --- a/lib/simple_solr/core/index.rb +++ b/lib/simple_solr/core/index.rb @@ -2,7 +2,7 @@ # Add the given hash or array of hashes # @return self def add_docs(*hash_or_hashes) - update(hash_or_hashes) + u...
Fix fv_search to put parens around ssearch terms
diff --git a/lib/tracks_attributes/base.rb b/lib/tracks_attributes/base.rb index abc1234..def5678 100644 --- a/lib/tracks_attributes/base.rb +++ b/lib/tracks_attributes/base.rb @@ -12,6 +12,7 @@ class Base extend ClassMethods include ActiveModel::Validations + tracks_attributes ## # The s...
Move the call to tracks_attributes to the class def from initialize
diff --git a/smartcoin.gemspec b/smartcoin.gemspec index abc1234..def5678 100644 --- a/smartcoin.gemspec +++ b/smartcoin.gemspec @@ -18,6 +18,8 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] + spec.add_dependency "rest-client", "~> 1.6.7" + spec.add_developme...
BugFix: Include gem dependency - rest-client
diff --git a/app/controllers/otus_controller.rb b/app/controllers/otus_controller.rb index abc1234..def5678 100644 --- a/app/controllers/otus_controller.rb +++ b/app/controllers/otus_controller.rb @@ -25,7 +25,7 @@ end def show - otu = Otu.find(params[:id]) + @otu = Otu.find(params[:id]) end def ed...
Fix missing @ on otu
diff --git a/app/mailers/distribution_mailer.rb b/app/mailers/distribution_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/distribution_mailer.rb +++ b/app/mailers/distribution_mailer.rb @@ -9,7 +9,8 @@ @distribution = distribution @default_email_text = current_organization.default_email_text @c...
Address a problem when a diaper bank doesnt have an email listed. Have it fall back to the email of the first user of the diaperbank.
diff --git a/rspec-hal.gemspec b/rspec-hal.gemspec index abc1234..def5678 100644 --- a/rspec-hal.gemspec +++ b/rspec-hal.gemspec @@ -21,5 +21,5 @@ spec.add_development_dependency "rake", "~> 10.1" spec.add_runtime_dependency "rspec", ">= 2.0", "< 4.0.0.pre" - spec.add_runtime_dependency "hal-client", "~> 2.4" +...
Allow hal-client version to float into 3.x series
diff --git a/rubycards.gemspec b/rubycards.gemspec index abc1234..def5678 100644 --- a/rubycards.gemspec +++ b/rubycards.gemspec @@ -6,8 +6,8 @@ Gem::Specification.new do |gem| gem.name = "rubycards" gem.version = RubyCards::VERSION - gem.authors = ["Jordan Scales", "Joe Letizia"] - gem.ema...
Add Justin Workman as an author in gemspec. Woohoo!
diff --git a/danger-gitlab.gemspec b/danger-gitlab.gemspec index abc1234..def5678 100644 --- a/danger-gitlab.gemspec +++ b/danger-gitlab.gemspec @@ -13,6 +13,6 @@ spec.files = %w(README.md LICENSE) spec.required_ruby_version = ">= 2.3.0" - spec.add_runtime_dependency "danger", "~> 8.0" + spec.add_runt...
Remove pinning from danger dependency
diff --git a/config/initializers/secret_token.rb b/config/initializers/secret_token.rb index abc1234..def5678 100644 --- a/config/initializers/secret_token.rb +++ b/config/initializers/secret_token.rb @@ -5,3 +5,4 @@ # Make sure the secret is at least 30 characters and all random, # no regular words or you'll be expos...
Add secret_key_base for encrypted cookies
diff --git a/activerecord/lib/active_record/relation/predicate_builder.rb b/activerecord/lib/active_record/relation/predicate_builder.rb index abc1234..def5678 100644 --- a/activerecord/lib/active_record/relation/predicate_builder.rb +++ b/activerecord/lib/active_record/relation/predicate_builder.rb @@ -20,7 +20,9 @@ ...
Raise a StatementInvalid error when trying to build a condition with hash keys that do not correspond to columns.
diff --git a/db/migrate/20151206031947_create_root_user.rb b/db/migrate/20151206031947_create_root_user.rb index abc1234..def5678 100644 --- a/db/migrate/20151206031947_create_root_user.rb +++ b/db/migrate/20151206031947_create_root_user.rb @@ -2,7 +2,7 @@ def up user = User.new user.id = 0 - user.email ...
Fix production email in migration
diff --git a/lib/capistrano/forkcms/defaults.rb b/lib/capistrano/forkcms/defaults.rb index abc1234..def5678 100644 --- a/lib/capistrano/forkcms/defaults.rb +++ b/lib/capistrano/forkcms/defaults.rb @@ -7,13 +7,13 @@ # Run required tasks after the stage Capistrano::DSL.stages.each do |stage| - after stage, 'forkcms:c...
Use " instead of '
diff --git a/attributes/client.rb b/attributes/client.rb index abc1234..def5678 100644 --- a/attributes/client.rb +++ b/attributes/client.rb @@ -20,7 +20,14 @@ libperconaserverclient#{abi_version}-dev percona-server-client-#{version} ] when "rhel" - default["percona"]["client"]["packages"] = %W[ - Percona-S...
Fix package list for clusters based on CentOS
diff --git a/cookbooks/cicd_infrastructure/recipes/integration_gerrit_ldap.rb b/cookbooks/cicd_infrastructure/recipes/integration_gerrit_ldap.rb index abc1234..def5678 100644 --- a/cookbooks/cicd_infrastructure/recipes/integration_gerrit_ldap.rb +++ b/cookbooks/cicd_infrastructure/recipes/integration_gerrit_ldap.rb @@ ...
[DMG-406] Use improved gerrit.config template for ldap setup
diff --git a/scss-lint.gemspec b/scss-lint.gemspec index abc1234..def5678 100644 --- a/scss-lint.gemspec +++ b/scss-lint.gemspec @@ -17,7 +17,7 @@ s.executables = ['scss-lint'] s.files = Dir['config/**/*.yml'] + - Dir['data/**'] + + Dir['data/**/*'] + ...
Fix glob for data directory This was only including files in the `data` directory, excluding subdirectories. Change-Id: I8a276678e0cd495196c11808ad3e3e0cdddf5c9b Reviewed-on: http://gerrit.causes.com/40952 Tested-by: jenkins <d95b56ce41a2e1ac4cecdd398defd7414407cc08@causes.com> Reviewed-by: Shane da Silva <67fb7bfe39...
diff --git a/birth_number.gemspec b/birth_number.gemspec index abc1234..def5678 100644 --- a/birth_number.gemspec +++ b/birth_number.gemspec @@ -21,7 +21,7 @@ spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(spec)/}) } spec.require_paths = ['lib'] - spec.required_ruby_version = '>= ...
Set support for minimum Ruby version to 2.1
diff --git a/lib/miq_tools_services/bugzilla.rb b/lib/miq_tools_services/bugzilla.rb index abc1234..def5678 100644 --- a/lib/miq_tools_services/bugzilla.rb +++ b/lib/miq_tools_services/bugzilla.rb @@ -14,7 +14,11 @@ def service @service ||= begin require 'active_bugzilla' - bz = ActiveBugzill...
Support RailsConfig objects for credentials
diff --git a/coursemology2/db/transforms/models/default.rb b/coursemology2/db/transforms/models/default.rb index abc1234..def5678 100644 --- a/coursemology2/db/transforms/models/default.rb +++ b/coursemology2/db/transforms/models/default.rb @@ -1,3 +1,3 @@ module CoursemologyV1::Source - def_model 'user_courses', 'ann...
Remove duplicate declaration of user_achievements
diff --git a/lib/serverspec/commands/freebsd.rb b/lib/serverspec/commands/freebsd.rb index abc1234..def5678 100644 --- a/lib/serverspec/commands/freebsd.rb +++ b/lib/serverspec/commands/freebsd.rb @@ -1,13 +1,11 @@-require 'shellwords' - module Serverspec module Commands class FreeBSD < Base - def check_e...
Fix arguments of the methods
diff --git a/lib/smart_answer/question/value.rb b/lib/smart_answer/question/value.rb index abc1234..def5678 100644 --- a/lib/smart_answer/question/value.rb +++ b/lib/smart_answer/question/value.rb @@ -10,16 +10,16 @@ if Integer == @parse begin Integer(raw_input) - rescue TypeErr...
Remove unused and therefore confusing exception message As discussed here [1], the exception message is only ever used as a key to **lookup** an error message from the locale files. Looking at the original code [2] which motivated the introduction of this `rescue` clause, it was simply raising an `InvalidResponse` ex...
diff --git a/Casks/adobe-reader.rb b/Casks/adobe-reader.rb index abc1234..def5678 100644 --- a/Casks/adobe-reader.rb +++ b/Casks/adobe-reader.rb @@ -1,6 +1,6 @@ cask :v1 => 'adobe-reader' do - version '2015.007.20033' - sha256 '46703ba27599512223e9b89c308075a0ddb625287be8e22a87574dfc70a77eb5' + version '2015.008.200...
Upgrade Adobe Acrobat Reader DC to 2015.008.20082
diff --git a/Casks/font-pt-mono.rb b/Casks/font-pt-mono.rb index abc1234..def5678 100644 --- a/Casks/font-pt-mono.rb +++ b/Casks/font-pt-mono.rb @@ -1,8 +1,8 @@ class FontPtMono < Cask - version '1.002' - sha256 '93c0ca1d9873ecc7c70131fa763aaaaa24345fc8b8f193ea2175b0857823d58a' + version '1.003' + sha256 '741b14570...
Update PT Mono to 1.003
diff --git a/spec/requests/user/accounts_spec.rb b/spec/requests/user/accounts_spec.rb index abc1234..def5678 100644 --- a/spec/requests/user/accounts_spec.rb +++ b/spec/requests/user/accounts_spec.rb @@ -0,0 +1,19 @@+require "spec_helper" + +# This should not test out the functionality of the devise controllers +# or ...
Add a failing test - users can't edit their account details.
diff --git a/spec/unit/resources/package_spec.rb b/spec/unit/resources/package_spec.rb index abc1234..def5678 100644 --- a/spec/unit/resources/package_spec.rb +++ b/spec/unit/resources/package_spec.rb @@ -13,6 +13,7 @@ name: 'foo', version: '1.0.0' ) + expect(stow_package_run).to run_execut...
Add test to verify execute command runs properly
diff --git a/app/controllers/application.rb b/app/controllers/application.rb index abc1234..def5678 100644 --- a/app/controllers/application.rb +++ b/app/controllers/application.rb @@ -10,6 +10,7 @@ before_filter :can_create?, :only => [:new, :create] before_filter :can_edit?, :only => [:edit, :update, :destroy]...
Load current_network in an ApplicationController before_filter
diff --git a/app/controllers/forest_controller.rb b/app/controllers/forest_controller.rb index abc1234..def5678 100644 --- a/app/controllers/forest_controller.rb +++ b/app/controllers/forest_controller.rb @@ -23,12 +23,10 @@ controller_heirarchy.pop controller_heirarchy = controller_heirarchy.collect { |a|...
Add ability to add additional body classes to body tag via host app
diff --git a/app/models/francis_cms/webmention.rb b/app/models/francis_cms/webmention.rb index abc1234..def5678 100644 --- a/app/models/francis_cms/webmention.rb +++ b/app/models/francis_cms/webmention.rb @@ -4,7 +4,7 @@ has_one :webmention_entry validates :source, :target, presence: true - validates :sou...
Use URI::DEFAULT_PARSER.make_regexp instead of URI.regexp
diff --git a/app/services/create_esdl_scenario.rb b/app/services/create_esdl_scenario.rb index abc1234..def5678 100644 --- a/app/services/create_esdl_scenario.rb +++ b/app/services/create_esdl_scenario.rb @@ -19,7 +19,11 @@ private def send_request - HTTParty.public_send(:post, api_url, { body: { energysystem...
ESDL: Add support for pro environment
diff --git a/probablyfine.gemspec b/probablyfine.gemspec index abc1234..def5678 100644 --- a/probablyfine.gemspec +++ b/probablyfine.gemspec @@ -1,13 +1,13 @@ # Ensure we require the local version and not one we might have installed already require File.join([File.dirname(__FILE__),'lib','probablyfine','version.rb']) ...
Add stuff to the gemspect because it beats adding functionality
diff --git a/app/workers/build_finished_worker.rb b/app/workers/build_finished_worker.rb index abc1234..def5678 100644 --- a/app/workers/build_finished_worker.rb +++ b/app/workers/build_finished_worker.rb @@ -7,9 +7,9 @@ def perform(build_id) Ci::Build.find_by(id: build_id).try do |build| BuildTraceSectio...
Make all workers in BuildFinishedWorker to run async and reorder
diff --git a/features/step_definitions/deployment_steps.rb b/features/step_definitions/deployment_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/deployment_steps.rb +++ b/features/step_definitions/deployment_steps.rb @@ -3,7 +3,7 @@ end Given(/^I am on the target page$/) do - visit "/target/...
Fix typo in targets URL
diff --git a/lib/griddler/adapters/sendgrid_adapter.rb b/lib/griddler/adapters/sendgrid_adapter.rb index abc1234..def5678 100644 --- a/lib/griddler/adapters/sendgrid_adapter.rb +++ b/lib/griddler/adapters/sendgrid_adapter.rb @@ -1,16 +1,31 @@ module Griddler module Adapters class SendGridAdapter + attr_acc...
[JRO] Clean up the SendGrid adapter class
diff --git a/sloc.gemspec b/sloc.gemspec index abc1234..def5678 100644 --- a/sloc.gemspec +++ b/sloc.gemspec @@ -22,6 +22,7 @@ spec.add_dependency "slop", "~> 3.0" spec.add_development_dependency "bundler", ">= 1.7" + spec.add_development_dependency "coveralls" spec.add_development_dependency "pry" spec.a...
Add coveralls as development dependency
diff --git a/lib/templates/rspec/scaffold/edit_spec.rb b/lib/templates/rspec/scaffold/edit_spec.rb index abc1234..def5678 100644 --- a/lib/templates/rspec/scaffold/edit_spec.rb +++ b/lib/templates/rspec/scaffold/edit_spec.rb @@ -2,14 +2,15 @@ RSpec.describe '<%= ns_table_name %>/edit', <%= type_metatag(:view) %> do ...
Fix 'edit' template spec tempalte
diff --git a/middleman-google-analytics.gemspec b/middleman-google-analytics.gemspec index abc1234..def5678 100644 --- a/middleman-google-analytics.gemspec +++ b/middleman-google-analytics.gemspec @@ -20,5 +20,5 @@ s.required_ruby_version = '>= 1.9.3' s.add_dependency("middleman-core", ["~> 3.2"]) - s.add_depen...
Fix conflicting version of uglifier
diff --git a/cmf/all/provisioners/cikit/config.rb b/cmf/all/provisioners/cikit/config.rb index abc1234..def5678 100644 --- a/cmf/all/provisioners/cikit/config.rb +++ b/cmf/all/provisioners/cikit/config.rb @@ -0,0 +1,16 @@+module VagrantPlugins::CIKit + class Config < Vagrant.plugin("2", :config) + attr_accessor :pl...
Fix critical typo in CIKit Vagrant provisioner
diff --git a/lib/app/presenters/notifications_presenter.rb b/lib/app/presenters/notifications_presenter.rb index abc1234..def5678 100644 --- a/lib/app/presenters/notifications_presenter.rb +++ b/lib/app/presenters/notifications_presenter.rb @@ -16,7 +16,7 @@ notifications.map { |notification| { id: ...
Update notification type in presenter
diff --git a/lib/big_decimal_helper/conversion_protocol.rb b/lib/big_decimal_helper/conversion_protocol.rb index abc1234..def5678 100644 --- a/lib/big_decimal_helper/conversion_protocol.rb +++ b/lib/big_decimal_helper/conversion_protocol.rb @@ -13,6 +13,7 @@ module ViaStringRepresentation def to_bd ...
Fix spec that breaks on recent-ish Ruby
diff --git a/lib/enableplaceholder-jquery-rails/version.rb b/lib/enableplaceholder-jquery-rails/version.rb index abc1234..def5678 100644 --- a/lib/enableplaceholder-jquery-rails/version.rb +++ b/lib/enableplaceholder-jquery-rails/version.rb @@ -1,7 +1,7 @@ module EnableplaceholderJquery module Rails - # Use logge...
Fix comment to describe enablePlaceholder
diff --git a/edtf-humanize.gemspec b/edtf-humanize.gemspec index abc1234..def5678 100644 --- a/edtf-humanize.gemspec +++ b/edtf-humanize.gemspec @@ -17,8 +17,9 @@ s.files = Dir["{app,config,db,lib}/**/*", "LICENSE.txt", "Rakefile", "README.rdoc"] s.test_files = Dir["test/**/*"] - s.add_dependency "rails", "~> 4...
Move dependency from Rails to ActiveSupport Also allow Rails 5
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -11,7 +11,7 @@ # www.interconlarp.org becomes interconlarp.org second_level_domain = just_hostname.split("....
Make sure the cookie will work for subdomains
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -2,5 +2,5 @@ Rails.application.config.session_store :cookie_store, key: "_updated_gobierto_session", - dom...
Set up a common session store in test environment to work with sessions
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,6 +1,9 @@ # Be sure to restart your server when you modify this file. -Panopticon::Application.config.sessi...
Set cookies to only be served over https and to be http only
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,7 +1,7 @@ # Be sure to restart your server when you modify this file. options = if Rails.env.production? -...
Append glowfic-staging to cookies list, hopefully not affecting prod
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,4 +1,8 @@ # We set the cookie domain dynamically with a Rack middleware. # See lib/intercode/dynamic_cookie_...
Set an expiration for session cookies
diff --git a/config/initializers/bower_rails.rb b/config/initializers/bower_rails.rb index abc1234..def5678 100644 --- a/config/initializers/bower_rails.rb +++ b/config/initializers/bower_rails.rb @@ -1,19 +1,26 @@ BowerRails.configure do |bower_rails| # Tell bower-rails what path should be considered as root. Defau...
Update all of bower rails to use production settings
diff --git a/config/initializers/rabl_config.rb b/config/initializers/rabl_config.rb index abc1234..def5678 100644 --- a/config/initializers/rabl_config.rb +++ b/config/initializers/rabl_config.rb @@ -1,6 +1,6 @@ Rabl.configure do |config| config.include_json_root = false config.include_child_root = false - conf...
Update to disable Rabl caching We've been finding that we're encountering errors on production that we're unable to reproduce locally using the same data. After some investigation we found that the Rabl source cache option seemed to be the root of these issues and given the other layers of caching we have present we f...
diff --git a/services/automatic_geocoder/lib/automatic_geocoder/runner.rb b/services/automatic_geocoder/lib/automatic_geocoder/runner.rb index abc1234..def5678 100644 --- a/services/automatic_geocoder/lib/automatic_geocoder/runner.rb +++ b/services/automatic_geocoder/lib/automatic_geocoder/runner.rb @@ -17,7 +17,7 @@ ...
Reduce the interval between geocoding checks
diff --git a/spec/features/content_plan_spec.rb b/spec/features/content_plan_spec.rb index abc1234..def5678 100644 --- a/spec/features/content_plan_spec.rb +++ b/spec/features/content_plan_spec.rb @@ -12,13 +12,11 @@ fill_in "Title", with: "Some title" fill_in "Ref no", with: "X" - fill_in "Size", with: "...
Update spec to remove size
diff --git a/spec/requests/static_pages_spec.rb b/spec/requests/static_pages_spec.rb index abc1234..def5678 100644 --- a/spec/requests/static_pages_spec.rb +++ b/spec/requests/static_pages_spec.rb @@ -42,4 +42,19 @@ it { should have_content('David E. Smyth') } end + + it "should have the right links on the la...
Add tests for following links on static pages
diff --git a/app/config/capistrano/stages/staging.rb b/app/config/capistrano/stages/staging.rb index abc1234..def5678 100644 --- a/app/config/capistrano/stages/staging.rb +++ b/app/config/capistrano/stages/staging.rb @@ -1,14 +1,14 @@ ### DO NOT EDIT BELOW ### set :branch, "staging" -set :document_root, "/home/sites/p...
Change default php version to 7.4
diff --git a/examples/params.rb b/examples/params.rb index abc1234..def5678 100644 --- a/examples/params.rb +++ b/examples/params.rb @@ -4,8 +4,8 @@ contract = Class.new(Dry::Validation::Contract) do params do - required(:email).filled - required(:age).filled(:int?, gt?: 18) + required(:email).filled(:str...
Add type specs to example
diff --git a/script/update-marriage-abroad-services.rb b/script/update-marriage-abroad-services.rb index abc1234..def5678 100644 --- a/script/update-marriage-abroad-services.rb +++ b/script/update-marriage-abroad-services.rb @@ -0,0 +1,47 @@+update_file = ARGV.shift +unless update_file && File.exist?(update_file) + pu...
Add script to update marriage_abroad_services.yml Trello card: https://trello.com/c/D0ZMM9v5 This will help me update the services based on the data in the spreadsheet attached to the Trello card.
diff --git a/feedcellar.gemspec b/feedcellar.gemspec index abc1234..def5678 100644 --- a/feedcellar.gemspec +++ b/feedcellar.gemspec @@ -18,7 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_runtime_dependency("rroonga") + spec.add_runtime_depend...
Use rroonga 3.0.4 or later
diff --git a/app/controllers/auth0_controller.rb b/app/controllers/auth0_controller.rb index abc1234..def5678 100644 --- a/app/controllers/auth0_controller.rb +++ b/app/controllers/auth0_controller.rb @@ -10,7 +10,7 @@ session[:uid] = user.uid redirect_to root_url else - render plain: { bell: 'sh...
Update error message for github org login failure to explain reason for failure
diff --git a/app/controllers/index_controller.rb b/app/controllers/index_controller.rb index abc1234..def5678 100644 --- a/app/controllers/index_controller.rb +++ b/app/controllers/index_controller.rb @@ -1,10 +1,12 @@ class IndexController < ApplicationController - REDIS_KEY_PREFIX = "bus-detective:index" - force_...
Use s3-index instead of redis for ember index page
diff --git a/app/controllers/items_controller.rb b/app/controllers/items_controller.rb index abc1234..def5678 100644 --- a/app/controllers/items_controller.rb +++ b/app/controllers/items_controller.rb @@ -17,7 +17,9 @@ end def show + today = Date.today @item = Item.find(params[:id]) + redirect_to root_path if...
Fix disable Item show until the day
diff --git a/Casks/jing.rb b/Casks/jing.rb index abc1234..def5678 100644 --- a/Casks/jing.rb +++ b/Casks/jing.rb @@ -2,6 +2,6 @@ url 'http://download.techsmith.com/jing/mac/jing.dmg' homepage 'http://www.techsmith.com/jing.html' version 'latest' - sha1 'no_checksum' + no_checksum link 'Jing.app' end
Remove quotation marks for no_checksum
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -5,6 +5,7 @@ end def new + redirect_to root_path if current_user @user = User.new end @@ -25,12 +26,12 ...
Add redirecting to root path
diff --git a/lib/imap/backup/downloader.rb b/lib/imap/backup/downloader.rb index abc1234..def5678 100644 --- a/lib/imap/backup/downloader.rb +++ b/lib/imap/backup/downloader.rb @@ -15,7 +15,6 @@ count = uids.count Imap::Backup::Logger.logger.debug "[#{folder.name}] #{count} new messages" uids.each_s...
Declare variable as late as possible
diff --git a/spec/extensions/invoice_extension_spec.rb b/spec/extensions/invoice_extension_spec.rb index abc1234..def5678 100644 --- a/spec/extensions/invoice_extension_spec.rb +++ b/spec/extensions/invoice_extension_spec.rb @@ -4,10 +4,10 @@ context "extensions" do describe ".pending" do it "returns Invo...
Change test to be order independent
diff --git a/spec/features/user_creates_a_post_spec.rb b/spec/features/user_creates_a_post_spec.rb index abc1234..def5678 100644 --- a/spec/features/user_creates_a_post_spec.rb +++ b/spec/features/user_creates_a_post_spec.rb @@ -22,8 +22,8 @@ feature 'Auto generate post slug' do scenario 'user types on title f...
Fix capybara waits for ajax
diff --git a/spec/support/integration_example_group.rb b/spec/support/integration_example_group.rb index abc1234..def5678 100644 --- a/spec/support/integration_example_group.rb +++ b/spec/support/integration_example_group.rb @@ -10,7 +10,6 @@ include RSpec::Rails::TestUnitAssertionAdapter include ActionDispatc...
Remove RSpec::Matchers include which was causing stack level too deep error [myronmarston]
diff --git a/app/presenters/request_presenter.rb b/app/presenters/request_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/request_presenter.rb +++ b/app/presenters/request_presenter.rb @@ -1,6 +1,7 @@ class RequestPresenter < SimpleDelegator def can_vote?(u) - self.user.id != u.id && !self.user.vo...
Use the current user, not the request owner