diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/Casks/opera-beta.rb b/Casks/opera-beta.rb index abc1234..def5678 100644 --- a/Casks/opera-beta.rb +++ b/Casks/opera-beta.rb @@ -1,6 +1,6 @@ cask :v1 => 'opera-beta' do - version '30.0.1835.18' - sha256 '7c27bfd506a5d3a9a41eabd27908344269d1d4f5a85d451d2d2ce0a9ee602993' + version '30.0.1835.47' + sha256 ...
Upgrade Opera Beta.app to v30.0.1835.47
diff --git a/app/controllers/api/materials_controller.rb b/app/controllers/api/materials_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/materials_controller.rb +++ b/app/controllers/api/materials_controller.rb @@ -1,22 +1,35 @@-class Api::MaterialsController < ApplicationController - skip_before...
Create CRUD methods for materials controller
diff --git a/app/views/gitlab_client_identities/_gitlab_client_identity.json.jbuilder b/app/views/gitlab_client_identities/_gitlab_client_identity.json.jbuilder index abc1234..def5678 100644 --- a/app/views/gitlab_client_identities/_gitlab_client_identity.json.jbuilder +++ b/app/views/gitlab_client_identities/_gitlab_c...
Add missing gitlab_user_name attribute to attributes reported for gitlab_client_identity.
diff --git a/app/controllers/health_checks_controller.rb b/app/controllers/health_checks_controller.rb index abc1234..def5678 100644 --- a/app/controllers/health_checks_controller.rb +++ b/app/controllers/health_checks_controller.rb @@ -4,11 +4,12 @@ @health_checks = HealthChecks.all respond_to do |format| -...
Include a JSON healthcheck for ELB which does not 500 if the app is up
diff --git a/lib/active_cmis/ns.rb b/lib/active_cmis/ns.rb index abc1234..def5678 100644 --- a/lib/active_cmis/ns.rb +++ b/lib/active_cmis/ns.rb @@ -8,11 +8,11 @@ ATOM = "http://www.w3.org/2005/Atom" COMBINED = { - "c" => CMIS_CORE, - "cra" => CMIS_REST, - "cm" => CMIS_MESSAGING, - "app" ...
Allow NS::COMBINED to be used in building xml
diff --git a/lib/capybara/rspec.rb b/lib/capybara/rspec.rb index abc1234..def5678 100644 --- a/lib/capybara/rspec.rb +++ b/lib/capybara/rspec.rb @@ -9,6 +9,8 @@ RSpec.configure do |config| config.include Capybara::DSL, type: :feature config.include Capybara::RSpecMatchers, type: :feature + config.include Capybar...
Include DSL and RSpecMatchers into system specs by default
diff --git a/lib/grabble/vertex.rb b/lib/grabble/vertex.rb index abc1234..def5678 100644 --- a/lib/grabble/vertex.rb +++ b/lib/grabble/vertex.rb @@ -1,12 +1,9 @@ module Grabble class Vertex + attr_reader :data + def initialize(data) @data = data end - - def data - @data - end - end ...
Use attr_reader instead of manual getter method
diff --git a/lib/kahuna/handler.rb b/lib/kahuna/handler.rb index abc1234..def5678 100644 --- a/lib/kahuna/handler.rb +++ b/lib/kahuna/handler.rb @@ -4,24 +4,6 @@ module Kahuna class Handler attr_reader :event, :members - - # def self.build - # klass = Class.new(BasicObject) do - # def inspect - ...
Remove stupid comments from experiments
diff --git a/lib/poke/character.rb b/lib/poke/character.rb index abc1234..def5678 100644 --- a/lib/poke/character.rb +++ b/lib/poke/character.rb @@ -3,6 +3,16 @@ # contains various methods for moving, updating, drawing, and collision # detection. class Character + + PARAMS_REQUIRED = [:window, :x, :y] + + ...
Add base skeleton structure to Character
diff --git a/app/controllers/organizations_controller.rb b/app/controllers/organizations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/organizations_controller.rb +++ b/app/controllers/organizations_controller.rb @@ -11,7 +11,13 @@ :organization_id => params[:id] })...
Clear Doc cache when Organization language changes
diff --git a/app/controllers/relationships_controller.rb b/app/controllers/relationships_controller.rb index abc1234..def5678 100644 --- a/app/controllers/relationships_controller.rb +++ b/app/controllers/relationships_controller.rb @@ -2,15 +2,11 @@ before_filter :authenticate_user! #TODO: Use ajax? + #TODO: A...
Refactor controller to include new connection creating methods
diff --git a/lib/vagrant-mirror.rb b/lib/vagrant-mirror.rb index abc1234..def5678 100644 --- a/lib/vagrant-mirror.rb +++ b/lib/vagrant-mirror.rb @@ -36,4 +36,7 @@ Vagrant.actions[:start].use Vagrant::Mirror::Middleware::Sync # Add the mirror middleware to the standard stacks -Vagrant.actions[:start].insert Vagrant::...
Fix syntax errors, abort on any thread exception
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -5,4 +5,5 @@ :cookie_store, key: '_nippo_session', secure: Rails.env.production?, + expire_after: 30.da...
Set expiration date to session cookie
diff --git a/Casks/beatport-pro.rb b/Casks/beatport-pro.rb index abc1234..def5678 100644 --- a/Casks/beatport-pro.rb +++ b/Casks/beatport-pro.rb @@ -1,12 +1,12 @@ cask :v1 => 'beatport-pro' do - version '2.1.1_137' - sha256 '62526d08723e5a54953473a2c1530e5b298ab2a50a491dd2a846bf7c0b9499cb' + version '2.1.4_150' + s...
Update Beatport Pro to 2.1.4
diff --git a/spec/workers/download_manuscript_worker_spec.rb b/spec/workers/download_manuscript_worker_spec.rb index abc1234..def5678 100644 --- a/spec/workers/download_manuscript_worker_spec.rb +++ b/spec/workers/download_manuscript_worker_spec.rb @@ -8,14 +8,14 @@ paper.create_manuscript! end - it "download...
Mark DownloadManuscriptWorker spec as pending
diff --git a/core/encoding/locale_charmap_spec.rb b/core/encoding/locale_charmap_spec.rb index abc1234..def5678 100644 --- a/core/encoding/locale_charmap_spec.rb +++ b/core/encoding/locale_charmap_spec.rb @@ -7,22 +7,31 @@ end # FIXME: Get this working on Windows - platform_is :os => [:darwin, :linux] do ...
Fix for *BSD and Darwin about locale charmap. * The result of locale charmap is not standardized. So even if LANG=C, locale charmap name is not predictable. * LC_ALL is prior to LANG, so we use LC_ALL.
diff --git a/DSSparseArray.podspec b/DSSparseArray.podspec index abc1234..def5678 100644 --- a/DSSparseArray.podspec +++ b/DSSparseArray.podspec @@ -6,6 +6,6 @@ s.source = { :git => "https://github.com/LavaSlider/DSSparseArray.git", :tag => "1.0.0" } s.summary = "Objective C Sparse Array Implementation" s.homep...
Change file pattern in pod
diff --git a/fcc_reboot.gemspec b/fcc_reboot.gemspec index abc1234..def5678 100644 --- a/fcc_reboot.gemspec +++ b/fcc_reboot.gemspec @@ -7,8 +7,8 @@ gem.add_dependency 'hashie', '~> 1.2' gem.add_dependency 'json', '~> 1.6' gem.add_dependency 'multi_json', '~> 1.3' + gem.add_development_dependency 'maruku' g...
Use maruku instead of rdiscount for compatibility with JRuby and Rubinius in 1.9 mode
diff --git a/lib/cacheable_flash/rspec_matchers.rb b/lib/cacheable_flash/rspec_matchers.rb index abc1234..def5678 100644 --- a/lib/cacheable_flash/rspec_matchers.rb +++ b/lib/cacheable_flash/rspec_matchers.rb @@ -1,33 +1,36 @@-require 'cacheable_flash/test_helpers' +require 'stackable_flash/test_helpers' # Used in th...
Use stackable_flash/test_helpers instead of reinventing the wheel
diff --git a/app/controllers/internal_change_notes_controller.rb b/app/controllers/internal_change_notes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/internal_change_notes_controller.rb +++ b/app/controllers/internal_change_notes_controller.rb @@ -1,6 +1,6 @@ class InternalChangeNotesController < A...
Refactor how an InternalChangeNote is stored This refactor will make it easier to optionally add a value for edition_number to the `other_fields` in the next commit.
diff --git a/lib/kosmos/packages/deadly_reentry.rb b/lib/kosmos/packages/deadly_reentry.rb index abc1234..def5678 100644 --- a/lib/kosmos/packages/deadly_reentry.rb +++ b/lib/kosmos/packages/deadly_reentry.rb @@ -0,0 +1,9 @@+class DeadlyReentry < Kosmos::Package + title 'Deadly Reentry' + url 'https://github.com/Nath...
Add package for Deadly Reentry.
diff --git a/test/integration/ad_creation_test.rb b/test/integration/ad_creation_test.rb index abc1234..def5678 100644 --- a/test/integration/ad_creation_test.rb +++ b/test/integration/ad_creation_test.rb @@ -8,7 +8,7 @@ it 'can have pictures of 5 megabytes or less' do with_file_of_size(5.megabytes) do |path| ...
Rename helper method for clarity The method also submits the form so `fill_form` was not accurate.
diff --git a/islay_blog.gemspec b/islay_blog.gemspec index abc1234..def5678 100644 --- a/islay_blog.gemspec +++ b/islay_blog.gemspec @@ -16,7 +16,7 @@ s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.md"] s.test_files = Dir["test/**/*"] - s.add_dependency 'islay', '~> 1.0....
Update Islay dependency to 1.0.3 (which actually exists)
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -15,8 +15,7 @@ # so read line and split by myself. open('db/commits.txt') do |file| file.each do |line| - repo_full_name, sha, *message_array = line.split(',').map(&:strip) - message = message_array.joi...
Improve method for data load
diff --git a/phantomjs-binaries.gemspec b/phantomjs-binaries.gemspec index abc1234..def5678 100644 --- a/phantomjs-binaries.gemspec +++ b/phantomjs-binaries.gemspec @@ -7,7 +7,7 @@ s.version = Phantomjs::Binaries::VERSION s.authors = ["Anton Vaynshtok"] s.email = ["avaynshtok@gmail.com"] - s.home...
Make it so people can find the source from the Gemspec
diff --git a/lib/chamber.rb b/lib/chamber.rb index abc1234..def5678 100644 --- a/lib/chamber.rb +++ b/lib/chamber.rb @@ -23,8 +23,12 @@ load_file(self.basepath + 'settings.yml') end - def [](key) - settings[key] + def method_missing(name, *args) + settings.public_send(name, *args) if settings.respond_t...
Use method missing to delegate any message sent to Chamber as a message for the underlying Hash
diff --git a/lib/bulk/engine.rb b/lib/bulk/engine.rb index abc1234..def5678 100644 --- a/lib/bulk/engine.rb +++ b/lib/bulk/engine.rb @@ -16,7 +16,9 @@ require 'bulk/sproutcore' end - config.paths.add "app/bulk", :eager_load => true - config.paths.add "app/sproutcore" + initializer "config paths" d...
Fix setting paths for Rails 3.1
diff --git a/lib/konacha.rb b/lib/konacha.rb index abc1234..def5678 100644 --- a/lib/konacha.rb +++ b/lib/konacha.rb @@ -40,7 +40,7 @@ Rails.application.assets.content_type_of(pathname) == 'application/javascript' }.map { |pathname| pathname.to_s.gsub(File.join(spec_root, ''), '') - } + ...
Sort the spec_paths to avoid undefined ordering I think that it's good practice to keep file lists sorted. Otherwise we can get file-system dependent (undefined) file ordering, and we'll have order-dependent tests showing up as unreproducible failures on the build server, which is worse than having them pass silently....
diff --git a/lib/ews/types/calendar_item.rb b/lib/ews/types/calendar_item.rb index abc1234..def5678 100644 --- a/lib/ews/types/calendar_item.rb +++ b/lib/ews/types/calendar_item.rb @@ -8,15 +8,21 @@ recurring?: [:is_recurring, :text], meeting?: [:is_meeting, :text], cancelled?: [:is_cancelle...
Add duration, time zone, start, end, location and all day attributes to the calendar item
diff --git a/lib/gitlab/current_settings.rb b/lib/gitlab/current_settings.rb index abc1234..def5678 100644 --- a/lib/gitlab/current_settings.rb +++ b/lib/gitlab/current_settings.rb @@ -41,6 +41,9 @@ use_db && ActiveRecord::Base.connection.active? && !ActiveRecord::Migrator.needs_migration? && ...
Handle missing DBs in connect_to_db? This ensures CurrentSettings#connect_to_db? returns "false" in the event of a database not existing, instead of raising an error.
diff --git a/lib/scube/cli/commands/base.rb b/lib/scube/cli/commands/base.rb index abc1234..def5678 100644 --- a/lib/scube/cli/commands/base.rb +++ b/lib/scube/cli/commands/base.rb @@ -17,9 +17,10 @@ attr_reader :client - # FIXME: implement this correctly (arity errors) def setup_arguments a...
Handle command arguments arity errors
diff --git a/lib/coordinates.rb b/lib/coordinates.rb index abc1234..def5678 100644 --- a/lib/coordinates.rb +++ b/lib/coordinates.rb @@ -2,7 +2,7 @@ def initialize(window, user) @window, @user = window, user - @coordinate_text = Gosu::Font.new(@window, Media::Font, 16) + @coordinate_text = Gosu::Font.new...
Update Coordinates to use new uppercase constants
diff --git a/lib/kaleidoscope/instance_methods.rb b/lib/kaleidoscope/instance_methods.rb index abc1234..def5678 100644 --- a/lib/kaleidoscope/instance_methods.rb +++ b/lib/kaleidoscope/instance_methods.rb @@ -4,9 +4,11 @@ end def generate_colors + Kaleidoscope.log("Generating colors.") end d...
Add log messages to instance methods
diff --git a/activesupport/test/load_paths_test.rb b/activesupport/test/load_paths_test.rb index abc1234..def5678 100644 --- a/activesupport/test/load_paths_test.rb +++ b/activesupport/test/load_paths_test.rb @@ -10,7 +10,7 @@ } load_paths_count[File.expand_path('../../lib', __FILE__)] -= 1 - filtered = l...
Drop extra variable from test
diff --git a/activesupport/test/subscriber_test.rb b/activesupport/test/subscriber_test.rb index abc1234..def5678 100644 --- a/activesupport/test/subscriber_test.rb +++ b/activesupport/test/subscriber_test.rb @@ -23,6 +23,7 @@ # Monkey patch subscriber to test that only one subscriber per method is added. class Test...
Remove warning remeving the method before redefining We need to test if the same method defined more than once only register one subscriber for it. We can safelly remove because the method body is the same and Subscriber use method_added hook for register the subscriber.
diff --git a/ruby/spec/support/shared_examples.rb b/ruby/spec/support/shared_examples.rb index abc1234..def5678 100644 --- a/ruby/spec/support/shared_examples.rb +++ b/ruby/spec/support/shared_examples.rb @@ -12,22 +12,30 @@ shared_examples_for "a bson element" do - subject { (defined? obj) ? obj : described_class...
Change shared examples to proper conventions
diff --git a/lib/find_chrome.rb b/lib/find_chrome.rb index abc1234..def5678 100644 --- a/lib/find_chrome.rb +++ b/lib/find_chrome.rb @@ -14,6 +14,7 @@ CHROMEDRIVER_PATHS = [ "/usr/local/bin/chromedriver", "/usr/lib/chromium-browser/chromedriver", + "/app/.chromedriver/bin/chromedriver", ENV["CHROMED...
Add binary paths to chrome(driver) finder(s) With the buildpacks we've now added to our heroku apps, we now have two binaries available that we can use when we drive our applications. The changes here point to the location of both of those binaries.
diff --git a/lib/gocd_client.rb b/lib/gocd_client.rb index abc1234..def5678 100644 --- a/lib/gocd_client.rb +++ b/lib/gocd_client.rb @@ -27,7 +27,7 @@ next unless stage['result'] == 'Failed' stage_url = "#{@gocd_addr}/go/pipelines/#{pipe_name}/#{event['counter']}/#{stage['name']}/#{stage['counter']}" ...
Improve status report for GoCD issues
diff --git a/lib/alchemy_api.rb b/lib/alchemy_api.rb index abc1234..def5678 100644 --- a/lib/alchemy_api.rb +++ b/lib/alchemy_api.rb @@ -5,6 +5,14 @@ Dir.glob(File.dirname(__FILE__) + "/**/*.rb").each do |f| require f end + +$LOAD_PATH.unshift(File.dirname(__FILE__)) +require 'alchemy_api/base' +require 'alchemy_ap...
Make sure files require in the correct order.
diff --git a/lib/spidr/spidr.rb b/lib/spidr/spidr.rb index abc1234..def5678 100644 --- a/lib/spidr/spidr.rb +++ b/lib/spidr/spidr.rb @@ -16,6 +16,7 @@ # @since 0.5.0 # def self.robots? + @robots ||= false @robots end
Fix warning instance variable @robots not initialized
diff --git a/lib/tasks/eve.rake b/lib/tasks/eve.rake index abc1234..def5678 100644 --- a/lib/tasks/eve.rake +++ b/lib/tasks/eve.rake @@ -36,4 +36,13 @@ AncestriesImporter.new.import end end + + desc 'Import EveOnline Alliances' + task alliances: :environment do + ActiveRecord::Base.transaction do + ...
Add rake task for import alliances
diff --git a/spec/support/browser_spec_helper.rb b/spec/support/browser_spec_helper.rb index abc1234..def5678 100644 --- a/spec/support/browser_spec_helper.rb +++ b/spec/support/browser_spec_helper.rb @@ -46,7 +46,6 @@ $spec_app = Thread.new do Rack::Server.new(:app => Hdo::Application, ...
Revert "Use puma for browser specs" This reverts commit a4ff77f90abbe84d1f14ddd3520c217b7e5510ab.
diff --git a/spec/unit/template_variable_spec.rb b/spec/unit/template_variable_spec.rb index abc1234..def5678 100644 --- a/spec/unit/template_variable_spec.rb +++ b/spec/unit/template_variable_spec.rb @@ -7,16 +7,16 @@ it "requires a variable name" do expect { TemplateVariable.new }.to raise_error(KeyE...
Use standard variable casing in specs
diff --git a/musical-pitch-classes/pitch_class.rb b/musical-pitch-classes/pitch_class.rb index abc1234..def5678 100644 --- a/musical-pitch-classes/pitch_class.rb +++ b/musical-pitch-classes/pitch_class.rb @@ -1,31 +1,14 @@ NATURAL_NOTES = { - 'C' => 0, - 'D' => 2, - 'E' => 4, - 'F' => 5, - 'G' => 7, - 'A' => 9, -...
Refactor to use ceiling and modulus
diff --git a/config/initializers/gds_api.rb b/config/initializers/gds_api.rb index abc1234..def5678 100644 --- a/config/initializers/gds_api.rb +++ b/config/initializers/gds_api.rb @@ -5,3 +5,6 @@ GdsApi::Base.default_options = {disable_timeout: true} Frontend.detailed_guidance_content_api = GdsApi::ContentApi.new(P...
Make note of copies existing in preview/production
diff --git a/lib/genome/online_updaters/go/api_client.rb b/lib/genome/online_updaters/go/api_client.rb index abc1234..def5678 100644 --- a/lib/genome/online_updaters/go/api_client.rb +++ b/lib/genome/online_updaters/go/api_client.rb @@ -21,7 +21,7 @@ end def gene_lookup_base_url(id) - "http://api.geneon...
Add quotes around GO ID in API call to only get exact matches
diff --git a/lib/json_schema/artesano/tools/data_type.rb b/lib/json_schema/artesano/tools/data_type.rb index abc1234..def5678 100644 --- a/lib/json_schema/artesano/tools/data_type.rb +++ b/lib/json_schema/artesano/tools/data_type.rb @@ -0,0 +1,33 @@+# +# The DataType strategy uses the data type of any primitive or enum...
Add data type strategy (Tools::DataType) The DataType strategy uses the data type of any primitive or enum property as the generated data. Might help you to visually understand a JSON Schema better (maybe).
diff --git a/locationer.gemspec b/locationer.gemspec index abc1234..def5678 100644 --- a/locationer.gemspec +++ b/locationer.gemspec @@ -9,7 +9,7 @@ s.version = Locationer::VERSION s.authors = ["Tomasz Grabowski"] s.email = ["belike81@gmail.com"] - s.homepage = "www.tomaszgrabowski.com" + s.h...
Add http protocol to homepage URI in gemspec
diff --git a/app/controllers/contact_controller.rb b/app/controllers/contact_controller.rb index abc1234..def5678 100644 --- a/app/controllers/contact_controller.rb +++ b/app/controllers/contact_controller.rb @@ -5,7 +5,7 @@ end def create - if params[:value].blank? then + if params[:value].blank? && !params[:t...
Make sure message does not get sent when no commitee has been selected
diff --git a/spec/aws/ssm/console/options_spec.rb b/spec/aws/ssm/console/options_spec.rb index abc1234..def5678 100644 --- a/spec/aws/ssm/console/options_spec.rb +++ b/spec/aws/ssm/console/options_spec.rb @@ -0,0 +1,59 @@+require 'spec_helper' + +RSpec.describe Aws::SSM::Console::Options, type: :lib do + describe '#ne...
Add examples for command line options.
diff --git a/app/helpers/admin/users_helper.rb b/app/helpers/admin/users_helper.rb index abc1234..def5678 100644 --- a/app/helpers/admin/users_helper.rb +++ b/app/helpers/admin/users_helper.rb @@ -5,10 +5,10 @@ def render_options_for_display_name options = "<option value='#{@user.login}' #{get_select(@user.nam...
Hide Display Name option choices in profile edit if blank It's possible the user name options for setting Display Name are blank or empty strings so let's check for that in addition to if they're set in the first place.
diff --git a/app/helpers/allocations_helper.rb b/app/helpers/allocations_helper.rb index abc1234..def5678 100644 --- a/app/helpers/allocations_helper.rb +++ b/app/helpers/allocations_helper.rb @@ -1,12 +1,3 @@ module AllocationsHelper - def start_time_form_column(record, options) - options[:class] += " time_picker"...
Remove timepicker from allocation views
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -10,7 +10,7 @@ # Escape text for inclusion in Latex documents def lesc(text) - # Use gsub to remove any characters...
FIX: Switch gsub in lesc to ensure running on text
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -8,7 +8,7 @@ :description => description, :type => page_type, :url => url_for(:only_path => false), - ...
Add width and height to opengraph image
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -6,12 +6,12 @@ def event_host? event_host = nil - unless admin? - else + unless @event.nil? + unles...
Correct `event_host?` with nil check on `@event` `@event` will be nil if we aren't in an event's scope!
diff --git a/test/integration/config/serverspec/auth_spec.rb b/test/integration/config/serverspec/auth_spec.rb index abc1234..def5678 100644 --- a/test/integration/config/serverspec/auth_spec.rb +++ b/test/integration/config/serverspec/auth_spec.rb @@ -1,10 +1,6 @@ require 'spec_helper' describe file('/etc/rundeck/r...
Remove unrelated specs from the config suite
diff --git a/test/lib/pc_rails_code_quality/analysis_test.rb b/test/lib/pc_rails_code_quality/analysis_test.rb index abc1234..def5678 100644 --- a/test/lib/pc_rails_code_quality/analysis_test.rb +++ b/test/lib/pc_rails_code_quality/analysis_test.rb @@ -1,35 +1,29 @@ # frozen_string_literal: true require 'test_helper' ...
Adjust tests for analisys module - check only if response to methods
diff --git a/railties/lib/rails/generators/rails/plugin/templates/rails/application.rb b/railties/lib/rails/generators/rails/plugin/templates/rails/application.rb index abc1234..def5678 100644 --- a/railties/lib/rails/generators/rails/plugin/templates/rails/application.rb +++ b/railties/lib/rails/generators/rails/plugi...
Add ActionCable require statement to plugin When generating a plugin without ActiveRecord (-O), ActionCable wasn't include, which causes problems with the require action_cable statement in cable.js add active_job require statement also updated order of require statements to match with all.rb
diff --git a/app/models/concerns/boolean_fields.rb b/app/models/concerns/boolean_fields.rb index abc1234..def5678 100644 --- a/app/models/concerns/boolean_fields.rb +++ b/app/models/concerns/boolean_fields.rb @@ -21,7 +21,7 @@ extend ActiveSupport::Concern def boolean_regex - "(Yes|No|Y|N|TickYes|TickNo)+" + ...
Support T and F as boolean suffixes
diff --git a/app/models/spree/variant_decorator.rb b/app/models/spree/variant_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/variant_decorator.rb +++ b/app/models/spree/variant_decorator.rb @@ -1,20 +1,8 @@ Spree::Variant.class_eval do - has_many :digitals, :dependent => :destroy - after_save :...
Remove delete digitals on soft delete of variant
diff --git a/abstract_class.gemspec b/abstract_class.gemspec index abc1234..def5678 100644 --- a/abstract_class.gemspec +++ b/abstract_class.gemspec @@ -12,7 +12,7 @@ s.author = 'Sean Huber' s.email = 'github@shuber.io' - s.homepage = 'http://github.com/shuber/abstract_class' + s.homepage = 'https://githu...
Use https in the gemspec homepage
diff --git a/scripts/scan_categories.rb b/scripts/scan_categories.rb index abc1234..def5678 100644 --- a/scripts/scan_categories.rb +++ b/scripts/scan_categories.rb @@ -8,7 +8,7 @@ puts("Total number of categories: " + arr.length.to_s) -key_words = ["medizin"] +key_words = ["medizin", "gesundheit", "krankheit", "ep...
Add keywords for category selection. ~ 800 categories / 10'000 articles with these key words.
diff --git a/0_code_wars/extract_the_ids_from_the_data_set.rb b/0_code_wars/extract_the_ids_from_the_data_set.rb index abc1234..def5678 100644 --- a/0_code_wars/extract_the_ids_from_the_data_set.rb +++ b/0_code_wars/extract_the_ids_from_the_data_set.rb @@ -0,0 +1,17 @@+# http://www.codewars.com/kata/5158bfce931c51b69b0...
Add code wars (6) - extract ids from data set
diff --git a/assets/filter.d/rel_changes_of.rb b/assets/filter.d/rel_changes_of.rb index abc1234..def5678 100644 --- a/assets/filter.d/rel_changes_of.rb +++ b/assets/filter.d/rel_changes_of.rb @@ -3,7 +3,7 @@ # changes than the whole site had lines before. WCC::Filters.add 'rel_changes_of' do |data,args| - nex...
Fix another typo in filter -.-
diff --git a/lib/github/repo.rb b/lib/github/repo.rb index abc1234..def5678 100644 --- a/lib/github/repo.rb +++ b/lib/github/repo.rb @@ -34,7 +34,7 @@ end def from_api_response(api_response) - new(api_response[:full_name], api_response[:ssh_url]) + new(api_response[:full_name], api_response...
Revert using SSH URL to HTML URL so it can be opened in the browser
diff --git a/app/models/document.rb b/app/models/document.rb index abc1234..def5678 100644 --- a/app/models/document.rb +++ b/app/models/document.rb @@ -33,7 +33,7 @@ end def description - @desc ||= exists? ? self.content.lines.reject{|l| l =~ /^(\n|<)/ }.second.delete('<br>').strip : '' + @desc ||= exis...
Use gsub instead of delete method to fetch OGP description
diff --git a/app/models/identity.rb b/app/models/identity.rb index abc1234..def5678 100644 --- a/app/models/identity.rb +++ b/app/models/identity.rb @@ -3,6 +3,6 @@ validates :name, presence: true validates :email, presence: true, uniqueness: true, allow_blank: true, format: - { with: /^([^@\s]+)@((?:[-a-z0-9...
Fix regular expression of email > The provided regular expression is using multiline anchors (^ or $), which may present a security risk. Did you mean to use \A and \z, or forgot to add the :multiline => true option?
diff --git a/lib/semantology.rb b/lib/semantology.rb index abc1234..def5678 100644 --- a/lib/semantology.rb +++ b/lib/semantology.rb @@ -1,5 +1,7 @@ require 'rdf' require 'linkeddata' + +require_relative 'semantology/reader/rdfa' # The module that contains everything Semantology-related module Semantology @@ -12,7...
Read RDFa data in convinience method
diff --git a/lib/shoes/check.rb b/lib/shoes/check.rb index abc1234..def5678 100644 --- a/lib/shoes/check.rb +++ b/lib/shoes/check.rb @@ -15,8 +15,6 @@ @gui = Shoes.configuration.backend_for(self, @parent.gui, blk) @parent.add_child self - - click(&opts[:click]) if opts[:click] end def ch...
Remove click option for Check temporarily
diff --git a/lib/tasks/dev.rake b/lib/tasks/dev.rake index abc1234..def5678 100644 --- a/lib/tasks/dev.rake +++ b/lib/tasks/dev.rake @@ -27,6 +27,6 @@ end task :console do - exec("ssh tps@sgmap_production1 -t 'source /etc/profile && cd current && bundle exec rails c production'") + exec("ssh tps@sgmap_prod...
Remove a warning in the console task Passing the environment's name as a regular argument is deprecated and will be removed in the next Rails version. Please, use the -e option instead.
diff --git a/app/api/api/spam_domains_api.rb b/app/api/api/spam_domains_api.rb index abc1234..def5678 100644 --- a/app/api/api/spam_domains_api.rb +++ b/app/api/api/spam_domains_api.rb @@ -6,7 +6,8 @@ std_result SpamDomain.all.order(id: :desc), filter: FILTERS[:domains] end - get 'name/:name' do + # ...
Allow literal '.' in /api/v2/domains/name fixes #832
diff --git a/app/controllers/registration.rb b/app/controllers/registration.rb index abc1234..def5678 100644 --- a/app/controllers/registration.rb +++ b/app/controllers/registration.rb @@ -3,7 +3,7 @@ puts "*"*50 if user session[:user_id] = user.id - redirect "users/#{user.id}" + redirect "users/#{user...
Update login page to redirect to users profile tweets page
diff --git a/app/jobs/fetch_link_data_job.rb b/app/jobs/fetch_link_data_job.rb index abc1234..def5678 100644 --- a/app/jobs/fetch_link_data_job.rb +++ b/app/jobs/fetch_link_data_job.rb @@ -9,7 +9,7 @@ FetchLinkDataJob.set(wait: 1.minute). perform_later(post_id, url, retry_count+1) unless retry_count > 3 r...
Update wait time on LinkThumbnailer::Exceptions
diff --git a/db/migrate/20130910184823_create_index_on_builds_id_desc_and_repository_id_and_event_type.rb b/db/migrate/20130910184823_create_index_on_builds_id_desc_and_repository_id_and_event_type.rb index abc1234..def5678 100644 --- a/db/migrate/20130910184823_create_index_on_builds_id_desc_and_repository_id_and_even...
Disable ddl transaction for index added concurrently
diff --git a/app/models/concerns/runnable.rb b/app/models/concerns/runnable.rb index abc1234..def5678 100644 --- a/app/models/concerns/runnable.rb +++ b/app/models/concerns/runnable.rb @@ -28,7 +28,7 @@ end def can_rerun? - state.aborted? || status == :failure + state.completed? || state.aborted? end ...
Revert "restric the rerun for failure or aborted only" This reverts commit cd159fdf1e447191ccf11d80281c75700f8770c2.
diff --git a/spec/nanoc/regressions/gh_913_spec.rb b/spec/nanoc/regressions/gh_913_spec.rb index abc1234..def5678 100644 --- a/spec/nanoc/regressions/gh_913_spec.rb +++ b/spec/nanoc/regressions/gh_913_spec.rb @@ -0,0 +1,24 @@+describe 'GH-891', site: true, stdio: true do + before do + File.write('content/hello.html...
Add regression spec for GH-913
diff --git a/email_format_validator.gemspec b/email_format_validator.gemspec index abc1234..def5678 100644 --- a/email_format_validator.gemspec +++ b/email_format_validator.gemspec @@ -1,6 +1,5 @@ # -*- encoding: utf-8 -*- $:.push File.expand_path("../lib", __FILE__) -require "email_format_validator/version" Gem::S...
Delete module version from gemspec file
diff --git a/spec/build_process_spec.rb b/spec/build_process_spec.rb index abc1234..def5678 100644 --- a/spec/build_process_spec.rb +++ b/spec/build_process_spec.rb @@ -32,7 +32,7 @@ watcher = Juici::Watcher.instance.start build = Juici::Build.new(parent: "test project", environment: {},...
Make failed build spec saner
diff --git a/spec/defile/spec_helper.rb b/spec/defile/spec_helper.rb index abc1234..def5678 100644 --- a/spec/defile/spec_helper.rb +++ b/spec/defile/spec_helper.rb @@ -2,16 +2,10 @@ require "defile" require "defile/backend_examples" -tmp_path = File.expand_path("tmp", Dir.pwd) +tmp_path = Dir.mktmpdir -if File.ex...
Use tmpdir instead of ./tmp
diff --git a/spec/features/main_spec.rb b/spec/features/main_spec.rb index abc1234..def5678 100644 --- a/spec/features/main_spec.rb +++ b/spec/features/main_spec.rb @@ -1,11 +1,21 @@ # frozen_string_literal: true describe 'main process', type: :feature, js: true do + before do + FakeS3Server.restart + s3 = Aws:...
Modify feature spec to use FakeS3Server
diff --git a/spec/models/origin_spec.rb b/spec/models/origin_spec.rb index abc1234..def5678 100644 --- a/spec/models/origin_spec.rb +++ b/spec/models/origin_spec.rb @@ -1,12 +1,6 @@ # -*- encoding : utf-8 -*- require File.expand_path(File.dirname(__FILE__) + '../../spec_helper') require 'uwdc' - -# AfricaFocus - Hyen...
Remove UWDC sample items from Origin specs
diff --git a/spec/subtime/timer_spec.rb b/spec/subtime/timer_spec.rb index abc1234..def5678 100644 --- a/spec/subtime/timer_spec.rb +++ b/spec/subtime/timer_spec.rb @@ -3,6 +3,10 @@ require 'kernel/kernel' describe Timer do + + before do + $stdout = StringIO.new + end let(:timer_output) { double('timer_out...
Add override for $stdout to make rspec output pretty
diff --git a/test/models/concerns/storied_test.rb b/test/models/concerns/storied_test.rb index abc1234..def5678 100644 --- a/test/models/concerns/storied_test.rb +++ b/test/models/concerns/storied_test.rb @@ -0,0 +1,21 @@+require 'test_helper' +require 'active_record' + +describe Storied do + + class StoriedTestModel ...
Add basic test for concern
diff --git a/kartograph.gemspec b/kartograph.gemspec index abc1234..def5678 100644 --- a/kartograph.gemspec +++ b/kartograph.gemspec @@ -19,7 +19,7 @@ spec.require_paths = ["lib"] spec.add_development_dependency "bundler", "~> 1.6" - spec.add_development_dependency "rake", '< 11.0' - spec.add_development_depen...
Update rake and rspec for CVE-2020-8130
diff --git a/app/controllers/answers_controller.rb b/app/controllers/answers_controller.rb index abc1234..def5678 100644 --- a/app/controllers/answers_controller.rb +++ b/app/controllers/answers_controller.rb @@ -13,6 +13,12 @@ def show @question = Question.find(params[:question_id]) + end + + def edit + ...
Add edit action for answers
diff --git a/app/controllers/auth/remote_header.rb b/app/controllers/auth/remote_header.rb index abc1234..def5678 100644 --- a/app/controllers/auth/remote_header.rb +++ b/app/controllers/auth/remote_header.rb @@ -4,6 +4,13 @@ # Fetches the user from the REMOTE_USER header set by the FreeIPA module of # the web ser...
Make remote header handling more flexible
diff --git a/app/controllers/uploads_controller.rb b/app/controllers/uploads_controller.rb index abc1234..def5678 100644 --- a/app/controllers/uploads_controller.rb +++ b/app/controllers/uploads_controller.rb @@ -1,4 +1,7 @@ class UploadsController < ApplicationController + skip_before_filter :authenticate_user!, :rej...
Allow non authenticated access to avatars
diff --git a/app/models/invoice_addon_line_item.rb b/app/models/invoice_addon_line_item.rb index abc1234..def5678 100644 --- a/app/models/invoice_addon_line_item.rb +++ b/app/models/invoice_addon_line_item.rb @@ -2,9 +2,10 @@ belongs_to :invoice belongs_to :package_addon_type - validates_presence_of :invoice - ...
Fix validations on invoice line items
diff --git a/lib/ch05/eliza1.rb b/lib/ch05/eliza1.rb index abc1234..def5678 100644 --- a/lib/ch05/eliza1.rb +++ b/lib/ch05/eliza1.rb @@ -0,0 +1,90 @@+require 'pat5' + +module Enumerable + def some? + self.each do |v| + result = yield v + return result if result + end + nil + end +end + +class Array...
Add simple implementation of Eliza
diff --git a/lib/multibinder.rb b/lib/multibinder.rb index abc1234..def5678 100644 --- a/lib/multibinder.rb +++ b/lib/multibinder.rb @@ -2,7 +2,7 @@ require 'json' module MultiBinder - def self.bind(address, port) + def self.bind(address, port, options={}) abort 'MULTIBINDER_SOCK environment variable must be ...
Allow overriding bind options in client library.
diff --git a/lib/neptune/api.rb b/lib/neptune/api.rb index abc1234..def5678 100644 --- a/lib/neptune/api.rb +++ b/lib/neptune/api.rb @@ -8,21 +8,11 @@ module Neptune module Api - NAMES = { - consumer_metadata: ConsumerMetadata, - fetch: Fetch, - metadata: Metadata, - offset: Offset, - o...
Refactor Api registration to be more similar to Compression registration
diff --git a/lib/source_code.rb b/lib/source_code.rb index abc1234..def5678 100644 --- a/lib/source_code.rb +++ b/lib/source_code.rb @@ -1,6 +1,6 @@-require "source_code/method" -require "source_code/monkey_patch" -require "source_code/version" +require_relative "source_code/method" +require_relative "source_code/monke...
Fix how these are required.
diff --git a/lib/bike.rb b/lib/bike.rb index abc1234..def5678 100644 --- a/lib/bike.rb +++ b/lib/bike.rb @@ -1,6 +1,4 @@ class Bike - attr_reader :color - def initialize(color) @color = color end @@ -8,4 +6,10 @@ def is_cool? color == "red" end + + # This is the same as: + # attr_reader :color +...
Make color method more explicit There was some confusion about where the color method was coming from
diff --git a/resque-multi-job-forks.gemspec b/resque-multi-job-forks.gemspec index abc1234..def5678 100644 --- a/resque-multi-job-forks.gemspec +++ b/resque-multi-job-forks.gemspec @@ -11,7 +11,7 @@ s.description = "When your resque jobs are frequent and fast, the overhead of forking and running your after_fork might...
Allow Resque 2.3 and 2.4
diff --git a/db/migrate/20131118115555_add_customer_number.rb b/db/migrate/20131118115555_add_customer_number.rb index abc1234..def5678 100644 --- a/db/migrate/20131118115555_add_customer_number.rb +++ b/db/migrate/20131118115555_add_customer_number.rb @@ -20,9 +20,10 @@ customer = Customer.where(source_id_name =...
Fix customer with not-existing customer
diff --git a/spec/features/article_viewer_spec.rb b/spec/features/article_viewer_spec.rb index abc1234..def5678 100644 --- a/spec/features/article_viewer_spec.rb +++ b/spec/features/article_viewer_spec.rb @@ -0,0 +1,25 @@+# frozen_string_literal: true + +require 'rails_helper' + +describe 'Article Viewer', type: :featu...
Add simple browser test of ArticleViewer with WhoColor data
diff --git a/spec/features/votes_features_spec.rb b/spec/features/votes_features_spec.rb index abc1234..def5678 100644 --- a/spec/features/votes_features_spec.rb +++ b/spec/features/votes_features_spec.rb @@ -0,0 +1,54 @@+require 'spec_helper' + +describe "VoteFeatures" do + before(:all) do + @idea = create(:idea) ...
Add some (breaking) Vote feature specs Create some feature specs for testing voting functionality. Currently, tests break for one reason or another when all four are enabled. One issue is that these specs expect to be executed in a particulr order, which they shouldn't be so they'll have to be adjusted. Additionally, ...
diff --git a/spec/lita/handlers/ascii_art_spec.rb b/spec/lita/handlers/ascii_art_spec.rb index abc1234..def5678 100644 --- a/spec/lita/handlers/ascii_art_spec.rb +++ b/spec/lita/handlers/ascii_art_spec.rb @@ -1,12 +1,25 @@ require "spec_helper" describe Lita::Handlers::AsciiArt, lita_handler: true do - it { routes_...
spec: Test Slack and HipChat formatting
diff --git a/spec/models/batch_update_job_spec.rb b/spec/models/batch_update_job_spec.rb index abc1234..def5678 100644 --- a/spec/models/batch_update_job_spec.rb +++ b/spec/models/batch_update_job_spec.rb @@ -0,0 +1,42 @@+require 'spec_helper' + +describe BatchUpdateJob do + before(:all) do + GenericFile.any_instan...
Add specs for new BatchUpdateJob
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -4,6 +4,13 @@ # # Copyright (c) 2015 The Authors, All Rights Reserved. -service node[:quickservice][:service] do - action node[:quickservice][:action] +services = [node[:quickservi...
Support multiple services and actions.