diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/models/menu.rb b/app/models/menu.rb index abc1234..def5678 100644 --- a/app/models/menu.rb +++ b/app/models/menu.rb @@ -2,7 +2,7 @@ has_many :links, class_name: 'MenuLink' def self.links_for_menu_cached(menu_name) - Rails.cache.fetch(Menu.where(name: menu_name).last.cache_key, expires_in: 24....
Remove unnecessary call to cache_key
diff --git a/lib/sprockets/es6.rb b/lib/sprockets/es6.rb index abc1234..def5678 100644 --- a/lib/sprockets/es6.rb +++ b/lib/sprockets/es6.rb @@ -33,7 +33,7 @@ end append_path ES6to5::Source.root - register_mime_type 'text/ecmascript-6', extensions: ['.es6'], charset: EncodingUtils::DETECT_UNICODE + register_mi...
Switch to new charset detector shorthand
diff --git a/lib/appsignal/integrations/rails.rb b/lib/appsignal/integrations/rails.rb index abc1234..def5678 100644 --- a/lib/appsignal/integrations/rails.rb +++ b/lib/appsignal/integrations/rails.rb @@ -22,7 +22,7 @@ # Load config Appsignal.config = Appsignal::Config.new( Rails.root,...
Set the app environment using the APPSIGNAL_APP_ENV env var
diff --git a/lib/benchmark/memory/measurement.rb b/lib/benchmark/memory/measurement.rb index abc1234..def5678 100644 --- a/lib/benchmark/memory/measurement.rb +++ b/lib/benchmark/memory/measurement.rb @@ -1,3 +1,4 @@+require "forwardable" require "benchmark/memory/measurement/metric" module Benchmark
Add forgotten require of Forwardable
diff --git a/spec/support/delete_button.rb b/spec/support/delete_button.rb index abc1234..def5678 100644 --- a/spec/support/delete_button.rb +++ b/spec/support/delete_button.rb @@ -5,6 +5,6 @@ button = find('div.ui.button', text: text) button.click expect(button).to have_css('.menu.visible:not(.animating)...
Fix delete button clicker in Capybara tests After ausaccessfed/aaf-lipstick#14 these tests were expecting the old (incorrect) 'Confirm Delete' button text which is no longer present. Fixes test failures after upgrading the lipstick library.
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -5,7 +5,7 @@ acts_as_authentic do |c| c.login_field = 'email' - c.crypto_provider = Authlogic::CryptoProviders::Sha512 + #c.crypto_provider = Authlogic::CryptoProviders:...
Disable Sha512 authlogic crypto provider
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -2,4 +2,27 @@ # Remember to create a migration! has_many :rounds has_many :guesses, through: :rounds + + validates :email, presence: true, uniqueness: true end + +def passwor...
Create reader and writer password methods, and add authentication method with some validations
diff --git a/lib/tasks/users.rake b/lib/tasks/users.rake index abc1234..def5678 100644 --- a/lib/tasks/users.rake +++ b/lib/tasks/users.rake @@ -0,0 +1,20 @@+namespace :users do + namespace :admin do + def privileges(state) + raise unless ENV['email'] + u = User.find_by_email!(ENV['email']) + u.is_ad...
Add Rake task to grant and remove Admin privileges
diff --git a/lib/formtastic/inputs/file_input.rb b/lib/formtastic/inputs/file_input.rb index abc1234..def5678 100644 --- a/lib/formtastic/inputs/file_input.rb +++ b/lib/formtastic/inputs/file_input.rb @@ -13,7 +13,7 @@ # # <%= semantic_form_for(@user, :html => { :multipart => true }) do |f| %> # <%=...
Fix example code for FileInput Closes GH-635
diff --git a/lib/onebox/engine/youtube_onebox.rb b/lib/onebox/engine/youtube_onebox.rb index abc1234..def5678 100644 --- a/lib/onebox/engine/youtube_onebox.rb +++ b/lib/onebox/engine/youtube_onebox.rb @@ -7,11 +7,16 @@ matches_regexp /^https?:\/\/(?:www\.)?(?:youtube\.com|youtu\.be)\/.+$/ def to_html - ...
Support for embedding YouTube links to particular times
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -1,15 +1,15 @@ # This file is used by Rack-based servers to start the application. -require 'rack-rewrite' - -DOMAIN = 'aqueousband.net' - -# Redirect to the www version of the domain in production -use Rack::Rewrite...
Disable rack rewrite for now
diff --git a/spec/functional/command/init_spec.rb b/spec/functional/command/init_spec.rb index abc1234..def5678 100644 --- a/spec/functional/command/init_spec.rb +++ b/spec/functional/command/init_spec.rb @@ -0,0 +1,29 @@+require File.expand_path('../../../spec_helper', __FILE__) + +module Pod + describe Command::Init...
Add a basic spec for the init subcommand.
diff --git a/spec/graphql/schema/addition_spec.rb b/spec/graphql/schema/addition_spec.rb index abc1234..def5678 100644 --- a/spec/graphql/schema/addition_spec.rb +++ b/spec/graphql/schema/addition_spec.rb @@ -0,0 +1,16 @@+# frozen_string_literal: true +require "spec_helper" + +describe GraphQL::Schema::Addition do + i...
Add test for addition fix
diff --git a/libraries/plugins.rb b/libraries/plugins.rb index abc1234..def5678 100644 --- a/libraries/plugins.rb +++ b/libraries/plugins.rb @@ -1,7 +1,7 @@ class Chef class Recipe def add_vim_git_plugin(repository_url) - node.set[:vim_config][:bundles][:git] = node[:vim_config][:bundles][:git].dup << re...
Use override instead of set node attribute
diff --git a/lib/versionator/detector/drupal6.rb b/lib/versionator/detector/drupal6.rb index abc1234..def5678 100644 --- a/lib/versionator/detector/drupal6.rb +++ b/lib/versionator/detector/drupal6.rb @@ -24,8 +24,6 @@ !is_openatrium? && installed_version.major < 7 if super end - private - ...
Fix code style in Drupal6 detector
diff --git a/spec/support/isolated_environment.rb b/spec/support/isolated_environment.rb index abc1234..def5678 100644 --- a/spec/support/isolated_environment.rb +++ b/spec/support/isolated_environment.rb @@ -7,6 +7,10 @@ around do |example| Dir.mktmpdir do |tmpdir| original_home = ENV['HOME'] + + # ...
Fix the isolated environment spec on OS X The reason this spec was failing is that on OS X the temp directory is actually something like this: /var/folders/bg/8sxn6p0j5kv0j1z__3hwz5nm0000gn/T/ However, /var is not an actual folder, but a symlink to /private/var and that causes the check for root_level in ConfigLoade...
diff --git a/lib/salesforce_bulk/query_result_collection.rb b/lib/salesforce_bulk/query_result_collection.rb index abc1234..def5678 100644 --- a/lib/salesforce_bulk/query_result_collection.rb +++ b/lib/salesforce_bulk/query_result_collection.rb @@ -13,7 +13,7 @@ @batch_id = batch_id @result_id = result_id ...
Update to pass new assertion where if no result_id index was found we use a default index value of 0.
diff --git a/lib/vagrant-cachier/cap/linux/composer_path.rb b/lib/vagrant-cachier/cap/linux/composer_path.rb index abc1234..def5678 100644 --- a/lib/vagrant-cachier/cap/linux/composer_path.rb +++ b/lib/vagrant-cachier/cap/linux/composer_path.rb @@ -7,8 +7,11 @@ composer_path = nil machine.commu...
Resolve $HOME even if VM spits bogus new lines Fixes issue #122
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -11,6 +11,7 @@ minute '30' user 'root' command "#{node['aide']['binary']} #{node['aide']['extra_parameters']} --check -V3" + mailto node['aide']['cron_mailto'] if node['aide']...
Use cron_mailto attribute for cron jobs if set
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -8,7 +8,7 @@ # node['opsworks']['instance']['layers'].each do |layer| - if Regexp.new(node['opsworks-mongodb']['replset_pattern']).match(layer) + if Regexp.new(node['opsworks-mongod...
Refactor to new pattern name.
diff --git a/spec/features/search_spec.rb b/spec/features/search_spec.rb index abc1234..def5678 100644 --- a/spec/features/search_spec.rb +++ b/spec/features/search_spec.rb @@ -1,8 +1,13 @@ require 'spec_helper' +<<<<<<< HEAD describe 'searching', :type => :feature do before { GenericFile.destroy_all } let!(:f...
Set title as a multivalued field
diff --git a/spec/models/resource_spec.rb b/spec/models/resource_spec.rb index abc1234..def5678 100644 --- a/spec/models/resource_spec.rb +++ b/spec/models/resource_spec.rb @@ -1,4 +1,31 @@ require 'rails_helper' describe Resource, type: :model do + describe '#upload' do + let(:blog) { create :blog } + let(:r...
Add tests for Resource upload behavior
diff --git a/core/app/models/spree/promotion_chooser.rb b/core/app/models/spree/promotion_chooser.rb index abc1234..def5678 100644 --- a/core/app/models/spree/promotion_chooser.rb +++ b/core/app/models/spree/promotion_chooser.rb @@ -12,7 +12,7 @@ if best_promotion_adjustment @adjustments.select(&:eligibl...
Update updated_at timestamp on eligibility change The _adjustment jbuilder view caches based on the adjustment updated_at timestamp. Currently if a promotion is made ineligible by this class and a previous call to api/orders#show has been made, a subsequent calls will send back the cached view.
diff --git a/test/sepa/banks/nordea/nordea_renew_cert_application_request_test.rb b/test/sepa/banks/nordea/nordea_renew_cert_application_request_test.rb index abc1234..def5678 100644 --- a/test/sepa/banks/nordea/nordea_renew_cert_application_request_test.rb +++ b/test/sepa/banks/nordea/nordea_renew_cert_application_req...
Test that timestamp is set correctly
diff --git a/lib/badgeoverflow/core/models/badges/moderation/citizen_patrol.rb b/lib/badgeoverflow/core/models/badges/moderation/citizen_patrol.rb index abc1234..def5678 100644 --- a/lib/badgeoverflow/core/models/badges/moderation/citizen_patrol.rb +++ b/lib/badgeoverflow/core/models/badges/moderation/citizen_patrol.rb...
Comment out Marshal badge for time being (clashing with existing Ruby class)
diff --git a/test/helpers/sitemap_helper_test.rb b/test/helpers/sitemap_helper_test.rb index abc1234..def5678 100644 --- a/test/helpers/sitemap_helper_test.rb +++ b/test/helpers/sitemap_helper_test.rb @@ -0,0 +1,12 @@+require 'test_helper' + +# +# == SitemapHelper Test +# +class SitemapHelperTest < ActionView::TestCase...
Add test file for SitemapHelper
diff --git a/Framezilla.podspec b/Framezilla.podspec index abc1234..def5678 100644 --- a/Framezilla.podspec +++ b/Framezilla.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |spec| spec.name = "Framezilla" - spec.version = "2.0.0" + spec.version = "2.1.0" spec.summary = "Comfortab...
Update pod version -> 2.1.0
diff --git a/tools/test_common.rb b/tools/test_common.rb index abc1234..def5678 100644 --- a/tools/test_common.rb +++ b/tools/test_common.rb @@ -1,3 +1,5 @@+# frozen_string_literal: true + if ENV["BUILDKITE"] require "minitest/reporters" require "fileutils"
Fix rubocop offence for `Style/FrozenStringLiteralComment` ``` % be rubocop -a Inspecting 2777 files .............................................................................................................................................................................................................................
diff --git a/lib/active_utils/common/utils.rb b/lib/active_utils/common/utils.rb index abc1234..def5678 100644 --- a/lib/active_utils/common/utils.rb +++ b/lib/active_utils/common/utils.rb @@ -1,4 +1,4 @@-require 'active_support/secure_random' +require 'securerandom' module ActiveMerchant #:nodoc: module Utils #:...
Use ruby core securerandom as it's removed from latest activesupport
diff --git a/lib/exercism/use_cases/notify.rb b/lib/exercism/use_cases/notify.rb index abc1234..def5678 100644 --- a/lib/exercism/use_cases/notify.rb +++ b/lib/exercism/use_cases/notify.rb @@ -23,10 +23,13 @@ user: to, from: from.username, regarding: about, - link: send("#{about}_link".to_sym) ...
Prepend `/` to notification links. Notification links were broken before, giving the reletive href. Now they'll work regardless of where the user is at the time of the clicky- click.
diff --git a/boost_info.gemspec b/boost_info.gemspec index abc1234..def5678 100644 --- a/boost_info.gemspec +++ b/boost_info.gemspec @@ -17,6 +17,6 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~> 1.8" + sp...
Downgrade bundler for Travis CI
diff --git a/lib/foot_stats/error_response.rb b/lib/foot_stats/error_response.rb index abc1234..def5678 100644 --- a/lib/foot_stats/error_response.rb +++ b/lib/foot_stats/error_response.rb @@ -31,5 +31,15 @@ def each(&block) [] end + + # <b>Respect the contract with the Resource Instance and Resource...
Add response convenient method to Error Response. Useful for store or logging the error response.
diff --git a/Casks/reflector.rb b/Casks/reflector.rb index abc1234..def5678 100644 --- a/Casks/reflector.rb +++ b/Casks/reflector.rb @@ -1,6 +1,6 @@ cask :v1 => 'reflector' do - version '2.1.0.0' - sha256 'eda358fec24270e823bd46441ab39e434a616752cd0d5f02456871ee1f870af9' + version '2.2.0' + sha256 '2a35b89d7b5181c2...
Upgrade Reflector.app to v 2.2.0
diff --git a/lib/futurocube/verify_command.rb b/lib/futurocube/verify_command.rb index abc1234..def5678 100644 --- a/lib/futurocube/verify_command.rb +++ b/lib/futurocube/verify_command.rb @@ -9,8 +9,8 @@ def exec(file) ResourceFile.open(file) do |rf| expected = rf.header.checksum - with_prog...
Verify wasn't passing the hash back after refactoring with_progress
diff --git a/app/controllers/solidus_subscriptions/api/v1/line_items_controller.rb b/app/controllers/solidus_subscriptions/api/v1/line_items_controller.rb index abc1234..def5678 100644 --- a/app/controllers/solidus_subscriptions/api/v1/line_items_controller.rb +++ b/app/controllers/solidus_subscriptions/api/v1/line_ite...
Use configurable strong params list Instead of hard-coding these, use the global list in the config, minus the subscribable_id, since we don't wish for users to be able to completely swap out the basis of their subscription.
diff --git a/lib/money-rails/mongoid/three.rb b/lib/money-rails/mongoid/three.rb index abc1234..def5678 100644 --- a/lib/money-rails/mongoid/three.rb +++ b/lib/money-rails/mongoid/three.rb @@ -28,7 +28,7 @@ when object.is_a?(Money) then object.mongoize when object.is_a?(Hash) then object.symbolize...
Fix syntax error for mongoid extension
diff --git a/lib/phare/checks/ruby_rubocop.rb b/lib/phare/checks/ruby_rubocop.rb index abc1234..def5678 100644 --- a/lib/phare/checks/ruby_rubocop.rb +++ b/lib/phare/checks/ruby_rubocop.rb @@ -4,7 +4,7 @@ attr_reader :status def initialize - @command = 'bundle exec rubocop' + @command = 'ru...
Remove bundle exec from Rubocop check
diff --git a/library/rbconfig/unicode_spec.rb b/library/rbconfig/unicode_spec.rb index abc1234..def5678 100644 --- a/library/rbconfig/unicode_spec.rb +++ b/library/rbconfig/unicode_spec.rb @@ -0,0 +1,34 @@+require_relative '../../spec_helper' +require 'rbconfig' + +describe "RbConfig::CONFIG['UNICODE_VERSION']" do + r...
Add a spec for RbConfig::CONFIG['UNICODE_VERSION']
diff --git a/messagemedia.gemspec b/messagemedia.gemspec index abc1234..def5678 100644 --- a/messagemedia.gemspec +++ b/messagemedia.gemspec @@ -10,7 +10,7 @@ spec.name = "messagemedia" spec.version = Messagemedia::VERSION spec.authors = ["Chris Hawkins", "Tristan Penman"] - spec.email ...
Update author email address in gemspec file.
diff --git a/simple_webmon.gemspec b/simple_webmon.gemspec index abc1234..def5678 100644 --- a/simple_webmon.gemspec +++ b/simple_webmon.gemspec @@ -8,8 +8,8 @@ spec.version = SimpleWebmon::VERSION spec.authors = ["Mike Admire"] spec.email = ["mike@mikeadmire.com"] - spec.description = %q...
Add description and summary to gemspec.
diff --git a/files/lib/compat_resource/gemspec.rb b/files/lib/compat_resource/gemspec.rb index abc1234..def5678 100644 --- a/files/lib/compat_resource/gemspec.rb +++ b/files/lib/compat_resource/gemspec.rb @@ -28,6 +28,6 @@ s.executables = [] s.require_path = "files/lib" s.files = %w(LICENSE README.md CHA...
Remove absolute paths from the manifest
diff --git a/fluent-plugin-gcloud-storage.gemspec b/fluent-plugin-gcloud-storage.gemspec index abc1234..def5678 100644 --- a/fluent-plugin-gcloud-storage.gemspec +++ b/fluent-plugin-gcloud-storage.gemspec @@ -18,6 +18,7 @@ spec.add_development_dependency 'bundler', '~> 1.10' spec.add_development_dependency 'rake',...
Add test-unit as development dependency
diff --git a/test/integration/configuration/serverspec/localhost/setup_spec.rb b/test/integration/configuration/serverspec/localhost/setup_spec.rb index abc1234..def5678 100644 --- a/test/integration/configuration/serverspec/localhost/setup_spec.rb +++ b/test/integration/configuration/serverspec/localhost/setup_spec.rb...
Remove unnecessary integration test case
diff --git a/plugins/commands/destroy/command.rb b/plugins/commands/destroy/command.rb index abc1234..def5678 100644 --- a/plugins/commands/destroy/command.rb +++ b/plugins/commands/destroy/command.rb @@ -18,6 +18,11 @@ o.on("-f", "--force", "Destroy without confirmation.") do |f| options[:force]...
Introduce parallel destroy for certain providers This commit introduces parallel destroy using the batch action class for the destroy command.
diff --git a/WebKitPlus.podspec b/WebKitPlus.podspec index abc1234..def5678 100644 --- a/WebKitPlus.podspec +++ b/WebKitPlus.podspec @@ -11,7 +11,7 @@ s.homepage = "https://github.com/yashigani/WebKitPlus" s.license = { :type => "MIT", :file => "LICENSE" } - s.ios.deployment_target = "8.0" + s.ios.depl...
Update iOS deployment target in podspec
diff --git a/plugins/kernel_v1/config/vagrant.rb b/plugins/kernel_v1/config/vagrant.rb index abc1234..def5678 100644 --- a/plugins/kernel_v1/config/vagrant.rb +++ b/plugins/kernel_v1/config/vagrant.rb @@ -11,10 +11,20 @@ @host = UNSET_VALUE end + def finalize! + @dotfile_name = nil ...
Add a warning if dotfile_name is used in V1
diff --git a/lib/tasks/deployment/20181031104615_remove_path_from_archived_procedures.rake b/lib/tasks/deployment/20181031104615_remove_path_from_archived_procedures.rake index abc1234..def5678 100644 --- a/lib/tasks/deployment/20181031104615_remove_path_from_archived_procedures.rake +++ b/lib/tasks/deployment/20181031...
Remove path from archived procedures
diff --git a/test/support/appearance_assertion.rb b/test/support/appearance_assertion.rb index abc1234..def5678 100644 --- a/test/support/appearance_assertion.rb +++ b/test/support/appearance_assertion.rb @@ -5,6 +5,7 @@ module MiniTest module Assertions def assert_same_image(expected_image_path, output_image, ...
Test: Add envrionment variable to skip checking difference
diff --git a/spec/models/jar.rb b/spec/models/jar.rb index abc1234..def5678 100644 --- a/spec/models/jar.rb +++ b/spec/models/jar.rb @@ -1,5 +1,5 @@ class Jar include Mongoid::Document - identity type: Integer + identity :type => Integer has_many :cookies, :class_name => "Cookie" end
Fix 1.8.x syntax error in spec models
diff --git a/spec/roomy_spec.rb b/spec/roomy_spec.rb index abc1234..def5678 100644 --- a/spec/roomy_spec.rb +++ b/spec/roomy_spec.rb @@ -5,7 +5,7 @@ expect(Roomy::VERSION).not_to be nil end - it 'does something useful' do + xit 'does something useful' do expect(false).to eq(true) end end
Mark the failing (boilerplate) test as pending
diff --git a/spec/pages/manual_page_spec.rb b/spec/pages/manual_page_spec.rb index abc1234..def5678 100644 --- a/spec/pages/manual_page_spec.rb +++ b/spec/pages/manual_page_spec.rb @@ -32,7 +32,8 @@ source/manual/howto-merge-a-pull-request-from-an-external-contributor.html.md ]) it "doesn't use H1 tag...
Add failing test hint for unnecessary H1 Although the tests check for the presence of a H1 (#) on the page, the presence of a comment in a code block also triggers a failure. This isn't easily fixable without a markdown AST. This PR adds a hint as to a possible cause, to avoid confusion when this edge case occurs an...
diff --git a/spec/features/user_feature.spec.rb b/spec/features/user_feature.spec.rb index abc1234..def5678 100644 --- a/spec/features/user_feature.spec.rb +++ b/spec/features/user_feature.spec.rb @@ -0,0 +1,18 @@+require 'rails_helper' + +describe 'feature testing', :type => :feature do + + feature 'the home page' do...
Add feature testing for homepage
diff --git a/src/helpers/loader.rb b/src/helpers/loader.rb index abc1234..def5678 100644 --- a/src/helpers/loader.rb +++ b/src/helpers/loader.rb @@ -13,6 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. require 'bundler' + Bundler.require(:default) Bund...
Remove already loaded gems by Bundler
diff --git a/resources/files/irbrc_predefiner.rb b/resources/files/irbrc_predefiner.rb index abc1234..def5678 100644 --- a/resources/files/irbrc_predefiner.rb +++ b/resources/files/irbrc_predefiner.rb @@ -19,9 +19,3 @@ File.write(history_file, hist) end end - -# Fix IRB input text encoding when ruby is running ...
Remove workaround for UTF-8 issue in Reline This has been fixed in commit https://github.com/ruby/ruby/commit/f8ea2860b0cac1aec79978e6c44168802958e8af
diff --git a/test/functional/page_controller_test.rb b/test/functional/page_controller_test.rb index abc1234..def5678 100644 --- a/test/functional/page_controller_test.rb +++ b/test/functional/page_controller_test.rb @@ -3,13 +3,13 @@ class PageControllerTest < ActionController::TestCase context 'on GET to :index' d...
Fix broken PageController tests by using the new active_project factory.
diff --git a/test/helpers/application_helper_test.rb b/test/helpers/application_helper_test.rb index abc1234..def5678 100644 --- a/test/helpers/application_helper_test.rb +++ b/test/helpers/application_helper_test.rb @@ -0,0 +1,8 @@+require 'test_helper' + +class ApplicationHelperTest < ActionView::TestCase + test "fu...
Create the unit test of application helper
diff --git a/lib/awestruct/extensions/atomizer.rb b/lib/awestruct/extensions/atomizer.rb index abc1234..def5678 100644 --- a/lib/awestruct/extensions/atomizer.rb +++ b/lib/awestruct/extensions/atomizer.rb @@ -2,8 +2,8 @@ module Extensions class Atomizer - def initialize(entries_name, output_path, opts={})...
Allow to specify the entries directly as an Array instead of reading them from site
diff --git a/test/unit/models/location_error_test.rb b/test/unit/models/location_error_test.rb index abc1234..def5678 100644 --- a/test/unit/models/location_error_test.rb +++ b/test/unit/models/location_error_test.rb @@ -1,7 +1,7 @@ class LocationErrorTest < ActiveSupport::TestCase context '#initialize' do shou...
Fix outstanding UselessAssignment lint offenses
diff --git a/Casks/revisions-beta.rb b/Casks/revisions-beta.rb index abc1234..def5678 100644 --- a/Casks/revisions-beta.rb +++ b/Casks/revisions-beta.rb @@ -0,0 +1,11 @@+cask :v1 => 'revisions-beta' do + version '2.1-r928' + sha256 'fb91a2dd876becd034445813bac037cf99cb4f3691f2d140c6425fe52427789f' + + url "https://r...
Add Revisions beta version 2.1 This commit adds a new cask for the Revisions app. I haven't included a comment to say where the download link was obtained as it is from a public page on the vendor site: https://www.revisionsapp.com/releases
diff --git a/db/migrate/20151126050103_add_gateway_profile_ids_to_spree_konbinis.rb b/db/migrate/20151126050103_add_gateway_profile_ids_to_spree_konbinis.rb index abc1234..def5678 100644 --- a/db/migrate/20151126050103_add_gateway_profile_ids_to_spree_konbinis.rb +++ b/db/migrate/20151126050103_add_gateway_profile_ids_...
Add missing columns to Spree::Konbini We're not using these but they are expected on credit cards, so better to have them.
diff --git a/lib/facter/rabbitmq_erlang_cookie.rb b/lib/facter/rabbitmq_erlang_cookie.rb index abc1234..def5678 100644 --- a/lib/facter/rabbitmq_erlang_cookie.rb +++ b/lib/facter/rabbitmq_erlang_cookie.rb @@ -6,9 +6,11 @@ Facter.add(:rabbitmq_erlang_cookie) do confine :osfamily => %w[Debian RedHat Suse] - case Fa...
Fix the wrapping around this fact. Embarrassing this fact was completely broken, but because the spec tests fake out the results of the fact it wasn't being picked up.
diff --git a/spec/tic_tac_toe/view/board_spec.rb b/spec/tic_tac_toe/view/board_spec.rb index abc1234..def5678 100644 --- a/spec/tic_tac_toe/view/board_spec.rb +++ b/spec/tic_tac_toe/view/board_spec.rb @@ -0,0 +1,18 @@+require 'spec_helper' +require 'tic_tac_toe/view/board' + +describe TicTacToe::View::Board do + + it ...
Add a board view test for the start and end logic of rows
diff --git a/spec/unit/rom/session/state_spec.rb b/spec/unit/rom/session/state_spec.rb index abc1234..def5678 100644 --- a/spec/unit/rom/session/state_spec.rb +++ b/spec/unit/rom/session/state_spec.rb @@ -0,0 +1,77 @@+require 'spec_helper' + +describe Session::State do + fake(:object) + fake(:mapper) + fake(:relatio...
Add specs for state predicate methods
diff --git a/lib/project/rumo_text/type_helper.rb b/lib/project/rumo_text/type_helper.rb index abc1234..def5678 100644 --- a/lib/project/rumo_text/type_helper.rb +++ b/lib/project/rumo_text/type_helper.rb @@ -19,8 +19,8 @@ end def size - size_ptr = Pointer.new('I') - align_ptr = Pointer.new('I') + ...
Fix to be able to use RubyMotion 3.0
diff --git a/lib/rails_database_yml/capistrano.rb b/lib/rails_database_yml/capistrano.rb index abc1234..def5678 100644 --- a/lib/rails_database_yml/capistrano.rb +++ b/lib/rails_database_yml/capistrano.rb @@ -26,5 +26,5 @@ end end after "deploy:setup", "rails_database:setup" - after "deploy:update_code", "ra...
Create the symlink before "deploy:finalize_update". Fix a regression with Rails 3.1 applications. Precompiling the asset pipeline needs a correct config/database.yml file.
diff --git a/lib/rmuh/serverstats/operationarrowhead.rb b/lib/rmuh/serverstats/operationarrowhead.rb index abc1234..def5678 100644 --- a/lib/rmuh/serverstats/operationarrowhead.rb +++ b/lib/rmuh/serverstats/operationarrowhead.rb @@ -0,0 +1,16 @@+# -*- coding: UTF-8 -*- + +require 'rmuh/serverstats/base' + +module RMuh ...
Add new OperationArrowhead server stats Really, this just extends the Base class with some method_missing magic.
diff --git a/lib/thinreports/core/shape/basic/format.rb b/lib/thinreports/core/shape/basic/format.rb index abc1234..def5678 100644 --- a/lib/thinreports/core/shape/basic/format.rb +++ b/lib/thinreports/core/shape/basic/format.rb @@ -10,6 +10,11 @@ config_reader :type, :id config_reader :style ...
Add some properties to all items - affect-bottom-margin - follow-stretch Co-authored-by: kosappi <1a72c3adb8cf451abd36cfcfa35039fbab5efb3b@misoca.jp> Co-authored-by: Katsuya HIDAKA <2f1e5d0fd7c5b5529f5d591c063df911b29bc9d1@gmail.com>
diff --git a/lib/blueberry_cms/liquid_tags/page_link.rb b/lib/blueberry_cms/liquid_tags/page_link.rb index abc1234..def5678 100644 --- a/lib/blueberry_cms/liquid_tags/page_link.rb +++ b/lib/blueberry_cms/liquid_tags/page_link.rb @@ -9,7 +9,9 @@ def render(context) page = Page.find(@options[:id]) - ...
Add CSS class to Page link drop
diff --git a/lib/redis/objects/connection_pool_proxy.rb b/lib/redis/objects/connection_pool_proxy.rb index abc1234..def5678 100644 --- a/lib/redis/objects/connection_pool_proxy.rb +++ b/lib/redis/objects/connection_pool_proxy.rb @@ -9,6 +9,7 @@ def method_missing(name, *args, &block) @pool.with { |x| x.s...
Fix ConnectionPoolProxy Ruby 3.0 compatibility Fix: https://github.com/nateware/redis-objects/pull/258
diff --git a/lib/rspec/json_matcher/abstract_matcher.rb b/lib/rspec/json_matcher/abstract_matcher.rb index abc1234..def5678 100644 --- a/lib/rspec/json_matcher/abstract_matcher.rb +++ b/lib/rspec/json_matcher/abstract_matcher.rb @@ -27,7 +27,7 @@ "be JSON" end - def failure_message_for_should + ...
Fix deprecation warnings: use new protocols for rspec 3
diff --git a/lib/ebay/types/product_sort_code.rb b/lib/ebay/types/product_sort_code.rb index abc1234..def5678 100644 --- a/lib/ebay/types/product_sort_code.rb +++ b/lib/ebay/types/product_sort_code.rb @@ -3,7 +3,6 @@ class ProductSortCode extend Enumerable extend Enumeration - PopularityAsc = 'Po...
Remove duplicate definition of PopularityAsc Which resulted in warnings displayed whenever the library is required. The reason it is appearing twice is that because it is defined twice in ebaySvc.xsd (schema) file and class generator doesn't check uniqueness of enumerable values. Perhaps eBay going to remove it from...
diff --git a/lib/loader/vertica/vertica_utils.rb b/lib/loader/vertica/vertica_utils.rb index abc1234..def5678 100644 --- a/lib/loader/vertica/vertica_utils.rb +++ b/lib/loader/vertica/vertica_utils.rb @@ -0,0 +1,61 @@+module Myreplicator + class VerticaUtils + class << self + # Example: get_grant({:db => "bidw...
Add GRANT utils to Myreplicator to use in dropping a table and then re-grant the permission on that table
diff --git a/lib/rrj/janus/responses/standard.rb b/lib/rrj/janus/responses/standard.rb index abc1234..def5678 100644 --- a/lib/rrj/janus/responses/standard.rb +++ b/lib/rrj/janus/responses/standard.rb @@ -11,9 +11,17 @@ data_id end + def session_id + request['session_id'] + e...
Add method for extracting session_id/handle_id
diff --git a/lib/suspect/file_tree/git/client.rb b/lib/suspect/file_tree/git/client.rb index abc1234..def5678 100644 --- a/lib/suspect/file_tree/git/client.rb +++ b/lib/suspect/file_tree/git/client.rb @@ -3,7 +3,7 @@ module Git class Client def modified_files - `git ls-files --modified` + ...
Add --full-name option to git ls-files command The option was added "just in case".
diff --git a/spec/controllers/info_boxes_controller_spec.rb b/spec/controllers/info_boxes_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/info_boxes_controller_spec.rb +++ b/spec/controllers/info_boxes_controller_spec.rb @@ -4,9 +4,6 @@ RSpec.describe InfoBoxesController, type: :controller do ...
Fix failing test that seem to require auth
diff --git a/spec/dummy/config/initializers/secret_token.rb b/spec/dummy/config/initializers/secret_token.rb index abc1234..def5678 100644 --- a/spec/dummy/config/initializers/secret_token.rb +++ b/spec/dummy/config/initializers/secret_token.rb @@ -0,0 +1,12 @@+# Be sure to restart your server when you modify this file...
Add secret token to dummy app
diff --git a/lib/gitlab/background_migration/migrate_build_stage_id_reference.rb b/lib/gitlab/background_migration/migrate_build_stage_id_reference.rb index abc1234..def5678 100644 --- a/lib/gitlab/background_migration/migrate_build_stage_id_reference.rb +++ b/lib/gitlab/background_migration/migrate_build_stage_id_refe...
Test if argument passed to a migration is present
diff --git a/app/cells/plugins/core/tree_cell.rb b/app/cells/plugins/core/tree_cell.rb index abc1234..def5678 100644 --- a/app/cells/plugins/core/tree_cell.rb +++ b/app/cells/plugins/core/tree_cell.rb @@ -20,9 +20,13 @@ end def metadata_values + values = [["-- Select an Option --", nil]] + ...
Add Default Nil Values for all Dropdowns
diff --git a/app/concerns/couriers/fusionable.rb b/app/concerns/couriers/fusionable.rb index abc1234..def5678 100644 --- a/app/concerns/couriers/fusionable.rb +++ b/app/concerns/couriers/fusionable.rb @@ -35,7 +35,6 @@ table.select("ROWID", "WHERE name='#{photo.key}'").map(&:values).map(&:first).map...
Remove sleep from Fusion Tables
diff --git a/app/controllers/claim_controller.rb b/app/controllers/claim_controller.rb index abc1234..def5678 100644 --- a/app/controllers/claim_controller.rb +++ b/app/controllers/claim_controller.rb @@ -4,7 +4,8 @@ def index if Mockr.unclaimed? && viewer.authenticated? - owner = User.create(:facebook_ui...
Standardize on a default name that doesn't depend on a Facebook cookie. Change-Id: Ie20a5957809fbf8ed56cf943e2fa1959634a2e9b Reviewed-on: https://gerrit.causes.com/5045 Reviewed-by: Chris Chan <711c73f64afdce07b7e38039a96d2224209e9a6c@causes.com> Tested-by: Chris Chan <711c73f64afdce07b7e38039a96d2224209e9a6c@causes.c...
diff --git a/app/controllers/dojos_controller.rb b/app/controllers/dojos_controller.rb index abc1234..def5678 100644 --- a/app/controllers/dojos_controller.rb +++ b/app/controllers/dojos_controller.rb @@ -6,8 +6,8 @@ url: dojo.url, name: dojo.name, order: dojo.order, - ...
Return prefecture name instead of region name
diff --git a/app/controllers/repos_controller.rb b/app/controllers/repos_controller.rb index abc1234..def5678 100644 --- a/app/controllers/repos_controller.rb +++ b/app/controllers/repos_controller.rb @@ -1,5 +1,5 @@ class ReposController < ApplicationController - # before_filter :fetch_email_address, only: [:index] +...
Revert "Don't fetch emails until migration has run" This reverts commit e073c655a694e13adb670961af12c8157a458577.
diff --git a/app/controllers/tests_controller.rb b/app/controllers/tests_controller.rb index abc1234..def5678 100644 --- a/app/controllers/tests_controller.rb +++ b/app/controllers/tests_controller.rb @@ -10,10 +10,7 @@ Rails.cache.clear DatabaseCleaner.strategy = :truncation DatabaseCleaner.clean -...
Use respond_with_json on tests controller
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -7,8 +7,10 @@ def show @user = User.find(params[:id]) + if current_user @connection = Connection....
Add check to see if user is signed in
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -6,7 +6,7 @@ def show @user = User.find(params[:id]) - @documents = @user.documents + @documents = @u...
Order documents in descending order
diff --git a/app/models/collaborator_importer.rb b/app/models/collaborator_importer.rb index abc1234..def5678 100644 --- a/app/models/collaborator_importer.rb +++ b/app/models/collaborator_importer.rb @@ -0,0 +1,101 @@+class CollaboratorImporter + ACCEPT_CONTENT_TYPE = 'text/plain' + LINE_FORMAT = /\A\d{4}\s+\d{4}\s+...
Add another not used file for tests
diff --git a/app/models/cost_calculation_type.rb b/app/models/cost_calculation_type.rb index abc1234..def5678 100644 --- a/app/models/cost_calculation_type.rb +++ b/app/models/cost_calculation_type.rb @@ -1,10 +1,5 @@ class CostCalculationType < ActiveRecord::Base - - # associations - has_many :policys - - #attr_a...
Remove association from lookup table
diff --git a/app/models/manual_with_documents.rb b/app/models/manual_with_documents.rb index abc1234..def5678 100644 --- a/app/models/manual_with_documents.rb +++ b/app/models/manual_with_documents.rb @@ -1,10 +1,10 @@ require "delegate" class ManualWithDocuments < SimpleDelegator - def initialize(document_builder,...
Use Ruby keyword args in ManualWithDocuments I think that using language features instead of custom code makes this easier to understand.
diff --git a/HTDelegateProxy.podspec b/HTDelegateProxy.podspec index abc1234..def5678 100644 --- a/HTDelegateProxy.podspec +++ b/HTDelegateProxy.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "HTDelegateProxy" - s.version = "0.0.1" + s.version = "0.0.2" s.summary = "A class that al...
Update podspec, change tag to 0.0.2
diff --git a/Library/Formula/neon.rb b/Library/Formula/neon.rb index abc1234..def5678 100644 --- a/Library/Formula/neon.rb +++ b/Library/Formula/neon.rb @@ -1,12 +1,15 @@ require 'brewkit' class Neon <Formula - @url='http://www.webdav.org/neon/neon-0.28.5.tar.gz' + @url='http://www.webdav.org/neon/neon-0.29.0.tar....
Bump Neon version and add --with-ssl
diff --git a/app/controllers/events_controller.rb b/app/controllers/events_controller.rb index abc1234..def5678 100644 --- a/app/controllers/events_controller.rb +++ b/app/controllers/events_controller.rb @@ -1,7 +1,12 @@ class EventsController < ApplicationController def index - @events = Event.includes(:event...
Make date select for event list work
diff --git a/app/controllers/groups_controller.rb b/app/controllers/groups_controller.rb index abc1234..def5678 100644 --- a/app/controllers/groups_controller.rb +++ b/app/controllers/groups_controller.rb @@ -2,10 +2,15 @@ def show if params[:id] @group = Group.find(params[:id]) - else current_group + ...
Handle unrecognised subdomains with a redirect to www
diff --git a/app/steps/medicaid/amounts_income.rb b/app/steps/medicaid/amounts_income.rb index abc1234..def5678 100644 --- a/app/steps/medicaid/amounts_income.rb +++ b/app/steps/medicaid/amounts_income.rb @@ -9,7 +9,7 @@ delegate( :employed_number_of_jobs, - :other_income_types, + :receives_unemp...
Use existing predicate method on Member object `receives_unemployment_income?` is defined in the member object, therefore we can use that to ask the question istead of inspecting the contents of the other_income_types column
diff --git a/app/models/idea.rb b/app/models/idea.rb index abc1234..def5678 100644 --- a/app/models/idea.rb +++ b/app/models/idea.rb @@ -25,6 +25,7 @@ vote.lock! self.lock! self.rating += vote.value + self.save! vote end @@ -32,6 +33,7 @@ vote.lock! self.lock! self.rating -= vot...
Add 'save!' methods to Idea rating counters Save the changes to the Idea's rating after it has been incremented or decremented.
diff --git a/app/models/task.rb b/app/models/task.rb index abc1234..def5678 100644 --- a/app/models/task.rb +++ b/app/models/task.rb @@ -30,9 +30,11 @@ delegate :name, :to => :assigned_user, :prefix => true, :allow_nil => true - scope :completed, lambda { |milestone_id| - where(:state => Task::COMPL...
Move the scope to a class method, since it is too long.
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -25,14 +25,13 @@ end def self.find_or_create_for_github_oauth(auth) - auth.info.image.gsub!("?","") where(github_uid: auth.uid).first_or_create do |user| user.git...
Revert "Remove trailing ? from Github avatar URL in the hopes that this fixes the seg" This reverts commit 6905de3def0696220adeccc108e98ebd357fdf03.
diff --git a/app/models/drop.rb b/app/models/drop.rb index abc1234..def5678 100644 --- a/app/models/drop.rb +++ b/app/models/drop.rb @@ -8,6 +8,12 @@ :storage => :s3, :s3_credentials => Proc.new{|a| a.instance.s3_credentials } validates_attachment_content_type :photo, conten...
Add method for converting coords to rgeo points
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -7,6 +7,11 @@ has_many :identities, dependent: :destroy has_many :memberships, dependent: :destroy has_many :units, through: :memberships + + # TODO: This needs a real impleme...
Add stub groups method to User
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -27,11 +27,11 @@ end def hours_spent - self.projects.map {|p| p.hours}.sum + self.projects.map {|p| p.hours }.compact.sum end def words_written - self.projects...
Fix bug with nil values
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,5 +1,7 @@ class User < ActiveRecord::Base # Remember to create a migration! + has_secure_password + has_many :messages has_many :sent_messages, foreign_key: "sender_id",...
Add has_secure_password to User model