diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/command_line/dash_upper_i_spec.rb b/command_line/dash_upper_i_spec.rb index abc1234..def5678 100644 --- a/command_line/dash_upper_i_spec.rb +++ b/command_line/dash_upper_i_spec.rb @@ -21,3 +21,20 @@ ruby_exe(@script, options: "-I not_exist/not_exist").lines[0].should == "#{Dir.pwd}/not_exist/not_exist\...
Add spec for -I with symlinks
diff --git a/app/controllers/api/search_controller.rb b/app/controllers/api/search_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/search_controller.rb +++ b/app/controllers/api/search_controller.rb @@ -1,6 +1,6 @@ class Api::SearchController < ApplicationController def show - @searches = Li...
Call uniq! to get unique searches deal with perf later
diff --git a/app/reports/research_matters_exporter.rb b/app/reports/research_matters_exporter.rb index abc1234..def5678 100644 --- a/app/reports/research_matters_exporter.rb +++ b/app/reports/research_matters_exporter.rb @@ -0,0 +1,94 @@+require 'csv' + +class ResearchMattersExporter + + STUDENT_INCLUDES = %w[school a...
Create data export code for Research Matters
diff --git a/lib/scorm2004/sequencing/rollup_rule.rb b/lib/scorm2004/sequencing/rollup_rule.rb index abc1234..def5678 100644 --- a/lib/scorm2004/sequencing/rollup_rule.rb +++ b/lib/scorm2004/sequencing/rollup_rule.rb @@ -6,6 +6,8 @@ module Sequencing class RollupRule include RollupRuleDescription + + ...
Fix the missing attribute reader. RollupRule should have attr_reader :rule.
diff --git a/lib/vagrant-chef-zero/server_helpers.rb b/lib/vagrant-chef-zero/server_helpers.rb index abc1234..def5678 100644 --- a/lib/vagrant-chef-zero/server_helpers.rb +++ b/lib/vagrant-chef-zero/server_helpers.rb @@ -32,7 +32,7 @@ end def get_chef_zero_server_pid(port) - pid = %x[ lsof -i tcp:...
Add second search term when grepping for PID of Chef-Zero
diff --git a/lib/versioneye/services/http_service.rb b/lib/versioneye/services/http_service.rb index abc1234..def5678 100644 --- a/lib/versioneye/services/http_service.rb +++ b/lib/versioneye/services/http_service.rb @@ -1,8 +1,24 @@ class HttpService < Versioneye::Service def self.fetch_response url, timeout = 60...
Add Proxy Settings to HTTP connections.
diff --git a/config/initializers/wicked_pdf.rb b/config/initializers/wicked_pdf.rb index abc1234..def5678 100644 --- a/config/initializers/wicked_pdf.rb +++ b/config/initializers/wicked_pdf.rb @@ -1,7 +1,7 @@ require 'wicked_pdf' WickedPdf.config = if Rails.env.production? - { exe_path: '/u/apps/handy/shared/bin/wk...
Update wkhtmltopdf executable path for Heroku
diff --git a/Casks/cacoo-ninja.rb b/Casks/cacoo-ninja.rb index abc1234..def5678 100644 --- a/Casks/cacoo-ninja.rb +++ b/Casks/cacoo-ninja.rb @@ -8,7 +8,6 @@ license :gratis installer :script => 'Install Cacoo Ninja.app/Contents/MacOS/Install Cacoo Ninja', - :args => %w[-silent], :sudo ...
Remove silent option to update successfully
diff --git a/simple_sitemap.gemspec b/simple_sitemap.gemspec index abc1234..def5678 100644 --- a/simple_sitemap.gemspec +++ b/simple_sitemap.gemspec @@ -13,7 +13,7 @@ gem.email = ['rpjlower@gmail.com'] gem.description = 'A simple sitemap generator' gem.summary = 'Simple sitemap generator' - gem...
Add github source URL as homepage
diff --git a/spec/command/trunk/addowner_spec.rb b/spec/command/trunk/addowner_spec.rb index abc1234..def5678 100644 --- a/spec/command/trunk/addowner_spec.rb +++ b/spec/command/trunk/addowner_spec.rb @@ -4,7 +4,36 @@ describe Command::Trunk::AddOwner do describe 'CLAide' do it 'registers it self' do - ...
[Specs] Test input validation in `trunk add-owner`
diff --git a/spec/correios/sro_validator_spec.rb b/spec/correios/sro_validator_spec.rb index abc1234..def5678 100644 --- a/spec/correios/sro_validator_spec.rb +++ b/spec/correios/sro_validator_spec.rb @@ -18,6 +18,20 @@ it { expect(subject.valid?).to be false } end + context "given a random string" do +...
Add more spec to cover latest improvements on the validator - Spec to cover any random String should not break the validator - Given a SRO with a specific suffix we could validate passing the suffix to the validator
diff --git a/spec/helpers/sidebar_helper_spec.rb b/spec/helpers/sidebar_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/sidebar_helper_spec.rb +++ b/spec/helpers/sidebar_helper_spec.rb @@ -0,0 +1,55 @@+require 'spec_helper' + +class TestBrokenSidebar < Sidebar + description "Invalid test sidebar" + de...
Add some specs for sidebar helper. Not pretty.
diff --git a/omniauth-medpass.gemspec b/omniauth-medpass.gemspec index abc1234..def5678 100644 --- a/omniauth-medpass.gemspec +++ b/omniauth-medpass.gemspec @@ -20,7 +20,7 @@ gem.add_development_dependency 'rack-test' gem.add_development_dependency 'rake' - gem.add_development_dependency 'rspec', '~> 2.8.0' + ...
Update rspec to ~> 2.9.0.rc2
diff --git a/activesupport/lib/active_support/core_ext/kernel/debugger.rb b/activesupport/lib/active_support/core_ext/kernel/debugger.rb index abc1234..def5678 100644 --- a/activesupport/lib/active_support/core_ext/kernel/debugger.rb +++ b/activesupport/lib/active_support/core_ext/kernel/debugger.rb @@ -7,6 +7,7 @@ ...
Fix Ruby warning: method redefined; discarding old breakpoint
diff --git a/app/controllers/active_storage/representations_controller.rb b/app/controllers/active_storage/representations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/active_storage/representations_controller.rb +++ b/app/controllers/active_storage/representations_controller.rb @@ -8,23 +8,11 @@ ...
Revert "Return webp if browser supports it" This reverts commit a7127f132a007839a63a912cdcdba2ac7dfcd780.
diff --git a/spec/lib/board_spec.rb b/spec/lib/board_spec.rb index abc1234..def5678 100644 --- a/spec/lib/board_spec.rb +++ b/spec/lib/board_spec.rb @@ -0,0 +1,34 @@+require 'spec_helper' + +describe Tavern::Board do + + let(:status_list) { [:todo, :done] } + let(:priorities) { [:low, :normal, :high] } + + subject...
Add first Board class spec
diff --git a/lib/dimma/version.rb b/lib/dimma/version.rb index abc1234..def5678 100644 --- a/lib/dimma/version.rb +++ b/lib/dimma/version.rb @@ -1,5 +1,5 @@ module Dimma # Dimmas’ version. # @see http://semver.org/ - VERSION = %w(1 0 1).join(".") + VERSION = %w(1 1 0).join(".") end
Bump to v1.1.0 (added Dimma::VERSION)
diff --git a/lib/identity/main.rb b/lib/identity/main.rb index abc1234..def5678 100644 --- a/lib/identity/main.rb +++ b/lib/identity/main.rb @@ -20,8 +20,7 @@ domain: Config.heroku_cookie_domain, expire_after: 2592000, http_only: true, - key: 'rack.session.heroku', - secret: Conf...
Remove secret from Heroku cookie
diff --git a/lib/model_patches.rb b/lib/model_patches.rb index abc1234..def5678 100644 --- a/lib/model_patches.rb +++ b/lib/model_patches.rb @@ -16,14 +16,24 @@ end end - # Add intro paragraph to new request template OutgoingMessage.class_eval do + # Add intro paragraph to new request ...
Hide legal intro paragraph from request search listing
diff --git a/lib/mollie/amount.rb b/lib/mollie/amount.rb index abc1234..def5678 100644 --- a/lib/mollie/amount.rb +++ b/lib/mollie/amount.rb @@ -1,6 +1,10 @@ module Mollie class Amount < Base attr_accessor :value, :currency + + def initialize(attributes) + super unless attributes.nil? + end de...
Return empty Amount object when API returns null
diff --git a/buildserver/cookbooks/fdroidbuild-general/recipes/default.rb b/buildserver/cookbooks/fdroidbuild-general/recipes/default.rb index abc1234..def5678 100644 --- a/buildserver/cookbooks/fdroidbuild-general/recipes/default.rb +++ b/buildserver/cookbooks/fdroidbuild-general/recipes/default.rb @@ -5,7 +5,7 @@ c...
Add scons, make-like tool used by godot
diff --git a/web-services/tests/common/cache_test.rb b/web-services/tests/common/cache_test.rb index abc1234..def5678 100644 --- a/web-services/tests/common/cache_test.rb +++ b/web-services/tests/common/cache_test.rb @@ -1,7 +1,32 @@-cache_test.rb - Unit Tests + #cache_test.rb - Unit Tests require 'test/unit' +requi...
[16] Add unit tests for cache manager
diff --git a/web.rb b/web.rb index abc1234..def5678 100644 --- a/web.rb +++ b/web.rb @@ -11,6 +11,7 @@ property :region, String property :realm, String property :character, String + property :img_url, String property :created_at, DateTime property :updated_at, DateTime end
Add image URL to Character model
diff --git a/app/controllers/api/items_controller.rb b/app/controllers/api/items_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/items_controller.rb +++ b/app/controllers/api/items_controller.rb @@ -1,12 +1,14 @@ class Api::ItemsController < ApiController def index item_type_id = params[:i...
Add Search For Number In API Item
diff --git a/blog.rb b/blog.rb index abc1234..def5678 100644 --- a/blog.rb +++ b/blog.rb @@ -1,4 +1,5 @@ require 'sinatra' +require 'sinatra/reloader' if development? require 'haml' require_relative 'lib/config'
Use sinatra/reloader in development mode
diff --git a/bigpanda.gemspec b/bigpanda.gemspec index abc1234..def5678 100644 --- a/bigpanda.gemspec +++ b/bigpanda.gemspec @@ -7,7 +7,7 @@ s.authors = ["BigPanda"] s.email = 'support@bigpanda.io' s.files = ["lib/bigpanda.rb", "lib/bigpanda/capistrano.rb", "lib/bigpanda/bp-api.rb"] - s.homepag...
Update homepage of the gem
diff --git a/lib/sub_diff/gsub.rb b/lib/sub_diff/gsub.rb index abc1234..def5678 100644 --- a/lib/sub_diff/gsub.rb +++ b/lib/sub_diff/gsub.rb @@ -8,6 +8,16 @@ def diff_method :gsub + end + + def prefix + super.sub(last_prefix, '') + end + + def suffix + unless super.send(matcher, args....
Change visiblity of a couple methods in `Gsub`
diff --git a/lib/taxonomy/tree.rb b/lib/taxonomy/tree.rb index abc1234..def5678 100644 --- a/lib/taxonomy/tree.rb +++ b/lib/taxonomy/tree.rb @@ -1,5 +1,6 @@-# This has been copied into Content Tagger, pending a decision on where it should live. -# If you're changing it, please consider handling the common case. +# This...
Change indentation in Tree class To remove the long lines.
diff --git a/lib/woodhouse/job.rb b/lib/woodhouse/job.rb index abc1234..def5678 100644 --- a/lib/woodhouse/job.rb +++ b/lib/woodhouse/job.rb @@ -3,6 +3,9 @@ class Woodhouse::Job attr_accessor :worker_class_name, :job_method, :arguments + extend Forwardable + + def_delegators :arguments, :each def initialize...
Allow Woodhouse::Job to mimic a hash of its arguments.
diff --git a/minc.rb b/minc.rb index abc1234..def5678 100644 --- a/minc.rb +++ b/minc.rb @@ -7,13 +7,17 @@ head 'https://github.com/BIC-MNI/minc.git' - #fails_with_clang "Throws 'non-void function 'miget_real_value_hyperslab' should return a value' error during build.", :build => 318 - depends_on 'netcdf' ...
Use new fails_with DSL syntax Signed-off-by: Jack Nagel <43386ce32af96f5c56f2a88e458cb94cebee3751@gmail.com>
diff --git a/week-4/simple_substrings/my_solution.rb b/week-4/simple_substrings/my_solution.rb index abc1234..def5678 100644 --- a/week-4/simple_substrings/my_solution.rb +++ b/week-4/simple_substrings/my_solution.rb @@ -6,7 +6,7 @@ # Your Solution Below def welcome(address) - if address.include?('CA') == true + i...
Add space in front of CA for include method
diff --git a/spec/features/experiment_create_spec.rb b/spec/features/experiment_create_spec.rb index abc1234..def5678 100644 --- a/spec/features/experiment_create_spec.rb +++ b/spec/features/experiment_create_spec.rb @@ -5,7 +5,7 @@ it 'is able to display a new experiment form' do visit '/experiment/index' ...
Refactor test to redirect to new experiment path
diff --git a/spec/helpers/user_and_repo_from_spec.rb b/spec/helpers/user_and_repo_from_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/user_and_repo_from_spec.rb +++ b/spec/helpers/user_and_repo_from_spec.rb @@ -5,11 +5,11 @@ @helper = GitHub::Helper.new end - it "should return defunkt and github.git...
Increase the descriptiveness of the examples
diff --git a/app/mailers/comment_mailer.rb b/app/mailers/comment_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/comment_mailer.rb +++ b/app/mailers/comment_mailer.rb @@ -10,6 +10,6 @@ @campaign = idea.campaign end - mail(to: @user.email, subject: "You have new comment in #{@campaign.name} : #...
Remove game from email title.
diff --git a/app/models/query_condition.rb b/app/models/query_condition.rb index abc1234..def5678 100644 --- a/app/models/query_condition.rb +++ b/app/models/query_condition.rb @@ -17,6 +17,6 @@ attribute :object, Types::Strict::String.maybe attribute :element, Types::Strict::String attribute :operator, Operato...
Allow the condition value to accept any type
diff --git a/app/controllers/educations_controller.rb b/app/controllers/educations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/educations_controller.rb +++ b/app/controllers/educations_controller.rb @@ -1,4 +1,9 @@ class EducationsController < MyplaceonlineController + def index + @graduated =...
Add education filter for only graduated degrees
diff --git a/app/controllers/operations_controller.rb b/app/controllers/operations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/operations_controller.rb +++ b/app/controllers/operations_controller.rb @@ -0,0 +1,19 @@+class OperationsController < ApplicationController + skip_before_filter :require_...
Add OperationsController and create - new actions.
diff --git a/app/sweepers/route_sweeper.rb b/app/sweepers/route_sweeper.rb index abc1234..def5678 100644 --- a/app/sweepers/route_sweeper.rb +++ b/app/sweepers/route_sweeper.rb @@ -24,13 +24,13 @@ :action => 'show_route_region', :id => route.region, ...
Add explicit reference to controller to prevent namespace clash.
diff --git a/week-4/shortest-string/my_solution.rb b/week-4/shortest-string/my_solution.rb index abc1234..def5678 100644 --- a/week-4/shortest-string/my_solution.rb +++ b/week-4/shortest-string/my_solution.rb @@ -21,5 +21,4 @@ end result - end
Complete 4.6.4. Small formatting change on prev commit
diff --git a/FreeStreamer.podspec b/FreeStreamer.podspec index abc1234..def5678 100644 --- a/FreeStreamer.podspec +++ b/FreeStreamer.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'FreeStreamer' - s.version = '1.3.1' + s.version = '1.3.2' s.license =...
Bump the version to 1.3.2.
diff --git a/spec/utilities_spec.rb b/spec/utilities_spec.rb index abc1234..def5678 100644 --- a/spec/utilities_spec.rb +++ b/spec/utilities_spec.rb @@ -0,0 +1,48 @@+require 'spec_helper' + +include GitHubArchiveParser + +describe Utilities do + describe "#time_from_natural_language" do + it "should raise an error ...
Add specs for Utilities module Add: * Specs for time_from_natural_language method * Specs for class_from_string method
diff --git a/features/lib/support/normalise_output.rb b/features/lib/support/normalise_output.rb index abc1234..def5678 100644 --- a/features/lib/support/normalise_output.rb +++ b/features/lib/support/normalise_output.rb @@ -19,8 +19,10 @@ elements = feature.fetch('elements') { [] } elements.each do |scena...
Handle that scenario outline steps do not contain result
diff --git a/app/controllers/spree/checkout_controller_decorator.rb b/app/controllers/spree/checkout_controller_decorator.rb index abc1234..def5678 100644 --- a/app/controllers/spree/checkout_controller_decorator.rb +++ b/app/controllers/spree/checkout_controller_decorator.rb @@ -2,13 +2,13 @@ CheckoutController.clas...
Rename method load_order to load_order_with_lock Fixes #59
diff --git a/config/initializers/question_cookies.rb b/config/initializers/question_cookies.rb index abc1234..def5678 100644 --- a/config/initializers/question_cookies.rb +++ b/config/initializers/question_cookies.rb @@ -1,2 +1,3 @@ # This hash will contain the type of the question as a key and value will be number of ...
Set default Cookie value at 0
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -8,14 +8,14 @@ get '/search', :to => 'search#index' - get '/dictionary', :to => redirect('/dictionaries') - get '/dictionaries', :to => 'dictionaries#index' + get '/dictionary', :to => re...
Make redirects robust enough to cope with a relative root URL
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -8,17 +8,15 @@ patch 'stories/:id/upvote', to: 'votes#upvote', as: 'vote_up' delete '/vote/:id', to: 'votes#destroy', as: 'vote_delete' - resources :users, only: [:show, :edit, :upda...
Create route to searched stories view
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -2,7 +2,7 @@ # Frontend routes namespace :elasticsearch, :path => '' do - match "/search", :to => 'search#show', :as => 'search' + get '/search', to: 'search#show', as: 'search' ...
Use rails 4 route syntax
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -34,4 +34,5 @@ resources :recruiters, only: :show get '/:id', to: 'developers#show', as: :developer + get '/:id/edit', to: 'developers#edit', as: :edit_developer end
Add edit route for developer
diff --git a/config/sentry.rb b/config/sentry.rb index abc1234..def5678 100644 --- a/config/sentry.rb +++ b/config/sentry.rb @@ -8,4 +8,4 @@ # Overwrite excluded exceptions config.excluded_exceptions = [] -en+end
Correct the end in raven configuration
diff --git a/lib/bodega/engine.rb b/lib/bodega/engine.rb index abc1234..def5678 100644 --- a/lib/bodega/engine.rb +++ b/lib/bodega/engine.rb @@ -4,17 +4,13 @@ initializer "bodega.hookses" do ActiveSupport.on_load :action_controller do - #require 'bodega/action_controller' + helper 'bodega/car...
Include helper automatically in all controllers
diff --git a/test/unit/presenters/completed_transaction_presenter_test.rb b/test/unit/presenters/completed_transaction_presenter_test.rb index abc1234..def5678 100644 --- a/test/unit/presenters/completed_transaction_presenter_test.rb +++ b/test/unit/presenters/completed_transaction_presenter_test.rb @@ -0,0 +1,11 @@+re...
Add a presenter test for CompletedTransactionPresenter
diff --git a/lib/roda/plugins/delete_empty_headers.rb b/lib/roda/plugins/delete_empty_headers.rb index abc1234..def5678 100644 --- a/lib/roda/plugins/delete_empty_headers.rb +++ b/lib/roda/plugins/delete_empty_headers.rb @@ -13,18 +13,18 @@ module ResponseMethods # Delete any empty headers when calling f...
Fix a typo in DeleteEmptyHeaders plugin
diff --git a/lib/sepa/banks/danske/danske_response.rb b/lib/sepa/banks/danske/danske_response.rb index abc1234..def5678 100644 --- a/lib/sepa/banks/danske/danske_response.rb +++ b/lib/sepa/banks/danske/danske_response.rb @@ -1,31 +1,28 @@ module Sepa class DanskeResponse < Response - # Namespace used in danske ...
Use xml namespace constant from sepafm.rb and add memoization to methods
diff --git a/db/seeds/demo/160_patients_bookmarks.rb b/db/seeds/demo/160_patients_bookmarks.rb index abc1234..def5678 100644 --- a/db/seeds/demo/160_patients_bookmarks.rb +++ b/db/seeds/demo/160_patients_bookmarks.rb @@ -5,10 +5,20 @@ roger_rabbit = Patient.find_by(family_name: 'RABBIT', given_name: 'Roger') User....
Add 'Jessica RABBIT' bookmarks to each user
diff --git a/serp_metrics.gemspec b/serp_metrics.gemspec index abc1234..def5678 100644 --- a/serp_metrics.gemspec +++ b/serp_metrics.gemspec @@ -10,7 +10,7 @@ gem.email = ["kristinalim.ph@gmail.com"] gem.description = %q{Ruby interface to the SERP Metrics API} gem.summary = %q{Ruby interface to ...
Fix homepage to not use git URI.
diff --git a/lib/katgut/engine.rb b/lib/katgut/engine.rb index abc1234..def5678 100644 --- a/lib/katgut/engine.rb +++ b/lib/katgut/engine.rb @@ -6,9 +6,5 @@ g.test_framework :rspec, fixture: false g.fixture_replacement :factory_girl, dir: "spec/factories" end - - initializer "static assets" do |app...
Remove unnecessary settings for loading of static assets * It brokes 'rake assets:precompile' when the host app is set not to serve static assets
diff --git a/lib/matross/nginx.rb b/lib/matross/nginx.rb index abc1234..def5678 100644 --- a/lib/matross/nginx.rb +++ b/lib/matross/nginx.rb @@ -22,6 +22,7 @@ run "#{sudo} sed -i /auth_basic/d /etc/nginx/sites-available/#{application}" nginx_lock = " auth_basic \"Restricted\";\n auth_basic_user_f...
Put the htpasswd file in shared path
diff --git a/spec/memory_spec.rb b/spec/memory_spec.rb index abc1234..def5678 100644 --- a/spec/memory_spec.rb +++ b/spec/memory_spec.rb @@ -2,6 +2,10 @@ describe Memory do describe Memory::Sources::GitHubSource do + subject(:github_source) { + Memory::Sources::GitHubSource.new(username: 'svankmajer') + ...
Introduce subject to GitHubSource specs. This commits adds a _named_ subject to Memory::Sources::GitHubSource specs to avoid code duplication.
diff --git a/app/controllers/api/status_controller.rb b/app/controllers/api/status_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/status_controller.rb +++ b/app/controllers/api/status_controller.rb @@ -4,7 +4,7 @@ def check if params[:projects].any? @projects = params[:projects].gro...
Enable checking up to 1000 projects at a time
diff --git a/app/controllers/localities_controller.rb b/app/controllers/localities_controller.rb index abc1234..def5678 100644 --- a/app/controllers/localities_controller.rb +++ b/app/controllers/localities_controller.rb @@ -41,8 +41,9 @@ end def destroy + locality_name = @locality.city if @locality.dest...
Fix bug - trying to access locality name after it had been deleted.
diff --git a/lib/readme_tester.rb b/lib/readme_tester.rb index abc1234..def5678 100644 --- a/lib/readme_tester.rb +++ b/lib/readme_tester.rb @@ -10,6 +10,9 @@ Deject self, :interaction dependency(:interpreter_class) { Interpreter } dependency(:file_class) { File } + + SUCCESS_STATUS = 0 + FAILURE_STATU...
Set exit statuses into constants instead of hard coding them
diff --git a/app/helpers/application_helper/button/utilization_download.rb b/app/helpers/application_helper/button/utilization_download.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper/button/utilization_download.rb +++ b/app/helpers/application_helper/button/utilization_download.rb @@ -1,7 +1,7 @@...
Fix error about empty? called on nil object
diff --git a/app/serializers/lite_paper_serializer.rb b/app/serializers/lite_paper_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/lite_paper_serializer.rb +++ b/app/serializers/lite_paper_serializer.rb @@ -5,8 +5,7 @@ scoped_user.paper_roles.where(paper: object).order(created_at: :desc).pluck(:cr...
Update todo to point to open pivotal card
diff --git a/app/services/csvlint_validate_service.rb b/app/services/csvlint_validate_service.rb index abc1234..def5678 100644 --- a/app/services/csvlint_validate_service.rb +++ b/app/services/csvlint_validate_service.rb @@ -0,0 +1,13 @@+class CsvlintValidateService + + require 'csvlint' + + def self.validate_csv(datas...
Add service CsvlintValidateService - validate s3 csv string with csvlint.rb
diff --git a/spec/features/override_sendgrid_spec.rb b/spec/features/override_sendgrid_spec.rb index abc1234..def5678 100644 --- a/spec/features/override_sendgrid_spec.rb +++ b/spec/features/override_sendgrid_spec.rb @@ -29,4 +29,26 @@ expect(page).to have_content('Your request is being processed') end + + sc...
Add end-to-end bounce override spec
diff --git a/lib/session_token.rb b/lib/session_token.rb index abc1234..def5678 100644 --- a/lib/session_token.rb +++ b/lib/session_token.rb @@ -1,17 +1,19 @@ class SessionToken - PASSWORD = Rails.application.secrets.secret_key_base - EXPIRY = 4.days - ISSUER = 'farmbot-web-app' + EXPIRY = 4.days + ISSUE...
Change JWT encrytion to RS256
diff --git a/app/uploaders/pulitzer/image_uploader.rb b/app/uploaders/pulitzer/image_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/pulitzer/image_uploader.rb +++ b/app/uploaders/pulitzer/image_uploader.rb @@ -5,4 +5,8 @@ def resize_image self.class.process resize_to_fit: [model.height, model.widt...
Add thumb version for images
diff --git a/lib/time_zone_ext.rb b/lib/time_zone_ext.rb index abc1234..def5678 100644 --- a/lib/time_zone_ext.rb +++ b/lib/time_zone_ext.rb @@ -5,9 +5,9 @@ module TimeZoneExt def strptime(date, format) if format =~ /%z/i - Time.strptime(date, format).in_time_zone + DateTime.strptime(date, format).in_...
Use DateTime instaed of Time to support ruby 1.8
diff --git a/lib/usesthis/page.rb b/lib/usesthis/page.rb index abc1234..def5678 100644 --- a/lib/usesthis/page.rb +++ b/lib/usesthis/page.rb @@ -20,11 +20,11 @@ end end - def write(output_path) + def write(output_path, filename = 'index.html') if @path - path = File.join(output_path, Fi...
Support passing in a custom filename to write().
diff --git a/db/migrate/20171113180900_add_dry_to_user_migration_import.rb b/db/migrate/20171113180900_add_dry_to_user_migration_import.rb index abc1234..def5678 100644 --- a/db/migrate/20171113180900_add_dry_to_user_migration_import.rb +++ b/db/migrate/20171113180900_add_dry_to_user_migration_import.rb @@ -4,7 +4,7 @@...
Change default value for migration
diff --git a/spec/bench_helper.rb b/spec/bench_helper.rb index abc1234..def5678 100644 --- a/spec/bench_helper.rb +++ b/spec/bench_helper.rb @@ -58,7 +58,7 @@ $__benchmarks__ = [] at_exit do - reports = Benchmark.ips(time = 2) do |x| + reports = Benchmark.ips(time = 1) do |x| $__benchmarks__.each do |bench| ...
Make running benchmarks TWICE AS FAST!
diff --git a/postrank-uri.gemspec b/postrank-uri.gemspec index abc1234..def5678 100644 --- a/postrank-uri.gemspec +++ b/postrank-uri.gemspec @@ -15,7 +15,7 @@ s.rubyforge_project = "postrank-uri" - s.add_dependency "addressable", "~> 2.3.0" + s.add_dependency "addressable", ">= 2.3.0", "< 2.6" s.add_depe...
Allow newer versions of addressable Tested and working with addressable 2.5.0
diff --git a/spec/support/auto_load_turnip.rb b/spec/support/auto_load_turnip.rb index abc1234..def5678 100644 --- a/spec/support/auto_load_turnip.rb +++ b/spec/support/auto_load_turnip.rb @@ -1,47 +1,22 @@-# See https://github.com/jnicklas/turnip/pull/96 -# with a tweak to group features into acceptance/features/ alon...
Switch away from patched Turnip autoloading.
diff --git a/tasks/user_system_has_accounts_tasks.rake b/tasks/user_system_has_accounts_tasks.rake index abc1234..def5678 100644 --- a/tasks/user_system_has_accounts_tasks.rake +++ b/tasks/user_system_has_accounts_tasks.rake @@ -18,7 +18,7 @@ desc "Run migrations for the UserSystemHasAccounts Extension" task :mi...
Fix require 'environment' => 'config/environment'
diff --git a/test/controllers/store_controller_test.rb b/test/controllers/store_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/store_controller_test.rb +++ b/test/controllers/store_controller_test.rb @@ -4,6 +4,10 @@ test "should get index" do get :index assert_response :success + ...
Store Controller Test for navigation, record number, sample title, and price formatting
diff --git a/lib/identificamex/normalizador_cadena.rb b/lib/identificamex/normalizador_cadena.rb index abc1234..def5678 100644 --- a/lib/identificamex/normalizador_cadena.rb +++ b/lib/identificamex/normalizador_cadena.rb @@ -16,13 +16,22 @@ end def normalizar - if nombres.count > 1 - nombre_princ...
Refactor to reduce method length.
diff --git a/core/config/initializers/secret_token.rb b/core/config/initializers/secret_token.rb index abc1234..def5678 100644 --- a/core/config/initializers/secret_token.rb +++ b/core/config/initializers/secret_token.rb @@ -4,4 +4,4 @@ # If you change this key, all old signed cookies will become invalid! # Make sure ...
Update secret token to fix current sessions
diff --git a/lib/tasks/compute_match_percentages.rake b/lib/tasks/compute_match_percentages.rake index abc1234..def5678 100644 --- a/lib/tasks/compute_match_percentages.rake +++ b/lib/tasks/compute_match_percentages.rake @@ -0,0 +1,13 @@+desc "Compute the match percentages for all of the user pairs in a section" +task ...
Add a rake task to compute the match percentages
diff --git a/app/controllers/feedback_controller.rb b/app/controllers/feedback_controller.rb index abc1234..def5678 100644 --- a/app/controllers/feedback_controller.rb +++ b/app/controllers/feedback_controller.rb @@ -7,7 +7,7 @@ def create @seo_carrier ||= OpenStruct.new(title: I18n.t('defaults.page_titles.feedb...
Add usefull comment about email devilery
diff --git a/app/controllers/invoices_controller.rb b/app/controllers/invoices_controller.rb index abc1234..def5678 100644 --- a/app/controllers/invoices_controller.rb +++ b/app/controllers/invoices_controller.rb @@ -32,7 +32,7 @@ cl.quantity) end - piwik += piwik_ecommerce...
Fix shipping reporting in Piwik
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -5,6 +5,7 @@ def set_logged_in if (user_signed_in?) # Sets a "permanent" cookie (which exp...
Add comment to clarify logged_in cookie
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -5,9 +5,9 @@ end def create - @user = User.find_by(email: user_params[:email]) - if @user.p...
Fix logging in validation for user
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -0,0 +1,19 @@+class SessionsController < ApplicationController + + def new + @user = User.new + end...
Add new and create routes
diff --git a/app/jobs/promo/email_breakdowns_job.rb b/app/jobs/promo/email_breakdowns_job.rb index abc1234..def5678 100644 --- a/app/jobs/promo/email_breakdowns_job.rb +++ b/app/jobs/promo/email_breakdowns_job.rb @@ -12,8 +12,12 @@ is_geo: true, include_ratios: false ).perform) - csv.delete("Day") ...
Fix the columns being selected
diff --git a/spec/controllers/home_controller_spec.rb b/spec/controllers/home_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/home_controller_spec.rb +++ b/spec/controllers/home_controller_spec.rb @@ -1,12 +1,13 @@ require 'spec_helper' describe HomeController do + render_views describe...
Add a test for the title of the homepage.
diff --git a/db/migrate/20151114201151_add_project_name_to_teams.rb b/db/migrate/20151114201151_add_project_name_to_teams.rb index abc1234..def5678 100644 --- a/db/migrate/20151114201151_add_project_name_to_teams.rb +++ b/db/migrate/20151114201151_add_project_name_to_teams.rb @@ -4,7 +4,7 @@ Project.joins(:team)....
Allow running migrations when association is gone
diff --git a/db/migrate/20160721152111_change_explicit_to_string.rb b/db/migrate/20160721152111_change_explicit_to_string.rb index abc1234..def5678 100644 --- a/db/migrate/20160721152111_change_explicit_to_string.rb +++ b/db/migrate/20160721152111_change_explicit_to_string.rb @@ -0,0 +1,17 @@+class ChangeExplicitToStri...
Change podcast explicit to a string not a boolean
diff --git a/modules/nagios/lib/facter/nagios_pci.rb b/modules/nagios/lib/facter/nagios_pci.rb index abc1234..def5678 100644 --- a/modules/nagios/lib/facter/nagios_pci.rb +++ b/modules/nagios/lib/facter/nagios_pci.rb @@ -1,20 +1,22 @@ # Create nagios_pci_<modname> facts for these modules, if found modnames = [ "megara...
Fix warning on virtual machines with no PCI bus
diff --git a/subscriptionManager.rb b/subscriptionManager.rb index abc1234..def5678 100644 --- a/subscriptionManager.rb +++ b/subscriptionManager.rb @@ -28,7 +28,8 @@ end #Class that handles the mailing operations -class Mailer +class Mailer + @@sender @@recipient @@subject @@ -44,9 +45,30 @@ FAILURE: ...
Add method to send email. Requires a mailserver (postfix on localhost will work)
diff --git a/recipes/configure.rb b/recipes/configure.rb index abc1234..def5678 100644 --- a/recipes/configure.rb +++ b/recipes/configure.rb @@ -5,3 +5,18 @@ variables :config => node['chef-grafana']['config'] notifies :restart, "service[grafana-server]" end + +# Make data/log dirs if we changed them from the def...
Create data/log dirs if we change them from defaults
diff --git a/spec/support/matchers/gitaly_matchers.rb b/spec/support/matchers/gitaly_matchers.rb index abc1234..def5678 100644 --- a/spec/support/matchers/gitaly_matchers.rb +++ b/spec/support/matchers/gitaly_matchers.rb @@ -9,6 +9,6 @@ RSpec::Matchers.define :gitaly_request_with_params do |params| match do |actua...
Fix order-dependent Gitaly specs failing If `spec/tasks/gitlab/cleanup_rake_spec.rb` preceded any of the Gitaly request specs, it would import the `cleanup.rake` and the global function `limit`. For some reason, the Protobuf implementation would use the global function instead of the getter method. For example: ``` d...
diff --git a/spec/traders_spec.rb b/spec/traders_spec.rb index abc1234..def5678 100644 --- a/spec/traders_spec.rb +++ b/spec/traders_spec.rb @@ -7,7 +7,7 @@ trader.fetch expect(trader.rates).not_to be_empty - expect(trader.rates).to be == expected_rates(short_name) + expect(trader.rates).to eq(...
Use `eq` instead of `be ==`
diff --git a/app/helpers/budget_investments_helper.rb b/app/helpers/budget_investments_helper.rb index abc1234..def5678 100644 --- a/app/helpers/budget_investments_helper.rb +++ b/app/helpers/budget_investments_helper.rb @@ -1,6 +1,8 @@ module BudgetInvestmentsHelper def budget_investments_sorting_options - Budge...
Fix line length at budget investments helper
diff --git a/app/models/solidus_easypost/estimator.rb b/app/models/solidus_easypost/estimator.rb index abc1234..def5678 100644 --- a/app/models/solidus_easypost/estimator.rb +++ b/app/models/solidus_easypost/estimator.rb @@ -3,48 +3,38 @@ module SolidusEasypost class Estimator def shipping_rates(package, _front...
Split SolidusEasypost::Estimator logic into multiple methods
diff --git a/spec/support/capybara.rb b/spec/support/capybara.rb index abc1234..def5678 100644 --- a/spec/support/capybara.rb +++ b/spec/support/capybara.rb @@ -1,20 +1,30 @@ require 'capybara/poltergeist' -# disable logger -module NullPoltergeistLogger - def self.puts(*) +class ActionDispatch::IntegrationTest + # ...
Increase default waiting time and add timeout for poltergeist
diff --git a/spec/tic_tac_toe_spec.rb b/spec/tic_tac_toe_spec.rb index abc1234..def5678 100644 --- a/spec/tic_tac_toe_spec.rb +++ b/spec/tic_tac_toe_spec.rb @@ -5,7 +5,7 @@ expect(TicTacToe::VERSION).not_to be nil end - it 'does something useful' do - expect(false).to eq(true) + it 'has a game' do + ga...
Add a better failing test
diff --git a/spec/tic_tac_toe_spec.rb b/spec/tic_tac_toe_spec.rb index abc1234..def5678 100644 --- a/spec/tic_tac_toe_spec.rb +++ b/spec/tic_tac_toe_spec.rb @@ -7,5 +7,6 @@ it 'has a game' do game = TicTacToe::Game.new + expect(game).to be_an_instance_of TicTacToe::Game end end
Add an expectation of type
diff --git a/spec/toy/plugins_spec.rb b/spec/toy/plugins_spec.rb index abc1234..def5678 100644 --- a/spec/toy/plugins_spec.rb +++ b/spec/toy/plugins_spec.rb @@ -9,12 +9,19 @@ describe ".plugin" do before do - class_methods_mod = Module.new { def foo; 'foo' end } - instance_methods_mod = Module.new...
Tweak plugin spec to not use InstanceMethods
diff --git a/spec/update/path_spec.rb b/spec/update/path_spec.rb index abc1234..def5678 100644 --- a/spec/update/path_spec.rb +++ b/spec/update/path_spec.rb @@ -12,7 +12,7 @@ build_lib "activesupport", "3.0", :path => lib_path("rails/activesupport") bundle "update --source activesupport" - expect(ou...
[Path] Update spec for wrapping path in backticks
diff --git a/lib/optimus_prime.rb b/lib/optimus_prime.rb index abc1234..def5678 100644 --- a/lib/optimus_prime.rb +++ b/lib/optimus_prime.rb @@ -14,6 +14,7 @@ require 'optimus_prime/destinations/rdbms_writer' require 'optimus_prime/sources/flurry_helpers/flurry_connector' require 'optimus_prime/transformers/expand_js...
Load AppAnnie source before loading AppAnnieProductSales source.