diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/adapter/v1/cloudFoundry/cloud_foundry_adapter_spec.rb b/spec/adapter/v1/cloudFoundry/cloud_foundry_adapter_spec.rb index abc1234..def5678 100644 --- a/spec/adapter/v1/cloudFoundry/cloud_foundry_adapter_spec.rb +++ b/spec/adapter/v1/cloudFoundry/cloud_foundry_adapter_spec.rb @@ -2,7 +2,7 @@ describe ...
Use `cf-bosh-local` instead of `cf-stackato-local` for Cloud Foundry tests (--> faster!)
diff --git a/spec/lib/neighborly/balanced/bankaccount/interface_spec.rb b/spec/lib/neighborly/balanced/bankaccount/interface_spec.rb index abc1234..def5678 100644 --- a/spec/lib/neighborly/balanced/bankaccount/interface_spec.rb +++ b/spec/lib/neighborly/balanced/bankaccount/interface_spec.rb @@ -1,7 +1,6 @@ require 'sp...
Remove unnecessary subject on spec
diff --git a/lib/alephant/broker/cache.rb b/lib/alephant/broker/cache.rb index abc1234..def5678 100644 --- a/lib/alephant/broker/cache.rb +++ b/lib/alephant/broker/cache.rb @@ -4,7 +4,6 @@ module Alephant module Broker module Cache - class Client include Logger @@ -19,6 +18,22 @@ @...
Set custom TTL in Cache Closes #24
diff --git a/core/spec/models/comable/variant_spec.rb b/core/spec/models/comable/variant_spec.rb index abc1234..def5678 100644 --- a/core/spec/models/comable/variant_spec.rb +++ b/core/spec/models/comable/variant_spec.rb @@ -0,0 +1,10 @@+describe Comable::Variant do + it { is_expected.to belong_to(:product).class_name...
Add the test for Variant
diff --git a/lib/bankscrap/transaction.rb b/lib/bankscrap/transaction.rb index abc1234..def5678 100644 --- a/lib/bankscrap/transaction.rb +++ b/lib/bankscrap/transaction.rb @@ -15,7 +15,7 @@ end def to_a - [effective_date.strftime('%d/%m/%Y'), description, amount] + [:id, effective_date.strftime('%...
Add `:id` and `:description_details` to `to_a` method for `Bankscrap::Transaction`
diff --git a/config/initializers/secure_headers.rb b/config/initializers/secure_headers.rb index abc1234..def5678 100644 --- a/config/initializers/secure_headers.rb +++ b/config/initializers/secure_headers.rb @@ -6,6 +6,7 @@ config.csp = { enforce: true, default_src: 'https://* self', + style_src: ...
Allow inline CSS, for now. The form_for helper in the picture upload form generates a <div style="display:none"> tag around the utf8 and authenticity_token input fields.
diff --git a/app/controllers/areas_controller.rb b/app/controllers/areas_controller.rb index abc1234..def5678 100644 --- a/app/controllers/areas_controller.rb +++ b/app/controllers/areas_controller.rb @@ -12,7 +12,7 @@ def update @area = Area.find_by_id params[:id] - if @area.update_attributes params[:area]...
Add strong params for areas
diff --git a/db/migrate/1406149630_create_test_set.rb b/db/migrate/1406149630_create_test_set.rb index abc1234..def5678 100644 --- a/db/migrate/1406149630_create_test_set.rb +++ b/db/migrate/1406149630_create_test_set.rb @@ -1,14 +1,7 @@ Sequel.migration do change do - create_table(:testset) do - serial :set...
Change testset migration to alter table not create it The testset migration should not create the lone testset table, but it should alter the one created by resultsdb.sql, at least until all of resultsdb.sql is included in the migrations.
diff --git a/db/migrate/20150506084842_create_maps.rb b/db/migrate/20150506084842_create_maps.rb index abc1234..def5678 100644 --- a/db/migrate/20150506084842_create_maps.rb +++ b/db/migrate/20150506084842_create_maps.rb @@ -2,7 +2,6 @@ def change create_table :maps do |t| t.string :name - t.string :...
Remove string field for maps table
diff --git a/tasks/build-binary-new/source_input.rb b/tasks/build-binary-new/source_input.rb index abc1234..def5678 100644 --- a/tasks/build-binary-new/source_input.rb +++ b/tasks/build-binary-new/source_input.rb @@ -1,9 +1,10 @@ class SourceInput attr_reader :url, :md5, :git_commit_sha - attr_accessor :name, :vers...
Add source_repo to dependency builder object [#164880949] Co-authored-by: Daniel Thornton <5874b3971aa460e96f75d4dbef8f6aadb66f1697@pivotal.io>
diff --git a/app/controllers/theme_controller.rb b/app/controllers/theme_controller.rb index abc1234..def5678 100644 --- a/app/controllers/theme_controller.rb +++ b/app/controllers/theme_controller.rb @@ -1,4 +1,10 @@ # Theme controller +# Shows information about available user color themes. +# +# ==== Public Actions ...
Document public actions of ThemeController Includes an explanation why the actions for the individual themes (e.g., `theme/Agaricus`) are not defined in the controller.
diff --git a/lib/facter/root_encrypted.rb b/lib/facter/root_encrypted.rb index abc1234..def5678 100644 --- a/lib/facter/root_encrypted.rb +++ b/lib/facter/root_encrypted.rb @@ -5,7 +5,7 @@ def root_encrypted? system("/usr/bin/fdesetup isactive /") - [0, 2].include? $? + [0, 2].include? $?.exitstatus e...
Fix bug in checking exitstatus When fdesetup returns with exit code 2, $? is actually 512 (512 >> 8 == 2). Need to check for $?.exitstatus
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,7 +1,7 @@ class UsersController < ApplicationController respond_to :json + before_filter :authenticate_admin!...
Refactor user create/update params to different methods
diff --git a/lib/logster/configuration.rb b/lib/logster/configuration.rb index abc1234..def5678 100644 --- a/lib/logster/configuration.rb +++ b/lib/logster/configuration.rb @@ -12,7 +12,8 @@ @subdirectory = nil @allow_grouping = false - if defined?(::Rails) && ::Rails.env.production? + + if def...
FIX: Check that `Rails.env` is defined as well.
diff --git a/tools/groonga-memory-usage-analyzer.rb b/tools/groonga-memory-usage-analyzer.rb index abc1234..def5678 100644 --- a/tools/groonga-memory-usage-analyzer.rb +++ b/tools/groonga-memory-usage-analyzer.rb @@ -0,0 +1,86 @@+#!/usr/bin/env ruby + +class Memory < Struct.new(:size, :file, :line, :function) + def lo...
Add a tool to analyze memory usage from memory debug log
diff --git a/lib/cdistance.rb b/lib/cdistance.rb index abc1234..def5678 100644 --- a/lib/cdistance.rb +++ b/lib/cdistance.rb @@ -1,5 +1,35 @@+require 'bundler/setup' +require 'ffi' + module Cdistance extend FFI::Library - ffi_lib FFI::Library::LIBC - attach_function :puts, [ :string ], :int + + lib_file = File.e...
Add an actual FFI interface for the library
diff --git a/lib/simctl/command/create.rb b/lib/simctl/command/create.rb index abc1234..def5678 100644 --- a/lib/simctl/command/create.rb +++ b/lib/simctl/command/create.rb @@ -14,6 +14,8 @@ def create_device(name, devicetype, runtime) runtime = runtime(name: runtime) unless runtime.is_a?(Runtime) ...
Raise exception if runtime or devicetype lookup failed
diff --git a/lib/simple_authentication.rb b/lib/simple_authentication.rb index abc1234..def5678 100644 --- a/lib/simple_authentication.rb +++ b/lib/simple_authentication.rb @@ -3,4 +3,4 @@ require "simple_authentication/model_methods" ApplicationController.send(:include, SimpleAuthentication::ControllerMethods::Appl...
Add i18n load path to the beginning to allow values to be overridden
diff --git a/lib/taskmeister/task_list.rb b/lib/taskmeister/task_list.rb index abc1234..def5678 100644 --- a/lib/taskmeister/task_list.rb +++ b/lib/taskmeister/task_list.rb @@ -9,7 +9,7 @@ end def to_short_list - longest_id = @hash.keys.max {|id| id.length } + longest_id = @hash.keys.max_by(&:lengt...
Fix column width on short_list
diff --git a/lib/tasks/pull_requests.rake b/lib/tasks/pull_requests.rake index abc1234..def5678 100644 --- a/lib/tasks/pull_requests.rake +++ b/lib/tasks/pull_requests.rake @@ -20,3 +20,11 @@ user.download_pull_requests(load_user.token) rescue nil end end + +desc 'Clean the pulls with empty link' +task :clean_e...
Clean PRs with empty link [fixes #388]
diff --git a/lib/multi_dir.rb b/lib/multi_dir.rb index abc1234..def5678 100644 --- a/lib/multi_dir.rb +++ b/lib/multi_dir.rb @@ -1,3 +1,4 @@+require 'active_support/core_ext/kernel/singleton_class' require 'active_support/core_ext/hash/keys' require 'multi_dir/version'
Revert "Remove AC singleton_class polyfil." This reverts commit c05840f7f00d676f00e0971f828faa09f2d76e8b.
diff --git a/lib/rubbr/cli.rb b/lib/rubbr/cli.rb index abc1234..def5678 100644 --- a/lib/rubbr/cli.rb +++ b/lib/rubbr/cli.rb @@ -19,7 +19,7 @@ end def color?(msg, code) - Rubbr.options[:color] ? "#{code}#{msg}" : msg + Rubbr.options[:color] ? "#{code}#{msg}\e[0m" : msg end def disable_s...
Reset color after outputting color message
diff --git a/lib/shibaraku.rb b/lib/shibaraku.rb index abc1234..def5678 100644 --- a/lib/shibaraku.rb +++ b/lib/shibaraku.rb @@ -4,4 +4,6 @@ module Shibaraku end -ActiveRecord::Base.include(Shibaraku::ActiveRecordExt) +ActiveSupport.on_load :active_record do + ActiveRecord::Base.include(Shibaraku::ActiveRecordExt) ...
Use ActiveSupport lazy load hook to initialize ActiveRecord Fix breaking `active_record.belongs_to_required_by_default` configuration.
diff --git a/lib/backlog_kit/client/notification.rb b/lib/backlog_kit/client/notification.rb index abc1234..def5678 100644 --- a/lib/backlog_kit/client/notification.rb +++ b/lib/backlog_kit/client/notification.rb @@ -1,18 +1,34 @@ module BacklogKit class Client module Notification + + # Get list of own not...
Add documentation for the Notification API
diff --git a/lib/cache_comment/comment_formatter.rb b/lib/cache_comment/comment_formatter.rb index abc1234..def5678 100644 --- a/lib/cache_comment/comment_formatter.rb +++ b/lib/cache_comment/comment_formatter.rb @@ -20,7 +20,9 @@ end def start_regex - Regexp.new start.gsub(@time.to_s, '.*').gsub((@time...
Fix regexp for cache without expiry
diff --git a/lib/kumo_dockercloud/console_jockey.rb b/lib/kumo_dockercloud/console_jockey.rb index abc1234..def5678 100644 --- a/lib/kumo_dockercloud/console_jockey.rb +++ b/lib/kumo_dockercloud/console_jockey.rb @@ -27,7 +27,10 @@ rescue status = false end - status == "yes" + + proceed ...
Add feedback after user enters yes, no or timesout
diff --git a/lib/libdolt/gitorious_repo_resolver.rb b/lib/libdolt/gitorious_repo_resolver.rb index abc1234..def5678 100644 --- a/lib/libdolt/gitorious_repo_resolver.rb +++ b/lib/libdolt/gitorious_repo_resolver.rb @@ -0,0 +1,29 @@+# encoding: utf-8 +#-- +# Copyright (C) 2012 Gitorious AS +# +# This program is free s...
Add very simple Gitorious repo resolver
diff --git a/lib/netsuite/records/pricing_matrix.rb b/lib/netsuite/records/pricing_matrix.rb index abc1234..def5678 100644 --- a/lib/netsuite/records/pricing_matrix.rb +++ b/lib/netsuite/records/pricing_matrix.rb @@ -1,23 +1,11 @@ module NetSuite module Records - class PricingMatrix + class PricingMatrix < Sup...
Use sublist for pricing matrix If pricing matrix was nil in the XML response, a corrupted pricing matrix item would be contained in `prices`
diff --git a/spec/i18n_spec.rb b/spec/i18n_spec.rb index abc1234..def5678 100644 --- a/spec/i18n_spec.rb +++ b/spec/i18n_spec.rb @@ -6,13 +6,21 @@ let(:missing_keys) { i18n.missing_keys } let(:unused_keys) { i18n.unused_keys } + let(:missing_keys_message) do + "Missing #{missing_keys.leaves.count} i18n keys,...
Style/AlignParameters: Align the parameters of a method call if they span more than one line.
diff --git a/skroutz_api.gemspec b/skroutz_api.gemspec index abc1234..def5678 100644 --- a/skroutz_api.gemspec +++ b/skroutz_api.gemspec @@ -10,7 +10,7 @@ spec.email = ["zorbash@skroutz.gr"] spec.summary = %q{Skroutz API client} spec.description = %q{Ruby API client for Skroutz} - spec.homepage...
Update project homepage in gemspec
diff --git a/test/benchmark/query.rb b/test/benchmark/query.rb index abc1234..def5678 100644 --- a/test/benchmark/query.rb +++ b/test/benchmark/query.rb @@ -0,0 +1,77 @@+$:.unshift File.expand_path('../../../lib',__FILE__) +require 'rubygems' +require 'bench_press' +require 'tiny_tds' +require 'odbc' +require 'odbc_utf...
Add another benchmark that side by sides clients. UTF8 ruby odbc is so buggy it can not even run the test.
diff --git a/pairhost.gemspec b/pairhost.gemspec index abc1234..def5678 100644 --- a/pairhost.gemspec +++ b/pairhost.gemspec @@ -8,14 +8,14 @@ s.authors = ["Larry Karnowski"] s.email = ["larry@hickorywind.org"] s.homepage = "http://www.github.com/karnowski/pairhost" - s.summary = %q{Automate c...
Update fog & gem summary/description
diff --git a/lib/embryo/rspec.rb b/lib/embryo/rspec.rb index abc1234..def5678 100644 --- a/lib/embryo/rspec.rb +++ b/lib/embryo/rspec.rb @@ -12,6 +12,7 @@ def spec_helper_data 'RSpec.configure do |config| + config.color = true config.order = :random config.mock_with :rspec do |mocks| mocks.verify_par...
Configure Rspec to use color
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -27,11 +27,12 @@ end end - Given(:container_root) { find('body') } - Given(:container) { Container.new(root: container_root) } + Given(:container_class) ...
[spec] Make default container class name configurable.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -12,7 +12,11 @@ require 'simplecov' require 'simplecov-rcov' SimpleCov.formatter = SimpleCov::Formatter::RcovFormatter - SimpleCov.start + SimpleCov.start do + add_fil...
Use absolute syntax on filters to avoid matching parent directories: e.g. /home/spec/rails_core_extensions/lib accidently matches spec when only intending to match spec within rails_core_extensions directory
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -9,7 +9,7 @@ app = DolphyApp.app do DolphyApp.router do get '/' do - haml :index, body: "Hello" + haml :index, { title: "booyah!", body: "Hello" } end ...
Add title to test app.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -7,7 +7,7 @@ require 'rspec' require 'factory_girl' -require_relative 'factories' +require 'factories' if RUBY_VERSION >= '1.9'
Use require instead of require_relative
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -14,4 +14,15 @@ RSpec.configure do |config| config.order = 'random' + # Configure the DatabaseCleaner + config.before(:suite) do + DatabaseCleaner.strategy = :transaction...
Add database cleanup to suite
diff --git a/lib/rack_tracker.rb b/lib/rack_tracker.rb index abc1234..def5678 100644 --- a/lib/rack_tracker.rb +++ b/lib/rack_tracker.rb @@ -14,6 +14,14 @@ include Rack::Caller include Rack::TrackerPlugins + # + # All Rack::Tracker class variables are settable via this configuration method. + # + ...
Add notes for the configure block
diff --git a/lib/saves/backup.rb b/lib/saves/backup.rb index abc1234..def5678 100644 --- a/lib/saves/backup.rb +++ b/lib/saves/backup.rb @@ -0,0 +1,81 @@+require 'zlib' +require 'archive/tar/minitar' + +module Saves + class Backup + attr_reader :game, :backup + + def initialize(game) + @game = game + end...
Add code for baking up the saves
diff --git a/lib/twitter-vine.rb b/lib/twitter-vine.rb index abc1234..def5678 100644 --- a/lib/twitter-vine.rb +++ b/lib/twitter-vine.rb @@ -1,6 +1,7 @@ require 'twitter-vine/version' require 'twitter' require 'nokogiri' +require 'twitter-vine/client' module TwitterVine DEBUG = false
Fix broken Twitter::Client by requiring client.rb
diff --git a/libraries/sysctl.rb b/libraries/sysctl.rb index abc1234..def5678 100644 --- a/libraries/sysctl.rb +++ b/libraries/sysctl.rb @@ -16,7 +16,7 @@ prefix += '.' unless prefix.empty? v.map { |key, value| compile_attr("#{prefix}#{key}", value) }.flatten.sort else - raise Chef::Excep...
Use fail instead of raise
diff --git a/link_shrink.gemspec b/link_shrink.gemspec index abc1234..def5678 100644 --- a/link_shrink.gemspec +++ b/link_shrink.gemspec @@ -22,6 +22,6 @@ spec.add_dependency 'typhoeus', '~> 0.6.3' spec.add_development_dependency 'bundler', '~> 1.3' - spec.add_development_dependency 'rspec', '~> 2.13.0' + spec...
Update gemspec dev_dependency for new versions of rspec
diff --git a/AvitoMediaPicker.podspec b/AvitoMediaPicker.podspec index abc1234..def5678 100644 --- a/AvitoMediaPicker.podspec +++ b/AvitoMediaPicker.podspec @@ -1,7 +1,7 @@ Pod::Spec.new do |s| s.name = 'AvitoMediaPicker' s.module_name = 'AvitoMediaPicker' - s.version ...
Change podspec version to 0.0.0
diff --git a/test/data/models.rb b/test/data/models.rb index abc1234..def5678 100644 --- a/test/data/models.rb +++ b/test/data/models.rb @@ -56,7 +56,7 @@ end class UppercaseTableName < ActiveRecord::Base - set_table_name "UPPERCASE_TABLE_NAME" + self.table_name = "UPPERCASE_TABLE_NAME" translates :name end
Fix for deprecation in Rails 3.2
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -6,4 +6,4 @@ gem 'minitest' require 'minitest/autorun' require 'minitest/pride' - +require 'pry'
Add pry to test helper
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -6,6 +6,9 @@ require 'database_cleaner' require 'database_cleaner/active_record/base' require 'awesome_print' +require 'minitest/reporters' + +MiniTest::Reporters.use! Rails.b...
Add support for Rubymine test/unit reporter
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,5 +1,4 @@-ENV["RAILS_ENV"] = "test" - +ENV["RAILS_ENV"] ||= "test" require File.expand_path('../../config/environment', __FILE__) require 'minitest/autorun' @@ -41,21 +40,6 ...
Remove some unecessary test setup clearance/test_unit , should take care of the clearance session setup capybara/rails , should take care of the capybara app setup
diff --git a/app/controllers/questions_controller.rb b/app/controllers/questions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/questions_controller.rb +++ b/app/controllers/questions_controller.rb @@ -35,3 +35,20 @@ erb :'/questions/show' end end + +get '/questions/:id/edit' do + @question ...
Add route for editing question
diff --git a/app/admin/dashboard.rb b/app/admin/dashboard.rb index abc1234..def5678 100644 --- a/app/admin/dashboard.rb +++ b/app/admin/dashboard.rb @@ -1,5 +1,4 @@ ActiveAdmin.register_page "Dashboard" do - menu :priority => 0, :label => proc{ I18n.t("active_admin.dashboard") } content :title => proc{ I18n.t("...
Add some info to dashbard
diff --git a/app/models/gem_typo.rb b/app/models/gem_typo.rb index abc1234..def5678 100644 --- a/app/models/gem_typo.rb +++ b/app/models/gem_typo.rb @@ -14,6 +14,8 @@ end def protected_typo? + return false + return false if @rubygem_name.size < GemTypo::SIZE_THRESHOLD gem_typo_exceptions = GemTypo...
Disable typo protection for now This is a good idea, but it's blocking a lot of legitimate gems, and it's too hard for our limited support time to go to manually allowing gems through. A Slack feed of gems that look like they might be typos to allow humans to review would be a more practical way to implement this sor...
diff --git a/app/models/key_pair.rb b/app/models/key_pair.rb index abc1234..def5678 100644 --- a/app/models/key_pair.rb +++ b/app/models/key_pair.rb @@ -23,7 +23,7 @@ private_key_path = dir_path + 'id_rsa' public_key_path = dir_path + 'id_rsa.pub' - unless system("ssh-keygen -f #{private_key_path} -P '' -...
Enforce PEM format when generating private key
diff --git a/app/controllers/calendars_controller.rb b/app/controllers/calendars_controller.rb index abc1234..def5678 100644 --- a/app/controllers/calendars_controller.rb +++ b/app/controllers/calendars_controller.rb @@ -2,38 +2,45 @@ class CalendarsController < ApplicationController def show - @categories = Ca...
Make the calendars controller a little easier to understand This shows some points for future extractions
diff --git a/test/test_header.rb b/test/test_header.rb index abc1234..def5678 100644 --- a/test/test_header.rb +++ b/test/test_header.rb @@ -0,0 +1,22 @@+require 'minitest/autorun' +require 'node' +require 'header' + +class TestHeader < MiniTest::Test + + def setup + # Initialize nodes + @header = Header.new + ...
Test added for calculating header node total
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -4,8 +4,9 @@ ENV["RAILS_ENV"] = "test" require File.expand_path("../../test/dummy/config/environment.rb", __FILE__) + ActiveRecord::Migration.verbose = false -ENV['VERBOSE'] = ...
Return of the verbosity of Shut Up 'n Play Yer Migrations
diff --git a/app/models/coursewareable/assignment.rb b/app/models/coursewareable/assignment.rb index abc1234..def5678 100644 --- a/app/models/coursewareable/assignment.rb +++ b/app/models/coursewareable/assignment.rb @@ -7,7 +7,7 @@ extend FriendlyId include PublicActivity::Model - attr_accessible :conten...
Add quiz attr to accessible list.
diff --git a/app/models/notification_subscription.rb b/app/models/notification_subscription.rb index abc1234..def5678 100644 --- a/app/models/notification_subscription.rb +++ b/app/models/notification_subscription.rb @@ -25,6 +25,10 @@ !self.confirmation_sent_at.nil? end + def override_last_email_sent_at_to!(...
Add method to NotificationSubscription that allows overriding the last_email_sent_at attribute
diff --git a/lib/bigcommerce_api/option_set_option.rb b/lib/bigcommerce_api/option_set_option.rb index abc1234..def5678 100644 --- a/lib/bigcommerce_api/option_set_option.rb +++ b/lib/bigcommerce_api/option_set_option.rb @@ -18,5 +18,21 @@ def parent 'option_set' end + + def find_for_reload + se...
Add custom find query for option set options
diff --git a/lib/brakeman/processors/gem_processor.rb b/lib/brakeman/processors/gem_processor.rb index abc1234..def5678 100644 --- a/lib/brakeman/processors/gem_processor.rb +++ b/lib/brakeman/processors/gem_processor.rb @@ -40,7 +40,7 @@ end def get_rails_version gem_lock - if gem_lock =~ /\srails \((\d+.\d+...
Allow pre-release Rails versions in Gemfile.lock
diff --git a/lib/compare_linker/github_link_finder.rb b/lib/compare_linker/github_link_finder.rb index abc1234..def5678 100644 --- a/lib/compare_linker/github_link_finder.rb +++ b/lib/compare_linker/github_link_finder.rb @@ -1,5 +1,6 @@ require "json" require "httpclient" +require "net/http" class CompareLinker ...
Fix raise error which github url is redirect one Ex. https://rubygems.org/gems/chef
diff --git a/lib/sequent/core/helpers/self_applier.rb b/lib/sequent/core/helpers/self_applier.rb index abc1234..def5678 100644 --- a/lib/sequent/core/helpers/self_applier.rb +++ b/lib/sequent/core/helpers/self_applier.rb @@ -19,12 +19,11 @@ module ClassMethods def on(*message_classes, &block) - ...
Fix handling events on super classes Use a class hierarchy variable to track event message handlers so that a super class can handle certain events. Specifically this is necessary to handle `SnapshotEvent` in `AggregateRoot`.
diff --git a/app/models/source.rb b/app/models/source.rb index abc1234..def5678 100644 --- a/app/models/source.rb +++ b/app/models/source.rb @@ -1,8 +1,8 @@ class Source < ApplicationRecord class UnknownRankable < StandardError; end has_many :imports - validates :name, presence: true + validates :name, presen...
Add uniqueness validation to Source
diff --git a/app/models/status.rb b/app/models/status.rb index abc1234..def5678 100644 --- a/app/models/status.rb +++ b/app/models/status.rb @@ -1,3 +1,11 @@ class Status < ActiveRecord::Base belongs_to :user + + def to_s + if lcd.nil? + "#{text}" + else + "#{text} [#{lcd}]" + end + end end
Add a to_s method to the Status model Before this method was defined, just doing a <%= status %> showed a #<Status::x123...> because that was the default Ruby inspection!
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -8,6 +8,7 @@ require "uri" def description_text(text) + text = text.to_s URI.extract(text, ['http', 'https'])...
Support nil description of user.
diff --git a/telemetry.gemspec b/telemetry.gemspec index abc1234..def5678 100644 --- a/telemetry.gemspec +++ b/telemetry.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'telemetry' - s.version = '0.1.2' + s.version = '0.1.3' s.summary = 'In-process telemetry based on ob...
Package version is increased from 0.1.2 to 0.1.3
diff --git a/Casks/silverlight.rb b/Casks/silverlight.rb index abc1234..def5678 100644 --- a/Casks/silverlight.rb +++ b/Casks/silverlight.rb @@ -1,7 +1,7 @@ class Silverlight < Cask - url 'http://silverlight.dlservice.microsoft.com/download/B/A/9/BA94BEC9-5DBC-4B50-BC2B-046A42399067/30214.00/Silverlight.dmg' + url 'h...
Update Silverlight to version 5.1.30317
diff --git a/lib/chef/provisioning/machine_spec.rb b/lib/chef/provisioning/machine_spec.rb index abc1234..def5678 100644 --- a/lib/chef/provisioning/machine_spec.rb +++ b/lib/chef/provisioning/machine_spec.rb @@ -21,13 +21,6 @@ def attrs data['normal'] ||= {} data['normal']['chef_provisioning'] ||= {}...
Use the actual `name` from the superclass, else we get caught in a loop
diff --git a/lib/feidee_utils/record/namespaced.rb b/lib/feidee_utils/record/namespaced.rb index abc1234..def5678 100644 --- a/lib/feidee_utils/record/namespaced.rb +++ b/lib/feidee_utils/record/namespaced.rb @@ -1,3 +1,5 @@+require 'set' + module FeideeUtils class Record module Namespaced
Add require set to namespace.
diff --git a/lib/protobuf/active_record/railtie.rb b/lib/protobuf/active_record/railtie.rb index abc1234..def5678 100644 --- a/lib/protobuf/active_record/railtie.rb +++ b/lib/protobuf/active_record/railtie.rb @@ -1,7 +1,7 @@ module Protobuf module ActiveRecord class Railtie < Rails::Railtie - config.protob...
Rename the config object to match the gem conventions.
diff --git a/attributes/tomcat.rb b/attributes/tomcat.rb index abc1234..def5678 100644 --- a/attributes/tomcat.rb +++ b/attributes/tomcat.rb @@ -13,5 +13,5 @@ # limitations under the License. override['tomcat']['deploy_manager_apps'] = false -override['tomcat']['java_options'] = '-Djava.awt.headless=true -Xmx512m -X...
Use a non-blocking entropy source to prevent insanely slow startups in Tomcat.
diff --git a/core/spec/ohm-models/graph_user_spec.rb b/core/spec/ohm-models/graph_user_spec.rb index abc1234..def5678 100644 --- a/core/spec/ohm-models/graph_user_spec.rb +++ b/core/spec/ohm-models/graph_user_spec.rb @@ -7,8 +7,8 @@ others end - subject {create :graph_user } - let(:fact) {create(:fact,:creat...
Use new hash syntax and fix spaces
diff --git a/config/initializers/toot_transformer.rb b/config/initializers/toot_transformer.rb index abc1234..def5678 100644 --- a/config/initializers/toot_transformer.rb +++ b/config/initializers/toot_transformer.rb @@ -1,4 +1,4 @@-if defined?(Rake) || Rails.env.test? +if Rails.env.test? || File.split($0).last == 'rak...
Improve rake detection to avoid connecting to twitter
diff --git a/lib/commontator/shared_helper.rb b/lib/commontator/shared_helper.rb index abc1234..def5678 100644 --- a/lib/commontator/shared_helper.rb +++ b/lib/commontator/shared_helper.rb @@ -3,21 +3,16 @@ def commontator_thread(commontable) user = Commontator.current_user_proc.call(self) thread = co...
Allow Avatar to simply use a string instead of gravatar use for my own app
diff --git a/test/dummy/app/controllers/application_controller.rb b/test/dummy/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/test/dummy/app/controllers/application_controller.rb +++ b/test/dummy/app/controllers/application_controller.rb @@ -1,3 +1,10 @@ class ApplicationController < Acti...
Add ability to flush per request for local testing.
diff --git a/lib/feed2email/feed_data_file.rb b/lib/feed2email/feed_data_file.rb index abc1234..def5678 100644 --- a/lib/feed2email/feed_data_file.rb +++ b/lib/feed2email/feed_data_file.rb @@ -9,11 +9,12 @@ end def uri=(new_uri) - if new_uri != uri - remove_file - mark_dirty - @uri ...
Make sure data is loaded before removing file Otherwise there will be nothing to sync
diff --git a/lib/formalist/output_compiler.rb b/lib/formalist/output_compiler.rb index abc1234..def5678 100644 --- a/lib/formalist/output_compiler.rb +++ b/lib/formalist/output_compiler.rb @@ -1,17 +1,5 @@-require "dry-data" - module Formalist class OutputCompiler - FORM_TYPES = %w[ - bool - date - ...
Stop coercing form post data in the output compiler Now that we require a schema, we can depend on that for form post data type coercions. Avoiding the coercions here means we also avoid errors due to the naive approach we’d taken so far. This was actually manifested in the formalist-demo app as errors when trying to ...
diff --git a/lib/kosmos/packages/hyperedit.rb b/lib/kosmos/packages/hyperedit.rb index abc1234..def5678 100644 --- a/lib/kosmos/packages/hyperedit.rb +++ b/lib/kosmos/packages/hyperedit.rb @@ -0,0 +1,8 @@+class Hyperedit < Kosmos::Package + title 'Hyperedit' + url 'http://www.kerbaltekaerospace.com/?download=hyperedi...
Add a package for Hyperedit.
diff --git a/lib/specinfra/command/freebsd.rb b/lib/specinfra/command/freebsd.rb index abc1234..def5678 100644 --- a/lib/specinfra/command/freebsd.rb +++ b/lib/specinfra/command/freebsd.rb @@ -26,6 +26,10 @@ def get_mode(file) "stat -f%Lp #{escape(file)}" end + + def install(package) + ...
Support `install` command on FreeBSD
diff --git a/Fibonacci_series/Ruby/jcla1/fib_test.rb b/Fibonacci_series/Ruby/jcla1/fib_test.rb index abc1234..def5678 100644 --- a/Fibonacci_series/Ruby/jcla1/fib_test.rb +++ b/Fibonacci_series/Ruby/jcla1/fib_test.rb @@ -0,0 +1,56 @@+require 'rspec' +require './fib' + +describe '#fib(n)' do + context 'When given 0' do...
Add spec to test fib.rb.
diff --git a/Casks/apache-directory-studio.rb b/Casks/apache-directory-studio.rb index abc1234..def5678 100644 --- a/Casks/apache-directory-studio.rb +++ b/Casks/apache-directory-studio.rb @@ -1,6 +1,6 @@ cask 'apache-directory-studio' do - version '2.0.0.v20150606-M9' - sha256 '9eca84d081a500fec84943600723782a6edac0...
Update Apache Directory Studio (2.0.0.v20151221-M10)
diff --git a/Library/Homebrew/unpack_strategy/air.rb b/Library/Homebrew/unpack_strategy/air.rb index abc1234..def5678 100644 --- a/Library/Homebrew/unpack_strategy/air.rb +++ b/Library/Homebrew/unpack_strategy/air.rb @@ -5,7 +5,8 @@ using Magic def self.can_extract?(path) - path.extname == ".air" + ...
Use magic number for Adobe Air.
diff --git a/SwiftJSONRPC.podspec b/SwiftJSONRPC.podspec index abc1234..def5678 100644 --- a/SwiftJSONRPC.podspec +++ b/SwiftJSONRPC.podspec @@ -7,7 +7,7 @@ s.author = { "Denis Kolyasev" => "kolyasev@gmail.com" } s.source = { :git => "https://github.com/kolyasev/SwiftJSONRPC.git", :tag => s.ver...
Fix iOS deployment target version in podspec
diff --git a/hubdown.gemspec b/hubdown.gemspec index abc1234..def5678 100644 --- a/hubdown.gemspec +++ b/hubdown.gemspec @@ -12,7 +12,7 @@ gem.summary = %q{CLI for GitHub Flavored markdown to html conversion} gem.homepage = "https://github.com/knomedia/hubdown" - gem.add_dependency 'github/markdown...
Correct syntax for gh markdown
diff --git a/lib/netsuite/records/bin_number_list.rb b/lib/netsuite/records/bin_number_list.rb index abc1234..def5678 100644 --- a/lib/netsuite/records/bin_number_list.rb +++ b/lib/netsuite/records/bin_number_list.rb @@ -2,7 +2,7 @@ module Records # TODO this is fairly messy: shouldn't mix multiple classes in on...
Refactor BinNumberList to use Support::Lists
diff --git a/lib/rmre/active_record/schema_dumper.rb b/lib/rmre/active_record/schema_dumper.rb index abc1234..def5678 100644 --- a/lib/rmre/active_record/schema_dumper.rb +++ b/lib/rmre/active_record/schema_dumper.rb @@ -23,13 +23,5 @@ trailer(stream) stream end - - def self.dump_table(table_name, ...
Revert - we will not work with table dumps
diff --git a/swipe-rails.gemspec b/swipe-rails.gemspec index abc1234..def5678 100644 --- a/swipe-rails.gemspec +++ b/swipe-rails.gemspec @@ -14,7 +14,7 @@ gem.name = "swipe-rails" gem.require_paths = ["lib"] gem.version = SwipeRails::VERSION - gem.add_dependency 'rails', '~> 3.2.13' + gem.add_d...
Allow to be used with Rails 4
diff --git a/EventEmitter.podspec b/EventEmitter.podspec index abc1234..def5678 100644 --- a/EventEmitter.podspec +++ b/EventEmitter.podspec @@ -0,0 +1,16 @@+Pod::Spec.new do |spec| + spec.name = 'EventEmitter' + spec.summary = 'Node.js inspired EventEmitter for Objective C.' + spec.version ...
Add local CocoaPods spec file.
diff --git a/rails/app/controllers/home_controller.rb b/rails/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/rails/app/controllers/home_controller.rb +++ b/rails/app/controllers/home_controller.rb @@ -9,11 +9,10 @@ end def search - @postcode = params[:query] if params[:query] =~ /^\d{4...
Rework to make it clearer what this is doing
diff --git a/rb/lib/selenium/webdriver/common/wait.rb b/rb/lib/selenium/webdriver/common/wait.rb index abc1234..def5678 100644 --- a/rb/lib/selenium/webdriver/common/wait.rb +++ b/rb/lib/selenium/webdriver/common/wait.rb @@ -3,14 +3,14 @@ class Wait DEFAULT_TIMEOUT = 5 - DEFAULT_INTERVAL = 0.5 + ...
JariBakken: Reduce the polling interval in Ruby's Wait class. git-svn-id: aa1aa1384423cb28c2b1e29129bb3a91de1d9196@15890 07704840-8298-11de-bf8c-fd130f914ac9
diff --git a/app/mutations/saved_gardens/snapshot.rb b/app/mutations/saved_gardens/snapshot.rb index abc1234..def5678 100644 --- a/app/mutations/saved_gardens/snapshot.rb +++ b/app/mutations/saved_gardens/snapshot.rb @@ -7,14 +7,14 @@ def execute SavedGarden.transaction do - binding.pry + # b...
Add tests for files that were lacking them
diff --git a/api/standard_sets.rb b/api/standard_sets.rb index abc1234..def5678 100644 --- a/api/standard_sets.rb +++ b/api/standard_sets.rb @@ -21,7 +21,8 @@ end - post "/", hidden: true do + desc "To preview the results of a standard set query, we call this api." + post "/from_query", hidden:...
Change endpoint for generating standard set from query
diff --git a/test/filter_test.rb b/test/filter_test.rb index abc1234..def5678 100644 --- a/test/filter_test.rb +++ b/test/filter_test.rb @@ -11,7 +11,7 @@ end end - teardown do + setup do Filter.instance_variable_set(:@instance, nil) end
Fix some random test failures
diff --git a/app/models/commit.rb b/app/models/commit.rb index abc1234..def5678 100644 --- a/app/models/commit.rb +++ b/app/models/commit.rb @@ -1,17 +1,25 @@ class Commit < ActiveRecord::Base validates_format_of :sha1, :with => /^[a-z0-9]+$/ validates_length_of :sha1, :is => 40 + + def check_valid + if ! sel...
Refactor and clean up diff model a little
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -18,7 +18,7 @@ end def teardown_db - ActiveRecord::Base.connection.tables.each do |table| + ActiveRecord::Base.connection.data_sources.each do |table| ActiveRecord::Base....
Fix deprecation warnings in tests
diff --git a/spec/unit/assertions_spec.rb b/spec/unit/assertions_spec.rb index abc1234..def5678 100644 --- a/spec/unit/assertions_spec.rb +++ b/spec/unit/assertions_spec.rb @@ -9,7 +9,9 @@ it "passes asertion by performing 10K ips" do bench = Benchmark::Perf - assertion = bench.assert_perform_ips(10_000, wa...
Change to reduce test time
diff --git a/Casks/playback.rb b/Casks/playback.rb index abc1234..def5678 100644 --- a/Casks/playback.rb +++ b/Casks/playback.rb @@ -1,6 +1,6 @@ cask :v1 => 'playback' do - version '1.3.0' - sha256 'e161c0589f57f840428e946f3d12301377cdcb9aaba79a5f39c1a5048314b944' + version '1.3.1' + sha256 'bffca6b43363b8a0a511eae...
Update Playback.app to version 1.3.1
diff --git a/spec/source_spec.rb b/spec/source_spec.rb index abc1234..def5678 100644 --- a/spec/source_spec.rb +++ b/spec/source_spec.rb @@ -0,0 +1,41 @@+# encoding: utf-8 + +require 'spec_helper' + +describe 'kafka::source' do + let :chef_run do + ChefSpec::ChefRunner.new(platform: 'centos', version: '6.4').conver...
Add basic specs for source recipe
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -20,4 +20,13 @@ config.expect_with :rspec do |expect| expect.syntax = :expect end + + if ENV['CI'] + config.before(:example, :focus) { raise "Do not commit focused sp...
Enable running specific tests with focus: true
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -16,7 +16,6 @@ RSpec.configure do |config| config.use_transactional_fixtures = true config.infer_base_class_for_anonymous_controllers = false - config.treat_symbols_as_metad...
Fix deprecation warning on treat_symbols_as_metadata_keys_with_true_values It is now set to true as default and setting it to false has no effect.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -10,7 +10,7 @@ VCR.configure do |config| config.cassette_library_dir = "spec/fixtures/cassettes" config.hook_into :webmock - config.filter_sensitive_data("__SPTRANS_TOKEN__"...
Create a namespace for spec environment helpers.