diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/models/startup.rb b/app/models/startup.rb index abc1234..def5678 100644 --- a/app/models/startup.rb +++ b/app/models/startup.rb @@ -1,6 +1,5 @@ class Startup < ActiveRecord::Base belongs_to :user - # has_and_belongs_to_many :markets # Alias for acts_as_taggable_on :tags acts_as_ordered_taggab...
Remove commented out markets setter method
diff --git a/SwiftyReceiptValidator.podspec b/SwiftyReceiptValidator.podspec index abc1234..def5678 100644 --- a/SwiftyReceiptValidator.podspec +++ b/SwiftyReceiptValidator.podspec @@ -11,7 +11,7 @@ s.swift_version = '5.0' s.requires_arc = true -s.ios.deployment_target = '10.3' +s.ios.deployment_target = '11.0' s...
Update pod spec deployment target to ios 11.0
diff --git a/attributes/default.rb b/attributes/default.rb index abc1234..def5678 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -21,4 +21,4 @@ default[:seyren][:application_name] = 'seyren' default[:seyren][:application_path] = '/opt/seyren' default[:seyren][:application_version] = '1.0.0' -defaul...
Change war uri to bintray. Chef have some probleme with github's redirect.
diff --git a/test/tss_test.rb b/test/tss_test.rb index abc1234..def5678 100644 --- a/test/tss_test.rb +++ b/test/tss_test.rb @@ -6,6 +6,6 @@ end def test_it_does_something_useful - assert false + assert true end end
Make all skeleton tests pass to test travis-ci integration
diff --git a/app/models/fluentd/agent/td_agent/unix.rb b/app/models/fluentd/agent/td_agent/unix.rb index abc1234..def5678 100644 --- a/app/models/fluentd/agent/td_agent/unix.rb +++ b/app/models/fluentd/agent/td_agent/unix.rb @@ -4,16 +4,20 @@ module Unix def start backup_running_config do - ...
Use systemctl instead of /etc/init.d/td-agent Because td-agent3 supports systemd. Signed-off-by: Kenji Okimoto <7a4b90a0a1e6fc688adec907898b6822ce215e6c@clear-code.com>
diff --git a/app/presenters/jadu_xml/file_presenter.rb b/app/presenters/jadu_xml/file_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/jadu_xml/file_presenter.rb +++ b/app/presenters/jadu_xml/file_presenter.rb @@ -8,7 +8,7 @@ end def checksum - Digest::MD5.file(represented.path).hexdigest...
Use hexdigest so we get the checksum when we use S3
diff --git a/app/serializers/api/v1/user_serializer.rb b/app/serializers/api/v1/user_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/api/v1/user_serializer.rb +++ b/app/serializers/api/v1/user_serializer.rb @@ -11,11 +11,42 @@ end link(:self) { api_user_path(object.id) } - link(:gi...
Return metadata for user links in V1 API
diff --git a/lib/buckaruby/currency.rb b/lib/buckaruby/currency.rb index abc1234..def5678 100644 --- a/lib/buckaruby/currency.rb +++ b/lib/buckaruby/currency.rb @@ -3,5 +3,7 @@ module Buckaruby module Currency EURO = "EUR" + BRITISH_POUND = "GBP" + US_DOLLAR = "USD" end end
Add currencies GBP and USD.
diff --git a/spec/support/shoulda/matchers/rails_shim.rb b/spec/support/shoulda/matchers/rails_shim.rb index abc1234..def5678 100644 --- a/spec/support/shoulda/matchers/rails_shim.rb +++ b/spec/support/shoulda/matchers/rails_shim.rb @@ -0,0 +1,27 @@+# monkey patch which fixes serialization matcher in Rails 5 +# https:/...
Fix shoulda-matchers in Rails 5 Backports a fix for https://github.com/thoughtbot/shoulda-matchers/issues/913. This can be removed once new shoulda-matchers version is released.
diff --git a/lib/kosmos/package_dsl.rb b/lib/kosmos/package_dsl.rb index abc1234..def5678 100644 --- a/lib/kosmos/package_dsl.rb +++ b/lib/kosmos/package_dsl.rb @@ -6,9 +6,5 @@ FileUtils.cp_r(File.join(@download_dir, from), File.join(@ksp_path, destination)) end - - def remove(path, opts = {}...
Revert "add the options for packages to remove file or folders in their install scripts"
diff --git a/test/test_verbose_formatter.rb b/test/test_verbose_formatter.rb index abc1234..def5678 100644 --- a/test/test_verbose_formatter.rb +++ b/test/test_verbose_formatter.rb @@ -1,14 +1,29 @@ require_relative './helper' class VerboseFormatterTest < Test::Unit::TestCase + class ErrorHighlightDummyFormatter + ...
Disable error_highlight when testing did_you_mean Fixes #160
diff --git a/app/helpers/campaign_helper.rb b/app/helpers/campaign_helper.rb index abc1234..def5678 100644 --- a/app/helpers/campaign_helper.rb +++ b/app/helpers/campaign_helper.rb @@ -6,27 +6,24 @@ end def formatted_organisation_name(publication) - organisation_name = organisation_attr(publication, 'formatte...
Refactor campaign helper organisation methods Previously the organisation_attr method was doing 2 things - • checking the publication has organisation details • accessing a value from those details Refactored to only do the checking, as we want to use the attributes in a different way to fix a bug.
diff --git a/app/models/product_category.rb b/app/models/product_category.rb index abc1234..def5678 100644 --- a/app/models/product_category.rb +++ b/app/models/product_category.rb @@ -9,6 +9,9 @@ scope :by_enterprise, lambda { |enterprise| { :joins => :products, :conditions => ['products.profile_id = ?', e...
Add scope to search product categories by environment
diff --git a/lib/archetype/resourceful/parameters.rb b/lib/archetype/resourceful/parameters.rb index abc1234..def5678 100644 --- a/lib/archetype/resourceful/parameters.rb +++ b/lib/archetype/resourceful/parameters.rb @@ -6,7 +6,7 @@ included do define_method "#{resource_instance_name}_params" do ...
Fix params for extracted attributes
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -22,5 +22,7 @@ # Do not swallow errors in after_commit/after_rollback callbacks. config.active_record.raise_in_transactional_callbacks = true + + config.time_...
Configure timezone so times show in Pacific time by default
diff --git a/lib/codelation/development/dot_files.rb b/lib/codelation/development/dot_files.rb index abc1234..def5678 100644 --- a/lib/codelation/development/dot_files.rb +++ b/lib/codelation/development/dot_files.rb @@ -6,12 +6,16 @@ # Install dot files and load them into ~/.bash_profile def install_dot_fil...
Add source ~/.codelation.bash to ~/.bash_profile
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -1,16 +1,9 @@ require File.expand_path('../boot', __FILE__) -# Silence warnings while loading Rails gems, since we're using Ruby 2.6 and Rails 4, -# we would otherwise ge...
Revert "silence warnings while loading rails gems" This reverts commit 171ea5edcd8ca5374deb809690f86f61caeba8d9.
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -21,6 +21,7 @@ # config.i18n.default_locale = :de config.assets.precompile << /\.(?:svg|eot|woff|ttf)$/ + config.assets.precompile << 'base.js' # Requi...
Add base.js to assets:precompile list. base.js was not being precompiled in production, which broke pages that relied on its presence.
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -24,7 +24,7 @@ # Do not swallow errors in after_commit/after_rollback callbacks. config.active_record.raise_in_transactional_callbacks = true - # Here we're s...
Raise error if variable MWL_DIR is not set.
diff --git a/config/initializers/cookies_serializer.rb b/config/initializers/cookies_serializer.rb index abc1234..def5678 100644 --- a/config/initializers/cookies_serializer.rb +++ b/config/initializers/cookies_serializer.rb @@ -1,3 +1,3 @@ # Be sure to restart your server when you modify this file. -Rails.applicatio...
Fix bug with devise and mongoid current_user, user_signed_in ... works :)
diff --git a/app/application.rb b/app/application.rb index abc1234..def5678 100644 --- a/app/application.rb +++ b/app/application.rb @@ -2,25 +2,18 @@ module CherryTomato class Application < Sinatra::Base - use AssetLoader + use AssetsHelper + use SessionsHelper + + helpers SessionsHelper::UserSession ...
Add after Twitter login logic
diff --git a/spec/requests/healthcheck_spec.rb b/spec/requests/healthcheck_spec.rb index abc1234..def5678 100644 --- a/spec/requests/healthcheck_spec.rb +++ b/spec/requests/healthcheck_spec.rb @@ -1,6 +1,13 @@ RSpec.describe "/healthcheck" do + before do + get "/healthcheck" + end + + it "returns a 200 HTTP statu...
Add 200 ok healthcheck test
diff --git a/spec/unit/install_command_spec.rb b/spec/unit/install_command_spec.rb index abc1234..def5678 100644 --- a/spec/unit/install_command_spec.rb +++ b/spec/unit/install_command_spec.rb @@ -18,11 +18,23 @@ describe "When the Podfile does not specify the xcodeproject" do before do config.stubs(:root...
Raise an informative error when Podfile specifies xcodeproj to an invalid path
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -15,18 +15,16 @@ end def self.find(id) return nil unless id.present? - Rails.cache.fetch("/api/users/#{id}.json") do user = super id - user.groups.each do |gro...
Fix drop down menu authentication
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,9 +1,14 @@ class User < ActiveRecord::Base before_save :set_permission - has_one :recent_post, class_name: "Space", foreign_key: "poster_id" + has_many :spaces, foreign_key: "post...
Fix some shit...delete post issues. Add associaiton
diff --git a/lib/analytical/modules/google_universal.rb b/lib/analytical/modules/google_universal.rb index abc1234..def5678 100644 --- a/lib/analytical/modules/google_universal.rb +++ b/lib/analytical/modules/google_universal.rb @@ -20,6 +20,8 @@ ga('create', '#{options[:key]}', '#{options[:domain]}'); ...
Add bounce rate fix to Google UA settings
diff --git a/lib/rubocop/cop/rspec/instance_variable.rb b/lib/rubocop/cop/rspec/instance_variable.rb index abc1234..def5678 100644 --- a/lib/rubocop/cop/rspec/instance_variable.rb +++ b/lib/rubocop/cop/rspec/instance_variable.rb @@ -23,6 +23,8 @@ MESSAGE = 'Use `let` instead of an instance variable'.freeze ...
Change RSpec/InstanceVariable to only check specs Fixes #115
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -24,6 +24,5 @@ config.autoload_paths += Dir["#{config.root}/lib/**/"] config.assets.precompile += %w( bootstrap-material.css ) config.active_record.raise_in_t...
Remove dalli store from global config
diff --git a/lib/active_ums/extensions/kaminari.rb b/lib/active_ums/extensions/kaminari.rb index abc1234..def5678 100644 --- a/lib/active_ums/extensions/kaminari.rb +++ b/lib/active_ums/extensions/kaminari.rb @@ -44,5 +44,6 @@ end ActiveUMS::Base.send(:include, Kaminari::ActiveUMS::ActiveUMSExtension) +ActiveUMS::Re...
Include ActiveUMSExtension to Relation for Kaminari extension
diff --git a/mipt/app/controllers/courses_controller.rb b/mipt/app/controllers/courses_controller.rb index abc1234..def5678 100644 --- a/mipt/app/controllers/courses_controller.rb +++ b/mipt/app/controllers/courses_controller.rb @@ -1,5 +1,6 @@ class CoursesController < ApplicationController def index + @courses ...
Complete index action in courses controller
diff --git a/btc_ticker.gemspec b/btc_ticker.gemspec index abc1234..def5678 100644 --- a/btc_ticker.gemspec +++ b/btc_ticker.gemspec @@ -21,7 +21,7 @@ spec.require_paths = ["lib"] spec.add_development_dependency "bundler", "~> 1.14" - spec.add_development_dependency "rake", "~> 10.0" + spec.add_development_dep...
Update Rake from 10.0 to 12.0
diff --git a/lib/rails_4_session_flash_backport.rb b/lib/rails_4_session_flash_backport.rb index abc1234..def5678 100644 --- a/lib/rails_4_session_flash_backport.rb +++ b/lib/rails_4_session_flash_backport.rb @@ -7,6 +7,8 @@ require 'rails_4_session_flash_backport/rails2/session_with_indifferent_access' when 3 re...
Add Rails 4 specific warning
diff --git a/lib/trogdir/versions/v1/photos_api.rb b/lib/trogdir/versions/v1/photos_api.rb index abc1234..def5678 100644 --- a/lib/trogdir/versions/v1/photos_api.rb +++ b/lib/trogdir/versions/v1/photos_api.rb @@ -21,8 +21,8 @@ params do requires :type, type: Symbol, values: Photo::TYPES re...
Make photo height and width required to match the requirements of the model
diff --git a/library/zlib/gzipwriter/write_spec.rb b/library/zlib/gzipwriter/write_spec.rb index abc1234..def5678 100644 --- a/library/zlib/gzipwriter/write_spec.rb +++ b/library/zlib/gzipwriter/write_spec.rb @@ -31,6 +31,6 @@ Zlib::GzipWriter.wrap @io do |gzio| gzio.write input end - @io.string.size...
Fix expectation in a zlib spec
diff --git a/config/initializers/gds-sso.rb b/config/initializers/gds-sso.rb index abc1234..def5678 100644 --- a/config/initializers/gds-sso.rb +++ b/config/initializers/gds-sso.rb @@ -1,6 +1,6 @@ GDS::SSO.config do |config| config.user_model = "User" - config.oauth_id = ENV["OAUTH_ID"] - config.oauth_secret = ENV...
Add fallback OAuth ID and secret This commit adds a fallback OAuth ID and secret. This will allow the signon-munging script for development to configure signon for this app locally.
diff --git a/spec/helpers/application_helper/buttons/instance_migrate.rb b/spec/helpers/application_helper/buttons/instance_migrate.rb index abc1234..def5678 100644 --- a/spec/helpers/application_helper/buttons/instance_migrate.rb +++ b/spec/helpers/application_helper/buttons/instance_migrate.rb @@ -0,0 +1,40 @@+descri...
Add test for the Live Migrate button class
diff --git a/spec/unit/rom/support/deprecations_spec.rb b/spec/unit/rom/support/deprecations_spec.rb index abc1234..def5678 100644 --- a/spec/unit/rom/support/deprecations_spec.rb +++ b/spec/unit/rom/support/deprecations_spec.rb @@ -3,7 +3,7 @@ RSpec.describe ROM::Deprecations do let(:log_file) do - Tempfile.ne...
Fix specs for older rubies
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -2,4 +2,24 @@ # Prevent CSRF attacks by raising an exception. # For APIs, you may want ...
Configure devise methods in application controller
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -3,8 +3,21 @@ # For APIs, you may want to use :null_session instead. protect_from_forge...
Add locale handling to the controller This will parse the "locale" parameter, and append to any local URLs. Use it like: http://localhost:3000/?locale=es
diff --git a/app/mailers/semi_static/comment_mailer.rb b/app/mailers/semi_static/comment_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/semi_static/comment_mailer.rb +++ b/app/mailers/semi_static/comment_mailer.rb @@ -5,7 +5,7 @@ email = SemiStatic::Engine.config.has?('comment_email') || SemiStatic::En...
Fix host name bug in URL for blog comments
diff --git a/app/overrides/add_klarna_error_message.rb b/app/overrides/add_klarna_error_message.rb index abc1234..def5678 100644 --- a/app/overrides/add_klarna_error_message.rb +++ b/app/overrides/add_klarna_error_message.rb @@ -1,10 +1,3 @@-Deface::Override.new( - virtual_path: "spree/admin/orders/edit", - insert_to...
Remove Klarna warning message from Shipments As the information that is displayed in shipments will not affect Klarana's security information it is safe to modify it.
diff --git a/app/serializers/feed_import_serializer.rb b/app/serializers/feed_import_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/feed_import_serializer.rb +++ b/app/serializers/feed_import_serializer.rb @@ -29,6 +29,8 @@ :created_at, :updated_at + has_many :feed_sched...
Add has_many :feed_schedule_imports to FeedImport serializer
diff --git a/spec/default_spec.rb b/spec/default_spec.rb index abc1234..def5678 100644 --- a/spec/default_spec.rb +++ b/spec/default_spec.rb @@ -21,7 +21,7 @@ let(:chef_run) do ChefSpec::SoloRunner.new( platform: 'centos', - version: '6.8' + version: '6.9' ).converge(described_r...
Update specs to the latest platform versions Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/app/services/network_visibility_service.rb b/app/services/network_visibility_service.rb index abc1234..def5678 100644 --- a/app/services/network_visibility_service.rb +++ b/app/services/network_visibility_service.rb @@ -4,15 +4,15 @@ field_names_to_edit = [] if show_dns_settings?(sysprep_enabled...
Fix rubocop warnings in NetworkVisibilityService
diff --git a/spec/quantum_spec.rb b/spec/quantum_spec.rb index abc1234..def5678 100644 --- a/spec/quantum_spec.rb +++ b/spec/quantum_spec.rb @@ -8,7 +8,7 @@ end describe '.leap' do - the_past = Time.new(1956, 9, 13, 15, 00) + let(:the_past) { Time.new(1956, 9, 13, 15, 00) } it 'changes the current t...
Use let instead of local variables
diff --git a/app/views/api/v1/notes/index.json.jbuilder b/app/views/api/v1/notes/index.json.jbuilder index abc1234..def5678 100644 --- a/app/views/api/v1/notes/index.json.jbuilder +++ b/app/views/api/v1/notes/index.json.jbuilder @@ -2,5 +2,8 @@ # json.extract! note, :id, :title, :body_text, :body_html, :created_at, :...
Add other notes attributes to returned JSON
diff --git a/app/models/manageiq/providers/ansible_operations_workflow.rb b/app/models/manageiq/providers/ansible_operations_workflow.rb index abc1234..def5678 100644 --- a/app/models/manageiq/providers/ansible_operations_workflow.rb +++ b/app/models/manageiq/providers/ansible_operations_workflow.rb @@ -0,0 +1,92 @@+cl...
Add a state machine for long ansible operations This adds a Job state machine for long running async ansible operations.
diff --git a/rails/attributes/rails.rb b/rails/attributes/rails.rb index abc1234..def5678 100644 --- a/rails/attributes/rails.rb +++ b/rails/attributes/rails.rb @@ -4,4 +4,4 @@ # log rotation via logrotate default[:rails][:logrotate][:interval] = 'daily' -default[:rails][:logrotate][:keep_for] = 365+default[:rails][...
Change default number of days logs hang out for now that we back them up off server.
diff --git a/railties/lib/rails/cli.rb b/railties/lib/rails/cli.rb index abc1234..def5678 100644 --- a/railties/lib/rails/cli.rb +++ b/railties/lib/rails/cli.rb @@ -6,7 +6,7 @@ Rails::ScriptRailsLoader.exec_script_rails! require 'rails/ruby_version_check' -Signal.trap("INT") { puts; exit } +Signal.trap("INT") { puts...
Exit with non-zero to signal failure.
diff --git a/lib/ello/kinesis_consumer/s3_processor.rb b/lib/ello/kinesis_consumer/s3_processor.rb index abc1234..def5678 100644 --- a/lib/ello/kinesis_consumer/s3_processor.rb +++ b/lib/ello/kinesis_consumer/s3_processor.rb @@ -7,15 +7,10 @@ def run! @stream_reader.run! do |record, opts| @log...
Revert "Add new relic tracking for s3 uploads" This reverts commit 20e9a892ed7b75853192b5bfeaf00b49654bf47e.
diff --git a/lib/mindbody-api/services/site_service.rb b/lib/mindbody-api/services/site_service.rb index abc1234..def5678 100644 --- a/lib/mindbody-api/services/site_service.rb +++ b/lib/mindbody-api/services/site_service.rb @@ -5,7 +5,7 @@ operation :get_sites operation :get_locations, :locals...
Add ability to pass locals to activation code
diff --git a/railties/test/commands/runner_test.rb b/railties/test/commands/runner_test.rb index abc1234..def5678 100644 --- a/railties/test/commands/runner_test.rb +++ b/railties/test/commands/runner_test.rb @@ -0,0 +1,61 @@+# frozen_string_literal: true + +require "isolation/abstract_unit" +require "rails/command" +r...
Add tests for rails runner * Refs #42007
diff --git a/app/models/breeze/pay_online/payment_form.rb b/app/models/breeze/pay_online/payment_form.rb index abc1234..def5678 100644 --- a/app/models/breeze/pay_online/payment_form.rb +++ b/app/models/breeze/pay_online/payment_form.rb @@ -18,8 +18,10 @@ save_data_to controller.session unl...
Create payment instead of Application
diff --git a/Casks/a-better-finder-rename.rb b/Casks/a-better-finder-rename.rb index abc1234..def5678 100644 --- a/Casks/a-better-finder-rename.rb +++ b/Casks/a-better-finder-rename.rb @@ -0,0 +1,7 @@+class ABetterFinderRename < Cask + url 'http://www.publicspace.net/download/ABFRX.dmg' + homepage 'http://www.publics...
Add A Better Findeer Ranem app
diff --git a/Casks/synology-cloud-station.rb b/Casks/synology-cloud-station.rb index abc1234..def5678 100644 --- a/Casks/synology-cloud-station.rb +++ b/Casks/synology-cloud-station.rb @@ -1,6 +1,6 @@ cask :v1 => 'synology-cloud-station' do - version '3.2-3484' - sha256 'aa544573ca9f7d3cb6693cba2406901a8b5e241eba0ed1...
Update Synology Cloud Station to v3.2-3487
diff --git a/spec/acceptance/statsd_exporter_spec.rb b/spec/acceptance/statsd_exporter_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/statsd_exporter_spec.rb +++ b/spec/acceptance/statsd_exporter_spec.rb @@ -0,0 +1,54 @@+require 'spec_helper_acceptance' + +describe 'prometheus statsd exporter' do + it 'st...
Add acceptance test for statsd_exporter
diff --git a/spec/features/pages/revisioning_spec.rb b/spec/features/pages/revisioning_spec.rb index abc1234..def5678 100644 --- a/spec/features/pages/revisioning_spec.rb +++ b/spec/features/pages/revisioning_spec.rb @@ -0,0 +1,27 @@+require 'spec_helper' + +describe 'pages revisioning' do + + before :each do + log...
Add basic revisioning flow spec
diff --git a/spec/helpers/fortitude_rails_helpers.rb b/spec/helpers/fortitude_rails_helpers.rb index abc1234..def5678 100644 --- a/spec/helpers/fortitude_rails_helpers.rb +++ b/spec/helpers/fortitude_rails_helpers.rb @@ -4,6 +4,16 @@ def rails_server_project_root @rails_server_project_root ||= File.expan...
Move the last of the Fortitude-specific stuff back into this gem.
diff --git a/spec/integration/serializable_spec.rb b/spec/integration/serializable_spec.rb index abc1234..def5678 100644 --- a/spec/integration/serializable_spec.rb +++ b/spec/integration/serializable_spec.rb @@ -4,7 +4,10 @@ class Serializable include Memoizable - def method; end + + def method + rand(10000)...
Add integration test for deserialization with Marshal
diff --git a/lib/capistrano/tasks/copy.rake b/lib/capistrano/tasks/copy.rake index abc1234..def5678 100644 --- a/lib/capistrano/tasks/copy.rake +++ b/lib/capistrano/tasks/copy.rake @@ -2,11 +2,14 @@ archive_name = "archive.tar.gz" include_dir = fetch(:include_dir) || "*" - exclude_dir = fetch(:exclude_dir) ||...
Fix --exclude argument order to work on OS X. Allow exlude_dir to be an Array
diff --git a/lib/jimsy/git/clone_service.rb b/lib/jimsy/git/clone_service.rb index abc1234..def5678 100644 --- a/lib/jimsy/git/clone_service.rb +++ b/lib/jimsy/git/clone_service.rb @@ -6,7 +6,7 @@ SAFE_HOSTS = %w[github.com bitbucket.org].freeze def initialize(uri, code_dir) - @uri = URI(uri)...
Make `git clone` work with ssh non-urls.
diff --git a/lib/list_pull_requests/user.rb b/lib/list_pull_requests/user.rb index abc1234..def5678 100644 --- a/lib/list_pull_requests/user.rb +++ b/lib/list_pull_requests/user.rb @@ -25,12 +25,16 @@ puts "Retrieving list of pulls....".red page = 1 begin - json = JSON.parse(open(url + "&page=#{page}...
Add preliminary error control for open-uri
diff --git a/lib/tasks/metadata_tagger.rake b/lib/tasks/metadata_tagger.rake index abc1234..def5678 100644 --- a/lib/tasks/metadata_tagger.rake +++ b/lib/tasks/metadata_tagger.rake @@ -2,5 +2,5 @@ desc "Apply metadata from the json file" task :tag_metadata do - Indexer::MetadataTagger.amend_indexes_for_file(file_pa...
Call 'amend_all_metadata' in tag_metadata task This was renamed in 1645f66.
diff --git a/dots-formatter/ruby/dots-formatter.gemspec b/dots-formatter/ruby/dots-formatter.gemspec index abc1234..def5678 100644 --- a/dots-formatter/ruby/dots-formatter.gemspec +++ b/dots-formatter/ruby/dots-formatter.gemspec @@ -1,12 +1,12 @@ # encoding: utf-8 Gem::Specification.new do |s| - s.name = 'dots...
Rename dots formatter Ruby gem to be idiomatic
diff --git a/db/migrate/20160117202815_create_sendings.rb b/db/migrate/20160117202815_create_sendings.rb index abc1234..def5678 100644 --- a/db/migrate/20160117202815_create_sendings.rb +++ b/db/migrate/20160117202815_create_sendings.rb @@ -0,0 +1,11 @@+class CreateSendings < ActiveRecord::Migration + def change + ...
Add sending migration to create sendings table
diff --git a/features/support/app_installation_hooks.rb b/features/support/app_installation_hooks.rb index abc1234..def5678 100644 --- a/features/support/app_installation_hooks.rb +++ b/features/support/app_installation_hooks.rb @@ -8,11 +8,13 @@ scenario = scenario.scenario_outline if scenario.respond_to?(:scenario_...
Change default behaviour to not reinstall apps when starting a new feature file
diff --git a/wateringServer/spec/controllers/waterings_controller_spec.rb b/wateringServer/spec/controllers/waterings_controller_spec.rb index abc1234..def5678 100644 --- a/wateringServer/spec/controllers/waterings_controller_spec.rb +++ b/wateringServer/spec/controllers/waterings_controller_spec.rb @@ -19,10 +19,16 @@...
Add test for errors on post to waterings
diff --git a/core/main/def_spec.rb b/core/main/def_spec.rb index abc1234..def5678 100644 --- a/core/main/def_spec.rb +++ b/core/main/def_spec.rb @@ -1,14 +1,27 @@ require File.expand_path('../../../spec_helper', __FILE__) require File.expand_path('../fixtures/classes', __FILE__) + +script_binding = binding describe...
Add specs for visibility of top level methods and script binding
diff --git a/lib/capistrano-nvie-git-workflow/tasks.rb b/lib/capistrano-nvie-git-workflow/tasks.rb index abc1234..def5678 100644 --- a/lib/capistrano-nvie-git-workflow/tasks.rb +++ b/lib/capistrano-nvie-git-workflow/tasks.rb @@ -28,13 +28,18 @@ end task :set_from_tag do - ENV['git_log_command'] = 'log -...
Choose deployment branch before git:commit_log
diff --git a/lib/elmas/resources/sales_invoice_line.rb b/lib/elmas/resources/sales_invoice_line.rb index abc1234..def5678 100644 --- a/lib/elmas/resources/sales_invoice_line.rb +++ b/lib/elmas/resources/sales_invoice_line.rb @@ -16,7 +16,7 @@ SHARED_LINE_ATTRIBUTES.inject( [ :employee, :end_ti...
Support setting ledger id on invoice lines
diff --git a/lib/coderay/encoders/token_class_filter.rb b/lib/coderay/encoders/token_class_filter.rb index abc1234..def5678 100644 --- a/lib/coderay/encoders/token_class_filter.rb +++ b/lib/coderay/encoders/token_class_filter.rb @@ -21,8 +21,9 @@ end def text_token text, kind - [text, kind] if !@exc...
TokenClassFilter: Support for :exclud => :all. git-svn-id: 3003a0d67ecddf9b67dc4af6cf35c502b83f6d3b@370 282260fa-4eda-c845-a9f0-6527b7353f92
diff --git a/lib/to_source/proc/parser19/extensions.rb b/lib/to_source/proc/parser19/extensions.rb index abc1234..def5678 100644 --- a/lib/to_source/proc/parser19/extensions.rb +++ b/lib/to_source/proc/parser19/extensions.rb @@ -4,12 +4,15 @@ module Extensions module Result + POS, TYP, VAL = 0...
Use constants instead of literal to ease maintenance.
diff --git a/lib/puppet/functions/get_opengrok_fname.rb b/lib/puppet/functions/get_opengrok_fname.rb index abc1234..def5678 100644 --- a/lib/puppet/functions/get_opengrok_fname.rb +++ b/lib/puppet/functions/get_opengrok_fname.rb @@ -4,7 +4,7 @@ end def get_opengrok_fname(opengrok_url) - a = opengrok_url.lines...
Use split rather than lines Signed-off-by: Jordan Conway <bb3bf96ee76b8b43aa7e5815135ed8d69362d4f1@linuxfoundation.org>
diff --git a/nanoc/lib/nanoc/filters/erb.rb b/nanoc/lib/nanoc/filters/erb.rb index abc1234..def5678 100644 --- a/nanoc/lib/nanoc/filters/erb.rb +++ b/nanoc/lib/nanoc/filters/erb.rb @@ -27,7 +27,7 @@ # Get result trim_mode = params[:trim_mode] - erb = ::ERB.new(content, nil, trim_mode) + erb = :...
Switch ERB to use keyword arguments Positional arguments were deprecated in Ruby 3. Change is backwards-compatible to Ruby 2.3. Resolves #1547.
diff --git a/spec/factories/axiom_selection_factory.rb b/spec/factories/axiom_selection_factory.rb index abc1234..def5678 100644 --- a/spec/factories/axiom_selection_factory.rb +++ b/spec/factories/axiom_selection_factory.rb @@ -1,14 +1,34 @@ FactoryGirl.define do factory :axiom_selection do - association :proof_...
Fix axiom selection factories not properly creating ProofAttempts.
diff --git a/app/models/fan.rb b/app/models/fan.rb index abc1234..def5678 100644 --- a/app/models/fan.rb +++ b/app/models/fan.rb @@ -18,7 +18,7 @@ end def debut_show - @debut_show ||= shows.last + @debut_show ||= shows.ordered.last end def shows_since_debut
Order shows properly for debut
diff --git a/spec/lib/training/training_loader_spec.rb b/spec/lib/training/training_loader_spec.rb index abc1234..def5678 100644 --- a/spec/lib/training/training_loader_spec.rb +++ b/spec/lib/training/training_loader_spec.rb @@ -1,24 +1,55 @@ # frozen_string_literal: true + require 'rails_helper' require "#{Rails.roo...
Extend TrainingLoader spec to test all training content classes
diff --git a/app/mailers/team_user_mailer.rb b/app/mailers/team_user_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/team_user_mailer.rb +++ b/app/mailers/team_user_mailer.rb @@ -6,8 +6,7 @@ @team = team @requestor = requestor @url = URI.join(origin, "/members") - @handle = requestor....
Fix team link and add user handle to email
diff --git a/app/models/categories/gender.rb b/app/models/categories/gender.rb index abc1234..def5678 100644 --- a/app/models/categories/gender.rb +++ b/app/models/categories/gender.rb @@ -20,5 +20,13 @@ "M" end end + + def men? + gender == "M" + end + + def women? + gender == "F"...
Add men? and women? convenience methods
diff --git a/app/models/unit_activity_set.rb b/app/models/unit_activity_set.rb index abc1234..def5678 100644 --- a/app/models/unit_activity_set.rb +++ b/app/models/unit_activity_set.rb @@ -1,6 +1,8 @@ class UnitActivitySet < ActiveRecord::Base belongs_to :unit belongs_to :activity_type + + has_many :campus_activ...
ENHANCE: Add has many relationship between unit and campus sets
diff --git a/app/presenters/gui_presenter.rb b/app/presenters/gui_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/gui_presenter.rb +++ b/app/presenters/gui_presenter.rb @@ -3,8 +3,8 @@ attr_reader :guis_info def initialize - @yaml = YAML.load_file('resources/guis.yml') - @guis_info = @yaml[...
Remove unneeded instance variable from GUI yaml parser
diff --git a/lib/jwt/jwk/rsa.rb b/lib/jwt/jwk/rsa.rb index abc1234..def5678 100644 --- a/lib/jwt/jwk/rsa.rb +++ b/lib/jwt/jwk/rsa.rb @@ -1,4 +1,6 @@ # frozen_string_literal: true + +require 'forwardable' module JWT module JWK
Add forwardable dependency for JWK RSA KeyFinder Fixes #316.
diff --git a/lib/rbvmomi/pbm.rb b/lib/rbvmomi/pbm.rb index abc1234..def5678 100644 --- a/lib/rbvmomi/pbm.rb +++ b/lib/rbvmomi/pbm.rb @@ -0,0 +1,66 @@+# Copyright (c) 2012 VMware, Inc. All Rights Reserved. +require 'rbvmomi' + +module RbVmomi + +# A connection to one vSphere ProfileBasedManagement endpoint. +# @see #se...
Add connection endpoint for PBM. Not functional without API definitions
diff --git a/lib/tasks/tmp.rake b/lib/tasks/tmp.rake index abc1234..def5678 100644 --- a/lib/tasks/tmp.rake +++ b/lib/tasks/tmp.rake @@ -8,6 +8,7 @@ Vendor.each(&:status) end + desc "Rebuilds the MPL Download .zip for all installed bundles" task mpl_download_rebuild: [:environment] do puts '...
Add a description to the mpl_download_rebuild task, and add that task to the bundle:download_and_install task after bundle installation
diff --git a/doc/rc_alive_check.rb b/doc/rc_alive_check.rb index abc1234..def5678 100644 --- a/doc/rc_alive_check.rb +++ b/doc/rc_alive_check.rb @@ -0,0 +1,49 @@+#!/usr/bin/env ruby + +require 'rubygems' +require 'omf_common' + +unless ARGV[0] && ARGV[1] + puts "Missing argument: The credential to connect to your XMPP...
Add a simple script to check if rc alive
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -3,7 +3,7 @@ end def search - @query = params[:query].blank? ? '*' : params[:query] + @query = params[:quer...
Rewrite query handling in a more idiomatic way
diff --git a/app/models/concerns/crop_search.rb b/app/models/concerns/crop_search.rb index abc1234..def5678 100644 --- a/app/models/concerns/crop_search.rb +++ b/app/models/concerns/crop_search.rb @@ -4,7 +4,14 @@ included do #################################### # Elastic search configuration - searchkic...
Add ElasticSearch mappings, to fix intermittent errors
diff --git a/app/mutations/tool_slots/create.rb b/app/mutations/tool_slots/create.rb index abc1234..def5678 100644 --- a/app/mutations/tool_slots/create.rb +++ b/app/mutations/tool_slots/create.rb @@ -2,11 +2,15 @@ class Create < Mutations::Command required do model :device, class: Device + integer :...
Make fields optional on API
diff --git a/spec/system/common_patterns_spec.rb b/spec/system/common_patterns_spec.rb index abc1234..def5678 100644 --- a/spec/system/common_patterns_spec.rb +++ b/spec/system/common_patterns_spec.rb @@ -18,13 +18,16 @@ it "should support an 'include' directive at the end of postgresql.conf" do pending('no ...
Fix selinux permissions for fedora tests Signed-off-by: Ken Barber <470bc578162732ac7f9d387d34c4af4ca6e1b6f7@bob.sh>
diff --git a/app/representers/api/episode_representer.rb b/app/representers/api/episode_representer.rb index abc1234..def5678 100644 --- a/app/representers/api/episode_representer.rb +++ b/app/representers/api/episode_representer.rb @@ -1,8 +1,15 @@ # encoding: utf-8 class Api::EpisodeRepresenter < Api::BaseRepresen...
Make the guid match what is in the feed, also return episode id and original/override guid as read only
diff --git a/react-native-mapbox-gl.podspec b/react-native-mapbox-gl.podspec index abc1234..def5678 100644 --- a/react-native-mapbox-gl.podspec +++ b/react-native-mapbox-gl.podspec @@ -14,4 +14,5 @@ s.source_files = "ios/RCTMGL/**/*.{h,m}" s.vendored_frameworks = 'ios/Mapbox.framework' + s.dependency 'React' e...
[iOS] Add React dependency to Podspec Support older versions of Swift by allowing `use_frameworks!` in CocoaPods
diff --git a/config/initializers/requires.rb b/config/initializers/requires.rb index abc1234..def5678 100644 --- a/config/initializers/requires.rb +++ b/config/initializers/requires.rb @@ -2,5 +2,5 @@ require 'nokogiri' require 'hdo/storting_importer' -require 'hdo/stats/vote_scorer' -require 'hdo/stats/vote_counts'...
Make sure VoteScorer/VoteCounts are reloaded in dev.
diff --git a/spec/javascripts/support/jasmine_helper.rb b/spec/javascripts/support/jasmine_helper.rb index abc1234..def5678 100644 --- a/spec/javascripts/support/jasmine_helper.rb +++ b/spec/javascripts/support/jasmine_helper.rb @@ -12,4 +12,8 @@ # Jasmine.configure do |config| # config.prevent_phantom_js_auto_insta...
Allow console.log in Jasmine tests, for debugging
diff --git a/ruby/nested_data_structures.rb b/ruby/nested_data_structures.rb index abc1234..def5678 100644 --- a/ruby/nested_data_structures.rb +++ b/ruby/nested_data_structures.rb @@ -42,8 +42,7 @@ puts freeway[:white_honda][:people] freeway[:black_mini][:no_of_cupholders] = 4 -puts freeway[:black_mini][:no_of_cuph...
Add missing bracket to last line of code
diff --git a/cli_tools.gemspec b/cli_tools.gemspec index abc1234..def5678 100644 --- a/cli_tools.gemspec +++ b/cli_tools.gemspec @@ -10,7 +10,7 @@ spec.email = ["alex@kukushk.in"] spec.description = %q{A collection of helper methods for ruby CLI applications} spec.summary = %q{CLI application he...
Set gem homepage to github
diff --git a/config/initializers/barclaycard.rb b/config/initializers/barclaycard.rb index abc1234..def5678 100644 --- a/config/initializers/barclaycard.rb +++ b/config/initializers/barclaycard.rb @@ -6,4 +6,4 @@ EPDQ.config pspid: ENV.fetch('EPDQ_PSPID'), sha_type: :sha256, sha_in: ENV.fetch('EPDQ_SECRET_IN'), sh...
Use BarclayCard test gateway on all hosts except where ENV == 'prod'
diff --git a/spec/unit/plugins/solaris2/memory_spec.rb b/spec/unit/plugins/solaris2/memory_spec.rb index abc1234..def5678 100644 --- a/spec/unit/plugins/solaris2/memory_spec.rb +++ b/spec/unit/plugins/solaris2/memory_spec.rb @@ -20,7 +20,7 @@ before(:each) do @plugin = get_plugin("solaris2/memory") allow(@p...
Update solaris2 memory spec to match memory command
diff --git a/config/metrics.rb b/config/metrics.rb index abc1234..def5678 100644 --- a/config/metrics.rb +++ b/config/metrics.rb @@ -31,7 +31,7 @@ code: code, method: env['REQUEST_METHOD'].downcase, host: env['HTTP_HOST'].to_s, - path: env['PATH_INFO'], + ...
Troubleshoot what's in the environment
diff --git a/config/unicorn.rb b/config/unicorn.rb index abc1234..def5678 100644 --- a/config/unicorn.rb +++ b/config/unicorn.rb @@ -1,6 +1,7 @@ # config/unicorn.rb worker_processes Integer(ENV["WEB_CONCURRENCY"] || 3) -timeout( ENV["WEB_TIMEOUT"] || 15) +timeout Integer(ENV["WEB_TIMEOUT"] || 20) + preload_app true ...
[FIX] Handle conversion of string to integer from env
diff --git a/spec/controllers/sessions_controller_spec.rb b/spec/controllers/sessions_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/sessions_controller_spec.rb +++ b/spec/controllers/sessions_controller_spec.rb @@ -0,0 +1,32 @@+require 'rails_helper' + +describe SessionsController do + let(:e...
Add sessions controller spec file