diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -6,13 +6,14 @@ helper_method :current_user, :logged_in?, :ensure_login! def current_u...
Add restrictions for non-logged in users
diff --git a/lib/awestruct/extensions/pipeline.rb b/lib/awestruct/extensions/pipeline.rb index abc1234..def5678 100644 --- a/lib/awestruct/extensions/pipeline.rb +++ b/lib/awestruct/extensions/pipeline.rb @@ -18,6 +18,7 @@ def extension(ext) @extensions << ext + ext.transform(@transformers) if e...
Add support for Extensions to define Transformers A Extension can register it's own Transformers without involving the user. e.g. The extension need to change the rendered output based on internal state. '''ruby class MyExtension def execute(site) # do.stuff end def transform(transformers) transforme...
diff --git a/app/helpers/simple_form_ransack_helper.rb b/app/helpers/simple_form_ransack_helper.rb index abc1234..def5678 100644 --- a/app/helpers/simple_form_ransack_helper.rb +++ b/app/helpers/simple_form_ransack_helper.rb @@ -6,7 +6,7 @@ opts = {} end - opts[:url] = request.original_url unless op...
Use path instead of URL for the action on form.
diff --git a/lib/lazy/attribute/lazy_attribute.rb b/lib/lazy/attribute/lazy_attribute.rb index abc1234..def5678 100644 --- a/lib/lazy/attribute/lazy_attribute.rb +++ b/lib/lazy/attribute/lazy_attribute.rb @@ -1,6 +1,19 @@ module Lazy module Attribute module ClassMethods + + # Including the lazy_attribute g...
Add docs for better usability
diff --git a/lib/lightchef/resources/directory.rb b/lib/lightchef/resources/directory.rb index abc1234..def5678 100644 --- a/lib/lightchef/resources/directory.rb +++ b/lib/lightchef/resources/directory.rb @@ -13,10 +13,10 @@ escaped_path = shell_escape(path) run_command("test -d #{escaped_path} || mkdi...
Use change_file_mode and change_file_owner instead of calling run_command directly
diff --git a/lib/redis_cacheable/active_record.rb b/lib/redis_cacheable/active_record.rb index abc1234..def5678 100644 --- a/lib/redis_cacheable/active_record.rb +++ b/lib/redis_cacheable/active_record.rb @@ -16,9 +16,10 @@ end # cache all persisted records + # @param [Hash] options pass to find_eac...
Add option parameter to `cache_all`
diff --git a/lib/smartsheet/api/request_client.rb b/lib/smartsheet/api/request_client.rb index abc1234..def5678 100644 --- a/lib/smartsheet/api/request_client.rb +++ b/lib/smartsheet/api/request_client.rb @@ -0,0 +1,19 @@+module Smartsheet + module API + class RequestClient + def initialize(token, client) + ...
Add a client adapter that handles request construction.
diff --git a/lib/spectrum/config/z3988_literal.rb b/lib/spectrum/config/z3988_literal.rb index abc1234..def5678 100644 --- a/lib/spectrum/config/z3988_literal.rb +++ b/lib/spectrum/config/z3988_literal.rb @@ -13,7 +13,7 @@ def value(data) if id && data && data[:value] [data[:value]].flatten.ma...
Fix "no implicit conversion" error I was getting a "no implicit conversion of Integer into String" error on this line; adding this to_s fixed it
diff --git a/lib/spontaneous/model/box/comment.rb b/lib/spontaneous/model/box/comment.rb index abc1234..def5678 100644 --- a/lib/spontaneous/model/box/comment.rb +++ b/lib/spontaneous/model/box/comment.rb @@ -1,4 +1,6 @@ # encoding: UTF-8 + +require 'kramdown' module Spontaneous::Model::Box module Comment @@ -11,...
Fix resolution of Kramdown class
diff --git a/lib/vmdb/settings/database_source.rb b/lib/vmdb/settings/database_source.rb index abc1234..def5678 100644 --- a/lib/vmdb/settings/database_source.rb +++ b/lib/vmdb/settings/database_source.rb @@ -12,7 +12,7 @@ def load return if resource.nil? - resource.settings_changes(true).each_w...
Remove Rails 5 deprecation on reloading the settings_changes.
diff --git a/lib/reconn/analyzer/project_elements/class.rb b/lib/reconn/analyzer/project_elements/class.rb index abc1234..def5678 100644 --- a/lib/reconn/analyzer/project_elements/class.rb +++ b/lib/reconn/analyzer/project_elements/class.rb @@ -30,6 +30,16 @@ methods.size end + def +(other) + other...
Add + method to Class
diff --git a/lib/standalone_validator/validation_result.rb b/lib/standalone_validator/validation_result.rb index abc1234..def5678 100644 --- a/lib/standalone_validator/validation_result.rb +++ b/lib/standalone_validator/validation_result.rb @@ -50,5 +50,11 @@ end alias_method :valid?, :ok? + + def [](attr...
Add introspection method for filtering violations by type
diff --git a/ci_environment/hhvm/attributes/default.rb b/ci_environment/hhvm/attributes/default.rb index abc1234..def5678 100644 --- a/ci_environment/hhvm/attributes/default.rb +++ b/ci_environment/hhvm/attributes/default.rb @@ -1,4 +1,7 @@ default["hhvm"]["package"]["name"] = "hhvm" default["hhvm"]["package"]["versio...
Use precise-specific hhvm package on precise even though .... does this even work??
diff --git a/rb/lib/selenium/webdriver/common/zipper.rb b/rb/lib/selenium/webdriver/common/zipper.rb index abc1234..def5678 100644 --- a/rb/lib/selenium/webdriver/common/zipper.rb +++ b/rb/lib/selenium/webdriver/common/zipper.rb @@ -36,7 +36,7 @@ entry = file.sub("#{path}/", '') zos.put_next_...
JariBakken: Make sure we properly zip binary files on Windows. r11358
diff --git a/ruby/command-t/finder/mru_buffer_finder.rb b/ruby/command-t/finder/mru_buffer_finder.rb index abc1234..def5678 100644 --- a/ruby/command-t/finder/mru_buffer_finder.rb +++ b/ruby/command-t/finder/mru_buffer_finder.rb @@ -7,6 +7,11 @@ module CommandT class MRUBufferFinder < BufferFinder + def initial...
Put initialize method at top of class By convention, this is where people expect to see this.
diff --git a/db/migrate/20131002192016_create_users.rb b/db/migrate/20131002192016_create_users.rb index abc1234..def5678 100644 --- a/db/migrate/20131002192016_create_users.rb +++ b/db/migrate/20131002192016_create_users.rb @@ -2,7 +2,7 @@ def change create_table :users do |t| t.string :provider - t...
Fix DB issue for postgres
diff --git a/regexp_parser.gemspec b/regexp_parser.gemspec index abc1234..def5678 100644 --- a/regexp_parser.gemspec +++ b/regexp_parser.gemspec @@ -26,8 +26,6 @@ Dir.glob('lib/**/*.yml') + %w(Gemfile Rakefile LICENSE README.md CHANGELOG.md regexp_parser.gemspec) - gem.te...
Remove deprecated `test_files` from gemspec
diff --git a/db/migrate/20150916144535_create_users.rb b/db/migrate/20150916144535_create_users.rb index abc1234..def5678 100644 --- a/db/migrate/20150916144535_create_users.rb +++ b/db/migrate/20150916144535_create_users.rb @@ -6,5 +6,6 @@ t.string :hashed_password, null: false t.timestamps null: false ...
Add uniqueness index to Users table
diff --git a/spec/acceptance/class_disabled_spec.rb b/spec/acceptance/class_disabled_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/class_disabled_spec.rb +++ b/spec/acceptance/class_disabled_spec.rb @@ -1,26 +1,45 @@ require 'spec_helper_acceptance' -describe 'selinux class disabled' do +describe 'selin...
Extend acceptance tests for enforcing to disabled mode Unfortunatly some people really disable selinux.
diff --git a/db/migrate/20121003020810_create_features.rb b/db/migrate/20121003020810_create_features.rb index abc1234..def5678 100644 --- a/db/migrate/20121003020810_create_features.rb +++ b/db/migrate/20121003020810_create_features.rb @@ -7,7 +7,7 @@ t.integer :position, :null => false, :limit => 3, :...
Allow feature descriptions to be blank
diff --git a/deploy/development.rb b/deploy/development.rb index abc1234..def5678 100644 --- a/deploy/development.rb +++ b/deploy/development.rb @@ -1,6 +1,6 @@ # The hosts where are are deploying -role :app, "flood.amee.com" -role :db, "flood.amee.com", :primary => true +role :app, "monsoon.amee.com" +role :db, "mo...
Update dev server name to monsoon. OPS-1250.
diff --git a/pusher-client.gemspec b/pusher-client.gemspec index abc1234..def5678 100644 --- a/pusher-client.gemspec +++ b/pusher-client.gemspec @@ -21,7 +21,7 @@ s.require_paths = ['lib'] s.licenses = ['MIT'] - s.add_runtime_dependency 'websocket', '~> 1.0.0' + s.add_runtime_dependency 'websocket',...
Update the websocket dependency to 1.1.2
diff --git a/spec/requests/authentication_pages_spec.rb b/spec/requests/authentication_pages_spec.rb index abc1234..def5678 100644 --- a/spec/requests/authentication_pages_spec.rb +++ b/spec/requests/authentication_pages_spec.rb @@ -4,11 +4,13 @@ subject { page } - describe "signin page" do + describe "signin" ...
Reorganize sign in page test
diff --git a/spec/workers/inactive_draft_worker_spec.rb b/spec/workers/inactive_draft_worker_spec.rb index abc1234..def5678 100644 --- a/spec/workers/inactive_draft_worker_spec.rb +++ b/spec/workers/inactive_draft_worker_spec.rb @@ -1,6 +1,6 @@-require 'spec_helper' +require 'rails_helper' -describe InactiveDraftWork...
Fix InactiveDraftWorker to RSpec 3
diff --git a/regexp_parser.gemspec b/regexp_parser.gemspec index abc1234..def5678 100644 --- a/regexp_parser.gemspec +++ b/regexp_parser.gemspec @@ -31,5 +31,5 @@ gem.platform = Gem::Platform::RUBY - gem.required_ruby_version = '>= 1.8.7' + gem.required_ruby_version = '>= 1.9.1' end
Update minimum ruby version in gemspec to 1.9.1
diff --git a/spec/acceptance/install_spec.rb b/spec/acceptance/install_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/install_spec.rb +++ b/spec/acceptance/install_spec.rb @@ -0,0 +1,24 @@+require "spec_helper" +require "tmpdir" + +RSpec.describe "Installing the Gem" do + describe "Using generator" do + ...
Add test for installing Gem
diff --git a/spec/models/cell_volume_spec.rb b/spec/models/cell_volume_spec.rb index abc1234..def5678 100644 --- a/spec/models/cell_volume_spec.rb +++ b/spec/models/cell_volume_spec.rb @@ -1,6 +1,8 @@ require "spec_helper" RSpec.describe CellVolume do + it { is_expected.to belong_to :cell_block_device } + it { is_...
Add a couple of missing association expectations
diff --git a/files/gitlab-cookbooks/gitlab/metadata.rb b/files/gitlab-cookbooks/gitlab/metadata.rb index abc1234..def5678 100644 --- a/files/gitlab-cookbooks/gitlab/metadata.rb +++ b/files/gitlab-cookbooks/gitlab/metadata.rb @@ -1,6 +1,6 @@ maintainer "GitLab.com" maintainer_email "support@gitlab.com" -license "MIT" +...
Change gitlab cookbook license to Apache 2.0
diff --git a/spec/features/fall2017_cmu_experiment_spec.rb b/spec/features/fall2017_cmu_experiment_spec.rb index abc1234..def5678 100644 --- a/spec/features/fall2017_cmu_experiment_spec.rb +++ b/spec/features/fall2017_cmu_experiment_spec.rb @@ -0,0 +1,37 @@+# frozen_string_literal: true + +require 'rails_helper' + +des...
Add feature spec for opt-in/opt-out
diff --git a/lib/docs/scrapers/redis.rb b/lib/docs/scrapers/redis.rb index abc1234..def5678 100644 --- a/lib/docs/scrapers/redis.rb +++ b/lib/docs/scrapers/redis.rb @@ -1,7 +1,7 @@ module Docs class Redis < UrlScraper self.type = 'redis' - self.release = 'up to 3.2.1' + self.release = 'up to 3.2.2' s...
Update Redis documentation (up to 3.2.2)
diff --git a/lib/flowdock_connection.rb b/lib/flowdock_connection.rb index abc1234..def5678 100644 --- a/lib/flowdock_connection.rb +++ b/lib/flowdock_connection.rb @@ -32,7 +32,7 @@ 'authorization' => [username, password] }) @source.message(&@on_message_block) - @source.inactivity_timeout = 0 + @s...
Enable timeout, streaming api sends keepalives
diff --git a/app/controllers/usermovements_controller.rb b/app/controllers/usermovements_controller.rb index abc1234..def5678 100644 --- a/app/controllers/usermovements_controller.rb +++ b/app/controllers/usermovements_controller.rb @@ -46,6 +46,6 @@ end def movement_params - params.require(:movement).permit(:nam...
Remove movement_type from usermovement controller
diff --git a/lib/appsignal/integrations/delayed_job.rb b/lib/appsignal/integrations/delayed_job.rb index abc1234..def5678 100644 --- a/lib/appsignal/integrations/delayed_job.rb +++ b/lib/appsignal/integrations/delayed_job.rb @@ -7,6 +7,10 @@ callbacks do |lifecycle| lifecycle.around(:invoke_job) do |...
Call Appsignal.stop after DJ loop stops
diff --git a/lib/phoneword/converter.rb b/lib/phoneword/converter.rb index abc1234..def5678 100644 --- a/lib/phoneword/converter.rb +++ b/lib/phoneword/converter.rb @@ -17,10 +17,15 @@ match_head = dictionary.search(variations(head_digits)) match_tail = dictionary.search(variations(tail_digits)) - ...
Drop results if empty head or tail, use head and tail product in the result
diff --git a/lib/ravelin/transaction.rb b/lib/ravelin/transaction.rb index abc1234..def5678 100644 --- a/lib/ravelin/transaction.rb +++ b/lib/ravelin/transaction.rb @@ -12,7 +12,9 @@ :decline_code, :gateway_reference, :avs_result_code, - :cvv_result_code + :cvv_result_code, + :type, +...
Add type and time to Transaction As can be seen on Raveline API here https://developer.ravelin.com/\#post-/v2/transaction
diff --git a/lib/ultima/core/limiter.rb b/lib/ultima/core/limiter.rb index abc1234..def5678 100644 --- a/lib/ultima/core/limiter.rb +++ b/lib/ultima/core/limiter.rb @@ -8,10 +8,12 @@ def reset! @acted_at = nil + true end def act! @acted_at = Gosu::milliseconds + t...
Return true in Limiter shebang methods
diff --git a/lib/vcr/middleware/rack.rb b/lib/vcr/middleware/rack.rb index abc1234..def5678 100644 --- a/lib/vcr/middleware/rack.rb +++ b/lib/vcr/middleware/rack.rb @@ -3,8 +3,13 @@ class Rack include Common + def initialize(*args) + @mutex = Mutex.new + super + end + def cal...
Use a mutex rather than Thread.exclusive. I'm getting errors from the rack middleware cuke on 1.8 w/ the Thread.exclusive.
diff --git a/lib/kochiku/jobs/shutdown_instance_job.rb b/lib/kochiku/jobs/shutdown_instance_job.rb index abc1234..def5678 100644 --- a/lib/kochiku/jobs/shutdown_instance_job.rb +++ b/lib/kochiku/jobs/shutdown_instance_job.rb @@ -9,7 +9,7 @@ Process.kill("QUIT", Process.ppid) # Shutdown the instance 1 minute ...
Remove minute designation from shutdown Without the minute unit it works on both osx and linux. OSX only with it.
diff --git a/Casks/kensington-trackball-works.rb b/Casks/kensington-trackball-works.rb index abc1234..def5678 100644 --- a/Casks/kensington-trackball-works.rb +++ b/Casks/kensington-trackball-works.rb @@ -3,7 +3,7 @@ sha256 '285511269aea2e0517198b354923676655c72142062dcba7bdc41bc29d1f08d1' # windows.net is the o...
Update download url, but did not change shasum Signed-off-by: Koichi Shiraishi <41a18128582fec5418c0a92661f7d4b13d21d912@gmail.com>
diff --git a/spec/ruby/core/array/shared/index.rb b/spec/ruby/core/array/shared/index.rb index abc1234..def5678 100644 --- a/spec/ruby/core/array/shared/index.rb +++ b/spec/ruby/core/array/shared/index.rb @@ -18,6 +18,7 @@ it "returns nil if no element == to object" do [2, 1, 1, 1, 1].send(@method, 3).should == ...
Adjust blank line to improve coding style in a spec file
diff --git a/spec/lib/everything/add_pathname_to_everything_refinement_spec.rb b/spec/lib/everything/add_pathname_to_everything_refinement_spec.rb index abc1234..def5678 100644 --- a/spec/lib/everything/add_pathname_to_everything_refinement_spec.rb +++ b/spec/lib/everything/add_pathname_to_everything_refinement_spec.rb...
Add parens around eq argument
diff --git a/test/lib/shopify_app/login_protection_test.rb b/test/lib/shopify_app/login_protection_test.rb index abc1234..def5678 100644 --- a/test/lib/shopify_app/login_protection_test.rb +++ b/test/lib/shopify_app/login_protection_test.rb @@ -1,7 +1,7 @@ require 'test_helper' require 'action_controller' -class Hel...
Replace Helper name with LoginProtection
diff --git a/test/frameworks/apps/padrino_simple.rb b/test/frameworks/apps/padrino_simple.rb index abc1234..def5678 100644 --- a/test/frameworks/apps/padrino_simple.rb +++ b/test/frameworks/apps/padrino_simple.rb @@ -8,6 +8,7 @@ # class SimpleDemo < Padrino::Application + register Padrino::Helpers set :reload, t...
Fix for broken Padrino helpers in tests
diff --git a/caruby-tissue.gemspec b/caruby-tissue.gemspec index abc1234..def5678 100644 --- a/caruby-tissue.gemspec +++ b/caruby-tissue.gemspec @@ -1,7 +1,7 @@ require 'date' -require 'catissue/version' +require File.expand_path('version', File.dirname(__FILE__) + '/lib/catissue') -CaTissue::SPEC = Gem::Specificatio...
Remove SPEC constant. Add dev dependencies. Add test files.
diff --git a/config/initializers/heliotrope_authority.rb b/config/initializers/heliotrope_authority.rb index abc1234..def5678 100644 --- a/config/initializers/heliotrope_authority.rb +++ b/config/initializers/heliotrope_authority.rb @@ -11,8 +11,7 @@ def licenses_for(actor, target) Greensub::License.where( ...
Performance/SelectMap: Use filter_map instead of select.map.
diff --git a/clone_github_repos.rb b/clone_github_repos.rb index abc1234..def5678 100644 --- a/clone_github_repos.rb +++ b/clone_github_repos.rb @@ -0,0 +1,55 @@+#!/usr/bin/env ruby +require 'net/http' +require 'json' + +include Process + +def get_all_repos_from_user(username, protocol = 'ssh') + repos = get_response(...
Add script for cloning all of my repos
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -17,10 +17,10 @@ class Application < Rails::Application config.assets.precompile += %w( - application.scss - application-ie6.scss - application-...
Fix config for css in asset pipeline
diff --git a/test/cluster_client_replicas_test.rb b/test/cluster_client_replicas_test.rb index abc1234..def5678 100644 --- a/test/cluster_client_replicas_test.rb +++ b/test/cluster_client_replicas_test.rb @@ -11,6 +11,11 @@ 100.times do |i| assert_equal 'OK', r.set("key#{i}", i) + end + + begin + ...
Add some WAIT for tests using replication
diff --git a/config/environment.rb b/config/environment.rb index abc1234..def5678 100644 --- a/config/environment.rb +++ b/config/environment.rb @@ -2,8 +2,6 @@ # See: http://gembundler.com/bundler_setup.html # http://stackoverflow.com/questions/7243486/why-do-you-need-require-bundler-setup ENV['BUNDLE_GEMFILE']...
Move API key out of accessible files
diff --git a/test/integration/legislators_test.rb b/test/integration/legislators_test.rb index abc1234..def5678 100644 --- a/test/integration/legislators_test.rb +++ b/test/integration/legislators_test.rb @@ -14,4 +14,13 @@ assert_equal "Joe", legislators.first.first_name end + + def test_districts_by_latlong...
Test for legislator search by lat / long
diff --git a/db/migrate/20150827194533_collapse_repo_upstream_user_into_name.rb b/db/migrate/20150827194533_collapse_repo_upstream_user_into_name.rb index abc1234..def5678 100644 --- a/db/migrate/20150827194533_collapse_repo_upstream_user_into_name.rb +++ b/db/migrate/20150827194533_collapse_repo_upstream_user_into_nam...
Fix migration for upstream_user collapse
diff --git a/db/migrate/20180320182229_add_indexes_for_user_activity_queries.rb b/db/migrate/20180320182229_add_indexes_for_user_activity_queries.rb index abc1234..def5678 100644 --- a/db/migrate/20180320182229_add_indexes_for_user_activity_queries.rb +++ b/db/migrate/20180320182229_add_indexes_for_user_activity_querie...
Patch MySQL's odd foreign key behavior.
diff --git a/db/migrate/20190221195025_change_admin_team_member_id_to_bigint.rb b/db/migrate/20190221195025_change_admin_team_member_id_to_bigint.rb index abc1234..def5678 100644 --- a/db/migrate/20190221195025_change_admin_team_member_id_to_bigint.rb +++ b/db/migrate/20190221195025_change_admin_team_member_id_to_bigin...
Update admin_team_member_id primary key to bigint
diff --git a/app/controllers/error_controller.rb b/app/controllers/error_controller.rb index abc1234..def5678 100644 --- a/app/controllers/error_controller.rb +++ b/app/controllers/error_controller.rb @@ -1,6 +1,6 @@-class ErrorController < ApplicationController +class ErrorsController < ApplicationController skip_b...
Add an s to fix things
diff --git a/app/controllers/items_controller.rb b/app/controllers/items_controller.rb index abc1234..def5678 100644 --- a/app/controllers/items_controller.rb +++ b/app/controllers/items_controller.rb @@ -14,6 +14,7 @@ def edit @list = List.find_by(id: params[:list_id]) @item = Item.find_by(id: params[:id])...
Include Store when editing Item
diff --git a/app/controllers/races_controller.rb b/app/controllers/races_controller.rb index abc1234..def5678 100644 --- a/app/controllers/races_controller.rb +++ b/app/controllers/races_controller.rb @@ -21,7 +21,7 @@ rescue RuntimeError => e respond_to do |format| format.html { redirect_to races_path, a...
Print errors to the console log rather than using an alert They're only useful for a developer debugging, who will know to look there. They don't need to be shown to the end user.
diff --git a/app/controllers/tasks_controller.rb b/app/controllers/tasks_controller.rb index abc1234..def5678 100644 --- a/app/controllers/tasks_controller.rb +++ b/app/controllers/tasks_controller.rb @@ -10,8 +10,7 @@ # also responds to PUT /builds/:id legacy route def update - @task = Task.find(params[:id],...
Revert "Do not load full build log when we builds are finalized" This reverts commit 6f8d5260a91a8bbc3e9c148b00ae65c65c0ba8aa. It breaks some specs. I will wait for Sven to tell me what I may be missing.
diff --git a/app/controllers/tours_controller.rb b/app/controllers/tours_controller.rb index abc1234..def5678 100644 --- a/app/controllers/tours_controller.rb +++ b/app/controllers/tours_controller.rb @@ -13,11 +13,13 @@ def create session[:touring] = true + expire_fragment(%r{views/people/#{@logged_in.id}_...
Expire cache when tour starts or stops.
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -4,8 +4,7 @@ def show @emails = Email.where(account_id: @current_user.current_account_id).reverse - @acc...
Save the changes on account
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -18,7 +18,7 @@ flash[:info] = 'Successfully signed you up!' redirect_to @user else - flash[:e...
Fix error message on signup
diff --git a/app/models/metrics/accessibility.rb b/app/models/metrics/accessibility.rb index abc1234..def5678 100644 --- a/app/models/metrics/accessibility.rb +++ b/app/models/metrics/accessibility.rb @@ -9,7 +9,7 @@ end def self.split_to_words(text) - [] + text.split /\W+/ end end
Implement split text into words method I just implemented the split text into words method of the accessibility metric and it seems to work as expected. Signed-off-by: Konrad Reiche <4ff0213f56e2082fcd8c882d04c546881c579ce4@gmail.com>
diff --git a/templates/config/environment.rb b/templates/config/environment.rb index abc1234..def5678 100644 --- a/templates/config/environment.rb +++ b/templates/config/environment.rb @@ -7,9 +7,7 @@ config.version = "0.0.1" config.publisher = "Example" config.url = "http://example.com" - - # con...
Remove titanium reference from env template
diff --git a/spec/features/benchmark_schedules_spec.rb b/spec/features/benchmark_schedules_spec.rb index abc1234..def5678 100644 --- a/spec/features/benchmark_schedules_spec.rb +++ b/spec/features/benchmark_schedules_spec.rb @@ -0,0 +1,86 @@+# frozen_string_literal: true + +require 'rails_helper' + +feature 'Benchmark ...
Add benchmark schedule feature specs
diff --git a/spec/github_cli/commands/contents_spec.rb b/spec/github_cli/commands/contents_spec.rb index abc1234..def5678 100644 --- a/spec/github_cli/commands/contents_spec.rb +++ b/spec/github_cli/commands/contents_spec.rb @@ -0,0 +1,41 @@+# encoding: utf-8 + +require 'spec_helper' + +describe GithubCLI::Commands::Co...
Add specs for content commands.
diff --git a/spec/lib/nerve/reporter_zookeeper_spec.rb b/spec/lib/nerve/reporter_zookeeper_spec.rb index abc1234..def5678 100644 --- a/spec/lib/nerve/reporter_zookeeper_spec.rb +++ b/spec/lib/nerve/reporter_zookeeper_spec.rb @@ -16,7 +16,7 @@ it 'deregisters service on exit' do zk = double("zk") - allow(zk)...
Update the tests to check for close! call.
diff --git a/test/service/s3_service_test.rb b/test/service/s3_service_test.rb index abc1234..def5678 100644 --- a/test/service/s3_service_test.rb +++ b/test/service/s3_service_test.rb @@ -9,25 +9,15 @@ include ActiveStorage::Service::SharedServiceTests test "direct upload" do - # FIXME: This test is fa...
Fix S3 direct upload test
diff --git a/lib/generators/nested_scaffold_generator.rb b/lib/generators/nested_scaffold_generator.rb index abc1234..def5678 100644 --- a/lib/generators/nested_scaffold_generator.rb +++ b/lib/generators/nested_scaffold_generator.rb @@ -26,7 +26,7 @@ return if options[:actions].present? route_config = ...
Fix line breaks in generated routes.rb
diff --git a/config/initializers/secret_token.rb b/config/initializers/secret_token.rb index abc1234..def5678 100644 --- a/config/initializers/secret_token.rb +++ b/config/initializers/secret_token.rb @@ -4,4 +4,4 @@ # If you change this key, all old signed cookies will become invalid! # Make sure the secret is at lea...
Read session token from the environment if set.
diff --git a/lib/beans/registry.rb b/lib/beans/registry.rb index abc1234..def5678 100644 --- a/lib/beans/registry.rb +++ b/lib/beans/registry.rb @@ -13,6 +13,7 @@ end def reset + @default = in_memory_repository repositories.each { |_, r| r.delete_all } end @@ -23,7 +24,11 @@ private ...
Fix default repository not resetting
diff --git a/cookbooks/bcpc/recipes/bootstrap.rb b/cookbooks/bcpc/recipes/bootstrap.rb index abc1234..def5678 100644 --- a/cookbooks/bcpc/recipes/bootstrap.rb +++ b/cookbooks/bcpc/recipes/bootstrap.rb @@ -32,3 +32,14 @@ group "root" mode 00755 end + +# Install some useful packages +include_recipe "bcpc::packa...
Add python-{openstack,keystoneclient} packages to boostrap node Fixes #793
diff --git a/lib/referehencible.rb b/lib/referehencible.rb index abc1234..def5678 100644 --- a/lib/referehencible.rb +++ b/lib/referehencible.rb @@ -2,19 +2,35 @@ require 'securerandom' module Referehencible + DEFAULT_LENGTH = 32 + module ClassMethods def referenced_by(*referenced_attributes) - referen...
Feature: Allow reference number length to be customizable Previously all reference numbers were forced to be 32 hex characters. We had a need for the exact functionality that referehencible provides, but for an attribute where we only wanted 8 characters. Now we can do that by passing a `length` option to `reference...
diff --git a/lib/rohbau/runtime.rb b/lib/rohbau/runtime.rb index abc1234..def5678 100644 --- a/lib/rohbau/runtime.rb +++ b/lib/rohbau/runtime.rb @@ -62,5 +62,26 @@ end end + def handle_transaction(&block) + if transaction_handling_plugin + transaction_handling_plugin.transaction_handler(&blo...
Enable Transaction handling for plugins
diff --git a/lib/scrobbler/rest.rb b/lib/scrobbler/rest.rb index abc1234..def5678 100644 --- a/lib/scrobbler/rest.rb +++ b/lib/scrobbler/rest.rb @@ -22,7 +22,7 @@ if args # TODO: What about keys without value? - url.query = args.map { |k,v| "%s=%s" % [URI.encode(k), URI.encode(v)] }.join("&") + ...
Allow symbols in request query
diff --git a/lib/tasks/router.rake b/lib/tasks/router.rake index abc1234..def5678 100644 --- a/lib/tasks/router.rake +++ b/lib/tasks/router.rake @@ -7,11 +7,11 @@ end task :register_backend => :router_environment do - @router_api.add_backend('contacts-frontend', Plek.current.find('contacts-frontend', :force_h...
Update route registration to reflect new vhost The frontend part of the app is currently listening on 2 vhosts - contacts-frontend and contacts-frontend-old. Before long the former will be reclaimed for the new frontend app, so the routes need to be pointed at the latter.
diff --git a/test/examples_test.rb b/test/examples_test.rb index abc1234..def5678 100644 --- a/test/examples_test.rb +++ b/test/examples_test.rb @@ -6,6 +6,7 @@ examples_directory = File.expand_path('../../examples', __FILE__) @examples = Dir.glob("#{examples_directory}/*.rb") @test_dir = File.absolute_pa...
Create test tmp dir if not exist
diff --git a/spec/models/player_spec.rb b/spec/models/player_spec.rb index abc1234..def5678 100644 --- a/spec/models/player_spec.rb +++ b/spec/models/player_spec.rb @@ -1,4 +1,24 @@ require 'spec_helper' describe Player do + describe 'create' do + before do + Player.create( + name: 'maytheplic', + ...
Add specs for Player model.
diff --git a/app/controllers/audiences_controller.rb b/app/controllers/audiences_controller.rb index abc1234..def5678 100644 --- a/app/controllers/audiences_controller.rb +++ b/app/controllers/audiences_controller.rb @@ -12,26 +12,35 @@ .select("date, SUM(count) AS count") .grou...
Return all metrics as graph data.
diff --git a/app/controllers/questions_controller.rb b/app/controllers/questions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/questions_controller.rb +++ b/app/controllers/questions_controller.rb @@ -3,16 +3,25 @@ end def new - @question = Question.new + if logged_in? + @question ...
Add user validation for question creation
diff --git a/app/controllers/questions_controller.rb b/app/controllers/questions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/questions_controller.rb +++ b/app/controllers/questions_controller.rb @@ -8,6 +8,8 @@ def show @question = Question.find(params[:id]) + @question.update_attribut...
Increment times_viewed attribute when question is viewed
diff --git a/Formula/android-sdk.rb b/Formula/android-sdk.rb index abc1234..def5678 100644 --- a/Formula/android-sdk.rb +++ b/Formula/android-sdk.rb @@ -25,9 +25,13 @@ end end - def caveats; "\ + def caveats; <<-EOS We agreed to the Android SDK License Agreement for you by downloading the SDK. If this is u...
Add ANDROID_SDK_ROOT to Android's caveats.
diff --git a/app/presenters/transaction_presenter.rb b/app/presenters/transaction_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/transaction_presenter.rb +++ b/app/presenters/transaction_presenter.rb @@ -1,4 +1,6 @@ class TransactionPresenter + + cattr_accessor :new_window_transactions def initia...
Use class attribute to store list of transactions in memory
diff --git a/app/controllers/article_controller.rb b/app/controllers/article_controller.rb index abc1234..def5678 100644 --- a/app/controllers/article_controller.rb +++ b/app/controllers/article_controller.rb @@ -6,11 +6,11 @@ redirect_to root_path, alert: "You have to be signed in to use this feature!" return ...
Make the copy from params to object dynamic - using a Ruby oneliner with `each` Signed-off-by: Siddharth Kannan <7a804f1d08bac02a84ba1822c22c8bf38be68ecc@tutanota.com>
diff --git a/app/decorators/ubicacion_decorator.rb b/app/decorators/ubicacion_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/ubicacion_decorator.rb +++ b/app/decorators/ubicacion_decorator.rb @@ -16,11 +16,7 @@ end def srid - begin - h.current_usuario.srid.to_i - rescue NoMethodError ...
Fix bug al preguntar srid en el decorador
diff --git a/app/models/spree_product_decorator.rb b/app/models/spree_product_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree_product_decorator.rb +++ b/app/models/spree_product_decorator.rb @@ -7,7 +7,8 @@ LEFT JOIN spree_option_values_variants AS ovv ON (ovv.option_value_id = ov.id) LEF...
Use both name and presentation fields to locate option values
diff --git a/app/serializers/comment_serializer.rb b/app/serializers/comment_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/comment_serializer.rb +++ b/app/serializers/comment_serializer.rb @@ -1,3 +1,4 @@ class CommentSerializer < ActiveModel::Serializer - attributes :id, :content + attributes :id...
Add resource_id and user to Comments Serializer.:
diff --git a/app/serializers/holiday_serializer.rb b/app/serializers/holiday_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/holiday_serializer.rb +++ b/app/serializers/holiday_serializer.rb @@ -1,9 +1,5 @@ class HolidaySerializer < ActiveModel::Serializer attribute :title - attribute :start do - ...
Refactor holiday serializer to use built in aliasing
diff --git a/spec/features/parse_pidgin_log_file_spec.rb b/spec/features/parse_pidgin_log_file_spec.rb index abc1234..def5678 100644 --- a/spec/features/parse_pidgin_log_file_spec.rb +++ b/spec/features/parse_pidgin_log_file_spec.rb @@ -0,0 +1,13 @@+require "spec_helper" + +describe "Parse a pidgin log file" do + incl...
Add a failing feature spec
diff --git a/lib/legacy_courses/legacy_course_updater.rb b/lib/legacy_courses/legacy_course_updater.rb index abc1234..def5678 100644 --- a/lib/legacy_courses/legacy_course_updater.rb +++ b/lib/legacy_courses/legacy_course_updater.rb @@ -12,6 +12,7 @@ data['course']&.delete('listed') # Symbol if coming from con...
Fix changed behavior of legacy course end dates
diff --git a/lib/octicons_helper/octicons_helper.gemspec b/lib/octicons_helper/octicons_helper.gemspec index abc1234..def5678 100644 --- a/lib/octicons_helper/octicons_helper.gemspec +++ b/lib/octicons_helper/octicons_helper.gemspec @@ -14,5 +14,6 @@ s.require_paths = ["lib"] s.add_dependency "octicons", "12.1.0...
Use more explicit dependencies for Rails helper This doesn't require all of Rails, only ActionView & Railties. Reduce the dependencies here means that it enables folks to use only parts of Rails and to slim down their applications by removing unused components of Rails.
diff --git a/lib/toy_robot_simulator/robot_controller.rb b/lib/toy_robot_simulator/robot_controller.rb index abc1234..def5678 100644 --- a/lib/toy_robot_simulator/robot_controller.rb +++ b/lib/toy_robot_simulator/robot_controller.rb @@ -1,7 +1,33 @@+require './lib/toy_robot_simulator/command/command' +require 'forwarda...
Implement RobotController complaint with RobotControllerTest
diff --git a/app/controllers/api/v1/plays_controller.rb b/app/controllers/api/v1/plays_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/plays_controller.rb +++ b/app/controllers/api/v1/plays_controller.rb @@ -1,4 +1,6 @@ class Api::V1::PlaysController < ApplicationController + before_action :au...
Add create action to plays controller
diff --git a/db/migrate/20151109143515_add_full_text_search_index_to_documents.rb b/db/migrate/20151109143515_add_full_text_search_index_to_documents.rb index abc1234..def5678 100644 --- a/db/migrate/20151109143515_add_full_text_search_index_to_documents.rb +++ b/db/migrate/20151109143515_add_full_text_search_index_to_...
Add an index for full text search
diff --git a/Library/Formula/dwm.rb b/Library/Formula/dwm.rb index abc1234..def5678 100644 --- a/Library/Formula/dwm.rb +++ b/Library/Formula/dwm.rb @@ -17,12 +17,12 @@ end def caveats - <<EOF - In order to use the Mac OS X command key '⌘' for dwm commands + <<-EOS + In order to use the Mac OS X comm...
Remove command-key character for compatibility.
diff --git a/spec/views/curation_concerns/base/_find_work_widget.html.erb_spec.rb b/spec/views/curation_concerns/base/_find_work_widget.html.erb_spec.rb index abc1234..def5678 100644 --- a/spec/views/curation_concerns/base/_find_work_widget.html.erb_spec.rb +++ b/spec/views/curation_concerns/base/_find_work_widget.html...
Add a test for the find_work_widget partial
diff --git a/app/controllers/loads_session.rb b/app/controllers/loads_session.rb index abc1234..def5678 100644 --- a/app/controllers/loads_session.rb +++ b/app/controllers/loads_session.rb @@ -1,7 +1,7 @@ module LoadsSession def logged_in? - !get_session.nil? + !get_session.nil? unless request.nil? end ...
Fix - Ashok - Fixed the specs
diff --git a/app/models/standard_interview.rb b/app/models/standard_interview.rb index abc1234..def5678 100644 --- a/app/models/standard_interview.rb +++ b/app/models/standard_interview.rb @@ -43,5 +43,7 @@ attribute :explanations, String attribute :mitigations, String attribute :aggravating_features, String + ...
Add TODO for validating appropriate_adults
diff --git a/app/views/api/v1/items/show.rabl b/app/views/api/v1/items/show.rabl index abc1234..def5678 100644 --- a/app/views/api/v1/items/show.rabl +++ b/app/views/api/v1/items/show.rabl @@ -1,9 +1,10 @@ cache @item object @item => :items -attributes :id, :guid, :title, :channel_type, :tags, :description, :content...
Use view helpers for content and excerpt
diff --git a/features/step_definitions/adding_events.rb b/features/step_definitions/adding_events.rb index abc1234..def5678 100644 --- a/features/step_definitions/adding_events.rb +++ b/features/step_definitions/adding_events.rb @@ -0,0 +1,17 @@+Given(/^I am on the 'Add an Event' page$/) do + visit new_event_path +end...
Write step definitions to support “add an event” scenario I’m conscious that these are duplicating work from other step definitions, and that more generally we’re already suffering from the “feature-coupled step definitions” antipattern [1], but for now I’m concentrating on getting the new feature working. I’ll come b...
diff --git a/config/initializers/exlibris_aleph.rb b/config/initializers/exlibris_aleph.rb index abc1234..def5678 100644 --- a/config/initializers/exlibris_aleph.rb +++ b/config/initializers/exlibris_aleph.rb @@ -3,9 +3,7 @@ Exlibris::Aleph::TablesManager.instance.sub_libraries.all # Load all the item circulation ...
Remove debug messages from the Exlibris::Aleph initializer
diff --git a/app/controllers/api/v1/staging_controller.rb b/app/controllers/api/v1/staging_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/staging_controller.rb +++ b/app/controllers/api/v1/staging_controller.rb @@ -12,7 +12,7 @@ def get_event if @event authorize @event - ren...
Add SplitTimesController with related serializers, policy, and routes; remove unused parameter from StagingController.