diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -25,8 +25,12 @@ try: except (IOError, ImportError): description = '' -with open('requirements.txt') as fhandle: - requirements = [line.strip() for line in fhandle] +on_rtd = os.environ.get('READTHEDOCS', None) == 'T...
Harden setup.py against RTD
diff --git a/pycbc/inject/injfilterrejector.py b/pycbc/inject/injfilterrejector.py index <HASH>..<HASH> 100644 --- a/pycbc/inject/injfilterrejector.py +++ b/pycbc/inject/injfilterrejector.py @@ -233,7 +233,7 @@ class InjFilterRejector(object): def generate_short_inj_from_inj(self, inj_waveform, simulation_id): ...
Don't gen short injections when not needed (#<I>)
diff --git a/src/Excel.php b/src/Excel.php index <HASH>..<HASH> 100644 --- a/src/Excel.php +++ b/src/Excel.php @@ -87,7 +87,18 @@ class Excel { * @throws \PhpOffice\PhpSpreadsheet\Reader\Exception */ public static function sheetToArray( $path, $sheetIndex = 0 ) { - $reader = new \PhpOffice\PhpSp...
Creating the reader specific to the xls version now.
diff --git a/app/validators/safe_html.rb b/app/validators/safe_html.rb index <HASH>..<HASH> 100644 --- a/app/validators/safe_html.rb +++ b/app/validators/safe_html.rb @@ -19,14 +19,26 @@ class SafeHtml < ActiveModel::Validator end def check_string(record, field_name, string) - dirty_html = Govspeak::Document...
Break out html conversion into separate methods to clarify the intent
diff --git a/test/testsuite/generator/behavior/AlternativeCodingStandardsBehaviorTest.php b/test/testsuite/generator/behavior/AlternativeCodingStandardsBehaviorTest.php index <HASH>..<HASH> 100644 --- a/test/testsuite/generator/behavior/AlternativeCodingStandardsBehaviorTest.php +++ b/test/testsuite/generator/behavior/...
Revert bad CS fix (alternative CS behavior)
diff --git a/firebirdsql/wireprotocol.py b/firebirdsql/wireprotocol.py index <HASH>..<HASH> 100644 --- a/firebirdsql/wireprotocol.py +++ b/firebirdsql/wireprotocol.py @@ -972,6 +972,7 @@ class WireProtocol(object): while bytes_to_bint(b) == self.op_dummy: b = self.recv_channel(4) if bytes...
one more lazy response counter decrement.
diff --git a/src/RobotsTxt.php b/src/RobotsTxt.php index <HASH>..<HASH> 100644 --- a/src/RobotsTxt.php +++ b/src/RobotsTxt.php @@ -197,7 +197,7 @@ class RobotsTxt protected function isDisallowLine(string $line): string { - return trim(substr(str_replace(' ', '', strtolower(trim($line))), 0, 6), ': ')...
- use full word for disallow
diff --git a/code/MultiFormStep.php b/code/MultiFormStep.php index <HASH>..<HASH> 100644 --- a/code/MultiFormStep.php +++ b/code/MultiFormStep.php @@ -162,12 +162,11 @@ class MultiFormStep extends DataObject { * Custom validation for a step. In most cases, it should be sufficient * to have built-in validation thr...
MINOR Removed @usedby, it's not a valid phpdoc token
diff --git a/tests/Fixture/CounterlessMuffinsFixture.php b/tests/Fixture/CounterlessMuffinsFixture.php index <HASH>..<HASH> 100644 --- a/tests/Fixture/CounterlessMuffinsFixture.php +++ b/tests/Fixture/CounterlessMuffinsFixture.php @@ -7,11 +7,6 @@ use Cake\TestSuite\Fixture\TestFixture; class CounterlessMuffinsFixture...
Fix tests after <I> release
diff --git a/src/python/grpcio_tests/tests/unit/_logging_test.py b/src/python/grpcio_tests/tests/unit/_logging_test.py index <HASH>..<HASH> 100644 --- a/src/python/grpcio_tests/tests/unit/_logging_test.py +++ b/src/python/grpcio_tests/tests/unit/_logging_test.py @@ -45,13 +45,23 @@ class LoggingTest(unittest.TestCase):...
Add explicit test that user can configure their own handler
diff --git a/lib/loga/configuration.rb b/lib/loga/configuration.rb index <HASH>..<HASH> 100644 --- a/lib/loga/configuration.rb +++ b/lib/loga/configuration.rb @@ -29,7 +29,7 @@ module Loga end def initialize! - @service_name.to_s.strip! + @service_name = service_name.to_s.strip @service_ver...
Remove service_name mutation when initializing, closes #<I>
diff --git a/lib/yap/shell/evaluation.rb b/lib/yap/shell/evaluation.rb index <HASH>..<HASH> 100644 --- a/lib/yap/shell/evaluation.rb +++ b/lib/yap/shell/evaluation.rb @@ -55,7 +55,7 @@ module Yap::Shell @aliases_expanded ||= [] @command_node_args_stack ||= [] with_standard_streams do |stdin, stdout...
When processing arguments shell_expand them (not just variable_expand). This ensures that expansions like ~ work.
diff --git a/tests/Negotiation/Tests/NegotiatorTest.php b/tests/Negotiation/Tests/NegotiatorTest.php index <HASH>..<HASH> 100644 --- a/tests/Negotiation/Tests/NegotiatorTest.php +++ b/tests/Negotiation/Tests/NegotiatorTest.php @@ -28,18 +28,22 @@ class NegotiatorTest extends TestCase { try { ...
Reduce try/catch to getBest method only. PHPUnit uses Exceptions in its asserts functions. In case of assertion failure in test, it is caught by the catch block and give a wrong message.
diff --git a/datasources/sql/DbModel.php b/datasources/sql/DbModel.php index <HASH>..<HASH> 100644 --- a/datasources/sql/DbModel.php +++ b/datasources/sql/DbModel.php @@ -275,8 +275,8 @@ abstract class DbModel extends BaseModel implements ModelInterface { } } - public function relationIsSet($relatinN...
Fixed column read when value is null.
diff --git a/examples/example2.js b/examples/example2.js index <HASH>..<HASH> 100644 --- a/examples/example2.js +++ b/examples/example2.js @@ -13,7 +13,7 @@ hosts.forEach(function (host) { hosts.forEach(function (host) { ping.promise.probe(host, { timeout: 10, - extra: ["-i 2"] + extra: ["-...
Fix bug on window platform --Overview 1. Window's ping command treat '-i 2' as an invalid option. Therefore, we must split them up. IE using ['-i', '2'] instead of ['-i 2']
diff --git a/lib/bento_search/version.rb b/lib/bento_search/version.rb index <HASH>..<HASH> 100644 --- a/lib/bento_search/version.rb +++ b/lib/bento_search/version.rb @@ -1,3 +1,3 @@ module BentoSearch - VERSION = "0.0.1" + VERSION = "0.5.0" end
time for another gem release, let's call it <I>, it's getting stable-ish
diff --git a/fireplace/game.py b/fireplace/game.py index <HASH>..<HASH> 100644 --- a/fireplace/game.py +++ b/fireplace/game.py @@ -172,6 +172,9 @@ class BaseGame(Entity): else: player.playstate = PlayState.WON self.state = State.COMPLETE + self.manager.step(self.next_step, Step.FINAL_WRAPUP) + self...
Walk through WRAPUP and GAMEOVER at the end of the game Touches #<I>
diff --git a/salt/modules/virtualenv_mod.py b/salt/modules/virtualenv_mod.py index <HASH>..<HASH> 100644 --- a/salt/modules/virtualenv_mod.py +++ b/salt/modules/virtualenv_mod.py @@ -319,7 +319,7 @@ def _install_script(source, cwd, python, user, saltenv='base'): if not salt.utils.is_windows(): fn_ = __sal...
Use octal. Since it's a permission. I can't do decimal -> octal -> unix perms in my head.
diff --git a/public/js/directives.js b/public/js/directives.js index <HASH>..<HASH> 100644 --- a/public/js/directives.js +++ b/public/js/directives.js @@ -14,7 +14,12 @@ angular.module('njax.directives', ['njax.services']) try{ var jBody = $(element[0].contentWindow.document.body); jBody.find('#n...
Trying to squash iframe bug
diff --git a/code/model/UserDefinedForm.php b/code/model/UserDefinedForm.php index <HASH>..<HASH> 100755 --- a/code/model/UserDefinedForm.php +++ b/code/model/UserDefinedForm.php @@ -838,7 +838,7 @@ JS * @param ArrayList fields * @return ArrayData */ - private function getMergeFieldsMap($fields = a...
Make getMergeFieldsMap protected Annoying having to copy this method if you want to replace "process" in an extending class so we'll make it a bit looser shall we?
diff --git a/src/Visitor/QueryItemElastica.php b/src/Visitor/QueryItemElastica.php index <HASH>..<HASH> 100644 --- a/src/Visitor/QueryItemElastica.php +++ b/src/Visitor/QueryItemElastica.php @@ -43,7 +43,7 @@ class QueryItemElastica implements QueryItemVisitorInterface */ public function visitPhrase(Node\Phr...
Fixed typo - wrong param name
diff --git a/python/phonenumbers/phonemetadata.py b/python/phonenumbers/phonemetadata.py index <HASH>..<HASH> 100644 --- a/python/phonenumbers/phonemetadata.py +++ b/python/phonenumbers/phonemetadata.py @@ -402,6 +402,7 @@ class PhoneMetadata(object): result += ",\n voip=%s" % self.voip result += "...
Include emergency PhoneNumberDesc in metadata self-serialization output
diff --git a/docs/_static/js/custom.js b/docs/_static/js/custom.js index <HASH>..<HASH> 100644 --- a/docs/_static/js/custom.js +++ b/docs/_static/js/custom.js @@ -21,8 +21,27 @@ window.onload = function () { $(" nav.bd-links ").children().hide() } - var selected = $("a.current") - selected.html("&...
Update custom.js in docs
diff --git a/irc3/plugins/feeds.py b/irc3/plugins/feeds.py index <HASH>..<HASH> 100644 --- a/irc3/plugins/feeds.py +++ b/irc3/plugins/feeds.py @@ -61,6 +61,7 @@ import time import irc3 import datetime from concurrent.futures import ThreadPoolExecutor +from operator import itemgetter def default_hook(entries): @...
Sort feed entries with the date field only. Otherwise, if there are multiple entries at the same date, this fails because the second field is a `FeedParserDict` which is not sortable.
diff --git a/tile_generator/package_definitions.py b/tile_generator/package_definitions.py index <HASH>..<HASH> 100644 --- a/tile_generator/package_definitions.py +++ b/tile_generator/package_definitions.py @@ -66,7 +66,7 @@ class PackageBoshRelease(BasePackage): flags = [flag.BoshRelease] _schema = { ...
Fix issue #<I>, handle Capital letters as a valid package name start, allow for underscore _ in name
diff --git a/wordpress_xmlrpc/wordpress.py b/wordpress_xmlrpc/wordpress.py index <HASH>..<HASH> 100644 --- a/wordpress_xmlrpc/wordpress.py +++ b/wordpress_xmlrpc/wordpress.py @@ -50,7 +50,6 @@ class WordPressBase(object): data[output] = fmap.conversion(getattr(self, var)) ...
Removed erroneous print statement.
diff --git a/lib/chrome/webdriver/index.js b/lib/chrome/webdriver/index.js index <HASH>..<HASH> 100644 --- a/lib/chrome/webdriver/index.js +++ b/lib/chrome/webdriver/index.js @@ -55,6 +55,13 @@ module.exports.configureBuilder = function(builder, baseDir, options) { let chromeOptions = new chrome.Options(); chrome...
Disable save passwords popups in Chrome. (#<I>) This was introduced when we removed the WebExtension for Chrome.
diff --git a/packages/request-maxdome/src/Asset.js b/packages/request-maxdome/src/Asset.js index <HASH>..<HASH> 100644 --- a/packages/request-maxdome/src/Asset.js +++ b/packages/request-maxdome/src/Asset.js @@ -21,6 +21,7 @@ class Asset { this.protocol = protocol; this.id = data.id; + this.referenceId = ...
Use ID of the series if its the first season
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -23,7 +23,8 @@ setup( entry_points={ 'console_scripts': [ 'alfred-workflow-packager=awp.main:main', - 'workflow-packager=awp.main:main' + 'workflow-packager=awp.main:main', + ...
Add awp as an additional shell command
diff --git a/app/assets/javascripts/fastui/app/view/VTab.js b/app/assets/javascripts/fastui/app/view/VTab.js index <HASH>..<HASH> 100644 --- a/app/assets/javascripts/fastui/app/view/VTab.js +++ b/app/assets/javascripts/fastui/app/view/VTab.js @@ -6,7 +6,6 @@ Ext.define('FastUI.view.VTab', { layout:"card", ini...
create abstract class MObject most of class are inherit it
diff --git a/modules/smartnameattribute/lib/Auth/Process/SmartName.php b/modules/smartnameattribute/lib/Auth/Process/SmartName.php index <HASH>..<HASH> 100644 --- a/modules/smartnameattribute/lib/Auth/Process/SmartName.php +++ b/modules/smartnameattribute/lib/Auth/Process/SmartName.php @@ -21,6 +21,11 @@ class sspmod_s...
use cn if contains multiple parts
diff --git a/lib/chef/json_compat.rb b/lib/chef/json_compat.rb index <HASH>..<HASH> 100644 --- a/lib/chef/json_compat.rb +++ b/lib/chef/json_compat.rb @@ -18,8 +18,6 @@ # Wrapper class for interacting with JSON. require 'ffi_yajl' -#require 'json' -require 'ffi_yajl/json_gem' # XXX: parts of chef require JSON gem'...
Removing old .to_json monkeypatching for all objects
diff --git a/anchore/cli/toolbox.py b/anchore/cli/toolbox.py index <HASH>..<HASH> 100644 --- a/anchore/cli/toolbox.py +++ b/anchore/cli/toolbox.py @@ -325,6 +325,10 @@ def show_analyzer_status(): @click.option('--outfile', help='output file for exported image', required=True, metavar='<file.json>') def export(outfile...
small fix to disallow export if image has not been analyzed
diff --git a/tests/Functional/Table/TableServiceFunctionalTest.php b/tests/Functional/Table/TableServiceFunctionalTest.php index <HASH>..<HASH> 100644 --- a/tests/Functional/Table/TableServiceFunctionalTest.php +++ b/tests/Functional/Table/TableServiceFunctionalTest.php @@ -215,7 +215,7 @@ class TableServiceFunctionalT...
Resolve set service properties issue.
diff --git a/main/cloudfoundry_client/v3/apps.py b/main/cloudfoundry_client/v3/apps.py index <HASH>..<HASH> 100644 --- a/main/cloudfoundry_client/v3/apps.py +++ b/main/cloudfoundry_client/v3/apps.py @@ -11,3 +11,6 @@ class AppManager(EntityManager): def get_env(self, application_guid: str) -> JsonObject: ...
Adding new method to retrive app routes
diff --git a/acceptance/tests/resource/service/ticket_1343_should_add_and_remove_symlinks.rb b/acceptance/tests/resource/service/ticket_1343_should_add_and_remove_symlinks.rb index <HASH>..<HASH> 100644 --- a/acceptance/tests/resource/service/ticket_1343_should_add_and_remove_symlinks.rb +++ b/acceptance/tests/resource...
(PUP-<I>) confine test ticket_<I> to el-5 This fixes the acceptance test failures happening for all the platforms this test wasn't intended for.
diff --git a/packages/build-tools/svgo-plugins.js b/packages/build-tools/svgo-plugins.js index <HASH>..<HASH> 100644 --- a/packages/build-tools/svgo-plugins.js +++ b/packages/build-tools/svgo-plugins.js @@ -83,9 +83,6 @@ module.exports = [ moveGroupAttrsToElems: true, }, { - collapseGroups: true, - }, - ...
chore: don't collapse SVG groups in SVGO and instead just stick to using the default SVGO config for this
diff --git a/emirdrp/recipes/image/join.py b/emirdrp/recipes/image/join.py index <HASH>..<HASH> 100644 --- a/emirdrp/recipes/image/join.py +++ b/emirdrp/recipes/image/join.py @@ -128,7 +128,6 @@ class JoinDitheredImagesRecipe(EmirRecipe): def run_single(self, rinput): use_errors = True - datamode...
Update SKYADD keyword in Dither to allow forced sky subtraction
diff --git a/lib/OpenLayers/Control/Scale.js b/lib/OpenLayers/Control/Scale.js index <HASH>..<HASH> 100644 --- a/lib/OpenLayers/Control/Scale.js +++ b/lib/OpenLayers/Control/Scale.js @@ -11,11 +11,12 @@ OpenLayers.Control.Scale = Class.create(); OpenLayers.Control.Scale.prototype = Object.extend( new OpenLayers.Co...
Fix broken units: inches was missing, and dd was in place of images. git-svn-id: <URL>
diff --git a/impl-base/src/test/java/DefaultPackageAddTestCase.java b/impl-base/src/test/java/DefaultPackageAddTestCase.java index <HASH>..<HASH> 100644 --- a/impl-base/src/test/java/DefaultPackageAddTestCase.java +++ b/impl-base/src/test/java/DefaultPackageAddTestCase.java @@ -91,12 +91,27 @@ public class DefaultPacka...
[SHRINKWRAP-<I>] Makes sure classes only from the default package are added
diff --git a/lib/whenever/capistrano/v2/recipes.rb b/lib/whenever/capistrano/v2/recipes.rb index <HASH>..<HASH> 100644 --- a/lib/whenever/capistrano/v2/recipes.rb +++ b/lib/whenever/capistrano/v2/recipes.rb @@ -7,7 +7,7 @@ Capistrano::Configuration.instance(:must_exist).load do _cset(:whenever_options) { {:role...
Default `rails_env` to `:stage` in Capistrano v2 Similar to #<I>.
diff --git a/lib/Service/Application.js b/lib/Service/Application.js index <HASH>..<HASH> 100644 --- a/lib/Service/Application.js +++ b/lib/Service/Application.js @@ -16,7 +16,7 @@ module.exports = function(di, config) { methods: ['GET', 'POST', 'PATCH', 'DELETE', 'OPTIONS'] })); - app.use(require('....
fix: no debug response in REST, invalid continue option in Service/Application
diff --git a/src/main/java/com/dcsquare/hivemq/spi/callback/events/OnPublishReceivedCallback.java b/src/main/java/com/dcsquare/hivemq/spi/callback/events/OnPublishReceivedCallback.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/dcsquare/hivemq/spi/callback/events/OnPublishReceivedCallback.java +++ b/src/main/j...
fixed OnPublishReceivedCallback documentation
diff --git a/config/pubsub.php b/config/pubsub.php index <HASH>..<HASH> 100644 --- a/config/pubsub.php +++ b/config/pubsub.php @@ -29,8 +29,8 @@ return [ 'connections' => [ - 'null' => [ - 'driver' => 'null', + '/dev/null' => [ + 'driver' => '/dev/null', ], ...
forgot to rename /dev/null
diff --git a/content/template/bookingTemplate/questionView.php b/content/template/bookingTemplate/questionView.php index <HASH>..<HASH> 100644 --- a/content/template/bookingTemplate/questionView.php +++ b/content/template/bookingTemplate/questionView.php @@ -16,7 +16,7 @@ } array_multisort($qCategories, SOR...
1 file changed, 1 insertion(+), 1 deletion(-) On branch master Your branch is up-to-date with 'origin/master'. Changes to be committed: (use "git reset HEAD <file>..." to unstage) modified: content/template/bookingTemplate/questionView.php
diff --git a/lib/jsonapi/resource_serializer.rb b/lib/jsonapi/resource_serializer.rb index <HASH>..<HASH> 100644 --- a/lib/jsonapi/resource_serializer.rb +++ b/lib/jsonapi/resource_serializer.rb @@ -306,7 +306,7 @@ module JSONAPI if relationship.is_a?(JSONAPI::Relationship::ToMany) if relationship.polym...
underscorize resource type name in links
diff --git a/lib/codemirror.js b/lib/codemirror.js index <HASH>..<HASH> 100644 --- a/lib/codemirror.js +++ b/lib/codemirror.js @@ -20,7 +20,7 @@ var CodeMirror = (function() { // This mess creates the base DOM structure for the editor. wrapper.innerHTML = '<div style="overflow: hidden; position: relati...
Add explicit height to inner textarea to prevent surprising css rule interactions
diff --git a/raiden/transfer/events.py b/raiden/transfer/events.py index <HASH>..<HASH> 100644 --- a/raiden/transfer/events.py +++ b/raiden/transfer/events.py @@ -412,7 +412,7 @@ class EventPaymentSentFailed(Event): pex(self.payment_network_identifier), pex(self.token_network_identifier), ...
Fix __repr__ of some classes [skip ci]
diff --git a/run.go b/run.go index <HASH>..<HASH> 100644 --- a/run.go +++ b/run.go @@ -33,9 +33,15 @@ func StartWithSize(c *exec.Cmd, sz *Winsize) (pty *os.File, err error) { return nil, err } } - c.Stdout = tty - c.Stdin = tty - c.Stderr = tty + if c.Stdout == nil { + c.Stdout = tty + } + if c.Stderr == nil ...
Don't set Stdin/Stdout/Stderr if already set (#<I>) * only set stdout and stderr if not already set * Don't set cmd.Stdin if it's already set Considered @craek's codereview
diff --git a/lib/ajax/section_classes.js b/lib/ajax/section_classes.js index <HASH>..<HASH> 100755 --- a/lib/ajax/section_classes.js +++ b/lib/ajax/section_classes.js @@ -849,7 +849,9 @@ resource_class.prototype.clear_move_markers = function(target) { resources = target.parentObj.resources; } for (va...
MDL-<I> Preventing the border from being assigned to label list elements. Merged from MOODLE_<I>_STABLE
diff --git a/code/services/QueuedJobService.php b/code/services/QueuedJobService.php index <HASH>..<HASH> 100644 --- a/code/services/QueuedJobService.php +++ b/code/services/QueuedJobService.php @@ -261,7 +261,6 @@ class QueuedJobService $job->prepareForRestart(); } - // make sure the descriptor is up to ...
Added additional call to 'write' after setting broken job
diff --git a/src/plugins/background_button/background_button.js b/src/plugins/background_button/background_button.js index <HASH>..<HASH> 100644 --- a/src/plugins/background_button/background_button.js +++ b/src/plugins/background_button/background_button.js @@ -35,7 +35,17 @@ class BackgroundButton extends UICorePlugi...
fix background button mediator event leak (refs #<I>)
diff --git a/src/Events/EntityWasSaved.php b/src/Events/EntityWasSaved.php index <HASH>..<HASH> 100644 --- a/src/Events/EntityWasSaved.php +++ b/src/Events/EntityWasSaved.php @@ -42,9 +42,15 @@ class EntityWasSaved if ($relationValue instanceof ValueCollection) { foreach ...
Set attribute value's entity_id since it's always null
diff --git a/lib/rspec-puppet/tasks/release_test.rb b/lib/rspec-puppet/tasks/release_test.rb index <HASH>..<HASH> 100644 --- a/lib/rspec-puppet/tasks/release_test.rb +++ b/lib/rspec-puppet/tasks/release_test.rb @@ -128,7 +128,7 @@ task :release_test do end end -class GemfileRewrite < Parser::Rewriter +class Gemfi...
Update release_test GemfileRewrite to use Parser::TreeRewriter
diff --git a/spyderlib/spyder.py b/spyderlib/spyder.py index <HASH>..<HASH> 100644 --- a/spyderlib/spyder.py +++ b/spyderlib/spyder.py @@ -34,7 +34,13 @@ if is_module_installed('IPython', '>=0.12'): # bootstrap script has eventually set this option), switch to # PyQt API #2 by simply importing the I...
Fixed regression introduced with revision ed<I>bb<I>b<I>a: no Tkinter message was shown when neither PyQt4 or PySide was installed
diff --git a/src/frontend/org/voltdb/SnapshotDaemon.java b/src/frontend/org/voltdb/SnapshotDaemon.java index <HASH>..<HASH> 100644 --- a/src/frontend/org/voltdb/SnapshotDaemon.java +++ b/src/frontend/org/voltdb/SnapshotDaemon.java @@ -965,7 +965,7 @@ public class SnapshotDaemon implements SnapshotCompletionInterest { ...
ENG-<I> Fix trunc event on SnapshotDaemon promotion.
diff --git a/ParameterConverter.php b/ParameterConverter.php index <HASH>..<HASH> 100644 --- a/ParameterConverter.php +++ b/ParameterConverter.php @@ -8,12 +8,12 @@ class ParameterConverter { if (is_array($args)) { $failed = array_filter($args, function ($e) use ($type_of) { - ...
Trying to solve github issues
diff --git a/lib/active_support/cache/dalli_store.rb b/lib/active_support/cache/dalli_store.rb index <HASH>..<HASH> 100644 --- a/lib/active_support/cache/dalli_store.rb +++ b/lib/active_support/cache/dalli_store.rb @@ -109,13 +109,13 @@ module ActiveSupport end if entry == not_found - ...
Always pass namespaced key to the subscriber of instrumentation API To be consistent with other events (e.g. `read`, `write`), namespaced keys should be passed to the subscribers of the following events: - fetch_hit - generate - read_multi - fetch_multi
diff --git a/gym/lib/gym/detect_values.rb b/gym/lib/gym/detect_values.rb index <HASH>..<HASH> 100644 --- a/gym/lib/gym/detect_values.rb +++ b/gym/lib/gym/detect_values.rb @@ -98,9 +98,12 @@ module Gym bundle_identifier = current["PRODUCT_BUNDLE_IDENTIFIER"] provisioning_profile_specifier...
Detect selected provisioning profile UUIDs for Xcode 9 (#<I>) * Detect selected provisioning profile UUIDs for Xcode 9 The Xcode 9 provisioningProfiles export option allows to specify either provisioning profile names (specifiers) or UUIDs. When automatically generating provisioningProfiles from the project file ...
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -40,9 +40,14 @@ setup( packages=find_packages(), install_requires=['spglib', 'numpy', 'scipy', 'pymatgen>=2017.12.30', 'h5py', 'phonopy', 'matplotlib', 'seekpath'], - extras_require={'docs':...
Add style sheets to setup.py
diff --git a/packages/@vue/cli-service/lib/Service.js b/packages/@vue/cli-service/lib/Service.js index <HASH>..<HASH> 100644 --- a/packages/@vue/cli-service/lib/Service.js +++ b/packages/@vue/cli-service/lib/Service.js @@ -189,7 +189,7 @@ module.exports = class Service { } plugins = plugins.concat(files.m...
fix: fix resolve project local plugin's file path (#<I>)
diff --git a/salt/modules/win_file.py b/salt/modules/win_file.py index <HASH>..<HASH> 100644 --- a/salt/modules/win_file.py +++ b/salt/modules/win_file.py @@ -28,6 +28,7 @@ import re # do not remove, used in imported file.py functions import sys # do not remove, used in imported file.py functions import fileinput ...
Added missing import mmap required by file.py
diff --git a/staticfy.py b/staticfy.py index <HASH>..<HASH> 100644 --- a/staticfy.py +++ b/staticfy.py @@ -58,8 +58,9 @@ def staticfy(file_, static_endpoint='static', project_type='flask', **kwargs): file_handle.close() - # incase filename is a link to a path + # extract the filename incase the filename ...
Fixed issue with staticfy filling in None when the static url is not specified
diff --git a/lib/core/jhipster/field_types.js b/lib/core/jhipster/field_types.js index <HASH>..<HASH> 100644 --- a/lib/core/jhipster/field_types.js +++ b/lib/core/jhipster/field_types.js @@ -61,7 +61,7 @@ const CommonDBValidations = { Double: new CustomSet([REQUIRED, UNIQUE, MIN, MAX]), Enum: new CustomSet([REQUI...
Fixed issue with unique validation for LocalDate
diff --git a/src/super_archives/models.py b/src/super_archives/models.py index <HASH>..<HASH> 100644 --- a/src/super_archives/models.py +++ b/src/super_archives/models.py @@ -108,6 +108,10 @@ class Thread(models.Model): verbose_name_plural = _(u"Threads") unique_together = ('subject_token', 'mailingli...
Adding get_absolute_url method to thread
diff --git a/drools-compiler/src/main/java/org/drools/compiler/builder/impl/TypeDeclarationFactory.java b/drools-compiler/src/main/java/org/drools/compiler/builder/impl/TypeDeclarationFactory.java index <HASH>..<HASH> 100644 --- a/drools-compiler/src/main/java/org/drools/compiler/builder/impl/TypeDeclarationFactory.jav...
Fix typo in error message (cherry picked from commit f<I>f<I>ee<I>b<I>cb5bf3ce)
diff --git a/js/bitfinex.js b/js/bitfinex.js index <HASH>..<HASH> 100644 --- a/js/bitfinex.js +++ b/js/bitfinex.js @@ -673,7 +673,7 @@ module.exports = class bitfinex extends Exchange { return this.parseOrder (result); } - async editOrder (id, symbol = undefined, type = undefined, side = undefined, a...
bitfinex editOrder signature compatible with the declaration from the base class
diff --git a/src/projex/rest.py b/src/projex/rest.py index <HASH>..<HASH> 100644 --- a/src/projex/rest.py +++ b/src/projex/rest.py @@ -116,6 +116,8 @@ def py2json(py_obj): return py_obj.strftime('%Y-%m-%d') elif type(py_obj) == datetime.time: return py_obj.strftime('%H:%M:%S:%f') + elif typ...
* json cannot serialize set's, converting to a list
diff --git a/spec/rbnacl/util_spec.rb b/spec/rbnacl/util_spec.rb index <HASH>..<HASH> 100644 --- a/spec/rbnacl/util_spec.rb +++ b/spec/rbnacl/util_spec.rb @@ -118,6 +118,16 @@ describe RbNaCl::Util do end end + context "check_string" do + it "raises EncodingError when given strings with non-BINARY encodin...
Spec for non-BINARY encodings
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -12,7 +12,7 @@ def read(fname): setup( name='sqlacfg', - version='0.3.dev1', + version='0.4.dev1', description='Stores configurations in a database instead of a file', long_description=read('README.rst'...
Start developing version <I>.dev1 (after release of <I>)
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -14,6 +14,7 @@ setup( # long_description=open('README.md').read(), install_requires=[ 'Django>=1.6,<1.7', + 'django-shared', ], dependency_links=[ ],
added django-shared dependency
diff --git a/minimal.js b/minimal.js index <HASH>..<HASH> 100644 --- a/minimal.js +++ b/minimal.js @@ -22,12 +22,11 @@ function unbox(data, unboxers, key) { for(var i = 0;i < unboxers.length;i++) { var unboxer = unboxers[i] - if (key) { - plaintext = unboxer.value(data.value.content, key) - ...
can't use key if unboxer is old style, without key method. otherwise, handle if key is already available or not. sorry @christianbundy my earlier advice was incorrect
diff --git a/src/commands/test/util/browser-tests-runner/setup.js b/src/commands/test/util/browser-tests-runner/setup.js index <HASH>..<HASH> 100644 --- a/src/commands/test/util/browser-tests-runner/setup.js +++ b/src/commands/test/util/browser-tests-runner/setup.js @@ -9,12 +9,23 @@ window.mocha.reporter('html'); r...
Add support for promises when testing in the browser
diff --git a/core/serial_web_bluetooth.js b/core/serial_web_bluetooth.js index <HASH>..<HASH> 100644 --- a/core/serial_web_bluetooth.js +++ b/core/serial_web_bluetooth.js @@ -44,7 +44,7 @@ return {error:"Serving off HTTP (not HTTPS)"}; } if (!isSupportedByBrowser) { - // return {error:"Web Bluetoot...
check for 'implemented but not enabled'
diff --git a/src/config/boomcms/viewHelpers.php b/src/config/boomcms/viewHelpers.php index <HASH>..<HASH> 100644 --- a/src/config/boomcms/viewHelpers.php +++ b/src/config/boomcms/viewHelpers.php @@ -4,15 +4,11 @@ use BoomCMS\Core\Page; return [ 'viewHelpers' => [ - 'assetURL' => function() { - $args = ...
Fixed bugs in $assetURL view helper
diff --git a/tests/app/src/Command/CommandRunner.php b/tests/app/src/Command/CommandRunner.php index <HASH>..<HASH> 100644 --- a/tests/app/src/Command/CommandRunner.php +++ b/tests/app/src/Command/CommandRunner.php @@ -4,7 +4,6 @@ namespace App\Command; use Symfony\Bundle\FrameworkBundle\Console\Application; use Sy...
Report error on running command on unit testing
diff --git a/pyxel/editor/__init__.py b/pyxel/editor/__init__.py index <HASH>..<HASH> 100644 --- a/pyxel/editor/__init__.py +++ b/pyxel/editor/__init__.py @@ -11,7 +11,7 @@ def run(): print("usage: pyxeleditor pyxel_resource_file") print("\n") print("Pyxel Editor {}".format(pyxel.VERSION)) - ...
Modified the usage of Pyxel Editor
diff --git a/core/src/main/java/hudson/model/Computer.java b/core/src/main/java/hudson/model/Computer.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/hudson/model/Computer.java +++ b/core/src/main/java/hudson/model/Computer.java @@ -1313,7 +1313,7 @@ public /*transient*/ abstract class Computer extends Action...
Expanding Javadoc from #<I> as suggested by @oleg-nenashev.
diff --git a/future/tests/test_httplib.py b/future/tests/test_httplib.py index <HASH>..<HASH> 100644 --- a/future/tests/test_httplib.py +++ b/future/tests/test_httplib.py @@ -26,7 +26,7 @@ HOST = support.HOST class FakeSocket(object): def __init__(self, text, fileclass=io.BytesIO): - if isinstance(text, ...
Use isinstance(blah, type('')) idiom in test_httplib.py * TODO: The docs should describe the purpose of this too. * Is there a cleaner alternative that could be recommended over this?
diff --git a/runipy/main.py b/runipy/main.py index <HASH>..<HASH> 100644 --- a/runipy/main.py +++ b/runipy/main.py @@ -118,7 +118,13 @@ def main(): exporter = HTMLExporter() else: exporter = HTMLExporter( - config=Config({'HTMLExporter':{'template_file':args.templat...
runipy/main.py: Wrap `HTMLExporter` arguments to make them more readable and shorten the line length.
diff --git a/blocks/admin_tree/block_admin_tree.php b/blocks/admin_tree/block_admin_tree.php index <HASH>..<HASH> 100644 --- a/blocks/admin_tree/block_admin_tree.php +++ b/blocks/admin_tree/block_admin_tree.php @@ -22,8 +22,11 @@ class block_admin_tree extends block_base { } function applicable_formats() { ...
Prevent admin tree to be showed for non-admins in 'my' page. MDL-<I> ; merged from <I>_STABLE
diff --git a/grunt.js b/grunt.js index <HASH>..<HASH> 100644 --- a/grunt.js +++ b/grunt.js @@ -63,6 +63,9 @@ module.exports = function( grunt ) { lint: { files: [ "grunt.js", "dist/jquery.js" ] }, + qunit: { + files: "test/index.html" + }, watch: { files: "<config:lint.files>", tasks: "concat l...
Grunt: Add qunit target. Currently finishes with <I>/<I> assertions failing. If that can be made to pass, it should be added to the default task
diff --git a/rejected/consumer.py b/rejected/consumer.py index <HASH>..<HASH> 100644 --- a/rejected/consumer.py +++ b/rejected/consumer.py @@ -896,6 +896,12 @@ class Consumer(object): self._republish_processing_error(error_text) raise gen.Return(data.PROCESSING_EXCEPTION) + except Not...
Possibly address issue #<I> by catching NotImplementedError
diff --git a/lib/easypost/object.rb b/lib/easypost/object.rb index <HASH>..<HASH> 100644 --- a/lib/easypost/object.rb +++ b/lib/easypost/object.rb @@ -134,7 +134,9 @@ class EasyPost::EasyPostObject # The metaclass of an object. def metaclass - class << self; self; end + class << self + self; + end...
- Fix linting issues
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -139,7 +139,7 @@ install_requires=[ 'enum34 >= 1.1.6', 'funcsigs >= 0.4', 'futures >= 3.0.5', - 'hypercube == 0.3.0a6', + 'hypercube == 0.3.2', 'numpy >= 1.11.3', 'numexpr >= 2.6.1', 'python...
Upgrade to hypercube <I>
diff --git a/framework/zii/widgets/CMenu.php b/framework/zii/widgets/CMenu.php index <HASH>..<HASH> 100644 --- a/framework/zii/widgets/CMenu.php +++ b/framework/zii/widgets/CMenu.php @@ -24,6 +24,7 @@ * // Important: you need to specify url as 'controller/action', * // not just as 'controller' even ...
(Fixes issue <I>) More API docs for CMenu
diff --git a/src/main/java/com/cloudbees/jenkins/support/impl/UpdateCenter.java b/src/main/java/com/cloudbees/jenkins/support/impl/UpdateCenter.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/cloudbees/jenkins/support/impl/UpdateCenter.java +++ b/src/main/java/com/cloudbees/jenkins/support/impl/UpdateCenter.ja...
Mention that the async-http-client plugin is not installed.
diff --git a/core/src/main/java/jenkins/security/DefaultConfidentialStore.java b/core/src/main/java/jenkins/security/DefaultConfidentialStore.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/jenkins/security/DefaultConfidentialStore.java +++ b/core/src/main/java/jenkins/security/DefaultConfidentialStore.java @...
[FIXED JENKINS-<I>] Treat BadPaddingException as an unloadable key and continue. (cherry picked from commit <I>b8d<I>abdf8b<I>f4e1b8ce8bf<I>e<I>ad) Conflicts: changelog.html
diff --git a/src/parser-flow.js b/src/parser-flow.js index <HASH>..<HASH> 100644 --- a/src/parser-flow.js +++ b/src/parser-flow.js @@ -4,6 +4,8 @@ const createError = require("./parser-create-error"); const includeShebang = require("./parser-include-shebang"); function parse(text) { + // Fixes Node 4 issue (#1986)...
Add "use strict" to fix SyntaxError on Node@4 (#<I>)
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/time/StronglyTypeTime.java b/core/src/main/java/com/google/errorprone/bugpatterns/time/StronglyTypeTime.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/time/StronglyTypeTime.java +++ b/core/src/main/java/com/go...
Re-write DEADLINE_USEC to DEADLINE instead of DEADLINE_U. PiperOrigin-RevId: <I>
diff --git a/lib/rack/typhoeus/middleware/params_decoder/helper.rb b/lib/rack/typhoeus/middleware/params_decoder/helper.rb index <HASH>..<HASH> 100644 --- a/lib/rack/typhoeus/middleware/params_decoder/helper.rb +++ b/lib/rack/typhoeus/middleware/params_decoder/helper.rb @@ -48,8 +48,12 @@ module Rack # @retu...
FIXED: Any key .to_i would turn 0. So if there was only 1 key, converted? returned true wrongly
diff --git a/src/java/org/apache/cassandra/gms/Gossiper.java b/src/java/org/apache/cassandra/gms/Gossiper.java index <HASH>..<HASH> 100644 --- a/src/java/org/apache/cassandra/gms/Gossiper.java +++ b/src/java/org/apache/cassandra/gms/Gossiper.java @@ -241,6 +241,7 @@ public class Gossiper implements IFailureDetectionEve...
Keep endpoint state until aVeryLongTime. Patch by brandonwilliams reviewed by gdusbabek for CASSANDRA-<I> git-svn-id: <URL>
diff --git a/spec/rollbar_spec.rb b/spec/rollbar_spec.rb index <HASH>..<HASH> 100644 --- a/spec/rollbar_spec.rb +++ b/spec/rollbar_spec.rb @@ -157,6 +157,7 @@ describe Rollbar do end it 'should not modify any parent notifier configuration' do + configure Rollbar.configuration.code_versio...
Reconfigure Rollbar in a random spec.
diff --git a/spec/scorm_engine/api/endpoints/registrations_spec.rb b/spec/scorm_engine/api/endpoints/registrations_spec.rb index <HASH>..<HASH> 100644 --- a/spec/scorm_engine/api/endpoints/registrations_spec.rb +++ b/spec/scorm_engine/api/endpoints/registrations_spec.rb @@ -126,7 +126,7 @@ RSpec.describe ScormEngine::A...
fix test now that we have new models
diff --git a/webroot/js/helper.js b/webroot/js/helper.js index <HASH>..<HASH> 100644 --- a/webroot/js/helper.js +++ b/webroot/js/helper.js @@ -585,8 +585,9 @@ foodcoopshop.Helper = { var root = '#content'; - if (foodcoopshop.Helper.isMobile()) { - root = '#responsive-header'; + var...
bugfix: responsive-header not used in admin
diff --git a/datacats/environment.py b/datacats/environment.py index <HASH>..<HASH> 100644 --- a/datacats/environment.py +++ b/datacats/environment.py @@ -384,7 +384,13 @@ class Environment(object): port = self.port production = production or self.always_prod - override_site_url = self.addres...
Add another condition for the site_url override - that no one has explicitly set the site_url
diff --git a/etebase/__init__.py b/etebase/__init__.py index <HASH>..<HASH> 100644 --- a/etebase/__init__.py +++ b/etebase/__init__.py @@ -2,7 +2,7 @@ import functools import msgpack -from .etebase_python import CollectionAccessLevel, PrefetchOption # noqa +from .etebase_python import CollectionAccessLevel, Prefe...
Utils: fix exposing Utils class. We weren't re-exporting it so it wasn't easily accessible.
diff --git a/backbone.localStorage.js b/backbone.localStorage.js index <HASH>..<HASH> 100644 --- a/backbone.localStorage.js +++ b/backbone.localStorage.js @@ -122,6 +122,10 @@ Backbone.LocalStorage.sync = window.Store.sync = Backbone.localSync = function(m if (options && options.error) options.error("Record not fo...
add options.complete to Backbone.LocalStorage.sync to add compatibility with $.ajax
diff --git a/app-examples/MongoNode.php b/app-examples/MongoNode.php index <HASH>..<HASH> 100644 --- a/app-examples/MongoNode.php +++ b/app-examples/MongoNode.php @@ -13,6 +13,7 @@ class MongoNode extends AppInstance { public $LockClient; // LockClient public $cursor; // Tailable cursor public $timer; + protected...
Added missing MongoNode\->inited property
diff --git a/bokeh/transforms/ar_downsample.py b/bokeh/transforms/ar_downsample.py index <HASH>..<HASH> 100644 --- a/bokeh/transforms/ar_downsample.py +++ b/bokeh/transforms/ar_downsample.py @@ -20,7 +20,7 @@ except: print("Install from the ./python directory with 'python setup.py install' (may require admin privled...
Removed raise on import error. Now it matches behavior of image_downsample.