diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/index.js b/lib/index.js index <HASH>..<HASH> 100644 --- a/lib/index.js +++ b/lib/index.js @@ -1,10 +1,10 @@ +S3 = require('AWS').S3; + Upload = (awsBucketName, options) { - this.aws = null; // initial aws connection - - this.awsBucketName = awsBucketName; - - // Set default options - this.path...
Init S3 bucket on new class instance
diff --git a/src/utils/source.js b/src/utils/source.js index <HASH>..<HASH> 100644 --- a/src/utils/source.js +++ b/src/utils/source.js @@ -280,6 +280,23 @@ function getMode(source: Source, sourceMetaData: SourceMetaDataType) { return "jsx"; } + const languageMimeMap = [ + { ext: ".c", mode: "text/x-csrc" ...
Add non-js languages (#<I>)
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -40,6 +40,7 @@ module.exports = function(app, dcPath) { '-f', dcFile, 'run', + '--service-ports', app, cmd ].join(' ');
[#1] add service ports option to the command
diff --git a/loadCSS.js b/loadCSS.js index <HASH>..<HASH> 100644 --- a/loadCSS.js +++ b/loadCSS.js @@ -31,21 +31,17 @@ function loadCSS( href, before, media, callback ){ // This function sets the link's media back to `all` so that the stylesheet applies once it loads // It is designed to poll until document.styleSh...
optimise: Simplify by returning early from the loop
diff --git a/app/templates/_keystone.js b/app/templates/_keystone.js index <HASH>..<HASH> 100644 --- a/app/templates/_keystone.js +++ b/app/templates/_keystone.js @@ -14,7 +14,6 @@ var Twig = require('twig');<% } %> // and documentation. <% } %> keystone.init({ - 'name': '<%= projectName %>', 'brand': '<%= proje...
Fixing lint errors in generated code
diff --git a/src/Extend/Item.php b/src/Extend/Item.php index <HASH>..<HASH> 100644 --- a/src/Extend/Item.php +++ b/src/Extend/Item.php @@ -35,7 +35,7 @@ class Item extends CommonItem implements ItemInterface */ public function getProductRecord() { - return $this->getParameter('product_code'); + ...
Issue #<I> - refactored to camel case for product code
diff --git a/tests/unit/framework/db/ActiveRecordTest.php b/tests/unit/framework/db/ActiveRecordTest.php index <HASH>..<HASH> 100644 --- a/tests/unit/framework/db/ActiveRecordTest.php +++ b/tests/unit/framework/db/ActiveRecordTest.php @@ -426,7 +426,16 @@ class ActiveRecordTest extends DatabaseTestCase $this->...
removed duplicated joins when using joinWith and via relations fixes #<I>
diff --git a/eZ/Publish/Core/REST/Server/Controller/Content.php b/eZ/Publish/Core/REST/Server/Controller/Content.php index <HASH>..<HASH> 100644 --- a/eZ/Publish/Core/REST/Server/Controller/Content.php +++ b/eZ/Publish/Core/REST/Server/Controller/Content.php @@ -67,7 +67,13 @@ class Content extends RestController ...
Fix for EZP-<I>: REST API: GET Content request fails when the content has not been published.
diff --git a/mtools/mlaunch/mlaunch.py b/mtools/mlaunch/mlaunch.py index <HASH>..<HASH> 100755 --- a/mtools/mlaunch/mlaunch.py +++ b/mtools/mlaunch/mlaunch.py @@ -994,7 +994,7 @@ class MLaunchTool(BaseCmdLineTool): self.wait_for(ports) - def _initiate_replset(self, port, name): + def _initiate_re...
introduced <I>sec delay in last commit. now correctly breaks if replset is configured.
diff --git a/pkg/policy/api/fqdn.go b/pkg/policy/api/fqdn.go index <HASH>..<HASH> 100644 --- a/pkg/policy/api/fqdn.go +++ b/pkg/policy/api/fqdn.go @@ -54,6 +54,10 @@ type FQDNSelector struct { MatchPattern string `json:"matchPattern,omitempty"` } +func (s *FQDNSelector) String() string { + return fmt.Sprintf("Matc...
policy API: add String() function for FQDNSelector Similar to the EndpointSelector, this allows for storing the string representation of an FQDNSelector as a map key in the SelectorCache.
diff --git a/mime.js b/mime.js index <HASH>..<HASH> 100644 --- a/mime.js +++ b/mime.js @@ -118,12 +118,14 @@ MIME.prototype = { * @return {String} */ encodeBase64: function( input, charset ) { - if( Buffer.isBuffer( input ) ) { - return input.toString( 'base64' ) - } else { + if( charset ) { ...
Updated mime.js: Added iconv to base<I> en/decoding
diff --git a/src/Symfony/Component/Security/Http/LoginLink/ExpiredLoginLinkStorage.php b/src/Symfony/Component/Security/Http/LoginLink/ExpiredLoginLinkStorage.php index <HASH>..<HASH> 100644 --- a/src/Symfony/Component/Security/Http/LoginLink/ExpiredLoginLinkStorage.php +++ b/src/Symfony/Component/Security/Http/LoginLi...
[Security] Mark ExpiredLoginLinkStorage as experimental
diff --git a/tests/test_vincent.py b/tests/test_vincent.py index <HASH>..<HASH> 100644 --- a/tests/test_vincent.py +++ b/tests/test_vincent.py @@ -206,12 +206,13 @@ class TestVincent(object): for cls in test_classes: vis1 = cls() vis2 = cls() - vis3 = cls() ass...
BUG: __sub__ added instead of removed - fixes <I>
diff --git a/chef/spec/unit/provider/user/pw_spec.rb b/chef/spec/unit/provider/user/pw_spec.rb index <HASH>..<HASH> 100644 --- a/chef/spec/unit/provider/user/pw_spec.rb +++ b/chef/spec/unit/provider/user/pw_spec.rb @@ -217,6 +217,9 @@ describe Chef::Provider::User::Pw do end describe "when loading the current s...
avoid libshadow check in User::Pw tests This fixes the case where there's a user named "adam" with "x" for the password field on the box running the tests
diff --git a/framework/filter.js b/framework/filter.js index <HASH>..<HASH> 100644 --- a/framework/filter.js +++ b/framework/filter.js @@ -210,12 +210,16 @@ module.exports = Base.extend({ this.partitions.forEach(function (partition) { if ((partition.selected.length === 2) && (partition.isDatetime || parti...
Keep binning settings as consistent as possible on zooming in closes #<I>
diff --git a/src/Session.php b/src/Session.php index <HASH>..<HASH> 100644 --- a/src/Session.php +++ b/src/Session.php @@ -57,7 +57,7 @@ class Session extends Token { Toolkit::trace("SessionId from cookie: $sessionId"); } - $session = parent::getInstance($args, $conf, $confHash); + ...
Session should pass sessionId not args to parent
diff --git a/salt/utils/yamldumper.py b/salt/utils/yamldumper.py index <HASH>..<HASH> 100644 --- a/salt/utils/yamldumper.py +++ b/salt/utils/yamldumper.py @@ -9,7 +9,7 @@ from __future__ import absolute_import try: from yaml import CDumper as Dumper except ImportError: - from yaml import CDumper as Dumper + ...
Update yamldumper.py fixed wrong import
diff --git a/pysc2/env/sc2_env.py b/pysc2/env/sc2_env.py index <HASH>..<HASH> 100644 --- a/pysc2/env/sc2_env.py +++ b/pysc2/env/sc2_env.py @@ -537,8 +537,10 @@ class SC2Env(environment.Base): return replay_path def close(self): - self._metrics.close() logging.info("Environment Close") + if hasattr(...
Shut down cleanly even if the environment didn't finish the constructor. PiperOrigin-RevId: <I>
diff --git a/bigtext.js b/bigtext.js index <HASH>..<HASH> 100644 --- a/bigtext.js +++ b/bigtext.js @@ -51,6 +51,8 @@ if($.fn.smartresize) { // https://github.com/lrbabe/jquery-smartresize/ eventName = 'smartresize.' + eventName; + } else if(_.debounce) { + resizeF...
Add underscore resize debouncer
diff --git a/Config/Database.cfg.php b/Config/Database.cfg.php index <HASH>..<HASH> 100644 --- a/Config/Database.cfg.php +++ b/Config/Database.cfg.php @@ -14,7 +14,7 @@ class Database_Config_Framework { : "Gt_" . APPNAME; $this->_user = isset($this->_user) ? $this->_user - : "Gt_" . APPNAME . "_User"; + ...
Changed database username convention to drop the _User. Increased APPNAME to <I> char limit.
diff --git a/lib/valid_email2/address.rb b/lib/valid_email2/address.rb index <HASH>..<HASH> 100644 --- a/lib/valid_email2/address.rb +++ b/lib/valid_email2/address.rb @@ -21,10 +21,8 @@ module ValidEmail2 return false if @parse_error if address.domain && address.address == @raw_address - tree = a...
Count the dots in the domain without using the tree method Instead of using the private method #tree on the address to count the dots in the domain we simply match if there are any at all. This allows us to be compatible with the latest mail gem version which has deprecated the #tree.
diff --git a/agent/utils/mongo_fix/mongo_fix.go b/agent/utils/mongo_fix/mongo_fix.go index <HASH>..<HASH> 100644 --- a/agent/utils/mongo_fix/mongo_fix.go +++ b/agent/utils/mongo_fix/mongo_fix.go @@ -18,7 +18,6 @@ package mongo_fix import ( "net/url" - "github.com/pkg/errors" "go.mongodb.org/mongo-driver/mongo/op...
fallback to original DSN if it is non-URI (#<I>)
diff --git a/lib/agent.js b/lib/agent.js index <HASH>..<HASH> 100644 --- a/lib/agent.js +++ b/lib/agent.js @@ -61,6 +61,8 @@ module.exports = { request: dispatchFromAgent('request'), stream: dispatchFromAgent('stream'), pipeline: dispatchFromAgent('pipeline'), + connect: dispatchFromAgent('connect'), + upgra...
feat: add connect and upgrade to global methods
diff --git a/Services/Twilio/Rest/IncomingPhoneNumber.php b/Services/Twilio/Rest/IncomingPhoneNumber.php index <HASH>..<HASH> 100644 --- a/Services/Twilio/Rest/IncomingPhoneNumber.php +++ b/Services/Twilio/Rest/IncomingPhoneNumber.php @@ -81,6 +81,10 @@ * * The HTTP method Twilio will use when requesting the a...
Add beta property to IPN docs
diff --git a/code/model/EventRegistration.php b/code/model/EventRegistration.php index <HASH>..<HASH> 100644 --- a/code/model/EventRegistration.php +++ b/code/model/EventRegistration.php @@ -245,7 +245,7 @@ class EventRegistration extends DataObject { } public function isSubmitted() { - return ($this->Status != ...
FIX: isSubmitted check on EventRegistration should also check if the Status value is set
diff --git a/filesystems/common.py b/filesystems/common.py index <HASH>..<HASH> 100644 --- a/filesystems/common.py +++ b/filesystems/common.py @@ -54,7 +54,7 @@ def create( _state=attr.ib(default=attr.Factory(state), repr=False), create=create_file, - open=lambda fs, p...
Default open to mode "r" not "rb"
diff --git a/lib/options.js b/lib/options.js index <HASH>..<HASH> 100644 --- a/lib/options.js +++ b/lib/options.js @@ -33,21 +33,14 @@ module.exports.parse = function (argv) { // Deprecated in 0.0.10 'flow-parser' ], - string: ['print-width', 'tab-width', 'parser', 'trailing-comma'], + string: ...
Relax option parsing a bit Prettier does some extra validation and conversion, but let's just be lazy, skip the validation, and let minimist do the conversion.
diff --git a/ModelDescriber/Annotations/SymfonyConstraintAnnotationReader.php b/ModelDescriber/Annotations/SymfonyConstraintAnnotationReader.php index <HASH>..<HASH> 100644 --- a/ModelDescriber/Annotations/SymfonyConstraintAnnotationReader.php +++ b/ModelDescriber/Annotations/SymfonyConstraintAnnotationReader.php @@ -8...
feature: Add new validation from constraints. - Add minimum for GreaterThanOrEqual - add minimum and exclusiveMinimum LessThanOrEqual annotation
diff --git a/pkg/cmd/server/kubernetes/node_config.go b/pkg/cmd/server/kubernetes/node_config.go index <HASH>..<HASH> 100644 --- a/pkg/cmd/server/kubernetes/node_config.go +++ b/pkg/cmd/server/kubernetes/node_config.go @@ -176,12 +176,17 @@ func BuildKubernetesNodeConfig(options configapi.NodeConfig) (*NodeConfig, erro...
Fix dind compatibility with centos/rhel Kubelet's cgroup manipulation of the dind daemon is not compatible with centos/rhel. This change disables the offending cgroup manipulation when the kubelet is running with dind.
diff --git a/lib/db/services.php b/lib/db/services.php index <HASH>..<HASH> 100644 --- a/lib/db/services.php +++ b/lib/db/services.php @@ -126,7 +126,7 @@ $functions = array( 'classpath' => 'user/externallib.php', 'description' => 'Get users by id.', 'type' => 'read', - 'capab...
MDL-<I> fix capability name typo in the description of the web service function moodle_user_get_users_by_id
diff --git a/tests/isArguments.unit.test.js b/tests/isArguments.unit.test.js index <HASH>..<HASH> 100644 --- a/tests/isArguments.unit.test.js +++ b/tests/isArguments.unit.test.js @@ -30,16 +30,11 @@ test(txt + 'return false if given anything else', function (t) { t.equal( isArguments( new Date() ), false ); t.equ...
Modified unit test for backwards.isArguments
diff --git a/src/main/java/graphql/relay/Relay.java b/src/main/java/graphql/relay/Relay.java index <HASH>..<HASH> 100644 --- a/src/main/java/graphql/relay/Relay.java +++ b/src/main/java/graphql/relay/Relay.java @@ -212,6 +212,9 @@ public class Relay { public ResolvedGlobalId fromGlobalId(String globalId) { ...
illegal global id should yield illegal argument exception
diff --git a/Tone/core/Emitter.js b/Tone/core/Emitter.js index <HASH>..<HASH> 100644 --- a/Tone/core/Emitter.js +++ b/Tone/core/Emitter.js @@ -114,7 +114,7 @@ define(["Tone/core/Tone"], function (Tone) { * @returns {Tone.Emitter} */ Tone.Emitter.mixin = function(object){ - var functions = ["on", "off", "emit"...
adding 'once' to mixin methods
diff --git a/src/helpers/reverse-publication-test.js b/src/helpers/reverse-publication-test.js index <HASH>..<HASH> 100644 --- a/src/helpers/reverse-publication-test.js +++ b/src/helpers/reverse-publication-test.js @@ -12,14 +12,6 @@ describe('reversePublication', function () { expect(actual).to.equal('/content/1....
Remove redundant test (#<I>)
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -122,8 +122,11 @@ function sanitizeHtml(html, options) { result += ' ' + a; if (value.length) { // Values are ALREADY escaped, calling escapeHtml here - // results in doubl...
Strip any unescaped double-quotes from output
diff --git a/src/main/java/org/jboss/pressgang/ccms/filter/builder/TopicFilterQueryBuilder.java b/src/main/java/org/jboss/pressgang/ccms/filter/builder/TopicFilterQueryBuilder.java index <HASH>..<HASH> 100644 --- a/src/main/java/org/jboss/pressgang/ccms/filter/builder/TopicFilterQueryBuilder.java +++ b/src/main/java/or...
Added the ability to search for an equal min hash
diff --git a/test/test.py b/test/test.py index <HASH>..<HASH> 100755 --- a/test/test.py +++ b/test/test.py @@ -175,6 +175,7 @@ class TestTropoPython(unittest.TestCase): url = "/receive_recording.py" choices_obj = Choices("", terminator="#").json tropo.record(say="Tell us about yourself", url=...
Add unittest for improvement/TROPO-<I>-record
diff --git a/fundamentals/mysql/convert_dictionary_to_mysql_table.py b/fundamentals/mysql/convert_dictionary_to_mysql_table.py index <HASH>..<HASH> 100644 --- a/fundamentals/mysql/convert_dictionary_to_mysql_table.py +++ b/fundamentals/mysql/convert_dictionary_to_mysql_table.py @@ -461,7 +461,7 @@ def convert_dictionar...
testing moving updates to insert into list of dictionaries into database
diff --git a/will/settings.py b/will/settings.py index <HASH>..<HASH> 100644 --- a/will/settings.py +++ b/will/settings.py @@ -28,6 +28,10 @@ def import_settings(quiet=True): if "PLUGINS" in settings: settings["PLUGINS"] = settings["PLUGINS"].split(";") + if 'PLUGIN_BLACKLIST' in settings: + s...
Allow setting of plugin list from WILL_PLUGIN_BLACKLIST environment variable
diff --git a/test/level2/html.js b/test/level2/html.js index <HASH>..<HASH> 100644 --- a/test/level2/html.js +++ b/test/level2/html.js @@ -2637,6 +2637,11 @@ exports.tests = { vcookie = doc.cookie; test.equal(vcookie, "key3=value3; key4=value4", "cookieLink"); + var ret = doc.cookie = null; + test.equ...
Test that doc.cookie = null returns null and has no effect
diff --git a/driver/src/main/org/mongodb/impl/MongoCollectionImpl.java b/driver/src/main/org/mongodb/impl/MongoCollectionImpl.java index <HASH>..<HASH> 100644 --- a/driver/src/main/org/mongodb/impl/MongoCollectionImpl.java +++ b/driver/src/main/org/mongodb/impl/MongoCollectionImpl.java @@ -116,10 +116,10 @@ class Mongo...
Propagating writeConcern in save
diff --git a/lib/quickbooks/service/base_service.rb b/lib/quickbooks/service/base_service.rb index <HASH>..<HASH> 100644 --- a/lib/quickbooks/service/base_service.rb +++ b/lib/quickbooks/service/base_service.rb @@ -242,12 +242,23 @@ module Quickbooks unless headers.has_key?('Content-Type') headers.m...
be smarter about calling the correct HTTP verb
diff --git a/lib/active_admin/view_helpers/filter_form_helper.rb b/lib/active_admin/view_helpers/filter_form_helper.rb index <HASH>..<HASH> 100644 --- a/lib/active_admin/view_helpers/filter_form_helper.rb +++ b/lib/active_admin/view_helpers/filter_form_helper.rb @@ -155,7 +155,7 @@ module ActiveAdmin end ...
Fix for specs. Filter forms shouldn't display polymorphic belongs_to
diff --git a/lib/collection/url.js b/lib/collection/url.js index <HASH>..<HASH> 100644 --- a/lib/collection/url.js +++ b/lib/collection/url.js @@ -91,8 +91,7 @@ _.extend(Url.prototype, /** @lends Url.prototype */ { /** * @type {PropertyList<QueryParam>} */ - query: qu...
Fixed dead code and throwback logic in URL constructor and query param getter.
diff --git a/path.py b/path.py index <HASH>..<HASH> 100644 --- a/path.py +++ b/path.py @@ -1665,6 +1665,10 @@ class TempDir(Path): self.rmtree() +# For backwards compatibility. +tempdir = TempDir + + def _multi_permission_mask(mode): """ Support multiple, comma-separated Unix chmod symbolic ...
Add tempdir name for backwards compatibility. tempdir is just an alias to TempDir.
diff --git a/lib/db.js b/lib/db.js index <HASH>..<HASH> 100644 --- a/lib/db.js +++ b/lib/db.js @@ -44,7 +44,7 @@ exports.db_setup = function(app, db, next) { if (typeof values != 'function') _sql = app.db.format(sql, values); console.log('SQL query:', _sql); - return _query(sql, values, callback)...
small fix to mysql interface
diff --git a/src/main/java/com/github/alexcojocaru/mojo/elasticsearch/ElasticSearchNode.java b/src/main/java/com/github/alexcojocaru/mojo/elasticsearch/ElasticSearchNode.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/github/alexcojocaru/mojo/elasticsearch/ElasticSearchNode.java +++ b/src/main/java/com/github/...
enable HTTP CORS on the local node, to allow web plugins to talk to it see <URL>
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -35,7 +35,7 @@ setup( 'test': [ 'nose', 'flake8', - 'openfisca-country-template == 1.2.2', + 'openfisca-country-template >= 1.2.3rc0, <= 1.2.3', 'openfisca-...
Update requirement for openfisca-country-template
diff --git a/lib/raven/processor/sanitizedata.rb b/lib/raven/processor/sanitizedata.rb index <HASH>..<HASH> 100644 --- a/lib/raven/processor/sanitizedata.rb +++ b/lib/raven/processor/sanitizedata.rb @@ -37,7 +37,7 @@ module Raven end def fields_re - @fields_re ||= /(#{(DEFAULT_FIELDS + @sanitize_fields...
union instead of concatenation, because duplicate fields
diff --git a/Lib/fontbakery/specifications/googlefonts.py b/Lib/fontbakery/specifications/googlefonts.py index <HASH>..<HASH> 100644 --- a/Lib/fontbakery/specifications/googlefonts.py +++ b/Lib/fontbakery/specifications/googlefonts.py @@ -2,8 +2,7 @@ from __future__ import absolute_import, print_function, unicode_lite...
remove a few unused imports (issue #<I>)
diff --git a/src/createReduxForm.js b/src/createReduxForm.js index <HASH>..<HASH> 100755 --- a/src/createReduxForm.js +++ b/src/createReduxForm.js @@ -526,6 +526,18 @@ const createReduxForm = (structure: Structure<*, *>) => { ) } + componentDidMount() { + if (!isHotReloading()) { +...
initialize in componentDidMount as well (#<I>) React <I> ensures a certain order of lifcecycles when replacing a component which causes redux-form to destroy the form, breaking it. This change, when used with `enableReinitialize`, causes the form to reinitialize correctly, preserving the form.
diff --git a/api/client.go b/api/client.go index <HASH>..<HASH> 100644 --- a/api/client.go +++ b/api/client.go @@ -108,6 +108,7 @@ func (c *Client) isOkStatus(code int) bool { 411: false, 413: false, 415: false, + 423: false, 500: false, 503: false, } @@ -257,7 +258,7 @@ func (c *retryableHTTPClient) ...
Handling <I>-locked response
diff --git a/hearthstone/entities.py b/hearthstone/entities.py index <HASH>..<HASH> 100644 --- a/hearthstone/entities.py +++ b/hearthstone/entities.py @@ -75,6 +75,8 @@ class Game(Entity): self.initial_entities.append(entity) def find_entity_by_id(self, id): + # int() for LazyPlayer mainly... + id = int(id) ...
entities: Always int-ify the argument to Game.find_entity_by_id()
diff --git a/test/src/net/lshift/javax/xml/DocumentHelperTest.java b/test/src/net/lshift/javax/xml/DocumentHelperTest.java index <HASH>..<HASH> 100644 --- a/test/src/net/lshift/javax/xml/DocumentHelperTest.java +++ b/test/src/net/lshift/javax/xml/DocumentHelperTest.java @@ -13,7 +13,7 @@ public class DocumentHelperTest...
bug <I>: test now works. However, it's not entirely reliable - correct code could fail this test.
diff --git a/app/jobs/cangaroo/job.rb b/app/jobs/cangaroo/job.rb index <HASH>..<HASH> 100644 --- a/app/jobs/cangaroo/job.rb +++ b/app/jobs/cangaroo/job.rb @@ -7,6 +7,7 @@ module Cangaroo class_configuration :connection class_configuration :path, '' class_configuration :parameters, {} + class_configura...
Adding option to stop reprocessing of jobs
diff --git a/packages/vx-shape/src/util/stackOrder.js b/packages/vx-shape/src/util/stackOrder.js index <HASH>..<HASH> 100644 --- a/packages/vx-shape/src/util/stackOrder.js +++ b/packages/vx-shape/src/util/stackOrder.js @@ -8,7 +8,7 @@ import { export const STACK_ORDERS = { ascending: stackOrderAscending, - descr...
Typo in stack order enum descrending => descending
diff --git a/src/Illuminate/Foundation/Channels/SmsChannel.php b/src/Illuminate/Foundation/Channels/SmsChannel.php index <HASH>..<HASH> 100644 --- a/src/Illuminate/Foundation/Channels/SmsChannel.php +++ b/src/Illuminate/Foundation/Channels/SmsChannel.php @@ -18,7 +18,7 @@ class SmsChannel public function send($not...
change sms configs.
diff --git a/etcdctl/ctlv3/ctl.go b/etcdctl/ctlv3/ctl.go index <HASH>..<HASH> 100644 --- a/etcdctl/ctlv3/ctl.go +++ b/etcdctl/ctlv3/ctl.go @@ -43,7 +43,7 @@ var ( ) func init() { - rootCmd.PersistentFlags().StringSliceVar(&globalFlags.Endpoints, "endpoints", []string{"127.0.0.1:2379", "127.0.0.1:22379", "127.0.0.1:...
etcdctl: only takes <I>:<I> as default endpoint
diff --git a/plugins/CoreVisualizations/Visualizations/Cloud.php b/plugins/CoreVisualizations/Visualizations/Cloud.php index <HASH>..<HASH> 100644 --- a/plugins/CoreVisualizations/Visualizations/Cloud.php +++ b/plugins/CoreVisualizations/Visualizations/Cloud.php @@ -49,7 +49,7 @@ class Cloud extends Visualization ...
cloud works only with DataTable not with a map
diff --git a/aeron-archive/src/test/java/io/aeron/archive/ArchiveTest.java b/aeron-archive/src/test/java/io/aeron/archive/ArchiveTest.java index <HASH>..<HASH> 100644 --- a/aeron-archive/src/test/java/io/aeron/archive/ArchiveTest.java +++ b/aeron-archive/src/test/java/io/aeron/archive/ArchiveTest.java @@ -73,25 +73,26 ...
[Java] Test should shutdown client before driver to avoid stale data.
diff --git a/examples/server/server.py b/examples/server/server.py index <HASH>..<HASH> 100644 --- a/examples/server/server.py +++ b/examples/server/server.py @@ -11,14 +11,13 @@ from aiortc import RTCPeerConnection, RTCSessionDescription from aiortc.mediastreams import (AudioFrame, AudioStreamTrack, VideoFrame, ...
[examples] reduce video frame rate
diff --git a/lib/offsite_payments/integrations/quickpay.rb b/lib/offsite_payments/integrations/quickpay.rb index <HASH>..<HASH> 100644 --- a/lib/offsite_payments/integrations/quickpay.rb +++ b/lib/offsite_payments/integrations/quickpay.rb @@ -5,7 +5,7 @@ module OffsitePayments #:nodoc: self.service_url = 'https:...
Must check params with MD5secret from options.
diff --git a/cake/libs/view/media.php b/cake/libs/view/media.php index <HASH>..<HASH> 100644 --- a/cake/libs/view/media.php +++ b/cake/libs/view/media.php @@ -208,7 +208,11 @@ class MediaView extends View { $this->_output(); $this->_clearBuffer(); - while (!feof($handle) && $this->_isActive()) { + while (...
If connection is aborted, now MediaView returns false after stopping the transfer
diff --git a/src/HttpRouter.php b/src/HttpRouter.php index <HASH>..<HASH> 100644 --- a/src/HttpRouter.php +++ b/src/HttpRouter.php @@ -73,4 +73,4 @@ class HttpRouter implements HttpRouterInterface array("X-Reason" => "no module for path"), $request->closeConnection()); } } -} \ No newline...
Added \n to the last line of every file (to conform with POSIX: <URL>)
diff --git a/internal/core/command/device.go b/internal/core/command/device.go index <HASH>..<HASH> 100644 --- a/internal/core/command/device.go +++ b/internal/core/command/device.go @@ -45,7 +45,7 @@ func commandByDeviceID(did string, cid string, b string, p bool) (string, int) { } } - if p && (d.AdminState == ...
#<I> Return HTTP <I> LOCKED when issuing a GET command to a locked device
diff --git a/src/Process.php b/src/Process.php index <HASH>..<HASH> 100644 --- a/src/Process.php +++ b/src/Process.php @@ -45,8 +45,7 @@ class Process extends EventEmitter * @param string $cwd Current working directory or null to inherit * @param array $env Environment variables or null to inherit ...
Throw LogicException when proc_open() is not installed
diff --git a/lib/dalli/client.rb b/lib/dalli/client.rb index <HASH>..<HASH> 100644 --- a/lib/dalli/client.rb +++ b/lib/dalli/client.rb @@ -108,7 +108,6 @@ module Dalli # - false if the value was changed by someone else. # - true if the value was successfully updated. def cas(key, ttl=nil, options=nil) - ...
Fix a couple of minor errors in my last PR
diff --git a/escpos/impl/epson.py b/escpos/impl/epson.py index <HASH>..<HASH> 100644 --- a/escpos/impl/epson.py +++ b/escpos/impl/epson.py @@ -185,7 +185,7 @@ class GenericESCPOS(object): for char in bytearray(unicode_text, 'cp1251'): printer.device.write(chr(char)) """ - i...
Impl: Epson: Fixed bad logic when testing code page validity.
diff --git a/AegeanTools/BANE.py b/AegeanTools/BANE.py index <HASH>..<HASH> 100755 --- a/AegeanTools/BANE.py +++ b/AegeanTools/BANE.py @@ -370,14 +370,14 @@ def filter_image(im_name, out_base, step_size=None, box_size=None, twopass=False Parameters ---------- - im_name : str or HDUList - Image to ...
update docstring to be correct resolves #<I>
diff --git a/scriptblock.js b/scriptblock.js index <HASH>..<HASH> 100644 --- a/scriptblock.js +++ b/scriptblock.js @@ -33,6 +33,22 @@ ScriptblockPlugin.prototype.disable = function() { }; ScriptblockPlugin.prototype.interact = function(target) { - console.log(target); - // TODO: prompt for script, set at x,y,z + ...
Set script in blockdata when interact with top, run when interact on other sides
diff --git a/source/application/models/oxorder.php b/source/application/models/oxorder.php index <HASH>..<HASH> 100644 --- a/source/application/models/oxorder.php +++ b/source/application/models/oxorder.php @@ -350,13 +350,13 @@ class oxOrder extends oxBase /** * Order article list setter * - * @pa...
Changed comment and variable name in setOrderArticleList() (cherry picked from commit <I>b8ff) (cherry picked from commit <I>a<I>c6)
diff --git a/pydoop/hdfs/core/bridged/hadoop.py b/pydoop/hdfs/core/bridged/hadoop.py index <HASH>..<HASH> 100644 --- a/pydoop/hdfs/core/bridged/hadoop.py +++ b/pydoop/hdfs/core/bridged/hadoop.py @@ -246,7 +246,7 @@ class CoreHdfsFs(CoreFsApi): else: boolean_overwrite = True ...
defaultBlockSize in hadoop.open_file(..) is now obtained using hadoop.get_default_block_size() method
diff --git a/backbone-firebase.js b/backbone-firebase.js index <HASH>..<HASH> 100644 --- a/backbone-firebase.js +++ b/backbone-firebase.js @@ -210,6 +210,9 @@ Backbone.Firebase.Collection = Backbone.Collection.extend({ add: function(models, options) { var parsed = this._parseModels(models); + options = opt...
check for the existence of options and options.success
diff --git a/src/edu/jhu/hltcoe/model/dmv/DmvDepTreeGenerator.java b/src/edu/jhu/hltcoe/model/dmv/DmvDepTreeGenerator.java index <HASH>..<HASH> 100644 --- a/src/edu/jhu/hltcoe/model/dmv/DmvDepTreeGenerator.java +++ b/src/edu/jhu/hltcoe/model/dmv/DmvDepTreeGenerator.java @@ -34,7 +34,9 @@ public class DmvDepTreeGenerato...
Bug fix: generating to left of wall git-svn-id: svn+ssh://external.hltcoe.jhu.edu/home/hltcoe/mgormley/public/repos/dep_parse_filtered/trunk@<I> <I>f-cb4b-<I>-8b<I>-c<I>bcb<I>
diff --git a/src/RuleCollection.php b/src/RuleCollection.php index <HASH>..<HASH> 100644 --- a/src/RuleCollection.php +++ b/src/RuleCollection.php @@ -118,21 +118,26 @@ class RuleCollection public function __construct(RuleLocator $rule_locator) { $this->rule_locator = $rule_locator; + $this->i...
add init() method for self-initialization if needed
diff --git a/pyroma/projectdata.py b/pyroma/projectdata.py index <HASH>..<HASH> 100644 --- a/pyroma/projectdata.py +++ b/pyroma/projectdata.py @@ -2,6 +2,7 @@ import os import re import sys +import logging from collections import defaultdict IMPORTS = re.compile('^import (.*)$|^from (.*?) import .*$', re.MULTILI...
Print the exception when it can't find setup.py.
diff --git a/lib/premailer-rails3/hook.rb b/lib/premailer-rails3/hook.rb index <HASH>..<HASH> 100644 --- a/lib/premailer-rails3/hook.rb +++ b/lib/premailer-rails3/hook.rb @@ -6,6 +6,7 @@ module PremailerRails html_part = message.body ) premailer = Premailer.new(html_part.body.to_s) + pla...
Do not override already rendered plain-text mail
diff --git a/cake/tests/cases/libs/model/model_delete.test.php b/cake/tests/cases/libs/model/model_delete.test.php index <HASH>..<HASH> 100644 --- a/cake/tests/cases/libs/model/model_delete.test.php +++ b/cake/tests/cases/libs/model/model_delete.test.php @@ -44,7 +44,7 @@ class ModelDeleteTest extends BaseModelTest { ...
Fixing failing test caused by boolean type changes.
diff --git a/add-commands.js b/add-commands.js index <HASH>..<HASH> 100644 --- a/add-commands.js +++ b/add-commands.js @@ -1,4 +1,4 @@ // this file is here so it's easy to register the commands -// `import 'cypress-testing-library/add-commands'` +// `import '@testing-library/cypress/add-commands'` // eslint-disable-n...
chore: update comment in add-commands (#<I>)
diff --git a/test/transports.browser.js b/test/transports.browser.js index <HASH>..<HASH> 100644 --- a/test/transports.browser.js +++ b/test/transports.browser.js @@ -168,7 +168,9 @@ describe('transports', () => { }) }) - it('many writes', (done) => { + it('many writes', function (done) { + ...
test: increase timeout for many writes
diff --git a/app/assets/javascripts/meurio_ui.js b/app/assets/javascripts/meurio_ui.js index <HASH>..<HASH> 100644 --- a/app/assets/javascripts/meurio_ui.js +++ b/app/assets/javascripts/meurio_ui.js @@ -3,5 +3,10 @@ $(function(){ $('.meurio_header .meurio_apps').hover(function(e){ $('.other_apps').toggle(); e.stopPr...
[#<I>] add local storage support for MC warning
diff --git a/src/Message/Helper/GenericHelper.php b/src/Message/Helper/GenericHelper.php index <HASH>..<HASH> 100644 --- a/src/Message/Helper/GenericHelper.php +++ b/src/Message/Helper/GenericHelper.php @@ -64,7 +64,7 @@ class GenericHelper extends AbstractHelper */ public function removeContentHeadersAndCon...
Use self:: instead of static:: for private member
diff --git a/scss/tests/test_files.py b/scss/tests/test_files.py index <HASH>..<HASH> 100644 --- a/scss/tests/test_files.py +++ b/scss/tests/test_files.py @@ -42,7 +42,7 @@ def test_pair_programmatic(scss_file_pair): scss.config.STATIC_ROOT = os.path.join(directory, 'static') try: - compiler = scss.S...
Include the test directory in search path (to easily test bootstrap and others)
diff --git a/pandas/tests/test_timeseries.py b/pandas/tests/test_timeseries.py index <HASH>..<HASH> 100644 --- a/pandas/tests/test_timeseries.py +++ b/pandas/tests/test_timeseries.py @@ -619,6 +619,17 @@ class TestLegacySupport(unittest.TestCase): for val in rng: self.assert_(val.time() == the_tim...
TST: failing unit test for #<I>
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100755 --- a/setup.py +++ b/setup.py @@ -3,7 +3,7 @@ from distutils.core import setup setup( name='hapipy', - version='2.1.5', + version='2.1.6', description="A python wrapper around HubSpot's APIs", long_description = open('README.md').read(...
Adding pycurl to setup.py.
diff --git a/tests/phpunit/unit/Controller/Backend/RecordsTest.php b/tests/phpunit/unit/Controller/Backend/RecordsTest.php index <HASH>..<HASH> 100644 --- a/tests/phpunit/unit/Controller/Backend/RecordsTest.php +++ b/tests/phpunit/unit/Controller/Backend/RecordsTest.php @@ -198,9 +198,10 @@ class RecordsTest extends Co...
[Tests] Handle change in array layout
diff --git a/quark/compiler.py b/quark/compiler.py index <HASH>..<HASH> 100644 --- a/quark/compiler.py +++ b/quark/compiler.py @@ -723,7 +723,7 @@ class Reflector: return fields def meths(self, cls, cid, use_bindings): - if cls.package is None or cls.package.name.text in ("reflect", "concurrent",...
Generate reflection metadata for all builtin.q except reflection
diff --git a/redis/redis_test.go b/redis/redis_test.go index <HASH>..<HASH> 100644 --- a/redis/redis_test.go +++ b/redis/redis_test.go @@ -35,7 +35,8 @@ func TestAdd(t *testing.T) { func TestThreadSafeAdd(t *testing.T) { // Redis Add is not thread safe. If you run this, the test should fail because it never receiv...
redis: explain why not thread safe
diff --git a/scraper/gen_code_gov_json.py b/scraper/gen_code_gov_json.py index <HASH>..<HASH> 100755 --- a/scraper/gen_code_gov_json.py +++ b/scraper/gen_code_gov_json.py @@ -78,6 +78,8 @@ if __name__ == '__main__': parser.add_argument('--github-orgs', type=str, nargs='+', help='GitHub Organizations') parser....
Added flag for processing projects into a CSV file
diff --git a/pulsar/managers/util/drmaa/__init__.py b/pulsar/managers/util/drmaa/__init__.py index <HASH>..<HASH> 100644 --- a/pulsar/managers/util/drmaa/__init__.py +++ b/pulsar/managers/util/drmaa/__init__.py @@ -1,10 +1,14 @@ try: from drmaa import Session, JobControlAction +except OSError as e: + LOAD_ERRO...
Improve error message when drmaa cannot be loaded.
diff --git a/ospd/ospd.py b/ospd/ospd.py index <HASH>..<HASH> 100644 --- a/ospd/ospd.py +++ b/ospd/ospd.py @@ -1187,7 +1187,7 @@ class OSPDaemon: logger.info("Received Ctrl-C shutting-down ...") def check_pending_scans(self): - for scan_id in list(self.scan_collection.ids_iterator()): + ...
Don't cast the iterator to list
diff --git a/docs/conf.py b/docs/conf.py index <HASH>..<HASH> 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -9,8 +9,8 @@ exclude_patterns = ['_build'] project = u'Flask-Nav' copyright = u'2015, Marc Brinkmann' author = u'Marc Brinkmann' -version = '0.4' -release = '0.4.dev1' +version = '0.5' +release = '0.5.dev1' ...
Start developing version <I>.dev1 (after release of <I>)
diff --git a/DBUtils/Tests/TestPooledDB.py b/DBUtils/Tests/TestPooledDB.py index <HASH>..<HASH> 100644 --- a/DBUtils/Tests/TestPooledDB.py +++ b/DBUtils/Tests/TestPooledDB.py @@ -19,8 +19,8 @@ import unittest sys.path.insert(1, '../..') # The TestSteadyDB module serves as a mock object for the DB-API 2 module: from ...
Allow running test with Python <I> We will require modern Python in version <I> only.
diff --git a/.travis.yml b/.travis.yml index <HASH>..<HASH> 100644 --- a/.travis.yml +++ b/.travis.yml @@ -8,7 +8,6 @@ language: python: - "2.7" - "3.4" - - "3.5" - "3.6" before_install: diff --git a/tests/test_library.py b/tests/test_library.py index <HASH>..<HASH> 100644 --- a/tests/test_library.py +++ ...
Tweak two tests; Remove Python <I> testing since we cover both before and after already
diff --git a/test/basic_tests.go b/test/basic_tests.go index <HASH>..<HASH> 100644 --- a/test/basic_tests.go +++ b/test/basic_tests.go @@ -126,13 +126,18 @@ func SubtestNotFounds(t *testing.T, ds dstore.Datastore) { switch err { case dstore.ErrNotFound: case nil: - t.Fatal("expected error getting size after dele...
Ensure that deletion of a non-existent key does not produce an error.
diff --git a/lib/engineyard/model/instance.rb b/lib/engineyard/model/instance.rb index <HASH>..<HASH> 100644 --- a/lib/engineyard/model/instance.rb +++ b/lib/engineyard/model/instance.rb @@ -119,7 +119,7 @@ module EY framework_arg = ['--framework-env', environment.framework_env] - verbose_arg = verb...
Pass --verbose to eysd whenever DEBUG is set. [#<I> state:merged]
diff --git a/impala/util.py b/impala/util.py index <HASH>..<HASH> 100644 --- a/impala/util.py +++ b/impala/util.py @@ -17,14 +17,11 @@ from __future__ import absolute_import import string import random -try: - import pandas as pd - - def as_pandas(cursor): - names = [metadata[0] for metadata in cursor....
[IMPYLA-<I>] Move pandas import into as_pandas In lieu of setting up logging, this should eliminate the annoying message about not being able to import pandas. Fixes #<I>.
diff --git a/visa.py b/visa.py index <HASH>..<HASH> 100644 --- a/visa.py +++ b/visa.py @@ -13,7 +13,7 @@ from __future__ import division, unicode_literals, print_function, absolute_import -from pyvisa import logger, __version__, log_to_screen +from pyvisa import logger, __version__, log_to_screen, constants from ...
Added constants to visa.py
diff --git a/setuptools/tests/contexts.py b/setuptools/tests/contexts.py index <HASH>..<HASH> 100644 --- a/setuptools/tests/contexts.py +++ b/setuptools/tests/contexts.py @@ -83,3 +83,11 @@ def save_user_site_setting(): yield saved finally: site.ENABLE_USER_SITE = saved + + +@contextlib.contextma...
Suppress exceptions in a context for clarity, brevity, and reuse.
diff --git a/configStore.js b/configStore.js index <HASH>..<HASH> 100644 --- a/configStore.js +++ b/configStore.js @@ -113,6 +113,7 @@ } function parse (config) { + config = config || {}; var parsed = {}; Object.keys(config).forEach(function (key) { @@ -152,4 +153,4 @@ } } -})(); \ No n...
Make sure Object.keys arg is an object