diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/jobs/import_job.rb b/app/jobs/import_job.rb index abc1234..def5678 100644 --- a/app/jobs/import_job.rb +++ b/app/jobs/import_job.rb @@ -7,4 +7,9 @@ def max_attempts 1 end + + def max_run_time + 6.hours + end + end
Increase max run time to 6 hours + https://github.com/studentinsights/studentinsights/issues/1023#issuecomment-330038945
diff --git a/app/models/spid/idp.rb b/app/models/spid/idp.rb index abc1234..def5678 100644 --- a/app/models/spid/idp.rb +++ b/app/models/spid/idp.rb @@ -12,7 +12,8 @@ 'poste_test' => 'http://spidposte.test.poste.it/jod-fs/metadata/idp.xml', 'spiditalia' => 'https://spid.register.it/login/metadata', ...
Add local testenv2 to available providers
diff --git a/app/models/question.rb b/app/models/question.rb index abc1234..def5678 100644 --- a/app/models/question.rb +++ b/app/models/question.rb @@ -2,4 +2,5 @@ belongs_to :user has_many :responses + validates :image_path, presence: true end
Add Validation to Question for Specs Testing
diff --git a/lib/flipper/middleware/setup_env.rb b/lib/flipper/middleware/setup_env.rb index abc1234..def5678 100644 --- a/lib/flipper/middleware/setup_env.rb +++ b/lib/flipper/middleware/setup_env.rb @@ -1,7 +1,7 @@ module Flipper module Middleware class SetupEnv - # Public: Initializes an instance of the...
Fix typo in setup env docs
diff --git a/lib/json_api/response/middleware.rb b/lib/json_api/response/middleware.rb index abc1234..def5678 100644 --- a/lib/json_api/response/middleware.rb +++ b/lib/json_api/response/middleware.rb @@ -2,7 +2,9 @@ module Response class Middleware < Faraday::Middleware - def initialize(app, directory:) ...
Use Ruby's built-in default param support This is terser.
diff --git a/spec/unit/veritas/adapter/arango/visitor/wrappable/limit/root_spec.rb b/spec/unit/veritas/adapter/arango/visitor/wrappable/limit/root_spec.rb index abc1234..def5678 100644 --- a/spec/unit/veritas/adapter/arango/visitor/wrappable/limit/root_spec.rb +++ b/spec/unit/veritas/adapter/arango/visitor/wrappable/li...
Add specs for limit operation
diff --git a/lib/oauth/request_proxy/rack_request.rb b/lib/oauth/request_proxy/rack_request.rb index abc1234..def5678 100644 --- a/lib/oauth/request_proxy/rack_request.rb +++ b/lib/oauth/request_proxy/rack_request.rb @@ -7,7 +7,7 @@ proxies Rack::Request def method - request.request_method + reques...
Fix for applications using the MethodOverride middleware
diff --git a/lib/boletosimples/resources/bank_billet.rb b/lib/boletosimples/resources/bank_billet.rb index abc1234..def5678 100644 --- a/lib/boletosimples/resources/bank_billet.rb +++ b/lib/boletosimples/resources/bank_billet.rb @@ -2,6 +2,8 @@ module BoletoSimples class BankBillet < BaseModel + custom_put :pay...
Test cutom method from Her
diff --git a/lib/bugherd_client/resources/v1/comment.rb b/lib/bugherd_client/resources/v1/comment.rb index abc1234..def5678 100644 --- a/lib/bugherd_client/resources/v1/comment.rb +++ b/lib/bugherd_client/resources/v1/comment.rb @@ -13,6 +13,14 @@ end # + # Get a single comment of a Task + ...
Add Comment.find for v1 of api
diff --git a/lib/tasks/load_additional_record_data.rake b/lib/tasks/load_additional_record_data.rake index abc1234..def5678 100644 --- a/lib/tasks/load_additional_record_data.rake +++ b/lib/tasks/load_additional_record_data.rake @@ -32,7 +32,7 @@ print "\e[32m.\e[0m" begin newitem.save...
Correct error handling for duplicates.
diff --git a/config/initializers/meta_tags.rb b/config/initializers/meta_tags.rb index abc1234..def5678 100644 --- a/config/initializers/meta_tags.rb +++ b/config/initializers/meta_tags.rb @@ -0,0 +1,10 @@+# frozen_string_literal: true + +# Module contains helpers that normalize text meta tag values. +module MetaTags +...
Fix bug with some special chars being escaped in page title
diff --git a/config/initializers/paperclip.rb b/config/initializers/paperclip.rb index abc1234..def5678 100644 --- a/config/initializers/paperclip.rb +++ b/config/initializers/paperclip.rb @@ -7,10 +7,8 @@ fog_credentials: { aws_access_key_id: ENV['AWS_ACCESS_KEY_ID'], aws_secret_access_key: ENV['...
Remove us-west-1 from the S3 bucket
diff --git a/core/objectspace/_id2ref_spec.rb b/core/objectspace/_id2ref_spec.rb index abc1234..def5678 100644 --- a/core/objectspace/_id2ref_spec.rb +++ b/core/objectspace/_id2ref_spec.rb @@ -7,16 +7,43 @@ r.should == s end - it "retrieves an Integer by object_id" do - f = 1 - r = ObjectSpace._id2ref(f...
Cover more cases for ObjectSpace._id2ref
diff --git a/recipes/source.rb b/recipes/source.rb index abc1234..def5678 100644 --- a/recipes/source.rb +++ b/recipes/source.rb @@ -3,3 +3,13 @@ reference node["taskwarrior"]["source"]["git_revision"] action :sync end + +bash "Install taskwarrior" do + user "root" + cwd "#{Chef::Config[:file_cache_path]}/task....
Build taskwarrior with a bash block.
diff --git a/app/coin_calculator.rb b/app/coin_calculator.rb index abc1234..def5678 100644 --- a/app/coin_calculator.rb +++ b/app/coin_calculator.rb @@ -45,7 +45,7 @@ unless @result.empty? erb :result else - flash[:error] = "You must enter an amount" + flash[:warning] = "You must ent...
Change from error to warning for blank amount - probably a warning and not an alert (fatal error)
diff --git a/app/models/document.rb b/app/models/document.rb index abc1234..def5678 100644 --- a/app/models/document.rb +++ b/app/models/document.rb @@ -1,8 +1,7 @@ class Document < ActiveRecord::Base belongs_to :user - has_attached_file :doc_pdf, styles: {:thumb => "100x100#", - :small => "150x150>", - ...
Remove attachment styles and unnecessary content type
diff --git a/app/models/notifier.rb b/app/models/notifier.rb index abc1234..def5678 100644 --- a/app/models/notifier.rb +++ b/app/models/notifier.rb @@ -10,7 +10,7 @@ end def occurence_report(user, occurence, sent_at = Time.now) - subject "[#{occurence.error.project.name}] An error occured" + subject ...
Include the error id in the mail title
diff --git a/kiwi/app/controllers/questions_controller.rb b/kiwi/app/controllers/questions_controller.rb index abc1234..def5678 100644 --- a/kiwi/app/controllers/questions_controller.rb +++ b/kiwi/app/controllers/questions_controller.rb @@ -1,6 +1,4 @@ class QuestionsController < ApplicationController - - # before_fil...
Add Sorting filter in question controller
diff --git a/holiday_japan.gemspec b/holiday_japan.gemspec index abc1234..def5678 100644 --- a/holiday_japan.gemspec +++ b/holiday_japan.gemspec @@ -13,6 +13,8 @@ gem.homepage = "https://masa16.github.io/holiday_japan/" gem.license = "MIT" + gem.metadata['source_code_uri'] = 'https://github.com/masa1...
Add source code URI to gemspec
diff --git a/spec/nyny_spec.rb b/spec/nyny_spec.rb index abc1234..def5678 100644 --- a/spec/nyny_spec.rb +++ b/spec/nyny_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' describe NYNY do - its 'root points to pwd' do + it 'root points to pwd' do NYNY.root.should == Pathname.pwd end @@ -9,7 +9,7 @@ NYNY....
Use it instead of its, fails on Travis for some reason
diff --git a/spec/test_xmpp.rb b/spec/test_xmpp.rb index abc1234..def5678 100644 --- a/spec/test_xmpp.rb +++ b/spec/test_xmpp.rb @@ -4,20 +4,10 @@ include XMPPTestHelper - before(:all) { require '' } - - before :each do - - end - - after :each do - XMPP.stop - end - - - - - + before(:all) { } + + # TO...
Remove nonsense from XMPP tests
diff --git a/lib/kaminari/models/data_mapper_extension.rb b/lib/kaminari/models/data_mapper_extension.rb index abc1234..def5678 100644 --- a/lib/kaminari/models/data_mapper_extension.rb +++ b/lib/kaminari/models/data_mapper_extension.rb @@ -5,8 +5,10 @@ module Paginatable class_eval <<-RUBY, __FILE__, __LINE...
Fix for Model.all.page in DataMapper
diff --git a/lib/parsley_simple_form/simple_form_adapt.rb b/lib/parsley_simple_form/simple_form_adapt.rb index abc1234..def5678 100644 --- a/lib/parsley_simple_form/simple_form_adapt.rb +++ b/lib/parsley_simple_form/simple_form_adapt.rb @@ -0,0 +1,26 @@+module ParsleySimpleForm + class SimpleFormAdapt < SimpleForm::Fo...
Add simple form adapt implementation
diff --git a/spec/javascripts/support/jasmine_helper.rb b/spec/javascripts/support/jasmine_helper.rb index abc1234..def5678 100644 --- a/spec/javascripts/support/jasmine_helper.rb +++ b/spec/javascripts/support/jasmine_helper.rb @@ -14,7 +14,8 @@ # pin chromedriver version to latest compatible found # see https://chro...
Downgrade chrome driver for jasmine Inline with feature test chromedirver version and version 79 may not work for some local test envs.
diff --git a/spec/provider/bluemix_cloudfoundry_spec.rb b/spec/provider/bluemix_cloudfoundry_spec.rb index abc1234..def5678 100644 --- a/spec/provider/bluemix_cloudfoundry_spec.rb +++ b/spec/provider/bluemix_cloudfoundry_spec.rb @@ -0,0 +1,23 @@+require 'spec_helper' +require 'dpl/provider/bluemix_cloudfoundry' + +desc...
Add Bluemix deploy provider test coverage Add spec class to test Bluemix deploy provider Signed-off-by: Adam King <a74e182e49abf6252c9b13e1b94c4c5a47f8da9a@us.ibm.com>
diff --git a/event_store-entity_store.gemspec b/event_store-entity_store.gemspec index abc1234..def5678 100644 --- a/event_store-entity_store.gemspec +++ b/event_store-entity_store.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'event_store-entity_store' - s.version = '0.3...
Package version is increased from 0.3.3 to 0.3.4
diff --git a/auto_time_zone.gemspec b/auto_time_zone.gemspec index abc1234..def5678 100644 --- a/auto_time_zone.gemspec +++ b/auto_time_zone.gemspec @@ -16,5 +16,5 @@ s.files = Dir['{app,lib}/**/*', 'MIT-LICENSE', 'Rakefile', 'README.rdoc'] s.test_files = Dir['test/**/*'] - s.add_dependency 'rails', '~> 4.0' + ...
Update gemspec to work with higher versions of rails
diff --git a/spec/sprinkle/installers/pear_spec.rb b/spec/sprinkle/installers/pear_spec.rb index abc1234..def5678 100644 --- a/spec/sprinkle/installers/pear_spec.rb +++ b/spec/sprinkle/installers/pear_spec.rb @@ -4,16 +4,11 @@ before do @package = mock(Sprinkle::Package, :name => 'spec') - end - - def create...
[FIX] Fix up build failure in pear installer spec
diff --git a/spec/support/save_feature_failures.rb b/spec/support/save_feature_failures.rb index abc1234..def5678 100644 --- a/spec/support/save_feature_failures.rb +++ b/spec/support/save_feature_failures.rb @@ -9,7 +9,7 @@ example_filename += '.html' if RSpec.current_example.exception.present? save_pa...
Fix bug in logging of screenshots of failed tests Presumably this was a typo.
diff --git a/spec/ldap-relations/integration_spec.rb b/spec/ldap-relations/integration_spec.rb index abc1234..def5678 100644 --- a/spec/ldap-relations/integration_spec.rb +++ b/spec/ldap-relations/integration_spec.rb @@ -0,0 +1,42 @@+require 'spec_helper' +require 'ldap-relations' + +# Example ActiveRecord style usage ...
Add integration spec to test use with an ActiveRecord still interface
diff --git a/spec/routing/market_price_route_spec.rb b/spec/routing/market_price_route_spec.rb index abc1234..def5678 100644 --- a/spec/routing/market_price_route_spec.rb +++ b/spec/routing/market_price_route_spec.rb @@ -0,0 +1,19 @@+require 'spec_helper' + +describe "routing to market_prices" do + it { {:get, "/game/...
Add market price route specs.
diff --git a/app/controllers/api/committees_controller.rb b/app/controllers/api/committees_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/committees_controller.rb +++ b/app/controllers/api/committees_controller.rb @@ -5,7 +5,7 @@ @committees = Committee.all @committees = @committees.where(...
Add LIKE To API Committee Name Search Add LIKE instead of API Committee name search because the user should not type in the whole name of what they are looking for.
diff --git a/app/controllers/spree/comments_controller.rb b/app/controllers/spree/comments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/spree/comments_controller.rb +++ b/app/controllers/spree/comments_controller.rb @@ -4,12 +4,11 @@ # Spree::StoreController already has authenticaiton methods...
Remove problematic authorize! & redirect to slug instead of product id
diff --git a/bootstrap-sass.gemspec b/bootstrap-sass.gemspec index abc1234..def5678 100644 --- a/bootstrap-sass.gemspec +++ b/bootstrap-sass.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = "bootstrap-sass" - s.version = '2.0.4.1' + s.version = '2.1.0.0' s.authors = ["Thomas McDonald"] s.email ...
Bump working version to 2.1.0.0
diff --git a/FTWebViewController.podspec b/FTWebViewController.podspec index abc1234..def5678 100644 --- a/FTWebViewController.podspec +++ b/FTWebViewController.podspec @@ -1,12 +1,16 @@ Pod::Spec.new do |s| s.name = "FTWebViewController" - s.version = "0.0.1" + s.version = "0.0.2" s.summary ...
Add authors and bump version to 0.0.2.
diff --git a/lib/bmff/box/track.rb b/lib/bmff/box/track.rb index abc1234..def5678 100644 --- a/lib/bmff/box/track.rb +++ b/lib/bmff/box/track.rb @@ -0,0 +1,12 @@+# coding: utf-8 +# vim: set expandtab tabstop=2 shiftwidth=2 softtabstop=2 autoindent: + +class BMFF::Box::Track < BMFF::Box::Base + register_box "trak" + i...
Add BMFF::Box::Track class which represents Track Box.
diff --git a/plugins/guests/haiku/cap/change_host_name.rb b/plugins/guests/haiku/cap/change_host_name.rb index abc1234..def5678 100644 --- a/plugins/guests/haiku/cap/change_host_name.rb +++ b/plugins/guests/haiku/cap/change_host_name.rb @@ -11,18 +11,18 @@ # Ensure exit on command error set...
plugins/guest: Fix a few typos for Haiku
diff --git a/cookbooks/rs_utils/recipes/setup_hostname.rb b/cookbooks/rs_utils/recipes/setup_hostname.rb index abc1234..def5678 100644 --- a/cookbooks/rs_utils/recipes/setup_hostname.rb +++ b/cookbooks/rs_utils/recipes/setup_hostname.rb @@ -25,6 +25,5 @@ rs_utils_hostname "set_system_hostname" do short_hostname node...
Remove uneeded provider option ref.
diff --git a/lib/tasks/tmp_migrate_hmrc_manuals_rendering_to_government_frontend.rake b/lib/tasks/tmp_migrate_hmrc_manuals_rendering_to_government_frontend.rake index abc1234..def5678 100644 --- a/lib/tasks/tmp_migrate_hmrc_manuals_rendering_to_government_frontend.rake +++ b/lib/tasks/tmp_migrate_hmrc_manuals_rendering...
Add temporary Rake task to migrate hmrc_manuals rendering to goverment-frontend
diff --git a/lib/line/bot/utils.rb b/lib/line/bot/utils.rb index abc1234..def5678 100644 --- a/lib/line/bot/utils.rb +++ b/lib/line/bot/utils.rb @@ -7,7 +7,7 @@ return false unless mids.is_a?(String) || mids.is_a?(Array) mids = [mids] if mids.is_a?(String) - return false unless mids.size > 0 &...
Delete to check `String` in validation for mid
diff --git a/lib/magnum/payload.rb b/lib/magnum/payload.rb index abc1234..def5678 100644 --- a/lib/magnum/payload.rb +++ b/lib/magnum/payload.rb @@ -1,12 +1,10 @@-require 'magnum/payload/version' +require "magnum/payload/version" +require "magnum/payload/errors" module Magnum module Payload SOURCES = %w(cust...
Move error classes definitions into separate file
diff --git a/spec/controllers/profiles_controller_spec.rb b/spec/controllers/profiles_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/profiles_controller_spec.rb +++ b/spec/controllers/profiles_controller_spec.rb @@ -8,7 +8,7 @@ context "an user logged in station in demo mode" do before...
Move profils controller spec to factory_girl.
diff --git a/spec/controllers/sessions_controller_spec.rb b/spec/controllers/sessions_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/sessions_controller_spec.rb +++ b/spec/controllers/sessions_controller_spec.rb @@ -32,14 +32,34 @@ end describe '#create' do - let(:valid_user) { User.c...
Test for session controller pass, 100% coverage
diff --git a/spec/system/method_precedence_system_spec.rb b/spec/system/method_precedence_system_spec.rb index abc1234..def5678 100644 --- a/spec/system/method_precedence_system_spec.rb +++ b/spec/system/method_precedence_system_spec.rb @@ -0,0 +1,48 @@+describe "Fortitude method precedence", :type => :system do + it ...
Add spec to make sure method precedence works correctly in Fortitude.
diff --git a/lib/mindbody-api/models/visit.rb b/lib/mindbody-api/models/visit.rb index abc1234..def5678 100644 --- a/lib/mindbody-api/models/visit.rb +++ b/lib/mindbody-api/models/visit.rb @@ -12,6 +12,7 @@ attribute :web_signup, Boolean attribute :signed_in, Boolean attribute :make_up, Boolean + ...
Add late_cancelled field to Visit model
diff --git a/lib/action_web_service/protocol/discovery.rb b/lib/action_web_service/protocol/discovery.rb index abc1234..def5678 100644 --- a/lib/action_web_service/protocol/discovery.rb +++ b/lib/action_web_service/protocol/discovery.rb @@ -4,18 +4,20 @@ def self.included(base) base.extend(ClassMethods) ...
Make web_service_protocols an class attribute
diff --git a/config/requirements.rb b/config/requirements.rb index abc1234..def5678 100644 --- a/config/requirements.rb +++ b/config/requirements.rb @@ -2,7 +2,7 @@ include FileUtils require 'rubygems' -%w[rake hoe newgem rubigen].each do |req_gem| +%w[hanna/rdoctask rake hoe newgem rubigen].each do |req_gem| beg...
Use the hanna rdoc template
diff --git a/lib/puppet/util/network_device/pure/facts.rb b/lib/puppet/util/network_device/pure/facts.rb index abc1234..def5678 100644 --- a/lib/puppet/util/network_device/pure/facts.rb +++ b/lib/puppet/util/network_device/pure/facts.rb @@ -11,10 +11,10 @@ def retrieve Puppet.debug("Fetching facts from Pure Arra...
Format tweak on Debug logging
diff --git a/lib/suspenders/generators/views_generator.rb b/lib/suspenders/generators/views_generator.rb index abc1234..def5678 100644 --- a/lib/suspenders/generators/views_generator.rb +++ b/lib/suspenders/generators/views_generator.rb @@ -36,6 +36,7 @@ end def create_application_layout + remove_file "...
Remove application.html.erb, we use slim
diff --git a/app/models/photo_request.rb b/app/models/photo_request.rb index abc1234..def5678 100644 --- a/app/models/photo_request.rb +++ b/app/models/photo_request.rb @@ -32,7 +32,13 @@ end def presigned_post - AWS::S3::PresignedPost.new(bucket, :key => key, :secure => false) + AWS::S3::PresignedPost.new...
Set the content type and ACL
diff --git a/app/decorators/optional_module_decorator.rb b/app/decorators/optional_module_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/optional_module_decorator.rb +++ b/app/decorators/optional_module_decorator.rb @@ -10,7 +10,7 @@ color = model.enabled? ? 'green' : 'red' arbre do - s...
Update translation for enabled/disabled OptionalModules
diff --git a/app/uploaders/shoppe/attachment_uploader.rb b/app/uploaders/shoppe/attachment_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/shoppe/attachment_uploader.rb +++ b/app/uploaders/shoppe/attachment_uploader.rb @@ -37,6 +37,8 @@ def watermark return unless file.content_type.include? 'imag...
Watermark applyes only if watermark file presents
diff --git a/test/obix_test.rb b/test/obix_test.rb index abc1234..def5678 100644 --- a/test/obix_test.rb +++ b/test/obix_test.rb @@ -0,0 +1,36 @@+require "obix" +require "minitest/unit" +require "minitest/autorun" +require "active_support/all" + +require "test_helper" + +class OBIXTest < MiniTest::Unit::TestCase + def...
Add tests for OBIX module
diff --git a/activejob/test/cases/timezones_test.rb b/activejob/test/cases/timezones_test.rb index abc1234..def5678 100644 --- a/activejob/test/cases/timezones_test.rb +++ b/activejob/test/cases/timezones_test.rb @@ -32,5 +32,7 @@ end assert_equal "Happy New Year!", JobBuffer.last_value + ensure + Time.z...
Reset Time.zone to avoid leaking into other tests https://buildkite.com/rails/rails/builds/72478#93358e11-6e26-4588-a791-26f9512157c2/1074-1087 https://buildkite.com/rails/rails/builds/72747#10657eba-2359-47ca-9914-49a48b3f2d3c/967-976 https://buildkite.com/rails/rails/builds/72795#3f4bff27-3f42-4678-b643-08cc811c8954...
diff --git a/spec/controllers/contacts_controller_spec.rb b/spec/controllers/contacts_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/contacts_controller_spec.rb +++ b/spec/controllers/contacts_controller_spec.rb @@ -0,0 +1,59 @@+require 'spec_helper' + +describe ContactsController do + describ...
Add ContactsController spec - 05_controller_basics Rspec tests outlined for ContactsController but not yet implemented. Specs organized to flesh out the expectation for happy path and unhappy path.
diff --git a/app/controllers/hr/users_controller.rb b/app/controllers/hr/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/hr/users_controller.rb +++ b/app/controllers/hr/users_controller.rb @@ -22,11 +22,11 @@ def get_user @user = User.find(params[:id]) - authorize @user, :edit? + ...
Allow HR to change name, fix user authorisation
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -1,7 +1,7 @@ class SessionsController < Devise::SessionsController def destroy - current_user.is...
Make sure we have a valid session before trying to log the user out.
diff --git a/config/deploy/production.rb b/config/deploy/production.rb index abc1234..def5678 100644 --- a/config/deploy/production.rb +++ b/config/deploy/production.rb @@ -10,17 +10,12 @@ server "50.57.155.246", :web, :app, :db, :primary => true, :memcached => true -before 'uploads:symlink', 'uploads:create_shared...
Change the image upload symlinking behavior.
diff --git a/app/mailers/woodlock_welcome_mailer.rb b/app/mailers/woodlock_welcome_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/woodlock_welcome_mailer.rb +++ b/app/mailers/woodlock_welcome_mailer.rb @@ -8,6 +8,6 @@ @greeting = "Hi #{user.first_name}! Thanks for registering with #{provider_name}." ...
Change Google and Facebook registration mailer subject
diff --git a/has_breadcrumb.gemspec b/has_breadcrumb.gemspec index abc1234..def5678 100644 --- a/has_breadcrumb.gemspec +++ b/has_breadcrumb.gemspec @@ -8,9 +8,9 @@ gem.version = HasBreadcrumb::VERSION gem.authors = ["Tim Harvey", "Matt Outten"] gem.email = ["developers@squaremouth.com"] - ...
Add gem dependencies and meta info to gemspec This commit adds semantic versions to the rails-spec and sqlite3 gems. Also added was a home page pointed to the gem source code hosted at Github.com. Lastly, the description and summary was improved to be more descriptive of the gem and what it does. This commit was in...
diff --git a/brain/spec/lib/humanity_neuron_spec.rb b/brain/spec/lib/humanity_neuron_spec.rb index abc1234..def5678 100644 --- a/brain/spec/lib/humanity_neuron_spec.rb +++ b/brain/spec/lib/humanity_neuron_spec.rb @@ -12,7 +12,7 @@ ['Hi', 'Why hello there!'], ['hi', 'Why hello there!'], ['Hi Adam', '...
[BRAIN] Fix a bug in assertions
diff --git a/app/api/better_doctor/error_formatter.rb b/app/api/better_doctor/error_formatter.rb index abc1234..def5678 100644 --- a/app/api/better_doctor/error_formatter.rb +++ b/app/api/better_doctor/error_formatter.rb @@ -0,0 +1,16 @@+module BetterDoctor + module ErrorFormatter + + # ----------------------------...
Implement base API error formatter
diff --git a/app/controllers/admin/base_controller.rb b/app/controllers/admin/base_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/base_controller.rb +++ b/app/controllers/admin/base_controller.rb @@ -1,16 +1,23 @@-class Admin::BaseController < ApplicationController - inherit_resources - befor...
Use admin policy class on admin
diff --git a/app/controllers/v2/actions_controller.rb b/app/controllers/v2/actions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/v2/actions_controller.rb +++ b/app/controllers/v2/actions_controller.rb @@ -4,7 +4,9 @@ TimedFeature.check!(owner: "Tijmen", expires: "2017-04-22") actions ...
Return at most 100 items in the actions This is to prevent super-large payloads.
diff --git a/app/views/campaigns/alerts.json.jbuilder b/app/views/campaigns/alerts.json.jbuilder index abc1234..def5678 100644 --- a/app/views/campaigns/alerts.json.jbuilder +++ b/app/views/campaigns/alerts.json.jbuilder @@ -1,6 +1,6 @@ # frozen_string_literal: true -json.alerts @campaign.public_alerts do |alert| +js...
Fix N+1 queries on campaign alerts
diff --git a/lib/liftoff/dependency_managers/carthage.rb b/lib/liftoff/dependency_managers/carthage.rb index abc1234..def5678 100644 --- a/lib/liftoff/dependency_managers/carthage.rb +++ b/lib/liftoff/dependency_managers/carthage.rb @@ -18,7 +18,7 @@ [ { "file" => "copy_frameworks.sh", - ...
Fix "framworks" typo in Carthage copy phase.
diff --git a/lib/pushing/adapters/fcm/andpush_adapter.rb b/lib/pushing/adapters/fcm/andpush_adapter.rb index abc1234..def5678 100644 --- a/lib/pushing/adapters/fcm/andpush_adapter.rb +++ b/lib/pushing/adapters/fcm/andpush_adapter.rb @@ -13,7 +13,9 @@ def push!(notification) FcmResponse.new(self.class.cli...
Make sure to not create a response wrapepr object if not present If the exception is a conneciton error (e.g. Timeout, SSL error), the response object ends up being nil and it doesn't make sense to wrap a nil object. In case of network/connection error, just skip wrapping it so we can save work and things will be less...
diff --git a/Casks/earlybird.rb b/Casks/earlybird.rb index abc1234..def5678 100644 --- a/Casks/earlybird.rb +++ b/Casks/earlybird.rb @@ -7,6 +7,7 @@ name 'Thunderbird Nightly' homepage 'https://www.mozilla.org/en-US/thunderbird/channel/' license :mpl + tags :vendor => 'Mozilla' app 'Earlybird.app' end
Add tags stanza to Earlybird
diff --git a/lib/action_profiler.rb b/lib/action_profiler.rb index abc1234..def5678 100644 --- a/lib/action_profiler.rb +++ b/lib/action_profiler.rb @@ -3,7 +3,7 @@ module ActionController module ActionProfiler - MODES = Set.new(%w(process_time wall_time cpu_time allocated_objects memory)) + MODES = Set.new(...
Update available profile modes for current ruby-prof
diff --git a/lib/database_config.rb b/lib/database_config.rb index abc1234..def5678 100644 --- a/lib/database_config.rb +++ b/lib/database_config.rb @@ -13,7 +13,8 @@ { host: config["host"], database: config["database"], username: config["username"], - password: config["password"] + password...
Reconnect to the database server if the connection goes away.
diff --git a/lib/dawanda/request.rb b/lib/dawanda/request.rb index abc1234..def5678 100644 --- a/lib/dawanda/request.rb +++ b/lib/dawanda/request.rb @@ -13,12 +13,11 @@ # Perform a GET request for the resource with optional parameters - returns # A Response object with the payload data + # def s...
Raise exception if HTTP status is not successful
diff --git a/lib/helios/listener.rb b/lib/helios/listener.rb index abc1234..def5678 100644 --- a/lib/helios/listener.rb +++ b/lib/helios/listener.rb @@ -5,6 +5,7 @@ end def listen! + puts "Beginning polling..." @aws.queues.named('helios').poll do |message| begin puts "Received...
Add message to indicate polling has begun
diff --git a/lib/honyomi/web/app.rb b/lib/honyomi/web/app.rb index abc1234..def5678 100644 --- a/lib/honyomi/web/app.rb +++ b/lib/honyomi/web/app.rb @@ -16,7 +16,7 @@ results = @database.search(@params[:query]) page_entries = results.paginate([["_score", :desc]], :page => 1, :size => 20) - snippet = GrnMini::Ut...
Change snippet max_results: 3 -> 10
diff --git a/lib/omnibus/logging.rb b/lib/omnibus/logging.rb index abc1234..def5678 100644 --- a/lib/omnibus/logging.rb +++ b/lib/omnibus/logging.rb @@ -17,18 +17,43 @@ module Omnibus module Logging def self.included(base) - base.send(:include, Methods) - base.send(:extend, Methods) + base.send(...
Update Logger mixin to add a log_key method
diff --git a/lib/table_for/table.rb b/lib/table_for/table.rb index abc1234..def5678 100644 --- a/lib/table_for/table.rb +++ b/lib/table_for/table.rb @@ -13,7 +13,7 @@ def render builder = TableBuilder.new(self) - body = if block_given? then capture(builder, &block) else builder end + body = if bl...
Fix incorrect usage of block_given?
diff --git a/lib/rubygems_plugin.rb b/lib/rubygems_plugin.rb index abc1234..def5678 100644 --- a/lib/rubygems_plugin.rb +++ b/lib/rubygems_plugin.rb @@ -1,5 +1,11 @@-require 'rubygems' +Gem.post_install do |gem| -Gem.post_install do - puts 'this is a test' + spec = gem.spec + files = spec.files - spec.test_files ...
Add code to find the files that need to be compiled The trick now is going to be getting the correct path.
diff --git a/lib/rubygems_plugin.rb b/lib/rubygems_plugin.rb index abc1234..def5678 100644 --- a/lib/rubygems_plugin.rb +++ b/lib/rubygems_plugin.rb @@ -1,7 +1,7 @@ require 'rubygems' Gem.post_install do |installer| - clone_dir = "#{installer.gem_dir}/src" + clone_dir = ENV['GEMSRC_CLONE_ROOT'] ? "#{ENV['GEMSRC_CL...
Enable to set root directory to clone gems with an environment var
diff --git a/lib/tasks/testing.rake b/lib/tasks/testing.rake index abc1234..def5678 100644 --- a/lib/tasks/testing.rake +++ b/lib/tasks/testing.rake @@ -2,7 +2,7 @@ begin require 'rspec/core/rake_task' task(:spec).clear - RSpec::Core::RakeTask.new(:spec) do |t| + RSpec::Core::RakeTask.new(:spec => 'db:test:prep...
Make "rake" depend on "rake db:test:prepare". This also tests for pending migrations.
diff --git a/lib/same_boat/crews.rb b/lib/same_boat/crews.rb index abc1234..def5678 100644 --- a/lib/same_boat/crews.rb +++ b/lib/same_boat/crews.rb @@ -1,6 +1,6 @@ module SameBoat class Crews - def initialize(crews, journal_path:) + def initialize(crews, journal_path: SameBoat::DEFAULT_JOURNAL) @crews,...
Add default value for keyword argument
diff --git a/license_finder.gemspec b/license_finder.gemspec index abc1234..def5678 100644 --- a/license_finder.gemspec +++ b/license_finder.gemspec @@ -15,6 +15,7 @@ s.rubyforge_project = "license_finder" s.add_development_dependency 'rspec', '~>2.3' s.add_development_dependency 'rr' + s.add_development_depen...
Add rake to development dependencies
diff --git a/db/migrate/20120723144115_add_render_as_partial_for_layout_for_spree_pages.rb b/db/migrate/20120723144115_add_render_as_partial_for_layout_for_spree_pages.rb index abc1234..def5678 100644 --- a/db/migrate/20120723144115_add_render_as_partial_for_layout_for_spree_pages.rb +++ b/db/migrate/20120723144115_add...
Add migration for render_as_partial_for_layout toggle
diff --git a/core/spec/models/spree/line_item_spec.rb b/core/spec/models/spree/line_item_spec.rb index abc1234..def5678 100644 --- a/core/spec/models/spree/line_item_spec.rb +++ b/core/spec/models/spree/line_item_spec.rb @@ -49,3 +49,4 @@ end end end +
Remove all references to on_hand
diff --git a/link_to_action.gemspec b/link_to_action.gemspec index abc1234..def5678 100644 --- a/link_to_action.gemspec +++ b/link_to_action.gemspec @@ -19,4 +19,5 @@ s.add_development_dependency "rails", "~> 3.2.8" s.add_development_dependency "sqlite3" s.add_development_dependency "simplecov" + s.add_develop...
Add debugger as development dependency.
diff --git a/spec/helpers/home_helper_spec.rb b/spec/helpers/home_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/home_helper_spec.rb +++ b/spec/helpers/home_helper_spec.rb @@ -8,25 +8,30 @@ subject { HomeClass.new } describe "#get_completed_test_runs" do - let(:time1) { Time.new(2012,12...
Refactor the mess out of a test
diff --git a/spec/routing/calculators_spec.rb b/spec/routing/calculators_spec.rb index abc1234..def5678 100644 --- a/spec/routing/calculators_spec.rb +++ b/spec/routing/calculators_spec.rb @@ -0,0 +1,6 @@+RSpec.describe 'Calculator routing', type: :routing do + it 'routes /take-whole-pot/estimate to calculators/take_w...
Add routing spec for calculators
diff --git a/spec/support/test_environment.rb b/spec/support/test_environment.rb index abc1234..def5678 100644 --- a/spec/support/test_environment.rb +++ b/spec/support/test_environment.rb @@ -9,7 +9,6 @@ end require "action_controller/railtie" -require "active_resource/railtie" require 'active_model' # Create a...
Remove active resource require because we are not using it
diff --git a/TSMessages.podspec b/TSMessages.podspec index abc1234..def5678 100644 --- a/TSMessages.podspec +++ b/TSMessages.podspec @@ -14,7 +14,7 @@ s.author = { "Felix Krause" => "krausefx@gmail.com" } - s.source = { :git => "https://github.com/toursprung/TSMessages.git" :tag => "0.9.4"} + s.sour...
Fix syntax error in podspec.
diff --git a/lib/geocoder/lookups/ovi.rb b/lib/geocoder/lookups/ovi.rb index abc1234..def5678 100644 --- a/lib/geocoder/lookups/ovi.rb +++ b/lib/geocoder/lookups/ovi.rb @@ -13,7 +13,7 @@ end def query_url(query) - "#{protocol}://lbs.ovi.com/search/6.2/geocode.json?" + url_query_string(query) + "#{p...
Add reversed geocoding support for Ovi/Nokia
diff --git a/lib/git_hooks/checkstyle.rb b/lib/git_hooks/checkstyle.rb index abc1234..def5678 100644 --- a/lib/git_hooks/checkstyle.rb +++ b/lib/git_hooks/checkstyle.rb @@ -30,7 +30,7 @@ violations['files'] ||= [] file_violation = { - 'path' => fix_path(file[:name]), + 'path...
Use the pre-Ruby 2.4 method for element attribute access for backwards compatibility.
diff --git a/lib/jmespath/nodes/index.rb b/lib/jmespath/nodes/index.rb index abc1234..def5678 100644 --- a/lib/jmespath/nodes/index.rb +++ b/lib/jmespath/nodes/index.rb @@ -13,6 +13,40 @@ nil end end + + def chains_with?(other) + other.is_a?(Index) + end + + def chain(oth...
Optimize runs of Index to ChainIndex
diff --git a/lib/kekomi/content_types.rb b/lib/kekomi/content_types.rb index abc1234..def5678 100644 --- a/lib/kekomi/content_types.rb +++ b/lib/kekomi/content_types.rb @@ -23,6 +23,7 @@ klass.class_eval &block klass.before_save :serialize_fields klass.validates_presence_of klass.represented_with un...
Add defined hook when content type is created
diff --git a/lib/openlogi/base_object.rb b/lib/openlogi/base_object.rb index abc1234..def5678 100644 --- a/lib/openlogi/base_object.rb +++ b/lib/openlogi/base_object.rb @@ -18,9 +18,9 @@ super(@attributes, &block) end - property :error + property :error, coerce: String property :errors, coerce: ...
Add missing coercions to error-related properties on base object
diff --git a/lib/daimon_skycrawlers/url_consumer.rb b/lib/daimon_skycrawlers/url_consumer.rb index abc1234..def5678 100644 --- a/lib/daimon_skycrawlers/url_consumer.rb +++ b/lib/daimon_skycrawlers/url_consumer.rb @@ -22,6 +22,7 @@ def process(message) url = message[:url] + # XXX When several crawlers ...
Add comment for unresolved behavior I don't know now.
diff --git a/lib/shell/build-protobox.rb b/lib/shell/build-protobox.rb index abc1234..def5678 100644 --- a/lib/shell/build-protobox.rb +++ b/lib/shell/build-protobox.rb @@ -2,10 +2,10 @@ ansible_version_file = protobox_dir + '/ansible_version' # Ansible version - ansible_version = '1.6.8' - #if !yaml['protobox...
Move ansible version back to latest since release of 1.7
diff --git a/lib/tasks/tag_from_csv.rake b/lib/tasks/tag_from_csv.rake index abc1234..def5678 100644 --- a/lib/tasks/tag_from_csv.rake +++ b/lib/tasks/tag_from_csv.rake @@ -0,0 +1,6 @@+desc "Perform taggings from a csv file" +task :tag_from_csv, [:csv_url] => :environment do |_, args| + Tagging::CsvTagger.do_tagging(a...
Add rake task to tag content from a remote CSV file
diff --git a/lib/yard/generators/class_generator.rb b/lib/yard/generators/class_generator.rb index abc1234..def5678 100644 --- a/lib/yard/generators/class_generator.rb +++ b/lib/yard/generators/class_generator.rb @@ -10,7 +10,10 @@ DocstringGenerator, AttributesGenerator, Constan...
Add public instance method summary view to class generator
diff --git a/lib/cucumber/events/test_run_finished.rb b/lib/cucumber/events/test_run_finished.rb index abc1234..def5678 100644 --- a/lib/cucumber/events/test_run_finished.rb +++ b/lib/cucumber/events/test_run_finished.rb @@ -3,8 +3,9 @@ module Cucumber module Events - # Event fired after aall test cases have fi...
Make event parsable by yardoc
diff --git a/app/models/post.rb b/app/models/post.rb index abc1234..def5678 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -1,3 +1,12 @@ class Post < ActiveRecord::Base belongs_to :author, class_name: :user, foreign_key: :author_id + scope :ordered, :order => "created_at DESC" + + def self.published +...
Add published and unpublished functions
diff --git a/lib/intrinsic/intrinsicism/validation.rb b/lib/intrinsic/intrinsicism/validation.rb index abc1234..def5678 100644 --- a/lib/intrinsic/intrinsicism/validation.rb +++ b/lib/intrinsic/intrinsicism/validation.rb @@ -24,6 +24,9 @@ private def validate(property, validator) + begin + re...
Make begin, rescue, end blocks
diff --git a/app/models/stop.rb b/app/models/stop.rb index abc1234..def5678 100644 --- a/app/models/stop.rb +++ b/app/models/stop.rb @@ -24,6 +24,6 @@ def self.find_legacy(id) # This is to support the case where a user has a favorite saved from # before the switch to postres generated ids - Stop.where(id...
Raise an RecordNotFound error on Stop.find_legacy