diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/services/iiif_manifest.rb b/app/services/iiif_manifest.rb index abc1234..def5678 100644 --- a/app/services/iiif_manifest.rb +++ b/app/services/iiif_manifest.rb @@ -5,7 +5,6 @@ end def add_noid - return unless ark_url solr_hash["access_identifier_ssim"] = [noid] end @@ -24,6 +23,10 @...
Support fallback when no rendering
diff --git a/lib/batch_api.rb b/lib/batch_api.rb index abc1234..def5678 100644 --- a/lib/batch_api.rb +++ b/lib/batch_api.rb @@ -5,7 +5,19 @@ require 'batch_api/middleware' module BatchApi + + # Public: access the main Batch API configuration object. + # + # Returns a BatchApi::Configuration instance def self....
Add rails? method in BatchApi
diff --git a/lib/consoleIO.rb b/lib/consoleIO.rb index abc1234..def5678 100644 --- a/lib/consoleIO.rb +++ b/lib/consoleIO.rb @@ -4,9 +4,9 @@ attr_reader :input attr_reader :output - def initialize(params = {}) - @input = params.fetch(:input, STDIN) - @output = params.fetch(:output, STDOUT) + def initiali...
Make consoleio class have named params
diff --git a/lib/hg/prompt.rb b/lib/hg/prompt.rb index abc1234..def5678 100644 --- a/lib/hg/prompt.rb +++ b/lib/hg/prompt.rb @@ -23,7 +23,7 @@ # Invoke a question type of prompt. # # @example - # prompt = TTY::Prompt.new + # prompt = Hg::Prompt.new # prompt.invoke_question(Question, "Your...
Update comments to refer to correct classes
diff --git a/test/serializer/dsl_test.rb b/test/serializer/dsl_test.rb index abc1234..def5678 100644 --- a/test/serializer/dsl_test.rb +++ b/test/serializer/dsl_test.rb @@ -4,7 +4,8 @@ class Serializer class TestDSL < Minitest::Test def setup - @user = User.new(name: "Carles Jove", email: "hola@car...
Set a date_created in dls_test?
diff --git a/sidekiq-unique-jobs.gemspec b/sidekiq-unique-jobs.gemspec index abc1234..def5678 100644 --- a/sidekiq-unique-jobs.gemspec +++ b/sidekiq-unique-jobs.gemspec @@ -15,7 +15,7 @@ gem.require_paths = ["lib"] gem.version = SidekiqUniqueJobs::VERSION gem.add_dependency 'sidekiq', '>= 2.6'...
Declare mock_redis as development dependency instead of runtime one
diff --git a/ext/rocksdb/extconf.rb b/ext/rocksdb/extconf.rb index abc1234..def5678 100644 --- a/ext/rocksdb/extconf.rb +++ b/ext/rocksdb/extconf.rb @@ -1,7 +1,9 @@ require "mkmf" dir_config('rocksdb') -RbConfig::CONFIG["CPP"] = "g++ -E -std=gnu++17" +cxx = RbConfig::CONFIG["CXX"] +RbConfig::CONFIG["CPP"] = "#{cxx} ...
Fix build for MacOS on Ruby 3.1 Between Ruby 3.0 and 3.1 the behaviour of `have_library` has changed. Now it does not use `RbConfig::CONFIG['CPP']`, but `RbConfig::CONFIG['CC']`. To allow the extension to compile on MacOS, the latter needs to be adjusted as well. This also uses `RbConfig::CONFIG['CXX']` instead of ha...
diff --git a/tools/fetch_ago_mappings.rb b/tools/fetch_ago_mappings.rb index abc1234..def5678 100644 --- a/tools/fetch_ago_mappings.rb +++ b/tools/fetch_ago_mappings.rb @@ -0,0 +1,74 @@+#!/usr/bin/env ruby -w +require 'csv' +require 'uri' +require 'net/http' +require 'pathname' + +class FetchAgoMappings + + def fetch ...
Add script for fetching AGO mappings from google doc
diff --git a/app/controllers/contentr/application_controller.rb b/app/controllers/contentr/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/contentr/application_controller.rb +++ b/app/controllers/contentr/application_controller.rb @@ -1,7 +1,7 @@ # coding: utf-8 module Contentr - class...
Extend ActionController::Base instead of the ::ApplicationController
diff --git a/spec/features/users_spec.rb b/spec/features/users_spec.rb index abc1234..def5678 100644 --- a/spec/features/users_spec.rb +++ b/spec/features/users_spec.rb @@ -0,0 +1,32 @@+require 'rails_helper' + +feature "User management" do + scenario "has a user signup, login, logout cycle" do + visit new_user_pat...
Complete full user auth feature test. Conflicts: spec/features/users_spec.rb
diff --git a/common/constants.rb b/common/constants.rb index abc1234..def5678 100644 --- a/common/constants.rb +++ b/common/constants.rb @@ -3,6 +3,7 @@ module Constants # The API version # This follows Semantic Versioning (http://semver.org). + # When changing this, update API_CHANGE_LOG. ...
Add request to update changelog.
diff --git a/spec/system/haproxy_spec.rb b/spec/system/haproxy_spec.rb index abc1234..def5678 100644 --- a/spec/system/haproxy_spec.rb +++ b/spec/system/haproxy_spec.rb @@ -9,17 +9,10 @@ RSpec.describe "haproxy" do - let(:service_name) { environment.bosh_manifest.property('rabbitmq-broker.service.name') } - - let...
Fix haproxy tests so we don't have to push a CF app Signed-off-by: Carlo Colombo <38c9d5db9f6d6f5bb8266b73fcdee56a5a2fe4dc@pivotal.io>
diff --git a/backend/app/helpers/spree/admin/products_helper.rb b/backend/app/helpers/spree/admin/products_helper.rb index abc1234..def5678 100644 --- a/backend/app/helpers/spree/admin/products_helper.rb +++ b/backend/app/helpers/spree/admin/products_helper.rb @@ -1,30 +1,6 @@ module Spree module Admin module P...
Remove unused admin products helpers This removes taxon_options_for and option_types_options_for, which haven't been used since 2012 (when their usage replaced with querying the API)
diff --git a/bullet.gemspec b/bullet.gemspec index abc1234..def5678 100644 --- a/bullet.gemspec +++ b/bullet.gemspec @@ -14,6 +14,10 @@ s.homepage = 'https://github.com/flyerhzm/bullet' s.summary = 'help to kill N+1 queries and unused eager loading.' s.description = 'help to kill N+1 queries and unused e...
Add source and changelog urls to rubygems page
diff --git a/test/user_auth_test.rb b/test/user_auth_test.rb index abc1234..def5678 100644 --- a/test/user_auth_test.rb +++ b/test/user_auth_test.rb @@ -5,7 +5,7 @@ def test_autoload_paths autoload_paths = ActiveSupport::Dependencies.autoload_paths - DIRECTORIES_TO_LOAD_FROM.each do |dir| + USER_AUTH_DIR...
Fix UserAuthTest for the constant name test/user_auth_test.rb - Fix to use USER_AUTH_DIRECTORIES_TO_LOAD_FROM instead of DIRECTORIES_TO_LOAD_FROM.
diff --git a/cookbooks/wt_monitoring/recipes/email_heartbeat.rb b/cookbooks/wt_monitoring/recipes/email_heartbeat.rb index abc1234..def5678 100644 --- a/cookbooks/wt_monitoring/recipes/email_heartbeat.rb +++ b/cookbooks/wt_monitoring/recipes/email_heartbeat.rb @@ -0,0 +1,15 @@+# +# Cookbook Name:: wt_monitoring +# Reci...
Create a 4 hour heartbeat e-mail recipe in wt_monitoring that goes to the admin_email in wt_common Former-commit-id: b0d2ac99aaf1b147d689b37205ec0b4467340c2e [formerly acd53badb692d131427c04eda2f0e3ad4ff503dc] [formerly ac69e488174a0f954bd1789ac6562e4055555fde [formerly bba87f7ee63505ca3ab8013414652838acf02b5c [forme...
diff --git a/guard-cucumber.gemspec b/guard-cucumber.gemspec index abc1234..def5678 100644 --- a/guard-cucumber.gemspec +++ b/guard-cucumber.gemspec @@ -18,9 +18,9 @@ s.add_dependency 'guard', '>= 0.8.3' s.add_dependency 'cucumber', '>= 1.2.0' - s.add_development_dependency 'bundler', '~> 1.0' - s...
Remove explicit dev version dependency.
diff --git a/examples/async_helper.rb b/examples/async_helper.rb index abc1234..def5678 100644 --- a/examples/async_helper.rb +++ b/examples/async_helper.rb @@ -0,0 +1,24 @@+# If you want to just call a method on an object in the background, +# we can easily add that functionality to Resque. + +# Here's our ActiveRecor...
Add an example which shows how to implement something like DJ's `send_later`
diff --git a/db/migrate/050_add_user_index_to_diary_comments.rb b/db/migrate/050_add_user_index_to_diary_comments.rb index abc1234..def5678 100644 --- a/db/migrate/050_add_user_index_to_diary_comments.rb +++ b/db/migrate/050_add_user_index_to_diary_comments.rb @@ -0,0 +1,9 @@+class AddUserIndexToDiaryComments < ActiveR...
Add a user index to diary comments
diff --git a/Casks/hopper-disassembler.rb b/Casks/hopper-disassembler.rb index abc1234..def5678 100644 --- a/Casks/hopper-disassembler.rb +++ b/Casks/hopper-disassembler.rb @@ -1,10 +1,10 @@ cask :v1 => 'hopper-disassembler' do - version '3.10.8.1' - sha256 '20cfb6d8da01af0cbcd645ccde02e30c88515342873da19d2d25c533f85...
Update Hopper, Hopper Disassembler to 3.10.9
diff --git a/em-hiredis.gemspec b/em-hiredis.gemspec index abc1234..def5678 100644 --- a/em-hiredis.gemspec +++ b/em-hiredis.gemspec @@ -12,7 +12,7 @@ s.summary = %q{Eventmachine redis client} s.description = %q{Eventmachine redis client using hiredis native parser} - s.add_dependency 'hiredis', '~> 0.3.0' ...
Update hiredis dependency to 0.4.x
diff --git a/spec/controllers/request_controller_spec.rb b/spec/controllers/request_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/request_controller_spec.rb +++ b/spec/controllers/request_controller_spec.rb @@ -3,11 +3,11 @@ describe BlacklightCornellRequests::RequestController, :type => :co...
Add first working controller rspec test.
diff --git a/spec/lib/organicat/organization_dsl_spec.rb b/spec/lib/organicat/organization_dsl_spec.rb index abc1234..def5678 100644 --- a/spec/lib/organicat/organization_dsl_spec.rb +++ b/spec/lib/organicat/organization_dsl_spec.rb @@ -18,6 +18,7 @@ dsl.organizations.first end + its(:name) { is_e...
Add spec for organization name
diff --git a/config/boot.rb b/config/boot.rb index abc1234..def5678 100644 --- a/config/boot.rb +++ b/config/boot.rb @@ -1,4 +1,4 @@ # Set up gems listed in the Gemfile. ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__) -require 'bundler/setup' if File.exists?(ENV['BUNDLE_GEMFILE']) +require 'bun...
Replace deprecated File.exists? method with File.exist?
diff --git a/_plugins/md_to_html.rb b/_plugins/md_to_html.rb index abc1234..def5678 100644 --- a/_plugins/md_to_html.rb +++ b/_plugins/md_to_html.rb @@ -1,4 +1,5 @@ require_relative '../_config' +require 'redcloth' module Jekyll module MarkdownFilter
Add RedCloth req to plugin
diff --git a/app/controllers/quotes_controller.rb b/app/controllers/quotes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/quotes_controller.rb +++ b/app/controllers/quotes_controller.rb @@ -45,6 +45,6 @@ end def language - @quotes = Quote.where(language: params[:language]) + @quotes = Qu...
Make language page lists by recent created order
diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb index abc1234..def5678 100644 --- a/app/controllers/search_controller.rb +++ b/app/controllers/search_controller.rb @@ -1,12 +1,10 @@ class SearchController < ApplicationController - - skip_before_filter :load_project - before_fi...
Revert before_filter tampering in SearchController These "fixes" are no longer necessary and they broke some permissions features of searching across all projects. This reverts commits: - 04a7f9b8358a5c053c4b76a91993e920f820d5e6 - 04a5479a4291a39801d6bfd05d8cd09ece361e74
diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb index abc1234..def5678 100644 --- a/app/controllers/search_controller.rb +++ b/app/controllers/search_controller.rb @@ -16,7 +16,7 @@ s.size 25 s.query do |query| - query.string @query + query.string @q...
Change default search operator from OR to AND.
diff --git a/app/models/refresh_feed_job_state.rb b/app/models/refresh_feed_job_state.rb index abc1234..def5678 100644 --- a/app/models/refresh_feed_job_state.rb +++ b/app/models/refresh_feed_job_state.rb @@ -33,7 +33,7 @@ # Update the refresh_feed_jobs_updated_at attribute of the associated user with the current dat...
Fix bug: update User instance from RefreshFeedJobState AR callback only if user exists. When RefreshFeedWorker detects that the passed user does not exist, it deletes the RefreshFeedJobState from the database before exiting. This invokes the after_destroy callback of the RefreshFeedJobState model, which tries to updat...
diff --git a/lib/assorted/scopes.rb b/lib/assorted/scopes.rb index abc1234..def5678 100644 --- a/lib/assorted/scopes.rb +++ b/lib/assorted/scopes.rb @@ -20,7 +20,7 @@ def sanitized_order(column, direction) if attribute_names.include?(column.to_s) - order("#{column} #{direction}") + order("#{t...
Include table name to prevent ambiguous queries
diff --git a/lib/high_roller/cli.rb b/lib/high_roller/cli.rb index abc1234..def5678 100644 --- a/lib/high_roller/cli.rb +++ b/lib/high_roller/cli.rb @@ -1,6 +1,12 @@+require 'trollop' + module HighRoller::CLI autoload :REPL, 'high_roller/cli/repl' autoload :Single, 'high_roller/cli/single' + + def self.run! +...
Move bin logic to CLI
diff --git a/lib/microspec/raise.rb b/lib/microspec/raise.rb index abc1234..def5678 100644 --- a/lib/microspec/raise.rb +++ b/lib/microspec/raise.rb @@ -2,6 +2,20 @@ module Microspec module Raise + module Helper + def self.exception(expected: nil, actual: nil, message: nil) + if actual.nil? + ...
Move exception generation to helper module
diff --git a/lib/nexmo/signature.rb b/lib/nexmo/signature.rb index abc1234..def5678 100644 --- a/lib/nexmo/signature.rb +++ b/lib/nexmo/signature.rb @@ -6,7 +6,7 @@ def self.check(params, secret) params = params.dup - signature = params.delete(:sig) + signature = params.delete('sig') ::J...
Fix Nexmo::Signature.check using symbol key instead of string key
diff --git a/app/models/category.rb b/app/models/category.rb index abc1234..def5678 100644 --- a/app/models/category.rb +++ b/app/models/category.rb @@ -17,7 +17,12 @@ items.sum("current_quantity * value") else items.includes(:versions).inject(0) do |sum, item| - sum + (item.total_value(at: at)...
Use clearer conditionals for skipping item total_values that are nil
diff --git a/enum_test.rb b/enum_test.rb index abc1234..def5678 100644 --- a/enum_test.rb +++ b/enum_test.rb @@ -0,0 +1,14 @@+clock = Enumerator.new { |y| loop { y << Time.now.to_f } } +const = Enumerator.new { |y| loop { y << 1 } } +limited = (0..10).to_enum + +enums = [clock, const, limited] +loop do + begin + ne...
Test out enumerations. Looks like no laziness in 1.9.3
diff --git a/app/models/voteable.rb b/app/models/voteable.rb index abc1234..def5678 100644 --- a/app/models/voteable.rb +++ b/app/models/voteable.rb @@ -7,6 +7,29 @@ def upvote(user) @_vote = find_vote(user) @_vote.value = true + end + + def parent_question_id + case Module.get_const(self.get_type) + ...
Define method to return Voteable object's id
diff --git a/coroutine.rb b/coroutine.rb index abc1234..def5678 100644 --- a/coroutine.rb +++ b/coroutine.rb @@ -1,4 +1,12 @@ require "continuation" + +# For some reason calling Fiber.current prevents a "coroutine.rb:25:in +# `call': continuation called across fiber (RuntimeError)" which +# started happening after swit...
Add bogus call to Fiber.current as a hack.
diff --git a/activerecord/test/cases/log_subscriber_test.rb b/activerecord/test/cases/log_subscriber_test.rb index abc1234..def5678 100644 --- a/activerecord/test/cases/log_subscriber_test.rb +++ b/activerecord/test/cases/log_subscriber_test.rb @@ -41,4 +41,21 @@ assert_match(/CACHE/, @logger.logged(:debug).last) ...
Test added, we shouldn't log sql calls when logger is not on debug? mode
diff --git a/souschef.gemspec b/souschef.gemspec index abc1234..def5678 100644 --- a/souschef.gemspec +++ b/souschef.gemspec @@ -22,4 +22,11 @@ spec.add_development_dependency "rake" spec.add_dependency 'ruth' spec.add_dependency 'colorize' + spec.add_dependency 'chef' + spec.add_dependency 'berkshelf' + spe...
Add more Chef related dependencies
diff --git a/souschef.gemspec b/souschef.gemspec index abc1234..def5678 100644 --- a/souschef.gemspec +++ b/souschef.gemspec @@ -20,5 +20,6 @@ spec.add_development_dependency "bundler", "~> 1.6" spec.add_development_dependency "rake" + spec.add_dependency 'ruth' spec.add_dependency 'colorize' end
Add Ruth gem for Gemfile generation
diff --git a/test/server_test.rb b/test/server_test.rb index abc1234..def5678 100644 --- a/test/server_test.rb +++ b/test/server_test.rb @@ -1,17 +1,21 @@ require File.dirname(__FILE__) + '/helper' -class Rack::Handler::Mock - extend Test::Unit::Assertions +module Rack::Handler + class Mock + extend Test::Unit::...
Use rack's new handler registration stuff to fix some failing specs
diff --git a/MDCSwipeToChoose.podspec b/MDCSwipeToChoose.podspec index abc1234..def5678 100644 --- a/MDCSwipeToChoose.podspec +++ b/MDCSwipeToChoose.podspec @@ -5,7 +5,7 @@ s.homepage = 'https://github.com/modocache/MDCSwipeToChoose' s.license = 'MIT' s.author = { 'modocache' => 'modocache@gmail....
Use old Ruby syntax in podspec.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,8 +1,8 @@ require 'minitest/autorun' -begin require 'ruby-debug'; rescue; end -begin require 'redgreen' ; rescue; end -begin require 'phocus' ; rescue; end +begin require ...
Fix requiring of optional test deps
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,3 +1,4 @@+$: << 'lib' gem 'minitest' require 'minitest/spec'
Add lib to the path in the test helper
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,8 +1,14 @@ require 'simplecov' -SimpleCov.start +require 'coveralls' -require 'coveralls' -Coveralls.wear! +SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[ + Cove...
Update configuration for SimpleCov and Coveralls
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,3 +1,3 @@ # Be sure to restart your server when you modify this file. -Rails.application.config.session_sto...
Expire session cookie after two weeks
diff --git a/lib/generators/georgia/install/templates/db/migrate/create_georgia_messages.rb b/lib/generators/georgia/install/templates/db/migrate/create_georgia_messages.rb index abc1234..def5678 100644 --- a/lib/generators/georgia/install/templates/db/migrate/create_georgia_messages.rb +++ b/lib/generators/georgia/ins...
Add spam column to messages
diff --git a/environment.rb b/environment.rb index abc1234..def5678 100644 --- a/environment.rb +++ b/environment.rb @@ -14,7 +14,7 @@ configure do # load models - Dir.glob("#{File.dirname(__FILE__)}/lib/models/*.rb") { |lib| require lib } + Dir.glob("#{File.dirname(__FILE__)}/lib/models/*.rb").sort.each { |lib|...
Fix dir.glob sorting across platforms. On some OSes, the results of ````Dir.glob```` will not be sorted alphabetically, this makes it consistent across different platforms.
diff --git a/Quick.podspec b/Quick.podspec index abc1234..def5678 100644 --- a/Quick.podspec +++ b/Quick.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "Quick" - s.version = "0.4.0" + s.version = "0.5.0" s.summary = "The Swift (and Objective-C) testing framework." s.descriptio...
Bump version to 0.5.0 in podspec
diff --git a/app/models/ansible/runner.rb b/app/models/ansible/runner.rb index abc1234..def5678 100644 --- a/app/models/ansible/runner.rb +++ b/app/models/ansible/runner.rb @@ -0,0 +1,27 @@+module Ansible + class Runner + def self.run(env_vars, extra_vars, playbook_path) + run_via_cli(env_vars, extra_vars, pla...
Add simple wrapping code for running ansible-playbook Add simple wrapping code for running ansible-playbook
diff --git a/app/models/symbolize_json.rb b/app/models/symbolize_json.rb index abc1234..def5678 100644 --- a/app/models/symbolize_json.rb +++ b/app/models/symbolize_json.rb @@ -1,7 +1,7 @@ module SymbolizeJSON def self.included(model) model.columns.each do |column| - next unless column.sql_type == "json" +...
Change check to match json and jsonb
diff --git a/test/ruby/support/api_umbrella_tests/admin_auth.rb b/test/ruby/support/api_umbrella_tests/admin_auth.rb index abc1234..def5678 100644 --- a/test/ruby/support/api_umbrella_tests/admin_auth.rb +++ b/test/ruby/support/api_umbrella_tests/admin_auth.rb @@ -8,6 +8,12 @@ visit "/admins/auth/developer" ...
Fix intermittent ajax test failures due to canceled ajax requests.
diff --git a/lib/goog/sheet_record.rb b/lib/goog/sheet_record.rb index abc1234..def5678 100644 --- a/lib/goog/sheet_record.rb +++ b/lib/goog/sheet_record.rb @@ -1,11 +1,15 @@ class Goog::SheetRecord attr :schema attr :row_values + attr :row_num + attr :sheet include Goog::SpreadsheetUtils - def initialize...
Add row_num and sheet to SheetRecord. Raise NoMethodError if method is not in schema. Create class method to handle record creation.
diff --git a/ext/extconf.rb b/ext/extconf.rb index abc1234..def5678 100644 --- a/ext/extconf.rb +++ b/ext/extconf.rb @@ -10,7 +10,7 @@ f.print mf f.print <<END all:: - $(MAKE) all -C tidy-html5/build/gmake + $(MAKE) all -C #{File.expand_path(File.join(File.dirname(__FILE__), 'tidy-html5', 'build', 'gmake'))} i...
Use full path to makefile
diff --git a/spec/features/top_spec.rb b/spec/features/top_spec.rb index abc1234..def5678 100644 --- a/spec/features/top_spec.rb +++ b/spec/features/top_spec.rb @@ -4,7 +4,7 @@ describe "GET /" do scenario "Sponser links should be exist" do visit "/" - expect(page).to have_css 'section.sponsors_logo ...
Fix broken test for Sponsors
diff --git a/tools/snippet-testing/language_handler/python_6.rb b/tools/snippet-testing/language_handler/python_6.rb index abc1234..def5678 100644 --- a/tools/snippet-testing/language_handler/python_6.rb +++ b/tools/snippet-testing/language_handler/python_6.rb @@ -23,9 +23,12 @@ def replace_twilio_client_initiali...
Make replace TwilioHttpClient in Python snippets more resilient
diff --git a/transfluent.gemspec b/transfluent.gemspec index abc1234..def5678 100644 --- a/transfluent.gemspec +++ b/transfluent.gemspec @@ -6,7 +6,12 @@ s.description = "Order human powered translations directly from your Ruby code!" s.authors = ["Transfluent Ltd"] s.email = 'coders@transfluent.com' ...
Add missing files to gemfile
diff --git a/vendor/cookbooks/devbox/attributes/mysql_server.rb b/vendor/cookbooks/devbox/attributes/mysql_server.rb index abc1234..def5678 100644 --- a/vendor/cookbooks/devbox/attributes/mysql_server.rb +++ b/vendor/cookbooks/devbox/attributes/mysql_server.rb @@ -1 +1,6 @@ include_attribute "mysql::server" + +override...
Fix mysql cookbook settings to include default passwords
diff --git a/lib/liquid/interrupts.rb b/lib/liquid/interrupts.rb index abc1234..def5678 100644 --- a/lib/liquid/interrupts.rb +++ b/lib/liquid/interrupts.rb @@ -1,6 +1,6 @@ module Liquid - # An interrupt is any command that breaks processing of a block (ex: a for loop). - class Interrupt + # A block interrupt is any...
Remove reserved word Interrupt to avoid confusion Also resolves rubocop conflicts
diff --git a/roles/cassandra_datanode.rb b/roles/cassandra_datanode.rb index abc1234..def5678 100644 --- a/roles/cassandra_datanode.rb +++ b/roles/cassandra_datanode.rb @@ -6,6 +6,7 @@ runit boost thrift + ntp cassandra cassandra::install_from_release cassandra::autoconf
Add ntp to cassandra datanode role.
diff --git a/lib/pixiv/illust_list.rb b/lib/pixiv/illust_list.rb index abc1234..def5678 100644 --- a/lib/pixiv/illust_list.rb +++ b/lib/pixiv/illust_list.rb @@ -0,0 +1,28 @@+module Pixiv + # @abstract + class IllustList < Page + include PageCollection + + attr_reader :page + attr_reader :count + + def pag...
Add new IllustList, the base class for illust list
diff --git a/lib/productivity/good.rb b/lib/productivity/good.rb index abc1234..def5678 100644 --- a/lib/productivity/good.rb +++ b/lib/productivity/good.rb @@ -0,0 +1,16 @@+require 'securerandom' + +module Productivity + +class Good + @attr_accessor :name, :version, :id, :ancestors + + def initialize args ...
Add the Good class, which defines anything that can be used by man to satisfy an end. Add a very brief description of the project to README.rdoc
diff --git a/app/admin/article_post.rb b/app/admin/article_post.rb index abc1234..def5678 100644 --- a/app/admin/article_post.rb +++ b/app/admin/article_post.rb @@ -26,8 +26,8 @@ row :author row :column row :featured - row :featured_image do |post| - img src: post.featured_image.thumb.ur...
Fix shadowed outer local variable
diff --git a/lib/send_with_us/file.rb b/lib/send_with_us/file.rb index abc1234..def5678 100644 --- a/lib/send_with_us/file.rb +++ b/lib/send_with_us/file.rb @@ -1,16 +1,21 @@ module SendWithUs - class File < SimpleDelegator + class File + attr_accessor :attachment + def initialize(file_data, opts = {}) - ...
Drop SimpleDelegator dependency to avoid bad performance ruby@1.8
diff --git a/lib/subtime/timer_cli.rb b/lib/subtime/timer_cli.rb index abc1234..def5678 100644 --- a/lib/subtime/timer_cli.rb +++ b/lib/subtime/timer_cli.rb @@ -23,7 +23,7 @@ " Example: -s 9,'Get up and stretch'", " This will say 'Get up and stretch' at minute 9", " NOT...
Fix -s to accept multiple key,values
diff --git a/app/helpers/xml_helper.rb b/app/helpers/xml_helper.rb index abc1234..def5678 100644 --- a/app/helpers/xml_helper.rb +++ b/app/helpers/xml_helper.rb @@ -1,7 +1,7 @@ module XmlHelper def collection_lastmod(collection) - article_updated = collection.articles.find(:first, order: 'updated_at DESC') - a...
Fix the retrieval of published and updated articles
diff --git a/app/models/charge_rate.rb b/app/models/charge_rate.rb index abc1234..def5678 100644 --- a/app/models/charge_rate.rb +++ b/app/models/charge_rate.rb @@ -9,7 +9,7 @@ to = duration_to.nil? ? "" : I18n::localize(duration_to) "%s: %s (%s - %s)" % [title, rate_to_s, from, to] else - ...
Use "%title (%rate) as ChargeRate.to_s.
diff --git a/bot/job_status_generation.rb b/bot/job_status_generation.rb index abc1234..def5678 100644 --- a/bot/job_status_generation.rb +++ b/bot/job_status_generation.rb @@ -2,7 +2,7 @@ def to_status rep = [] - rep << "Job #{ident} (#{url}):" + rep << "Job #{ident} ( #{url} ):" if started_by ...
Add a space between the URL and the surrounding parens to make various auto-linkers happy
diff --git a/interactor.gemspec b/interactor.gemspec index abc1234..def5678 100644 --- a/interactor.gemspec +++ b/interactor.gemspec @@ -14,6 +14,6 @@ spec.files = `git ls-files`.split($/) spec.test_files = spec.files.grep(/^spec/) - spec.add_development_dependency "bundler", "~> 1.7" - spec.add_developme...
Drop version requirements for bundler and rake
diff --git a/app/controllers/stash_engine/sessions_controller.rb b/app/controllers/stash_engine/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/stash_engine/sessions_controller.rb +++ b/app/controllers/stash_engine/sessions_controller.rb @@ -24,7 +24,9 @@ # destroy the session (ie, log ...
Fix for developer login not setting tenant correctly for testing.
diff --git a/app/observers/open_conference_ware/cache_watcher.rb b/app/observers/open_conference_ware/cache_watcher.rb index abc1234..def5678 100644 --- a/app/observers/open_conference_ware/cache_watcher.rb +++ b/app/observers/open_conference_ware/cache_watcher.rb @@ -15,7 +15,8 @@ Snippet, Track, U...
Expire cache when modifying SelectorVotes Closes #105
diff --git a/app/services/ci/create_pipeline_schedule_service.rb b/app/services/ci/create_pipeline_schedule_service.rb index abc1234..def5678 100644 --- a/app/services/ci/create_pipeline_schedule_service.rb +++ b/app/services/ci/create_pipeline_schedule_service.rb @@ -1,39 +1,13 @@ module Ci class CreatePipelineSche...
Revert extra validation for duplication between same keys on a submit
diff --git a/postmark-rails.gemspec b/postmark-rails.gemspec index abc1234..def5678 100644 --- a/postmark-rails.gemspec +++ b/postmark-rails.gemspec @@ -21,7 +21,7 @@ s.rdoc_options = ["--charset=UTF-8"] s.add_dependency('actionmailer', ">= 3.0.0") - s.add_dependency('postmark', "~> 1.15") + s.add_dependency('...
Update minimum postmark gem dependency to avoid use of TLS v1
diff --git a/hkdf.gemspec b/hkdf.gemspec index abc1234..def5678 100644 --- a/hkdf.gemspec +++ b/hkdf.gemspec @@ -13,6 +13,7 @@ s.require_paths = ['lib'] s.add_dependency 'jruby-openssl' if RUBY_PLATFORM == 'java' + s.add_development_dependency 'bundler', '~> 1.0' s.add_development_dependency 'rake', '10.1.0'...
Add bundler as a development dependency
diff --git a/.config/mdl/style.rb b/.config/mdl/style.rb index abc1234..def5678 100644 --- a/.config/mdl/style.rb +++ b/.config/mdl/style.rb @@ -1,7 +1,4 @@ all - -# Ignore front matter -ignore_front_matter true # Use MD041 instead exclude_rule 'MD002'
Move front matter config into correct place
diff --git a/jastor.podspec b/jastor.podspec index abc1234..def5678 100644 --- a/jastor.podspec +++ b/jastor.podspec @@ -3,8 +3,8 @@ s.version = "0.1.0" s.summary = "Auto translates NSDictionary to instances of Objective-C classes, supporting nested types and arrays." s.homepage = "https://github....
Fix version and pass spec lint Fix the version (sorry about that) Pass pod spec lint (add license)
diff --git a/spec/build/job/test/perl.rb b/spec/build/job/test/perl.rb index abc1234..def5678 100644 --- a/spec/build/job/test/perl.rb +++ b/spec/build/job/test/perl.rb @@ -22,5 +22,13 @@ end end end + context "when project uses neither Build.PL nor Makefile.PL" do + it 'does nothing' do + ...
Add another spec for when projects don't use EUMM or Module::Build
diff --git a/spec/classes/params_spec.rb b/spec/classes/params_spec.rb index abc1234..def5678 100644 --- a/spec/classes/params_spec.rb +++ b/spec/classes/params_spec.rb @@ -15,10 +15,8 @@ :is_pe => false, } end - it { is_expected.to contain_apache__params } - it "Should not ...
Update tests to pass with puppet 4.5 and test properly
diff --git a/spec/features/users_spec.rb b/spec/features/users_spec.rb index abc1234..def5678 100644 --- a/spec/features/users_spec.rb +++ b/spec/features/users_spec.rb @@ -8,20 +8,24 @@ click_link("Sign Up") end + subject(:fill_in_require_fields) do + user_new_password = "Pass3word:" + + fill_in "Emai...
Add Fill Require Fields Suject, User Feature Test
diff --git a/spec/models/contact_spec.rb b/spec/models/contact_spec.rb index abc1234..def5678 100644 --- a/spec/models/contact_spec.rb +++ b/spec/models/contact_spec.rb @@ -0,0 +1,63 @@+require 'spec_helper' + +describe Contact do + it "is valid with a firstname, lastname, and email" do + contact = Contact.new( + ...
Add model tests for Contacts - ERT_Rspec 03_models
diff --git a/spec/models/request_spec.rb b/spec/models/request_spec.rb index abc1234..def5678 100644 --- a/spec/models/request_spec.rb +++ b/spec/models/request_spec.rb @@ -0,0 +1,20 @@+require 'rails_helper' + +describe Request do + context "validations" do + it { should validate_presence_of :content } + it { s...
Add basic testing for the Request model. Tests include all validations and associations, but model methods have not yet been tested. This will be included in future releases.
diff --git a/bin/lib/transform_node.rb b/bin/lib/transform_node.rb index abc1234..def5678 100644 --- a/bin/lib/transform_node.rb +++ b/bin/lib/transform_node.rb @@ -10,16 +10,19 @@ # end # ``` class TransformNode < Node - def initialize(source:) + def initialize(source:, mask: nil) super(lights: source.lights)...
Add ability to mask out lights...
diff --git a/config/initializers/money.rb b/config/initializers/money.rb index abc1234..def5678 100644 --- a/config/initializers/money.rb +++ b/config/initializers/money.rb @@ -1,2 +1,2 @@ Money.rounding_mode = BigDecimal::ROUND_HALF_EVEN -Money.default_currency = Money::Currency.new('USD') +Money.default_currency = Mo...
Use the instance currency as Money's default
diff --git a/lib/growl-transfer/gt_scp.rb b/lib/growl-transfer/gt_scp.rb index abc1234..def5678 100644 --- a/lib/growl-transfer/gt_scp.rb +++ b/lib/growl-transfer/gt_scp.rb @@ -8,7 +8,7 @@ @output.puts "Downloading #{remote}" params = remote.split(":") file = params.last.split("/").last ...
Use current UNIX user, incase your name isn't Clint
diff --git a/lib/insensitive_load/list.rb b/lib/insensitive_load/list.rb index abc1234..def5678 100644 --- a/lib/insensitive_load/list.rb +++ b/lib/insensitive_load/list.rb @@ -20,10 +20,10 @@ # list def items( - *args, + path_src, absolute_path: nil, - **options) - collect...
Modify argument names a little InsensitiveLoad::List ---- - Change argument names in .items. - From '*args' to 'path_src'. - From '**options' to '**init_options'.
diff --git a/lib/lita/handlers/netping.rb b/lib/lita/handlers/netping.rb index abc1234..def5678 100644 --- a/lib/lita/handlers/netping.rb +++ b/lib/lita/handlers/netping.rb @@ -27,7 +27,8 @@ end def ping_target(host) - Net::Ping::External.new(host).ping + p = Net::Ping::External.new(host) +...
Add a shorter timeout, this should be user-accessible at some point.
diff --git a/kittenizer.gemspec b/kittenizer.gemspec index abc1234..def5678 100644 --- a/kittenizer.gemspec +++ b/kittenizer.gemspec @@ -19,6 +19,6 @@ spec.require_paths = ["lib"] spec.add_development_dependency "bundler", ">= 1.8" - spec.add_development_dependency "rake", "~> 10.0" + spec.add_development_depe...
Update rake requirement from ~> 10.0 to ~> 12.3 Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version. - [Release notes](https://github.com/ruby/rake/releases) - [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc) - [Commits](https://github.com/ruby/rake/compare/r...
diff --git a/lib/amee/v3.rb b/lib/amee/v3.rb index abc1234..def5678 100644 --- a/lib/amee/v3.rb +++ b/lib/amee/v3.rb @@ -1,7 +1,7 @@ # Copyright (C) 2008-2011 AMEE UK Ltd. - http://www.amee.com # Released as Open Source Software under the BSD 3-Clause license. See LICENSE.txt for details. -AMEE_API_VERSION = '3.3' +...
Update to use plain version 3 api, no minor version. SDK-194
diff --git a/lib/helpers.rb b/lib/helpers.rb index abc1234..def5678 100644 --- a/lib/helpers.rb +++ b/lib/helpers.rb @@ -1,6 +1,6 @@ require 'erb' require 'yaml' -require 'helpers/logger' -require 'helpers/config_file' -require 'helpers/repository' -require 'helpers/pull_requests_data' +require './lib/helpers/logger' ...
Fix require paths for individual helper files.
diff --git a/lib/verilog.rb b/lib/verilog.rb index abc1234..def5678 100644 --- a/lib/verilog.rb +++ b/lib/verilog.rb @@ -3,7 +3,7 @@ $LOAD_PATH.unshift(libdir) unless $LOAD_PATH.include?(libdir) module Verilog - VERSION = '0.0.3' + VERSION = '0.0.4' end require 'verilog/file'
Increment version number for next release
diff --git a/lib/graph/graph.rb b/lib/graph/graph.rb index abc1234..def5678 100644 --- a/lib/graph/graph.rb +++ b/lib/graph/graph.rb @@ -31,6 +31,13 @@ def remove_node(node) @nodes.delete(node) # the edges/vertices are going to have to be handled too + # that might look like iterating over all th...
Include some comments that detail a possible extension to the solution of remove_node that would also clean up the edges.
diff --git a/lib/line_parser.rb b/lib/line_parser.rb index abc1234..def5678 100644 --- a/lib/line_parser.rb +++ b/lib/line_parser.rb @@ -20,7 +20,7 @@ end { - :metric => Rufus.dsub(@metric, variables), + :name => Rufus.dsub(@metric, variables), :time => time, ...
Fix name of metric key
diff --git a/lib/simplecheck.rb b/lib/simplecheck.rb index abc1234..def5678 100644 --- a/lib/simplecheck.rb +++ b/lib/simplecheck.rb @@ -9,9 +9,7 @@ simplecheck_check_arguments( arguments ) end - if error_message - simplecheck_handle_failure( error_message ) - end...
Return true if check passed
diff --git a/lib/ditty/models/user_login_trait.rb b/lib/ditty/models/user_login_trait.rb index abc1234..def5678 100644 --- a/lib/ditty/models/user_login_trait.rb +++ b/lib/ditty/models/user_login_trait.rb @@ -11,6 +11,7 @@ def validate super + validates_presence :user_id end end end
chore: Add validation to user login trait
diff --git a/integration-tests/apps/alacarte/services/simple_service.rb b/integration-tests/apps/alacarte/services/simple_service.rb index abc1234..def5678 100644 --- a/integration-tests/apps/alacarte/services/simple_service.rb +++ b/integration-tests/apps/alacarte/services/simple_service.rb @@ -21,7 +21,7 @@ end ...
Print the injected webserver for manual verification of workingness.
diff --git a/lib/filepicker/rails/form_builder.rb b/lib/filepicker/rails/form_builder.rb index abc1234..def5678 100644 --- a/lib/filepicker/rails/form_builder.rb +++ b/lib/filepicker/rails/form_builder.rb @@ -15,7 +15,7 @@ 'data-fp-option-container' => options[:container], - 'data-fp-option-multi...
Allow data-fp-option-multiple to be specified in the options hash
diff --git a/lib/puppet/provider/vs_bridge/ovs.rb b/lib/puppet/provider/vs_bridge/ovs.rb index abc1234..def5678 100644 --- a/lib/puppet/provider/vs_bridge/ovs.rb +++ b/lib/puppet/provider/vs_bridge/ovs.rb @@ -1,7 +1,8 @@ require "puppet" Puppet::Type.type(:vs_bridge).provide(:ovs) do - optional_commands :vsctl => "...
Make sure that created bridges are brought up
diff --git a/lib/ruby_git_hooks/jira_ref_check.rb b/lib/ruby_git_hooks/jira_ref_check.rb index abc1234..def5678 100644 --- a/lib/ruby_git_hooks/jira_ref_check.rb +++ b/lib/ruby_git_hooks/jira_ref_check.rb @@ -2,8 +2,8 @@ require "ruby_git_hooks" -# This hook checks that the commit message has one or more valid Jira...
Remove reference to 'valid' ticket since we don't check validity SYSINT-5460
diff --git a/app/models/secret.rb b/app/models/secret.rb index abc1234..def5678 100644 --- a/app/models/secret.rb +++ b/app/models/secret.rb @@ -2,7 +2,8 @@ validates :address, presence: true validates :message, presence: true validates :song, format: { with: /.*soundcloud.*/, - message: "must use a valid sou...
Allow song to be blank
diff --git a/lib/expando.rb b/lib/expando.rb index abc1234..def5678 100644 --- a/lib/expando.rb +++ b/lib/expando.rb @@ -1,6 +1,6 @@ require 'dry-initializer' require 'dry-types' -require 'api-ai-ruby' +require 'voxable-api-ai-ruby' require 'colorize' require 'awesome_print'
Use forked version of ApiAiRuby client gem