diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/kckstrt.rb b/lib/kckstrt.rb index abc1234..def5678 100644 --- a/lib/kckstrt.rb +++ b/lib/kckstrt.rb @@ -20,23 +20,26 @@ c.switch [:f, :force] c.action do |global_options, options, args| - forced = global_options[:force] || options[:force] - generate_app(args.first, forced) + @...
Use global `@options` instead of parameters
diff --git a/myprecious.gemspec b/myprecious.gemspec index abc1234..def5678 100644 --- a/myprecious.gemspec +++ b/myprecious.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = 'myprecious' - s.version = '0.0.4' + s.version = '0.0.6' s.date = '2017-04-26' s.summary = "You...
Add runtime dependencies to gem spec file
diff --git a/lib/lyricfy.rb b/lib/lyricfy.rb index abc1234..def5678 100644 --- a/lib/lyricfy.rb +++ b/lib/lyricfy.rb @@ -18,7 +18,7 @@ metro_lyrics: MetroLyrics } - if !args.empty? + unless args.empty? passed_providers = {} args.each do |provider| raise Exception ...
Use unless for more idiomatic condition in Lyricfy::Fetcher
diff --git a/test/models/tasks_test.rb b/test/models/tasks_test.rb index abc1234..def5678 100644 --- a/test/models/tasks_test.rb +++ b/test/models/tasks_test.rb @@ -1,7 +1,20 @@ require 'test_helper' class TasksTest < ActiveSupport::TestCase - # test "the truth" do - # assert true - # end + + test "should not ...
Add unit tests to task model.
diff --git a/obtuse.gemspec b/obtuse.gemspec index abc1234..def5678 100644 --- a/obtuse.gemspec +++ b/obtuse.gemspec @@ -8,9 +8,11 @@ gem.version = Obtuse::VERSION gem.authors = ["Utkarsh Kukreti"] gem.email = ["utkarshkukreti@gmail.com"] - gem.description = %q{TODO: Write a gem descripti...
Add description, summary, and homepage in the gemspec.
diff --git a/test/test_deprecations.rb b/test/test_deprecations.rb index abc1234..def5678 100644 --- a/test/test_deprecations.rb +++ b/test/test_deprecations.rb @@ -2,6 +2,10 @@ class TestDeprecations < Test::Unit::TestCase context "with Gelf object" do + should "fail" do + flunk "Hello Hudson!" + end +...
Break gem test to test Hudson.
diff --git a/lib/day08.rb b/lib/day08.rb index abc1234..def5678 100644 --- a/lib/day08.rb +++ b/lib/day08.rb @@ -5,20 +5,21 @@ end def escape_overhead(escaped_string) - result = 2 - result += escaped_string.scan(/\\\\/).size - result += escaped_string.scan(/\\"/).size - result += escaped_string.scan(/\\x[a-f0-9]...
Simplify day 8 a bit.
diff --git a/tty-tree.gemspec b/tty-tree.gemspec index abc1234..def5678 100644 --- a/tty-tree.gemspec +++ b/tty-tree.gemspec @@ -6,7 +6,7 @@ spec.name = "tty-tree" spec.version = TTY::Tree::VERSION spec.authors = ["Piotr Murach"] - spec.email = [""] + spec.email = ["me@pio...
Change to relax dev deps
diff --git a/lib/title.rb b/lib/title.rb index abc1234..def5678 100644 --- a/lib/title.rb +++ b/lib/title.rb @@ -1,3 +1,6 @@+app = File.expand_path('../../app', __FILE__) +$LOAD_PATH.unshift(app) unless $LOAD_PATH.include?(app) + require 'title/version' require 'rails/engine' require 'title/engine'
Add app back into load path I bet this is an API change in Rails sometime but this is an easy fix. Maybe I'll come back to it later.
diff --git a/ruby_event_store/spec/actions/delete_stream_events_spec.rb b/ruby_event_store/spec/actions/delete_stream_events_spec.rb index abc1234..def5678 100644 --- a/ruby_event_store/spec/actions/delete_stream_events_spec.rb +++ b/ruby_event_store/spec/actions/delete_stream_events_spec.rb @@ -2,7 +2,6 @@ module Ru...
Remove unused let var in client spec
diff --git a/workable.gemspec b/workable.gemspec index abc1234..def5678 100644 --- a/workable.gemspec +++ b/workable.gemspec @@ -23,6 +23,4 @@ spec.add_development_dependency 'rspec', '~> 3.1.0' spec.add_development_dependency 'webmock', '~> 1.20.4' spec.add_development_dependency 'coveralls', '~> 0.8.9' - spe...
Make guard a soft dev-dependency
diff --git a/db/migrate/20130220162840_add_document_type_and_slug_to_unpublishings.rb b/db/migrate/20130220162840_add_document_type_and_slug_to_unpublishings.rb index abc1234..def5678 100644 --- a/db/migrate/20130220162840_add_document_type_and_slug_to_unpublishings.rb +++ b/db/migrate/20130220162840_add_document_type_...
Correct slugs and edition types for existing unpublishings The few existing unpublishings had lost the information about the original url, because the title of the last edition has been changed.
diff --git a/recipes/deb.rb b/recipes/deb.rb index abc1234..def5678 100644 --- a/recipes/deb.rb +++ b/recipes/deb.rb @@ -11,3 +11,12 @@ dpkg_package "#{Chef::Config[:file_cache_path]}/#{filename}" do action :install end + +ruby_block "Set heap size in /etc/default/elasticsearch" do + block do + fe = Chef::Util:...
Use the heap size set in Chef via /etc/default/elasticsearch
diff --git a/has_breadcrumb.gemspec b/has_breadcrumb.gemspec index abc1234..def5678 100644 --- a/has_breadcrumb.gemspec +++ b/has_breadcrumb.gemspec @@ -6,7 +6,7 @@ Gem::Specification.new do |gem| gem.name = "has_breadcrumb" gem.version = HasBreadcrumb::VERSION - gem.authors = ["Tim Harvey"]...
Add Matt Outten to the authors in gemspec This commit adds Matt as an author to this gem as he and Tim were the original coders on the project.
diff --git a/spec/omniauth/strategies/madmimi_spec.rb b/spec/omniauth/strategies/madmimi_spec.rb index abc1234..def5678 100644 --- a/spec/omniauth/strategies/madmimi_spec.rb +++ b/spec/omniauth/strategies/madmimi_spec.rb @@ -16,7 +16,7 @@ end it 'should have correct site' do - subject.options.client_opt...
Fix test for default site location
diff --git a/app/controllers/physical_infra_topology_controller.rb b/app/controllers/physical_infra_topology_controller.rb index abc1234..def5678 100644 --- a/app/controllers/physical_infra_topology_controller.rb +++ b/app/controllers/physical_infra_topology_controller.rb @@ -2,5 +2,5 @@ @layout = "physical_infra_top...
Fix menu selection when on physical infra topology view
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index abc1234..def5678 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -1,4 +1,45 @@ require 'rails_helper' describe User do + subject(:user) { build :user } + + describe '#full_name' do + it 'returns the full name' do + ...
Add some examples for the user.
diff --git a/test/integration/ebs/serverspec/default_spec.rb b/test/integration/ebs/serverspec/default_spec.rb index abc1234..def5678 100644 --- a/test/integration/ebs/serverspec/default_spec.rb +++ b/test/integration/ebs/serverspec/default_spec.rb @@ -1,19 +1,15 @@ require 'spec_helper' describe 'LVM Pool' do - { ...
Remove unnecessary loop code from ebs test
diff --git a/spec/unit/spec_helper.rb b/spec/unit/spec_helper.rb index abc1234..def5678 100644 --- a/spec/unit/spec_helper.rb +++ b/spec/unit/spec_helper.rb @@ -19,4 +19,5 @@ end Itamae::Logger.log_device = StringIO.new +Specinfra.configuration.error_on_missing_backend_type = false
Set error_on_missing_backend_type false in unit tests.
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -23,11 +23,11 @@ ControlGroups.config_struct_init(node) ControlGroups.rules_struct_init(node) c = Chef::Resource::File.new('/etc/cgconfig.conf', run_context) - c.conte...
Update to use run state over node attributes
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -30,14 +30,15 @@ end gunicorn do - only_if { node['roles'].include? 'ganeti_web_application_server' } - app_module "ganeti_web" - port 8000 + only_if { node['roles']...
Change ports, and role names
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -18,7 +18,7 @@ # limitations under the License. # -Chef::Log.info("Chef Handlers will be located at: #{node['chef_handler']['handler_path']}") +Chef::Log.debug("Chef Handlers will b...
Reduce handler location log level to debug
diff --git a/recipes/install.rb b/recipes/install.rb index abc1234..def5678 100644 --- a/recipes/install.rb +++ b/recipes/install.rb @@ -22,6 +22,6 @@ include_recipe 'apt' end -include_recipe 'yum::epel' if node['platform_family'] == 'rhel' +include_recipe 'yum-epel' if node['platform_family'] == 'rhel' package...
Use yum-epel default recipe not yum::epel.
diff --git a/lib/browserstack.rb b/lib/browserstack.rb index abc1234..def5678 100644 --- a/lib/browserstack.rb +++ b/lib/browserstack.rb @@ -13,7 +13,10 @@ def snapshot(url) driver = Selenium::WebDriver.for(:remote, :url => get_url, - :desired_capabilities => Selenium::WebDriver::Remote::Capabilities...
Set a project name in Browserstack so we can tell what is taking a snapshot.
diff --git a/lib/dimples/post.rb b/lib/dimples/post.rb index abc1234..def5678 100644 --- a/lib/dimples/post.rb +++ b/lib/dimples/post.rb @@ -12,11 +12,8 @@ @metadata[:layout] ||= @site.config.layouts.post @metadata[:date] = Date.new(parts[1].to_i, parts[2].to_i, parts[3].to_i) - @metadata[:year] = @...
Remove the date parts and set a default empty categories array
diff --git a/resources/check.rb b/resources/check.rb index abc1234..def5678 100644 --- a/resources/check.rb +++ b/resources/check.rb @@ -28,8 +28,8 @@ # Name of the nrpe check, used for the filename and the command name attribute :command_name, :kind_of => String, :name_attribute => true -attribute :warning_conditio...
Allow warning/critical condition in LRWP to be both Int/String
diff --git a/Casks/corsixth.rb b/Casks/corsixth.rb index abc1234..def5678 100644 --- a/Casks/corsixth.rb +++ b/Casks/corsixth.rb @@ -8,5 +8,7 @@ homepage 'https://github.com/CorsixTH/CorsixTH' license :mit - app 'CorsixTH.app' + app 'CorsixTH/CorsixTH.app' + app 'CorsixTH/AnimView.app' + app 'CorsixTH/MapEdi...
Fix path to CorsixTH app
diff --git a/app/controllers/letter_opener_web/application_controller.rb b/app/controllers/letter_opener_web/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/letter_opener_web/application_controller.rb +++ b/app/controllers/letter_opener_web/application_controller.rb @@ -2,5 +2,6 @@ modul...
Add Rails' built-in CSRF protection
diff --git a/app/controllers/publications/users/categories_controller.rb b/app/controllers/publications/users/categories_controller.rb index abc1234..def5678 100644 --- a/app/controllers/publications/users/categories_controller.rb +++ b/app/controllers/publications/users/categories_controller.rb @@ -2,6 +2,6 @@ def s...
Hide invisible posts in user categories
diff --git a/GPActivityViewController.podspec b/GPActivityViewController.podspec index abc1234..def5678 100644 --- a/GPActivityViewController.podspec +++ b/GPActivityViewController.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'GPActivityViewController' - s.version = '1.3.1' + s.version = '1...
Update facebook dependency to restore compilation on iOS5
diff --git a/lib/gollum-lib/macro/note.rb b/lib/gollum-lib/macro/note.rb index abc1234..def5678 100644 --- a/lib/gollum-lib/macro/note.rb +++ b/lib/gollum-lib/macro/note.rb @@ -1,10 +1,18 @@ module Gollum class Macro class Note < Gollum::Macro - def render(notice) - icon = Octicons::Octicon.new('inf...
Extend Note() macro with optional arg for changing the octicon.
diff --git a/lib/identity/cookie_coder.rb b/lib/identity/cookie_coder.rb index abc1234..def5678 100644 --- a/lib/identity/cookie_coder.rb +++ b/lib/identity/cookie_coder.rb @@ -11,7 +11,7 @@ end def encode(payload) - payload = JSON.parse(JSON.generate(payload)) # make sure all keys are string + pay...
Return nil when verifier is invalid
diff --git a/lib/marconiclient/logging.rb b/lib/marconiclient/logging.rb index abc1234..def5678 100644 --- a/lib/marconiclient/logging.rb +++ b/lib/marconiclient/logging.rb @@ -0,0 +1,21 @@+require 'logger' + +module Logging + def logger + @logger ||= Logging.logger_for(self.class.name) + end + + @loggers = {} + ...
Add core transport. create/delete/exists for queues.
diff --git a/lib/last_hit/cli.rb b/lib/last_hit/cli.rb index abc1234..def5678 100644 --- a/lib/last_hit/cli.rb +++ b/lib/last_hit/cli.rb @@ -2,6 +2,8 @@ require 'yaml' class LastHit + class FileNotFound < StandardError; end + class Cli < Thor CONFIG_PATH = '~/last_hit.yml' @@ -9,8 +11,11 @@ class <<...
Raise error when file not found
diff --git a/lib/scaffolder/tool_index.rb b/lib/scaffolder/tool_index.rb index abc1234..def5678 100644 --- a/lib/scaffolder/tool_index.rb +++ b/lib/scaffolder/tool_index.rb @@ -5,6 +5,10 @@ def normalise(name) name.to_s.downcase.to_sym if name + end + + def fetch_tool_class(name) + tools[normalise(name)] ...
Remove tool class name method
diff --git a/lib/rails_ui_kit.rb b/lib/rails_ui_kit.rb index abc1234..def5678 100644 --- a/lib/rails_ui_kit.rb +++ b/lib/rails_ui_kit.rb @@ -1,5 +1,10 @@ require 'rails_ui_kit/engine' -require 'faker' + +if Gem::Specification.find_all_by_name('ffaker').any? + require 'ffaker' unless defined?(Faker) +else + require 'f...
Use ffaker gem if it exist in bundle to avoid collision with faker gem. (ffaker gem, for example, used in spree)
diff --git a/app/helpers/budgets_helper.rb b/app/helpers/budgets_helper.rb index abc1234..def5678 100644 --- a/app/helpers/budgets_helper.rb +++ b/app/helpers/budgets_helper.rb @@ -42,4 +42,9 @@ def investment_tags_select_options Budget::Investment.tags_on(:valuation).order(:name).select(:name).distinct end +...
Add budget_published? helper method to BudgetHelper We need to check if the budget is in drafting phase to avoid showing it to the users, unless the current user is an administrator.
diff --git a/app/models/frontend_router.rb b/app/models/frontend_router.rb index abc1234..def5678 100644 --- a/app/models/frontend_router.rb +++ b/app/models/frontend_router.rb @@ -36,6 +36,8 @@ [ SuggestedChange, :id ] when /assertions?/ [ Assertion, :id ] + when /allele_registry/ + [ Variant...
Add direct link to variants by allele registry id
diff --git a/spec/shexec/executor_spec.rb b/spec/shexec/executor_spec.rb index abc1234..def5678 100644 --- a/spec/shexec/executor_spec.rb +++ b/spec/shexec/executor_spec.rb @@ -1,12 +1,5 @@ require 'spec_helper' require 'stringio' - -# TODO Check whether rspec's output matcher has become thread-safe. -# It would be wo...
Use rspec's new _from_any_process output modifiers
diff --git a/test/apps/queue_wait.ru b/test/apps/queue_wait.ru index abc1234..def5678 100644 --- a/test/apps/queue_wait.ru +++ b/test/apps/queue_wait.ru @@ -24,7 +24,7 @@ env['HTTP_X_REQUEST_START'] = "t=#{(Time.now.to_f * 1000000).to_i}".to_s sleep 0.02 when '/with_period' - env['HTTP_X_REQUEST_...
Remove unneeded cast to float
diff --git a/spec/spec_helper/fixtures.rb b/spec/spec_helper/fixtures.rb index abc1234..def5678 100644 --- a/spec/spec_helper/fixtures.rb +++ b/spec/spec_helper/fixtures.rb @@ -7,6 +7,7 @@ class Command < CLAide::Command self.command = 'bin' + self.ansi_output = false class SpecFile < Command ...
[Specs] Disable ANSI in fixture classes
diff --git a/src/bosh-template/bosh-template.gemspec b/src/bosh-template/bosh-template.gemspec index abc1234..def5678 100644 --- a/src/bosh-template/bosh-template.gemspec +++ b/src/bosh-template/bosh-template.gemspec @@ -10,7 +10,7 @@ spec.author = 'Pivotal' spec.email = 'support@cloudfoundry.com' ...
Fix the license string in the gemspec. [#150502401](https://www.pivotaltracker.com/story/show/150502401) Signed-off-by: Luan Santos <509a85c757dc22c0257f4655fb3fb682d42f965b@pivotal.io>
diff --git a/test/url_for_test.rb b/test/url_for_test.rb index abc1234..def5678 100644 --- a/test/url_for_test.rb +++ b/test/url_for_test.rb @@ -5,7 +5,7 @@ class UrlForTest < MiniTest::Unit::TestCase module UrlFor def url_for(*args) - @actual = args + args end end @@ -13,27 +13,27 @@ incl...
Set ivar outside the method
diff --git a/rack-cloudflare_ip.gemspec b/rack-cloudflare_ip.gemspec index abc1234..def5678 100644 --- a/rack-cloudflare_ip.gemspec +++ b/rack-cloudflare_ip.gemspec @@ -7,8 +7,8 @@ spec.version = "1.0.0" spec.authors = ["Pip Taylor"] spec.email = ["pip@evilgeek.co.uk"] - spec.summary ...
Add summary and homepage to gemspec.
diff --git a/spec/helper.rb b/spec/helper.rb index abc1234..def5678 100644 --- a/spec/helper.rb +++ b/spec/helper.rb @@ -8,7 +8,7 @@ SimpleCov.formatters = [SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter] SimpleCov.start do - minimum_coverage(76) + minimum_coverage(78.48) end end ...
Increase minimum code coverage percentage
diff --git a/config/initializers/github.rb b/config/initializers/github.rb index abc1234..def5678 100644 --- a/config/initializers/github.rb +++ b/config/initializers/github.rb @@ -1,2 +1,2 @@-GITHUB = Github.new(:oauth_token => "...") +GITHUB = Github.new(:oauth_token => nil) # Add a token to access private repos GIT...
Create GitHub client with no auth token
diff --git a/config/initializers/refile.rb b/config/initializers/refile.rb index abc1234..def5678 100644 --- a/config/initializers/refile.rb +++ b/config/initializers/refile.rb @@ -5,6 +5,11 @@ Refile.automount = false Rails.application.routes.prepend do mount Refile.app, at: Refile.mount_point, as: :refile_app +en...
Use a CDN if the host application has one configured
diff --git a/app/decorators/user_decorator.rb b/app/decorators/user_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/user_decorator.rb +++ b/app/decorators/user_decorator.rb @@ -22,7 +22,7 @@ end def link - author_path(object) + author_path(object.id) end def link_tag
Use user ID to avoid nil errors on to_param Honestly no idea why this keeps popping up only on Travis. Just doing this to trigger clearer nil errors if object is somehow nil.
diff --git a/app/helpers/imageables_helper.rb b/app/helpers/imageables_helper.rb index abc1234..def5678 100644 --- a/app/helpers/imageables_helper.rb +++ b/app/helpers/imageables_helper.rb @@ -4,11 +4,7 @@ end def imageable_max_file_size - bytes_to_megabytes(Setting["uploads.images.max_size"].to_i.megabytes) ...
Simplify method to check an image max size We were converting megabytes to bytes with the `megabytes` method and then adding a `bytes_to_megabytes` method to convert it back to bytes, which is the same as not doing anything at all :).
diff --git a/app/helpers/serializer_helper.rb b/app/helpers/serializer_helper.rb index abc1234..def5678 100644 --- a/app/helpers/serializer_helper.rb +++ b/app/helpers/serializer_helper.rb @@ -13,4 +13,11 @@ (serializer_attributes & model_attributes).map { |attr| "#{model.table_name}.#{attr}" } end + + # Sinc...
Add helper method for correctly generating with fingerprints in Serializers
diff --git a/current_user.gemspec b/current_user.gemspec index abc1234..def5678 100644 --- a/current_user.gemspec +++ b/current_user.gemspec @@ -21,8 +21,7 @@ s.extra_rdoc_files = ["README.md"] s.test_files = Dir["test/**/*"] - #s.add_dependency "rails", ">= 3.2.6", "< 5" - s.add_dependency "rails", "4.0.0" + ...
Declare support 4 Rails 4
diff --git a/config/unicorn.rb b/config/unicorn.rb index abc1234..def5678 100644 --- a/config/unicorn.rb +++ b/config/unicorn.rb @@ -1,11 +1,3 @@ require "govuk_app_config" GovukUnicorn.configure(self) - -GovukError.configure do |config| - config.data_sync_excluded_exceptions += [ - "PG::UndefinedTable", - "Act...
Revert "Explitly ignore UndefinedTable and StatementInvalid exceptions"
diff --git a/config/requirements.rb b/config/requirements.rb index abc1234..def5678 100644 --- a/config/requirements.rb +++ b/config/requirements.rb @@ -2,7 +2,7 @@ include FileUtils require 'rubygems' -%w[rake hoe newgem rubigen actionpack activesupport].each do |req_gem| +%w[rake hoe newgem rubigen activesupport a...
Swap load order of activesupport and action pack.\nThis is not technically required but it causes them to load in the actual order they are required.
diff --git a/gtm-oauth2-thekey.podspec b/gtm-oauth2-thekey.podspec index abc1234..def5678 100644 --- a/gtm-oauth2-thekey.podspec +++ b/gtm-oauth2-thekey.podspec @@ -1,11 +1,11 @@ Pod::Spec.new do |s| s.name = "gtm-oauth2-thekey" - s.version = "1.0.118" + s.version = "1.0.120" s.summary = ...
Increment version to 1.0.120, based on SVN r120
diff --git a/sql_tagger.gemspec b/sql_tagger.gemspec index abc1234..def5678 100644 --- a/sql_tagger.gemspec +++ b/sql_tagger.gemspec @@ -7,7 +7,7 @@ s.description = 'sql_tagger inserts stack trace comments into SQL queries.' s.license = 'MIT' - s.add_development_dependency('rspec', '~> 2.11') + s.add_developme...
Upgrade rspec to '~> 3.4'
diff --git a/lib/chef_zero/endpoints/containers_endpoint.rb b/lib/chef_zero/endpoints/containers_endpoint.rb index abc1234..def5678 100644 --- a/lib/chef_zero/endpoints/containers_endpoint.rb +++ b/lib/chef_zero/endpoints/containers_endpoint.rb @@ -8,6 +8,19 @@ def initialize(server) super(server, %w(id ...
Implement POST /containers to create a container with the given 'id' or 'container_name'.
diff --git a/lib/usesthis/api/generators/stats_generator.rb b/lib/usesthis/api/generators/stats_generator.rb index abc1234..def5678 100644 --- a/lib/usesthis/api/generators/stats_generator.rb +++ b/lib/usesthis/api/generators/stats_generator.rb @@ -0,0 +1,51 @@+# frozen_string_literal: true + +module UsesThis + module...
Add the stats API generator
diff --git a/config/initializers/dragonfly.rb b/config/initializers/dragonfly.rb index abc1234..def5678 100644 --- a/config/initializers/dragonfly.rb +++ b/config/initializers/dragonfly.rb @@ -9,3 +9,6 @@ ActiveRecord::Base.extend Dragonfly::Model ActiveRecord::Base.extend Dragonfly::Model::Validations end + +# D...
Allow flatten as argument for Dragonfly encode Dragonfly 1.4.0 does not allow flatten as argument to encode.
diff --git a/config/initializers/redcarpet.rb b/config/initializers/redcarpet.rb index abc1234..def5678 100644 --- a/config/initializers/redcarpet.rb +++ b/config/initializers/redcarpet.rb @@ -38,5 +38,9 @@ readme_markdown.gsub! \ /(?<=\<a )href="(?!http)/, link_sub_string + readme_markdown.gsub! \ + (/(hr...
Make readme link parsing more robust for markdown
diff --git a/test/models/account_test.rb b/test/models/account_test.rb index abc1234..def5678 100644 --- a/test/models/account_test.rb +++ b/test/models/account_test.rb @@ -4,4 +4,8 @@ # test "the truth" do # assert true # end + test "should not save account without url" do + account = Account.new + as...
Add a test for account model
diff --git a/test/variable_mixin_test.rb b/test/variable_mixin_test.rb index abc1234..def5678 100644 --- a/test/variable_mixin_test.rb +++ b/test/variable_mixin_test.rb @@ -9,7 +9,7 @@ site.compile assert_equal NanocConrefFS::Variables.variables[:default].keys, ['site'] - assert_equal NanocConrefFS:...
Sort keys found for comparison.
diff --git a/app/admin/webhooks.rb b/app/admin/webhooks.rb index abc1234..def5678 100644 --- a/app/admin/webhooks.rb +++ b/app/admin/webhooks.rb @@ -0,0 +1,57 @@+ActiveAdmin.register Webhook do + + controller do + def create + @webhook = Webhook.new(webhook_params) + if @webhook.save + redirect_to ...
Add slack webhook admin panel
diff --git a/app/models/comment.rb b/app/models/comment.rb index abc1234..def5678 100644 --- a/app/models/comment.rb +++ b/app/models/comment.rb @@ -11,6 +11,30 @@ # Comment model class Comment < ActiveRecord::Base - belongs_to :Glsa, :class_name => "Glsa", :foreign_key => "glsa_id" + belongs_to :glsa, :class_name...
Comment: Apply permission checking as validations
diff --git a/lib/generators/active_record/templates/migration.rb b/lib/generators/active_record/templates/migration.rb index abc1234..def5678 100644 --- a/lib/generators/active_record/templates/migration.rb +++ b/lib/generators/active_record/templates/migration.rb @@ -23,7 +23,7 @@ def down change_table :<%= tab...
Remove invitations_count on inviteable drop invitations_count was not removed when rolling back the inviteable migration
diff --git a/Casks/jawbone-updater.rb b/Casks/jawbone-updater.rb index abc1234..def5678 100644 --- a/Casks/jawbone-updater.rb +++ b/Casks/jawbone-updater.rb @@ -2,6 +2,6 @@ url 'http://content.jawbone.com/store/dashboard/Jawbone_Updater-2.2.3.pkg' homepage 'http://jawbone.com/' version '2.2.3' - sha1 'f729fc0d...
Update jawbone updater to sha 256
diff --git a/tinyrpn/rpn.rb b/tinyrpn/rpn.rb index abc1234..def5678 100644 --- a/tinyrpn/rpn.rb +++ b/tinyrpn/rpn.rb @@ -15,4 +15,4 @@ a end -puts rpn('10.2 2 + 14 - 4 + 2 ^') +puts rpn('10 2 + 14 - 4 + 2 ^ 0.2 +')
Add a test for floats and such.
diff --git a/lib/airbrush/processors/image/rmagick.rb b/lib/airbrush/processors/image/rmagick.rb index abc1234..def5678 100644 --- a/lib/airbrush/processors/image/rmagick.rb +++ b/lib/airbrush/processors/image/rmagick.rb @@ -36,7 +36,7 @@ end def purify_image(image) - system ...
Comment out call to jhead for the moment, since it requires a saved version of the file on disk. git-svn-id: 6d9b9a8f21f96071dc3ac7ff320f08f2a342ec80@69 daa9635f-4444-0410-9b3d-b8c75a019348
diff --git a/lib/decent_exposure/constant_resolver.rb b/lib/decent_exposure/constant_resolver.rb index abc1234..def5678 100644 --- a/lib/decent_exposure/constant_resolver.rb +++ b/lib/decent_exposure/constant_resolver.rb @@ -26,7 +26,9 @@ def namespace path = context.to_s - path[0...(path.rindex('::')...
Fix 'wrong constant name' error (Rails 4.1.0beta1)
diff --git a/pronto-reek.gemspec b/pronto-reek.gemspec index abc1234..def5678 100644 --- a/pronto-reek.gemspec +++ b/pronto-reek.gemspec @@ -20,7 +20,7 @@ s.require_paths = ['lib'] s.add_dependency 'pronto', '~> 0.4.0' - s.add_dependency 'reek', '~> 2.0' + s.add_dependency 'reek', '~> 2.2.1' s.add_developme...
Update and tighten reek dependency
diff --git a/actionview/lib/action_view/template/types.rb b/actionview/lib/action_view/template/types.rb index abc1234..def5678 100644 --- a/actionview/lib/action_view/template/types.rb +++ b/actionview/lib/action_view/template/types.rb @@ -5,7 +5,7 @@ class Template class Types class Type - SET = ...
Store the symbols as an array. A Set can't be implicitly converted into an Array: ``` irb(main):012:0> formats = [ :rss ] => [:rss] irb(main):013:0> formats &= SET.symbols TypeError: no implicit conversion of Set into Array from (irb):13:in `&' from (irb):13 from /Users/kasperhansen/.rbenv/versions/2.2.3/...
diff --git a/app/models/calendar_item_reminder_pending.rb b/app/models/calendar_item_reminder_pending.rb index abc1234..def5678 100644 --- a/app/models/calendar_item_reminder_pending.rb +++ b/app/models/calendar_item_reminder_pending.rb @@ -6,12 +6,14 @@ belongs_to :calendar def self.pending_items(user, calendar...
Sort due calendar items on homepage
diff --git a/rails_admin.gemspec b/rails_admin.gemspec index abc1234..def5678 100644 --- a/rails_admin.gemspec +++ b/rails_admin.gemspec @@ -0,0 +1,27 @@+# -*- encoding: utf-8 -*- +require File.expand_path('../lib/rails_admin/version', __FILE__) + +Gem::Specification.new do |s| + s.add_development_dependency('devise',...
Remove calls to git from gemspec for Windows compatibility Closes #85 Closes #170 Closes #171
diff --git a/rakelib/readme.rake b/rakelib/readme.rake index abc1234..def5678 100644 --- a/rakelib/readme.rake +++ b/rakelib/readme.rake @@ -1,19 +1,25 @@ #!/usr/bin/env ruby -require 'redcloth' +begin + require 'redcloth' + directory "html" -directory "html" + desc "Display the README file" + task :readme => "...
Allow rakefile to run w/o RedCloth. Only complain about missing redcloth if we try to run the readme task.
diff --git a/lib/hdo/storting_importer/data_source.rb b/lib/hdo/storting_importer/data_source.rb index abc1234..def5678 100644 --- a/lib/hdo/storting_importer/data_source.rb +++ b/lib/hdo/storting_importer/data_source.rb @@ -5,7 +5,7 @@ class NotFoundError < StandardError end - DEFAULT_SESSION = '20...
Change the default session. We should remove this altogether eventually.
diff --git a/lib/lita/rspec/matchers/route_matcher.rb b/lib/lita/rspec/matchers/route_matcher.rb index abc1234..def5678 100644 --- a/lib/lita/rspec/matchers/route_matcher.rb +++ b/lib/lita/rspec/matchers/route_matcher.rb @@ -3,10 +3,14 @@ module Matchers # Used to complete a chat routing test chain. c...
Set example description for chat routes.
diff --git a/lib/models/badges/answers/nice_answer.rb b/lib/models/badges/answers/nice_answer.rb index abc1234..def5678 100644 --- a/lib/models/badges/answers/nice_answer.rb +++ b/lib/models/badges/answers/nice_answer.rb @@ -13,19 +13,21 @@ sort: 'votes', order: 'desc', pagesize: 1, + filter: '...
Add link to answer in NiceAnswer's progress_description
diff --git a/attributes/default.rb b/attributes/default.rb index abc1234..def5678 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -1,2 +1,2 @@ # Must correspond to a valid release here https://github.com/facebook/watchman/releases -default['watchman']['version'] = 'v3.0.0' +default['watchman']['versio...
Use Most Recent Watchman Version
diff --git a/sandbox/dev/cookbooks/atmessager/recipes/default.rb b/sandbox/dev/cookbooks/atmessager/recipes/default.rb index abc1234..def5678 100644 --- a/sandbox/dev/cookbooks/atmessager/recipes/default.rb +++ b/sandbox/dev/cookbooks/atmessager/recipes/default.rb @@ -1,19 +1,27 @@ remote_file '/tmp/nodejs.deb' do - ...
Add Install forever, create log file folder and remove start app part
diff --git a/spec/mobility/plugins/fallthrough_accessors_spec.rb b/spec/mobility/plugins/fallthrough_accessors_spec.rb index abc1234..def5678 100644 --- a/spec/mobility/plugins/fallthrough_accessors_spec.rb +++ b/spec/mobility/plugins/fallthrough_accessors_spec.rb @@ -18,6 +18,7 @@ end end + model...
Fix test so it fails when options not correctly passed to super
diff --git a/test/models/product_test.rb b/test/models/product_test.rb index abc1234..def5678 100644 --- a/test/models/product_test.rb +++ b/test/models/product_test.rb @@ -1,7 +1,13 @@ require 'test_helper' class ProductTest < ActiveSupport::TestCase - # test "the truth" do - # assert true - # end + test "pro...
Add model test for Product properties
diff --git a/test/models/rss_log_test.rb b/test/models/rss_log_test.rb index abc1234..def5678 100644 --- a/test/models/rss_log_test.rb +++ b/test/models/rss_log_test.rb @@ -3,6 +3,10 @@ require("test_helper") class RssLogTest < UnitTestCase + # Alert developer if normalization changes the path of an RssLogg'ed obje...
Add comment about purpose of test
diff --git a/Casks/browserstacklocal.rb b/Casks/browserstacklocal.rb index abc1234..def5678 100644 --- a/Casks/browserstacklocal.rb +++ b/Casks/browserstacklocal.rb @@ -5,7 +5,7 @@ url 'https://www.browserstack.com/browserstack-local/BrowserStackLocal-darwin-x64.zip' name 'BrowserStack' name 'BrowserStack Local...
Fix homepage to use SSL in BrowserStack Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/Casks/transporter-desktop.rb b/Casks/transporter-desktop.rb index abc1234..def5678 100644 --- a/Casks/transporter-desktop.rb +++ b/Casks/transporter-desktop.rb @@ -1,6 +1,6 @@ cask :v1 => 'transporter-desktop' do - version '4.0.8_19845' - sha256 '9d8d0606286a4baa1a3fc4df4bad64e879cb434766f6d4466c0d3a8ec8...
Update Transporter Desktop to version 4.1.5_20060 This commit updates the version and sha256 stanzas.
diff --git a/GNContextManager.podspec b/GNContextManager.podspec index abc1234..def5678 100644 --- a/GNContextManager.podspec +++ b/GNContextManager.podspec @@ -8,8 +8,8 @@ s.homepage = "https://github.com/jakubknejzlik/GNContextManager" s.license = { :type => "MIT", :file => "LICENSE" } s.author ...
Fix platforms in cocoapods spec
diff --git a/test/tc_send_incremental.rb b/test/tc_send_incremental.rb index abc1234..def5678 100644 --- a/test/tc_send_incremental.rb +++ b/test/tc_send_incremental.rb @@ -5,7 +5,7 @@ file = "data/noyes/noyes.flac" to_server = StringIO.new 'wb' from_server = StringIO.new 'dummy result' - result = send...
Send test now reflects additional parameters to incremental send.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -14,6 +14,15 @@ devise_parameter_sanitizer.for(:sign_up) << [{adresses_attributes: [:id,...
FIX : prise en compte de la gestion de la méthode current_user pour l'application native.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,8 +1,13 @@ class ApplicationController < ActionController::Base protect_from_forgery ...
Store the current user in the thread to allow us to capture that in various models
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -23,8 +23,13 @@ end def current_applicant - if user_signed_in? and not session[:cu...
Check for RecordNotFound in current_applicant This tends to happen when old cookies are left around when reseeding the database.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -10,11 +10,15 @@ before_action :configure_permitted_parameters, if: :devise_controller? ...
Update sanitizer options to new devise
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -4,15 +4,19 @@ protect_from_forgery with: :exception include SessionsHelper # before...
Add profiler info to prod
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -17,6 +17,6 @@ end def set_page_caching - @page_caching = true + @page_caching ...
Enable page caching based on perform_caching setting
diff --git a/lib/dugway/application.rb b/lib/dugway/application.rb index abc1234..def5678 100644 --- a/lib/dugway/application.rb +++ b/lib/dugway/application.rb @@ -26,8 +26,8 @@ def find_template(request) if template = @theme.find_template_by_request(request) template - elsif page = @store.pag...
Clarify that these are custom pages
diff --git a/lib/her/json_api/model.rb b/lib/her/json_api/model.rb index abc1234..def5678 100644 --- a/lib/her/json_api/model.rb +++ b/lib/her/json_api/model.rb @@ -13,7 +13,7 @@ end def self.to_params(attributes, changes={}) - request_data = { type: 'users' }.tap { |request_body| + ...
Determine type from class name
diff --git a/app/services/dropped_attributes_setter.rb b/app/services/dropped_attributes_setter.rb index abc1234..def5678 100644 --- a/app/services/dropped_attributes_setter.rb +++ b/app/services/dropped_attributes_setter.rb @@ -19,8 +19,9 @@ def set_attributes efforts.each do |effort| - effort.dropped_sp...
Fix bug in DroppedAttributesSetter that under some conditions set dropped_split_id without setting dropped_lap.
diff --git a/lib/parelation/applier.rb b/lib/parelation/applier.rb index abc1234..def5678 100644 --- a/lib/parelation/applier.rb +++ b/lib/parelation/applier.rb @@ -9,7 +9,7 @@ Parelation::Criteria::Offset, Parelation::Criteria::Order, Parelation::Criteria::Query, - Parelation::Criteria::Where + Par...
Use trailing commas in multi-line Arrays.
diff --git a/lib/paypal/nvp/request.rb b/lib/paypal/nvp/request.rb index abc1234..def5678 100644 --- a/lib/paypal/nvp/request.rb +++ b/lib/paypal/nvp/request.rb @@ -21,6 +21,7 @@ def initialize(attributes = {}) @version = Paypal.api_version super + self.subject ||= '' end ...
Fix the compatibility with rest-client 2.0
diff --git a/lib/tolk/link_renderer.rb b/lib/tolk/link_renderer.rb index abc1234..def5678 100644 --- a/lib/tolk/link_renderer.rb +++ b/lib/tolk/link_renderer.rb @@ -7,17 +7,17 @@ links.push page_link_or_span(@collection.next_page, 'disabled next_page', @options[:next_label]) html = links.joi...
Use html_safe and not html_safe!
diff --git a/lib/zartan/source_type.rb b/lib/zartan/source_type.rb index abc1234..def5678 100644 --- a/lib/zartan/source_type.rb +++ b/lib/zartan/source_type.rb @@ -1,10 +1,11 @@ module Zartan module SourceType extend self - + def all [ - ::Sources::DigitalOcean + ::Sources::Digita...
Add Linode as an option.
diff --git a/core/exception/top_level_spec.rb b/core/exception/top_level_spec.rb index abc1234..def5678 100644 --- a/core/exception/top_level_spec.rb +++ b/core/exception/top_level_spec.rb @@ -0,0 +1,22 @@+require_relative '../../spec_helper' + +describe "An Exception reaching the top level" do + it "is printed on STD...
Add spec checking exceptions reaching the top-level are printed properly
diff --git a/test/helpers/mountain_view/component_helper_test.rb b/test/helpers/mountain_view/component_helper_test.rb index abc1234..def5678 100644 --- a/test/helpers/mountain_view/component_helper_test.rb +++ b/test/helpers/mountain_view/component_helper_test.rb @@ -7,6 +7,6 @@ expected = /Pepe/ assert_mat...
Make Hound CI even happier.