diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/guard-notifier-blink1.gemspec b/guard-notifier-blink1.gemspec index abc1234..def5678 100644 --- a/guard-notifier-blink1.gemspec +++ b/guard-notifier-blink1.gemspec @@ -18,7 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_runtime_depe...
Update minimum version of Guard to 2.9 The `Guard::Notifier::SUPPORTED` constant was not available until Guard 2.9.0.
diff --git a/lib/vidibus/subdomain/extensions/controller.rb b/lib/vidibus/subdomain/extensions/controller.rb index abc1234..def5678 100644 --- a/lib/vidibus/subdomain/extensions/controller.rb +++ b/lib/vidibus/subdomain/extensions/controller.rb @@ -16,7 +16,7 @@ # Returns current subdomain. def subdoma...
Exclude domain of current service from hostname to detect subdomain properly
diff --git a/jquery-lazy-images.gemspec b/jquery-lazy-images.gemspec index abc1234..def5678 100644 --- a/jquery-lazy-images.gemspec +++ b/jquery-lazy-images.gemspec @@ -13,7 +13,7 @@ This Rails engine prevents images from loading until they're actually going to be displayed. This saves bandwidth, reduces serve...
Remove removed doc file from gemspec
diff --git a/lib/cocoapods/search/pod.rb b/lib/cocoapods/search/pod.rb index abc1234..def5678 100644 --- a/lib/cocoapods/search/pod.rb +++ b/lib/cocoapods/search/pod.rb @@ -3,6 +3,10 @@ module Cocoapods::Search class Pod attr_accessor :name, :star_count, :fork_count, :has_github + + def initialize + @ha...
Fix warning: instance variable @has_github not initialized
diff --git a/KHAForm.podspec b/KHAForm.podspec index abc1234..def5678 100644 --- a/KHAForm.podspec +++ b/KHAForm.podspec @@ -1,11 +1,11 @@ Pod::Spec.new do |s| s.name = "KHAForm" - s.version = "0.5" + s.version = "0.6" s.summary = "Simple tableview form in swift" s.homepage = "http...
Increase pod version and change podspec file
diff --git a/firmata.gemspec b/firmata.gemspec index abc1234..def5678 100644 --- a/firmata.gemspec +++ b/firmata.gemspec @@ -2,8 +2,8 @@ require File.expand_path('../lib/firmata/version', __FILE__) Gem::Specification.new do |gem| - gem.authors = ["'Mike Breen'"] - gem.email = ["hardbap@gmail.com"] + ...
Update some info for building from fork
diff --git a/roles/edgeuno.rb b/roles/edgeuno.rb index abc1234..def5678 100644 --- a/roles/edgeuno.rb +++ b/roles/edgeuno.rb @@ -2,6 +2,11 @@ description "Role applied to all servers at Edgeuno" default_attributes( + :accounts => { + :users => { + :e1admin => { :status => :administrator } + } + }, :h...
Add remote hands account for Edgeuno
diff --git a/recipes/mongodb.rb b/recipes/mongodb.rb index abc1234..def5678 100644 --- a/recipes/mongodb.rb +++ b/recipes/mongodb.rb @@ -17,6 +17,12 @@ # limitations under the License. # +# Install dependencies needed to compile `mongo` ruby gem. +# @see https://sethvargo.com/using-gems-with-chef/ +package 'libsasl...
Install library needed to compile `mongo` ruby gem
diff --git a/recipes/smartos.rb b/recipes/smartos.rb index abc1234..def5678 100644 --- a/recipes/smartos.rb +++ b/recipes/smartos.rb @@ -18,7 +18,7 @@ # # for backwards compatibility with older datasets -if !system("pkgin avail | grep build-essential") +if !system("pkgin -y avail | grep build-essential") packages...
Allow database to update w/o interaction
diff --git a/lib/faker/default/esport.rb b/lib/faker/default/esport.rb index abc1234..def5678 100644 --- a/lib/faker/default/esport.rb +++ b/lib/faker/default/esport.rb @@ -3,22 +3,67 @@ module Faker class Esport < Base class << self + ## + # Produces the name of a professional eSports player. + ...
Add YARD docs for Faker::Esport
diff --git a/spec/config_spec.rb b/spec/config_spec.rb index abc1234..def5678 100644 --- a/spec/config_spec.rb +++ b/spec/config_spec.rb @@ -3,6 +3,17 @@ describe Confoog::Settings do subject {Confoog::Settings.new} + + before(:all) do + # create an internal STDERR so we can still test this but it will not + ...
Add missing before(:all) and after(:all) to one rspec file Add to spec/config_spec.rb to silence console output during testing [ci skip] Signed-off-by: Seapagan <4ab1b2fdb7784a8f9b55e81e3261617f44fd0585@gmail.com>
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -5,6 +5,6 @@ require 'clean_files' -Spec::Runner.configure do |config| +RSpec.configure do |config| end
Use new rspec configuration syntax
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -2,3 +2,13 @@ $: << File.join(File.dirname(__FILE__), "/../../lib" ) require 'cucumber_priority' + +if defined?(RSpec) + RSpec.configure do |config| + if config.respond_to?(...
Remove deprecation warnings in new RSpecs
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -9,6 +9,8 @@ name = 'vidibus-gem_template_test' host = 'localhost' config.master = Mongo::Connection.new.db(name) + # Display MongoDB logs for debugging: + # config.maste...
Add a configuration example for enabling MongoDB logging
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,2 +1,3 @@ $LOAD_PATH.unshift File.expand_path("../../lib", __FILE__) require "franklin" +require "pry"
Add pry when runnign specs
diff --git a/app/controllers/cangaroo/endpoint_controller.rb b/app/controllers/cangaroo/endpoint_controller.rb index abc1234..def5678 100644 --- a/app/controllers/cangaroo/endpoint_controller.rb +++ b/app/controllers/cangaroo/endpoint_controller.rb @@ -41,14 +41,19 @@ def key if Rails.configuration.cangaroo....
Support basic auth on push endpoint
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,4 +1,4 @@-if ENV["CODECLIMATE_REPO_TOKEN"] +if ENV["CC_TEST_REPORTER_ID"] require "simplecov" SimpleCov.start end
Use correct ENV Var for CodeClimate
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -16,6 +16,9 @@ end RSpec.configure do |config| + config.filter_run :focus => true + config.run_all_when_everything_filtered = true + # In RSpec 3 this will no longer be nec...
Add support for :focus metadata filtering in rspec This is just a convenience to allow isolated tests to be run by adding :focus to the example or example group metadata.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -4,6 +4,8 @@ RSpec.configure do |config| config.include(RDF::Spec::Matchers) + config.filter_run :focus => true + config.run_all_when_everything_filtered = true config.ex...
Add RSpec filter configurations to allow running just focused specs.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,5 +1,12 @@+require 'simplecov' require 'coveralls' -Coveralls.wear! + +SimpleCov.formatter = Coveralls::SimpleCov::Formatter +if ENV['TRAVIS_CI'].nil? + SimpleCov.start +else ...
Exclude the scraper for SimpleCov if ENV is TRAVIS_CI
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -8,10 +8,6 @@ config.treat_symbols_as_metadata_keys_with_true_values = true config.filter_run_excluding do_not_run_in_transpeced_spec: ENV['TRANSPECED_SPEC'] -end - -Dir[Fil...
Fix coverage of some spec files was not measured
diff --git a/greeklish.gemspec b/greeklish.gemspec index abc1234..def5678 100644 --- a/greeklish.gemspec +++ b/greeklish.gemspec @@ -8,9 +8,9 @@ spec.version = Greeklish::VERSION spec.authors = ["Petros Markou"] spec.email = ["markoupetr@skroutz.gr"] - spec.summary = %q{TODO: Write a ...
Update summary, description and homepage in gemspec
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,5 +1,6 @@ require "pry" require "support/sequel_test_support" +require "support/blog_schema" RSpec.configure do |config| config.expect_with :rspec do |expectations| @@ -2...
Drop and recreate schema before test run The performance hit is not so bad for the convenience it provides.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -28,9 +28,6 @@ RSpec.configure do |config| - config.filter_run :focus => true - config.run_all_when_everything_filtered = true - config.after(:each) do if example.met...
Remove unused rspec :focus metadata configuration I actually remember that being kinda dangerous from app development. If you happen to forget to remove a :focus flag, only the focused tests will be run. During library development, I found myself simply running the specs in question explicitly, using something like: ...
diff --git a/bm/minitest_example.rb b/bm/minitest_example.rb index abc1234..def5678 100644 --- a/bm/minitest_example.rb +++ b/bm/minitest_example.rb @@ -0,0 +1,33 @@+require 'minitest/unit' +require 'minitest/autorun' + +class ShowThemHowToBeatIt < MiniTest::Unit::TestCase + + # will fail + def test_show_them_how_to...
Add a minitest example for comparison. [test]
diff --git a/lib/action_subscriber/middleware/error_handler.rb b/lib/action_subscriber/middleware/error_handler.rb index abc1234..def5678 100644 --- a/lib/action_subscriber/middleware/error_handler.rb +++ b/lib/action_subscriber/middleware/error_handler.rb @@ -8,26 +8,10 @@ end def call(env) - job...
Remove extra thread in error handler - already in a threadpool
diff --git a/lib/arbetsformedlingen/codes/municipality_code.rb b/lib/arbetsformedlingen/codes/municipality_code.rb index abc1234..def5678 100644 --- a/lib/arbetsformedlingen/codes/municipality_code.rb +++ b/lib/arbetsformedlingen/codes/municipality_code.rb @@ -22,8 +22,10 @@ name.to_s.strip end - def se...
Add Municipality::to_form_array method name_only option
diff --git a/lib/generators/sauce/install/install_generator.rb b/lib/generators/sauce/install/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/sauce/install/install_generator.rb +++ b/lib/generators/sauce/install/install_generator.rb @@ -41,7 +41,6 @@ require 'sauce' Sauce.config do |conf| - ...
Remove the unnecessary fake domain nonsense from the Rails2 generator Fixes #56
diff --git a/app/models/manageiq/providers/google/regions.rb b/app/models/manageiq/providers/google/regions.rb index abc1234..def5678 100644 --- a/app/models/manageiq/providers/google/regions.rb +++ b/app/models/manageiq/providers/google/regions.rb @@ -3,6 +3,11 @@ module Regions # From https://cloud.google....
Add the new Eastern US region to GCE
diff --git a/lib/tasks/move_primary_section_into_taggable.rake b/lib/tasks/move_primary_section_into_taggable.rake index abc1234..def5678 100644 --- a/lib/tasks/move_primary_section_into_taggable.rake +++ b/lib/tasks/move_primary_section_into_taggable.rake @@ -1,5 +1,5 @@ namespace :migrate do - desc "Populate tag obj...
Update desc to be relevant & accurate
diff --git a/app/controllers/task_comments_controller.rb b/app/controllers/task_comments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/task_comments_controller.rb +++ b/app/controllers/task_comments_controller.rb @@ -20,7 +20,7 @@ @task = Task.find(params[:task_id]) @comment = @task.comment...
Comment added to task show to view single task comment
diff --git a/lib/thinking_sphinx/test.rb b/lib/thinking_sphinx/test.rb index abc1234..def5678 100644 --- a/lib/thinking_sphinx/test.rb +++ b/lib/thinking_sphinx/test.rb @@ -4,9 +4,9 @@ config.settings['quiet_deltas'] = suppress_delta_output end - def self.start + def self.start(options = {}) config.rend...
Add clear method and no-index option for start to ThinkingSphinx::Test.
diff --git a/spec/exchanges/bitconnect/integration/market_spec.rb b/spec/exchanges/bitconnect/integration/market_spec.rb index abc1234..def5678 100644 --- a/spec/exchanges/bitconnect/integration/market_spec.rb +++ b/spec/exchanges/bitconnect/integration/market_spec.rb @@ -14,8 +14,8 @@ end it 'fetch ticker' do -...
Refactor longer varname to pair
diff --git a/QRSwift.podspec b/QRSwift.podspec index abc1234..def5678 100644 --- a/QRSwift.podspec +++ b/QRSwift.podspec @@ -15,6 +15,7 @@ s.ios.deployment_target = "9.0" s.osx.deployment_target = "10.11" + s.tvos.deployment_target = "10" s.source = { :git => "https://github.com/chrisamanse/QRSwift.g...
Add tvos deployment target in podspec
diff --git a/spec/unit/concurrent/synchronized_sorted_set_spec.rb b/spec/unit/concurrent/synchronized_sorted_set_spec.rb index abc1234..def5678 100644 --- a/spec/unit/concurrent/synchronized_sorted_set_spec.rb +++ b/spec/unit/concurrent/synchronized_sorted_set_spec.rb @@ -1,34 +1,36 @@ require "spec_helper" require "b...
Exclude this test from CI
diff --git a/app/validators/status_prerequisite_validator.rb b/app/validators/status_prerequisite_validator.rb index abc1234..def5678 100644 --- a/app/validators/status_prerequisite_validator.rb +++ b/app/validators/status_prerequisite_validator.rb @@ -1,15 +1,25 @@ class StatusPrerequisiteValidator < ActiveModel::Each...
Refactor the status prerequisite validator
diff --git a/spec/models/tag_spec.rb b/spec/models/tag_spec.rb index abc1234..def5678 100644 --- a/spec/models/tag_spec.rb +++ b/spec/models/tag_spec.rb @@ -2,7 +2,7 @@ RSpec.describe Tag, type: :model do describe 'tag associations' do - it { is_expected.to have_many(:pintags)} + xit { is_expected.to have_ma...
Put test in pending - tag is expected to have many pintags
diff --git a/envryo.gemspec b/envryo.gemspec index abc1234..def5678 100644 --- a/envryo.gemspec +++ b/envryo.gemspec @@ -18,6 +18,8 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] + spec.add_runtime_dependency "evernote_oauth", "~> 0.2" + spec.add_developm...
Add evernote_oauth as runtime dependency
diff --git a/spec/support/samples.rb b/spec/support/samples.rb index abc1234..def5678 100644 --- a/spec/support/samples.rb +++ b/spec/support/samples.rb @@ -5,7 +5,7 @@ def sample_fitness_evaluator fitness_evaluator = Object.new def fitness_evaluator.fitness(params) - params.each_value.inject(:*) || 1 + par...
Fix sample fitness evaluator to use array of hashes
diff --git a/spec/unit/timer_spec.rb b/spec/unit/timer_spec.rb index abc1234..def5678 100644 --- a/spec/unit/timer_spec.rb +++ b/spec/unit/timer_spec.rb @@ -24,6 +24,6 @@ # busy work end - expect(yielded.size).to be >= 3 + expect(yielded.size).to be >= 2 end end
Change to ensure passes on old rubies and windows
diff --git a/app/helpers/rawnet_admin/resource_helper.rb b/app/helpers/rawnet_admin/resource_helper.rb index abc1234..def5678 100644 --- a/app/helpers/rawnet_admin/resource_helper.rb +++ b/app/helpers/rawnet_admin/resource_helper.rb @@ -15,7 +15,7 @@ confirm: "Are you sure?" } }.merge(op...
Allow changing of delete link text
diff --git a/lib/active_admin/engine.rb b/lib/active_admin/engine.rb index abc1234..def5678 100644 --- a/lib/active_admin/engine.rb +++ b/lib/active_admin/engine.rb @@ -1,7 +1,8 @@ # frozen_string_literal: true module ActiveAdmin class Engine < ::Rails::Engine - initializer "active_admin.load_app_path" do |app| ...
Support specs running with config.eager_load=true `ActiveAdmin::Aplication.remove_active_admin_load_paths_from_rails_autoload_and_eager_load` is not working on feature tests. Starting from Rails 7.0, running tests with eager_load enabled produces the following error: ``` Failure/Error: require "#{ActiveAdmin::TestAp...
diff --git a/SwiftySwift.podspec b/SwiftySwift.podspec index abc1234..def5678 100644 --- a/SwiftySwift.podspec +++ b/SwiftySwift.podspec @@ -6,8 +6,30 @@ s.license = { :type => 'MIT' } s.authors = { "Agustin de Cabrera" => "agustindc@gmail.com" } s.source = { :git => "https://github.com/adeca/Sw...
Split Podfile spec into several sub-specs.
diff --git a/app/views/live/events/_event_data.json.ruby b/app/views/live/events/_event_data.json.ruby index abc1234..def5678 100644 --- a/app/views/live/events/_event_data.json.ruby +++ b/app/views/live/events/_event_data.json.ruby @@ -1,6 +1,7 @@ { eventId: @event.id, eventName: @event.name, + ...
Add multiLap key to _event_data JSON response
diff --git a/SwiftKeychainWrapper.podspec b/SwiftKeychainWrapper.podspec index abc1234..def5678 100644 --- a/SwiftKeychainWrapper.podspec +++ b/SwiftKeychainWrapper.podspec @@ -1,9 +1,9 @@ Pod::Spec.new do |s| s.name = 'SwiftKeychainWrapper' - s.version = '2.0.0' - s.summary = 'Static wrapper for the iOS Keychai...
Update to pod spec description
diff --git a/week-4/address/my_solution.rb b/week-4/address/my_solution.rb index abc1234..def5678 100644 --- a/week-4/address/my_solution.rb +++ b/week-4/address/my_solution.rb @@ -4,3 +4,6 @@ # Your Solution Below +def make_address(street, city, state, zip) + return "You live at #{street}, in the beautiful city...
Complete the answer for 4.3.1 Return A Formatted Address.
diff --git a/scripts/list-routes.rb b/scripts/list-routes.rb index abc1234..def5678 100644 --- a/scripts/list-routes.rb +++ b/scripts/list-routes.rb @@ -0,0 +1,32 @@+#!/usr/bin/env ruby + +require 'json' +require 'set' + +routes_by_domain_url = {} + +page = JSON.parse `cf curl '/v2/routes?results-per-page=100'` +next_u...
Add a script to list the routes in a region This may be useful when we're trying to understand what things are running on the platform. Possible future improvements: - send a `dig` to custom domains to see if DNS is actually setup - send an HTTP request to the domain to see if it's serving 200s [skip-ci]
diff --git a/safeword.gemspec b/safeword.gemspec index abc1234..def5678 100644 --- a/safeword.gemspec +++ b/safeword.gemspec @@ -27,4 +27,6 @@ spec.add_development_dependency 'pry', '~> 0.10' spec.add_development_dependency 'rake', '~> 11.2' spec.add_development_dependency 'rspec', '~> 3.5' + spec.add_developm...
Add Rubocop to help keep the codebase healthy
diff --git a/test/functional/repos_controller_test.rb b/test/functional/repos_controller_test.rb index abc1234..def5678 100644 --- a/test/functional/repos_controller_test.rb +++ b/test/functional/repos_controller_test.rb @@ -22,8 +22,10 @@ test 'logged in user can create repo' do sign_in users(:mockstar) - ...
Use VCR cassete so tests will pass on travis
diff --git a/lib/specter.rb b/lib/specter.rb index abc1234..def5678 100644 --- a/lib/specter.rb +++ b/lib/specter.rb @@ -3,5 +3,11 @@ require 'clap' class Specter - # Your code goes here... + def patterns + @patterns ||= [] + end + + def filenames + Dir[*patterns] + end end
Handle file patterns and names.
diff --git a/db/migrate/033_change_diary_entries_language.rb b/db/migrate/033_change_diary_entries_language.rb index abc1234..def5678 100644 --- a/db/migrate/033_change_diary_entries_language.rb +++ b/db/migrate/033_change_diary_entries_language.rb @@ -1,7 +1,7 @@ class ChangeDiaryEntriesLanguage < ActiveRecord::Migrat...
Tweak migration to ensure that migrating from a database with existing diary entries sets a default language for those entries.
diff --git a/settings.gemspec b/settings.gemspec index abc1234..def5678 100644 --- a/settings.gemspec +++ b/settings.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'settings' - s.version = '0.1.3' + s.version = '0.1.4' s.summary = 'Settings data access and assignment' ...
Package version increased from 0.1.3 to 0.1.4
diff --git a/app/models/setup/deletion.rb b/app/models/setup/deletion.rb index abc1234..def5678 100644 --- a/app/models/setup/deletion.rb +++ b/app/models/setup/deletion.rb @@ -5,9 +5,10 @@ build_in_data_type def run(message) - if (model = data_type_from(message).records_model) + data_type = data_t...
Fix | Deletion of multiples files records
diff --git a/test/api/override_test.rb b/test/api/override_test.rb index abc1234..def5678 100644 --- a/test/api/override_test.rb +++ b/test/api/override_test.rb @@ -26,11 +26,12 @@ end test "make sure modules can overwrite I18n methods" do - @I18n.extend OverrideInverse + @I18n.extend OverrideInverse ...
Fix the build bu disabling a 1.8.7 specific test
diff --git a/test/spec/upstart_spec.rb b/test/spec/upstart_spec.rb index abc1234..def5678 100644 --- a/test/spec/upstart_spec.rb +++ b/test/spec/upstart_spec.rb @@ -0,0 +1,51 @@+# +# Copyright 2015, Noah Kantrowitz +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except...
Add a test for upstart template rendering.
diff --git a/test/test_registration.rb b/test/test_registration.rb index abc1234..def5678 100644 --- a/test/test_registration.rb +++ b/test/test_registration.rb @@ -17,17 +17,17 @@ def test_registered # all these class names must appear once in enumerate class names - classes = [ "RCP_ComputerSystem.mof", -...
Fix registration test, add DeepInheritance
diff --git a/lib/apiuri.rb b/lib/apiuri.rb index abc1234..def5678 100644 --- a/lib/apiuri.rb +++ b/lib/apiuri.rb @@ -0,0 +1,23 @@+require 'uri' + +class ApiUri + VENDOR_HOST = "api.replicated.com" + VENDOR_BASE_PATH = "/vendor/v1" + + def self.build_uri(module_name, endpoint = nil, params = nil) + uri_base =...
Add a class to build a URI object This uses the standard format for the Replicated Vendor API to build up a uri object for an endpoint. With this simplified interface, the request client can be simplified, and the API modules only need to be concerned with building the correct `endpoint` string.
diff --git a/spec/lib/stellar/price_spec.rb b/spec/lib/stellar/price_spec.rb index abc1234..def5678 100644 --- a/spec/lib/stellar/price_spec.rb +++ b/spec/lib/stellar/price_spec.rb @@ -4,7 +4,7 @@ subject{ Stellar::Price } let(:seed){ 225571644875421139403973254661022579608 } #generated using Random.new let(:ra...
Fix SMOKE_ITERATIONS for test suite
diff --git a/spec/local_vm_requests_spec.rb b/spec/local_vm_requests_spec.rb index abc1234..def5678 100644 --- a/spec/local_vm_requests_spec.rb +++ b/spec/local_vm_requests_spec.rb @@ -3,7 +3,9 @@ # TODO - Global vars are so bad. Do this better. describe "VMRequests" do - it "creates a VM" + it "creates a VM" do +...
Add spec to create VM.
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -18,6 +18,7 @@ # Install module and dependencies hosts.each do |host| copy_module_to(host, source: proj_root, module_nam...
Add missing dependency for Beaker tests
diff --git a/snitcher.gemspec b/snitcher.gemspec index abc1234..def5678 100644 --- a/snitcher.gemspec +++ b/snitcher.gemspec @@ -8,8 +8,8 @@ spec.version = Snitcher::VERSION spec.author = "Collective Idea" - spec.email = "info@collectiveidea.com" - spec.homepage = "https://github.com/collectiveidea/snitch...
Update link and email address for new github org. We've moved the code from collectiveidea to deadmanssnitch so we should reflect that in the gemspec.
diff --git a/services/importer/spec/factories/pg_connection.rb b/services/importer/spec/factories/pg_connection.rb index abc1234..def5678 100644 --- a/services/importer/spec/factories/pg_connection.rb +++ b/services/importer/spec/factories/pg_connection.rb @@ -9,7 +9,7 @@ module Factories class PGConnection ...
Use built-ins for importer unit tests, avoid loading SequelRails and its dependencies
diff --git a/lib/ckeditor-rails/tasks.rake b/lib/ckeditor-rails/tasks.rake index abc1234..def5678 100644 --- a/lib/ckeditor-rails/tasks.rake +++ b/lib/ckeditor-rails/tasks.rake @@ -6,6 +6,8 @@ for file in Dir["public/assets/ckeditor/**/*"] next unless file =~ fingerprint nondigest = file.sub fingerprint, '....
Copy fingerprinted assets only if more recent than non-fingerprinted versions
diff --git a/APIService/APIService-TalkingData.podspec b/APIService/APIService-TalkingData.podspec index abc1234..def5678 100644 --- a/APIService/APIService-TalkingData.podspec +++ b/APIService/APIService-TalkingData.podspec @@ -0,0 +1,23 @@+Pod::Spec.new do |s| + s.name = "APIService-TalkingData" + s.ve...
Revert "Remove TalkingData, app can use TalkingData-AppAnalytics instead" This reverts commit d34b2833a444cffb8f9eeee4d59133dcc4066567.
diff --git a/schema.gemspec b/schema.gemspec index abc1234..def5678 100644 --- a/schema.gemspec +++ b/schema.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'schema' s.summary = "Primitives for schema and structure" - s.version = '0.4.5.1' + s.version = '0.4.5.2' s.description = ' ' s.aut...
Package version is increased from 0.4.5.1 to 0.4.5.2
diff --git a/lib/rake/classic_namespace.rb b/lib/rake/classic_namespace.rb index abc1234..def5678 100644 --- a/lib/rake/classic_namespace.rb +++ b/lib/rake/classic_namespace.rb @@ -3,7 +3,9 @@ # referenced Task from the top level. warn "WARNING: Classic namespaces are deprecated and will be removed from future versi...
Hide the deprecated classic namespace from RDoc
diff --git a/lib/recaptcha_mailhide/url.rb b/lib/recaptcha_mailhide/url.rb index abc1234..def5678 100644 --- a/lib/recaptcha_mailhide/url.rb +++ b/lib/recaptcha_mailhide/url.rb @@ -1,11 +1,11 @@ module RecaptchaMailhide module URL - BASE_URL = "http://www.google.com/recaptcha/mailhide/d" + BASE_URL = "https://...
Use HTTPS in generated URLs.
diff --git a/lib/recorder/rails/railtie.rb b/lib/recorder/rails/railtie.rb index abc1234..def5678 100644 --- a/lib/recorder/rails/railtie.rb +++ b/lib/recorder/rails/railtie.rb @@ -2,7 +2,7 @@ module Recorder module Rails - class Railtie < Rails::Railtie + class Railtie < ::Rails::Railtie initializer ...
Fix 'uninitialized constant Recorder::Rails::Railtie' error
diff --git a/lib/tasks/data/poll_imdb.rake b/lib/tasks/data/poll_imdb.rake index abc1234..def5678 100644 --- a/lib/tasks/data/poll_imdb.rake +++ b/lib/tasks/data/poll_imdb.rake @@ -0,0 +1,6 @@+namespace :data do + desc 'Poll data from Imdb to import movies in our database' + task :poll_imdb => :environment do + Mo...
feat(task): Add a rake task to poll imdb
diff --git a/lib/tasks/publishing_api.rake b/lib/tasks/publishing_api.rake index abc1234..def5678 100644 --- a/lib/tasks/publishing_api.rake +++ b/lib/tasks/publishing_api.rake @@ -15,7 +15,7 @@ Rails.application.publishing_api_v2.patch_links( artefact.content_id, links: { - ordered_rel...
Send related items in order to publishing-api The ordering is important because the user has specified it in the UI.
diff --git a/lib/tic_tac_toe/rack_shell.rb b/lib/tic_tac_toe/rack_shell.rb index abc1234..def5678 100644 --- a/lib/tic_tac_toe/rack_shell.rb +++ b/lib/tic_tac_toe/rack_shell.rb @@ -6,6 +6,9 @@ return RackShell.new end + def call(env) + [200, {}, ["Hello World"]] + end end end
Add a hello world call implementation
diff --git a/lib/timerage/time_interval.rb b/lib/timerage/time_interval.rb index abc1234..def5678 100644 --- a/lib/timerage/time_interval.rb +++ b/lib/timerage/time_interval.rb @@ -30,20 +30,26 @@ an_obj.respond_to?(:end) end + # --- + # + # This is implemented in a slightly more procedural styl...
Reduce the number of comparisons during iteration
diff --git a/lib/torckapi/response/base.rb b/lib/torckapi/response/base.rb index abc1234..def5678 100644 --- a/lib/torckapi/response/base.rb +++ b/lib/torckapi/response/base.rb @@ -7,7 +7,7 @@ def self.bdecode_and_check(data, key) begin - bdecoded_data = BEncode.load(data, :ignore_trailing_jun...
Revert "Allow proper loading of failed Bencoded data" This reverts commit b000225b6a3068eb858ed8290fe3594ed849e383.
diff --git a/src/models/operating_system.rb b/src/models/operating_system.rb index abc1234..def5678 100644 --- a/src/models/operating_system.rb +++ b/src/models/operating_system.rb @@ -15,6 +15,4 @@ require 'sinatra/activerecord' class OperatingSystem < ActiveRecord::Base - def initialize - end end
Remove override constructor to initialize model
diff --git a/CMNavBarNotificationView.podspec b/CMNavBarNotificationView.podspec index abc1234..def5678 100644 --- a/CMNavBarNotificationView.podspec +++ b/CMNavBarNotificationView.podspec @@ -1,12 +1,13 @@ Pod::Spec.new do |s| s.name = "CMNavBarNotificationView" - s.version = "1.0.3" + s.version ...
Bump new version and add requires_arc to podspec
diff --git a/validate_as_email.gemspec b/validate_as_email.gemspec index abc1234..def5678 100644 --- a/validate_as_email.gemspec +++ b/validate_as_email.gemspec @@ -16,6 +16,6 @@ gem.version = ValidateAsEmail::VERSION gem.platform = Gem::Platform::RUBY - gem.add_dependency 'activemodel', '> 3', '< 4....
Allow to run with activemodel 4.2.x
diff --git a/test/unit/test_store_metadata.rb b/test/unit/test_store_metadata.rb index abc1234..def5678 100644 --- a/test/unit/test_store_metadata.rb +++ b/test/unit/test_store_metadata.rb @@ -1,6 +1,6 @@ require 'helper' -class TestStoreConstruction < Test::Pwl::TestCase +class TestStoreMetaData < Test::Pwl::TestCas...
Fix wrong test class name
diff --git a/source/feed.xml.builder b/source/feed.xml.builder index abc1234..def5678 100644 --- a/source/feed.xml.builder +++ b/source/feed.xml.builder @@ -6,6 +6,7 @@ xml.link "href" => "http://blog.troutwine.us/feed.xml", "rel" => "self" xml.updated data.blog.articles.first.date.to_time.iso8601 xml.author { ...
Add favicon icon to Atom feed output. Signed-off-by: Brian L. Troutwine <760e7dab2836853c63805033e514668301fa9c47@troutwine.us>
diff --git a/counter_api.rb b/counter_api.rb index abc1234..def5678 100644 --- a/counter_api.rb +++ b/counter_api.rb @@ -1,8 +1,7 @@ require "sinatra/json" configure do - session = Moped::Session.new([ '127.0.0.1:27017' ]) - session.use "cloud_counter_#{ENV['RACK_ENV']}" + session ||= Moped::Session.connect(ENV.f...
Connect to mongo on heroku too
diff --git a/spec/controller_spec.rb b/spec/controller_spec.rb index abc1234..def5678 100644 --- a/spec/controller_spec.rb +++ b/spec/controller_spec.rb @@ -0,0 +1,13 @@+require File.join(File.dirname(__FILE__), 'spec_helper.rb') + +class Test < Merb::Controller + def index + "index" + end +end + +describe Merb::C...
Add controller spec (not full)
diff --git a/spec/end_to_end_spec.rb b/spec/end_to_end_spec.rb index abc1234..def5678 100644 --- a/spec/end_to_end_spec.rb +++ b/spec/end_to_end_spec.rb @@ -24,4 +24,12 @@ shell.game_loop end + it "ends after a draw" do + x_moves = [0, 1, 3, 8, 4] + y_moves = [2, 6, 7, 5] + moves = x_moves.zip(y_move...
Add a test that plays through a tie game
diff --git a/mpfr2.rb b/mpfr2.rb index abc1234..def5678 100644 --- a/mpfr2.rb +++ b/mpfr2.rb @@ -0,0 +1,47 @@+require 'formula' + +class Mpfr2 < Formula + homepage 'http://www.mpfr.org/' + # Tracking legacy version on gcc ftp + url 'ftp://gcc.gnu.org/pub/gcc/infrastructure/mpfr-2.4.2.tar.bz2' + sha1 '7ca93006e38ae6...
Add legacy version of mpfr. * Add mpfr 2.4.2 from GCC infrastructure.
diff --git a/app/controllers/policies_controller.rb b/app/controllers/policies_controller.rb index abc1234..def5678 100644 --- a/app/controllers/policies_controller.rb +++ b/app/controllers/policies_controller.rb @@ -5,7 +5,7 @@ before_action :authenticate_user!, except: [:index, :show, :detail] def index - @...
Reduce sql calls on list of policies
diff --git a/app/controllers/subjects_controller.rb b/app/controllers/subjects_controller.rb index abc1234..def5678 100644 --- a/app/controllers/subjects_controller.rb +++ b/app/controllers/subjects_controller.rb @@ -30,5 +30,9 @@ def resource @subject ||= chain.distinct("subjects") .find { |subject| subj...
Raise error when subject not found
diff --git a/lib/plucky.rb b/lib/plucky.rb index abc1234..def5678 100644 --- a/lib/plucky.rb +++ b/lib/plucky.rb @@ -15,16 +15,13 @@ end def self.to_object_id(value) - if value.nil? || (value.respond_to?(:empty?) && value.empty?) - nil - elsif value.is_a?(BSON::ObjectId) + return value if value.is_...
Check if already bson object id first. Assumes that is most common.
diff --git a/app/importers/iep_import/iep_storer.rb b/app/importers/iep_import/iep_storer.rb index abc1234..def5678 100644 --- a/app/importers/iep_import/iep_storer.rb +++ b/app/importers/iep_import/iep_storer.rb @@ -18,14 +18,31 @@ return @logger.info("student not in db!") unless @student - @logger.info("st...
Print out AWS S3 confirmation of server_side_encrpytion status + ... also don't save an object to the DB unless we hear back from AWS that it saved successfully
diff --git a/jsrebuild.gemspec b/jsrebuild.gemspec index abc1234..def5678 100644 --- a/jsrebuild.gemspec +++ b/jsrebuild.gemspec @@ -1,24 +1,31 @@+# -*- encoding: utf-8 -*- +lib = File.expand_path('../lib/', __FILE__) +$:.unshift lib unless $:.include?(lib) + +require 'jsrebuild' + Gem::Specification.new do |gem| - g...
Add require_path, load version from JSRebuild::VERSION constant and add gem platform to gemspec.
diff --git a/lib/server.rb b/lib/server.rb index abc1234..def5678 100644 --- a/lib/server.rb +++ b/lib/server.rb @@ -1,4 +1,5 @@ require 'socket' +require 'stringio' class Server def initialize(port, sleep = 1)
Add missing require for StringIO
diff --git a/spec/controllers/moderation_controller_spec.rb b/spec/controllers/moderation_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/moderation_controller_spec.rb +++ b/spec/controllers/moderation_controller_spec.rb @@ -1,4 +1,58 @@ require 'rails_helper' RSpec.describe ModerationControl...
Add some moderation controller tests
diff --git a/pre-commit.d/whitespace.rb b/pre-commit.d/whitespace.rb index abc1234..def5678 100644 --- a/pre-commit.d/whitespace.rb +++ b/pre-commit.d/whitespace.rb @@ -4,17 +4,17 @@ `git rev-parse --verify HEAD` against = if $? == 0 - 'HEAD' + 'HEAD' else - '4b825dc642cb6eb9a060e54bf8d69288fbee4904' + '4b825dc64...
Use spaces instead of tabs.
diff --git a/railties/configs/routes.rb b/railties/configs/routes.rb index abc1234..def5678 100644 --- a/railties/configs/routes.rb +++ b/railties/configs/routes.rb @@ -19,6 +19,7 @@ # -- just remember to delete public/index.html. # map.root :controller => "welcome" - # Install the default route as the lowest p...
Include default route for formats git-svn-id: afc9fed30c1a09d8801d1e4fbe6e01c29c67d11f@6576 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
diff --git a/lib/csi/record.rb b/lib/csi/record.rb index abc1234..def5678 100644 --- a/lib/csi/record.rb +++ b/lib/csi/record.rb @@ -13,7 +13,7 @@ raise CSI::CodeInvalid, 'String required' unless code.is_a? String type.downcase! - raise CSI::TypeInvalid, 'Invalid type - SIC and NAICS only' unless ty...
Fix '=' instead of '==' typo on conditional
diff --git a/lib/mongoid_connection_pool/mongoid/sessions.rb b/lib/mongoid_connection_pool/mongoid/sessions.rb index abc1234..def5678 100644 --- a/lib/mongoid_connection_pool/mongoid/sessions.rb +++ b/lib/mongoid_connection_pool/mongoid/sessions.rb @@ -22,13 +22,17 @@ @session_pool[name] end - def...
Fix locking issue on disconnect
diff --git a/test/syntax_test.rb b/test/syntax_test.rb index abc1234..def5678 100644 --- a/test/syntax_test.rb +++ b/test/syntax_test.rb @@ -0,0 +1,32 @@+require 'test_helper' + +describe "Syntax check" do + project_root = Pathname.new(File.expand_path("#{File.dirname(__FILE__)}/../")) + backend_files = Dir[project_r...
Add a syntax test to help support multiple Rubies This is no real gain on Travis, which runs the full test suite against two Rubies. It does catch a few classes of error when running the test suite locally.
diff --git a/app/controllers/news_controller.rb b/app/controllers/news_controller.rb index abc1234..def5678 100644 --- a/app/controllers/news_controller.rb +++ b/app/controllers/news_controller.rb @@ -1,6 +1,6 @@ class NewsController < ApplicationController before_action :set_news, only: [:show, :edit, :update, :des...
Make news readable for public
diff --git a/app/models/mixins/tenancy_mixin.rb b/app/models/mixins/tenancy_mixin.rb index abc1234..def5678 100644 --- a/app/models/mixins/tenancy_mixin.rb +++ b/app/models/mixins/tenancy_mixin.rb @@ -24,11 +24,11 @@ # Current user # Parent EMS # Root tenant - self.tenant_id ||= if respond_to?(:m...
Handle case of nil tenant id on group, user, and ems. If the group, user, ems is nil (handled already) or if their tenant id is nil(fixed in this commit), we need to fall through to the next option. Owning group -> current user -> parent ems -> root tenant Fixes some API specs where a Vmware::InfraManager wasn't fal...
diff --git a/app/models/reports/admin_report.rb b/app/models/reports/admin_report.rb index abc1234..def5678 100644 --- a/app/models/reports/admin_report.rb +++ b/app/models/reports/admin_report.rb @@ -39,7 +39,7 @@ private def category - params[:category] if FormAnswer::AWARD_TYPE_FULL_NAMES.keys.include?(par...
Fix issue with not found constant
diff --git a/app/models/spree/user_decorator.rb b/app/models/spree/user_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/user_decorator.rb +++ b/app/models/spree/user_decorator.rb @@ -1,6 +1,6 @@ module Spree User.class_eval do - scope :dibs_referrers, lambda { includes(:roles).where("#{::Spree::...
Fix role reference in checkout
diff --git a/app/serializers/user_serializer.rb b/app/serializers/user_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/user_serializer.rb +++ b/app/serializers/user_serializer.rb @@ -2,5 +2,6 @@ include TalkSerializer include ModerationActions - all_attributes except: :email + attributes :i...
Whitelist instead of blacklist user attributes
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -23,9 +23,9 @@ out, err, status = Open3.capture3(*(['bzip2'] + arguments)) args_string = arguments.collect {|a| "'#{a}'" }.join(' ') + assert(err == '', "`bzip2...
Reorder assertions to report error/output on a non-zero exit status.