diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/related.gemspec b/related.gemspec index abc1234..def5678 100644 --- a/related.gemspec +++ b/related.gemspec @@ -6,6 +6,7 @@ s.version = Related::Version s.summary = 'Related is a Redis-backed high performance distributed graph database.' s.description = 'Related is a Redis-backed high perfo...
Add missing `license` property to gemspec
diff --git a/lib/rspec/contracts/interaction.rb b/lib/rspec/contracts/interaction.rb index abc1234..def5678 100644 --- a/lib/rspec/contracts/interaction.rb +++ b/lib/rspec/contracts/interaction.rb @@ -1,19 +1,25 @@ module RSpec module Contracts class Interaction - attr_reader :interface_name, :method_name,...
Add specification checking to interface comparison logic
diff --git a/lita-imgflip.gemspec b/lita-imgflip.gemspec index abc1234..def5678 100644 --- a/lita-imgflip.gemspec +++ b/lita-imgflip.gemspec @@ -17,7 +17,7 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" - spec.add_development_dependency "rspec", "~> 2.14" + spec.a...
Update rspec requirement to 3.0.0.beta1.
diff --git a/app/helpers/date_helper.rb b/app/helpers/date_helper.rb index abc1234..def5678 100644 --- a/app/helpers/date_helper.rb +++ b/app/helpers/date_helper.rb @@ -35,6 +35,6 @@ def zero_pad(value) return value unless value =~ /^\d$/ - format("%02d", value) + sprintf("%02d", value) # rubocop:disable...
Fix buggy auto-correct for 'format' method Previously we changed to use the Kernel 'format' method, but this conflicts with an app-specific 'format' method. This switches to using 'sprintf' and disables the associated Cop. Unfortantely the term 'format' is too prevalent in this app to rename the method.
diff --git a/app/helpers/yelp_helper.rb b/app/helpers/yelp_helper.rb index abc1234..def5678 100644 --- a/app/helpers/yelp_helper.rb +++ b/app/helpers/yelp_helper.rb @@ -34,15 +34,17 @@ # sort: '2' # } - p "PEEING OUT PARAMS" p params p location @response = Yelp.client.search(loc...
Add debugging code for phone number
diff --git a/lib/frontend_server.rb b/lib/frontend_server.rb index abc1234..def5678 100644 --- a/lib/frontend_server.rb +++ b/lib/frontend_server.rb @@ -50,10 +50,10 @@ end def boot! - @config = OpenStruct.new(YAML.load(ERB.new(File.read("#{root}/config/application.yml")).result)[env]) + @config = ...
Reorganize for heroku build pack
diff --git a/app/models/news_archive.rb b/app/models/news_archive.rb index abc1234..def5678 100644 --- a/app/models/news_archive.rb +++ b/app/models/news_archive.rb @@ -11,11 +11,12 @@ end def find_years - @years = @entries.map {|e| e.created_at.year }.uniq + @years = @entries.map {|e| e.created_at.year }....
Fix sorting issues for months and years
diff --git a/app/models/select_facet.rb b/app/models/select_facet.rb index abc1234..def5678 100644 --- a/app/models/select_facet.rb +++ b/app/models/select_facet.rb @@ -12,6 +12,11 @@ value: allowed_value['value'], label: allowed_value['label'], id: allowed_value['value'], + data_attrib...
Add tracking to option select filters
diff --git a/app/models/select_facet.rb b/app/models/select_facet.rb index abc1234..def5678 100644 --- a/app/models/select_facet.rb +++ b/app/models/select_facet.rb @@ -4,10 +4,10 @@ def options allowed_values.map do | allowed_value | { - "value" => allowed_value.value, - "label" => allowed_...
Use symbols, not strings, for component object keys We should only use one style of keys for objects used in components, to avoid reduce confusion when using components. Consistency is good. After discussion with @edds we agreed to use symbols as this makes more sense in a ruby/rails environment. The first step was ...
diff --git a/lib/openlogi/client.rb b/lib/openlogi/client.rb index abc1234..def5678 100644 --- a/lib/openlogi/client.rb +++ b/lib/openlogi/client.rb @@ -30,6 +30,10 @@ @shipments ||= Api::Shipments.new(self) end + def validations + @validations ||= Api::Validations.new(self) + end + extend ...
Add validations method for shortcut
diff --git a/test/unit/basic_test.rb b/test/unit/basic_test.rb index abc1234..def5678 100644 --- a/test/unit/basic_test.rb +++ b/test/unit/basic_test.rb @@ -19,14 +19,14 @@ client.use_oauth2_auth = use_auth %i[get delete head].each do |method| stub = stub_request(method, /feed-test/).to_timeout - ...
Test handles multiple exception types depending on version of RestClient.
diff --git a/lib/ppcurses/Screen.rb b/lib/ppcurses/Screen.rb index abc1234..def5678 100644 --- a/lib/ppcurses/Screen.rb +++ b/lib/ppcurses/Screen.rb @@ -61,7 +61,7 @@ cbreak start_color - yield + return yield rescue SystemExit, Interrupt # Empty Catch block so...
Return the response from yield
diff --git a/amakanize.gemspec b/amakanize.gemspec index abc1234..def5678 100644 --- a/amakanize.gemspec +++ b/amakanize.gemspec @@ -12,8 +12,6 @@ spec.license = "MIT" spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } - spec.bindir = "exe" - spec.executables = spec....
Remove unused configuration about executables
diff --git a/lib/ethon/easy/mirror.rb b/lib/ethon/easy/mirror.rb index abc1234..def5678 100644 --- a/lib/ethon/easy/mirror.rb +++ b/lib/ethon/easy/mirror.rb @@ -10,7 +10,7 @@ end def self.informations_to_log - [:url, :response_code, :return_code, :total_time] + [:effective_url, :response_co...
Use effective_url instead of url for logging Whenever I look at logs from ethon, I get something like ```performed EASY url= response_code=200 return_code=ok total_time=0.28435``` . I'm on OSX, ethon version 0.7. This seems to fix it so that I can see the url in my logs ```EASY effective_url=http://www.exampl...
diff --git a/lib/sweep/scheduler.rb b/lib/sweep/scheduler.rb index abc1234..def5678 100644 --- a/lib/sweep/scheduler.rb +++ b/lib/sweep/scheduler.rb @@ -10,18 +10,19 @@ @tasks.size end - def scheduleAlive(ip) + def scheduleAlive(host) end - def scheduleTcp(ip) + def scheduleTcp(host) end - ...
Clarify scheduling of different types of tasks.
diff --git a/lib/lifx/light_target.rb b/lib/lifx/light_target.rb index abc1234..def5678 100644 --- a/lib/lifx/light_target.rb +++ b/lib/lifx/light_target.rb @@ -1,7 +1,7 @@ module LIFX module LightTarget MSEC_PER_SEC = 1000 - def set_color(color, duration = LIFX::Config.default_duration) + def set_color...
Use keyword arguments for set_color
diff --git a/lita-vkontakte.gemspec b/lita-vkontakte.gemspec index abc1234..def5678 100644 --- a/lita-vkontakte.gemspec +++ b/lita-vkontakte.gemspec @@ -22,6 +22,6 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ['lib'] - spec.add_development_dependency 'bundler'...
Fix Bundler version (~> 1.7)
diff --git a/Casks/bettertouchtool.rb b/Casks/bettertouchtool.rb index abc1234..def5678 100644 --- a/Casks/bettertouchtool.rb +++ b/Casks/bettertouchtool.rb @@ -7,8 +7,8 @@ # bettertouchtool.com is the official download host per the vendor homepage url "http://bettertouchtool.net/btt#{version}.zip" else - ...
Update Better Touch Tool to 1.20
diff --git a/Casks/opera-developer.rb b/Casks/opera-developer.rb index abc1234..def5678 100644 --- a/Casks/opera-developer.rb +++ b/Casks/opera-developer.rb @@ -1,6 +1,6 @@ cask :v1 => 'opera-developer' do - version '30.0.1835.5' - sha256 'f4a8cd8860ac2836b420b9f0456b50629759465eba91bf472a30d529815ba0fa' + version '...
Upgrade Opera Developer.app to v31.0.1857.0
diff --git a/lib/socializer/engine.rb b/lib/socializer/engine.rb index abc1234..def5678 100644 --- a/lib/socializer/engine.rb +++ b/lib/socializer/engine.rb @@ -24,7 +24,7 @@ initializer "webpacker.proxy" do |app| insert_middleware = begin - Socializer.webpacker.config.dev_server...
Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
diff --git a/Casks/remote-desktop-manager.rb b/Casks/remote-desktop-manager.rb index abc1234..def5678 100644 --- a/Casks/remote-desktop-manager.rb +++ b/Casks/remote-desktop-manager.rb @@ -1,9 +1,9 @@ cask :v1 => 'remote-desktop-manager' do - version '1.1.11.0' - sha256 'f5e9ec3d2a3bea912e1686ee167f4dcca5643d504fd1ca...
Upgrade Remote Desktop Manager to version 2.0.4.0 Fixed newline at end of file.
diff --git a/Library/Formula/oxygen-icons.rb b/Library/Formula/oxygen-icons.rb index abc1234..def5678 100644 --- a/Library/Formula/oxygen-icons.rb +++ b/Library/Formula/oxygen-icons.rb @@ -1,9 +1,9 @@ require 'formula' class OxygenIcons <Formula - url 'ftp://ftp.kde.org/pub/kde/stable/4.4.0/src/oxygen-icons-4.4.0.t...
Update Oxygen icons to 4.4.1.
diff --git a/config/initializers/sidekiq.rb b/config/initializers/sidekiq.rb index abc1234..def5678 100644 --- a/config/initializers/sidekiq.rb +++ b/config/initializers/sidekiq.rb @@ -1,5 +1,3 @@-require 'sidekiq/middleware/i18n' - host = ENV.fetch('REDIS_HOST') { 'localhost' } port = ENV.fetch('REDIS_PORT') { 6379 ...
Remove unnecessary library from configuration
diff --git a/config/initializers/statsd.rb b/config/initializers/statsd.rb index abc1234..def5678 100644 --- a/config/initializers/statsd.rb +++ b/config/initializers/statsd.rb @@ -3,7 +3,7 @@ require "datadog/statsd" class StubStatsd - def increment; end + def increment(stat, opts={}); end end module GitHubCl...
Change increment method signature to match actual signature
diff --git a/app/models/promotion_spend_condition.rb b/app/models/promotion_spend_condition.rb index abc1234..def5678 100644 --- a/app/models/promotion_spend_condition.rb +++ b/app/models/promotion_spend_condition.rb @@ -6,6 +6,10 @@ metadata(:config) do float :amount, :required => true, :greater_than => 0, :d...
Fix summarising mimimum spend condition.
diff --git a/Casks/navicat-for-sql-server.rb b/Casks/navicat-for-sql-server.rb index abc1234..def5678 100644 --- a/Casks/navicat-for-sql-server.rb +++ b/Casks/navicat-for-sql-server.rb @@ -1,6 +1,6 @@ cask :v1 => 'navicat-for-sql-server' do - version '11.1.7' - sha256 '6f3d7e13d929395f92ccf040867fa80b3cf29651070a6473...
Update Navicat for SQL Server to 11.1.9
diff --git a/app/presenters/renalware/medications/treatable_presenter.rb b/app/presenters/renalware/medications/treatable_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/renalware/medications/treatable_presenter.rb +++ b/app/presenters/renalware/medications/treatable_presenter.rb @@ -4,7 +4,7 @@ modul...
Use more intention revealing predicate
diff --git a/app/models/url.rb b/app/models/url.rb index abc1234..def5678 100644 --- a/app/models/url.rb +++ b/app/models/url.rb @@ -3,7 +3,7 @@ :address, :name - validates_format_of :address, with: %r[https?://.+] + validates_format_of :address, with: %r[\Ah...
Improve Url address format validation By anchoring our regex at the beginning of the string, we prevent possibly incorrect addresses from slipping through the cracks. Change-Id: Ied867410dcb37d99f0a7c5fe3d435b7b26bbded8
diff --git a/app/forms/search_form.rb b/app/forms/search_form.rb index abc1234..def5678 100644 --- a/app/forms/search_form.rb +++ b/app/forms/search_form.rb @@ -0,0 +1,11 @@+class SearchForm < Reform::Form + property :q + + def initialize + super(OpenStruct.new) + end + + def self.property(name, options={}) + ...
Use a form object for search form
diff --git a/app/jobs/push_job.rb b/app/jobs/push_job.rb index abc1234..def5678 100644 --- a/app/jobs/push_job.rb +++ b/app/jobs/push_job.rb @@ -9,6 +9,11 @@ end def perform(post) + unless post.present? + logger.error('the post does not exist') + return + end + if post.stale? logger.w...
Check post existence before processing
diff --git a/db/migrate/20210312061725_add_replica_identity_for_roles.rb b/db/migrate/20210312061725_add_replica_identity_for_roles.rb index abc1234..def5678 100644 --- a/db/migrate/20210312061725_add_replica_identity_for_roles.rb +++ b/db/migrate/20210312061725_add_replica_identity_for_roles.rb @@ -0,0 +1,32 @@+# froz...
Set up replica identity index for Role refs FOO-1171 flag=none test plan: - migration works up and down - tests pass Change-Id: I3a45025a1b8f178de84d9511b0efe56546d701f1 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/260530 Tested-by: Service Cloud Jenkins <9144042a601061f88f1e1d7a1753ea3e2972119d@inst...
diff --git a/fixture_dependencies.gemspec b/fixture_dependencies.gemspec index abc1234..def5678 100644 --- a/fixture_dependencies.gemspec +++ b/fixture_dependencies.gemspec @@ -5,7 +5,7 @@ s.email = "code@jeremyevans.net" s.platform = Gem::Platform::RUBY s.summary = "Sequel/ActiveRecord fixture loader that hand...
Use a glob instead of specifically loading each lib file This should prevent future issues with missing lib files.
diff --git a/spec/use_cases/check_assignments/remind_pending_check_assignment_spec.rb b/spec/use_cases/check_assignments/remind_pending_check_assignment_spec.rb index abc1234..def5678 100644 --- a/spec/use_cases/check_assignments/remind_pending_check_assignment_spec.rb +++ b/spec/use_cases/check_assignments/remind_pend...
Add specs for `RemindPendingCheckAssignment` service
diff --git a/spec/controllers/spree/products_controller_spec.rb b/spec/controllers/spree/products_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/spree/products_controller_spec.rb +++ b/spec/controllers/spree/products_controller_spec.rb @@ -16,13 +16,9 @@ allow(controller).to receive(:before...
Remove code for Soldius 2.5 is specs
diff --git a/lib/gearman.rb b/lib/gearman.rb index abc1234..def5678 100644 --- a/lib/gearman.rb +++ b/lib/gearman.rb @@ -16,23 +16,33 @@ data ].join - socket = TCPSocket.new('localhost', '4730') + begin + socket = TCPSocket.new('localhost', '4730') + rescue => e + abort 'Co...
Remove timeout, rescue socket connection failures.
diff --git a/lib/keyring.rb b/lib/keyring.rb index abc1234..def5678 100644 --- a/lib/keyring.rb +++ b/lib/keyring.rb @@ -5,7 +5,7 @@ attr_accessor :keys, :path, :name def initialize(name, path, keys = []) - @name = name + @name = name.to_s @path = path @keys = keys end @@ -28,13 ...
[Keyring] Transform name to a string upon initialization
diff --git a/spec/scenario/config/initializers/session_store.rb b/spec/scenario/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/spec/scenario/config/initializers/session_store.rb +++ b/spec/scenario/config/initializers/session_store.rb @@ -6,3 +6,4 @@ # which shouldn't be used to store highly c...
Work around lack of logger silence
diff --git a/app/controllers/api/donations_controller.rb b/app/controllers/api/donations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/donations_controller.rb +++ b/app/controllers/api/donations_controller.rb @@ -1,6 +1,9 @@ class Api::DonationsController < ApplicationController respond_to :j...
[skip ci] Add documentation comment to donations controller
diff --git a/app/services/results/fill_event_template.rb b/app/services/results/fill_event_template.rb index abc1234..def5678 100644 --- a/app/services/results/fill_event_template.rb +++ b/app/services/results/fill_event_template.rb @@ -24,9 +24,9 @@ ranked_efforts = event.efforts.ranked_with_status if e...
Fix N+1 query problem in FillEventTemplate class
diff --git a/lib/flavors/preferences/preferences.rb b/lib/flavors/preferences/preferences.rb index abc1234..def5678 100644 --- a/lib/flavors/preferences/preferences.rb +++ b/lib/flavors/preferences/preferences.rb @@ -9,6 +9,10 @@ has_many :preferences, :as => :prefered, :class_name => "::Flavors::Preference" ...
Support Ruby naming convention for boolean getter procedures
diff --git a/app/admin/photos.rb b/app/admin/photos.rb index abc1234..def5678 100644 --- a/app/admin/photos.rb +++ b/app/admin/photos.rb @@ -23,11 +23,15 @@ link_to(photo.user.id, admin_user_path(photo.user)) end column :poi do |photo| - span do - [ - link_to(photo.poi.headline, adm...
Fix list of fotos in admin backend.
diff --git a/lib/smartdown/api/previous_question.rb b/lib/smartdown/api/previous_question.rb index abc1234..def5678 100644 --- a/lib/smartdown/api/previous_question.rb +++ b/lib/smartdown/api/previous_question.rb @@ -5,7 +5,7 @@ def_delegators :@question, :title, :options - attr_reader :response + a...
Make question available on previousquestion
diff --git a/app/lib/services.rb b/app/lib/services.rb index abc1234..def5678 100644 --- a/app/lib/services.rb +++ b/app/lib/services.rb @@ -15,6 +15,9 @@ end def self.link_checker_api - @link_checker_api ||= GdsApi::LinkCheckerApi.new(Plek.new.find("link-checker-api")) + @link_checker_api ||= GdsApi::Link...
Add bearer tokens for link-checker-api authentication
diff --git a/lib/tasks/sample_data/group_factory.rb b/lib/tasks/sample_data/group_factory.rb index abc1234..def5678 100644 --- a/lib/tasks/sample_data/group_factory.rb +++ b/lib/tasks/sample_data/group_factory.rb @@ -10,19 +10,21 @@ return if EnterpriseGroup.where(name: "Producer group").exists? create_group...
Fix group factory in rails 4 params[:address] was breaking the creation of the EnterpriseGroup
diff --git a/app/models/spree/license_key.rb b/app/models/spree/license_key.rb index abc1234..def5678 100644 --- a/app/models/spree/license_key.rb +++ b/app/models/spree/license_key.rb @@ -5,6 +5,8 @@ belongs_to :license_key_type, :class_name => "Spree::LicenseKeyType" attr_accessible :license_key, :inventor...
Add a scope for available Change-Id: I772a38d9b50dfbe763e3a5653512becc7ffaee1a
diff --git a/app/observers/cache_observer.rb b/app/observers/cache_observer.rb index abc1234..def5678 100644 --- a/app/observers/cache_observer.rb +++ b/app/observers/cache_observer.rb @@ -16,7 +16,7 @@ # Expires all cached data. def self.expire_all logit "invoked" - Rails.cache.delete_matched(//) + Rai...
Update cache clearing for Rails 3
diff --git a/app/validators/run_validator.rb b/app/validators/run_validator.rb index abc1234..def5678 100644 --- a/app/validators/run_validator.rb +++ b/app/validators/run_validator.rb @@ -24,7 +24,9 @@ # Embeds break for URLs like https://www.twitch.tv/videos/29447340?filter=highlights&sort=time, which is what T...
Fix a bug where YouTube video URLs get cut off
diff --git a/lib/adsf/rack/index_file_finder.rb b/lib/adsf/rack/index_file_finder.rb index abc1234..def5678 100644 --- a/lib/adsf/rack/index_file_finder.rb +++ b/lib/adsf/rack/index_file_finder.rb @@ -1,9 +1,9 @@ module Adsf::Rack class IndexFileFinder - def initialize(app, options) + def initialize(app, root:...
Refactor: Use keyword args in IndexFileFinder
diff --git a/lib/asciidoctor/doctest/version.rb b/lib/asciidoctor/doctest/version.rb index abc1234..def5678 100644 --- a/lib/asciidoctor/doctest/version.rb +++ b/lib/asciidoctor/doctest/version.rb @@ -1,5 +1,5 @@ module Asciidoctor module DocTest - VERSION = '1.5.1.2' + VERSION = '1.5.2.dev' end end
Prepare for next development iteration
diff --git a/lib/brightbox-cli/firewall_rule.rb b/lib/brightbox-cli/firewall_rule.rb index abc1234..def5678 100644 --- a/lib/brightbox-cli/firewall_rule.rb +++ b/lib/brightbox-cli/firewall_rule.rb @@ -21,12 +21,9 @@ def to_row attrs = attributes - attrs[:protocol] = attributes[:protocol] || '-' - ...
Use loop rather than assigning defaults one by one
diff --git a/matrix.gemspec b/matrix.gemspec index abc1234..def5678 100644 --- a/matrix.gemspec +++ b/matrix.gemspec @@ -4,20 +4,21 @@ require 'matrix/version' Gem::Specification.new do |spec| - spec.name = "matrix" + spec.name = 'matrix' spec.version = Matrix::VERSION - spec.authors ...
Update gemspec and add runtime dependency for activesupport.
diff --git a/proxy_fetcher.gemspec b/proxy_fetcher.gemspec index abc1234..def5678 100644 --- a/proxy_fetcher.gemspec +++ b/proxy_fetcher.gemspec @@ -18,7 +18,7 @@ gem.license = 'MIT' gem.required_ruby_version = '>= 2.0.0' - gem.add_runtime_dependency 'http', '~> 3.0' + gem.add_runtime_dependency 'http', '>= 3'...
Update http requirement from ~> 3.0 to >= 3, < 5 Updates the requirements on [http](https://github.com/httprb/http) to permit the latest version. - [Release notes](https://github.com/httprb/http/releases) - [Changelog](https://github.com/httprb/http/blob/master/CHANGES.md) - [Commits](https://github.com/httprb/http/co...
diff --git a/lib/specinfra/command/freebsd10.rb b/lib/specinfra/command/freebsd10.rb index abc1234..def5678 100644 --- a/lib/specinfra/command/freebsd10.rb +++ b/lib/specinfra/command/freebsd10.rb @@ -8,6 +8,14 @@ "pkg info #{escape(package)}" end end + + def install(package) + "pk...
Add install and get_package_version for FreeBSD10 like 34a45cf and 7c2a3da
diff --git a/lib/vault/rails/json_serializer.rb b/lib/vault/rails/json_serializer.rb index abc1234..def5678 100644 --- a/lib/vault/rails/json_serializer.rb +++ b/lib/vault/rails/json_serializer.rb @@ -7,13 +7,13 @@ }.freeze def self.encode(raw) - self._init! + _init! JSON.fast_ge...
Remove superfluous self in JSONSerializer
diff --git a/lib/writer/overwrite_prevention.rb b/lib/writer/overwrite_prevention.rb index abc1234..def5678 100644 --- a/lib/writer/overwrite_prevention.rb +++ b/lib/writer/overwrite_prevention.rb @@ -1,6 +1,6 @@ module Writer class OverwritePrevention - def self.adjust_name(name) + def self.adjust(name) ...
Change name of adjust method
diff --git a/test/functional/admin/transactions_controller_test.rb b/test/functional/admin/transactions_controller_test.rb index abc1234..def5678 100644 --- a/test/functional/admin/transactions_controller_test.rb +++ b/test/functional/admin/transactions_controller_test.rb @@ -4,7 +4,10 @@ setup do stub_request...
Move one more test over to use panopticon_has_metadata
diff --git a/config/initializers/ruby_22_polyfill.rb b/config/initializers/ruby_22_polyfill.rb index abc1234..def5678 100644 --- a/config/initializers/ruby_22_polyfill.rb +++ b/config/initializers/ruby_22_polyfill.rb @@ -4,13 +4,17 @@ unless instance_methods.include? :slice_when def slice_when(&block) rai...
Handle case of one item
diff --git a/bin/check-hardware-fail.rb b/bin/check-hardware-fail.rb index abc1234..def5678 100644 --- a/bin/check-hardware-fail.rb +++ b/bin/check-hardware-fail.rb @@ -30,12 +30,8 @@ class CheckHardwareFail < Sensu::Plugin::Check::CLI def run - errors = `dmesg`.lines.grep(/\[Hardware Error\]/) - # #YELLOW -...
Fix ruby utf8 byte sequence error
diff --git a/raygun_client.gemspec b/raygun_client.gemspec index abc1234..def5678 100644 --- a/raygun_client.gemspec +++ b/raygun_client.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'raygun_client' - s.version = '0.5.2.0' + s.version = '0.6.0.0' s.summary = 'Client f...
Package version is increased from 0.5.2.0 to 0.6.0.0
diff --git a/Casks/beyond-compare.rb b/Casks/beyond-compare.rb index abc1234..def5678 100644 --- a/Casks/beyond-compare.rb +++ b/Casks/beyond-compare.rb @@ -1,6 +1,6 @@ cask :v1 => 'beyond-compare' do - version '4.0.3.19420' - sha256 '2feb23098fa6fdc6885ef57fbea1a638a820f4eaeffbbd2e820ef7dc6272342f' + version '4.0.4...
Update Beyond Compare.app to 4.0.4.19477
diff --git a/ttc_notices/app/controllers/application_controller.rb b/ttc_notices/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/ttc_notices/app/controllers/application_controller.rb +++ b/ttc_notices/app/controllers/application_controller.rb @@ -1,5 +1,7 @@ class ApplicationController < A...
Allow HTTP Requests for JSON API-endpoints
diff --git a/config/initializers/settings.rb b/config/initializers/settings.rb index abc1234..def5678 100644 --- a/config/initializers/settings.rb +++ b/config/initializers/settings.rb @@ -23,8 +23,8 @@ # The configuration of shelves in the physical library. Only the first and last # book codes of each shelf need ...
Update the comment for the shelves setting
diff --git a/lib/hightops/tasks/hightops.rake b/lib/hightops/tasks/hightops.rake index abc1234..def5678 100644 --- a/lib/hightops/tasks/hightops.rake +++ b/lib/hightops/tasks/hightops.rake @@ -12,7 +12,7 @@ desc 'Stop hightops' task :stop_hightops do on roles fetch(:hightops_role, :app) do - if test("[ -...
Fix error raised while checking pidfile
diff --git a/lib/ffi-glib/list_methods.rb b/lib/ffi-glib/list_methods.rb index abc1234..def5678 100644 --- a/lib/ffi-glib/list_methods.rb +++ b/lib/ffi-glib/list_methods.rb @@ -36,11 +36,11 @@ end def tail - self.class.wrap(element_type, @struct[:next]) + self.class.wrap(element_type, struct[:next]...
Use struct accessor in List methods too
diff --git a/lib/sprockets/environment.rb b/lib/sprockets/environment.rb index abc1234..def5678 100644 --- a/lib/sprockets/environment.rb +++ b/lib/sprockets/environment.rb @@ -1,8 +1,14 @@ module Sprockets class Environment + class << self + attr_accessor :extensions + end + + self.extensions = %w( co...
Expand extensions and move them to a class attr_accessor
diff --git a/lib/userbin/support/rails.rb b/lib/userbin/support/rails.rb index abc1234..def5678 100644 --- a/lib/userbin/support/rails.rb +++ b/lib/userbin/support/rails.rb @@ -1,7 +1,7 @@ module Userbin module UserbinClient def userbin - @userbin ||= Userbin::Client.new(request, response) + @userbin ...
Use client from env if present
diff --git a/tasks/ci.rake b/tasks/ci.rake index abc1234..def5678 100644 --- a/tasks/ci.rake +++ b/tasks/ci.rake @@ -2,11 +2,10 @@ file "lib/libsodium.so" => :build_libsodium do cp $LIBSODIUM_PATH, "lib/libsodium.so" - system "nm lib/libsodium.so" end task "ci:sodium" => "lib/libsodium.so" task :ci => %w(c...
Revert "Dump libsodium symbols in CI environment" This reverts commit f23acf9e5cc69a032afd3839dc2084a02a3c924c.
diff --git a/examples/socket.rb b/examples/socket.rb index abc1234..def5678 100644 --- a/examples/socket.rb +++ b/examples/socket.rb @@ -0,0 +1,35 @@+ +$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib')) + +require 'minx' +require 'minx/io' +require 'socket' + +include ::Socket::Constants + +sockaddr = S...
Add example of Socket usage
diff --git a/app/models/manageiq/providers/embedded_automation_manager.rb b/app/models/manageiq/providers/embedded_automation_manager.rb index abc1234..def5678 100644 --- a/app/models/manageiq/providers/embedded_automation_manager.rb +++ b/app/models/manageiq/providers/embedded_automation_manager.rb @@ -6,6 +6,10 @@ ...
Disable creation of embedded automation managers
diff --git a/lib/gitlab/repository_cache.rb b/lib/gitlab/repository_cache.rb index abc1234..def5678 100644 --- a/lib/gitlab/repository_cache.rb +++ b/lib/gitlab/repository_cache.rb @@ -7,13 +7,13 @@ def initialize(repository, extra_namespace: nil, backend: Rails.cache) @repository = repository - @name...
Change project cache key to depend on ID instead of full path Previously, project cache used as part of the namespace the `full_path`, which included namespace and project slug. That meant that anytime a project was renamed or transfered to a different namespace, we would lose the existing cache. This is not necessar...
diff --git a/lib/imap/backup/cli/restore.rb b/lib/imap/backup/cli/restore.rb index abc1234..def5678 100644 --- a/lib/imap/backup/cli/restore.rb +++ b/lib/imap/backup/cli/restore.rb @@ -7,6 +7,7 @@ attr_reader :account_names def initialize(email = nil, options) + super([]) @email = email @a...
Add missing initializer for parent
diff --git a/lib/semi_auto/configuration.rb b/lib/semi_auto/configuration.rb index abc1234..def5678 100644 --- a/lib/semi_auto/configuration.rb +++ b/lib/semi_auto/configuration.rb @@ -15,7 +15,6 @@ def read @configurations = YAML.load(file.read) if file - puts @configurations.inspect load_wi...
Remove puts added for debugging
diff --git a/lib/veritas/algebra/product.rb b/lib/veritas/algebra/product.rb index abc1234..def5678 100644 --- a/lib/veritas/algebra/product.rb +++ b/lib/veritas/algebra/product.rb @@ -16,12 +16,12 @@ end def body - @body ||= multiply_bodies + @body ||= join_bodies end priva...
Rename method to match the intention better
diff --git a/core/app/finders/spree/line_item/find_by_variant.rb b/core/app/finders/spree/line_item/find_by_variant.rb index abc1234..def5678 100644 --- a/core/app/finders/spree/line_item/find_by_variant.rb +++ b/core/app/finders/spree/line_item/find_by_variant.rb @@ -1,5 +1,5 @@ module Spree - class LineItem + class...
Add correct base class for LineItem class in FindByVariant finder
diff --git a/db/migrate/20130110042952_add_completed_to_talks.rb b/db/migrate/20130110042952_add_completed_to_talks.rb index abc1234..def5678 100644 --- a/db/migrate/20130110042952_add_completed_to_talks.rb +++ b/db/migrate/20130110042952_add_completed_to_talks.rb @@ -1,10 +1,5 @@ class AddCompletedToTalks < ActiveReco...
Remove completed talk migration update all to pass tests
diff --git a/spec/controllers/application_controller_spec.rb b/spec/controllers/application_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/application_controller_spec.rb +++ b/spec/controllers/application_controller_spec.rb @@ -0,0 +1,27 @@+require 'spec_helper' + +describe ApplicationControlle...
Add specs testing single page app rending and login redirect
diff --git a/spec/controllers/attachments_controller_spec.rb b/spec/controllers/attachments_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/attachments_controller_spec.rb +++ b/spec/controllers/attachments_controller_spec.rb @@ -13,6 +13,10 @@ get :download, :id => attachment.id res...
Throw 404 if attachment can not be found.
diff --git a/spec/controllers/test_emails_controller_spec.rb b/spec/controllers/test_emails_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/test_emails_controller_spec.rb +++ b/spec/controllers/test_emails_controller_spec.rb @@ -0,0 +1,10 @@+require 'spec_helper' + +describe TestEmailsController...
Add simple (partial) test for TestEmailsController
diff --git a/Library/Homebrew/build_environment.rb b/Library/Homebrew/build_environment.rb index abc1234..def5678 100644 --- a/Library/Homebrew/build_environment.rb +++ b/Library/Homebrew/build_environment.rb @@ -29,11 +29,11 @@ end def _dump(*) - @settings.to_a.join(":") + Marshal.dump(@settings) end ...
Remove knowledge of serialization details by marshaling twice
diff --git a/omniauth-remote-user.gemspec b/omniauth-remote-user.gemspec index abc1234..def5678 100644 --- a/omniauth-remote-user.gemspec +++ b/omniauth-remote-user.gemspec @@ -10,8 +10,8 @@ gem.homepage = 'http://beta.softwarepublico.gov.br/gitlab/softwarepublico/omniauth-remote-user' gem.authors = ['Lucas Kanash...
Apply correct gem.files with Dir - Removing gem.files with git - Removing unecessary gem.test_files
diff --git a/fluent-plugin-juniper-telemetry.gemspec b/fluent-plugin-juniper-telemetry.gemspec index abc1234..def5678 100644 --- a/fluent-plugin-juniper-telemetry.gemspec +++ b/fluent-plugin-juniper-telemetry.gemspec @@ -4,7 +4,7 @@ Gem::Specification.new do |s| s.name = "fluent-plugin-juniper-telemetry" ...
Update gem spec to 2.5.0 and add protobof as requirement
diff --git a/plugins/providers/virtualbox/plugin.rb b/plugins/providers/virtualbox/plugin.rb index abc1234..def5678 100644 --- a/plugins/providers/virtualbox/plugin.rb +++ b/plugins/providers/virtualbox/plugin.rb @@ -14,7 +14,7 @@ Provider end - config(:virtualbox, :provider => :virtualbox) do + ...
Set the virtualbox config scope
diff --git a/script/import_ikiwiki.rb b/script/import_ikiwiki.rb index abc1234..def5678 100644 --- a/script/import_ikiwiki.rb +++ b/script/import_ikiwiki.rb @@ -1,6 +1,6 @@ require "nokogiri" -doc = Nokogiri::HTML(open(ARGV[0])) +doc = Nokogiri::HTML($stdin) doc.css('#content p').each do |p| begin quote = Qu...
Make import script read from stdin Using ARGV conflicts with passing an --environment argument to rails runner
diff --git a/lib/codelation/development/atom_packages.rb b/lib/codelation/development/atom_packages.rb index abc1234..def5678 100644 --- a/lib/codelation/development/atom_packages.rb +++ b/lib/codelation/development/atom_packages.rb @@ -18,7 +18,6 @@ # Install Atom.app Packages def install_atom_packages ...
Remove color-picker from Atom packages to install
diff --git a/spec/ffi/fork_spec.rb b/spec/ffi/fork_spec.rb index abc1234..def5678 100644 --- a/spec/ffi/fork_spec.rb +++ b/spec/ffi/fork_spec.rb @@ -5,8 +5,7 @@ require File.expand_path(File.join(File.dirname(__FILE__), "spec_helper")) -# Skip platforms that don't implement Process.fork -unless RUBY_ENGINE == "truf...
Improve check for whether fork is available
diff --git a/spec/language_spec.rb b/spec/language_spec.rb index abc1234..def5678 100644 --- a/spec/language_spec.rb +++ b/spec/language_spec.rb @@ -0,0 +1,57 @@+require 'Language' +Dir[File.dirname(__FILE__) + "/../lib/errors/*.rb"].each {|file| require file } + +RSpec.describe Language do + context "default" do + ...
Add some tests for english strings
diff --git a/spec/lib/base_spec.rb b/spec/lib/base_spec.rb index abc1234..def5678 100644 --- a/spec/lib/base_spec.rb +++ b/spec/lib/base_spec.rb @@ -41,4 +41,15 @@ subject.should respond_to :presenter end end + + context 'actions' do + it 'has an action method' do + subject.should respond_to :act...
Add spec for actions on base spec.
diff --git a/lib/octokit/enterprise_admin_client/orgs.rb b/lib/octokit/enterprise_admin_client/orgs.rb index abc1234..def5678 100644 --- a/lib/octokit/enterprise_admin_client/orgs.rb +++ b/lib/octokit/enterprise_admin_client/orgs.rb @@ -17,6 +17,8 @@ # @example # @admin_client.create_organization('SuchAG...
Fix org creation to include login and admin.
diff --git a/lib/serverkit/resources/homebrew_package.rb b/lib/serverkit/resources/homebrew_package.rb index abc1234..def5678 100644 --- a/lib/serverkit/resources/homebrew_package.rb +++ b/lib/serverkit/resources/homebrew_package.rb @@ -7,7 +7,7 @@ def apply run_command( ::Specinfra::Command::...
Fix bug on installation of nested package name
diff --git a/retryable.gemspec b/retryable.gemspec index abc1234..def5678 100644 --- a/retryable.gemspec +++ b/retryable.gemspec @@ -3,6 +3,7 @@ Gem::Specification.new do |gem| gem.add_development_dependency 'bundler', '~> 1.0' + gem.add_development_dependency 'pry', '~> 0.10' gem.authors = ["Nikita Fedyashev"...
Add pry as development dependency so that debug is easier next time(and you don't need to temporarily add it again)
diff --git a/activerecord/lib/active_record/associations/builder/singular_association.rb b/activerecord/lib/active_record/associations/builder/singular_association.rb index abc1234..def5678 100644 --- a/activerecord/lib/active_record/associations/builder/singular_association.rb +++ b/activerecord/lib/active_record/asso...
Move define_constructors to class level
diff --git a/test/acts_as_approvable_ownership_test.rb b/test/acts_as_approvable_ownership_test.rb index abc1234..def5678 100644 --- a/test/acts_as_approvable_ownership_test.rb +++ b/test/acts_as_approvable_ownership_test.rb @@ -0,0 +1,41 @@+require 'test_helper' + +class ActsAsApprovableOwnershipTest < Test::Unit::Tes...
Test that configuration of ownership works
diff --git a/test/fixtures/cookbooks/test/recipes/package.rb b/test/fixtures/cookbooks/test/recipes/package.rb index abc1234..def5678 100644 --- a/test/fixtures/cookbooks/test/recipes/package.rb +++ b/test/fixtures/cookbooks/test/recipes/package.rb @@ -13,5 +13,5 @@ end hab_package 'core/hab-sup' do - bldr_url 'htt...
Use the correct acceptance URL for builder Signed-off-by: Joshua Timberman <d6955d9721560531274cb8f50ff595a9bd39d66f@chef.io>
diff --git a/db/data_migrations/20200203221840_add_long_lat_query_tool.rb b/db/data_migrations/20200203221840_add_long_lat_query_tool.rb index abc1234..def5678 100644 --- a/db/data_migrations/20200203221840_add_long_lat_query_tool.rb +++ b/db/data_migrations/20200203221840_add_long_lat_query_tool.rb @@ -1,11 +1,18 @@ c...
Add and change syntax of query tool migrations for postgres compatibility.
diff --git a/app/helpers/artifacts_helper.rb b/app/helpers/artifacts_helper.rb index abc1234..def5678 100644 --- a/app/helpers/artifacts_helper.rb +++ b/app/helpers/artifacts_helper.rb @@ -1,6 +1,6 @@ module ArtifactsHelper def temportal_facet_path(params, low, high) - artifacts_path(params.dup.update(low_date: l...
Reset page to 0 when changing filter.
diff --git a/app/models/ci/build_metadata.rb b/app/models/ci/build_metadata.rb index abc1234..def5678 100644 --- a/app/models/ci/build_metadata.rb +++ b/app/models/ci/build_metadata.rb @@ -10,9 +10,7 @@ self.table_name = 'ci_builds_metadata' - belongs_to :build, class_name: 'CommitStatus', - ...
Simplify relation between a build and metadata This removes erroneously defined polymorphic association, because specifying `belongs_to` relationship with a class that already supports polymorphic associations works out-of-the-box.
diff --git a/select2_helper.gemspec b/select2_helper.gemspec index abc1234..def5678 100644 --- a/select2_helper.gemspec +++ b/select2_helper.gemspec @@ -17,7 +17,7 @@ s.files = Dir['{app,config,db,lib}/**/*', 'MIT-LICENSE', 'Rakefile', 'README.rdoc'] s.test_files = Dir['test/**/*'] - s.add_dependency 'rails', '...
Set gemsspec to be compatible with 4.2
diff --git a/app/decorators/service_template_decorator.rb b/app/decorators/service_template_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/service_template_decorator.rb +++ b/app/decorators/service_template_decorator.rb @@ -8,6 +8,10 @@ end def fileicon - try(:picture) ? "/pictures/#{picture....
Add single_quad definition for the ServiceTemplate model
diff --git a/examples/formats.rb b/examples/formats.rb index abc1234..def5678 100644 --- a/examples/formats.rb +++ b/examples/formats.rb @@ -2,10 +2,9 @@ require 'tty-spinner' -TTY::Formats::FORMATS.size.times do |i| - format = "spin_#{i+1}" - options = {format: format.to_sym, hide_cursor: true} - spinner = TTY:...
Change to update to use new names.
diff --git a/spec/integration/connect/spec/with_capybara_spec.rb b/spec/integration/connect/spec/with_capybara_spec.rb index abc1234..def5678 100644 --- a/spec/integration/connect/spec/with_capybara_spec.rb +++ b/spec/integration/connect/spec/with_capybara_spec.rb @@ -2,9 +2,9 @@ describe "Capybara" do describe "Wi...
Remove content of connect capybara spec. Not sure what this was trying to achieve, but the current behaviour doesn't start a server unless started from rspec.