diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/kafka_connection.rb b/lib/kafka_connection.rb index abc1234..def5678 100644 --- a/lib/kafka_connection.rb +++ b/lib/kafka_connection.rb @@ -5,7 +5,7 @@ require "kafka_connection/pool" module KafkaConnection - def self.new(app_name:, env_name:, pool_idx:) + def self.new(app_name:, env_name:, pool_i...
Fix required variable pool_idx that should not be
diff --git a/Formula/jake.rb b/Formula/jake.rb index abc1234..def5678 100644 --- a/Formula/jake.rb +++ b/Formula/jake.rb @@ -0,0 +1,14 @@+require 'formula' + +class Jake <Formula + head 'git://github.com/280north/jake.git' + homepage 'http://github.com/280north/jake' + + depends_on 'narwhal' + + def install + li...
Add Jake build tool formula Signed-off-by: Adam Vandenberg <34c2b6407fd5a10249a15d699d40f9ed1782e98c@gmail.com>
diff --git a/lib/pod/command/open.rb b/lib/pod/command/open.rb index abc1234..def5678 100644 --- a/lib/pod/command/open.rb +++ b/lib/pod/command/open.rb @@ -5,9 +5,14 @@ self.summary = 'Open the workspace' self.description = <<-DESC Opens the workspace in xcode. If no workspace found in the curren...
Use option syntax for '-a'. Fixes a warning with newer versions of CLAide.
diff --git a/lib/sfn-vault/inject.rb b/lib/sfn-vault/inject.rb index abc1234..def5678 100644 --- a/lib/sfn-vault/inject.rb +++ b/lib/sfn-vault/inject.rb @@ -2,31 +2,17 @@ module SparkleAttribute module Aws - require 'vault' - require 'securerandom' - - # Polluting SparkleFormation::SparkleAttrib...
Simplify DSL helper method: vault_parameter! This simplifies the vault helper method provided to the template DSL to simply insert a named parameter with a generic description and NoEcho set. This parameter uses a custom type that is not recognized by AWS and will cause a validation error if not replaced. The templat...
diff --git a/Formula/rats.rb b/Formula/rats.rb index abc1234..def5678 100644 --- a/Formula/rats.rb +++ b/Formula/rats.rb @@ -0,0 +1,13 @@+require 'formula' + +class Rats < Formula + url 'http://www.fortify.com/servlet/download/public/rats-2.3.tar.gz' + homepage 'http://www.fortify.com/security-resources/rats.jsp' + ...
Add a formula for RATS. RATS - Rough Auditing Tool for Security http://www.fortify.com/security-resources/rats.jsp Signed-off-by: Adam Vandenberg <flangy@gmail.com> * Tweaked mandir
diff --git a/lib/util/config_file.rb b/lib/util/config_file.rb index abc1234..def5678 100644 --- a/lib/util/config_file.rb +++ b/lib/util/config_file.rb @@ -16,10 +16,10 @@ end def get(property) - @properties[property] || raise("No #{property} property found in #{@filename}") + return @properties[property]...
Revert "Blow up if we ask for an undefined property, stopping us interpolating madness" This reverts commit 6cc3a2a6ce96103aa857d77a2d94167059410bb6.
diff --git a/lib/web_console/repl.rb b/lib/web_console/repl.rb index abc1234..def5678 100644 --- a/lib/web_console/repl.rb +++ b/lib/web_console/repl.rb @@ -1,39 +1,41 @@ module WebConsole module REPL - class << self - # The adapters registry. - # - # Don't manually alter the registry, use +WebCons...
Drop a level of indentation by extending self
diff --git a/app/helpers/application_helper/button/vm_snapshot_add.rb b/app/helpers/application_helper/button/vm_snapshot_add.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper/button/vm_snapshot_add.rb +++ b/app/helpers/application_helper/button/vm_snapshot_add.rb @@ -1,16 +1,10 @@ class Application...
Allow user to create snapshot without an active snapshot https://bugzilla.redhat.com/show_bug.cgi?id=1425591
diff --git a/activerecord/test/cases/adapters/sqlite3/sqlite3_create_folder_test.rb b/activerecord/test/cases/adapters/sqlite3/sqlite3_create_folder_test.rb index abc1234..def5678 100644 --- a/activerecord/test/cases/adapters/sqlite3/sqlite3_create_folder_test.rb +++ b/activerecord/test/cases/adapters/sqlite3/sqlite3_c...
Fix test failure on Windows When this test was run on Windows, the database file would still be in use, and `File.unlink` would fail. This would cause the temp directory to be unable to be removed, and error out. By disconnecting the connection when finished, we can avoid this error.
diff --git a/elements.gemspec b/elements.gemspec index abc1234..def5678 100644 --- a/elements.gemspec +++ b/elements.gemspec @@ -24,6 +24,7 @@ s.add_dependency 'awesome_nested_set' s.add_dependency 'carrierwave' s.add_dependency 'mini_magick' + s.add_dependency 'devise' s.add_development_dependency 'mysql...
Add device to gem spec
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -10,6 +10,10 @@ erb :what, :body => "wat" end + get '/greeting' do + erb :what, :body => "Hello #{params["name"]}" + end + get '/' do haml :index, :body => "index" end
Add one more route taking a parameter.
diff --git a/lib/gir_ffi/builders/class_struct_builder.rb b/lib/gir_ffi/builders/class_struct_builder.rb index abc1234..def5678 100644 --- a/lib/gir_ffi/builders/class_struct_builder.rb +++ b/lib/gir_ffi/builders/class_struct_builder.rb @@ -14,16 +14,27 @@ raise "Info does not represent gtype_struct" unless inf...
Raise approppriate error when parent class info cannot be found
diff --git a/config/initializers/assets.rb b/config/initializers/assets.rb index abc1234..def5678 100644 --- a/config/initializers/assets.rb +++ b/config/initializers/assets.rb @@ -0,0 +1,8 @@+Rails.application.config.assets.version = '1.0' + +# Add folder with webpack generated assets to assets.paths +Rails.applicatio...
Make webpack folder visible to rails asset pipeline
diff --git a/config/initializers/assets.rb b/config/initializers/assets.rb index abc1234..def5678 100644 --- a/config/initializers/assets.rb +++ b/config/initializers/assets.rb @@ -21,4 +21,6 @@ 'vendor' ) -Rails.application.config.assets.precompile << 'moj.slot-picker/dist/stylesheets/**/*.png' +Rails.application...
Add slot picker stylesheets to precompile list
diff --git a/config/initializers/paypal.rb b/config/initializers/paypal.rb index abc1234..def5678 100644 --- a/config/initializers/paypal.rb +++ b/config/initializers/paypal.rb @@ -0,0 +1,15 @@+# Fixes the issue about some PayPal requests failing with +# OpenSSL::SSL::SSLError (SSL_connect returned=1 errno=0 state=erro...
Bring in Paypal certificates hack via new initializer
diff --git a/MiawKit.podspec b/MiawKit.podspec index abc1234..def5678 100644 --- a/MiawKit.podspec +++ b/MiawKit.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'MiawKit' - s.version = 'v1.2' + s.version = '1.2' s.license = { :type => 'MIT', :file => 'LICENSE' } ...
Fix that damn version number
diff --git a/specs/ishigaki-internal/controls/tidy_files.rb b/specs/ishigaki-internal/controls/tidy_files.rb index abc1234..def5678 100644 --- a/specs/ishigaki-internal/controls/tidy_files.rb +++ b/specs/ishigaki-internal/controls/tidy_files.rb @@ -45,4 +45,10 @@ end + %w[src.zip demo man sample].each do |cruft|...
Check that Java has been trimmed
diff --git a/web/app.rb b/web/app.rb index abc1234..def5678 100644 --- a/web/app.rb +++ b/web/app.rb @@ -13,10 +13,10 @@ schema_info: Domain.schema_info.first.version, schema_info_metrics: Domain.schema_info_metrics.first.version }, - counts: Domain.entities.inject({}) do |hash, entity| - ...
Remove the counts for now.
diff --git a/resque-priority_enqueue.gemspec b/resque-priority_enqueue.gemspec index abc1234..def5678 100644 --- a/resque-priority_enqueue.gemspec +++ b/resque-priority_enqueue.gemspec @@ -14,7 +14,6 @@ spec.license = "MIT" spec.add_runtime_dependency "resque", "~> 1.19" - spec.add_runtime_dependency "deb...
Remove debugger as a dependency for this gem
diff --git a/test/server/metrics.rb b/test/server/metrics.rb index abc1234..def5678 100644 --- a/test/server/metrics.rb +++ b/test/server/metrics.rb @@ -12,5 +12,5 @@ errors:0, warnings:0, skips:0, - duration:200, + duration:2, }
Reduce server-test max duration to 2 seconds
diff --git a/ext/edn_turbo/extconf.rb b/ext/edn_turbo/extconf.rb index abc1234..def5678 100644 --- a/ext/edn_turbo/extconf.rb +++ b/ext/edn_turbo/extconf.rb @@ -2,18 +2,18 @@ require 'mkmf' -HEADER_DIRS = [ +header_dirs = [ '/usr/local/include', '/usr/local/opt/icu4c/include', '/usr/include' ].freeze -L...
Fix dir_config usage to specify paths for icuuc.
diff --git a/app/controllers/alerts_controller.rb b/app/controllers/alerts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/alerts_controller.rb +++ b/app/controllers/alerts_controller.rb @@ -5,7 +5,8 @@ def welcome message = "Thanks, #{current_user.name}! You should be receiving a confirmation ...
Move back to immediate sending of welcome text message since it is costing me money to run background workers on Heroku
diff --git a/apns-s3.gemspec b/apns-s3.gemspec index abc1234..def5678 100644 --- a/apns-s3.gemspec +++ b/apns-s3.gemspec @@ -25,4 +25,5 @@ spec.add_development_dependency "bundler", "~> 1.7" spec.add_development_dependency "rake", "~> 10.0" + spec.add_development_dependency "test-unit", "~> 3.1.2" end
Use test-unit gem ~> 3.1.2
diff --git a/SwiftJose.podspec b/SwiftJose.podspec index abc1234..def5678 100644 --- a/SwiftJose.podspec +++ b/SwiftJose.podspec @@ -12,4 +12,5 @@ spec.source_files = "SwiftJose/**/*.{h, swift}" ## SwCrypt dependency?? + spec.dependency = "SwCrypt" end
Add SwCrypt dependency to podspec
diff --git a/finstyle.gemspec b/finstyle.gemspec index abc1234..def5678 100644 --- a/finstyle.gemspec +++ b/finstyle.gemspec @@ -19,7 +19,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_dependency("rubocop", "0.24.1") + spec.add_dependency("ruboco...
Upgrade to RuboCop 0.25.0 dependency.
diff --git a/SGImageCache.podspec b/SGImageCache.podspec index abc1234..def5678 100644 --- a/SGImageCache.podspec +++ b/SGImageCache.podspec @@ -7,7 +7,7 @@ s.license = { :type => "BSD", :file => "LICENSE" } s.author = "SeatGeek" s.platform = :ios, "7.0" - s.source = { :git => "https://git...
Revert source changes in podspec
diff --git a/lib/foodcritic/rules/fc025.rb b/lib/foodcritic/rules/fc025.rb index abc1234..def5678 100644 --- a/lib/foodcritic/rules/fc025.rb +++ b/lib/foodcritic/rules/fc025.rb @@ -1,8 +1,10 @@ rule "FC025", "Prefer chef_gem to compile-time gem install" do tags %w{correctness deprecated} recipe do |ast| + # wh...
Fix FC025 for Ruby 2.5 There's new elements and this is a VERY specific query which blows up with the extra elements. Hopefully this is the only one. Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/config/initializers/mail.rb b/config/initializers/mail.rb index abc1234..def5678 100644 --- a/config/initializers/mail.rb +++ b/config/initializers/mail.rb @@ -7,14 +7,14 @@ ActionMailer::Base.smtp_settings = { :address => "smtp.mandrillapp.com", :port => 587, - :user_name => options[...
Read env variables for Mandrill api_key, username, and password.
diff --git a/lib/rom/commands/composite.rb b/lib/rom/commands/composite.rb index abc1234..def5678 100644 --- a/lib/rom/commands/composite.rb +++ b/lib/rom/commands/composite.rb @@ -1,18 +1,44 @@ module ROM module Commands + # Composite command that consists of left and right commands + # + # @public cl...
Add yard docs for Commands::Composite
diff --git a/spec/features/dashboard_spec.rb b/spec/features/dashboard_spec.rb index abc1234..def5678 100644 --- a/spec/features/dashboard_spec.rb +++ b/spec/features/dashboard_spec.rb @@ -12,8 +12,6 @@ expect(page).to have_link("Download Report (PDF)", href: pdf_download_path(user)) - expect_nav_bar - ...
Remove test for demo link in nav bar
diff --git a/lib/jekyll_picture_tag/generated_image.rb b/lib/jekyll_picture_tag/generated_image.rb index abc1234..def5678 100644 --- a/lib/jekyll_picture_tag/generated_image.rb +++ b/lib/jekyll_picture_tag/generated_image.rb @@ -4,12 +4,14 @@ require 'mini_magick' require 'fastimage' + attr_reader :width + d...
Enable generated image to handle missing source files
diff --git a/spec/factories/raw_entity_ids.rb b/spec/factories/raw_entity_ids.rb index abc1234..def5678 100644 --- a/spec/factories/raw_entity_ids.rb +++ b/spec/factories/raw_entity_ids.rb @@ -1,5 +1,5 @@ FactoryGirl.define do - factory :raw_entity_id, class: EntityId do + factory :raw_entity_id, class: 'EntityId' do...
Correct Factory bug identified by CI schema:load
diff --git a/libraries/httpd_service_debian_systemd.rb b/libraries/httpd_service_debian_systemd.rb index abc1234..def5678 100644 --- a/libraries/httpd_service_debian_systemd.rb +++ b/libraries/httpd_service_debian_systemd.rb @@ -0,0 +1,107 @@+module HttpdCookbook + class HttpdServiceDebianSystemd < HttpdServiceDebian ...
Add basic systemd provider for debian systems Very basic systemd provider for debian systems.
diff --git a/chef/lib/chef/provider/ruby_block.rb b/chef/lib/chef/provider/ruby_block.rb index abc1234..def5678 100644 --- a/chef/lib/chef/provider/ruby_block.rb +++ b/chef/lib/chef/provider/ruby_block.rb @@ -21,7 +21,6 @@ class Provider class RubyBlock < Chef::Provider def load_current_resource - ...
CHEF-882: Disable some extremely verbose debugging output slowing down chef runs.
diff --git a/griddler.gemspec b/griddler.gemspec index abc1234..def5678 100644 --- a/griddler.gemspec +++ b/griddler.gemspec @@ -24,6 +24,7 @@ s.add_dependency 'htmlentities' s.add_development_dependency 'rspec-rails' s.add_development_dependency 'sqlite3' + s.add_development_dependency 'pry' # jquery-rails...
Add pry to help debugging during development
diff --git a/plugins/link_github_issues.rb b/plugins/link_github_issues.rb index abc1234..def5678 100644 --- a/plugins/link_github_issues.rb +++ b/plugins/link_github_issues.rb @@ -13,7 +13,7 @@ class Cinch::LinkGitHubIssues include Cinch::Plugin - match %r{([\w-]{3,}) ?#(\d{1,4})}, :use_prefix => false + match ...
Allow dots in project name for linking issues This is needed at least for the homepage ('easy-rpg.org').
diff --git a/test/integration/specialist_document_search_test.rb b/test/integration/specialist_document_search_test.rb index abc1234..def5678 100644 --- a/test/integration/specialist_document_search_test.rb +++ b/test/integration/specialist_document_search_test.rb @@ -32,6 +32,6 @@ first_result = parsed_response["r...
Use assert_equal in a test So that we can see what it's failing on.
diff --git a/subst_attr.gemspec b/subst_attr.gemspec index abc1234..def5678 100644 --- a/subst_attr.gemspec +++ b/subst_attr.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'subst_attr' - s.version = '0.0.1.4' + s.version = '0.0.1.5' s.summary = 'Declare attributes that...
Increase version from 0.0.1.4 to 0.0.1.5
diff --git a/app/models/tree.rb b/app/models/tree.rb index abc1234..def5678 100644 --- a/app/models/tree.rb +++ b/app/models/tree.rb @@ -7,7 +7,8 @@ @entries = Gitlab::Git::Tree.where(git_repo, sha, path) if readme_tree = @entries.find(&:readme?) - @readme = Gitlab::Git::Blob.find(git_repo, sha, readme_...
Fix README detection for subdir
diff --git a/app/models/vote.rb b/app/models/vote.rb index abc1234..def5678 100644 --- a/app/models/vote.rb +++ b/app/models/vote.rb @@ -1,13 +1,11 @@ class Vote < ActiveRecord::Base - after_save :update_parent_vote_total - - belongs_to :candidate, class_name: 'User' + after_save :update_parent_vote_total +...
Change validations on the Vote model. Presence true is redundant if another validation is being performed.
diff --git a/_ext/pipeline.rb b/_ext/pipeline.rb index abc1234..def5678 100644 --- a/_ext/pipeline.rb +++ b/_ext/pipeline.rb @@ -22,10 +22,10 @@ extension Awestruct::Extensions::Symlinker.new extension Awestruct::Extensions::Posts.new('/news', :posts) extension Awestruct::Extensions::Paginator.new(:posts, '/new...
Fix links in atom feed
diff --git a/test/test_hijri.rb b/test/test_hijri.rb index abc1234..def5678 100644 --- a/test/test_hijri.rb +++ b/test/test_hijri.rb @@ -24,15 +24,8 @@ g = Date.new 2008, 12, 29 assert_equal(g , h.to_greo) end - - # def test_georigean_converter - # (1..12).each do |m| - # (1..30).each do |d| - ...
Remove old test method and add some todos
diff --git a/lib/generators/paul_revere/paul_revere_generator.rb b/lib/generators/paul_revere/paul_revere_generator.rb index abc1234..def5678 100644 --- a/lib/generators/paul_revere/paul_revere_generator.rb +++ b/lib/generators/paul_revere/paul_revere_generator.rb @@ -3,7 +3,7 @@ class PaulRevereGenerator < Rails::Gene...
Improve the copy for the rails generator help Makes it slightly more explicit what running the generator will do to your Rails application.
diff --git a/spec/factories/parcels.rb b/spec/factories/parcels.rb index abc1234..def5678 100644 --- a/spec/factories/parcels.rb +++ b/spec/factories/parcels.rb @@ -5,9 +5,9 @@ description "pet cat" pickup_by Date.parse('1995-03-03') deliver_by Date.parse('1995-04-04') - origin_address_id 1 - destin...
Use factory girl associations for addresses
diff --git a/spec/models/order_spec.rb b/spec/models/order_spec.rb index abc1234..def5678 100644 --- a/spec/models/order_spec.rb +++ b/spec/models/order_spec.rb @@ -1,9 +1,14 @@ require 'rails_helper' RSpec.describe Order, type: :model do + customer = Customer.create(first_name: 'Jon', last_name: 'Chen') + order =...
Add spec for default delivery status
diff --git a/spec/models/users_spec.rb b/spec/models/users_spec.rb index abc1234..def5678 100644 --- a/spec/models/users_spec.rb +++ b/spec/models/users_spec.rb @@ -3,22 +3,33 @@ describe User do describe "validations" do describe "invitation_code" do - it "only accepts valid invitation codes" do - ...
Test operates correctly regardless of dev's ENV config
diff --git a/spec/system/class_spec.rb b/spec/system/class_spec.rb index abc1234..def5678 100644 --- a/spec/system/class_spec.rb +++ b/spec/system/class_spec.rb @@ -1,17 +1,31 @@ require 'spec_helper_system' describe 'apache class' do + it 'should install apache' do if system_node.facts['osfamily'] == 'Debia...
Add checks to ensure the service is running.
diff --git a/lib/hypercuke.rb b/lib/hypercuke.rb index abc1234..def5678 100644 --- a/lib/hypercuke.rb +++ b/lib/hypercuke.rb @@ -9,7 +9,9 @@ require 'hypercuke/adapter_definition' module Hypercuke - def self.reset! + extend self + + def reset! layers.clear topics.clear StepAdapters.clear @@ -17,14 ...
Use ‘extend self’ instead of ‘def self.’
diff --git a/lib/active_any/adapter.rb b/lib/active_any/adapter.rb index abc1234..def5678 100644 --- a/lib/active_any/adapter.rb +++ b/lib/active_any/adapter.rb @@ -1,19 +1,21 @@ # frozen_string_literal: true -class Adapter - def initialize(klass) - @klass = klass - end - - def query(where_clause, limit_value) ...
Fix Adapter no wrapping for ActiveAny
diff --git a/lib/and-son/connection.rb b/lib/and-son/connection.rb index abc1234..def5678 100644 --- a/lib/and-son/connection.rb +++ b/lib/and-son/connection.rb @@ -12,7 +12,7 @@ protocol_connection = Sanford::Protocol::Connection.new(tcp_socket) yield protocol_connection if block_given? ensure - ...
Stop confusing exception when AndSon can't bind to a server Previously, we were getting an `NoMethodError` for `close` on the connection (because it could never make a connection) when a client couldn't bind. This fixes that by making sure protocol connection has been set before trying to close it. With this, you will...
diff --git a/lib/snl_admin.rb b/lib/snl_admin.rb index abc1234..def5678 100644 --- a/lib/snl_admin.rb +++ b/lib/snl_admin.rb @@ -4,6 +4,8 @@ # This is where global configuration options can go mattr_accessor :user_class mattr_accessor :redirection_class + mattr_accessor :license_class + mattr_accessor :taxono...
Add class methods for license and taxonomy
diff --git a/lib/commandline_parser.rb b/lib/commandline_parser.rb index abc1234..def5678 100644 --- a/lib/commandline_parser.rb +++ b/lib/commandline_parser.rb @@ -4,7 +4,7 @@ class CommandlineParser < Parslet::Parser rule(:prompt) do - str('$') | str('#') + str('$') | str('#') | str('>>') end rule(...
Allow irb prompt for commandline slides
diff --git a/app/models/url.rb b/app/models/url.rb index abc1234..def5678 100644 --- a/app/models/url.rb +++ b/app/models/url.rb @@ -1,9 +1,13 @@ class Url < ActiveRecord::Base - validates_presence_of :viewport_width, :address, :name - validates_format_of :address, :with => /https?:\/\/.+/ + validates_presence_of :v...
Align code in Url model
diff --git a/CircleProgressBar.podspec b/CircleProgressBar.podspec index abc1234..def5678 100644 --- a/CircleProgressBar.podspec +++ b/CircleProgressBar.podspec @@ -11,7 +11,7 @@ s.screenshots = "https://raw.githubusercontent.com/Eclair/CircleProgressBar/master/Screenshots/ios-screen01.png", "https://raw.githubuserc...
Use version number to get appropriate tag
diff --git a/spec/factories/model_object.rb b/spec/factories/model_object.rb index abc1234..def5678 100644 --- a/spec/factories/model_object.rb +++ b/spec/factories/model_object.rb @@ -0,0 +1,18 @@+require 'bra/model' + +# A minimal mock implementation of a ModelObject. +class MockModelObject + include Bra::Model::Mod...
Create factory for a minimal model object.
diff --git a/spec/features/sign_out_spec.rb b/spec/features/sign_out_spec.rb index abc1234..def5678 100644 --- a/spec/features/sign_out_spec.rb +++ b/spec/features/sign_out_spec.rb @@ -0,0 +1,18 @@+require 'spec_helper' + +describe 'sign out' do + let!(:user) do + Fabricate(:user, email: 'user@timeoverflow.org', pa...
Add sign out feature spec
diff --git a/spec/pages/manual_page_spec.rb b/spec/pages/manual_page_spec.rb index abc1234..def5678 100644 --- a/spec/pages/manual_page_spec.rb +++ b/spec/pages/manual_page_spec.rb @@ -26,7 +26,11 @@ expect(filename).to match(/\.html\.md$/) end - unless filename.in?(%w[source/manual/readmes.html.md sour...
Add new file to linting whitelist
diff --git a/spec/support/parser_helpers.rb b/spec/support/parser_helpers.rb index abc1234..def5678 100644 --- a/spec/support/parser_helpers.rb +++ b/spec/support/parser_helpers.rb @@ -1,7 +1,7 @@ require 'opal/parser' module ParserHelpers - def parsed(source, file='(string)') + def parsed(source, file='(ParserHel...
Use a recognizable filename in ParserHelpers Just to ease debugging.
diff --git a/lib/anticuado/ios/carthage.rb b/lib/anticuado/ios/carthage.rb index abc1234..def5678 100644 --- a/lib/anticuado/ios/carthage.rb +++ b/lib/anticuado/ios/carthage.rb @@ -23,13 +23,24 @@ return [] if index.nil? array[index + 1..array.size].map do |library| - versions = library.spli...
Support newer syntax of Carthage
diff --git a/Casks/hopper-disassembler.rb b/Casks/hopper-disassembler.rb index abc1234..def5678 100644 --- a/Casks/hopper-disassembler.rb +++ b/Casks/hopper-disassembler.rb @@ -1,6 +1,6 @@ cask :v1 => 'hopper-disassembler' do - version '3.9.16' - sha256 '045ee3ecba3c81388112dd038df91ffe6e4a905d9d2c8bd2650cfff43ec0121...
Update Hopper Disassembler to version 3.10.2.2 This commit updates the version and sha256 stanzas.
diff --git a/lib/junit_adapter.rb b/lib/junit_adapter.rb index abc1234..def5678 100644 --- a/lib/junit_adapter.rb +++ b/lib/junit_adapter.rb @@ -2,6 +2,7 @@ COUNT_REGEXP = /Tests run: (\d+)/ FAILURES_REGEXP = /Failures: (\d+)/ SUCCESS_REGEXP = /OK \((\d+) test[s]?\)/ + ASSERTION_ERROR_REGEXP = /java\.lang\.Ass...
Add error message grabbing support for JUnit
diff --git a/lib/context/controller_helper.rb b/lib/context/controller_helper.rb index abc1234..def5678 100644 --- a/lib/context/controller_helper.rb +++ b/lib/context/controller_helper.rb @@ -1,21 +1,21 @@ module Context -module ControllerHelper + module ControllerHelper - # Returns the current Context::Page for t...
Fix indentation for controller helper
diff --git a/lib/delayed_job_groups_plugin.rb b/lib/delayed_job_groups_plugin.rb index abc1234..def5678 100644 --- a/lib/delayed_job_groups_plugin.rb +++ b/lib/delayed_job_groups_plugin.rb @@ -14,10 +14,10 @@ if defined?(Delayed::Backend::ActiveRecord) if defined?(Rails::Railtie) # Postpone initialization to ra...
Update require statement to match new location of railtie.rb. Update to use ruby 2.5 include
diff --git a/lib/exercism/markdown.rb b/lib/exercism/markdown.rb index abc1234..def5678 100644 --- a/lib/exercism/markdown.rb +++ b/lib/exercism/markdown.rb @@ -26,7 +26,7 @@ end def block_code(code, language) - lexer = Rouge::Lexer.find_fancy(language, code) || Rouge::Lexers::Text + lexer = Rouge::Lexer.f...
Use PlainText lexer from Rouge I got a NameError for the Text lexer, and digging into the rouge codebase, it looks like this is the fix for it. I opened a ticket to verify: https://github.com/jayferd/rouge/issues/92
diff --git a/lib/playa/status_view.rb b/lib/playa/status_view.rb index abc1234..def5678 100644 --- a/lib/playa/status_view.rb +++ b/lib/playa/status_view.rb @@ -2,30 +2,30 @@ module Playa class StatusView < View - def interface - 'status' - end + # def interface + # 'status' + # end - de...
Revert to simple status bar.
diff --git a/lib/subtime/timer_cli.rb b/lib/subtime/timer_cli.rb index abc1234..def5678 100644 --- a/lib/subtime/timer_cli.rb +++ b/lib/subtime/timer_cli.rb @@ -26,6 +26,13 @@ if minute_messages.size.odd? raise OptionParser::InvalidArgument end + minute_messages.each_with_index do |mi...
Fix reference issues in accepting multiple messages
diff --git a/lib/spree/adyen/api_response.rb b/lib/spree/adyen/api_response.rb index abc1234..def5678 100644 --- a/lib/spree/adyen/api_response.rb +++ b/lib/spree/adyen/api_response.rb @@ -9,6 +9,11 @@ def success? !error_response? && gateway_response.success? + end + + def redirect? + ...
Add method for determining if adyen response is for a redirect
diff --git a/lib/tasks/import_locations.rake b/lib/tasks/import_locations.rake index abc1234..def5678 100644 --- a/lib/tasks/import_locations.rake +++ b/lib/tasks/import_locations.rake @@ -0,0 +1,33 @@+require 'open-uri' +require 'csv' + +namespace :import do + desc 'Import locations via the provided CSV' + task loca...
Add rake task to import locations This should be a one-shot affair.
diff --git a/lib/vagrant-mutate/converter.rb b/lib/vagrant-mutate/converter.rb index abc1234..def5678 100644 --- a/lib/vagrant-mutate/converter.rb +++ b/lib/vagrant-mutate/converter.rb @@ -35,7 +35,7 @@ end def convert(input_box, output_box) - write_metadata(output_box.dir, output_box.provider) + w...
Fix call to write metadata
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -1,5 +1,10 @@ class HomeController < ApplicationController def index - redirect_to new_user_session_path unless us...
Set schema index as home if user is signed in
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -7,7 +7,7 @@ def sfdata @geojson = HTTParty.get("https://data.sfgov.org/resource/qg52-sqku?$$app_token=Tfqfz8...
Change format of object sent from sever to frontend
diff --git a/app/controllers/root_controller.rb b/app/controllers/root_controller.rb index abc1234..def5678 100644 --- a/app/controllers/root_controller.rb +++ b/app/controllers/root_controller.rb @@ -8,7 +8,7 @@ end def trace - trace = Trace.find_by id: params[:id] + trace = Trace.find_by id: params[:id]....
Remove whitespace from trace IDs in the search bar These values are often pasted from browsers, where whitespace may accidentally creep in.
diff --git a/app/controllers/tags_controller.rb b/app/controllers/tags_controller.rb index abc1234..def5678 100644 --- a/app/controllers/tags_controller.rb +++ b/app/controllers/tags_controller.rb @@ -1,4 +1,7 @@ class TagsController < ApplicationController + + before_action :set_tag, only: [:show] + # GET /tags ...
Use a 'before_action' in the Tags controller Before the 'show' action, set the Tag to be shown with a 'before_action.'
diff --git a/app/controllers/tags_controller.rb b/app/controllers/tags_controller.rb index abc1234..def5678 100644 --- a/app/controllers/tags_controller.rb +++ b/app/controllers/tags_controller.rb @@ -32,6 +32,6 @@ end def sanitize(search_term) - search_term.gsub(/[^a-zA-Z0-9,.\s]*/, '').gsub(/\./, '\\.') + ...
Fix ignoring non ascii tag character
diff --git a/api/config/initializers/cors.rb b/api/config/initializers/cors.rb index abc1234..def5678 100644 --- a/api/config/initializers/cors.rb +++ b/api/config/initializers/cors.rb @@ -10,6 +10,8 @@ Rails.application.config.middleware.insert_before 0, Rack::Cors do BASE_ORIGINS = ['https://new.hackclub.com', ...
Add lachlan.hackclub.com to allowed CORS origins
diff --git a/chef/lib/chef/knife/role_create.rb b/chef/lib/chef/knife/role_create.rb index abc1234..def5678 100644 --- a/chef/lib/chef/knife/role_create.rb +++ b/chef/lib/chef/knife/role_create.rb @@ -30,8 +30,8 @@ banner "knife role create ROLE (options)" option :description, - :short => "-d", - ...
CHEF-2595: Fix -d in knife role create.
diff --git a/app/helpers/documents_helper.rb b/app/helpers/documents_helper.rb index abc1234..def5678 100644 --- a/app/helpers/documents_helper.rb +++ b/app/helpers/documents_helper.rb @@ -11,7 +11,7 @@ data["moreGames"] = document end - url = Addressable::URI.parse(codap_server || ENV['DEFAULT_CODAP_UR...
Fix typo for getting default codap server url [#78742620]
diff --git a/lib/gitlab_git/compare.rb b/lib/gitlab_git/compare.rb index abc1234..def5678 100644 --- a/lib/gitlab_git/compare.rb +++ b/lib/gitlab_git/compare.rb @@ -1,20 +1,18 @@ module Gitlab module Git class Compare - attr_accessor :commits, :commit, :diffs, :same, :limit, :timeout + attr_reader :co...
Remove confusing limit for Compare Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/private_address_check.gemspec b/private_address_check.gemspec index abc1234..def5678 100644 --- a/private_address_check.gemspec +++ b/private_address_check.gemspec @@ -9,8 +9,8 @@ spec.authors = ["John Downey"] spec.email = ["jdowney@gmail.com"] - spec.summary = %q{Checks if a U...
Improve gem summary and description
diff --git a/lib/billy/resource_utils.rb b/lib/billy/resource_utils.rb index abc1234..def5678 100644 --- a/lib/billy/resource_utils.rb +++ b/lib/billy/resource_utils.rb @@ -7,12 +7,12 @@ def url_formatter(url, include_params=false) url = URI(url) url_fragment = url.fragment - format = url.scheme+...
Improve variable naming within url_formatter.
diff --git a/lib/buffet/remote_runner.rb b/lib/buffet/remote_runner.rb index abc1234..def5678 100644 --- a/lib/buffet/remote_runner.rb +++ b/lib/buffet/remote_runner.rb @@ -4,18 +4,28 @@ class RemoteRunner def initialize @lock = Mutex.new + @someone_running = false end + def can_run? + ...
Allow a check to see if someone is running Buffet. Interesting to note is that there is a very minor race condition in this code, documented in the comment in front of `run`. This race is incredibly unlikely, and will not break functionality at all, so I haven't prioritized it.
diff --git a/lib/cucumber/broadcaster.rb b/lib/cucumber/broadcaster.rb index abc1234..def5678 100644 --- a/lib/cucumber/broadcaster.rb +++ b/lib/cucumber/broadcaster.rb @@ -1,17 +1,19 @@-class Broadcaster +module Cucumber + class Broadcaster - def initialize(receivers = []) - @receivers = receivers + def init...
Make Broadcaster live in Cucumber module
diff --git a/lib/racket/application.rb b/lib/racket/application.rb index abc1234..def5678 100644 --- a/lib/racket/application.rb +++ b/lib/racket/application.rb @@ -18,6 +18,12 @@ def self.options instance.options + end + + def self.using(options) + @instance = self.new(options) + @instance...
Implement Application.using so that configuration can be set directly from config.ru
diff --git a/lib/rrj/rabbit/publish.rb b/lib/rrj/rabbit/publish.rb index abc1234..def5678 100644 --- a/lib/rrj/rabbit/publish.rb +++ b/lib/rrj/rabbit/publish.rb @@ -16,6 +16,8 @@ private + # Define options to message pusblishing in queue + # @return [Hash] def option_publish(correlation) ...
Add comment to private method
diff --git a/lib/tasks/dependency.rake b/lib/tasks/dependency.rake index abc1234..def5678 100644 --- a/lib/tasks/dependency.rake +++ b/lib/tasks/dependency.rake @@ -0,0 +1,19 @@+namespace :dependency do + desc "Update dependencies to reset rubygem_id where rubygem_id is dangling" + task dangling_rubygem_id_purge: :en...
Update dependencies with dangling rubygem_id to null Ideally, these should have never existed as we update dependencies to unresolved_name and reset rubygem_id when a rubygem record gets deleted. These seems to have been created before the time we added before_destroy hook. Fixes following exception on transitive dep...
diff --git a/libraries/nexus_helper.rb b/libraries/nexus_helper.rb index abc1234..def5678 100644 --- a/libraries/nexus_helper.rb +++ b/libraries/nexus_helper.rb @@ -1,5 +1,5 @@ require 'timeout' -require 'open-uri' +require 'net/http' module Nexus3 # Helper library for testing Nexus3 responses @@ -17,19 +17,19 @@...
Replace use of ::Kernel.open by a proper HTTP call It is recommended not to use ::Kernel.open for security reason. Also due to the same reason recent rubocop versions doesn't like this method. Since we need basic HTTP here, use the built-in Net/Http module.
diff --git a/lib/epub/search/formatter/cli.rb b/lib/epub/search/formatter/cli.rb index abc1234..def5678 100644 --- a/lib/epub/search/formatter/cli.rb +++ b/lib/epub/search/formatter/cli.rb @@ -2,19 +2,19 @@ module Search module Formatter class CLI - def initialize(data, word, hilight=$stderr.tty?) ...
Fix typos: hilight -> highlihgt
diff --git a/lib/dotenv/beefy/railtie.rb b/lib/dotenv/beefy/railtie.rb index abc1234..def5678 100644 --- a/lib/dotenv/beefy/railtie.rb +++ b/lib/dotenv/beefy/railtie.rb @@ -7,9 +7,15 @@ config.before_configuration { load_environments } def load_environments - files = environments.map { |env| ".env...
Use Dotenv.overload to override ENV values with each new .env file
diff --git a/cookbooks/chef/attributes/default.rb b/cookbooks/chef/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/chef/attributes/default.rb +++ b/cookbooks/chef/attributes/default.rb @@ -2,7 +2,7 @@ default[:apt][:sources] = node[:apt][:sources] | ["opscode"] # Set the default server version -d...
Update chef server to 12.13.0
diff --git a/lib/jiraSOAP/JIRAservice.rb b/lib/jiraSOAP/JIRAservice.rb index abc1234..def5678 100644 --- a/lib/jiraSOAP/JIRAservice.rb +++ b/lib/jiraSOAP/JIRAservice.rb @@ -1,5 +1,14 @@ # All the remote entities as well as the SOAP service client. module JIRA + +# Interface to the JIRA endpoint server; set at initiali...
Add documention about the JIRA::JIRAService class
diff --git a/core/app/controllers/brightcontent/application_controller.rb b/core/app/controllers/brightcontent/application_controller.rb index abc1234..def5678 100644 --- a/core/app/controllers/brightcontent/application_controller.rb +++ b/core/app/controllers/brightcontent/application_controller.rb @@ -12,7 +12,7 @@ ...
Add locale setting from param.
diff --git a/Casks/omnifocus-beta.rb b/Casks/omnifocus-beta.rb index abc1234..def5678 100644 --- a/Casks/omnifocus-beta.rb +++ b/Casks/omnifocus-beta.rb @@ -1,6 +1,6 @@ cask 'omnifocus-beta' do - version '2.4.x-r253472' - sha256 '3420deb1dee658e4e9e1d158fe429cb0df2eae682935a24da351bfb26fd07ca0' + version '2.4.x-r253...
Update OmniFocus Beta to version 2.4.x-r253971 This commit updates the version and sha256 stanzas.
diff --git a/lib/python20_course_week.rb b/lib/python20_course_week.rb index abc1234..def5678 100644 --- a/lib/python20_course_week.rb +++ b/lib/python20_course_week.rb @@ -8,7 +8,13 @@ 1 when /Python20 Aufgabe 2/ 2 - when /Python20 Aufgabe 3/ + when /Python20 Aufgabe 3.1/ + nil # Explicitl...
Allow linter for exercises 3.1.X in Python course
diff --git a/command_line/error_message_spec.rb b/command_line/error_message_spec.rb index abc1234..def5678 100644 --- a/command_line/error_message_spec.rb +++ b/command_line/error_message_spec.rb @@ -0,0 +1,11 @@+require File.expand_path('../../spec_helper', __FILE__) + +describe "The error message caused by an except...
Add specs to test where error messages are printed.
diff --git a/lib/spreadsheet_on_rails.rb b/lib/spreadsheet_on_rails.rb index abc1234..def5678 100644 --- a/lib/spreadsheet_on_rails.rb +++ b/lib/spreadsheet_on_rails.rb @@ -16,7 +16,7 @@ def temp_file_path unless @@temp_file - temp = Tempfile.new('spreadsheet-', File.join(RAILS_ROOT, 'tmp') ) + ...
Use Rails.root.to_s (Rails 3 style) instead of the deprecated RAILS_ROOT variable
diff --git a/lib/cerberus/publisher/mail.rb b/lib/cerberus/publisher/mail.rb index abc1234..def5678 100644 --- a/lib/cerberus/publisher/mail.rb +++ b/lib/cerberus/publisher/mail.rb @@ -1,6 +1,10 @@ require 'action_mailer' require 'cerberus/publisher/base' -require 'cerberus/publisher/netsmtp_tls_fix' + +if RUBY_VERSIO...
Use TLS hack only on Ruby 1.8.4 git-svn-id: fbbd53e748d1d9421100d69b79e89db6c5fd213c@90 65aa75ef-ce15-0410-bc34-cdc86d5f77e6
diff --git a/FastEasyMapping.podspec b/FastEasyMapping.podspec index abc1234..def5678 100644 --- a/FastEasyMapping.podspec +++ b/FastEasyMapping.podspec @@ -1,7 +1,7 @@ Pod::Spec.new do |s| s.name = "FastEasyMapping" - s.version = "0.2.0" + s.version = "0.2.1" s.summary = "Fast mapping ...
Bump podspec version to 0.2.1
diff --git a/test/test_rake_xcscheme_task.rb b/test/test_rake_xcscheme_task.rb index abc1234..def5678 100644 --- a/test/test_rake_xcscheme_task.rb +++ b/test/test_rake_xcscheme_task.rb @@ -1,7 +1,7 @@ require_relative 'helper' require 'rake/xcscheme_task' -class TestRakeXcodebuildTask < Rake::TestCase +class TestRak...
Fix bug causing tests not to be namespaced properly
diff --git a/ruby/lib/json_event_logger.rb b/ruby/lib/json_event_logger.rb index abc1234..def5678 100644 --- a/ruby/lib/json_event_logger.rb +++ b/ruby/lib/json_event_logger.rb @@ -1,5 +1,6 @@ # A machine-readable first, human-readable second logging library class MicroserviceLogger + # The actual class that does the...
Add a 'documentation' comment to JsonEventLogger
diff --git a/lib/mongoid/relations/eager.rb b/lib/mongoid/relations/eager.rb index abc1234..def5678 100644 --- a/lib/mongoid/relations/eager.rb +++ b/lib/mongoid/relations/eager.rb @@ -25,14 +25,14 @@ grouped_relations = relations.group_by do |metadata| metadata.inverse_class_name end - ...
Remove begining underscore of used block parameters