diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/support/login_macro.rb b/spec/support/login_macro.rb index abc1234..def5678 100644 --- a/spec/support/login_macro.rb +++ b/spec/support/login_macro.rb @@ -2,8 +2,8 @@ def login_with(user) visit '/sessions/new' within("form") do - fill_in 'session_name', :with => exists_user.name - ...
Use argument value instead of `let` value
diff --git a/lib/email_assessor.rb b/lib/email_assessor.rb index abc1234..def5678 100644 --- a/lib/email_assessor.rb +++ b/lib/email_assessor.rb @@ -18,6 +18,6 @@ file_name ||= "" domain = domain.downcase - File.open(file_name).each_line.any? { |line| domain =~ %r{\A(.*\.)*#{line.chomp}\z}i } + File.op...
Make regex group non capturing
diff --git a/config/initializers/delayed_job_config.rb b/config/initializers/delayed_job_config.rb index abc1234..def5678 100644 --- a/config/initializers/delayed_job_config.rb +++ b/config/initializers/delayed_job_config.rb @@ -24,3 +24,4 @@ # ActiveRecord::Base.logger = Delayed::Worker.logger # Rails.logger = De...
Adjust the max run time to 8 hours
diff --git a/Casks/model-boiler.rb b/Casks/model-boiler.rb index abc1234..def5678 100644 --- a/Casks/model-boiler.rb +++ b/Casks/model-boiler.rb @@ -0,0 +1,13 @@+cask 'model-boiler' do + version '2.1.2' + sha256 '8169af020a1354ee1ee688da28d5dcde741e342dff73ab17a1fa94dcfa7d4d1e' + + url "https://github.com/nodes-ios/...
Add Model Boiler cask v2.1.2
diff --git a/lib/gon/watch.rb b/lib/gon/watch.rb index abc1234..def5678 100644 --- a/lib/gon/watch.rb +++ b/lib/gon/watch.rb @@ -25,7 +25,7 @@ variable = {} @watch_variables ||= {} env = Gon::Request.env - variable['url'] = env['ORIGINAL_FULLPATH'] + variable['url'] = e...
Fix for empty original fullpath
diff --git a/Casks/phpstorm-eap.rb b/Casks/phpstorm-eap.rb index abc1234..def5678 100644 --- a/Casks/phpstorm-eap.rb +++ b/Casks/phpstorm-eap.rb @@ -1,7 +1,7 @@ class PhpstormEap < Cask - url 'http://download.jetbrains.com/webide/PhpStorm-EAP-138.1161.dmg' + url 'http://download.jetbrains.com/webide/PhpStorm-EAP-138....
Update PHPStorm EAP to 138.1289
diff --git a/Casks/phpstorm-eap.rb b/Casks/phpstorm-eap.rb index abc1234..def5678 100644 --- a/Casks/phpstorm-eap.rb +++ b/Casks/phpstorm-eap.rb @@ -1,6 +1,6 @@ cask :v1 => 'phpstorm-eap' do - version '139.873' - sha256 '8405a198ee9720e05f0b589367514ae4b86bb28064cd7d2a9cc9a015b30a53c3' + version '139.1226' + sha256...
Update PhpStorm EAP Cask to v139.1226
diff --git a/lib/hotchkiss.rb b/lib/hotchkiss.rb index abc1234..def5678 100644 --- a/lib/hotchkiss.rb +++ b/lib/hotchkiss.rb @@ -1,3 +1,4 @@+require 'hotchkiss/version' require 'hotchkiss/router' require 'hotchkiss/controller' require 'hotchkiss/fast_responder'
Fix require issue at server start
diff --git a/lib/syoboemon.rb b/lib/syoboemon.rb index abc1234..def5678 100644 --- a/lib/syoboemon.rb +++ b/lib/syoboemon.rb @@ -1,17 +1,24 @@ $:.unshift File.dirname(__FILE__) -# gems +# ruby gems require 'rubygems' require 'faraday' require 'happymapper' -# syoboemon files -require "syoboemon/version" -require...
Add file names to require ruby file list
diff --git a/util.rb b/util.rb index abc1234..def5678 100644 --- a/util.rb +++ b/util.rb @@ -1,6 +1,7 @@ module Util def self.ago_in_words(time1, time2) diff = time1.to_i - time2.to_i + ago = '' if diff == 1 ago = "#{diff} second ago" @@ -9,19 +10,19 @@ elsif diff < 120 ago = "a minu...
Make the time output look a little better than something non-sensical
diff --git a/lib/blacklight_cornell_requests/oracle_connection.rb b/lib/blacklight_cornell_requests/oracle_connection.rb index abc1234..def5678 100644 --- a/lib/blacklight_cornell_requests/oracle_connection.rb +++ b/lib/blacklight_cornell_requests/oracle_connection.rb @@ -0,0 +1,14 @@+module BlacklightCornellRequests +...
Add OracleConnection class for future use
diff --git a/lib/cramp/generators/templates/application/config.ru b/lib/cramp/generators/templates/application/config.ru index abc1234..def5678 100644 --- a/lib/cramp/generators/templates/application/config.ru +++ b/lib/cramp/generators/templates/application/config.ru @@ -5,6 +5,9 @@ if <%= app_const %>.env == 'develop...
Use Rack::Reloader in dev mode
diff --git a/lib/pv/bug_tracker.rb b/lib/pv/bug_tracker.rb index abc1234..def5678 100644 --- a/lib/pv/bug_tracker.rb +++ b/lib/pv/bug_tracker.rb @@ -2,18 +2,26 @@ module Pv class BugTracker - def initialize with_username, and_password + attr_reader :username, :password, :token + + def initialize with_user...
Refactor BugTracker to also read from file configuration
diff --git a/lib/routes/content.rb b/lib/routes/content.rb index abc1234..def5678 100644 --- a/lib/routes/content.rb +++ b/lib/routes/content.rb @@ -10,8 +10,13 @@ delete '/content' do begin require_authentication - raw_result = find_result_by_link(params["link"]) - delete_result_from_index(raw_...
Delete results from all clusters
diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/users_controller_test.rb +++ b/test/controllers/users_controller_test.rb @@ -0,0 +1,16 @@+require 'test_helper' + +class UsersControllerTest < ActionDispatch::Integrati...
Add test for updating personal access token
diff --git a/lib/stylus/railtie.rb b/lib/stylus/railtie.rb index abc1234..def5678 100644 --- a/lib/stylus/railtie.rb +++ b/lib/stylus/railtie.rb @@ -9,22 +9,23 @@ config.app_generators.stylesheet_engine :stylus - initializer :setup_stylus, :after => 'sprockets.environment', :group => :all do |app| + initi...
Rewrite the after_initialize block as an initializer to append paths properly.
diff --git a/bin/recog_verify.rb b/bin/recog_verify.rb index abc1234..def5678 100644 --- a/bin/recog_verify.rb +++ b/bin/recog_verify.rb @@ -37,7 +37,7 @@ if ARGV.empty? $stderr.puts 'Missing XML fingerprint files' puts option_parser - exit + exit(1) end ARGV.each do |file|
Exit non-zero if the arguments are wrong
diff --git a/lib/tasks/resque.rake b/lib/tasks/resque.rake index abc1234..def5678 100644 --- a/lib/tasks/resque.rake +++ b/lib/tasks/resque.rake @@ -14,6 +14,8 @@ if time_running > max_time_running w.unregister_worker end + + Resque.workers.each { |w| w.unregister_worker unless w.working? } ...
Clear working workers count in Resque Resque will show something like "2 of 356 Workers Working" which is clearly false. This will clear that count, back to sane numbers.
diff --git a/spec/models/menu_spec.rb b/spec/models/menu_spec.rb index abc1234..def5678 100644 --- a/spec/models/menu_spec.rb +++ b/spec/models/menu_spec.rb @@ -11,6 +11,9 @@ describe 'Associations' do it { is_expected.to have_and_belong_to_many :menu_items } + it 'join table should have unique index' do + ...
Add test for join table index Conflicts: spec/models/menu_spec.rb
diff --git a/spec/tesla/model_spec.rb b/spec/tesla/model_spec.rb index abc1234..def5678 100644 --- a/spec/tesla/model_spec.rb +++ b/spec/tesla/model_spec.rb @@ -1,7 +1,14 @@ require File.join(File.dirname(__FILE__), '..', 'spec_helper') describe Tesla::Model do - it "should fail" do - flunk "fail!" + + describe...
Add basic spec for persistability on class
diff --git a/rails/app/controllers/application_controller.rb b/rails/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/rails/app/controllers/application_controller.rb +++ b/rails/app/controllers/application_controller.rb @@ -4,6 +4,11 @@ protect_from_forgery with: :exception before_acti...
Switch to KTH Github endpoint
diff --git a/lib/vhdl_connector.rb b/lib/vhdl_connector.rb index abc1234..def5678 100644 --- a/lib/vhdl_connector.rb +++ b/lib/vhdl_connector.rb @@ -10,11 +10,13 @@ require "vhdl_connector/port_wrapper" module VhdlConnector - def parse_entity(vhdl_str) - EntityWrapper.new(VHDL_Parser.parse(vhdl_str)) - end + c...
Move top module method to uniq class method
diff --git a/app/controllers/api/v1/sessions_controller.rb b/app/controllers/api/v1/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/sessions_controller.rb +++ b/app/controllers/api/v1/sessions_controller.rb @@ -3,7 +3,7 @@ def create @user = User.find_by username: user_params[:u...
Send full user for api login
diff --git a/app/controllers/connection_logs_controller.rb b/app/controllers/connection_logs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/connection_logs_controller.rb +++ b/app/controllers/connection_logs_controller.rb @@ -3,14 +3,19 @@ def create if ConnectionLogsController.key == params...
Remove transaction to try to remedy "Deadlock found when trying to get lock; try restarting transaction" Replace with a simpler scheme that just retries
diff --git a/lib/helpers/number_formatter.rb b/lib/helpers/number_formatter.rb index abc1234..def5678 100644 --- a/lib/helpers/number_formatter.rb +++ b/lib/helpers/number_formatter.rb @@ -8,6 +8,10 @@ "%.1f%c" % [(self.to_f / 1000 ** exp).round(1), suffix[exp-1]] end end + + def with_commas + self.to...
Add with_commas method to NumberFormatter module
diff --git a/chef/lib/chef/run_list/versioned_recipe_list.rb b/chef/lib/chef/run_list/versioned_recipe_list.rb index abc1234..def5678 100644 --- a/chef/lib/chef/run_list/versioned_recipe_list.rb +++ b/chef/lib/chef/run_list/versioned_recipe_list.rb @@ -1,6 +1,7 @@ # # Author:: Stephen Delano (<stephen@opscode.com>) -#...
Use Chef::Version in VersionedRecipeList CHEF-1818
diff --git a/bumbleworks.gemspec b/bumbleworks.gemspec index abc1234..def5678 100644 --- a/bumbleworks.gemspec +++ b/bumbleworks.gemspec @@ -20,4 +20,7 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" + spec.add_runtime_dependency "ruote" + spec.add_runtime_dependen...
Add puntine dependance on ruote, ruote-redis and ruote-sequel
diff --git a/bundler_ext.gemspec b/bundler_ext.gemspec index abc1234..def5678 100644 --- a/bundler_ext.gemspec +++ b/bundler_ext.gemspec @@ -20,4 +20,5 @@ s.requirements = ['Install the linux_admin gem and set BEXT_ACTIVATE_VERSIONS to true to activate rpm/deb installed gems'] s.add_development_dependency('rspec...
Add rake as a development dependency
diff --git a/lib/rack_tracker/plugins/dsl.rb b/lib/rack_tracker/plugins/dsl.rb index abc1234..def5678 100644 --- a/lib/rack_tracker/plugins/dsl.rb +++ b/lib/rack_tracker/plugins/dsl.rb @@ -8,8 +8,8 @@ def initialize plugin_name, &block @@currently_defining = plugin_name + eval define_plugi...
Define the plugin name before yielding the block
diff --git a/spec/controllers/collections_controller_spec.rb b/spec/controllers/collections_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/collections_controller_spec.rb +++ b/spec/controllers/collections_controller_spec.rb @@ -0,0 +1,30 @@+require 'spec_helper' + +describe CollectionsControlle...
Add rspec tests for collections controller
diff --git a/cleaner.rb b/cleaner.rb index abc1234..def5678 100644 --- a/cleaner.rb +++ b/cleaner.rb @@ -5,6 +5,7 @@ self.rename_file file, path else puts file + " is a folder" + self.clean_folder file end end "Cleaned files in folder: " + path
Make clean folder recursive so that it clears an entire tree of files
diff --git a/hashtel.gemspec b/hashtel.gemspec index abc1234..def5678 100644 --- a/hashtel.gemspec +++ b/hashtel.gemspec @@ -15,7 +15,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~> 1.5" + spec.add_development_d...
Update bundler requirement from ~> 1.5 to ~> 2.2 Updates the requirements on [bundler](https://github.com/rubygems/rubygems) to permit the latest version. - [Release notes](https://github.com/rubygems/rubygems/releases) - [Changelog](https://github.com/rubygems/rubygems/blob/master/bundler/CHANGELOG.md) - [Commits](ht...
diff --git a/spec/penguin_spec.rb b/spec/penguin_spec.rb index abc1234..def5678 100644 --- a/spec/penguin_spec.rb +++ b/spec/penguin_spec.rb @@ -5,13 +5,8 @@ describe Penguin do include Rack::Test::Methods - let(:middleware) { - Penguin::Middleware.new( - lambda { |env| ['200', {'Content-Type' => 'text/ht...
Test app is not called when limit exceeded
diff --git a/app/helpers/schema_org_helper.rb b/app/helpers/schema_org_helper.rb index abc1234..def5678 100644 --- a/app/helpers/schema_org_helper.rb +++ b/app/helpers/schema_org_helper.rb @@ -1,17 +1,17 @@ module SchemaOrgHelper def meta_person_schema_url - 'http://schema.org/Person' + 'https://schema.org/Per...
Use HTTPS for schema.org requests
diff --git a/db/migrate/20131216190859_add_integration_id.rb b/db/migrate/20131216190859_add_integration_id.rb index abc1234..def5678 100644 --- a/db/migrate/20131216190859_add_integration_id.rb +++ b/db/migrate/20131216190859_add_integration_id.rb @@ -0,0 +1,48 @@+class AddIntegrationId < ActiveRecord::Migration + ta...
Add integration_id to SIS models An integration_id can be used in a way similar to sis_source_id in that it documents a 3rd party identifier for a particular object. The reason we use an integration_id instead of a sis_source_id for some SIS integrations is that there is BOTH a sis_source_id and another id that is use...
diff --git a/app/models/project_suggestion.rb b/app/models/project_suggestion.rb index abc1234..def5678 100644 --- a/app/models/project_suggestion.rb +++ b/app/models/project_suggestion.rb @@ -9,8 +9,8 @@ end def pending - (repository_url.present? && repository_url != project.repository_url) || - (licenses...
Handle deleted projects when filtering suggestions
diff --git a/kato-cli.gemspec b/kato-cli.gemspec index abc1234..def5678 100644 --- a/kato-cli.gemspec +++ b/kato-cli.gemspec @@ -8,8 +8,9 @@ spec.version = Kato::Cli::VERSION spec.authors = ["Tom McDonald"] spec.email = ["tommcdo@gmail.com"] - spec.summary = %q{CLI client for posting ...
Update gemspec with more detail
diff --git a/app/views/feeds/show.xml.builder b/app/views/feeds/show.xml.builder index abc1234..def5678 100644 --- a/app/views/feeds/show.xml.builder +++ b/app/views/feeds/show.xml.builder @@ -14,10 +14,10 @@ xml.guid "http://" + request.host_with_port + "/articles/#{article.id}" xml.description do ...
Make RSS feed author list and section bold.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -1,6 +1,10 @@ module ApplicationHelper def phone_to(number) - link_to number, "tel:#{number}" + if number.nil? + ...
Remove ':tel' display on member page when nil Added logic to application_helper to check if phone value is nil and remove ':tel' display value
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -1,7 +1,15 @@ module ApplicationHelper module AuthorizeHelper def client - @client ||= Instagram.client + ...
Change client method to return authorized client when authenticated.
diff --git a/icepick.gemspec b/icepick.gemspec index abc1234..def5678 100644 --- a/icepick.gemspec +++ b/icepick.gemspec @@ -20,7 +20,7 @@ gem.add_runtime_dependency 'awesome_print', '~> 1.2' gem.add_runtime_dependency 'colorize', '~> 0.7' gem.add_runtime_dependency 'pry', '~> 0...
Update byebug to latest and greatest
diff --git a/app/helpers/import_task_report.rb b/app/helpers/import_task_report.rb index abc1234..def5678 100644 --- a/app/helpers/import_task_report.rb +++ b/app/helpers/import_task_report.rb @@ -6,17 +6,9 @@ @models_for_report = models_for_report end - def humanize_class_name(klass) - klass.to_s.pluraliz...
Define private interface for import task report
diff --git a/lib/persistence/article_service.rb b/lib/persistence/article_service.rb index abc1234..def5678 100644 --- a/lib/persistence/article_service.rb +++ b/lib/persistence/article_service.rb @@ -4,9 +4,7 @@ end def fetch(id) - article = @db[:articles].where(:id => id).first - article[:category] = C...
Remove useless category lookup in ArticleService
diff --git a/lib/ppcurses/form/input_element.rb b/lib/ppcurses/form/input_element.rb index abc1234..def5678 100644 --- a/lib/ppcurses/form/input_element.rb +++ b/lib/ppcurses/form/input_element.rb @@ -11,7 +11,13 @@ end def show(screen) + # Show Label screen.addstr("#{@label}: ") + + # Show ...
Add input value portion scaffolding.
diff --git a/lib/protobuf/field/varint_field.rb b/lib/protobuf/field/varint_field.rb index abc1234..def5678 100644 --- a/lib/protobuf/field/varint_field.rb +++ b/lib/protobuf/field/varint_field.rb @@ -21,14 +21,6 @@ def self.default 0 - end - - def self.decode(bytes) - value = 0 - ...
Remove unused VarintField.decode method (handled by Decoder)
diff --git a/clock.rb b/clock.rb index abc1234..def5678 100644 --- a/clock.rb +++ b/clock.rb @@ -30,11 +30,16 @@ # This only really needs to run once an hour, but no harm comes # from running it more frequently, so let's try several times an # hour to avoid problems + # + # N.B.: If this becomes too...
Add logging to scheduled transfer invocation
diff --git a/history_book.gemspec b/history_book.gemspec index abc1234..def5678 100644 --- a/history_book.gemspec +++ b/history_book.gemspec @@ -8,6 +8,7 @@ s.authors = ['John Downey'] s.email = ['jdowney@gmail.com'] s.homepage = 'http://github.com/jtdowney/history_book' + s.license = 'MIT' ...
Add MIT license to gemspec
diff --git a/spec/unit/concurrent/synchronized_sorted_set_spec.rb b/spec/unit/concurrent/synchronized_sorted_set_spec.rb index abc1234..def5678 100644 --- a/spec/unit/concurrent/synchronized_sorted_set_spec.rb +++ b/spec/unit/concurrent/synchronized_sorted_set_spec.rb @@ -3,30 +3,32 @@ describe Bunny::Concurrent::Syn...
Fix race conditions in this trivial unit test. Headdesk.
diff --git a/libraries/drivers_db_postgresql.rb b/libraries/drivers_db_postgresql.rb index abc1234..def5678 100644 --- a/libraries/drivers_db_postgresql.rb +++ b/libraries/drivers_db_postgresql.rb @@ -4,7 +4,7 @@ module Db class Postgresql < Base adapter :postgresql - allowed_engines :postgres, :post...
fix(db): Fix typo for aurora postgresql
diff --git a/lib/codebase.rb b/lib/codebase.rb index abc1234..def5678 100644 --- a/lib/codebase.rb +++ b/lib/codebase.rb @@ -18,7 +18,7 @@ def request(url, data) uri = URI.parse(url) req = Net::HTTP::Post.new(uri.path) - req.set_form_data(data, ';') + req.set_form_data(data) res = Net...
Allow Net::HTTP to use it's default delimiter A semicolon with no space is no longer supported by rack, so request will be malformed
diff --git a/lib/congress.rb b/lib/congress.rb index abc1234..def5678 100644 --- a/lib/congress.rb +++ b/lib/congress.rb @@ -1,27 +1,27 @@ require 'congress/client' module Congress - class << self - attr_accessor :key - def configure - yield self - end + extend self # rubocop:disable ModuleFunction +...
Refactor “class << self” to “extend self” in module Congress.
diff --git a/lib/knapsack.rb b/lib/knapsack.rb index abc1234..def5678 100644 --- a/lib/knapsack.rb +++ b/lib/knapsack.rb @@ -7,6 +7,7 @@ require_relative 'knapsack/presenter' require_relative 'knapsack/report' require_relative 'knapsack/allocator' +require_relative 'knapsack/allocator_builder' require_relative 'knap...
Add missing require for allocator builder
diff --git a/vampires-deck.rb b/vampires-deck.rb index abc1234..def5678 100644 --- a/vampires-deck.rb +++ b/vampires-deck.rb @@ -0,0 +1,34 @@+class Deck + + + def compare + if user_input == pick_card.question + output_correct + pick_card + elsif user_input == 'exit' + puts "Quitter." + else + ...
Add compare method and Card class
diff --git a/lib/lineprof.rb b/lib/lineprof.rb index abc1234..def5678 100644 --- a/lib/lineprof.rb +++ b/lib/lineprof.rb @@ -2,12 +2,13 @@ require 'rack/lineprof/source_extension' class Lineprof - IGNORE_PATTERN = /lib\/lineprof\.rb$/ + IGNORE_PATTERN = /lib\/lineprof\.rb$/ + DEFAULT_PATTERN = /./ class << ...
Use caller filename by default
diff --git a/learn-co.gemspec b/learn-co.gemspec index abc1234..def5678 100644 --- a/learn-co.gemspec +++ b/learn-co.gemspec @@ -23,5 +23,6 @@ spec.add_runtime_dependency "learn-test", ">= 1.1.1" spec.add_runtime_dependency "learn-config", ">= 0.0.32" + spec.add_runtime_dependency "learn-open" spec.add_runti...
Add learn-open as runtime dep
diff --git a/lib/fulmar/domain/task/database_sync.rake b/lib/fulmar/domain/task/database_sync.rake index abc1234..def5678 100644 --- a/lib/fulmar/domain/task/database_sync.rake +++ b/lib/fulmar/domain/task/database_sync.rake @@ -1,13 +1,8 @@ require 'pp' db_configs = [] -full_configuration[:environments].each_key do...
[REFACTORING] Use the fantastic new .each method
diff --git a/lib/rails-footnotes/notes/assigns_note.rb b/lib/rails-footnotes/notes/assigns_note.rb index abc1234..def5678 100644 --- a/lib/rails-footnotes/notes/assigns_note.rb +++ b/lib/rails-footnotes/notes/assigns_note.rb @@ -3,7 +3,20 @@ module Footnotes module Notes class AssignsNote < AbstractNote - ...
Fix ruby 1.9 issue where it doesn't ignore most assigns because controller.protected_instance_variables array looks like string in ruby 1.8.7 and like :string in 1.9
diff --git a/sinatra-github_webhooks.gemspec b/sinatra-github_webhooks.gemspec index abc1234..def5678 100644 --- a/sinatra-github_webhooks.gemspec +++ b/sinatra-github_webhooks.gemspec @@ -21,8 +21,8 @@ spec.add_dependency 'sinatra' spec.add_dependency 'rack-github_webhooks', '>= 0.3.0' - spec.add_development_d...
Remove explicit versions of development dependencies Probably better to fix problems with newer versions of development tooling, rather than pin to old versions.
diff --git a/lib/migrator.rb b/lib/migrator.rb index abc1234..def5678 100644 --- a/lib/migrator.rb +++ b/lib/migrator.rb @@ -7,7 +7,7 @@ end def self.available_migrations - Dir["#{migrations_path}/[0-9]*_*.rb"].sort + Dir["#{migrations_path}/[1-9]*_*.rb"].sort_by { |name| name.scan(/\d+/).first.to_i } e...
Fix admin/ migration problem with 0_initial_schema, from Eridius git-svn-id: 70ab0960c3db1cbf656efd6df54a8f3de72dc710@607 820eb932-12ee-0310-9ca8-eeb645f39767
diff --git a/app/workers/spam_worker.rb b/app/workers/spam_worker.rb index abc1234..def5678 100644 --- a/app/workers/spam_worker.rb +++ b/app/workers/spam_worker.rb @@ -5,7 +5,7 @@ @message = Georgia::Message.find(message_id) @message.update_attributes(spam: @message.spam?, verified_at: Time.zone.now) # T...
Send message even when spam for now
diff --git a/app/models/ability.rb b/app/models/ability.rb index abc1234..def5678 100644 --- a/app/models/ability.rb +++ b/app/models/ability.rb @@ -3,6 +3,8 @@ def initialize(subject) super + + admin = (!Site.current.nil?) and (can? :update, Site.current) if subject.is_a?(Application) && subject.sto...
Allow admins to use SCIM API
diff --git a/lib/rbraspag.rb b/lib/rbraspag.rb index abc1234..def5678 100644 --- a/lib/rbraspag.rb +++ b/lib/rbraspag.rb @@ -16,12 +16,6 @@ require 'rbraspag/order' module Braspag - def self.logger=(logger) - HTTPI.log = true - HTTPI.logger = logger - HTTPI.log_level = :debug - end - def self.config_fi...
Revert "Forcing logger enabling from outside to HTTPI" This reverts commit 3035c99cb09764fc02052c7e418a8229b867734f.
diff --git a/lib/chatrix/bot.rb b/lib/chatrix/bot.rb index abc1234..def5678 100644 --- a/lib/chatrix/bot.rb +++ b/lib/chatrix/bot.rb @@ -19,7 +19,7 @@ # Initializes a new Bot instance. # @param file [String] File to load config from. - def initialize(file = 'config.yaml') + def initialize(file = Config...
Use config const instead of hardcoded value in Bot It was using a hardcoded string for the default config path.
diff --git a/backend/app/helpers/spree/admin/adjustments_helper.rb b/backend/app/helpers/spree/admin/adjustments_helper.rb index abc1234..def5678 100644 --- a/backend/app/helpers/spree/admin/adjustments_helper.rb +++ b/backend/app/helpers/spree/admin/adjustments_helper.rb @@ -29,7 +29,7 @@ end def displa...
Use translated text for shipment in AdjustmentsHelper
diff --git a/spec/expando/expander_spec.rb b/spec/expando/expander_spec.rb index abc1234..def5678 100644 --- a/spec/expando/expander_spec.rb +++ b/spec/expando/expander_spec.rb @@ -1,9 +1,9 @@ require 'spec_helper' describe Expando::Expander do - it 'properly expands tokenized text' do - lines = [ '(I|we|they) h...
Add a failing spec for ignoring comments OS-10
diff --git a/SwiftyReceiptValidator.podspec b/SwiftyReceiptValidator.podspec index abc1234..def5678 100644 --- a/SwiftyReceiptValidator.podspec +++ b/SwiftyReceiptValidator.podspec @@ -18,6 +18,6 @@ :tag => s.version } -s.source_files = "SwiftyReceiptValidator/**/*.{swift}" +s.source_files = "Sources/**/*.{swift...
Update podspec to point to correct file
diff --git a/spec/support/twilio_matchers.rb b/spec/support/twilio_matchers.rb index abc1234..def5678 100644 --- a/spec/support/twilio_matchers.rb +++ b/spec/support/twilio_matchers.rb @@ -0,0 +1,29 @@+require 'nokogiri' + +RSpec::Matchers.define :redirect_twilio_to do |expected| + match do |actual| + doc = Nokogir...
Add custom RSpec Twilio matchers from CityVoice, via @ohrite
diff --git a/spec/unit/query_builder_spec.rb b/spec/unit/query_builder_spec.rb index abc1234..def5678 100644 --- a/spec/unit/query_builder_spec.rb +++ b/spec/unit/query_builder_spec.rb @@ -11,15 +11,15 @@ end it "should return empty conditions if the search query is nil" do - ScopedSearch::QueryBuilder.build_...
Fix query builder specs by including :order => nil
diff --git a/lib/hooks_utils.rb b/lib/hooks_utils.rb index abc1234..def5678 100644 --- a/lib/hooks_utils.rb +++ b/lib/hooks_utils.rb @@ -1,5 +1,5 @@ module HooksUtils - extend self + module_function # Gets an array of Git push options from the environment def get_push_options
Use `module_fuction` instead of `extend self` https://github.com/rubocop-hq/ruby-style-guide#module-function
diff --git a/app/jobs/geocode_adviser_job.rb b/app/jobs/geocode_adviser_job.rb index abc1234..def5678 100644 --- a/app/jobs/geocode_adviser_job.rb +++ b/app/jobs/geocode_adviser_job.rb @@ -10,6 +10,6 @@ private def stat(key) - Stats.increment("radsignup.geocode_adviser.#{key}") + Stats.increment("radsignup...
Use dots instead of underscores for statsd keys.
diff --git a/test/spec/database_integration/get_not_found.rb b/test/spec/database_integration/get_not_found.rb index abc1234..def5678 100644 --- a/test/spec/database_integration/get_not_found.rb +++ b/test/spec/database_integration/get_not_found.rb @@ -0,0 +1,19 @@+require_relative './database_integration_init' + +desc...
Test for get of stream that doesn't exist
diff --git a/Casks/mongohub.rb b/Casks/mongohub.rb index abc1234..def5678 100644 --- a/Casks/mongohub.rb +++ b/Casks/mongohub.rb @@ -0,0 +1,11 @@+cask :v1 => 'mongohub' do + version :latest + sha256 :no_check + + url 'https://mongohub.s3.amazonaws.com/MongoHub.zip' + name 'MongoHub' + homepage 'https://github.com/...
Add MongoHub.app latest current version 3.1.4
diff --git a/Casks/sqwiggle.rb b/Casks/sqwiggle.rb index abc1234..def5678 100644 --- a/Casks/sqwiggle.rb +++ b/Casks/sqwiggle.rb @@ -0,0 +1,7 @@+class Sqwiggle < Cask + url 'https://www.sqwiggle.com/download/mac' + homepage 'https://www.sqwiggle.com' + version '0.4.2' + sha1 '15c49c5443780749ca833605bd61f9ee0b4d810...
Add new cask for Sqwiggle.app.
diff --git a/gutentag.gemspec b/gutentag.gemspec index abc1234..def5678 100644 --- a/gutentag.gemspec +++ b/gutentag.gemspec @@ -15,6 +15,8 @@ s.add_runtime_dependency 'activerecord', '>= 3.2.0' s.add_runtime_dependency 'appraisal', '~> 1.0.2' + + s.add_development_dependency 'bundler', '>= 1.7....
Use latest release of bundler. Required for ruby_22 flag.
diff --git a/db/migrate/20201219120055_add_order_to_adjustments.rb b/db/migrate/20201219120055_add_order_to_adjustments.rb index abc1234..def5678 100644 --- a/db/migrate/20201219120055_add_order_to_adjustments.rb +++ b/db/migrate/20201219120055_add_order_to_adjustments.rb @@ -21,7 +21,17 @@ # Migrate adjustments ...
Fix issue with orphaned adjustments in migration
diff --git a/lib/spot_rate.rb b/lib/spot_rate.rb index abc1234..def5678 100644 --- a/lib/spot_rate.rb +++ b/lib/spot_rate.rb @@ -31,5 +31,5 @@ end end -require './lib/spot_rate/google_currency_converter' +require 'spot_rate/google_currency_converter' SpotRate.register_currency_converter :default, SpotRate::Google...
Update require path, amateur hour over here
diff --git a/lib/rails_admin/models/setup/delayed_message_admin.rb b/lib/rails_admin/models/setup/delayed_message_admin.rb index abc1234..def5678 100644 --- a/lib/rails_admin/models/setup/delayed_message_admin.rb +++ b/lib/rails_admin/models/setup/delayed_message_admin.rb @@ -10,7 +10,11 @@ navigation_label...
Fix | Contextualizing delayed message config with adapter
diff --git a/test/locotimezone_test.rb b/test/locotimezone_test.rb index abc1234..def5678 100644 --- a/test/locotimezone_test.rb +++ b/test/locotimezone_test.rb @@ -1,27 +1,41 @@ require 'test_helper' class LocotimezoneTest < Minitest::Test - attr_reader :loco + attr_reader :locotime + attr_reader :just_location ...
Test options for location_only and timezone_only
diff --git a/db/migrate/20191010143350_add_conditioning_unit_to_products.rb b/db/migrate/20191010143350_add_conditioning_unit_to_products.rb index abc1234..def5678 100644 --- a/db/migrate/20191010143350_add_conditioning_unit_to_products.rb +++ b/db/migrate/20191010143350_add_conditioning_unit_to_products.rb @@ -27,7 +2...
Revert "Fix bug during deployment on not null column conditionning_unit in products." This reverts commit 27b3244eba4901962aef6b3f2832efb3d532d740.
diff --git a/aruba-doubles.gemspec b/aruba-doubles.gemspec index abc1234..def5678 100644 --- a/aruba-doubles.gemspec +++ b/aruba-doubles.gemspec @@ -12,6 +12,7 @@ s.add_dependency 'cucumber', '>= 1.0.2' s.add_dependency 'rspec', '>= 2.6.0' + s.add_development_dependency 'rake', '>= 0.9.2.2' s.add_development...
Fix missing dev dependency rake
diff --git a/looksee.gemspec b/looksee.gemspec index abc1234..def5678 100644 --- a/looksee.gemspec +++ b/looksee.gemspec @@ -22,4 +22,5 @@ s.add_development_dependency 'ritual', '>= 0.2.0' s.add_development_dependency 'rspec', '>= 2.0.0' s.add_development_dependency 'mocha' + s.add_development_dependency 'wirb...
Add wirble as a development dependency.
diff --git a/db/migrate/007_add_user_id_to_search_terms.rb b/db/migrate/007_add_user_id_to_search_terms.rb index abc1234..def5678 100644 --- a/db/migrate/007_add_user_id_to_search_terms.rb +++ b/db/migrate/007_add_user_id_to_search_terms.rb @@ -0,0 +1,44 @@+migration 7, :add_user_id_to_search_terms do + up do + exe...
Add user id to search terms
diff --git a/attributes/default.rb b/attributes/default.rb index abc1234..def5678 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -1,5 +1,5 @@ default['selenium']['url'] = - 'https://selenium-release.storage.googleapis.com/2.47/selenium-server-standalone-2.47.0.jar' + 'https://selenium-release.stora...
Use selenium jar version 1.47.1
diff --git a/site-cookbooks/backup_restore/spec/recipes/restore_spec.rb b/site-cookbooks/backup_restore/spec/recipes/restore_spec.rb index abc1234..def5678 100644 --- a/site-cookbooks/backup_restore/spec/recipes/restore_spec.rb +++ b/site-cookbooks/backup_restore/spec/recipes/restore_spec.rb @@ -0,0 +1,51 @@+require_re...
Add chef-spec for restore recipe
diff --git a/lib/extensions/string.rb b/lib/extensions/string.rb index abc1234..def5678 100644 --- a/lib/extensions/string.rb +++ b/lib/extensions/string.rb @@ -5,7 +5,7 @@ end def extract_settings - gsub(/ /, '').split(',') + split(",").map { |x| x.strip } end def remove_prefix(prefix = 'admin/')
Use split instead of gsub.
diff --git a/lib/minotaur/document.rb b/lib/minotaur/document.rb index abc1234..def5678 100644 --- a/lib/minotaur/document.rb +++ b/lib/minotaur/document.rb @@ -1,5 +1,4 @@ require 'nokogiri' -require 'pry' module Minotaur class Document
Remove pry require in Document
diff --git a/test/integration/justhub-version/serverspec/server_spec.rb b/test/integration/justhub-version/serverspec/server_spec.rb index abc1234..def5678 100644 --- a/test/integration/justhub-version/serverspec/server_spec.rb +++ b/test/integration/justhub-version/serverspec/server_spec.rb @@ -8,9 +8,9 @@ it { ...
Check if the file exists before we try to get version information from it
diff --git a/localdoc.gemspec b/localdoc.gemspec index abc1234..def5678 100644 --- a/localdoc.gemspec +++ b/localdoc.gemspec @@ -26,5 +26,9 @@ s.add_development_dependency "pry-rails" s.add_development_dependency "byebug" - s.post_install_message = "Run `(cd `bundle show localdoc` && npm install) && rake locald...
Use bundle exec in post install message's suggested command
diff --git a/classy_hash.gemspec b/classy_hash.gemspec index abc1234..def5678 100644 --- a/classy_hash.gemspec +++ b/classy_hash.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = 'classy_hash' - s.version = '0.2.0' + s.version = '0.2.1' s.license = 'MIT' s.files = ['lib/classy_hash.rb', 'lib/cla...
Bump gem version and allow Ruby 2.4.
diff --git a/lib/ovirt/base_object.rb b/lib/ovirt/base_object.rb index abc1234..def5678 100644 --- a/lib/ovirt/base_object.rb +++ b/lib/ovirt/base_object.rb @@ -12,5 +12,11 @@ def parse_version xml (xml/'version').first[:major] +"."+ (xml/'version').first[:minor] end + + def parse_bool text + re...
Add method to parse XML booleans Currently we don't convert boolean objects returned by the server to the Ruby representation of booleans. This complicates further treatment of these values, as they have to be treated as strings. To avoid that this patch introduces a new "parse_bool" method in the base object class in...
diff --git a/lib/rack/test/methods.rb b/lib/rack/test/methods.rb index abc1234..def5678 100644 --- a/lib/rack/test/methods.rb +++ b/lib/rack/test/methods.rb @@ -1,45 +1,33 @@+require "forwardable" + module Rack module Test - module Methods - - def self.delegate_to_rack_test_session(*meths) - ...
Use forwardable from the stdlib
diff --git a/features/step_definitions/attachment_steps.rb b/features/step_definitions/attachment_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/attachment_steps.rb +++ b/features/step_definitions/attachment_steps.rb @@ -24,6 +24,8 @@ When /^the (?:attachment|image)s? (?:has|have) been virus\-...
Fix the cucumber virus checker so that it mimics the VirusScanHelper This is needed as we will mark the files a not clean otherwise. And Images on people have many variations which also need moving
diff --git a/MDCSwipeToChoose.podspec b/MDCSwipeToChoose.podspec index abc1234..def5678 100644 --- a/MDCSwipeToChoose.podspec +++ b/MDCSwipeToChoose.podspec @@ -8,7 +8,7 @@ s.social_media_url = 'https://twitter.com/modocache' s.source = { :git => 'https://github.com/modocache/MDCSwipeToChoose.git', :tag => "v#{s.v...
Remove .m files from public_header_files in .podspec
diff --git a/app/workers/update_scheduler.rb b/app/workers/update_scheduler.rb index abc1234..def5678 100644 --- a/app/workers/update_scheduler.rb +++ b/app/workers/update_scheduler.rb @@ -7,7 +7,7 @@ recurrence { hourly } def perform - Component.all.each do |component| + Component.select(:name).find_each ...
fix: Make update scheduler more performant
diff --git a/acts_as_paranoid.gemspec b/acts_as_paranoid.gemspec index abc1234..def5678 100644 --- a/acts_as_paranoid.gemspec +++ b/acts_as_paranoid.gemspec @@ -17,8 +17,8 @@ spec.test_files = Dir["test/*.rb"] spec.require_paths = ["lib"] - spec.add_dependency "activerecord", ">= 4.2", "< 6.0" - spec.add_de...
Allow ActiveRecord and ActiveSupport 6.0
diff --git a/config/initializers/crowdblog.rb b/config/initializers/crowdblog.rb index abc1234..def5678 100644 --- a/config/initializers/crowdblog.rb +++ b/config/initializers/crowdblog.rb @@ -2,3 +2,20 @@ Rails.application.config.discus_key = ENV['DISQUS_KEY'] Rails.application.config.publishers = ENV['PUBLISHERS']...
Add carrier wave AWS configuration
diff --git a/config/initializers/us_states.rb b/config/initializers/us_states.rb index abc1234..def5678 100644 --- a/config/initializers/us_states.rb +++ b/config/initializers/us_states.rb @@ -0,0 +1,60 @@+US_STATES = { + 'AL' => 'Alabama', + 'AK' => 'Alaska', + 'AS' => 'America Samoa', + 'AZ' => 'Arizona', + 'AR'...
Add US States abbreviations -> full name hash
diff --git a/config/software/datadog-gohai.rb b/config/software/datadog-gohai.rb index abc1234..def5678 100644 --- a/config/software/datadog-gohai.rb +++ b/config/software/datadog-gohai.rb @@ -9,6 +9,6 @@ build do command "$GOROOT/bin/go get -d -u github.com/DataDog/gohai", :env => env - command "cd $GOPATH/src...
Use cwd instead of cd for gohai software
diff --git a/test/unit/test_movie_walker_parse.rb b/test/unit/test_movie_walker_parse.rb index abc1234..def5678 100644 --- a/test/unit/test_movie_walker_parse.rb +++ b/test/unit/test_movie_walker_parse.rb @@ -0,0 +1,30 @@+# -*- coding: utf-8 -*- + +require 'test-unit' +require 'nokogiri' +require 'open-uri' + +require ...
Add test for parsing MovieWalker page.
diff --git a/app/models/meeting_proposal.rb b/app/models/meeting_proposal.rb index abc1234..def5678 100644 --- a/app/models/meeting_proposal.rb +++ b/app/models/meeting_proposal.rb @@ -4,5 +4,5 @@ belongs_to :meeting, counter_cache: :proposals_count belongs_to :proposal - delegate :title, to: :proposal + deleg...
Fix url generation by meeting proposal model