diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/config/initializers/heroku_keep_alive.rb b/config/initializers/heroku_keep_alive.rb index abc1234..def5678 100644 --- a/config/initializers/heroku_keep_alive.rb +++ b/config/initializers/heroku_keep_alive.rb @@ -0,0 +1,10 @@+require 'rufus/scheduler' +scheduler = Rufus::Scheduler.start_new + +if Rails.env....
Add keep alive for free heroku hosting
diff --git a/config/initializers/search_controller.rb b/config/initializers/search_controller.rb index abc1234..def5678 100644 --- a/config/initializers/search_controller.rb +++ b/config/initializers/search_controller.rb @@ -1,5 +1,5 @@ # Re-open SearchController to support different institutional search methods. -# We...
Clean up whitespace in the SearchController initializer
diff --git a/test/unit/release/finalizers/rsync_test.rb b/test/unit/release/finalizers/rsync_test.rb index abc1234..def5678 100644 --- a/test/unit/release/finalizers/rsync_test.rb +++ b/test/unit/release/finalizers/rsync_test.rb @@ -0,0 +1,52 @@+require "test_helper" +require "roger/testing/mock_release" + +module Roge...
Add tests for rsync finalizer
diff --git a/lib/platform/tasks/ci.rake b/lib/platform/tasks/ci.rake index abc1234..def5678 100644 --- a/lib/platform/tasks/ci.rake +++ b/lib/platform/tasks/ci.rake @@ -2,19 +2,19 @@ desc 'Setup and run rspec' task :rspec do - %x{ + system ''' mkdir -p spec/reports mkdir -p coverage/rcov COV...
Use system instead of %x{} so we see all the output. Helpful for Jenkins.
diff --git a/lib/tasks/sample_data.rake b/lib/tasks/sample_data.rake index abc1234..def5678 100644 --- a/lib/tasks/sample_data.rake +++ b/lib/tasks/sample_data.rake @@ -0,0 +1,9 @@+namespace :db do + desc "Fill the database with sample data" + task populate: :environment do + Bike.create!(name: "Mountain Bike") + ...
Add rake task for populating sample bikes
diff --git a/lib/tracker-git/project.rb b/lib/tracker-git/project.rb index abc1234..def5678 100644 --- a/lib/tracker-git/project.rb +++ b/lib/tracker-git/project.rb @@ -22,7 +22,7 @@ end def add_label(story, label) - labels = story.labels.split(",") || [] + labels = (story.labels || "").split(",") ...
Fix code when label is empty
diff --git a/lib/eye/patch/capistrano3.rb b/lib/eye/patch/capistrano3.rb index abc1234..def5678 100644 --- a/lib/eye/patch/capistrano3.rb +++ b/lib/eye/patch/capistrano3.rb @@ -38,8 +38,6 @@ end if fetch(:eye_default_hooks, true) - after "deploy:stop", "eye:stop" - after "deploy:start", "eye:load_config...
Remove obsolete hooks for Capistrano 3 integration
diff --git a/lib/salesforce_bulk/batch.rb b/lib/salesforce_bulk/batch.rb index abc1234..def5678 100644 --- a/lib/salesforce_bulk/batch.rb +++ b/lib/salesforce_bulk/batch.rb @@ -33,7 +33,7 @@ end def state?(value) - !self.state.nil? && self.state.casecmp(value) == 0 + self.state.present? && self...
Update state? method to use present? internally. All tests passing.
diff --git a/homebrew/dvm.rb b/homebrew/dvm.rb index abc1234..def5678 100644 --- a/homebrew/dvm.rb +++ b/homebrew/dvm.rb @@ -2,8 +2,8 @@ class Dvm < Formula homepage 'http://fnichol.github.io/dvm' - url 'https://github.com/fnichol/dvm/archive/v0.1.0.tar.gz' - sha1 '55562579262edfb1aca6a96568e561e362b4d96b' + ur...
Update homebrew formula for 0.2.0.
diff --git a/app/models/guest_device.rb b/app/models/guest_device.rb index abc1234..def5678 100644 --- a/app/models/guest_device.rb +++ b/app/models/guest_device.rb @@ -15,6 +15,8 @@ has_many :firmwares, :dependent => :destroy has_many :child_devices, -> { where(:parent_device_id => ids) }, :foreign_key => "parent...
Create an alias attribute for device_name to resolve guest device page error
diff --git a/spec/broadcast_spec.rb b/spec/broadcast_spec.rb index abc1234..def5678 100644 --- a/spec/broadcast_spec.rb +++ b/spec/broadcast_spec.rb @@ -0,0 +1,37 @@+require File.expand_path("./helper", File.dirname(__FILE__)) + +describe 'Broadcast' do + context 'search' do + before(:all) do + @gs = Groovesha...
Add tests for Broadcast class.
diff --git a/spec/mas_guardfile_spec.rb b/spec/mas_guardfile_spec.rb index abc1234..def5678 100644 --- a/spec/mas_guardfile_spec.rb +++ b/spec/mas_guardfile_spec.rb @@ -14,7 +14,7 @@ end - describe 'When providing as options as sass plugin identifier' do + describe 'When providing an options as sass plugi...
Fix type in spec desc
diff --git a/spec/support/setup_dirs.rb b/spec/support/setup_dirs.rb index abc1234..def5678 100644 --- a/spec/support/setup_dirs.rb +++ b/spec/support/setup_dirs.rb @@ -1,5 +1,5 @@ dirs = [] dirs << Rails.root.join('public', 'uploads', 'failed_imports') -dirs.each{|dir| Fileutils.mkdir_p dir unless Dir.exist? dir} +...
Fix stupid typo in specs support file
diff --git a/spec/todo/item_spec.rb b/spec/todo/item_spec.rb index abc1234..def5678 100644 --- a/spec/todo/item_spec.rb +++ b/spec/todo/item_spec.rb @@ -1,10 +1,14 @@ require 'spec_helper' Todo::Item = Struct.new(:text) do - attr_reader :assignee + attr_reader :assignee, :due_at def assign_to(assignee) @...
Add deadlines to todo items
diff --git a/examples/ask.rb b/examples/ask.rb index abc1234..def5678 100644 --- a/examples/ask.rb +++ b/examples/ask.rb @@ -1,7 +1,11 @@ # frozen_string_literal: true +require "pastel" require_relative "../lib/tty-prompt" prompt = TTY::Prompt.new +pastel = Pastel.new +notice = pastel.cyan.bold.detach -prompt.a...
Change example to show color configuration with a callable object
diff --git a/feature/feature_helper.rb b/feature/feature_helper.rb index abc1234..def5678 100644 --- a/feature/feature_helper.rb +++ b/feature/feature_helper.rb @@ -3,7 +3,7 @@ # Add the bin directory, to allow testing of gem executables as if the gem is # already installed. root_dir = RSpec::Core::RubyProject.root -...
Fix Rspec version compatibility issue
diff --git a/lib/jsonapi/authorization/resource_policy_authorization.rb b/lib/jsonapi/authorization/resource_policy_authorization.rb index abc1234..def5678 100644 --- a/lib/jsonapi/authorization/resource_policy_authorization.rb +++ b/lib/jsonapi/authorization/resource_policy_authorization.rb @@ -12,7 +12,7 @@ end...
Remove authorization on :save callback from resource This should be covered by :create_resource_operation in the operations processor.
diff --git a/server.rb b/server.rb index abc1234..def5678 100644 --- a/server.rb +++ b/server.rb @@ -19,8 +19,13 @@ end def practices_matching(search_term) - SEARCH_INDEX.find(search_term).map { |index, _, _| - PRACTICES.fetch(index) + SEARCH_INDEX.find(search_term).map { |index, matches, weight| + PRACTICES...
Add search scores to JSON output Useful during development to see how it's actually coming up with the matches.
diff --git a/db/migrate/20100524151953_move_notes_to_comments_in_students.rb b/db/migrate/20100524151953_move_notes_to_comments_in_students.rb index abc1234..def5678 100644 --- a/db/migrate/20100524151953_move_notes_to_comments_in_students.rb +++ b/db/migrate/20100524151953_move_notes_to_comments_in_students.rb @@ -2,1...
Adjust migration to use person instead of student
diff --git a/deployment/puppet/swift/spec/defines/swift_storage_node_spec.rb b/deployment/puppet/swift/spec/defines/swift_storage_node_spec.rb index abc1234..def5678 100644 --- a/deployment/puppet/swift/spec/defines/swift_storage_node_spec.rb +++ b/deployment/puppet/swift/spec/defines/swift_storage_node_spec.rb @@ -1,4...
Implement basic spec test for swift::storage::node
diff --git a/test/unit/integrations/universal/universal_return_test.rb b/test/unit/integrations/universal/universal_return_test.rb index abc1234..def5678 100644 --- a/test/unit/integrations/universal/universal_return_test.rb +++ b/test/unit/integrations/universal/universal_return_test.rb @@ -18,6 +18,11 @@ assert !...
Test success? after acknowledge on return.
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -29,8 +29,10 @@ @active_freddie = @freddies.first['id'] if @active_freddie != old_freddie - # Send notification e.g. "New Freddie!" + send_notification # Send notification through Mailgun update_freddie(@active_fre...
Send notification when there's a new Freddie
diff --git a/rpn.rb b/rpn.rb index abc1234..def5678 100644 --- a/rpn.rb +++ b/rpn.rb @@ -6,29 +6,29 @@ processor = Processor.new -puts "#{GREEN_TEXT}RPN Calculator, ©2014, Phil Runninger #{CYAN_TEXT}======================= Enter ? for help." -print "#{GREEN_TEXT} » #{RESET_COLORS}" +puts "#{TITLE_COLOR}RPN Calculat...
Use app-specific color constants. Use result of execute method instead of rereading the stack.
diff --git a/themes.gemspec b/themes.gemspec index abc1234..def5678 100644 --- a/themes.gemspec +++ b/themes.gemspec @@ -18,7 +18,7 @@ s.test_files = Dir["spec/**/*"] s.license = 'MIT' - s.add_dependency "rails" + s.add_dependency "rails", ">= 3.2" s.add_development_dependency "sqlite3" s.add_developme...
Make tests work from Rails 3.2 to 5.2
diff --git a/db/migrate/20110705151648_add_council_contacts_index_on_area_id_and_deleted.rb b/db/migrate/20110705151648_add_council_contacts_index_on_area_id_and_deleted.rb index abc1234..def5678 100644 --- a/db/migrate/20110705151648_add_council_contacts_index_on_area_id_and_deleted.rb +++ b/db/migrate/20110705151648_...
Add index on council contact area and deleted.
diff --git a/recipes/_source_han_code_jp_fonts.rb b/recipes/_source_han_code_jp_fonts.rb index abc1234..def5678 100644 --- a/recipes/_source_han_code_jp_fonts.rb +++ b/recipes/_source_han_code_jp_fonts.rb @@ -22,5 +22,5 @@ fc-cache -fv COMMAND - not_if 'ls #{install_dir} | grep SourceHanCodeJP' + not_if "ls ...
:bug: Fix fonts install skipping issue not_if condition isn't correct.
diff --git a/app/helpers/application_helper/toolbar/miq_alert_center.rb b/app/helpers/application_helper/toolbar/miq_alert_center.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper/toolbar/miq_alert_center.rb +++ b/app/helpers/application_helper/toolbar/miq_alert_center.rb @@ -25,7 +25,8 @@ ...
Add button class to toolbar
diff --git a/app/controllers/spree/adyen_notifications_controller.rb b/app/controllers/spree/adyen_notifications_controller.rb index abc1234..def5678 100644 --- a/app/controllers/spree/adyen_notifications_controller.rb +++ b/app/controllers/spree/adyen_notifications_controller.rb @@ -19,7 +19,7 @@ # Enable HTTP b...
Fix ENV var check in http basic auth
diff --git a/app/substitution_helper.rb b/app/substitution_helper.rb index abc1234..def5678 100644 --- a/app/substitution_helper.rb +++ b/app/substitution_helper.rb @@ -1,4 +1,12 @@ module SubstitutionHelper + SUBSTITUTABLE_DOCUMENT_TYPES = %w( + coming_soon + gone + redirect + unpublishing + special_ro...
Make the substitutable document types accessible As the SubstitutionHelper is involved in publishing content, to work out if a draft can be published, you need to know what the substitutable document types are.
diff --git a/spec/tic_tac_toe/game_spec.rb b/spec/tic_tac_toe/game_spec.rb index abc1234..def5678 100644 --- a/spec/tic_tac_toe/game_spec.rb +++ b/spec/tic_tac_toe/game_spec.rb @@ -5,17 +5,15 @@ describe TicTacToe::Game do let(:display) { double(:display) } + let(:game) { TicTacToe::Game.new display } it 'ca...
Add a let for the game object
diff --git a/spec/aruba/runtime_spec.rb b/spec/aruba/runtime_spec.rb index abc1234..def5678 100644 --- a/spec/aruba/runtime_spec.rb +++ b/spec/aruba/runtime_spec.rb @@ -1,47 +1,33 @@ require 'spec_helper' RSpec.describe Aruba::Runtime do + include_context 'uses aruba API' + describe '#fixtures_directory' do - ...
Make Aruba::Runtime specs test something
diff --git a/spec/route_loading_spec.rb b/spec/route_loading_spec.rb index abc1234..def5678 100644 --- a/spec/route_loading_spec.rb +++ b/spec/route_loading_spec.rb @@ -0,0 +1,37 @@+require "spec_helper" + +describe "loading routes from the db" do + start_backend_around_all :port => 3160, :identifier => "backend 1" + ...
Add tests around route loading functionality
diff --git a/spec/unit/downtime_spec.rb b/spec/unit/downtime_spec.rb index abc1234..def5678 100644 --- a/spec/unit/downtime_spec.rb +++ b/spec/unit/downtime_spec.rb @@ -1,7 +1,12 @@ require 'spec_helper' -class DowntimeTest < ActiveSupport::TestCase - # test "the truth" do - # assert true - # end +describe Downt...
Add stub for downtime unit tests
diff --git a/tasks/common.rb b/tasks/common.rb index abc1234..def5678 100644 --- a/tasks/common.rb +++ b/tasks/common.rb @@ -14,7 +14,8 @@ PROVIDER_FOLDERS = { ansible: 'build/ansible', puppet: 'build/puppet/%s', - chef: 'build/chef/%s' + chef: 'build/chef/%s', + terraform: 'build/terraform' }.freeze # Giv...
Add terraform as Rake target. Enables build of Terraform by: rake compile:terraform Change-Id: Ib9dac46d4cf6a8e3446d9aab6da29019f0335f38
diff --git a/irc2hipchat.god b/irc2hipchat.god index abc1234..def5678 100644 --- a/irc2hipchat.god +++ b/irc2hipchat.god @@ -6,6 +6,8 @@ God.watch do |w| w.name = 'irc2hipchat' - w.start = 'bundle exec ruby irc2hipchat.rb' + w.start = "bundle exec ruby irc2hipchat.rb" + w.dir = `pwd`.chomp + w.keepalive end ...
Set working directory to pwd
diff --git a/section02/lesson03/blueberry_hill.rb b/section02/lesson03/blueberry_hill.rb index abc1234..def5678 100644 --- a/section02/lesson03/blueberry_hill.rb +++ b/section02/lesson03/blueberry_hill.rb @@ -0,0 +1,61 @@+# Section 2, Lesson 3 - Rhythm 3 - Blueberry Hill Rhythm +# FIXME: The timing is a bit off here......
Put in attempt at Blueberry Hill, but the timing seems a bit off at the moment
diff --git a/lib/generators/my_zipcode_gem/templates/county_model.rb b/lib/generators/my_zipcode_gem/templates/county_model.rb index abc1234..def5678 100644 --- a/lib/generators/my_zipcode_gem/templates/county_model.rb +++ b/lib/generators/my_zipcode_gem/templates/county_model.rb @@ -8,8 +8,16 @@ validates :name, uni...
Convert raw SQL to Arel
diff --git a/auto_js.gemspec b/auto_js.gemspec index abc1234..def5678 100644 --- a/auto_js.gemspec +++ b/auto_js.gemspec @@ -1,12 +1,12 @@ Gem::Specification.new do |s| s.name = 'auto_js' - s.version = '0.9.0' + s.version = '0.9.1' s.date = '2015-03-20' s.summary = "Auto-executes ja...
Update gemspec with a few more details
diff --git a/jquery_mobile_rails.gemspec b/jquery_mobile_rails.gemspec index abc1234..def5678 100644 --- a/jquery_mobile_rails.gemspec +++ b/jquery_mobile_rails.gemspec @@ -14,7 +14,7 @@ s.description = "JQuery Mobile files for Rails' assets pipeline" s.license = 'MIT' - s.files = Dir["{app,config,db,lib,ve...
Fix gemspec to point to new README format
diff --git a/spec/scss_lint/linter/disable_linter_reason_spec.rb b/spec/scss_lint/linter/disable_linter_reason_spec.rb index abc1234..def5678 100644 --- a/spec/scss_lint/linter/disable_linter_reason_spec.rb +++ b/spec/scss_lint/linter/disable_linter_reason_spec.rb @@ -47,4 +47,17 @@ it { should_not report_lint } ...
Add spec ensuring only disables are checked We only want to enforce reasons for disabling of a linter, since when disabling over a range you don't want to have to justify both control comments.
diff --git a/lib/blocktrain/train_crowding.rb b/lib/blocktrain/train_crowding.rb index abc1234..def5678 100644 --- a/lib/blocktrain/train_crowding.rb +++ b/lib/blocktrain/train_crowding.rb @@ -1,6 +1,7 @@ module Blocktrain class TrainCrowding CAR_LOADS = %w[2E64930W 2E64932W 2E64934W 2E64936W] + CAR_NAMES = ...
Print carriage crowding information like the 80’s
diff --git a/spec/controllers/application_controller/advanced_search_spec.rb b/spec/controllers/application_controller/advanced_search_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/application_controller/advanced_search_spec.rb +++ b/spec/controllers/application_controller/advanced_search_spec.rb @@ -1,1...
Add spec test for fix of broken tagging in Datastores and My Services
diff --git a/user_api/com/mdi/storage/collection_definitions_mapping.rb b/user_api/com/mdi/storage/collection_definitions_mapping.rb index abc1234..def5678 100644 --- a/user_api/com/mdi/storage/collection_definitions_mapping.rb +++ b/user_api/com/mdi/storage/collection_definitions_mapping.rb @@ -21,9 +21,20 @@ ...
Add method to get definitions for an asset
diff --git a/test/io_test.rb b/test/io_test.rb index abc1234..def5678 100644 --- a/test/io_test.rb +++ b/test/io_test.rb @@ -0,0 +1,35 @@+require_relative 'test_helper' + +# Trivial IO test class +# Behavior is not really tested, as call is forwarded to File class +class IOTest < Minitest::Test + def test_method_IO_re...
Add non-regression test for IO mocks
diff --git a/hector.gemspec b/hector.gemspec index abc1234..def5678 100644 --- a/hector.gemspec +++ b/hector.gemspec @@ -2,8 +2,8 @@ s.name = "hector" s.version = "1.0.7" s.platform = Gem::Platform::RUBY - s.authors = ["Sam Stephenson"] - s.email = ["sstephenson@gmail.com"] + s.a...
Add Ross Paffett as a gem author Sam says that I am special now
diff --git a/lib/mc-schematic/array_helper.rb b/lib/mc-schematic/array_helper.rb index abc1234..def5678 100644 --- a/lib/mc-schematic/array_helper.rb +++ b/lib/mc-schematic/array_helper.rb @@ -16,5 +16,27 @@ end blocks end + # Gets the 'surface' of a multidimensional array + def get_surface(data...
Add array helper for getting surface
diff --git a/lib/rails5/spec_converter/cli.rb b/lib/rails5/spec_converter/cli.rb index abc1234..def5678 100644 --- a/lib/rails5/spec_converter/cli.rb +++ b/lib/rails5/spec_converter/cli.rb @@ -1,4 +1,5 @@ require 'rails5/spec_converter/text_transformer' +require 'rails5/spec_converter/version' require 'optparse' mo...
Add --version flag to print the version
diff --git a/lib/rspec/contracts/interface.rb b/lib/rspec/contracts/interface.rb index abc1234..def5678 100644 --- a/lib/rspec/contracts/interface.rb +++ b/lib/rspec/contracts/interface.rb @@ -11,27 +11,19 @@ end def add_requirement(method_name, options = {}) - Interface.add_requirement Interactio...
Simplify collection management in Interface
diff --git a/lib/camayoc.rb b/lib/camayoc.rb index abc1234..def5678 100644 --- a/lib/camayoc.rb +++ b/lib/camayoc.rb @@ -5,6 +5,7 @@ require 'camayoc/handlers/filter' require 'camayoc/handlers/io' require 'camayoc/handlers/memory' +require 'camayoc/handlers/statsd' require 'camayoc/stats' module Camayoc
Load the statsd handler by default without another require
diff --git a/lib/travis/build/addons/hosts.rb b/lib/travis/build/addons/hosts.rb index abc1234..def5678 100644 --- a/lib/travis/build/addons/hosts.rb +++ b/lib/travis/build/addons/hosts.rb @@ -13,6 +13,7 @@ sh.fold 'hosts.before' do sh.echo "" sh.cmd "cat #{HOSTS_FILE}" + ...
Add newline after host file to fix fold
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -14,7 +14,7 @@ # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone. # Run "rake -D time" for a list of tasks for findi...
Use US East timezone as default - at least for the moment.
diff --git a/Casks/kindle.rb b/Casks/kindle.rb index abc1234..def5678 100644 --- a/Casks/kindle.rb +++ b/Casks/kindle.rb @@ -7,7 +7,7 @@ homepage 'https://www.amazon.com/gp/digital/fiona/kcp-landing-page' license :gratis - app 'Kindle.App' + app 'Kindle.app' zap :delete => [ '~/Library/...
Fix for case-sensitive systems in Kindle Cask
diff --git a/spec/factories/songs.rb b/spec/factories/songs.rb index abc1234..def5678 100644 --- a/spec/factories/songs.rb +++ b/spec/factories/songs.rb @@ -7,6 +7,14 @@ status :closed youtube_id 'https://www.youtube.com/watch?v=2TL90rxt9bo' comment 'アンプラグドのテーマソングです' + + transient do + user nil + ...
Enable to create a song with a user by the factory
diff --git a/spec/ffi/string_spec.rb b/spec/ffi/string_spec.rb index abc1234..def5678 100644 --- a/spec/ffi/string_spec.rb +++ b/spec/ffi/string_spec.rb @@ -22,6 +22,10 @@ str.should == "test" str.tainted?.should == true end + it "Poison null byte raises error" do + s = "123\0abc" + lambda { LibTest....
Add poison null byte spec
diff --git a/spec/lib/config_spec.rb b/spec/lib/config_spec.rb index abc1234..def5678 100644 --- a/spec/lib/config_spec.rb +++ b/spec/lib/config_spec.rb @@ -7,9 +7,7 @@ its('github.user') { should be_nil } its('github.token') { should be_nil } - context 'with a config file' do - include_context 'init anvil ...
Use rspec metadata to load context
diff --git a/lib/facterdb.rb b/lib/facterdb.rb index abc1234..def5678 100644 --- a/lib/facterdb.rb +++ b/lib/facterdb.rb @@ -4,9 +4,10 @@ module FacterDB def self.get_os_facts(facter_version='*', filter=[]) + facts_dir = File.expand_path(File.join(File.dirname(__FILE__), '../facts')) filter_str = filter.ma...
Use a relative factsdir for the lib
diff --git a/lib/paprika.rb b/lib/paprika.rb index abc1234..def5678 100644 --- a/lib/paprika.rb +++ b/lib/paprika.rb @@ -3,6 +3,8 @@ module Paprika class Tasks < Thor + include Thor::Actions + desc "compile", "Compile sass and haml" def compile Dir["**/*.haml"].each do |file| @@ -27,7 +29,14 @@...
Improve run the command to package the extension Signed-off-by: Johanna Mantilla Duque <5cd76578dd906d3abcbebcbe5b23d6d7232b4085@gmail.com>
diff --git a/lib/promobox.rb b/lib/promobox.rb index abc1234..def5678 100644 --- a/lib/promobox.rb +++ b/lib/promobox.rb @@ -14,7 +14,7 @@ @api_key = api_key @login = login @password = password - @hash_password = Digest::MD5.hexdigest("#{@password}{#{@api_key}}").unpack('H*').first + @hash_password ...
Use digest instead of hexdigest API doc use $raw_output = true for md5 and sha1 functions
diff --git a/linked_list.rb b/linked_list.rb index abc1234..def5678 100644 --- a/linked_list.rb +++ b/linked_list.rb @@ -0,0 +1,50 @@+class SinlglyLinkedList + def initialize + @head = Node.new(value) + end + + def add(value) + node = Node.new(value) + node.next = @head + @head = node + end + + def rem...
Add singly linked list class
diff --git a/lib/asset_hash/railtie.rb b/lib/asset_hash/railtie.rb index abc1234..def5678 100644 --- a/lib/asset_hash/railtie.rb +++ b/lib/asset_hash/railtie.rb @@ -1,9 +1,12 @@ require 'asset_hash' -require 'rails' -module AssetHash - class Railtie < Rails::Railtie - rake_tasks do - load "tasks/asset_hash.rak...
Allow asset_hash to work with Rails 2.3.x.
diff --git a/lib/classes/purchasing.rb b/lib/classes/purchasing.rb index abc1234..def5678 100644 --- a/lib/classes/purchasing.rb +++ b/lib/classes/purchasing.rb @@ -10,21 +10,21 @@ end role :purchaser do - def has_already_purchased_book? + def owns_book? Purchase.where(purchaser: self, book: book).c...
Rename method to check if purchaser owns book
diff --git a/config/initializers/avalon_lti.rb b/config/initializers/avalon_lti.rb index abc1234..def5678 100644 --- a/config/initializers/avalon_lti.rb +++ b/config/initializers/avalon_lti.rb @@ -5,7 +5,7 @@ module Lti begin Configuration = - YAML.safe_load(ERB.new(File.read(File.expand_path('../....
Use `YAML.load` instead of `YAML.safe_load` because although Rubocop wants `safe_load`, it doesn't parse symbols (which is what the example `lti.yml` uses).
diff --git a/bosh_cli_plugin_aws/migrations/20130412183544_create_rds_dbs.rb b/bosh_cli_plugin_aws/migrations/20130412183544_create_rds_dbs.rb index abc1234..def5678 100644 --- a/bosh_cli_plugin_aws/migrations/20130412183544_create_rds_dbs.rb +++ b/bosh_cli_plugin_aws/migrations/20130412183544_create_rds_dbs.rb @@ -8,7...
Revert "Boostrap no longer creates an RDS database for a public mysql offering." This reverts commit ea7a17091d4d5208ad11feb155427ae18022d443. Requires a cross team pair. Also retro-actively changing a migration that has already run is a no-no.
diff --git a/config/initializers/setup_mail.rb b/config/initializers/setup_mail.rb index abc1234..def5678 100644 --- a/config/initializers/setup_mail.rb +++ b/config/initializers/setup_mail.rb @@ -1,9 +1,8 @@ ActionMailer::Base.smtp_settings = { - address: "smtp.gmail.com", - port: 587, - domain: "gmail.com", ...
Fix mail not sending properly in production
diff --git a/joofaq.gemspec b/joofaq.gemspec index abc1234..def5678 100644 --- a/joofaq.gemspec +++ b/joofaq.gemspec @@ -12,6 +12,9 @@ gem.summary = %q{Easily implement dynamic FAQ pages into your rails app} gem.homepage = "https://github.com/joofsh/joofaq" + gem.add_dependency "rdiscount", "1.6.8" +...
Add rdiscount as gem dependency
diff --git a/db/migrate/20150115013419_organisation_default_string_values.rb b/db/migrate/20150115013419_organisation_default_string_values.rb index abc1234..def5678 100644 --- a/db/migrate/20150115013419_organisation_default_string_values.rb +++ b/db/migrate/20150115013419_organisation_default_string_values.rb @@ -28,...
Change scoping for down migration too
diff --git a/lib/cucumber/rails/world.rb b/lib/cucumber/rails/world.rb index abc1234..def5678 100644 --- a/lib/cucumber/rails/world.rb +++ b/lib/cucumber/rails/world.rb @@ -20,7 +20,7 @@ module Cucumber module Rails - class World < ActionDispatch::IntegrationTest + class World < ::ActionDispatch::Integration...
Resolve NameError occurring in TravisCI The build is failing with multiple occurrences of the following error: `uninitialized constant Cucumber::Rails::ActionDispatch::IntegrationTest (NameError)` Example: https://travis-ci.org/cucumber/cucumber-rails/jobs/650040930 I have also encountered this error when pointing a...
diff --git a/lib/exiv2/shared_methods.rb b/lib/exiv2/shared_methods.rb index abc1234..def5678 100644 --- a/lib/exiv2/shared_methods.rb +++ b/lib/exiv2/shared_methods.rb @@ -23,4 +23,26 @@ end "#<#{self.class.name}: {#{items.join(', ')}}>" end + + def [](key) + self.to_hash[key] + end + + def []=(...
Add array accessors and method to set (delete all and add new) tags.
diff --git a/test/integration/default/serverspec/default_spec.rb b/test/integration/default/serverspec/default_spec.rb index abc1234..def5678 100644 --- a/test/integration/default/serverspec/default_spec.rb +++ b/test/integration/default/serverspec/default_spec.rb @@ -10,19 +10,3 @@ describe service('cloudsight') do ...
Remove serverspec tests that are unable to be tested w/o TS key
diff --git a/test/integration/default/serverspec/default_spec.rb b/test/integration/default/serverspec/default_spec.rb index abc1234..def5678 100644 --- a/test/integration/default/serverspec/default_spec.rb +++ b/test/integration/default/serverspec/default_spec.rb @@ -0,0 +1,51 @@+require 'serverspec' +require 'pathnam...
Add serverspec coverage for the default recipe!
diff --git a/lib/graphql/validation.rb b/lib/graphql/validation.rb index abc1234..def5678 100644 --- a/lib/graphql/validation.rb +++ b/lib/graphql/validation.rb @@ -25,7 +25,7 @@ GraphQL::Argument.accepts_definitions \ validate_with: ->(type_defn, validator) { type_defn.define do - prepare ...
Fix warning about arity of prepare
diff --git a/spec/data/local_authorities_csv_spec.rb b/spec/data/local_authorities_csv_spec.rb index abc1234..def5678 100644 --- a/spec/data/local_authorities_csv_spec.rb +++ b/spec/data/local_authorities_csv_spec.rb @@ -0,0 +1,88 @@+describe "local-authorities.csv" do + let(:path_to_csv) { File.expand_path("../../dat...
Test that data CSV is valid This checks that the CSV has the right number of values in each row, and that each value is in the format we expect. It also checks that the headings are in the order we expect. The regexes used in these tests are for sense-checking only. For example, checking that the URL field begins wit...
diff --git a/spec/lib/nacre/order_collection_spec.rb b/spec/lib/nacre/order_collection_spec.rb index abc1234..def5678 100644 --- a/spec/lib/nacre/order_collection_spec.rb +++ b/spec/lib/nacre/order_collection_spec.rb @@ -2,40 +2,33 @@ describe Nacre::OrderCollection do - describe '#orders' do + let(:parametrized_...
Make OrderCollection spec test the right things OrderCollection was testing things in Order, so now it just makes sure it has an Order, which seems like a reasonable thing to depend on until we add more resources.
diff --git a/chamber.gemspec b/chamber.gemspec index abc1234..def5678 100644 --- a/chamber.gemspec +++ b/chamber.gemspec @@ -26,7 +26,6 @@ spec.add_runtime_dependency "hashie", "~> 2.0" - spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" spec.add_development_depende...
Remove bundler from the development dependencies. It lives outside of gemspecs
diff --git a/lib/instagram/response.rb b/lib/instagram/response.rb index abc1234..def5678 100644 --- a/lib/instagram/response.rb +++ b/lib/instagram/response.rb @@ -4,9 +4,12 @@ data = response_hash.data.dup rescue response_hash data.extend( self ) data.instance_exec do - @pagination = respon...
Fix "can't modify frozen NilClass".
diff --git a/lib/jekyll_test_plugin.rb b/lib/jekyll_test_plugin.rb index abc1234..def5678 100644 --- a/lib/jekyll_test_plugin.rb +++ b/lib/jekyll_test_plugin.rb @@ -15,6 +15,8 @@ end class TestGenerator < Jekyll::Generator + safe true + def generate(site) site.pages << TestPage.new(site, site.sour...
Set it to true so it'll run in a whitelist. /cc @benbalter
diff --git a/lib/parse-model-scaffold.rb b/lib/parse-model-scaffold.rb index abc1234..def5678 100644 --- a/lib/parse-model-scaffold.rb +++ b/lib/parse-model-scaffold.rb @@ -2,7 +2,7 @@ require 'parse-model-scaffold/parse_inspector' require 'parse-model-scaffold/parse_class_builder' -class ParseModelGenerator +class ...
Change main class name to match Gem name
diff --git a/lib/persey/adapters/yaml.rb b/lib/persey/adapters/yaml.rb index abc1234..def5678 100644 --- a/lib/persey/adapters/yaml.rb +++ b/lib/persey/adapters/yaml.rb @@ -6,7 +6,7 @@ class << self def load(file, env) begin - raw_hash = YAML.load_file(file) + raw_hash = ...
Add ERB support in YAML files
diff --git a/lib/htmlentities/decoder.rb b/lib/htmlentities/decoder.rb index abc1234..def5678 100644 --- a/lib/htmlentities/decoder.rb +++ b/lib/htmlentities/decoder.rb @@ -9,11 +9,11 @@ def decode(source) prepare(source).gsub(@entity_regexp){ if $1 && codepoint = @map[$1] - [codepoint].pac...
Use chr instead of pack It expresses the intention more clearly, and it's about twice as fast.
diff --git a/lib/rack/quote_displayer.rb b/lib/rack/quote_displayer.rb index abc1234..def5678 100644 --- a/lib/rack/quote_displayer.rb +++ b/lib/rack/quote_displayer.rb @@ -1,20 +1,25 @@+require 'rack' + class QuoteDisplayer attr_reader :quotes - def initialize(app) - @app = app #rails application - @quote...
Refactor code to allow any params.
diff --git a/lib/rb_wunderground/base.rb b/lib/rb_wunderground/base.rb index abc1234..def5678 100644 --- a/lib/rb_wunderground/base.rb +++ b/lib/rb_wunderground/base.rb @@ -20,14 +20,16 @@ FEATURES.each do |name| define_method(name) do |arg| - url = base_url + name + "/q/" + arg + format + ur...
Use << instead of +
diff --git a/lib/lagomorph/subscriber.rb b/lib/lagomorph/subscriber.rb index abc1234..def5678 100644 --- a/lib/lagomorph/subscriber.rb +++ b/lib/lagomorph/subscriber.rb @@ -7,8 +7,11 @@ @worker_class = worker_class end - def subscribe(queue, channel) - queue.subscribe(manual_ack: true, block: false...
Allow subscribe to take opts, and default durable: true
diff --git a/lib/recurly/xml/nokogiri.rb b/lib/recurly/xml/nokogiri.rb index abc1234..def5678 100644 --- a/lib/recurly/xml/nokogiri.rb +++ b/lib/recurly/xml/nokogiri.rb @@ -36,7 +36,7 @@ if node.text? node.text else - node.children.each { |e| return e.text if e.text? } + ...
Fix Nokogiri interpretation of empty nodes Nokogiri::Element returns the number of nodes when you call children#each, leading to text returning 0 if there are none. Instead, let's join the texts together and return that ("" instead in that last case). Signed-off-by: Stephen Celis <06fa905d7f2aaced6dc72e9511c71a2a51e8...
diff --git a/UIColor_Hex_Swift.podspec b/UIColor_Hex_Swift.podspec index abc1234..def5678 100644 --- a/UIColor_Hex_Swift.podspec +++ b/UIColor_Hex_Swift.podspec @@ -12,4 +12,5 @@ s.source_files = 'HEXColor/*.{h,swift}' s.frameworks = ['UIKit'] s.requires_arc = true + s.swift_versions = ['5.0'] end
Fix -- [!] Usage of the `.swift_version` file has been deprecated! Please delete the file and use the `swift_versions` attribute within your podspec instead.
diff --git a/spec/requests/public/viewing_talks_for_an_event_spec.rb b/spec/requests/public/viewing_talks_for_an_event_spec.rb index abc1234..def5678 100644 --- a/spec/requests/public/viewing_talks_for_an_event_spec.rb +++ b/spec/requests/public/viewing_talks_for_an_event_spec.rb @@ -3,9 +3,9 @@ RSpec.describe "Creatin...
Clean up spec a little bit around creating an event through the organizer
diff --git a/app/helpers/pages_helper.rb b/app/helpers/pages_helper.rb index abc1234..def5678 100644 --- a/app/helpers/pages_helper.rb +++ b/app/helpers/pages_helper.rb @@ -7,12 +7,11 @@ content = page.title if content.nil? begin link_to(content, - (page.advanced_path.blank? ? show_path(page.tit...
Fix for advanced_path requiring arguments.
diff --git a/lib/tasks/spree_chimpy.rake b/lib/tasks/spree_chimpy.rake index abc1234..def5678 100644 --- a/lib/tasks/spree_chimpy.rake +++ b/lib/tasks/spree_chimpy.rake @@ -20,4 +20,19 @@ puts nil, 'done' end end + + namespace :users do + desc 'segment all subscribed users' + task segment: :envir...
Add rake task for segmenting users Rake task will segment all subscribed users and print out errors if it encounters any.
diff --git a/lib/pliny/helpers/params.rb b/lib/pliny/helpers/params.rb index abc1234..def5678 100644 --- a/lib/pliny/helpers/params.rb +++ b/lib/pliny/helpers/params.rb @@ -7,7 +7,7 @@ private def parse_body_params - if request.content_type == "application/json" + if request.media_type == "applicat...
Check media_type instead of content_type. This will allow Content-Types header values such as "application/json;charset=utf-8".
diff --git a/postgresql_connector.gemspec b/postgresql_connector.gemspec index abc1234..def5678 100644 --- a/postgresql_connector.gemspec +++ b/postgresql_connector.gemspec @@ -1,6 +1,6 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| - s.name = 'postgresql_connector' + s.name = 'postgresql-connector' s...
Use sequel version 4.14.0 and update gem name to match file structure.
diff --git a/lib/mail/gpg/sign_part.rb b/lib/mail/gpg/sign_part.rb index abc1234..def5678 100644 --- a/lib/mail/gpg/sign_part.rb +++ b/lib/mail/gpg/sign_part.rb @@ -12,12 +12,25 @@ end end - def self.signature_valid?(plain, signature, options = {}) - if !(signature.has_content_type? && ('ap...
Fix signature verification for external messages. Mail::Body.encoded returns an altered string compared to the original if the original wasn't created with Mail.
diff --git a/lib/ridgepole/cli/config.rb b/lib/ridgepole/cli/config.rb index abc1234..def5678 100644 --- a/lib/ridgepole/cli/config.rb +++ b/lib/ridgepole/cli/config.rb @@ -42,6 +42,7 @@ 'username' => uri.user, 'password' => uri.password, 'host' => uri.host, + 'port' => uri.port...
Fix database url parse: parse port num
diff --git a/recipes/_ruby.rb b/recipes/_ruby.rb index abc1234..def5678 100644 --- a/recipes/_ruby.rb +++ b/recipes/_ruby.rb @@ -28,6 +28,10 @@ package 'ruby2.0' package 'ruby2.0-dev' +# Nokogiri requires XML +package 'libxslt-dev' +package 'libxml2-dev' + gem_package 'bundler' execute 'bundle[install]' do
Fix up a few minor issues on the DevVM with VirtualBox
diff --git a/lib/twentyfour_seven_office/services/authentication.rb b/lib/twentyfour_seven_office/services/authentication.rb index abc1234..def5678 100644 --- a/lib/twentyfour_seven_office/services/authentication.rb +++ b/lib/twentyfour_seven_office/services/authentication.rb @@ -10,6 +10,10 @@ operations :login,...
Convert hash argument to Credential data type
diff --git a/lib/search/query_helpers.rb b/lib/search/query_helpers.rb index abc1234..def5678 100644 --- a/lib/search/query_helpers.rb +++ b/lib/search/query_helpers.rb @@ -3,21 +3,14 @@ module QueryHelpers private - # Combine filters using an operator - # - # `filters` should be a sequence of filters. ...
Simplify and update combining filters Combining filters is only necessary for the or/should case. The 'and' case is the default: https://www.elastic.co/guide/en/elasticsearch/guide/current/combining-filters.html#bool-filter :or and :and are deprecated and replaced by a 'bool' query - https://www.elastic.co/guide/en/e...
diff --git a/activerecord/test/cases/adapters/mysql/quoting_test.rb b/activerecord/test/cases/adapters/mysql/quoting_test.rb index abc1234..def5678 100644 --- a/activerecord/test/cases/adapters/mysql/quoting_test.rb +++ b/activerecord/test/cases/adapters/mysql/quoting_test.rb @@ -15,14 +15,14 @@ def test_quoted_dat...
Remove ivar only when defined this fixes a failing test case
diff --git a/zircon.gemspec b/zircon.gemspec index abc1234..def5678 100644 --- a/zircon.gemspec +++ b/zircon.gemspec @@ -14,4 +14,6 @@ gem.name = "zircon" gem.require_paths = ["lib"] gem.version = Zircon::VERSION + + gem.add_development_dependency "rspec" end
Add RSpec dependency for development
diff --git a/app/jobs/prepare_benchmark_execution_job.rb b/app/jobs/prepare_benchmark_execution_job.rb index abc1234..def5678 100644 --- a/app/jobs/prepare_benchmark_execution_job.rb +++ b/app/jobs/prepare_benchmark_execution_job.rb @@ -4,14 +4,16 @@ benchmark_definition = BenchmarkDefinition.find(benchmark_definit...
Add BenchmarkExecution status update and fix mixing up execution and definition on save
diff --git a/app/models/spree/stock/package_decorator.rb b/app/models/spree/stock/package_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/stock/package_decorator.rb +++ b/app/models/spree/stock/package_decorator.rb @@ -1,6 +1,6 @@ module Spree::Stock::PackageDecorator def shipping_methods - if (...
Return all shipping methods when Shipping Methods aren't vendorized
diff --git a/log.gemspec b/log.gemspec index abc1234..def5678 100644 --- a/log.gemspec +++ b/log.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-log' - s.version = '0.5.2.1' + s.version = '0.6.0.0' s.summary = 'Logging to STD IO with levels, tagging, and coloring' ...
Package version is increased from 0.5.2.1 to 0.6.0.0
diff --git a/core/lib/tasks/refinery.rb b/core/lib/tasks/refinery.rb index abc1234..def5678 100644 --- a/core/lib/tasks/refinery.rb +++ b/core/lib/tasks/refinery.rb @@ -1,3 +1,4 @@+=begin # Because we use plugins that are shipped via gems, we lose their rake tasks. # So here, we find them (if there are any) and inclu...
Disable loading in of extra tasks.