diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/polished-knockout.gemspec b/polished-knockout.gemspec index abc1234..def5678 100644 --- a/polished-knockout.gemspec +++ b/polished-knockout.gemspec @@ -10,7 +10,7 @@ spec.email = ["jared@jaredwhite.com"] spec.description = %q{An Opal wrapper for creating view models that use Knockout.js for ...
Use knockout-rb, not knockout, so as to avoid repo naming collision with main knockout project
diff --git a/rom-sql.gemspec b/rom-sql.gemspec index abc1234..def5678 100644 --- a/rom-sql.gemspec +++ b/rom-sql.gemspec @@ -15,7 +15,7 @@ spec.files = Dir['CHANGELOG.md', 'LICENSE', 'README.md', 'lib/**/*'] spec.require_paths = ['lib'] - spec.required_ruby_version = ">= 2.3.0" + spec.required_ruby_ver...
Drop support for Ruby < 2.4
diff --git a/test/integration/default/serverspec/postgresql_spec.rb b/test/integration/default/serverspec/postgresql_spec.rb index abc1234..def5678 100644 --- a/test/integration/default/serverspec/postgresql_spec.rb +++ b/test/integration/default/serverspec/postgresql_spec.rb @@ -0,0 +1,25 @@+require "spec_helper" + +d...
Add integration test for PostgreSQL
diff --git a/spec/command/linux/bridge_spec.rb b/spec/command/linux/bridge_spec.rb index abc1234..def5678 100644 --- a/spec/command/linux/bridge_spec.rb +++ b/spec/command/linux/bridge_spec.rb @@ -0,0 +1,12 @@+require 'spec_helper' + +property[:os] = nil +set :os, :family => 'linux' + +describe get_command(:check_bridg...
Add tests for Bridge resource on Linux
diff --git a/spec/helpers/plots_helper_spec.rb b/spec/helpers/plots_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/plots_helper_spec.rb +++ b/spec/helpers/plots_helper_spec.rb @@ -9,7 +9,7 @@ before { plot.featured_plant = nil } before { allow(helper).to receive(:current_user).and_return(c...
Update link in spec to fix broken test
diff --git a/ruby/to_file.rb b/ruby/to_file.rb index abc1234..def5678 100644 --- a/ruby/to_file.rb +++ b/ruby/to_file.rb @@ -0,0 +1,31 @@+#!/bin/env ruby + +# A ruby module is a collection of functions and constants. +# By including a module as part of a class, those behaviors and constants become +# part of the class....
Add an example of mixin By including a module in a class we can add behaviors without using an inheritance relation. We can add features regardless of his others properties.
diff --git a/app/controllers/widgets_controller.rb b/app/controllers/widgets_controller.rb index abc1234..def5678 100644 --- a/app/controllers/widgets_controller.rb +++ b/app/controllers/widgets_controller.rb @@ -1,5 +1,5 @@ class WidgetsController < ApplicationController - #before_filter :authenticate + before_filte...
Add back before_filter on widgets so you must be logged in
diff --git a/tekido.gemspec b/tekido.gemspec index abc1234..def5678 100644 --- a/tekido.gemspec +++ b/tekido.gemspec @@ -10,7 +10,7 @@ spec.email = ["pinzolo@gmail.com"] spec.description = %q{`Tekido` generates various random value.} spec.summary = %q{A handy little random value generator.} - s...
Add homepage URL to gemspec
diff --git a/puppet-lint-duplicate_class_parameters-check.gemspec b/puppet-lint-duplicate_class_parameters-check.gemspec index abc1234..def5678 100644 --- a/puppet-lint-duplicate_class_parameters-check.gemspec +++ b/puppet-lint-duplicate_class_parameters-check.gemspec @@ -22,7 +22,7 @@ spec.add_development_dependency...
Update rubocop requirement from ~> 0.76.0 to ~> 0.77.0 Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](h...
diff --git a/app/jobs/user_import_operation_job.rb b/app/jobs/user_import_operation_job.rb index abc1234..def5678 100644 --- a/app/jobs/user_import_operation_job.rb +++ b/app/jobs/user_import_operation_job.rb @@ -9,6 +9,8 @@ unless succeeded operation_failed(format_error_report(batch.errors)) end + ens...
2343: Delete file upload after job processing
diff --git a/dash/app/controllers/spree/admin/overview_controller.rb b/dash/app/controllers/spree/admin/overview_controller.rb index abc1234..def5678 100644 --- a/dash/app/controllers/spree/admin/overview_controller.rb +++ b/dash/app/controllers/spree/admin/overview_controller.rb @@ -18,7 +18,7 @@ private de...
Correct call to Spree::Dash::Config.configured? within Admin::OverviewController
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -1,7 +1,7 @@ require 'rubygems' require 'bundler' begin - Bundler.setup(:default, :development) + Bundler.setup(:default, :development, :test) rescue Bundler::BundlerError => e $stderr.puts e....
Add test enviroment to bundler setup on tests This made possible to run individual tests with something like: ruby -Itest/ test/test_spinning_cursor.rb -v -n "/allow you to change the banner/" Necessary to faster repeating individual tests.
diff --git a/renderer.rb b/renderer.rb index abc1234..def5678 100644 --- a/renderer.rb +++ b/renderer.rb @@ -6,7 +6,9 @@ COLON = 10 def initialize(game) - @game = game + @game = game + @bomb_led = LED.new(game, 495, 9) + @elapsed_led = LED.new(game, 210, 9) end def d...
Add a LED class for bombs and elapsed time display
diff --git a/app/decorators/controllers/refinery/pages_controller_decorator.rb b/app/decorators/controllers/refinery/pages_controller_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/controllers/refinery/pages_controller_decorator.rb +++ b/app/decorators/controllers/refinery/pages_controller_decorator.rb...
Use an ISO 8601 date instead of distance. Fixes #7
diff --git a/definitions/disk-monitor.rb b/definitions/disk-monitor.rb index abc1234..def5678 100644 --- a/definitions/disk-monitor.rb +++ b/definitions/disk-monitor.rb @@ -20,7 +20,7 @@ template application[:bin] do source application[:template] cookbook application[:cookbook] - user application[:user] ...
Switch template dsl to use the correct method for user permissions (owner)
diff --git a/spec/helpers/physical_server_helper/textual_summary_spec.rb b/spec/helpers/physical_server_helper/textual_summary_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/physical_server_helper/textual_summary_spec.rb +++ b/spec/helpers/physical_server_helper/textual_summary_spec.rb @@ -0,0 +1,28 @@+descri...
Add spec test for textual_ipv4
diff --git a/init.rb b/init.rb index abc1234..def5678 100644 --- a/init.rb +++ b/init.rb @@ -2,7 +2,9 @@ require File.join(File.dirname(__FILE__), '/lib/rites_portal.rb') require File.join(File.dirname(__FILE__), '/lib/sds_connect.rb') +# Access this class so that the has_many_polymorphs code will get called and set...
Comment explaining why we're accessing School.
diff --git a/Casks/opera-developer.rb b/Casks/opera-developer.rb index abc1234..def5678 100644 --- a/Casks/opera-developer.rb +++ b/Casks/opera-developer.rb @@ -1,6 +1,6 @@ cask :v1 => 'opera-developer' do - version '29.0.1795.14' - sha256 'ce0e8ecdac8c1fda65369acc5d9539faad529e0970c4a6de0c5ed832e29d34e0' + version ...
Upgrade Opera Developer.app to v30.0.1812.0
diff --git a/spec/integration/example_spec.rb b/spec/integration/example_spec.rb index abc1234..def5678 100644 --- a/spec/integration/example_spec.rb +++ b/spec/integration/example_spec.rb @@ -9,7 +9,7 @@ let(:default_title) { "Example Presentation" } let(:description) { "Several parade examples to assist with s...
FIX for integration specs based on example preso change
diff --git a/spec/integration/haproxy_spec.rb b/spec/integration/haproxy_spec.rb index abc1234..def5678 100644 --- a/spec/integration/haproxy_spec.rb +++ b/spec/integration/haproxy_spec.rb @@ -0,0 +1,24 @@+require 'spec_helper' + +require 'httparty' + +RSpec.describe "haproxy" do + [0, 1].each do |job_index| + cont...
Revert "Remove haproxy system test" This reverts commit 25e6748fcabfd35ea2f98702a94f460a284afe74.
diff --git a/human_player.rb b/human_player.rb index abc1234..def5678 100644 --- a/human_player.rb +++ b/human_player.rb @@ -44,4 +44,11 @@ end end + + def call_shot + guess = nil + + + end + end
Add computer guessing for calling shots.
diff --git a/tasks/rspec.rake b/tasks/rspec.rake index abc1234..def5678 100644 --- a/tasks/rspec.rake +++ b/tasks/rspec.rake @@ -1,3 +1,10 @@ require 'rspec/core/rake_task' -RSpec::Core::RakeTask.new('spec') +RSpec::Core::RakeTask.new(:spec) + +namespace :spec do + desc "Open coverage report in browser" + task :ope...
Add a task to open the coverage report
diff --git a/spec/db_spec.rb b/spec/db_spec.rb index abc1234..def5678 100644 --- a/spec/db_spec.rb +++ b/spec/db_spec.rb @@ -25,7 +25,19 @@ expect(Db.table_exists?(test_table)).to be_false end + it "creates a table when called to" do + Db.create_table test_table, nil, '(var1 text)' + ...
Add tests for table creation, table drops
diff --git a/test/features/support/pages/catalinker/catalinker_client.rb b/test/features/support/pages/catalinker/catalinker_client.rb index abc1234..def5678 100644 --- a/test/features/support/pages/catalinker/catalinker_client.rb +++ b/test/features/support/pages/catalinker/catalinker_client.rb @@ -13,7 +13,8 @@ e...
Make sure new work button is present
diff --git a/lib/flickrie/collection.rb b/lib/flickrie/collection.rb index abc1234..def5678 100644 --- a/lib/flickrie/collection.rb +++ b/lib/flickrie/collection.rb @@ -7,7 +7,7 @@ # (you can evem use it with [will_paginate](https://github.com/mislav/will_paginate), # see {Flickrie.pagination}). It also has the me...
Fix Flickrie::Collection still using will_paginate, even though it isn't explicitly set
diff --git a/spec/classes/params_spec.rb b/spec/classes/params_spec.rb index abc1234..def5678 100644 --- a/spec/classes/params_spec.rb +++ b/spec/classes/params_spec.rb @@ -11,4 +11,17 @@ it "Should not contain any resources" do subject.resources.size.should == 4 end + + describe "With unknown lsbdistid" do ...
Add spec test to test for failure
diff --git a/spec/classes/params_spec.rb b/spec/classes/params_spec.rb index abc1234..def5678 100644 --- a/spec/classes/params_spec.rb +++ b/spec/classes/params_spec.rb @@ -0,0 +1,10 @@+require 'spec_helper' + +describe 'nexus::params', :type => :class do + + context 'with default params' do + it { should contain_c...
Add basic tests for nexus::params Signed-off-by: Andrew Grimberg <1f872228929e751eea07667e68fbb1655199bd12@linuxfoundation.org>
diff --git a/react-native-track-player.podspec b/react-native-track-player.podspec index abc1234..def5678 100644 --- a/react-native-track-player.podspec +++ b/react-native-track-player.podspec @@ -3,19 +3,21 @@ package = JSON.parse(File.read(File.join(__dir__, "package.json"))) Pod::Spec.new do |s| - s.name ...
[iOS] Update podspec swift version to match SwiftAudio submodule. Cleanup quotes and other formatting.
diff --git a/spec/models/comment_spec.rb b/spec/models/comment_spec.rb index abc1234..def5678 100644 --- a/spec/models/comment_spec.rb +++ b/spec/models/comment_spec.rb @@ -1,11 +1,6 @@ require 'rails_helper' RSpec.describe Comment, type: :model do - let(:question) { create(:question) } - let(:user) {create(:user,...
Remove unnecessary lets from comment model test
diff --git a/spec/dummy/app/controllers/application_controller.rb b/spec/dummy/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/spec/dummy/app/controllers/application_controller.rb +++ b/spec/dummy/app/controllers/application_controller.rb @@ -1,3 +1,7 @@ class ApplicationController < Actio...
Define sign_in_path in ApplicationController for dummy application
diff --git a/tltool.gemspec b/tltool.gemspec index abc1234..def5678 100644 --- a/tltool.gemspec +++ b/tltool.gemspec @@ -8,8 +8,8 @@ spec.version = Tltool::VERSION spec.authors = ["Pinnapong Silpsakulsuk"] spec.email = ["pinnapong@gmail.com"] - spec.summary = %q{TODO: Write a short su...
Add gem summary and description
diff --git a/app/controllers/auth.rb b/app/controllers/auth.rb index abc1234..def5678 100644 --- a/app/controllers/auth.rb +++ b/app/controllers/auth.rb @@ -8,8 +8,8 @@ end post '/signup' do - puts 'create new user' - redirect '/signin' + + redirect '/' end get '/signout' do
Update signup POST route to redirect to homepage
diff --git a/lib/moonshine/memcached.rb b/lib/moonshine/memcached.rb index abc1234..def5678 100644 --- a/lib/moonshine/memcached.rb +++ b/lib/moonshine/memcached.rb @@ -1,14 +1,15 @@ module Moonshine module Memcached - # Define options for this plugin via the <tt>configure</tt> method # in your application...
Fix previous commit. GitHub web interface is not nice for editing.
diff --git a/app/models/notify_user/apn_connection.rb b/app/models/notify_user/apn_connection.rb index abc1234..def5678 100644 --- a/app/models/notify_user/apn_connection.rb +++ b/app/models/notify_user/apn_connection.rb @@ -5,7 +5,7 @@ end def setup - @uri, @certificate = if Rails.env.production? + @uri, ...
Make both the staging and production environments use the production gateway and cert. Temp solution for TN, something gets set in the actual project using `notify_user` dictate which gateway it wants to use per environment.
diff --git a/app/models/sql_probe/event_set_writer.rb b/app/models/sql_probe/event_set_writer.rb index abc1234..def5678 100644 --- a/app/models/sql_probe/event_set_writer.rb +++ b/app/models/sql_probe/event_set_writer.rb @@ -17,17 +17,19 @@ full_path = File.join(output_dir, "#{file_id}.yml") # write cont...
Add MD5 id to Event Set
diff --git a/app/mutations/working_group/base_form.rb b/app/mutations/working_group/base_form.rb index abc1234..def5678 100644 --- a/app/mutations/working_group/base_form.rb +++ b/app/mutations/working_group/base_form.rb @@ -3,9 +3,7 @@ attribute :name, :string attribute :description, :string, required: false - ...
Remove legacy admin edit code from working group edit page
diff --git a/lib/npr_todays_news/cli.rb b/lib/npr_todays_news/cli.rb index abc1234..def5678 100644 --- a/lib/npr_todays_news/cli.rb +++ b/lib/npr_todays_news/cli.rb @@ -30,7 +30,9 @@ def list_stories @news_list.stories.each.with_index(1) do |story, index| - puts "#{index}. #{story.title}" #-- #{story.tea...
Add story teaser to output when listing the featured stories.
diff --git a/lib/restforce/file_part.rb b/lib/restforce/file_part.rb index abc1234..def5678 100644 --- a/lib/restforce/file_part.rb +++ b/lib/restforce/file_part.rb @@ -1,6 +1,11 @@ # frozen_string_literal: true +# rubocop:disable Lint/DuplicateBranch case Faraday::VERSION +when /\A0\.16\./ + # Faraday 0.16.x behav...
Fix compatability with Faraday 0.16.x by setting up multipart support like v1.x
diff --git a/lib/tasks/application.rake b/lib/tasks/application.rake index abc1234..def5678 100644 --- a/lib/tasks/application.rake +++ b/lib/tasks/application.rake @@ -23,7 +23,15 @@ end puts "Loaded #{Electorate.count} electorates" - # TODO: Load people.xml + # people.xml + people_xml = Nokogiri.p...
Load people.xml part of memxml2db.pl
diff --git a/lib/zebra/zpl/printable.rb b/lib/zebra/zpl/printable.rb index abc1234..def5678 100644 --- a/lib/zebra/zpl/printable.rb +++ b/lib/zebra/zpl/printable.rb @@ -16,6 +16,9 @@ def position=(coords) @position, @x, @y = coords, coords[0], coords[1] + if @justification + @x = 0 + ...
Set x position to zero if justification is given
diff --git a/Casks/logic.rb b/Casks/logic.rb index abc1234..def5678 100644 --- a/Casks/logic.rb +++ b/Casks/logic.rb @@ -4,7 +4,7 @@ url "http://downloads.saleae.com/betas/#{version}/Logic-#{version}-Darwin.dmg" name 'Logic' - homepage 'http://www.saleae.com/' + homepage 'https://www.saleae.com/' license :c...
Fix homepage to use SSL in Logic Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/Cosmos.podspec b/Cosmos.podspec index abc1234..def5678 100644 --- a/Cosmos.podspec +++ b/Cosmos.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "Cosmos" - s.version = "8.0.0" + s.version = "8.0.1" s.license = { :type => "MIT" } s.homepage = "https://github.com/marketp...
Add RightToLeft to tvOS target
diff --git a/Formula/p0f.rb b/Formula/p0f.rb index abc1234..def5678 100644 --- a/Formula/p0f.rb +++ b/Formula/p0f.rb @@ -1,24 +1,24 @@-require 'formula' +require "formula" class P0f < Formula - homepage 'http://lcamtuf.coredump.cx/p0f3/' - url 'http://lcamtuf.coredump.cx/p0f3/releases/p0f-3.07b.tgz' - sha1 'ae2c4...
Use double-quotes on all lines
diff --git a/spec/classes/charles_spec.rb b/spec/classes/charles_spec.rb index abc1234..def5678 100644 --- a/spec/classes/charles_spec.rb +++ b/spec/classes/charles_spec.rb @@ -4,6 +4,6 @@ it { should contain_class('charles') } it { should contain_package('Charles').with_provider('appdmg_eula_charles') } - it {...
Update spec for new resource url
diff --git a/scripts/merge-candidates.rb b/scripts/merge-candidates.rb index abc1234..def5678 100644 --- a/scripts/merge-candidates.rb +++ b/scripts/merge-candidates.rb @@ -41,6 +41,7 @@ ") # Delete the loser candidate +DeletedCandidate.create(:old_candidate_id => loser, :candidate_id => winner) Candidate.get(loser...
Create a DeletedCandidate for the merged candidate
diff --git a/lib/qbwc_requests/bill_payment_credit_card/v07/query.rb b/lib/qbwc_requests/bill_payment_credit_card/v07/query.rb index abc1234..def5678 100644 --- a/lib/qbwc_requests/bill_payment_credit_card/v07/query.rb +++ b/lib/qbwc_requests/bill_payment_credit_card/v07/query.rb @@ -2,6 +2,7 @@ module BillPaymentCre...
Add transaction id to bill payment credit card
diff --git a/app/models/api_error.rb b/app/models/api_error.rb index abc1234..def5678 100644 --- a/app/models/api_error.rb +++ b/app/models/api_error.rb @@ -10,9 +10,9 @@ [ { :code => INVALID_ARGUMENT, :description => "Invalid argument", :status_code => 403 }, { :code => INVALID_RANGE, :description => "...
Use 401 for bad authentication, use 403 for lack of permission
diff --git a/Loggie.podspec b/Loggie.podspec index abc1234..def5678 100644 --- a/Loggie.podspec +++ b/Loggie.podspec @@ -7,7 +7,7 @@ s.author = { 'Filip Beć' => 'filip.bec@gmail.com' } s.source = { :git => 'https://github.com/infinum/iOS-Loggie.git', :tag => s.version.to_s } s.social_media_u...
Update Podspec to Swift 4.2
diff --git a/config/software/fluentd.rb b/config/software/fluentd.rb index abc1234..def5678 100644 --- a/config/software/fluentd.rb +++ b/config/software/fluentd.rb @@ -1,5 +1,5 @@ name "fluentd" -default_version 'a3068ff3f73525c72694465a5f42bcae6bf90104' +default_version 'a8ec325bbdf13c2c8cd9839abb566811dab4418c' d...
Update Fluentd to v0.10.49 with latest change
diff --git a/traducto.gemspec b/traducto.gemspec index abc1234..def5678 100644 --- a/traducto.gemspec +++ b/traducto.gemspec @@ -3,7 +3,7 @@ gem.description = "Rails helpers collection to simplify the localization code." gem.summary = "Rails helpers collection to simplify the localization code." gem.homepag...
Fix a bundle install dependencies
diff --git a/lib/generators/jsonapi/serializable/serializable_generator.rb b/lib/generators/jsonapi/serializable/serializable_generator.rb index abc1234..def5678 100644 --- a/lib/generators/jsonapi/serializable/serializable_generator.rb +++ b/lib/generators/jsonapi/serializable/serializable_generator.rb @@ -27,7 +27,7 ...
Fix serializable type for namespaced models
diff --git a/lib/vagrant-ca-certificates/cap/debian/update_certificates.rb b/lib/vagrant-ca-certificates/cap/debian/update_certificates.rb index abc1234..def5678 100644 --- a/lib/vagrant-ca-certificates/cap/debian/update_certificates.rb +++ b/lib/vagrant-ca-certificates/cap/debian/update_certificates.rb @@ -7,10 +7,18 ...
Make debian update certificate action idempotent.
diff --git a/tasks/util.rb b/tasks/util.rb index abc1234..def5678 100644 --- a/tasks/util.rb +++ b/tasks/util.rb @@ -5,7 +5,7 @@ # Project -> [Branch1, Branch2, ...] DOWNSTREAM_EXAMPLES = { - 'react4j-todomvc' => %w(raw raw_maven arez arez_maven spritz dagger dagger_maven raw_maven_j2cl arez_maven_j2cl dagger_ma...
Remove some maven examples that we no longer care about
diff --git a/app/helpers/application_helper/toolbar/ansible_credential_center.rb b/app/helpers/application_helper/toolbar/ansible_credential_center.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper/toolbar/ansible_credential_center.rb +++ b/app/helpers/application_helper/toolbar/ansible_credential_c...
Fix tool tip when tagging Ansible Credential from its summary page
diff --git a/rulers.gemspec b/rulers.gemspec index abc1234..def5678 100644 --- a/rulers.gemspec +++ b/rulers.gemspec @@ -20,10 +20,10 @@ spec.require_paths = ["lib"] spec.add_development_dependency "bundler", "~> 1.5" - spec.add_development_dependency "rake", '~> 0' + spec.add_development_dependency "rake", '~...
Update gemspec to add specific gem version
diff --git a/spec/features/admin_spec.rb b/spec/features/admin_spec.rb index abc1234..def5678 100644 --- a/spec/features/admin_spec.rb +++ b/spec/features/admin_spec.rb @@ -7,7 +7,7 @@ end let(:user) do - FactoryGirl.create(:user, email: 'user@example.com') + FactoryGirl.create(:activated_user, email: 'use...
Add capybara spec for delete links
diff --git a/spec/helper/backend_spec.rb b/spec/helper/backend_spec.rb index abc1234..def5678 100644 --- a/spec/helper/backend_spec.rb +++ b/spec/helper/backend_spec.rb @@ -0,0 +1,11 @@+require 'spec_helper' + +describe 'backend_for(:type) returns correct backend object' do + it 'backend_for(:exec) returns SpecInfra::...
Add spec for backend helper
diff --git a/spec/lib/cadooz/services.rb b/spec/lib/cadooz/services.rb index abc1234..def5678 100644 --- a/spec/lib/cadooz/services.rb +++ b/spec/lib/cadooz/services.rb @@ -2,4 +2,45 @@ describe Cadooz::BusinessOrderService do + describe "instance methods" do + context "create order" do + + end + + contex...
Add contexts for service specs
diff --git a/spec/support/gff3_macros.rb b/spec/support/gff3_macros.rb index abc1234..def5678 100644 --- a/spec/support/gff3_macros.rb +++ b/spec/support/gff3_macros.rb @@ -5,11 +5,12 @@ diffable end - -def attributes_to_hash(gff3) - [:attributes,:end,:feature,:frame,:score,:seqname, - :source,:strand].inject(...
Order of gff3 attribute fields does not matter.
diff --git a/actionpack/lib/action_controller/record_identifier.rb b/actionpack/lib/action_controller/record_identifier.rb index abc1234..def5678 100644 --- a/actionpack/lib/action_controller/record_identifier.rb +++ b/actionpack/lib/action_controller/record_identifier.rb @@ -4,7 +4,7 @@ module RecordIdentifier ...
Fix typo in deprecation warning
diff --git a/spec/birthday_bot_spec.rb b/spec/birthday_bot_spec.rb index abc1234..def5678 100644 --- a/spec/birthday_bot_spec.rb +++ b/spec/birthday_bot_spec.rb @@ -8,8 +8,9 @@ end it "posts tweet" do - expect(bot).to receive(:post_tweet).with("今日はキュアミラクル(Cv. 高橋李依)の誕生日です! https://github.com/sue445...
Use spy instead of mock
diff --git a/spec/classes/init_spec.rb b/spec/classes/init_spec.rb index abc1234..def5678 100644 --- a/spec/classes/init_spec.rb +++ b/spec/classes/init_spec.rb @@ -1,5 +1,9 @@ require 'spec_helper' describe 'goaudit' do + let (:facts) {{ + :osfamily => 'Debian' + }} + context 'with default values for all para...
Set osfamily fact in spec test
diff --git a/SSPPullToRefresh.podspec b/SSPPullToRefresh.podspec index abc1234..def5678 100644 --- a/SSPPullToRefresh.podspec +++ b/SSPPullToRefresh.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'SSPPullToRefresh' - s.version = '0.1.6' + s.version = '0.1.7' s.summary ...
Update pod spec to 0.1.7
diff --git a/app/helpers/forms_helper.rb b/app/helpers/forms_helper.rb index abc1234..def5678 100644 --- a/app/helpers/forms_helper.rb +++ b/app/helpers/forms_helper.rb @@ -3,21 +3,30 @@ def breadcrumbs content_tag(:ol, class: 'breadcrumb') do wizard_steps.collect do |every_step| - class_str = - ...
Fix breadcrumbs to indicate which one we're on
diff --git a/app/models/order_request.rb b/app/models/order_request.rb index abc1234..def5678 100644 --- a/app/models/order_request.rb +++ b/app/models/order_request.rb @@ -4,7 +4,7 @@ belongs_to :external_system attr_accessible :external_copyright_charge, :external_currency, :external_number, :external_servi...
Make order status updateable from admin interface.
diff --git a/app/policies/post_policy.rb b/app/policies/post_policy.rb index abc1234..def5678 100644 --- a/app/policies/post_policy.rb +++ b/app/policies/post_policy.rb @@ -1,10 +1,12 @@ PostPolicy = Struct.new(:user, :post) do def update? + return false unless user user.admin? or post.user == user end ...
Fix bug with nil user.
diff --git a/app/models/user_identity.rb b/app/models/user_identity.rb index abc1234..def5678 100644 --- a/app/models/user_identity.rb +++ b/app/models/user_identity.rb @@ -1,4 +1,5 @@ class UserIdentity < ActiveRecord::Base belongs_to :user validates :provider, uniqueness: { scope: :user_id } + validates :uid, ...
Add validation for uid uniqness [GIOT-29]
diff --git a/app/models/user_location.rb b/app/models/user_location.rb index abc1234..def5678 100644 --- a/app/models/user_location.rb +++ b/app/models/user_location.rb @@ -13,6 +13,8 @@ class UserLocation < ActiveRecord::Base include Locatable + attr_accessible :category_id, :loc_json + belongs_to :user be...
Allow only category_id and loc_json to be set by mass assignment.
diff --git a/lib/banquo/banquo.rb b/lib/banquo/banquo.rb index abc1234..def5678 100644 --- a/lib/banquo/banquo.rb +++ b/lib/banquo/banquo.rb @@ -1,6 +1,6 @@ module Banquo def self.create_user(options) - cmd = `casperjs #{File.dirname(__FILE__)}/script/create-user.js #{BASE_URL} #{options[:email]} #{options[:passw...
Set `--web-security=no` flag when creating a user
diff --git a/core/db/migrate/20101026184808_migrate_checkout_to_orders.rb b/core/db/migrate/20101026184808_migrate_checkout_to_orders.rb index abc1234..def5678 100644 --- a/core/db/migrate/20101026184808_migrate_checkout_to_orders.rb +++ b/core/db/migrate/20101026184808_migrate_checkout_to_orders.rb @@ -1,4 +1,8 @@ cla...
Fix checkout_to_order migration to include Checkout model
diff --git a/lib/attribute_normalizer/normalizers/whitespace_normalizer.rb b/lib/attribute_normalizer/normalizers/whitespace_normalizer.rb index abc1234..def5678 100644 --- a/lib/attribute_normalizer/normalizers/whitespace_normalizer.rb +++ b/lib/attribute_normalizer/normalizers/whitespace_normalizer.rb @@ -2,7 +2,7 @@...
Remove whitespaces adjacent to newline. Actually pass all tests
diff --git a/files/opt/nanobox/hooks/lib/stderr.rb b/files/opt/nanobox/hooks/lib/stderr.rb index abc1234..def5678 100644 --- a/files/opt/nanobox/hooks/lib/stderr.rb +++ b/files/opt/nanobox/hooks/lib/stderr.rb @@ -2,7 +2,8 @@ class Stderr def initialize(opts) - @log_level = level_to_int(opts[:log_level]) +...
Set info log level when none is provided
diff --git a/db/migrate/20121113120000_create_honorific_prefixes_table.rb b/db/migrate/20121113120000_create_honorific_prefixes_table.rb index abc1234..def5678 100644 --- a/db/migrate/20121113120000_create_honorific_prefixes_table.rb +++ b/db/migrate/20121113120000_create_honorific_prefixes_table.rb @@ -1,6 +1,6 @@ cla...
Create not alter table honorific_prefixes in the so called migration.
diff --git a/ydf.gemspec b/ydf.gemspec index abc1234..def5678 100644 --- a/ydf.gemspec +++ b/ydf.gemspec @@ -19,7 +19,7 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~> 1.12" - spec.add_development_dependen...
Remove versions of dependent gems in development
diff --git a/lib/ohm/datatypes.rb b/lib/ohm/datatypes.rb index abc1234..def5678 100644 --- a/lib/ohm/datatypes.rb +++ b/lib/ohm/datatypes.rb @@ -7,7 +7,7 @@ module DataTypes module Type Integer = lambda { |x| x.to_i } - Decimal = lambda { |x| x && BigDecimal(x.to_s) } + Decimal = lambda { ...
Fix behavior of Decimal to return 0 for nil / empty string (via @soveran).
diff --git a/lib/pogoplug/file.rb b/lib/pogoplug/file.rb index abc1234..def5678 100644 --- a/lib/pogoplug/file.rb +++ b/lib/pogoplug/file.rb @@ -46,6 +46,7 @@ parent_id: json['parentid'], size: json['size'].to_i, origin: json['origin'], + properties: json['properties'] || {}, r...
Include properties when parsing as well
diff --git a/test/system/fluentd/setting/filter_record_transformer_test.rb b/test/system/fluentd/setting/filter_record_transformer_test.rb index abc1234..def5678 100644 --- a/test/system/fluentd/setting/filter_record_transformer_test.rb +++ b/test/system/fluentd/setting/filter_record_transformer_test.rb @@ -0,0 +1,30 @...
Add system test for filter_record_transformer Signed-off-by: Kenji Okimoto <7a4b90a0a1e6fc688adec907898b6822ce215e6c@clear-code.com>
diff --git a/attributes/server_apache.rb b/attributes/server_apache.rb index abc1234..def5678 100644 --- a/attributes/server_apache.rb +++ b/attributes/server_apache.rb @@ -1,6 +1,6 @@ default['icinga2']['apache_modules'] = value_for_platform( - %w(centos redhat fedora) => { '>= 7' => %w(default mod_wsgi mod_php5 mo...
Fix version contraint for centos 7 apache modules
diff --git a/uidable.gemspec b/uidable.gemspec index abc1234..def5678 100644 --- a/uidable.gemspec +++ b/uidable.gemspec @@ -23,6 +23,6 @@ spec.require_paths = ["lib"] spec.required_ruby_version = '>= 2.1.0' - spec.add_development_dependency "bundler", "~> 1.9" - spec.add_development_dependency "rake", "~> 10....
Update bundler and rake version
diff --git a/Casks/sidekick.rb b/Casks/sidekick.rb index abc1234..def5678 100644 --- a/Casks/sidekick.rb +++ b/Casks/sidekick.rb @@ -2,7 +2,7 @@ version :latest sha256 :no_check - url 'http://oomphalot.com/sidekick/release/Sidekick.zip' + url 'http://releases.oomphalot.com.s3-website-us-east-1.amazonaws.com/Si...
Update the URL for fetching Sidekick since they moved to Amazon S3
diff --git a/spec/henson/source/github_spec.rb b/spec/henson/source/github_spec.rb index abc1234..def5678 100644 --- a/spec/henson/source/github_spec.rb +++ b/spec/henson/source/github_spec.rb @@ -34,7 +34,7 @@ it.expects(:version).returns("1.1.2").at_least(3) ui.expects(:debug). - with("Downloadi...
Fix yet another hardcoded spec
diff --git a/spec/support/controller_macros.rb b/spec/support/controller_macros.rb index abc1234..def5678 100644 --- a/spec/support/controller_macros.rb +++ b/spec/support/controller_macros.rb @@ -0,0 +1,17 @@+module ControllerMacros + def login_admin + before(:each) do + @request.env["devise.mapping"] = Devis...
Add macros for devise spec testing
diff --git a/spec/support/test_classes/book.rb b/spec/support/test_classes/book.rb index abc1234..def5678 100644 --- a/spec/support/test_classes/book.rb +++ b/spec/support/test_classes/book.rb @@ -1,6 +1,6 @@ class Book attr_accessor :title, :authors - def initialize title="Foo Bar", authors=[] + def initialize ti...
Make default test class data index-friendly
diff --git a/lib/conjure/provision/docker_image.rb b/lib/conjure/provision/docker_image.rb index abc1234..def5678 100644 --- a/lib/conjure/provision/docker_image.rb +++ b/lib/conjure/provision/docker_image.rb @@ -3,14 +3,15 @@ class DockerImage attr_reader :image_name - def initialize(base_image_name)...
Support remote server operation in Provision::DockerImage
diff --git a/test/helpers/git_helper.rb b/test/helpers/git_helper.rb index abc1234..def5678 100644 --- a/test/helpers/git_helper.rb +++ b/test/helpers/git_helper.rb @@ -2,22 +2,23 @@ module GitHelper module_function - def git_commit_am(message) - index = @repo.index + def git_commit(index, message...
Split `git_commit_am` and create `git_commit`
diff --git a/spec/views/medicaid/contact_social_security/edit.html.erb_spec.rb b/spec/views/medicaid/contact_social_security/edit.html.erb_spec.rb index abc1234..def5678 100644 --- a/spec/views/medicaid/contact_social_security/edit.html.erb_spec.rb +++ b/spec/views/medicaid/contact_social_security/edit.html.erb_spec.rb...
Add spec to ensure error messages are showing
diff --git a/db/migrate/20200417183101_add_missing_reference_number_on_entries.rb b/db/migrate/20200417183101_add_missing_reference_number_on_entries.rb index abc1234..def5678 100644 --- a/db/migrate/20200417183101_add_missing_reference_number_on_entries.rb +++ b/db/migrate/20200417183101_add_missing_reference_number_o...
Add migration to set sale/purchase reference_number on entry if nil.
diff --git a/libraries/helpers.rb b/libraries/helpers.rb index abc1234..def5678 100644 --- a/libraries/helpers.rb +++ b/libraries/helpers.rb @@ -1,16 +1,39 @@ module VarnishCookbook # Helper methods to be used in multiple Varnish cookbook libraries. module Helpers + def self.installed_major_version # Has issue...
Add back shell out version detection
diff --git a/config/initializers/fast_gettext.rb b/config/initializers/fast_gettext.rb index abc1234..def5678 100644 --- a/config/initializers/fast_gettext.rb +++ b/config/initializers/fast_gettext.rb @@ -1,2 +1,2 @@-FastGettext.add_text_domain 'app', :path => 'locale', :type => :po, :ignore_fuzzy => true, :ignore_obso...
Put back the gettext fuzzy/obsolete warnings Be careful: turns out that the :ignore_fuzzy flag changes the behaviour of gettext. The warnings dont show up, but the fuzzy strings get used, and theyre most often wrong!
diff --git a/cookbooks/wt_streaminglogreplayer/recipes/undeploy.rb b/cookbooks/wt_streaminglogreplayer/recipes/undeploy.rb index abc1234..def5678 100644 --- a/cookbooks/wt_streaminglogreplayer/recipes/undeploy.rb +++ b/cookbooks/wt_streaminglogreplayer/recipes/undeploy.rb @@ -11,9 +11,9 @@ install_dir = "#{node['wt_co...
Fix uninstall script formatting in log replayer
diff --git a/app/controllers/search_results_controller.rb b/app/controllers/search_results_controller.rb index abc1234..def5678 100644 --- a/app/controllers/search_results_controller.rb +++ b/app/controllers/search_results_controller.rb @@ -2,14 +2,14 @@ decorates_assigned :search_results, with: SearchResultCollectio...
Use a guard clause instead of wrapping the code inside a conditional expression
diff --git a/lib/keychain.rb b/lib/keychain.rb index abc1234..def5678 100644 --- a/lib/keychain.rb +++ b/lib/keychain.rb @@ -22,7 +22,7 @@ # @note This method asks only for the metadata to be returned and thus # does not need user authorization to get results. # Returns true if there are any item matching the ...
Fix a documentation typo and add missing documentation
diff --git a/app/models/renalware/letters/rtf_renderer.rb b/app/models/renalware/letters/rtf_renderer.rb index abc1234..def5678 100644 --- a/app/models/renalware/letters/rtf_renderer.rb +++ b/app/models/renalware/letters/rtf_renderer.rb @@ -35,10 +35,12 @@ temp_html_file.unlink # allows garbage collection and t...
Use Windows CRLF line endings when rendering RTF letters Previously we were using the native default == Linux == LF in Pandoc which was causing problems at Batrs with the RTFs they send to GPs.
diff --git a/lib/data_mapper/finalizer/dependent_relationship_set.rb b/lib/data_mapper/finalizer/dependent_relationship_set.rb index abc1234..def5678 100644 --- a/lib/data_mapper/finalizer/dependent_relationship_set.rb +++ b/lib/data_mapper/finalizer/dependent_relationship_set.rb @@ -23,6 +23,8 @@ # Iterate over ...
Add missing @return yard tag
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -30,5 +30,6 @@ caller[0] =~ /`([^']*)'/ and where = $1 logger.error "[#{where}] #{e...
Add manual exception notification in log_error
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -4,6 +4,6 @@ protected def admin? - BasicAuth.admin?(request) + BasicAuth.logge...
Fix usage of BasicAuth.logged_in? method
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -5,7 +5,18 @@ protected - def not_found - render json: { errors: 'Not found' }, st...
Use json-api adapter for error render
diff --git a/app/helpers/channels_helper.rb b/app/helpers/channels_helper.rb index abc1234..def5678 100644 --- a/app/helpers/channels_helper.rb +++ b/app/helpers/channels_helper.rb @@ -1,11 +1,11 @@ module ChannelsHelper def format_body(post) - text = simple_format(post.body) + text = simple_format(post.bo...
Disable sanitizing for post bodies
diff --git a/china_region_fu.gemspec b/china_region_fu.gemspec index abc1234..def5678 100644 --- a/china_region_fu.gemspec +++ b/china_region_fu.gemspec @@ -14,4 +14,6 @@ gem.name = "china_region_fu" gem.require_paths = ["lib"] gem.version = ChinaRegionFu::VERSION + + gem.add_dependency 'jquer...
Add dependency 'jquery-rails' for Jquery
diff --git a/app/helpers/sessions_helper.rb b/app/helpers/sessions_helper.rb index abc1234..def5678 100644 --- a/app/helpers/sessions_helper.rb +++ b/app/helpers/sessions_helper.rb @@ -1,9 +1,11 @@ module SessionsHelper + # Logs in the given user. def log_in(user) session[:user_id] = user.id end + # Re...
Add comments within the SessionsHelper to explain the methods there